X-Loop: help-debbugs@HIDDEN Subject: bug#10899: 24.0.93; c-forward-conditional should not move the mark Resent-From: Dani Moncayo <dmoncayo@HIDDEN> Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Mon, 27 Feb 2012 19:10:02 +0000 Resent-Message-ID: <handler.10899.B.133036974922502 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 10899 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 10899 <at> debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN Received: via spool by submit <at> debbugs.gnu.org id=B.133036974922502 (code B ref -1); Mon, 27 Feb 2012 19:10:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Feb 2012 19:09:09 +0000 Received: from localhost ([127.0.0.1]:60126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1S25wb-0005qt-91 for submit <at> debbugs.gnu.org; Mon, 27 Feb 2012 14:09:09 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48339) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <dmoncayo@HIDDEN>) id 1S25wY-0005qm-QE for submit <at> debbugs.gnu.org; Mon, 27 Feb 2012 14:09:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <dmoncayo@HIDDEN>) id 1S25tl-0006E5-CA for submit <at> debbugs.gnu.org; Mon, 27 Feb 2012 14:06:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:45828) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <dmoncayo@HIDDEN>) id 1S25tl-0006E1-87 for submit <at> debbugs.gnu.org; Mon, 27 Feb 2012 14:06:13 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39470) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <dmoncayo@HIDDEN>) id 1S25tk-0005Gb-7p for bug-gnu-emacs@HIDDEN; Mon, 27 Feb 2012 14:06:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <dmoncayo@HIDDEN>) id 1S25tg-0006Dg-7H for bug-gnu-emacs@HIDDEN; Mon, 27 Feb 2012 14:06:12 -0500 Received: from mail-tul01m020-f169.google.com ([209.85.214.169]:40708) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <dmoncayo@HIDDEN>) id 1S25tg-0006Db-1p for bug-gnu-emacs@HIDDEN; Mon, 27 Feb 2012 14:06:08 -0500 Received: by obbta7 with SMTP id ta7so6905973obb.0 for <bug-gnu-emacs@HIDDEN>; Mon, 27 Feb 2012 11:06:06 -0800 (PST) Received-SPF: pass (google.com: domain of dmoncayo@HIDDEN designates 10.60.5.231 as permitted sender) client-ip=10.60.5.231; Authentication-Results: mr.google.com; spf=pass (google.com: domain of dmoncayo@HIDDEN designates 10.60.5.231 as permitted sender) smtp.mail=dmoncayo@HIDDEN; dkim=pass header.i=dmoncayo@HIDDEN Received: from mr.google.com ([10.60.5.231]) by 10.60.5.231 with SMTP id v7mr2736037oev.50.1330369566817 (num_hops = 1); Mon, 27 Feb 2012 11:06:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; bh=QUOa3hgbzi5RN6DixWz46zlnMF7ByO1s1L/ERnlPHVw=; b=i598Zimy5KWZL9skzPXXBN4OrjMIc6Lbkq6WcR+fMjuohN65cZkvPrGCzeOdspAY88 8RuHBy01DitNVRvvFYGNYQAr19ncfeNi96GPR0w3mbxAImAmSM3RMmEbY9hgNFb2044H DEBu1IZN+P/5lK2tfribPUBY8SSGKCtucqshE= MIME-Version: 1.0 Received: by 10.60.5.231 with SMTP id v7mr2415597oev.50.1330369566749; Mon, 27 Feb 2012 11:06:06 -0800 (PST) Received: by 10.60.42.193 with HTTP; Mon, 27 Feb 2012 11:06:06 -0800 (PST) Date: Mon, 27 Feb 2012 20:06:06 +0100 Message-ID: <CAH8Pv0hLmrfnHR-8J9ACV+SDAED6GL_tzJJ+D1FOHTpitWh0ZQ@HIDDEN> From: Dani Moncayo <dmoncayo@HIDDEN> Content-Type: multipart/mixed; boundary=e89a8ff2535072355c04b9f6cde2 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Recipe from "emacs -Q": 1. Visit the attached file. 2. Type: C-SPC C-c C-n C-c C-n --> Expected result: the region covers the two "#ifdef" preprocessor conditionals. --> Observed result: it covers only the second one, because the mark has moved when I typed the second "C-c C-n". [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.7 RCVD_IN_PSBL RBL: Received via a relay in PSBL [208.118.235.92 listed in psbl.surriel.com] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dmoncayo[at]gmail.com) 0.8 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Sender: debbugs-submit-bounces <at> debbugs.gnu.org Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Recipe from "emacs -Q": 1. Visit the attached file. 2. Type: C-SPC C-c C-n C-c C-n --> Expected result: the region covers the two "#ifdef" preprocessor conditionals. --> Observed result: it covers only the second one, because the mark has moved when I typed the second "C-c C-n". [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.7 RCVD_IN_PSBL RBL: Received via a relay in PSBL [208.118.235.92 listed in psbl.surriel.com] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dmoncayo[at]gmail.com) 0.8 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid --e89a8ff2535072355c04b9f6cde2 Content-Type: text/plain; charset=ISO-8859-1 Recipe from "emacs -Q": 1. Visit the attached file. 2. Type: C-SPC C-c C-n C-c C-n --> Expected result: the region covers the two "#ifdef" preprocessor conditionals. --> Observed result: it covers only the second one, because the mark has moved when I typed the second "C-c C-n". In GNU Emacs 24.0.93.1 (i386-mingw-nt6.1.7601) of 2012-02-14 on DANI-PC Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --with-gcc (4.6)' -- Dani Moncayo --e89a8ff2535072355c04b9f6cde2 Content-Type: text/x-csrc; charset=US-ASCII; name="test.c" Content-Disposition: attachment; filename="test.c" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gz5vm6qn0 DQojaWZkZWYgQUENCkFBX0NPREU7DQojZW5kaWYNCg0KI2lmZGVmIEJCDQpCQl9DT0RFOw0KI2Vu ZGlmDQo= --e89a8ff2535072355c04b9f6cde2--
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Dani Moncayo <dmoncayo@HIDDEN> Subject: bug#10899: Acknowledgement (24.0.93; c-forward-conditional should not move the mark) Message-ID: <handler.10899.B.133036974922502.ack <at> debbugs.gnu.org> References: <CAH8Pv0hLmrfnHR-8J9ACV+SDAED6GL_tzJJ+D1FOHTpitWh0ZQ@HIDDEN> X-Gnu-PR-Message: ack 10899 X-Gnu-PR-Package: emacs Reply-To: 10899 <at> debbugs.gnu.org Date: Mon, 27 Feb 2012 19:10:04 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 10899 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 10899: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D10899 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN Subject: bug#10899: 24.0.93; c-forward-conditional should not move the mark Resent-From: Dani Moncayo <dmoncayo@HIDDEN> Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org Resent-CC: bug-gnu-emacs@HIDDEN, bug-cc-mode@HIDDEN Resent-Date: Mon, 27 Feb 2012 19:33:02 +0000 Resent-Message-ID: <handler.10899.B10899.133037117024758 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 10899 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: To: 10899 <at> debbugs.gnu.org Received: via spool by 10899-submit <at> debbugs.gnu.org id=B10899.133037117024758 (code B ref 10899); Mon, 27 Feb 2012 19:33:02 +0000 Received: (at 10899) by debbugs.gnu.org; 27 Feb 2012 19:32:50 +0000 Received: from localhost ([127.0.0.1]:60163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1S26JV-0006RH-Hb for submit <at> debbugs.gnu.org; Mon, 27 Feb 2012 14:32:49 -0500 Received: from mail-tul01m020-f172.google.com ([209.85.214.172]:49449) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <dmoncayo@HIDDEN>) id 1S26JU-0006RA-7S for 10899 <at> debbugs.gnu.org; Mon, 27 Feb 2012 14:32:48 -0500 Received: by obbeh20 with SMTP id eh20so1556415obb.3 for <10899 <at> debbugs.gnu.org>; Mon, 27 Feb 2012 11:29:55 -0800 (PST) Received-SPF: pass (google.com: domain of dmoncayo@HIDDEN designates 10.60.12.8 as permitted sender) client-ip=10.60.12.8; Authentication-Results: mr.google.com; spf=pass (google.com: domain of dmoncayo@HIDDEN designates 10.60.12.8 as permitted sender) smtp.mail=dmoncayo@HIDDEN; dkim=pass header.i=dmoncayo@HIDDEN Received: from mr.google.com ([10.60.12.8]) by 10.60.12.8 with SMTP id u8mr6179879oeb.60.1330370995134 (num_hops = 1); Mon, 27 Feb 2012 11:29:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=Fc4wklDWar4ktwghIhR0BLg6NdRrLxObb5ADu0GAFYE=; b=fkEwy5O39xEGK258vunRe3ZhxyczCsA65lb7ijsh9/oJMt5wCE2tRMUf65Un9LCUJa yYhUDmefLq2w4XD/FwkPydPcdnL0r3BAWgkHuKHqLtSwMn/U1EnMTwZ9Oj314v59vAz2 +QkGPY4gtHG9e3KiL209Khdz5R9YtLcf5HJOw= MIME-Version: 1.0 Received: by 10.60.12.8 with SMTP id u8mr5458032oeb.60.1330370995066; Mon, 27 Feb 2012 11:29:55 -0800 (PST) Received: by 10.60.42.193 with HTTP; Mon, 27 Feb 2012 11:29:55 -0800 (PST) In-Reply-To: <CAH8Pv0hLmrfnHR-8J9ACV+SDAED6GL_tzJJ+D1FOHTpitWh0ZQ@HIDDEN> References: <CAH8Pv0hLmrfnHR-8J9ACV+SDAED6GL_tzJJ+D1FOHTpitWh0ZQ@HIDDEN> Date: Mon, 27 Feb 2012 20:29:55 +0100 Message-ID: <CAH8Pv0g7WdpONkkt-gTz6UixK0vp__BrR+gMfu9U98mD90j8Vg@HIDDEN> From: Dani Moncayo <dmoncayo@HIDDEN> Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Sender: debbugs-submit-bounces <at> debbugs.gnu.org Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org X-Spam-Score: -2.6 (--) > Recipe from "emacs -Q": > 1. Visit the attached file. > 2. Type: C-SPC C-c C-n C-c C-n > > --> Expected result: the region covers the two "#ifdef" preprocessor > conditionals. > --> Observed result: it covers only the second one, because the mark > has moved when I typed the second "C-c C-n". I didn't read the docstring of the function, which says: Move forward across a preprocessor conditional, leaving mark behind. A prefix argument acts as a repeat count. With a negative argument, move backward across a preprocessor conditional. What does "leaving mark behind" mean exactly here? It seem to mean "setting the mark at point, and then moving the point". At least it is the behavior I observe. But this behavior is undesirable (IMO - this is a movement command. whats the point of setting the mark here?), and inconsistent with analogous movement commands such as `forward-list'. -- Dani Moncayo
X-Loop: help-debbugs@HIDDEN Subject: bug#10899: 24.0.93; c-forward-conditional should not move the mark Resent-From: Eli Zaretskii <eliz@HIDDEN> Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org Resent-CC: bug-gnu-emacs@HIDDEN, bug-cc-mode@HIDDEN Resent-Date: Mon, 27 Feb 2012 20:31:02 +0000 Resent-Message-ID: <handler.10899.B10899.1330374616650 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 10899 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: To: Dani Moncayo <dmoncayo@HIDDEN> Cc: 10899 <at> debbugs.gnu.org Reply-To: Eli Zaretskii <eliz@HIDDEN> Received: via spool by 10899-submit <at> debbugs.gnu.org id=B10899.1330374616650 (code B ref 10899); Mon, 27 Feb 2012 20:31:02 +0000 Received: (at 10899) by debbugs.gnu.org; 27 Feb 2012 20:30:16 +0000 Received: from localhost ([127.0.0.1]:60221 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1S27D6-0000AR-ET for submit <at> debbugs.gnu.org; Mon, 27 Feb 2012 15:30:16 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:50915) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <eliz@HIDDEN>) id 1S27D4-0000AH-D9 for 10899 <at> debbugs.gnu.org; Mon, 27 Feb 2012 15:30:15 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0M0200600JGTBX00@HIDDEN> for 10899 <at> debbugs.gnu.org; Mon, 27 Feb 2012 22:26:54 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.119.92]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M020045UJGTAB51@HIDDEN>; Mon, 27 Feb 2012 22:26:54 +0200 (IST) Date: Mon, 27 Feb 2012 22:28:58 +0200 From: Eli Zaretskii <eliz@HIDDEN> In-reply-to: <CAH8Pv0g7WdpONkkt-gTz6UixK0vp__BrR+gMfu9U98mD90j8Vg@HIDDEN> X-012-Sender: halo1@HIDDEN Message-id: <83haycdnqt.fsf@HIDDEN> References: <CAH8Pv0hLmrfnHR-8J9ACV+SDAED6GL_tzJJ+D1FOHTpitWh0ZQ@HIDDEN> <CAH8Pv0g7WdpONkkt-gTz6UixK0vp__BrR+gMfu9U98mD90j8Vg@HIDDEN> X-Spam-Score: -1.2 (-) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Sender: debbugs-submit-bounces <at> debbugs.gnu.org Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org X-Spam-Score: -1.2 (-) > Date: Mon, 27 Feb 2012 20:29:55 +0100 > From: Dani Moncayo <dmoncayo@HIDDEN> > > What does "leaving mark behind" mean exactly here? It seem to mean > "setting the mark at point, and then moving the point". At least it > is the behavior I observe. What else could it possibly mean? > But this behavior is undesirable (IMO - this is a movement command. > whats the point of setting the mark here?) A conditional could, and frequently does, enclose a large portion of the code. Leaving the mark where you were lets you get back there with "C-x C-x", obviously, which is a convenience. In general, Emacs commands that could potentially move a long way leave the mark behind. > and inconsistent with analogous movement commands such as > `forward-list'. There's no need for consistency in all movement commands. In particular, those that generally move short distances need not behave the same as the other kind. And you have "C-u C-c C-n" to do what you want.
X-Loop: help-debbugs@HIDDEN Subject: bug#10899: 24.0.93; c-forward-conditional should not move the mark Resent-From: Dani Moncayo <dmoncayo@HIDDEN> Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org Resent-CC: bug-gnu-emacs@HIDDEN, bug-cc-mode@HIDDEN Resent-Date: Mon, 27 Feb 2012 21:04:02 +0000 Resent-Message-ID: <handler.10899.B10899.13303765973509 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 10899 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: To: Eli Zaretskii <eliz@HIDDEN> Cc: 10899 <at> debbugs.gnu.org Received: via spool by 10899-submit <at> debbugs.gnu.org id=B10899.13303765973509 (code B ref 10899); Mon, 27 Feb 2012 21:04:02 +0000 Received: (at 10899) by debbugs.gnu.org; 27 Feb 2012 21:03:17 +0000 Received: from localhost ([127.0.0.1]:60237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1S27ix-0000u9-Hx for submit <at> debbugs.gnu.org; Mon, 27 Feb 2012 16:03:17 -0500 Received: from mail-tul01m020-f172.google.com ([209.85.214.172]:44279) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <dmoncayo@HIDDEN>) id 1S27ig-0000tY-A6 for 10899 <at> debbugs.gnu.org; Mon, 27 Feb 2012 16:03:00 -0500 Received: by obbeh20 with SMTP id eh20so1646403obb.3 for <10899 <at> debbugs.gnu.org>; Mon, 27 Feb 2012 12:59:45 -0800 (PST) Received-SPF: pass (google.com: domain of dmoncayo@HIDDEN designates 10.182.149.71 as permitted sender) client-ip=10.182.149.71; Authentication-Results: mr.google.com; spf=pass (google.com: domain of dmoncayo@HIDDEN designates 10.182.149.71 as permitted sender) smtp.mail=dmoncayo@HIDDEN; dkim=pass header.i=dmoncayo@HIDDEN Received: from mr.google.com ([10.182.149.71]) by 10.182.149.71 with SMTP id ty7mr5604601obb.70.1330376385934 (num_hops = 1); Mon, 27 Feb 2012 12:59:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=UQSvxR4pzRunHhgG2M4B7/MQuZBLeBehhDNe6ZoC6DY=; b=jLZaf4Lbc0k6NJxpdoERF7YbILndMgB5qxgapcdZiawcePoN5WruOPL4Y9k26YMURG 41sWdqZ+25g8AQKeJRwqcFTP74hha8eE45e4TNac5I4YERMc8ebJdj40MqobPk3WY9h8 +oQZmwkcaO0TLJFgVbdyRoBapRo1yOffKKNUU= MIME-Version: 1.0 Received: by 10.182.149.71 with SMTP id ty7mr4990373obb.70.1330376385881; Mon, 27 Feb 2012 12:59:45 -0800 (PST) Received: by 10.60.42.193 with HTTP; Mon, 27 Feb 2012 12:59:45 -0800 (PST) In-Reply-To: <83haycdnqt.fsf@HIDDEN> References: <CAH8Pv0hLmrfnHR-8J9ACV+SDAED6GL_tzJJ+D1FOHTpitWh0ZQ@HIDDEN> <CAH8Pv0g7WdpONkkt-gTz6UixK0vp__BrR+gMfu9U98mD90j8Vg@HIDDEN> <83haycdnqt.fsf@HIDDEN> Date: Mon, 27 Feb 2012 21:59:45 +0100 Message-ID: <CAH8Pv0jA22K9TmKBiFEc+BguFmpOXqbkUf+QcQKp7dwhB+DUmg@HIDDEN> From: Dani Moncayo <dmoncayo@HIDDEN> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Sender: debbugs-submit-bounces <at> debbugs.gnu.org Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org X-Spam-Score: -2.6 (--) >> What does "leaving mark behind" mean exactly here? =A0It seem to mean >> "setting the mark at point, and then moving the point". =A0At least it >> is the behavior I observe. > > What else could it possibly mean? I don't know, but "to leave X behind" does not imply to move "X" from its original position. So this wording seems confusing to me. >> But this behavior is undesirable (IMO - this is a movement command. >> whats the point of setting the mark here?) > > A conditional could, and frequently does, enclose a large portion of > the code. =A0Leaving the mark where you were lets you get back there > with "C-x C-x", obviously, which is a convenience. =A0In general, Emacs > commands that could potentially move a long way leave the mark behind. > >> and inconsistent with analogous movement commands such as >> `forward-list'. > > There's no need for consistency in all movement commands. =A0In > particular, those that generally move short distances need not behave > the same as the other kind. > Consistency is a good design principle to follow, unless there is good reason not to. And frankly, I don't see a good reason here. > And you have "C-u C-c C-n" to do what you want. And if "C-c C-n" didn't set the mark, you would have "C-SPC C-c C-n" to do what you want. --=20 Dani Moncayo
X-Loop: help-debbugs@HIDDEN Subject: bug#10899: 24.0.93; c-forward-conditional should not move the mark Resent-From: Dani Moncayo <dmoncayo@HIDDEN> Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org Resent-CC: bug-gnu-emacs@HIDDEN, bug-cc-mode@HIDDEN Resent-Date: Tue, 28 Feb 2012 07:47:02 +0000 Resent-Message-ID: <handler.10899.B10899.133041518129888 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 10899 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: To: Eli Zaretskii <eliz@HIDDEN> Cc: 10899 <at> debbugs.gnu.org Received: via spool by 10899-submit <at> debbugs.gnu.org id=B10899.133041518129888 (code B ref 10899); Tue, 28 Feb 2012 07:47:02 +0000 Received: (at 10899) by debbugs.gnu.org; 28 Feb 2012 07:46:21 +0000 Received: from localhost ([127.0.0.1]:60667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1S2HlH-0007lk-1Y for submit <at> debbugs.gnu.org; Tue, 28 Feb 2012 02:46:20 -0500 Received: from mail-tul01m020-f172.google.com ([209.85.214.172]:48502) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <dmoncayo@HIDDEN>) id 1S2Hkw-0007ks-LO for 10899 <at> debbugs.gnu.org; Tue, 28 Feb 2012 02:46:00 -0500 Received: by obbeh20 with SMTP id eh20so2145550obb.3 for <10899 <at> debbugs.gnu.org>; Mon, 27 Feb 2012 23:42:43 -0800 (PST) Received-SPF: pass (google.com: domain of dmoncayo@HIDDEN designates 10.182.149.71 as permitted sender) client-ip=10.182.149.71; Authentication-Results: mr.google.com; spf=pass (google.com: domain of dmoncayo@HIDDEN designates 10.182.149.71 as permitted sender) smtp.mail=dmoncayo@HIDDEN; dkim=pass header.i=dmoncayo@HIDDEN Received: from mr.google.com ([10.182.149.71]) by 10.182.149.71 with SMTP id ty7mr6294331obb.70.1330414963270 (num_hops = 1); Mon, 27 Feb 2012 23:42:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=6hK6uch1AAPm7aCVlGvDRMGYkeglxk++4xgGaCCstow=; b=u4OmeqSFqssjzHfz+vtYPjsEhj25PSEyu0mE0x2tOrpv6vZpeTzvQilkOQqWXkBvyr NpXUGMo+NXBf39f/OGBwfq4TZxQqUO6tL+dkFBOyqKuYI4vPW+iHE/d2+DIbij5BYVF9 yBHuSJuQCwdBC7h+hlZois0L2/7U/d/3g24Zo= MIME-Version: 1.0 Received: by 10.182.149.71 with SMTP id ty7mr5601503obb.70.1330414963195; Mon, 27 Feb 2012 23:42:43 -0800 (PST) Received: by 10.60.42.193 with HTTP; Mon, 27 Feb 2012 23:42:43 -0800 (PST) In-Reply-To: <CAH8Pv0jA22K9TmKBiFEc+BguFmpOXqbkUf+QcQKp7dwhB+DUmg@HIDDEN> References: <CAH8Pv0hLmrfnHR-8J9ACV+SDAED6GL_tzJJ+D1FOHTpitWh0ZQ@HIDDEN> <CAH8Pv0g7WdpONkkt-gTz6UixK0vp__BrR+gMfu9U98mD90j8Vg@HIDDEN> <83haycdnqt.fsf@HIDDEN> <CAH8Pv0jA22K9TmKBiFEc+BguFmpOXqbkUf+QcQKp7dwhB+DUmg@HIDDEN> Date: Tue, 28 Feb 2012 08:42:43 +0100 Message-ID: <CAH8Pv0hF+yd5ui3gmFfBAtyT3i0kB=q3Vz=59-fdtder_jZN1A@HIDDEN> From: Dani Moncayo <dmoncayo@HIDDEN> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Sender: debbugs-submit-bounces <at> debbugs.gnu.org Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org X-Spam-Score: -2.6 (--) > Consistency is a good design principle to follow, unless there is good > reason not to. =A0And frankly, I don't see a good reason here. ...and I'll explain why: Well-known movement commands like `M-<', `M->' or the search commands set the mark (IMO) because they meet two criteria: 1. They may move point to a distant location. 2. There is not an "inverse" command to move point back to the original position (or near it): commands like `forward-list' or `forward-page' meet criterion #1, but they don't set the mark because you have `backward-list' and `backward-page' to move to the original position. And when command meet these two criteria, it should set the mark, but only if it is inactive, because when the mark is active, the user surely wants to extend the _current_ region, i.e., "leave the mark alone where I've set it, and just move the point". IMO, this is the behavior users expect, and are used to. Summarizing: a. `c-forward-conditional' and `c-backward-conditional' should not set the mark, because each one has an inverse movement command. b. Even if you disagree, those commands should not set the mark when it is active. --=20 Dani Moncayo
X-Loop: help-debbugs@HIDDEN Subject: bug#10899: 24.0.93; c-forward-conditional should not move the mark Resent-From: Juri Linkov <juri@HIDDEN> Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org Resent-CC: bug-gnu-emacs@HIDDEN, bug-cc-mode@HIDDEN Resent-Date: Tue, 28 Feb 2012 10:50:02 +0000 Resent-Message-ID: <handler.10899.B10899.133042618513487 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 10899 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: To: Dani Moncayo <dmoncayo@HIDDEN> Cc: 10899 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN> Received: via spool by 10899-submit <at> debbugs.gnu.org id=B10899.133042618513487 (code B ref 10899); Tue, 28 Feb 2012 10:50:02 +0000 Received: (at 10899) by debbugs.gnu.org; 28 Feb 2012 10:49:45 +0000 Received: from localhost ([127.0.0.1]:60800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1S2Kcq-0003VH-Vy for submit <at> debbugs.gnu.org; Tue, 28 Feb 2012 05:49:45 -0500 Received: from ps18281.dreamhost.com ([69.163.218.105]:44740 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <juri@HIDDEN>) id 1S2KcV-0003Uh-Kg for 10899 <at> debbugs.gnu.org; Tue, 28 Feb 2012 05:49:33 -0500 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 88A6C451C1C9; Tue, 28 Feb 2012 02:44:30 -0800 (PST) From: Juri Linkov <juri@HIDDEN> Organization: JURTA References: <CAH8Pv0hLmrfnHR-8J9ACV+SDAED6GL_tzJJ+D1FOHTpitWh0ZQ@HIDDEN> <CAH8Pv0g7WdpONkkt-gTz6UixK0vp__BrR+gMfu9U98mD90j8Vg@HIDDEN> <83haycdnqt.fsf@HIDDEN> <CAH8Pv0jA22K9TmKBiFEc+BguFmpOXqbkUf+QcQKp7dwhB+DUmg@HIDDEN> <CAH8Pv0hF+yd5ui3gmFfBAtyT3i0kB=q3Vz=59-fdtder_jZN1A@HIDDEN> Date: Tue, 28 Feb 2012 12:30:46 +0200 In-Reply-To: <CAH8Pv0hF+yd5ui3gmFfBAtyT3i0kB=q3Vz=59-fdtder_jZN1A@HIDDEN> (Dani Moncayo's message of "Tue, 28 Feb 2012 08:42:43 +0100") Message-ID: <87399v2qsp.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Sender: debbugs-submit-bounces <at> debbugs.gnu.org Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org X-Spam-Score: -1.9 (-) > Summarizing: > a. `c-forward-conditional' and `c-backward-conditional' should not set > the mark, because each one has an inverse movement command. > b. Even if you disagree, those commands should not set the mark when > it is active. All similar movement commands like `c-beginning-of-defun' and `c-end-of-defun' take precautions against the behavior you found. They do this by using the following condition before leaving mark behind: (and transient-mark-mode mark-active) The patch below fixes the remaining movement commands to do the same, except `c-mark-function' that needs to be rewritten to follow the logic of `mark-defun' for setting the mark. === modified file 'lisp/progmodes/cc-cmds.el' --- lisp/progmodes/cc-cmds.el 2012-01-25 17:54:01 +0000 +++ lisp/progmodes/cc-cmds.el 2012-02-28 10:27:49 +0000 @@ -2910,7 +2910,8 @@ (defun c-up-conditional (count) forward." (interactive "p") (let ((new-point (c-scan-conditionals (- count) -1))) - (push-mark) + (or (and transient-mark-mode mark-active) + (push-mark)) (goto-char new-point)) (c-keep-region-active)) @@ -2920,7 +2921,8 @@ (defun c-up-conditional-with-else (count directives." (interactive "p") (let ((new-point (c-scan-conditionals (- count) -1 t))) - (push-mark) + (or (and transient-mark-mode mark-active) + (push-mark)) (goto-char new-point)) (c-keep-region-active)) @@ -2934,7 +2936,8 @@ (defun c-down-conditional (count) backward." (interactive "p") (let ((new-point (c-scan-conditionals count 1))) - (push-mark) + (or (and transient-mark-mode mark-active) + (push-mark)) (goto-char new-point)) (c-keep-region-active)) @@ -2944,7 +2947,8 @@ (defun c-down-conditional-with-else (cou directives." (interactive "p") (let ((new-point (c-scan-conditionals count 1 t))) - (push-mark) + (or (and transient-mark-mode mark-active) + (push-mark)) (goto-char new-point)) (c-keep-region-active)) @@ -2959,7 +2963,8 @@ (defun c-backward-conditional (count &op to call `c-scan-conditionals' directly instead." (interactive "p") (let ((new-point (c-scan-conditionals (- count) target-depth with-else))) - (push-mark) + (or (and transient-mark-mode mark-active) + (push-mark)) (goto-char new-point)) (c-keep-region-active)) @@ -2980,7 +2985,8 @@ (defun c-forward-conditional (count &opt to call `c-scan-conditionals' directly instead." (interactive "p") (let ((new-point (c-scan-conditionals count target-depth with-else))) - (push-mark) + (or (and transient-mark-mode mark-active) + (push-mark)) (goto-char new-point))) (defun c-scan-conditionals (count &optional target-depth with-else)
X-Loop: help-debbugs@HIDDEN Subject: bug#10899: 24.0.93; c-forward-conditional should not move the mark Resent-From: Dani Moncayo <dmoncayo@HIDDEN> Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org Resent-CC: bug-gnu-emacs@HIDDEN, bug-cc-mode@HIDDEN Resent-Date: Tue, 28 Feb 2012 11:17:02 +0000 Resent-Message-ID: <handler.10899.B10899.133042777515874 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 10899 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: To: Juri Linkov <juri@HIDDEN> Cc: 10899 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN> Received: via spool by 10899-submit <at> debbugs.gnu.org id=B10899.133042777515874 (code B ref 10899); Tue, 28 Feb 2012 11:17:02 +0000 Received: (at 10899) by debbugs.gnu.org; 28 Feb 2012 11:16:15 +0000 Received: from localhost ([127.0.0.1]:60828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1S2L2G-00047H-QI for submit <at> debbugs.gnu.org; Tue, 28 Feb 2012 06:16:15 -0500 Received: from mail-tul01m020-f172.google.com ([209.85.214.172]:33435) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <dmoncayo@HIDDEN>) id 1S2L20-00046p-1O for 10899 <at> debbugs.gnu.org; Tue, 28 Feb 2012 06:15:49 -0500 Received: by obbeh20 with SMTP id eh20so2310368obb.3 for <10899 <at> debbugs.gnu.org>; Tue, 28 Feb 2012 03:12:32 -0800 (PST) Received-SPF: pass (google.com: domain of dmoncayo@HIDDEN designates 10.182.192.36 as permitted sender) client-ip=10.182.192.36; Authentication-Results: mr.google.com; spf=pass (google.com: domain of dmoncayo@HIDDEN designates 10.182.192.36 as permitted sender) smtp.mail=dmoncayo@HIDDEN; dkim=pass header.i=dmoncayo@HIDDEN Received: from mr.google.com ([10.182.192.36]) by 10.182.192.36 with SMTP id hd4mr6521766obc.60.1330427552303 (num_hops = 1); Tue, 28 Feb 2012 03:12:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=wk0dwFvSQQvwCkMFQq1iMulIsqDbUZiLmtB1UI+Lr60=; b=w9FL0w/McKRic7NpIiXEfes9ezxutO5aRgZBMIUET+smFfNmjCrJlhQRGkS3YQ87CO I3OfBW/YXWa+eBhPWN5oPuWHhS0Q4H8Ye9hWS5n/t4+6ZtmsbwNjWBsGi+C599OWhy9r ZS5yk+x5I7svyy06fOjwJFlvxh6dZW5gIyqiI= MIME-Version: 1.0 Received: by 10.182.192.36 with SMTP id hd4mr5801294obc.60.1330427552181; Tue, 28 Feb 2012 03:12:32 -0800 (PST) Received: by 10.60.42.193 with HTTP; Tue, 28 Feb 2012 03:12:32 -0800 (PST) In-Reply-To: <87399v2qsp.fsf@HIDDEN> References: <CAH8Pv0hLmrfnHR-8J9ACV+SDAED6GL_tzJJ+D1FOHTpitWh0ZQ@HIDDEN> <CAH8Pv0g7WdpONkkt-gTz6UixK0vp__BrR+gMfu9U98mD90j8Vg@HIDDEN> <83haycdnqt.fsf@HIDDEN> <CAH8Pv0jA22K9TmKBiFEc+BguFmpOXqbkUf+QcQKp7dwhB+DUmg@HIDDEN> <CAH8Pv0hF+yd5ui3gmFfBAtyT3i0kB=q3Vz=59-fdtder_jZN1A@HIDDEN> <87399v2qsp.fsf@HIDDEN> Date: Tue, 28 Feb 2012 12:12:32 +0100 Message-ID: <CAH8Pv0hu==OkPZJ0=03+yLLTzjxr49wFUJEYa0rQj=2uxjhSfQ@HIDDEN> From: Dani Moncayo <dmoncayo@HIDDEN> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Sender: debbugs-submit-bounces <at> debbugs.gnu.org Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org X-Spam-Score: -2.6 (--) >> Summarizing: >> a. `c-forward-conditional' and `c-backward-conditional' should not set >> the mark, because each one has an inverse movement command. >> b. Even if you disagree, those commands should not set the mark when >> it is active. > > All similar movement commands like `c-beginning-of-defun' and `c-end-of-d= efun' > take precautions against the behavior you found. =A0They do this by using > the following condition before leaving mark behind: > > =A0(and transient-mark-mode mark-active) > > The patch below fixes the remaining movement commands to do the same, > except `c-mark-function' that needs to be rewritten to follow the logic > of `mark-defun' for setting the mark. Thanks Juri, for working on this and many other fixes/improvements to Emacs= . Regarding your patch, I think it clearly improve the current behavior, but I want to emphasize again that, IMO, setting the mark in too many commands is bad, because it overfills the mark ring, thus making harder to return to earlier positions. --=20 Dani Moncayo
X-Loop: help-debbugs@HIDDEN Subject: bug#10899: 24.0.93; c-forward-conditional should not move the mark Resent-From: Stefan Monnier <monnier@HIDDEN> Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org Resent-CC: bug-gnu-emacs@HIDDEN, bug-cc-mode@HIDDEN Resent-Date: Tue, 28 Feb 2012 22:00:04 +0000 Resent-Message-ID: <handler.10899.B10899.13304663992043 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 10899 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: To: Dani Moncayo <dmoncayo@HIDDEN> Cc: 10899 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN> Received: via spool by 10899-submit <at> debbugs.gnu.org id=B10899.13304663992043 (code B ref 10899); Tue, 28 Feb 2012 22:00:04 +0000 Received: (at 10899) by debbugs.gnu.org; 28 Feb 2012 21:59:59 +0000 Received: from localhost ([127.0.0.1]:54700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1S2V5T-0000Wh-3P for submit <at> debbugs.gnu.org; Tue, 28 Feb 2012 16:59:59 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]:34970) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <monnier@HIDDEN>) id 1S2V5H-0000WC-04 for 10899 <at> debbugs.gnu.org; Tue, 28 Feb 2012 16:59:47 -0500 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q1SLxU2K006384; Tue, 28 Feb 2012 16:59:31 -0500 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id D6BBAB4166; Tue, 28 Feb 2012 16:59:30 -0500 (EST) From: Stefan Monnier <monnier@HIDDEN> Message-ID: <jwvbooioc2c.fsf-monnier+emacs@HIDDEN> References: <CAH8Pv0hLmrfnHR-8J9ACV+SDAED6GL_tzJJ+D1FOHTpitWh0ZQ@HIDDEN> <CAH8Pv0g7WdpONkkt-gTz6UixK0vp__BrR+gMfu9U98mD90j8Vg@HIDDEN> <83haycdnqt.fsf@HIDDEN> <CAH8Pv0jA22K9TmKBiFEc+BguFmpOXqbkUf+QcQKp7dwhB+DUmg@HIDDEN> <CAH8Pv0hF+yd5ui3gmFfBAtyT3i0kB=q3Vz=59-fdtder_jZN1A@HIDDEN> Date: Tue, 28 Feb 2012 16:59:30 -0500 In-Reply-To: <CAH8Pv0hF+yd5ui3gmFfBAtyT3i0kB=q3Vz=59-fdtder_jZN1A@HIDDEN> (Dani Moncayo's message of "Tue, 28 Feb 2012 08:42:43 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4146=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4146> : streams <733156> : uri <1073872> X-Spam-Score: -3.5 (---) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Sender: debbugs-submit-bounces <at> debbugs.gnu.org Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org X-Spam-Score: -3.5 (---) > Summarizing: > a. `c-forward-conditional' and `c-backward-conditional' should not set > the mark, because each one has an inverse movement command. > b. Even if you disagree, those commands should not set the mark when > it is active. FWIW I completely agree. Stefan
X-Loop: help-debbugs@HIDDEN Subject: bug#10899: 24.0.93; c-forward-conditional should not move the mark Resent-From: Juri Linkov <juri@HIDDEN> Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org Resent-CC: bug-gnu-emacs@HIDDEN, bug-cc-mode@HIDDEN Resent-Date: Wed, 29 Feb 2012 00:22:02 +0000 Resent-Message-ID: <handler.10899.B10899.133047489714879 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 10899 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: To: Dani Moncayo <dmoncayo@HIDDEN> Cc: 10899 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN> Received: via spool by 10899-submit <at> debbugs.gnu.org id=B10899.133047489714879 (code B ref 10899); Wed, 29 Feb 2012 00:22:02 +0000 Received: (at 10899) by debbugs.gnu.org; 29 Feb 2012 00:21:37 +0000 Received: from localhost ([127.0.0.1]:54893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1S2XIX-0003rm-4j for submit <at> debbugs.gnu.org; Tue, 28 Feb 2012 19:21:37 -0500 Received: from ps18281.dreamhost.com ([69.163.218.105]:48323 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <juri@HIDDEN>) id 1S2XIJ-0003rM-Nk for 10899 <at> debbugs.gnu.org; Tue, 28 Feb 2012 19:21:25 -0500 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 907D1451C1B1; Tue, 28 Feb 2012 16:19:25 -0800 (PST) From: Juri Linkov <juri@HIDDEN> Organization: JURTA References: <CAH8Pv0hLmrfnHR-8J9ACV+SDAED6GL_tzJJ+D1FOHTpitWh0ZQ@HIDDEN> <CAH8Pv0g7WdpONkkt-gTz6UixK0vp__BrR+gMfu9U98mD90j8Vg@HIDDEN> <83haycdnqt.fsf@HIDDEN> <CAH8Pv0jA22K9TmKBiFEc+BguFmpOXqbkUf+QcQKp7dwhB+DUmg@HIDDEN> <CAH8Pv0hF+yd5ui3gmFfBAtyT3i0kB=q3Vz=59-fdtder_jZN1A@HIDDEN> <87399v2qsp.fsf@HIDDEN> <CAH8Pv0hu==OkPZJ0=03+yLLTzjxr49wFUJEYa0rQj=2uxjhSfQ@HIDDEN> Date: Wed, 29 Feb 2012 02:14:05 +0200 In-Reply-To: <CAH8Pv0hu==OkPZJ0=03+yLLTzjxr49wFUJEYa0rQj=2uxjhSfQ@HIDDEN> (Dani Moncayo's message of "Tue, 28 Feb 2012 12:12:32 +0100") Message-ID: <87399ua436.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Sender: debbugs-submit-bounces <at> debbugs.gnu.org Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org X-Spam-Score: -1.9 (-) > Regarding your patch, I think it clearly improve the current behavior, > but I want to emphasize again that, IMO, setting the mark in too many > commands is bad, because it overfills the mark ring, thus making > harder to return to earlier positions. What I wanted to achieve is to make C movement commands to behave exactly as their Lisp counterparts. I see the following correspondence: leaves mark behind? c-beginning-of-defun beginning-of-defun yes c-end-of-defun end-of-defun yes c-mark-function mark-defun yes c-up-conditional backward-up-list no c-down-conditional down-list no c-backward-conditional backward-list no c-forward-conditional forward-list no So I agree that `c-forward-conditional' and `c-backward-conditional' should not push the mark. Regarding bug#10906, I think `c-mark-function' should be rewritten to follow the logic of `mark-defun'.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.