GNU bug report logs - #12953
Implement line highlighting (à la hl-line) in the display engine

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 21 Nov 2012 15:51:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 21 10:51:45 2012
Received: from localhost ([127.0.0.1]:59302 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1TbCaX-0004xZ-9A
	for submit <at> debbugs.gnu.org; Wed, 21 Nov 2012 10:51:45 -0500
Received: from eggs.gnu.org ([208.118.235.92]:37013)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <lekktu@HIDDEN>) id 1TbCaV-0004xS-7y
	for submit <at> debbugs.gnu.org; Wed, 21 Nov 2012 10:51:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lekktu@HIDDEN>) id 1TbCZD-0006a6-Oc
	for submit <at> debbugs.gnu.org; Wed, 21 Nov 2012 10:50:27 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
	RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.2
Received: from lists.gnu.org ([208.118.235.17]:59125)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lekktu@HIDDEN>) id 1TbCZD-0006a2-LY
	for submit <at> debbugs.gnu.org; Wed, 21 Nov 2012 10:50:23 -0500
Received: from eggs.gnu.org ([208.118.235.92]:60524)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lekktu@HIDDEN>) id 1TbCZ7-0006VN-PZ
	for bug-gnu-emacs@HIDDEN; Wed, 21 Nov 2012 10:50:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lekktu@HIDDEN>) id 1TbCZ1-0006Mi-Ud
	for bug-gnu-emacs@HIDDEN; Wed, 21 Nov 2012 10:50:17 -0500
Received: from mail-bk0-f41.google.com ([209.85.214.41]:49615)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lekktu@HIDDEN>) id 1TbCZ1-0006Lw-NR
	for bug-gnu-emacs@HIDDEN; Wed, 21 Nov 2012 10:50:11 -0500
Received: by mail-bk0-f41.google.com with SMTP id jg9so3225678bkc.0
	for <bug-gnu-emacs@HIDDEN>; Wed, 21 Nov 2012 07:50:10 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:from:date:message-id:subject:to:content-type;
	bh=zM6e2u0EuCPzVyaRbhulH4xQ6O4ZZm5mcBWwP3/2+oc=;
	b=0Ma5VtwDEmytqQN7vTlsF6yc1gp3sQCpMCGWMsAm6vz22ilKR8lBTKFa+gORmU66SZ
	7LHrr3+KAnFL8dVV+V2RjLGrrRdNbkLm+XMjFH9pN9BnU50fYyZXouR9POqfHWe6rVb9
	W7g2oucrYXuyKDzyXpedbU1FzsstQ/k0d0AeIislvEquPPbd6TmNlu1n3nA21yNzEcoJ
	SrJO96hsItV5rtfy14EZD1AfrdAXPYBq3EIkw8fbaCZhSxWbxvIiPBJMmLQV0gJLISQc
	yyJ2pibFwSDqUxxPDjaYXr4dOR6JdhCOfA8+t5pY8kv91b912jFOMcV6LMdtvkaKfH2e
	s6sQ==
Received: by 10.204.147.207 with SMTP id m15mr7136840bkv.54.1353513010286;
	Wed, 21 Nov 2012 07:50:10 -0800 (PST)
MIME-Version: 1.0
Received: by 10.204.34.70 with HTTP; Wed, 21 Nov 2012 07:49:29 -0800 (PST)
From: Juanma Barranquero <lekktu@HIDDEN>
Date: Wed, 21 Nov 2012 16:49:29 +0100
Message-ID: <CAAeL0SRTV3Po5JmabweTcQks1fpifkAkxpq+w5U3E9=BOkU20g@HIDDEN>
Subject: =?UTF-8?Q?Implement_line_highlighting_=28=C3=A0_la_hl=2Dline=29_in_the_d?=
	=?UTF-8?Q?isplay_engine?=
To: Bug-Gnu-Emacs <bug-gnu-emacs@HIDDEN>
Content-Type: text/plain; charset=UTF-8
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 208.118.235.17
X-Spam-Score: -3.4 (---)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -3.4 (---)

Package: emacs
Version: 24.2.50
Severity: wishlist
X-Debbugs-Cc: gavenkoa@HIDDEN


---------- Forwarded message ----------
From: Eli Zaretskii <eliz@HIDDEN>
Date: Tue, Nov 20, 2012 at 9:47 PM
Subject: bug#12927: 24.2; global-hl-line-mode and
"scroll-conservatively=1000" take	jump	up-down the text when hold DOWN
key (in *info* buffer).
To: Oleksandr Gavenko <gavenkoa@HIDDEN>
Cc: 12927 <at> debbugs.gnu.org


> From: Oleksandr Gavenko <gavenkoa@HIDDEN>
> Cc: 12927 <at> debbugs.gnu.org
> Date: Tue, 20 Nov 2012 22:36:58 +0200
>
> > Should be fixed in revision 110927 on the emacs-24 branch.  Please
> > test.
>
> I don't familiar with bzr:
>
>   $ bzr up
>   $ bzr info -v
>   Repository checkout (format: 2a)
>   Location:
>     repository checkout root: .
>           checkout of branch: bzr://bzr.savannah.gnu.org/emacs/trunk/
>            shared repository: /home/user/devel/emacs/emacs-bzr

This is the trunk, not the emacs-24 branch.  I committed the fix to
the emacs-24 branch.  You can wait until the changes from the branch
are merged onto the trunk, and test then.  Or you can checkout the
branch, like so:

  $ cd /home/user/devel/emacs/emacs-bzr
  $ bzr branch bzr://bzr.savannah.gnu.org/emacs/emacs-24

This will create an emacs-24 directory under
/home/user/devel/emacs/emacs-bzr, and you can then build it and try
the fix.

> Also I found that "(global-hl-line-mode 1)" slow down scrolling in CC-mode
> enabled buffers in two or more times. Do I need report a bug?

No, this is expected.  hl-line-mode adds itself to post-command-hook,
and moves its overlay after each command that changes the current
line.  What this does is completely disable the redisplay
optimizations used when only the cursor moves without any other
changes to the text, because moving an overlay requires a thorough
redisplay of the window, which is more expensive.

The only bug report that I can think of is a feature request to move
hl-line-mode into the display engine, because the display engine
knowns very well where's the current line (when it decides where to
display the cursor), and can do this highlighting better and much more
efficiently.