Received: (at 22466) by debbugs.gnu.org; 7 Mar 2025 12:26:27 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 07 07:26:27 2025 Received: from localhost ([127.0.0.1]:47337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tqWmY-0004cb-Ry for submit <at> debbugs.gnu.org; Fri, 07 Mar 2025 07:26:27 -0500 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]:54480) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <maurooaranda@HIDDEN>) id 1tqWmV-0004cL-NA for 22466 <at> debbugs.gnu.org; Fri, 07 Mar 2025 07:26:24 -0500 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-223a7065ff8so3905565ad.0 for <22466 <at> debbugs.gnu.org>; Fri, 07 Mar 2025 04:26:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741350377; x=1741955177; darn=debbugs.gnu.org; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=XAccMUIinGF+slo3DWFy3b+8yLwzAGAACM48AXbOiLA=; b=hcZL3VRS/5C5dQNu2vQuSM3L7PjR0KY6AiISFHU7ZKgzTeBJvMkRcgYN8r9g6N5oea nVnMXDIaF/dVv9dX5s4CkrVaOx87fGhZkjmcSDeBVBrmH0PerzEc66JrM9WYZp34uJfo k9S2O2MTcCYjJbDrOy4t5tR/Cn1LB0xj8kfkJMkEJyv7JZvWkR14kCFGl0Bq9aQtzS2N g9SI7Yp5HwWMoNMyzJFLNq/kQfPnD+pMw8GHzWVnHfTZwpxnXBNWk+zmjz3PG2pl254k AXU2nCVYo7rPYgcyADqXYyX9HkcZ6jNdnyeI9lB/RdnoQGK1tsCL0rsZIWSG9zFsiKI8 DwgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741350377; x=1741955177; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=XAccMUIinGF+slo3DWFy3b+8yLwzAGAACM48AXbOiLA=; b=Aml6Vki4XzV14J3DtI9ehzK/qYLuKGLzk1TTdxweEnGFKyNQlubHCZpVGtUBnFRe4w Yi9NZXci3iu5wYDeRGviu5CDfSFHUMQlljfgIDeX8MLNGykWVSAIYOXzdQefcRJDDQ6V toiQ3BoxRCkT8OyWCyMgMXAJhsdGD6roy32VKGOAZ7WXyDO3viSYkhF47d8QSnI0bMKE 2SNps4kCcJFbP2vpLAC7RPU7oc6sIG5tCSE4HjyWs6xvFT8UZur7O2+M82F+BRQC3Ycd lpoiYQEnVK0G1dKaeuY1HLu0HaIstu+RN3scyZv+DT2GwbL4mdTyKIfijK76XuOGFotN WEUg== X-Gm-Message-State: AOJu0Yyy72FYExadMHqiOci8UAf/4I5jHvIpPD6Bh6z7qavFePqDPHMS PI/3Oka+ORI2plHs9VZuytg9oZW9FuIZC9uxYFqysLvxUzH97tnt X-Gm-Gg: ASbGncs53aH8Etrk1Dwcbj+goOB3fdJIsQNwxrllcOzojNuNyfE+TvDAbzAiqhvNEfQ AZh/MW88I3ANWK5ZVKVirXUxioF7hQUxfWNHyY6Zl3wxz5a96p+kl2rjwdoXC7dstH08017k9p2 Bho50igK9Y4UapRfh3IqIAo0JK04AdoW42NzLIU8Uqrn2cRwpx6Niy54R+1agoCsVv+FYSGxp4Y tj4KC9YkkFP2DycRGLSBY70r9xYRjwaLFRLb54Le/ZMkO9z2i9+t8Qt0EMqej1rglkCjyOMvslx +TO99/Hj8yn0gLwTigYefOKZ9pimhrdXa7fsx3nMAv8R9MKRdhU= X-Google-Smtp-Source: AGHT+IHRQ1O9/TGH1wh9UUIQ0xlUnvAXvssYAYcIseK2OL6G97JaeTTV8FH8CFIvE/iYkfxiWt3GYw== X-Received: by 2002:a17:902:d2c2:b0:21f:617a:f1b2 with SMTP id d9443c01a7336-22428ad58bfmr49572655ad.46.1741350377524; Fri, 07 Mar 2025 04:26:17 -0800 (PST) Received: from [192.168.0.234] ([181.228.33.6]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-224109dd627sm28793695ad.50.2025.03.07.04.26.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Mar 2025 04:26:16 -0800 (PST) Content-Type: multipart/mixed; boundary="------------04KB0Yajh3iDkmeKpR0KZYhA" Message-ID: <84e8ad5c-7183-4fbd-a22c-ca946c43d5f9@HIDDEN> Date: Fri, 7 Mar 2025 09:26:14 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash To: Eli Zaretskii <eliz@HIDDEN> References: <e47d6218-72eb-4c3a-a281-e641a1c09438@HIDDEN> <86a59xkptz.fsf@HIDDEN> Content-Language: en-US From: Mauro Aranda <maurooaranda@HIDDEN> In-Reply-To: <86a59xkptz.fsf@HIDDEN> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 22466 Cc: 22466 <at> debbugs.gnu.org, bruce.connor.am@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------04KB0Yajh3iDkmeKpR0KZYhA Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 7/3/25 09:06, Eli Zaretskii wrote: >> Date: Fri, 7 Mar 2025 08:53:25 -0300 >> Cc: Eli Zaretskii <eliz@HIDDEN>, Artur Malabarba <bruce.connor.am@HIDDEN> >> From: Mauro Aranda <maurooaranda@HIDDEN> >> >> >> Eli Zaretskii <eliz@HIDDEN> writes: >> >> >> From: Artur Malabarba <bruce.connor.am@HIDDEN> >> >> Cc: 22466 <at> debbugs.gnu.org >> >> Date: Wed, 27 Jan 2016 20:20:43 +0000 >> >> >> >> > Then it would make sense to find a way of switching a theme without >> >> > changing the frame's background color, if that's possible (i.e. if the >> >> > new theme keeps the same background color). If there's a function >> >> > missing for that, I'd suggest to add one. >> >> >> >> How about just running that form only when necessary (i.e., only if the >> >> disabled theme actually sets the frame `background-color')? >> > >> > Yes, something like that. Or maybe add a new switch-theme API that >> > receives both the old and a new theme, and changes the background >> > color only if the new theme sets a different one. >> >> With the provided recipe, I only see a flash at the scroll-bar >> position, unlike in older versions. >> >> I'll be testing the attached patch for a while, which introduces a >> new switch-theme command. > > Thanks. > > Would it be a better UI if instead of prompting with > > Enable custom theme: > Disable custom theme: > > we would prompt like this: > > Switch off theme (default none): > Switch on theme: > > I think this order is preferable, since "switch-SOMETHING" > conceptually means turn off OLD, then turn on NEW, not the other way > around, even if the implementation does it in the reverse order for > some technical reasons. Thank you Eli, that does indeed look better for the UI. Updated patch attached. If it works fine, I'll add a NEWS entry. --------------04KB0Yajh3iDkmeKpR0KZYhA Content-Type: text/x-patch; charset=UTF-8; name="0001-New-command-switch-theme.patch" Content-Disposition: attachment; filename="0001-New-command-switch-theme.patch" Content-Transfer-Encoding: base64 RnJvbSBiZjNjMjcxMzEzZWIyMGE1YmQ4MzQyYTNhODRkODIzMjc0ZGZjZTA3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IFR1ZSwgNCBNYXIgMjAyNSAxMDowNDoyMiAtMDMwMApTdWJqZWN0OiBb UEFUQ0hdIE5ldyBjb21tYW5kIHN3aXRjaC10aGVtZQoKKiBsaXNwL2N1c3RvbS5lbCAoc3dp dGNoLXRoZW1lKTogTmV3IGNvbW1hbmQuICBBdm9pZHMgc2NyZWVuCmZsYXNoaW5nIHdoZW4g c3dpdGNoaW5nIHRoZW1lcywgb3IgcmVlbmFibGluZyBvbmUuICAoQnVnIzIyNDY2KQotLS0K IGxpc3AvY3VzdG9tLmVsIHwgMjIgKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNo YW5nZWQsIDIyIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9saXNwL2N1c3RvbS5lbCBi L2xpc3AvY3VzdG9tLmVsCmluZGV4IDUzNjBjMzk3YzU5Li5lNTlkZGQ0ZDA5NyAxMDA2NDQK LS0tIGEvbGlzcC9jdXN0b20uZWwKKysrIGIvbGlzcC9jdXN0b20uZWwKQEAgLTE0NDEsNiAr MTQ0MSwyOCBAQCB0aGVtZS1jaG9vc2UtdmFyaWFudAogCiAoZGVmYWxpYXMgJ3RvZ2dsZS10 aGVtZSAjJ3RoZW1lLWNob29zZS12YXJpYW50KQogCisoZGVmdW4gc3dpdGNoLXRoZW1lIChv bGQgbmV3KQorICAiRGlzYWJsZSB0aGVtZSBPTEQgYW5kIGVuYWJsZSB0aGVtZSBORVcuCisK K0JvdGggdGhlbWVzIHNob3VsZCBiZSBrbm93biB0aGVtZXMsIGJ1dCBPTEQgbWlnaHQgYmUg bmlsLCBpbiB3aGljaAorY2FzZSB0aGlzIGlzIGVxdWl2YWxlbnQgdG8gZXhlY3V0aW5nIGBl bmFibGUtdGhlbWUnLiIKKyAgKGludGVyYWN0aXZlIChsaXN0IChpbnRlcm4KKyAgICAgICAg ICAgICAgICAgICAgICAoY29tcGxldGluZy1yZWFkCisgICAgICAgICAgICAgICAgICAgICAg ICJTd2l0Y2ggb2ZmIHRoZW1lIChkZWZhdWx0IG5vbmUpOiAiCisgICAgICAgICAgICAgICAg ICAgICAgIGN1c3RvbS1lbmFibGVkLXRoZW1lcyBuaWwgbmlsIG5pbCBuaWwgIm5pbCIpKQor ICAgICAgICAgICAgICAgICAgICAgKGludGVybgorICAgICAgICAgICAgICAgICAgICAgIChj b21wbGV0aW5nLXJlYWQKKyAgICAgICAgICAgICAgICAgICAgICAgIlN3aXRjaCBvbiB0aGVt ZTogIgorICAgICAgICAgICAgICAgICAgICAgICBvYmFycmF5IChsYW1iZGEgKHN5bSkKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChhbmQgKGdldCBzeW0gJ3RoZW1lLXNl dHRpbmdzKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAobm90IChl cSBzeW0gJ3VzZXIpKSkpCisgICAgICAgICAgICAgICAgICAgICAgIHQpKSkpCisgIDs7IEVu YWJsZSBhbmQgdGhlbiBkaXNhYmxlLCB0byBhdm9pZCBhbiBpbnRlcm1lZGlhdGUgc3RlcCB3 aGVyZQorICA7OyB3ZSBzd2l0Y2ggYmFjayB0byB0aGUgZnJhbWUncyBkZWZhdWx0IGZvcmVn cm91bmQgYW5kIGJhY2tncm91bmQuCisgIChlbmFibGUtdGhlbWUgbmV3KQorICAod2hlbiBv bGQKKyAgICAoZGlzYWJsZS10aGVtZSBvbGQpKSkKKwogKGRlZnVuIGN1c3RvbS10aGVtZS1s b2FkLWNvbmZpcm0gKGhhc2gpCiAgICJRdWVyeSB0aGUgdXNlciBhYm91dCBsb2FkaW5nIGEg Q3VzdG9tIHRoZW1lIHRoYXQgbWF5IG5vdCBiZSBzYWZlLgogVGhlIHRoZW1lIHNob3VsZCBi ZSBpbiB0aGUgY3VycmVudCBidWZmZXIuICBJZiB0aGUgdXNlciBhZ3JlZXMsCi0tIAoyLjM0 LjEKCg== --------------04KB0Yajh3iDkmeKpR0KZYhA--
bug-gnu-emacs@HIDDEN:bug#22466; Package emacs.
Full text available.Received: (at 22466) by debbugs.gnu.org; 7 Mar 2025 12:06:30 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 07 07:06:30 2025 Received: from localhost ([127.0.0.1]:47305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tqWTF-0003jz-Iy for submit <at> debbugs.gnu.org; Fri, 07 Mar 2025 07:06:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54418) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tqWTC-0003jl-Qt for 22466 <at> debbugs.gnu.org; Fri, 07 Mar 2025 07:06:28 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tqWT7-0002Qj-8y; Fri, 07 Mar 2025 07:06:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=R9NCSfAAjal9OWpzrAqaIliJKLuMLBnM+vRCkTMwUjY=; b=kkXwV5lm7ARuVw9CbicQ fI4p6ghpFPwC5d9Frpq4UaMqgf5MBeea+FsU9maMuLiFtMBzrxnT2Lwf6FHZg+WvZhVCxMdYtLFMB XOxcCRONQD0PdjVc8LF4wyLlDIKVAXIwu0EJCsK17b6MBSFYPnk2BXiBDIfqQdEi/lc06ifGH94Wf 3rVOrUbobfRoGV7fQQ4WAYWbj8HXUkjplqshhWYwHiVs6Gc8tmv+0SusNq4A58Iv4SOozNSXNjhYk Ju5lQ4HZJMTeAKiLK303ebOf+0JM1muefOUdBWO7azhAhH9ObNhzvGe44lHUWSHBQM3k0OOu7yQCb iWLJxyuQsRyFjw==; Date: Fri, 07 Mar 2025 14:06:16 +0200 Message-Id: <86a59xkptz.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Mauro Aranda <maurooaranda@HIDDEN> In-Reply-To: <e47d6218-72eb-4c3a-a281-e641a1c09438@HIDDEN> (message from Mauro Aranda on Fri, 7 Mar 2025 08:53:25 -0300) Subject: Re: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash References: <e47d6218-72eb-4c3a-a281-e641a1c09438@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 22466 Cc: 22466 <at> debbugs.gnu.org, bruce.connor.am@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Fri, 7 Mar 2025 08:53:25 -0300 > Cc: Eli Zaretskii <eliz@HIDDEN>, Artur Malabarba <bruce.connor.am@HIDDEN> > From: Mauro Aranda <maurooaranda@HIDDEN> > > > Eli Zaretskii <eliz@HIDDEN> writes: > > >> From: Artur Malabarba <bruce.connor.am@HIDDEN> > >> Cc: 22466 <at> debbugs.gnu.org > >> Date: Wed, 27 Jan 2016 20:20:43 +0000 > >> > >> > Then it would make sense to find a way of switching a theme without > >> > changing the frame's background color, if that's possible (i.e. if the > >> > new theme keeps the same background color). If there's a function > >> > missing for that, I'd suggest to add one. > >> > >> How about just running that form only when necessary (i.e., only if the > >> disabled theme actually sets the frame `background-color')? > > > > Yes, something like that. Or maybe add a new switch-theme API that > > receives both the old and a new theme, and changes the background > > color only if the new theme sets a different one. > > With the provided recipe, I only see a flash at the scroll-bar > position, unlike in older versions. > > I'll be testing the attached patch for a while, which introduces a > new switch-theme command. Thanks. Would it be a better UI if instead of prompting with Enable custom theme: Disable custom theme: we would prompt like this: Switch off theme (default none): Switch on theme: I think this order is preferable, since "switch-SOMETHING" conceptually means turn off OLD, then turn on NEW, not the other way around, even if the implementation does it in the reverse order for some technical reasons.
bug-gnu-emacs@HIDDEN:bug#22466; Package emacs.
Full text available.Received: (at 22466) by debbugs.gnu.org; 7 Mar 2025 11:53:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 07 06:53:39 2025 Received: from localhost ([127.0.0.1]:47268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tqWGp-00036u-7m for submit <at> debbugs.gnu.org; Fri, 07 Mar 2025 06:53:39 -0500 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]:56363) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <maurooaranda@HIDDEN>) id 1tqWGl-00036Z-K9 for 22466 <at> debbugs.gnu.org; Fri, 07 Mar 2025 06:53:36 -0500 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-223cc017ef5so33676635ad.0 for <22466 <at> debbugs.gnu.org>; Fri, 07 Mar 2025 03:53:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741348409; x=1741953209; darn=debbugs.gnu.org; h=subject:from:cc:to:content-language:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=G5oJ4ZWCTLk/l3CxtLiPN1HJP9YFUOTWrChcSsmZlTQ=; b=cwAvt9SgL6Ux98tVnbi1eu//kqjXKddED7VGVbcPV2LlmpNd2I9mCqGKzrbhlARMRp iU1WL4BmSBKKL9406VOOSNoWSyTaVn5yNtncjIJF+OkkJvlUxSB10aNBH8Moo/dtQlRq qztDuJ9KGW8ju7jAegHFbwTNtKyZcZUiCifTcsIiFnuuGzRjXbkesUknlSHOjKjcleCX ujHVwvU8i8O9LjJh0HVKCTVq2bYot5wDqJYLPd/4CRdRB+CgSpM+GOVXGmArIJwzAFju klM8vHp68mL59JmKEniweKPelFvBKGd8xu8VO1AUDp5dtNw9ndslND0A038EDzP2xdYZ RcwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741348409; x=1741953209; h=subject:from:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=G5oJ4ZWCTLk/l3CxtLiPN1HJP9YFUOTWrChcSsmZlTQ=; b=P5vrEGGE+G0BZDVdrFPcSfFdOLzDcNbTClu+33lhnS5ZqjgYnawApTaJM4jWTtGekp JAIb/ffD70tJCmDiJNyFTaCrQBPQTrUhPQ67KNIPdmBInH2h3hi32nWP/qppTb44kWYN ACtvBAqRMkCLMWT9dTCAd4jWi3g/Zp7xPu9TK08IoU67/1ybk2Mqa3Mq1HZS14fJ8LPJ ZEFgHJrhl6GCitVHRPF2JGrDOCkV5/wOoWiGCOUIAi3qUHyHQQpdX2A5T3ajSNCVMLSP 93bhwC+CrvZQyjE3SYTuxlPI5mbCXU5SUAz5f1ogH8kYX5Esbzx5H3ldbkeZCYb06cUD qqww== X-Gm-Message-State: AOJu0Ywzxk1VBwmvFJfydjMZvSYwXCTNIwia/l3Lq9YasG9zBd2JtfOW ghKP0WcoEchdqblJMNkb6uX2oOzCKuQbMhsbrjny0TIyzmDVptGKJl8Skg== X-Gm-Gg: ASbGncs5f6KRDj3sfw6l42H7a0HwVZ859fKkGJWJ/DvK9BB9tHc137MYGfJkYJ0QiQo CFFJHv1fob7pFyP60O2Zf6lE5dpaJ0f4LdQchXS4hfGM1Ov1J34nEs6AS8DrT4Bl8ScVmpOnc10 APOpm85w5o6VoH50m7ow+iWOMRvjkiyN9xk1zSFV68WzO5Pfgwl5sCVHg7E2ubzOkPBulH1NcRw J/VmdgF+vQTuC1sIy/yNuFBv5Yye8reF78Cg4G9Z7X3q6eV+MeNQCGWi0pelqbaRPB9o8x5uUdz d8lwM5o7bhyug1eMf9G60aF/v94VruQd9GLUUzXkN2rnkfzCTMo= X-Google-Smtp-Source: AGHT+IHzAlFgNRpaFdwsYMkGZKTeMCSNjG7YJqnqZBZzvnCC6qpStJ9Z/eunDCKayP04O5neme39Rg== X-Received: by 2002:a05:6a00:c8f:b0:736:69aa:112c with SMTP id d2e1a72fcca58-736aaa1df1emr3844636b3a.9.1741348409028; Fri, 07 Mar 2025 03:53:29 -0800 (PST) Received: from [192.168.0.234] ([181.228.33.6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-736984f7252sm3121615b3a.101.2025.03.07.03.53.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Mar 2025 03:53:28 -0800 (PST) Content-Type: multipart/mixed; boundary="------------gU70cuKBjpLigG1ljJnridtQ" Message-ID: <e47d6218-72eb-4c3a-a281-e641a1c09438@HIDDEN> Date: Fri, 7 Mar 2025 08:53:25 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: 22466 <at> debbugs.gnu.org From: Mauro Aranda <maurooaranda@HIDDEN> Subject: Re: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 22466 Cc: Eli Zaretskii <eliz@HIDDEN>, Artur Malabarba <bruce.connor.am@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------gU70cuKBjpLigG1ljJnridtQ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Eli Zaretskii <eliz@HIDDEN> writes: >> From: Artur Malabarba <bruce.connor.am@HIDDEN> >> Cc: 22466 <at> debbugs.gnu.org >> Date: Wed, 27 Jan 2016 20:20:43 +0000 >> >> > Then it would make sense to find a way of switching a theme without >> > changing the frame's background color, if that's possible (i.e. if the >> > new theme keeps the same background color). If there's a function >> > missing for that, I'd suggest to add one. >> >> How about just running that form only when necessary (i.e., only if the >> disabled theme actually sets the frame `background-color')? > > Yes, something like that. Or maybe add a new switch-theme API that > receives both the old and a new theme, and changes the background > color only if the new theme sets a different one. With the provided recipe, I only see a flash at the scroll-bar position, unlike in older versions. I'll be testing the attached patch for a while, which introduces a new switch-theme command. --------------gU70cuKBjpLigG1ljJnridtQ Content-Type: text/x-patch; charset=UTF-8; name="0001-New-command-switch-theme.patch" Content-Disposition: attachment; filename="0001-New-command-switch-theme.patch" Content-Transfer-Encoding: base64 RnJvbSA3NDEwZjBiNDVhNTk1NDk1YzNjODc4NjJmZWNiMmVmYjJmZjVlYWI0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IFR1ZSwgNCBNYXIgMjAyNSAxMDowNDoyMiAtMDMwMApTdWJqZWN0OiBb UEFUQ0hdIE5ldyBjb21tYW5kIHN3aXRjaC10aGVtZQoKKiBsaXNwL2N1c3RvbS5lbCAoc3dp dGNoLXRoZW1lKTogTmV3IGNvbW1hbmQuICBBdm9pZHMgc2NyZWVuCmZsYXNoaW5nIHdoZW4g c3dpdGNoaW5nIHRoZW1lcywgb3IgcmVlbmFibGluZyBvbmUuICAoQnVnIzIyNDY2KQotLS0K IGxpc3AvY3VzdG9tLmVsIHwgMjIgKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNo YW5nZWQsIDIyIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9saXNwL2N1c3RvbS5lbCBi L2xpc3AvY3VzdG9tLmVsCmluZGV4IDUzNjBjMzk3YzU5Li5mNzczZGZhNTA3MSAxMDA2NDQK LS0tIGEvbGlzcC9jdXN0b20uZWwKKysrIGIvbGlzcC9jdXN0b20uZWwKQEAgLTE0NDEsNiAr MTQ0MSwyOCBAQCB0aGVtZS1jaG9vc2UtdmFyaWFudAogCiAoZGVmYWxpYXMgJ3RvZ2dsZS10 aGVtZSAjJ3RoZW1lLWNob29zZS12YXJpYW50KQogCisoZGVmdW4gc3dpdGNoLXRoZW1lIChu ZXcgJm9wdGlvbmFsIG9sZCkKKyAgIkVuYWJsZSB0aGVtZSBORVcgYW5kIGRpc2FibGUgdGhl bWUgT0xELgorCitCb3RoIE5FVyBhbmQgT0xEIHNob3VsZCBiZSBrbm93biB0aGVtZXMgYnV0 IE9MRCBtaWdodCBiZSBvbWl0dGVkLCBpbiB3aGljaAorY2FzZSwgdGhpcyBpcyBlcXVpdmFs ZW50IHRvIGV4ZWN1dGluZyBgZW5hYmxlLXRoZW1lJy4iCisgIChpbnRlcmFjdGl2ZSAobGlz dCAoaW50ZXJuCisgICAgICAgICAgICAgICAgICAgICAgKGNvbXBsZXRpbmctcmVhZAorICAg ICAgICAgICAgICAgICAgICAgICAiRW5hYmxlIGN1c3RvbSB0aGVtZTogIgorICAgICAgICAg ICAgICAgICAgICAgICBvYmFycmF5IChsYW1iZGEgKHN5bSkKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIChhbmQgKGdldCBzeW0gJ3RoZW1lLXNldHRpbmdzKQorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAobm90IChlcSBzeW0gJ3VzZXIpKSkp CisgICAgICAgICAgICAgICAgICAgICAgIHQpKQorICAgICAgICAgICAgICAgICAgICAgKGlu dGVybgorICAgICAgICAgICAgICAgICAgICAgIChjb21wbGV0aW5nLXJlYWQKKyAgICAgICAg ICAgICAgICAgICAgICAgIkRpc2FibGUgY3VzdG9tIHRoZW1lOiAiCisgICAgICAgICAgICAg ICAgICAgICAgIGN1c3RvbS1lbmFibGVkLXRoZW1lcyBuaWwgbmlsIG5pbCBuaWwgIm5pbCIp KSkpCisgIDs7IEVuYWJsZSBhbmQgdGhlbiBkaXNhYmxlLCB0byBhdm9pZCBhbiBpbnRlcm1l ZGlhdGUgc3RlcCB3aGVyZQorICA7OyB3ZSBzd2l0Y2ggYmFjayB0byB0aGUgZnJhbWUncyBk ZWZhdWx0IGZvcmVncm91bmQgYW5kIGJhY2tncm91bmQuCisgIChlbmFibGUtdGhlbWUgbmV3 KQorICAod2hlbiBvbGQKKyAgICAoZGlzYWJsZS10aGVtZSBvbGQpKSkKKwogKGRlZnVuIGN1 c3RvbS10aGVtZS1sb2FkLWNvbmZpcm0gKGhhc2gpCiAgICJRdWVyeSB0aGUgdXNlciBhYm91 dCBsb2FkaW5nIGEgQ3VzdG9tIHRoZW1lIHRoYXQgbWF5IG5vdCBiZSBzYWZlLgogVGhlIHRo ZW1lIHNob3VsZCBiZSBpbiB0aGUgY3VycmVudCBidWZmZXIuICBJZiB0aGUgdXNlciBhZ3Jl ZXMsCi0tIAoyLjM0LjEKCg== --------------gU70cuKBjpLigG1ljJnridtQ--
bug-gnu-emacs@HIDDEN:bug#22466; Package emacs.
Full text available.Mauro Aranda <maurooaranda@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 22466) by debbugs.gnu.org; 28 Jan 2016 03:37:44 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 27 22:37:44 2016 Received: from localhost ([127.0.0.1]:39062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1aOdOx-0005zJ-QU for submit <at> debbugs.gnu.org; Wed, 27 Jan 2016 22:37:43 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48567) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <eliz@HIDDEN>) id 1aOdOw-0005z7-EQ for 22466 <at> debbugs.gnu.org; Wed, 27 Jan 2016 22:37:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1aOdNh-0007AK-SP for 22466 <at> debbugs.gnu.org; Wed, 27 Jan 2016 22:37:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1aOdNh-0007AE-Kj; Wed, 27 Jan 2016 22:36:25 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2401 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1aOdNg-0007Dp-UL; Wed, 27 Jan 2016 22:36:25 -0500 Date: Thu, 28 Jan 2016 05:36:58 +0200 Message-Id: <83egd2z86d.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Artur Malabarba <bruce.connor.am@HIDDEN> In-reply-to: <87bn86ojtw.fsf@HIDDEN> (message from Artur Malabarba on Wed, 27 Jan 2016 20:20:43 +0000) Subject: Re: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash References: <87y4bcsogq.fsf@HIDDEN> <83powo1j71.fsf@HIDDEN> <87io2gns3b.fsf@HIDDEN> <831t9414it.fsf@HIDDEN> <87bn86ojtw.fsf@HIDDEN> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 22466 Cc: 22466 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: Eli Zaretskii <eliz@HIDDEN> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -5.0 (-----) > From: Artur Malabarba <bruce.connor.am@HIDDEN> > Cc: 22466 <at> debbugs.gnu.org > Date: Wed, 27 Jan 2016 20:20:43 +0000 > > > Then it would make sense to find a way of switching a theme without > > changing the frame's background color, if that's possible (i.e. if the > > new theme keeps the same background color). If there's a function > > missing for that, I'd suggest to add one. > > How about just running that form only when necessary (i.e., only if the > disabled theme actually sets the frame `background-color')? Yes, something like that. Or maybe add a new switch-theme API that receives both the old and a new theme, and changes the background color only if the new theme sets a different one.
bug-gnu-emacs@HIDDEN:bug#22466; Package emacs.
Full text available.Received: (at 22466) by debbugs.gnu.org; 27 Jan 2016 22:21:03 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 27 17:21:03 2016 Received: from localhost ([127.0.0.1]:38998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1aOYSV-0006xx-JD for submit <at> debbugs.gnu.org; Wed, 27 Jan 2016 17:21:03 -0500 Received: from mail-qg0-f42.google.com ([209.85.192.42]:34739) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <bruce.connor.am@HIDDEN>) id 1aOYSU-0006xA-C7 for 22466 <at> debbugs.gnu.org; Wed, 27 Jan 2016 17:21:02 -0500 Received: by mail-qg0-f42.google.com with SMTP id 6so19490728qgy.1 for <22466 <at> debbugs.gnu.org>; Wed, 27 Jan 2016 14:21:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=LvYV0T284pZBtSEEcYiRg2HupklylUSlVGRG2H0B81Q=; b=kP4KnLU7Y5bzYTLF6YaYvw0m+F53vir6g42hsNzxncejnH6lLAwbER3DxiXE6B0Plk e0pi3uoQGnwGfP4ombunXzZsuK189/QPUYV/godixe3XAEw+i3MPGwOZa7/r1LQl/xCt 4x6Wrmrd+4fyQ1qtFem2kGCR+otN1ZAZyhS2s4oEYWLCr9NYCcAVjjkDk9XLpgMzsal/ AKB7/18aKXkuXW1JVDbt6wg514fGTsvxQ/AHE3tZ+wv+SnDVM+nquGj+YWiRVxAxSHAJ xR2H3J3SYY8dJTGSnZ56i8pc+UKRob0z8Tpz7Pq8AEpB9dAHpKAeCLTOCG6tmOkE5/8R uMJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version:content-type; bh=LvYV0T284pZBtSEEcYiRg2HupklylUSlVGRG2H0B81Q=; b=YY2v1/FRTpLBdtkq0JWov5KafyDbUyUiPpC7e/APoeVUknffVLlXk2Ibi0JhupSF6j V7cXT7g/QmxwgSTm5PIGGjv7+eloITKhR9t0VnATvxBAkBlf4UOtYVgsRRSMqf/Jnk45 9zc56+snULkEANv0zt+58Pji4EOgfMjs9MSGbx9LeIZ6JJDxyJqkG057BG8WSjZfrTx7 Q3M4g+Hj2F+jV59HSE39d9cqU28JKWj1k1VD+DyedstD34+OkPgjnd74hBghaxmR68EA GgmTpp9RcVnR42lREBpVsQd4GF76mmVptslF68ChjRzNsaTMtQxtM6dsd6+nUn6EITwp 9I9w== X-Gm-Message-State: AG10YORzysf2s2eDZRztvcszrqbHUZC38zJSggMhdG447WxgXPnF+omEu3+XLXlBlcOLOg== X-Received: by 10.140.171.5 with SMTP id r5mr40730308qhr.51.1453933257031; Wed, 27 Jan 2016 14:20:57 -0800 (PST) Received: from Gandalf-Linux.gmail.com ([201.37.162.188]) by smtp.gmail.com with ESMTPSA id v70sm2557583qkl.15.2016.01.27.14.20.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Jan 2016 14:20:56 -0800 (PST) From: Artur Malabarba <bruce.connor.am@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash References: <87y4bcsogq.fsf@HIDDEN> <83powo1j71.fsf@HIDDEN> <87io2gns3b.fsf@HIDDEN> <831t9414it.fsf@HIDDEN> Date: Wed, 27 Jan 2016 20:20:43 +0000 In-Reply-To: <831t9414it.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 26 Jan 2016 22:15:22 +0200") Message-ID: <87bn86ojtw.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 22466 Cc: 22466 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.7 (/) Eli Zaretskii <eliz@HIDDEN> writes: > So disable-theme actually means go back to the default theme? If so, > when someone changes a theme, they don't really need to call > disable-theme, right? They could just call load-theme with the new > theme as an argument? I'm not sure why you reach this conclusion. `disable-theme' is meant to disable a single theme. If I have theme X enabled, then (disable-theme 'X) is supposed to restore the default Emacs appearance. If have two themes enabled (X and Y), then (disable-theme 'X) is supposed to give me just the appearance of theme Y. Right now, that's indeed what it does. But if I remove the form (as you asked) then it fails to do the above (it doesn't remove the background set by the disabled theme). > Then it would make sense to find a way of switching a theme without > changing the frame's background color, if that's possible (i.e. if the > new theme keeps the same background color). If there's a function > missing for that, I'd suggest to add one. How about just running that form only when necessary (i.e., only if the disabled theme actually sets the frame `background-color')?
bug-gnu-emacs@HIDDEN:bug#22466; Package emacs.
Full text available.Received: (at 22466) by debbugs.gnu.org; 26 Jan 2016 23:03:10 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 26 18:03:10 2016 Received: from localhost ([127.0.0.1]:37966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1aOCdh-0003in-Tn for submit <at> debbugs.gnu.org; Tue, 26 Jan 2016 18:03:10 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:19584) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <drew.adams@HIDDEN>) id 1aOCdg-0003ia-GO for 22466 <at> debbugs.gnu.org; Tue, 26 Jan 2016 18:03:08 -0500 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u0QN32br027364 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 26 Jan 2016 23:03:02 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u0QN2xAW022512 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 26 Jan 2016 23:03:01 GMT Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id u0QN2xT5005475; Tue, 26 Jan 2016 23:02:59 GMT MIME-Version: 1.0 Message-ID: <0af8586e-9886-4684-9a4d-8d82b99f8f8e@default> Date: Tue, 26 Jan 2016 15:02:57 -0800 (PST) From: Drew Adams <drew.adams@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN>, Michael Albinus <michael.albinus@HIDDEN> Subject: RE: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash References: <<87y4bcsogq.fsf@HIDDEN>> <<83powo1j71.fsf@HIDDEN> <1bbf7218-bd5b-4618-822c-cd75884a81ee@default> <83d1so1df3.fsf@HIDDEN>> <<87y4bc89pt.fsf@HIDDEN>> <<834me01881.fsf@HIDDEN>> In-Reply-To: <<834me01881.fsf@HIDDEN>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0021.oracle.com [156.151.31.71] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 22466 Cc: 22466 <at> debbugs.gnu.org, bruce.connor.am@HIDDEN, drew.adams@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) > > On my todo list there is also writing tramp-theme.el. Something, which > > makes it obvious that you are editing a remote file, or not. Even more > > important: you are editing a file as root, or not. > > > > This could fall into the category of enabling-disabling the theme more > > often than just at the start of your session. >=20 > I hope that theme won't change my frame's background color ;-) I heard that Michael is working on a special background color that will take effect only when the user is Eli Zaretskii.
bug-gnu-emacs@HIDDEN:bug#22466; Package emacs.
Full text available.Received: (at 22466) by debbugs.gnu.org; 26 Jan 2016 20:15:03 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 26 15:15:03 2016 Received: from localhost ([127.0.0.1]:37937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1aOA11-00082L-CU for submit <at> debbugs.gnu.org; Tue, 26 Jan 2016 15:15:03 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60652) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <eliz@HIDDEN>) id 1aOA10-00081c-2J for 22466 <at> debbugs.gnu.org; Tue, 26 Jan 2016 15:15:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1aOA0r-0007Dv-My for 22466 <at> debbugs.gnu.org; Tue, 26 Jan 2016 15:14:56 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42907) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1aOA0r-0007Dn-J9; Tue, 26 Jan 2016 15:14:53 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1591 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1aOA0q-0002HB-SS; Tue, 26 Jan 2016 15:14:53 -0500 Date: Tue, 26 Jan 2016 22:15:22 +0200 Message-Id: <831t9414it.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Artur Malabarba <bruce.connor.am@HIDDEN> In-reply-to: <87io2gns3b.fsf@HIDDEN> (message from Artur Malabarba on Tue, 26 Jan 2016 17:25:36 +0000) Subject: Re: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash References: <87y4bcsogq.fsf@HIDDEN> <83powo1j71.fsf@HIDDEN> <87io2gns3b.fsf@HIDDEN> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 22466 Cc: 22466 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: Eli Zaretskii <eliz@HIDDEN> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -5.0 (-----) > From: Artur Malabarba <bruce.connor.am@HIDDEN> > Cc: 22466 <at> debbugs.gnu.org > Date: Tue, 26 Jan 2016 17:25:36 +0000 > > >> (set-frame-parameter frame 'background-color > >> (custom--frame-color-default > >> frame :background "background" "Background" > >> "unspecified-bg" "white")) > >> > >> I'm not saying this form is wrong. I'm just pointing to where it happens. > > > > What happens if you remove that from disable-theme? > > Then there's no flashing, but then if I simply disable the theme > (without enabling a new one) I'm left with theme's background. So disable-theme actually means go back to the default theme? If so, when someone changes a theme, they don't really need to call disable-theme, right? They could just call load-theme with the new theme as an argument? > I never change my main color theme, but I always have a second theme > enabled that only affects the mode-line. This second theme is changed > occasionally and it always causes a flash (even though the theme has > nothing to do with the background). > > Besides, custom themes are not just for faces. This also came up because > someone is writing a package that simultaneously toggles between > different values for a set of variables (called a context) using > custom-themes. That's something that's designed to be used a couple > times a day. Then it would make sense to find a way of switching a theme without changing the frame's background color, if that's possible (i.e. if the new theme keeps the same background color). If there's a function missing for that, I'd suggest to add one.
bug-gnu-emacs@HIDDEN:bug#22466; Package emacs.
Full text available.Received: (at 22466) by debbugs.gnu.org; 26 Jan 2016 19:55:45 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 26 14:55:45 2016 Received: from localhost ([127.0.0.1]:37933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1aO9iK-0007Yr-PL for submit <at> debbugs.gnu.org; Tue, 26 Jan 2016 14:55:44 -0500 Received: from mail-qg0-f52.google.com ([209.85.192.52]:36709) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <bruce.connor.am@HIDDEN>) id 1aO9iJ-0007Ye-Oh for 22466 <at> debbugs.gnu.org; Tue, 26 Jan 2016 14:55:44 -0500 Received: by mail-qg0-f52.google.com with SMTP id e32so149169257qgf.3 for <22466 <at> debbugs.gnu.org>; Tue, 26 Jan 2016 11:55:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:references:message-id:mime-version :content-type; bh=0gKk7pHqt3LV2fHaDwi/iRIu2O39avqVNMwLGGxzYco=; b=ZJNQS4z5dvCws5gzvQsVk4SHDOh8NhshK8g/oEiuPTu6pHJ3Q8N2adMRVsRbffDl9K HuGWSjXuC13woV6swCQcIxO4rpSrn3nEuvPfxtpLers7eSnCd1TUAN6TCVb3rFHtAaxc iHHM65priTq4YjXWaC3Py0Nsz+aSBnd664xWfbBRbjK5Sv5WpSo2mrIF0dt/BaeSiOYu 1QN1wP9UdIbjfgEK02RqlmtT/jab9ZvLz2tQTmWSQpRIozauaqI5R5RdhpX5Bu0ZBmWU 4a/IVQVOLfHYcDpNKUjKctFpegh9b4hkW2BH7lO3uzfD62QUQev+OcC4pkCV5D7TzAJH OACw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:references :message-id:mime-version:content-type; bh=0gKk7pHqt3LV2fHaDwi/iRIu2O39avqVNMwLGGxzYco=; b=UQ/4kJ+U89bH1BYeV9yuAz/9p6ONsdpiyHC0UP0i4NMaHRQo0rOquJ/QTkvPd/gUW9 uJ3qs8Ocg99g/T/nUusx3Zrp1uTYWwL/F+KsMZCmpYYl1cRhZnyuGlp4NZ+AVDhXNQgK yGQ+KuVrWOOMDrk/27f0RuRm8LL1UygEIg0Xb16iAJqPhE7tBTKeNJKA0GrHJJs770wf RWxozDoFraiGmvfWhfO8/NH0JCbL8tJjzZwYfVxB5hP523pCr/ShJhMsZAnsWgQeNkjG u/sNhePwKkGWv0xj9qF6CdSFCRGUqHwLl0K6uTJgjn67IDDzZDTBcD4w0OAsc5FD+lVU t+jA== X-Gm-Message-State: AG10YOQI185jxrj3So4NkTcuzxvQvypABXiYHesfRP6cXLdzfh+vXW6+Lw5keNm3+CAAtA== X-Received: by 10.140.42.139 with SMTP id c11mr30768626qga.5.1453838138143; Tue, 26 Jan 2016 11:55:38 -0800 (PST) Received: from Gandalf-Linux.gmail.com ([201.37.162.188]) by smtp.gmail.com with ESMTPSA id h99sm1145544qge.7.2016.01.26.11.55.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Jan 2016 11:55:37 -0800 (PST) From: Artur Malabarba <bruce.connor.am@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash Date: Tue, 26 Jan 2016 17:25:36 +0000 References: <87y4bcsogq.fsf@HIDDEN> <83powo1j71.fsf@HIDDEN> Message-ID: <87io2gns3b.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 22466 Cc: 22466 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.7 (/) Eli Zaretskii <eliz@HIDDEN> writes: > It's not redisplay that does this. It's the fact that disable-theme > changes the frame's background color, and when that happens, we > immediately clear the frame using the new background color, as part of > the modify-frame-parameters call. > > Redisplay only handles the portions of display where there's text and > other decorations that we manage. Clearing the frame with the new > background color is not redisplay's job. Thanks, that's good to know. >> (set-frame-parameter frame 'background-color >> (custom--frame-color-default >> frame :background "background" "Background" >> "unspecified-bg" "white")) >> >> I'm not saying this form is wrong. I'm just pointing to where it happens. > > What happens if you remove that from disable-theme? Then there's no flashing, but then if I simply disable the theme (without enabling a new one) I'm left with theme's background. > (I don't really understand why it has to specify "white".) I guess it's meant to reset the face to the default. Although, I don't see why this is explicitly necessary for the default background/foreground colors, but isn't necessary for other faces. > Anyway, how come you get to doing this so often it hurts your eyes? > Aren't people setting their beloved theme once when the session > starts, and then never change it? I never change my main color theme, but I always have a second theme enabled that only affects the mode-line. This second theme is changed occasionally and it always causes a flash (even though the theme has nothing to do with the background). Besides, custom themes are not just for faces. This also came up because someone is writing a package that simultaneously toggles between different values for a set of variables (called a context) using custom-themes. That's something that's designed to be used a couple times a day. Anyway, it's not a huge defficiency and it's not worth any large efforts. I brought it up because I thought there was an eager redisplay happening somewhere and that might point to a deeper bug, but you've clearly explained that's not the case. :-)
bug-gnu-emacs@HIDDEN:bug#22466; Package emacs.
Full text available.Received: (at 22466) by debbugs.gnu.org; 26 Jan 2016 19:31:25 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 26 14:31:25 2016 Received: from localhost ([127.0.0.1]:37927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1aO9Km-0006zO-QZ for submit <at> debbugs.gnu.org; Tue, 26 Jan 2016 14:31:24 -0500 Received: from mout.gmx.net ([212.227.15.15]:49646) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <michael.albinus@HIDDEN>) id 1aO9Kl-0006zB-Fx for 22466 <at> debbugs.gnu.org; Tue, 26 Jan 2016 14:31:23 -0500 Received: from detlef.gmx.de ([79.195.30.160]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0Me8di-1ake2J16Q2-00Pv63; Tue, 26 Jan 2016 20:31:13 +0100 From: Michael Albinus <michael.albinus@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash References: <87y4bcsogq.fsf@HIDDEN> <83powo1j71.fsf@HIDDEN> <1bbf7218-bd5b-4618-822c-cd75884a81ee@default> <83d1so1df3.fsf@HIDDEN> <87y4bc89pt.fsf@HIDDEN> <834me01881.fsf@HIDDEN> Date: Tue, 26 Jan 2016 20:31:10 +0100 In-Reply-To: <834me01881.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 26 Jan 2016 20:55:26 +0200") Message-ID: <87twm087ep.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:7EbELqDjChnG4xHcecq8K8kWugAZsMr1jZno4Sv5wF9O8OHnOXf v7vVVQPw2vd+SvgYxmm6jAJ12W8T4ssTJvthw2qpWjazE66pAlzh8w3aFmoiHC1TngjjS90 dNp0OgdSbuIMyYclYeKY8Z6B+XG+KDuA2k7DWdHypU+dY1F29BMsvH/KLJterduTgsirGlV wcUztSofSqocuESpVbh/Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:hyLFLIad4nw=:UJNkTUQ/s0MbDF2Z6ObSWL WTD+wygwgGvVhfpOjaVmFTpt5HCwOqB3tXynxYmEHuhbYjwRxy1T42qyQxQsaOHTftMLRWWaj +VxOarPPJlX7ePSu0OH9GxRQBjefN2YmdXD+IYRE1l/NQpUj1DWZn7hn8w94K0OIh/A6Uvlkz U4HNO9HPr6vlHp0MVvGyCYMo0AjT//n/Vp0i3HlqmLZqPlF4HEpzrUpo7p59SnufVsIRr4os7 GEs5Ksm1daSDrg9HOv9RjpUxSfdpzsARn6aKq9YmAUpv5LEIWqaJef7OhiSnNnEaXz9Dv0dPX NGj53v+R3y2SS7F4fByP4W6+XFdaKnjAL1rUaRI9IsYXEoo7FPsFNkz2x0kqlKt6NZxsM8Ti2 JoLDHr9nMvPXNuDtG+mimX460/9327GL+2BlQVvKLcMGpLAkPj0EgGGY/laIMxCdkJ5fhMui+ LIvyFzFezyCMmZxIjB0OxRE2xG4GJThQZfu/b8tA0DfziaVXS4kfRJzpzqJ/z4a0UPhZLRc/X GQWZI8YOsFDsf/hu3TWt38IpOsAXtoKMullZRqznEZsIKlFBjsXSZU/fP2nSfrlZTnqRZuV48 jQdtyWqjII/Fky1hGh8yx74ZxcfrCoBWVNX3rCeSLNIa0AD9EbLkt66AhntlkX/HEzaxiAOSp 2/LXSnRUjzyGqguHfSBv0/TzMHAp9Bt6nEnxPBE+yhEmoqTqE+TFTSgvhSrbUVwAHOvR/BQhP 34gesJaEKveNhxOo2c70fFsi9nVqiclTkiOv4HKPKVWmYRkcozWMhouHlVxBWZNkB2DE55rYe cs5hvX6 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 22466 Cc: 22466 <at> debbugs.gnu.org, bruce.connor.am@HIDDEN, drew.adams@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.7 (/) Eli Zaretskii <eliz@HIDDEN> writes: > I hope that theme won't change my frame's background color ;-) Don't know yet. What about blinking alarm red, in case you are root? :-) The screen flash, as discussed in this bug, would be a feature then. Another option would be white foreground / white background. For security reasons. :-) Hmm. Maybe I let you customize it yourself ... Best regards, Michael.
bug-gnu-emacs@HIDDEN:bug#22466; Package emacs.
Full text available.Received: (at 22466) by debbugs.gnu.org; 26 Jan 2016 18:55:10 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 26 13:55:10 2016 Received: from localhost ([127.0.0.1]:37918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1aO8li-00065e-KB for submit <at> debbugs.gnu.org; Tue, 26 Jan 2016 13:55:10 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40438) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <eliz@HIDDEN>) id 1aO8lg-00065S-1B for 22466 <at> debbugs.gnu.org; Tue, 26 Jan 2016 13:55:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1aO8la-0003pf-C2 for 22466 <at> debbugs.gnu.org; Tue, 26 Jan 2016 13:55:03 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41762) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1aO8lX-0003oj-4D; Tue, 26 Jan 2016 13:54:59 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1499 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1aO8lW-0003Go-8M; Tue, 26 Jan 2016 13:54:58 -0500 Date: Tue, 26 Jan 2016 20:55:26 +0200 Message-Id: <834me01881.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Michael Albinus <michael.albinus@HIDDEN> In-reply-to: <87y4bc89pt.fsf@HIDDEN> (message from Michael Albinus on Tue, 26 Jan 2016 19:41:18 +0100) Subject: Re: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash References: <87y4bcsogq.fsf@HIDDEN> <83powo1j71.fsf@HIDDEN> <1bbf7218-bd5b-4618-822c-cd75884a81ee@default> <83d1so1df3.fsf@HIDDEN> <87y4bc89pt.fsf@HIDDEN> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 22466 Cc: 22466 <at> debbugs.gnu.org, bruce.connor.am@HIDDEN, drew.adams@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: Eli Zaretskii <eliz@HIDDEN> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -5.0 (-----) > From: Michael Albinus <michael.albinus@HIDDEN> > Cc: Drew Adams <drew.adams@HIDDEN>, 22466 <at> debbugs.gnu.org, bruce.connor.am@HIDDEN > Date: Tue, 26 Jan 2016 19:41:18 +0100 > > On my todo list there is also writing tramp-theme.el. Something, which > makes it obvious that you are editing a remote file, or not. Even more > important: you are editing a file as root, or not. > > This could fall into the category of enabling-disabling the theme more > often than just at the start of your session. I hope that theme won't change my frame's background color ;-)
bug-gnu-emacs@HIDDEN:bug#22466; Package emacs.
Full text available.Received: (at 22466) by debbugs.gnu.org; 26 Jan 2016 18:41:32 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 26 13:41:32 2016 Received: from localhost ([127.0.0.1]:37897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1aO8YW-0005jo-Er for submit <at> debbugs.gnu.org; Tue, 26 Jan 2016 13:41:32 -0500 Received: from mout.gmx.net ([212.227.17.21]:53691) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <michael.albinus@HIDDEN>) id 1aO8YV-0005jb-79 for 22466 <at> debbugs.gnu.org; Tue, 26 Jan 2016 13:41:31 -0500 Received: from detlef.gmx.de ([79.195.30.160]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0MZOan-1agcCo4B13-00LGwy; Tue, 26 Jan 2016 19:41:20 +0100 From: Michael Albinus <michael.albinus@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash References: <87y4bcsogq.fsf@HIDDEN> <83powo1j71.fsf@HIDDEN> <1bbf7218-bd5b-4618-822c-cd75884a81ee@default> <83d1so1df3.fsf@HIDDEN> Date: Tue, 26 Jan 2016 19:41:18 +0100 In-Reply-To: <83d1so1df3.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 26 Jan 2016 19:03:12 +0200") Message-ID: <87y4bc89pt.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:XtAXB/enZmAX5cCejQML6ifLuU7dKEX8vHuI+dEqo//6caeTYhh jBXL9hX5KBNHGKALxAdPqdqd3u0Zk/2LxHI2BXyg1XUS4gvJJCP3hlRQB2nVYYTybHTiSJX xBl+0ROrlP4ooQagH0R/mJaFYWs0ou1Lfl40Q5gE1GvhI+nMTGDl7jJytuDBlFTVW5zKNiG nVZYkmN4ocs0JUnhwCZrA== X-UI-Out-Filterresults: notjunk:1;V01:K0:vIl/ryvjgHU=:mFLPkjR3BSc18tuL+em/wU hMKxIQfK9DpEe/fbPTZHFYKb/uMpsv2d6f8mkscvx80qDbCcactpLktghM+3/olktBinOYHSF FVejtcdxwD9GjfC1Sf92VVV36Nu4QRkmWVvgoPKZOm9i7Aa4046SoBrv4uujk76nTg8dLo09B fC+Isy8TQiuzkWdeAhknaHbrKx9ShVCGnJDPQT+yxBY1XDb17FdOeiqK9nPMKRfQRfwED41nD r0/m++YZ2JUJIYykKBYyPS2ts8XfZWkwe4Y8DoKT5grqc/gflJlKLotfHpwmc+SCUgxzoe8Bz qauk8a1oeN2/I2e4mXxImID8JkcTJB6v+GAWGpKoLNoZ6hD4YADY+pbvrwTNMEKIbKeBpIcgm RXJ7r9hK+rWbIp67C33loRsf+pPIDu1Ew0qR4sM/U1u1ND3wdF43vNEiu8korL5cthOTZxk3K fLOoYD67E7ysEJhrUP7jrIdsJ+6GFtc7NnftcSzMacAiIaq7sfyi7+kzfjiqJhd0aECQ0L10E oRGyq8TIvZ9hgm90k+Ah6EjwxL+ECvv/fDCy57uFv2DlRoIVWUDg9XN0ybqVZK2/tEjRg7dRx UqA66QU/DwJjiH7UFl6mnDe7cd3UMFcsu79Z0oU4jvEo/T03LIlcU+3VwviPzMK5v5k0M1lJE yRFLMPwn8Iab+2OCOCmbleyZzYQVRf47fIxOnLCHjnsjkbSZchDV4Vk5e2AQXzyz7IRuAFLFU 8p4J1T3ayY4DfQcc/LOIm7ddQvFWXqB1YGXDfmBzkcooLzF22VAEgKLVEwAxCsJK1mZvQXyYT yJ/GYGs X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 22466 Cc: 22466 <at> debbugs.gnu.org, bruce.connor.am@HIDDEN, Drew Adams <drew.adams@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.7 (/) Eli Zaretskii <eliz@HIDDEN> writes: >> Date: Tue, 26 Jan 2016 08:36:56 -0800 (PST) >> From: Drew Adams <drew.adams@HIDDEN> >> Cc: 22466 <at> debbugs.gnu.org >> >> > Anyway, how come you get to doing this so often it hurts your eyes? >> > Aren't people setting their beloved theme once when the session >> > starts, and then never change it? >> >> I can't speak for the OP, but no, users can well want to cycle >> through a set of themes before choosing one. > > Yes, once. Until they choose that one. On my todo list there is also writing tramp-theme.el. Something, which makes it obvious that you are editing a remote file, or not. Even more important: you are editing a file as root, or not. This could fall into the category of enabling-disabling the theme more often than just at the start of your session. Best regards, Michael.
bug-gnu-emacs@HIDDEN:bug#22466; Package emacs.
Full text available.Received: (at 22466) by debbugs.gnu.org; 26 Jan 2016 17:07:26 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 26 12:07:26 2016 Received: from localhost ([127.0.0.1]:37860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1aO75S-0003P3-EX for submit <at> debbugs.gnu.org; Tue, 26 Jan 2016 12:07:26 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:34081) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <drew.adams@HIDDEN>) id 1aO75R-0003Oq-6O for 22466 <at> debbugs.gnu.org; Tue, 26 Jan 2016 12:07:25 -0500 Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u0QH7Im8007862 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 26 Jan 2016 17:07:19 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u0QH7Ipp010175 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 26 Jan 2016 17:07:18 GMT Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id u0QH7Is9014156; Tue, 26 Jan 2016 17:07:18 GMT MIME-Version: 1.0 Message-ID: <36e71def-75ba-4cb6-be82-2546d21403d7@default> Date: Tue, 26 Jan 2016 09:07:17 -0800 (PST) From: Drew Adams <drew.adams@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: RE: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash References: <<87y4bcsogq.fsf@HIDDEN>> <<83powo1j71.fsf@HIDDEN>> <<1bbf7218-bd5b-4618-822c-cd75884a81ee@default>> <<83d1so1df3.fsf@HIDDEN>> In-Reply-To: <<83d1so1df3.fsf@HIDDEN>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 22466 Cc: 22466 <at> debbugs.gnu.org, bruce.connor.am@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) > > > Anyway, how come you get to doing this so often it hurts your eyes? > > > Aren't people setting their beloved theme once when the session > > > starts, and then never change it? > > > > I can't speak for the OP, but no, users can well want to cycle > > through a set of themes before choosing one. >=20 > Yes, once. Until they choose that one. But they might do this over and over, in different contexts. Anyway, I've made the point. Up to you whether it matters.
bug-gnu-emacs@HIDDEN:bug#22466; Package emacs.
Full text available.Received: (at 22466) by debbugs.gnu.org; 26 Jan 2016 17:02:58 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 26 12:02:58 2016 Received: from localhost ([127.0.0.1]:37856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1aO717-0003IO-S6 for submit <at> debbugs.gnu.org; Tue, 26 Jan 2016 12:02:58 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60055) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <eliz@HIDDEN>) id 1aO715-0003IA-J0 for 22466 <at> debbugs.gnu.org; Tue, 26 Jan 2016 12:02:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1aO70v-0001Ct-Sj for 22466 <at> debbugs.gnu.org; Tue, 26 Jan 2016 12:02:50 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39688) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1aO70v-0001Cp-PT; Tue, 26 Jan 2016 12:02:45 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1424 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1aO70u-0000NF-6a; Tue, 26 Jan 2016 12:02:44 -0500 Date: Tue, 26 Jan 2016 19:03:12 +0200 Message-Id: <83d1so1df3.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Drew Adams <drew.adams@HIDDEN> In-reply-to: <1bbf7218-bd5b-4618-822c-cd75884a81ee@default> (message from Drew Adams on Tue, 26 Jan 2016 08:36:56 -0800 (PST)) Subject: Re: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash References: <87y4bcsogq.fsf@HIDDEN> <83powo1j71.fsf@HIDDEN> <1bbf7218-bd5b-4618-822c-cd75884a81ee@default> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 22466 Cc: 22466 <at> debbugs.gnu.org, bruce.connor.am@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: Eli Zaretskii <eliz@HIDDEN> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -5.0 (-----) > Date: Tue, 26 Jan 2016 08:36:56 -0800 (PST) > From: Drew Adams <drew.adams@HIDDEN> > Cc: 22466 <at> debbugs.gnu.org > > > Anyway, how come you get to doing this so often it hurts your eyes? > > Aren't people setting their beloved theme once when the session > > starts, and then never change it? > > I can't speak for the OP, but no, users can well want to cycle > through a set of themes before choosing one. Yes, once. Until they choose that one.
bug-gnu-emacs@HIDDEN:bug#22466; Package emacs.
Full text available.Received: (at 22466) by debbugs.gnu.org; 26 Jan 2016 16:37:06 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 26 11:37:06 2016 Received: from localhost ([127.0.0.1]:37844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1aO6c6-0002gs-9f for submit <at> debbugs.gnu.org; Tue, 26 Jan 2016 11:37:06 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:35414) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <drew.adams@HIDDEN>) id 1aO6c4-0002gO-Jc for 22466 <at> debbugs.gnu.org; Tue, 26 Jan 2016 11:37:04 -0500 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u0QGawWb031605 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Jan 2016 16:36:58 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.13.8) with ESMTP id u0QGavJN001459 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 26 Jan 2016 16:36:58 GMT Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u0QGav1x020556; Tue, 26 Jan 2016 16:36:57 GMT MIME-Version: 1.0 Message-ID: <1bbf7218-bd5b-4618-822c-cd75884a81ee@default> Date: Tue, 26 Jan 2016 08:36:56 -0800 (PST) From: Drew Adams <drew.adams@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN>, Artur Malabarba <bruce.connor.am@HIDDEN> Subject: RE: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash References: <87y4bcsogq.fsf@HIDDEN> <83powo1j71.fsf@HIDDEN> In-Reply-To: <83powo1j71.fsf@HIDDEN> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0022.oracle.com [156.151.31.74] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 22466 Cc: 22466 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) > Anyway, how come you get to doing this so often it hurts your eyes? > Aren't people setting their beloved theme once when the session > starts, and then never change it? I can't speak for the OP, but no, users can well want to cycle through a set of themes before choosing one.
bug-gnu-emacs@HIDDEN:bug#22466; Package emacs.
Full text available.Received: (at 22466) by debbugs.gnu.org; 26 Jan 2016 14:58:22 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 26 09:58:22 2016 Received: from localhost ([127.0.0.1]:37765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1aO54Y-0000Fz-79 for submit <at> debbugs.gnu.org; Tue, 26 Jan 2016 09:58:22 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37430) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from <eliz@HIDDEN>) id 1aO54X-0000Fn-4h for 22466 <at> debbugs.gnu.org; Tue, 26 Jan 2016 09:58:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1aO54B-0001uh-VK for 22466 <at> debbugs.gnu.org; Tue, 26 Jan 2016 09:58:15 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37573) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>) id 1aO54B-0001ua-Ro; Tue, 26 Jan 2016 09:57:59 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1334 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1aO54A-00018J-Fw; Tue, 26 Jan 2016 09:57:59 -0500 Date: Tue, 26 Jan 2016 16:58:26 +0200 Message-Id: <83powo1j71.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Artur Malabarba <bruce.connor.am@HIDDEN> In-reply-to: <87y4bcsogq.fsf@HIDDEN> (message from Artur Malabarba on Tue, 26 Jan 2016 09:02:29 +0000) Subject: Re: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash References: <87y4bcsogq.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 22466 Cc: 22466 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: Eli Zaretskii <eliz@HIDDEN> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -5.0 (-----) > From: Artur Malabarba <bruce.connor.am@HIDDEN> > Date: Tue, 26 Jan 2016 09:02:29 +0000 > > > 1. From “emacs -Q” evaluate `(load-theme 'tango-dark)'. Any other theme > with a dark background will also do. > > 2. Then, notice how every time you evaluate the following code, the > screen flashes white for a moment, and then resumes the exact same > appearance. > > (progn (disable-theme 'tango-dark) > (load-theme 'tango-dark)) > > Of course, “resuming the same appearance” is expected, the problem is > that the white flash is distracting, unnecessary, and eye-hurting. > > I understand _why_ it happens (after `disable-theme' the background is > actually white), but I don't see why it _has_ to happen. That is, why > does Emacs redisplay the frame in the middle of lisp evaluation, instead > of waiting until the end of the command loop? It's not redisplay that does this. It's the fact that disable-theme changes the frame's background color, and when that happens, we immediately clear the frame using the new background color, as part of the modify-frame-parameters call. Redisplay only handles the portions of display where there's text and other decorations that we manage. Clearing the frame with the new background color is not redisplay's job. > More importantly, is this redisplay (or “partial redisplay”, or whatever > it is) be avoided, so Emacs doesn't flash white on my pretty little eyes? > > ----- > > ps: In case it helps, investigation shows that this is caused by this > form inside `disable-theme': > > (set-frame-parameter frame 'background-color > (custom--frame-color-default > frame :background "background" "Background" > "unspecified-bg" "white")) > > I'm not saying this form is wrong. I'm just pointing to where it happens. What happens if you remove that from disable-theme? (I don't really understand why it has to specify "white".) Anyway, how come you get to doing this so often it hurts your eyes? Aren't people setting their beloved theme once when the session starts, and then never change it?
bug-gnu-emacs@HIDDEN:bug#22466; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 26 Jan 2016 11:03:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 26 06:03:02 2016
Received: from localhost ([127.0.0.1]:36626 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1aO1On-0001Hw-P6
for submit <at> debbugs.gnu.org; Tue, 26 Jan 2016 06:03:02 -0500
Received: from eggs.gnu.org ([208.118.235.92]:56690)
by debbugs.gnu.org with esmtp (Exim 4.84)
(envelope-from <bruce.connor.am@HIDDEN>) id 1aO1Ol-0001Hk-QK
for submit <at> debbugs.gnu.org; Tue, 26 Jan 2016 06:03:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <bruce.connor.am@HIDDEN>) id 1aO1Of-0004ER-SW
for submit <at> debbugs.gnu.org; Tue, 26 Jan 2016 06:02:54 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level:
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM,
T_DKIM_INVALID autolearn=disabled version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:59398)
by eggs.gnu.org with esmtp (Exim 4.71)
(envelope-from <bruce.connor.am@HIDDEN>) id 1aO1Of-0004EN-Q3
for submit <at> debbugs.gnu.org; Tue, 26 Jan 2016 06:02:53 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47647)
by lists.gnu.org with esmtp (Exim 4.71)
(envelope-from <bruce.connor.am@HIDDEN>) id 1aO1Oe-0007tq-Qo
for bug-gnu-emacs@HIDDEN; Tue, 26 Jan 2016 06:02:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <bruce.connor.am@HIDDEN>) id 1aO1OZ-0004Dd-RJ
for bug-gnu-emacs@HIDDEN; Tue, 26 Jan 2016 06:02:52 -0500
Received: from mail-qg0-x22e.google.com ([2607:f8b0:400d:c04::22e]:36790)
by eggs.gnu.org with esmtp (Exim 4.71)
(envelope-from <bruce.connor.am@HIDDEN>) id 1aO1OZ-0004DY-Mi
for bug-gnu-emacs@HIDDEN; Tue, 26 Jan 2016 06:02:47 -0500
Received: by mail-qg0-x22e.google.com with SMTP id e32so134568454qgf.3
for <bug-gnu-emacs@HIDDEN>; Tue, 26 Jan 2016 03:02:47 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
h=sender:from:to:subject:date:message-id:mime-version:content-type
:content-transfer-encoding;
bh=m4LNZuqWcRY3tUQJIVdPaGCgvZaiTPV1zR3Ar1/i/aA=;
b=o8t3jEDV0S2ilIZkP5sfDsbdUFHcV8LF9ph6xu27dzL0NAos0n9phtKFgyk1FMRlYk
T9+ZlNhQVu9SlxfuIK9TpvhPjIzzDDRCACez6kYJagAhaDOmq+VrVrh0SIyoA136j9xA
5P5yqfnfzPClF1GLzQvCd4GoAbJFdWlDqjfmrmldQg22evINO+L8QS+joLrdxtRLWYho
hwKSzchD2mVmYW7SlMXd3Ie0FpoLkC5f/C4TfUCPfhspLKFflLkUre1jSzB1+UrYrLdX
Feb7vFcVqmak7ntagVIj7Cr5WMjfshb09pbD5J50ooUYzLJl7CVafoqZQ7xp5tzpT7jD
YcZA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:sender:from:to:subject:date:message-id
:mime-version:content-type:content-transfer-encoding;
bh=m4LNZuqWcRY3tUQJIVdPaGCgvZaiTPV1zR3Ar1/i/aA=;
b=M8g/CpUHI46AbQTcI/40D5/yrLBGYLrHuPbyD2Zr/Ts/oVs6XagxbLYJtbKw84q2CH
k1qOKa/Y9ZQYQENC8IgOJ1Am8gSJpG7ifDptvBzjxcxSGHI2ShUpEViV5Ez5TXbxdUmO
iQ7jrLORDd4wtFi6s5inR3+jbTPphd6IzcyWY9bjRj+lMI8D2xVQYze3urgtempspgpV
5gRrKyPoIzW8SvMvoscLwbbTCKl2w8pkNwV9pLQPpG84gJW2z4PII7ddEIRoShxihFdD
ATfesajeuYTa0U6WG+B9nv+YD2aZbbx+TbT5pDpIy3R3ECXpzCoBAbco05RifYpChB5J
DclA==
X-Gm-Message-State: AG10YOSuHoDjRwLbivmV3YnwFpx19iBAT8vUFRlNhMZJcN3LK0P1JQakGYu45vQk8aXotQ==
X-Received: by 10.55.81.3 with SMTP id f3mr27646822qkb.35.1453806167031;
Tue, 26 Jan 2016 03:02:47 -0800 (PST)
Received: from Gandalf-Linux.gmail.com ([201.37.162.188])
by smtp.gmail.com with ESMTPSA id t187sm267684qht.39.2016.01.26.03.02.45
for <bug-gnu-emacs@HIDDEN>
(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Tue, 26 Jan 2016 03:02:46 -0800 (PST)
From: Artur Malabarba <bruce.connor.am@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 25.0.50;
disable-theme apparently forces a redisplay and causes a screen flash
Date: Tue, 26 Jan 2016 09:02:29 +0000
Message-ID: <87y4bcsogq.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.0 (----)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -4.0 (----)
1. From =E2=80=9Cemacs -Q=E2=80=9D evaluate `(load-theme 'tango-dark)'. Any=
other theme
with a dark background will also do.
2. Then, notice how every time you evaluate the following code, the
screen flashes white for a moment, and then resumes the exact same
appearance.
(progn (disable-theme 'tango-dark)
(load-theme 'tango-dark))
Of course, =E2=80=9Cresuming the same appearance=E2=80=9D is expected, the =
problem is
that the white flash is distracting, unnecessary, and eye-hurting.
I understand _why_ it happens (after `disable-theme' the background is
actually white), but I don't see why it _has_ to happen. That is, why
does Emacs redisplay the frame in the middle of lisp evaluation, instead
of waiting until the end of the command loop?
More importantly, is this redisplay (or =E2=80=9Cpartial redisplay=E2=80=9D=
, or whatever
it is) be avoided, so Emacs doesn't flash white on my pretty little eyes?
-----
ps: In case it helps, investigation shows that this is caused by this
form inside `disable-theme':
(set-frame-parameter frame 'background-color
(custom--frame-color-default
frame :background "background" "Background"
"unspecified-bg" "white"))
I'm not saying this form is wrong. I'm just pointing to where it happens.
Artur Malabarba <bruce.connor.am@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#22466; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.