GNU logs - #32501, boring messages

Message sent to bug-guile@HIDDEN:

Subject: bug#32501: Bouncing parentheses broken in REPL with vi-mode enabled
Resent-From: Daniel Tam <danooo.tam@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guile@HIDDEN
Resent-Date: Wed, 22 Aug 2018 17:07:02 +0000
Resent-Message-ID: <handler.32501.B.153495761528158 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 32501 <at> debbugs.gnu.org
From: Daniel Tam <danooo.tam@HIDDEN>
Message-ID: <0290e793-0acc-31ed-1d7e-61ed65b9bcf2@HIDDEN>
Date: Thu, 23 Aug 2018 01:47:39 +1000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi,


I've activated readline support for the Guile repl, but I've found that
if my inputrc enables vi-mode, then the bouncing parentheses feature
doesn't work. Disabling vi-mode does the trick.


Cheers,

Dan

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Daniel Tam <danooo.tam@HIDDEN>
Subject: bug#32501: Acknowledgement (Bouncing parentheses broken in REPL
 with vi-mode enabled)
Message-ID: <handler.32501.B.153495761528158.ack <at> debbugs.gnu.org>
References: <0290e793-0acc-31ed-1d7e-61ed65b9bcf2@HIDDEN>
X-Gnu-PR-Message: ack 32501
X-Gnu-PR-Package: guile
Reply-To: 32501 <at> debbugs.gnu.org
Date: Wed, 22 Aug 2018 17:07:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-guile@HIDDEN

If you wish to submit further information on this problem, please
send it to 32501 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
32501: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D32501
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-guile@HIDDEN:

Subject: bug#32501: Bouncing parentheses broken in REPL with vi-mode enabled
Resent-From: Mark H Weaver <mhw@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guile@HIDDEN
Resent-Date: Thu, 23 Aug 2018 02:44:02 +0000
Resent-Message-ID: <handler.32501.B32501.15349922365334 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Daniel Tam <danooo.tam@HIDDEN>
Cc: 32501 <at> debbugs.gnu.org
From: Mark H Weaver <mhw@HIDDEN>
References: <0290e793-0acc-31ed-1d7e-61ed65b9bcf2@HIDDEN>
Date: Wed, 22 Aug 2018 22:42:15 -0400
In-Reply-To: <0290e793-0acc-31ed-1d7e-61ed65b9bcf2@HIDDEN> (Daniel Tam's
 message of "Thu, 23 Aug 2018 01:47:39 +1000")
Message-ID: <87pny9by7s.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi Daniel,

Daniel Tam <danooo.tam@HIDDEN> writes:

> I've activated readline support for the Guile repl, but I've found that
> if my inputrc enables vi-mode, then the bouncing parentheses feature
> doesn't work. Disabling vi-mode does the trick.

Indeed.  For some reason that I cannot determine, the bouncing
parentheses feature is specifically disabled when the vi keymap is in
use.  The relevant function is 'init_bouncing_parens' in
guile-readline/readline.c:

  static void
  init_bouncing_parens ()
  {
    if (strncmp (rl_get_keymap_name (rl_get_keymap ()), "vi", 2))
      {
        rl_bind_key (')', match_paren);
        rl_bind_key (']', match_paren);
        rl_bind_key ('}', match_paren);
      }
  }

This is ancient code, predating version control, present in the original
import into CVS in 1999.

I looked at the source code of readline-7.0, and IIUC none of those keys
have mappings in the default vi keymap.

The right fix might be to simply remove the 'if' check above.  Would you
like to try it and report back?

      Thanks,
        Mark

Message sent to bug-guile@HIDDEN:

Subject: bug#32501: Bouncing parentheses broken in REPL with vi-mode enabled
Resent-From: Mark H Weaver <mhw@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guile@HIDDEN
Resent-Date: Thu, 23 Aug 2018 04:05:02 +0000
Resent-Message-ID: <handler.32501.B32501.153499709120689 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Daniel Tam <danooo.tam@HIDDEN>
Cc: 32501 <at> debbugs.gnu.org
From: Mark H Weaver <mhw@HIDDEN>
References: <0290e793-0acc-31ed-1d7e-61ed65b9bcf2@HIDDEN>
 <87pny9by7s.fsf@HIDDEN>
Date: Thu, 23 Aug 2018 00:03:09 -0400
In-Reply-To: <87pny9by7s.fsf@HIDDEN> (Mark H. Weaver's message of "Wed, 22
 Aug 2018 22:42:15 -0400")
Message-ID: <87lg8xbugy.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi again,

> Daniel Tam <danooo.tam@HIDDEN> writes:
>
>> I've activated readline support for the Guile repl, but I've found that
>> if my inputrc enables vi-mode, then the bouncing parentheses feature
>> doesn't work. Disabling vi-mode does the trick.
>
> Indeed.  For some reason that I cannot determine, the bouncing
> parentheses feature is specifically disabled when the vi keymap is in
> use.

I think I now see the reason for it.  I noticed that readline's default
vi keymap includes a binding for '%', which jumps to the paren matching
the one under the cursor.  That reminded me, from many years ago when I
used vi more often, that this is the way that old vi traditionally
allows matching parens to be found.

So, I guess the decision long ago to disable bouncing parens when in vi
mode was to match the way that emacs and vi behaved at that time.

However, I just tried modern vim, and I see that it now highlights
matching parens by default.  So, we should probably remove the 'if' to
match this newer behavior.

       Mark

Message sent to bug-guile@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#32501: Bouncing parentheses broken in REPL with vi-mode enabled
Resent-From: John Cowan <cowan@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guile@HIDDEN
Resent-Date: Thu, 23 Aug 2018 16:24:02 +0000
Resent-Message-ID: <handler.32501.B32501.1535041417844 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 32501
X-GNU-PR-Package: guile
X-GNU-PR-Keywords: 
To: Mark H Weaver <mhw@HIDDEN>
Cc: danooo.tam@HIDDEN, 32501 <at> debbugs.gnu.org
Received: via spool by 32501-submit <at> debbugs.gnu.org id=B32501.1535041417844
          (code B ref 32501); Thu, 23 Aug 2018 16:24:02 +0000
Received: (at 32501) by debbugs.gnu.org; 23 Aug 2018 16:23:37 +0000
Received: from localhost ([127.0.0.1]:59058 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1fssOW-0000DW-Ru
	for submit <at> debbugs.gnu.org; Thu, 23 Aug 2018 12:23:37 -0400
Received: from mail-wm0-f44.google.com ([74.125.82.44]:39245)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <cowan@HIDDEN>) id 1fssFR-0008Qq-WB
 for 32501 <at> debbugs.gnu.org; Thu, 23 Aug 2018 12:14:14 -0400
Received: by mail-wm0-f44.google.com with SMTP id q8-v6so6444063wmq.4
 for <32501 <at> debbugs.gnu.org>; Thu, 23 Aug 2018 09:14:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=ccil-org.20150623.gappssmtp.com; s=20150623;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=Ggctz6s7rGUzdgdHOU1oAMqgYcnwk9F9mMQyXXIaLHQ=;
 b=sVoSSi3iDT91r/RJ+h+HBnmiP2QnLPqvUyvN0yFV1SUjALQfWZk0Zf4XeuhIR7pk3a
 i6Pdr8mlJzqGLfva4p0M3Y4/cUimG5ZzMo2i3YLJO7w2JtIGzBtKlS1o50y8MnpVWm64
 p9enEP8AmQJC5ppmxB0zlKqsNLTv7r72RJtBwuclA9U+xDCvvG9cN2cdh+FBX8wUaixO
 xmfHAQlggmvSgvUrAwStVl9Uut+C2nXNsHfIBMY5oqXUGSoLKoT+2IEDVVidfgc91i4C
 4K26DRBn3yNadsA+1YJexQsofduYpGnZJhjeKVqXdc75mJAa4HMMFtxa8aQeh14W8HkX
 LkFw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=Ggctz6s7rGUzdgdHOU1oAMqgYcnwk9F9mMQyXXIaLHQ=;
 b=GUnbHHsSGLnTYI1mXT55BLvl9ObFSDZ+rYtX94jKF/WU9jVRtNkPkze2Cd+iH3uaLu
 wTxWLPvPytxcY7AsrcJq5RARUdWe/834eoZVaXEnaapmjRZA+MXYsiXfTUgSl67nc+qQ
 6uPp7XLIxfGc5OBuzt/EpU5lXhKLvgvsQYZafDoSrKPmAXDPDjjTujI7D4q0BuX5RqXV
 6t2AFr6/vx3gDfhZyEanyfP3gKzhtNkrdt2i7w/P19b/l9EqULG3pKH7mvzRycvObZ00
 kcMxkjqPUpwKC9FQFActmi+OIbHruDfyLEkMfnbSNGxN5ESzkBhb3n4roenQHDysfLB8
 Mm3A==
X-Gm-Message-State: APzg51DSxPlXrn97cidkMo9FXky/uT/YGCC3+7Q5+mDeWlBBlj6PsLLB
 QzXzhJyuaVwczWwajGRQK6woRY1koT79kYgi2elPEw==
X-Google-Smtp-Source: ANB0VdY5ktTJPyMji9FFLyKRqlhGGyqKlPPO58q4Ui6TZB+qQe+fow0TYpgB6ADChKLRy3nHmOGITGlXgNmDF6w5TVM=
X-Received: by 2002:a1c:b143:: with SMTP id
 a64-v6mr6136620wmf.114.1535040848261; 
 Thu, 23 Aug 2018 09:14:08 -0700 (PDT)
MIME-Version: 1.0
References: <0290e793-0acc-31ed-1d7e-61ed65b9bcf2@HIDDEN>
 <87pny9by7s.fsf@HIDDEN> <87lg8xbugy.fsf@HIDDEN>
In-Reply-To: <87lg8xbugy.fsf@HIDDEN>
From: John Cowan <cowan@HIDDEN>
Date: Thu, 23 Aug 2018 12:13:57 -0400
Message-ID: <CAD2gp_RWvmp=ghsAqm0rrVBs397UymKsNh+t2ug4T4vTpGbJJw@HIDDEN>
Content-Type: multipart/alternative; boundary="0000000000007a14bc05741c8c68"
X-Spam-Score: -0.0 (/)
X-Mailman-Approved-At: Thu, 23 Aug 2018 12:23:35 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--0000000000007a14bc05741c8c68
Content-Type: text/plain; charset="UTF-8"

Indeed, I pretty much only go into vi-mode in vi itself to use %; the rest
of the time, I remain an "ex" troglodyte whose only vi-commands are h, j,
k, l (and arrow analogues), x, %, and most importantly gQ.  Yes, even when
writing Lisp.

On Thu, Aug 23, 2018 at 12:05 AM Mark H Weaver <mhw@HIDDEN> wrote:

> Hi again,
>
> > Daniel Tam <danooo.tam@HIDDEN> writes:
> >
> >> I've activated readline support for the Guile repl, but I've found that
> >> if my inputrc enables vi-mode, then the bouncing parentheses feature
> >> doesn't work. Disabling vi-mode does the trick.
> >
> > Indeed.  For some reason that I cannot determine, the bouncing
> > parentheses feature is specifically disabled when the vi keymap is in
> > use.
>
> I think I now see the reason for it.  I noticed that readline's default
> vi keymap includes a binding for '%', which jumps to the paren matching
> the one under the cursor.  That reminded me, from many years ago when I
> used vi more often, that this is the way that old vi traditionally
> allows matching parens to be found.
>
> So, I guess the decision long ago to disable bouncing parens when in vi
> mode was to match the way that emacs and vi behaved at that time.
>
> However, I just tried modern vim, and I see that it now highlights
> matching parens by default.  So, we should probably remove the 'if' to
> match this newer behavior.
>
>        Mark
>
>
>
>

--0000000000007a14bc05741c8c68
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Indeed, I pretty much only go into vi-mode in vi itself to=
 use %; the rest of the time, I remain an &quot;ex&quot; troglodyte whose o=
nly vi-commands are h, j, k, l (and arrow analogues), x, %, and most import=
antly gQ.=C2=A0 Yes, even when writing Lisp.</div><br><div class=3D"gmail_q=
uote"><div dir=3D"ltr">On Thu, Aug 23, 2018 at 12:05 AM Mark H Weaver &lt;<=
a href=3D"mailto:mhw@HIDDEN" target=3D"_blank">mhw@HIDDEN</a>&gt; w=
rote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex=
;border-left:1px #ccc solid;padding-left:1ex">Hi again,<br>
<br>
&gt; Daniel Tam &lt;<a href=3D"mailto:danooo.tam@HIDDEN" target=3D"_blan=
k">danooo.tam@HIDDEN</a>&gt; writes:<br>
&gt;<br>
&gt;&gt; I&#39;ve activated readline support for the Guile repl, but I&#39;=
ve found that<br>
&gt;&gt; if my inputrc enables vi-mode, then the bouncing parentheses featu=
re<br>
&gt;&gt; doesn&#39;t work. Disabling vi-mode does the trick.<br>
&gt;<br>
&gt; Indeed.=C2=A0 For some reason that I cannot determine, the bouncing<br=
>
&gt; parentheses feature is specifically disabled when the vi keymap is in<=
br>
&gt; use.<br>
<br>
I think I now see the reason for it.=C2=A0 I noticed that readline&#39;s de=
fault<br>
vi keymap includes a binding for &#39;%&#39;, which jumps to the paren matc=
hing<br>
the one under the cursor.=C2=A0 That reminded me, from many years ago when =
I<br>
used vi more often, that this is the way that old vi traditionally<br>
allows matching parens to be found.<br>
<br>
So, I guess the decision long ago to disable bouncing parens when in vi<br>
mode was to match the way that emacs and vi behaved at that time.<br>
<br>
However, I just tried modern vim, and I see that it now highlights<br>
matching parens by default.=C2=A0 So, we should probably remove the &#39;if=
&#39; to<br>
match this newer behavior.<br>
<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0Mark<br>
<br>
<br>
<br>
</blockquote></div>

--0000000000007a14bc05741c8c68--

Message sent to bug-guile@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#32501: Bouncing parentheses broken in REPL with vi-mode enabled
Resent-From: Mark H Weaver <mhw@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guile@HIDDEN
Resent-Date: Fri, 24 Aug 2018 05:38:01 +0000
Resent-Message-ID: <handler.32501.B32501.153508906118573 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 32501
X-GNU-PR-Package: guile
X-GNU-PR-Keywords: 
To: Daniel Tam <danooo.tam@HIDDEN>
Cc: 32501 <at> debbugs.gnu.org
Received: via spool by 32501-submit <at> debbugs.gnu.org id=B32501.153508906118573
          (code B ref 32501); Fri, 24 Aug 2018 05:38:01 +0000
Received: (at 32501) by debbugs.gnu.org; 24 Aug 2018 05:37:41 +0000
Received: from localhost ([127.0.0.1]:59269 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ft4mz-0004pU-03
	for submit <at> debbugs.gnu.org; Fri, 24 Aug 2018 01:37:41 -0400
Received: from world.peace.net ([64.112.178.59]:41786)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mhw@HIDDEN>) id 1ft4mx-0004pI-Ci
 for 32501 <at> debbugs.gnu.org; Fri, 24 Aug 2018 01:37:39 -0400
Received: from mhw by world.peace.net with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89)
 (envelope-from <mhw@HIDDEN>)
 id 1ft4mr-0000w2-G9; Fri, 24 Aug 2018 01:37:33 -0400
From: Mark H Weaver <mhw@HIDDEN>
References: <0290e793-0acc-31ed-1d7e-61ed65b9bcf2@HIDDEN>
 <87pny9by7s.fsf@HIDDEN>
Date: Fri, 24 Aug 2018 01:36:00 -0400
In-Reply-To: <87pny9by7s.fsf@HIDDEN> (Mark H. Weaver's message of "Wed, 22
 Aug 2018 22:42:15 -0400")
Message-ID: <87tvnkcon3.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello again,

I wrote:

> The relevant function is 'init_bouncing_parens' in
> guile-readline/readline.c:
>
>   static void
>   init_bouncing_parens ()
>   {
>     if (strncmp (rl_get_keymap_name (rl_get_keymap ()), "vi", 2))
>       {
>         rl_bind_key (')', match_paren);
>         rl_bind_key (']', match_paren);
>         rl_bind_key ('}', match_paren);
>       }
>   }

[...]

> The right fix might be to simply remove the 'if' check above.

Actually, it probably won't be that simple.  Whereas in emacs mode, we
can probably rely on these bindings being added to the correct keymap,
namely 'emacs_standard_keymap', when in vi mode it's likely that these
bindings would end up in the wrong keymap, namely 'vi_movement_keymap'.

When in vi mode, these mappings should be added to
'vi_insertion_keymap', and that probably involves using
'rl_bind_key_in_map' instead of 'rl_bind_key'.

       Mark

Message sent to bug-guile@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#32501: Bouncing parentheses broken in REPL with vi-mode enabled
Resent-From: Mark H Weaver <mhw@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guile@HIDDEN
Resent-Date: Fri, 24 Aug 2018 06:12:02 +0000
Resent-Message-ID: <handler.32501.B32501.153509109421642 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 32501
X-GNU-PR-Package: guile
X-GNU-PR-Keywords: 
To: Daniel Tam <danooo.tam@HIDDEN>
Cc: 32501 <at> debbugs.gnu.org
Received: via spool by 32501-submit <at> debbugs.gnu.org id=B32501.153509109421642
          (code B ref 32501); Fri, 24 Aug 2018 06:12:02 +0000
Received: (at 32501) by debbugs.gnu.org; 24 Aug 2018 06:11:34 +0000
Received: from localhost ([127.0.0.1]:59278 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ft5Jl-0005d0-Uo
	for submit <at> debbugs.gnu.org; Fri, 24 Aug 2018 02:11:34 -0400
Received: from world.peace.net ([64.112.178.59]:41816)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mhw@HIDDEN>) id 1ft5Jk-0005cn-K3
 for 32501 <at> debbugs.gnu.org; Fri, 24 Aug 2018 02:11:32 -0400
Received: from mhw by world.peace.net with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89)
 (envelope-from <mhw@HIDDEN>)
 id 1ft5Je-00012j-UW; Fri, 24 Aug 2018 02:11:27 -0400
From: Mark H Weaver <mhw@HIDDEN>
References: <0290e793-0acc-31ed-1d7e-61ed65b9bcf2@HIDDEN>
 <87pny9by7s.fsf@HIDDEN> <87tvnkcon3.fsf@HIDDEN>
Date: Fri, 24 Aug 2018 02:09:54 -0400
In-Reply-To: <87tvnkcon3.fsf@HIDDEN> (Mark H. Weaver's message of "Fri, 24
 Aug 2018 01:36:00 -0400")
Message-ID: <87mutccn2l.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

I wrote:

>> The right fix might be to simply remove the 'if' check above.
>
> Actually, it probably won't be that simple.  Whereas in emacs mode, we
> can probably rely on these bindings being added to the correct keymap,
> namely 'emacs_standard_keymap', when in vi mode it's likely that these
> bindings would end up in the wrong keymap, namely 'vi_movement_keymap'.
>
> When in vi mode, these mappings should be added to
> 'vi_insertion_keymap', and that probably involves using
> 'rl_bind_key_in_map' instead of 'rl_bind_key'.

And I guess 'rl_get_keymap_by_name' is the function we should use to get
the keymap.  From keymaps.h in readline:

  /* Return the keymap corresponding to a given name.  Names look like
     `emacs' or `emacs-meta' or `vi-insert'.  */
  extern Keymap rl_get_keymap_by_name PARAMS((const char *));

      Mark

Message sent to bug-guile@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#32501: Bouncing parentheses broken in REPL with vi-mode enabled
Resent-From: Daniel Tam <danooo.tam@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guile@HIDDEN
Resent-Date: Fri, 24 Aug 2018 12:44:02 +0000
Resent-Message-ID: <handler.32501.B32501.153511458216487 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 32501
X-GNU-PR-Package: guile
X-GNU-PR-Keywords: 
To: Mark H Weaver <mhw@HIDDEN>
Cc: 32501 <at> debbugs.gnu.org
Received: via spool by 32501-submit <at> debbugs.gnu.org id=B32501.153511458216487
          (code B ref 32501); Fri, 24 Aug 2018 12:44:02 +0000
Received: (at 32501) by debbugs.gnu.org; 24 Aug 2018 12:43:02 +0000
Received: from localhost ([127.0.0.1]:59406 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ftBQc-0004Hr-Ax
	for submit <at> debbugs.gnu.org; Fri, 24 Aug 2018 08:43:02 -0400
Received: from mail-pl1-f170.google.com ([209.85.214.170]:42449)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <danooo.tam@HIDDEN>) id 1ftBQa-0004HN-Su
 for 32501 <at> debbugs.gnu.org; Fri, 24 Aug 2018 08:43:01 -0400
Received: by mail-pl1-f170.google.com with SMTP id g23-v6so1060813plq.9
 for <32501 <at> debbugs.gnu.org>; Fri, 24 Aug 2018 05:43:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=subject:to:cc:references:from:message-id:date:user-agent
 :mime-version:in-reply-to:content-transfer-encoding:content-language;
 bh=+gsbZYzk/ZEFzPx9pVn10nXHkZvbp2gFX+GXNZ1ouSQ=;
 b=XAUdHbSP4GiwZPzRRUsB55+xmC4DRSCVy1MarJd37ydo9qCpTErLvl8jym/Vi9gd/D
 SoNEIEKl7jr0gBd8mArhYG/5Vpt+RfD2CeT0fXOIJDj0rRpVEDEStZSnWRl0e1O21Fe9
 kEJUDlARyG+VmzSZTGCb4ZERWxg+hsUf1SK0HGmTb3DuFJDFrMl6E4/A4eggaVXCiRbB
 z3BMkDhmCLeaD4JLI3XPkurdBZ6QjXQMyvo4YG50NOC/9dI/F3Zt+3KA7u/pu6fiLgLW
 c+i/IqVWp0umCHJ6jNNBP2chIDsuAn0RZqM3ywf+LvIanJVQL7PRxB0GMkk8RK4A0Ohl
 Db8g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:subject:to:cc:references:from:message-id:date
 :user-agent:mime-version:in-reply-to:content-transfer-encoding
 :content-language;
 bh=+gsbZYzk/ZEFzPx9pVn10nXHkZvbp2gFX+GXNZ1ouSQ=;
 b=rlRTKbl0IfkuCxPhi8m7I+M3g0tibJWE/bT3CS49GLzqcHmn3KIDyquS83G8mC8VP7
 EjE5AoX6DmBW794mRpWby4CB6OH5v7/zptpbtBVn+OMw3kPiLxx/7msY0wqL82jvJCVw
 Z0HoQHF7monKgkI3Roc072ePLfeceV6fEhXNTYn27KIfjX9F0Ng12AI8Dq9opMmN7GAq
 zFpM2Se526ObLF3L79lQP7EHjIXMMUQ8Gdmrah3dyhnVNWG4GY0WgCH11qAUexWCtEnz
 YNFYkdq9gHL3OWAHFKf4a2lqt3Az6OmWEDlCWTN51PO97WtASBepFczOD8NxQZR0zaZG
 eLmA==
X-Gm-Message-State: APzg51CPvoktopkMGrH+I/yHtE+FlRgo6qfV6HoisVA+4QREwHk6Ptlf
 d/IsGWL9ZaGYU/6+3uqInrFzHv9dN+k=
X-Google-Smtp-Source: ANB0VdalCTvps0HKTAJp/8qTo4jyW9LMKnqajzodmjILfmq+yIaSwoReVPz4QVtLxK/Fif+JkDbiDA==
X-Received: by 2002:a17:902:5a49:: with SMTP id
 f9-v6mr1592687plm.332.1535114574822; 
 Fri, 24 Aug 2018 05:42:54 -0700 (PDT)
Received: from [192.168.1.100] (ppp121-44-111-137.bras1.syd7.internode.on.net.
 [121.44.111.137])
 by smtp.gmail.com with ESMTPSA id a2-v6sm8268963pgc.68.2018.08.24.05.42.49
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 24 Aug 2018 05:42:54 -0700 (PDT)
References: <0290e793-0acc-31ed-1d7e-61ed65b9bcf2@HIDDEN>
 <87pny9by7s.fsf@HIDDEN> <87tvnkcon3.fsf@HIDDEN>
 <87mutccn2l.fsf@HIDDEN>
From: Daniel Tam <danooo.tam@HIDDEN>
Message-ID: <7e908c7a-4e02-13c4-c09b-78bedc805cf6@HIDDEN>
Date: Fri, 24 Aug 2018 22:42:40 +1000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <87mutccn2l.fsf@HIDDEN>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hey Mark,


On 08/24/2018 04:09 PM, Mark H Weaver wrote:
> I wrote:
>
>>> The right fix might be to simply remove the 'if' check above.
>> Actually, it probably won't be that simple.  Whereas in emacs mode, we=

>> can probably rely on these bindings being added to the correct keymap,=

>> namely 'emacs_standard_keymap', when in vi mode it's likely that these=

>> bindings would end up in the wrong keymap, namely 'vi_movement_keymap'=
=2E
>>
>> When in vi mode, these mappings should be added to
>> 'vi_insertion_keymap', and that probably involves using
>> 'rl_bind_key_in_map' instead of 'rl_bind_key'.
> And I guess 'rl_get_keymap_by_name' is the function we should use to ge=
t
> the keymap.  From keymaps.h in readline:
>
>   /* Return the keymap corresponding to a given name.  Names look like
>      `emacs' or `emacs-meta' or `vi-insert'.  */
>   extern Keymap rl_get_keymap_by_name PARAMS((const char *));
>
>       Mark
I'm excited to have a look but I have 0 knowledge of the code base (and
am just learning Scheme although that's probably not an issue in this
case whatsoever). Do you have any advice for specific
documentation/files (other than README and HACKING) that I should read
if I were to attempt this? As well as which branch to base my changes ont=
o.

Daniel

Message sent to bug-guile@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#32501: Bouncing parentheses broken in REPL with vi-mode enabled
Resent-From: Mark H Weaver <mhw@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guile@HIDDEN
Resent-Date: Fri, 24 Aug 2018 22:14:02 +0000
Resent-Message-ID: <handler.32501.B32501.153514880121229 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 32501
X-GNU-PR-Package: guile
X-GNU-PR-Keywords: 
To: Daniel Tam <danooo.tam@HIDDEN>
Cc: 32501 <at> debbugs.gnu.org
Received: via spool by 32501-submit <at> debbugs.gnu.org id=B32501.153514880121229
          (code B ref 32501); Fri, 24 Aug 2018 22:14:02 +0000
Received: (at 32501) by debbugs.gnu.org; 24 Aug 2018 22:13:21 +0000
Received: from localhost ([127.0.0.1]:60054 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ftKKU-0005WJ-Qj
	for submit <at> debbugs.gnu.org; Fri, 24 Aug 2018 18:13:21 -0400
Received: from world.peace.net ([64.112.178.59]:45588)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mhw@HIDDEN>) id 1ftKKS-0005W5-9u
 for 32501 <at> debbugs.gnu.org; Fri, 24 Aug 2018 18:13:16 -0400
Received: from mhw by world.peace.net with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89)
 (envelope-from <mhw@HIDDEN>)
 id 1ftKKM-000531-DQ; Fri, 24 Aug 2018 18:13:10 -0400
From: Mark H Weaver <mhw@HIDDEN>
References: <0290e793-0acc-31ed-1d7e-61ed65b9bcf2@HIDDEN>
 <87pny9by7s.fsf@HIDDEN> <87tvnkcon3.fsf@HIDDEN>
 <87mutccn2l.fsf@HIDDEN>
 <7e908c7a-4e02-13c4-c09b-78bedc805cf6@HIDDEN>
Date: Fri, 24 Aug 2018 18:11:38 -0400
In-Reply-To: <7e908c7a-4e02-13c4-c09b-78bedc805cf6@HIDDEN> (Daniel Tam's
 message of "Fri, 24 Aug 2018 22:42:40 +1000")
Message-ID: <87pny7bejp.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Daniel,

Daniel Tam <danooo.tam@HIDDEN> writes:
> I'm excited to have a look but I have 0 knowledge of the code base (and
> am just learning Scheme although that's probably not an issue in this
> case whatsoever).

It's okay, please don't feel any obligation to work on this.  Sometimes
people are impatient to fix a problem ASAP, and that's why I wrote these
preliminary emails.

It's probably better for you to focus on learning Scheme for now, rather
than mucking around in the underbelly of an implementation :)

I appreciate you taking the time to file this bug report.  That's quite
useful by itself.

      Thanks!
        Mark

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.