GNU logs - #33266, boring messages

Message sent to bug-guix@HIDDEN:

Subject: bug#33266: guix-copy: Honor the SSH port of a host when defined in ~/.ssh/config
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Mon, 05 Nov 2018 04:59:01 +0000
Resent-Message-ID: <handler.33266.B.154139393511571 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 33266 <at> debbugs.gnu.org
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Date: Sun, 04 Nov 2018 23:58:27 -0500
Message-ID: <87a7mo5de4.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--=-=-=
Content-Type: text/plain

Hello,

I recently stumbled on the bug where guix copy would the port 22 even
when I had specified a different one in my ~/.ssh/config file.

This bug is triggered when omitting the port in the --to= (or --from)
expression, such as in

guix copy --to=somehost bash

And where somehost exists in ~/.ssh/config, say:

Host somehost
     User someuser
     HostName someplace.somedns.net
     Port 1234

Instead of using port 1234, the port 22 would be used.  Commit
cc1dfc202f is the reason of this overriding; the attached patch 
reverts it, with a detailed explanation.

Thank you,

Maxim


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
 filename=0001-Revert-copy-Default-to-port-22.patch

From 942eb8cabef5b7c8b4425c765b6ee2ac9f529ad8 Mon Sep 17 00:00:00 2001
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Date: Sun, 4 Nov 2018 23:35:16 -0500
Subject: [PATCH] Revert "copy: Default to port 22."

This reverts commit cc1dfc202f2fefb6c2eb9467d1fc90a9154550c9.  Specifying a
default port had the undesirable effect of disregarding a port specification
for a given host in the ~/.ssh/config that would otherwise have been honored
at the time `open-ssh-session' calls the `session-parse-config!' method.

In any case, `make-session' will default the port value of the created session
to 22 if left unspecified.
---
 guix/scripts/copy.scm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/guix/scripts/copy.scm b/guix/scripts/copy.scm
index 4c8592985..d35eed74e 100644
--- a/guix/scripts/copy.scm
+++ b/guix/scripts/copy.scm
@@ -75,8 +75,7 @@ package names, build the underlying packages before sending them."
 
       (and (or (assoc-ref opts 'dry-run?)
                (build-derivations local drv))
-           (let* ((session (open-ssh-session host #:user user
-                                             #:port (or port 22)))
+           (let* ((session (open-ssh-session host #:user user #:port port))
                   (sent    (send-files local items
                                        (connect-to-remote-daemon session)
                                        #:recursive? #t)))
@@ -89,7 +88,7 @@ package names, build the underlying packages before sending them."
     (let*-values (((user host port)
                    (ssh-spec->user+host+port source))
                   ((session)
-                   (open-ssh-session host #:user user #:port (or port 22)))
+                   (open-ssh-session host #:user user #:port port))
                   ((remote)
                    (connect-to-remote-daemon session)))
       (set-build-options-from-command-line local opts)
-- 
2.19.0


--=-=-=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Subject: bug#33266: Acknowledgement (guix-copy: Honor the SSH port of a
 host when defined in ~/.ssh/config)
Message-ID: <handler.33266.B.154139393511571.ack <at> debbugs.gnu.org>
References: <87a7mo5de4.fsf@HIDDEN>
X-Gnu-PR-Message: ack 33266
X-Gnu-PR-Package: guix
Reply-To: 33266 <at> debbugs.gnu.org
Date: Mon, 05 Nov 2018 04:59:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-guix@HIDDEN

If you wish to submit further information on this problem, please
send it to 33266 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
33266: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D33266
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-guix@HIDDEN:

Subject: bug#33266: guix-copy: Honor the SSH port of a host when defined in ~/.ssh/config
Resent-From: ludo@HIDDEN (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Tue, 06 Nov 2018 14:13:01 +0000
Resent-Message-ID: <handler.33266.B33266.154151358128038 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Cc: 33266 <at> debbugs.gnu.org
From: ludo@HIDDEN (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <87a7mo5de4.fsf@HIDDEN>
Date: Tue, 06 Nov 2018 15:12:44 +0100
In-Reply-To: <87a7mo5de4.fsf@HIDDEN> (Maxim Cournoyer's message of "Sun, 04
 Nov 2018 23:58:27 -0500")
Message-ID: <87o9b21ehv.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hello,

Maxim Cournoyer <maxim.cournoyer@HIDDEN> skribis:

> From 942eb8cabef5b7c8b4425c765b6ee2ac9f529ad8 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
> Date: Sun, 4 Nov 2018 23:35:16 -0500
> Subject: [PATCH] Revert "copy: Default to port 22."
>
> This reverts commit cc1dfc202f2fefb6c2eb9467d1fc90a9154550c9.  Specifying=
 a
> default port had the undesirable effect of disregarding a port specificat=
ion
> for a given host in the ~/.ssh/config that would otherwise have been hono=
red
> at the time `open-ssh-session' calls the `session-parse-config!' method.
>
> In any case, `make-session' will default the port value of the created se=
ssion
> to 22 if left unspecified.

This looks good, and indeed it=E2=80=99s an unintended consequence of commit
cc1dfc202f2fefb6c2eb9467d1fc90a9154550c9.

However, the log of commit cc1dfc had this:

   Failing to do that, "%p" would be "0" when using "ProxyCommand"
   in ~/.ssh/config.

This is arguably a defect in either Guile-SSH or (more likely) libssh,
and it would be nice to report it.

Would you like to report it upstream?

Thanks,
Ludo=E2=80=99.

Message sent to bug-guix@HIDDEN:

Subject: bug#33266: guix-copy: Honor the SSH port of a host when defined in ~/.ssh/config
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Fri, 09 Nov 2018 03:36:02 +0000
Resent-Message-ID: <handler.33266.B33266.15417345453088 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: ludo@HIDDEN (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Cc: 33266 <at> debbugs.gnu.org
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
References: <87a7mo5de4.fsf@HIDDEN> <87o9b21ehv.fsf@HIDDEN>
Date: Thu, 08 Nov 2018 22:35:32 -0500
In-Reply-To: <87o9b21ehv.fsf@HIDDEN> ("Ludovic
 \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
 \=\?utf-8\?Q\?s\?\= message of "Tue, 06 Nov 2018 15:12:44 +0100")
Message-ID: <871s7u53ej.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hello!

ludo@HIDDEN (Ludovic Court=C3=A8s) writes:

[...]

> This looks good, and indeed it=E2=80=99s an unintended consequence of com=
mit
> cc1dfc202f2fefb6c2eb9467d1fc90a9154550c9.
>
> However, the log of commit cc1dfc had this:
>
>    Failing to do that, "%p" would be "0" when using "ProxyCommand"
>    in ~/.ssh/config.

Yeah, I had seen this message, but was doubting if it was still
valid. Helas, it seems so:

Given the ~/.ssh/config snippet (and configured machines):
--8<---------------cut here---------------start------------->8---
Host vm-host
     HostName 10.5.5.5
     User someuser
=20=20=20=20=20
Host some-guest
     IdentityFile ~/.ssh/vm-host/id_rsa
     HostName some-guest
     User guest
     ProxyCommand ssh vm-host nc %h %p
--8<---------------cut here---------------end--------------->8---

--8<---------------cut here---------------start------------->8---
scheme@(guile-user)> ,use (ssh session)
scheme@(guile-user)> (make-session #:host "some-guest")
$1 =3D #<session #<undefined>@some-guest:22 (disconnected) 11dffe0>
scheme@(guile-user)> (session-get $1 'host)
$2 =3D "some-guest"
scheme@(guile-user)> (session-get $1 'port)
$3 =3D 22
scheme@(guile-user)> (session-parse-config! $1 "~/.ssh/config")
$4 =3D #<undefined>
scheme@(guile-user)> (session-get $1 'port)
$5 =3D 22
scheme@(guile-user)> (connect! $1)
$6 =3D error
scheme@(guile-user)> (make-session #:host "some-guest" #:port 22)
$7 =3D #<session #<undefined>@some-guest:22 (disconnected) 11dffc0>
scheme@(guile-user)> (session-parse-config! $7 "~/.ssh/config")
$8 =3D #<undefined>
scheme@(guile-user)> (session-get $7 'port)
$9 =3D 22
scheme@(guile-user)> (connect! $7)
$10 =3D ok
--8<---------------cut here---------------end--------------->8---

> This is arguably a defect in either Guile-SSH or (more likely) libssh,
> and it would be nice to report it.
>
> Would you like to report it upstream?

It has to be in libssh. I'll try to come up with a repro in C, and
submit the issue to them.

When it's done, I'll add a note in the code.

To be continued... Thanks for looking :)

Maxim

Message sent to bug-guix@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#33266: guix-copy: Honor the SSH port of a host when defined in ~/.ssh/config
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Tue, 22 Jan 2019 22:10:02 +0000
Resent-Message-ID: <handler.33266.B33266.154819495210342 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 33266
X-GNU-PR-Package: guix
X-GNU-PR-Keywords: 
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Cc: 33266 <at> debbugs.gnu.org
Received: via spool by 33266-submit <at> debbugs.gnu.org id=B33266.154819495210342
          (code B ref 33266); Tue, 22 Jan 2019 22:10:02 +0000
Received: (at 33266) by debbugs.gnu.org; 22 Jan 2019 22:09:12 +0000
Received: from localhost ([127.0.0.1]:41704 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gm4EK-0002gk-FK
	for submit <at> debbugs.gnu.org; Tue, 22 Jan 2019 17:09:12 -0500
Received: from hera.aquilenet.fr ([185.233.100.1]:50886)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1gm4EI-0002gb-Fr
 for 33266 <at> debbugs.gnu.org; Tue, 22 Jan 2019 17:09:10 -0500
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 671864F13;
 Tue, 22 Jan 2019 23:09:09 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id sskwcurosmH2; Tue, 22 Jan 2019 23:09:08 +0100 (CET)
Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id C9FCE4F11;
 Tue, 22 Jan 2019 23:09:07 +0100 (CET)
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
References: <87a7mo5de4.fsf@HIDDEN> <87o9b21ehv.fsf@HIDDEN>
 <871s7u53ej.fsf@HIDDEN>
Date: Tue, 22 Jan 2019 23:09:07 +0100
In-Reply-To: <871s7u53ej.fsf@HIDDEN> (Maxim Cournoyer's message of "Thu, 08
 Nov 2018 22:35:32 -0500")
Message-ID: <874la0jqf0.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

Hi Maxim,

Maxim Cournoyer <maxim.cournoyer@HIDDEN> skribis:

> ludo@HIDDEN (Ludovic Court=C3=A8s) writes:
>
> [...]
>
>> This looks good, and indeed it=E2=80=99s an unintended consequence of co=
mmit
>> cc1dfc202f2fefb6c2eb9467d1fc90a9154550c9.
>>
>> However, the log of commit cc1dfc had this:
>>
>>    Failing to do that, "%p" would be "0" when using "ProxyCommand"
>>    in ~/.ssh/config.
>
> Yeah, I had seen this message, but was doubting if it was still
> valid. Helas, it seems so:

[...]

>> This is arguably a defect in either Guile-SSH or (more likely) libssh,
>> and it would be nice to report it.
>>
>> Would you like to report it upstream?
>
> It has to be in libssh. I'll try to come up with a repro in C, and
> submit the issue to them.

With the recent upgrade to libssh 0.8.6, is the issue still present?

Ludo=E2=80=99.

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.