GNU logs - #39275, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#39275] [PATCH] gnu: vlc: add fluidsynth as input.
Resent-From: Jesse Gibbons <jgibbons2357@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 25 Jan 2020 01:21:01 +0000
Resent-Message-ID: <handler.39275.B.157991520811140 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 39275 <at> debbugs.gnu.org
Message-ID: <56f17e2eeb450626e36f546d80f0c63a26185c56.camel@HIDDEN>
From: Jesse Gibbons <jgibbons2357@HIDDEN>
Date: Fri, 24 Jan 2020 18:19:57 -0700
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.32.4 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

* gnu/packages/video.scm (vlc) [inputs]: Add FluidSynth.
---
 gnu/packages/video.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index ee7108753f..53d9a794f8 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1118,6 +1118,7 @@ videoformats depend on the configuration flags of
ffmpeg.")
        ("dbus" ,dbus)
        ("eudev" ,eudev)
        ("flac" ,flac)
+       ("fluidsynth" ,fluidsynth)
        ("ffmpeg" ,ffmpeg)
        ("fontconfig" ,fontconfig)
        ("freetype" ,freetype)

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Jesse Gibbons <jgibbons2357@HIDDEN>
Subject: bug#39275: Acknowledgement ([PATCH] gnu: vlc: add fluidsynth as
 input.)
Message-ID: <handler.39275.B.157991520811140.ack <at> debbugs.gnu.org>
References: <56f17e2eeb450626e36f546d80f0c63a26185c56.camel@HIDDEN>
X-Gnu-PR-Message: ack 39275
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 39275 <at> debbugs.gnu.org
Date: Sat, 25 Jan 2020 01:21:03 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 39275 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
39275: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D39275
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#39275] [PATCH] gnu: vlc: add fluidsynth as input.
Resent-From: Christopher Baines <mail@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 25 Jan 2020 08:36:01 +0000
Resent-Message-ID: <handler.39275.B39275.157994131525740 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: jgibbons2357@HIDDEN
Cc: 39275 <at> debbugs.gnu.org
References: <56f17e2eeb450626e36f546d80f0c63a26185c56.camel@HIDDEN>
User-agent: mu4e 1.2.0; emacs 26.3
From: Christopher Baines <mail@HIDDEN>
In-reply-to: <56f17e2eeb450626e36f546d80f0c63a26185c56.camel@HIDDEN>
Date: Sat, 25 Jan 2020 08:35:07 +0000
Message-ID: <871rro6iis.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--=-=-=
Content-Type: text/plain

Jesse Gibbons <jgibbons2357@HIDDEN> writes:

> * gnu/packages/video.scm (vlc) [inputs]: Add FluidSynth.
> ---
>  gnu/packages/video.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index ee7108753f..53d9a794f8 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -1118,6 +1118,7 @@ videoformats depend on the configuration flags of
> ffmpeg.")
>         ("dbus" ,dbus)
>         ("eudev" ,eudev)
>         ("flac" ,flac)
> +       ("fluidsynth" ,fluidsynth)
>         ("ffmpeg" ,ffmpeg)
>         ("fontconfig" ,fontconfig)
>         ("freetype" ,freetype)

Hi Jesse,

It would be good to put something in the commit message about why this
is happening, as it's not obvious to me at least.

Thanks,

Chris

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl4r/btfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE
9XczQw//b8laG3y8dbmTqN/yifAq7xtLUO0p48yLwAU/7omVl+SSuabLBvgIKlii
z/A/pqVoB8wsbJPK5uSTlYEdXzv811j/1n4LNihe7pVDoOrjf6rvuV1tpMcRiXr6
GN3z1vxiGvXSOznziShvGt91tjW0FXvRtyktppmjqgavbkqTgs4MHvhgPXY9no2u
5iTbJjA52wBJQVJgWhjLBg4tVBKamyP+jvxwEOkTI4wMdGlooX/e2rkqIHNhbh4N
tFO6hs8yDsrANHAqCTbGAoSSUvBc0Af/oJdpv/nJcahvgTaMnAU6HTNMembQ9WPM
qKiP/haDXxntY1j2xaz7rRDh/N4sX4BREEyhm25Oxce0t9BFnx5YeUlBknxBZKQh
M/0W62EZhOr0jFInh+U1pAbrrJEODM84tiYHElvybgf5kdB8x81yKm1Mgvx8BGhS
OHdfkj7ja+weRleqmHnbUqpXEgcp2Orwwo91d2jFV8AKcu5ZxduHkFz03x4UXpI/
e6C56GGuTORrnt0o4OXj6o89CEuXjc5rQYOhOJSOQ4ZGe2caAwKHeI4GyhAKdCxE
Kf2LGf1exg1I2zL+foCcYt2RrmGTAhDgDXiJiTisOfWhHdXkklFfKOaRjYrEjKjO
/CsDlr7EDfQGReJYz5OW1B+NugzKKiiPo4os1BlCEGj9ZbKFe08=
=kq5j
-----END PGP SIGNATURE-----
--=-=-=--

Message sent to guix-patches@HIDDEN:

Subject: [bug#39275] [PATCH] gnu: vlc: add fluidsynth as input.
Resent-From: Danny Milosavljevic <dannym@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 25 Jan 2020 11:31:02 +0000
Resent-Message-ID: <handler.39275.B39275.15799518359126 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Christopher Baines <mail@HIDDEN>, jgibbons2357@HIDDEN
Cc: 39275 <at> debbugs.gnu.org
Date: Sat, 25 Jan 2020 12:30:27 +0100
From: Danny Milosavljevic <dannym@HIDDEN>
Message-ID: <20200125123027.50a6ab1a@HIDDEN>
In-Reply-To: <871rro6iis.fsf@HIDDEN>
References: <56f17e2eeb450626e36f546d80f0c63a26185c56.camel@HIDDEN>
 <871rro6iis.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/uw5eHZ8XpWtrHVD=+zrG1fG";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--Sig_/uw5eHZ8XpWtrHVD=+zrG1fG
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi,

I'd prefer to change the subject to "gnu: vlc: Add MIDI support.".

> It would be good to put something in the commit message about why this
> is happening, as it's not obvious to me at least.

I disagree in general because I've seen before what that leads to:
Half the source code (the comments) end up in the commit messages instead.
Eventually (because of some merge or something) those get lost, or
(because of a new commit) those get hidden.
Now someone is going to overlook it.

So I'd put documentation into comments, except when it's ephemeral ("news").

Also, in the special case of Guix the reason why we add an input later is
"we forgot to add it earlier and it was optional to the package and thus the
package built" most of the time.  So the commit message would always be
"we forgot earlier".

In this case, vlc got MIDI support with vlc 0.9.0 (long ago) and nobody
noticed.

We could have the subject say "Add MIDI support" because it communicates mo=
re
clearly what this commit does for users.  And that's the news :)

--Sig_/uw5eHZ8XpWtrHVD=+zrG1fG
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl4sJtMACgkQ5xo1VCww
uqW6kgf+N9sb5cn0u0bbHONcvsSF8EDZsCFubO2yiQFvQ6TnV2WxWZEOOlI8LuNH
Zuwhg3sFDarX9lp2ol3ZMb/rTrmKR7STm3NRFW4bZeVp8kQYxAt7VW5kl29oRR+n
U77/9rNpyeOd0OOcfG6+6suumMWC2VSlw3DbjtcGrwFxJX0n+Z9y8EPn8/WqXW3p
q82laSqg9X/z8e4FT17e8XQJJkBhPSzcEeT/R0ykxc02SDDVSal53EoRNoIuJZqJ
5/n/S7SXbtxU1DkEUHuDA/eajZZpif9pJIq/xy+sGHOSJ2vJqgpGQ26P7TEJCZ9p
IPXYWDMUpMMTG0VOd/OCqyV85SZngg==
=Nvop
-----END PGP SIGNATURE-----

--Sig_/uw5eHZ8XpWtrHVD=+zrG1fG--

Last modified: Sat, 25 Jan 2020 11:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.