Ludovic Courtès <ludo@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at 40430) by debbugs.gnu.org; 20 Apr 2020 22:12:59 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 20 18:12:59 2020
Received: from localhost ([127.0.0.1]:48616 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1jQeew-0008I5-Qi
for submit <at> debbugs.gnu.org; Mon, 20 Apr 2020 18:12:59 -0400
Received: from eggs.gnu.org ([209.51.188.92]:46258)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ludo@HIDDEN>) id 1jQeev-0008Hs-1S
for 40430 <at> debbugs.gnu.org; Mon, 20 Apr 2020 18:12:57 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:56963)
by eggs.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <ludo@HIDDEN>)
id 1jQeeo-0002uz-R6; Mon, 20 Apr 2020 18:12:50 -0400
Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=34756 helo=ribbon)
by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
(Exim 4.82) (envelope-from <ludo@HIDDEN>)
id 1jQeef-0007t7-PR; Mon, 20 Apr 2020 18:12:50 -0400
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Ivan Kozlov <kanichos@HIDDEN>
Subject: Re: [bug#40430] =?utf-8?Q?Don=E2=80=99t?= attempt to create a
module database when none are available
References: <5354211586005255@HIDDEN>
Date: Tue, 21 Apr 2020 00:12:40 +0200
In-Reply-To: <5354211586005255@HIDDEN> (Ivan
Kozlov's message of "Sat, 04 Apr 2020 19:16:15 +0300")
Message-ID: <87h7xdzu07.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 40430
Cc: Danny Milosavljevic <dannym@HIDDEN>, 40430 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Hi,
Ivan Kozlov <kanichos@HIDDEN> skribis:
> The present code breaks with a non-modular kernel. This can be easily avo=
ided.
>
> --- a/gnu/system.scm
> +++ #<buffer system.scm>
> @@ -477,13 +477,19 @@
> value of the SYSTEM-SERVICE-TYPE service."
> (let ((locale (operating-system-locale-directory os)))
> (mlet* %store-monad ((kernel -> (operating-system-kernel os))
> + (kernel-modules (package-file kernel "lib/modul=
es"))
> (modules ->
> (operating-system-kernel-loadable-modules os))
> + (has-modules ->
> + (or (not (null? modules))
> + (file-exists? kernel-modules)))
> (kernel
> (profile-derivation
> (packages->manifest
> (cons kernel modules))
> - #:hooks (list linux-module-database)))
> + #:hooks (if has-modules
> + (list linux-module-database)
> + '())))
> (initrd -> (operating-system-initrd-file os))
> (params (operating-system-boot-parameters-fi=
le os)))
> (return `(("kernel" ,kernel)
There were a couple of mistakes in this patch (which is fine, we all
make mistakes!), so I reverted it along with explanations:
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D71977a6c59460e029=
c91741c8b11f3a544a70486
What problem were you trying to solve, Ivan? What do you mean by
=E2=80=9Cnon-modular kernel=E2=80=9D?
Thanks,
Ludo=E2=80=99.
guix-patches@HIDDEN:bug#40430; Package guix-patches.
Full text available.Debbugs Internal Request <help-debbugs@HIDDEN>
to internal_control <at> debbugs.gnu.org.
Full text available.Received: (at 40430-done) by debbugs.gnu.org; 4 Apr 2020 20:05:52 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 04 16:05:52 2020 Received: from localhost ([127.0.0.1]:44859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1jKp3A-000598-IQ for submit <at> debbugs.gnu.org; Sat, 04 Apr 2020 16:05:52 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:56838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dannym@HIDDEN>) id 1jKp38-00058w-Us for 40430-done <at> debbugs.gnu.org; Sat, 04 Apr 2020 16:05:51 -0400 Received: from localhost (unknown [185.128.244.187]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 4C4F03367FCE; Sat, 4 Apr 2020 22:05:50 +0200 (CEST) Date: Sat, 4 Apr 2020 22:05:49 +0200 From: Danny Milosavljevic <dannym@HIDDEN> To: Ivan Kozlov <kanichos@HIDDEN> Subject: Re: [bug#40430] =?UTF-8?Q?Don=E2=80=99t?= attempt to create a module database when none are available Message-ID: <20200404220549.7ad7bac5@HIDDEN> In-Reply-To: <5354211586005255@HIDDEN> References: <5354211586005255@HIDDEN> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/EaWatGf.A1UDa.7yHPz.QPt"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40430-done Cc: 40430-done <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) --Sig_/EaWatGf.A1UDa.7yHPz.QPt Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Thanks! Pushed to guix master as commit b2fff3b5de7d510fe4809e9a97089dddf2a39ffc. --Sig_/EaWatGf.A1UDa.7yHPz.QPt Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl6I6J0ACgkQ5xo1VCww uqVm/Af/dIo6ZSARuAZ92YJtpdaKPxFtbmOwAfknE1RClhbAp1gMyc0g4kufxgYx FXOH6YT1z0o3NFtrN6pEB+Ssx0T5otrWPpct57o8aQu3S7Xn38dhrGsISvGjcPee uANptsAGmiYKGtkQvKqWZURr7bnmnSioP3xK3gH8AuqyMqXut0mApw+7YHlvMTRK UcIz9W2jbwLmS0pFmgFa+g7+9CscfOFoBI+251iu4xNBnSrF4z5W3lGIRTrAKV0c UsM3sh2HlQsokPBuVYrCh+hlWHcd6ijYI0JmwHgKuQwctfOlOp+UOpMmlfuL/Pfc fesa/qr2P2GPR2j8L18DNNUwsoR9gA== =5xZD -----END PGP SIGNATURE----- --Sig_/EaWatGf.A1UDa.7yHPz.QPt--
Ivan Kozlov <kanichos@HIDDEN>:Danny Milosavljevic <dannym@HIDDEN>:
Received: (at submit) by debbugs.gnu.org; 4 Apr 2020 16:16:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 04 12:16:25 2020
Received: from localhost ([127.0.0.1]:44626 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1jKlT6-0007Ld-T3
for submit <at> debbugs.gnu.org; Sat, 04 Apr 2020 12:16:25 -0400
Received: from lists.gnu.org ([209.51.188.17]:32909)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <kanichos@HIDDEN>) id 1jKlT5-0007LT-AM
for submit <at> debbugs.gnu.org; Sat, 04 Apr 2020 12:16:23 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:53845)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <kanichos@HIDDEN>) id 1jKlT3-0003kx-Vg
for guix-patches@HIDDEN; Sat, 04 Apr 2020 12:16:23 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: **
X-Spam-Status: No, score=2.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM,
RCVD_IN_DNSWL_NONE,SPOOFED_FREEMAIL,URIBL_BLOCKED autolearn=disabled
version=3.3.2
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <kanichos@HIDDEN>) id 1jKlT2-0001DH-58
for guix-patches@HIDDEN; Sat, 04 Apr 2020 12:16:21 -0400
Received: from forward104p.mail.yandex.net ([77.88.28.107]:59871)
by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
(Exim 4.71) (envelope-from <kanichos@HIDDEN>) id 1jKlT1-0001CF-Fi
for guix-patches@HIDDEN; Sat, 04 Apr 2020 12:16:20 -0400
Received: from forward100q.mail.yandex.net (forward100q.mail.yandex.net
[IPv6:2a02:6b8:c0e:4b:0:640:4012:bb97])
by forward104p.mail.yandex.net (Yandex) with ESMTP id A54CE4B0049B
for <guix-patches@HIDDEN>; Sat, 4 Apr 2020 19:16:15 +0300 (MSK)
Received: from mxback11q.mail.yandex.net (mxback11q.mail.yandex.net
[IPv6:2a02:6b8:c0e:1b4:0:640:1f0c:10f2])
by forward100q.mail.yandex.net (Yandex) with ESMTP id A15357080009
for <guix-patches@HIDDEN>; Sat, 4 Apr 2020 19:16:15 +0300 (MSK)
Received: from localhost (localhost [::1])
by mxback11q.mail.yandex.net (mxback/Yandex) with ESMTP id rGhk6vG2lr-GFS0AM8Y;
Sat, 04 Apr 2020 19:16:15 +0300
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail;
t=1586016975; bh=WTRQlP9F71s/yutKF+E6z9xn/O67cBGsfXU7bIwTsR4=;
h=Message-Id:Date:Subject:To:From;
b=ozATj+67fzbHTziuS8P1JmWnQorzf70UUgD9ht92pUu0Ok0ylw5Ywz8iDRUNtAIRG
NgNUCRSsPSVUqnE2xgmuN2kusBlHUEYoRUeUNCuGmzYSMDROJgOx/c4xcfplizy3sq
5kvJ8wKC1zkf7L4zD8IlwD3ifcAwplQE62IVSW6U=
Authentication-Results: mxback11q.mail.yandex.net;
dkim=pass header.i=@yandex.ru
Received: by vla3-6a5326aeb4ee.qloud-c.yandex.net with HTTP;
Sat, 04 Apr 2020 19:16:15 +0300
From: Ivan Kozlov <kanichos@HIDDEN>
To: "guix-patches@HIDDEN" <guix-patches@HIDDEN>
Subject: =?utf-8?B?RG9u4oCZdCBhdHRlbXB0IHRvIGNyZWF0ZSBhIG1vZHVsZSBkYXRhYmFzZSB3aGVuIG5vbmUgYXJlIGF2?=
=?utf-8?B?YWlsYWJsZQ==?=
MIME-Version: 1.0
X-Mailer: Yamail [ http://yandex.ru ] 5.0
Date: Sat, 04 Apr 2020 19:16:15 +0300
Message-Id: <5354211586005255@HIDDEN>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
[fuzzy]
X-Received-From: 77.88.28.107
X-Spam-Score: 2.3 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: The present code breaks with a non-modular kernel. This can
be easily avoided. --- a/gnu/system.scm +++ #<buffer system.scm> @@ -477,13
+477,
19 @@ value of the SYSTEM-SERVICE-TYPE service." (let ((locale
(operating-system-locale-directory
os))) (mlet* %store-monad ((kernel -> (o [...]
Content analysis details: (2.3 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was
blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block
for more information. [URIs: yandex.ru]
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (kanichos[at]yandex.ru)
-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/,
low trust [209.51.188.17 listed in list.dnswl.org]
1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
2.0 SPOOFED_FREEMAIL No description available.
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)
The present code breaks with a non-modular kernel. This can be easily avoided.
--- a/gnu/system.scm
+++ #<buffer system.scm>
@@ -477,13 +477,19 @@
value of the SYSTEM-SERVICE-TYPE service."
(let ((locale (operating-system-locale-directory os)))
(mlet* %store-monad ((kernel -> (operating-system-kernel os))
+ (kernel-modules (package-file kernel "lib/modules"))
(modules ->
(operating-system-kernel-loadable-modules os))
+ (has-modules ->
+ (or (not (null? modules))
+ (file-exists? kernel-modules)))
(kernel
(profile-derivation
(packages->manifest
(cons kernel modules))
- #:hooks (list linux-module-database)))
+ #:hooks (if has-modules
+ (list linux-module-database)
+ '())))
(initrd -> (operating-system-initrd-file os))
(params (operating-system-boot-parameters-file os)))
(return `(("kernel" ,kernel)
Ivan Kozlov <kanichos@HIDDEN>:guix-patches@HIDDEN.
Full text available.guix-patches@HIDDEN:bug#40430; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.