X-Loop: help-debbugs@HIDDEN Subject: [bug#52712] [PATCH v2 4/4] services: cuirass: Ensure correct ownership of directory trees. Resent-From: Brice Waegeneire <brice@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: guix-patches@HIDDEN Resent-Date: Tue, 21 Dec 2021 19:37:01 +0000 Resent-Message-ID: <handler.52712.B.164011541727355 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 52712 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 52712 <at> debbugs.gnu.org X-Debbugs-Original-To: guix-patches@HIDDEN Received: via spool by submit <at> debbugs.gnu.org id=B.164011541727355 (code B ref -1); Tue, 21 Dec 2021 19:37:01 +0000 Received: (at submit) by debbugs.gnu.org; 21 Dec 2021 19:36:57 +0000 Received: from localhost ([127.0.0.1]:55693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mzkwT-000777-77 for submit <at> debbugs.gnu.org; Tue, 21 Dec 2021 14:36:57 -0500 Received: from lists.gnu.org ([209.51.188.17]:37522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <brice@HIDDEN>) id 1mzkwS-00076t-0q for submit <at> debbugs.gnu.org; Tue, 21 Dec 2021 14:36:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <brice@HIDDEN>) id 1mzkwR-0001wI-Dx for guix-patches@HIDDEN; Tue, 21 Dec 2021 14:36:55 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:42477) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <brice@HIDDEN>) id 1mzkwP-0004Et-A5 for guix-patches@HIDDEN; Tue, 21 Dec 2021 14:36:54 -0500 Received: (Authenticated sender: brice@HIDDEN) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id C450D240002 for <guix-patches@HIDDEN>; Tue, 21 Dec 2021 19:36:51 +0000 (UTC) From: Brice Waegeneire <brice@HIDDEN> Date: Tue, 21 Dec 2021 20:36:46 +0100 Message-Id: <20211221193646.16849-4-brice@HIDDEN> X-Mailer: git-send-email 2.34.0 In-Reply-To: <8735mleoxo.fsf_-_@HIDDEN> References: <8735mleoxo.fsf_-_@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=217.70.183.193; envelope-from=brice@HIDDEN; helo=relay1-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.7 (--) * gnu/services/cuirass.scm (cuirass-activation): Replace 'chown' calls by 'lchown-recursive'. --- gnu/services/cuirass.scm | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/gnu/services/cuirass.scm b/gnu/services/cuirass.scm index 96f28a9670..41e45604dd 100644 --- a/gnu/services/cuirass.scm +++ b/gnu/services/cuirass.scm @@ -5,6 +5,7 @@ ;;; Copyright © 2017 Jan Nieuwenhuizen <janneke@HIDDEN> ;;; Copyright © 2018, 2019 Ricardo Wurmus <rekado@HIDDEN> ;;; Copyright © 2018 Clément Lassieur <clement@HIDDEN> +;;; Copyright © 2021 Brice Waegeneire <brice@HIDDEN> ;;; ;;; This file is part of GNU Guix. ;;; @@ -24,6 +25,7 @@ (define-module (gnu services cuirass) #:use-module (guix channels) #:use-module (guix gexp) + #:use-module (guix modules) #:use-module (guix records) #:use-module (guix store) #:use-module (guix utils) @@ -278,9 +280,11 @@ (define (cuirass-activation config) (profile (string-append "/var/guix/profiles/per-user/" user)) (roots (string-append profile "/cuirass")) (group (cuirass-configuration-group config))) - (with-imported-modules '((guix build utils)) + (with-imported-modules (source-module-closure + '((gnu build activation))) #~(begin - (use-modules (guix build utils)) + (use-modules (guix build utils) + (gnu build activation)) (mkdir-p #$cache) (mkdir-p #$log) @@ -291,13 +295,13 @@ (define (cuirass-activation config) (let ((uid (passwd:uid (getpw #$user))) (gid (group:gid (getgr #$group)))) - (chown #$cache uid gid) - (chown #$log uid gid) - (chown #$roots uid gid) - (chown #$profile uid gid) + (lchown-recursive #$cache uid gid) + (lchown-recursive #$log uid gid) + (lchown-recursive #$profile uid gid) + (lchown-recursive (passwd:dir (getpw #$user)) uid gid) (when #$remote-cache - (chown #$remote-cache uid gid))))))) + (lchown-recursive #$remote-cache uid gid))))))) (define (cuirass-log-rotations config) "Return the list of log rotations that corresponds to CONFIG." -- 2.34.0
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Brice Waegeneire <brice@HIDDEN> Subject: bug#52712: Acknowledgement ([PATCH v2 4/4] services: cuirass: Ensure correct ownership of directory trees.) Message-ID: <handler.52712.B.164011541727355.ack <at> debbugs.gnu.org> References: <20211221193646.16849-4-brice@HIDDEN> X-Gnu-PR-Message: ack 52712 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 52712 <at> debbugs.gnu.org Date: Tue, 21 Dec 2021 19:37:01 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): guix-patches@HIDDEN If you wish to submit further information on this problem, please send it to 52712 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 52712: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D52712 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
Received: (at control) by debbugs.gnu.org; 21 Dec 2021 20:11:14 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Dec 21 15:11:14 2021 Received: from localhost ([127.0.0.1]:55768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1mzlTe-00083g-5l for submit <at> debbugs.gnu.org; Tue, 21 Dec 2021 15:11:14 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:34747) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <brice@HIDDEN>) id 1mzlTc-00083T-RW for control <at> debbugs.gnu.org; Tue, 21 Dec 2021 15:11:13 -0500 Received: (Authenticated sender: brice@HIDDEN) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 428E3FF809 for <control <at> debbugs.gnu.org>; Tue, 21 Dec 2021 20:11:07 +0000 (UTC) Date: Tue, 21 Dec 2021 21:11:06 +0100 To: control <at> debbugs.gnu.org From: Brice Waegeneire <brice@HIDDEN> Subject: control message for bug #52712 X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Message-Id: <E1mzlTe-00083g-5l <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) merge 52712 52454 quit
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.