GNU logs - #54165, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#54165] [PATCH] gnu: guile-bytestructures: Update to 2.0.1.
Resent-From: Taylan Kammer <taylan.kammer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 25 Feb 2022 20:52:01 +0000
Resent-Message-ID: <handler.54165.B.16458222883415 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 54165 <at> debbugs.gnu.org
Message-ID: <77e3dbeb-5d43-5450-075c-e74fccfff626@HIDDEN>
Date: Fri, 25 Feb 2022 21:51:10 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Content-Language: en-US
From: Taylan Kammer <taylan.kammer@HIDDEN>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Received-SPF: pass client-ip=2a00:1450:4864:20::62e;
 envelope-from=taylan.kammer@HIDDEN; helo=mail-ej1-x62e.google.com
X-Spam_score_int: -6
X-Spam_score: -0.7
X-Spam_bar: /
X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

* gnu/packages/guile.scm (guile-bytestructures): Update to 2.0.1.

Although the major version number is increased due to a small API-breaking
change, all packages that depend on guile-bytestructures still build fine and
pass their test suite if they have one, so it should not be necessary to
create a bytestructures-2.0 package.

The breaking change is that bs:pointer would previously implicitly dereference
the pointer when any index other than '* was provided, whereas in this version
the dereference must be explicit, and can be '* or an integer that represents
an offset from the pointer address a la *(ptr + i) in C.
---
 gnu/packages/guile.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm
index f74a389da5..1ac1690455 100644
--- a/gnu/packages/guile.scm
+++ b/gnu/packages/guile.scm
@@ -746,7 +746,7 @@ Guile's foreign function interface.")
 (define-public guile-bytestructures
   (package
     (name "guile-bytestructures")
-    (version "1.0.10")
+    (version "2.0.1")
     (home-page "https://github.com/TaylanUB/scheme-bytestructures")
     (source (origin
               (method git-fetch)
@@ -756,7 +756,7 @@ Guile's foreign function interface.")
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "14k50jln32kkxv41hvsdgjkkfj6xlv06vc1caz01qkgk1fzh72nk"))))
+                "1gnh3p2042cch1nkapl0p4pv20q7qs8cxvvbp7a5h1dwqbrkdyss"))))
     (build-system gnu-build-system)
     (arguments
      `(#:make-flags '("GUILE_AUTO_COMPILE=0")     ;to prevent guild warnings
-- 
2.30.2

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Taylan Kammer <taylan.kammer@HIDDEN>
Subject: bug#54165: Acknowledgement ([PATCH] gnu: guile-bytestructures:
 Update to 2.0.1.)
Message-ID: <handler.54165.B.16458222883415.ack <at> debbugs.gnu.org>
References: <77e3dbeb-5d43-5450-075c-e74fccfff626@HIDDEN>
X-Gnu-PR-Message: ack 54165
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 54165 <at> debbugs.gnu.org
Date: Fri, 25 Feb 2022 20:52:01 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 54165 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
54165: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D54165
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#54165] [PATCH] gnu: guile-bytestructures: Update to 2.0.1.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 01 Mar 2022 11:39:01 +0000
Resent-Message-ID: <handler.54165.B54165.164613469222098 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Taylan Kammer <taylan.kammer@HIDDEN>
Cc: 54165 <at> debbugs.gnu.org
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
References: <77e3dbeb-5d43-5450-075c-e74fccfff626@HIDDEN>
Date: Tue, 01 Mar 2022 12:38:02 +0100
In-Reply-To: <77e3dbeb-5d43-5450-075c-e74fccfff626@HIDDEN> (Taylan Kammer's
 message of "Fri, 25 Feb 2022 21:51:10 +0100")
Message-ID: <87mti97vj9.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi,

Taylan Kammer <taylan.kammer@HIDDEN> skribis:

> * gnu/packages/guile.scm (guile-bytestructures): Update to 2.0.1.
>
> Although the major version number is increased due to a small API-breaking
> change, all packages that depend on guile-bytestructures still build fine=
 and
> pass their test suite if they have one, so it should not be necessary to
> create a bytestructures-2.0 package.
>
> The breaking change is that bs:pointer would previously implicitly derefe=
rence
> the pointer when any index other than '* was provided, whereas in this ve=
rsion
> the dereference must be explicit, and can be '* or an integer that repres=
ents
> an offset from the pointer address a la *(ptr + i) in C.

Since it=E2=80=99s an indirect dependency of Guix, I tested a bit more
thoroughly than for other packages.

While running this:

  ./pre-inst-env guix build guile-git -s x86_64-linux -s i686-linux -s armh=
f-linux -s aarch64-linux

I got this test failure on i686-linux:

--8<---------------cut here---------------start------------->8---
starting phase `check'
./pre-inst-env          \
  /gnu/store/pihshjqc5x3k8yhdp1nvkgwiifyxin4v-guile-3.0.7/bin/guile --no-au=
to-compile           \
  ./run-tests.guile.scm
Backtrace:
           7 (primitive-load "/tmp/guix-build-guile-bytestructures-2=E2=80=
=A6")
In ice-9/eval.scm:
    619:8  6 (_ #f)
In ice-9/boot-9.scm:
    142:2  5 (dynamic-wind #<procedure 8fca850 at ice-9/eval.scm:33=E2=80=
=A6> =E2=80=A6)
    142:2  4 (dynamic-wind #<procedure 883d3b0 at ice-9/eval.scm:33=E2=80=
=A6> =E2=80=A6)
In ice-9/eval.scm:
    619:8  3 (_ #(#(#<directory (guile-user) 8194690>)))
In ice-9/boot-9.scm:
    142:2  2 (dynamic-wind #<procedure 8845110 at ice-9/eval.scm:33=E2=80=
=A6> =E2=80=A6)
In ice-9/eval.scm:
    619:8  1 (_ #(#(#(#<directory (guile-user) 8194690>)) #<variab=E2=80=A6=
>))
In unknown file:
           0 (bytevector-u64-native-set! #vu8(0 0 0 0 0 0 0 0 65 1 =E2=80=
=A6) =E2=80=A6)

ERROR: In procedure bytevector-u64-native-set!:
In procedure bytevector-u64-native-set!: Value out of range: 8
%%%% Starting test bytestructures  (Writing full log to "bytestructures.log=
")
run-tests.body.scm:194: FAIL ref1
make: *** [Makefile:779: check] Error 1

Test suite failed, dumping logs.
error: in phase 'check': uncaught exception:
%exception #<&invoke-error program: "make" arguments: ("check" "-j" "8" "GU=
ILE_AUTO_COMPILE=3D0") exit-status: 2 term-signal: #f stop-signal: #f>=20
phase `check' failed after 1.1 seconds
command "make" "check" "-j" "8" "GUILE_AUTO_COMPILE=3D0" failed with status=
 2
builder for `/gnu/store/xkbc6a6jlg9r1lkma6zw8lfmprfsfkqw-guile-bytestructur=
es-2.0.1.drv' failed with exit code 1
--8<---------------cut here---------------end--------------->8---

With:

  ./pre-inst-env guix build -v1 guile-drmaa nyacc nyacc@HIDDEN guile-lzma

I got this nyacc test failure:

--8<---------------cut here---------------start------------->8---
GUILE_LOAD_PATH=3D/tmp/guix-build-nyacc-1.00.2.drv-0/nyacc-1.00.2/module GU=
ILE_LOAD_COMPILED_PATH=3D/tmp/guix-build-nyacc-1.00.2.drv-0/nyacc-1.00.2/mo=
dule \
  /tmp/guix-build-nyacc-1.00.2.drv-0/nyacc-1.00.2/etc/guild compile -o syst=
em/ffi-help-rt.go system/ffi-help-rt.scm
;;; note: auto-compilation is enabled, set GUILE_AUTO_COMPILE=3D0
;;;       or pass the --no-auto-compile argument to disable.
;;; compiling /tmp/guix-build-nyacc-1.00.2.drv-0/nyacc-1.00.2/etc/guild
;;; WARNING: compilation of /tmp/guix-build-nyacc-1.00.2.drv-0/nyacc-1.00.2=
/etc/guild failed:
;;; failed to create path for auto-compiled file "/tmp/guix-build-nyacc-1.0=
0.2.drv-0/nyacc-1.00.2/etc/guild"
Backtrace:
In system/base/target.scm:
     65:6 19 (with-target _ _)
In system/base/compile.scm:
    187:6 18 (compile-file "system/ffi-help-rt.scm" #:output-file _ # =E2=
=80=A6)
     53:4 17 (call-with-output-file/atomic _ _ _)
In ice-9/boot-9.scm:
  1752:10 16 (with-exception-handler _ _ #:unwind? _ # _)
In system/base/compile.scm:
    69:11 15 (_)
   190:11 14 (_ #<closed: file 7fffedfe4150>)
   331:39 13 (read-and-compile #<input: system/ffi-help-rt.scm 15> # =E2=80=
=A6)
   261:27 12 (_ _ _)
In ice-9/boot-9.scm:
   2835:4 11 (save-module-excursion #<procedure 7fffee7e3c00 at lang=E2=80=
=A6>)
In language/scheme/compile-tree-il.scm:
    31:15 10 (_)
In ice-9/psyntax.scm:
  1230:36  9 (expand-top-sequence (#<syntax:ffi-help-rt.scm:20:0 (=E2=80=A6=
>) =E2=80=A6)
  1222:19  8 (parse _ (("placeholder" placeholder)) ((top) #(# # =E2=80=A6)=
) =E2=80=A6)
   259:10  7 (parse _ (("placeholder" placeholder)) (()) _ c&e (# #) #)
In ice-9/eval.scm:
   293:34  6 (_ #<module (#{ g100}#) 7fffee85c280>)
In ice-9/boot-9.scm:
   3409:4  5 (define-module* _ #:filename _ #:pure _ #:version _ # _ =E2=80=
=A6)
  2594:24  4 (call-with-deferred-observers #<procedure 7fffefc7b1e0 =E2=80=
=A6>)
  3422:24  3 (_)
   222:17  2 (map1 (((bytestructures guile)) ((bytestructures # =E2=80=A6))=
 =E2=80=A6))
   3329:6  1 (resolve-interface (bytestructures guile) #:select _ # _ =E2=
=80=A6)
  1685:16  0 (raise-exception _ #:continuable? _)

ice-9/boot-9.scm:1685:16: In procedure raise-exception:
no code for module (bytestructures guile)
make[1]: *** [Makefile:93: system/ffi-help-rt.go] Error 1

[=E2=80=A6]

@ build-failed /gnu/store/qsnsix75inib689w6yr7a335xch13wk0-nyacc-1.00.2.drv=
 - 1 builder for `/gnu/store/qsnsix75inib689w6yr7a335xch13wk0-nyacc-1.00.2.=
drv' failed with exit code 1
--8<---------------cut here---------------end--------------->8---

Could you take a look?

Thanks,
Ludo=E2=80=99.

Message sent to ludo@HIDDEN, guix-patches@HIDDEN:

Subject: [bug#54165] [PATCH v2 1/2] gnu: guile-bytestructures: Update to 2.0.1.
Resent-From: Felix Lechner <felix.lechner@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: ludo@HIDDEN, guix-patches@HIDDEN
Resent-Date: Fri, 07 Jun 2024 13:48:02 +0000
Resent-Message-ID: <handler.54165.B54165.171776807529345 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 54165@HIDDEN
Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Taylan Kammer <taylan.kammer@HIDDEN>, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
From: Felix Lechner <felix.lechner@HIDDEN>
Date: Fri,  7 Jun 2024 06:44:55 -0700
Message-ID: <c48b47ba696a8068fda077c9a8e2a167bc21c677.1717767896.git.felix.lechner@HIDDEN>
In-Reply-To: <87mti97vj9.fsf@HIDDEN>
References: <87mti97vj9.fsf@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

From: Taylan Kammer <taylan.kammer@HIDDEN>

* gnu/packages/guile.scm (guile-bytestructures): Update to 2.0.1.

Although the major version number is increased due to a small API-breaking
change, all packages that depend on guile-bytestructures still build fine and
pass their test suite if they have one, so it should not be necessary to
create a bytestructures-2.0 package.

The breaking change is that bs:pointer would previously implicitly dereference
the pointer when any index other than '* was provided, whereas in this version
the dereference must be explicit, and can be '* or an integer that represents
an offset from the pointer address a la *(ptr + i) in C.
---
 gnu/packages/guile.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm
index e8705dc7d2..0bbd4a12ad 100644
--- a/gnu/packages/guile.scm
+++ b/gnu/packages/guile.scm
@@ -786,7 +786,7 @@ (define-public guile2.2-sqlite3
 (define-public guile-bytestructures
   (package
     (name "guile-bytestructures")
-    (version "1.0.10")
+    (version "2.0.1")
     (home-page "https://github.com/TaylanUB/scheme-bytestructures")
     (source (origin
               (method git-fetch)
@@ -796,7 +796,7 @@ (define-public guile-bytestructures
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "14k50jln32kkxv41hvsdgjkkfj6xlv06vc1caz01qkgk1fzh72nk"))))
+                "1gnh3p2042cch1nkapl0p4pv20q7qs8cxvvbp7a5h1dwqbrkdyss"))))
     (build-system gnu-build-system)
     (arguments
      `(#:make-flags '("GUILE_AUTO_COMPILE=0")     ;to prevent guild warnings

base-commit: 580d77d0fb12448ef1621699cc0c56e787e2aadb
-- 
2.41.0

Message sent to ludo@HIDDEN, guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#54165] [PATCH v2 2/2] gnu: guile-bytestructures: add patch. (Closes: #54165)
Resent-From: Felix Lechner <felix.lechner@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: ludo@HIDDEN, guix-patches@HIDDEN
Resent-Date: Fri, 07 Jun 2024 13:48:02 +0000
Resent-Message-ID: <handler.54165.B54165.171776807729360 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54165
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 54165@HIDDEN
Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Taylan Kammer <taylan.kammer@HIDDEN>, Felix Lechner <felix.lechner@HIDDEN>, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
X-Debbugs-Original-Xcc: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Received: via spool by 54165-submit <at> debbugs.gnu.org id=B54165.171776807729360
          (code B ref 54165); Fri, 07 Jun 2024 13:48:02 +0000
Received: (at 54165) by debbugs.gnu.org; 7 Jun 2024 13:47:57 +0000
Received: from localhost ([127.0.0.1]:58414 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sFZwj-0007dR-5Q
	for submit <at> debbugs.gnu.org; Fri, 07 Jun 2024 09:47:57 -0400
Received: from sail-ipv4.us-core.com ([208.82.101.137]:53056)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <felix.lechner@HIDDEN>) id 1sFZwf-0007cy-7G
 for 54165 <at> debbugs.gnu.org; Fri, 07 Jun 2024 09:47:53 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=Hi+RA7HckCr0HXh
 Hm5YhGEh25t5alTUiElEWHlhrM/U=;
 h=references:in-reply-to:date:subject:
 cc:to:from; d=lease-up.com; b=jKH6sLk7g/NWgWdVCOp9su7+XUpkOkpzfejnwq7M
 gES9G7AXu/DvXjdmOthRagc/Wdkn++4R4unT5dze9wL3lOOdIskf546VWCYTbVoSdoBdZw
 nnoNXELn1HYjj5kStvx/7J98+IzjMgBqtSrflO9XFyqJgXoAcHCi6EGpu9Cko=
Received: by localhost (OpenSMTPD) with ESMTPA id 27dd4d28
 for <54165 <at> debbugs.gnu.org>; Fri, 7 Jun 2024 13:47:36 +0000 (UTC)
Delivered-To: 54165@HIDDEN
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=Hi+RA7HckCr0HXh
 Hm5YhGEh25t5alTUiElEWHlhrM/U=;
 h=references:in-reply-to:date:subject:
 cc:to:from; d=lease-up.com; b=jKH6sLk7g/NWgWdVCOp9su7+XUpkOkpzfejnwq7M
 gES9G7AXu/DvXjdmOthRagc/Wdkn++4R4unT5dze9wL3lOOdIskf546VWCYTbVoSdoBdZw
 nnoNXELn1HYjj5kStvx/7J98+IzjMgBqtSrflO9XFyqJgXoAcHCi6EGpu9Cko=
Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 67c7b5e1
 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); 
 Fri, 7 Jun 2024 13:47:36 +0000 (UTC)
Received: from localhost (localhost [local])
 by localhost (OpenSMTPD) with ESMTPA id a090640d;
 Fri, 7 Jun 2024 13:47:35 +0000 (UTC)
From: Felix Lechner <felix.lechner@HIDDEN>
Date: Fri,  7 Jun 2024 06:44:56 -0700
Message-ID: <eff1f3146d51e82bbc6a2bc3c8e9e98aab6e82c7.1717767896.git.felix.lechner@HIDDEN>
X-Mailer: git-send-email 2.41.0
In-Reply-To: <87mti97vj9.fsf@HIDDEN>
References: <87mti97vj9.fsf@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.2 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)

Adds the patch from a pull request recently submitted upstream. [1] The
maintainer has not responded yet, so there could be further updates as time
goes on.

With this commit, nyacc 1.08.1 builds successfully..

[1] https://github.com/TaylanUB/scheme-bytestructures/pull/48

Change-Id: I8cd248e6e33efd36f54ca3b31c17badf54a863c5
---
 gnu/packages/guile.scm                        |  3 +-
 .../guile-bytestructures-fix-54165.patch      | 92 +++++++++++++++++++
 2 files changed, 94 insertions(+), 1 deletion(-)
 create mode 100644 gnu/packages/patches/guile-bytestructures-fix-54165.patch

diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm
index 0bbd4a12ad..f7ef0dceff 100644
--- a/gnu/packages/guile.scm
+++ b/gnu/packages/guile.scm
@@ -796,7 +796,8 @@ (define-public guile-bytestructures
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "1gnh3p2042cch1nkapl0p4pv20q7qs8cxvvbp7a5h1dwqbrkdyss"))))
+                "1gnh3p2042cch1nkapl0p4pv20q7qs8cxvvbp7a5h1dwqbrkdyss"))
+              (patches (search-patches "guile-bytestructures-fix-54165.patch"))))
     (build-system gnu-build-system)
     (arguments
      `(#:make-flags '("GUILE_AUTO_COMPILE=0")     ;to prevent guild warnings
diff --git a/gnu/packages/patches/guile-bytestructures-fix-54165.patch b/gnu/packages/patches/guile-bytestructures-fix-54165.patch
new file mode 100644
index 0000000000..b91ca36df4
--- /dev/null
+++ b/gnu/packages/patches/guile-bytestructures-fix-54165.patch
@@ -0,0 +1,92 @@
+From 5082cdd2529f13286509a525a28f9d9917456fc1 Mon Sep 17 00:00:00 2001
+From: Felix Lechner <felix.lechner@HIDDEN>
+Date: Fri, 7 Jun 2024 04:51:17 -0700
+Subject: [PATCH] Fix alignment in unpacked structs containing unions. (Closes:
+ #47)
+
+The 2.0.1 release suffered from a test failure [1] that caused some
+distributions to disable the test [2] but the underlying cause had yet
+to be identified.
+
+Based on a preliminary review of the code, the author of this commit
+believes there was a surplus line in the code [3] which is deleted
+here.  This is the proposed evidence: The line shadowed the
+'alignment' variable in line immediately above it. [4] Then, the same
+expression was used two lines down below. [5] In combination, the line
+being removed here seems to have been left over from editing under
+time pressure. It may also have been added inadvertently.
+
+On GNU Guix, this commit fixes the 'ref1' test for aligned struct
+bytestructures containing union members, which was referenced via
+"run-tests.body.scm:194: FAIL ref1" in Ludo's original report. [6] The
+test output can be found at the bottom of this message.
+
+This commit closes Github issue #47. [7]
+
+[1] https://issues.guix.gnu.org/54165#1
+[2] https://github.com/alpinelinux/aports/commit/2d8604645ca38552343c61fbc65728a2881e6ddd
+[3] https://github.com/TaylanUB/scheme-bytestructures/blob/a6d5d25b26c0c5ef1f5fa38e2472fbf6a32cdf89/bytestructures/body/struct.scm#L110
+[4] https://github.com/TaylanUB/scheme-bytestructures/blob/a6d5d25b26c0c5ef1f5fa38e2472fbf6a32cdf89/bytestructures/body/struct.scm#L109
+[5] https://github.com/TaylanUB/scheme-bytestructures/blob/a6d5d25b26c0c5ef1f5fa38e2472fbf6a32cdf89/bytestructures/body/struct.scm#L112
+[6] https://github.com/TaylanUB/scheme-bytestructures/blob/a6d5d25b26c0c5ef1f5fa38e2472fbf6a32cdf89/run-tests.body.scm#L194
+[7] https://github.com/TaylanUB/scheme-bytestructures/issues/47
+
+* * *
+
+Group begin: aligned
+Test begin:
+  test-name: "ref1"
+  source-file: "run-tests.body.scm"
+  source-line: 194
+  source-form: (test-eqv "ref1" 321 (bytestructure-ref bs (quote a)))
+Test end:
+  result-kind: pass
+  actual-value: 321
+  expected-value: 321
+Test begin:
+  test-name: "ref2"
+  source-file: "run-tests.body.scm"
+  source-line: 196
+  source-form: (test-eqv "ref2" 456 (bytestructure-ref bs (quote b)))
+Test end:
+  result-kind: pass
+  actual-value: 456
+  expected-value: 456
+Test begin:
+  test-name: "set1"
+  source-file: "run-tests.body.scm"
+  source-line: 197
+  source-form: (test-eqv "set1" 789 (begin (bytestructure-set! bs (quote a) 789) (bytestructure-ref bs (quote a))))
+Test end:
+  result-kind: pass
+  actual-value: 789
+  expected-value: 789
+Test begin:
+  test-name: "set2"
+  source-file: "run-tests.body.scm"
+  source-line: 199
+  source-form: (test-eqv "set2" 987 (begin (bytestructure-set! bs (quote b) 987) (bytestructure-ref bs (quote b))))
+Test end:
+  result-kind: pass
+  actual-value: 987
+  expected-value: 987
+Group end: aligned
+---
+ bytestructures/body/struct.scm | 1 -
+ 1 file changed, 1 deletion(-)
+
+diff --git a/bytestructures/body/struct.scm b/bytestructures/body/struct.scm
+index 07797b5..0113a17 100644
+--- a/bytestructures/body/struct.scm
++++ b/bytestructures/body/struct.scm
+@@ -107,7 +107,6 @@
+     (let ((descriptor (cadr field-spec)))
+       (bytestructure-descriptor-size descriptor)))
+   (let* ((alignment (apply max (map field-spec-alignment field-specs)))
+-         (alignment (pack-alignment pack alignment))
+          (size (apply max (map field-spec-size field-specs)))
+          (position (align position size (pack-alignment pack alignment))))
+     (let loop ((field-specs field-specs)
+-- 
+2.41.0
+
-- 
2.41.0

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#54165] Update guile-bytestructures to 2.0.2.
Resent-From: Vagrant Cascadian <vagrant@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 20 Aug 2024 19:14:01 +0000
Resent-Message-ID: <handler.54165.B54165.172418119413255 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54165
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 54165 <at> debbugs.gnu.org
Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Taylan Kammer <taylan.kammer@HIDDEN>, Felix Lechner <felix.lechner@HIDDEN>
Received: via spool by 54165-submit <at> debbugs.gnu.org id=B54165.172418119413255
          (code B ref 54165); Tue, 20 Aug 2024 19:14:01 +0000
Received: (at 54165) by debbugs.gnu.org; 20 Aug 2024 19:13:14 +0000
Received: from localhost ([127.0.0.1]:33669 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sgUI6-0003Rj-0t
	for submit <at> debbugs.gnu.org; Tue, 20 Aug 2024 15:13:14 -0400
Received: from cascadia.aikidev.net ([173.255.214.101]:33850)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vagrant@HIDDEN>) id 1sgUI3-0003RW-G1
 for 54165 <at> debbugs.gnu.org; Tue, 20 Aug 2024 15:13:12 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org;
 s=1.vagrant.user; t=1724181111;
 bh=/P7fkOSs1IL1ohR7b9TfwGz9WcAbJtFtQrtypmQh8yQ=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=V81OT/ZxUGYRz0XMjg7ctUIKO/KBypKLWdBBHE7Ru0Z9iFiVtACeu1/TFdzpoRW+d
 umkHawqtqsdf66X5zqCrbZn8XVMeZGOHWcWnHeX6nOcfVnUi1MYgR97ZkHMRmMDF6/
 VATiUviozV7XFX59oKse6EYxAc8TsUSawK9+Zq7JQHltyfTrzFGx5puOI0HIfgRUjS
 Dk4vyXE3pzRvsbN4Nn98UGXgbyF8TJiFYA/l6VCIVyi34XArl8nJTgRSDjUvyy1wk7
 n3tULNrrahinqaSzL5WI296y5McE486gfIYFUAiATKfXXPehaAXXd4j6OO2ESAIk7k
 T7kIZcf7zdTkw==
Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50])
 by cascadia.aikidev.net (Postfix) with ESMTPSA id 9572B168A;
 Tue, 20 Aug 2024 12:11:51 -0700 (PDT)
From: Vagrant Cascadian <vagrant@HIDDEN>
In-Reply-To: <c48b47ba696a8068fda077c9a8e2a167bc21c677.1717767896.git.felix.lechner@HIDDEN>
References: <87mti97vj9.fsf@HIDDEN>
 <c48b47ba696a8068fda077c9a8e2a167bc21c677.1717767896.git.felix.lechner@HIDDEN>
Date: Tue, 20 Aug 2024 12:11:46 -0700
Message-ID: <87seuzj9fx.fsf@wireframe>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="==-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--==-=-=
Content-Type: multipart/mixed; boundary="=-=-="

--=-=-=
Content-Type: text/plain

The attached patch updates to guile-bytestructures 2.0.2.

I am not sure if the other previously suggested changes are still
needed; I did successfully build most of the packages listed by "guix
refresh --list-dependent" other than guix-jupyter... though I only
tested on x86_64. Hopefully QA picks this up and gives us better
information.

FWIW, the updated guile-bytestructures seems to work fine in Debian. :)

live well,
  vagrant

--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline;
 filename=0001-gnu-guile-bytestructures-Update-to-2.0.2.patch
Content-Transfer-Encoding: quoted-printable

From=2056dd4f2f1635c450bd62138c9c0e92f77427576f Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@HIDDEN>
Date: Tue, 20 Aug 2024 11:57:29 -0700
Subject: [PATCH] gnu: guile-bytestructures: Update to 2.0.2.

* gnu/packages/guile.scm (guile-bytestructures): Update to 2.0.2.
[source]: Adjust tag used to fetch git commit.
=2D--
 gnu/packages/guile.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm
index e8705dc7d2..581f188dbe 100644
=2D-- a/gnu/packages/guile.scm
+++ b/gnu/packages/guile.scm
@@ -786,17 +786,17 @@ (define-public guile2.2-sqlite3
 (define-public guile-bytestructures
   (package
     (name "guile-bytestructures")
=2D    (version "1.0.10")
+    (version "2.0.2")
     (home-page "https://github.com/TaylanUB/scheme-bytestructures")
     (source (origin
               (method git-fetch)
               (uri (git-reference
                     (url home-page)
=2D                    (commit version)))
+                    (commit (string-append "v" version))))
               (file-name (git-file-name name version))
               (sha256
                (base32
=2D                "14k50jln32kkxv41hvsdgjkkfj6xlv06vc1caz01qkgk1fzh72nk"))=
))
+                "1dyhf39s16q3fvps0mfb65xrlcb8rk8m5kc82ngkwhzmf1svalpc"))))
     (build-system gnu-build-system)
     (arguments
      `(#:make-flags '("GUILE_AUTO_COMPILE=3D0")     ;to prevent guild warn=
ings

base-commit: bef48dd553aef3c8fb3bc48143739debb629c825
=2D-=20
2.39.2


--=-=-=--

--==-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZsTqcgAKCRDcUY/If5cW
qpHsAP9vKW9R94ZSIeHxDpBN5Rao9Vqip+8SpAUO1hImmfHcwwD+NPYJPNhY+uP6
hg6eBypEOL7QPtQE+leNE43kmzO69A8=
=9F/9
-----END PGP SIGNATURE-----
--==-=-=--

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.