X-Loop: help-debbugs@HIDDEN
Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build
Resent-From: Cees de Groot <cg@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 08 Mar 2022 20:53:01 +0000
Resent-Message-ID: <handler.54304.B.164677273725968 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 54304
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 54304 <at> debbugs.gnu.org
X-Debbugs-Original-To: "guix-patches@HIDDEN" <guix-patches@HIDDEN>
Reply-To: Cees de Groot <cg@HIDDEN>
Received: via spool by submit <at> debbugs.gnu.org id=B.164677273725968
(code B ref -1); Tue, 08 Mar 2022 20:53:01 +0000
Received: (at submit) by debbugs.gnu.org; 8 Mar 2022 20:52:17 +0000
Received: from localhost ([127.0.0.1]:58020 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nRgob-0006km-2E
for submit <at> debbugs.gnu.org; Tue, 08 Mar 2022 15:52:17 -0500
Received: from lists.gnu.org ([209.51.188.17]:36996)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <cg@HIDDEN>) id 1nRgoZ-0006kf-K8
for submit <at> debbugs.gnu.org; Tue, 08 Mar 2022 15:52:16 -0500
Received: from eggs.gnu.org ([209.51.188.92]:42404)
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <cg@HIDDEN>) id 1nRgoZ-00050x-Ct
for guix-patches@HIDDEN; Tue, 08 Mar 2022 15:52:15 -0500
Received: from mail-4323.proton.ch ([185.70.43.23]:58905)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <cg@HIDDEN>) id 1nRgoV-00027J-UL
for guix-patches@HIDDEN; Tue, 08 Mar 2022 15:52:14 -0500
Date: Tue, 08 Mar 2022 20:52:00 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=evrl.com;
s=protonmail3; t=1646772722;
bh=+UJykmJ3PV5R2EtV86yqRtp/UWUCO1WG1pV5QoyPy5U=;
h=Date:To:From:Reply-To:Subject:Message-ID:From:To:Cc:Date:Subject:
Reply-To:Feedback-ID:Message-ID;
b=Q+IDzC0oPCOCrFAK110NItyz9xM3BpF8b+BHt4wMorAG9opz9sKUP2NnNd9QGFY4U
Sr7eOt2Lrho94N4C3PjcxNZUloxLlYU2vjPcEorqUjIIV+RpSgYMrxdU5Fkg3dN2Sx
WyLgWbLnRbcMnyqLuCqc7mZIyK85DXmyh2AMHDxvZgxWUeB32Ub4Yf37H3/zuoOBQa
TFtYfRxr0B5g663VgwNmyNjJzDVX7qf12ZTZFg5w1DN1y/iPZ8tpIc7q5ZFuCuGqwR
RXJwCjZfDOFyXTGCM9IRxe37GQQxn2UYqmkRF09WtKnlNwRfAcdDwj0+8Z8Gt1y0Jz
WqpAJm9FUXfLw==
From: Cees de Groot <cg@HIDDEN>
Message-ID: <vJt9-EGxCcqYcRJpPwLXHo3DPOa8pdhHUN3rrKNuV7BI-evzYt_zYqj_XgYNdYE5Xv5OOf1U4fIsOPa0lBOWSh5fqKBrxxoeF1w3PkEAKiA=@evrl.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=185.70.43.23; envelope-from=cg@HIDDEN;
helo=mail-4323.proton.ch
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)
The removed code below affected two locations where Elixir uses Git:
* At build-time, Git is used to see if the build is inside a Git repo and i=
f so, git info
is added to the build information that Elixir returns with `System.build_=
info()`. The code
uses PATH + `git` so the Git version from the inputs is used which is jus=
t fine.
* At run-time, Git is used by Mix if, and only if, there are any Git-based =
dependencies. This
is not the normal case, and in that sense Git is an optional dependency o=
f Elixir - most
projects will work just fine without Git being present. Here, too, PATH +=
`git` is used
so if there is a need on a user's system to use Git-based dependencies, t=
he user can just
add the package to the profile and things will just work.
I feel that leaving this alone is cleaner than trying to fix the dependency=
(if we want to
keep it, it needs to be in propagated-inputs in order to keep Git around; I=
stumbled upon
this building a project with Git dependencies after doing a `guix gc`. Howe=
ver, given that
using Git dependencies is the exception and I think that minimizing depende=
ncies is nicer
I opted to just remove the substition completely).
---
gnu/packages/elixir.scm | 5 -----
1 file changed, 5 deletions(-)
diff --git a/gnu/packages/elixir.scm b/gnu/packages/elixir.scm
index 55e17f2901..f509c59ee3 100644
--- a/gnu/packages/elixir.scm
+++ b/gnu/packages/elixir.scm
@@ -60,11 +60,6 @@ (define-public elixir
(for-each make-file-writable (find-files "."))))
(add-after 'make-git-checkout-writable 'replace-paths
(lambda* (#:key inputs #:allow-other-keys)
- (substitute* '("lib/elixir/lib/system.ex"
- "lib/mix/lib/mix/scm/git.ex")
- (("(cmd\\(['\"])git" _ prefix)
- (string-append prefix
- (search-input-file inputs "/bin/git"))))
(substitute* '("lib/mix/lib/mix/release.ex"
"lib/mix/lib/mix/tasks/release.init.ex")
(("#!/bin/sh")
--
2.34.0
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Cees de Groot <cg@HIDDEN> Subject: bug#54304: Acknowledgement ([PATCH] Don't fix git executable location during Elixir build) Message-ID: <handler.54304.B.164677273725968.ack <at> debbugs.gnu.org> References: <vJt9-EGxCcqYcRJpPwLXHo3DPOa8pdhHUN3rrKNuV7BI-evzYt_zYqj_XgYNdYE5Xv5OOf1U4fIsOPa0lBOWSh5fqKBrxxoeF1w3PkEAKiA=@evrl.com> X-Gnu-PR-Message: ack 54304 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 54304 <at> debbugs.gnu.org Date: Tue, 08 Mar 2022 20:53:01 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): guix-patches@HIDDEN If you wish to submit further information on this problem, please send it to 54304 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 54304: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D54304 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 08 Mar 2022 22:17:02 +0000
Resent-Message-ID: <handler.54304.B54304.164677780710302 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54304
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Cees de Groot <cg@HIDDEN>, 54304 <at> debbugs.gnu.org
Received: via spool by 54304-submit <at> debbugs.gnu.org id=B54304.164677780710302
(code B ref 54304); Tue, 08 Mar 2022 22:17:02 +0000
Received: (at 54304) by debbugs.gnu.org; 8 Mar 2022 22:16:47 +0000
Received: from localhost ([127.0.0.1]:58062 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nRi8N-0002g6-MT
for submit <at> debbugs.gnu.org; Tue, 08 Mar 2022 17:16:47 -0500
Received: from laurent.telenet-ops.be ([195.130.137.89]:47436)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maximedevos@HIDDEN>) id 1nRi8L-0002fu-7e
for 54304 <at> debbugs.gnu.org; Tue, 08 Mar 2022 17:16:46 -0500
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
by laurent.telenet-ops.be with bizsmtp
id 3yGj270024UW6Th01yGjMk; Tue, 08 Mar 2022 23:16:43 +0100
Message-ID: <5e1d2abc1008c43dd70a85999420d529980c2bd1.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Tue, 08 Mar 2022 23:16:39 +0100
In-Reply-To: <vJt9-EGxCcqYcRJpPwLXHo3DPOa8pdhHUN3rrKNuV7BI-evzYt_zYqj_XgYNdYE5Xv5OOf1U4fIsOPa0lBOWSh5fqKBrxxoeF1w3PkEAKiA=@evrl.com>
References: <vJt9-EGxCcqYcRJpPwLXHo3DPOa8pdhHUN3rrKNuV7BI-evzYt_zYqj_XgYNdYE5Xv5OOf1U4fIsOPa0lBOWSh5fqKBrxxoeF1w3PkEAKiA=@evrl.com>
Content-Type: multipart/signed; micalg="pgp-sha512";
protocol="application/pgp-signature"; boundary="=-B173se/SuPuHkm+OXWBt"
User-Agent: Evolution 3.38.3-1
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
t=1646777803; bh=aauHOZDDCDajSwiFkX8qj69ZCftMK3vLwJ4GdYIQkNw=;
h=Subject:From:To:Date:In-Reply-To:References;
b=KfDB2kDtH6Wu+gFPIvxhCyp6ISro8uTLEsfb6Iu9BojPtcKehQcRdjv1iINIcC4kF
wZvNztBqin2DPldxvVVPAnnHun3MDtHNWwhGt0vHME3AtrRq3QKJy48JKKKMfX3VNQ
RMpiqmiXzhPU5j065u11vmnyYdx1PBSrQVRWGU2Y7c+tqSxjJ3Mz6WfjYfOf96JHSQ
w9zUqVL7/OhsXMew6a0OxFYp72oNWQoMxd37kscVeMdMKMGhRw0+oNO1qZwlL9/H2p
2MHMoaO2Y2PhUBdI73jmOo2H2n1iDR6DEDD+wKFw1jvh3it+fzxB/f1WU1QvPegdte
s8W+84iWS+W8g==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
--=-B173se/SuPuHkm+OXWBt
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cees de Groot schreef op di 08-03-2022 om 20:52 [+0000]:
> I feel that leaving this alone is cleaner than trying to fix the dependen=
cy (if we want to
> keep it, it needs to be in propagated-inputs in order to keep Git around;
Instead of propagation, I recommend substitution, like done currently.
Propagation is not necessary to =E2=80=98keep git around=E2=80=99 (assuming=
that the
store reference is not obfuscated by gzipping or the like).
If it's used at build-time instead of run-time, then git should be
moved to native-inputs, for cross-compilation reasons.
Greetings,
Maxime
--=-B173se/SuPuHkm+OXWBt
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYifVxxccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7tv0AQDJoIGfzPsjTnIGId3E+kcY04qZ
mk3MxZ8RCkkj0jcN/QD/c9Z/61ESb6clBTp9GPzKT92dtM4LEXEr1gTqRyCMeQc=
=P2yc
-----END PGP SIGNATURE-----
--=-B173se/SuPuHkm+OXWBt--
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 08 Mar 2022 22:18:01 +0000
Resent-Message-ID: <handler.54304.B54304.164677787010418 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54304
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Cees de Groot <cg@HIDDEN>, 54304 <at> debbugs.gnu.org
Received: via spool by 54304-submit <at> debbugs.gnu.org id=B54304.164677787010418
(code B ref 54304); Tue, 08 Mar 2022 22:18:01 +0000
Received: (at 54304) by debbugs.gnu.org; 8 Mar 2022 22:17:50 +0000
Received: from localhost ([127.0.0.1]:58067 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nRi9O-0002hy-0Y
for submit <at> debbugs.gnu.org; Tue, 08 Mar 2022 17:17:50 -0500
Received: from michel.telenet-ops.be ([195.130.137.88]:53776)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maximedevos@HIDDEN>) id 1nRi9L-0002hn-M7
for 54304 <at> debbugs.gnu.org; Tue, 08 Mar 2022 17:17:48 -0500
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
by michel.telenet-ops.be with bizsmtp
id 3yHm270034UW6Th06yHmeo; Tue, 08 Mar 2022 23:17:46 +0100
Message-ID: <d40072710db6d1352dba3664f881c47411100788.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Tue, 08 Mar 2022 23:17:46 +0100
In-Reply-To: <vJt9-EGxCcqYcRJpPwLXHo3DPOa8pdhHUN3rrKNuV7BI-evzYt_zYqj_XgYNdYE5Xv5OOf1U4fIsOPa0lBOWSh5fqKBrxxoeF1w3PkEAKiA=@evrl.com>
References: <vJt9-EGxCcqYcRJpPwLXHo3DPOa8pdhHUN3rrKNuV7BI-evzYt_zYqj_XgYNdYE5Xv5OOf1U4fIsOPa0lBOWSh5fqKBrxxoeF1w3PkEAKiA=@evrl.com>
Content-Type: multipart/signed; micalg="pgp-sha512";
protocol="application/pgp-signature"; boundary="=-VO3ivcgAnqIhSpvw18kI"
User-Agent: Evolution 3.38.3-1
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
t=1646777866; bh=MtqDbKN9ifoz4jeKyleAIF7z5ENP0369mxnpBfWIjRk=;
h=Subject:From:To:Date:In-Reply-To:References;
b=hV8jp7EtEyWf10p7GoxOQt/eBOlGAvSAEBPW6JPYNlWh7J1NWlqXQRKlGAa/i6jZ4
bHhSyVF1OvlCnmc8s0QuTveJoGoY5oJ/qdJizCheQIewEwKKJO7cF02elnGKpMKqNk
bIcdcpCc64Ucn9XxXxiIaYX2JGta8YK5z24l7BgOMU7IwKqP8DHEwU2ZE4gJdoS9Ln
CDxoZlt/ZqFiynLkCN02DSy+HCoszQkC6zlMRXFYCW8WAlZcuFqh5oUZMKA78XYYzo
f//+zpI2tdxBG8eL7NAMrv+2UTr8hOmCPFweICmTOd2Z0vsaZ6U9hCx++MHnOGdRLo
chKaJkniGTGcg==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
--=-VO3ivcgAnqIhSpvw18kI
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cees de Groot schreef op di 08-03-2022 om 20:52 [+0000]:
> * At build-time, Git is used to see if the build is inside a Git repo and=
if so, git info
That cannot ever have worked in the first place, since Guix does not
save the '.git' directory when downloading elixir's source code.
Greetings,
Maxime.
--=-VO3ivcgAnqIhSpvw18kI
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYifWChccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7vipAP9JudT4J/sNY++GM6xV6EIWpWBg
dYT50SRZcvbnMzLFHwEA5quWzqcl7fre9Zlcbsy0ANi7foz+PIiIGFreZ1DDSg4=
=1MrM
-----END PGP SIGNATURE-----
--=-VO3ivcgAnqIhSpvw18kI--
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 08 Mar 2022 22:19:01 +0000
Resent-Message-ID: <handler.54304.B54304.164677791710510 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54304
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Cees de Groot <cg@HIDDEN>, 54304 <at> debbugs.gnu.org
Received: via spool by 54304-submit <at> debbugs.gnu.org id=B54304.164677791710510
(code B ref 54304); Tue, 08 Mar 2022 22:19:01 +0000
Received: (at 54304) by debbugs.gnu.org; 8 Mar 2022 22:18:37 +0000
Received: from localhost ([127.0.0.1]:58072 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nRiA9-0002jR-AY
for submit <at> debbugs.gnu.org; Tue, 08 Mar 2022 17:18:37 -0500
Received: from albert.telenet-ops.be ([195.130.137.90]:54684)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maximedevos@HIDDEN>) id 1nRiA7-0002jJ-NP
for 54304 <at> debbugs.gnu.org; Tue, 08 Mar 2022 17:18:36 -0500
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
by albert.telenet-ops.be with bizsmtp
id 3yJa270034UW6Th06yJaEW; Tue, 08 Mar 2022 23:18:34 +0100
Message-ID: <c5a44f63897dafaafff33d4cdcd5c17324bf9029.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Tue, 08 Mar 2022 23:18:34 +0100
In-Reply-To: <vJt9-EGxCcqYcRJpPwLXHo3DPOa8pdhHUN3rrKNuV7BI-evzYt_zYqj_XgYNdYE5Xv5OOf1U4fIsOPa0lBOWSh5fqKBrxxoeF1w3PkEAKiA=@evrl.com>
References: <vJt9-EGxCcqYcRJpPwLXHo3DPOa8pdhHUN3rrKNuV7BI-evzYt_zYqj_XgYNdYE5Xv5OOf1U4fIsOPa0lBOWSh5fqKBrxxoeF1w3PkEAKiA=@evrl.com>
Content-Type: multipart/signed; micalg="pgp-sha512";
protocol="application/pgp-signature"; boundary="=-uV+Pi1NA4U+wPeecxnX2"
User-Agent: Evolution 3.38.3-1
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
t=1646777914; bh=b0bWZLqXloiIJh3acWLnEtVvbAvlkcaUVxLVCuYqA/c=;
h=Subject:From:To:Date:In-Reply-To:References;
b=ViWdRacZoJjKlZSHOCSmuVCbmbyA2UgMv552G+kQA2fCEE5rN2tO62yoc3+sDpmqh
J1U/V/AtEuaqV8StKdldB2519xMuBIkRzM6iYULMhle/v58OJGY66GamjxmZR/6kEC
32OYErsx6rYYSgGx5iYsaBypWjRk4NLcZ0asndFwxsYJKZXB7wFYtcfdOwi7YSYvte
1gBZKTfgy6ExzEUWqLB1VYlJCWrnWJZwsQngepJknhq0C+sfTYjkdtcrdcJrRD6RrC
WjnqDCCsMy93abt4zmT5PY0YI+pENxvfCWFuLvBTVy9rbtxf3jgxbfvlpbRaLUHivN
FdmQxsNw2dvow==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
--=-uV+Pi1NA4U+wPeecxnX2
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cees de Groot schreef op di 08-03-2022 om 20:52 [+0000]:
> =C2=A0 uses PATH + `git` so the Git version from the inputs is used which=
is just fine.
Due to cross-compilation reasons, this is not fine, it should use the
git from native-inputs instead.
Greetings,
Maxime.
--=-uV+Pi1NA4U+wPeecxnX2
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYifWOhccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7nKWAQCylSTfi61xYr9qtawkwphhcC5b
eAK6/HwQgIr7Kp/uSgEAl3pcPOJRwgaCa96f1er7efpCfaZLDi7RldnkjQCQ8gM=
=HHY0
-----END PGP SIGNATURE-----
--=-uV+Pi1NA4U+wPeecxnX2--
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 08 Mar 2022 22:23:01 +0000
Resent-Message-ID: <handler.54304.B54304.164677816510944 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54304
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Cees de Groot <cg@HIDDEN>, 54304 <at> debbugs.gnu.org
Received: via spool by 54304-submit <at> debbugs.gnu.org id=B54304.164677816510944
(code B ref 54304); Tue, 08 Mar 2022 22:23:01 +0000
Received: (at 54304) by debbugs.gnu.org; 8 Mar 2022 22:22:45 +0000
Received: from localhost ([127.0.0.1]:58083 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nRiE9-0002qS-4a
for submit <at> debbugs.gnu.org; Tue, 08 Mar 2022 17:22:45 -0500
Received: from albert.telenet-ops.be ([195.130.137.90]:57614)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maximedevos@HIDDEN>) id 1nRiE7-0002qK-Mx
for 54304 <at> debbugs.gnu.org; Tue, 08 Mar 2022 17:22:44 -0500
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
by albert.telenet-ops.be with bizsmtp
id 3yNi2700G4UW6Th06yNiYL; Tue, 08 Mar 2022 23:22:42 +0100
Message-ID: <5f60c94ec46bf7348c3f1906957dc3cbb4d9d395.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Tue, 08 Mar 2022 23:22:42 +0100
In-Reply-To: <vJt9-EGxCcqYcRJpPwLXHo3DPOa8pdhHUN3rrKNuV7BI-evzYt_zYqj_XgYNdYE5Xv5OOf1U4fIsOPa0lBOWSh5fqKBrxxoeF1w3PkEAKiA=@evrl.com>
References: <vJt9-EGxCcqYcRJpPwLXHo3DPOa8pdhHUN3rrKNuV7BI-evzYt_zYqj_XgYNdYE5Xv5OOf1U4fIsOPa0lBOWSh5fqKBrxxoeF1w3PkEAKiA=@evrl.com>
Content-Type: multipart/signed; micalg="pgp-sha512";
protocol="application/pgp-signature"; boundary="=-mCNYTeeQVIgzg8XAVY+/"
User-Agent: Evolution 3.38.3-1
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
t=1646778163; bh=gz4GAN1uQUApIBWRNc6qrqZchwkcnjMQKd2L2xtWAe0=;
h=Subject:From:To:Date:In-Reply-To:References;
b=AwtbHOs8OVb4OMYQHxXmjXkZ8yU/qCxDRrNYdOO8o6f6mp+AmlKoReIyQ0VMtJs9n
zyyyE5bIvqpGy9scTCN8mLfZ9T6Duh5Jq4Sz6BM+k9jH8Qc4Xmq04uuwdBrO2kHWmf
gV2PIXjRmtsJEE1+n1RHXl0blY/k37Y6Zex64qJbvAN90IaIxsFiitG+kve1TgJI1v
PiZ0e1EtMYgi5MEaJpB4TzH3cUziKK5/XKrzu0UzAETalPfCoNf5dltZEBvBn6Mv4e
OPlN7u24tcGmeILupkoZ/8KX1ma+zjWppypRMPMHYDGQ5meozva+3U2sPyGPjtCjJI
ctaK5R/SlV2Lw==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
--=-mCNYTeeQVIgzg8XAVY+/
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cees de Groot schreef op di 08-03-2022 om 20:52 [+0000]:
> * At run-time, Git is used by Mix if, and only if, there are any Git-base=
d dependencies. This
> =C2=A0 is not the normal case, and in that sense Git is an optional depen=
dency of Elixir - most
> =C2=A0 projects will work just fine without Git being present. Here, too,=
PATH + `git` is used
> =C2=A0 so if there is a need on a user's system to use Git-based dependen=
cies, the user can just
> =C2=A0 add the package to the profile and things will just work.
If it's optional and not used most of the time, removing
it seems fine to me, though this seems useful information for the
description. Also, it would be nice if 'elixir' were patched
to emit a nice message when 'git' is not found. Suggestion:
This project required 'git', but it is not in $PATH. It can be
installed into the user profile with `guix install git`.
You might want to contact whoever added the substitution originally,
to see what the original reasons were.
Greetings,
Maxime.
--=-mCNYTeeQVIgzg8XAVY+/
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYifXMhccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7q7UAP45wDMIM6e9HIRusznaKGZa93bk
oP8mUmH8GJiZ7sJBgwEAxYKovszQztu8RTbsQWWOz28xlUMgo+nP7AbZr5caSQA=
=cc7j
-----END PGP SIGNATURE-----
--=-mCNYTeeQVIgzg8XAVY+/--
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 09 Mar 2022 07:32:01 +0000
Resent-Message-ID: <handler.54304.B54304.164681107729688 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54304
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Cees de Groot <cg@HIDDEN>
Cc: 54304 <at> debbugs.gnu.org
Received: via spool by 54304-submit <at> debbugs.gnu.org id=B54304.164681107729688
(code B ref 54304); Wed, 09 Mar 2022 07:32:01 +0000
Received: (at 54304) by debbugs.gnu.org; 9 Mar 2022 07:31:17 +0000
Received: from localhost ([127.0.0.1]:58386 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nRqmz-0007im-KT
for submit <at> debbugs.gnu.org; Wed, 09 Mar 2022 02:31:17 -0500
Received: from laurent.telenet-ops.be ([195.130.137.89]:35748)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maximedevos@HIDDEN>) id 1nRqmx-0007id-5R
for 54304 <at> debbugs.gnu.org; Wed, 09 Mar 2022 02:31:15 -0500
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
by laurent.telenet-ops.be with bizsmtp
id 47XD2700R4UW6Th017XD66; Wed, 09 Mar 2022 08:31:13 +0100
Message-ID: <090dccee9fc3834656bbe416364a9a337122a2fb.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Wed, 09 Mar 2022 08:31:12 +0100
In-Reply-To: <OtG7oZgFz6vgVWUbmqcU-n34hv-sQCpJYpJKR7rdQvIDnB1sUh_1LoUl9egvv6vKWH_THdYl9gwPrzwzXx_FnxlPXJHaB3D70jY32T3oMuk=@evrl.com>
References: <vJt9-EGxCcqYcRJpPwLXHo3DPOa8pdhHUN3rrKNuV7BI-evzYt_zYqj_XgYNdYE5Xv5OOf1U4fIsOPa0lBOWSh5fqKBrxxoeF1w3PkEAKiA=@evrl.com>
<d40072710db6d1352dba3664f881c47411100788.camel@HIDDEN>
<OtG7oZgFz6vgVWUbmqcU-n34hv-sQCpJYpJKR7rdQvIDnB1sUh_1LoUl9egvv6vKWH_THdYl9gwPrzwzXx_FnxlPXJHaB3D70jY32T3oMuk=@evrl.com>
Content-Type: multipart/signed; micalg="pgp-sha512";
protocol="application/pgp-signature"; boundary="=-6H5RtnckZH/ppwALV9SL"
User-Agent: Evolution 3.38.3-1
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
t=1646811073; bh=/lrmVBstLh0F4XjQi0P1wgmI7CNXC091IExl68ugWVk=;
h=Subject:From:To:Cc:Date:In-Reply-To:References;
b=RSleLYEJOh2qCvlScq8BYKXj/LgX1QHMx70K+tKmWxV90ueQJHWinM0HcTA5mnR9X
HVPflelgg9DrEsVNaX9z9bqDkR/Vqpmg06GX/oB0Lke0iQsS2FnSGKRny9/McvHFQT
ti5bh6ENEEATFoMsX3UXhu97ox+PcihOUoMa5aFSjyR0nnleX0d2tMi/gwKxsf26vK
TqEnE4ZanjyUJAyv2lJaWgcuw+zPZz6Uees4PfVHYCSP96zrgxXXrxqIQgYeacH4iB
flTBhHItk7kS+71ri84zQhpL5lSmB4g7CNQ76RUxFlfmzSildXrIRHmdS3YRGEGON3
mTN90QEr0+ukA==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
--=-6H5RtnckZH/ppwALV9SL
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cees de Groot schreef op wo 09-03-2022 om 02:39 [+0000]:
> > [...]
> > That cannot ever have worked in the first place, since Guix
> > does not save the '.git' directory when downloading elixir's source
> > code.
> That=E2=80=99s correct and fine. The info is informational at most =C2=A0
How can being completely broken be correct and fine?
Greetings,
Maxime.
--=-6H5RtnckZH/ppwALV9SL
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYihXwBccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7pr1AQDfGqFcumXY6bg7sxxJEQmZXnLm
cia/7AbpZo/4wsccOwD/WvE1oQjlzhDIfJk1ufGLBaRSACKFBWU5NFTTnI/zOQo=
=WeWl
-----END PGP SIGNATURE-----
--=-6H5RtnckZH/ppwALV9SL--
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build
Resent-From: Cees de Groot <cg@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 09 Mar 2022 17:30:03 +0000
Resent-Message-ID: <handler.54304.B54304.164684697412709 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54304
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Maxime Devos <maximedevos@HIDDEN>
Cc: 54304 <at> debbugs.gnu.org
Reply-To: Cees de Groot <cg@HIDDEN>
Received: via spool by 54304-submit <at> debbugs.gnu.org id=B54304.164684697412709
(code B ref 54304); Wed, 09 Mar 2022 17:30:03 +0000
Received: (at 54304) by debbugs.gnu.org; 9 Mar 2022 17:29:34 +0000
Received: from localhost ([127.0.0.1]:60630 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nS07y-0003Iv-4N
for submit <at> debbugs.gnu.org; Wed, 09 Mar 2022 12:29:34 -0500
Received: from mail-4317.proton.ch ([185.70.43.17]:17630)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <cg@HIDDEN>) id 1nS07v-0003Id-FD
for 54304 <at> debbugs.gnu.org; Wed, 09 Mar 2022 12:29:32 -0500
Date: Wed, 09 Mar 2022 17:29:21 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=evrl.com;
s=protonmail3; t=1646846964;
bh=mqS784/iozdStffEOVLuCQPXoRJKBAI8XdhoCr8B47c=;
h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To:
References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
Message-ID;
b=LjA08RKuImhYOrw1s53FJ7qxuMCUkwwSxwc4RqQ605h9DQqnI16VXhpHUWGn/PL1e
Ml9GjzU31RZSzsKnKGnuJmKgCKBkhkmxEyekwWEqZNY6d/VydpXHrMEBBrEfTx6jvC
jkwY2vD0LR3NoLslhRVo4Ln9P6cD7Jsj4OM+a5UcKXv25a0chOdz47qqUs2ciPM1qM
P0BPOrexp3umyXWcy2Ko8gesU1NKR8C9ldT4qdo0rzSEq+bNStSpYhL8t4dEWSXzCM
S5bm9oKlf7rih1grT3B+tmn2xhOvNZKNxdlB6VklKAy4XnwwRQhC2HHTbAl3IFjCeU
yeg3nDo4KswMw==
From: Cees de Groot <cg@HIDDEN>
Message-ID: <ExhgBMh19WrDLQHI-IOvmUDtnsZhoC7V_oAtrNS89idRnqtYgXQRaBTthBngQCRkFa-P0pSXOPwDAyIXL56CLBjGF-vHP4KEQUEbLkhz-4s=@evrl.com>
In-Reply-To: <090dccee9fc3834656bbe416364a9a337122a2fb.camel@HIDDEN>
References: <vJt9-EGxCcqYcRJpPwLXHo3DPOa8pdhHUN3rrKNuV7BI-evzYt_zYqj_XgYNdYE5Xv5OOf1U4fIsOPa0lBOWSh5fqKBrxxoeF1w3PkEAKiA=@evrl.com>
<d40072710db6d1352dba3664f881c47411100788.camel@HIDDEN>
<OtG7oZgFz6vgVWUbmqcU-n34hv-sQCpJYpJKR7rdQvIDnB1sUh_1LoUl9egvv6vKWH_THdYl9gwPrzwzXx_FnxlPXJHaB3D70jY32T3oMuk=@evrl.com>
<090dccee9fc3834656bbe416364a9a337122a2fb.camel@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
From the docs:
":revision - short Git revision hash. If Git was not available at building =
time, it is set to """ (https://hexdocs.pm/elixir/System.html#build_info/0)
So if git is not available - either because the executable is not there or =
because the build checkout is not from Git, the revision hash is set to the=
empty string, which is in accordance with the docs and what the Guix build=
has been doing all along (because, as you said, at build time, .git isn't =
there).
So for build time, cross-compiling or not, we don't need Git.
------- Original Message -------
On Wednesday, March 9th, 2022 at 02:31, Maxime Devos <maximedevos@HIDDEN=
e> wrote:
> Cees de Groot schreef op wo 09-03-2022 om 02:39 [+0000]:
>
> > > [...]
> > >
> > > That cannot ever have worked in the first place, since Guix
> > >
> > > does not save the '.git' directory when downloading elixir's source
> > >
> > > code.
>
> > That=E2=80=99s correct and fine. The info is informational at most
>
> How can being completely broken be correct and fine?
>
> Greetings,
>
> Maxime.
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build
Resent-From: Cees de Groot <cg@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 09 Mar 2022 17:32:01 +0000
Resent-Message-ID: <handler.54304.B54304.164684710513069 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54304
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Maxime Devos <maximedevos@HIDDEN>
Cc: 54304 <at> debbugs.gnu.org
Reply-To: Cees de Groot <cg@HIDDEN>
Received: via spool by 54304-submit <at> debbugs.gnu.org id=B54304.164684710513069
(code B ref 54304); Wed, 09 Mar 2022 17:32:01 +0000
Received: (at 54304) by debbugs.gnu.org; 9 Mar 2022 17:31:45 +0000
Received: from localhost ([127.0.0.1]:60647 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nS0A5-0003Oj-K1
for submit <at> debbugs.gnu.org; Wed, 09 Mar 2022 12:31:45 -0500
Received: from mail-4022.proton.ch ([185.70.40.22]:62056)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <cg@HIDDEN>) id 1nS0A4-0003OT-4U
for 54304 <at> debbugs.gnu.org; Wed, 09 Mar 2022 12:31:44 -0500
Date: Wed, 09 Mar 2022 17:31:37 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=evrl.com;
s=protonmail3; t=1646847098;
bh=wkN2QYO2RJPiKG5jp3DZ/MApF9qziqilrbIoJ4c61DM=;
h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To:
References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
Message-ID;
b=fFprEC+a9FnotDPYXrkF/GrsD27CzyieAIdf1ViBLYkB/j5//qzjg7L4ed2nqtMV8
1H5PLH4fpQ6KlDsFo917lRg5Sr+/ji6sINhH7gNtzRtFui0emW06MHb32ffctT9GTu
ubHHveKuqibNeSgv5bAAzVfuesHt4YSuQhR9EQpW+Xj/sMnmk6WuVxUFYJCSSQ0CaY
YTyP/JBQsGXETbbhPCN0wzo1psTZvvXEl8NRLcihTte6qMkqgaNkPT6lxiPSNjzAX7
NaGkJ5b/dy1z/whhiTJMwH6KfU9KaFypDnR9vz+p7UGZ9KnsGHMlb+c2V38zwrwM50
Sxc/6EvUXc4uw==
From: Cees de Groot <cg@HIDDEN>
Message-ID: <cU5FfmYRpITfhryoKWDl9Fk9O4bHdSY6qH-1r-XoPShMPsucSfjzsg-9qAge_ewWi5mt-hnBlntnc0F7CO1RmSnibVrYdhaEHIMXnoff6xc=@evrl.com>
In-Reply-To: <5f60c94ec46bf7348c3f1906957dc3cbb4d9d395.camel@HIDDEN>
References: <vJt9-EGxCcqYcRJpPwLXHo3DPOa8pdhHUN3rrKNuV7BI-evzYt_zYqj_XgYNdYE5Xv5OOf1U4fIsOPa0lBOWSh5fqKBrxxoeF1w3PkEAKiA=@evrl.com>
<5f60c94ec46bf7348c3f1906957dc3cbb4d9d395.camel@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
I think changing the behaviour of a programming language just to be helpful=
to developers is something that one may consider for upstream, but certain=
ly not in the context of a packaging system like Guix - that just will bree=
d confusion.
As it is, the error message thrown by Elixir when Git is not there is very =
easy to interpret for developers (and _only_ at development time can this h=
appen!), no need to go overboard here. Unless, of course, you think it is u=
seful to submit an upstream patch, feel free to do so.
------- Original Message -------
On Tuesday, March 8th, 2022 at 17:22, Maxime Devos <maximedevos@HIDDEN>=
wrote:
> Cees de Groot schreef op di 08-03-2022 om 20:52 [+0000]:
>
> > * At run-time, Git is used by Mix if, and only if, there are any Git-ba=
sed dependencies. This
> >
> > =C2=A0 is not the normal case, and in that sense Git is an optional dep=
endency of Elixir - most
> >
> > =C2=A0 projects will work just fine without Git being present. Here, to=
o, PATH + `git` is used
> >
> > =C2=A0 so if there is a need on a user's system to use Git-based depend=
encies, the user can just
> >
> > =C2=A0 add the package to the profile and things will just work.
>
> If it's optional and not used most of the time, removing
>
> it seems fine to me, though this seems useful information for the
>
> description. Also, it would be nice if 'elixir' were patched
>
> to emit a nice message when 'git' is not found. Suggestion:
>
> This project required 'git', but it is not in $PATH. It can be
>
> installed into the user profile with `guix install git`.
>
> You might want to contact whoever added the substitution originally,
>
> to see what the original reasons were.
>
> Greetings,
>
> Maxime.
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build
Resent-From: Cees de Groot <cg@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 09 Mar 2022 17:36:02 +0000
Resent-Message-ID: <handler.54304.B54304.164684733513486 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54304
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Maxime Devos <maximedevos@HIDDEN>
Cc: 54304 <at> debbugs.gnu.org
Reply-To: Cees de Groot <cg@HIDDEN>
Received: via spool by 54304-submit <at> debbugs.gnu.org id=B54304.164684733513486
(code B ref 54304); Wed, 09 Mar 2022 17:36:02 +0000
Received: (at 54304) by debbugs.gnu.org; 9 Mar 2022 17:35:35 +0000
Received: from localhost ([127.0.0.1]:60658 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nS0Dn-0003VS-IL
for submit <at> debbugs.gnu.org; Wed, 09 Mar 2022 12:35:35 -0500
Received: from mail-4317.proton.ch ([185.70.43.17]:38619)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <cg@HIDDEN>) id 1nS0Dm-0003VC-3D
for 54304 <at> debbugs.gnu.org; Wed, 09 Mar 2022 12:35:34 -0500
Date: Wed, 09 Mar 2022 17:35:25 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=evrl.com;
s=protonmail3; t=1646847328;
bh=1Nn2/FHVZRMTpesI+X8pMs1XEFNH+9tWi3aszZcae1w=;
h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To:
References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
Message-ID;
b=jufhLWmm/IFXCsvW9UwipsOAhKTv81Rqd8IdYeLrBJ10Z1LETTI+K6AJ9VuawUau+
R2Yu0dJI7v5DAYYDHA6CEX5EVDZV2PAlLJSc8p1WtdTYNH9K3/puAnNfnZOVStRLgW
7OeSdH8VpLdd90rJ0c/rclOxz6a9Hs2ogavvR4czfQRl8bPLUHdmoY7+KEHjLMlgy0
csHJy3VTRKx0+jiLcZl9ZnXxQ0JfjmcDylmjJl20YB0nNiI13HR6x323PAEcbNdTt/
HSWoUY945oI1arPgdaLdOb9VBqu2ZQo8c612LGYkvqK0cjwhiphSDEeyyjwp1uxec5
haHM1dnC+Bd9Q==
From: Cees de Groot <cg@HIDDEN>
Message-ID: <vzMnya4Wgd5OVun0QL9Rb6Yz8i-gpXWRsqldCku8vMVCEbU5_G_KnikguFe-d-ZN067kP1qtJo9liNrWraPfLzowJZy5zYJvdGyNJaumbyo=@evrl.com>
In-Reply-To: <5e1d2abc1008c43dd70a85999420d529980c2bd1.camel@HIDDEN>
References: <vJt9-EGxCcqYcRJpPwLXHo3DPOa8pdhHUN3rrKNuV7BI-evzYt_zYqj_XgYNdYE5Xv5OOf1U4fIsOPa0lBOWSh5fqKBrxxoeF1w3PkEAKiA=@evrl.com>
<5e1d2abc1008c43dd70a85999420d529980c2bd1.camel@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
> Propagation is not necessary to =E2=80=98keep git around=E2=80=99 (assumi=
ng that the
Well.... the whole reason that I stumbled upon this was that the compile-ti=
me substitution referred to a Git version that got GC'd. And I think that t=
hat is the different between regular inputs and propagated inputs, whether =
inputs become eligible for GC at run-time or not. If I'm misunderstanding s=
omething there, something else caused that version of Git to get GC'd and I=
'd be more than happy to be corrected in my assumptions.
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build
Resent-From: Tobias Geerinckx-Rice <me@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 09 Mar 2022 18:00:02 +0000
Resent-Message-ID: <handler.54304.B54304.164684875316068 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54304
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Cees de Groot <cg@HIDDEN>, Maxime Devos <maximedevos@HIDDEN>
Cc: 54304 <at> debbugs.gnu.org
Received: via spool by 54304-submit <at> debbugs.gnu.org id=B54304.164684875316068
(code B ref 54304); Wed, 09 Mar 2022 18:00:02 +0000
Received: (at 54304) by debbugs.gnu.org; 9 Mar 2022 17:59:13 +0000
Received: from localhost ([127.0.0.1]:60689 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nS0ad-0004B3-De
for submit <at> debbugs.gnu.org; Wed, 09 Mar 2022 12:59:13 -0500
Received: from tobias.gr ([80.241.217.52]:50988)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <me@HIDDEN>) id 1nS0aY-0004Ap-03
for 54304 <at> debbugs.gnu.org; Wed, 09 Mar 2022 12:59:10 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=gAuX6re861w28
sur5tPUcCuk6zab1xFM7dMygg8D/4U=;
h=references:in-reply-to:subject:cc:
to:from:date; d=tobias.gr; b=lklNF+H2U0AufxYSQnk0cvD029wIl8JJArTgOmGtY
Uq1g1qVONU5Yr2ZpieIz4tc4bTg2xO8tCijn70vrto0PKloEk7wK+xyR2DmUFpAFu75cru
DCI2pbe8Umwugk6M7n0LFMh8n1i0DawOB8CzRqRaxvSgDSdQ68rpR6iUWtcgViT23TCOs8
jvsDSP/tDTFgNRzmG/cOr9yz/PX6kUzBVo/d6FPJU1c9MvM1amkco9PiUmZN/FamyR3Xo1
7ORc9Hl0njVVS3n7XuaR6DNAvVAqZdD5vV35LjXESHtM1W8SolN4mvZLCe1dq2WqvCpn++
PCqEDPB4KAsdGUGtBS8xQ==
Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 4948aa06
(TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO);
Wed, 9 Mar 2022 17:59:01 +0000 (UTC)
Date: Wed, 09 Mar 2022 17:59:03 +0000
From: Tobias Geerinckx-Rice <me@HIDDEN>
In-Reply-To: <vzMnya4Wgd5OVun0QL9Rb6Yz8i-gpXWRsqldCku8vMVCEbU5_G_KnikguFe-d-ZN067kP1qtJo9liNrWraPfLzowJZy5zYJvdGyNJaumbyo=@evrl.com>
References: <vJt9-EGxCcqYcRJpPwLXHo3DPOa8pdhHUN3rrKNuV7BI-evzYt_zYqj_XgYNdYE5Xv5OOf1U4fIsOPa0lBOWSh5fqKBrxxoeF1w3PkEAKiA=@evrl.com>
<5e1d2abc1008c43dd70a85999420d529980c2bd1.camel@HIDDEN>
<vzMnya4Wgd5OVun0QL9Rb6Yz8i-gpXWRsqldCku8vMVCEbU5_G_KnikguFe-d-ZN067kP1qtJo9liNrWraPfLzowJZy5zYJvdGyNJaumbyo=@evrl.com>
Message-ID: <3FC21903-C19B-49C1-B865-7D15E1B3EC74@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain;
charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
On 9 March 2022 17:35:25 UTC, Cees de Groot <cg@evrl=2Ecom> wrote:
>> Propagation is not necessary to =E2=80=98keep git around=E2=80=99 (assu=
ming that the
>
>Well=2E=2E=2E=2E the whole reason that I stumbled upon this was that the =
compile-time substitution referred to a Git version that got GC'd=2E
This simply Should Not happen=2E Guix's GC model (inherited from Nix) is =
brutally simple: if the raw string /gnu/store/xxx occurs anywhere within a =
protected /gnu/store/yyy (e=2Eg=2E in a binary), then xxx is also protected=
, recursively=2E
Assuming those assumptions hold here it's a 'mystery' why git got GC'd=2E =
From experience and for our collective peace of mind I'd say it's more lik=
ely that they didn't hold somehow, than that there's a serious GC bug :-)
> And I think that that is the different between regular inputs and propag=
ated inputs, whether inputs become eligible for GC at run-time or not=2E
So, no=2E Completely unrelated=2E The GC has no concept of time at all=
=2E This isn't Gentoo=2E
Propagated inputs are 'oh, here's this extra thing I was unable to properl=
y patch, please add it to the profile and treat it as a GC reference anyway=
'=2E
This is ugly and regular, non-propagated inputs are always preferred=2E S=
ome software just makes them too painful=2E
Cees,
Kind regards,
T G-R
Sent on the go=2E Excuse or enjoy my brevity=2E
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 09 Mar 2022 19:46:02 +0000
Resent-Message-ID: <handler.54304.B54304.164685514626969 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54304
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Cees de Groot <cg@HIDDEN>
Cc: 54304 <at> debbugs.gnu.org
Received: via spool by 54304-submit <at> debbugs.gnu.org id=B54304.164685514626969
(code B ref 54304); Wed, 09 Mar 2022 19:46:02 +0000
Received: (at 54304) by debbugs.gnu.org; 9 Mar 2022 19:45:46 +0000
Received: from localhost ([127.0.0.1]:60769 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nS2Fm-00070v-GS
for submit <at> debbugs.gnu.org; Wed, 09 Mar 2022 14:45:46 -0500
Received: from andre.telenet-ops.be ([195.130.132.53]:51312)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maximedevos@HIDDEN>) id 1nS2Fj-00070j-U0
for 54304 <at> debbugs.gnu.org; Wed, 09 Mar 2022 14:45:45 -0500
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
by andre.telenet-ops.be with bizsmtp
id 4Klh2700E4UW6Th01Klhy1; Wed, 09 Mar 2022 20:45:42 +0100
Message-ID: <919b8ca66b9548aa0e3cf682b9e293f7ed28b2a8.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Wed, 09 Mar 2022 20:45:41 +0100
In-Reply-To: <cU5FfmYRpITfhryoKWDl9Fk9O4bHdSY6qH-1r-XoPShMPsucSfjzsg-9qAge_ewWi5mt-hnBlntnc0F7CO1RmSnibVrYdhaEHIMXnoff6xc=@evrl.com>
References: <vJt9-EGxCcqYcRJpPwLXHo3DPOa8pdhHUN3rrKNuV7BI-evzYt_zYqj_XgYNdYE5Xv5OOf1U4fIsOPa0lBOWSh5fqKBrxxoeF1w3PkEAKiA=@evrl.com>
<5f60c94ec46bf7348c3f1906957dc3cbb4d9d395.camel@HIDDEN>
<cU5FfmYRpITfhryoKWDl9Fk9O4bHdSY6qH-1r-XoPShMPsucSfjzsg-9qAge_ewWi5mt-hnBlntnc0F7CO1RmSnibVrYdhaEHIMXnoff6xc=@evrl.com>
Content-Type: multipart/signed; micalg="pgp-sha512";
protocol="application/pgp-signature"; boundary="=-0hT54dB9YfW6numgs8+V"
User-Agent: Evolution 3.38.3-1
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
t=1646855142; bh=zrxlcvu/v2z8VlWRX4rhIIaN0UROC49OorewclcKGXo=;
h=Subject:From:To:Cc:Date:In-Reply-To:References;
b=GqgiMzDqiT02posWB5xjK5tU6gddlT1qAETwOWiAeGMvUWLiJHlCJYn4lDYjDLCsl
eGplgEL2iotNa9kgO6reD/pvSepaHp05GMdhCQBrBtnNlL8siLOl4Hqe+pbSsAADkQ
Yx67m/4qrIHAGE5GNqfuzHZHNVkqVKZgM2dSA9oHCqplAbzzwHP9pCHzEeFKkES7Ql
zcD3Rlfso1bf87dkian+G/ERqinYcOSqoqcnyKXoNwt2SizrvWjHfd2S12Y6ZmIjzG
mUftnUf2/8Q8jFSt4JMPoSWCL6Pa+GnNIXULi7JL7Vqjxzir/ZfsfEB7ufOpmCJR51
qaX/BvJPOr3FQ==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
--=-0hT54dB9YfW6numgs8+V
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cees de Groot schreef op wo 09-03-2022 om 17:31 [+0000]:
> I think changing the behaviour of a programming language just to be helpf=
ul to developers
Developers are users too and users can be developers. Furthermore,
Elixir is an implementation of a programming language, so aren't all
users of Elixir automatically developers?
I'm not sure how exactly Elixir integrates with git but I assume the
integration can be very useful.
Also, this does not change the behaviour of the language, it only
adjusts a detail of the implementation: the error message for
indicating that git is missing is adjusted.
> is something that one may consider for upstream, but certainly not in th=
e context
> of a packaging system like Guix - that just will breed confusion.
How could better error messages breed confusion?
Also, this seems a change that would absolutely _not_ be considered
upstream. Why would upstream have distro-specific error messages? If
the new error message is Guix-specific, wouldn't Guix be the logical
place to have it?
Greetings,
Maxime.
--=-0hT54dB9YfW6numgs8+V
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYikD5RccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7gppAP45vq8lFQRRs+nLssm3L7rBLQzZ
q0ZPo5RcbDwVwdFssAD/coZUNom2+Cus2qHJ3O/PxMf0t3Z2hiLr4CskcVHNpQ0=
=PAGC
-----END PGP SIGNATURE-----
--=-0hT54dB9YfW6numgs8+V--
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build
Resent-From: Cees de Groot <cg@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 09 Mar 2022 21:02:02 +0000
Resent-Message-ID: <handler.54304.B54304.16468597189318 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54304
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Tobias Geerinckx-Rice <me@HIDDEN>
Cc: 54304 <at> debbugs.gnu.org, Maxime Devos <maximedevos@HIDDEN>
Reply-To: Cees de Groot <cg@HIDDEN>
Received: via spool by 54304-submit <at> debbugs.gnu.org id=B54304.16468597189318
(code B ref 54304); Wed, 09 Mar 2022 21:02:02 +0000
Received: (at 54304) by debbugs.gnu.org; 9 Mar 2022 21:01:58 +0000
Received: from localhost ([127.0.0.1]:60905 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nS3RV-0002Py-Ny
for submit <at> debbugs.gnu.org; Wed, 09 Mar 2022 16:01:58 -0500
Received: from mail-4022.proton.ch ([185.70.40.22]:54845)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <cg@HIDDEN>) id 1nS3RS-0002JI-8e
for 54304 <at> debbugs.gnu.org; Wed, 09 Mar 2022 16:01:56 -0500
Date: Wed, 09 Mar 2022 21:01:46 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=evrl.com;
s=protonmail3; t=1646859707;
bh=mr3T2WZmjeNBtRtUDukC0fP4URkTPZBjDdzN3OC8PJY=;
h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To:
References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
Message-ID;
b=tnpRo3kanikcg5JSIDIb5KMy75Cpf0J3v439SzHHXa3W3PYxvQsqdfPJ1AHcp/iwx
4PInO9nO4atkBytfWr39ZaaWnLHLH1AQLqGYHV+CacCahTUZOHbqzSarZ/vVYenomn
9q/kRC4UvenqjrueD13LePcMGDg8JSJX27lWxg8fKBLsISJ4AWF4wC7tXDnQ22Ycd1
qMcZmydIt/OhglXsE6D5roWAqF4sFylEIqq+WkKlBSmkAejcER1xv04By3ZsvptK92
SHspDqNVRZbIPi7vZHwISfuOKqBjMejiizfvWef6Uwft27aSJ0b/9Rm28YUxAfvlXR
GEwJfZKQpz+qQ==
From: Cees de Groot <cg@HIDDEN>
Message-ID: <BLnyODUm-yZNU1xZMtYiaY3geuDk0O7KQALAgfrx-7bnEsKDlS9rQUJWNmPebVfjPdgRwlrW1Mqwa60k8ZJLyOMHuqbK7TYFsBeYbkf8h1I=@evrl.com>
In-Reply-To: <3FC21903-C19B-49C1-B865-7D15E1B3EC74@HIDDEN>
References: <vJt9-EGxCcqYcRJpPwLXHo3DPOa8pdhHUN3rrKNuV7BI-evzYt_zYqj_XgYNdYE5Xv5OOf1U4fIsOPa0lBOWSh5fqKBrxxoeF1w3PkEAKiA=@evrl.com>
<5e1d2abc1008c43dd70a85999420d529980c2bd1.camel@HIDDEN>
<vzMnya4Wgd5OVun0QL9Rb6Yz8i-gpXWRsqldCku8vMVCEbU5_G_KnikguFe-d-ZN067kP1qtJo9liNrWraPfLzowJZy5zYJvdGyNJaumbyo=@evrl.com>
<3FC21903-C19B-49C1-B865-7D15E1B3EC74@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
On Wednesday, March 9th, 2022 at 12:59, Tobias Geerinckx-Rice <me@HIDDEN=
> wrote:
> This simply Should Not happen. Guix's GC model (inherited from Nix) is br=
utally simple: if the raw string /gnu/store/xxx occurs anywhere within a pr=
otected /gnu/store/yyy (e.g. in a binary), then xxx is also protected, recu=
rsively.
So how does Guix figure out what to keep and what not? I mean, in this case=
the patched string will land in a compiled .BEAM file which very well may =
have the string obfuscated (I need to check how the VM stores strings in bi=
naries).
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.