Received: (at 54986) by debbugs.gnu.org; 9 Dec 2022 13:45:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 09 08:45:05 2022
Received: from localhost ([127.0.0.1]:36195 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1p3dgX-00024I-An
for submit <at> debbugs.gnu.org; Fri, 09 Dec 2022 08:45:05 -0500
Received: from smtpmciv5.myservices.hosting ([185.26.107.241]:50898)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <mirai@HIDDEN>)
id 1p3dgV-00023u-DU; Fri, 09 Dec 2022 08:45:03 -0500
Received: from mail1.netim.hosting (unknown [185.26.106.172])
by smtpmciv5.myservices.hosting (Postfix) with ESMTP id E947520BE5;
Fri, 9 Dec 2022 14:45:00 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
by mail1.netim.hosting (Postfix) with ESMTP id 865A080098;
Fri, 9 Dec 2022 14:45:00 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting
Received: from mail1.netim.hosting ([127.0.0.1])
by localhost (mail1-1.netim.hosting [127.0.0.1]) (amavisd-new, port 10026)
with ESMTP id qmuGHNF6oe9n; Fri, 9 Dec 2022 14:45:00 +0100 (CET)
Received: from [192.168.1.239] (unknown [10.192.1.83])
(Authenticated sender: lumen@HIDDEN)
by mail1.netim.hosting (Postfix) with ESMTPSA id DD71480093;
Fri, 9 Dec 2022 14:44:59 +0100 (CET)
Message-ID: <d5439211-66b2-0938-2de4-1847b22ce0e2@HIDDEN>
Date: Fri, 9 Dec 2022 13:44:58 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
Thunderbird/102.5.1
Subject: Re: [PATCH 0/2] services: mpd: Refactor MPD service
Content-Language: en-US
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>, 59866 <at> debbugs.gnu.org
References: <cover.1670368385.git.mirai@HIDDEN>
<6e66967984d1bc22d8abf5dd4b07c1a20b4b06ee.camel@HIDDEN>
<71f31a0d-cc58-a0e6-4aa4-b5c46513c835@HIDDEN>
<c2c097ea2491638d0553e2a3bea65e571e5e595a.camel@HIDDEN>
From: mirai <mirai@HIDDEN>
In-Reply-To: <c2c097ea2491638d0553e2a3bea65e571e5e595a.camel@HIDDEN>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 54986
Cc: 54986 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
On 2022-12-08 13:35, Liliana Marie Prikler wrote:
> This doesn't work for #54986, which makes it so that in-file addresses
> are ignored in favour of handing over the sockets directly through
> shepherd. Looking at [4], it appears the meaning of "port" is closer
> to that of a default port, as addresses can have ports in them. But I
> would still prefer addresses to be "endpoints", which if they happen to
> be a list of strings are taken as MPD addresses and if they happen to
> be shepherd endpoints are passed on to the shepherd service.
Are you proposing for the 'addresses' field to be a
"maybe-list-of-string-or-shepherd-endpoint"? (more of a xor as they can't
be used simultaneously)
Example:
--8<---------------cut here---------------start------------->8---
;; should fire a error message during guix system reconfigure
(mpd-configuration
(addresses `("[::]:6645"
,(shepherd-endpoint
(address "/var/run/mpd-shepherd-socket")))))
--8<---------------cut here---------------end--------------->8---
I don't think it breaks backward compatibility to introduce this
after #59866 is merged.
The type of field 'addresses' could be changed transparently to something like:
--8<---------------cut here---------------start------------->8---
(define list-of-addresses (list-of (lambda (x) (or (string? x) (shepherd-endpoint? x)))))
--8<---------------cut here---------------end--------------->8---
guix-patches@HIDDEN:bug#54986; Package guix-patches.
Full text available.Received: (at 54986) by debbugs.gnu.org; 8 Dec 2022 13:36:07 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Dec 08 08:36:07 2022 Received: from localhost ([127.0.0.1]:56813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1p3H4I-00033M-Kk for submit <at> debbugs.gnu.org; Thu, 08 Dec 2022 08:36:07 -0500 Received: from mail-ej1-f66.google.com ([209.85.218.66]:40764) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <liliana.prikler@HIDDEN>) id 1p3H4G-00032r-32; Thu, 08 Dec 2022 08:36:04 -0500 Received: by mail-ej1-f66.google.com with SMTP id b2so3910445eja.7; Thu, 08 Dec 2022 05:36:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=NLSGOOf2eRBAwiYW6X8+LYnqDTQCwpP7U+hL/+ZUHVQ=; b=nigV6vxdvqjvSTOBVGJyMbgXrlmDMcah6CMYU/lv5MW5wZT+kBSuknsHSss1CdDjUY 6wRpQtaQI5omo1xhgw+PKP1ob4YB4ZTGDInr8WeZSdG3Sii2Ah5VpzXwFCMkwmAmf1eN wRpFNNDLkR2jJ88h6EDYxYEM4wF3ouMvrVW70uZcAEsVdtfkgGLA3jnb3BLuNy8ATVWr tdamTH7ktq2IB1x82EsiLpWkEFerMn+tz0d1Vlsnz5aYHp7d35h+xI2AH5radpNkbYYi B3OlfNb4nhb9OhgbTSKFi+W4ssNJuCh1TqfOjI9l5CUUDffwiE4PrpQJMoism9pG/wG9 mHug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=NLSGOOf2eRBAwiYW6X8+LYnqDTQCwpP7U+hL/+ZUHVQ=; b=eWuofNeZrctnoL2UbNalrbcOaQ3WKlwJwIY8Ne6bh32NymI6g0h2Hd6jnLoJsChZIh eLOPCADI+aggBnVFyzP/so3Mx8JStyqkKK8cs0t4fvQVxiap+DIAc+czT3ai3iHNgiTE irUqN7KS3tCCJm4XZ6+Jkru2rRI//qeEMa8xGR4UxDq0rjPCcDaNWyxukO35wPtKZT27 KDlSAB8QeJ59NAFPBUnh7SELHFRKCN2/86DrRyXEAVCazAIphJylpfCYGUy/i2tHvBFP XH5bGpnTIjU2mKRKc3REXK8cFZ2e0TL+lwaJOhdJqV35VqFeGtg8wcjx68UrsUsgD0bs Sqag== X-Gm-Message-State: ANoB5pkQ2329GieiWpoRajUiVj0L2JUQEqOBszVd7KluM5r9VrzGSebw 8xwox0JAldLPqifJnBjHrZI= X-Google-Smtp-Source: AA0mqf5Ln50FtyONi6KSjrGOB+MJbHvtPfzUlpfihVKWxpPlvU/LquS4omNId7i5rnq+03w5Lt3aQQ== X-Received: by 2002:aa7:cd02:0:b0:46c:9536:8598 with SMTP id b2-20020aa7cd02000000b0046c95368598mr15835083edw.123.1670506557965; Thu, 08 Dec 2022 05:35:57 -0800 (PST) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id i26-20020aa7dd1a000000b0045c47b2a800sm3358568edv.67.2022.12.08.05.35.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Dec 2022 05:35:57 -0800 (PST) Message-ID: <c2c097ea2491638d0553e2a3bea65e571e5e595a.camel@HIDDEN> Subject: Re: [PATCH 0/2] services: mpd: Refactor MPD service From: Liliana Marie Prikler <liliana.prikler@HIDDEN> To: mirai <mirai@HIDDEN>, 59866 <at> debbugs.gnu.org Date: Thu, 08 Dec 2022 14:35:55 +0100 In-Reply-To: <71f31a0d-cc58-a0e6-4aa4-b5c46513c835@HIDDEN> References: <cover.1670368385.git.mirai@HIDDEN> <6e66967984d1bc22d8abf5dd4b07c1a20b4b06ee.camel@HIDDEN> <71f31a0d-cc58-a0e6-4aa4-b5c46513c835@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54986 Cc: 54986 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Am Donnerstag, dem 08.12.2022 um 13:11 +0000 schrieb mirai: > On 2022-12-07 18:27, Liliana Marie Prikler wrote: > > Note that there is [1], which attempts to make it so that shepherd > > endpoints can be specified in lieu of MPD endpoints.=C2=A0 You don't > > need to implement this logic =E2=80=93 you are free to do so if you wan= t to > > =E2=80=93 but could you make it so that there is an explicit endpoint > > abstraction that would allow for extension later on? > >=20 > > Cheers > >=20 > > [1] https://issues.guix.gnu.org/54986 >=20 > Hi, >=20 > After reading issue #54986, regarding mpd escaping shepherd > management, my guess is that there could be two issues at play here: >=20 > * mpd.conf was serialized with pid_file [1]. The safest is > to actually not serialize any unused directives and let MPD decide > based on what's actually present. pid_file should only be set if > MPD is to be launched as a "daemon process". [2] >=20 > * But the service definition for MPD is launched with '--no-daemon' > option as seen in [3], which could be triggering a bug in MPD. It's > probably worth testing the combinations of having pid_file set and > invoking --no-daemon. Nice catch, but completely unrelated to the issue. In neither case do we ever spawn MPD as a regular daemon, yet only in the systemd case does shepherd have a problem with it. That statement was concerning shepherd's (mis)management of sockets, not MPD. > > but could you make it so that there is an explicit endpoint > > abstraction that would allow for extension later on? >=20 > If I'm understanding correctly what [1] is about, I think this can be > implemented through the 'extend' interface. See how certbot adds a > nginx-server-configuration to a nginx-service-type through the > 'extend' interface. For MPD, this would amount to appending the > 'adresses' field with "adequately formatted" values. This doesn't work for #54986, which makes it so that in-file addresses are ignored in favour of handing over the sockets directly through shepherd. Looking at [4], it appears the meaning of "port" is closer to that of a default port, as addresses can have ports in them. But I would still prefer addresses to be "endpoints", which if they happen to be a list of strings are taken as MPD addresses and if they happen to be shepherd endpoints are passed on to the shepherd service. WDYT? [4] https://mpd.readthedocs.io/en/stable/user.html#client-connections
guix-patches@HIDDEN:bug#54986; Package guix-patches.
Full text available.Received: (at 54986) by debbugs.gnu.org; 8 Dec 2022 13:11:37 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Dec 08 08:11:37 2022 Received: from localhost ([127.0.0.1]:56702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1p3Gga-0002o3-Va for submit <at> debbugs.gnu.org; Thu, 08 Dec 2022 08:11:37 -0500 Received: from smtpmciv4.myservices.hosting ([185.26.107.240]:48080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mirai@HIDDEN>) id 1p3GgZ-0002nu-9L; Thu, 08 Dec 2022 08:11:35 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.172]) by smtpmciv4.myservices.hosting (Postfix) with ESMTP id A58AF20775; Thu, 8 Dec 2022 14:11:33 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 65C0E80096; Thu, 8 Dec 2022 14:11:33 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-1.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Qm4M4if-MSeb; Thu, 8 Dec 2022 14:11:29 +0100 (CET) Received: from [192.168.1.239] (unknown [10.192.1.83]) (Authenticated sender: lumen@HIDDEN) by mail1.netim.hosting (Postfix) with ESMTPSA id 9CFC980093; Thu, 8 Dec 2022 14:11:29 +0100 (CET) Message-ID: <71f31a0d-cc58-a0e6-4aa4-b5c46513c835@HIDDEN> Date: Thu, 8 Dec 2022 13:11:29 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 From: mirai <mirai@HIDDEN> Subject: Re: [PATCH 0/2] services: mpd: Refactor MPD service To: Liliana Marie Prikler <liliana.prikler@HIDDEN>, 59866 <at> debbugs.gnu.org References: <cover.1670368385.git.mirai@HIDDEN> <6e66967984d1bc22d8abf5dd4b07c1a20b4b06ee.camel@HIDDEN> Content-Language: en-US In-Reply-To: <6e66967984d1bc22d8abf5dd4b07c1a20b4b06ee.camel@HIDDEN> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54986 Cc: 54986 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On 2022-12-07 18:27, Liliana Marie Prikler wrote: > Note that there is [1], which attempts to make it so that shepherd > endpoints can be specified in lieu of MPD endpoints. You don't need to > implement this logic – you are free to do so if you want to – but could > you make it so that there is an explicit endpoint abstraction that > would allow for extension later on? > > Cheers > > [1] https://issues.guix.gnu.org/54986 Hi, After reading issue #54986, regarding mpd escaping shepherd management, my guess is that there could be two issues at play here: * mpd.conf was serialized with pid_file [1]. The safest is to actually not serialize any unused directives and let MPD decide based on what's actually present. pid_file should only be set if MPD is to be launched as a "daemon process". [2] * But the service definition for MPD is launched with '--no-daemon' option as seen in [3], which could be triggering a bug in MPD. It's probably worth testing the combinations of having pid_file set and invoking --no-daemon. > but could > you make it so that there is an explicit endpoint abstraction that > would allow for extension later on? If I'm understanding correctly what [1] is about, I think this can be implemented through the 'extend' interface. See how certbot adds a nginx-server-configuration to a nginx-service-type through the 'extend' interface. For MPD, this would amount to appending the 'adresses' field with "adequately formatted" values. [1]: https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/services/audio.scm?id=1b6172d5f6ca22f0fa02cd1335b1b90e9501b731#n116 [2]: https://mpd.readthedocs.io/en/latest/user.html#starting-and-stopping-mpd [3]: https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/services/audio.scm?id=1b6172d5f6ca22f0fa02cd1335b1b90e9501b731#n145
guix-patches@HIDDEN:bug#54986; Package guix-patches.
Full text available.Received: (at 54986) by debbugs.gnu.org; 26 Nov 2022 12:59:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 26 07:59:39 2022 Received: from localhost ([127.0.0.1]:38135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oyumQ-0004aM-RQ for submit <at> debbugs.gnu.org; Sat, 26 Nov 2022 07:59:39 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:34768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <liliana.prikler@HIDDEN>) id 1oyumP-0004a8-N1 for 54986 <at> debbugs.gnu.org; Sat, 26 Nov 2022 07:59:38 -0500 Received: by mail-wm1-f66.google.com with SMTP id t25-20020a1c7719000000b003cfa34ea516so7322048wmi.1 for <54986 <at> debbugs.gnu.org>; Sat, 26 Nov 2022 04:59:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=CHye/8wTyDBzAWP+bhAiAXiJlUip0X3RXLHHvGoWYOw=; b=FXeHvlfWSxX23Xrrth1BJ+ZtRDUa20agj3Y1TJU2TtVnzOlrXdjJpTnRM1PV13ZTMe ikZxxoLLB2noF/HJnZcbWSMXYhx/RbU6RywS4T+lpHjyGMuG8Jjxksyt3VRhPrdkz7JF 81U11KtDOgdoRAzLf6lUEfZU6ZPM3l1P63NBJn01SAEE/rDep4dUJ1YIhHKZUJifKM0I 7BLe1ncWnQ9uceUnOhn2AnPAuXkkmiRBpN+avLZtKQCaUDlyzNEx8Yyb5VS+jc1ATUzI Fuadj1bqKT+uoNfS42UAJBS6tREdDPAStY7jDK2muqSo1Llgq8eIE4hcdzL7+UcXV1z0 y7Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=CHye/8wTyDBzAWP+bhAiAXiJlUip0X3RXLHHvGoWYOw=; b=bY38wpLQBmN03ngI7CkPWtHq0bhHX0fpCfVyIj0giDoIBMV7KC1Vtq03LqHKZvfsna j8oOMfaX4rvx6rk/Tni4WILr1RWJRg2Vf3OEliVqb+u1F20OKYHLXfFsL1EIEiZYdKUG QEZCjCofGwH3NRzQ9SaXBgevlI4t06tmky747WOULR3cfpshbZR1m6Ia/FRL5QtJjqOB ZKPpRa5wZ1YlPtb0hJ/zsSzmi6vc6hIL9+XHrui8HUv4nJao5j1tj1njKDP7nnT82Ebf 8cEuI+NU8UT/f85iJ1K4MoVkXVq4elfL7mNjc2XE5TMNvTHuIbSuAx7wsIql5LVUyQa1 VqJA== X-Gm-Message-State: ANoB5pkAVz69cYdYayuOBBNK71MsuwZZX9wTINPQVd6g3wCB3SdgQqIS XAnO2UKOQIjz0NvMZsjygW3AamdpeNE= X-Google-Smtp-Source: AA0mqf42Iw/eVFlgp+730o4Tbow1bhR+bkLtyQ4Ixt4bqFWutnB0nV8hf7LUjU0+42RLMeAzvzNegw== X-Received: by 2002:a05:600c:4e47:b0:3cf:5657:4717 with SMTP id e7-20020a05600c4e4700b003cf56574717mr35107126wmq.87.1669467572100; Sat, 26 Nov 2022 04:59:32 -0800 (PST) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id s10-20020a1cf20a000000b003cfe1376f68sm8396936wmc.9.2022.11.26.04.59.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Nov 2022 04:59:31 -0800 (PST) Message-ID: <c02ceb22a209fba5ac4fa5789b5f7266173462d8.camel@HIDDEN> Subject: Re: [PATCH v3 2/2] services: mpd: Support socket activation. From: Liliana Marie Prikler <liliana.prikler@HIDDEN> To: 54986 <at> debbugs.gnu.org Date: Sat, 26 Nov 2022 13:59:30 +0100 In-Reply-To: <01c0edd6f378636fb7a2a7d4dab8af7ca829e305.camel@HIDDEN> References: <3105812906c619735df4a5f476c1c822c63bfb15.camel@HIDDEN> <01c0edd6f378636fb7a2a7d4dab8af7ca829e305.camel@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 54986 Cc: Ludovic =?ISO-8859-1?Q?Court=E8s?= <ludo@HIDDEN>, Maxime Devos <maximedevos@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Am Sonntag, dem 23.10.2022 um 13:38 +0200 schrieb Liliana Marie Prikler: > Am Samstag, dem 23.04.2022 um 16:39 +0200 schrieb Liliana Marie > Prikler: > > * gnu/services/audio.scm (<mpd-endpoint>): New record. > > (<mpd-configuration>)[port, address]: Removed fields. > > [endpoints]: New field. > > (sanitize-mpd-endpoints, mpd-configuration-shepherd-endpoints): New > > variables. > > (mpd-shepherd-service): Use mpd-configuration-shepherd-endpoints. > > * doc/guix.texi (Music Player Daemon): Document it. > > --- > Bump Bumpy bump
guix-patches@HIDDEN:bug#54986; Package guix-patches.
Full text available.Received: (at 54986) by debbugs.gnu.org; 23 Oct 2022 11:39:05 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Oct 23 07:39:05 2022 Received: from localhost ([127.0.0.1]:43777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1omZJp-0002R1-5u for submit <at> debbugs.gnu.org; Sun, 23 Oct 2022 07:39:05 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:39748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <liliana.prikler@HIDDEN>) id 1omZJn-0002QI-5I for 54986 <at> debbugs.gnu.org; Sun, 23 Oct 2022 07:39:03 -0400 Received: by mail-ed1-f65.google.com with SMTP id b12so21741614edd.6 for <54986 <at> debbugs.gnu.org>; Sun, 23 Oct 2022 04:39:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=CuHu41UhoFHRDuB7aiiDErLiF0aEYAgJswuwqsJR47E=; b=QjlE/q46dMG7B0vYW9h2ah5cwAqug+fDJ9Y3oviu0jCJ5ZIgR0lWJuW1iVeHv72Zau qI39zoOnqI2oh8v86OzQMIVNu5CXBcopxhU1+7opIyGq4M640c8TWqRdmxM8nfD9zaEZ kwrK/pNECJCYckUGs6P6KhamY411WoC6yCXprX0e3SYUqVrl6dxn8UPO9VjbIWu3NLcl +2/aGzf7D25aS0b5g44hesyJjEhasjDHCahWk8e5LTom2Xrz6KsSnblhmYHIro24mDt7 YK0d+y97fUK8KefCEFAvizaICHZGMh20rrommEFEheSPQQhMbe61AYNa5xI2Wf48csEZ Hg7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=CuHu41UhoFHRDuB7aiiDErLiF0aEYAgJswuwqsJR47E=; b=wpaYDrogJBsK01SZUW8bxIXs5lqfJpcyOHD14elVwFEXA4T8sRNVNLIN/wN1D9TkSZ PY4iuXmQf6fJscRYU49GFGGuMK53RkKDmna64M1KvlsVNzBCgj9s096fvlNYxQlFXIcJ UvajW8LVvtmbmx008i1MkOtEiKBngBCHTgzIuRqj7d73b4POgwlyPCBSwlH5xSqDaQQG 9zrJPE9qlK8hgLyNONUAUPtMwcDzgonES+PKzcJMq3M9MHqP1VdxY2sCinGPPwK48YSy hcgTZ7IvE2mVwF4SoDgcIeA0dccmBTL+Gzlsq46KlbzXK9zf7hRArJWTi+bbGVkfAXw4 YQaA== X-Gm-Message-State: ACrzQf1dW2ovuNt72oOtVhlj91FTY9zHlZ36n83f2dRr5Ngki1s9j8kz ZpmqyKitDBTcz7dRSoEVcXVcZK69Zng= X-Google-Smtp-Source: AMsMyM6M1NZ7pGfRiGaR8KAeBLwcsFaXaO1GcoGAGmmrc8lyuPnVxHJ7Zuh4aoe0SK6UnBj4V9lHYA== X-Received: by 2002:a17:906:ef8c:b0:78d:46b7:6847 with SMTP id ze12-20020a170906ef8c00b0078d46b76847mr22882000ejb.241.1666525137565; Sun, 23 Oct 2022 04:38:57 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id q21-20020aa7da95000000b00458d383a6ddsm2455128eds.44.2022.10.23.04.38.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Oct 2022 04:38:57 -0700 (PDT) Message-ID: <01c0edd6f378636fb7a2a7d4dab8af7ca829e305.camel@HIDDEN> Subject: Re: [PATCH v3 2/2] services: mpd: Support socket activation. From: Liliana Marie Prikler <liliana.prikler@HIDDEN> To: 54986 <at> debbugs.gnu.org Date: Sun, 23 Oct 2022 13:38:56 +0200 In-Reply-To: <3105812906c619735df4a5f476c1c822c63bfb15.camel@HIDDEN> References: <3105812906c619735df4a5f476c1c822c63bfb15.camel@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 54986 Cc: Ludovic =?ISO-8859-1?Q?Court=E8s?= <ludo@HIDDEN>, Maxime Devos <maximedevos@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Am Samstag, dem 23.04.2022 um 16:39 +0200 schrieb Liliana Marie Prikler: > * gnu/services/audio.scm (<mpd-endpoint>): New record. > (<mpd-configuration>)[port, address]: Removed fields. > [endpoints]: New field. > (sanitize-mpd-endpoints, mpd-configuration-shepherd-endpoints): New > variables. > (mpd-shepherd-service): Use mpd-configuration-shepherd-endpoints. > * doc/guix.texi (Music Player Daemon): Document it. > --- Bump
guix-patches@HIDDEN:bug#54986; Package guix-patches.
Full text available.
Received: (at 54986) by debbugs.gnu.org; 10 Sep 2022 18:31:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 10 14:31:55 2022
Received: from localhost ([127.0.0.1]:40389 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oX5Gk-0001Ic-KL
for submit <at> debbugs.gnu.org; Sat, 10 Sep 2022 14:31:55 -0400
Received: from mail-ej1-f65.google.com ([209.85.218.65]:45969)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <liliana.prikler@HIDDEN>) id 1oX5Gf-0001IB-RI
for 54986 <at> debbugs.gnu.org; Sat, 10 Sep 2022 14:31:52 -0400
Received: by mail-ej1-f65.google.com with SMTP id dv25so11233364ejb.12
for <54986 <at> debbugs.gnu.org>; Sat, 10 Sep 2022 11:31:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=mime-version:message-id:content-transfer-encoding:cc:to:subject
:date:from:from:to:cc:subject:date;
bh=XiO8gnCxHDejLQac9nO0WN6awpRFU9cTHmARLqGWpd8=;
b=Qi6MnxjeLSUTJBuYtC1FdpXYaxLalK8GuQhrIc2flhpONbfOcm4in5mDBTGJ7Jc8Bd
LHrJ9Xs0nb+KCwhR3Xf0+MYdajoNG3iYu8j2/AMeOLtHFWzMEeDSemPecJuMtcD767fM
ughs1mTyLt4V7wESpPV0ITfaFt2vl8f69UOFvgdcoI7tXhJg/l799273AVgeAJ2p8Xb4
DBrL1AVVlwEKM31fge77Q1rGCOqNqpPzSwkLB76fS2mIs7APoocxmjJtNO4Xwc7K0SE/
CnyEmQ3jzzAJLTy9CjS89aWbokmjjCgvTvlcclg7DfSeihAm4bqIYxoTDtg7o/kErk8T
FEHA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=mime-version:message-id:content-transfer-encoding:cc:to:subject
:date:from:x-gm-message-state:from:to:cc:subject:date;
bh=XiO8gnCxHDejLQac9nO0WN6awpRFU9cTHmARLqGWpd8=;
b=jvcxsWZS/X368oqFFbmirLEODcWStM3XaLz7rIufgkHmvJWQUKYtX/FmE8QjaWmOYN
LXybkMeuh6Po7nOWEEQsytiyM+EuDE+/NYtOXXKRZGwniNwRNJ5FTj8nlIpzwvXYuYLQ
mSQANV+waC0XeBUVLQtGvveMsCU4t7/gV5WI8fegXszKeEqjkeDexdriykN2vWqb8E4k
5C21JXGI1lO5ii5VnHBjjyBI8SQ6xMtPKYkkTClReOS6dm8WBBkfy1nuc4LqXXK6QiAu
Ov1GHWYznf/HT94fgWHDF4wCZHFxrKI4Xwb4lD57IfKUk3PfwF+u1qlr4L6izdgllm29
XW1g==
X-Gm-Message-State: ACgBeo0C2h11RgBbJPJtvSxI/yGH91HQeMdu3A3DStRMFF+MnFF9jxic
V1GjRhtM7MJIMGk4uLCTgLGVoPwBDbw=
X-Google-Smtp-Source: AA6agR6cXne7/me6EJ70I5JNckty9Nm7Jy+gtlGSVwZm4Gvapezi6HIWSMwAEEiAmBNSAk8ss+oDmQ==
X-Received: by 2002:a17:907:b03:b0:770:872d:d7e9 with SMTP id
h3-20020a1709070b0300b00770872dd7e9mr12456175ejl.272.1662834703058;
Sat, 10 Sep 2022 11:31:43 -0700 (PDT)
Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
[85.127.52.93]) by smtp.gmail.com with ESMTPSA id
v12-20020a056402348c00b0043bbb3535d6sm2599993edc.66.2022.09.10.11.31.42
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 10 Sep 2022 11:31:42 -0700 (PDT)
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Date: Sat, 23 Apr 2022 16:25:55 +0200
Subject: [PATCH v3 1/2] services: shepherd: Add support for socket
activation endpoints.
to: 54986 <at> debbugs.gnu.org
Content-Transfer-Encoding: 7bit
Message-ID: <684304748f200de9493550d079d59dc8cfe2b002.camel@HIDDEN>
MIME-Version: 1.0
X-Spam-Score: 2.1 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: * gnu/services/shepherd.scm (<shepherd-endpoint>): New record
type. (shepherd-endpoint->sexp): New variable. * doc/guix.texi (Shepherd
Services): Document it. --- doc/guix.texi | 32 ++++++++++++++++++ [...]
Content analysis details: (2.1 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (liliana.prikler[at]gmail.com)
2.1 DATE_IN_PAST_96_XX Date: is 96 hours or more before Received:
date 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3)
[209.85.218.65 listed in wl.mailspike.net]
0.0 RCVD_IN_MSPIKE_WL Mailspike good senders
-0.0 T_SCC_BODY_TEXT_LINE No description available.
X-Debbugs-Envelope-To: 54986
Cc: Ludovic =?ISO-8859-1?Q?Court=E8s?= <ludo@HIDDEN>,
Maxime Devos <maximedevos@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.1 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: * gnu/services/shepherd.scm (<shepherd-endpoint>): New record
type. (shepherd-endpoint->sexp): New variable. * doc/guix.texi (Shepherd
Services): Document it. --- doc/guix.texi | 32 ++++++++++++++++++ [...]
Content analysis details: (1.1 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3)
[209.85.218.65 listed in wl.mailspike.net]
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (liliana.prikler[at]gmail.com)
2.1 DATE_IN_PAST_96_XX Date: is 96 hours or more before Received:
date
0.0 RCVD_IN_MSPIKE_WL Mailspike good senders
-0.0 T_SCC_BODY_TEXT_LINE No description available.
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
* gnu/services/shepherd.scm (<shepherd-endpoint>): New record type.
(shepherd-endpoint->sexp): New variable.
* doc/guix.texi (Shepherd Services): Document it.
---
doc/guix.texi | 32 ++++++++++++++++++++
gnu/services/shepherd.scm | 64 +++++++++++++++++++++++++++++++++++++++
2 files changed, 96 insertions(+)
diff --git a/doc/guix.texi b/doc/guix.texi
index c21235f28d..30cc3b6d45 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -39332,6 +39332,38 @@ This, as you can see, is a fairly sophisticated way to say hello.
info on actions.
@end deftp
+@deftp {Data Type} shepherd-endpoint
+This data type represents an endpoint for inetd-style and systemd-style
+services. Its fields reflect the arguments to shepherd's
+@code{endpoint} procedure.
+
+@table @code
+@item address
+The socket address to bind via shepherd and forward to the service.
+
+@item name
+A ``descriptive'' name to forward to the service along with the socket.
+
+@item style
+The socket style to use.
+@xref{Network Sockets and Communication,,, guile, GNU Guile Reference
+Manual}.
+
+@item backlog
+The maximum length of the queue for pending connections.
+
+@item socket-owner
+The user ID owning the socket.
+
+@item socket-group
+The group ID owning the socket.
+
+@item socket-directory-permissions
+The UNIX permissions to set for the directory the socket resides in.
+
+@end table
+@end deftp
+
@defvr {Scheme Variable} shepherd-root-service-type
The service type for the Shepherd ``root service''---i.e., PID@tie{}1.
diff --git a/gnu/services/shepherd.scm b/gnu/services/shepherd.scm
index 4fd4b2a497..f0d204ff3a 100644
--- a/gnu/services/shepherd.scm
+++ b/gnu/services/shepherd.scm
@@ -66,6 +66,17 @@ (define-module (gnu services shepherd)
shepherd-action-documentation
shepherd-action-procedure
+ shepherd-endpoint
+ shepherd-endpoint?
+ shepherd-endpoint-address
+ shepherd-endpoint-name
+ shepherd-endpoint-style
+ shepherd-endpoint-backlog
+ shepherd-endpoint-socket-owner
+ shepherd-endpoint-socket-group
+ shepherd-endpoint-socket-directory-permissions
+ shepherd-endpoint->sexp
+
%default-modules
shepherd-service-file
@@ -183,6 +194,59 @@ (define %default-modules
((guix build utils) #:hide (delete))
(guix build syscalls)))
+(define-record-type* <shepherd-endpoint>
+ shepherd-endpoint make-shepherd-endpoint
+ shepherd-endpoint?
+ (address shepherd-endpoint-address) ; sockaddr
+ (name shepherd-endpoint-name ; string | #f
+ (default #f))
+ (style shepherd-endpoint-style ; int | #f
+ (default #f))
+ (backlog shepherd-endpoint-backlog ; int | #f
+ (default #f))
+ (socket-owner shepherd-endpoint-socket-owner ; uid | #f
+ (default #f))
+ (socket-group shepherd-endpoint-socket-group ; gid | #f
+ (default #f))
+ (socket-directory-permissions
+ shepherd-endpoint-socket-directory-permissions ; chmod pattern (int) | #f
+ (default #f)))
+
+(define (shepherd-endpoint->sexp endpoint)
+ (match endpoint
+ (($ <shepherd-endpoint> address
+ name style backlog socket-owner socket-group
+ socket-directory-permissions)
+ `(endpoint
+ ,(match (sockaddr:fam address)
+ ((? (cute = <> AF_INET) _)
+ `((@ (guile) make-socket-addr)
+ AF_INET
+ ,(sockaddr:addr address)
+ ,(sockaddr:port address)))
+ ((? (cute = <> AF_INET6) _)
+ `((@ (guile) make-socket-addr)
+ AF_INET6
+ ,(sockaddr:addr address)
+ ,(sockaddr:port address)
+ ,(sockaddr:flowinfo address)
+ ,(sockaddr:scopeid address)))
+ ((? (cute = <> AF_UNIX) _)
+ `((@ (guile) make-socket-addr)
+ AF_UNIX
+ ,(sockaddr:path address))))
+ ,@(fold
+ (match-lambda*
+ (((key value) seed)
+ (if value (cons* key value seed) seed)))
+ '()
+ `((#:name ,name)
+ (#:style ,style)
+ (#:backlog ,backlog)
+ (#:socket-owner ,socket-owner)
+ (#:socket-group ,socket-group)
+ (#:socket-directory-permissions ,socket-directory-permissions)))))))
+
(define-record-type* <shepherd-service>
shepherd-service make-shepherd-service
shepherd-service?
--
2.37.3
guix-patches@HIDDEN:bug#54986; Package guix-patches.
Full text available.
Received: (at 54986) by debbugs.gnu.org; 10 Sep 2022 18:31:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 10 14:31:51 2022
Received: from localhost ([127.0.0.1]:40387 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oX5Gh-0001IN-0y
for submit <at> debbugs.gnu.org; Sat, 10 Sep 2022 14:31:51 -0400
Received: from mail-ed1-f66.google.com ([209.85.208.66]:42700)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <liliana.prikler@HIDDEN>) id 1oX5Gf-0001IA-Nm
for 54986 <at> debbugs.gnu.org; Sat, 10 Sep 2022 14:31:50 -0400
Received: by mail-ed1-f66.google.com with SMTP id q21so7128836edc.9
for <54986 <at> debbugs.gnu.org>; Sat, 10 Sep 2022 11:31:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=mime-version:message-id:content-transfer-encoding:cc:to:subject
:date:from:from:to:cc:subject:date;
bh=DfLDIrAOK4qB4Pw7AgXES9F2QW50ZL1LQTEWIvogyp8=;
b=Qq2NZJp+N7pKXff7GidlgdMKnug72RJoJkffqd19n1jNtbrzn9Ug9rkDxgrWg3jaop
O5FUYCYbbDWyp/Zvyc8/daIMYwQYmoFlu9WccOCL8bCe0MynVoKRW0aNE1mayV96DEuU
nEBTOPMxKy7qJbme8YMlQmIp4PBKH7In/FWYiCJJReP1Wls0Id08I5ZV4wXNjjTIPr/R
FxewcR0zGOhw6OkqxCf+78tTOfhqnVjanMhguaaOTlXpJwcA25FDP7fJaZz9TycIqHxK
Qv53KqVgx14y3wItnnUA5PzX+voP+0ZNGu7b4rMT+QYNXm+GsldyNYzOt1uKt2UPuCn5
p8WA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=mime-version:message-id:content-transfer-encoding:cc:to:subject
:date:from:x-gm-message-state:from:to:cc:subject:date;
bh=DfLDIrAOK4qB4Pw7AgXES9F2QW50ZL1LQTEWIvogyp8=;
b=jNoictNz8ZWYyCZJDMr3q3IIvktpLmqSefhc3vyBa6+j5BchS7Nh7lAfPgwYDOTsuf
ULnc1DFqkPxDU7CqjBOv958NK6vanF6yU7ltyR06Gt2Pa5wJq6c/k52E4aZGCPikq5/9
YYYYSMfk6bf60tlvhFln89PL/YOsMgF5scTMpfb1fAji0DEk80CMik/pSDs/J++M0CRY
1vgBzxBbb5IUtYkY9Vrr/ShyfZdJIJeS/eKUdqZl03QmDL/8wxQnuMztqDYxiorSiusW
Th/hLjWWtr3aEuIZAWE4T4aNetl+7CbTBNwFcTLH9PKX400XbWReobsa6tPJHwx/DK4j
+LLQ==
X-Gm-Message-State: ACgBeo3WftsaxmrczvLcDA5Znez+S48EeHVtq3gImtw6nT3S6mkWiEvI
ADG10pj6+40pB1f7xgfcFR0bVrRJwQM=
X-Google-Smtp-Source: AA6agR6uotoEaYa0zjQOT2iM+fw7IcorRjz5GKUuzc9cS+M6bPf84AVBwndcPyVkK+wV7VL0M0QmUQ==
X-Received: by 2002:a05:6402:22c7:b0:451:403e:68f5 with SMTP id
dm7-20020a05640222c700b00451403e68f5mr3791486edb.242.1662834703711;
Sat, 10 Sep 2022 11:31:43 -0700 (PDT)
Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
[85.127.52.93]) by smtp.gmail.com with ESMTPSA id
v12-20020a056402348c00b0043bbb3535d6sm2599993edc.66.2022.09.10.11.31.43
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 10 Sep 2022 11:31:43 -0700 (PDT)
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Date: Sat, 23 Apr 2022 16:39:59 +0200
Subject: [PATCH v3 2/2] services: mpd: Support socket activation.
to: 54986 <at> debbugs.gnu.org
Content-Transfer-Encoding: 7bit
Message-ID: <3105812906c619735df4a5f476c1c822c63bfb15.camel@HIDDEN>
MIME-Version: 1.0
X-Spam-Score: 2.1 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: * gnu/services/audio.scm (<mpd-endpoint>): New record.
(<mpd-configuration>)[port,
address]: Removed fields. [endpoints]: New field. (sanitize-mpd-endpoints,
mpd-configuration-shepherd-endpoints): New [...]
Content analysis details: (2.1 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (liliana.prikler[at]gmail.com)
2.1 DATE_IN_PAST_96_XX Date: is 96 hours or more before Received:
date -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[209.85.208.66 listed in wl.mailspike.net]
-0.0 T_SCC_BODY_TEXT_LINE No description available.
X-Debbugs-Envelope-To: 54986
Cc: Ludovic =?ISO-8859-1?Q?Court=E8s?= <ludo@HIDDEN>,
Maxime Devos <maximedevos@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.1 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: * gnu/services/audio.scm (<mpd-endpoint>): New record. (<mpd-configuration>)[port,
address]: Removed fields. [endpoints]: New field. (sanitize-mpd-endpoints,
mpd-configuration-shepherd-endpoints): New [...]
Content analysis details: (1.1 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[209.85.208.66 listed in wl.mailspike.net]
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (liliana.prikler[at]gmail.com)
2.1 DATE_IN_PAST_96_XX Date: is 96 hours or more before Received:
date
-0.0 T_SCC_BODY_TEXT_LINE No description available.
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
* gnu/services/audio.scm (<mpd-endpoint>): New record.
(<mpd-configuration>)[port, address]: Removed fields.
[endpoints]: New field.
(sanitize-mpd-endpoints, mpd-configuration-shepherd-endpoints): New variables.
(mpd-shepherd-service): Use mpd-configuration-shepherd-endpoints.
* doc/guix.texi (Music Player Daemon): Document it.
---
doc/guix.texi | 23 ++++++++--
gnu/services/audio.scm | 98 +++++++++++++++++++++++++++++++++---------
2 files changed, 97 insertions(+), 24 deletions(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index 30cc3b6d45..d5b9de0de2 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -32192,15 +32192,30 @@ The location of the file that stores current MPD's state.
@item @code{sticker-file} (default: @code{"~/.mpd/sticker.sql"})
The location of the sticker database.
-@item @code{port} (default: @code{"6600"})
-The port to run mpd on.
+@item @code{endpoints} (default: @code{(list (mpd-endpoint))})
+The endpoints to bind MPD to. This can be an mpd-endpoint (see below)
+or a list of shepherd endpoints. If using shepherd endpoints, MPD
+will be spawned as a systemd-style service rather than as a
+forkexec-style one. This delays the start of MPD until the first client
+connects.
+
+@item @code{outputs} (default: @code{"(list (mpd-output))"})
+The audio outputs that MPD can use. By default this is a single output using pulseaudio.
+
+@end table
+@end deftp
+
+@deftp {Data Type} mpd-endpoint
+Data type representing the configuration of @command{mpd}.
+
+@table @asis
@item @code{address} (default: @code{"any"})
The address that mpd will bind to. To use a Unix domain socket,
an absolute path can be specified here.
-@item @code{outputs} (default: @code{"(list (mpd-output))"})
-The audio outputs that MPD can use. By default this is a single output using pulseaudio.
+@item @code{port} (default: @code{"6600"})
+The port to run mpd on.
@end table
@end deftp
diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm
index c60053f33c..6e8fd460a1 100644
--- a/gnu/services/audio.scm
+++ b/gnu/services/audio.scm
@@ -20,6 +20,8 @@
(define-module (gnu services audio)
#:use-module (guix gexp)
+ #:use-module (guix diagnostics)
+ #:use-module (guix i18n)
#:use-module (gnu services)
#:use-module (gnu services shepherd)
#:use-module (gnu system shadow)
@@ -28,8 +30,14 @@ (define-module (gnu services audio)
#:use-module (guix records)
#:use-module (ice-9 match)
#:use-module (ice-9 format)
+ #:use-module (srfi srfi-1)
+ #:use-module (srfi srfi-26)
+ #:use-module (srfi srfi-34)
+ #:use-module (srfi srfi-35)
#:export (mpd-output
mpd-output?
+ mpd-endpoint
+ mpd-endpoint?
mpd-configuration
mpd-configuration?
mpd-service-type))
@@ -59,6 +67,30 @@ (define-record-type* <mpd-output>
(extra-options mpd-output-extra-options
(default '())))
+(define-record-type* <mpd-endpoint>
+ mpd-endpoint make-mpd-endpoint
+ mpd-endpoint?
+ (address mpd-endpoint-address (default "any"))
+ (port mpd-endpoint-port (default "6600")))
+
+(define-with-syntax-properties (sanitize-mpd-endpoints (endpoints properties))
+ (match endpoints
+ ((? mpd-endpoint? endpoint) (list endpoint))
+ (((? mpd-endpoint?)) endpoints)
+ (((? mpd-endpoint?) . _)
+ (raise (make-compound-condition
+ (condition (&message
+ (message
+ (G_ "\
+<mpd-endpoint> is mutually exclusive with other endpoints."))))
+ (condition (&error-location
+ (location (source-properties->location properties))))
+ (condition (&fix-hint
+ (hint "\
+Make sure you only need one endpoint or use shepherd endpoints instead."))))))
+ (((? shepherd-endpoint?) . (? (cute every shepherd-endpoint? <>)))
+ endpoints)))
+
(define-record-type* <mpd-configuration>
mpd-configuration make-mpd-configuration
mpd-configuration?
@@ -74,10 +106,9 @@ (define-record-type* <mpd-configuration>
(default "~/.mpd/state"))
(sticker-file mpd-configuration-sticker-file
(default "~/.mpd/sticker.sql"))
- (port mpd-configuration-port
- (default "6600"))
- (address mpd-configuration-address
- (default "any"))
+ (endpoints mpd-configuration-endpoints ; list of <shepherd-endpoint>
+ (default (list (mpd-endpoint))) ; | <mpd-endpoint>
+ (sanitize sanitize-mpd-endpoints))
(outputs mpd-configuration-outputs
(default (list (mpd-output)))))
@@ -124,9 +155,12 @@ (define (mpd-config->file config)
("playlist_directory" ,mpd-configuration-playlist-dir)
("db_file" ,mpd-configuration-db-file)
("state_file" ,mpd-configuration-state-file)
- ("sticker_file" ,mpd-configuration-sticker-file)
- ("port" ,mpd-configuration-port)
- ("bind_to_address" ,mpd-configuration-address))))))
+ ("sticker_file" ,mpd-configuration-sticker-file)))
+ (match (mpd-configuration-endpoints config)
+ (($ <mpd-endpoint> address port)
+ `(("bind_to_address" ,address)
+ ("port" ,port)))
+ (_ '())))))
(define (mpd-file-name config file)
"Return a path in /var/run/mpd/ that is writable
@@ -135,24 +169,48 @@ (define (mpd-file-name config file)
(mpd-configuration-user config)
"/" file))
+(define (mpd-configuration-shepherd-endpoints config)
+ "Return @code{(mpd-configuration-endpoints config)}"
+ (let ((endpoints (mpd-configuration-endpoints config)))
+ (match endpoints
+ (((? shepherd-endpoint?) . _) endpoints)
+ (_ #f))))
+
(define (mpd-shepherd-service config)
(shepherd-service
(documentation "Run the MPD (Music Player Daemon)")
(requirement '(user-processes))
(provision '(mpd))
- (start #~(make-forkexec-constructor
- (list #$(file-append mpd "/bin/mpd")
- "--no-daemon"
- #$(mpd-config->file config))
- #:environment-variables
- ;; Required to detect PulseAudio when run under a user account.
- (list (string-append
- "XDG_RUNTIME_DIR=/run/user/"
- (number->string
- (passwd:uid
- (getpwnam #$(mpd-configuration-user config))))))
- #:log-file #$(mpd-file-name config "log")))
- (stop #~(make-kill-destructor))))
+ (start (if (mpd-configuration-shepherd-endpoints config)
+ #~(make-systemd-constructor
+ (list #$(file-append mpd "/bin/mpd")
+ "--systemd"
+ #$(mpd-config->file config))
+ (list #$@(map shepherd-endpoint->sexp
+ (mpd-configuration-shepherd-endpoints config)))
+ #:environment-variables
+ ;; Required to detect PulseAudio when run under a user account.
+ (list (string-append
+ "XDG_RUNTIME_DIR=/run/user/"
+ (number->string
+ (passwd:uid
+ (getpwnam #$(mpd-configuration-user config))))))
+ #:log-file #$(mpd-file-name config "log"))
+ #~(make-forkexec-constructor
+ (list #$(file-append mpd "/bin/mpd")
+ "--no-daemon"
+ #$(mpd-config->file config))
+ #:environment-variables
+ ;; Required to detect PulseAudio when run under a user account.
+ (list (string-append
+ "XDG_RUNTIME_DIR=/run/user/"
+ (number->string
+ (passwd:uid
+ (getpwnam #$(mpd-configuration-user config))))))
+ #:log-file #$(mpd-file-name config "log"))))
+ (stop (if (mpd-configuration-shepherd-endpoints config)
+ #~(make-systemd-destructor)
+ #~(make-kill-destructor)))))
(define (mpd-service-activation config)
(with-imported-modules '((guix build utils))
--
2.37.3
guix-patches@HIDDEN:bug#54986; Package guix-patches.
Full text available.Received: (at 54986) by debbugs.gnu.org; 13 May 2022 17:00:52 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 13 13:00:51 2022 Received: from localhost ([127.0.0.1]:44896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1npYep-00025w-Lx for submit <at> debbugs.gnu.org; Fri, 13 May 2022 13:00:51 -0400 Received: from mail-ej1-f65.google.com ([209.85.218.65]:39812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <liliana.prikler@HIDDEN>) id 1npYen-00025d-Ls for 54986 <at> debbugs.gnu.org; Fri, 13 May 2022 13:00:50 -0400 Received: by mail-ej1-f65.google.com with SMTP id bv19so17413652ejb.6 for <54986 <at> debbugs.gnu.org>; Fri, 13 May 2022 10:00:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=JN5U+gAgTD/IH3wmOSQ28ZxIcZOrP1192oQArTCvSF8=; b=Yfj2PtaL8Dx3DJ5F8ewd+NDmTH59LKC1ntHOM/SthglIzFpXFSvGRkNyDom5GFSRFQ 1UIxZ+MXluRwcBbpcJKtZIfuLp5yz6qy7xIjmt1NJQdrXM8Dl/NTUX6s4TZlnPd0BOAT rWFc/sPg1WrB6Bru5jKJNwtgUbF3hnBGPpZX8jOXQU185GFRAqhoXAd32/Sja4slNDzj PWacAJA3wqm18YRzo6H9usC0KsKORvCLVnOGVN0dnUNViR0NQL7u6jYN6Llo7/beAheX YKnPY67jzeK4sjDBwoCxetHnDX590ZP/PHeEEQ5MkWI+3EIzatbzfw4XctqTQB/7W2Qe y8xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=JN5U+gAgTD/IH3wmOSQ28ZxIcZOrP1192oQArTCvSF8=; b=Y9pQqeDEAH+g0bwLxcLkJm3SCK3n0vEcgdk0pbqnQDWHwU9+dknbCNGVrFBUTb92zw 0+77CI4WxuuW48bDV7fbiZ6Eb4+1e/ckf7fNZzMR0iDQt1VZxW3+bnNVr0BYwmEh3O2y aki55Y5lAovGyCOpRepkC/2QE5vCvHlEqcLpHGfF7dHEXOaipF5dw7wC7F9n6d9lmKaR 5/UmH9OyNL8O+wyQ3996BHofX6CcxIxJKmQORQtCmDaKlvZMtkwu39gJblld8VC4dQ4K 4dAl1y5GaimlaQEB6SUx3ROiBThmp7lcyX/c8t1cfRFrnsh5Lmmcnd+wFEr1n/mPDu9y mPlQ== X-Gm-Message-State: AOAM532hC2XdNHlMKtBPrpw/l1ucQ15ZlF4OSBhoiBYDNJnvaLDGD6Cz xQ+pzZ3lVrteL1f+JllBKyc= X-Google-Smtp-Source: ABdhPJwcLmZby5X0YKaxj4Qw4sqaKXHyEA8FwUe3qU+wkq3+gAaWwkoicuu9yQjgXRopevYWzh559w== X-Received: by 2002:a17:906:d9d1:b0:6fd:d8d5:5c9c with SMTP id qk17-20020a170906d9d100b006fdd8d55c9cmr5058426ejb.665.1652461243468; Fri, 13 May 2022 10:00:43 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id u11-20020a50eacb000000b0042617ba6383sm1198062edp.13.2022.05.13.10.00.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 10:00:42 -0700 (PDT) Message-ID: <d3bb074bff53a0503742b953762ac46de5f0b9cc.camel@HIDDEN> Subject: Re: bug#54986: [PATCH] gnu: mpd: Add support for socket activation. From: Liliana Marie Prikler <liliana.prikler@HIDDEN> To: Ludovic =?ISO-8859-1?Q?Court=E8s?= <ludo@HIDDEN> Date: Fri, 13 May 2022 19:00:41 +0200 In-Reply-To: <87ee0xfmvb.fsf_-_@HIDDEN> References: <155723efbcf08c6e0bb6552b8f6341d4a1f20ecb.camel@HIDDEN> <87y1zqfabs.fsf@HIDDEN> <87ee0xfmvb.fsf_-_@HIDDEN> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54986 Cc: 54986 <at> debbugs.gnu.org, Maxime Devos <maximedevos@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Am Freitag, dem 13.05.2022 um 17:55 +0200 schrieb Ludovic Courtès: > Hi Liliana, > > What’s the status of this patch series? Would be nice to have it in! The patch for MPD itself is good to go as far as I'm aware, the patch for the service type is work in progress. This question > Ludovic Courtès <ludo@HIDDEN> skribis: > > The way I see it, service configuration should be oblivious to > > whether it’s started as “forkexec”, systemd, or inetd. has me in a bit of a bind in multiple ways. For one, I don't see a direct translation from MPD's configuration scheme to shepherd's. For another, the distinct semantics between forkexec and lazy loading cause observable differences as in “What the fuck, I only ran mpc status, why is the music now playing?” – this can be avoided if the user knows that shepherd will be lazy-loading mpd and that it might as a result to starting start playing on the first received command. Moreover, I think the patch I added to make endpoint records configurable from Guix could also serve to solve other bugs, e.g. SSH only listening on IPv4 addresses, which would require us to be able to specify whether to listen on IPv4, IPv6 or both through Guix. Long term, I think we should only keep the distinction between forkexec and inetd/systemd for those services where it makes an observable difference, like mpd. For SSH, apart from bugs and perhaps people using old shepherd, I don't think there'd be any reason to keep forkexec beyond a certain point (in a future as distant as you would want it to be). Maxime also raised hygiene concerns that would be comparatively easy to solve. TL;DR: v2 [1/3] is good, [2/3 WIP] and [3/3 WIP] should be kept back for now. Cheers
guix-patches@HIDDEN:bug#54986; Package guix-patches.
Full text available.
Received: (at 54986) by debbugs.gnu.org; 13 May 2022 15:55:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 13 11:55:48 2022
Received: from localhost ([127.0.0.1]:44792 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1npXdr-0006Cf-UF
for submit <at> debbugs.gnu.org; Fri, 13 May 2022 11:55:48 -0400
Received: from eggs.gnu.org ([209.51.188.92]:56438)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ludo@HIDDEN>) id 1npXdq-0006CT-BP
for 54986 <at> debbugs.gnu.org; Fri, 13 May 2022 11:55:46 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:35846)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
id 1npXdk-0001wp-VN; Fri, 13 May 2022 11:55:40 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
From; bh=zDg3DNOL2/Oqb3v9adKZ9vvJarDK4G6mm2nNGfSsIb8=; b=sICyZDk9VCYW0Rfu0+sc
K6MeikNUQWqtmbA8Wc4Md60fjESLgqiXaaQoj+8vzbdm9ZXlg4AJa7gp/PPqF1tdhsZVj+e3zAZtd
T7xS78veaP42PudQHqCrwvpyUa4ViycHXy14AlqW40r468QCh8dIxhPBUDrxhpl+wL1zjb7f4Egvg
SC0lwgz0/0H/cAQvO2ijxHtE0Z7FDxBndLOZkon8HDn1cHnEQBhMjH0vE2ZHd4FaUrSuDzhab2VTh
JwBpenSY/sVAZuJiv1Rfc2BQlMOHOuHH0vkb+9aZTf5WI1TrXagpY96+H7umnADxwZgitSDMvqjCl
cdy6yWFSc7JWIA==;
Received: from [193.50.110.244] (port=52724 helo=ribbon)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
id 1npXdi-0000eP-BH; Fri, 13 May 2022 11:55:40 -0400
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Subject: Re: bug#54986: [PATCH] gnu: mpd: Add support for socket activation.
References: <155723efbcf08c6e0bb6552b8f6341d4a1f20ecb.camel@HIDDEN>
<87y1zqfabs.fsf@HIDDEN>
Date: Fri, 13 May 2022 17:55:36 +0200
In-Reply-To: <87y1zqfabs.fsf@HIDDEN> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?=
=?utf-8?Q?s?= message of "Thu, 28 Apr 2022 00:08:55 +0200")
Message-ID: <87ee0xfmvb.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 54986
Cc: 54986 <at> debbugs.gnu.org, Maxime Devos <maximedevos@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Hi Liliana,
What=E2=80=99s the status of this patch series? Would be nice to have it i=
n!
Ludo=E2=80=99.
Ludovic Court=C3=A8s <ludo@HIDDEN> skribis:
> Liliana Marie Prikler <liliana.prikler@HIDDEN> skribis:
>
>> * gnu/services/audio.scm (<mpd-configuration>)[shepherd-endpoints]: New =
field.
>> (mpd-shepherd-service): Use it.
>> * doc/guix.texi (Music Player Daemon): Document it.
>
> [...]
>
>> +++ b/gnu/services/audio.scm
>> @@ -78,6 +78,8 @@ (define-record-type* <mpd-configuration>
>> (default "6600"))
>> (address mpd-configuration-address
>> (default "any"))
>> + (shepherd-endpoints mpd-configuration-shepherd-endpoints
>> + (default '())) ; list of <shepherd-endpoint>
>
> The way I see it, service configuration should be oblivious to whether
> it=E2=80=99s started as =E2=80=9Cforkexec=E2=80=9D, systemd, or inetd.
>
> There=E2=80=99s already an =E2=80=98address=E2=80=99 field above, so my s=
uggestion would be to
> reuse it. This is what I did for example for the openssh service, and
> also for bitlbee and dicod here:
>
> https://issues.guix.gnu.org/54997#5
>
> WDYT?
>
> Thanks,
> Ludo=E2=80=99.
guix-patches@HIDDEN:bug#54986; Package guix-patches.
Full text available.
Received: (at 54986) by debbugs.gnu.org; 28 Apr 2022 16:45:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 28 12:45:24 2022
Received: from localhost ([127.0.0.1]:49805 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nk7Gd-0000fy-Qv
for submit <at> debbugs.gnu.org; Thu, 28 Apr 2022 12:45:23 -0400
Received: from mail-ed1-f65.google.com ([209.85.208.65]:42646)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <liliana.prikler@HIDDEN>) id 1nk7Gc-0000fm-6N
for 54986 <at> debbugs.gnu.org; Thu, 28 Apr 2022 12:45:22 -0400
Received: by mail-ed1-f65.google.com with SMTP id z19so6174710edx.9
for <54986 <at> debbugs.gnu.org>; Thu, 28 Apr 2022 09:45:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=message-id:subject:from:to:cc:date:in-reply-to:references
:user-agent:mime-version:content-transfer-encoding;
bh=Fn/cLf9fs+l6JdPMktfUqaAMVfOiE2lbV8n8vQ5iMTY=;
b=IaARPXNMiqFiOYd5+F/PKMSP08mgM2JX8QxGgqa6WLlafXjEkeoiK8Z5/BBILVpngM
NnM02MdCbDgknNnfZ8KhkYdWrxN8YHqjV3BgeiV4/tqcZV6xHFrnTXK8tIbRpFAmNEK3
Duu+0CKjrjALmOZQ6tHhGIb8ZjrI5u/D+zfDbzvxhDu3I2WtfNgyKlNVhA63WHjGxLTa
rlUgQtwB+EBiHcGuzDMVW08GtGvRXUbIIay/zg2OmMkoVYDp8HNemuLe0BC+sgizHbEv
pBXemuqan7UhTY0xnyE8DUqb+krnsZIKbOJ6wd9g1qKSKCAgjoNlFhE2uPkl8cjCEWA0
dVqg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
:references:user-agent:mime-version:content-transfer-encoding;
bh=Fn/cLf9fs+l6JdPMktfUqaAMVfOiE2lbV8n8vQ5iMTY=;
b=fDmpNoDJK55dU1keFm/H99D0UBZ6o3eIV5oCHIw7KwbZFOuUpkXRMRI5M9k8H/uiup
s+pAozGCj7cb79FgfC54sGRI+qutpXn66fn3ei7eM7zpR9GlNcxR9zuIUGqiFzOy6gng
oQTdEdtiWstZR7bUohkgNFGmMAI3FWyxIVogrtWcnDPcLI7JupgKpIzD4AUR73jXJflV
cFA0wEfWuZdfQNkTLsC5Vr9sAJTFMItytfchzoefaz3RUOo5Wp6W+yusVl+DHMD1E+yP
0xT/zOYJfFIPXMNq2YR1MRIcA3RHb2TC8yaQjxxj0P6twGEN+GFRMMu4En80R4WIFnvv
MEUA==
X-Gm-Message-State: AOAM531cg/+KjuNKpV/tHBhsgDA5gUel/ub5CTfZ1OOdP2S97hQEXL+Q
R7Rae+t9gGxLbKPKZMcphZ4=
X-Google-Smtp-Source: ABdhPJwI3HXwiK+4BIvScXHq974oONZ1A9E0yZACcm8AVBhH9ya6xOqXwcOXG9pv5mLo8iesM0IsnA==
X-Received: by 2002:a05:6402:2714:b0:426:1c9a:6375 with SMTP id
y20-20020a056402271400b004261c9a6375mr8006120edd.221.1651164316225;
Thu, 28 Apr 2022 09:45:16 -0700 (PDT)
Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
[85.127.52.93]) by smtp.gmail.com with ESMTPSA id
j12-20020aa7de8c000000b0042617ba63b2sm1871936edv.60.2022.04.28.09.45.14
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 28 Apr 2022 09:45:14 -0700 (PDT)
Message-ID: <aa80e431411c64da21253501eeaf3e8e722a4d49.camel@HIDDEN>
Subject: Re: bug#54986: [PATCH] gnu: mpd: Add support for socket activation.
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
To: Ludovic =?ISO-8859-1?Q?Court=E8s?= <ludo@HIDDEN>
Date: Thu, 28 Apr 2022 18:45:13 +0200
In-Reply-To: <87v8uui6st.fsf@HIDDEN>
References: <9d4cc9d3ebb05d2aabf8f06e1890efe9b0b9a849.camel@HIDDEN>
<87o80zzagn.fsf@HIDDEN>
<a710e56204436941d99c663d76cf7e51c6a2ed60.camel@HIDDEN>
<87fsmaumok.fsf@HIDDEN>
<413952d60ee9444bff89412751b8c7c97a0102a1.camel@HIDDEN>
<87v8uui6st.fsf@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 54986
Cc: 54986 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Am Mittwoch, dem 27.04.2022 um 22:56 +0200 schrieb Ludovic Courtès:
>
> > Interestingly, the running value for the mpd service remains
> > (("unknown" . "#<input-output: socket 17>")) even after MPD
> > started. Should that be the case?
>
> No.
It turns out the issue here was that I rewrote the service to put its
log into XDG_STATE_HOME as well, but under a directory that did not yet
exist. #55080 addresses this.
Cheers
guix-patches@HIDDEN:bug#54986; Package guix-patches.
Full text available.Received: (at 54986) by debbugs.gnu.org; 27 Apr 2022 22:09:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 27 18:09:04 2022 Received: from localhost ([127.0.0.1]:44695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1njpqK-0006oA-C8 for submit <at> debbugs.gnu.org; Wed, 27 Apr 2022 18:09:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1njpqJ-0006ni-AD for 54986 <at> debbugs.gnu.org; Wed, 27 Apr 2022 18:09:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38266) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1njpqD-0000B1-88; Wed, 27 Apr 2022 18:08:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=xw9jaGc4HDhftwm6DNQkQ7997JIT3DN8fEhbiQ1nyRA=; b=RTxQMuZvIiuryEx6zlyR lnKE0GkA+tw4jDDWRH4mgff5MdMlBj9OzfBUnO1ljDtKCC/F9pwUt2dzj+bZo//OJQInGp3OMzO3Z V+Ps5n7xFd7FFuSe+4d2lBXdaRtms1pS3658+5rO+Y/6jiGWIdSFjG0ZYTjD5nN6cVbZV50rznrao ppVBL0NKNOEH8ftiLUg7LM68o9IEzh24zX//OlzRdCMfUVJ3XzCxWponQtShbU2xhIE1R1l8bnYfV NynhL3hJPQ02vmtW+WmBcGIINLFamB8AJGBrW0yF5CWf5aUqZ8W6FK04RWYOl44fxf89FlrSiX4CZ Ci84PWlJx+xO2Q==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:50558 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1njpqC-0006nu-Qa; Wed, 27 Apr 2022 18:08:57 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: Liliana Marie Prikler <liliana.prikler@HIDDEN> Subject: Re: [PATCH v2 3/3 WIP] services: mpd: Support socket activation. References: <155723efbcf08c6e0bb6552b8f6341d4a1f20ecb.camel@HIDDEN> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 9 =?utf-8?Q?Flor=C3=A9al?= an 230 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 28 Apr 2022 00:08:55 +0200 In-Reply-To: <155723efbcf08c6e0bb6552b8f6341d4a1f20ecb.camel@HIDDEN> (Liliana Marie Prikler's message of "Sat, 23 Apr 2022 16:39:59 +0200") Message-ID: <87y1zqfabs.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54986 Cc: 54986 <at> debbugs.gnu.org, Maxime Devos <maximedevos@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Liliana Marie Prikler <liliana.prikler@HIDDEN> skribis: > * gnu/services/audio.scm (<mpd-configuration>)[shepherd-endpoints]: New f= ield. > (mpd-shepherd-service): Use it. > * doc/guix.texi (Music Player Daemon): Document it. [...] > +++ b/gnu/services/audio.scm > @@ -78,6 +78,8 @@ (define-record-type* <mpd-configuration> > (default "6600")) > (address mpd-configuration-address > (default "any")) > + (shepherd-endpoints mpd-configuration-shepherd-endpoints > + (default '())) ; list of <shepherd-endpoint> The way I see it, service configuration should be oblivious to whether it=E2=80=99s started as =E2=80=9Cforkexec=E2=80=9D, systemd, or inetd. There=E2=80=99s already an =E2=80=98address=E2=80=99 field above, so my sug= gestion would be to reuse it. This is what I did for example for the openssh service, and also for bitlbee and dicod here: https://issues.guix.gnu.org/54997#5 WDYT? Thanks, Ludo=E2=80=99.
guix-patches@HIDDEN:bug#54986; Package guix-patches.
Full text available.Received: (at 54986) by debbugs.gnu.org; 27 Apr 2022 22:05:29 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 27 18:05:29 2022 Received: from localhost ([127.0.0.1]:44689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1njpmq-0006iT-S5 for submit <at> debbugs.gnu.org; Wed, 27 Apr 2022 18:05:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1njpmo-0006iG-RT for 54986 <at> debbugs.gnu.org; Wed, 27 Apr 2022 18:05:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38122) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1njpmj-0008C5-MA; Wed, 27 Apr 2022 18:05:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=RPze33+ibaxWZuw9yqDXgJCkEoD3m7Kyf4SgiJnrJQM=; b=YLEBCcNQcz31sQ4QQmuK uDFPcmTwY0oloDuUMAVJOYaUaNSsKk3uJ73EhmkfWe/j1RJ2i9o43yvHg9Onbbs8sqZ33aQhb7MeZ nqPZ1NPAaasL+5yvM6CVTBYLyrURaBdUNlg4JnQYLp+B6hv2GKOYNoC+ozDZMFJoOq2jmxlo4mexj tIggE9P2J4iy1kvq47bIv8ULdIL2vkqCRCJ2wzRWtmNZ9SisTI+7WYCuGd099C/je+0X0o2BJJdPQ IDgbopk1oqdyXaOiNRzn3BJ/4i87IRXdVtFric28gA1hVz05CRSvJy6MOr5nMf/JgUsvMwevF6IjY 5LKverPznKwVCg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:59794 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1njpmj-0006Rm-Ab; Wed, 27 Apr 2022 18:05:21 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: Liliana Marie Prikler <liliana.prikler@HIDDEN> Subject: Re: [PATCH v2 2/3 WIP] services: shepherd: Add support for socket activation endpoints. References: <454555484d434cefead47968e938ea071fe6121a.camel@HIDDEN> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 9 =?utf-8?Q?Flor=C3=A9al?= an 230 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 28 Apr 2022 00:05:19 +0200 In-Reply-To: <454555484d434cefead47968e938ea071fe6121a.camel@HIDDEN> (Liliana Marie Prikler's message of "Sat, 23 Apr 2022 16:25:55 +0200") Message-ID: <874k2egp28.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54986 Cc: 54986 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Hi, Liliana Marie Prikler <liliana.prikler@HIDDEN> skribis: > * gnu/services/shepherd.scm (<shepherd-endpoint>): New record type. > (shepherd-endpoint->sexp): New variable. > * doc/guix.texi (Shepherd Services): Document it. [...] > +++ b/gnu/services/shepherd.scm > @@ -66,6 +66,16 @@ (define-module (gnu services shepherd) > shepherd-action-documentation > shepherd-action-procedure >=20=20 > + shepherd-endpoint > + shepherd-endpoint-address > + shepherd-endpoint-name > + shepherd-endpoint-style > + shepherd-endpoint-backlog > + shepherd-endpoint-socket-owner > + shepherd-endpoint-socket-group > + shepherd-endpoint-socket-directory-permissions > + shepherd-endpoint->sexp > + > %default-modules >=20=20 > shepherd-service-file > @@ -183,6 +193,56 @@ (define %default-modules > ((guix build utils) #:hide (delete)) > (guix build syscalls))) >=20=20 > +(define-record-type* <shepherd-endpoint> I don=E2=80=99t think this is necessary: Shepherd endpoints are created in a #~(make-systemd-constructor =E2=80=A6) gexp, it=E2=80=99s OK to use the She= pherd endpoint API there. Ludo=E2=80=99.
guix-patches@HIDDEN:bug#54986; Package guix-patches.
Full text available.
Received: (at 54986) by debbugs.gnu.org; 27 Apr 2022 20:56:59 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 27 16:56:58 2022
Received: from localhost ([127.0.0.1]:44563 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1njoiY-0004ko-MV
for submit <at> debbugs.gnu.org; Wed, 27 Apr 2022 16:56:58 -0400
Received: from eggs.gnu.org ([209.51.188.92]:57466)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ludo@HIDDEN>) id 1njoiX-0004kW-Iv
for 54986 <at> debbugs.gnu.org; Wed, 27 Apr 2022 16:56:57 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:37046)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
id 1njoiS-0007AM-8I; Wed, 27 Apr 2022 16:56:52 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
From; bh=hY8PxDSn6GDlLESWtZJmEMzu2xvdPMxpWOXC2OOLJWU=; b=XlKDUzUbM0AL8VQWySOx
6i21ZhNTCjByo1OPoqaoYQL62A8ldbloQzAeueDKZk0Khu0q3DOyWRpRF+4haiVdm0zxH+eLtQeg5
NzwUXU38qXKHInt5d7VtSJUOq6/BFYlWAtz9oYL8T+gCobfw33b0vuZRgWa6PNaatbgntGb3Zz1/M
7P733pXYLK5mmENzqzrCRYUn6x220fQsxZmAX79+ldhzD6/Sd9+BSgo0nFOJwyqjE6WRfU4nz5EyV
TaLVUVAXjTZ/hOOEeAvucnRp7dVyEmK5FLhLZDVucp4xgjAcPnXsWmWKr+PUMPui2Awdal9JXMtYr
kzYwbvXWnYdbxw==;
Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:52289
helo=ribbon)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
id 1njoiR-0006Qi-SH; Wed, 27 Apr 2022 16:56:52 -0400
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Subject: Re: bug#54986: [PATCH] gnu: mpd: Add support for socket activation.
References: <9d4cc9d3ebb05d2aabf8f06e1890efe9b0b9a849.camel@HIDDEN>
<87o80zzagn.fsf@HIDDEN>
<a710e56204436941d99c663d76cf7e51c6a2ed60.camel@HIDDEN>
<87fsmaumok.fsf@HIDDEN>
<413952d60ee9444bff89412751b8c7c97a0102a1.camel@HIDDEN>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: 8 =?utf-8?Q?Flor=C3=A9al?= an 230 de la =?utf-8?Q?R?=
=?utf-8?Q?=C3=A9volution?=
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
Date: Wed, 27 Apr 2022 22:56:50 +0200
In-Reply-To: <413952d60ee9444bff89412751b8c7c97a0102a1.camel@HIDDEN>
(Liliana Marie Prikler's message of "Mon, 18 Apr 2022 23:19:12 +0200")
Message-ID: <87v8uui6st.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 54986
Cc: 54986 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Hi,
Liliana Marie Prikler <liliana.prikler@HIDDEN> skribis:
[...]
>> Do you mean that =E2=80=98herd stop mpd=E2=80=99 doesn=E2=80=99t stop th=
e mpd process?
> Yep.
>> What does /var/log/messages say?
> I don't think there's anything meaningful there to inspect, I'm running
> this as a user service. Shepherd's own logs are rather empty.
Then it=E2=80=99s in ~/.local/state (by default) or
~/.local/var/log/shepherd.log if you=E2=80=99re using Guix Home.
> Interestingly, the running value for the mpd service remains
> (("unknown" . "#<input-output: socket 17>")) even after MPD started.=20
> Should that be the case?
No.
>> > and shepherd won't restart a killed MPD without asked to.
>>=20
>> Weird.=C2=A0 What you describe sounds as if shepherd is not looking at t=
he
>> right process or something.
>>=20
>> If you have a service definition to reproduce this, I=E2=80=99d be happy=
to
>> take a look!
> The second is probably just me forgetting to set #:respawn? #t. One
> "bug" down, one more to go.
:-)
Ludo=E2=80=99.
guix-patches@HIDDEN:bug#54986; Package guix-patches.
Full text available.Received: (at 54986) by debbugs.gnu.org; 23 Apr 2022 18:36:28 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 23 14:36:28 2022 Received: from localhost ([127.0.0.1]:57224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1niKcO-0000uO-0B for submit <at> debbugs.gnu.org; Sat, 23 Apr 2022 14:36:28 -0400 Received: from mail-ej1-f65.google.com ([209.85.218.65]:44641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <liliana.prikler@HIDDEN>) id 1niKcN-0000uB-0B for 54986 <at> debbugs.gnu.org; Sat, 23 Apr 2022 14:36:27 -0400 Received: by mail-ej1-f65.google.com with SMTP id u15so22131055ejf.11 for <54986 <at> debbugs.gnu.org>; Sat, 23 Apr 2022 11:36:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=CTY+rF9BpTylosfPKSFrc7ZkUUchZ4earzJ72TpEp6A=; b=MeEktht4NtVmnzy3rMNuBAniNv2uvI1yMwaNHp0RuLs+j4UPl99mTL87XhIsQQa5n3 WJdim35xwLtC2P3JfR51KRbGjlI/4VIDZA///gEnS4LrQAKltqno4bv2BssDESyh/TmG Mg3u+ZkDh4evXYB65Kg+6lVFTsstyYQ/MIl4jsVLH832vo26ec2XjdBcqOQPJi4Y2y5c wY9u3lVizgwAjoKP7UdtJQrJ0f9FHEfy8e6jHsIOVejgFz8Lp7tcq47kAF2QiZS7cny7 D/8Kf0lSZJRyk5xHNfilE9ibXO6AvGw+iSM5becUVSE2okJXPkhtDvOHITj4thT9655F oFsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=CTY+rF9BpTylosfPKSFrc7ZkUUchZ4earzJ72TpEp6A=; b=D8ETvB2KcYv2zCeb01KAFxd7YC4g/crFQ1ccKyVcXIS5yUfipyTja2uI16NkEHScTC CEcr2AL3iZSKj20olixXyjm1gaqXoWSWnhLSvAkXN7timaV6MHhziC1mwBPKUGQXn2Fd 8F4Fqyvimd5ckhuL4s41fmsbNyJA8magP1iuiV1kXn6h/Cfv59hOWudPTcuDyYJ8NmXu jJTq5SJKVVooOkMBFc+LLaOE3lqgG2iLdpps3puQLgYCwD5sR0mUGJzYONGH/kP1n1O3 w7j0m/Kx1wepAEtSC0eQjG6e9MVvPJTBqVkLPqLxioVeNqY+QIIDASRbqgKVDnPFH7bg 7ffw== X-Gm-Message-State: AOAM532Al9jDha4xYbDdnf5lLTsKOaKG5m9U4rKGQz3aev3vRJ2fcrd3 PpIkOJ25l9s7/XmuUZbXO3o= X-Google-Smtp-Source: ABdhPJzCVEMPekVyPgIYlqxNs4Y7x3r2/eCDKGXqom3fWsvkOfwAUNQCL5+9Y7GHg4ON5lXuUxbJMQ== X-Received: by 2002:a17:907:7206:b0:6f3:8361:338e with SMTP id dr6-20020a170907720600b006f38361338emr1324878ejc.485.1650738981120; Sat, 23 Apr 2022 11:36:21 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id z12-20020a50f14c000000b00425d61cbb0esm85696edl.22.2022.04.23.11.36.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Apr 2022 11:36:20 -0700 (PDT) Message-ID: <9d93799fedd4f40748669af04473198092c77173.camel@HIDDEN> Subject: Re: [bug#54986] [PATCH v2 3/3 WIP] services: mpd: Support socket activation. From: Liliana Marie Prikler <liliana.prikler@HIDDEN> To: Maxime Devos <maximedevos@HIDDEN>, 54986 <at> debbugs.gnu.org Date: Sat, 23 Apr 2022 20:36:19 +0200 In-Reply-To: <ec82acd564e34a73dd5d359788f292672079505a.camel@HIDDEN> References: <9d4cc9d3ebb05d2aabf8f06e1890efe9b0b9a849.camel@HIDDEN> <155723efbcf08c6e0bb6552b8f6341d4a1f20ecb.camel@HIDDEN> <ec82acd564e34a73dd5d359788f292672079505a.camel@HIDDEN> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54986 Cc: ludo@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Am Samstag, dem 23.04.2022 um 19:31 +0200 schrieb Maxime Devos: > > +(define (shepherd-endpoint->sexp endpoint) > > + (match endpoint > > + (($ <shepherd-endpoint> address > > + name style backlog socket-owner > > socket- > group > > + socket-directory-permissions) > > + `(endpoint > > + ,(match (sockaddr:fam address) > > + ((? (cute = <> AF_INET) _) > > + `(make-socket-addr AF_INET > > + ,(sockaddr:addr address) > > + ,(sockaddr:port address))) > > Liliana Marie Prikler schreef op za 23-04-2022 om 16:39 [+0200]: > > + (list #$@(map shepherd-endpoint->sexp > > + (mpd-configuration-shepherd- > > endpoints config))) > > For hygiene reasons, should 'shepherd-endpoint->sexp' use @? > > `((@ (the module) endpoint) > ,(match [...] > ((@ [...] make-socket-addr (@ [...] AF_UNIX) ...) > ...)) > > That way, no assumptions are made on what modules are imported and it > avoids hygiene problems like in > > ;; There are two ‘endpoints’ here: the ‘API endpoint’, > ;; and Shepherd endpoints. > #~(let ((endpoint "http://localhost:1234/api")) > (make-systemd-constructor > (list #$(file-append soft "/bin/ware") > "--endpoint" #$endpoint) > (list (shepherd-endpoint->sexp ...)))) Good point, that's should probably done for defensive programming. Note also that I'm missing half of the documentation still, so it won't be pushed too soon, though.
guix-patches@HIDDEN:bug#54986; Package guix-patches.
Full text available.
Received: (at 54986) by debbugs.gnu.org; 23 Apr 2022 18:28:41 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 23 14:28:40 2022
Received: from localhost ([127.0.0.1]:57209 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1niKUq-0000gy-MA
for submit <at> debbugs.gnu.org; Sat, 23 Apr 2022 14:28:40 -0400
Received: from mail-ej1-f67.google.com ([209.85.218.67]:43962)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <liliana.prikler@HIDDEN>) id 1niKUn-0000gk-RE
for 54986 <at> debbugs.gnu.org; Sat, 23 Apr 2022 14:28:39 -0400
Received: by mail-ej1-f67.google.com with SMTP id m20so1444680ejj.10
for <54986 <at> debbugs.gnu.org>; Sat, 23 Apr 2022 11:28:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=message-id:subject:from:to:cc:date:in-reply-to:references
:user-agent:mime-version:content-transfer-encoding;
bh=k/KIimFRxpvkJ4InD2HRRLdSFFzMv78Z4BCc68ZdAtI=;
b=hatAJwXfuxP2elBhSMaS4OVZ8NPcw9F9PMWdrhGD4ZD3BWqMjzehsZ6Q+1xMEBllNg
hzhaQcvNPH5fe0igvqYhEslZVEovQQWUSvLjHqagrsONDqsrdrQxyCWkaIrpNGf9+F9C
gGUskhdpHKW99vcS36QxsE0+Xuqgb7bZGbIO3W3DZf2ugGJmW87wS6B746wt+ea+iS1M
hAe+zR/yLQb+ZpnWce+sPS8ltMwQs+hbIdkG1oYzipX7aam/BHDO0k2RRsC0DMfJqmC8
WUA7AouFSq1027Ic7pI5BKFGqrhMU7OjBehgpGcfO1V7ZZlddddT18xpV9rqM+xkH8Eb
4peg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
:references:user-agent:mime-version:content-transfer-encoding;
bh=k/KIimFRxpvkJ4InD2HRRLdSFFzMv78Z4BCc68ZdAtI=;
b=k8dv3S2dzSUt4yucSxSGJCnVTij/ge4u2ELVpkL7YdnzhtxYYo9OWr3hevSiloqJD8
AZKXGg6sTttLtS2PZDyMsXfsSvoZIqFmh9C0BTxJDzKDktk/NSKlIdBDhc7CpMTKKthw
Ztqu6pmxjlq3MaNzhz7oBamzsMrKvLZge0gEIJdg0tmk6ap1TWAwgMqWaWzs21Fbe2cn
QLmSc8Kfh2/wonEKIoRb1A+vOgfK5xg3XJqsdNrOJ+Fwue1D5M+hTQ+ifknp4NV6+bYK
d2ZdguDDr3buyc/Q8hBIE7c+7TcUu1kfn+q2TYdHx/DxXT7MQN//lonL0BGqHaIh/DDu
lPXA==
X-Gm-Message-State: AOAM533208yL+TIG51b7wMUx61qEH2IGHXaYNhRh9WIqIhncv6PiohBf
lbMAwDW4p7aDV75Oq2CV/lU=
X-Google-Smtp-Source: ABdhPJx6dwyUJsp1JeRWirLoPfVp8ptqVy2W/pTrELTM+kNHJlqu/hXdhFSQn7eauD+bv5MHgcr8ag==
X-Received: by 2002:a17:907:6d8e:b0:6f0:298f:da11 with SMTP id
sb14-20020a1709076d8e00b006f0298fda11mr9176785ejc.562.1650738512005;
Sat, 23 Apr 2022 11:28:32 -0700 (PDT)
Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
[85.127.52.93]) by smtp.gmail.com with ESMTPSA id
gz15-20020a170906f2cf00b006f3802a963fsm391826ejb.21.2022.04.23.11.28.31
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 23 Apr 2022 11:28:31 -0700 (PDT)
Message-ID: <ba08b708ecb96e4e52d698d82616cee13e900e35.camel@HIDDEN>
Subject: Re: [bug#54986] [PATCH v2 3/3 WIP] services: mpd: Support socket
activation.
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
To: Maxime Devos <maximedevos@HIDDEN>, 54986 <at> debbugs.gnu.org
Date: Sat, 23 Apr 2022 20:28:30 +0200
In-Reply-To: <118400e2373bae7c4147e51ed2eb26eec27e3a05.camel@HIDDEN>
References: <9d4cc9d3ebb05d2aabf8f06e1890efe9b0b9a849.camel@HIDDEN>
<155723efbcf08c6e0bb6552b8f6341d4a1f20ecb.camel@HIDDEN>
<118400e2373bae7c4147e51ed2eb26eec27e3a05.camel@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 54986
Cc: ludo@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Am Samstag, dem 23.04.2022 um 19:35 +0200 schrieb Maxime Devos:
> Liliana Marie Prikler schreef op za 23-04-2022 om 16:39 [+0200]:
> > +@item @code{shepherd-endpoints} (default: @code{'()})
> > +The endpoints shepherd shall bind and spawn MPD from. If this
> > field is
> > +not empty (checked via @code{null?}), a systemd-style service is
> > used
> > +rather than a forkexec-service.
>
> systemd-style / forkexec-service looks like an implementation detail
> to me, not something useful to the user.
>
> > This delays the start of MPD until the
> > +first client connects.
>
> Likewise.
Even if this was just an implementation detail, I shall point to
Hyrum's law.
> > As a side effect @code{port} and @code{address}
> > +may be ignored.
>
> Could these three fields be unified, keeping 'port' and 'address'
> only for some backwards compatibility? E.g.:
>
> (mpd-configuration
> (endpoints (list (shepherd-endpoint [a AF_INET6 address])
> (shepherd-endpoint [a AF_UNIX address]))))
Not AFAIK. MPD is less strict than Guile when it comes to addresses,
so converting from address+port to socket addresses is nontrivial.
That being said, I'm not sure if they are even ignored. MPD only warns
about pid_file, so they might also be used.
Cheers
guix-patches@HIDDEN:bug#54986; Package guix-patches.
Full text available.
Received: (at 54986) by debbugs.gnu.org; 23 Apr 2022 17:35:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 23 13:35:50 2022
Received: from localhost ([127.0.0.1]:57168 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1niJfh-0007o0-PO
for submit <at> debbugs.gnu.org; Sat, 23 Apr 2022 13:35:50 -0400
Received: from xavier.telenet-ops.be ([195.130.132.52]:36454)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maximedevos@HIDDEN>) id 1niJfg-0007ns-HY
for 54986 <at> debbugs.gnu.org; Sat, 23 Apr 2022 13:35:48 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
by xavier.telenet-ops.be with bizsmtp
id NHbm2700a4UW6Th01HbnF1; Sat, 23 Apr 2022 19:35:47 +0200
Message-ID: <118400e2373bae7c4147e51ed2eb26eec27e3a05.camel@HIDDEN>
Subject: Re: [bug#54986] [PATCH v2 3/3 WIP] services: mpd: Support socket
activation.
From: Maxime Devos <maximedevos@HIDDEN>
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>, 54986 <at> debbugs.gnu.org
Date: Sat, 23 Apr 2022 19:35:46 +0200
In-Reply-To: <155723efbcf08c6e0bb6552b8f6341d4a1f20ecb.camel@HIDDEN>
References: <9d4cc9d3ebb05d2aabf8f06e1890efe9b0b9a849.camel@HIDDEN>
<155723efbcf08c6e0bb6552b8f6341d4a1f20ecb.camel@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
protocol="application/pgp-signature"; boundary="=-gxuZ0rAmhhfKDkOLUHkW"
User-Agent: Evolution 3.38.3-1
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
t=1650735347; bh=CIBqbMlEBY4mYi5yQAZBuYVMNc6YxKWNDoipzUEOqVM=;
h=Subject:From:To:Cc:Date:In-Reply-To:References;
b=ZfCNZ9PSKVOcoy2oze0U6tHKNtmTbSdC0U2O1+1zbxgSDF1mR3yH+hFNTMi3wxAch
wnJSYvLZwceQVrL0d4SEPCCgXcfNU9EtML4BlEBJhNeZwr3jkxqQoSY86laRNrCvKN
gkZWSeNKA9OCQonHdNiy1bWmEtg4KsrQ+nh4I2ecLTeJckq07EKvAX7uKs53wdxxpZ
zl/WDIawtQaXREEh5V6tMMKf4eTKF1e5ciYJb/c/4FajdiayUMy67XKt2/oYsgmNmP
PcLhP5ofmRqsTyjivQZooaHYCL0aIlBC5a06hZsKlTmlSGs9sIObl0JrOCp/VV3nCf
mhaiFJ2supoww==
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 54986
Cc: ludo@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-gxuZ0rAmhhfKDkOLUHkW
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Liliana Marie Prikler schreef op za 23-04-2022 om 16:39 [+0200]:
> +@item @code{shepherd-endpoints} (default: @code{'()})
> +The endpoints shepherd shall bind and spawn MPD from.=C2=A0 If this fiel=
d is
> +not empty (checked via @code{null?}), a systemd-style service is used
> +rather than a forkexec-service.
systemd-style / forkexec-service looks like an implementation detail to
me, not something useful to the user.
> =C2=A0This delays the start of MPD until the
> +first client connects.
>=20
Likewise.
> =C2=A0 As a side effect @code{port} and @code{address}
> +may be ignored.
Could these three fields be unified, keeping 'port' and 'address' only
for some backwards compatibility? E.g.:
(mpd-configuration
(endpoints (list (shepherd-endpoint [a AF_INET6 address])
(shepherd-endpoint [a AF_UNIX address]))))
Greetings,
Maxime.
--=-gxuZ0rAmhhfKDkOLUHkW
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYmQ48hccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7lyVAQC1CAeKjbGP1evIu5nuk+hU4Cj4
dofW6SrBqZ+othRhmAD/W/AzXs6WzBFnMb7nilaQPTC6cW1lnH2Jvvr+ILQgTAA=
=RhFJ
-----END PGP SIGNATURE-----
--=-gxuZ0rAmhhfKDkOLUHkW--
guix-patches@HIDDEN:bug#54986; Package guix-patches.
Full text available.
Received: (at 54986) by debbugs.gnu.org; 23 Apr 2022 17:31:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 23 13:31:42 2022
Received: from localhost ([127.0.0.1]:57163 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1niJbi-0007gw-7w
for submit <at> debbugs.gnu.org; Sat, 23 Apr 2022 13:31:42 -0400
Received: from andre.telenet-ops.be ([195.130.132.53]:50836)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maximedevos@HIDDEN>) id 1niJbh-0007gn-16
for 54986 <at> debbugs.gnu.org; Sat, 23 Apr 2022 13:31:41 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
by andre.telenet-ops.be with bizsmtp
id NHXe2700L4UW6Th01HXfrv; Sat, 23 Apr 2022 19:31:39 +0200
Message-ID: <ec82acd564e34a73dd5d359788f292672079505a.camel@HIDDEN>
Subject: Re: [bug#54986] [PATCH v2 3/3 WIP] services: mpd: Support socket
activation.
From: Maxime Devos <maximedevos@HIDDEN>
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>, 54986 <at> debbugs.gnu.org
Date: Sat, 23 Apr 2022 19:31:34 +0200
In-Reply-To: <155723efbcf08c6e0bb6552b8f6341d4a1f20ecb.camel@HIDDEN>
References: <9d4cc9d3ebb05d2aabf8f06e1890efe9b0b9a849.camel@HIDDEN>
<155723efbcf08c6e0bb6552b8f6341d4a1f20ecb.camel@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
protocol="application/pgp-signature"; boundary="=-/XIYNXpxlgE+4QcTZ1oY"
User-Agent: Evolution 3.38.3-1
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
t=1650735099; bh=GcR3jTqnq1mBEfLRpYRUN/OHhLMrprjNnwx4tNyQfts=;
h=Subject:From:To:Cc:Date:In-Reply-To:References;
b=JN3prPIIJKzSXsOTItROVjh0nfrCgjhQhoObCdyjhPqhDtTX3zCwy2yHa/Yq1+64g
jrQt6stuGRyiFTViGrhWSioItY7+uhiVhsN492Ma9sKWLl6+0Aw1/glkBFsEpcS7zX
x/lmr99V2YeDnN/KeEIV+LH06Ya3QQT2UtQWkXWH+2GcTPULlSX/SFOfLwm5hqtR6Y
tYQ8QA7zuwepUMGHipnEkDku/IokMWWHu2dPNx1lPLDrMtBhbvEoxM52bKzFDK8cqk
K//oGqEHVUKm2arQiwNzFnNmYlnKGxQkG0yEuP0xVlsCJ4I69RdvCkXipuOnO5OeCH
bvX5i0105m6HA==
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 54986
Cc: ludo@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-/XIYNXpxlgE+4QcTZ1oY
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
> +(define (shepherd-endpoint->sexp endpoint)
> + (match endpoint
> + (($ <shepherd-endpoint> address
> + name style backlog socket-owner socket-
group
> + socket-directory-permissions)
> + `(endpoint
> + ,(match (sockaddr:fam address)
> + ((? (cute =3D <> AF_INET) _)
> + `(make-socket-addr AF_INET
> + ,(sockaddr:addr address)
> + ,(sockaddr:port address)))
Liliana Marie Prikler schreef op za 23-04-2022 om 16:39 [+0200]:
> + (list #$@(map shepherd-endpoint->sexp
> + (mpd-configuration-shepherd-endpoints con=
fig)))=C2=A0
For hygiene reasons, should 'shepherd-endpoint->sexp' use @?
`((@ (the module) endpoint)
,(match [...]
((@ [...] make-socket-addr (@ [...] AF_UNIX) ...)
...))
That way, no assumptions are made on what modules are imported and it
avoids hygiene problems like in
;; There are two =E2=80=98endpoints=E2=80=99 here: the =E2=80=98API endpo=
int=E2=80=99,
;; and Shepherd endpoints.
#~(let ((endpoint "http://localhost:1234/api"))
(make-systemd-constructor
(list #$(file-append soft "/bin/ware")
"--endpoint" #$endpoint)
(list (shepherd-endpoint->sexp ...))))
Greetings,
Maxime.
--=-/XIYNXpxlgE+4QcTZ1oY
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYmQ39hccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7sQ1AQDwdd0W78+WuBLbBsCj42QqTl67
0wKGnWz8fetQ4c3KtQD/TeTUBQBNWZ9lDKgKs2tFiDV45g8d1/OFPn4LLaDxGAo=
=E7SQ
-----END PGP SIGNATURE-----
--=-/XIYNXpxlgE+4QcTZ1oY--
guix-patches@HIDDEN:bug#54986; Package guix-patches.
Full text available.
Received: (at 54986) by debbugs.gnu.org; 23 Apr 2022 17:06:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 23 13:06:49 2022
Received: from localhost ([127.0.0.1]:57145 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1niJDd-00073u-Dq
for submit <at> debbugs.gnu.org; Sat, 23 Apr 2022 13:06:49 -0400
Received: from mail-ej1-f68.google.com ([209.85.218.68]:35398)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <liliana.prikler@HIDDEN>) id 1niJDZ-00073A-Mt
for 54986 <at> debbugs.gnu.org; Sat, 23 Apr 2022 13:06:46 -0400
Received: by mail-ej1-f68.google.com with SMTP id l7so21987973ejn.2
for <54986 <at> debbugs.gnu.org>; Sat, 23 Apr 2022 10:06:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=from:date:subject:to:cc:content-transfer-encoding:message-id
:mime-version; bh=GhG4FwS5ELWHR4F8p1PH7qpP3YNN3wC1YRNv76XE5aU=;
b=MLdyAEhMSHHslR5QukLaOp3EA3vMnfOW9/Q+17V3knSwgS5HgZnnoHDwkFUY1FSR0P
5EYuiVF2NoqEj/WuQ3jyguVyzFeF6BB40X3DIvdroady3RflOcTy9AJP40un0SQgCcnx
IPBDFZWEMisrpEksCqncq9TKt6NF6jE/HGDrq4aZf/4OntRjPyZQzTypB4Ew5aVAi61T
Izy0TnutrXdTzN4pnpOBFsRzdW7fVKji8/Tz63duvmkCPqAqR+7RjW8W4mH4qDCbCx4V
B+98zmzehp7qCL8aJXw+zOMeraD01h9mTrf1Yyiy9Vpw0rMvlaMwugq9sdZpYIDEedwg
STEA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:from:date:subject:to:cc
:content-transfer-encoding:message-id:mime-version;
bh=GhG4FwS5ELWHR4F8p1PH7qpP3YNN3wC1YRNv76XE5aU=;
b=D8ZkpPGUqUn6vySxJo3lsIoyk0qn9avUTfi46ZKvRpp7qys9QM5O2xCGG4YMnHjxZz
Z9PzFO1EbVyi9jZf85twZxTE0SpVff7Kp/osswJcrDewJw/Jf1kyZ22/DuOvJrsdrNGO
dJGQ06swgM9Lizdc5SgxyfQTQXpKo17mKL83E5GVSJdywCjXd4epVeqpOj7rL1C/Y4yT
xJdMp0CppmgwEhk3UaGtvMaOnsOa5tFLkUo3Oim5NK+26UsLYZnJPerQ3q6F0FUfDDsT
f4YvRUTk9Tzal7DZh1f00ZlnpjIlbUkT2w9LhI6xAIaK0cvMKjoBa/Q/kt+/hL54gTv0
c2KQ==
X-Gm-Message-State: AOAM531X5d1vbH1EZjXu15ZPbi7NP4piNRGVhooI/LorTWDYvfGqeRnf
bAkFot2F4TAQRjqTIpL9gQQPleUIL6A=
X-Google-Smtp-Source: ABdhPJzi9eNyO/fId5sKJ/vujBN2zh7qJZSoiIylRvOvBdyVhNLk1ED9hNHrIbo/y2UnWzL6cNVpbw==
X-Received: by 2002:a17:907:9805:b0:6db:4c33:7883 with SMTP id
ji5-20020a170907980500b006db4c337883mr9273235ejc.555.1650733600150;
Sat, 23 Apr 2022 10:06:40 -0700 (PDT)
Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
[85.127.52.93]) by smtp.gmail.com with ESMTPSA id
b7-20020a170906708700b006da8440d642sm1855481ejk.113.2022.04.23.10.06.39
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 23 Apr 2022 10:06:39 -0700 (PDT)
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Date: Sat, 23 Apr 2022 16:39:59 +0200
Subject: [PATCH v2 3/3 WIP] services: mpd: Support socket activation.
to: 54986 <at> debbugs.gnu.org
Content-Transfer-Encoding: 7bit
Message-ID: <155723efbcf08c6e0bb6552b8f6341d4a1f20ecb.camel@HIDDEN>
MIME-Version: 1.0
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 54986
Cc: ludo@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
* gnu/services/audio.scm (<mpd-configuration>)[shepherd-endpoints]: New field.
(mpd-shepherd-service): Use it.
* doc/guix.texi (Music Player Daemon): Document it.
---
doc/guix.texi | 7 +++++++
gnu/services/audio.scm | 45 ++++++++++++++++++++++++++++++------------
2 files changed, 39 insertions(+), 13 deletions(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index 38aeda1d2d..6bfa854b1d 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -30883,6 +30883,13 @@ The port to run mpd on.
The address that mpd will bind to. To use a Unix domain socket,
an absolute path can be specified here.
+@item @code{shepherd-endpoints} (default: @code{'()})
+The endpoints shepherd shall bind and spawn MPD from. If this field is
+not empty (checked via @code{null?}), a systemd-style service is used
+rather than a forkexec-service. This delays the start of MPD until the
+first client connects. As a side effect @code{port} and @code{address}
+may be ignored.
+
@item @code{outputs} (default: @code{"(list (mpd-output))"})
The audio outputs that MPD can use. By default this is a single output using pulseaudio.
diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm
index c60053f33c..b184ac596a 100644
--- a/gnu/services/audio.scm
+++ b/gnu/services/audio.scm
@@ -78,6 +78,8 @@ (define-record-type* <mpd-configuration>
(default "6600"))
(address mpd-configuration-address
(default "any"))
+ (shepherd-endpoints mpd-configuration-shepherd-endpoints
+ (default '())) ; list of <shepherd-endpoint>
(outputs mpd-configuration-outputs
(default (list (mpd-output)))))
@@ -140,19 +142,36 @@ (define (mpd-shepherd-service config)
(documentation "Run the MPD (Music Player Daemon)")
(requirement '(user-processes))
(provision '(mpd))
- (start #~(make-forkexec-constructor
- (list #$(file-append mpd "/bin/mpd")
- "--no-daemon"
- #$(mpd-config->file config))
- #:environment-variables
- ;; Required to detect PulseAudio when run under a user account.
- (list (string-append
- "XDG_RUNTIME_DIR=/run/user/"
- (number->string
- (passwd:uid
- (getpwnam #$(mpd-configuration-user config))))))
- #:log-file #$(mpd-file-name config "log")))
- (stop #~(make-kill-destructor))))
+ (start (if (null? (mpd-configuration-shepherd-endpoints config))
+ #~(make-forkexec-constructor
+ (list #$(file-append mpd "/bin/mpd")
+ "--no-daemon"
+ #$(mpd-config->file config))
+ #:environment-variables
+ ;; Required to detect PulseAudio when run under a user account.
+ (list (string-append
+ "XDG_RUNTIME_DIR=/run/user/"
+ (number->string
+ (passwd:uid
+ (getpwnam #$(mpd-configuration-user config))))))
+ #:log-file #$(mpd-file-name config "log"))
+ #~(make-systemd-constructor
+ (list #$(file-append mpd "/bin/mpd")
+ "--systemd"
+ #$(mpd-config->file config))
+ (list #$@(map shepherd-endpoint->sexp
+ (mpd-configuration-shepherd-endpoints config)))
+ #:environment-variables
+ ;; Required to detect PulseAudio when run under a user account.
+ (list (string-append
+ "XDG_RUNTIME_DIR=/run/user/"
+ (number->string
+ (passwd:uid
+ (getpwnam #$(mpd-configuration-user config))))))
+ #:log-file #$(mpd-file-name config "log"))))
+ (stop (if (null? (mpd-configuration-shepherd-endpoints config))
+ #~(make-kill-destructor)
+ #~(make-systemd-destructor)))))
(define (mpd-service-activation config)
(with-imported-modules '((guix build utils))
--
2.35.1
guix-patches@HIDDEN:bug#54986; Package guix-patches.
Full text available.
Received: (at 54986) by debbugs.gnu.org; 23 Apr 2022 17:06:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 23 13:06:49 2022
Received: from localhost ([127.0.0.1]:57143 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1niJDd-00073n-04
for submit <at> debbugs.gnu.org; Sat, 23 Apr 2022 13:06:49 -0400
Received: from mail-ej1-f67.google.com ([209.85.218.67]:42576)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <liliana.prikler@HIDDEN>) id 1niJDZ-000737-4t
for 54986 <at> debbugs.gnu.org; Sat, 23 Apr 2022 13:06:45 -0400
Received: by mail-ej1-f67.google.com with SMTP id i27so21913264ejd.9
for <54986 <at> debbugs.gnu.org>; Sat, 23 Apr 2022 10:06:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=from:date:subject:to:cc:content-transfer-encoding:message-id
:mime-version; bh=seEX2LEgzCZY4UiCqrYu/PjKLIwGvoXWcSeGOBa8kjQ=;
b=LQapge+1rJWCtnqHF8/oLxQv75/bMT6hl5l/iEvbj8VRTlajj1qHr/Tu5oYT64/BgP
JK1UqYW1mBgRBbm/rLN+IjO2sCVD6bfIV4l/JEuQUZeEU8b54OHW64bxik5T8EeBtWom
HzXTi64C8ScZpxRmKyASKHzBRtZ2N+GdBVZHiid73ktqTnazYaYqPY2J4CKjSNqskm17
4misr7sl70Y+QhnV3u3Mq/xsD/2FamSQQ8mOVhNzFEnOD2X6gZxB4ZRr+HWlbHyNIfRk
r+cPj7HpIeEFtGT28PoCFjGYZDwTbQ1Ieeyn2g/4iKPIFQOu2Tg5u2Tcub2glfkOoodA
hf4w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:from:date:subject:to:cc
:content-transfer-encoding:message-id:mime-version;
bh=seEX2LEgzCZY4UiCqrYu/PjKLIwGvoXWcSeGOBa8kjQ=;
b=d9cxxzLYt20H1OBj5x6QzimeEMuzujp86MeSdOtMZuXzXNf7iToazlYIL7qll21ca8
GGyXOy3Mh67cLF0JpjtH37H/v51wl7lSOtVIQ6/aX6NiH6nZnex9fr4Qpi1X/N5JoWtB
ChwIeKHxRVpy3fjWqMjPIO16V1OJpM7u8vfcwlPLBhib6bH+q9eM/tWtiZ3J2EUhWmyT
IwrkYJKXM/SSqj8D0x5/MS6DiehApewlY7ksVTRVm8uLq/bnYkGXWXLAwbH8LeNEIjF/
QRK/CTQM0XNKEdT+1XRovExQGY9sgUn1/buPu26W2zmAqCyJB/66QN1dtmRKKdz//k7T
uvRg==
X-Gm-Message-State: AOAM532D7RO12i4IlMtUP3uKPxN8KD50OemqhxnzHtE6Zg38Y+da6Y93
iGzjO3zdBIUVjiTJeMxuWhGYhAFZbTk=
X-Google-Smtp-Source: ABdhPJw4ku37MuenuJK1wlUwmGCI3oTCm+TZWQ3bCvaFtQCy0eNAKINVK3ThZQknTsMAR09XE9r7wg==
X-Received: by 2002:a17:907:62a6:b0:6ef:8118:d3e2 with SMTP id
nd38-20020a17090762a600b006ef8118d3e2mr8850358ejc.605.1650733599436;
Sat, 23 Apr 2022 10:06:39 -0700 (PDT)
Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
[85.127.52.93]) by smtp.gmail.com with ESMTPSA id
b7-20020a170906708700b006da8440d642sm1855481ejk.113.2022.04.23.10.06.38
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 23 Apr 2022 10:06:39 -0700 (PDT)
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Date: Sat, 23 Apr 2022 16:25:55 +0200
Subject: [PATCH v2 2/3 WIP] services: shepherd: Add support for socket
activation endpoints.
to: 54986 <at> debbugs.gnu.org
Content-Transfer-Encoding: 8bit
Message-ID: <454555484d434cefead47968e938ea071fe6121a.camel@HIDDEN>
MIME-Version: 1.0
X-Spam-Score: 0.9 (/)
X-Debbugs-Envelope-To: 54986
Cc: ludo@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)
* gnu/services/shepherd.scm (<shepherd-endpoint>): New record type.
(shepherd-endpoint->sexp): New variable.
* doc/guix.texi (Shepherd Services): Document it.
---
doc/guix.texi | 29 +++++++++++++++++++
gnu/services/shepherd.scm | 60 +++++++++++++++++++++++++++++++++++++++
2 files changed, 89 insertions(+)
diff --git a/doc/guix.texi b/doc/guix.texi
index 5399584cb0..38aeda1d2d 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -37675,6 +37675,35 @@ This, as you can see, is a fairly sophisticated way to say hello.
info on actions.
@end deftp
+@deftp {Data Type} shepherd-endpoint
+This is an endpoint that a systemd-style shepherd service listens on.
+
+@table @code
+@item address
+This is the socket address that shepherd binds and forwards to the service.
+
+@item name
+‾\_(ツ)_/‾
+
+@item style
+‾\_(ツ)_/‾
+
+@item backlog
+‾\_(ツ)_/‾
+
+@item socket-owner
+This is the user ID owning the socket.
+
+@item socket-group
+This is the group ID owning the socket.
+
+@item socket-directory-permissions
+These are the UNIX permissions to set for the directory the socket
+resides in.
+
+@end table
+@end deftp
+
@defvr {Scheme Variable} shepherd-root-service-type
The service type for the Shepherd ``root service''---i.e., PID@tie{}1.
diff --git a/gnu/services/shepherd.scm b/gnu/services/shepherd.scm
index 4fd4b2a497..3ef0023d7f 100644
--- a/gnu/services/shepherd.scm
+++ b/gnu/services/shepherd.scm
@@ -66,6 +66,16 @@ (define-module (gnu services shepherd)
shepherd-action-documentation
shepherd-action-procedure
+ shepherd-endpoint
+ shepherd-endpoint-address
+ shepherd-endpoint-name
+ shepherd-endpoint-style
+ shepherd-endpoint-backlog
+ shepherd-endpoint-socket-owner
+ shepherd-endpoint-socket-group
+ shepherd-endpoint-socket-directory-permissions
+ shepherd-endpoint->sexp
+
%default-modules
shepherd-service-file
@@ -183,6 +193,56 @@ (define %default-modules
((guix build utils) #:hide (delete))
(guix build syscalls)))
+(define-record-type* <shepherd-endpoint>
+ shepherd-endpoint make-shepherd-endpoint
+ shepherd-endpoint?
+ (address shepherd-endpoint-address) ; sockaddr
+ (name shepherd-endpoint-name ; string | #f
+ (default #f))
+ (style shepherd-endpoint-style ; int | #f
+ (default #f))
+ (backlog shepherd-endpoint-backlog ; int | #f
+ (default #f))
+ (socket-owner shepherd-endpoint-socket-owner ; uid | #f
+ (default #f))
+ (socket-group shepherd-endpoint-socket-group ; gid | #f
+ (default #f))
+ (socket-directory-permissions
+ shepherd-endpoint-socket-directory-permissions ; chmod pattern (int) | #f
+ (default #f)))
+
+(define (shepherd-endpoint->sexp endpoint)
+ (match endpoint
+ (($ <shepherd-endpoint> address
+ name style backlog socket-owner socket-group
+ socket-directory-permissions)
+ `(endpoint
+ ,(match (sockaddr:fam address)
+ ((? (cute = <> AF_INET) _)
+ `(make-socket-addr AF_INET
+ ,(sockaddr:addr address)
+ ,(sockaddr:port address)))
+ ((? (cute = <> AF_INET6) _)
+ `(make-socket-addr AF_INET6
+ ,(sockaddr:addr address)
+ ,(sockaddr:port address)
+ ,(sockaddr:flowinfo address)
+ ,(sockaddr:scopeid address)))
+ ((? (cute = <> AF_UNIX) _)
+ `(make-socket-addr AF_UNIX
+ ,(sockaddr:path address))))
+ ,@(fold
+ (match-lambda*
+ (((key value) seed)
+ (if value (cons* key value seed) seed)))
+ '()
+ `((#:name ,name)
+ (#:style ,style)
+ (#:backlog ,backlog)
+ (#:socket-owner ,socket-owner)
+ (#:socket-group ,socket-group)
+ (#:socket-directory-permissions ,socket-directory-permissions)))))))
+
(define-record-type* <shepherd-service>
shepherd-service make-shepherd-service
shepherd-service?
--
2.35.1
guix-patches@HIDDEN:bug#54986; Package guix-patches.
Full text available.
Received: (at 54986) by debbugs.gnu.org; 23 Apr 2022 17:06:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 23 13:06:49 2022
Received: from localhost ([127.0.0.1]:57141 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1niJDc-00073k-MX
for submit <at> debbugs.gnu.org; Sat, 23 Apr 2022 13:06:48 -0400
Received: from mail-ej1-f65.google.com ([209.85.218.65]:37653)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <liliana.prikler@HIDDEN>) id 1niJDY-000736-PE
for 54986 <at> debbugs.gnu.org; Sat, 23 Apr 2022 13:06:45 -0400
Received: by mail-ej1-f65.google.com with SMTP id g13so21973363ejb.4
for <54986 <at> debbugs.gnu.org>; Sat, 23 Apr 2022 10:06:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=from:date:subject:mime-version:to:cc:content-transfer-encoding
:message-id; bh=mGiY5r+/zrnr75rG4wVqhLDFOdMCk5a8HGj+r9Jazyc=;
b=PpW7oxapXdx+qTgYTWWnxr+z5/SjYr2K2oo2Lu8EP3w5i97Hp4TWwDlOOAm1Dvztq6
D2trJP0KCzgBdUoBKkhPKj1F0v2yVpTOrO00rPI9SKb0UZxe7bVZ1t5AK6vCKGZdNlgW
r4D7ppAjf8YKlp46E7yLTDKMcE1StC5qnMc+h2A+1ujD3uPEKHJSCgdqu3CDDQS+iwzx
v/6kBo9cMUFg05EyYhSHfYZ4SFVySXvvf5qiTEG/+g4Q6htV1vZVUIVudhuE/vuJ+W6J
OX/3db1n5QA+NSy2eCbli8QokiifSA6qrG75imClwwVjrkPeby1skFrpfmDqoSAhXp05
S5Lw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:from:date:subject:mime-version:to:cc
:content-transfer-encoding:message-id;
bh=mGiY5r+/zrnr75rG4wVqhLDFOdMCk5a8HGj+r9Jazyc=;
b=jPv2zL3H9wWcT/3fjLJxdLcodofF6p6QdN3ZtFGEvi6cS4qZHKZYIqKkPzxaLTuFEe
/DbutIHcjBVtz5QBvsiQCPa7XPNbfxXmr9TLgWeMGdFwckKM+KqebbbaKk1oTpdKxeuk
5M678lfZ6bXID856nCNdzt5A4KA0LoV0E58eKZvDXJdUd3gBm/Z7Uql8KUTEwwl8OXY1
1sV2Oim+Wvp5f/7OOTkRnAe1ATyp9odTN7+hrzllIBMSwLhnt2LL1Th+UQ0QAKSNlvR0
lC8hihemnEkH+rVhOfhVUj0L+lMmWByl+2F4KsrrL1zambcUqx+YV/RZMHw5q9LSoOkz
6QvA==
X-Gm-Message-State: AOAM531yUIXziAovZTD46tD39lk45y4dcijof+0spml4K//0NsmRT4wP
HKUiNrM0VgmAOAuTTU/gEhohdVbuQqQ=
X-Google-Smtp-Source: ABdhPJzWte7uvgafnOrmr8dDExXSZwPPgZs3mBbgAzVrPfKFDCt3Oi53s+8fY0JZnIbqhv5XM//gww==
X-Received: by 2002:a17:907:8a11:b0:6df:db0a:e5ab with SMTP id
sc17-20020a1709078a1100b006dfdb0ae5abmr9026760ejc.528.1650733598698;
Sat, 23 Apr 2022 10:06:38 -0700 (PDT)
Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
[85.127.52.93]) by smtp.gmail.com with ESMTPSA id
b7-20020a170906708700b006da8440d642sm1855481ejk.113.2022.04.23.10.06.37
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 23 Apr 2022 10:06:38 -0700 (PDT)
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Date: Sun, 17 Apr 2022 12:01:47 +0200
Subject: [PATCH v2 1/3] gnu: mpd: Add support for socket activation.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
to: 54986 <at> debbugs.gnu.org
Content-Transfer-Encoding: 8bit
Message-ID: <8c12d29e4f7ec86ca04136ba0c62bb2947f4f190.camel@HIDDEN>
X-Spam-Score: 2.1 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: * gnu/packages/mpd.scm (mpd)[#:configure-flags]: Convert to
G-Expression. Add “-Dsystemd=enabled”. [#:phases]: New argument. [inputs]:
Add elogind. --- gnu/packages/mpd.scm | 19 ++++++++++++++++++ [...]
Content analysis details: (2.1 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
2.1 DATE_IN_PAST_96_XX Date: is 96 hours or more before Received:
date
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (liliana.prikler[at]gmail.com)
0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3)
[209.85.218.65 listed in wl.mailspike.net]
0.0 RCVD_IN_MSPIKE_WL Mailspike good senders
-0.0 T_SCC_BODY_TEXT_LINE No description available.
X-Debbugs-Envelope-To: 54986
Cc: ludo@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.1 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: * gnu/packages/mpd.scm (mpd)[#:configure-flags]: Convert to
G-Expression. Add “-Dsystemd=enabled”. [#:phases]: New argument. [inputs]:
Add elogind. --- gnu/packages/mpd.scm | 19 ++++++++++++++++++ [...]
Content analysis details: (1.1 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3)
[209.85.218.65 listed in wl.mailspike.net]
-0.0 SPF_PASS SPF: sender matches SPF record
2.1 DATE_IN_PAST_96_XX Date: is 96 hours or more before Received:
date
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (liliana.prikler[at]gmail.com)
0.0 RCVD_IN_MSPIKE_WL Mailspike good senders
-0.0 T_SCC_BODY_TEXT_LINE No description available.
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
* gnu/packages/mpd.scm (mpd)[#:configure-flags]: Convert to G-Expression.
Add “-Dsystemd=enabled”.
[#:phases]: New argument.
[inputs]: Add elogind.
---
gnu/packages/mpd.scm | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
index 1ee6806735..40e6a99ad7 100644
--- a/gnu/packages/mpd.scm
+++ b/gnu/packages/mpd.scm
@@ -47,6 +47,7 @@ (define-module (gnu packages mpd)
#:use-module (gnu packages boost)
#:use-module (gnu packages cdrom)
#:use-module (gnu packages cmake) ;for MPD
+ #:use-module (gnu packages freedesktop) ;elogind
#:use-module (gnu packages gettext)
#:use-module (gnu packages gnome)
#:use-module (gnu packages gnupg)
@@ -119,12 +120,28 @@ (define-public mpd
"1v969w7h3660ph3h2bdlkrzc05pfz95bmxjqdbzzf7pfwf795ifb"))))
(build-system meson-build-system)
(arguments
- `(#:configure-flags '("-Ddocumentation=enabled")))
+ (list
+ #:configure-flags #~(list "-Ddocumentation=enabled"
+ "-Dsystemd=enabled")
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'unpack 'enable-elogind
+ (lambda _
+ (substitute* "src/lib/systemd/meson.build"
+ (("libsystemd") "libelogind"))
+ ;; XXX: systemd dependency overwritten internally, leads to bad
+ ;; errors
+ (substitute* "src/lib/systemd/meson.build"
+ (("systemd_dep = declare_dependency" all)
+ (string-append "_" all)))
+ (substitute* "meson.build"
+ (("systemd_dep,") "systemd_dep, _systemd_dep,")))))))
(inputs (list ao
alsa-lib
avahi
boost
curl
+ elogind
ffmpeg
flac
fmt
--
2.35.1
guix-patches@HIDDEN:bug#54986; Package guix-patches.
Full text available.
Received: (at 54986) by debbugs.gnu.org; 18 Apr 2022 21:19:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 18 17:19:21 2022
Received: from localhost ([127.0.0.1]:41010 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ngYmH-0002or-2M
for submit <at> debbugs.gnu.org; Mon, 18 Apr 2022 17:19:21 -0400
Received: from mail-ej1-f66.google.com ([209.85.218.66]:38438)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <liliana.prikler@HIDDEN>) id 1ngYmF-0002of-RL
for 54986 <at> debbugs.gnu.org; Mon, 18 Apr 2022 17:19:20 -0400
Received: by mail-ej1-f66.google.com with SMTP id r13so29122015ejd.5
for <54986 <at> debbugs.gnu.org>; Mon, 18 Apr 2022 14:19:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=message-id:subject:from:to:cc:date:in-reply-to:references
:user-agent:mime-version:content-transfer-encoding;
bh=6IUAqPwhfWjQtCLVHx2iHhjeW3ag64msVxtxTs9RTwQ=;
b=gATiuwseqUuLHvr+ruI3sZHXW/iL/nNlCNKUbYe/IsfdZ8v8pGzm5etmQ+JEkMCvMh
Y/pfNQyEnYUjnrFZh99/ecvJU1Q3xb/9cNXYknG3B+WxqLfDOfNEuxcOu288gZsWkV14
Eru5l4lHkxk51ZyPeoTIFE674o8IcaXDyZuLTtnXNigESUycmwkOx2ZaWuM3EJnYw4CF
v7L23NOPbDeT6WQDYrs0+ykTjSSHBRcZzvJdgqQ/fJ+1xqke5lJHA5PXH1sqmKLAs3vJ
n6NypvJ/+DdbpvPXA6+nPwf0HWDo7eyhs5SS55teDwV9KwPpFbvA2FFMTWerBzLHqZlM
OOqg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
:references:user-agent:mime-version:content-transfer-encoding;
bh=6IUAqPwhfWjQtCLVHx2iHhjeW3ag64msVxtxTs9RTwQ=;
b=h2Jp4JkXXWrzatcxXDfD8lGq9NlfCCzwZZvMXu954rT2ZfQ0zryyvekuUWAsgK1Kxx
v6N+oZuqRBP0AzG3/YQUdX55SJ3iW0Y4c0Vb/QXQFmty6oJKqT8iRntbYH/iu3nau3Bc
ihfgtKHj5Zb72egkImd9oVtycKzK+9AyHZcM1asvZUbCDyrrgsYdEBBA8+Ke/LnFA3rL
xBVJ0GOJMRJ5G78mJPqVrQ3JYzmZJfaSRvk5RElYCY5+paFLR01Hqwm24KKiwXbesUTQ
QS5ncCZKJMcZ2TO4M/dv/smcHDieSKFoTlsz10BefBJdvXivHyqeOkR6nFVlPDhG0ehP
Sw7Q==
X-Gm-Message-State: AOAM531ITImY/ak0gLYjfGR8Ue9PaT1WqUYehuTpUwgQsFNqU2iEipoX
eX8olcn0EfkZ7qDTJysmMhB6XU4HgUE=
X-Google-Smtp-Source: ABdhPJwoWYh5PhPliBfG8H5wboq4WWGPqRvOPelXoeuP9fovodDPm/M0oiInbF/TBIMAomq7ThW26g==
X-Received: by 2002:a17:907:728c:b0:6e8:a052:4f03 with SMTP id
dt12-20020a170907728c00b006e8a0524f03mr10583893ejc.344.1650316754028;
Mon, 18 Apr 2022 14:19:14 -0700 (PDT)
Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
[85.127.52.93]) by smtp.gmail.com with ESMTPSA id
u6-20020a17090626c600b006e74ef7f092sm4979973ejc.176.2022.04.18.14.19.13
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 18 Apr 2022 14:19:13 -0700 (PDT)
Message-ID: <413952d60ee9444bff89412751b8c7c97a0102a1.camel@HIDDEN>
Subject: Re: bug#54986: [PATCH] gnu: mpd: Add support for socket activation.
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
To: Ludovic =?ISO-8859-1?Q?Court=E8s?= <ludo@HIDDEN>
Date: Mon, 18 Apr 2022 23:19:12 +0200
In-Reply-To: <87fsmaumok.fsf@HIDDEN>
References: <9d4cc9d3ebb05d2aabf8f06e1890efe9b0b9a849.camel@HIDDEN>
<87o80zzagn.fsf@HIDDEN>
<a710e56204436941d99c663d76cf7e51c6a2ed60.camel@HIDDEN>
<87fsmaumok.fsf@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 54986
Cc: 54986 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Am Montag, dem 18.04.2022 um 23:05 +0200 schrieb Ludovic Courtès:
> Hi,
>
> Liliana Marie Prikler <liliana.prikler@HIDDEN> skribis:
>
> > I'm not sure if updating the service is a good idea. On the
> > upside, people who report mpd starting too early will be alleviated
> > of one issue. On the downside, it appears as though mpd too easily
> > escapes shepherd's management. My current observations are more or
> > less consistent with what I saw with Emacs: killing the mpd service
> > won't stop playing music,
>
> Do you mean that ‘herd stop mpd’ doesn’t stop the mpd process?
Yep.
> What does /var/log/messages say?
I don't think there's anything meaningful there to inspect, I'm running
this as a user service. Shepherd's own logs are rather empty.
Interestingly, the running value for the mpd service remains
(("unknown" . "#<input-output: socket 17>")) even after MPD started.
Should that be the case?
> > and shepherd won't restart a killed MPD without asked to.
>
> Weird. What you describe sounds as if shepherd is not looking at the
> right process or something.
>
> If you have a service definition to reproduce this, I’d be happy to
> take a look!
The second is probably just me forgetting to set #:respawn? #t. One
"bug" down, one more to go.
guix-patches@HIDDEN:bug#54986; Package guix-patches.
Full text available.Received: (at 54986) by debbugs.gnu.org; 18 Apr 2022 21:05:59 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 18 17:05:59 2022 Received: from localhost ([127.0.0.1]:40950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ngYZL-0002RD-4G for submit <at> debbugs.gnu.org; Mon, 18 Apr 2022 17:05:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1ngYZJ-0002R2-KO for 54986 <at> debbugs.gnu.org; Mon, 18 Apr 2022 17:05:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52586) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1ngYZC-0003GO-OR; Mon, 18 Apr 2022 17:05:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=mguoktOLYFhgGPer2fzMfDjcnGQa14gI7mxtDDmgkc4=; b=I/A8Hzs/o/eYJ1fqkcpz vwjyb5Owa5blMg7VYHuRDIq3XRUyiqMfaRGbCPo1XHw+oCBUHxuo7p/i6CnY6yHiv6QnAXVdD0ZeV 0gEeHKVItFUET+LX6McDSK1uDGXL1aFR3jCeiRbslRRZUY9G0eyfNIDTLcalAdMpy86//G7ZV2E/x U2SHUyWEam7uqvlqtoSwJN9I6EMCC65y9x07pYrvJfrM2Cza9+0Nj06RoetS4LFwtIE+MGmMDiCo0 HUsWH3j0Cuerg8LAOytMCYpz+GAMvNXXoeJqcyPtW6X5VVcqdH4ZWdiYXYHekc1hRkL9wdViQWIkS RLjq1NrUSK4pUg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:50491 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1ngYZB-0004xd-H4; Mon, 18 Apr 2022 17:05:50 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: Liliana Marie Prikler <liliana.prikler@HIDDEN> Subject: Re: bug#54986: [PATCH] gnu: mpd: Add support for socket activation. References: <9d4cc9d3ebb05d2aabf8f06e1890efe9b0b9a849.camel@HIDDEN> <87o80zzagn.fsf@HIDDEN> <a710e56204436941d99c663d76cf7e51c6a2ed60.camel@HIDDEN> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 29 Germinal an 230 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 18 Apr 2022 23:05:47 +0200 In-Reply-To: <a710e56204436941d99c663d76cf7e51c6a2ed60.camel@HIDDEN> (Liliana Marie Prikler's message of "Sun, 17 Apr 2022 23:57:23 +0200") Message-ID: <87fsmaumok.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54986 Cc: 54986 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Hi, Liliana Marie Prikler <liliana.prikler@HIDDEN> skribis: > I'm not sure if updating the service is a good idea. On the upside, > people who report mpd starting too early will be alleviated of one > issue. On the downside, it appears as though mpd too easily escapes > shepherd's management. My current observations are more or less > consistent with what I saw with Emacs: killing the mpd service won't > stop playing music, Do you mean that =E2=80=98herd stop mpd=E2=80=99 doesn=E2=80=99t stop the m= pd process? What does /var/log/messages say? > and shepherd won't restart a killed MPD without asked to. Weird. What you describe sounds as if shepherd is not looking at the right process or something. If you have a service definition to reproduce this, I=E2=80=99d be happy to= take a look! Thanks, Ludo=E2=80=99.
guix-patches@HIDDEN:bug#54986; Package guix-patches.
Full text available.Received: (at 54986) by debbugs.gnu.org; 17 Apr 2022 21:57:32 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 17 17:57:32 2022 Received: from localhost ([127.0.0.1]:37497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ngCtg-0003Nm-4l for submit <at> debbugs.gnu.org; Sun, 17 Apr 2022 17:57:32 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:46783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <liliana.prikler@HIDDEN>) id 1ngCte-0003NW-H9 for 54986 <at> debbugs.gnu.org; Sun, 17 Apr 2022 17:57:30 -0400 Received: by mail-ed1-f67.google.com with SMTP id s25so15254212edi.13 for <54986 <at> debbugs.gnu.org>; Sun, 17 Apr 2022 14:57:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=0yCxicjH3uL65u/ioktzIcaWY2t4KOzuOplkkFS9ws0=; b=j71joEqjKy/mStBP4pk3eiDk4DFxaIVBAev5kTtOO1RDzc3QnCgEiCj1Oariyysuer H4TT3CYVPz6IqQUziNAzrNTmcV1yq/lwHuKYQL/8qkRbLONgapM+r53nQ+JnZlsT55NL fd61FsfsHEx5MHNRJLD8F2nr12h3DDdZ5ehzh8qoZ/X3AGouOgy7npbm1ggQFFF+2pdB zO6dzptjdXTdz/09w4VKQ4kh8lRfv+mWxLzaNFIFnkhz/IIGvku3KMBXuieNH4pzMLj2 y55LFRhMGDmuw9BdK4RC28+O9KUMFHIuqGph1ReOn6cF6no3QEtbMauIBiIFNph40K1J q66Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=0yCxicjH3uL65u/ioktzIcaWY2t4KOzuOplkkFS9ws0=; b=cNw2UCKV3ZSaRAjm6rZSkVPUlVn9ubwwcNmxiGxA237vKJyC4+nfRtMHQPXAT/yNNH qhCii42umii5G7NQGdft+28LR7saVrHgK/GovES3v9d4AzEApaMkMja3CNqDP17e64hZ VJA4w97Uq0TmLPCeY6bRtehGbg7NFqU4Y/lMFOsLhYLzBeV8jl9Zr5ipiM4mwO0V7VNL 8bCI7OG7LS/xGsuhW+UtDu8voR9x2o2BCnt7koaCYwnEhABiXnAhbfJgBfVYtdYsiRa1 mDxsUsA728H+eoxCfm6vpJquSK93JIBbP+dppGb8kcPGEVhgPIY/041zI3R8moFvuiGK tIfw== X-Gm-Message-State: AOAM530HSuob7iEfS3zuTMrWm8tSwHwPvUBtXvX1pruoGdZs0WbDrdbU APxJalp8U9HSvyvi9OvmwcA= X-Google-Smtp-Source: ABdhPJwMVuNe3ykAI5Y47zr4Dob1tDgMr341Z2Nk/Ihfrpg0k/tavCYT558SpZwaW9KooRo8PFUhqw== X-Received: by 2002:a50:871e:0:b0:41d:77c0:6927 with SMTP id i30-20020a50871e000000b0041d77c06927mr9388462edb.354.1650232644560; Sun, 17 Apr 2022 14:57:24 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id o24-20020aa7dd58000000b00420ca195de9sm6013574edw.25.2022.04.17.14.57.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Apr 2022 14:57:24 -0700 (PDT) Message-ID: <a710e56204436941d99c663d76cf7e51c6a2ed60.camel@HIDDEN> Subject: Re: bug#54986: [PATCH] gnu: mpd: Add support for socket activation. From: Liliana Marie Prikler <liliana.prikler@HIDDEN> To: Ludovic =?ISO-8859-1?Q?Court=E8s?= <ludo@HIDDEN> Date: Sun, 17 Apr 2022 23:57:23 +0200 In-Reply-To: <87o80zzagn.fsf@HIDDEN> References: <9d4cc9d3ebb05d2aabf8f06e1890efe9b0b9a849.camel@HIDDEN> <87o80zzagn.fsf@HIDDEN> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 54986 Cc: 54986 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Am Sonntag, dem 17.04.2022 um 23:06 +0200 schrieb Ludovic Courtès: > Hi, > > Liliana Marie Prikler <liliana.prikler@HIDDEN> skribis: > > > * gnu/packages/mpd.scm (mpd)[#:configure-flags]: Convert to G- > > Expression. > > Add “-Dsystemd=enabled”. > > [#:phases]: New argument. > > [inputs]: Add elogind. > > LGTM! > > Are you planning to update the service as well? I'm not sure if updating the service is a good idea. On the upside, people who report mpd starting too early will be alleviated of one issue. On the downside, it appears as though mpd too easily escapes shepherd's management. My current observations are more or less consistent with what I saw with Emacs: killing the mpd service won't stop playing music, and shepherd won't restart a killed MPD without asked to. IMHO shepherd's socket activation still needs some work before we can make it the default for every service. Cheers
guix-patches@HIDDEN:bug#54986; Package guix-patches.
Full text available.Received: (at 54986) by debbugs.gnu.org; 17 Apr 2022 21:06:26 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 17 17:06:26 2022 Received: from localhost ([127.0.0.1]:37455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ngC6E-00027n-5P for submit <at> debbugs.gnu.org; Sun, 17 Apr 2022 17:06:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1ngC6C-00027a-5D for 54986 <at> debbugs.gnu.org; Sun, 17 Apr 2022 17:06:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58484) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1ngC66-0000ce-To; Sun, 17 Apr 2022 17:06:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=9S1dGqjMLJWG0ECLAPhZkbV8+zaGYypyWPNlqUCDg/4=; b=UZ0wIbN/2oAsQN8lv0yf YRxfmijav9hvpQrmYgu5z3FD/q9LE6q5x4GpzjSQG3JsPI52+btATf5eJrvM1eb6VnnI+ov8Hlb/4 hA4ff0jC8bEZRLMpsf5xvoM2keEvsn0lCNUipbZDvCLmS5nlVBfv2ayDdtRH7Kgt2WzA7prhNW8RU HlUA9sWQMjWEpFb5JbeW8bajDTsY6e4bilir4G12exaEoGdo7ngLvLIegopuOk1E7da58wdXnhbs9 MZOtussux6UYVgVk8QUKEArR6vTr+15o/CD4gRwped2R2eMv9YbZ4XZNk/334YRrDU5WbMcAgoJK9 Ya9Iaii9CuHoxg==; Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=38872 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1ngC66-0002QA-Gs; Sun, 17 Apr 2022 17:06:18 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: Liliana Marie Prikler <liliana.prikler@HIDDEN> Subject: Re: bug#54986: [PATCH] gnu: mpd: Add support for socket activation. References: <9d4cc9d3ebb05d2aabf8f06e1890efe9b0b9a849.camel@HIDDEN> Date: Sun, 17 Apr 2022 23:06:16 +0200 In-Reply-To: <9d4cc9d3ebb05d2aabf8f06e1890efe9b0b9a849.camel@HIDDEN> (Liliana Marie Prikler's message of "Sun, 17 Apr 2022 12:01:47 +0200") Message-ID: <87o80zzagn.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 54986 Cc: 54986 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Hi, Liliana Marie Prikler <liliana.prikler@HIDDEN> skribis: > * gnu/packages/mpd.scm (mpd)[#:configure-flags]: Convert to G-Expression. > Add =E2=80=9C-Dsystemd=3Denabled=E2=80=9D. > [#:phases]: New argument. > [inputs]: Add elogind. LGTM! Are you planning to update the service as well? Thanks, Ludo=E2=80=99.
guix-patches@HIDDEN:bug#54986; Package guix-patches.
Full text available.
Received: (at submit) by debbugs.gnu.org; 17 Apr 2022 10:04:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 17 06:04:00 2022
Received: from localhost ([127.0.0.1]:34993 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ng1l9-00006P-NY
for submit <at> debbugs.gnu.org; Sun, 17 Apr 2022 06:03:59 -0400
Received: from lists.gnu.org ([209.51.188.17]:42376)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <liliana.prikler@HIDDEN>) id 1ng1l8-00006I-4t
for submit <at> debbugs.gnu.org; Sun, 17 Apr 2022 06:03:58 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:56488)
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <liliana.prikler@HIDDEN>)
id 1ng1l1-0000xz-2C
for guix-patches@HIDDEN; Sun, 17 Apr 2022 06:03:53 -0400
Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]:36673)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <liliana.prikler@HIDDEN>)
id 1ng1ky-00007A-HI
for guix-patches@HIDDEN; Sun, 17 Apr 2022 06:03:49 -0400
Received: by mail-ed1-x541.google.com with SMTP id u18so14652331eda.3
for <guix-patches@HIDDEN>; Sun, 17 Apr 2022 03:03:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=from:date:subject:mime-version:to:content-transfer-encoding
:message-id; bh=mGiY5r+/zrnr75rG4wVqhLDFOdMCk5a8HGj+r9Jazyc=;
b=dxsZCfVdsQ9LWhNsWJGsSMgXp6wJeUNSkPk5ATcGxiKQe0uRRgp3sKeLrictPAtJ/C
xDOIsKuxG/YMu4FRbc5QKmG10lsnbYFb3GxBwodC32mmKfB/oACnTrZvaCokV9X1Bzhb
VebkjqzCaepiIzMDystHsEXKdY/bm9ziTPUZcpaC0dsC/g/WAVh72XBASRIkyVt610zt
ECxOvZIVrSzsjbpClZ+GMy/k7bT9PkPui3YpoGYzGSZYpsTeRYoi4BTxbusz7VgReMd0
B/4RlVt8XUGyvKOJ+BZZn5ENOy/3LAPXhl9moZVKmdI/bGyduYvh00JdlTBOJj5lLm1c
RUyg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:from:date:subject:mime-version:to
:content-transfer-encoding:message-id;
bh=mGiY5r+/zrnr75rG4wVqhLDFOdMCk5a8HGj+r9Jazyc=;
b=iBqU6jg6NtJIEo5+9JGSLt2/Fb5kghBce70xqcFf0dIer9LzBva+2Rs175pHnzJRuV
WQCn+p9hIZwprHZSYcu31SNxsEtv2hipGLScv7JalneOv3RIBDoNAb8T3tbkb/6ATElE
Jnwc+QQdSX0hjccN3wmLNx2uLhk3SV7A3id9e7n5vckGY4CNQw9CRMgL3nqx74d/1KCN
dwlAp0OfN8jdAzVxQ0BtGr4aFnkv1LQ9sl48KOSFdyI0Tix9ftGF0BOlQl7LKmycFnxS
PL+GQZlczfkHLYAfIawsez5JBYnQLl5kNzqM/2pZixTfbM6dJW8auSA/Ine+5OR2wOU8
11lw==
X-Gm-Message-State: AOAM533yX+U5VV/0Cb2MrkyrcrjsXOgPRkJMWHb5p8LzV5QoMv6mSn1H
mgJJi7ttO5z3bO0AqNdlvofZyLJaJj8=
X-Google-Smtp-Source: ABdhPJwjroGMd/GfwGRJz9brUckyy3zDr2HfZXid02wgzs0sFNr1iE0yRivXllWLaUi8y3k19aG8hg==
X-Received: by 2002:a05:6402:3713:b0:41d:96f6:8a09 with SMTP id
ek19-20020a056402371300b0041d96f68a09mr7279448edb.136.1650189825789;
Sun, 17 Apr 2022 03:03:45 -0700 (PDT)
Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
[85.127.52.93]) by smtp.gmail.com with ESMTPSA id
cq24-20020a056402221800b00420ad7d2dd0sm5421086edb.29.2022.04.17.03.03.44
for <guix-patches@HIDDEN>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 17 Apr 2022 03:03:45 -0700 (PDT)
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Date: Sun, 17 Apr 2022 12:01:47 +0200
Subject: [PATCH] gnu: mpd: Add support for socket activation.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
to: guix-patches@HIDDEN
Content-Transfer-Encoding: 8bit
Message-ID: <9d4cc9d3ebb05d2aabf8f06e1890efe9b0b9a849.camel@HIDDEN>
Received-SPF: pass client-ip=2a00:1450:4864:20::541;
envelope-from=liliana.prikler@HIDDEN; helo=mail-ed1-x541.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)
* gnu/packages/mpd.scm (mpd)[#:configure-flags]: Convert to G-Expression.
Add “-Dsystemd=enabled”.
[#:phases]: New argument.
[inputs]: Add elogind.
---
gnu/packages/mpd.scm | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
index 1ee6806735..40e6a99ad7 100644
--- a/gnu/packages/mpd.scm
+++ b/gnu/packages/mpd.scm
@@ -47,6 +47,7 @@ (define-module (gnu packages mpd)
#:use-module (gnu packages boost)
#:use-module (gnu packages cdrom)
#:use-module (gnu packages cmake) ;for MPD
+ #:use-module (gnu packages freedesktop) ;elogind
#:use-module (gnu packages gettext)
#:use-module (gnu packages gnome)
#:use-module (gnu packages gnupg)
@@ -119,12 +120,28 @@ (define-public mpd
"1v969w7h3660ph3h2bdlkrzc05pfz95bmxjqdbzzf7pfwf795ifb"))))
(build-system meson-build-system)
(arguments
- `(#:configure-flags '("-Ddocumentation=enabled")))
+ (list
+ #:configure-flags #~(list "-Ddocumentation=enabled"
+ "-Dsystemd=enabled")
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'unpack 'enable-elogind
+ (lambda _
+ (substitute* "src/lib/systemd/meson.build"
+ (("libsystemd") "libelogind"))
+ ;; XXX: systemd dependency overwritten internally, leads to bad
+ ;; errors
+ (substitute* "src/lib/systemd/meson.build"
+ (("systemd_dep = declare_dependency" all)
+ (string-append "_" all)))
+ (substitute* "meson.build"
+ (("systemd_dep,") "systemd_dep, _systemd_dep,")))))))
(inputs (list ao
alsa-lib
avahi
boost
curl
+ elogind
ffmpeg
flac
fmt
--
2.35.1
Liliana Marie Prikler <liliana.prikler@HIDDEN>:guix-patches@HIDDEN.
Full text available.guix-patches@HIDDEN:bug#54986; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.