GNU logs - #55242, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#55242] [PATCH 01/10] guix: import: Print the number of packages at the end.
Resent-From: Attila Lendvai <attila@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 11:22:02 +0000
Resent-Message-ID: <handler.55242.B.165157687110165 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 55242 <at> debbugs.gnu.org
Cc: Attila Lendvai <attila@HIDDEN>
From: Attila Lendvai <attila@HIDDEN>
Date: Tue,  3 May 2022 13:16:12 +0200
Message-Id: <20220503111620.3139-1-attila@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2a00:1450:4864:20::630;
 envelope-from=attila.lendvai@HIDDEN; helo=mail-ej1-x630.google.com
X-Spam_score_int: -14
X-Spam_score: -1.5
X-Spam_bar: -
X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249,
 FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -0.8 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.8 (-)

---

this will be a series of patches that were needed to be able to
(mostly) successfully run these two imports (go-ethereum and
ethersphere/bee):

RUN=12
clear && ./pre-inst-env guix import go -r --pin-versions github.com/ethersphere/bee@HIDDEN > >(tee -a ~/workspace/guix/importing/bee-run-${RUN}.scm) 2> >(tee -a ~/workspace/guix/importing/bee-run-${RUN}.log >&2)

RUN=36
clear && ./pre-inst-env guix import go -r --pin-versions github.com/ethereum/go-ethereum@HIDDEN > >(tee -a ~/workspace/guix/importing/go-ethereum-run-${RUN}.scm) 2> >(tee -a ~/workspace/guix/importing/go-ethereum-run-${RUN}.log >&2)

note that i only have a mediocre knowledge of the golang
infrastructure, so this should be reviewed by someone who
more deeply understands the golang build process, and its
implementation within guix.

i think most of it is not very controversial, maybe except
the last commit.

i'm willing to reshape this under the guidance of someone who
has a better bird's eye view perspective on this all.

 guix/scripts/import.scm | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/guix/scripts/import.scm b/guix/scripts/import.scm
index 40fa6759ae..891f558b97 100644
--- a/guix/scripts/import.scm
+++ b/guix/scripts/import.scm
@@ -127,10 +127,14 @@ (define-command (guix-import . args)
                             ('define-public _ ...)))
               (print expr))
              ((? list? expressions)
-              (for-each (lambda (expr)
-                          (print expr)
-                          (newline))
-                        expressions))
+              (let ((count 0))
+                (for-each (lambda (expr)
+                            (print expr)
+                            (set! count (1+ count))
+                            (newline))
+                          expressions)
+                (format (current-warning-port)
+                        (G_ "Imported ~a packages~%") count)))
              (x
               (leave (G_ "'~a' import failed~%") importer))))
          (let ((hint (string-closest importer importers #:threshold 3)))
-- 
2.35.1

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Attila Lendvai <attila@HIDDEN>
Subject: bug#55242: Acknowledgement ([PATCH 01/10] guix: import: Print the
 number of packages at the end.)
Message-ID: <handler.55242.B.165157687110165.ack <at> debbugs.gnu.org>
References: <20220503111620.3139-1-attila@HIDDEN>
X-Gnu-PR-Message: ack 55242
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 55242 <at> debbugs.gnu.org
Date: Tue, 03 May 2022 11:22:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 55242 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
55242: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D55242
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#55242] [PATCH 02/10] guix: import: go: Rename go.pkg.dev-info to pkg.go.dev-info.
References: <20220503111620.3139-1-attila@HIDDEN>
In-Reply-To: <20220503111620.3139-1-attila@HIDDEN>
Resent-From: Attila Lendvai <attila@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 11:44:02 +0000
Resent-Message-ID: <handler.55242.B55242.165157821020687 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 55242 <at> debbugs.gnu.org
Cc: Attila Lendvai <attila@HIDDEN>
From: Attila Lendvai <attila@HIDDEN>
Date: Tue,  3 May 2022 13:42:53 +0200
Message-Id: <20220503114301.9524-2-attila@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

To properly mimic the name of the website. Also employ it at one more place.
---
 guix/import/go.scm | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/guix/import/go.scm b/guix/import/go.scm
index d00c13475a..bb4bb7bb7b 100644
--- a/guix/import/go.scm
+++ b/guix/import/go.scm
@@ -120,8 +120,11 @@ (define (escape occurrence)
 ;; Prevent inlining of this procedure, which is accessed by unit tests.
 (set! go-path-escape go-path-escape)
 
-(define (go.pkg.dev-info name)
-  (http-fetch* (string-append "https://pkg.go.dev/" name)))
+(define (pkg.go.dev-info module-path)
+  ;; FIXME if MODULE-PATH is a fork on github, then it will try to get the
+  ;; info of the fork (instead of the upstream), which most probably does not
+  ;; exist in pkg.go.dev.  Example: https://github.com/bonitoo-io/oapi-codegen
+  (http-fetch* (string-append "https://pkg.go.dev/" module-path)))
 
 (define* (go-module-version-string goproxy name #:key version)
   "Fetch the version string of the latest version for NAME from the given
@@ -147,7 +150,7 @@ (define* (go-module-available-versions goproxy name)
 (define (go-package-licenses name)
   "Retrieve the list of licenses that apply to NAME, a Go package or module
 name (e.g. \"github.com/golang/protobuf/proto\")."
-  (let* ((body (go.pkg.dev-info (string-append name "?tab=licenses")))
+  (let* ((body (pkg.go.dev-info (string-append name "?tab=licenses")))
          ;; Extract the text contained in a h2 child node of any
          ;; element marked with a "License" class attribute.
          (select (sxpath `(// (* (@ (equal? (class "License"))))
@@ -169,7 +172,7 @@ (define (sxml->texi sxml-node)
 (define (go-package-description name)
   "Retrieve a short description for NAME, a Go package name,
 e.g. \"google.golang.org/protobuf/proto\"."
-  (let* ((body (go.pkg.dev-info name))
+  (let* ((body (pkg.go.dev-info name))
          (sxml (html->sxml body #:strict? #t))
          (overview ((sxpath
                      `(//
@@ -206,8 +209,7 @@ (define (go-package-synopsis module-name)
 the https://pkg.go.dev/ web site."
   ;; Note: Only the *module* (rather than package) page has the README title
   ;; used as a synopsis on the https://pkg.go.dev web site.
-  (let* ((url (string-append "https://pkg.go.dev/" module-name))
-         (body (http-fetch* url))
+  (let* ((body (pkg.go.dev-info module-name))
          ;; Extract the text contained in a h2 child node of any
          ;; element marked with a "License" class attribute.
          (select-title (sxpath
-- 
2.35.1

Message sent to guix-patches@HIDDEN:

Subject: [bug#55242] [PATCH 03/10] guix: import: go: Add mockup logging facility.
Resent-From: Attila Lendvai <attila@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 11:44:02 +0000
Resent-Message-ID: <handler.55242.B55242.165157821120693 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 55242 <at> debbugs.gnu.org
Cc: Attila Lendvai <attila@HIDDEN>
From: Attila Lendvai <attila@HIDDEN>
Date: Tue,  3 May 2022 13:42:54 +0200
Message-Id: <20220503114301.9524-3-attila@HIDDEN>
In-Reply-To: <20220503114301.9524-2-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Introduce a (local) mockup logger, so that we don't need to keep adding and
deleting format's when debugging the codebase.

* guix/import/go.scm (log.info) (log.debug): New macros.
---
 guix/import/go.scm | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/guix/import/go.scm b/guix/import/go.scm
index bb4bb7bb7b..0af5e4b5e2 100644
--- a/guix/import/go.scm
+++ b/guix/import/go.scm
@@ -100,6 +100,17 @@ (define-module (guix import go)

 ;;; Code:

+;; FIXME set up logging for the entire project, and replace this poor man's
+;; logger with the proper one.
+(define-syntax-rule (log.info format-string ...)
+  (let ((port (current-warning-port)))
+    (format port format-string ...)
+    (newline port)))
+
+(define-syntax-rule (log.debug format-string ...)
+  ;;(log.info format-string ...)
+  '())
+
 (define http-fetch*
   ;; Like http-fetch, but memoized and returning the body as a string.
   (memoize (lambda args
-- 
2.35.1

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 05/10] guix: import: go: Harden sxml->texi conversion.
Resent-From: Attila Lendvai <attila@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 11:44:03 +0000
Resent-Message-ID: <handler.55242.B55242.165157821220716 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 55242 <at> debbugs.gnu.org
Cc: Attila Lendvai <attila@HIDDEN>
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165157821220716
          (code B ref 55242); Tue, 03 May 2022 11:44:03 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 11:43:32 +0000
Received: from localhost ([127.0.0.1]:38822 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlqwG-0005O4-2u
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 07:43:32 -0400
Received: from mail-ed1-f42.google.com ([209.85.208.42]:34329)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <attila.lendvai@HIDDEN>) id 1nlqwD-0005N7-Ke
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 07:43:29 -0400
Received: by mail-ed1-f42.google.com with SMTP id a21so19525563edb.1
 for <55242 <at> debbugs.gnu.org>; Tue, 03 May 2022 04:43:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=l8EBOt5SVXWzpaDhx/Bhrgf83/rE3rCzepMLOfV+yCc=;
 b=AnPL6C6a0VvRTC5OJaMcI5ikMZDsRmcY4TNvZl2eUXHxwUJrI/73kBs1seZuRxZzJe
 pYdcWlhnMify8Ogen1ulhnNJ10841tb5TEb6+BClw8F6wYps4aJfqGXV1egtDtHYJuEx
 tHo6wakwsxti7L+sROcRdQ0+XDoqOvxfluvGnaPYEmA9mSmv40ZQLCYZnPX0rsqd4K2A
 Pjx3jR8kvNvtNkJJgsQr82yQyUTE1QVQM5C2aITH8FCUtX2YrGw8QyH8o2/oDYlIdDad
 eB7q11GYcbprjcS+om+SiP+0ffHesrrLh7VeW1cJNzbL7PWfHcaKDMIgr7L+VmBouH1z
 WiaQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=l8EBOt5SVXWzpaDhx/Bhrgf83/rE3rCzepMLOfV+yCc=;
 b=LNa4spye5B8UMcq+gz1vqYjw2taZsUHfSbZ0RpiO/cTHIMsi9mosUbbaHNicn4lEHs
 iXhw3F/Zy7v8c/7kn4FH+rVBv4J/+0X/moOwUmfo0UAwzYxlGnFzgdysN/y3gUtZDFmN
 RXOhXLAOKp9UzHAWwmviG9ODOYhZ1KdxYrX3XCx5J4oPSCeN8LwsfIBrM+1YctyUEjUm
 NXV1YGRBZBUeStGImRfvk7N2cOrF12MsuLv9Z8PjHuH4Vva/kfjn8n8rV4q3zJZx0NVF
 vu+gRxrYyqyEoNCZXZFKyiQhHYqyrFKLLPL5eVpz7BpgaoqFnItpxQxFsJXj6iDGTkbT
 7n/w==
X-Gm-Message-State: AOAM530tHTpc1qIxQb/LueJJs9A/2rR53Jxeyw9lBEzSzEvYVFvD/B0i
 wkEyjJQgmpNG1ZSl7DF7WkaKoS+uSUQ=
X-Google-Smtp-Source: ABdhPJyiF6hFnrR6qsZw7KZ2CKW6ZpWVIHoS4lW2O+m2Me6l/HPUiVOMsskzxKz8pElVyAUNPWL6Vw==
X-Received: by 2002:a50:8a96:0:b0:425:e046:76d9 with SMTP id
 j22-20020a508a96000000b00425e04676d9mr17531066edj.115.1651578204017; 
 Tue, 03 May 2022 04:43:24 -0700 (PDT)
Received: from lelap.local (catv-89-132-245-188.catv.fixed.vodafone.hu.
 [89.132.245.188]) by smtp.gmail.com with ESMTPSA id
 k13-20020a05640212cd00b0042617ba63d6sm7766964edx.96.2022.05.03.04.43.23
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 03 May 2022 04:43:23 -0700 (PDT)
From: Attila Lendvai <attila@HIDDEN>
Date: Tue,  3 May 2022 13:42:56 +0200
Message-Id: <20220503114301.9524-5-attila@HIDDEN>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220503114301.9524-2-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.5 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

* guix/import/go.scm (sxml->texi): Escape @ as @@, and only emit the text part
of URLs if they are plain strings.
---
 guix/import/go.scm | 27 ++++++++++++++++++++-------
 1 file changed, 20 insertions(+), 7 deletions(-)

diff --git a/guix/import/go.scm b/guix/import/go.scm
index a115c61adc..6b0fbaa8b6 100644
--- a/guix/import/go.scm
+++ b/guix/import/go.scm
@@ -172,13 +172,26 @@ (define (sxml->texi sxml-node)
   "A very basic SXML to Texinfo converter which attempts to preserve HTML
 formatting and links as text."
   (sxml-match sxml-node
-              ((strong ,text)
-               (format #f "@strong{~a}" text))
-              ((a (@ (href ,url)) ,text)
-               (format #f "@url{~a,~a}" url text))
-              ((code ,text)
-               (format #f "@code{~a}" text))
-              (,something-else something-else)))
+    ((strong ,text)
+     (format #f "@strong{~a}" text))
+    ((a (@ (href ,url)) ,body)
+     ;; Examples: image in the url: github.com/go-openapi/jsonpointer
+     ;; (code ...) in the URL body: github.com/mwitkow/go-conntrack
+     (if (string? body)
+         (format #f "@url{~a,~a}" url body)
+         (sxml-match body
+                     ((code ,text)
+                      (format #f "@url{~a,~a}" url (sxml->texi body)))
+                     (,_
+                      (format #f "@url{~a}" url)))))
+    ((code ,text)
+     (format #f "@code{~a}" text))
+    (,something-else
+     ;; Example: @ in the description: github.com/ethersphere/langos
+     (if (string? something-else)
+         (string-replace-substring something-else
+                                   "@" "@@")
+         something-else))))
 
 (define (go-package-description name)
   "Retrieve a short description for NAME, a Go package name,
-- 
2.35.1

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 06/10] guix: import: go: Add a local duplicate of http-fetch.
Resent-From: Attila Lendvai <attila@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 11:44:03 +0000
Resent-Message-ID: <handler.55242.B55242.165157821320737 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 55242 <at> debbugs.gnu.org
Cc: Attila Lendvai <attila@HIDDEN>
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165157821320737
          (code B ref 55242); Tue, 03 May 2022 11:44:03 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 11:43:33 +0000
Received: from localhost ([127.0.0.1]:38826 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlqwH-0005OH-Af
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 07:43:33 -0400
Received: from mail-ed1-f44.google.com ([209.85.208.44]:39809)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <attila.lendvai@HIDDEN>) id 1nlqwE-0005N9-Gz
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 07:43:31 -0400
Received: by mail-ed1-f44.google.com with SMTP id g20so19511897edw.6
 for <55242 <at> debbugs.gnu.org>; Tue, 03 May 2022 04:43:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=gdXWK8w8gBi+z5S1dgCIitSmkMrxIP2VPhd8XbARarQ=;
 b=HyT0crT8mm3ccVqm4+LrFQX4+WiSxtSoDxXeiDCKMi0m0+yfRxgHbU335LD3UyA2qS
 faSoQOL1S7Ic4iyEgX8MymFdKKpsUSTMqMsy9BCttAhPXeYfJEAr7W4RkQm+YNCsa9SB
 o2u/iUFOjx3OOOVjJEmb4qTziWQQapiyf13ZizMbAAxUChmv28eos7AVXQ3ObP2WESNS
 uRc6tLh+MfV1WVZpyh1DLZgGc7EwctnBqnTVTNTywVfW+cJjUT+itpCoGytSnAwNLC4Z
 MPIGdy5m3WEcMeXjYAeGVL3olBC1pLNrUsf88UUT1nCjIV9MbxrdSu0iB/XkQPpfTdJY
 Z/UA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=gdXWK8w8gBi+z5S1dgCIitSmkMrxIP2VPhd8XbARarQ=;
 b=Fn66oExjvWeDzNZ65FwRpVFfoi8CYxe9yIfoSz4hQ/wC2WezgBgbxltyjOg4SD5jgq
 D03JR5CurhRKeFmcI0EY+EN7zkrWQpfFRcCK3jCePWuhkcNGJ+rdSqoGD1yVfPll9/i6
 RdiPIaatifV+Wh70PduLTFjBzkkr3MrONzbrxYKWOWDFaPueByFY55JC04eOtL5UPLcp
 eaMZLU8kciFXf9USIcWb+sT9tOL3hJ7uVJ8V/HEeDVD+cq7RRTL65NbpKD8Yrhh2TsA+
 hSp0zxwax0C88DLL9Tq7YkGoz4DilZQA9R2+hMk2SGAjHwueimyLty5N52p9VD5zYdC9
 j5NQ==
X-Gm-Message-State: AOAM533iBh/q1QIpqtHKQKtmkqqikcVEBvESx7TJ0IvFPAz9SeMYlfDX
 ay6cJqPIHvr+Rfbe885u4P47E8OZu28=
X-Google-Smtp-Source: ABdhPJw6GCQJ3tKo7W92ii6KOVMfj+EE/DhSOzgMXDjsmzwQY7qmRgluEc7ZYnlbxQhB/J6RQXdhMw==
X-Received: by 2002:a05:6402:354a:b0:427:d0e1:8ef3 with SMTP id
 f10-20020a056402354a00b00427d0e18ef3mr7012237edd.66.1651578204809; 
 Tue, 03 May 2022 04:43:24 -0700 (PDT)
Received: from lelap.local (catv-89-132-245-188.catv.fixed.vodafone.hu.
 [89.132.245.188]) by smtp.gmail.com with ESMTPSA id
 k13-20020a05640212cd00b0042617ba63d6sm7766964edx.96.2022.05.03.04.43.24
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 03 May 2022 04:43:24 -0700 (PDT)
From: Attila Lendvai <attila@HIDDEN>
Date: Tue,  3 May 2022 13:42:57 +0200
Message-Id: <20220503114301.9524-6-attila@HIDDEN>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220503114301.9524-2-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.5 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

This is needed when dealing with golang packages, as per:
https://golang.org/ref/mod#vcs-find

A page may return 404, but at the same time also contain the sought after
`go-import` meta tag.  An example for such a project/page is:
https://www.gonum.org/v1/gonum?go-get=1

It's not enough to just handle the thrown exception, because we need to be
able to get hold of the fetched content, too.

Discussion why it's duplicated here: https://issues.guix.gnu.org/54836

* guix/import/go.scm (http-fetch): Add a copy and extend it with the
accept-all-response-codes? param.
---
 guix/import/go.scm | 107 ++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 105 insertions(+), 2 deletions(-)

diff --git a/guix/import/go.scm b/guix/import/go.scm
index 6b0fbaa8b6..a08005d090 100644
--- a/guix/import/go.scm
+++ b/guix/import/go.scm
@@ -33,13 +33,22 @@ (define-module (guix import go)
   #:use-module (guix import json)
   #:use-module (guix packages)
   #:use-module ((guix utils) #:select (string-replace-substring))
-  #:use-module (guix http-client)
+  ;; FIXME? We use a local copy of http-fetch.
+  ;; See https://issues.guix.gnu.org/54836
+  #:use-module ((guix http-client) #:hide (http-fetch))
+  #:use-module (guix base64)
+  #:use-module (rnrs bytevectors)
+  #:use-module ((guix build download)
+                #:select (open-socket-for-uri
+                          (open-connection-for-uri
+                           . guix:open-connection-for-uri)
+                          resolve-uri-reference))
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix memoization)
   #:autoload   (htmlprag) (html->sxml)            ;from Guile-Lib
   #:autoload   (guix serialization) (write-file)
   #:autoload   (guix base32) (bytevector->nix-base32-string)
-  #:autoload   (guix build utils) (mkdir-p)
+  #:autoload   (guix build utils) (mkdir-p dump-port)
   #:autoload   (gcrypt hash) (hash-algorithm sha256)
   #:use-module (ice-9 format)
   #:use-module (ice-9 match)
@@ -69,6 +78,100 @@ (define-module (guix import go)
             go-module->guix-package*
             go-module-recursive-import))
 
+;; This is a duplicate from (guix http-client) with the addition of a
+;; #:accept-all-response-codes? param. See https://issues.guix.gnu.org/54836
+(define* (http-fetch uri #:key port (text? #f) (buffered? #t)
+                     (open-connection guix:open-connection-for-uri)
+                     (keep-alive? #f)
+                     (verify-certificate? #t)
+                     (headers '((user-agent . "GNU Guile")))
+                     (log-port (current-error-port))
+                     timeout
+                     (accept-all-response-codes? #f))
+  "Return an input port containing the data at URI, and the expected number of
+bytes available or #f.  If TEXT? is true, the data at URI is considered to be
+textual.  Follow any HTTP redirection.  When BUFFERED? is #f, return an
+unbuffered port, suitable for use in `filtered-port'.  HEADERS is an alist of
+extra HTTP headers.
+
+When KEEP-ALIVE? is true, the connection is marked as 'keep-alive' and PORT is
+not closed upon completion.
+
+When VERIFY-CERTIFICATE? is true, verify HTTPS server certificates.
+
+TIMEOUT specifies the timeout in seconds for connection establishment; when
+TIMEOUT is #f, connection establishment never times out.
+
+Write information about redirects to LOG-PORT.
+
+When ACCEPT-ALL-RESPONSE-CODES? is false then raise an '&http-get-error'
+condition if downloading fails, otherwise return the response regardless
+of the reponse code."
+  (define parsed-initial-uri
+    (if (string? uri) (string->uri uri) uri))
+
+  (define (open-connection* uri)
+    (open-connection uri
+                     #:verify-certificate? verify-certificate?
+                     #:timeout timeout))
+
+  (let loop ((current-uri parsed-initial-uri)
+             (current-port (or port (open-connection parsed-initial-uri))))
+    (let ((headers (match (uri-userinfo current-uri)
+                     ((? string? str)
+                      (cons (cons 'Authorization
+                                  (string-append "Basic "
+                                                 (base64-encode
+                                                  (string->utf8 str))))
+                            headers))
+                     (_ headers))))
+      (unless (or buffered? (not (file-port? current-port)))
+        (setvbuf current-port 'none))
+      (let*-values (((resp data)
+                     (http-get current-uri #:streaming? #t #:port current-port
+                               #:keep-alive? keep-alive?
+                               #:headers headers))
+                    ((code)
+                     (response-code resp)))
+        (case code
+          ((200)
+           (values data (response-content-length resp)))
+          ((301                         ; moved permanently
+            302                         ; found (redirection)
+            303                         ; see other
+            307                         ; temporary redirection
+            308)                        ; permanent redirection
+           (let ((host (uri-host current-uri))
+                 (new-uri (resolve-uri-reference (response-location resp)
+                                                 current-uri)))
+             (if keep-alive?
+                 (dump-port data (%make-void-port "w0")
+                            (response-content-length resp))
+                 (close-port current-port))
+             (format log-port (G_ "following redirection to `~a'...~%")
+                     (uri->string new-uri))
+             (loop new-uri
+                   (or (and keep-alive?
+                            (or (not (uri-host new-uri))
+                                (string=? host (uri-host new-uri)))
+                            current-port)
+                       (open-connection* new-uri)))))
+          (else
+           (if accept-all-response-codes?
+               (values data (response-content-length resp))
+               (raise (condition (&http-get-error
+                                  (uri current-uri)
+                                  (code code)
+                                  (reason (response-reason-phrase resp))
+                                  (headers (response-headers resp)))
+                                 (&message
+                                  (message
+                                   (format
+                                    #f
+                                    (G_ "~a: HTTP download failed: ~a (~s)")
+                                    (uri->string current-uri) code
+                                    (response-reason-phrase resp)))))))))))))
+
 ;;; Commentary:
 ;;;
 ;;; (guix import go) attempts to make it easier to create Guix package
-- 
2.35.1

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 04/10] guix: import: go: Fix the interpretation of the replace directive.
Resent-From: Attila Lendvai <attila@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 11:44:03 +0000
Resent-Message-ID: <handler.55242.B55242.165157821420744 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 55242 <at> debbugs.gnu.org
Cc: Attila Lendvai <attila@HIDDEN>
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165157821420744
          (code B ref 55242); Tue, 03 May 2022 11:44:03 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 11:43:34 +0000
Received: from localhost ([127.0.0.1]:38828 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlqwH-0005OQ-Rn
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 07:43:34 -0400
Received: from mail-ed1-f52.google.com ([209.85.208.52]:45618)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <attila.lendvai@HIDDEN>) id 1nlqwF-0005NC-BF
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 07:43:31 -0400
Received: by mail-ed1-f52.google.com with SMTP id be20so19512279edb.12
 for <55242 <at> debbugs.gnu.org>; Tue, 03 May 2022 04:43:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=8AS+bwnBiW5h+Jn9QhXNURpZsGBqogHAd3TY/Q7wtEY=;
 b=C19XHXcA/cNVDwDQvPxJJpiWHtY6GonPU7F7BeeyFBWvM37XC5AClRL67+5wCfPyW9
 R5h/sjmrfFZcMbCfq3SremekjAKZOHTG23TJgXKjboWP4f3JFyq2oXT1SDLGgNPJjvpB
 FkmN8AhgnxiOxRPSMks5A5tph1Bi/Ziw+OBUEGE/Y6LOfAB9Pb3scSOXgRnmtbQ0tKRT
 aU+dQBgZxoNOn5k5iUAQnHs9ge1wcng5h37CErZ19IJcCTU1GydYRGficAXecb/U0y0k
 JHF43HVCx8zJE66zN/HVMIXPnPKchqYrSerJIfjyPUW0V28f7F0mQupVg6pztYxXgJm3
 c/Rg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=8AS+bwnBiW5h+Jn9QhXNURpZsGBqogHAd3TY/Q7wtEY=;
 b=miQ1w/q7gH5hwJCahplA7jV/7F1un/7zvkVIhyhmYVUcfykwwmK1TQ+qXx8tM2nblU
 HsiFJ54/0OHb78P5ktjFkerbE7VgoJsXssPMRIAWDk7/hLHETLwMJ9P9mB8+Ua5j/nWW
 0wyTcLFsTSII+K6oxgWi+qkS7heFn2fiX44PX0oB64ko+yTikxHRgMQ2nUKH+A2Yzj0W
 QuNiwKRGSaTtlruE2On47sOfzTVvWGVRPTCrmLK/SXVKShtCtg+LiLOS4dUpjd8Ezzim
 1U0haHGeYNgsvxOOnqD9mlxeqTI6G31LhhOcxUWyzNfyhs/DxvRRgqwZMGarbm8YpBwo
 ZrLg==
X-Gm-Message-State: AOAM533y5RhXnDvc6wUePh/AGtHY7o0PhdgBRgHY7J+xDORQoKKAlO97
 27ueZLhqSLZ+bK/kY8W6AbLkP2+rfXk=
X-Google-Smtp-Source: ABdhPJxiuCX6iWHRvhew9WfO5GSHkg2C7tORKzfWdFVbha2m52btbQeb4RjmN/AMXn6/nKAxHx4PGg==
X-Received: by 2002:a05:6402:84a:b0:426:262d:967e with SMTP id
 b10-20020a056402084a00b00426262d967emr17646593edz.286.1651578203253; 
 Tue, 03 May 2022 04:43:23 -0700 (PDT)
Received: from lelap.local (catv-89-132-245-188.catv.fixed.vodafone.hu.
 [89.132.245.188]) by smtp.gmail.com with ESMTPSA id
 k13-20020a05640212cd00b0042617ba63d6sm7766964edx.96.2022.05.03.04.43.22
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 03 May 2022 04:43:22 -0700 (PDT)
From: Attila Lendvai <attila@HIDDEN>
Date: Tue,  3 May 2022 13:42:55 +0200
Message-Id: <20220503114301.9524-4-attila@HIDDEN>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220503114301.9524-2-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.5 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

When a version is specified in a replace directive, then we must also match
the version against any potential replacements.

* guix/import/go.scm (go.mod-requirements): Fix by also matching the version.
---
 guix/import/go.scm | 53 +++++++++++++++++++++++++++++++---------------
 1 file changed, 36 insertions(+), 17 deletions(-)

diff --git a/guix/import/go.scm b/guix/import/go.scm
index 0af5e4b5e2..a115c61adc 100644
--- a/guix/import/go.scm
+++ b/guix/import/go.scm
@@ -331,7 +331,7 @@ (define-peg-pattern original all (or (and module-path version) module-path))
   (define-peg-pattern with all (or (and module-path version) file-path))
   (define-peg-pattern replace all (and original => with EOL))
   (define-peg-pattern replace-top body
-    (and (ignore "replace") 
+    (and (ignore "replace")
          (or (and block-start (* (or replace block-line)) block-end) replace)))
 
   ;; RetractSpec = ( Version | "[" Version "," Version "]" ) newline .
@@ -365,22 +365,39 @@ (define (go.mod-directives go.mod directive)
 (define (go.mod-requirements go.mod)
   "Compute and return the list of requirements specified by GO.MOD."
   (define (replace directive requirements)
-    (define (maybe-replace module-path new-requirement)
-      ;; Do not allow version updates for indirect dependencies (see:
-      ;; https://golang.org/ref/mod#go-mod-file-replace).
-      (if (and (equal? module-path (first new-requirement))
-               (not (assoc-ref requirements module-path)))
-          requirements
-          (cons new-requirement (alist-delete module-path requirements))))
-
+    ;; Specification: https://golang.org/ref/mod#go-mod-file-replace
+    ;; Interesting test cases:
+    ;;   github.com/influxdata/influxdb-client-go/v2@HIDDEN
+    (log.debug "inside replace, directive ~S, requirements ~S" directive requirements)
+    (define (maybe-replace old-module-path old-version new-module-path new-version)
+      (let ((matched-entry (assoc-ref requirements old-module-path)))
+        (log.debug "inside maybe-replace, ~S ~S => ~S ~S, matched-entry ~S"
+                   old-module-path old-version new-module-path new-version matched-entry)
+        (cond ((and (equal? old-module-path new-module-path)
+                    (not matched-entry))
+               ;; "A replace directive has no effect if the module version on the left
+               ;; side is not required."
+               ;; Do not allow version updates for indirect dependencies.
+               requirements)
+              ((and matched-entry
+                    (or (not old-version)
+                        (equal? old-version new-version)))
+               (cons (list new-module-path new-version)
+                     (alist-delete old-module-path requirements)))
+              (else
+               requirements))))
+    (log.debug "toplevel directive is ~S" directive)
     (match directive
-      ((('original ('module-path module-path) . _) with . _)
+      ((('original ('module-path old-module-path) ('version old-version) ...) with)
+       (unless (null? old-version)
+         (set! old-version (first old-version)))
        (match with
-         (('with ('file-path _) . _)
-          (alist-delete module-path requirements))
-         (('with ('module-path new-module-path) ('version new-version) . _)
-          (maybe-replace module-path
-                         (list new-module-path new-version)))))))
+         (('with ('file-path _))
+          ;; Superseded by a module in a local path, so let's delete it.
+          (alist-delete old-module-path requirements))
+         (('with ('module-path new-module-path) ('version new-version))
+          (maybe-replace old-module-path old-version
+                         new-module-path new-version))))))
 
   (define (require directive requirements)
     (match directive
@@ -389,8 +406,10 @@ (define (require directive requirements)
 
   (let* ((requires (go.mod-directives go.mod 'require))
          (replaces (go.mod-directives go.mod 'replace))
-         (requirements (fold require '() requires)))
-    (fold replace requirements replaces)))
+         (requirements (fold require '() requires))
+         (result (fold replace requirements replaces)))
+    (log.debug "requires:~% ~S~%replaces:~% ~S~%result:~% ~S" requires replaces result)
+    result))
 
 ;; Prevent inlining of this procedure, which is accessed by unit tests.
 (set! go.mod-requirements go.mod-requirements)
-- 
2.35.1

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 07/10] guix: import: go: More resilience wrt network errors; add logging.
Resent-From: Attila Lendvai <attila@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 11:44:04 +0000
Resent-Message-ID: <handler.55242.B55242.165157821720761 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 55242 <at> debbugs.gnu.org
Cc: Attila Lendvai <attila@HIDDEN>
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165157821720761
          (code B ref 55242); Tue, 03 May 2022 11:44:04 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 11:43:37 +0000
Received: from localhost ([127.0.0.1]:38831 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlqwI-0005OX-6f
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 07:43:37 -0400
Received: from mail-ed1-f50.google.com ([209.85.208.50]:45616)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <attila.lendvai@HIDDEN>) id 1nlqwF-0005NB-8X
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 07:43:31 -0400
Received: by mail-ed1-f50.google.com with SMTP id be20so19512278edb.12
 for <55242 <at> debbugs.gnu.org>; Tue, 03 May 2022 04:43:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=SuK3B+RxJ2ghmZTZHTJv8kAsn1424PMUiNz8KrpJG4M=;
 b=A8ttGQFo4n4VYV/taagFKkrGYY5sqKLMPIveuHnanfytuV0YmGbCSUSwE+wAVYemXQ
 6rs8mJZG3LIJKfBR/XJPi2ekcfecjbWPCKoYX9upfVlmuEaSRoGnH3P083Z+Gx9Oi2UI
 SJ7jQ6c9IsuOjmz9aPMRWi2xnwIUgiEmsYNQgySn+tmDdg7bsRwDPSzlKhBON/ZMQxC/
 pxYVwT7mqz/r4m+sHlHORTkXqZuC3EkCqQDNSaY3OD/Oi0/kTBseT4FmvOgshPoF+zE5
 I0Ixh0rYpPi3fA9D72qcdyIlhYGdnPCf5UKQCVREfkNbyLu58rbkx0IZ1KZwVjpz3Kjb
 6mkA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=SuK3B+RxJ2ghmZTZHTJv8kAsn1424PMUiNz8KrpJG4M=;
 b=lO+xY0bhcCKbo8JWfwCwEdCpBTiyH6sWouVPMrOuOwnB+c6d1uW4yMbc9iJpILPN/L
 0w87ccbtTOImvuO3YMbapc0qBFdniTUQRtq/Ast1/CO4sQKhzcjckROfT/HJpdHlbKAL
 hmIzeEn/lK8VFUsqu3eeI+qZhlK2PQtpUQnTN0VtuUCNCub6MyyGevf3og31UnjQBGok
 34t1ZA+YMmY4XIb/ho839+gOqsdqUb/lROP9IiKAJy1qy6Gr/DAM4edpqlKonuM0czqC
 soKb4p/e2QTn3j94uAqL9+HDsYwdlIyPg2NiB91VSsPrshmTqk2VosiZh5Ejk+3yyPdq
 w6xg==
X-Gm-Message-State: AOAM5339sK/cKBwcEi2TbQQ1R0rT7boiViE8YWfLWw0TsxsAcGq26omp
 rxsXnCuTKbUA/Mgj0JDH1aVbVxGNnQo=
X-Google-Smtp-Source: ABdhPJxJLe04AocUpwUcav0J5DP9XDhmJEq8HZevXD0vKIKCAa078b5N+/7aaSActZe9oBna8VfUZQ==
X-Received: by 2002:a05:6402:35d3:b0:427:b3c7:f7f2 with SMTP id
 z19-20020a05640235d300b00427b3c7f7f2mr13231077edc.152.1651578205583; 
 Tue, 03 May 2022 04:43:25 -0700 (PDT)
Received: from lelap.local (catv-89-132-245-188.catv.fixed.vodafone.hu.
 [89.132.245.188]) by smtp.gmail.com with ESMTPSA id
 k13-20020a05640212cd00b0042617ba63d6sm7766964edx.96.2022.05.03.04.43.24
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 03 May 2022 04:43:25 -0700 (PDT)
From: Attila Lendvai <attila@HIDDEN>
Date: Tue,  3 May 2022 13:42:58 +0200
Message-Id: <20220503114301.9524-7-attila@HIDDEN>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220503114301.9524-2-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.5 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

This also adds logging statements to various parts of the go importer.

* guix/import/go.scm (go-module->guix-package*): Catch exceptions and retry in
case of network errors. Add ability to enable printing a full backtrace when
debugging.
(go-module->guix-package): Tolerate the inability to fetch the synopsis and
description.
---
 guix/import/go.scm | 104 +++++++++++++++++++++++++++++++++++++--------
 1 file changed, 86 insertions(+), 18 deletions(-)

diff --git a/guix/import/go.scm b/guix/import/go.scm
index a08005d090..6871132a70 100644
--- a/guix/import/go.scm
+++ b/guix/import/go.scm
@@ -23,7 +23,15 @@
 ;;; You should have received a copy of the GNU General Public License
 ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
 
+;;; goproxy protocol:
+;;;   https://golang.org/ref/mod#module-proxy
+;;;   https://docs.gomods.io/intro/protocol/
+;;;   https://roberto.selbach.ca/go-proxies/
+
 (define-module (guix import go)
+  #:use-module (git)
+  #:use-module (git structs)
+  #:use-module (git errors)
   #:use-module (guix build-system go)
   #:use-module (guix git)
   #:use-module (guix hash)
@@ -51,6 +59,8 @@ (define-module (guix import go)
   #:autoload   (guix build utils) (mkdir-p dump-port)
   #:autoload   (gcrypt hash) (hash-algorithm sha256)
   #:use-module (ice-9 format)
+  #:use-module (ice-9 control)
+  #:use-module (ice-9 exceptions)
   #:use-module (ice-9 match)
   #:use-module (ice-9 peg)
   #:use-module (ice-9 rdelim)
@@ -629,10 +639,14 @@ (define (go-import->module-meta content-text)
        (make-module-meta root-path (string->symbol vcs)
                          (strip-.git-suffix/maybe repo-url)))))
   ;; <meta name="go-import" content="import-prefix vcs repo-root">
-  (let* ((meta-data (http-fetch* (format #f "https://~a?go-get=1" module-path)))
+  (let* ((url (format #f "https://~a?go-get=1" module-path))
+         (meta-data (http-fetch* url #:accept-all-response-codes? #true))
          (select (sxpath `(// (meta (@ (equal? (name "go-import"))))
-                              // content))))
-    (match (select (html->sxml meta-data #:strict? #t))
+                              // content)))
+         (sxml (html->sxml meta-data #:strict? #t))
+         (selected (select sxml)))
+    (log.debug "The fetched meta-data from ~A is:~%~S" url selected)
+    (match selected
       (() #f)                           ;nothing selected
       ((('content content-text) ..1)
        (or
@@ -809,22 +823,76 @@ (define* (go-module->guix-package module-path #:key
          dependencies+versions
          dependencies))))
 
-(define go-module->guix-package*
-  (lambda args
-    ;; Disable output buffering so that the following warning gets printed
-    ;; consistently.
-    (setvbuf (current-error-port) 'none)
-    (let ((package-name (match args ((name _ ...) name))))
-      (guard (c ((http-get-error? c)
-                 (warning (G_ "Failed to import package ~s.
-reason: ~s could not be fetched: HTTP error ~a (~s).
+(define (go-module->guix-package* . args)
+  ;; Disable output buffering so that the following warning gets printed
+  ;; consistently.
+  (setvbuf (current-error-port) 'none)
+  (setvbuf (current-warning-port) 'none)
+  (let* ((package-name (match args ((name _ ...) name)))
+         ;; Use report-all-errors? for debugging purposes only, because
+         ;; e.g. getaddrinfo is not reentrant and therefore we must unwind
+         ;; before retrying.
+         (report-all-errors? #false)
+         (report-network-error
+          (lambda (reason)
+            (warning (G_ "Failing to import package ~S.
+reason: ~A.~%")
+                     package-name reason))))
+    (let loop ((attempts 0))
+      (when (> attempts 0)
+        (sleep 3)
+        (log.info "~%Retrying, attempt ~s." attempts))
+      (cond
+       ((> attempts 60)
+        (warning (G_ "Giving up on importing package ~s.
 This package and its dependencies won't be imported.~%")
-                          package-name
-                          (uri->string (http-get-error-uri c))
-                          (http-get-error-code c)
-                          (http-get-error-reason c))
-                 (values #f '())))
-        (apply go-module->guix-package args)))))
+                 package-name)
+        (values #f '()))
+       (else
+        (guard (c ((http-get-error? c)
+                   (report-network-error
+                    (format #f "~s could not be fetched: HTTP error ~a (~s)"
+                            (uri->string (http-get-error-uri c))
+                            (http-get-error-code c)
+                            (http-get-error-reason c)))
+                   (loop (+ 1 attempts)))
+                  ((eq? (exception-kind c)
+                        'getaddrinfo-error)
+                   (report-network-error "DNS lookup failed")
+                   (loop (+ 1 attempts)))
+                  ((and (eq? (exception-kind c)
+                             'git-error)
+                        (eq? (git-error-class (first (exception-args c)))
+                             GITERR_NET))
+                   (report-network-error "network error coming from git")
+                   (loop (+ 1 attempts)))
+                  (else
+                   (let ((port (current-warning-port)))
+                     (format port "Unexpected error, will skip ~S.~%reason: "
+                             package-name)
+                     ;; Printing a backtrace here is not very useful: it is
+                     ;; cut off because GUARD unwinds.
+                     (print-exception port (stack-ref (make-stack #t) 1)
+                                      c (exception-args c))
+                     (display-backtrace (make-stack #t) port))
+                   ;; give up on this entry
+                   (values #f '())))
+          (with-exception-handler
+              (lambda (c)
+                (when report-all-errors?
+                  (let ((port (current-warning-port)))
+                    (format port "*** exception while importing:~%")
+                    (print-exception port (stack-ref (make-stack #t) 1)
+                                     c (exception-args c))
+                    (format port "*** printing backtrace:~%")
+                    (display-backtrace (make-stack #t) port)
+                    ;; DISPLAY-BACKTRACE can fail, so it's better to make its
+                    ;; exit also visible.
+                    (format port "*** done printing backtrace~%")))
+                (raise-continuable c))
+            (lambda ()
+              (apply go-module->guix-package args))
+            #:unwind? (not report-all-errors?))))))))
 
 (define* (go-module-recursive-import package-name
                                      #:key (goproxy "https://proxy.golang.org")
-- 
2.35.1

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 08/10] guix: import: go: Modules in a subdir and prefixed tags.
Resent-From: Attila Lendvai <attila@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 11:44:04 +0000
Resent-Message-ID: <handler.55242.B55242.165157821820768 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 55242 <at> debbugs.gnu.org
Cc: Attila Lendvai <attila@HIDDEN>
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165157821820768
          (code B ref 55242); Tue, 03 May 2022 11:44:04 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 11:43:38 +0000
Received: from localhost ([127.0.0.1]:38833 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlqwL-0005Oo-NN
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 07:43:38 -0400
Received: from mail-ed1-f43.google.com ([209.85.208.43]:44929)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <attila.lendvai@HIDDEN>) id 1nlqwG-0005NE-A3
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 07:43:33 -0400
Received: by mail-ed1-f43.google.com with SMTP id t5so8893668edw.11
 for <55242 <at> debbugs.gnu.org>; Tue, 03 May 2022 04:43:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=zHrI7aV8BUrySjI0cC7uYm3uT3HxxRJ7k7KMlhL1Ivk=;
 b=VVSnc/QRer0/2iQeRMOdnwNYd45+j89e8Bl4nPNXZmYza2D6nAEgGI4ogfbDYWRoSZ
 zVYV+0aI9n37777HFoAkaGEnsDF2VwGDBlT4/FaiVOmPPYuMWBjWGI8joh9HGJcpBjJE
 InWCDySn3DwFmMawBjanJPThu2dDj+D/RTcoS/a2SG8FUvQo+Y/2c56QAMIqqeP0p4O6
 qkFADKDLH9Q+Hy1GkGsDc9ghUQJQUMcouZHOlaIWzX924V8pYCgbeWlwpuOA6E0hK7vb
 p0h4CxGdl6OdkVqae9rhaL76X/8PO0qXIIO39WWJXarYj4fiqbr0W6OneWIIMfUwPg+o
 0S8w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=zHrI7aV8BUrySjI0cC7uYm3uT3HxxRJ7k7KMlhL1Ivk=;
 b=n2dEAmHlhmSJqT3hoxIvjUpbu+Bj6PvUw5G18wulrZH+VqmBFn1xXINrVAlTAmGkrD
 bn2rZBBy6ZVfE8sczsJ6BNFUXy03CZjR5UkwEkkf75Nl1sOkuX4itTbcXMhPx5HxnCGI
 Lbv0c4szavoY16DAp0//J7t47KXXDlZL9gcztXK2yswul3wljJI884WUZS5OZHp/5lSi
 7kpTs9fS4X360A6mMC4kjHQzhVX0raQ3ZrijznOFKK/ZVxxZQxjxrbn1OVeNxTJBBgKO
 fbVxtAJx3D76meWXB+aBVrLimWc5mrcXxgZjUeHMnkAGg0Crua7j7jCXet1GQbliQml+
 6Uzw==
X-Gm-Message-State: AOAM530loxZ1MFihgFZaHM5xpKFK97sR4GzmQlHYTHOaUyNg/mjrswUm
 4VBSBQOLTkEl0MRliWDP8c1C98fU1cQ=
X-Google-Smtp-Source: ABdhPJwaOUjdTTXwaLEHcXHX+22GzklqhUUluRmClENkfB2bdwMPZi/cYY0M7bzkWAHfTx38TYvZUg==
X-Received: by 2002:a05:6402:90e:b0:425:a4bc:db86 with SMTP id
 g14-20020a056402090e00b00425a4bcdb86mr221768edz.98.1651578206532; 
 Tue, 03 May 2022 04:43:26 -0700 (PDT)
Received: from lelap.local (catv-89-132-245-188.catv.fixed.vodafone.hu.
 [89.132.245.188]) by smtp.gmail.com with ESMTPSA id
 k13-20020a05640212cd00b0042617ba63d6sm7766964edx.96.2022.05.03.04.43.25
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 03 May 2022 04:43:26 -0700 (PDT)
From: Attila Lendvai <attila@HIDDEN>
Date: Tue,  3 May 2022 13:42:59 +0200
Message-Id: <20220503114301.9524-8-attila@HIDDEN>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220503114301.9524-2-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.5 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

Handle golang projects that are located in a subdir relative to the repo's
root directory, and whose tags are also prefixed accordingly with the relative
path.

An example: guix import go github.com/aws/aws-sdk-go-v2/service/route53@HIDDEN

Also be more resilient while dealing with licences.

* guix/import/go.scm (go-module->guix-package): Attempt to split comma
separated lists of licences, and tolerate the inability to fetch any license
information.  Handle go modules that are a subdirectory of a vcs repo,
including the special naming of their tags (it includes the subdir as a prefix).
(list->licenses): Warn when the conversion fails.
(+known-vcs+): Renamed from known-vcs to use naming convention for constants.
---
 guix/import/go.scm | 130 +++++++++++++++++++++++++++++++++++----------
 1 file changed, 102 insertions(+), 28 deletions(-)

diff --git a/guix/import/go.scm b/guix/import/go.scm
index 6871132a70..ce6463cc51 100644
--- a/guix/import/go.scm
+++ b/guix/import/go.scm
@@ -346,6 +346,7 @@ (define (go-package-synopsis module-name)
 the https://pkg.go.dev/ web site."
   ;; Note: Only the *module* (rather than package) page has the README title
   ;; used as a synopsis on the https://pkg.go.dev web site.
+  (log.debug "Getting synopsis for ~S" module-name)
   (let* ((body (pkg.go.dev-info module-name))
          ;; Extract the text contained in a h2 child node of any
          ;; element marked with a "License" class attribute.
@@ -377,7 +378,12 @@ (define (list->licenses licenses)
                             ("GPL3" "GPL-3.0")
                             ("NIST" "NIST-PD")
                             (_ license)))
-                         'unknown-license!)))
+                         (begin
+                           (warning (G_ "Failed to identify license ~S.~%")
+                                    license)
+                           ;; This will put the license there as a string that
+                           ;; will error at compilation.
+                           license))))
               licenses))
 
 (define (fetch-go.mod goproxy module-path version)
@@ -550,7 +556,8 @@ (define-record-type <vcs>
 (define (make-vcs prefix regexp type)
   (%make-vcs prefix (make-regexp regexp) type))
 
-(define known-vcs
+;; TODO use define-constant
+(define +known-vcs+
   ;; See the following URL for the official Go equivalent:
   ;; https://github.com/golang/go/blob/846dce9d05f19a1f53465e62a304dea21b99f910/src/cmd/go/internal/vcs/vcs.go#L1026-L1087
   (list
@@ -587,16 +594,17 @@ (define vcs-qualifiers '(".bzr" ".fossil" ".git" ".hg" ".svn"))
 
   (define (vcs-qualified-module-path->root-repo-url module-path)
     (let* ((vcs-qualifiers-group (string-join vcs-qualifiers "|"))
-           (pattern (format #f "^(.*(~a))(/|$)" vcs-qualifiers-group))
-           (m (string-match pattern module-path)))
-      (and=> m (cut match:substring <> 1))))
+           (pattern (format #f "^(.*(~a))(/|$)" vcs-qualifiers-group)))
+      (and=> (string-match pattern module-path)
+             (cut match:substring <> 1))))
 
   (or (and=> (find (lambda (vcs)
                      (string-prefix? (vcs-url-prefix vcs) module-path))
-                   known-vcs)
+                   +known-vcs+)
              (lambda (vcs)
                (match:substring (regexp-exec (vcs-root-regex vcs)
-                                             module-path) 1)))
+                                             module-path)
+                                1)))
       (vcs-qualified-module-path->root-repo-url module-path)
       module-path))
 
@@ -666,6 +674,7 @@ (define (module-meta-data-repo-url meta-data goproxy)
 (define* (git-checkout-hash url reference algorithm)
   "Return the ALGORITHM hash of the checkout of URL at REFERENCE, a commit or
 tag."
+  (log.info "Fetching git repo at ~S, reference ~S" url reference)
   (define cache
     (string-append (or (getenv "TMPDIR") "/tmp")
                    "/guix-import-go-"
@@ -681,6 +690,7 @@ (define cache
                   (update-cached-checkout url
                                           #:ref
                                           `(tag-or-commit . ,reference)))))
+    (log.debug " hashing at checkout ~S, commit ~S, reference ~S" checkout commit reference)
     (file-hash* checkout #:algorithm algorithm #:recursive? #true)))
 
 (define (vcs->origin vcs-type vcs-repo-url version)
@@ -688,8 +698,10 @@ (define (vcs->origin vcs-type vcs-repo-url version)
 control system is being used."
   (case vcs-type
     ((git)
-     (let ((plain-version? (string=? version (go-version->git-ref version)))
-           (v-prefixed?    (string-prefix? "v" version)))
+     (let* ((git-ref        (go-version->git-ref version))
+            (plain-version? (string=? version git-ref))
+            (v-prefixed?    (string-prefix? "v" version)))
+       (log.debug "Version ~S converted to git reference ~S" version git-ref)
        `(origin
           (method git-fetch)
           (uri (git-reference
@@ -699,13 +711,12 @@ (define (vcs->origin vcs-type vcs-repo-url version)
                 ;; stripped of any 'v' prefixed.
                 (commit ,(if (and plain-version? v-prefixed?)
                              '(string-append "v" version)
-                             '(go-version->git-ref version)))))
+                             git-ref))))
           (file-name (git-file-name name version))
           (sha256
            (base32
             ,(bytevector->nix-base32-string
-              (git-checkout-hash vcs-repo-url (go-version->git-ref version)
-                                 (hash-algorithm sha256))))))))
+              (git-checkout-hash vcs-repo-url git-ref (hash-algorithm sha256))))))))
     ((hg)
      `(origin
         (method hg-fetch)
@@ -768,41 +779,104 @@ (define* (go-module->guix-package module-path #:key
   "Return the package S-expression corresponding to MODULE-PATH at VERSION, a Go package.
 The meta-data is fetched from the GOPROXY server and https://pkg.go.dev/.
 When VERSION is unspecified, the latest version available is used."
+  (log.info "~%Processing go module ~A@~A" module-path version)
   (let* ((available-versions (go-module-available-versions goproxy module-path))
          (version* (validate-version
                     (or (and version (ensure-v-prefix version))
                         (go-module-version-string goproxy module-path)) ;latest
                     available-versions
                     module-path))
-         (content (fetch-go.mod goproxy module-path version*))
-         (dependencies+versions (go.mod-requirements (parse-go.mod content)))
+         (go.mod (fetch-go.mod goproxy module-path version*))
+         (dependencies+versions (go.mod-requirements (parse-go.mod go.mod)))
          (dependencies (if pin-versions?
                            dependencies+versions
                            (map car dependencies+versions)))
-         (module-path-sans-suffix
-          (match:prefix (string-match "([\\./]v[0-9]+)?$" module-path)))
          (guix-name (go-module->guix-package-name module-path))
-         (root-module-path (module-path->repository-root module-path))
+         (repo-root (module-path->repository-root module-path))
          ;; The VCS type and URL are not included in goproxy information. For
          ;; this we need to fetch it from the official module page.
-         (meta-data (fetch-module-meta-data root-module-path))
+         (meta-data (fetch-module-meta-data repo-root))
+         (module-root-path (module-meta-import-prefix meta-data))
          (vcs-type (module-meta-vcs meta-data))
          (vcs-repo-url (module-meta-data-repo-url meta-data goproxy))
-         (synopsis (go-package-synopsis module-path))
-         (description (go-package-description module-path))
-         (licenses (go-package-licenses module-path)))
+         (raw-subdir (if (< (string-length module-root-path)
+                            (string-length module-path))
+                         (substring module-path
+                                    (+ 1 (string-length module-root-path)))
+                         #false))
+         (module-subdirectory raw-subdir)
+         (major-version (and=>
+                         (and raw-subdir
+                              (string-match ".*v([0-9]+)$" raw-subdir))
+                         (lambda (m)
+                           (let* ((v-postfix (match:substring m 1))
+                                  (ver (string->number v-postfix)))
+                             (log.debug " ~A matched as having a version-postfix: ~A"
+                                        raw-subdir v-postfix)
+                             (set! module-subdirectory
+                                   (substring raw-subdir 0
+                                              ;; Don't go negative when
+                                              ;; raw-subdir is a simple "v2".
+                                              (max 0
+                                                   (- (string-length raw-subdir)
+                                                      (string-length v-postfix)
+                                                      ;; Drop two slashes.
+                                                      2))))
+                             (when (string-null? module-subdirectory)
+                               (set! module-subdirectory #false))
+                             (unless (integer? ver)
+                               (raise
+                                (formatted-message (G_ "failed to parse version postfix from '~a' for package '~a'")
+                                                   raw-subdir module-path)))
+                             ;; TODO assert that major-version matches the first number in version
+                             ;; TODO assert that only version 1.x.y is allowed without a /v[major-version] postfix
+                             ver))))
+         (vcs-tag (if module-subdirectory
+                      (string-append module-subdirectory "/" version*)
+                      version*))
+         (synopsis (or (false-if-exception
+                        (go-package-synopsis module-path))
+                       (begin
+                         (warning (G_ "Failed to fetch synopsis for ~S.~%")
+                                  module-path)
+                         "TODO FIXME")))
+         (description (or (false-if-exception
+                           (go-package-description module-path))
+                          (begin
+                            (warning (G_ "Failed to fetch description for ~S.~%")
+                                     module-path)
+                            "TODO FIXME")))
+         (licenses (or (false-if-exception
+                        (go-package-licenses module-path))
+                       (begin
+                         (warning (G_ "Failed to fetch license for ~S.~%")
+                                  module-path)
+                         '("unknown-license!")))))
+    ;; Maybe split comma separated list of licenses in a single string
+    (when (and (= 1 (length licenses))
+               (string? (first licenses)))
+      (let ((pieces (map string-trim-both
+                         (remove! string-null?
+                                  (string-split (first licenses) #\,)))))
+        (when (< 1 (length pieces))
+          (set! licenses pieces))))
+    (log.debug " meta-data: ~S~% raw-subdir: ~S, module-subdirectory: ~S, \
+major-version: ~S"
+               meta-data raw-subdir module-subdirectory major-version)
+    (log.debug " dependencies:~%~S" dependencies+versions)
     (values
      `(package
         (name ,guix-name)
         (version ,(strip-v-prefix version*))
         (source
-         ,(vcs->origin vcs-type vcs-repo-url version*))
+         ,(vcs->origin vcs-type vcs-repo-url vcs-tag))
         (build-system go-build-system)
         (arguments
-         '(#:import-path ,module-path
-           ,@(if (string=? module-path-sans-suffix root-module-path)
-                 '()
-                 `(#:unpack-path ,root-module-path))))
+         '(#:tests? #false ; some packages have unrecorded dependencies needed only by their tests
+           #:import-path ,module-path
+           ,@(if module-subdirectory
+                 `(#:unpack-path ,module-root-path)
+                 '())))
         ,@(maybe-propagated-inputs
            (map (match-lambda
                   ((name version)
@@ -810,7 +884,7 @@ (define* (go-module->guix-package module-path #:key
                   (name
                    (go-module->guix-package-name name)))
                 dependencies))
-        (home-page ,(format #f "https://~a" root-module-path))
+        (home-page ,(format #f "https://~a" module-root-path))
         (synopsis ,synopsis)
         (description ,(and=> description beautify-description))
         (license ,(match (list->licenses licenses)
@@ -898,7 +972,7 @@ (define* (go-module-recursive-import package-name
                                      #:key (goproxy "https://proxy.golang.org")
                                      version
                                      pin-versions?)
-
+  (log.info "Initiating recursive import of ~a, version ~a" package-name version)
   (recursive-import
    package-name
    #:repo->guix-package
-- 
2.35.1

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 09/10] guix: import: go: module-name -> module-path to be consistent
Resent-From: Attila Lendvai <attila@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 11:44:05 +0000
Resent-Message-ID: <handler.55242.B55242.165157821820776 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 55242 <at> debbugs.gnu.org
Cc: Attila Lendvai <attila@HIDDEN>
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165157821820776
          (code B ref 55242); Tue, 03 May 2022 11:44:05 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 11:43:38 +0000
Received: from localhost ([127.0.0.1]:38835 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlqwM-0005P0-Fn
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 07:43:38 -0400
Received: from mail-ed1-f48.google.com ([209.85.208.48]:43605)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <attila.lendvai@HIDDEN>) id 1nlqwH-0005NF-25
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 07:43:33 -0400
Received: by mail-ed1-f48.google.com with SMTP id b24so19525458edu.10
 for <55242 <at> debbugs.gnu.org>; Tue, 03 May 2022 04:43:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=igWptIFJy8qnLiiMWFq7RA75L0EcJyyF4H3IxTcrB8g=;
 b=eniw7W0cXKORDKTrW10vW965ouCXrnlkTUNFn62/ZlGsWMW2o7HAFSHiKC+EHyyQRO
 eEfeViZf1v1/MTz0xG5l5Jd9+CEbBX1yC3trTFrTQUOFiUgFn+pVbI2IxJK9G1uunjdf
 tvoEkEgOxTYSqIUbtTx0AAmHQQ03FKQ4vjoQnyYmrNREHsKv8IEtg5SyR1rdgNf1b/1Y
 +NsedrRhd66an3jr0W9sBUbv/bROe+4vRj4p9SkXSTvE6EnRJr1KTCSdppoK8TkbnbTe
 gK7sBqZdFl0SAuxut9yj9yovOqaaAHCwRlXGW8Lt6zGFfDWOn+Vvw+gXZAuuJq4ZqUK9
 f+uA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=igWptIFJy8qnLiiMWFq7RA75L0EcJyyF4H3IxTcrB8g=;
 b=59so+3D7jKHpTtiLS3Cb9rYaHrjj6unwmcLZC4a82+nUXf+WjS8/Ynma3+wjKpUvWk
 iFRt9ZeoNzM5WqKefeh+fT+WEsn14f5A9fIobYblUN5e4TVaGFzDgQZ7nL3LAkukXWro
 TEq3VNZFR5a3CMKOHZMKdSn1LjS6mfALlxkkzqSS+RZwj8F9HY5Lz+X+ufSC8xdBgv4+
 wR4aufktkHcjWAZEGiW1pJX2IUVRgbKQCQD4J0MZ2UNRDXs+uEzrfq6HCrkSj1Y6plhy
 qVxCzDph+PSvybYC+GegI8abq8aApXBfoa9fEKPU7U/NQhTmKxwjibgi3O4SbWuiQKc5
 Q/lA==
X-Gm-Message-State: AOAM5338QgaZcl3z1BX8pUUFHEpMVfGEpINHOYF0MyWMKTpp3A3Sdbtp
 UsAXIW86iC/pNg1HYAq0Y1HC575/9nw=
X-Google-Smtp-Source: ABdhPJyipntZ6Y3xE5HRKuZ1GAlpxeKZFwyCost1lqn2bwRxLUvC1VNYTqmCA0zDLBcHU/BAlH/Vjg==
X-Received: by 2002:aa7:da08:0:b0:425:af3c:196a with SMTP id
 r8-20020aa7da08000000b00425af3c196amr17556627eds.69.1651578207493; 
 Tue, 03 May 2022 04:43:27 -0700 (PDT)
Received: from lelap.local (catv-89-132-245-188.catv.fixed.vodafone.hu.
 [89.132.245.188]) by smtp.gmail.com with ESMTPSA id
 k13-20020a05640212cd00b0042617ba63d6sm7766964edx.96.2022.05.03.04.43.26
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 03 May 2022 04:43:26 -0700 (PDT)
From: Attila Lendvai <attila@HIDDEN>
Date: Tue,  3 May 2022 13:43:00 +0200
Message-Id: <20220503114301.9524-9-attila@HIDDEN>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220503114301.9524-2-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.5 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

* guix/import/go.scm (go-package-description): Renamed first parameter.
---
 guix/import/go.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/guix/import/go.scm b/guix/import/go.scm
index ce6463cc51..25d424c1ac 100644
--- a/guix/import/go.scm
+++ b/guix/import/go.scm
@@ -340,14 +340,14 @@ (define (go-package-description name)
       ((p elements ...)
        (apply string-append (filter string? (map sxml->texi elements)))))))
 
-(define (go-package-synopsis module-name)
-  "Retrieve a short synopsis for a Go module named MODULE-NAME,
+(define (go-package-synopsis module-path)
+  "Retrieve a short synopsis for a Go module named MODULE-PATH,
 e.g. \"google.golang.org/protobuf\".  The data is scraped from
 the https://pkg.go.dev/ web site."
   ;; Note: Only the *module* (rather than package) page has the README title
   ;; used as a synopsis on the https://pkg.go.dev web site.
-  (log.debug "Getting synopsis for ~S" module-name)
-  (let* ((body (pkg.go.dev-info module-name))
+  (log.debug "Getting synopsis for ~S" module-path)
+  (let* ((body (pkg.go.dev-info module-path))
          ;; Extract the text contained in a h2 child node of any
          ;; element marked with a "License" class attribute.
          (select-title (sxpath
-- 
2.35.1

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 10/10] guix: import: go: Better handling of /v2 in the module path.
Resent-From: Attila Lendvai <attila@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 11:44:05 +0000
Resent-Message-ID: <handler.55242.B55242.165157821920782 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 55242 <at> debbugs.gnu.org
Cc: Attila Lendvai <attila@HIDDEN>
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165157821920782
          (code B ref 55242); Tue, 03 May 2022 11:44:05 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 11:43:39 +0000
Received: from localhost ([127.0.0.1]:38837 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlqwM-0005P3-Nu
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 07:43:39 -0400
Received: from mail-ed1-f45.google.com ([209.85.208.45]:40825)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <attila.lendvai@HIDDEN>) id 1nlqwH-0005NR-SW
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 07:43:34 -0400
Received: by mail-ed1-f45.google.com with SMTP id p18so19515047edr.7
 for <55242 <at> debbugs.gnu.org>; Tue, 03 May 2022 04:43:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=WXH0lfHok3sajpelue/NTp/Aq+/ANt0daCtjJoY8NiQ=;
 b=lW93FENB5dut+jBVYhm9T7fnoR7nq7mtSfPdoW9+hJcD/gjRtkLpp2NIGFMgcNLhHD
 orTw9vgSn/odIHFSHEwDkXCFNDfZJZ1mn5YUMM1LrU8ZmaEZW8LIMf6hu+GZ8vHR5Ha7
 +zdykBaLqacJkrAkDZjzY5XqV5FV13rmqVKLfTIitLvItbekuTmecjz36CXhs1axdNGD
 gwIjEuENysL7DT3wx+RVRUyk5YC5FKy2Ehr6xNsipX7Ijzj806ildMtSsBXTvuXaJgq2
 TnkffYzKRe6S2I4Bx1rtfcoY9gsE88kHZ2ELZPLdFJYlPVRKQSfhlN9OPWOrQ1HKJqqU
 ho6A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=WXH0lfHok3sajpelue/NTp/Aq+/ANt0daCtjJoY8NiQ=;
 b=Qeyqdf8joN+T5nUEZcX10Rvxu2x57XUH4OCIELpDLHsTyBU9K/2qUZG8oqqub3GsJc
 fqdB/jQRXPIFyyGQHYz+eCX61aRdzR4i6JW0WLDJZRhjyl+YZsBoxmEkhVWCZB7OThDy
 AIM2IW60oarMUku6mY/XfJf91Rb0JgFNshF0aLhC1rztyiikyTFhbWUUT/TB0nPjcYWU
 PLt5zOwOuDvNUYbrBSaa/sMGIrZZ8BORru77dyLwEDUMMHVrVbS85xgSlWIqoRyY2YCh
 FShIk7yyBeak2fCyPJVcBzoNcFKDUC9brRKthR8FhmlxTdeMXrNNdDePyDitof9zosJq
 1hsg==
X-Gm-Message-State: AOAM533d18uz5yS2DGt1x18iPUwRzxGb8zuGEMB1w244dUjZntWes0pH
 e1C+29nskizcaFnPFSr+7SCadFYUi/8=
X-Google-Smtp-Source: ABdhPJxq8zJKA+q8yYqWM0U0Rq5fCAP8ieqKOiSjtlctFfQzcSQwDze9NVShvyImm3Ap/AJPcJSwXg==
X-Received: by 2002:a05:6402:1f0b:b0:427:b390:2020 with SMTP id
 b11-20020a0564021f0b00b00427b3902020mr13306474edb.70.1651578208208; 
 Tue, 03 May 2022 04:43:28 -0700 (PDT)
Received: from lelap.local (catv-89-132-245-188.catv.fixed.vodafone.hu.
 [89.132.245.188]) by smtp.gmail.com with ESMTPSA id
 k13-20020a05640212cd00b0042617ba63d6sm7766964edx.96.2022.05.03.04.43.27
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 03 May 2022 04:43:27 -0700 (PDT)
From: Attila Lendvai <attila@HIDDEN>
Date: Tue,  3 May 2022 13:43:01 +0200
Message-Id: <20220503114301.9524-10-attila@HIDDEN>
X-Mailer: git-send-email 2.35.1
In-Reply-To: <20220503114301.9524-2-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.5 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

* guix/import/go.scm (module-path->repository-root): Delete version param.
(*module-path->import-path*): New mapping, initialized with a small db of
projects.
(go-module->guix-package): Return packages with #:unpack-path when needed.
---
 guix/import/go.scm | 93 +++++++++++++++++++++++++++-------------------
 1 file changed, 54 insertions(+), 39 deletions(-)

diff --git a/guix/import/go.scm b/guix/import/go.scm
index 25d424c1ac..fbed3ca88b 100644
--- a/guix/import/go.scm
+++ b/guix/import/go.scm
@@ -75,6 +75,7 @@ (define-module (guix import go)
   #:use-module (srfi srfi-26)
   #:use-module (srfi srfi-34)
   #:use-module (srfi srfi-35)
+  #:use-module (srfi srfi-71) ; let*
   #:use-module (sxml match)
   #:use-module ((sxml xpath) #:renamer (lambda (s)
                                          (if (eq? 'filter s)
@@ -608,19 +609,15 @@ (define (vcs-qualified-module-path->root-repo-url module-path)
       (vcs-qualified-module-path->root-repo-url module-path)
       module-path))
 
-(define* (go-module->guix-package-name module-path #:optional version)
-  "Converts a module's path to the canonical Guix format for Go packages.
-Optionally include a VERSION string to append to the name."
+(define* (go-module->guix-package-name module-path)
+  "Converts a module's path to the canonical Guix format for Go packages."
   ;; Map dot, slash, underscore and tilde characters to hyphens.
   (let ((module-path* (string-map (lambda (c)
                                     (if (member c '(#\. #\/ #\_ #\~))
                                         #\-
                                         c))
                                   module-path)))
-    (string-downcase (string-append "go-" module-path*
-                                    (if version
-                                        (string-append "-" version)
-                                        "")))))
+    (string-downcase (string-append "go-" module-path*))))
 
 (define (strip-.git-suffix/maybe repo-url)
   "Strip a repository URL '.git' suffix from REPO-URL if hosted at GitHub."
@@ -771,6 +768,14 @@ (define (validate-version version available-versions module-path)
 available versions:~{ ~a~}.")
                                   (map strip-v-prefix
                                        available-versions)))))))))
+(define *module-path->import-path*
+  ;; There's no other way to derive this information, at least that I know of.
+  '(("github.com/google/go-cmp" . "github.com/google/go-cmp/cmp")
+    ("github.com/sergi/go-diff" . "github.com/sergi/go-diff/diffmatchpatch")
+    ("github.com/davecgh/go-spew" . "github.com/davecgh/go-spew/spew")
+    ("github.com/beorn7/perks" . "github.com/beorn7/perks/quantile")
+    ("github.com/census-instrumentation/opencensus-proto" .
+     "github.com/census-instrumentation/opencensus-proto/gen-go")))
 
 (define* (go-module->guix-package module-path #:key
                                   (goproxy "https://proxy.golang.org")
@@ -864,38 +869,48 @@ (define* (go-module->guix-package module-path #:key
 major-version: ~S"
                meta-data raw-subdir module-subdirectory major-version)
     (log.debug " dependencies:~%~S" dependencies+versions)
-    (values
-     `(package
-        (name ,guix-name)
-        (version ,(strip-v-prefix version*))
-        (source
-         ,(vcs->origin vcs-type vcs-repo-url vcs-tag))
-        (build-system go-build-system)
-        (arguments
-         '(#:tests? #false ; some packages have unrecorded dependencies needed only by their tests
-           #:import-path ,module-path
-           ,@(if module-subdirectory
-                 `(#:unpack-path ,module-root-path)
-                 '())))
-        ,@(maybe-propagated-inputs
-           (map (match-lambda
-                  ((name version)
-                   (go-module->guix-package-name name (strip-v-prefix version)))
-                  (name
-                   (go-module->guix-package-name name)))
-                dependencies))
-        (home-page ,(format #f "https://~a" module-root-path))
-        (synopsis ,synopsis)
-        (description ,(and=> description beautify-description))
-        (license ,(match (list->licenses licenses)
-                    (() #f)                       ;unknown license
-                    ((license)                    ;a single license
-                     license)
-                    ((license ...)                ;a list of licenses
-                     `(list ,@license)))))
-     (if pin-versions?
-         dependencies+versions
-         dependencies))))
+    (let* ((import-path unpack-path
+            (if module-subdirectory
+                (values module-path module-root-path)
+                (let ((import-path (assoc-ref *module-path->import-path*
+                                              module-path)))
+                  (if import-path
+                      (begin
+                        (log.debug "matched as an import-path exception: ~S" import-path)
+                        (values import-path module-path))
+                      (values module-path #f))))))
+      (values
+       `(package
+          (name ,guix-name)
+          (version ,(strip-v-prefix version*))
+          (source
+           ,(vcs->origin vcs-type vcs-repo-url vcs-tag))
+          (build-system go-build-system)
+          (arguments
+           '(#:import-path ,import-path
+             ,@(if unpack-path
+                   `(#:unpack-path ,unpack-path)
+                   '())))
+          ,@(maybe-propagated-inputs
+             (map (match-lambda
+                    ((name version)
+                     (list (go-module->guix-package-name name)
+                           (strip-v-prefix version)))
+                    (name
+                     (go-module->guix-package-name name)))
+                  dependencies))
+          (home-page ,(format #f "https://~a" module-root-path))
+          (synopsis ,synopsis)
+          (description ,(and=> description beautify-description))
+          (license ,(match (list->licenses licenses)
+                      (() #f)                       ;unknown license
+                      ((license)                    ;a single license
+                       license)
+                      ((license ...)                ;a list of licenses
+                       `(list ,@license)))))
+       (if pin-versions?
+           dependencies+versions
+           dependencies)))))
 
 (define (go-module->guix-package* . args)
   ;; Disable output buffering so that the following warning gets printed
-- 
2.35.1

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 07/10] guix: import: go: More resilience wrt network errors; add logging.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 16:13:02 +0000
Resent-Message-ID: <handler.55242.B55242.16515943771954 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Attila Lendvai <attila@HIDDEN>, 55242 <at> debbugs.gnu.org
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.16515943771954
          (code B ref 55242); Tue, 03 May 2022 16:13:02 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 16:12:57 +0000
Received: from localhost ([127.0.0.1]:40752 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlv8z-0000VS-Ea
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 12:12:57 -0400
Received: from michel.telenet-ops.be ([195.130.137.88]:43240)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1nlv8w-0000VF-LB
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 12:12:56 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
 ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
 by michel.telenet-ops.be with bizsmtp
 id SGCs2700o4UW6Th06GCsAW; Tue, 03 May 2022 18:12:53 +0200
Message-ID: <7974a00256e3ee153507f77d6b0a405473e9bbc4.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Tue, 03 May 2022 18:12:49 +0200
In-Reply-To: <20220503114301.9524-7-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
 <20220503114301.9524-7-attila@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-ZqSygLFl7BwBCUtRFXOj"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1651594373; bh=yQXrEqdu15T3O7kyNoP487kd9BACb0qxWbnDC2V8B04=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=EGYbx8BLJV786+hLeTZLbtw2rSLdT2dLi56pB0T8d8pgW29MlISSmSGOD9ozjAzzH
 25pFSDyPL1tlkLSDcQOYFz62H/iTMLYbpJxWPOZtv8yAL2f5fddu/2dZ785psTviRr
 ytjCAKqrHlYoqYbw2bqzsvQQ7tPSVxB738IaWRF6ncNzrzBXOeyLvilg412X1qL3HW
 saIQstEvptZd0t1AxLaONvihMZcuQOk3hsB8cA8ZVo5eUceADfP5PJvTDMUz+6Cpf8
 6hOz8p9s1fPbL4geM1vdxUUn/CE8E7aQ0QnftPfBERgxP5AHV0q7a4WH5scH/ObsSX
 /NVRPyt5Jqs1g==
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--=-ZqSygLFl7BwBCUtRFXOj
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: base64

QXR0aWxhIExlbmR2YWkgc2NocmVlZiBvcCBkaSAwMy0wNS0yMDIyIG9tIDEzOjQyIFsrMDIwMF06
Cj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAobGV0ICgocG9ydCAoY3Vy
cmVudC13YXJuaW5nLXBvcnQpKSkKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoCAoZm9ybWF0IHBvcnQgIlVuZXhwZWN0ZWQgZXJyb3IsIHdpbGwgc2tpcCB+Uy5+JXJl
YXNvbjogIgo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoCBwYWNrYWdlLW5hbWUpCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqAgOzsgUHJpbnRpbmcgYSBiYWNrdHJhY2UgaGVyZSBpcyBub3QgdmVyeSB1c2Vm
dWw6IGl0IGlzCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgOzsg
Y3V0IG9mZiBiZWNhdXNlIEdVQVJEIHVud2luZHMuCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqAgKHByaW50LWV4Y2VwdGlvbiBwb3J0IChzdGFjay1yZWYgKG1ha2Ut
c3RhY2sgI3QpIDEpCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGMgKGV4Y2VwdGlvbi1hcmdzIGMpKQo+
ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChkaXNwbGF5LWJhY2t0
cmFjZSAobWFrZS1zdGFjayAjdCkgcG9ydCkpCgpXaHkgYXJlIHVua25vd24gZXJyb3JzIGJlaW5n
IGNhdGNoZWQgaGVyZT8KCkdyZWV0aW5ncywKTWF4aW1lLgo=


--=-ZqSygLFl7BwBCUtRFXOj
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnFUgRccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7mhkAQDw7mBIcVzVc1I07e0G/oj+ffOE
Bs3nRgbLD24cFdY0tQD/QP2UwSVoxTLOy9K+Sij2pqPRu5CyxhGDJUDy+L0BMws=
=vGcf
-----END PGP SIGNATURE-----

--=-ZqSygLFl7BwBCUtRFXOj--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 07/10] guix: import: go: More resilience wrt network errors; add logging.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 16:18:01 +0000
Resent-Message-ID: <handler.55242.B55242.16515946309699 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Attila Lendvai <attila@HIDDEN>, 55242 <at> debbugs.gnu.org
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.16515946309699
          (code B ref 55242); Tue, 03 May 2022 16:18:01 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 16:17:10 +0000
Received: from localhost ([127.0.0.1]:40757 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlvD3-0002W9-Ue
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 12:17:10 -0400
Received: from albert.telenet-ops.be ([195.130.137.90]:59004)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1nlvD1-0002Su-C8
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 12:17:08 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
 ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
 by albert.telenet-ops.be with bizsmtp
 id SGH52700A4UW6Th06GH57h; Tue, 03 May 2022 18:17:05 +0200
Message-ID: <ff2f84b74ecddae9e4513abc9782b544323c3501.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Tue, 03 May 2022 18:17:02 +0200
In-Reply-To: <20220503114301.9524-7-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
 <20220503114301.9524-7-attila@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-QAfLTP/nlWLUymrd7VbV"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1651594625; bh=JeFax4kjCGAJaRrYinzLAqM94bQC0swPsM8DKJBe9rQ=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=IolgIarzdWK7AD4xMrdMmi/9z6wnwRnpmP8Ijd3hBZ7MdqTyhw1Q0RW0lHna8hVZe
 jifFIPfwQMIN1oqqR7LWNoUMiXLSV9JIeH7rowZw4lpBZI8vLAzD7+lhx4ipHw2jta
 H2RiXWDd2qvacaGO2mFjUD6nq5cPQRNQxPx5oViTf15NRPw6aKKHLJHqy+p+O1IpZ8
 YU+pf9Xv/+p1j4rQf8BgOEtf/4SEqoblDMgJMQok16qQgQGDuxw2x1+WbkSN1liabI
 5TK6xgHEH2ZzVnXfOYxVGpnMd9Y9rzAXstX2H7x1/7ual/2SWpB1Y+MEU2DVBRbpKN
 s36ELy3lzBhwQ==
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--=-QAfLTP/nlWLUymrd7VbV
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: base64

QXR0aWxhIExlbmR2YWkgc2NocmVlZiBvcCBkaSAwMy0wNS0yMDIyIG9tIDEzOjQyIFsrMDIwMF06
Cj4gK8KgwqDCoMKgwqDCoMKgwqDCoCAod2l0aC1leGNlcHRpb24taGFuZGxlcgo+ICvCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoCAobGFtYmRhIChjKQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgKHdoZW4gcmVwb3J0LWFsbC1lcnJvcnM/Cj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqAgKGxldCAoKHBvcnQgKGN1cnJlbnQtd2FybmluZy1wb3J0KSkpCj4gK8Kg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChmb3JtYXQgcG9ydCAiKioqIGV4
Y2VwdGlvbiB3aGlsZSBpbXBvcnRpbmc6fiUiKQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoCAocHJpbnQtZXhjZXB0aW9uIHBvcnQgKHN0YWNrLXJlZiAobWFrZS1zdGFj
ayAjdCkgMSkKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGMgKGV4Y2VwdGlvbi1hcmdzIGMpKQo+ICvCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoZm9ybWF0IHBvcnQgIioqKiBwcmlu
dGluZyBiYWNrdHJhY2U6fiUiKQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoCAoZGlzcGxheS1iYWNrdHJhY2UgKG1ha2Utc3RhY2sgI3QpIHBvcnQpCj4gK8KgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIDs7IERJU1BMQVktQkFDS1RSQUNFIGNhbiBm
YWlsLCBzbyBpdCdzIGJldHRlciB0byBtYWtlIGl0cwo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoCA7OyBleGl0IGFsc28gdmlzaWJsZS4KPiArwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGZvcm1hdCBwb3J0ICIqKiogZG9uZSBwcmludGluZyBi
YWNrdHJhY2V+JSIpKSkKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChyYWlzZS1j
b250aW51YWJsZSBjKSkKCldoYXQncyB0aGUgJy1jb250aW51YWJsZScgZm9yIGhlcmU/ICBJcyBp
dCB0byBhdm9pZCBleHRyYSAncmFpc2UtCmV4Y2VwdGlvbicgZW50cmllcyBpbiB0aGUgYmFja3Ry
YWNlLCBvciBkb2VzIHRoaXMgYWN0dWFsbHkgbWFrZSB1c2Ugb2YKU2NoZW1lJ3MgY29udGludWFi
bGUgZXhjZXB0aW9ucz8KCkdyZWV0aW5ncywKTWF4aW1lLgo=


--=-QAfLTP/nlWLUymrd7VbV
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnFVfhccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7rwBAP9LEPY+FcRn5fv6BJAwvFmZUTHP
qk9SXSHRA3XriMrkBwD/dSJ7gTrvKmH9nOqAvnRFSaAihVAkulZtFXNGWfoBEQ4=
=DbsO
-----END PGP SIGNATURE-----

--=-QAfLTP/nlWLUymrd7VbV--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 01/10] guix: import: Print the number of packages at the end.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 16:22:01 +0000
Resent-Message-ID: <handler.55242.B55242.165159487811334 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Attila Lendvai <attila@HIDDEN>, 55242 <at> debbugs.gnu.org
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165159487811334
          (code B ref 55242); Tue, 03 May 2022 16:22:01 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 16:21:18 +0000
Received: from localhost ([127.0.0.1]:40780 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlvH4-0002wk-4m
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 12:21:18 -0400
Received: from albert.telenet-ops.be ([195.130.137.90]:37882)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1nlvH3-0002wZ-3u
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 12:21:17 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
 ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
 by albert.telenet-ops.be with bizsmtp
 id SGMF270044UW6Th06GMF4r; Tue, 03 May 2022 18:21:15 +0200
Message-ID: <15b2a5f3da980087b0a3f84910563b13a929076f.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Tue, 03 May 2022 18:21:12 +0200
In-Reply-To: <20220503111620.3139-1-attila@HIDDEN>
References: <20220503111620.3139-1-attila@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-UunKUs/YXKPXMrykXuBv"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1651594875; bh=31ZHkiFb44FVG50QWbO0+RQxSKsOUT3oqfOCeesP1HY=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=iGvO51RwrgLo24gXjFEeOCyRZupYNo7qL4ZRgo0iipLAerZ+4UwHy/sUZa9N+Sytp
 WF3lOdysaC+w5b2HeppQMrp8QT1bBZ4m/7uFuZuUIxYWY+FOa4JMH/lC6YuJAsBm+W
 JGdf/eCt27lBFvnY96q5BHTjMm9hdSg7R39YS+wCHPtXOQm5pcBGkwx6KVIXb/4D/Y
 1NJhWbBB+Az5TJxp/U+q8138zolDACQqGzTQ5HC9sl83dfh8RczXUH81OyppeclcC9
 s6Pta+gFhH3HlQe/MlJ+1E/XMZn+xKesJyUZoPlGdLRYxkZmH2pTEn0LJbh7nAdXGR
 f7wzzKQ0CBPYA==
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--=-UunKUs/YXKPXMrykXuBv
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Attila Lendvai schreef op di 03-05-2022 om 13:16 [+0200]:
> [bug#55242] [PATCH 01/10] guix: import: Print the number of packages
> at the end.
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 (format (current-warning-port)
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (G_ "Imp=
orted ~a packages~%") count)))

What's the use case for counting the number of packages?

Why only for the Go importer, and why a warning?=C2=A0

The 'info' macro from (guix diagnostics) seems to fit here (it also
uses 'current-warning-port', but only internally).

The plural form of 'packages' is incorrect when count=3D1.

Greetings,
Maxime

--=-UunKUs/YXKPXMrykXuBv
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnFWeBccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7smFAP9xcPIDwYxVWxn1g4eWCczdJkDL
oX4NmITfM829JsaebgEA6E2nWhoAFICcV5UnhywfCnYfddPprhnvDjv66kqvnAo=
=Yu5W
-----END PGP SIGNATURE-----

--=-UunKUs/YXKPXMrykXuBv--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 02/10] guix: import: go: Rename go.pkg.dev-info to pkg.go.dev-info.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 16:23:01 +0000
Resent-Message-ID: <handler.55242.B55242.165159495411471 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Attila Lendvai <attila@HIDDEN>, 55242 <at> debbugs.gnu.org
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165159495411471
          (code B ref 55242); Tue, 03 May 2022 16:23:01 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 16:22:34 +0000
Received: from localhost ([127.0.0.1]:40785 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlvII-0002yx-EA
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 12:22:34 -0400
Received: from michel.telenet-ops.be ([195.130.137.88]:59546)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1nlvIG-0002yp-Uk
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 12:22:33 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
 ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
 by michel.telenet-ops.be with bizsmtp
 id SGNX2700P4UW6Th06GNX6z; Tue, 03 May 2022 18:22:31 +0200
Message-ID: <afc2411679e7d6a34bdac1b0c8aca84c82409c3f.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Tue, 03 May 2022 18:22:28 +0200
In-Reply-To: <20220503114301.9524-2-attila@HIDDEN>
References: <20220503111620.3139-1-attila@HIDDEN>
 <20220503114301.9524-2-attila@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-/otcewnkNy1PbxML2zzl"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1651594951; bh=Jtzph/Rk2ksh1NXI5lARYkY2LS7Q/O9Jth5GvfQ5Um4=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=Zr5E/Xtfwi+bZvgH1iH+aBSrCQWZxTFB/DfN2u8CsL4xTRXFDHpGYhlq2jxLqeEuQ
 5gPwUjN1oex8M7/cZF7ULvsuCxYanscQWDLFYbTHG/mFLh/DevxkiQE+MT/Ayee9Pz
 Xcoqzy50DMXyS2+rAcBOBuvosMBfgsA32EKGC6bwtMS8+GDUNac1rxLQGap2pmWEW7
 TUj3nFosPijVV08m76V3g1KNtkAnZF9gIb+eK0ZyjhzzUqD8shaeImMCktYcqKegU7
 PuFpbkrzU2ckB/C0WMlLCN80uZbaXh4l8QPoZBSpAu5YMKMK9a90wmJ+gySxm9mbGD
 4rXUY0VLf6Oxw==
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--=-/otcewnkNy1PbxML2zzl
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Attila Lendvai schreef op di 03-05-2022 om 13:42 [+0200]:
> github

Standard capitalisation is "GitHub" here, not that it really matters
much.

Greetings,
Maxime.

--=-/otcewnkNy1PbxML2zzl
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iIwEABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnFWxBccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7iLeAPkB2KJiq2xgmDaME+zdtGWmxfNS
Wvdle6e4tChs34JNdgD1H8KVOyL1du+H87NhAOtNBp7w1yGAStoSUkpdYOQCDA==
=aZgn
-----END PGP SIGNATURE-----

--=-/otcewnkNy1PbxML2zzl--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 03/10] guix: import: go: Add mockup logging facility.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 16:24:02 +0000
Resent-Message-ID: <handler.55242.B55242.165159503611626 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Attila Lendvai <attila@HIDDEN>, 55242 <at> debbugs.gnu.org
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165159503611626
          (code B ref 55242); Tue, 03 May 2022 16:24:02 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 16:23:56 +0000
Received: from localhost ([127.0.0.1]:40790 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlvJb-00031R-NK
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 12:23:55 -0400
Received: from michel.telenet-ops.be ([195.130.137.88]:33318)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1nlvJV-00031A-QJ
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 12:23:54 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
 ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
 by michel.telenet-ops.be with bizsmtp
 id SGPo2700i4UW6Th06GPpKq; Tue, 03 May 2022 18:23:49 +0200
Message-ID: <5322f2d5dbe9e5b442c17084279d188f9c6c6f1d.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Tue, 03 May 2022 18:23:46 +0200
In-Reply-To: <20220503114301.9524-3-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
 <20220503114301.9524-3-attila@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-xIWZQoTX+dfNphYFd556"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1651595029; bh=UCgM1THE37v2sUKaqGO9NDXkdMrB6F1ao6pj25myHTU=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=lf6CIVpxtuHByf+i1fvAetGHJNQ6nEgcZyJzwuSi08Zv1noZ4YdWDtYvN+NOjmX5a
 EXEQ04QNJDy+nW9FM2v006HuuHSkAfFgMg7v2zdNuMfism5Uj6f7HEW4XVNuH5hroq
 2CLQNJaTWqqPV1iFxTOXYxbUKS6I29rTWAqh0rjnPIVLbSMl0NNumJe/niMAlZ1oD+
 gOFTPLO+WdD/le3Q55Z/7RxIyKmrtTABINAOrBps86ffmy7FtCQQdngUArYdvu7OGA
 KfqutONMKjm/LRIN7r4IW9zE/UtkbL3a1g72jnzNxcCtOMu6Z6HUEfw6iKFyFUTVou
 IRH+nD6+f3rQA==
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--=-xIWZQoTX+dfNphYFd556
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Attila Lendvai schreef op di 03-05-2022 om 13:42 [+0200]:
> +;; FIXME set up logging for the entire project, and replace this poor ma=
n's
> +;; logger with the proper one.
> +(define-syntax-rule (log.info format-string ...)
> +=C2=A0 (let ((port (current-warning-port)))
> +=C2=A0=C2=A0=C2=A0 (format port format-string ...)
> +=C2=A0=C2=A0=C2=A0 (newline port)))
> +
> +(define-syntax-rule (log.debug format-string ...)
> +=C2=A0 ;;(log.info format-string ...)
> +=C2=A0 '())

We already have a logging functionality: 'info' from
guix/diagnostics.scm.  No 'debug' yet though ...

Greetings,
Maxime.

--=-xIWZQoTX+dfNphYFd556
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnFXEhccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7pTbAQCwVTyNG23CikuzpGUeBSogPU7o
be+F8X+mTVTMTN5X/gEA1PByz5LIVERSANNoSpGtSn2gp/5C50nTNiyusnR6/AA=
=yBDF
-----END PGP SIGNATURE-----

--=-xIWZQoTX+dfNphYFd556--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 04/10] guix: import: go: Fix the interpretation of the replace directive.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 16:26:02 +0000
Resent-Message-ID: <handler.55242.B55242.165159512311851 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Attila Lendvai <attila@HIDDEN>, 55242 <at> debbugs.gnu.org
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165159512311851
          (code B ref 55242); Tue, 03 May 2022 16:26:02 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 16:25:23 +0000
Received: from localhost ([127.0.0.1]:40805 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlvL1-000354-JX
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 12:25:23 -0400
Received: from albert.telenet-ops.be ([195.130.137.90]:44620)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1nlvKz-00034u-LB
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 12:25:21 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
 ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
 by albert.telenet-ops.be with bizsmtp
 id SGRL2701E4UW6Th06GRLxz; Tue, 03 May 2022 18:25:20 +0200
Message-ID: <a73f177d4e7d8081c2b0bc0a3584ed164dde0ea6.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Tue, 03 May 2022 18:25:17 +0200
In-Reply-To: <20220503114301.9524-4-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
 <20220503114301.9524-4-attila@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-d+B5/ED7ti2aUfWP4QYG"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1651595120; bh=BCZJ44pwgHGWU8yA/mfeJMVY92yQdrYIr5a6zS7/2BE=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=T1X5B3GWlz3qg4gprY30CjIh2z/WPtZGYX7fo/xzlbG4tqLnWJCNFpcJOpMXYReSq
 lcLXNPj5CbGl5xOb67S99cHugy1xITHdIpDx9Hpy8Gu+XjJrvbsaGYdUaA+ZnOrWMa
 uuSp1lyT10YAerw3mL/eG9q81y4utrbB8igH1NISG8kgZ4UYq+j0iEDzMOHVexl6MT
 NQ9yFF49wJUFhoje+Vad0asVH2Bt7Bpz8uXd1FTnJNypPxJZbQAXA9R3nNhSEg83Qh
 1xim4P/CkkenJnCcDgCHoqlRXcPTDobzq3OJc1rMTMWDcneJtcelBD2i+gXgve3pUV
 Z77xo7VtK8M3Q==
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--=-d+B5/ED7ti2aUfWP4QYG
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Attila Lendvai schreef op di 03-05-2022 om 13:42 [+0200]:
> +=C2=A0=C2=A0=C2=A0 ;; Specification: https://golang.org/ref/mod#go-mod-f=
ile-replace
> +=C2=A0=C2=A0=C2=A0 ;; Interesting test cases:
> +=C2=A0=C2=A0=C2=A0 ;;=C2=A0=C2=A0 github.com/influxdata/influxdb-client-=
go/v2@HIDDEN
> +=C2=A0=C2=A0=C2=A0 (log.debug "inside replace, directive ~S, requirement=
s ~S" directive requirements)

You can use 'pk' for this:

  #;(pk "inside replace, directive" directive "requirements" requirements)

(delete 'pk' when debugging).

Greetings,
Maxime.

--=-d+B5/ED7ti2aUfWP4QYG
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnFXbRccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7oRlAQDMlFXyvv5xEzLB9C7d5S8en0Ym
ty720Ip5MhVTEw6omwD/TBPvThevt5iBFTY7dYUzhf1ReVB67Gcih4DCwy81VwQ=
=6SDX
-----END PGP SIGNATURE-----

--=-d+B5/ED7ti2aUfWP4QYG--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 04/10] guix: import: go: Fix the interpretation of the replace directive.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 16:27:01 +0000
Resent-Message-ID: <handler.55242.B55242.165159518111965 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Attila Lendvai <attila@HIDDEN>, 55242 <at> debbugs.gnu.org
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165159518111965
          (code B ref 55242); Tue, 03 May 2022 16:27:01 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 16:26:21 +0000
Received: from localhost ([127.0.0.1]:40810 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlvLw-00036v-Sg
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 12:26:21 -0400
Received: from albert.telenet-ops.be ([195.130.137.90]:44620)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1nlvLv-00034u-9n
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 12:26:19 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
 ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
 by albert.telenet-ops.be with bizsmtp
 id SGSJ2700K4UW6Th06GSJFX; Tue, 03 May 2022 18:26:18 +0200
Message-ID: <5252c8ff3e4373ab50553dd686fb6b9c7e9aed95.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Tue, 03 May 2022 18:26:15 +0200
In-Reply-To: <20220503114301.9524-4-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
 <20220503114301.9524-4-attila@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-Ew6ruI3xXlF1sPXC9Q67"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1651595178; bh=Lh7eovlZqNq1gKTmIFffBi3D9netbi/oYBpHY2n06bI=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=RGaCj/IMhNRDjT2Pgx6qaQMf47Lisa2w4PytjSmLvoTtGZwvpemK1z2M+0SFEl2jn
 f2jAA8qaztbbGQ8JzwWydDeN4mla44P+ViECqfJGXjy1Pow0wOuBtPVVVsH9147E6g
 cokvUVHEgan9sddPKDmOJI0JrkN4RcVlnR1/zyK7TflcHtijlbyy13mu6Sk0wLcI16
 K3v6x6sbqjj5z46Vsu7NCUQNvnYrcycXDlOqwkRK3ALYT1+sw9g5DSZjldUtLEXM1L
 Xt+6V/it9ja+dHex6eqv3SvAAicHDO7Xg9l6R3wbIVipaGWcJNp8G3w9+IPYxdyoVV
 +BArrBtb1AaRw==
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--=-Ew6ruI3xXlF1sPXC9Q67
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: base64

QXR0aWxhIExlbmR2YWkgc2NocmVlZiBvcCBkaSAwMy0wNS0yMDIyIG9tIDEzOjQyIFsrMDIwMF06
Cj4gK8KgwqDCoCAoZGVmaW5lIChtYXliZS1yZXBsYWNlIG9sZC1tb2R1bGUtcGF0aCBvbGQtdmVy
c2lvbiBuZXctbW9kdWxlLXBhdGggbmV3LXZlcnNpb24pCj4gK8KgwqDCoMKgwqAgKGxldCAoKG1h
dGNoZWQtZW50cnkgKGFzc29jLXJlZiByZXF1aXJlbWVudHMgb2xkLW1vZHVsZS1wYXRoKSkpCj4g
K8KgwqDCoMKgwqDCoMKgIChsb2cuZGVidWcgImluc2lkZSBtYXliZS1yZXBsYWNlLCB+UyB+UyA9
PiB+UyB+UywgbWF0Y2hlZC1lbnRyeSB+UyIKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgIG9sZC1tb2R1bGUtcGF0aCBvbGQtdmVyc2lvbiBuZXctbW9kdWxlLXBhdGggbmV3
LXZlcnNpb24gbWF0Y2hlZC1lbnRyeSkKPiArwqDCoMKgwqDCoMKgwqAgKGNvbmQgKChhbmQgKGVx
dWFsPyBvbGQtbW9kdWxlLXBhdGggbmV3LW1vZHVsZS1wYXRoKQo+ICvCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAobm90IG1hdGNoZWQtZW50cnkpKQo+ICvCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgIDs7ICJBIHJlcGxhY2UgZGlyZWN0aXZlIGhhcyBubyBlZmZlY3Qg
aWYgdGhlIG1vZHVsZSB2ZXJzaW9uIG9uIHRoZSBsZWZ0Cj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgOzsgc2lkZSBpcyBub3QgcmVxdWlyZWQuIgo+ICvCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgIDs7IERvIG5vdCBhbGxvdyB2ZXJzaW9uIHVwZGF0ZXMgZm9yIGluZGlyZWN0IGRl
cGVuZGVuY2llcy4KPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXF1aXJlbWVudHMp
Cj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICgoYW5kIG1hdGNoZWQtZW50cnkKPiArwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKG9yIChub3Qgb2xkLXZlcnNpb24p
Cj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGVxdWFs
PyBvbGQtdmVyc2lvbiBuZXctdmVyc2lvbikpKQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgIChjb25zIChsaXN0IG5ldy1tb2R1bGUtcGF0aCBuZXctdmVyc2lvbikKPiArwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoYWxpc3QtZGVsZXRlIG9sZC1tb2R1bGUt
cGF0aCByZXF1aXJlbWVudHMpKSkKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGVsc2UK
PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXF1aXJlbWVudHMpKSkpCgpUaGVyZSdz
IHNvbWUgZXh0cmEgY29tcGxleGl0eSBoZXJlLCBzbyBJIHJlY29tbWVuZCBzb21lIGNvcnJlc3Bv
bmRpbmcKZXh0cmEgdGVzdHMsIHRvIGF2b2lkIGl0IGJyZWFraW5nIGluIHRoZSBmdXR1cmUuCgpH
cmVldGluZ3MsCk1heGltZS4K


--=-Ew6ruI3xXlF1sPXC9Q67
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnFXpxccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7nYXAQDT+BC9OyC5u60sbdg4X+OLmxaJ
jEZNyJXUcCqZCpGiAgD/Y5amn1yDxlLxcYnAvt+lA4yat+RG4nd2OKvd2g9KYQE=
=0F8r
-----END PGP SIGNATURE-----

--=-Ew6ruI3xXlF1sPXC9Q67--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 04/10] guix: import: go: Fix the interpretation of the replace directive.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 16:28:02 +0000
Resent-Message-ID: <handler.55242.B55242.165159524312087 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Attila Lendvai <attila@HIDDEN>, 55242 <at> debbugs.gnu.org
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165159524312087
          (code B ref 55242); Tue, 03 May 2022 16:28:02 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 16:27:23 +0000
Received: from localhost ([127.0.0.1]:40815 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlvMx-00038t-5t
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 12:27:23 -0400
Received: from laurent.telenet-ops.be ([195.130.137.89]:47082)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1nlvMv-00038j-Nf
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 12:27:22 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
 ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
 by laurent.telenet-ops.be with bizsmtp
 id SGTK2700b4UW6Th01GTLtK; Tue, 03 May 2022 18:27:20 +0200
Message-ID: <46d5aa1aa8868e449e62a528c286d6803aa7c0e9.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Tue, 03 May 2022 18:27:16 +0200
In-Reply-To: <20220503114301.9524-4-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
 <20220503114301.9524-4-attila@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-jblbe3uO6xvNebqohh02"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1651595240; bh=b1Tc0Uq6DwRrjSvOBKRgw6abg5UPadH63xWg58jSnEw=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=BtkQI71+rMjnCL06hqCnNLqEVgOwzmbcBhZPQboYaMe5KIVZHczxY2nB99jDVWPKT
 mGjkKB+fzf9bGm6SrnP6VXnXv8nMNwtegKCH5hQGcEHuprkQX7uSBhfcN8WWCGR1fw
 dMStHfQ3l1hStOicv/eKKYia1J22GvCrs/bPGni8xJu1DSnO8AOJGF1R2xXaZAYxLq
 pwCEcID7nJyLu9k8P+fI8r7Wf4P1VXtDEa/RyHaHIBPDYpOsZjMsNdqDmFaJ8oVSPU
 TJ6rnkvzl1FZCMVzR96RI/Z8CwFZ2tG/uY7a0N9Fz8lQFS4Ylqdc5yDc9BE7EbomoJ
 cfcZ/8ChOtj4w==
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--=-jblbe3uO6xvNebqohh02
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Attila Lendvai schreef op di 03-05-2022 om 13:42 [+0200]:
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (unless (null? old-version)

How can a version be a list?

Greetings,
Maxime.

--=-jblbe3uO6xvNebqohh02
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnFX5BccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7vJHAQD7oPar7Qdjmg6196hP8CcljWle
ofiHgaZkUsTNyDSN+AD+NooHsEyRlz9BucJA1k+r2CefVlMAXabPafEqtiAI/ww=
=Io3b
-----END PGP SIGNATURE-----

--=-jblbe3uO6xvNebqohh02--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 04/10] guix: import: go: Fix the interpretation of the replace directive.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 16:29:01 +0000
Resent-Message-ID: <handler.55242.B55242.165159530712201 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Attila Lendvai <attila@HIDDEN>, 55242 <at> debbugs.gnu.org
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165159530712201
          (code B ref 55242); Tue, 03 May 2022 16:29:01 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 16:28:27 +0000
Received: from localhost ([127.0.0.1]:40820 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlvNz-0003Ai-EV
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 12:28:27 -0400
Received: from albert.telenet-ops.be ([195.130.137.90]:49384)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1nlvNx-0003AY-Ld
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 12:28:25 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
 ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
 by albert.telenet-ops.be with bizsmtp
 id SGUQ2700K4UW6Th06GUQf1; Tue, 03 May 2022 18:28:25 +0200
Message-ID: <619bfc4fb252b256b34af2305e1282c63a3c5d4c.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Tue, 03 May 2022 18:28:21 +0200
In-Reply-To: <20220503114301.9524-4-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
 <20220503114301.9524-4-attila@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-jYEPj6qFs5Af1LCEELrD"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1651595305; bh=0J+2BKPbKpy12WGEAE0jlh0GJG+zSFtKVJbU/YB+G0o=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=M2Y0eq8wTNOZjdrKjdRSrtuwJfb+nQXeIRh8iABlSzWLrABf3uYIAAe8VZYLb8Ve/
 lmro8OsgF84HoAJ7EZAdp2NvR05nYVKTckT2qfDKgTQ5gGnRVBSwmQwElhiGDubxDA
 XQC6FLXwX6VPuzfL8/3IiJIv/oVoF18lfaxoznuIJkOFEydm5f4y04dTyH7uSCVDf4
 YEKRiQbUPIjg+JaoW63CTP0RfOfmGDkQCAXZwB6vRw2sfNxhmjwmjkZZ8TSLm5rJqt
 68aIQVtvjIi7v/kiXrCFFXN0Q7aFKscTmAz+D8GdtYZIo8/a5uWTO5K8li0efT5RkQ
 2ZGaS7qzndKgQ==
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--=-jYEPj6qFs5Af1LCEELrD
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Attila Lendvai schreef op di 03-05-2022 om 13:42 [+0200]:
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (unless (null? old-version)
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (set! old-version (firs=
t old-version)))

Nevermind, there's some ...

Still, why choose the first old-version instead of the latest old-
version?  How can we know which one is correct?.

--=-jYEPj6qFs5Af1LCEELrD
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnFYJRccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7sVYAP0Q1IiuxcKNwPM1OmL0yloR2lRf
ctZP5JN0uoDbYLu2UwEA8ep0ZmGKSZMgjexPcP9rwE7DVfd6jGiyFn6ns1Te4Qs=
=vFx0
-----END PGP SIGNATURE-----

--=-jYEPj6qFs5Af1LCEELrD--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 05/10] guix: import: go: Harden sxml->texi conversion.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 16:34:01 +0000
Resent-Message-ID: <handler.55242.B55242.165159558521162 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Attila Lendvai <attila@HIDDEN>, 55242 <at> debbugs.gnu.org
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165159558521162
          (code B ref 55242); Tue, 03 May 2022 16:34:01 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 16:33:05 +0000
Received: from localhost ([127.0.0.1]:40837 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlvSS-0005VG-Uz
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 12:33:05 -0400
Received: from michel.telenet-ops.be ([195.130.137.88]:47344)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1nlvSR-0005V6-IW
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 12:33:04 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
 ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
 by michel.telenet-ops.be with bizsmtp
 id SGZ12700t4UW6Th06GZ1Pj; Tue, 03 May 2022 18:33:02 +0200
Message-ID: <646875155b87dbd5bff76f1f3ddbbdb50abd627f.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Tue, 03 May 2022 18:32:58 +0200
In-Reply-To: <20220503114301.9524-5-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
 <20220503114301.9524-5-attila@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-d3IWyyQ4+aCtUH3+RR62"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1651595582; bh=1TEEkfr3mK5N1Mz2/4TIEpVo9Oz+qi9YQveKGUVz6mc=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=BiTPAycabXOx8IByWr/mq3Lo1nYkbqbqgygkzMD67jT3fts4pC7wigZFDNtKlSq73
 pEHAIgkTfL+3WCIxl9NbRAmwamPnoUJajZCPNLSWiA56SyDg2o+f+qhl6KqMXBR9bA
 niT7ksjL0tYCKO6yW/AEiZdJYNOXwozZK1FpF4spigXvpuD42K6GaHjpnn2iqnkNkw
 MfuVib8uisJ6SJU5LQ/31SpgAW3Cyx6iLZVDGP6QWKBmPhk8yn24d5dbmROmnpIfBf
 G/BA9u1V0d5uHgZywvQ0aq/ro6KDSIzDCQCEphkHD+DuN/hrnvvgTjdEKK7ASJg8aO
 +gN/xwh2kKx2A==
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--=-d3IWyyQ4+aCtUH3+RR62
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: base64

QXR0aWxhIExlbmR2YWkgc2NocmVlZiBvcCBkaSAwMy0wNS0yMDIyIG9tIDEzOjQyIFsrMDIwMF06
Cj4gwqDCoCAoc3htbC1tYXRjaCBzeG1sLW5vZGUKPiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqAgKChzdHJvbmcgLHRleHQpCj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGZvcm1h
dCAjZiAiQHN0cm9uZ3t+YX0iIHRleHQpKQo+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAo
KGEgKEAgKGhyZWYgLHVybCkpICx0ZXh0KQo+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
IChmb3JtYXQgI2YgIkB1cmx7fmEsfmF9IiB1cmwgdGV4dCkpCj4gLcKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgICgoY29kZSAsdGV4dCkKPiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAo
Zm9ybWF0ICNmICJAY29kZXt+YX0iIHRleHQpKQo+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oCAoLHNvbWV0aGluZy1lbHNlIHNvbWV0aGluZy1lbHNlKSkpCj4gK8KgwqDCoCAoKHN0cm9uZyAs
dGV4dCkKPiArwqDCoMKgwqAgKGZvcm1hdCAjZiAiQHN0cm9uZ3t+YX0iIHRleHQpKQoKRG8gd2Ug
a25vdyBmb3Igc3VyZSBoZXJlIHRoYXQgJ3RleHQnIGlzIGFjdHVhbGx5IGEgc3RyaW5nPyAgV2hh
dCBpZiB0aGUKaW5wdXQgd2FzIChzdHJvbmcgKGVtIChhIChocmVmICJodHRwOi8vc3VwZXIiKSAi
U3VwZXIiKSBlbXBoYXNpcyIpPwoKPiArwqDCoMKgICgoYSAoQCAoaHJlZiAsdXJsKSkgLGJvZHkp
Cj4gK8KgwqDCoMKgIDs7IEV4YW1wbGVzOiBpbWFnZSBpbiB0aGUgdXJsOiBnaXRodWIuY29tL2dv
LW9wZW5hcGkvanNvbnBvaW50ZXIKPiArwqDCoMKgwqAgOzsgKGNvZGUgLi4uKSBpbiB0aGUgVVJM
IGJvZHk6IGdpdGh1Yi5jb20vbXdpdGtvdy9nby1jb25udHJhY2sKPiArwqDCoMKgwqAgKGlmIChz
dHJpbmc/IGJvZHkpCj4gK8KgwqDCoMKgwqDCoMKgwqAgKGZvcm1hdCAjZiAiQHVybHt+YSx+YX0i
IHVybCBib2R5KQo+ICvCoMKgwqDCoMKgwqDCoMKgIChzeG1sLW1hdGNoIGJvZHkKPiArwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoKGNvZGUgLHRleHQpCj4gK8KgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoZm9ybWF0ICNmICJAdXJse35h
LH5hfSIgdXJsIChzeG1sLT50ZXhpIGJvZHkpKSkKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoCAoLF8KCkknbSBub3QgZmFtaWxpYXIgZW5vdWdoIHdpdGggc3htbCB0
byBiZSBzdXJlLCBidXQgbWF5YmUgdGhlICwgY2FuIGJlCnJlbW92ZWQgaGVyZS4KCj4gK8KgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoZm9ybWF0ICNmICJAdXJse35h
fSIgdXJsKSkpKSkKPiArwqDCoMKgICgoY29kZSAsdGV4dCkKPiArwqDCoMKgwqAgKGZvcm1hdCAj
ZiAiQGNvZGV7fmF9IiB0ZXh0KSkKPiArwqDCoMKgICgsc29tZXRoaW5nLWVsc2UKPiArwqDCoMKg
wqAgOzsgRXhhbXBsZTogQCBpbiB0aGUgZGVzY3JpcHRpb246IGdpdGh1Yi5jb20vZXRoZXJzcGhl
cmUvbGFuZ29zCj4gK8KgwqDCoMKgIChpZiAoc3RyaW5nPyBzb21ldGhpbmctZWxzZSkKPiArwqDC
oMKgwqDCoMKgwqDCoCAoc3RyaW5nLXJlcGxhY2Utc3Vic3RyaW5nIHNvbWV0aGluZy1lbHNlCj4g
K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgICJAIiAiQEAiKQo+ICvCoMKgwqDCoMKgwqDCoMKgIHNvbWV0aGluZy1lbHNl
KSkpKQoKQW55d2F5LCBtb3JlIGNhc2VzIGFyZSBuaWNlLCBidXQgSSByZWNvbW1lbmQgdGVzdHMu
CgpHcmVldGluZ3MsCk1heGltZS4K


--=-d3IWyyQ4+aCtUH3+RR62
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnFZOhccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7nccAPkBhs4PVtSOOIlR7jlsXFm+KMgY
Lv4H8UGMrsMjVliT7QEA27Fpxebn2NKs2CWvCsEP7wgHVyrbyDC1bAIggkJfCgo=
=4yaz
-----END PGP SIGNATURE-----

--=-d3IWyyQ4+aCtUH3+RR62--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 07/10] guix: import: go: More resilience wrt network errors; add logging.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 16:37:02 +0000
Resent-Message-ID: <handler.55242.B55242.165159579721492 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Attila Lendvai <attila@HIDDEN>, 55242 <at> debbugs.gnu.org
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165159579721492
          (code B ref 55242); Tue, 03 May 2022 16:37:02 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 16:36:37 +0000
Received: from localhost ([127.0.0.1]:40842 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlvVt-0005aa-FX
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 12:36:37 -0400
Received: from albert.telenet-ops.be ([195.130.137.90]:34540)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1nlvVr-0005aQ-Gr
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 12:36:36 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
 ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
 by albert.telenet-ops.be with bizsmtp
 id SGca270014UW6Th06GcaV1; Tue, 03 May 2022 18:36:34 +0200
Message-ID: <724a0beb49e2854b5efe1a5069f11911b616cad9.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Tue, 03 May 2022 18:36:31 +0200
In-Reply-To: <20220503114301.9524-7-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
 <20220503114301.9524-7-attila@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-MFLCwRFDzsOWSl83oeah"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1651595794; bh=VPYN3fWrKH7Xh1NgijmBXKV+/7Ne5HxZJg6uhCFhv+A=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=Q6C1D58vDYt3rt5NWfT/cxUqUHoOuvCRt0VaWe7uj8ZKeIkhf1ct9zZxWyLTAaUjj
 XYnuDsxrWMU+QIzco56bvB4NdWV+3wIU2Ag6QwY8snb61TynHwKp3csT33fxOF0NG3
 VWs/IhZKKQKFd7W95TGrNciDQju+5I1oU62GNpnZcE/WxTkKwS1JnLxjqj7eslv4pE
 lInz2wcdghHCurot7jr59+dRI53oyVHTZBoCLSOMdb745MwFnnsz/ehTVWZ7xh612T
 YULfhwQAY9k+F0Vp8UOQgJzsv9j2m/Q993/mLZuPHdGzzjSFf5qjX+rV6p3oNlYSNv
 wa1Cq39dr96Kw==
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--=-MFLCwRFDzsOWSl83oeah
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Attila Lendvai schreef op di 03-05-2022 om 13:42 [+0200]:
> * guix/import/go.scm (go-module->guix-package*): Catch exceptions and ret=
ry in
> case of network errors. Add ability to enable printing a full backtrace w=
hen
> debugging.
> (go-module->guix-package): Tolerate the inability to fetch the synopsis a=
nd
> description.

Ok, but couldn't this be done more generally, for all importers using
HTTP?  E.g., could we have a variant 'http-fetch/retrying' of 'http-
fetch' that automatically retries a number of times?  Then the retrying
functionality could almost trivially be used in other HTTP-using
importers as well.

Greetings,
Maxime.

--=-MFLCwRFDzsOWSl83oeah
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnFaDxccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7jaAAQC3g7zni1ahy4ss9v4jnTwxHhYU
JckLdSa6gKTTY+BsywD5ATKyWslMVKLID30o/t4mRGv6VxO1N+oVwxa1QN4BUgI=
=8yVk
-----END PGP SIGNATURE-----

--=-MFLCwRFDzsOWSl83oeah--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 07/10] guix: import: go: More resilience wrt network errors; add logging.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 16:38:01 +0000
Resent-Message-ID: <handler.55242.B55242.165159583021578 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Attila Lendvai <attila@HIDDEN>, 55242 <at> debbugs.gnu.org
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165159583021578
          (code B ref 55242); Tue, 03 May 2022 16:38:01 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 16:37:10 +0000
Received: from localhost ([127.0.0.1]:40847 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlvWQ-0005by-NQ
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 12:37:10 -0400
Received: from laurent.telenet-ops.be ([195.130.137.89]:34790)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1nlvWO-0005bo-Hc
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 12:37:08 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
 ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
 by laurent.telenet-ops.be with bizsmtp
 id SGd7270054UW6Th01Gd78t; Tue, 03 May 2022 18:37:07 +0200
Message-ID: <ff7e50d5ec0e717a3ac78178e61290faf0719b4d.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Tue, 03 May 2022 18:37:04 +0200
In-Reply-To: <20220503114301.9524-7-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
 <20220503114301.9524-7-attila@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-5sTfObmR4nfBIiYH7xqe"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1651595827; bh=YhTC0i2o6thzl5AwqVR7wpQJT7mAJmMkrxwz5GNoaYg=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=mTTAEMx+ehV3EeCG1RfgbglPZZzVvhkw5vlBhTm15aqVFxxaC1Z6N6Q5W3m6ml+f0
 0hLIYr1s+D/cEdLKARRPHYYRVhluPiP0pgA516MmFfQCWkqrW7lrN57ZEBS0QI8ZJV
 W7pKelq00vXmTRM5MXCbbek2sOtzU/J0p5lxi8vCBjNPDpBbDgrddFU0S51XnUhrWt
 LxzWapKENi07piB+sddn5z7hU4MMWNzZqlT+8yZ13Oh1T6ubZonmfG52bZnoLxZugA
 vR1anO+G3ob19OKF2AeJFu5TOLBxGjRmzjs880kLtGsi/0tAmfbbk3xKRqztFfsVbH
 c1pVSkRpqY+rA==
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--=-5sTfObmR4nfBIiYH7xqe
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Attila Lendvai schreef op di 03-05-2022 om 13:42 [+0200]:
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (warn=
ing (G_ "Failing to import package ~S.
> +reason: ~A.~%")

Why a warning instead of a 'report-error'?

Greetings,
Maxime.

--=-5sTfObmR4nfBIiYH7xqe
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnFaMBccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7mmEAP9ZKs569BMvh6GKZExnx0b5HtkY
WqbfQ9YXxq9hC6VTJQEAi/O9egV1S5LQlukIW+sL8Hwwm9GduRwflpWCmiUAJQI=
=Cf8y
-----END PGP SIGNATURE-----

--=-5sTfObmR4nfBIiYH7xqe--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 08/10] guix: import: go: Modules in a subdir and prefixed tags.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 16:43:02 +0000
Resent-Message-ID: <handler.55242.B55242.165159614222110 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Attila Lendvai <attila@HIDDEN>, 55242 <at> debbugs.gnu.org
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165159614222110
          (code B ref 55242); Tue, 03 May 2022 16:43:02 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 16:42:22 +0000
Received: from localhost ([127.0.0.1]:40856 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlvbS-0005kY-K7
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 12:42:22 -0400
Received: from michel.telenet-ops.be ([195.130.137.88]:34036)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1nlvbQ-0005kP-Gy
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 12:42:21 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
 ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
 by michel.telenet-ops.be with bizsmtp
 id SGiJ2700n4UW6Th06GiKWi; Tue, 03 May 2022 18:42:19 +0200
Message-ID: <4a6bd86252c50d3302ae3bd4818071f26112ef6b.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Tue, 03 May 2022 18:42:18 +0200
In-Reply-To: <20220503114301.9524-8-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
 <20220503114301.9524-8-attila@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-jKyut6Lad45HvrUbLJWW"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1651596139; bh=xj06kfWXFGXT6Iqj98iX77hYQDVmWDklTkxXRAiVH2Y=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=LDTOLqmtkWROevd6A6tXmM3KMAkOMcA7kT7SRw1+w3K2Oqh44iChCVK7YjO21sLG4
 Bim9Dv3wxGaIk4zSAvrVbCnTUDSPP1pQloV6vNTc1lT8IKr+grimdvo/u8q0K52JrY
 aODLMyYnp6Nka+Z5qXi8pX+G9E6jn+Hm6Rkb9yHxOKAy2BAxMpcsSnSt6G9cFPQddS
 tZfGhXsSW7X4ZaeTG5mOJo5ByFJ454QpjbUAQEoo5xBjl2vmOjnE6QnDUDIGR6EHOK
 mnhHqS1WJVZGCmUl2sfdaXvGCmUoOeSz6VP299qPhrNFeW1dQ3es+yNsiZaO3+OogC
 pApZJJFRaOsRw==
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--=-jKyut6Lad45HvrUbLJWW
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: base64

QXR0aWxhIExlbmR2YWkgc2NocmVlZiBvcCBkaSAwMy0wNS0yMDIyIG9tIDEzOjQyIFsrMDIwMF06
Cj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAndW5r
bm93bi1saWNlbnNlISkpKQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqAgKGJlZ2luCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqAgKHdhcm5pbmcgKEdfICJGYWlsZWQgdG8gaWRlbnRpZnkgbGljZW5z
ZSB+Uy5+JSIpCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgbGljZW5zZSkKCldoeSBvbmx5IGZvciB0aGUgR28g
aW1wb3J0ZXIgYW5kIG5vdCBvdGhlciBpbXBvcnRlcnM/Ck1heWJlIHRoZSBiZWhhdmlvdXIgb2Yg
b3RoZXIgaW1wb3J0ZXJzIGluIHByZXNlbmNlIG9mIHVuaWRlbnRpZmlhYmxlCmxpY2Vuc2VzIGNv
dWxkIGJlIHVuaWZpZWQsIHdpdGggc29tZSBjb21tb24gc3VwcG9ydCBwcm9jZWR1cmUgb3IKc29t
ZXRoaW5nLiAgVGhlbiBvbmx5IGEgc2luZ2xlIGxvY2F0aW9uIG5lZWRzIHRvIGJlIG1vZGlmaWVk
IHRvIGNoYW5nZQp0aGluZ3MsIGFuZCBhbGwgaW1wb3J0ZXJzIHdvdWxkIGJlbmVmaXQuCgo+ICvC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIDs7IFRo
aXMgd2lsbCBwdXQgdGhlIGxpY2Vuc2UgdGhlcmUgYXMgYSBzdHJpbmcgdGhhdAo+ICvCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIDs7IHdpbGwgZXJy
b3IgYXQgY29tcGlsYXRpb24uCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqAgbGljZW5zZSkpKSkKCkkgZG9uJ3QgdGhpbmsgdGhpcyBpcyBjb3Jy
ZWN0LCBpbiB0aGUgcGFzdCBJJ3ZlIHB1dCAnKGZvb2JhcikgYW5kCiNmYWxzZSBpbiAnbGljZW5z
ZScgZmllbGRzIG9mIHBhY2thZ2VzIGFuZCB0aG9zZSBwYWNrYWdlcyBjb3VsZCBiZQpjb21waWxl
ZCwgd2l0aG91dCBhbnkgY29tcGlsYXRpb24gaXNzdWVzLiAgSSBhc3N1bWUgdGhlIHNhbWUgaG9s
ZHMgZm9yCnN0cmluZ3MgYXMgd2VsbC4KCkdyZWV0aW5ncywKTWF4aW1lLgo=


--=-jKyut6Lad45HvrUbLJWW
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnFbahccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7mIlAQCph1mw1I+bQ41s51ekfzUNFC2n
8t7+O2CIYavUwVg+KQEA1QNhG15Apod4z8ug64DQhoJ2LX7N/0PjwLmkmBO8rQ8=
=RqKc
-----END PGP SIGNATURE-----

--=-jKyut6Lad45HvrUbLJWW--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 08/10] guix: import: go: Modules in a subdir and prefixed tags.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 16:49:02 +0000
Resent-Message-ID: <handler.55242.B55242.165159649122870 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Attila Lendvai <attila@HIDDEN>, 55242 <at> debbugs.gnu.org
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165159649122870
          (code B ref 55242); Tue, 03 May 2022 16:49:02 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 16:48:11 +0000
Received: from localhost ([127.0.0.1]:40865 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlvh5-0005wn-Dx
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 12:48:11 -0400
Received: from laurent.telenet-ops.be ([195.130.137.89]:52202)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1nlvh3-0005wf-RR
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 12:48:10 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
 ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
 by laurent.telenet-ops.be with bizsmtp
 id SGo72700b4UW6Th01Go88b; Tue, 03 May 2022 18:48:08 +0200
Message-ID: <a1b3837274257314f2fa2349d15de3ca3329a9da.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Tue, 03 May 2022 18:48:07 +0200
In-Reply-To: <20220503114301.9524-8-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
 <20220503114301.9524-8-attila@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-fnIezkeRlR/DnmYZFAbh"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1651596488; bh=uH99q3bKXU0goqXCjxOeaGDdXYphM3WkCKF6ADKuc7Q=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=o7+Js9pycDKbVSqqSZKmFLEVbzZw/65ekFn3ZprPDNi8d5IezaM6ujtBnqRmMvPN9
 BiblxYy6s/+4d3Md7Y0PeueXCtQQgxFDsSRfUn5JNcUucWjyc42tnFJcx3WZ5gUUB/
 A6Nw+Z29sEATX6AyZxzjD4eQrXANRfq86ITJleeO19BaQUQXLoQR+ElyAnsP43nnaY
 T7ao9+omB9+XMuAh08yVIYOfJy+fnyHKll15YhuvAHnyB2SeAHdzc9Yp6mrExa8TfM
 +YQx8qGZE1FFJanQZyUJPeFxJlFXyO9mIO7uyg9vfq6D3RzmsIMZrYwRmAyuUv2ZuW
 7Owm4Wr67cBXg==
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--=-fnIezkeRlR/DnmYZFAbh
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Attila Lendvai schreef op di 03-05-2022 om 13:42 [+0200]:
> +;; TODO use define-constant
> +(define +known-vcs+

The naming convention in (Guile) Scheme is '%known-vcs' or 'known-vcs'.
Also, 'define-constant' doesn't exist in Guile, and the Lisp macro
'defconstant' and 'defmacro' appears to have some complications w.r.t.
phasing.  What would be the benefit of 'define-constant' here?


Greetings,
Maxime.

--=-fnIezkeRlR/DnmYZFAbh
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnFcxxccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7p37AQDyFVsLc+LIrqt5B+brsUrNxnm4
8JMR4KglAfass9qiDQD+Nh5WnToK3VGSZgS9o7VUngx2Wo+f4IDaPKgyTbR9fQY=
=v7AX
-----END PGP SIGNATURE-----

--=-fnIezkeRlR/DnmYZFAbh--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 08/10] guix: import: go: Modules in a subdir and prefixed tags.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 16:51:02 +0000
Resent-Message-ID: <handler.55242.B55242.165159665323177 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Attila Lendvai <attila@HIDDEN>, 55242 <at> debbugs.gnu.org
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165159665323177
          (code B ref 55242); Tue, 03 May 2022 16:51:02 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 16:50:53 +0000
Received: from localhost ([127.0.0.1]:40878 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlvjh-00061l-Bo
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 12:50:53 -0400
Received: from laurent.telenet-ops.be ([195.130.137.89]:56616)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1nlvje-00061Q-Ly
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 12:50:51 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
 ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
 by laurent.telenet-ops.be with bizsmtp
 id SGqp2700U4UW6Th01Gqpw3; Tue, 03 May 2022 18:50:49 +0200
Message-ID: <849ca73cf56763c56faa2a98ea744f678f233d1b.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Tue, 03 May 2022 18:50:49 +0200
In-Reply-To: <20220503114301.9524-8-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
 <20220503114301.9524-8-attila@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-XnR5f/E5KOwp5/CGsf8p"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1651596650; bh=xsf3DkziIVzBH4SIM+Awinu02Mk4TA8LlcgGsIf6iDU=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=OawaMKxlaek3aAmS+ufCWbQCdcgHBM1/RZq9NRV/1630F6ZbLVoolFv0Mi0miQtjJ
 HfKv7OQWOe3ajZP2AVS97s41lL+9Z0UdYfh56uQHsIQF12lgiw66RywiXh6UFUq6xC
 1uvk534x0aiyLtv8cT6rzl71Wg/73zko7SB4TYfs765ydMXGH+4fc/c/3Cq3B74kWh
 f+nOSQxU6PmE2CdirEEVyB3n3AAJlRn9Gm/3888PxMuPAxnfZu6kAVRzhxZOGhp8XO
 EZbYBt51/NbjyKlXw2UjsGHR0c3UKGxR9Sz0Rl23FlJV1rtqKH5vrHPXZV/cBcZc5l
 1586Aqj5C0Ybg==
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--=-XnR5f/E5KOwp5/CGsf8p
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Attila Lendvai schreef op di 03-05-2022 om 13:42 [+0200]:
> +=C2=A0 (log.info "~%Processing go module ~A@~A" module-path version)

Why a newline at the beginning instead of the end?  Also, why the
logging?  If I do "guix import go foobar", wouldn't I know in advance
it will process the foobar module?  And in case of --recursive,
wouldn't I know after the fact which modules were processed?

Greetings,
Maxime.

--=-XnR5f/E5KOwp5/CGsf8p
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnFdaRccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7p0lAQCyMFsDN9ov/MBB0iYC479jKpFy
sOtIZ/7EWzdeX+wGeAD+KYeLc3jPyKU+ITmYgTmhDEljwgFgO6XSM5g0RkXSIQ8=
=HEzh
-----END PGP SIGNATURE-----

--=-XnR5f/E5KOwp5/CGsf8p--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 08/10] guix: import: go: Modules in a subdir and prefixed tags.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 16:52:01 +0000
Resent-Message-ID: <handler.55242.B55242.165159669723277 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Attila Lendvai <attila@HIDDEN>, 55242 <at> debbugs.gnu.org
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165159669723277
          (code B ref 55242); Tue, 03 May 2022 16:52:01 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 16:51:37 +0000
Received: from localhost ([127.0.0.1]:40884 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlvkP-00063M-K6
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 12:51:37 -0400
Received: from albert.telenet-ops.be ([195.130.137.90]:59032)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1nlvkO-00063C-4k
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 12:51:36 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
 ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
 by albert.telenet-ops.be with bizsmtp
 id SGra270084UW6Th06GraCs; Tue, 03 May 2022 18:51:34 +0200
Message-ID: <6a532228dd7e6d8aada6b36df29241172aa5f3cd.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Tue, 03 May 2022 18:51:34 +0200
In-Reply-To: <20220503114301.9524-8-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
 <20220503114301.9524-8-attila@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-3572ZlsALgkbaRebzHg5"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1651596694; bh=jGB/JajljYxk3PnC3/iXpY+U91t/fBN+uTyGDh3xuQo=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=aXNYrZ3WpV2ls/xZ0y5pH3TfhMbaGZiauxm2QcqRL6pcrAUBZQ55xTDKaIB6+F7wb
 gi/P2SK98FXod2uOiZHlOzgXrwOSkNxLLv8t6qod+3cEytrtCkChmOm/otVBe0oT5F
 hnWCshYPzHRx9wczFXtUftWsaZr+3ep0PBXiuWXyi5MPbZMT2KOeHN1ssaG7fveNdV
 NrxP3Ud1xVEdvsw+Mj6XVJ0LjwumWQRbhQzzXk/kwyqvGdo2HPdnYYv7YZXLEQqKZd
 9a+WVuGQ13xXal6E+8KlQ+GCuN2oZsKzMlw6V3eXLxFxuoZvJ3i3JcP2Yb7kWfvjz9
 a8i5opq9fBKgQ==
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--=-3572ZlsALgkbaRebzHg5
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: base64

QXR0aWxhIExlbmR2YWkgc2NocmVlZiBvcCBkaSAwMy0wNS0yMDIyIG9tIDEzOjQyIFsrMDIwMF06
Cj4gK8KgwqDCoMKgwqDCoMKgwqAgKHJhdy1zdWJkaXIgKGlmICg8IChzdHJpbmctbGVuZ3RoIG1v
ZHVsZS1yb290LXBhdGgpCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoCAoc3RyaW5nLWxlbmd0aCBtb2R1bGUtcGF0aCkpCj4gK8KgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoc3Vic3RyaW5nIG1vZHVs
ZS1wYXRoCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKCsgMSAoc3RyaW5nLWxlbmd0aCBtb2R1bGUtcm9vdC1w
YXRoKSkpCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oCAjZmFsc2UpKQoKWW91IGNhbiB1c2UgKGFuZCBDT05EIChzdWJzdHJpbmcgLi4uKSkgaGVyZS4K
QWxzbywgdGhlIHVzdWFsIGV4dHJhIGNvbXBsZXhpdHkgLS0+IGV4dHJhIHRlc3RzLgoKR3JlZXRp
bmdzLApNYXhpbWUuCg==


--=-3572ZlsALgkbaRebzHg5
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnFdlhccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7jTpAP4kiUY7Gawrvw41IYNMtObS+xcx
MRs0Js7Rqq5wrOx6RgD+NySB8s87bcpEesZa99kaRQ9Eq1RfHbcRMlbiFfTsmgQ=
=56/P
-----END PGP SIGNATURE-----

--=-3572ZlsALgkbaRebzHg5--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 08/10] guix: import: go: Modules in a subdir and prefixed tags.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 16:54:01 +0000
Resent-Message-ID: <handler.55242.B55242.165159683223490 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Attila Lendvai <attila@HIDDEN>, 55242 <at> debbugs.gnu.org
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165159683223490
          (code B ref 55242); Tue, 03 May 2022 16:54:01 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 16:53:52 +0000
Received: from localhost ([127.0.0.1]:40889 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlvmZ-00066o-VC
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 12:53:52 -0400
Received: from albert.telenet-ops.be ([195.130.137.90]:35170)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1nlvmY-00066f-AK
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 12:53:50 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
 ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
 by albert.telenet-ops.be with bizsmtp
 id SGtp270064UW6Th06Gtppn; Tue, 03 May 2022 18:53:49 +0200
Message-ID: <27abb4025a581b0fda4cfe8b7e71f9a6e6ca6dbb.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Tue, 03 May 2022 18:53:46 +0200
In-Reply-To: <20220503114301.9524-8-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
 <20220503114301.9524-8-attila@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-+blyQdVXf6U5fn+o7mI2"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1651596829; bh=VmyzloW1Kiw8WIkZfONEuod4eBDAKad9xtKczbDKFxI=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=oZQqQIWOAucBDWMTU9cldLhhCkgjx4rSmvoQV2v4WQxMY9uX15IVgrlJsRdl9UAj0
 bRcRboedrTxcKsvkAD28+r+FDrhYzKsDN8ADqHtYgJCQP50kK266D4+t36aHlCuAPX
 0NBmCFe5iDrtkbRmUYinP7vVzoupdLoPmzTLyK/Q/h/KsRW3mmpHDCq7kqVFagjz0X
 NoXVYDY0Zqn954In1YcQ1dXa9e6fFJVMWOA/9L+xY0rVUye202DYfjVuhSmuIQCWTN
 Q2cBsavVqjZaJZyL0niDlkPqe9quob2LQGf7DnHweFH7hlKBn1s0Xf7lhZMZAwMuCu
 fu0G9OxhTp+qQ==
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--=-+blyQdVXf6U5fn+o7mI2
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Attila Lendvai schreef op di 03-05-2022 om 13:42 [+0200]:
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0 (string-match ".*v([0-9]+)$" raw-subdir))

Why a $ at the end but no "^" at the beginning?  What's the point of
the leading ".*"?  Could the regexp be constructed in advance, or only
once (maybe 'delay/force' and a global variable) -- turning a regexp
into a NFA into a DFA can be expensive.

Greetings,
Maxime.

--=-+blyQdVXf6U5fn+o7mI2
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnFeGhccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7og8AQCYqIFAC13fe33qxn9vUYrMJEAJ
N+rrrm5iz2LgFUiM4wEAiCFxzi/t1G5eNqJvH6ywOqUioNRJiDIOpls8M7LZ2Q0=
=GIIz
-----END PGP SIGNATURE-----

--=-+blyQdVXf6U5fn+o7mI2--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 08/10] guix: import: go: Modules in a subdir and prefixed tags.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 16:56:02 +0000
Resent-Message-ID: <handler.55242.B55242.165159691823682 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Attila Lendvai <attila@HIDDEN>, 55242 <at> debbugs.gnu.org
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165159691823682
          (code B ref 55242); Tue, 03 May 2022 16:56:02 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 16:55:18 +0000
Received: from localhost ([127.0.0.1]:40899 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlvny-00069u-G6
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 12:55:18 -0400
Received: from michel.telenet-ops.be ([195.130.137.88]:56336)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1nlvnw-00069l-Mg
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 12:55:17 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
 ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
 by michel.telenet-ops.be with bizsmtp
 id SGvF270014UW6Th06GvFZb; Tue, 03 May 2022 18:55:15 +0200
Message-ID: <140b35404dfd03c0a341c4c49a9b5d700c7f841d.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Tue, 03 May 2022 18:55:14 +0200
In-Reply-To: <20220503114301.9524-8-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
 <20220503114301.9524-8-attila@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-tTIt0XkJA5Cvm42DzYGc"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1651596915; bh=A8NJOn25R+ueQZ7PgTQ2MmEubzOxq4/SO0E0QQzhXY0=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=nD1WTxW53ihSvDm89lvvbkxmXUszjOs9mJMqmF8KOex9FKNu4C4JZKF6J7QKIsCUk
 Vq6YxV+++xBBdRK1T1SMG8ZlFHVQT2gS8ttvaxUK6bbwx6k6K0Eo8wvN4llc2fQLEo
 jq9DfYu0uVXsYGW9qIygdApo1ufXwlbqWVIGmnsqLgNffEJwPlqC4w6d1L2KTNgMTu
 RE6f+lvYlHiLmvBMEOYQCSxTSWVA6Jxf9/D7iiKOFmmeTyJ2ra1FpleHX6WnSCGH8R
 ECLPThOXs/o0Z78cj3Uo7XWhtKoF1NEGWj+QuQuyENg1e/eikjmxbrfsxV2d0LhDOy
 ZZ9FtgVHSQ73A==
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--=-tTIt0XkJA5Cvm42DzYGc
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: base64

QXR0aWxhIExlbmR2YWkgc2NocmVlZiBvcCBkaSAwMy0wNS0yMDIyIG9tIDEzOjQyIFsrMDIwMF06
Cj4gK8KgwqDCoMKgwqDCoMKgwqAgKHN5bm9wc2lzIChvciAoZmFsc2UtaWYtZXhjZXB0aW9uCj4g
K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGdvLXBhY2th
Z2Utc3lub3BzaXMgbW9kdWxlLXBhdGgpKQoKQXJlIHlvdSBzdXJlIHlvdSB3YW50IHRvIGlnbm9y
ZSBfYWxsXyBleGNlcHRpb25zPyAgSW5jbHVkaW5nIHN0YWNrCm92ZXJmbG93cywgb3V0LW9mLW1l
bW9yaWVzLCB1bmJvdW5kIHZhcmlhYmxlIGVycm9ycywgdHlwZSBlcnJvcnMgLi4uPwoKR3JlZXRp
bmdzLApNYXhpbWUuCg==


--=-tTIt0XkJA5Cvm42DzYGc
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnFechccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7s2uAP4uQmKj6l9KUX7Q/9sPUl2PlW1w
1bS7wIEnHjmhISTALAEAxUrb+8KrQ3zARIzZM5/UmpIO8XKRbb0MglWf4qTUrgk=
=91ab
-----END PGP SIGNATURE-----

--=-tTIt0XkJA5Cvm42DzYGc--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 08/10] guix: import: go: Modules in a subdir and prefixed tags.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 16:57:01 +0000
Resent-Message-ID: <handler.55242.B55242.165159699923868 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Attila Lendvai <attila@HIDDEN>, 55242 <at> debbugs.gnu.org
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165159699923868
          (code B ref 55242); Tue, 03 May 2022 16:57:01 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 16:56:39 +0000
Received: from localhost ([127.0.0.1]:40909 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlvpH-0006Cu-1I
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 12:56:39 -0400
Received: from albert.telenet-ops.be ([195.130.137.90]:39566)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1nlvpF-0006Cm-Dp
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 12:56:37 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
 ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
 by albert.telenet-ops.be with bizsmtp
 id SGwc2700E4UW6Th06Gwcko; Tue, 03 May 2022 18:56:36 +0200
Message-ID: <d0cf883672065bfc028f395bd1267c902877a931.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Tue, 03 May 2022 18:56:36 +0200
In-Reply-To: <20220503114301.9524-8-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
 <20220503114301.9524-8-attila@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-6ghyYlXglcLD6bkUwsrI"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1651596996; bh=3QsFn4oz8LZqpRoCygsKVYEhzmjAemzBkrLKWdozxoI=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=e9Z4rxbjRFw5FawuUYOgn1r+zQGgVbxNCCnIzNZxl3EMhPgU/hPqdU1JFMWDXXEmd
 FQUnUekeXkYI7+97Z83nKhA6kTca4ZA9ViRNoXc9nb+qbHGkZbnt2maBLYuMzOqK6O
 AibAIPe7srhBgnipD029Y2/GRR3TnIauJ8XESTW/hCsox0z1FLgQSrsMk5sbkmVoSs
 p8qv007AHUvKTkPR9P3SUt9aDfIMqRTaBMQwL4O6Pguohr88QktWPGw2NtS+3obndO
 LkHHI1PTVf1BMjDMm/DsRjPkSnDkAwR4PuEzqSzwKrINqAk72pAJ1Nkox9zJ8+ckdp
 OyE+gE9sl5RUw==
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--=-6ghyYlXglcLD6bkUwsrI
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: base64

QXR0aWxhIExlbmR2YWkgc2NocmVlZiBvcCBkaSAwMy0wNS0yMDIyIG9tIDEzOjQyIFsrMDIwMF06
Cj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAod2Fy
bmluZyAoR18gIkZhaWxlZCB0byBmZXRjaCBsaWNlbnNlIGZvciB+Uy5+JSIpCj4gK8KgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oCBtb2R1bGUtcGF0aCkKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgICcoInVua25vd24tbGljZW5zZSEiKSkpKSkKCgpJbiBzb21lIG90aGVyIGxvY2F0
aW9uLCB0aGUgc3ltYm9sICd1bmtub253LWxpY2Vuc2UhJyBpcyB1c2VkLiAgSGVyZSwgYQpzdHJp
bmcgaXMgdXNlZC4gIFdoeSB0aGUgaW5jb25zaXN0ZW5jeT8gIEFsc28sIGdpdmVuIHRoZSAidW5r
bm93bi0KbGljZW5zZSEiLCB0aGUgd2FybmluZyBzZWVtcyBtb3N0bHkgcmVkdW5kYW50IHRvIG1l
LgoKR3JlZXRpbmdzLApNYXhpbWUuCg==


--=-6ghyYlXglcLD6bkUwsrI
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnFexBccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7oS9AP4jqGMi+Ay5a8Cq8oZBsCJzvFRW
2TIQD3Kyhwh+x6PUyQD8DFNNg+BgM8yGqMJxcaRIeWSuqu3CEtw2QXTcCRC56g0=
=YqtN
-----END PGP SIGNATURE-----

--=-6ghyYlXglcLD6bkUwsrI--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 08/10] guix: import: go: Modules in a subdir and prefixed tags.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 17:00:02 +0000
Resent-Message-ID: <handler.55242.B55242.165159716224226 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Attila Lendvai <attila@HIDDEN>, 55242 <at> debbugs.gnu.org
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165159716224226
          (code B ref 55242); Tue, 03 May 2022 17:00:02 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 16:59:22 +0000
Received: from localhost ([127.0.0.1]:40928 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlvrt-0006Ig-Vo
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 12:59:22 -0400
Received: from michel.telenet-ops.be ([195.130.137.88]:34300)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1nlvrs-0006IU-A9
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 12:59:20 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
 ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
 by michel.telenet-ops.be with bizsmtp
 id SGzK270064UW6Th06GzKEb; Tue, 03 May 2022 18:59:19 +0200
Message-ID: <b5e7c69e909edb952782545a60170e5cbca69952.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Tue, 03 May 2022 18:59:18 +0200
In-Reply-To: <20220503114301.9524-8-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
 <20220503114301.9524-8-attila@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-d6ClsanIysMsvHrAVSWa"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1651597159; bh=Nu/ikjUrkvMtnF1G2lhI4peOG//5Nh0w3jn6Bb/rLDg=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=FED1AtmMf05RJ6Cd7U7WBXVGFyC3OU3ZVDcSBpoADtnPvODGAuM6g3EVozwWGjg1k
 2/ewRb7AsJ3ti6xG10V3AmdRp3olHX11l439emc2kdXcCYg1qcXb76HXRLPSSbV9Uj
 pzNwYCp+1v7+qx3dSHkCN+CIq+vaWzDPrpsUZu+4nK3Sg8VP84XVrW8wt+DwATU5sG
 FbMtGTTXD6qm5XGTJfyKp1jD5RLnZcZWvxRII7v6jsQgQuYsJqC3HpoM1GdsCcjmOM
 Vz4VLKp0BdSRoTWKDUCoo2SeHpi0iFQWECaYOMzxySgaCptUhWK34uXqGTnep94LGI
 R4YB4wKcod/QQ==
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--=-d6ClsanIysMsvHrAVSWa
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: base64

QXR0aWxhIExlbmR2YWkgc2NocmVlZiBvcCBkaSAwMy0wNS0yMDIyIG9tIDEzOjQyIFsrMDIwMF06
Cj4gK8KgwqDCoCA7OyBNYXliZSBzcGxpdCBjb21tYSBzZXBhcmF0ZWQgbGlzdCBvZiBsaWNlbnNl
cyBpbiBhIHNpbmdsZSBzdHJpbmcKPiArwqDCoMKgICh3aGVuIChhbmQgKD0gMSAobGVuZ3RoIGxp
Y2Vuc2VzKSkKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoc3RyaW5nPyAoZmlyc3Qg
bGljZW5zZXMpKSkKPiArwqDCoMKgwqDCoCAobGV0ICgocGllY2VzIChtYXAgc3RyaW5nLXRyaW0t
Ym90aAo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg
KHJlbW92ZSEgc3RyaW5nLW51bGw/CgpXaGVuIGNhbiBpdCBiZSBudWxsPyAgQWxzbywgdGVzdHMu
Cgo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqAgKHN0cmluZy1zcGxpdCAoZmlyc3QgbGljZW5zZXMpICNcLCkpKSkpCgpJ
cyB0aGVyZSBhIG5lZWQgZm9yIHNwZWVkIGhlcmU/ICBJZiBub3QsIEknZCBrZWVwIHRoaW5ncyBz
aW1wbGUgYnkKdXNpbmcgdGhlIG5vbi1tdXRhdGluZyB2ZXJzaW9uIChJIGV4cGVjdCB0aGUgc3Bl
ZWQgZ2FpbiB0byBiZSBuZWdsaWJsZQpoZXJlKS4gIElmIHRoZXJlIGlzLCBJIHdvdWxkIGFsc28g
dXNlIHRoZSBtdXRhdGluZyB2ZXJzaW9uIG9mIG1hcCAtLQonbWFwIScgZnJvbSBzcmZpLTEuCgoK
R3JlZXRpbmdzLApNYXhpbWUuCg==


--=-d6ClsanIysMsvHrAVSWa
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnFfZxccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7u2uAP9qhbYln/s2x2ZiOqZqp6JphqRf
RkuprghXBjQ6xOYs+QD/UUNypxbRV86m/1FECjm3z5580fiv73CO9o+eTJIHBwY=
=UH/D
-----END PGP SIGNATURE-----

--=-d6ClsanIysMsvHrAVSWa--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 08/10] guix: import: go: Modules in a subdir and prefixed tags.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 17:01:02 +0000
Resent-Message-ID: <handler.55242.B55242.165159722525873 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Attila Lendvai <attila@HIDDEN>, 55242 <at> debbugs.gnu.org
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165159722525873
          (code B ref 55242); Tue, 03 May 2022 17:01:02 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 17:00:25 +0000
Received: from localhost ([127.0.0.1]:40937 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlvsu-0006j3-Sp
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 13:00:25 -0400
Received: from albert.telenet-ops.be ([195.130.137.90]:45906)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1nlvst-0006h4-FL
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 13:00:23 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
 ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
 by albert.telenet-ops.be with bizsmtp
 id SH0M2700T4UW6Th06H0NWB; Tue, 03 May 2022 19:00:22 +0200
Message-ID: <a18b191e875fc8a8ac597e27200bb99d45b9c562.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Tue, 03 May 2022 19:00:21 +0200
In-Reply-To: <20220503114301.9524-8-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
 <20220503114301.9524-8-attila@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-EEL2A7Tr6+mBuMF64lFJ"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1651597222; bh=NxJ9EwR8b6bQZH0yf/Hn9Ui+7h2JTKx128ZYM9B8gYE=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=TieCbXqVOgwsY2f0fGOwmbw0YtEolfjzTP+LhBzR0kX2oIWIiN24bqOM0pdaCYeD5
 Hg7V2MqW4KjUwTWoHDlg5CrExXJsWbZeNOqG/aQZmoTH3vQ6i3vgjWuQN7Wq+z1OE0
 Vi45XX4Iq4lCDaB009ceu9iVeElb6bEmh++KQB82EJ/ChN9CNXfYzUhNqDOgonyPwJ
 eq3BMcPoDIEmPY7T8udYqEzKr+khOSu6QR3MywubdJ9vY8Sqo79UA+txni99jaiZJU
 f2TrRRprZia3EwIsooU/qiyW29Mx2qhe/9rwYGnE2sqLyfCwSpZK+2JfRwvix1+mKi
 ER9GEQ/qGJr8Q==
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--=-EEL2A7Tr6+mBuMF64lFJ
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Attila Lendvai schreef op di 03-05-2022 om 13:42 [+0200]:
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 '(#:tests? #false ; som=
e packages have unrecorded dependencies needed only by their tests

Then they need to be recorded, and the reviewer will ask why tests are
being skipped here.

Greetings,
Maxime.

--=-EEL2A7Tr6+mBuMF64lFJ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnFfpRccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7owHAP99Xtin+0OA0OshN8mC1N7HBuiA
7awbWkALEEQ3WjnVOgEArkl9zWVtYNP4pepriAdUvjDwJ8g1NeiF8vGPgYEb9g8=
=V0GW
-----END PGP SIGNATURE-----

--=-EEL2A7Tr6+mBuMF64lFJ--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 07/10] guix: import: go: More resilience wrt network errors; add logging.
Resent-From: Attila Lendvai <attila@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 17:01:02 +0000
Resent-Message-ID: <handler.55242.B55242.165159724827393 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Maxime Devos <maximedevos@HIDDEN>
Cc: 55242 <at> debbugs.gnu.org
Reply-To: Attila Lendvai <attila@HIDDEN>
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165159724827393
          (code B ref 55242); Tue, 03 May 2022 17:01:02 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 17:00:48 +0000
Received: from localhost ([127.0.0.1]:40941 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlvtI-00077M-6T
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 13:00:48 -0400
Received: from mail-4022.proton.ch ([185.70.40.22]:43509)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <attila@HIDDEN>) id 1nlvtE-0006vL-J2
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 13:00:47 -0400
Date: Tue, 03 May 2022 17:00:30 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lendvai.name;
 s=protonmail3; t=1651597236;
 bh=h7L6CQXLA/zVYUdaXgPGevvvUN8Yg4/4hkNY2OIHdLY=;
 h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To:
 References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To:
 Feedback-ID:Message-ID;
 b=Tv3x7+jtgkCX7MryNRQIICEXKfVefz2aPxxMPGDxxCgIIPnvuv70ozb6EKrQblDD/
 dZwocpMppasAzJ0XtAYecNpJExjiotsjpiTRgdEwYcLa1AlovOGeVIbSvaJ7Aoccxk
 Hdv5uEqH0YTqXzXmMp6KDVevbLQb+dev6F8ep3LEF3Ihs4k/l8J1GnWFrXIurokrHc
 QdmwTiTt+YrVMiIlDvXuw97cXK8B8FI1izcvO4WeB6t0Gt9kbWTXkCv27HS/oMgrzP
 EeGpvD7khRNvm+j3LxAXulXG5hxMIpeukNRlX/ptgjLZ1IX7G04dvShaHQhnTTTLdP
 uKmXEqCVkD92A==
From: Attila Lendvai <attila@HIDDEN>
Message-ID: <O9w-304SD4fvo6wWmpf2MalIwuxcoKjwxTx1eKYl9jkla_-7NUaoSc8ld3R01g-9GRQHCHeMuNvHQsPMpF0rSR8HnG3KTrf_oPiCKY2OR5Y=@lendvai.name>
In-Reply-To: <7974a00256e3ee153507f77d6b0a405473e9bbc4.camel@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
 <20220503114301.9524-7-attila@HIDDEN>
 <7974a00256e3ee153507f77d6b0a405473e9bbc4.camel@HIDDEN>
Feedback-ID: 28384833:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (let ((port (current-warning-por=
t)))
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (format port "Unexpe=
cted error, will skip ~S.~%reason: "
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 package-name)
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; Printing a backtr=
ace here is not very useful: it is
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; cut off because G=
UARD unwinds.
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (print-exception por=
t (stack-ref (make-stack #t) 1)
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 c (exception-args c))
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (display-backtrace (=
make-stack #t) port))
>
>
> Why are unknown errors being catched here?

*all* errors are caught, displayed, and swallowed, so that the importing ca=
n proceed to the rest of the packages.

a possible scenario: a large import can take several minutes. if there's a =
transient network error, then this way it may finish with 99% of the packag=
es, and the rest can be restarted by hand after inspecting the log output.

another scenario is that the importer is simply buggy, and the user gets 99=
% of the packages imported, and has to do only one package by hand.


> What's the '-continuable' for here?  Is it to avoid extra 'raise-
> exception' entries in the backtrace, or does this actually make use
> of Scheme's continuable exceptions?


honestly, i can't remember. which translates to: i should have
commented on that!

*shakes head and makes a mental note*

from guile's manual:

"If continuable? is true, the handler is invoked in tail position
relative to the raise-exception call. Otherwise if the handler
returns, a non-continuable exception of type &non-continuable is
raised in the same dynamic environment as the handler."

i.e. it should rather be called raise-continuably not
raise-continuable.

and i think the reason is that the stack is not unwound that way, so
that the handlers in the guard can print a backtrace showing the
entire stack.

does this make sense? i'm still learning scheme's stack/exception
handling...

or maybe what i wanted is that the handlers in the guard can return
with (values #f '())? but i think that should work with vanilla RAISE,
too.


> Why a warning instead of a 'report-error'?


because i want the importer to be able to deal with a transitive
closures of dependencies with > 400 entries. if it fails at the first
error, then a `guix import go -r` becomes a hopeless endeavor for
larger go modules.

thanks for the review Maxime! i'll address the rest, too.

--
=E2=80=A2 attila lendvai
=E2=80=A2 PGP: 963F 5D5F 45C7 DFCD 0A39
--
=E2=80=9C'Emergencies' have always been the pretext on which the safeguards=
 of individual liberty have been eroded.=E2=80=9D
=09=E2=80=94 F. A. Hayek (1899=E2=80=931992)

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#55242] [PATCH 08/10] guix: import: go: Modules in a subdir and prefixed tags.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 May 2022 17:02:02 +0000
Resent-Message-ID: <handler.55242.B55242.165159727228982 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 55242
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Attila Lendvai <attila@HIDDEN>, 55242 <at> debbugs.gnu.org
Received: via spool by 55242-submit <at> debbugs.gnu.org id=B55242.165159727228982
          (code B ref 55242); Tue, 03 May 2022 17:02:02 +0000
Received: (at 55242) by debbugs.gnu.org; 3 May 2022 17:01:12 +0000
Received: from localhost ([127.0.0.1]:40948 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nlvtf-0007X9-OT
	for submit <at> debbugs.gnu.org; Tue, 03 May 2022 13:01:12 -0400
Received: from laurent.telenet-ops.be ([195.130.137.89]:45336)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1nlvtd-0007UL-Si
 for 55242 <at> debbugs.gnu.org; Tue, 03 May 2022 13:01:10 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
 ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
 by laurent.telenet-ops.be with bizsmtp
 id SH182700G4UW6Th01H186V; Tue, 03 May 2022 19:01:08 +0200
Message-ID: <c9c1de9095244c938d41fea488933af8b4bcc7b1.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Tue, 03 May 2022 19:01:08 +0200
In-Reply-To: <20220503114301.9524-8-attila@HIDDEN>
References: <20220503114301.9524-2-attila@HIDDEN>
 <20220503114301.9524-8-attila@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-1koN4SXMSqvfM1j0bgw6"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1651597268; bh=OfaGRga2tSI9H3Wj+EWuJ+ZK95DS6fmVRcsA7U98VD0=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=VYJKBmvCEz6S4kb3Gpm6ws0FU39ksQH535OVBVC4FiTOG99f+zaomrk5BF8t+pYNL
 ZJU4pZx6r92Bt+BrPYvvkP873w/sz3uFE0peEk9FdMZXHwcpVaeJSKT+o7uPS/7WlP
 D2JXLBahh+qANll8DfoO1VojGqrOmYVkarWsg/+KJWoGAm1w0RYI/283Ksk9uwmNVu
 76o3IRdnAFKN+sJlyFahGkq79T/DK2apKO8oZbNIpyr3mNP+mse525YRlrr5X3rlkx
 xjdl/8P25pxC9i0GJCZowHLC2vgX45Iz5wtq+dH03PETVNHJFCZQiNmP4S5OoGecpF
 qfU5kbKJbrYQg==
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--=-1koN4SXMSqvfM1j0bgw6
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Attila Lendvai schreef op di 03-05-2022 om 13:42 [+0200]:
> +=C2=A0 (log.info "Initiating recursive import of ~a, version ~a" package=
-name version)

This seems implied by typing "guix import go --recursive foo@bar"?

Greetings,
Maxime.

--=-1koN4SXMSqvfM1j0bgw6
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnFf1BccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7kbFAP9tCRkgScGTQ6x7zQHnC3oVy7Pe
thCJx3hrFlOrtSHtCAD+KDBAygT8bYzLNPHIDDXbcJbQNEVm6HQVbwEBUBOLdQM=
=e3Zu
-----END PGP SIGNATURE-----

--=-1koN4SXMSqvfM1j0bgw6--

Last modified: Tue, 3 May 2022 17:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.