Received: (at 55310-done) by debbugs.gnu.org; 16 Mar 2025 03:34:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 15 23:34:03 2025 Received: from localhost ([127.0.0.1]:44625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ttelF-0007CD-UT for submit <at> debbugs.gnu.org; Sat, 15 Mar 2025 23:34:03 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:41788) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>) id 1ttelB-0007AY-6X for 55310-done <at> debbugs.gnu.org; Sat, 15 Mar 2025 23:33:59 -0400 DKIM-Signature: a=rsa-sha256; b=hPgi/Ka3BfMxyJAhnhRRr3VpJrD2Vzw1mNyBq0O8msqWElqBOjifKbdtyri/jR6/rnIBIQFxpJAgoPtNykA16wrWWhIs4bZC1+bo1ndtt04VJ89SxUhKQBCH0AJFEERNwf1qfrzle3CJSk696o4fni/nHM0/R22SVWCtzuWyx6Twxs02px3Hw/ctmq5JB/DacxROVMylVHgtbUaFokJsbWsKuoQZTx50JRJqDbdmOMB6ZHy4sBE2N388TKQiJSIMDUC2ANb/V4726g8BmPn59JbKfsNBF84jAwXoyAB1BDwXwjnvo68Vf7cmaOOZnkDaC827zL7XADo0A3HW5eRs+Q==; s=purelymail1; d=spwhitton.name; v=1; bh=1KvwN4+qSBqN/mP62Rf6qlwnvYxbhEtZ2HtT3yOFApA=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=YaEd+PkjQ2Lu2yEcSt1FMj2fXac5ATygk3pXqJ93tZoySdamPia6p97pYDBdWskz9ael7cD2M2tWQbaIQ7hvbtfcDEejpmMnFYWeJY12Wd09CaBTuA8cTiKWeTpP0K/U6GOMtSPggmXw2L+9O0yzixXi+bPOimHjnxppUZO2N735wWFCJZYT+Jz6+LTLx5mldoAmRjyH8FFA35FgEQOA3n1BR4yyDlFnGZiCShCbbPOLr9K2p9S98ginQu7mUgumIiLfyW6LVZxtOuEnz0o56MvwmSGlIPjoaUK8Sj47h+JmvcXSIU68ayfM279weBBVfV3iMjdMoYJwxaKLWs8AZw==; s=purelymail1; d=purelymail.com; v=1; bh=1KvwN4+qSBqN/mP62Rf6qlwnvYxbhEtZ2HtT3yOFApA=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 55310-done <at> debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -1437260311; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sun, 16 Mar 2025 03:33:48 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id E78977E0A51; Sun, 16 Mar 2025 11:33:45 +0800 (CST) From: Sean Whitton <spwhitton@HIDDEN> To: Dmitry Gutov <dgutov@HIDDEN> Subject: Re: bug#55310: 27.2; vc-revert: unhelpful error message when modified buffers exist In-Reply-To: <e04ed35b-38fb-438c-a088-97578af2176b@HIDDEN> References: <E1nnbY0-0002ze-78@HIDDEN> <87y1zcjljm.fsf@HIDDEN> <E1nnhoI-0007PC-RC@HIDDEN> <87ilqfcagd.fsf@HIDDEN> <87senll5zd.fsf@HIDDEN> <5ebb0fda-3db2-45ef-bc44-f9e18a6f004d@HIDDEN> <87ldt82sgm.fsf@HIDDEN> <c18d5f09-6170-4f06-8bc9-71c420e794ab@HIDDEN> <874izupvmi.fsf@HIDDEN> <e04ed35b-38fb-438c-a088-97578af2176b@HIDDEN> Date: Sun, 16 Mar 2025 11:33:45 +0800 Message-ID: <877c4pmyxy.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 55310-done Cc: 55310-done <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Version: 31.1 Hello, On Sat 15 Mar 2025 at 10:18pm +02, Dmitry Gutov wrote: > On 15/03/2025 10:04, Sean Whitton wrote: >> Hello again Dmitry, >> Okay, how do these look? > > Looking good, thanks. Thanks for looking them over. Installed and closing the bug. -- Sean Whitton
"Alfred M. Szmidt" <ams@HIDDEN>:Sean Whitton <spwhitton@HIDDEN>:Received: (at 55310) by debbugs.gnu.org; 15 Mar 2025 20:18:29 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 15 16:18:29 2025 Received: from localhost ([127.0.0.1]:43703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ttXxk-0000fz-Lf for submit <at> debbugs.gnu.org; Sat, 15 Mar 2025 16:18:28 -0400 Received: from forward502d.mail.yandex.net ([2a02:6b8:c41:1300:1:45:d181:d502]:43104) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <dgutov@HIDDEN>) id 1ttXxi-0000fM-Je; Sat, 15 Mar 2025 16:18:27 -0400 Received: from mail-nwsmtp-smtp-production-main-95.klg.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-95.klg.yp-c.yandex.net [IPv6:2a02:6b8:c43:7c8:0:640:150d:0]) by forward502d.mail.yandex.net (Yandex) with ESMTPS id D5ADF60F3E; Sat, 15 Mar 2025 23:18:17 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-95.klg.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id EIMZwTOLdW20-CxouJ3XT; Sat, 15 Mar 2025 23:18:17 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1742069897; bh=q6bFapZ03IxsUujVa3czqowRO6y/tRT3zfjnbSbnavE=; h=In-Reply-To:From:Subject:Message-ID:Cc:References:Date:To; b=utGec2fNgNOD8fuqD2gewiihbfxVMd20Y+OaioSAlJtOogtrLroNPy/oEMHzm1Mw5 Pcm2+xeHslNbQ7ZhhcK+DqL5Ymc8xpoSOJBCwPL/mBZR/9GxT2iptuBKpcsUoBdL1K Emb64xNOfx+pJARoHptTTdUocyp7LBXo8N4uCtvY= Authentication-Results: mail-nwsmtp-smtp-production-main-95.klg.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfauth.phl.internal (Postfix) with ESMTP id A4F4E1200079; Sat, 15 Mar 2025 16:18:14 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Sat, 15 Mar 2025 16:18:14 -0400 X-ME-Sender: <xms:huDVZ-ox7oHKhnRGBEByxn1VcMp-WD7bWZ2sFqsb70tRIm9gRGerow> <xme:huDVZ8qY8YpJ77WQsuacAeJjFl6V9wSVHLnjVLGcUJ40XiDszBlT6HlUslX9r8eJv ISoz-So95yuTEnoIHw> X-ME-Received: <xmr:huDVZzPiuzU1L8sFP95X0uaWlVKM2UGzwoDhgko1t-a_i2kUz7fGULh_nNj5o3sSCrUz> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddufeegieeiucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddt vdejnecuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegughhuthhovheshigrnhguvg igrdhruheqnecuggftrfgrthhtvghrnhepheegleejudegueffudejtdeukeelheduiefh leevkeeifeeugefhtdevvdegueelnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepughguhhtohhvodhmvghsmhhtphgruhhthhhpvghrshhonhgr lhhithihqddufeeffeelleehhedvqddvleegjeejjeejiedqughguhhtohhvpeephigrnh guvgigrdhruhesfhgrshhtmhgrihhlrdgtohhmpdhnsggprhgtphhtthhopeegpdhmohgu vgepshhmthhpohhuthdprhgtphhtthhopehsphifhhhithhtohhnsehsphifhhhithhtoh hnrdhnrghmvgdprhgtphhtthhopegrmhhssehgnhhurdhorhhgpdhrtghpthhtoheptgho nhhtrhholhesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopeehheefuddtse guvggssghughhsrdhgnhhurdhorhhg X-ME-Proxy: <xmx:huDVZ96NILTpHpO94fko_gyLSNaj8UOPAaS8QL7m75WC5eXx3H8kuQ> <xmx:huDVZ96fPXodO5u91GwwuiMSTIEP4q1fJm96etv6b1lAvH5Tqpdz1Q> <xmx:huDVZ9ghbc-wAc6khoudyYA8BWz1Gv1TJcqIuZ7cautrn0tw0G6Dlg> <xmx:huDVZ34KnVMYPGrhz4zujjkGvlPnIi_l0fj-0-JRYJ5_L0LFMgRQYg> <xmx:huDVZ4J4I6qkFCrxP6iZstC3um6IaCvyHMWHAAxyQ3dy0ZwaYGRDrSvA> Feedback-ID: ib1d9465d:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 15 Mar 2025 16:18:12 -0400 (EDT) Message-ID: <e04ed35b-38fb-438c-a088-97578af2176b@HIDDEN> Date: Sat, 15 Mar 2025 22:18:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#55310: 27.2; vc-revert: unhelpful error message when modified buffers exist To: Sean Whitton <spwhitton@HIDDEN> References: <E1nnbY0-0002ze-78@HIDDEN> <87y1zcjljm.fsf@HIDDEN> <E1nnhoI-0007PC-RC@HIDDEN> <87ilqfcagd.fsf@HIDDEN> <87senll5zd.fsf@HIDDEN> <5ebb0fda-3db2-45ef-bc44-f9e18a6f004d@HIDDEN> <87ldt82sgm.fsf@HIDDEN> <c18d5f09-6170-4f06-8bc9-71c420e794ab@HIDDEN> <874izupvmi.fsf@HIDDEN> Content-Language: en-US From: Dmitry Gutov <dgutov@HIDDEN> In-Reply-To: <874izupvmi.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55310 Cc: "Alfred M. Szmidt" <ams@HIDDEN>, control <at> debbugs.gnu.org, 55310 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Hi Sean, On 15/03/2025 09:37, Sean Whitton wrote: > Yes, this is exactly what I was suggesting 🙂 I'll go ahead and do that. Ah perfect. Sorry, guess I worked off the context in the GGGP email. On 15/03/2025 10:04, Sean Whitton wrote: > Hello again Dmitry, > > Okay, how do these look? Looking good, thanks.
bug-gnu-emacs@HIDDEN:bug#55310; Package emacs.
Full text available.Sean Whitton <spwhitton@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at 55310) by debbugs.gnu.org; 15 Mar 2025 08:05:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 15 04:05:09 2025
Received: from localhost ([127.0.0.1]:38646 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ttMW5-0001WI-26
for submit <at> debbugs.gnu.org; Sat, 15 Mar 2025 04:05:09 -0400
Received: from sendmail.purelymail.com ([34.202.193.197]:60610)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>)
id 1ttMW1-0001Vf-LU
for 55310 <at> debbugs.gnu.org; Sat, 15 Mar 2025 04:05:07 -0400
DKIM-Signature: a=rsa-sha256;
b=KjqExdymx23jLcpUfv2B3vakx2SLMz4Hxzau08cJGlW9CVmurczbc7IdPfgc9Gh02Yn4oc4JCdV3ytvGj9pETe/KRixkeXn0F8Z9ACWGzt/a3qqok7oc3w5gVDyWOSSmVnvowSdFBOyZhP4nDRp3sRx1cNCBo8hO55QL2wVlIJ+vxEx4/+HTvw61Zig3u0sZyNIjlIcLqS55aMsMsKXCwLGY7l8TXo6kmwupO6cm+7asH/QfOn7opAAnEOha8lUPY1I7TCdqLVMBHymxW8tr7KW65aYK724s8ly8tKQOidsDuYUe6NmlcMXxHhFwbC6u9ax1333wJLOuSJ/IEb/F7Q==;
s=purelymail1; d=spwhitton.name; v=1;
bh=2De1l7V08zKTYx8pWnMyt1pYnmkoJZk66MjNktDJtXw=;
h=Received:Received:From:To:Subject:Date;
DKIM-Signature: a=rsa-sha256;
b=Y7rxHwOinLhhprsaYmEaIuYbBTGuHKA/INyVGb5l4y9zTYad8OZmJhZfl5Tyg+bBQ2aHAqPrvkMRZDxnHoOdPNSs5HrV6i1iRcmlSMay+aotHhShL7gcqcTHFuUo9c/Ge4nxeHgxshnqOib0hAYR5Fn05Ivx1pbVIsxIuCd3+2EN2NTdX2D7W101uj2AFy2BYdKFJEjPzgv07zySz4cjLIwekWfst18GyVx3jwAwgoQLNx6Wh88mv/1hHy+/5at3e83i/4rZC5Z1BCJpmVkBPb7+7SA6Ds0I/dV39St5Dz0O+eSCXGWb5SHyK8H7rGy+Sff5qwusN/Sz4bjaf1r0nQ==;
s=purelymail1; d=purelymail.com; v=1;
bh=2De1l7V08zKTYx8pWnMyt1pYnmkoJZk66MjNktDJtXw=;
h=Feedback-ID:Received:Received:From:To:Subject:Date;
Feedback-ID: 20115:3760:null:purelymail
X-Pm-Original-To: 55310 <at> debbugs.gnu.org
Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -26268954;
(version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384);
Sat, 15 Mar 2025 08:04:57 +0000 (UTC)
Received: by melete.silentflame.com (Postfix, from userid 1000)
id D98067ED073; Sat, 15 Mar 2025 16:04:53 +0800 (CST)
From: Sean Whitton <spwhitton@HIDDEN>
To: Dmitry Gutov <dgutov@HIDDEN>
Subject: Re: bug#55310: 27.2; vc-revert: unhelpful error message when
modified buffers exist
In-Reply-To: <c18d5f09-6170-4f06-8bc9-71c420e794ab@HIDDEN>
References: <E1nnbY0-0002ze-78@HIDDEN> <87y1zcjljm.fsf@HIDDEN>
<E1nnhoI-0007PC-RC@HIDDEN> <87ilqfcagd.fsf@HIDDEN>
<87senll5zd.fsf@HIDDEN>
<5ebb0fda-3db2-45ef-bc44-f9e18a6f004d@HIDDEN>
<87ldt82sgm.fsf@HIDDEN>
<c18d5f09-6170-4f06-8bc9-71c420e794ab@HIDDEN>
Date: Sat, 15 Mar 2025 16:04:53 +0800
Message-ID: <874izupvmi.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 55310
Cc: "Alfred M. Szmidt" <ams@HIDDEN>, control <at> debbugs.gnu.org,
55310 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain
tag 55310 + patch
thanks
Hello again Dmitry,
Okay, how do these look?
--
Sean Whitton
--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment;
filename=0001-vc-revert-Offer-to-save-modified-buffers-bug-55310.patch
From e1359bd44de4b139f4cd971c07d356ebea754ee0 Mon Sep 17 00:00:00 2001
From: Sean Whitton <spwhitton@HIDDEN>
Date: Sat, 15 Mar 2025 16:02:56 +0800
Subject: [PATCH 1/2] vc-revert: Offer to save modified buffers (bug#55310)
* lisp/vc/vc.el (vc-revert): Offer to save modified buffers that
otherwise prevent proceeding with the revert (bug#55310).
---
lisp/vc/vc.el | 23 +++++++++++++++--------
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el
index bc96173d198..5c2f848b891 100644
--- a/lisp/vc/vc.el
+++ b/lisp/vc/vc.el
@@ -3243,14 +3243,21 @@ vc-revert
;; show the changes and ask for confirmation to discard them.
(when (or (not files) (memq (buffer-file-name) files))
(vc-buffer-sync nil))
- (dolist (file files)
- (let ((buf (get-file-buffer file)))
- (when (and buf (buffer-modified-p buf))
- (error "Please kill or save all modified buffers before reverting")))
- (when (vc-up-to-date-p file)
- (if (yes-or-no-p (format "%s seems up-to-date. Revert anyway? " file))
- (setq queried t)
- (error "Revert canceled"))))
+ (save-some-buffers nil (lambda ()
+ (member (buffer-file-name) files)))
+ (let (needs-save)
+ (dolist (file files)
+ (let ((buf (get-file-buffer file)))
+ (when (and buf (buffer-modified-p buf))
+ (push buf needs-save)))
+ (when (vc-up-to-date-p file)
+ (if (yes-or-no-p (format "%s seems up-to-date. Revert anyway? "
+ file))
+ (setq queried t)
+ (error "Revert canceled"))))
+ (when needs-save
+ (error "Cannot revert with these buffers unsaved: %s"
+ (string-join (mapcar #'buffer-name needs-save) ", "))))
(unwind-protect
(when (if vc-revert-show-diff
(progn
--
2.45.2
--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment;
filename=0002-New-project-save-some-buffers-command.patch
From 39d812ce59362b6da359a6f338730735b29b7f0d Mon Sep 17 00:00:00 2001
From: Sean Whitton <spwhitton@HIDDEN>
Date: Sat, 15 Mar 2025 16:03:38 +0800
Subject: [PATCH 2/2] New project-save-some-buffers command
* lisp/progmodes/project.el (project-save-some-buffers): New command.
(project-prefix-map): Bind it to C-x p C-x s.
---
lisp/progmodes/project.el | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index d954b78a745..e2cd5bfa231 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -903,6 +903,7 @@ project-prefix-map
(define-key map "x" 'project-execute-extended-command)
(define-key map "o" 'project-any-command)
(define-key map "\C-b" 'project-list-buffers)
+ (define-key map "\C-xs" 'project-save-some-buffers)
map)
"Keymap for project commands.")
@@ -1828,6 +1829,12 @@ project-kill-buffers
((funcall query-user)
(mapc #'kill-buffer bufs)))))
+;;;###autoload
+(defun project-save-some-buffers (arg)
+ "Like `save-some-buffers', but only for this project's buffers."
+ (interactive "P")
+ (save-some-buffers arg (save-some-buffers-root)))
+
;;; Project list
--
2.45.2
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#55310; Package emacs.
Full text available.Received: (at 55310) by debbugs.gnu.org; 15 Mar 2025 07:37:35 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 15 03:37:35 2025 Received: from localhost ([127.0.0.1]:38484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ttM5O-0005Vy-I6 for submit <at> debbugs.gnu.org; Sat, 15 Mar 2025 03:37:34 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:51770) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>) id 1ttM5M-0005VZ-0b for 55310 <at> debbugs.gnu.org; Sat, 15 Mar 2025 03:37:32 -0400 DKIM-Signature: a=rsa-sha256; b=j+l/UrcRVvQaYaTVxgAAteni9OnZO31ovaOA5NGo6YIcqIrbKibXmFO8KqMLaHdAqNvatpV0450QM9Q/SX/QraCgYWF+15bbU0lBFVvXVcu3p/Z3VuMzUs0CW7tnmhHXx44jp1sgG/c0xc1lgLOFSMAXIgTv7Y4zJgTafOZx1ki3AnZLSD60+q1lhQPu+dQmL17YgHzO53AR6ZEjnCSrPnHIQV3dg2jQtDhRvbhhDWOlgL/kWw5J0VXzNoWQdVGeokhGAb1fT5sEXLUDBf2EIkzXIf42j2FBozh0uomAPeW3Vq19+LsMqNine/FEqN5I+/38o9JnnXT5YTkdSA32pA==; s=purelymail1; d=spwhitton.name; v=1; bh=H+/3BVqxWbVSqI/GyOXzy+ZVvUcinmxFuTHCAxQacjI=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=IihflUjvhX2LZgnEOlHgdlMTnGV4EAhgCQozq6rltQnIdtP4pfjxKXFQQV9+ovmU5aZj+cDc5snubqkx93AGjUKFPKgPFCCrLrjF6GEnA5yt9xG6Ar3EXZ2fGqzObbLQfo7VkQ10JSYBwlT4Qb/99YHhGHGzhhNU53jaspzv7H81PYUybo8as2b/qFx7DhsLOpOjapZj9QQj15+6bU8JO+mMekYb5/8591CaQQHbilk44f5Vh6soGYYdV68hOyUFAQRiX+w89FfeaFIGRyHE1llYOjGrCiIwLrE2+BNydx1xXJpKd7QYHWLRtCKWlH/qqlbKGN39V8XQDk6KrApPrw==; s=purelymail1; d=purelymail.com; v=1; bh=H+/3BVqxWbVSqI/GyOXzy+ZVvUcinmxFuTHCAxQacjI=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 55310 <at> debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -1507707844; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sat, 15 Mar 2025 07:37:23 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id A75697ED073; Sat, 15 Mar 2025 15:37:19 +0800 (CST) From: Sean Whitton <spwhitton@HIDDEN> To: Dmitry Gutov <dgutov@HIDDEN> Subject: Re: bug#55310: 27.2; vc-revert: unhelpful error message when modified buffers exist In-Reply-To: <c18d5f09-6170-4f06-8bc9-71c420e794ab@HIDDEN> References: <E1nnbY0-0002ze-78@HIDDEN> <87y1zcjljm.fsf@HIDDEN> <E1nnhoI-0007PC-RC@HIDDEN> <87ilqfcagd.fsf@HIDDEN> <87senll5zd.fsf@HIDDEN> <5ebb0fda-3db2-45ef-bc44-f9e18a6f004d@HIDDEN> <87ldt82sgm.fsf@HIDDEN> <c18d5f09-6170-4f06-8bc9-71c420e794ab@HIDDEN> Date: Sat, 15 Mar 2025 15:37:19 +0800 Message-ID: <87a59mpwwg.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 55310 Cc: "Alfred M. Szmidt" <ams@HIDDEN>, 55310 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hello, On Sat 15 Mar 2025 at 04:18am +02, Dmitry Gutov wrote: > Re-reading the discussion again, maybe Lars's original suggestion - from > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55310#8 - is better? Yes, this is exactly what I was suggesting :) I'll go ahead and do that. > This way we'd only require that the buffers to be reverted, are saved. And > abort otherwise. > > Also probably change the error to something like > > "Please kill or save all affected buffers before reverting" > > If we can't print all the buffer names, which we also could try, though. > > Requiring all buffers across the project (never mind the session) to be saved > before any can be vc-reverted, would be a more disruptive change. > >> (2) Add a project-save-some-buffers which just binds >> save-some-buffers-default-predicate around a call to >> save-some-buffers, bind is to 'C-x p C-x s' (useful anyway, I think) >> and change the message to suggest using it: >> "Use C-x p C-x s to save or kill modified buffers before reverting" > > Adding a new command with a binding sounds good to me, irrespective of this > issue. Okay, I'll send you a patch. -- Sean Whitton
bug-gnu-emacs@HIDDEN:bug#55310; Package emacs.
Full text available.Received: (at 55310) by debbugs.gnu.org; 15 Mar 2025 02:19:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 14 22:19:18 2025 Received: from localhost ([127.0.0.1]:37073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ttH7N-0005Td-WA for submit <at> debbugs.gnu.org; Fri, 14 Mar 2025 22:19:18 -0400 Received: from forward502d.mail.yandex.net ([2a02:6b8:c41:1300:1:45:d181:d502]:39924) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <dgutov@HIDDEN>) id 1ttH7K-0005TI-Fh for 55310 <at> debbugs.gnu.org; Fri, 14 Mar 2025 22:19:16 -0400 Received: from mail-nwsmtp-smtp-production-main-52.klg.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-52.klg.yp-c.yandex.net [IPv6:2a02:6b8:c43:c94:0:640:bcb2:0]) by forward502d.mail.yandex.net (Yandex) with ESMTPS id A778B6105C; Sat, 15 Mar 2025 05:19:07 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-52.klg.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id 3J4oViGLeeA0-KYNRuHH3; Sat, 15 Mar 2025 05:19:06 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1742005146; bh=hGw98OuTHCJmxP8lVUfs7Rj6SFvM9u5Ud5RRaPKOK/Q=; h=In-Reply-To:From:Subject:Message-ID:Cc:References:Date:To; b=q9Z4FUhhRB4Ss10I3Pmm9f9zuomVFmMp1PJCHnU3dxt9fYevGKAbqF2c6v1rcD8lI Lho0HyTFkzlaUBGFSkRAM1+L4y6Cwp+DIUqWb2zgvBm3dwRv3jdd4xKhqwxZ6Y0gZi fE4wTjsLEaMZxDZ3QalIb/jDM9rBX/+Jg9xnAHsI= Authentication-Results: mail-nwsmtp-smtp-production-main-52.klg.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfauth.phl.internal (Postfix) with ESMTP id A46031200076; Fri, 14 Mar 2025 22:19:03 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-10.internal (MEProxy); Fri, 14 Mar 2025 22:19:03 -0400 X-ME-Sender: <xms:l-PUZ8hebAxoDdN7nPO_mo5KIHKq6gRJLVU1bpIywuoXjx95gRsJGw> <xme:l-PUZ1Anor-X4S6Ro2UYf-kkgBn466kSA0ehACXUaySDOBuPzPJfj8rlRfmaybbgf o1rv7eTxE05rLH2W4Q> X-ME-Received: <xmr:l-PUZ0H1fNwtkv8S_CYfHKj4bSJC9q8zwUdl_a6V87qfQJdwpQUb6rtIckk4iFoRX-g_> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddufedvgeelucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddt vdejnecuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegughhuthhovheshigrnhguvg igrdhruheqnecuggftrfgrthhtvghrnhepfeelfffhjefhgeehtdefhedtieehkeehteet feeljeekhfegteeivdehgfejueevnecuffhomhgrihhnpehgnhhurdhorhhgnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepughguhhtohhvodhm vghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqddufeeffeelleehhedvqddvleegje ejjeejiedqughguhhtohhvpeephigrnhguvgigrdhruhesfhgrshhtmhgrihhlrdgtohhm pdhnsggprhgtphhtthhopeefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehsph ifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgdprhgtphhtthhopegrmhhssehg nhhurdhorhhgpdhrtghpthhtohepheehfedutdesuggvsggsuhhgshdrghhnuhdrohhrgh X-ME-Proxy: <xmx:l-PUZ9Q-XOAWRAaX23vjbonsG_ZzdN3XDg1ZEXKHRkBBKcbSY3crXQ> <xmx:l-PUZ5z8bGciyIDouYnitnjSbAa92YKvo2L3ig3ZFmuqoi9kR9gCNw> <xmx:l-PUZ75SEp0EsAjBa9zFEtvMyabSnNSqKzcrns9P6FRxfW1CY3vbGw> <xmx:l-PUZ2yA6dTAaKZCZZry-ZSxKl2HbR0keSkwyKdjB0yE6NRl3g6tPg> <xmx:l-PUZ9iCDYXZH2_JEfgyWVTEfWoRKg6pJSXlfp6CtY9yl4B51OwidgL6> Feedback-ID: ib1d9465d:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 14 Mar 2025 22:19:02 -0400 (EDT) Message-ID: <c18d5f09-6170-4f06-8bc9-71c420e794ab@HIDDEN> Date: Sat, 15 Mar 2025 04:18:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#55310: 27.2; vc-revert: unhelpful error message when modified buffers exist To: Sean Whitton <spwhitton@HIDDEN>, "Alfred M. Szmidt" <ams@HIDDEN> References: <E1nnbY0-0002ze-78@HIDDEN> <87y1zcjljm.fsf@HIDDEN> <E1nnhoI-0007PC-RC@HIDDEN> <87ilqfcagd.fsf@HIDDEN> <87senll5zd.fsf@HIDDEN> <5ebb0fda-3db2-45ef-bc44-f9e18a6f004d@HIDDEN> <87ldt82sgm.fsf@HIDDEN> Content-Language: en-US From: Dmitry Gutov <dgutov@HIDDEN> In-Reply-To: <87ldt82sgm.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55310 Cc: 55310 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On 14/03/2025 05:37, Sean Whitton wrote: > Hello, > > On Wed 12 Mar 2025 at 10:11am +02, Dmitry Gutov wrote: > >> On 10/03/2025 09:06, Sean Whitton wrote: >>>>> Idea (ideas are cheap): maybe if one could add some sort of >>>>> high-light, or something in vc-dired that shows that this or that file >>>>> has a open buffer that is unmodified, and then the error could be the >>>>> same but just saying that one should check the highlighted buffers. >>>> I think that's a good idea -- perhaps Dmitry has some comments; added to >>>> the CCs. >>> ISTM that a project-save-some-buffers is what's wanted here. >>> Dmitry, has there been a discussion about having something like that? >> >> Last time this came up, a new value for save-some-buffers-default-predicate >> was added: save-some-buffers-root (bug#46374). So: >> >> (setopt save-some-buffers-default-predicate #'save-some-buffers-root) > > Ah, thanks for the reference. > > I would like to do one of the following things: > > (1) Do add the call to save-some-buffers in Lars's message. > We can change the error message to > "Some unsaved buffers remain; cannot revert" > and then I don't agree with him that the situation is confusing. Re-reading the discussion again, maybe Lars's original suggestion - from https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55310#8 - is better? This way we'd only require that the buffers to be reverted, are saved. And abort otherwise. Also probably change the error to something like "Please kill or save all affected buffers before reverting" If we can't print all the buffer names, which we also could try, though. Requiring all buffers across the project (never mind the session) to be saved before any can be vc-reverted, would be a more disruptive change. > (2) Add a project-save-some-buffers which just binds > save-some-buffers-default-predicate around a call to > save-some-buffers, bind is to 'C-x p C-x s' (useful anyway, I think) > and change the message to suggest using it: > "Use C-x p C-x s to save or kill modified buffers before reverting" Adding a new command with a binding sounds good to me, irrespective of this issue.
bug-gnu-emacs@HIDDEN:bug#55310; Package emacs.
Full text available.
Received: (at 55310) by debbugs.gnu.org; 14 Mar 2025 03:37:28 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Mar 13 23:37:27 2025
Received: from localhost ([127.0.0.1]:59221 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tsvrT-0002JP-Ex
for submit <at> debbugs.gnu.org; Thu, 13 Mar 2025 23:37:27 -0400
Received: from sendmail.purelymail.com ([34.202.193.197]:57620)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>)
id 1tsvrQ-0002J8-AY
for 55310 <at> debbugs.gnu.org; Thu, 13 Mar 2025 23:37:25 -0400
DKIM-Signature: a=rsa-sha256;
b=cBDk+iAe/dBDRgqYI6A94Ru/SOfZF0kD8BhpY7WhROF0F8RBLWUmdkVLHfhDReptb0MoiOto4c+8N+MDr4sSBQQ2YULDOWoRKwONJQlxl6XARzHGkS+44P7BsemOaI8bEy8/I6WjcfhtrBZjx9jdgs+suL6nMn95P6PwIv7lAF5AKxJUTmCa47DYrXBwLFzODjRdwvIGlZpFXwcLpR6oAk8nGfpSqS8aZTWl3jDCIufVYewLRH1ehYxgbwBNsb/4r2AbrroxJvtorVJ86gR5ekOab63aLEr5JI206Rjx3G6L1g5qiRkLUpwiOSFTcjs6moGGJPppPMGCz7TIP5Cbdw==;
s=purelymail1; d=spwhitton.name; v=1;
bh=Pd6lmnhMjrt5ZY49FerzgfZD0WYuY5Jmpd9Uebky+7c=;
h=Received:Received:From:To:Subject:Date;
DKIM-Signature: a=rsa-sha256;
b=bnF0RI8q3Y876XOJhkRmO8rpX2G7utkxFddbRcu5E0BbLWsym7zePRHD68GG18ZdsiArvFMwyCgHkzpWeUCRdEPpoQoG7S2AEtSsKm46PN7hTalktLRK3CPo3ZxJM50LWc/5I8b6BM27IZGkxgax1VLKy3Z+DCe6L6l1J2HtHQ+5fj0Fa3sOqsuxPVEjtIS7rfsLAhm7iOqSI+VjbDccCRjhr+FNafB9A98ygOZJx7uTx4GCJVf++wL/YPUsK2pWJ0FKOCrLjj50y3a+2syz3xGQTxICfOTySmeFuJ1yhAuwDFp3EO6ucX4GOAAqnLROZY32jFKJndFoTHVVMCJ4BQ==;
s=purelymail1; d=purelymail.com; v=1;
bh=Pd6lmnhMjrt5ZY49FerzgfZD0WYuY5Jmpd9Uebky+7c=;
h=Feedback-ID:Received:Received:From:To:Subject:Date;
Feedback-ID: 20115:3760:null:purelymail
X-Pm-Original-To: 55310 <at> debbugs.gnu.org
Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 1300798656;
(version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384);
Fri, 14 Mar 2025 03:37:17 +0000 (UTC)
Received: by melete.silentflame.com (Postfix, from userid 1000)
id 4EFA27EE5A8; Fri, 14 Mar 2025 11:37:13 +0800 (CST)
From: Sean Whitton <spwhitton@HIDDEN>
To: Dmitry Gutov <dgutov@HIDDEN>, "Alfred M. Szmidt" <ams@HIDDEN>
Subject: Re: bug#55310: 27.2; vc-revert: unhelpful error message when
modified buffers exist
In-Reply-To: <5ebb0fda-3db2-45ef-bc44-f9e18a6f004d@HIDDEN>
References: <E1nnbY0-0002ze-78@HIDDEN> <87y1zcjljm.fsf@HIDDEN>
<E1nnhoI-0007PC-RC@HIDDEN> <87ilqfcagd.fsf@HIDDEN>
<87senll5zd.fsf@HIDDEN>
<5ebb0fda-3db2-45ef-bc44-f9e18a6f004d@HIDDEN>
Date: Fri, 14 Mar 2025 11:37:13 +0800
Message-ID: <87ldt82sgm.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 55310
Cc: 55310 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hello,
On Wed 12 Mar 2025 at 10:11am +02, Dmitry Gutov wrote:
> On 10/03/2025 09:06, Sean Whitton wrote:
>>>> Idea (ideas are cheap): maybe if one could add some sort of
>>>> high-light, or something in vc-dired that shows that this or that file
>>>> has a open buffer that is unmodified, and then the error could be the
>>>> same but just saying that one should check the highlighted buffers.
>>> I think that's a good idea -- perhaps Dmitry has some comments; added to
>>> the CCs.
>> ISTM that a project-save-some-buffers is what's wanted here.
>> Dmitry, has there been a discussion about having something like that?
>
> Last time this came up, a new value for save-some-buffers-default-predicate
> was added: save-some-buffers-root (bug#46374). So:
>
> (setopt save-some-buffers-default-predicate #'save-some-buffers-root)
Ah, thanks for the reference.
I would like to do one of the following things:
(1) Do add the call to save-some-buffers in Lars's message.
We can change the error message to
"Some unsaved buffers remain; cannot revert"
and then I don't agree with him that the situation is confusing.
(2) Add a project-save-some-buffers which just binds
save-some-buffers-default-predicate around a call to
save-some-buffers, bind is to 'C-x p C-x s' (useful anyway, I think)
and change the message to suggest using it:
"Use C-x p C-x s to save or kill modified buffers before reverting"
WDYT?
--
Sean Whitton
bug-gnu-emacs@HIDDEN:bug#55310; Package emacs.
Full text available.Received: (at 55310) by debbugs.gnu.org; 12 Mar 2025 08:12:02 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Mar 12 04:12:02 2025 Received: from localhost ([127.0.0.1]:47193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tsHC6-0000I7-1z for submit <at> debbugs.gnu.org; Wed, 12 Mar 2025 04:12:02 -0400 Received: from forward500d.mail.yandex.net ([2a02:6b8:c41:1300:1:45:d181:d500]:45418) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <dgutov@HIDDEN>) id 1tsHC2-0000HU-7V for 55310 <at> debbugs.gnu.org; Wed, 12 Mar 2025 04:11:59 -0400 Received: from mail-nwsmtp-smtp-production-main-84.klg.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-84.klg.yp-c.yandex.net [IPv6:2a02:6b8:c42:8741:0:640:b274:0]) by forward500d.mail.yandex.net (Yandex) with ESMTPS id C83E16167A; Wed, 12 Mar 2025 11:11:51 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-84.klg.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id mBmRw3MLmuQ0-4ZEgGkEb; Wed, 12 Mar 2025 11:11:50 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1741767111; bh=0uvo3tXYyLPPLorGhcdZy2x78Aocx1m0zC+HIiRtlOU=; h=In-Reply-To:From:Subject:Message-ID:References:Date:To; b=Ua3aR7u0V8mNKF4SHjfYqMAwv4q6lqCMBOPKOer1VcILjwSWH+VEe2eXiYql28E8E 9KjSmmUh6540lF10y2GfRh14M1nHs43ZEJAuAUOhUx5RpoXYpL7EUHv2L7FSxlZRlR ma/7ocqewXNQB5d9EjALXXwAzkMrO4qWe9AbaILg= Authentication-Results: mail-nwsmtp-smtp-production-main-84.klg.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Received: from phl-compute-07.internal (phl-compute-07.phl.internal [10.202.2.47]) by mailfauth.phl.internal (Postfix) with ESMTP id B251A1200043; Wed, 12 Mar 2025 04:11:48 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-07.internal (MEProxy); Wed, 12 Mar 2025 04:11:48 -0400 X-ME-Sender: <xms:xEHRZ6dH85LTbV9BAfcSRp9ZuZsL5xTRiYfSNmX2mTa-GtAmbbXzGQ> <xme:xEHRZ0Oo30tN32-3C11-7iMy4E1MZoKFVag_7uUBn-gjhIxjwGM4V1OspCKzrnAXO _iQx31ZJWEb98kWHvI> X-ME-Received: <xmr:xEHRZ7gui25afUFsmhcKoeJLDqRn4S0GKDaBnOp1WlYjNFw5u2SVxSZnazj3AJ-8nSps> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduvdegheehucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvfhfhjggtgfesthejredttddv jeenucfhrhhomhepffhmihhtrhihucfiuhhtohhvuceoughguhhtohhvseihrghnuggvgi drrhhuqeenucggtffrrghtthgvrhhnpeetledtgfffheelgfeuheetleegueellefgudef ieejvdeuhfduueeuvdeikeduleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpegughhuthhovhdomhgvshhmthhprghuthhhphgvrhhsohhnrghl ihhthidqudeffeefleelheehvddqvdelgeejjeejjeeiqdgughhuthhovheppeihrghnug gvgidrrhhusehfrghsthhmrghilhdrtghomhdpnhgspghrtghpthhtohepfedpmhhouggv pehsmhhtphhouhhtpdhrtghpthhtohepshhpfihhihhtthhonhesshhpfihhihhtthhonh drnhgrmhgvpdhrtghpthhtoheprghmshesghhnuhdrohhrghdprhgtphhtthhopeehheef uddtseguvggssghughhsrdhgnhhurdhorhhg X-ME-Proxy: <xmx:xEHRZ3-gvwONJpSfzPu2xE-BoxCllRQMzgYuRw8UrUML3_YmwX33aQ> <xmx:xEHRZ2s0IRYv5gfqpoUykJ34Js3Trh9gQaqVGS8xsG8EOoWtDlA8Tw> <xmx:xEHRZ-EPxt5tHM1Rj6-nMrHoYGHosITKOe91GnwnAjkxCzvhxLRozw> <xmx:xEHRZ1N6ogDI5TIGAkT0CK_eW5u8LHQy2e_j4Rgta4_45FR6SRp1ng> <xmx:xEHRZzN0SQZGZk60cb7QGGsYtOsXyJyfpcni2Zu30K6colhJCEp3W1GF> Feedback-ID: ib1d9465d:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 12 Mar 2025 04:11:47 -0400 (EDT) Message-ID: <5ebb0fda-3db2-45ef-bc44-f9e18a6f004d@HIDDEN> Date: Wed, 12 Mar 2025 10:11:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#55310: 27.2; vc-revert: unhelpful error message when modified buffers exist To: Sean Whitton <spwhitton@HIDDEN>, "Alfred M. Szmidt" <ams@HIDDEN>, 55310 <at> debbugs.gnu.org References: <E1nnbY0-0002ze-78@HIDDEN> <87y1zcjljm.fsf@HIDDEN> <E1nnhoI-0007PC-RC@HIDDEN> <87ilqfcagd.fsf@HIDDEN> <87senll5zd.fsf@HIDDEN> Content-Language: en-US From: Dmitry Gutov <dgutov@HIDDEN> In-Reply-To: <87senll5zd.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55310 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On 10/03/2025 09:06, Sean Whitton wrote: >>> Idea (ideas are cheap): maybe if one could add some sort of >>> high-light, or something in vc-dired that shows that this or that file >>> has a open buffer that is unmodified, and then the error could be the >>> same but just saying that one should check the highlighted buffers. >> I think that's a good idea -- perhaps Dmitry has some comments; added to >> the CCs. > ISTM that a project-save-some-buffers is what's wanted here. > > Dmitry, has there been a discussion about having something like that? Last time this came up, a new value for save-some-buffers-default-predicate was added: save-some-buffers-root (bug#46374). So: (setopt save-some-buffers-default-predicate #'save-some-buffers-root)
bug-gnu-emacs@HIDDEN:bug#55310; Package emacs.
Full text available.
Received: (at 55310) by debbugs.gnu.org; 10 Mar 2025 07:06:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Mar 10 03:06:44 2025
Received: from localhost ([127.0.0.1]:36140 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1trXDn-0006hn-LY
for submit <at> debbugs.gnu.org; Mon, 10 Mar 2025 03:06:44 -0400
Received: from sendmail.purelymail.com ([34.202.193.197]:53260)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>)
id 1trXDk-0006hY-Js
for 55310 <at> debbugs.gnu.org; Mon, 10 Mar 2025 03:06:41 -0400
DKIM-Signature: a=rsa-sha256;
b=Asd49/F+I2Ni+IoPJ7BCmdcdD0eu+oC5vKnG2C2KMDWdz9H9qCOqbKqBgji6xGNZdMwx1Uod8d/GArq2+PzmmY3ct+2AQO/otGWMslpZv/xmQ2vz2rWh8GwZ63QSGy/vtSthOMPN27gus8EfdjRvac5Xqc5swRwoOvGLUWlncCr3zlKhwBpcgBzVbSfHslui9Prw0V9pe/LfxXFw1H0Ijn2wqD/JolYAV6Q4WNNsLOjbQsTQt28O1WsThmXjSyjCL7CcIs7jItGnftxg6+CPZXg7scF0cYE0qYL7HDi4WMkhaE/djOmzBFp/WoTzedKtcG3/u5M4+kzpGM+Lcr2/SA==;
s=purelymail3; d=spwhitton.name; v=1;
bh=9Tlc1XNV2ioZgCHwqE9GJAlk9wqQSpxxir4Jg2AWiR4=;
h=Received:Received:From:To:Subject:Date;
DKIM-Signature: a=rsa-sha256;
b=QpSRlQ9l0YM6kigkS3GiPQh5Bg+RLU03LfBmjGgWg+ofqJfmf7/MhQp7ppneZxePK+lBqfbTH66PxBV4nP8CeveInR9scaamBy0PBceDnQDhcH/zf7h4xpj01SU1HmPRKz6Ckd3mPNDCx1hgVvmIXxCbBpGCXN7ip3DfnRmvAZxPcZJE4BQKYHjAS+gtyM8mXopyRXbKVVyzX9deUb6Jrore2SX1uTgp/Hu5Ra2d89zdtufaaIxRoNXSRhOSa3TRXY+TxnM4H/ijJtc5vIFfm57VJMrywJMwIE5NhpDDtYfOIea8v8Eq7yAXaDVK8MHWWxvNfjjMpwmTHjN1t/c8mg==;
s=purelymail3; d=purelymail.com; v=1;
bh=9Tlc1XNV2ioZgCHwqE9GJAlk9wqQSpxxir4Jg2AWiR4=;
h=Feedback-ID:Received:Received:From:To:Subject:Date;
Feedback-ID: 20115:3760:null:purelymail
X-Pm-Original-To: 55310 <at> debbugs.gnu.org
Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -452311634;
(version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384);
Mon, 10 Mar 2025 07:06:32 +0000 (UTC)
Received: by melete.silentflame.com (Postfix, from userid 1000)
id 2178C7E0864; Mon, 10 Mar 2025 15:06:30 +0800 (CST)
From: Sean Whitton <spwhitton@HIDDEN>
To: "Alfred M. Szmidt" <ams@HIDDEN>, 55310 <at> debbugs.gnu.org, Dmitry Gutov
<dgutov@HIDDEN>
Subject: Re: bug#55310: 27.2; vc-revert: unhelpful error message when
modified buffers exist
In-Reply-To: <87ilqfcagd.fsf@HIDDEN>
References: <E1nnbY0-0002ze-78@HIDDEN> <87y1zcjljm.fsf@HIDDEN>
<E1nnhoI-0007PC-RC@HIDDEN> <87ilqfcagd.fsf@HIDDEN>
Date: Mon, 10 Mar 2025 15:06:30 +0800
Message-ID: <87senll5zd.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 55310
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hello,
On Mon 09 May 2022 at 11:38am +02, Lars Ingebrigtsen wrote:
> "Alfred M. Szmidt" <ams@HIDDEN> writes:
>
>> I don't think we want to have an interface that offers to kill buffers
>> in a loop -- it sounds like something that's really error-prone, which
>> is why that code is the way it is, I think. (To make the user make the
>> decision themselves explicitly.)
>>
>> We already support such mechanism I think in several other places,
>> like ibuffer, etc.
>
> Sure, but that's a mode to list and act on buffers -- having vc-revert
> kill buffers (even after querying the user) would be surprising.
Currently C-x v u from an individual file's buffer does prompt you to
save it, so it would be good to extend it to this case in VC-Dir.
>> My main problem is really that it is impossible to know _which_
>> buffers are modified, if you have several hundred open in several
>> different projects -- in addition to the fact that the error message
>> is just wrong ("all buffers" -- it is just some buffers, that are
>> marked).
>
> Yes, it would be nice if it actually said which buffers it's talking
> about.
>
>> Idea (ideas are cheap): maybe if one could add some sort of
>> high-light, or something in vc-dired that shows that this or that file
>> has a open buffer that is unmodified, and then the error could be the
>> same but just saying that one should check the highlighted buffers.
>
> I think that's a good idea -- perhaps Dmitry has some comments; added to
> the CCs.
ISTM that a project-save-some-buffers is what's wanted here.
Dmitry, has there been a discussion about having something like that?
--
Sean Whitton
bug-gnu-emacs@HIDDEN:bug#55310; Package emacs.
Full text available.Lars Ingebrigtsen <larsi@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at 55310) by debbugs.gnu.org; 9 May 2022 09:38:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 09 05:38:36 2022
Received: from localhost ([127.0.0.1]:56117 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nnzqe-0002jV-Im
for submit <at> debbugs.gnu.org; Mon, 09 May 2022 05:38:36 -0400
Received: from quimby.gnus.org ([95.216.78.240]:39842)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <larsi@HIDDEN>) id 1nnzqc-0002jH-MB
for 55310 <at> debbugs.gnu.org; Mon, 09 May 2022 05:38:35 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=z+AblMsPep8f1IgVAqrtkVeKoX1mlzCh+zCiruhq92o=; b=CBQy40VXifa8afaJtPBOhClGQ3
xoWsmB9ojuRnX2KEFeAIeuKDw2iQchn3HeDC/Ai77KIqzdILr9ydePh27FTcmBSR1DEjzjciIB04d
Tr/JfwbfuqKDKrgkskDOq3n6X6a0jTEbds/r5/H4HunIAaduuZ7BZxt4vdPzRnVPC3sY=;
Received: from [84.212.220.105] (helo=xo)
by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92) (envelope-from <larsi@HIDDEN>)
id 1nnzqU-00044d-Jj; Mon, 09 May 2022 11:38:28 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: "Alfred M. Szmidt" <ams@HIDDEN>
Subject: Re: bug#55310: 27.2; vc-revert: unhelpful error message when
modified buffers exist
References: <E1nnbY0-0002ze-78@HIDDEN> <87y1zcjljm.fsf@HIDDEN>
<E1nnhoI-0007PC-RC@HIDDEN>
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj
SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAIVBMVEX9/f0hDA67wq9T
qNr2723e3diWXk27olJdTkhSp7b///+JyUX3AAAAAWJLR0QKaND0VgAAAAd0SU1FB+YFCQkjMC6A
7ocAAAGVSURBVDjLtdG/T4NAFAfwy5Grrmdsy4inJR2bEBO7GYLWkTQe0c0QSxlNh9qx0BRulsX7
b70fTXtAm+jgGxj48H3v3gHAoS4sz/NAoIoa70FvD0sBiO6RaVgmCZujIwkBaQ2QmhHKVqvABGiC
ORx2JXQuFdy3Ei8SnoKH1owjoE8V9QQ8Br4JtgQ616uboBak722wT4AeTssW6D12YJ6q8yuobd6F
nneXMblIEJrQF4kMZ7jfAFAg8ooF2I1Was4BIocs4imcExK7cX6GRfUUDNcJWxPIooLlcY4k9NVx
h9uU5QQWLkvLPEcMY7tU4G6ZTrC02OYI6k4CosQlcURcogpNRWJS3xwl8pHZYg9KqbFHlHyIJTFm
2JZfHMD9jAlZiU4423DOzcQMDDN5XLypxgagQYjKKw21hKpzBRWvmgDle3vMq3ED0Le4w4o34DkI
fNG94k2QV8F1/St83fhkQK+92ybsLtwanQA4+ksCib9kOcBCoeOEFISIEt8PEllvwApbicmC6kQD
Jhrqw8Ul6lYzgEY/cgiymJjq9IAAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjItMDUtMDlUMDk6MzU6
NDgrMDA6MDCOxssmAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIyLTA1LTA5VDA5OjM1OjQ4KzAwOjAw
/5tzmgAAAABJRU5ErkJggg==
X-Now-Playing: Blaine L. Reininger's _Broken Fingers_: "Broken Fingers"
Date: Mon, 09 May 2022 11:38:26 +0200
In-Reply-To: <E1nnhoI-0007PC-RC@HIDDEN> (Alfred M. Szmidt's message
of "Sun, 08 May 2022 10:22:58 -0400")
Message-ID: <87ilqfcagd.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: "Alfred M. Szmidt" <ams@HIDDEN> writes: > I don't think we
want to have an interface that offers to kill buffers > in a loop -- it sounds
like something that's really error-prone, which > is why that code is the
way it is, I think. (To make [...]
Content analysis details: (-2.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 55310
Cc: 55310 <at> debbugs.gnu.org, Dmitry Gutov <dgutov@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
"Alfred M. Szmidt" <ams@HIDDEN> writes:
> I don't think we want to have an interface that offers to kill buffers
> in a loop -- it sounds like something that's really error-prone, which
> is why that code is the way it is, I think. (To make the user make the
> decision themselves explicitly.)
>
> We already support such mechanism I think in several other places,
> like ibuffer, etc.
Sure, but that's a mode to list and act on buffers -- having vc-revert
kill buffers (even after querying the user) would be surprising.
> My main problem is really that it is impossible to know _which_
> buffers are modified, if you have several hundred open in several
> different projects -- in addition to the fact that the error message
> is just wrong ("all buffers" -- it is just some buffers, that are
> marked).
Yes, it would be nice if it actually said which buffers it's talking
about.
> Idea (ideas are cheap): maybe if one could add some sort of
> high-light, or something in vc-dired that shows that this or that file
> has a open buffer that is unmodified, and then the error could be the
> same but just saying that one should check the highlighted buffers.
I think that's a good idea -- perhaps Dmitry has some comments; added to
the CCs.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#55310; Package emacs.
Full text available.
Received: (at 55310) by debbugs.gnu.org; 8 May 2022 14:23:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 08 10:23:06 2022
Received: from localhost ([127.0.0.1]:54990 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nnhoQ-0005ql-84
for submit <at> debbugs.gnu.org; Sun, 08 May 2022 10:23:06 -0400
Received: from eggs.gnu.org ([209.51.188.92]:46718)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ams@HIDDEN>) id 1nnhoO-0005q5-DE
for 55310 <at> debbugs.gnu.org; Sun, 08 May 2022 10:23:04 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:57066)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <ams@HIDDEN>)
id 1nnhoJ-0002lX-0u; Sun, 08 May 2022 10:22:59 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=Date:References:Subject:In-Reply-To:To:From:
mime-version; bh=0aMcdm+GqDT5pARd8qXn08XYthH6KwPKXJS+mPNLt7c=; b=Te6DgRdBayg4
lq/66rjOzvqiZPKuyQd4MsW1XzRqmUVxOnrlj4ZzN4nzSVn9jVsENTd7XnQivc0oxqJTuJnqbQIwZ
qp3p94DN6nybSYbiUwBW84CjxsisQYC/0PBeIRGr9zD/MI7y8V3B6YUrrY/PsDzyEsY3shKBoFF1V
YTn8EbQgOoLO1HW32OSJGw6B2MdyjPSacJT1KqB8lFAX3bqqnDeZZAF8AXw0mF2qTqiXmPJAVfytE
XpuNRPIrtZFLiQ+LdFPj4qUB3eJw/41flKRpKXoruAVd2lEpzhI1Z1KLECUPIm8mCb4qV4M+W0Z8+
Ak40eDXWfgWDjHJDcLfosQ==;
Received: from ams by fencepost.gnu.org with local (Exim 4.90_1)
(envelope-from <ams@HIDDEN>)
id 1nnhoI-0007PC-RC; Sun, 08 May 2022 10:22:58 -0400
From: "Alfred M. Szmidt" <ams@HIDDEN>
To: Lars Ingebrigtsen <larsi@HIDDEN>
In-Reply-To: <87y1zcjljm.fsf@HIDDEN> (message from Lars Ingebrigtsen on Sun,
08 May 2022 13:44:45 +0200)
Subject: Re: bug#55310: 27.2; vc-revert: unhelpful error message when
modified buffers exist
References: <E1nnbY0-0002ze-78@HIDDEN> <87y1zcjljm.fsf@HIDDEN>
Message-Id: <E1nnhoI-0007PC-RC@HIDDEN>
Date: Sun, 08 May 2022 10:22:58 -0400
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 55310
Cc: 55310 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
"Alfred M. Szmidt" <ams@HIDDEN> writes:
> When doing vc-revert in a vc-dir buffer, and when one has a bunch of
> open files, one somtimes gets the unhelpful message:
>
> vc-revert: Please kill or save all modified buffers before reverting
>
> Nicer would be prompting the user to kill/save those buffers, or list them.
I don't think we want to have an interface that offers to kill buffers
in a loop -- it sounds like something that's really error-prone, which
is why that code is the way it is, I think. (To make the user make the
decision themselves explicitly.)
We already support such mechanism I think in several other places,
like ibuffer, etc.
My main problem is really that it is impossible to know _which_
buffers are modified, if you have several hundred open in several
different projects -- in addition to the fact that the error message
is just wrong ("all buffers" -- it is just some buffers, that are
marked).
Idea (ideas are cheap): maybe if one could add some sort of
high-light, or something in vc-dired that shows that this or that file
has a open buffer that is unmodified, and then the error could be the
same but just saying that one should check the highlighted buffers.
So I think leaving it the way it is is the best option here, since this
command is one of the most potentially destructive ones we have in
Emacs. Anybody have an opinion here?
The destructiveness of vc-revert also depends on the version control
system, fossil provides a undo mechanism. But doing delete on files
in dired is far worse ... :-)
bug-gnu-emacs@HIDDEN:bug#55310; Package emacs.
Full text available.Lars Ingebrigtsen <larsi@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at 55310) by debbugs.gnu.org; 8 May 2022 11:44:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 08 07:44:58 2022
Received: from localhost ([127.0.0.1]:53494 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nnfLN-0004u2-Q6
for submit <at> debbugs.gnu.org; Sun, 08 May 2022 07:44:58 -0400
Received: from quimby.gnus.org ([95.216.78.240]:57926)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <larsi@HIDDEN>) id 1nnfLM-0004tn-7t
for 55310 <at> debbugs.gnu.org; Sun, 08 May 2022 07:44:56 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=R3ayTrpiILGA5Cl7aRrWAxE/eJcfHU1PSTb5aS7LqU0=; b=ZTxgBCn7cz3lsWtGcKpfFQ7G2i
t8Fq4Eyq9mEzWPp4VAiGtvfhD96JpOZtXEg1lfiLUVqZOmxLYE0lITzG6Om90nj5HLynVNZx3i4Xv
LaGH0t5r82CRh8Llj+2g1UBZEOJoE+WEa8w0eVHeGkA7EEqlbWMTEXcRYWP5zPcfGFhI=;
Received: from [84.212.220.105] (helo=xo)
by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92) (envelope-from <larsi@HIDDEN>)
id 1nnfLD-0007tK-3l; Sun, 08 May 2022 13:44:49 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: "Alfred M. Szmidt" <ams@HIDDEN>
Subject: Re: bug#55310: 27.2; vc-revert: unhelpful error message when
modified buffers exist
References: <E1nnbY0-0002ze-78@HIDDEN>
X-Now-Playing: Nina Simone's _The Montreux Years (1)_: "Don't Smoke in Bed
(Live At Casino Montreux, 13th July 1990)"
Date: Sun, 08 May 2022 13:44:45 +0200
In-Reply-To: <E1nnbY0-0002ze-78@HIDDEN> (Alfred M. Szmidt's message
of "Sun, 08 May 2022 03:41:44 -0400")
Message-ID: <87y1zcjljm.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: "Alfred M. Szmidt" <ams@HIDDEN> writes: > When doing
vc-revert
in a vc-dir buffer, and when one has a bunch of > open files, one somtimes
gets the unhelpful message: > > vc-revert: Please kill or save all modified
buffers before reverting > [...]
Content analysis details: (-2.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 55310
Cc: 55310 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
"Alfred M. Szmidt" <ams@HIDDEN> writes:
> When doing vc-revert in a vc-dir buffer, and when one has a bunch of
> open files, one somtimes gets the unhelpful message:
>
> vc-revert: Please kill or save all modified buffers before reverting
>
> Nicer would be prompting the user to kill/save those buffers, or list them.
I don't think we want to have an interface that offers to kill buffers
in a loop -- it sounds like something that's really error-prone, which
is why that code is the way it is, I think. (To make the user make the
decision themselves explicitly.)
We could do this, of course:
diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el
index 3508f684c4..cb5e42db4c 100644
--- a/lisp/vc/vc.el
+++ b/lisp/vc/vc.el
@@ -2780,6 +2780,10 @@ vc-revert
;; show the changes and ask for confirmation to discard them.
(when (or (not files) (memq (buffer-file-name) files))
(vc-buffer-sync nil))
+ ;; Offer to save all the buffers we're reverting.
+ (save-some-buffers
+ nil (lambda ()
+ (member (buffer-file-name) files)))
(dolist (file files)
(let ((buf (get-file-buffer file)))
(when (and buf (buffer-modified-p buf))
But if the user answers "no", then it'll just signal an error anyway, so
that's just confusing.
So I think leaving it the way it is is the best option here, since this
command is one of the most potentially destructive ones we have in
Emacs. Anybody have an opinion here?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#55310; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 8 May 2022 07:41:48 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 08 03:41:48 2022 Received: from localhost ([127.0.0.1]:53369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1nnbY3-000548-Tb for submit <at> debbugs.gnu.org; Sun, 08 May 2022 03:41:48 -0400 Received: from lists.gnu.org ([209.51.188.17]:46688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ams@HIDDEN>) id 1nnbY2-000541-LK for submit <at> debbugs.gnu.org; Sun, 08 May 2022 03:41:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59796) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ams@HIDDEN>) id 1nnbY2-00066n-EY for bug-gnu-emacs@HIDDEN; Sun, 08 May 2022 03:41:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51316) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ams@HIDDEN>) id 1nnbY1-0001iE-9Z for bug-gnu-emacs@HIDDEN; Sun, 08 May 2022 03:41:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Date:Subject:To:From:mime-version:in-reply-to: references; bh=+XdC70lxHP2SJeTmdOQorJ8SYDUrynsq1Yru9s9G0CM=; b=Bge/TKOrviptFT +62zDF06jrAgl8xM4D9qFV2vUGNpVFN09Un0VaRptELu5B/3G7/mmYE+dZ3D5VWoqtcFEQjr/hUl7 PurrOWM+VDE+ndzdzpkCVZL86Nm1OgmpbKWyoYbg9JKWxhg3ZGQN8PEGJIFwFGR+3VKsLQzTSNEEq LsJ8lUylcaoe6NakaDy5tOXx8LJ7sGPV7PnpoxNS5p3ogCk4HQy6awx/lMNomhZcQuHioonoLDWii P8PxtZva5AiFsRG2DvzBxRDYTDMTrIHSs/JSp3vhEUsX+wECSehzt8wvOR1wQaXMgwY4RAXFHnRdX s2B0r0tTjzGVGy2UkcLQ==; Received: from ams by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from <ams@HIDDEN>) id 1nnbY0-0002ze-78 for bug-gnu-emacs@HIDDEN; Sun, 08 May 2022 03:41:44 -0400 From: "Alfred M. Szmidt" <ams@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: 27.2; vc-revert: unhelpful error message when modified buffers exist Message-Id: <E1nnbY0-0002ze-78@HIDDEN> Date: Sun, 08 May 2022 03:41:44 -0400 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) When doing vc-revert in a vc-dir buffer, and when one has a bunch of open files, one somtimes gets the unhelpful message: vc-revert: Please kill or save all modified buffers before reverting Nicer would be prompting the user to kill/save those buffers, or list them. In GNU Emacs 27.2 (build 1, x86_64-unknown-openbsd, GTK+ Version 3.24.33) of 2022-04-09 built on amd64.ports.openbsd.org System Description: OpenBSD nitrogenium.mendeleev 7.1 GENERIC.MP#465 amd64 Recent messages: INFO Scraping files for loaddefs.el...done Loading /home/ams/loaddefs.el (source)...done Loading /home/ams/quicklisp/slime-helper.el (source)...done Loading /home/ams/quicklisp/clhs-use-local.el (source)...done Loading /home/ams/private/emacs-nitrogenium.mendeleev...done For information about GNU Emacs and the GNU system, type C-h C-a. Configured using: 'configure --build=amd64-unknown-openbsd --without-sound --with-x-toolkit=gtk3 --prefix=/usr/local --sysconfdir=/etc --mandir=/usr/local/man --infodir=/usr/local/info --localstatedir=/var --disable-silent-rules --disable-gtk-doc 'CFLAGS=-O2 -pipe -g' CPPFLAGS=-I/usr/local/include 'LDFLAGS=-L/usr/local/lib -g'' Configured features: XPM JPEG TIFF GIF PNG RSVG DBUS GSETTINGS GLIB NOTIFY KQUEUE GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS JSON PDUMPER LCMS2 GMP Important settings: locale-coding-system: nil Major mode: Fundamental Minor modes in effect: global-company-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t transient-mark-mode: t Load-path shadows: ~/loaddefs hides /usr/local/share/emacs/27.2/lisp/loaddefs Features: (shadow mailalias emacsbug message rmc puny dired dired-loaddefs format-spec rfc822 mml mml-sec epa epg epg-config gnus-util rmail rmail-loaddefs text-property-search mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader term/screen term/xterm xterm rcirc time-date mail-queue sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils slime-asdf grep slime-quicklisp slime-fancy slime-indentation slime-cl-indent cl-indent slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references slime-compiler-notes-tree slime-scratch slime-presentations advice bridge slime-macrostep macrostep slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc slime-repl elp slime-parse slime derived cl-extra help-mode gud apropos compile arc-mode archive-mode noutline outline easy-mmode pp comint ansi-color hyperspec thingatpt slime-autoloads company-oddmuse company-keywords company-etags etags fileloop generator xref project ring company-gtags company-dabbrev-code company-dabbrev company-files company-capf company-cmake company-xcode company-clang company-semantic company-eclim company-template company-bbdb company edmacro kmacro pcase cal-menu calendar cal-loaddefs autoload radix-tree lisp-mnt finder-inf disp-table package easymenu browse-url url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind kqueue lcms2 dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 190926 10037) (symbols 48 15424 2) (strings 32 47013 758) (string-bytes 1 1409610) (vectors 16 17009) (vector-slots 8 200499 8642) (floats 8 62 187) (intervals 56 260 129) (buffers 1000 12))
"Alfred M. Szmidt" <ams@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#55310; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.