GNU logs - #56657, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#56657] [PATCH] gnu: ranger: Add dependency file
Resent-From: =?UTF-8?Q?Nguy=E1=BB=85n?= Gia Phong <mcsinyx@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 20 Jul 2022 08:50:02 +0000
Resent-Message-ID: <handler.56657.B.165830697221233 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 56657 <at> debbugs.gnu.org
Cc: =?UTF-8?Q?Nguy=E1=BB=85n?= Gia Phong <mcsinyx@HIDDEN>
From: =?UTF-8?Q?Nguy=E1=BB=85n?= Gia Phong <mcsinyx@HIDDEN>
Date: Wed, 20 Jul 2022 17:01:43 +0900
Message-Id: <20220720080143.18005-1-mcsinyx@HIDDEN>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=178.21.23.139; envelope-from=mcsinyx@HIDDEN;
 helo=knopi.disroot.org
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Mailman-Approved-At: Wed, 20 Jul 2022 04:49:30 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

While file is an optional dependency, without it
file type determination and opening does not work out of the box.
---
 gnu/packages/disk.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/disk.scm b/gnu/packages/disk.scm
index 47b15e588f79..58bd3db3812c 100644
--- a/gnu/packages/disk.scm
+++ b/gnu/packages/disk.scm
@@ -24,6 +24,7 @@
 ;;; Copyright © 2021 Justin Veilleux <terramorpha@HIDDEN>
 ;;; Copyright © 2014, 2022 Ludovic Courtès <ludo@HIDDEN>
 ;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer@HIDDEN>
+;;; Copyright © 2022 Nguyễn Gia Phong <mcsinyx@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -800,7 +801,7 @@ (define-public ranger
                 "0lfjrpv3z4h0knd3v94fijrw2zjba51mrp3mjqx2c98wr428l26f"))))
     (build-system python-build-system)
     (inputs
-     (list w3m))
+     (list file w3m))
     (native-inputs
      (list which
            ;; For tests.
@@ -815,11 +816,13 @@ (define-public ranger
            (lambda* (#:key inputs outputs #:allow-other-keys)
              (let* ((out  (assoc-ref outputs "out"))
                     (ranger (string-append out "/bin/ranger"))
+                    (file (assoc-ref inputs "file"))
                     (w3m (assoc-ref inputs "w3m"))
                     (w3mimgdisplay (string-append w3m
                                    "/libexec/w3m/w3mimgdisplay")))
                (wrap-program ranger
-                 `("W3MIMGDISPLAY_PATH" ":" prefix (,w3mimgdisplay)))
+                 `("W3MIMGDISPLAY_PATH" ":" prefix (,w3mimgdisplay))
+                 `("PATH" ":" prefix ,(list (string-append file "/bin"))))
                #t)))
          (replace 'check
            ;; The default check phase simply prints 'Ran 0 tests in 0.000s'.
-- 
2.37.0

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: =?UTF-8?Q?Nguy=E1=BB=85n?= Gia Phong <mcsinyx@HIDDEN>
Subject: bug#56657: Acknowledgement ([PATCH] gnu: ranger: Add dependency file)
Message-ID: <handler.56657.B.165830697221233.ack <at> debbugs.gnu.org>
References: <20220720080143.18005-1-mcsinyx@HIDDEN>
X-Gnu-PR-Message: ack 56657
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 56657 <at> debbugs.gnu.org
Date: Wed, 20 Jul 2022 08:50:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 56657 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
56657: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D56657
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#56657] [PATCH] gnu: ranger: Add dependency file
Resent-From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 21 Jul 2022 06:51:01 +0000
Resent-Message-ID: <handler.56657.B56657.165838626022589 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: =?UTF-8?Q?Nguy=E1=BB=85n?= Gia Phong <mcsinyx@HIDDEN>,  56657 <at> debbugs.gnu.org
Message-ID: <223585fd44f0b8e94d85aacd6885d01432b5e3e0.camel@HIDDEN>
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Date: Thu, 21 Jul 2022 08:50:52 +0200
In-Reply-To: <20220720080143.18005-1-mcsinyx@HIDDEN>
References: <20220720080143.18005-1-mcsinyx@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Am Mittwoch, dem 20.07.2022 um 17:01 +0900 schrieb Nguyễn Gia Phong:
> While file is an optional dependency, without it
> file type determination and opening does not work out of the box.
Rather than patching PATH, you should use substitute* to hardcode the
reference.  Also, do write a ChangeLog style commit message.

Cheers

Message sent to guix-patches@HIDDEN:

Subject: [bug#56657] [PATCH] gnu: ranger: Add dependency file
Resent-From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 26 Jul 2022 07:50:01 +0000
Resent-Message-ID: <handler.56657.B56657.165882174628602 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: =?UTF-8?Q?Nguy=E1=BB=85n?= Gia Phong <mcsinyx@HIDDEN>,  56657 <at> debbugs.gnu.org
Message-ID: <3b9ad15ef70095a116c2657017808d0783a9c44e.camel@HIDDEN>
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Date: Tue, 26 Jul 2022 09:48:55 +0200
In-Reply-To: <CLPF3SUOY06B.2ONLNWJ9RSI7V@nix>
References: <20220720080143.18005-1-mcsinyx@HIDDEN>
 <223585fd44f0b8e94d85aacd6885d01432b5e3e0.camel@HIDDEN>
 <CLPF3SUOY06B.2ONLNWJ9RSI7V@nix>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Am Dienstag, dem 26.07.2022 um 16:43 +0900 schrieb Nguyễn Gia Phong:
> On Thu Jul 21, 2022 at 8:50 AM +0200, Liliana Marie Prikler wrote:
> > Rather than patching PATH, you should use substitute*
> > to hardcode the reference.
> 
> Coming from Nix, I don't get why is it preferred.
> Shouldn't users be able to override runtime dependencies at runtime,
> e.g. via a custom wrapper script?
In Guix we prefer not to rely on the environment because that breaks
the case of pure shells.  We have transformations, which are more
powerful than wrapper scripts.

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#56657] [PATCH] gnu: ranger: Add dependency file
Resent-From: =?UTF-8?Q?Nguy=E1=BB=85n?= Gia Phong <mcsinyx@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 26 Jul 2022 15:30:02 +0000
Resent-Message-ID: <handler.56657.B56657.165884938920737 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 56657
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: "Liliana Marie Prikler" <liliana.prikler@HIDDEN>, <56657 <at> debbugs.gnu.org>
Received: via spool by 56657-submit <at> debbugs.gnu.org id=B56657.165884938920737
          (code B ref 56657); Tue, 26 Jul 2022 15:30:02 +0000
Received: (at 56657) by debbugs.gnu.org; 26 Jul 2022 15:29:49 +0000
Received: from localhost ([127.0.0.1]:54200 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oGMVI-0005OP-K9
	for submit <at> debbugs.gnu.org; Tue, 26 Jul 2022 11:29:49 -0400
Received: from knopi.disroot.org ([178.21.23.139]:33090)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mcsinyx@HIDDEN>) id 1oGFDl-0007Ep-Qy
 for 56657 <at> debbugs.gnu.org; Tue, 26 Jul 2022 03:43:16 -0400
Received: from localhost (localhost [127.0.0.1])
 by disroot.org (Postfix) with ESMTP id 34D0440DC3;
 Tue, 26 Jul 2022 09:43:12 +0200 (CEST)
X-Virus-Scanned: SPAM Filter at disroot.org
Received: from knopi.disroot.org ([127.0.0.1])
 by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id cbQJBPJK6Ja3; Tue, 26 Jul 2022 09:43:11 +0200 (CEST)
Mime-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
 t=1658821391; bh=9mxULXOIASMUe/x022CrbZ0+T2oFz4X3HofhGdjxMgk=;
 h=Date:To:From:Subject:References:In-Reply-To;
 b=iBjvlftg90+yHVbFzDl2lpRcWiXtWfGcmbKpZZLi7CD/5tbvfgQhiEAhUSehlQq1j
 3dhZtSurRnR6E56pjwrAWEvVCFnaODd9ttdrm+RbdgCrH3ytzSYTxBP9CHqLgrhyDM
 2DvNePT8TrjkEbt77jkI055E5vyKoPloKhlO+qyj6d2eyJJnexgQW5YhQoFqiSxNWL
 6tRH+DPaVBlPGZCv8HfVjPuwjyinqzgzxm9NKLTBSBGdU6/YKCcEneRjtiOvTJsCsI
 auR1xR84P8w7YKy9WXwl5BtJVRwZguke5Yynl1DrKrEIX5Ej+qiKJThL+MozyHLJCb
 qhrTZe1WUW3bQ==
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Tue, 26 Jul 2022 16:43:06 +0900
Message-Id: <CLPF3SUOY06B.2ONLNWJ9RSI7V@nix>
From: =?UTF-8?Q?Nguy=E1=BB=85n?= Gia Phong <mcsinyx@HIDDEN>
References: <20220720080143.18005-1-mcsinyx@HIDDEN>
 <223585fd44f0b8e94d85aacd6885d01432b5e3e0.camel@HIDDEN>
In-Reply-To: <223585fd44f0b8e94d85aacd6885d01432b5e3e0.camel@HIDDEN>
X-Spam-Score: 0.0 (/)
X-Mailman-Approved-At: Tue, 26 Jul 2022 11:29:47 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Thu Jul 21, 2022 at 8:50 AM +0200, Liliana Marie Prikler wrote:
> Rather than patching PATH, you should use substitute*
> to hardcode the reference.

Coming from Nix, I don't get why is it preferred.
Shouldn't users be able to override runtime dependencies at runtime,
e.g. via a custom wrapper script?

If that is the case, I suppose the correct wrapper would be

(wrap-program ...
  '("PATH" suffix ,(list (string-append file "/bin"))))

> Also, do write a ChangeLog style commit message.

Thanks, I probably missed this reading the contrib guide.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 4 Aug 2022 21:59:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Aug 04 17:59:04 2022
Received: from localhost ([127.0.0.1]:55229 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oJirw-0001ed-CV
	for submit <at> debbugs.gnu.org; Thu, 04 Aug 2022 17:59:04 -0400
Received: from eggs.gnu.org ([209.51.188.92]:56376)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1oJiru-0001df-Pb
 for control <at> debbugs.gnu.org; Thu, 04 Aug 2022 17:59:03 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:52504)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1oJirp-0000Ze-7J
 for control <at> debbugs.gnu.org; Thu, 04 Aug 2022 17:58:57 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to:
 references; bh=4HYrTv1hVFR3/3I4RgvQX1Ag4vmq8lpqpPtfRP2eYNI=; b=gulIRMer+rlRUm
 zicSVeMohlB5tTG74jOeQP5teYnJjdPYJXE07ReHlLVbEPirBXUt2zgTYMll4fnek6k6goDn6uOjL
 FlnjJ37LaUZMX/PA0M8SL1goA+JyufbMwIicHZ8nk8LkljUOsc/AObLBpxc2bejWRehXm7zhXjeXw
 cukqG+q31l/3RqsDS3cTV2ox/7yyZJJcuftuaufCe6qHqufZvgAz6olKBd+mif6Zc080ae3CuLOxa
 DXItAW5OfO+hhYoSGuZXScWlg1Wq6EKKAZjwEf3AdsaW9iQXBzdPWqw0u+v6h1pJ5pqVoMqu5tPSO
 Nyf1gXSPS3wpCN2uzgdw==;
Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:52378
 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1oJiro-0005K8-RH
 for control <at> debbugs.gnu.org; Thu, 04 Aug 2022 17:58:57 -0400
Date: Thu, 04 Aug 2022 23:58:55 +0200
Message-Id: <87r11vk6w0.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
Subject: control message for bug #56657
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

tags 56657 + moreinfo
quit

Last modified: Thu, 4 Aug 2022 22:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.