Received: (at 61274) by debbugs.gnu.org; 15 Feb 2025 21:04:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 15 16:04:04 2025 Received: from localhost ([127.0.0.1]:58235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tjPKV-0007YQ-OG for submit <at> debbugs.gnu.org; Sat, 15 Feb 2025 16:04:04 -0500 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:37037 helo=mail.qxqx.de) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <mail@HIDDEN>) id 1tjPKS-0007Xo-MY for 61274 <at> debbugs.gnu.org; Sat, 15 Feb 2025 16:04:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=jVXlsr5Lm7CHwBdT8AWawPU//RY573Zmrr3tODjeCNA=; b=iKz63yUh613aePiw7Onp68xyQb 4eCSH8zQYwwMWB46vEOvq+khOjOYYA/VuS2J9LVaIWZi6Wi+3LV8hoFVCqVkxvsndQ+Zy3SbQMCKt DIGSSTw3vsOoY6jGBBwVWQFJYevecYPRQ92PooyaEzHJnnQKP4oGtX7dxvGUfn8Hcplg=; From: Daniel Mendler <mail@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#61274: 29.0.60; dabbrev-capf signals errors In-Reply-To: <7a02ad24-154e-5123-a8d4-ee815e2abf10@HIDDEN> (Daniel Mendler's message of "Sat, 4 Feb 2023 18:23:47 +0100") References: <87o7q9y9oh.fsf@HIDDEN> <83pmaptvt1.fsf@HIDDEN> <b03f603b-d00d-880d-7e61-9f8b3dcedf71@HIDDEN> <83mt5ttlqu.fsf@HIDDEN> <7a02ad24-154e-5123-a8d4-ee815e2abf10@HIDDEN> Date: Sat, 15 Feb 2025 22:03:52 +0100 Message-ID: <87r03y2a4n.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61274 Cc: 61274 <at> debbugs.gnu.org, monnier@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Daniel Mendler <mail@HIDDEN> writes: > On 2/4/23 17:54, Eli Zaretskii wrote: >>> Date: Sat, 4 Feb 2023 17:03:26 +0100 >>> Cc: 61274 <at> debbugs.gnu.org, monnier@HIDDEN >>> From: Daniel Mendler <mail@HIDDEN> >>> >>> On 2/4/23 14:16, Eli Zaretskii wrote: >>>> The patch below fixes the error. >>> >>> Thanks! >> >> Should I install it? > > Yes, please, if Stefan agrees. He added dabbrev-capf. > > Daniel I believe this issue can be closed. Maybe Stefan can confirm? Daniel
bug-gnu-emacs@HIDDEN:bug#61274; Package emacs.
Full text available.Received: (at 61274) by debbugs.gnu.org; 4 Feb 2023 18:21:59 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 04 13:21:59 2023 Received: from localhost ([127.0.0.1]:43442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pONAl-0002Ai-Ed for submit <at> debbugs.gnu.org; Sat, 04 Feb 2023 13:21:59 -0500 Received: from server.qxqx.de ([178.63.65.180]:58591 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mail@HIDDEN>) id 1pONAf-0002AP-Uj for 61274 <at> debbugs.gnu.org; Sat, 04 Feb 2023 13:21:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iCKcvlBAk3Mj1UN80ja1Bn7D/KPJvxMMvhTOCcIw+eE=; b=kym8knBSuHwC2MlaZYjguAJz42 QB7LGPv/zmH4gETMQvFbpXGkrd/dMImRGD3alcmDt1LDSjUS4qNV2EZaRDl8muunk7hXIah4fHjZM WrJYPZdvzw3Td+eB5lv55eTyJRn2tbcuin3GPT60L5lMc86A+B723xE5EzlheCQunko4=; Message-ID: <572f24c8-febf-a72b-c222-515ba8c2db28@HIDDEN> Date: Sat, 4 Feb 2023 19:21:47 +0100 MIME-Version: 1.0 Subject: Re: bug#61274: 29.0.60; dabbrev-capf signals errors To: Eli Zaretskii <eliz@HIDDEN> References: <87o7q9y9oh.fsf@HIDDEN> <83pmaptvt1.fsf@HIDDEN> <b03f603b-d00d-880d-7e61-9f8b3dcedf71@HIDDEN> <83mt5ttlqu.fsf@HIDDEN> <jwvedr5l5jq.fsf-monnier+emacs@HIDDEN> <83fsbltko3.fsf@HIDDEN> <c8e01b85-1d3b-17b9-0b8a-e6aeccc38569@HIDDEN> <83cz6pti8h.fsf@HIDDEN> Content-Language: en-US From: Daniel Mendler <mail@HIDDEN> In-Reply-To: <83cz6pti8h.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61274 Cc: 61274 <at> debbugs.gnu.org, monnier@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) On 2/4/23 19:09, Eli Zaretskii wrote: >> However the second issue still occurs even with `dabbrev-completion'. >> When I execute `dabbrev-completion' in a buffer where no completions are >> found, I get the message "dabbrev--abbrev-at-point: No possible >> abbreviation preceding point", while the message should be the usual "No >> match" from `completion-at-point'. > > I see a different message: > > completion--some: No dynamic expansion for "x" found in this-buffer > > Which IMO is completely reasonable. It is for `dabbrev-completion` but not for `dabbrev-capf', which should better not throw any errors, such that the next Capf gets its chance to run as I mentioned in my initial mail. Maybe Stefan has some more comments on how we could resolve this? Daniel
bug-gnu-emacs@HIDDEN:bug#61274; Package emacs.
Full text available.Received: (at 61274) by debbugs.gnu.org; 4 Feb 2023 18:09:54 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 04 13:09:54 2023 Received: from localhost ([127.0.0.1]:43397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pOMz4-0001pU-8B for submit <at> debbugs.gnu.org; Sat, 04 Feb 2023 13:09:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1pOMyz-0001pF-Ga for 61274 <at> debbugs.gnu.org; Sat, 04 Feb 2023 13:09:53 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pOMyt-0001DM-7O; Sat, 04 Feb 2023 13:09:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VNjQHKYiSeLk4fsYIpMkQF1xEcN3Q9Ky2jCJ+LmXVhs=; b=VGkNkwfJduqZ 1GbVUOie+1g+TxbuEK+QyFZkr0caWAQn+3rv3hwaqHu1kYuiFycpNRFPzD0sk/M2hA5Y3NiGqIGMa AvP+MTF56wYrYXm9jkDXGcozM3MmdvqYVJyC4tfDYPWgQvU8oGur/naCGStg86oaTqinQUPNZIpFv Q+NVRrPOfmW7r/r561HDHR5eN6k8sUnOo+7e9NXQFrhLO2RwhwoEZd+jHNbwFjquzSpIn2ykXaAYE 8OdPvvh67AD9/ZY0GZ876/7HGyuxDa99sBJDu6jDMMLAmhNYxVel1iA+H2LFGGDGS6PT1U0wvYy7S BqbHzrnP7dqyxMG0ufoJRA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pOMys-0004z9-H3; Sat, 04 Feb 2023 13:09:42 -0500 Date: Sat, 04 Feb 2023 20:09:50 +0200 Message-Id: <83cz6pti8h.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Daniel Mendler <mail@HIDDEN> In-Reply-To: <c8e01b85-1d3b-17b9-0b8a-e6aeccc38569@HIDDEN> (message from Daniel Mendler on Sat, 4 Feb 2023 18:30:41 +0100) Subject: Re: bug#61274: 29.0.60; dabbrev-capf signals errors References: <87o7q9y9oh.fsf@HIDDEN> <83pmaptvt1.fsf@HIDDEN> <b03f603b-d00d-880d-7e61-9f8b3dcedf71@HIDDEN> <83mt5ttlqu.fsf@HIDDEN> <jwvedr5l5jq.fsf-monnier+emacs@HIDDEN> <83fsbltko3.fsf@HIDDEN> <c8e01b85-1d3b-17b9-0b8a-e6aeccc38569@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61274 Cc: 61274 <at> debbugs.gnu.org, monnier@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Sat, 4 Feb 2023 18:30:41 +0100 > Cc: 61274 <at> debbugs.gnu.org > From: Daniel Mendler <mail@HIDDEN> > > > Then there's something here that puzzles me: the recipe presented by > > Daniel is basically identical to what dabbrev-completion does. And > > yet dabbrev-completion produces different effects when invoked in the > > same buffer with the same text at point. What is responsible for the > > difference in behavior? > > You mean that the stringp type error does not occur? There is some code > in `dabbrev-completion' which sets up Dabbrev (resets variables etc), so > this is likely causing the difference. This is solved by my patch. I thought there was some difference in behavior even after that, but it looks like I cannot reproduce it now, so I will consider that my dream. > However the second issue still occurs even with `dabbrev-completion'. > When I execute `dabbrev-completion' in a buffer where no completions are > found, I get the message "dabbrev--abbrev-at-point: No possible > abbreviation preceding point", while the message should be the usual "No > match" from `completion-at-point'. I see a different message: completion--some: No dynamic expansion for "x" found in this-buffer Which IMO is completely reasonable.
bug-gnu-emacs@HIDDEN:bug#61274; Package emacs.
Full text available.Received: (at 61274) by debbugs.gnu.org; 4 Feb 2023 17:30:51 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 04 12:30:51 2023 Received: from localhost ([127.0.0.1]:43375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pOMNH-0000qJ-0P for submit <at> debbugs.gnu.org; Sat, 04 Feb 2023 12:30:51 -0500 Received: from server.qxqx.de ([178.63.65.180]:41939 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mail@HIDDEN>) id 1pOMNE-0000q3-Vf for 61274 <at> debbugs.gnu.org; Sat, 04 Feb 2023 12:30:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fGBF/SowRqhE+V5faCq1GsFI9aACsU4YxfMj4YL1ch4=; b=gOx+IVNI1jQeKkt+KF+/aTqKl7 TpjOnVsbQ0BnafYuG1sGJ1Zj7AVBbT8D7YXdHA++Chys/rAAXSxV128KfeIGYSozoRIUSBCftXl1F 05Vu8tCC30CNIbeC2YM+wAatDSbARYoWGtR5TkYiFu90qu1milr0fKBloz5CiB8iDfZQ=; Message-ID: <c8e01b85-1d3b-17b9-0b8a-e6aeccc38569@HIDDEN> Date: Sat, 4 Feb 2023 18:30:41 +0100 MIME-Version: 1.0 Subject: Re: bug#61274: 29.0.60; dabbrev-capf signals errors Content-Language: en-US To: Eli Zaretskii <eliz@HIDDEN>, Stefan Monnier <monnier@HIDDEN> References: <87o7q9y9oh.fsf@HIDDEN> <83pmaptvt1.fsf@HIDDEN> <b03f603b-d00d-880d-7e61-9f8b3dcedf71@HIDDEN> <83mt5ttlqu.fsf@HIDDEN> <jwvedr5l5jq.fsf-monnier+emacs@HIDDEN> <83fsbltko3.fsf@HIDDEN> From: Daniel Mendler <mail@HIDDEN> In-Reply-To: <83fsbltko3.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61274 Cc: 61274 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) On 2/4/23 18:17, Eli Zaretskii wrote: >> From: Stefan Monnier <monnier@HIDDEN> >> Cc: Daniel Mendler <mail@HIDDEN>, 61274 <at> debbugs.gnu.org >> Date: Sat, 04 Feb 2023 12:13:27 -0500 >> >>> maybe dabbrev-capf is unsuitable to serve as the value of >>> completion-at-point-functions? >> >> As the name implies, it's a function designed specifically for use on >> `completion-at-point-functions`. Maybe dabbrev is not well adapted >> for use within a normal completion UI, but `dabbrev-capf` should do its >> best to obey the rules of `completion-at-point-functions`, so I think >> the behavior Daniel suggests is indeed what `dabbrev-capf` should try >> to do. > > Then there's something here that puzzles me: the recipe presented by > Daniel is basically identical to what dabbrev-completion does. And > yet dabbrev-completion produces different effects when invoked in the > same buffer with the same text at point. What is responsible for the > difference in behavior? You mean that the stringp type error does not occur? There is some code in `dabbrev-completion' which sets up Dabbrev (resets variables etc), so this is likely causing the difference. However the second issue still occurs even with `dabbrev-completion'. When I execute `dabbrev-completion' in a buffer where no completions are found, I get the message "dabbrev--abbrev-at-point: No possible abbreviation preceding point", while the message should be the usual "No match" from `completion-at-point'. At this point we are moving into problematic territory however, since Stefan reimplemented `dabbrev-completion' based on `dabbrev-capf'. We may want a more specific error message for `dabbev-completion', while we don't want any errors signalled by `dabbrev-capf', such that it conforms to the `completion-at-point-functions' contract. Daniel
bug-gnu-emacs@HIDDEN:bug#61274; Package emacs.
Full text available.Received: (at 61274) by debbugs.gnu.org; 4 Feb 2023 17:23:56 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 04 12:23:56 2023 Received: from localhost ([127.0.0.1]:43361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pOMGa-0000e2-Ac for submit <at> debbugs.gnu.org; Sat, 04 Feb 2023 12:23:56 -0500 Received: from server.qxqx.de ([178.63.65.180]:59773 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mail@HIDDEN>) id 1pOMGY-0000do-GJ for 61274 <at> debbugs.gnu.org; Sat, 04 Feb 2023 12:23:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=akDosrR7aiEpJKhYExddF8LEA0HsdmBxHSUsHbPonwI=; b=mfRsbLv3FaZvDFY2y7tOy81NEM ejeLx40iuMmIT0LwTw3nGSEQpVf9q7Ii2kgakoEWBOMkslTrWXHcJjPzQeRt21QiC+KVdhDcnu4Rw I7gmBHW2H3FglcRM9PsMuiB4UY1c3avhDdo0qmJpPi+yzq+wf5sO5l8+dL0gXq8dTS8w=; Message-ID: <7a02ad24-154e-5123-a8d4-ee815e2abf10@HIDDEN> Date: Sat, 4 Feb 2023 18:23:47 +0100 MIME-Version: 1.0 Subject: Re: bug#61274: 29.0.60; dabbrev-capf signals errors Content-Language: en-US To: Eli Zaretskii <eliz@HIDDEN> References: <87o7q9y9oh.fsf@HIDDEN> <83pmaptvt1.fsf@HIDDEN> <b03f603b-d00d-880d-7e61-9f8b3dcedf71@HIDDEN> <83mt5ttlqu.fsf@HIDDEN> From: Daniel Mendler <mail@HIDDEN> In-Reply-To: <83mt5ttlqu.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61274 Cc: 61274 <at> debbugs.gnu.org, monnier@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) On 2/4/23 17:54, Eli Zaretskii wrote: >> Date: Sat, 4 Feb 2023 17:03:26 +0100 >> Cc: 61274 <at> debbugs.gnu.org, monnier@HIDDEN >> From: Daniel Mendler <mail@HIDDEN> >> >> On 2/4/23 14:16, Eli Zaretskii wrote: >>> The patch below fixes the error. >> >> Thanks! > > Should I install it? Yes, please, if Stefan agrees. He added dabbrev-capf. Daniel
bug-gnu-emacs@HIDDEN:bug#61274; Package emacs.
Full text available.Received: (at 61274) by debbugs.gnu.org; 4 Feb 2023 17:17:23 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 04 12:17:23 2023 Received: from localhost ([127.0.0.1]:43352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pOMAF-0000Sx-2V for submit <at> debbugs.gnu.org; Sat, 04 Feb 2023 12:17:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1pOMAC-0000Sj-Ac for 61274 <at> debbugs.gnu.org; Sat, 04 Feb 2023 12:17:21 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pOMA6-0001WM-Dm; Sat, 04 Feb 2023 12:17:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=U01iOC720ggAR+gsCD48uz4lV6QcFxpRgcThDM+BBnI=; b=O2MmNuo1zgDx Dokomykj0BEUYBDDDbwXspiaw6NiMsQnvZVleO+GkbqGUI1q09o8WEbWlDpC8O1VEFJRtENmgYJzQ 8QkWLKHGQQQJFNsriV3bHZEP46/B2p9M/iAKKsGvMtCO7QUyGnjx+9XmUeLnETBc1LK9ckav/l11E +JTXbWdrgnW9IbbIcayL/k8J68VmLBurg46qHN0RItHLxJIoLX+gnkYPb+Rucy8GqILl9CEo1iCpV KaH+d1fLPykUXd7YgoyYGSf1VbOiZlpNQcuApkn5Tw74EnAqp1Pn27DyHfNTwNav6ivhbhjR347wx 7M+SHyGyidIT9v2LHBUTbQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pOMA0-0006dP-G0; Sat, 04 Feb 2023 12:17:14 -0500 Date: Sat, 04 Feb 2023 19:17:16 +0200 Message-Id: <83fsbltko3.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> In-Reply-To: <jwvedr5l5jq.fsf-monnier+emacs@HIDDEN> (message from Stefan Monnier on Sat, 04 Feb 2023 12:13:27 -0500) Subject: Re: bug#61274: 29.0.60; dabbrev-capf signals errors References: <87o7q9y9oh.fsf@HIDDEN> <83pmaptvt1.fsf@HIDDEN> <b03f603b-d00d-880d-7e61-9f8b3dcedf71@HIDDEN> <83mt5ttlqu.fsf@HIDDEN> <jwvedr5l5jq.fsf-monnier+emacs@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61274 Cc: mail@HIDDEN, 61274 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Stefan Monnier <monnier@HIDDEN> > Cc: Daniel Mendler <mail@HIDDEN>, 61274 <at> debbugs.gnu.org > Date: Sat, 04 Feb 2023 12:13:27 -0500 > > > maybe dabbrev-capf is unsuitable to serve as the value of > > completion-at-point-functions? > > As the name implies, it's a function designed specifically for use on > `completion-at-point-functions`. Maybe dabbrev is not well adapted > for use within a normal completion UI, but `dabbrev-capf` should do its > best to obey the rules of `completion-at-point-functions`, so I think > the behavior Daniel suggests is indeed what `dabbrev-capf` should try > to do. Then there's something here that puzzles me: the recipe presented by Daniel is basically identical to what dabbrev-completion does. And yet dabbrev-completion produces different effects when invoked in the same buffer with the same text at point. What is responsible for the difference in behavior?
bug-gnu-emacs@HIDDEN:bug#61274; Package emacs.
Full text available.
Received: (at 61274) by debbugs.gnu.org; 4 Feb 2023 17:13:41 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 04 12:13:41 2023
Received: from localhost ([127.0.0.1]:43342 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pOM6f-0000MR-4v
for submit <at> debbugs.gnu.org; Sat, 04 Feb 2023 12:13:41 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:13022)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1pOM6Z-0000MA-Pq
for 61274 <at> debbugs.gnu.org; Sat, 04 Feb 2023 12:13:39 -0500
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6161F4410FC;
Sat, 4 Feb 2023 12:13:30 -0500 (EST)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0DF53440C13;
Sat, 4 Feb 2023 12:13:29 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1675530809;
bh=WvanIUR2eh2wLRh5G4KlSTerqKRd/Sb8ZjFFELTDmqg=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=iKGpSdL6iHiPwUfJMsbqUMmiS57xi1wW3Ncxt1YJ3SemWZ3EMDONPesYRFa9PwIyf
hDWjHZQMdKFKtbWFXmJiPpBZqdHGtbt5Wf6ihPBs8CZqCTRZBXMdvBhfZI1cDe1NzB
MNecFOywd/nauqgJfWi/0Bl3ICaUPzqjnGdubpk/LerqGQJDyDrjfnzhniTDtOXH81
J6SHNxDus5or0UJKHwpdCNSS1CCrehz3vi8SlyplMtdjQZoEcQTJaTmsJbUSiac13/
W0dJyVgo5UMd61cvpgBJOSMaa3y5SaTVtWtJW/teoohA/urbvHpch8hW8S0aTBa4nT
wgfepBt6Dtsyw==
Received: from pastel (76-10-137-88.dsl.teksavvy.com [76.10.137.88])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D9E8212115A;
Sat, 4 Feb 2023 12:13:28 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#61274: 29.0.60; dabbrev-capf signals errors
In-Reply-To: <83mt5ttlqu.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 04 Feb
2023 18:54:01 +0200")
Message-ID: <jwvedr5l5jq.fsf-monnier+emacs@HIDDEN>
References: <87o7q9y9oh.fsf@HIDDEN> <83pmaptvt1.fsf@HIDDEN>
<b03f603b-d00d-880d-7e61-9f8b3dcedf71@HIDDEN>
<83mt5ttlqu.fsf@HIDDEN>
Date: Sat, 04 Feb 2023 12:13:27 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.021 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 61274
Cc: Daniel Mendler <mail@HIDDEN>, 61274 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> maybe dabbrev-capf is unsuitable to serve as the value of
> completion-at-point-functions?
As the name implies, it's a function designed specifically for use on
`completion-at-point-functions`. Maybe dabbrev is not well adapted
for use within a normal completion UI, but `dabbrev-capf` should do its
best to obey the rules of `completion-at-point-functions`, so I think
the behavior Daniel suggests is indeed what `dabbrev-capf` should try
to do.
Those people who don't like it can use dabbrev via various other UIs.
Stefan
bug-gnu-emacs@HIDDEN:bug#61274; Package emacs.
Full text available.Received: (at 61274) by debbugs.gnu.org; 4 Feb 2023 16:54:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 04 11:54:04 2023 Received: from localhost ([127.0.0.1]:43303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pOLng-0008II-14 for submit <at> debbugs.gnu.org; Sat, 04 Feb 2023 11:54:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1pOLnc-0008Hk-Ku for 61274 <at> debbugs.gnu.org; Sat, 04 Feb 2023 11:54:02 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pOLnW-0005lu-HO; Sat, 04 Feb 2023 11:53:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yIBAL6rOkmbBeKPt6N4b5Ek3PlkjCYWOwzR1oo8AeDk=; b=L4IveInkVbUm JONO/QAEezJ6WUw+ZZBjpzAzqofxVWZp0PP/4xv0DK/bZ2U1pSSN9s1z9AMvFxCIbB8KN6A4oUWRI cWuWOX1vUk897+9JBVVNACnLGEHlbASVDoQZ3eeFbh3/+9Q9MQ6KqYGUs+Ey4Jew2K1TsILG32/xQ 918j5gFqNfIhE+v4Zp0PyBXChbt6cMaSYqV8J3d4aEtLN/PIuMTPsRKivnWlZ8lNcA7GiwmeJ6EzF Y5g7+kxV2Z63DLh418JeE7//v6zWUfCO9YSQ2UHpPW0aRzG/gFP8QEIW+Lz3ZzkoIpTAqEgiANc91 xMIRzISYnq2RWzfw8GyGig==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pOLnW-0006w3-1C; Sat, 04 Feb 2023 11:53:54 -0500 Date: Sat, 04 Feb 2023 18:54:01 +0200 Message-Id: <83mt5ttlqu.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Daniel Mendler <mail@HIDDEN> In-Reply-To: <b03f603b-d00d-880d-7e61-9f8b3dcedf71@HIDDEN> (message from Daniel Mendler on Sat, 4 Feb 2023 17:03:26 +0100) Subject: Re: bug#61274: 29.0.60; dabbrev-capf signals errors References: <87o7q9y9oh.fsf@HIDDEN> <83pmaptvt1.fsf@HIDDEN> <b03f603b-d00d-880d-7e61-9f8b3dcedf71@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61274 Cc: 61274 <at> debbugs.gnu.org, monnier@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Sat, 4 Feb 2023 17:03:26 +0100 > Cc: 61274 <at> debbugs.gnu.org, monnier@HIDDEN > From: Daniel Mendler <mail@HIDDEN> > > On 2/4/23 14:16, Eli Zaretskii wrote: > > The patch below fixes the error. > > Thanks! Should I install it? > > Regarding "No dynamic expansion" error: what did you expect to happen > > instead and why? IOW, what is the expected result of having > > dabbrev-capf alone in completion-at-point-functions, and then typing > > "x M-TAB"? > > I would expect the completion UI to show a message, instead of an error > from the Capf. For example if you start emacs -Q, type "nonexistent > M-TAB" in the scratch buffer to access the normal Elisp completions. > Then you will see the message "No match" in the minibuffer. If > `dabbrev-capf' would not throw an error, we would get the same message. maybe dabbrev-capf is unsuitable to serve as the value of completion-at-point-functions? Stefan, any comments?
bug-gnu-emacs@HIDDEN:bug#61274; Package emacs.
Full text available.Received: (at 61274) by debbugs.gnu.org; 4 Feb 2023 16:03:43 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 04 11:03:43 2023 Received: from localhost ([127.0.0.1]:43267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pOL0x-0006z0-4F for submit <at> debbugs.gnu.org; Sat, 04 Feb 2023 11:03:43 -0500 Received: from server.qxqx.de ([178.63.65.180]:38849 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mail@HIDDEN>) id 1pOL0u-0006yf-P8 for 61274 <at> debbugs.gnu.org; Sat, 04 Feb 2023 11:03:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jmWooBLeJbKF/nEOO8yq0H42DmN/JCO9hOxyEiyRazg=; b=scYBgeIYwfJ3xfQHs6gI1l3dck czHkBiJkNecgQJyk9FpYpuQFLKBBdn+Er3L8OkfporUa1/QL7J8DFhLhuYNzePBbi9/xEXCDIxYlM GmWeTcKJUZQz3wm2+9uwZY7KQ1K7DXtOSQX+juF32LD5CzIh3UlQdDnc5uohYsGIHs9o=; Message-ID: <b03f603b-d00d-880d-7e61-9f8b3dcedf71@HIDDEN> Date: Sat, 4 Feb 2023 17:03:26 +0100 MIME-Version: 1.0 Subject: Re: bug#61274: 29.0.60; dabbrev-capf signals errors To: Eli Zaretskii <eliz@HIDDEN> References: <87o7q9y9oh.fsf@HIDDEN> <83pmaptvt1.fsf@HIDDEN> Content-Language: en-US From: Daniel Mendler <mail@HIDDEN> In-Reply-To: <83pmaptvt1.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61274 Cc: 61274 <at> debbugs.gnu.org, monnier@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) On 2/4/23 14:16, Eli Zaretskii wrote: > The patch below fixes the error. Thanks! > Regarding "No dynamic expansion" error: what did you expect to happen > instead and why? IOW, what is the expected result of having > dabbrev-capf alone in completion-at-point-functions, and then typing > "x M-TAB"? I would expect the completion UI to show a message, instead of an error from the Capf. For example if you start emacs -Q, type "nonexistent M-TAB" in the scratch buffer to access the normal Elisp completions. Then you will see the message "No match" in the minibuffer. If `dabbrev-capf' would not throw an error, we would get the same message. Daniel
bug-gnu-emacs@HIDDEN:bug#61274; Package emacs.
Full text available.
Received: (at 61274) by debbugs.gnu.org; 4 Feb 2023 13:16:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 04 08:16:47 2023
Received: from localhost ([127.0.0.1]:40830 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pOIPO-0001w8-L1
for submit <at> debbugs.gnu.org; Sat, 04 Feb 2023 08:16:47 -0500
Received: from eggs.gnu.org ([209.51.188.92]:44892)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1pOIPL-0001vu-5J
for 61274 <at> debbugs.gnu.org; Sat, 04 Feb 2023 08:16:46 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1pOIPE-0004EI-MG; Sat, 04 Feb 2023 08:16:36 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=LMs9qCcQ++ggQS6Kf0R8GUAHK3q5lYQn9v/wT6cbkhU=; b=MTL0uw0awAms
Ja9NI+oTC71wLMJEtXkDg/ObtY5JnbUTSM5Fy2rdlSYeuYc+sradffFbdkOFa6ELnTk+kJZ80HMfD
iHzNPp3xCNcSat6vNwVogZzKUtzQ3hjzovB6f0jt+4mrzcDS+AD3ttHSVCd0/ENhHXCOkdTgx65F8
Dk+578Ur2tTtuKKJj4MythkL5G8vgwpBnRnrQHQjBVvE7nDhz3m1X5hubkb908jRwA6mwMyJR25rM
PF0TQShjTauquR9YEGuhJwXFQaPdHK+BFCKNzvta4ld7c3jPAPWpK9mzJsK/p3AQr68XixUjpJ9Gd
J4lmQgwsq/vx2RtXwmkCPQ==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1pOIPD-00086p-Vg; Sat, 04 Feb 2023 08:16:36 -0500
Date: Sat, 04 Feb 2023 15:16:42 +0200
Message-Id: <83pmaptvt1.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Daniel Mendler <mail@HIDDEN>
In-Reply-To: <87o7q9y9oh.fsf@HIDDEN> (message from Daniel Mendler
on Sat, 04 Feb 2023 12:03:26 +0100)
Subject: Re: bug#61274: 29.0.60; dabbrev-capf signals errors
References: <87o7q9y9oh.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 61274
Cc: 61274 <at> debbugs.gnu.org, monnier@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Cc: monnier@HIDDEN
> From: Daniel Mendler <mail@HIDDEN>
> Date: Sat, 04 Feb 2023 12:03:26 +0100
>
> The completion-at-point-function `dabbrev-capf' sometimes signals
> errors. It would be good if the function would not do that but return
> nil if no completions are found, such that the next Capf from the list
> of completion functions gets its chance to run.
>
> 1. Start emacs -Q
> 2. Evaluate (require 'dabbrev).
> 3. Evaluate (setq completion-at-point-functions '(dabbrev-capf)) in the
> scratch buffer.
> 4. Type `x M-TAB` in the scratch buffer. I observe the following error:
>
> Debugger entered--Lisp error: (wrong-type-argument stringp nil)
> dabbrev--goto-start-of-abbrev()
> dabbrev--abbrev-at-point()
> dabbrev-capf()
> completion--capf-wrapper(dabbrev-capf all)
> completion-at-point()
> funcall-interactively(completion-at-point)
> command-execute(completion-at-point)
>
> Furthermore if no completions are found `dabbrev-capf' signals an error.
> The messages buffer will then contain:
>
> Scanning for dabbrevs...done
> completion--some: No dynamic expansion for "xyz" found
The patch below fixes the error.
Regarding "No dynamic expansion" error: what did you expect to happen
instead and why? IOW, what is the expected result of having
dabbrev-capf alone in completion-at-point-functions, and then typing
"x M-TAB"?
diff --git a/lisp/dabbrev.el b/lisp/dabbrev.el
index a4b4d07..deba082 100644
--- a/lisp/dabbrev.el
+++ b/lisp/dabbrev.el
@@ -400,6 +400,8 @@ dabbrev-completion
(defun dabbrev-capf ()
"Dabbrev completion function for `completion-at-point-functions'."
+ (or (stringp dabbrev--abbrev-char-regexp)
+ (dabbrev--reset-global-variables))
(let* ((abbrev (dabbrev--abbrev-at-point))
(beg (progn (search-backward abbrev) (point)))
(end (progn (search-forward abbrev) (point)))
bug-gnu-emacs@HIDDEN:bug#61274; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 4 Feb 2023 11:03:46 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 04 06:03:46 2023 Received: from localhost ([127.0.0.1]:40765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pOGKf-0001xX-V3 for submit <at> debbugs.gnu.org; Sat, 04 Feb 2023 06:03:46 -0500 Received: from lists.gnu.org ([209.51.188.17]:38018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mail@HIDDEN>) id 1pOGKb-0001xM-Rn for submit <at> debbugs.gnu.org; Sat, 04 Feb 2023 06:03:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <mail@HIDDEN>) id 1pOGKY-0002zz-AT for bug-gnu-emacs@HIDDEN; Sat, 04 Feb 2023 06:03:39 -0500 Received: from server.qxqx.de ([2a01:4f8:121:346::180] helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <mail@HIDDEN>) id 1pOGKU-0007x5-U3 for bug-gnu-emacs@HIDDEN; Sat, 04 Feb 2023 06:03:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Type:MIME-Version:Message-ID:Date:Subject:Cc:To: From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6V9aecApk0QxyEHLWRrIHK/kO9faCvigC2dQqIpbM8Q=; b=AN5lb4DGFdM04iAhIxtdlTnjCe GJ5u/C4N4h98cvMEDbV7Wp7ooyhq6yU3td2e77yX4frPdgoRpHuCl6D0TdOhLagsbSRAxR8nXYLSb xz4+dUGd5XYagap9ytMGQPnFmkxWRY6Pv3QIGXTvDExdO+uxSs8h7ypuqi0xeWNPFjW4=; From: Daniel Mendler <mail@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: 29.0.60; dabbrev-capf signals errors Date: Sat, 04 Feb 2023 12:03:26 +0100 Message-ID: <87o7q9y9oh.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@HIDDEN; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: monnier@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.4 (--) The completion-at-point-function `dabbrev-capf' sometimes signals errors. It would be good if the function would not do that but return nil if no completions are found, such that the next Capf from the list of completion functions gets its chance to run. 1. Start emacs -Q 2. Evaluate (require 'dabbrev). 3. Evaluate (setq completion-at-point-functions '(dabbrev-capf)) in the scratch buffer. 4. Type `x M-TAB` in the scratch buffer. I observe the following error: Debugger entered--Lisp error: (wrong-type-argument stringp nil) dabbrev--goto-start-of-abbrev() dabbrev--abbrev-at-point() dabbrev-capf() completion--capf-wrapper(dabbrev-capf all) completion-at-point() funcall-interactively(completion-at-point) command-execute(completion-at-point) Furthermore if no completions are found `dabbrev-capf' signals an error. The messages buffer will then contain: Scanning for dabbrevs...done completion--some: No dynamic expansion for "xyz" found In GNU Emacs 29.0.60 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw scroll bars) of 2023-01-26 built on projects Repository revision: f8c95d1a7681e861fc22d2a040cda0ddfe23eff4 Repository branch: emacs-29 Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Debian GNU/Linux 11 (bullseye)
Daniel Mendler <mail@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#61274; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.