GNU logs - #62353, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#62353] [PATCH] gnu: Add glava.
Resent-From: Spencer Skylar Chan <schan12@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 21 Mar 2023 20:17:01 +0000
Resent-Message-ID: <handler.62353.B.167942976826442 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 62353 <at> debbugs.gnu.org
Message-ID: <a778daaa-66a4-4ccf-d315-259da34b6843@HIDDEN>
Date: Tue, 21 Mar 2023 13:58:46 -0400
MIME-Version: 1.0
From: Spencer Skylar Chan <schan12@HIDDEN>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Received-SPF: pass client-ip=68.232.137.73; envelope-from=schan12@HIDDEN;
 helo=esa4.umd.iphmx.com
X-Spam_score_int: -43
X-Spam_score: -4.4
X-Spam_bar: ----
X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Mailman-Approved-At: Tue, 21 Mar 2023 16:16:04 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

 From 17eb638d8ff5d5cb40c9bdf9f24544ef7f23088e Mon Sep 17 00:00:00 2001
From: Skylar Chan <schan12@HIDDEN>
Date: Mon, 30 Jan 2023 13:39:53 -0500
Subject: [PATCH] gnu: Add glava.

* gnu/packages/audio.scm (glava): New variable.
---
  gnu/packages/audio.scm | 75 ++++++++++++++++++++++++++++++++++++++++++
  1 file changed, 75 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 6f3fa2a580..a0e73ed55a 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -5109,6 +5109,81 @@ (define-public cava
  using ALSA, MPD, PulseAudio, or a FIFO buffer as its input.")
      (license license:expat)))

+(define-public glava
+  (package
+    (name "glava")
+    (version "1.6.3")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/jarcode-foss/glava")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0kqkjxmpqkmgby05lsf6c6iwm45n33jk5qy6gi3zvjx4q4yzal1i"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list #:tests? #f ;no tests.
+           #:make-flags
+           #~(list
+              (string-append "DESTDIR=" #$output)
+              (string-append "PREFIX=" #$output)
+              (string-append "CC=" #$(cc-for-target)))
+           #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'unpack 'fix-etc-references
+                 (lambda* (#:key outputs #:allow-other-keys)
+                   (substitute* (find-files ".*")
+                     (("/etc/xdg") (string-append #$output 
"/etc/xdg/glava")))))
+               (add-after 'unpack 'patch-makefile
+                 (lambda _
+                   (substitute* "Makefile"
+                     (("$(DESTDIR)$(SHADERDIR)")
+                      "$(SHADERDIR)"))))
+               (delete 'configure)
+               (add-after 'install 'make-wrapper
+                 ;; 
https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/misc/glava/default.nix
+                 (lambda* (#:key inputs outputs #:allow-other-keys)
+                   (let* ((wrapper (string-append #$output "/bin/glava")))
+                     (with-output-to-file wrapper
+                       (lambda _
+                         (display
+                          (string-append
+                           "#!/bin/sh\n"
+                           "case \"$1\" in\n"
+                           "  --copy-config|-C)\n"
+                           "# The binary would symlink it, which won't 
work in Guix because the\n"
+                           "# garbage collector will eventually remove 
the original files after\n"
+                           "# updates.\n"
+                           "  echo \"Guix wrapper: Copying glava config 
to ~/.config/glava\"\n"
+                           "  cp -r --no-preserve=all " #$output 
"/etc/xdg/glava ~/.config/glava\n"
+                           "  ;;\n"
+                           "*)\n"
+                           "  exec " #$output "/bin/.glava-real \"$@\"\n"
+                           "esac\n"))))
+                     (chmod wrapper #o555))))
+               (add-after 'install 'rename-binary
+                 (lambda* (#:key outputs #:allow-other-keys)
+                   (mkdir-p (string-append #$output "/bin"))
+                   (rename-file (string-append #$output "/usr/bin/glava")
+                                (string-append #$output 
"/bin/.glava-real"))
+                   (delete-file-recursively (string-append #$output 
"/usr")))))))
+    (inputs (list pulseaudio
+                  libx11
+                  libxext
+                  libxcomposite
+                  libxrender))
+    (native-inputs (list python))
+    (home-page "https://github.com/jarcode-foss/glava")
+    (synopsis "OpenGL audio spectrum visualizer")
+    (description "GLava is an OpenGL audio spectrum visualizer using 
PulseAudio or
+MPD's fifo output.  Its primary use case is for desktop windows or 
backgrounds.
+It is compatible with most EMWH compliant window managers.")
+    (license (list license:gpl3+
+                   license:expat)))) ;; khrplatform.h
+
  (define-public fluid-3
    (let ((commit "871c8ce2002e8b3c198f532fdb4fbcce7914f951"))
      (package

base-commit: 60a211ec705ac98483d76da7f2523f2b8966343a
-- 
2.39.2

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Spencer Skylar Chan <schan12@HIDDEN>
Subject: bug#62353: Acknowledgement ([PATCH] gnu: Add glava.)
Message-ID: <handler.62353.B.167942976826442.ack <at> debbugs.gnu.org>
References: <a778daaa-66a4-4ccf-d315-259da34b6843@HIDDEN>
X-Gnu-PR-Message: ack 62353
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 62353 <at> debbugs.gnu.org
Date: Tue, 21 Mar 2023 20:17:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 62353 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
62353: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D62353
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#62353] [PATCH] gnu: Add glava.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 29 Mar 2023 03:02:02 +0000
Resent-Message-ID: <handler.62353.B62353.16800589165592 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Spencer Skylar Chan <schan12@HIDDEN>
Cc: 62353 <at> debbugs.gnu.org
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
References: <a778daaa-66a4-4ccf-d315-259da34b6843@HIDDEN>
Date: Tue, 28 Mar 2023 23:01:34 -0400
In-Reply-To: <a778daaa-66a4-4ccf-d315-259da34b6843@HIDDEN> (Spencer Skylar
 Chan's message of "Tue, 21 Mar 2023 13:58:46 -0400")
Message-ID: <87355o45wx.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi Spencer,

Spencer Skylar Chan <schan12@HIDDEN> writes:

>  From 17eb638d8ff5d5cb40c9bdf9f24544ef7f23088e Mon Sep 17 00:00:00 2001
> From: Skylar Chan <schan12@HIDDEN>
> Date: Mon, 30 Jan 2023 13:39:53 -0500
> Subject: [PATCH] gnu: Add glava.
>
> * gnu/packages/audio.scm (glava): New variable.

Thank you!

I'm having problem applying your patch; git says it's corrupted.  It
seems the longer lines were folded?  I'm using this opportunity to share
some review comments.

> ---
>   gnu/packages/audio.scm | 75 ++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 75 insertions(+)
>
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index 6f3fa2a580..a0e73ed55a 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -5109,6 +5109,81 @@ (define-public cava
>   using ALSA, MPD, PulseAudio, or a FIFO buffer as its input.")
>       (license license:expat)))
>
> +(define-public glava
> +  (package
> +    (name "glava")
> +    (version "1.6.3")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/jarcode-foss/glava")
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "0kqkjxmpqkmgby05lsf6c6iwm45n33jk5qy6gi3zvjx4q4yzal1i"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     (list #:tests? #f ;no tests.

nitpick: You can drop the trailing period since inline comments are not
complete sentence (contrary to standalone comments, which should be).

> +           #:make-flags
> +           #~(list
> +              (string-append "DESTDIR=" #$output)
> +              (string-append "PREFIX=" #$output)
> +              (string-append "CC=" #$(cc-for-target)))
> +           #:phases
> +           #~(modify-phases %standard-phases
> +               (add-after 'unpack 'fix-etc-references
> +                 (lambda* (#:key outputs #:allow-other-keys)
> +                   (substitute* (find-files ".*")

The first argument to find-files is a directory, not a regexp; so it
should probably be ".".  It's usually best to use a regexps as a 2nd
argument otherwise for large projects it wastes IO scanning tons of
files and sometimes fails on binary images for example.

> +                     (("/etc/xdg") (string-append #$output 
> "/etc/xdg/glava")))))
> 
> +               (add-after 'unpack 'patch-makefile
> +                 (lambda _
> +                   (substitute* "Makefile"
> +                     (("$(DESTDIR)$(SHADERDIR)")
> +                      "$(SHADERDIR)"))))

This substitution must do anything, as the pattern
"$(DESTDIR)$(SHADERDIR)" is a regexp, and $ matches the end of line
character.  You probably meant to escape regexp special characters like:

"\\$\\(DESTDIR\\)\\$\\(SHADERDIR\\)"

in the pattern.

> +               (delete 'configure)
> +               (add-after 'install 'make-wrapper
> +                 ;; 
> https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/misc/glava/default.nix

Please leave a verbose comment (complete sentence) explaining what is
the issue, and prefer linking to the 'raw' github file in a (see: $URL)
at the end of the explanation.

> +                 (lambda* (#:key inputs outputs #:allow-other-keys)

'inputs' appears unused.

> +                   (let* ((wrapper (string-append #$output "/bin/glava")))
> +                     (with-output-to-file wrapper
> +                       (lambda _
> +                         (display
> +                          (string-append
> +                           "#!/bin/sh\n"
> +                           "case \"$1\" in\n"
> +                           "  --copy-config|-C)\n"
> +                           "# The binary would symlink it, which won't 
> work in Guix because the\n"
> +                           "# garbage collector will eventually remove 
> the original files after\n"
> +                           "# updates.\n"
> +                           "  echo \"Guix wrapper: Copying glava config 
> to ~/.config/glava\"\n"
> +                           "  cp -r --no-preserve=all " #$output 
> "/etc/xdg/glava ~/.config/glava\n"
> +                           "  ;;\n"
> +                           "*)\n"
> +                           "  exec " #$output "/bin/.glava-real \"$@\"\n"
> +                           "esac\n"))))
> +                     (chmod wrapper #o555))))

Hm.  I'm not sure we want to preserve this behavior of messing with
the user's HOME files, but I haven't read the issue to get a grasp of
what is the exact problem it tries to solve.

> +               (add-after 'install 'rename-binary
> +                 (lambda* (#:key outputs #:allow-other-keys)
> +                   (mkdir-p (string-append #$output "/bin"))
> +                   (rename-file (string-append #$output "/usr/bin/glava")
> +                                (string-append #$output 
> "/bin/.glava-real"))
> +                   (delete-file-recursively (string-append #$output 
> "/usr")))))))
> +    (inputs (list pulseaudio
> +                  libx11
> +                  libxext
> +                  libxcomposite
> +                  libxrender))
> +    (native-inputs (list python))
> +    (home-page "https://github.com/jarcode-foss/glava")
> +    (synopsis "OpenGL audio spectrum visualizer")
> +    (description "GLava is an OpenGL audio spectrum visualizer using 
> PulseAudio or
> +MPD's fifo output.  Its primary use case is for desktop windows or 
> backgrounds.
> +It is compatible with most EMWH compliant window managers.")
> +    (license (list license:gpl3+
> +                   license:expat)))) ;; khrplatform.h

nitpick: Please use single ';' for inline comments :-)

Could you please send a revised version with the above taken care of?

-- 
Thanks,
Maxim

Last modified: Wed, 29 Mar 2023 03:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.