Received: (at 63253) by debbugs.gnu.org; 10 May 2023 11:15:56 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 10 07:15:56 2023 Received: from localhost ([127.0.0.1]:45369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pwhnY-0007Vj-AY for submit <at> debbugs.gnu.org; Wed, 10 May 2023 07:15:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1pwhnU-0007Ef-QO for 63253 <at> debbugs.gnu.org; Wed, 10 May 2023 07:15:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pwhnO-0001je-1s; Wed, 10 May 2023 07:15:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Rfa8FTrLd2170LklH6A0OwAoULTI0I7e1xuX7eBnn3w=; b=k5IWVzA3Ek/d Wt24xbRMg4KePOaLIu7ZgXulyIDGR8Fbh1s+pRvJA4aM/6N45VjVPeDfVY3q5crxhMfHst4h8HxiK h85inUTPrhKwgKtHzd893GYO3gKqzr3s5ys+1cEF2U2sFwEpT0Bog3vNcy1/d/ZleGF6RChNs99DP LvjyMmo4o7ZWkNso7KnAkPLmrtXzck7nDvTl337ztHNVn/56i1RvK3UT/H0bntfjIAEtM5UyCp6yU dmnaJQjdJ9MieyZ3K7sIjvC6W5lVjcMulOzYIXdSkdAZD+BsQEidk25ylHLd5LUHcruO4eylylwsM JlUDWo5hE1uxWlmSqz77KQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pwhnM-0002aP-O8; Wed, 10 May 2023 07:15:45 -0400 Date: Wed, 10 May 2023 14:16:36 +0300 Message-Id: <838rdwa12j.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> In-Reply-To: <jwvy1lwly8p.fsf-monnier+emacs@HIDDEN> (message from Stefan Monnier on Tue, 09 May 2023 22:31:09 -0400) Subject: Re: bug#63253: 29.0.90; with-delayed-message fails in combination with inhibit-message References: <87r0rxdwc8.fsf@HIDDEN> <jwvpm7bnf0q.fsf-monnier+emacs@HIDDEN> <837ctidgab.fsf@HIDDEN> <jwvwn1in9tr.fsf-monnier+emacs@HIDDEN> <831qjqdcz9.fsf@HIDDEN> <jwvy1lwly8p.fsf-monnier+emacs@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63253 Cc: mail@HIDDEN, larsi@HIDDEN, 63253 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Stefan Monnier <monnier@HIDDEN> > Cc: Lars Ingebrigtsen <larsi@HIDDEN>, mail@HIDDEN, > 63253 <at> debbugs.gnu.org > Date: Tue, 09 May 2023 22:31:09 -0400 > > > Thanks, I think you should install this on the emacs-29 branch. And I > > think a similar change is needed in clear_message, so it doesn't call > > clear-message-function. > > OK, done. Thanks. > > But what does this mean for with-delayed-message and > > funcall-with-delayed-message? These were introduced in Emacs 29, but > > if we say that atimers cannot be used to safely run arbitrary Lisp, > > then we should somehow make them safer, perhaps by having in > > with_delayed_message_display a subset of code message3, without the > > calls to Lisp. WDYT? > > The code already falls back to a default behavior of displaying the > message in the echo area when calls to ELisp can't be used. You mean, the changes that you just installed? If so, that is AFAIU conditioned on garbage_collection_inhibited, which doesn't necessarily disable Lisp calls from delayed messages in all situations. Plus, we might at some point decide that garbage_collection_inhibited is not necessary in probably_quit. What I meant was to completely disable customizing set-message-function for delayed messages. We don't have to support that, and the fact that we call 'message' is just an implementation detail. If nothing else, this will make the effect on delayed messages consistent no matter when and how they are actually displayed.
bug-gnu-emacs@HIDDEN
:bug#63253
; Package emacs
.
Full text available.Received: (at 63253) by debbugs.gnu.org; 10 May 2023 02:31:26 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 09 22:31:26 2023 Received: from localhost ([127.0.0.1]:44919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pwZbx-0002p7-Sr for submit <at> debbugs.gnu.org; Tue, 09 May 2023 22:31:26 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:39274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <monnier@HIDDEN>) id 1pwZbw-0002ou-0q for 63253 <at> debbugs.gnu.org; Tue, 09 May 2023 22:31:24 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6697A8089E; Tue, 9 May 2023 22:31:18 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 3F0E68028B; Tue, 9 May 2023 22:31:17 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1683685877; bh=Bqj2/7jmeej1mijtZZlNxvUnsfozGvpSvL4o/ujwuOY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=fNoAdwL+xabl9J228c0RBpD6tLwa2HZbJNxcAuuWxmnePAWXh2HzF09PTivuZTtIl meOZZ+urZhG3Hto+gIalRGOwGlwPp+ROjWGrejtLSQ9I8ChxFAE9SrS4wJlbPKiyDY xuEj0XUyIIWAPpbI4OlYvCp5ZPkpTuDjTFJJF4AspsC3aYfryCnC6xrUqw1Y7iYrCl EbFxYGTtHsueetXXkLvSgum6pgKefcUY820LbmEhh4yuMqaDUH/W+9CHVty1AhGtqj NkRNwah5r6CWsBSliFrdnUgXvLvbjSV/hoccLyCPbZJZ8zPflWBfSZFb+5vnSKGfYx ALC7WiAvwj6Og== Received: from pastel (unknown [45.72.217.176]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A6F24120A0F; Tue, 9 May 2023 22:31:16 -0400 (EDT) From: Stefan Monnier <monnier@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#63253: 29.0.90; with-delayed-message fails in combination with inhibit-message In-Reply-To: <831qjqdcz9.fsf@HIDDEN> (Eli Zaretskii's message of "Mon, 08 May 2023 19:06:34 +0300") Message-ID: <jwvy1lwly8p.fsf-monnier+emacs@HIDDEN> References: <87r0rxdwc8.fsf@HIDDEN> <jwvpm7bnf0q.fsf-monnier+emacs@HIDDEN> <837ctidgab.fsf@HIDDEN> <jwvwn1in9tr.fsf-monnier+emacs@HIDDEN> <831qjqdcz9.fsf@HIDDEN> Date: Tue, 09 May 2023 22:31:09 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.104 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63253 Cc: mail@HIDDEN, Lars Ingebrigtsen <larsi@HIDDEN>, 63253 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Thanks, I think you should install this on the emacs-29 branch. And I > think a similar change is needed in clear_message, so it doesn't call > clear-message-function. OK, done. > But what does this mean for with-delayed-message and > funcall-with-delayed-message? These were introduced in Emacs 29, but > if we say that atimers cannot be used to safely run arbitrary Lisp, > then we should somehow make them safer, perhaps by having in > with_delayed_message_display a subset of code message3, without the > calls to Lisp. WDYT? The code already falls back to a default behavior of displaying the message in the echo area when calls to ELisp can't be used. Stefan
bug-gnu-emacs@HIDDEN
:bug#63253
; Package emacs
.
Full text available.Received: (at 63253) by debbugs.gnu.org; 8 May 2023 16:05:45 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 08 12:05:44 2023 Received: from localhost ([127.0.0.1]:41392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pw3Mu-0004PC-Ik for submit <at> debbugs.gnu.org; Mon, 08 May 2023 12:05:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1pw3Ms-0004Ox-9U for 63253 <at> debbugs.gnu.org; Mon, 08 May 2023 12:05:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pw3Mk-0006Rl-Dl; Mon, 08 May 2023 12:05:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=t7z1OXxj+QTcH7PhXNQ3ETdudSxhGsZCg6T/XzTxN2s=; b=qu2j+mYktBoH wqpPlyhJsRnZvja8/if+ZQ0myMQbAH6oG72NVm3f5p2YXvX4CIRVmB4ybKQL0X2uQJFFUMYnQTpJt 5Ru3m+4qQ4r8vIng4fHzmjTa7GbxXy2wyJSYUtijlDKS7ZvJKRgROBEEyNqVqYev1uKGcsjJmtRpQ PbneDFPqNxYoesc+Jo4STI7O17igK8QRman/fFmUrGPN/LMww94RuyLILloR5bG9YtFaWOIiG/Q+h tvbNKxTxeiJTJb0eb97AUJkz5SLS0DyGt8HVL4xmu8cLb2haKqAo755u8u34nXm5dk+Jw5uD2KQVz 6pJWDy1fPHLZ7MEdfLi+AA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pw3Mj-0004aR-TY; Mon, 08 May 2023 12:05:34 -0400 Date: Mon, 08 May 2023 19:06:34 +0300 Message-Id: <831qjqdcz9.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Stefan Monnier <monnier@HIDDEN>, Lars Ingebrigtsen <larsi@HIDDEN> In-Reply-To: <jwvwn1in9tr.fsf-monnier+emacs@HIDDEN> (message from Stefan Monnier on Mon, 08 May 2023 11:13:37 -0400) Subject: Re: bug#63253: 29.0.90; with-delayed-message fails in combination with inhibit-message References: <87r0rxdwc8.fsf@HIDDEN> <jwvpm7bnf0q.fsf-monnier+emacs@HIDDEN> <837ctidgab.fsf@HIDDEN> <jwvwn1in9tr.fsf-monnier+emacs@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63253 Cc: mail@HIDDEN, 63253 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Stefan Monnier <monnier@HIDDEN> > Cc: mail@HIDDEN, 63253 <at> debbugs.gnu.org > Date: Mon, 08 May 2023 11:13:37 -0400 > > >> So `set-message-function` is "dangerous" because it runs ELisp code from > >> `message3` => `message3_nolog` => `set_message`. > > > > So I guess we need to have run_timers bind some variable, and then in > > set_message, if that variable is non-nil, we should avoid calling > > functions from set-message-function? > > That's probably the best short-term workaround, yes. > > The quick hack below seems to avoid the problem for me (at the cost of > ignoring `inhibit-message` for the `with-delayed-message`s). Thanks, I think you should install this on the emacs-29 branch. And I think a similar change is needed in clear_message, so it doesn't call clear-message-function. But what does this mean for with-delayed-message and funcall-with-delayed-message? These were introduced in Emacs 29, but if we say that atimers cannot be used to safely run arbitrary Lisp, then we should somehow make them safer, perhaps by having in with_delayed_message_display a subset of code message3, without the calls to Lisp. WDYT?
bug-gnu-emacs@HIDDEN
:bug#63253
; Package emacs
.
Full text available.Received: (at 63253) by debbugs.gnu.org; 8 May 2023 15:27:32 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 08 11:27:32 2023 Received: from localhost ([127.0.0.1]:41357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pw2lw-0003Ce-Ea for submit <at> debbugs.gnu.org; Mon, 08 May 2023 11:27:32 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:45037) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <monnier@HIDDEN>) id 1pw2lu-0003CS-Tx for 63253 <at> debbugs.gnu.org; Mon, 08 May 2023 11:27:31 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6512F80BAF; Mon, 8 May 2023 11:27:25 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2E64C8025F; Mon, 8 May 2023 11:27:24 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1683559644; bh=zJny60KMSJj3SSRlrTjvt+GTPejmUWIwdqCOpX5yU74=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=lFRA28GBZJPFlKRqWOTd0NQMpvtiTCuYrP2TvxGiqVd6CT+2PuvKLJmVbncTsJOaT DMY9TGQ46mMz/1LgM866kvuABdSBqADaxVNQib0bAnScf8TQSkc4tWD7X82uDFR6Jf v8wYWdu3PPgoPWEaR4347dGS6uR2K0u+7icoxGUs4OqkcIEywYW1Vr3VNKsOX94NS4 msEoudeMAWGWdkzZ01fNOW1Iia3yPekIeYKR4uDbTTxdnknQIhqS5mLWvL7K7f6OJJ y24fgUP9ArU2ZhNpdUAsFoZW2s424aavsSF0PWzTj5d25Usw1oJktOOaIkOlKz8UUc ZrTnENxC/WBhg== Received: from pastel (unknown [45.72.217.176]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E574012068A; Mon, 8 May 2023 11:27:23 -0400 (EDT) From: Stefan Monnier <monnier@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#63253: 29.0.90; with-delayed-message fails in combination with inhibit-message In-Reply-To: <833546df71.fsf@HIDDEN> (Eli Zaretskii's message of "Mon, 08 May 2023 18:18:42 +0300") Message-ID: <jwvr0rqn8yz.fsf-monnier+emacs@HIDDEN> References: <87r0rxdwc8.fsf@HIDDEN> <jwvpm7bnf0q.fsf-monnier+emacs@HIDDEN> <837ctidgab.fsf@HIDDEN> <833546df71.fsf@HIDDEN> Date: Mon, 08 May 2023 11:27:22 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.107 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63253 Cc: mail@HIDDEN, 63253 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Or maybe (or in addition) regex-emacs.c should save and restore its > state around calls to maybe_quit? Is that possible? That would be very costly, I think. But maybe `gl_state` can be turned into an array (stack) of states, or can be stack-allocated, so that when we can do nested regexp matches safely. There's still the issue that `set-message-functions` could theoretically do nasty things like insert/delete text in the current buffer, leading to `regexp.c` containing stale pointers to the old text. Stefan
bug-gnu-emacs@HIDDEN
:bug#63253
; Package emacs
.
Full text available.Received: (at 63253) by debbugs.gnu.org; 8 May 2023 15:17:50 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 08 11:17:50 2023 Received: from localhost ([127.0.0.1]:41352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pw2cY-0002wr-Bq for submit <at> debbugs.gnu.org; Mon, 08 May 2023 11:17:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1pw2cW-0002wf-QP for 63253 <at> debbugs.gnu.org; Mon, 08 May 2023 11:17:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pw2cP-0002RZ-Tl; Mon, 08 May 2023 11:17:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Ew2VjXlfF5GKi6LIwhEhT0KCbfI//kDg4RwdLK2pEho=; b=UzGzDzrGqPsh WPy3bLWRIlS/gd49F/B12MOGtzlsqngwEhEcJQTVHjF+6YGTWgfHHoCpvRKjF5IRQKnb/NBjqt2Sr ZCEtFCVeLuyRPXOUyIszMPL+sNw0SUEjqeVV9M4HbkCCsvuJGgt9IInA6TEtDN7+VkqWa9YavOcM3 UgXKDpDeHuvE6/oaKgG1Ys/f0FRl0z/08IopTMhrVjRPziAi3dZHl5ojuoez9UFsgaqTnf24m/Phs SNKedY05bwUWss8aodeon0awIr8zWYXb7XgWX8GiJovUijrAzrqK+5uAbqPv6KW1aoUoFXbz12/FG pdFRquqfRTML8m/7IXqkrw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pw2cO-0003Jp-VZ; Mon, 08 May 2023 11:17:41 -0400 Date: Mon, 08 May 2023 18:18:42 +0300 Message-Id: <833546df71.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: monnier@HIDDEN In-Reply-To: <837ctidgab.fsf@HIDDEN> (message from Eli Zaretskii on Mon, 08 May 2023 17:55:08 +0300) Subject: Re: bug#63253: 29.0.90; with-delayed-message fails in combination with inhibit-message References: <87r0rxdwc8.fsf@HIDDEN> <jwvpm7bnf0q.fsf-monnier+emacs@HIDDEN> <837ctidgab.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63253 Cc: mail@HIDDEN, 63253 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: mail@HIDDEN, 63253 <at> debbugs.gnu.org > Date: Mon, 08 May 2023 17:55:08 +0300 > From: Eli Zaretskii <eliz@HIDDEN> > > > So `set-message-function` is "dangerous" because it runs ELisp code from > > `message3` => `message3_nolog` => `set_message`. > > So I guess we need to have run_timers bind some variable, and then in > set_message, if that variable is non-nil, we should avoid calling > functions from set-message-function? Or maybe (or in addition) regex-emacs.c should save and restore its state around calls to maybe_quit? Is that possible?
bug-gnu-emacs@HIDDEN
:bug#63253
; Package emacs
.
Full text available.Received: (at 63253) by debbugs.gnu.org; 8 May 2023 15:13:48 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 08 11:13:48 2023 Received: from localhost ([127.0.0.1]:41340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pw2Ye-0002ov-90 for submit <at> debbugs.gnu.org; Mon, 08 May 2023 11:13:48 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:28433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <monnier@HIDDEN>) id 1pw2Yc-0002oh-RC for 63253 <at> debbugs.gnu.org; Mon, 08 May 2023 11:13:47 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2F9991001A4; Mon, 8 May 2023 11:13:41 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D747E100193; Mon, 8 May 2023 11:13:39 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1683558819; bh=xLu/7ovlpT4vLBO1Z7ZpgHParpMzi4h57rsr1BJqqBg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=oC60/dXzFZutngKYnl2rdyh0xm9cwkluNQ2lRZt77RlNq59vUZ1D1B5LD8QXqj1m8 RISUp/3IgzxAOOsPjgDJtkSriX+A79TWznN7Vsi+bnhAKSIbpfkbmmE20BMl3iRRc7 +sEQ3ikidN6TrGNiVZMHp9rQAtfXjmpumBKINWsJzsPPeUMemWDl98H8muzmLwhhNQ mYH8jF28L6GCZvRYJiAopYsYA6/7K/xEXAMbxmrydJuVBVwpt9VqCniswETDvWNOLx N4yYZk7fLu4IANxtqNQtvNF96aJV01Bbtu6k+M/Q2PUMlxaUc1eDeVzfrc/QXFzQfi y5sxUJp7X1Iwg== Received: from pastel (unknown [45.72.217.176]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A96901206CB; Mon, 8 May 2023 11:13:39 -0400 (EDT) From: Stefan Monnier <monnier@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#63253: 29.0.90; with-delayed-message fails in combination with inhibit-message In-Reply-To: <837ctidgab.fsf@HIDDEN> (Eli Zaretskii's message of "Mon, 08 May 2023 17:55:08 +0300") Message-ID: <jwvwn1in9tr.fsf-monnier+emacs@HIDDEN> References: <87r0rxdwc8.fsf@HIDDEN> <jwvpm7bnf0q.fsf-monnier+emacs@HIDDEN> <837ctidgab.fsf@HIDDEN> Date: Mon, 08 May 2023 11:13:37 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.192 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63253 Cc: mail@HIDDEN, 63253 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) >> So `set-message-function` is "dangerous" because it runs ELisp code from >> `message3` => `message3_nolog` => `set_message`. > > So I guess we need to have run_timers bind some variable, and then in > set_message, if that variable is non-nil, we should avoid calling > functions from set-message-function? That's probably the best short-term workaround, yes. The quick hack below seems to avoid the problem for me (at the cost of ignoring `inhibit-message` for the `with-delayed-message`s). Stefan diff --git a/src/alloc.c b/src/alloc.c index 05a19f0b7e9..7ff2cd3b100 100644 --- a/src/alloc.c +++ b/src/alloc.c @@ -367,7 +367,7 @@ #define PUREBEG (char *) pure /* If positive, garbage collection is inhibited. Otherwise, zero. */ -static intptr_t garbage_collection_inhibited; +intptr_t garbage_collection_inhibited; /* The GC threshold in bytes, the last time it was calculated from gc-cons-threshold and gc-cons-percentage. */ diff --git a/src/xdisp.c b/src/xdisp.c index 43847544396..a5d7d256b6d 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -12810,6 +12810,8 @@ truncate_message_1 (void *a1, Lisp_Object a2) return false; } +extern intptr_t garbage_collection_inhibited; + /* Set the current message to STRING. */ static void @@ -12819,7 +12821,11 @@ set_message (Lisp_Object string) eassert (STRINGP (string)); - if (FUNCTIONP (Vset_message_function)) + if (FUNCTIONP (Vset_message_function) + /* FIXME: (bug#63253) We should really make the regexp engine re-entrant, + but in the mean time, let's ignore `set-message-function` when + called from `probably_quit`. */ + && !garbage_collection_inhibited) { specpdl_ref count = SPECPDL_INDEX (); specbind (Qinhibit_quit, Qt);
bug-gnu-emacs@HIDDEN
:bug#63253
; Package emacs
.
Full text available.Received: (at 63253) by debbugs.gnu.org; 8 May 2023 14:54:42 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 08 10:54:42 2023 Received: from localhost ([127.0.0.1]:41298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pw2GA-0002Cq-7N for submit <at> debbugs.gnu.org; Mon, 08 May 2023 10:54:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1pw2G7-0002Cc-SO for 63253 <at> debbugs.gnu.org; Mon, 08 May 2023 10:54:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pw2Fu-0003lX-Fs; Mon, 08 May 2023 10:54:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=sOhW/XukgnN9r5TAIXLNbTQE1DVXdgXvSkUo7BH5yUQ=; b=Sjr42dRNKeGH 4RGC+tjJwQ7qtDQ6BowefG/N43a4zAelIQg+NqCMMkNSGAdBDTH4AHFXscC1FsbFTDPBLrZgzSquz 7bwmP0QhF0wkPC98c8Gk+JYzrT3cy5a4uyzDEdSVbaF+kmY0dewwl0E6mHUayToEdVANj2NnLuniK kMxEykpXHHVrxjLZIP+fHlSsAmYP9VzpAVLCqiOWZr9zBvRiEutbGfR8Lt+/28xJCX11I7D5WYeDg MA6Vk6709z/r3oRVqzj2kvhMIwk4IgPzrsbOLzqXtwFQVtNtgJ29RYCU7N0wCt/sQ0pjZA4EW0lQG 5wVepk4AdpfDGw2wViKWNw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pw2Fb-0002Um-JK; Mon, 08 May 2023 10:54:25 -0400 Date: Mon, 08 May 2023 17:55:08 +0300 Message-Id: <837ctidgab.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> In-Reply-To: <jwvpm7bnf0q.fsf-monnier+emacs@HIDDEN> (bug-gnu-emacs@HIDDEN) Subject: Re: bug#63253: 29.0.90; with-delayed-message fails in combination with inhibit-message References: <87r0rxdwc8.fsf@HIDDEN> <jwvpm7bnf0q.fsf-monnier+emacs@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63253 Cc: mail@HIDDEN, 63253 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: 63253 <at> debbugs.gnu.org > Date: Mon, 08 May 2023 09:54:35 -0400 > From: Stefan Monnier via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > > There seems to exist an interaction issue of `with-delayed-message' with > > `inhibit-message'. > > Very much so, indeed. The issue is fundamentally linked to > `set-message-function`: > > `with-delayed-message` calls `message3` (via > `with_delayed_message_display`) from an "atimer", i.e. a thing that can > be run from `process_pending_signals`, `unblock_input`, `maybe_quit`, ... > > AFAIK these are places where it's safe to run some C code, but not > places where it's safe to run arbitrary ELisp code. > > So `set-message-function` is "dangerous" because it runs ELisp code from > `message3` => `message3_nolog` => `set_message`. So I guess we need to have run_timers bind some variable, and then in set_message, if that variable is non-nil, we should avoid calling functions from set-message-function?
bug-gnu-emacs@HIDDEN
:bug#63253
; Package emacs
.
Full text available.Received: (at 63253) by debbugs.gnu.org; 8 May 2023 13:54:51 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 08 09:54:51 2023 Received: from localhost ([127.0.0.1]:39624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pw1KE-0005tc-Oy for submit <at> debbugs.gnu.org; Mon, 08 May 2023 09:54:51 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:6660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <monnier@HIDDEN>) id 1pw1KC-0005tN-FY for 63253 <at> debbugs.gnu.org; Mon, 08 May 2023 09:54:49 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9452380BAF; Mon, 8 May 2023 09:54:42 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 62FDD8025F; Mon, 8 May 2023 09:54:41 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1683554081; bh=luTOcnjSckXGkJ6mG+SzKbPYl7BZEPd2HsdYj915Ojc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=fKwKCnmpH5IeXfTcTknxBhG/a34ZTn1eHPun4vU6SMY0BxZW7zrrKs+mYieP2LXM5 JTM4n0U8YLunsl3TObguUUSd9bSsxqAS/GCc8jkpwlsn4YC9sSx8kBgWrCBLAmmiVo CKol7GLCRgHKZlkKUGqJKOb5aPJBwgYUTZqAajRwAPGCfgQVwZ768s1p1FhmCIjihB ePN0B4QQ+j7K/S8cGzEygpzhNIjpF2M4BD8zLxuMgNNzAkDSj3wix6ORvkNouZCao5 0Ko0BVr92l5NYJ0nWdY3Z2Z6xOt0oYWXqTZMtJDoxz+kAvMYFGTrXmh2tZ5sIBcF08 6WLggFGYbIR3g== Received: from pastel (unknown [45.72.217.176]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0F6DA12029D; Mon, 8 May 2023 09:54:41 -0400 (EDT) From: Stefan Monnier <monnier@HIDDEN> To: Daniel Mendler <mail@HIDDEN> Subject: Re: bug#63253: 29.0.90; with-delayed-message fails in combination with inhibit-message In-Reply-To: <87r0rxdwc8.fsf@HIDDEN> (Daniel Mendler's message of "Wed, 03 May 2023 21:54:47 +0200") Message-ID: <jwvpm7bnf0q.fsf-monnier+emacs@HIDDEN> References: <87r0rxdwc8.fsf@HIDDEN> Date: Mon, 08 May 2023 09:54:35 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.110 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63253 Cc: 63253 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > There seems to exist an interaction issue of `with-delayed-message' with > `inhibit-message'. Very much so, indeed. The issue is fundamentally linked to `set-message-function`: `with-delayed-message` calls `message3` (via `with_delayed_message_display`) from an "atimer", i.e. a thing that can be run from `process_pending_signals`, `unblock_input`, `maybe_quit`, ... AFAIK these are places where it's safe to run some C code, but not places where it's safe to run arbitrary ELisp code. So `set-message-function` is "dangerous" because it runs ELisp code from `message3` => `message3_nolog` => `set_message`. I think this is related to bug#58042. Here the problem is that the regexp engine is stateful, so calling a regexp function in the middle of another regexp match causes serious problems. When we need to run ELisp from a regexp match for on-the-fly syntax-propertization (in `parse_sexp_propertize`), we're careful to try and detect if the ELisp code may have modified the current buffer and we re-set the `gl_state` with a call to `SETUP_SYNTAX_TABLE`. But when `with-delayed-message' performs a regexp operation from within another regexp match, it doesn't re-set the `gl_state`, which then leads to this "Error in syntax_table logic for to-the-end intervals" error. I'm surprised we haven't yet seen the same problem when the ELisp code is run via things like -[EmacsView layoutSublayersOfLayer:] which can be called from `maybe_quit` and call `redisplay` which in turn can run arbitrary ELisp code (via `mode-line-format`, jit-lock, you name it). Stefan
bug-gnu-emacs@HIDDEN
:bug#63253
; Package emacs
.
Full text available.Received: (at 63253) by debbugs.gnu.org; 4 May 2023 22:13:55 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 04 18:13:55 2023 Received: from localhost ([127.0.0.1]:52267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1puhD1-0003Vr-1G for submit <at> debbugs.gnu.org; Thu, 04 May 2023 18:13:55 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:43263) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <monnier@HIDDEN>) id 1puhCy-0003Vc-Tm for 63253 <at> debbugs.gnu.org; Thu, 04 May 2023 18:13:53 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2770280937; Thu, 4 May 2023 18:13:47 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C0704805AC; Thu, 4 May 2023 18:13:45 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1683238425; bh=IoIfqIhyp7R58Su22cmCm10Qjp9MEoCwnBnKA13w65A=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=i+VbMVGl+QXd5+WAIsMvRrDrIV6KxwhINc1YkJFt4fKEzyVbwTskwKekpUhiS/Yg3 gYoQ+cah0zCuX79plEL6sp5A0JqS9fOMY4bdQDFCLeba4hDI3xOYpsXiEczfHYGPhX arxOrCctvQ4ch1QTcZlcLfC1TcmBEqvvZIt5zppBhEmd4jwDYFUswmUdsVa6kBCvFY OgCgoz2jp/kpouQ0lj7ksYFImTgbb8N2Kavp5o0Ljk2j4YuaxBlTkgi56Eg1Yc0UoU VF8gIjZasGZbqnK4YOXGvhxoaiJAuKpQlrLw30py5iiwP4KLG0rtZ8wyKS42wgjqVd FJ4rQTaA/BAXQ== Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 97804120978; Thu, 4 May 2023 18:13:45 -0400 (EDT) From: Stefan Monnier <monnier@HIDDEN> To: Daniel Mendler <mail@HIDDEN> Subject: Re: bug#63253: 29.0.90; with-delayed-message fails in combination with inhibit-message In-Reply-To: <87r0rxdwc8.fsf@HIDDEN> (Daniel Mendler's message of "Wed, 03 May 2023 21:54:47 +0200") Message-ID: <jwvfs8bsqpy.fsf-monnier+emacs@HIDDEN> References: <87r0rxdwc8.fsf@HIDDEN> Date: Thu, 04 May 2023 18:13:44 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.013 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63253 Cc: 63253 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > There seems to exist an interaction issue of `with-delayed-message' with > `inhibit-message'. In order to reproduce the issue, start emacs -Q and > evaluate the following function: > > (defun delayed-message-bug () > (interactive) > (setq inhibit-message-regexps (list "\\`something")) > (add-to-list 'set-message-functions #'inhibit-message) > (while t > (with-delayed-message (0.5 "Fontifying...") > (font-lock-flush (point-min) (point-max)) > (font-lock-ensure (point-min) (point-max))) > (message "Done"))) > > Then open a large file like emacs/src/xterm.c and run `M-x > delayed-message-bug'. The error may not occur on the first try since it > is timing dependent. Retry a few times if no error is observed. I > observe the internal error After several unsuccessful attempts, I just managed to reproduce the problem here. Not sure yet what was the magic incantation, but at least I should now be able to look into the source of the problem. Stefan
bug-gnu-emacs@HIDDEN
:bug#63253
; Package emacs
.
Full text available.Received: (at 63253) by debbugs.gnu.org; 4 May 2023 05:20:40 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 04 01:20:40 2023 Received: from localhost ([127.0.0.1]:48218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1puROS-0003o7-Ge for submit <at> debbugs.gnu.org; Thu, 04 May 2023 01:20:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1puROQ-0003ns-EE for 63253 <at> debbugs.gnu.org; Thu, 04 May 2023 01:20:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1puROI-0007vc-Iu; Thu, 04 May 2023 01:20:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ICD8CIDMIJ4Tg7V0cAljuy0gpJybkrNDBvD2EhY0A14=; b=AsokJjqg1DRS QFY4UwkRd5asq5ddNRj4CdjhxfyiJgtLNIqdPmWcw5FsGnvuLQZ9CmetKK05gfYL+bYofMh3krdmd FP0GfevwjGWguhrVGXs2cOHBQby1Vs9bLq8xzMd0nW7q7zw4wxICrS5a/Gn/QXwYgK1q7B6lGvpmJ 71uwEmXgKfeEpLQN34X5yqMAnL/V2fsisa10ULqdBLzGVh6Vc24PuSo8+FfVYS6471Gm+Kb2vd35v 5ASebcVaZlj2oGu/PSoyHOJec45I9uhkImwkvJN6Z2m8gvZJWC3QLH/Z41fsRoVfb2lhjOAI9u54s ZhjonMA/uGi4aQE0odpj6w==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1puROI-0000HB-2j; Thu, 04 May 2023 01:20:30 -0400 Date: Thu, 04 May 2023 08:21:19 +0300 Message-Id: <83lei4llio.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Daniel Mendler <mail@HIDDEN>, Stefan Monnier <monnier@HIDDEN> In-Reply-To: <87r0rxdwc8.fsf@HIDDEN> (message from Daniel Mendler on Wed, 03 May 2023 21:54:47 +0200) Subject: Re: bug#63253: 29.0.90; with-delayed-message fails in combination with inhibit-message References: <87r0rxdwc8.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63253 Cc: 63253 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Daniel Mendler <mail@HIDDEN> > Date: Wed, 03 May 2023 21:54:47 +0200 > > There seems to exist an interaction issue of `with-delayed-message' with > `inhibit-message'. In order to reproduce the issue, start emacs -Q and > evaluate the following function: > > (defun delayed-message-bug () > (interactive) > (setq inhibit-message-regexps (list "\\`something")) > (add-to-list 'set-message-functions #'inhibit-message) > (while t > (with-delayed-message (0.5 "Fontifying...") > (font-lock-flush (point-min) (point-max)) > (font-lock-ensure (point-min) (point-max))) > (message "Done"))) > > Then open a large file like emacs/src/xterm.c and run `M-x > delayed-message-bug'. The error may not occur on the first try since it > is timing dependent. Retry a few times if no error is observed. I > observe the internal error > > Error in syntax_table logic for to-the-end intervals > > which is produced by `update_syntax_table' from syntax.c. Stefan, and ideas/suggestions/hints?
bug-gnu-emacs@HIDDEN
:bug#63253
; Package emacs
.
Full text available.Received: (at submit) by debbugs.gnu.org; 3 May 2023 19:55:16 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 03 15:55:16 2023 Received: from localhost ([127.0.0.1]:47790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1puIZI-0001XB-AY for submit <at> debbugs.gnu.org; Wed, 03 May 2023 15:55:16 -0400 Received: from lists.gnu.org ([209.51.188.17]:57874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mail@HIDDEN>) id 1puIZG-0001Wl-7c for submit <at> debbugs.gnu.org; Wed, 03 May 2023 15:55:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <mail@HIDDEN>) id 1puIZD-0004J1-RS for bug-gnu-emacs@HIDDEN; Wed, 03 May 2023 15:55:11 -0400 Received: from server.qxqx.de ([2a01:4f8:121:346::180] helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <mail@HIDDEN>) id 1puIZB-0007FS-9g for bug-gnu-emacs@HIDDEN; Wed, 03 May 2023 15:55:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From :Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=d3+x8Ptpl6RFLp39B0vdteT0tTjilBe0LVhE2mELa8U=; b=VQD781qNrHslYFtJ3YX4f9V3yQ eekmByDfO6SNANT9rGiLr/Dd84cHbTO5XHu57e6lJ80954QwAl3QFyPgjqy7OgieReloalIrvONMI cSfjhbL0lyCaM0TJKva7PxVkEac71Fe9x109xNUejKBENBmSGfJa8D6X8FiVVChCY6TE=; From: Daniel Mendler <mail@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: 29.0.90; with-delayed-message fails in combination with inhibit-message Date: Wed, 03 May 2023 21:54:47 +0200 Message-ID: <87r0rxdwc8.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@HIDDEN; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.4 (--) There seems to exist an interaction issue of `with-delayed-message' with `inhibit-message'. In order to reproduce the issue, start emacs -Q and evaluate the following function: (defun delayed-message-bug () (interactive) (setq inhibit-message-regexps (list "\\`something")) (add-to-list 'set-message-functions #'inhibit-message) (while t (with-delayed-message (0.5 "Fontifying...") (font-lock-flush (point-min) (point-max)) (font-lock-ensure (point-min) (point-max))) (message "Done"))) Then open a large file like emacs/src/xterm.c and run `M-x delayed-message-bug'. The error may not occur on the first try since it is timing dependent. Retry a few times if no error is observed. I observe the internal error Error in syntax_table logic for to-the-end intervals which is produced by `update_syntax_table' from syntax.c. In GNU Emacs 29.0.90 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw scroll bars) of 2023-04-27 Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Debian GNU/Linux 11 (bullseye) Configured using: 'configure --prefix=/home/user/emacs/install --with-json --with-native-compilation --with-x-toolkit=athena --without-dbus --without-selinux --without-threads --without-gsettings --with-cairo' Configured features: CAIRO FREETYPE GIF GLIB GMP GNUTLS HARFBUZZ JPEG JSON LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XPM LUCID ZLIB
Daniel Mendler <mail@HIDDEN>
:bug-gnu-emacs@HIDDEN
.
Full text available.bug-gnu-emacs@HIDDEN
:bug#63253
; Package emacs
.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.