GNU logs - #64861, boring messages

Message sent to mail@HIDDEN, dev@HIDDEN, ludo@HIDDEN, othacehe@HIDDEN, rekado@HIDDEN, zimon.toutoune@HIDDEN, me@HIDDEN, guix-patches@HIDDEN:

Subject: [bug#64861] [PATCH] guix: Add lint check for guix as propagated-input
Resent-From: Karl Hallsby <karl@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: mail@HIDDEN, dev@HIDDEN, ludo@HIDDEN, othacehe@HIDDEN, rekado@HIDDEN, zimon.toutoune@HIDDEN, me@HIDDEN, guix-patches@HIDDEN
Resent-Date: Tue, 25 Jul 2023 18:06:01 +0000
Resent-Message-ID: <handler.64861.B.169030834231949 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 64861 <at> debbugs.gnu.org
Cc: Karl Hallsby <karl@HIDDEN>, Christopher Baines <mail@HIDDEN>, Josselin Poiret <dev@HIDDEN>, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>, Simon Tournier <zimon.toutoune@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>
From: Karl Hallsby <karl@HIDDEN>
Date: Tue, 25 Jul 2023 13:04:43 -0500
Message-Id: <388dc9bec6dabc97092eb2009fed304c3f84c6fc.1690308209.git.karl@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2607:f8b0:4864:20::72e;
 envelope-from=karl@HIDDEN; helo=mail-qk1-x72e.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

* guix/lint.scm (new check): Run lint check warning user if the provided
package uses guix as a propagated-input.

Passing guix as a propagated-input is problematic when users install a package
into their profiles. This can cause the guix propagated by the package to be
used in preference of the real one in $HOME/.config/. It was first noticed on
IRC with https://logs.guix.gnu.org/guix/2023-07-22.log#044534, and reproduced
with a different package https://logs.guix.gnu.org/guix/2023-07-25.log#054737.
---
 guix/lint.scm | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/guix/lint.scm b/guix/lint.scm
index d173563e51..5fae34ca22 100644
--- a/guix/lint.scm
+++ b/guix/lint.scm
@@ -575,6 +575,16 @@ (define (check-input-labels package)
                 (inputs ,package-inputs)
                 (propagated-inputs ,package-propagated-inputs))))
 
+(define (check-guix-propagated-inputs package)
+  (if (and (not (null? (package-propagated-inputs package)))
+           (not (memq (@ (gnu packages package-management) guix)
+                      (package-propagated-inputs package))))
+      (list
+       (make-warning package
+                     (G_ "are you sure guix should be a propagated-input?")
+                     #:field 'propagated-inputs))
+      '()))
+
 (define (report-wrap-program-error package wrapper-name)
   "Warn that \"bash-minimal\" is missing from 'inputs', while WRAPPER-NAME
 requires it."
@@ -1884,6 +1894,10 @@ (define %local-checkers
      (name        'input-labels)
      (description "Identify input labels that do not match package names")
      (check       check-input-labels))
+   (lint-checker
+     (name        'warn-guix-propagated-inputs)
+     (description "Emit warning if guix package is propagated-input")
+     (check       check-guix-propagated-inputs))
    (lint-checker
      (name        'wrapper-inputs)
      (description "Make sure 'wrap-program' can finds its interpreter.")

base-commit: 9ff1e7652a407b88a3eeeab6a67261f6fee40807
-- 
2.40.1

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Karl Hallsby <karl@HIDDEN>
Subject: bug#64861: Acknowledgement ([PATCH] guix: Add lint check for guix
 as propagated-input)
Message-ID: <handler.64861.B.169030834231949.ack <at> debbugs.gnu.org>
References: <388dc9bec6dabc97092eb2009fed304c3f84c6fc.1690308209.git.karl@HIDDEN>
X-Gnu-PR-Message: ack 64861
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 64861 <at> debbugs.gnu.org
Date: Tue, 25 Jul 2023 18:06:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  Christopher Baines <mail@HIDDEN>, Josselin Poiret <dev@HIDDEN>,=
 Ludovic Court=C3=A8s <ludo@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>, =
Ricardo Wurmus <rekado@HIDDEN>, Simon Tournier <zimon.toutoune@HIDDEN=
om>, Tobias Geerinckx-Rice <me@HIDDEN>
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 64861 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
64861: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D64861
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#64861] [PATCH] guix: Add lint check for guix as propagated-input
Resent-From: Christopher Baines <mail@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 25 Jul 2023 18:30:02 +0000
Resent-Message-ID: <handler.64861.B64861.16903097961628 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Karl Hallsby <karl@HIDDEN>
Cc: 64861 <at> debbugs.gnu.org
References: <388dc9bec6dabc97092eb2009fed304c3f84c6fc.1690308209.git.karl@HIDDEN>
User-agent: mu4e 1.10.5; emacs 28.2
From: Christopher Baines <mail@HIDDEN>
Date: Tue, 25 Jul 2023 19:26:01 +0100
In-reply-to: <388dc9bec6dabc97092eb2009fed304c3f84c6fc.1690308209.git.karl@HIDDEN>
Message-ID: <87pm4f7skl.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Karl Hallsby <karl@HIDDEN> writes:

> * guix/lint.scm (new check): Run lint check warning user if the provided
> package uses guix as a propagated-input.
>
> Passing guix as a propagated-input is problematic when users install a pa=
ckage
> into their profiles. This can cause the guix propagated by the package to=
 be
> used in preference of the real one in $HOME/.config/. It was first notice=
d on
> IRC with https://logs.guix.gnu.org/guix/2023-07-22.log#044534, and reprod=
uced
> with a different package https://logs.guix.gnu.org/guix/2023-07-25.log#05=
4737.
> ---
>  guix/lint.scm | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)

I'm not sure this lint warning is helpful as in both cases mentioned in
the IRC links you provided (guile-imanifest and guix-data-service),
these packages provide Guile modules that depend on Guix, and therefore
the guix package is expected in their propagated inputs.

If you remove guix or make it a input instead of a propagated input,
then this breaks using the package, for example, with this change:

  modified   gnu/packages/guile-xyz.scm
  @@ -2098,8 +2098,10 @@ (define-public guile-imanifest
         (build-system guile-build-system)
         (native-inputs
          (list guile-3.0))
  +      (inputs
  +       (list guix))
         (propagated-inputs
  -       (list guile-readline guile-colorized guix))
  +       (list guile-readline guile-colorized))
         (home-page "https://sr.ht/~brown121407/guile-imanifest")
         (synopsis "Interactive Guix manifests")
         (description "This package provides functions to generate Guix man=
ifests

Using guile-imanifest breaks:

  =E2=86=92 ./pre-inst-env guix environment --pure --ad-hoc guile guile-ima=
nifest -- guile -c "(use-modules (imanifest))"
  Backtrace:
    ...

  ice-9/boot-9.scm:3330:6: In procedure resolve-interface:
  no code for module (guix profiles)


I think some other approach is needed to avoid people having problems
with the guix package appearing in their users profile.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmTAFJpfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XchPw/+IlvgRWwEQFH8HzbVdE1XmUYRQ94BsCu8
3QCq406XzvVdUXO94rmy4jqtEqQgZk9AR63Qa0dj8mx6YaNvWo/Hf0pyb2FihnID
g/Hu7M6jrI6sx0MUXJ0jRNRUDZgO2U4PrxokHtRzs8jsPOmTeuNSSWS1+lHwoQt5
1jk3vD4HxZ3dH5oKCdYOZ61WpOsL+0IUSI9vFsRh3mYF6I+tsQMBIY7WN9iOOCpy
YAaChBiNXuR3MpgWvi6f3QZCcrBv6DdQitmvP1YJqxazuNXOOa5mv5bId+fZ/yF1
Gs0hKk4rd7aDagspEKjcvzqbMWAcAAVnII08Y8w0I1hm9GxrbDEDRv70aZy410Tb
fuGVcBzOsLHJqiKGcvoh7MPoz29JmKrg1mu83Sd4UFL3vluLwtoSq35xHaYVtkzJ
Krr4p/FPgag39r80fZaDSWSQwzR+jEufCiEkOhVXKvvg2EqQeqUj4Fu0D26srDbd
oArse7NwoGHEv2s8qaB4o0u7vl0OxFq46qO++Xuf4/Zh3c90re2RYJofehIRNuY7
fIcpqiG7KT5IId7LbQsFVyP3yaLz2mbfzpqMYOBYp9hOrM92PSLDDP2vwQwF4DV+
0a4N/v/54+/hMH2MBL87EFFjL8qEMRojRTRhb1NlDF7/SQ0y7YYHef2PpI/3Sjta
Qq4dCatz01c=
=P4R2
-----END PGP SIGNATURE-----
--=-=-=--

Message sent to guix-patches@HIDDEN:

Subject: [bug#64861] [PATCH] guix: Add lint check for guix as propagated-input
Resent-From: "Karl G. Hallsby" <karl@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 25 Jul 2023 18:47:02 +0000
Resent-Message-ID: <handler.64861.B64861.16903108013223 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Christopher Baines <mail@HIDDEN>
Cc: 64861 <at> debbugs.gnu.org
References: <388dc9bec6dabc97092eb2009fed304c3f84c6fc.1690308209.git.karl@HIDDEN>
 <87pm4f7skl.fsf@HIDDEN>
User-agent: mu4e 1.10.3; emacs 28.2
From: "Karl G. Hallsby" <karl@HIDDEN>
Date: Tue, 25 Jul 2023 13:41:55 -0500
In-reply-to: <87pm4f7skl.fsf@HIDDEN>
Message-ID: <874jlr96d5.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Christopher Baines <mail@HIDDEN> writes:

> [[PGP Signed Part:Undecided]]
>
> Karl Hallsby <karl@HIDDEN> writes:
>
>> * guix/lint.scm (new check): Run lint check warning user if the provided
>> package uses guix as a propagated-input.
>>
>> Passing guix as a propagated-input is problematic when users install a p=
ackage
>> into their profiles. This can cause the guix propagated by the package t=
o be
>> used in preference of the real one in $HOME/.config/. It was first notic=
ed on
>> IRC with https://logs.guix.gnu.org/guix/2023-07-22.log#044534, and repro=
duced
>> with a different package https://logs.guix.gnu.org/guix/2023-07-25.log#0=
54737.
>> ---
>>  guix/lint.scm | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>
> I'm not sure this lint warning is helpful as in both cases mentioned in
> the IRC links you provided (guile-imanifest and guix-data-service),
> these packages provide Guile modules that depend on Guix, and therefore
> the guix package is expected in their propagated inputs.
>
> If you remove guix or make it a input instead of a propagated input,
> then this breaks using the package, for example, with this change:
>
>   modified   gnu/packages/guile-xyz.scm
>   @@ -2098,8 +2098,10 @@ (define-public guile-imanifest
>          (build-system guile-build-system)
>          (native-inputs
>           (list guile-3.0))
>   +      (inputs
>   +       (list guix))
>          (propagated-inputs
>   -       (list guile-readline guile-colorized guix))
>   +       (list guile-readline guile-colorized))
>          (home-page "https://sr.ht/~brown121407/guile-imanifest")
>          (synopsis "Interactive Guix manifests")
>          (description "This package provides functions to generate Guix m=
anifests
>
> Using guile-imanifest breaks:
>
>   =E2=86=92 ./pre-inst-env guix environment --pure --ad-hoc guile guile-i=
manifest -- guile -c "(use-modules (imanifest))"
>   Backtrace:
>     ...
>
>   ice-9/boot-9.scm:3330:6: In procedure resolve-interface:
>   no code for module (guix profiles)
>
>
> I think some other approach is needed to avoid people having problems
> with the guix package appearing in their users profile.
>
> [[End of PGP Signed Part]]

That makes sense. Though, this lint is just a warning, so if nothing
else, it should make people think if guix really needs to be propagated.
If this lint is not the solution, then a way to mark packages that are
not recommended to be installed like this would be nice.

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#64861] [PATCH] guix: Add lint check for guix as propagated-input
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 20 Aug 2023 20:59:01 +0000
Resent-Message-ID: <handler.64861.B64861.169256510227170 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 64861
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Christopher Baines <mail@HIDDEN>
Cc: Karl Hallsby <karl@HIDDEN>, 64861 <at> debbugs.gnu.org
Received: via spool by 64861-submit <at> debbugs.gnu.org id=B64861.169256510227170
          (code B ref 64861); Sun, 20 Aug 2023 20:59:01 +0000
Received: (at 64861) by debbugs.gnu.org; 20 Aug 2023 20:58:22 +0000
Received: from localhost ([127.0.0.1]:54936 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qXpV8-00074A-84
	for submit <at> debbugs.gnu.org; Sun, 20 Aug 2023 16:58:22 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:39760)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1qXpV6-00073x-GR
 for 64861 <at> debbugs.gnu.org; Sun, 20 Aug 2023 16:58:21 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1qXpUz-0001qa-9C; Sun, 20 Aug 2023 16:58:13 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
 From; bh=+wktX6Zzw3ytO20Q3kNzbxWxzGuh9JD8Efkv6XAVcd8=; b=DvVj1Nd7BlILW45sBE6H
 /xuyAx5iEn7V/1DFplee1cSj8NvaBDfj9W7Pb+QY+P8fRN/J4DfTbu+VQuji6IxV30pJL3Tpdxm7H
 73MOgVfexFqHV9m2SFoXRwTah7GnksDtDH1eaQomPTYpUr+8+dC5ZYlaYR/vXmzcSjcbbQTM76CA/
 65Yrd4oRBzeiz12M075HiWQk4fZqaUh8q7YeSf+Vq7nO8B1EG+MNpGWGotYhicsQdSsmEoHjYa1V3
 6W9+xtRrwW1x0EnIZguxK0FunZc3hN7aVTM+iGaLMXBapn9r9a0bHLPR56mB8aJppeHusweKkl5iI
 AaeWVZs4gE9j2A==;
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
References: <388dc9bec6dabc97092eb2009fed304c3f84c6fc.1690308209.git.karl@HIDDEN>
 <87pm4f7skl.fsf@HIDDEN>
Date: Sun, 20 Aug 2023 22:58:10 +0200
In-Reply-To: <87pm4f7skl.fsf@HIDDEN> (Christopher Baines's message of
 "Tue, 25 Jul 2023 19:26:01 +0100")
Message-ID: <87fs4dqvml.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi,

Christopher Baines <mail@HIDDEN> skribis:

> Using guile-imanifest breaks:
>
>   =E2=86=92 ./pre-inst-env guix environment --pure --ad-hoc guile guile-i=
manifest -- guile -c "(use-modules (imanifest))"
>   Backtrace:
>     ...
>
>   ice-9/boot-9.scm:3330:6: In procedure resolve-interface:
>   no code for module (guix profiles)

Maybe =E2=80=98guile-imanifest=E2=80=99 should be made a Guix extension, wh=
ich Guix
searches for in $GUIX_EXTENSIONS_PATH?

An example of that is =E2=80=98guix-modules=E2=80=99.

Ludo=E2=80=99.

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#64861] [PATCH] guix: Add lint check for guix as propagated-input
Resent-From: Simon Tournier <zimon.toutoune@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 07 Sep 2023 15:20:02 +0000
Resent-Message-ID: <handler.64861.B64861.16940999528329 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 64861
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Christopher Baines <mail@HIDDEN>
Cc: Karl Hallsby <karl@HIDDEN>, 64861 <at> debbugs.gnu.org
Received: via spool by 64861-submit <at> debbugs.gnu.org id=B64861.16940999528329
          (code B ref 64861); Thu, 07 Sep 2023 15:20:02 +0000
Received: (at 64861) by debbugs.gnu.org; 7 Sep 2023 15:19:12 +0000
Received: from localhost ([127.0.0.1]:40977 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qeGml-0002AG-Ho
	for submit <at> debbugs.gnu.org; Thu, 07 Sep 2023 11:19:11 -0400
Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:40318)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zimon.toutoune@HIDDEN>) id 1qeGmb-00028t-MV
 for 64861 <at> debbugs.gnu.org; Thu, 07 Sep 2023 11:19:02 -0400
Received: by mail-wr1-x42c.google.com with SMTP id
 ffacd0b85a97d-31c3f574ef8so199197f8f.1
 for <64861 <at> debbugs.gnu.org>; Thu, 07 Sep 2023 08:18:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20221208; t=1694099934; x=1694704734; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:message-id:date:references
 :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id
 :reply-to; bh=mQrGfRJDEOaj0RZO7CNjwG/UMQGCG1S2vLErrEszL/A=;
 b=rLDuoNVq2w1q+uuCgRV1zbl0J7qf4PVarGo7qScroefeR/Uoe2505yEJDJXea1clhs
 HqvzZRc6a5RgfD2Wh0n/Te5TBsDEZqeNtcOnZRlkhOczBNKLqoXifBS0A4fX81sdeOPg
 4SAy43AMyHCWTbt/WMxP54W+daqQ4zka2qBP/mV/6YKhJ6aiY7LnlRh/4gvHPw2oUEfn
 YoFQTAoPjtswHS7SCkwESohWLbHjiRs+ooZdvL8dxRiqpgu1w4HkNLb7NpBG1OBze6h2
 ztHWD/29lZV2U/5UXgAnO8kHjDteNDWWj3z5oKD9bc54igYBaks+b2Sz2bvQgFdOPgQA
 wTOw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20221208; t=1694099934; x=1694704734;
 h=content-transfer-encoding:mime-version:message-id:date:references
 :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=mQrGfRJDEOaj0RZO7CNjwG/UMQGCG1S2vLErrEszL/A=;
 b=R42Hc5JHAFugcJPvkbQ7tiwhEqhniMw5IOnniAy2xKWYcGhYBKy3P5OKmc4F2RwpQK
 M6XJVPJhqfsrtbO4rqOBKHwq1O7I3cagqNd1fuz0EPecQFt97xNgyp1lmG3dAewLu9ME
 SpKF+1UAfZkxuqRlpsGanQ/r0us4rcpeuKKQjizpFZ+x0X331eVO1I5ragKo0+xU7gvZ
 N/GY7YD+tee9XSkUEzTlguIrrgtRYsV3kodUJODK5MyhUGjZ06f68ybw897d2d11F/Eh
 ve5lLQAO/Xu4nbaxmqbIPU+w8W8BZkYoNExBNilLeNpX/nJGGCLWLPqIJE+UrQ/YNoFu
 1M0g==
X-Gm-Message-State: AOJu0YzM7YPs24aOWl+6yU6KHZWEBuK2ss5ut3eoLZoDPL5u2jGT473b
 zygPy4lNmM6gJUGLRmUTv7ru1y5HcQo=
X-Google-Smtp-Source: AGHT+IHwJeeEyBdHPbJxMjDtK2tKgCuba1/LnKeqRX6NoYLfx6SCO3xXBq3DJZVi/4KsvrvdAoOyCQ==
X-Received: by 2002:adf:f291:0:b0:316:ef5f:7d8f with SMTP id
 k17-20020adff291000000b00316ef5f7d8fmr14578904wro.3.1694099934151; 
 Thu, 07 Sep 2023 08:18:54 -0700 (PDT)
Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id
 cc11-20020a5d5c0b000000b0031f34a395e7sm17301385wrb.45.2023.09.07.08.18.53
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 07 Sep 2023 08:18:53 -0700 (PDT)
From: Simon Tournier <zimon.toutoune@HIDDEN>
In-Reply-To: <87fs4dqvml.fsf_-_@HIDDEN>
References: <388dc9bec6dabc97092eb2009fed304c3f84c6fc.1690308209.git.karl@HIDDEN>
 <87pm4f7skl.fsf@HIDDEN> <87fs4dqvml.fsf_-_@HIDDEN>
Date: Thu, 07 Sep 2023 16:22:14 +0200
Message-ID: <87bkeekqqx.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi,

On Sun, 20 Aug 2023 at 22:58, Ludovic Court=C3=A8s <ludo@HIDDEN> wrote:

> Maybe =E2=80=98guile-imanifest=E2=80=99 should be made a Guix extension, =
which Guix
> searches for in $GUIX_EXTENSIONS_PATH?

And probably renamed =E2=80=99guix-imanifest=E2=80=99?

Back to the submission, I think that the propagation of the package guix
means something is wrong.  From my point of view, there is two cases:

 1. The package uses the stable library API and thus it makes sense to
    rely on the package =E2=80=99guix=E2=80=99.  That=E2=80=99s the case fo=
r =E2=80=99gwl=E2=80=99,
    =E2=80=99guix-data-service=E2=80=99 for example.

 2. The aim of package is to collaborate with the current Guix and thus
    there is no point to have the package =E2=80=99guix=E2=80=99 as inputs.=
  Instead,
    the package must rely on GUIX_EXTENSIONS_PATH.  That=E2=80=99s the case=
 for
    =E2=80=99guix-modules=E2=80=99 or =E2=80=99guile-imanifest=E2=80=99 (so=
 that needs a fix ;-))

Therefore, I think this new checker makes sense.  WDYT?


About #1, IMHO, this is expected:

--8<---------------cut here---------------start------------->8---
$ guix shell -C gwl -- guix --version
guix shell: error: guix: command not found

        (define-public gwl
            (inputs
        [...]
               (list guix
--8<---------------cut here---------------end--------------->8---

and this is not expected:

--8<---------------cut here---------------start------------->8---
$ guix shell -C guix-data-service -- guix --version
guix (GNU Guix) 1.4.0-10.4dfdd82
Copyright (C) 2023 the Guix authors
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.htm=
l>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

        (define-public guix-data-service
        [...]
              (propagated-inputs
               (list guix
--8<---------------cut here---------------end--------------->8---


Cheers,
simon

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#64861] [PATCH] guix: Add lint check for guix as propagated-input
Resent-From: "Karl G. Hallsby" <karl@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 11 Jan 2025 21:56:02 +0000
Resent-Message-ID: <handler.64861.B64861.173663251127512 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 64861
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 64861 <at> debbugs.gnu.org
Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Christopher Baines <mail@HIDDEN>, Karl Hallsby <karl@HIDDEN>, Simon Tournier <zimon.toutoune@HIDDEN>
Received: via spool by 64861-submit <at> debbugs.gnu.org id=B64861.173663251127512
          (code B ref 64861); Sat, 11 Jan 2025 21:56:02 +0000
Received: (at 64861) by debbugs.gnu.org; 11 Jan 2025 21:55:11 +0000
Received: from localhost ([127.0.0.1]:45191 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tWjRn-000790-H7
	for submit <at> debbugs.gnu.org; Sat, 11 Jan 2025 16:55:11 -0500
Received: from mail-io1-xd2f.google.com ([2607:f8b0:4864:20::d2f]:59810)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <karl@HIDDEN>) id 1tWjRl-00077v-6f
 for 64861 <at> debbugs.gnu.org; Sat, 11 Jan 2025 16:55:09 -0500
Received: by mail-io1-xd2f.google.com with SMTP id
 ca18e2360f4ac-84f1ea04c64so203143239f.3
 for <64861 <at> debbugs.gnu.org>; Sat, 11 Jan 2025 13:55:09 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=hallsby.com; s=google; t=1736632503; x=1737237303; darn=debbugs.gnu.org;
 h=mime-version:message-id:date:user-agent:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=o5pzWc6NwSmr54idXvJ+CuCYtecVRn/ajI3sRHWDgiM=;
 b=CrXq0huOGQYT+IrmQ3DfCv24PpMP71l3iK36lhsip/ufbOtVGtXhO52EFa/Dzdf9x3
 uCZSBmSghE9TJGMSD+iU0LtdRmwycia+vUqHkP6x/5oGcnK5S3hMk4yWhs1OjwgAKLUg
 evuTevRvm0gXFY1wuQXZC4Ec+94zo9h8f8sLWItsAVw6F7GSx2LCier92UVsc/061pXc
 prN2TCcyqgdzhWO30CDOFt2OpTdKQSl7xwks+BBwOZN3I/Id68ou7cOD4GzzSbOOBBI9
 egCNSExc0YOfD7usvGQ6RveM8Un/XLG29dtdUCx89s+lIl4ynatJbvuP4PZCRm0v3n/9
 TAkw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1736632503; x=1737237303;
 h=mime-version:message-id:date:user-agent:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=o5pzWc6NwSmr54idXvJ+CuCYtecVRn/ajI3sRHWDgiM=;
 b=sX8ii84lxbRyjVOd4rPfVHjYqWUp+lcW6T2QtJ/stpJYsYmoOqNoaxOLj29SdDwi4v
 f8BrTTz6NLsUJsXqkI++PHvK59eWMi4wd7j2+DUrRZyJlPQEXycU/kMoldK2OnV++J5A
 xTHQpfEH5QZtlkp7n+JQ4C06mpbgVSU+J2wGbrBh+LrYYYFGKeFBHYkFWGrK4jQbEdzS
 thAEbvDgYEdPSLfbgnje7bI9g7mTj6tX9hmva3g7KiBof6GRTZhu/VLa20E3eRp2yo3f
 nPjslPwmkEJe8FjveSqqW2RLJywCWIZnusjcawEsGzDTRm3vaChtzq+MCtlLhKfXLxRe
 x4Yw==
X-Gm-Message-State: AOJu0YztTy8jvpmk1YNTcdBCUgQIJbwmVPqkS9lRK9n6JQCLksaOSEZT
 fe9R7rj64uV0YXPv4tPDFXLVObFpx0QRJTjRQPF0I1ztFcmbCn34trqE49SmTJCqjD6COkaOXqW
 4NA==
X-Gm-Gg: ASbGncu+dFjN/WY1X7+1F1c/HK+k2MWjTAJU2nMTTeyK7HF6ygTC3/V+nI5d05Z1hyZ
 flGoXu5x3snCnPXFSC2jdbKyexKWk9zK9O5+WfJD1Puta58tRK8E9TfrDbxb3dmy1NhkvBc9QCt
 0WnONMidkmNjOXDO/7EZfu8/HybY+7cfDyTdJRd4YDmBwuzlRH9qh9cVqznX9J4u6LmTAkYhUeQ
 2NeeIyCneg6RLt5ry9eiURyi+N1j7qQiZErscCHswPcseIybg==
X-Google-Smtp-Source: AGHT+IH5/Qqi1qCU/f2bV8+W4Sz1veGDKWfCnMmAPG94uC+PskvMBG99bHkj7VKKl4D3gVVAbIq/Cg==
X-Received: by 2002:a05:6e02:1706:b0:3ce:6975:b668 with SMTP id
 e9e14a558f8ab-3ce6975b7fdmr13070925ab.6.1736632503060; 
 Sat, 11 Jan 2025 13:55:03 -0800 (PST)
Received: from localhost ([207.237.222.72]) by smtp.gmail.com with ESMTPSA id
 8926c6da1cb9f-4ea1b717d59sm1758415173.97.2025.01.11.13.55.00
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 11 Jan 2025 13:55:01 -0800 (PST)
From: "Karl G. Hallsby" <karl@HIDDEN>
In-Reply-To: <87bkeekqqx.fsf@HIDDEN> (Simon Tournier's message of "Thu, 07
 Sep 2023 16:22:14 +0200")
References: <388dc9bec6dabc97092eb2009fed304c3f84c6fc.1690308209.git.karl@HIDDEN>
 <87pm4f7skl.fsf@HIDDEN> <87fs4dqvml.fsf_-_@HIDDEN>
 <87bkeekqqx.fsf@HIDDEN>
User-Agent: mu4e 1.12.7; emacs 29.4
Date: Sat, 11 Jan 2025 15:54:59 -0600
Message-ID: <875xmlnhho.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi all,

What is the state of this patch's proposal? Is this warning check for
guix in propagated-inputs something we still want to warn about?


I know we have not talked about it in a while. I am going through all of
my contributions to Guix & Guix-based projects and
closing/merging/resolving them.

--
Raven Hallsby

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.