Received: (at 65788) by debbugs.gnu.org; 19 Dec 2023 14:43:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Dec 19 09:43:03 2023
Received: from localhost ([127.0.0.1]:35152 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rFbJE-0002D8-6l
for submit <at> debbugs.gnu.org; Tue, 19 Dec 2023 09:43:03 -0500
Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:40298)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <zimon.toutoune@HIDDEN>) id 1rFbJ9-0002CW-4f
for 65788 <at> debbugs.gnu.org; Tue, 19 Dec 2023 09:42:55 -0500
Received: by mail-wm1-x335.google.com with SMTP id
5b1f17b1804b1-40c2655da63so11651845e9.1
for <65788 <at> debbugs.gnu.org>; Tue, 19 Dec 2023 06:42:52 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1702996967; x=1703601767; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:message-id:date:references
:in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id
:reply-to; bh=NF8FPIfSVi02+SLpcETjP3Xo9oPD0Zcj+7NykSbMI4U=;
b=AWsaQ80dJqmK1RgpsjVJLpeU986w5cWKplTR29TKOz+JSbyjIRRJKIMVSw6pdS8fSi
VtzVZqJ9pYiUF5sLX8G+hBDvUiY0NySqmNibRmTYthSZ8T0AdeKF4IQw9NNRuz+U1ZP9
IiGf0Vr4bmYgxbb8UHIYwHxl2f0H1I7rTsCZ4Z48MLw6JMiZs76v64cgOFRMOqaNLsi3
pPhQSz8sFpuBUW7zw9NDo6YA0zIXIiVMnAQn81oUM/IRMKV2pxC1brf9Kiwc/VGP8Azp
qeMGhbnJzW3rZsQTBY/MP+hkpBogNPEnlvw5QKkBpw3W75XLvvLfzbsJOnOUMHdyHI2I
fzUg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1702996967; x=1703601767;
h=content-transfer-encoding:mime-version:message-id:date:references
:in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=NF8FPIfSVi02+SLpcETjP3Xo9oPD0Zcj+7NykSbMI4U=;
b=jEqfA/eBL0tOhT3nyWzoChSYHrz/nQKH20pDT4Qjj9TJMB5QbegoNaRWoV0XZroNGu
q5BqaEs9LqCn7H/v5IY52llQC4kr3OdR7MNKQLF65TWC/YhWosXjXLBFz6fjhG9kmD5Y
turlkRgsHoGMN9izyS1didblh3X9iUGCVBd+9LgGTbPG2g/RRUEhy8VviaDPxd83uZ8h
1rk95QLbmM/nlSq1A59cbepee57udIV2vjVKkG+tFPpY36S1App+jWmx6uQjaQrwWJhX
v7DJhMdT5tleVB2oeLae+rsKEsc8c8BRnLWHcYsoLqncq7X8R4qiauqsB7dM/khO9p3m
VmcQ==
X-Gm-Message-State: AOJu0Ywl2tCM7zLFIeLvDDy/z6KApri7Nn9BBIcWdVpGbkUda3mP1beb
uoiH+C0ufAfD7c2whfP1m+E=
X-Google-Smtp-Source: AGHT+IFdgZ0NHA2ns3i923UMG3z9foog3OwYEohuvxoQIJMJ1tmq6EEeU4dyQN0bk6IXbaKrmm8Bcw==
X-Received: by 2002:a05:600c:3b23:b0:40c:6e2a:35ec with SMTP id
m35-20020a05600c3b2300b0040c6e2a35ecmr8444020wms.0.1702996966585;
Tue, 19 Dec 2023 06:42:46 -0800 (PST)
Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id
o21-20020a05600c4fd500b0040c5cf930e6sm3102238wmq.19.2023.12.19.06.42.46
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 19 Dec 2023 06:42:46 -0800 (PST)
From: Simon Tournier <zimon.toutoune@HIDDEN>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Subject: Re: bug#65788: poor information when updating using
=?utf-8?Q?=E2=80=9Cguix_time-machine=E2=80=9D?=
In-Reply-To: <875y2q96hz.fsf@HIDDEN>
References: <87pm2vme7x.fsf@HIDDEN> <875y2q96hz.fsf@HIDDEN>
Date: Tue, 19 Dec 2023 15:36:51 +0100
Message-ID: <87h6ke45to.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 65788
Cc: 65788 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hi Ludo,
On Sat, 28 Oct 2023 at 16:16, Ludovic Court=C3=A8s <ludo@HIDDEN> wrote:
>> Why not move this =E2=80=99validate-guix-channel=E2=80=99 to internals. =
Somehow, it is
>> in guix/scripts/ because it captures =E2=80=99ref=E2=80=99. However, th=
is capture is
>> redundant and is normally managed by =E2=80=99channel-list=E2=80=99. Th=
erefore, I would
>> be tempted to have this validation for the reachable commit close to the
>> =E2=80=9CUpdating=E2=80=9D message.
>
> Yes, that=E2=80=99s a good idea.
>
> As I started looking into it, I realized we could reuse the existing
> #:validate-pull mechanism of =E2=80=98latest-channel-instances=E2=80=99 f=
or the purposes
> of this commit check in =E2=80=98time-machine=E2=80=99.
[...]
> Here=E2=80=99s my proposal to do that:
>
> https://issues.guix.gnu.org/66793
This improvement does not address this issue with
%oldest-possible-commit, right?
In addition, we also need to consider =E2=80=99inferior-for-channels=E2=80=
=99 which
calls =E2=80=99cached-channel-instance=E2=80=99 =E2=80=93 currently with th=
e default (const #t)
for #:validate-channels.
For an instance of bug with inferiors, please look at:
Dependence on an old version of a package.
Philippe Veber <philippe.veber@HIDDEN>
Sun, 10 Dec 2023 09:18:50 +0100
id:CAOOOohRJu0QH+czx3qAwNxCY0X9JBd4NdUd9vjBvt-kDFCHkmA@HIDDEN=
om
https://lists.gnu.org/archive/html/help-guix/2023-12
https://yhetil.org/guix/CAOOOohRJu0QH+czx3qAwNxCY0X9JBd4NdUd9vjBvt-=
kDFCHkmA@HIDDEN
Cheers,
simon
bug-guix@HIDDEN:bug#65788; Package guix.
Full text available.
Received: (at 65788) by debbugs.gnu.org; 31 Oct 2023 14:56:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Oct 31 10:56:42 2023
Received: from localhost ([127.0.0.1]:48967 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qxqAa-0006ot-VA
for submit <at> debbugs.gnu.org; Tue, 31 Oct 2023 10:56:42 -0400
Received: from mail-oi1-x22b.google.com ([2607:f8b0:4864:20::22b]:49560)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maxim.cournoyer@HIDDEN>) id 1qxqAV-0006oc-RA
for 65788 <at> debbugs.gnu.org; Tue, 31 Oct 2023 10:56:39 -0400
Received: by mail-oi1-x22b.google.com with SMTP id
5614622812f47-3b2f4a5ccebso3731252b6e.3
for <65788 <at> debbugs.gnu.org>; Tue, 31 Oct 2023 07:56:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1698764156; x=1699368956; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=M8Pl1FWa1OCbsrujL5YxhQzfCNgs+uC92Ygk/VV9I+U=;
b=Hb0vSIqBBff8yOMPyjE64tfL8M9uOBA6584TpnMxm4lU2rW16GW3G4D1J470FaqOdR
bDHpMrzZyUkKXgZym35HioUj0Lpt14TUxMrABmgUEN1+IlKAafHjYFSmIsOfcCwfjJiM
QmqYVnMVMLWnHr2EoqrCK9TJff+2A9rrci5k8k/1KfCOPqfYi9VZ6gwM23iSPzMbypFx
zl+QhJNX8wgcyBpjGKemudkWVq4pIJpvX60XBQMUaw7cNErm18L5hpUYdmfJETTxnFCz
H3OjRnE4GBiBN//7PTWILa1epv5GFqu1zu/4yI86pRCnK+DWdmYG5aa8e2ZHBgIDQTPU
vHmw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1698764156; x=1699368956;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
:to:cc:subject:date:message-id:reply-to;
bh=M8Pl1FWa1OCbsrujL5YxhQzfCNgs+uC92Ygk/VV9I+U=;
b=Gvu9iQSRyybQzfM4dV8+KhP0DA0EpUtJ+KFV1vqR/ePv6onHkYjQzy4GWzEs+pWc7I
Faw4G86Hy/xbjt9GVhWoh7/RUDEVyWjQaCFcKrJLPBnxELIv5DuR45qIz3enZe+Qcw5x
zWCW7CQWYZLf5eRMfJAWeW7YWQ9hpZfMCiVEXrCrSVa/gpM4zc+sgw5icDnc2HvMVY92
sEttHiyIfXtNTFCuqvXhKgkt3jJ7c0b4L5jzuLdX1RdtPzfSu/hS/zF8OwOh02oVsq6g
cSYZrELEvaHqniCFRUs4LlxF7wcJNH59qA0kA+gQo8alEzvIk/UoEArL+EO4JBI8UK8P
gh7A==
X-Gm-Message-State: AOJu0YyrRuuwZrgtjHapgmjihh9Ih2nwsRVrLx60zrFxS7fvu3iitgG5
rm5bHMNOlgJ0ztAOalmM2gA5bc3IoV4=
X-Google-Smtp-Source: AGHT+IHpBuCZdFB+BZWmsc+zblwyAJI3pRE+t4PYeJxTnaxjqPXKLllIE3C7PkDz8TIWuYlmbVcnjA==
X-Received: by 2002:a05:6808:191c:b0:3ad:f6a2:cfe2 with SMTP id
bf28-20020a056808191c00b003adf6a2cfe2mr15249403oib.22.1698764156131;
Tue, 31 Oct 2023 07:55:56 -0700 (PDT)
Received: from hurd (dsl-10-128-239.b2b2c.ca. [72.10.128.239])
by smtp.gmail.com with ESMTPSA id
p21-20020a05620a113500b0076f19b9e96fsm562499qkk.107.2023.10.31.07.55.55
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 31 Oct 2023 07:55:55 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Subject: Re: bug#65788: poor information when updating using
=?utf-8?Q?=E2=80=9Cguix_time-machine=E2=80=9D?=
In-Reply-To: <875y2q96hz.fsf@HIDDEN> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?=
=?utf-8?Q?s?= message of "Sat, 28 Oct 2023 16:16:56 +0200")
References: <87pm2vme7x.fsf@HIDDEN> <875y2q96hz.fsf@HIDDEN>
Date: Tue, 31 Oct 2023 10:55:54 -0400
Message-ID: <87bkcesux1.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 65788
Cc: 65788 <at> debbugs.gnu.org, Simon Tournier <zimon.toutoune@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hi,
Ludovic Court=C3=A8s <ludo@HIDDEN> writes:
[...]
> PS: We should define rules for =E2=80=9CReviewed-by=E2=80=9D tags because=
I don=E2=80=99t think
> I LGTM=E2=80=99d commit 79ec651a286c71a3d4c72be33a1f80e76a560031 (?).
It was a friendly credit added based on substantial comments I received
and acted upon from your review,
e.g. https://issues.guix.gnu.org/64746#7.
I don't mind if we codify to add these only when the reviewer added
their 'LGTM' approval stamp; there's an ongoing change adding some
guidelines for reviews in bug#66436, we should add this bit in.
--=20
Thanks,
Maxim
bug-guix@HIDDEN:bug#65788; Package guix.
Full text available.
Received: (at 65788) by debbugs.gnu.org; 28 Oct 2023 14:17:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 28 10:17:39 2023
Received: from localhost ([127.0.0.1]:39323 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qwk8B-0001st-5d
for submit <at> debbugs.gnu.org; Sat, 28 Oct 2023 10:17:39 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:60576)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ludo@HIDDEN>) id 1qwk88-0001sf-RN
for 65788 <at> debbugs.gnu.org; Sat, 28 Oct 2023 10:17:38 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
id 1qwk7X-0001dw-Df; Sat, 28 Oct 2023 10:16:59 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
From; bh=ra4B4uVkCaaJGDlvYmItNkmtV4aJ+KOvVvgRx/ql//w=; b=hB8DcwVdjQXCyW6Ob3c7
ETjuzTVCSx+7OO+6S9EMh2gHyNUj2kygADE2FFgaizgnA9R71MzMgOhfsiTXCOb9lIFFZaPm9Vel+
0P3ws1Bxl5o4dLy65bVh1lERq075sw3vXq2Rqa9HtX+qLRNDXjbSXfs5zlszxyr2oL8qC0VY9Z6Bw
1XZ/9Bq4RHWEAZ9NlVVvD9FrnR90YghAKdMvB2v4q1mN+e6tZdHUMWfls1I7Dw1/GEa7pJbKitaLd
vxpKD24gSyDC/I5tAEaOH5pM+vGqmVylpaBN2XSYgv/c4UbR/cUuKEHMM/cDyQX0Le3aM7Nw0Lx6y
tlRTC46hP9uYLg==;
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Simon Tournier <zimon.toutoune@HIDDEN>
Subject: Re: bug#65788: poor information when updating using
=?utf-8?Q?=E2=80=9Cguix_time-machine=E2=80=9D?=
In-Reply-To: <87pm2vme7x.fsf@HIDDEN> (Simon Tournier's message of "Wed, 06
Sep 2023 18:57:38 +0200")
References: <87pm2vme7x.fsf@HIDDEN>
Date: Sat, 28 Oct 2023 16:16:56 +0200
Message-ID: <875y2q96hz.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 65788
Cc: 65788 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Hi,
(Cc: Maxim.)
Simon Tournier <zimon.toutoune@HIDDEN> skribis:
> $ guix time-machine -q --commit=3D6113e05 -- describe
> receiving objects 2% =E2=96=95=E2=96=88=E2=96=8B
> =E2=80=A6some time flies=E2=80=A6
> indexing objects 21% =E2=96=95=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=
=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=
=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=
=96=88=E2=96=88 =
=E2=96=8F
> =E2=80=A6some time flies=E2=80=A6
> Updating channel 'guix' from Git repository at 'https://git.savannah.gnu.=
org/git/guix.git'...
> =E2=80=A6instant=E2=80=A6
> Computing Guix derivation for 'x86_64-linux'... \
To be clear, the problem you see is that =E2=80=9CUpdating channel=E2=80=9D=
is printed
too late, after =E2=80=9Creceiving objects=E2=80=9D etc., right?
> Why not move this =E2=80=99validate-guix-channel=E2=80=99 to internals. =
Somehow, it is
> in guix/scripts/ because it captures =E2=80=99ref=E2=80=99. However, thi=
s capture is
> redundant and is normally managed by =E2=80=99channel-list=E2=80=99. The=
refore, I would
> be tempted to have this validation for the reachable commit close to the
> =E2=80=9CUpdating=E2=80=9D message.
Yes, that=E2=80=99s a good idea.
As I started looking into it, I realized we could reuse the existing
#:validate-pull mechanism of =E2=80=98latest-channel-instances=E2=80=99 for=
the purposes
of this commit check in =E2=80=98time-machine=E2=80=99.
The main advantage is that this would address a performance issue with
the implementation of =E2=80=98validate-guix-channel=E2=80=99 in commit
79ec651a286c71a3d4c72be33a1f80e76a560031, namely the fact that it opens
and traverses the repository one extra time for this check. (The
#:validate-pull mechanism is integrated with =E2=80=98latest-channel-instan=
ces=E2=80=99
precisely to avoid this cost.)
Here=E2=80=99s my proposal to do that:
https://issues.guix.gnu.org/66793
Ludo=E2=80=99.
PS: We should define rules for =E2=80=9CReviewed-by=E2=80=9D tags because I=
don=E2=80=99t think
I LGTM=E2=80=99d commit 79ec651a286c71a3d4c72be33a1f80e76a560031 (?).
bug-guix@HIDDEN:bug#65788; Package guix.
Full text available.
Received: (at submit) by debbugs.gnu.org; 6 Sep 2023 16:57:59 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Sep 06 12:57:59 2023
Received: from localhost ([127.0.0.1]:37325 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qdvqp-0007Pk-00
for submit <at> debbugs.gnu.org; Wed, 06 Sep 2023 12:57:59 -0400
Received: from lists.gnu.org ([2001:470:142::17]:46298)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <zimon.toutoune@HIDDEN>) id 1qdvqn-0007PU-66
for submit <at> debbugs.gnu.org; Wed, 06 Sep 2023 12:57:57 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <zimon.toutoune@HIDDEN>)
id 1qdvqd-00067T-9Z
for bug-guix@HIDDEN; Wed, 06 Sep 2023 12:57:48 -0400
Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <zimon.toutoune@HIDDEN>)
id 1qdvqa-00083r-DF
for bug-guix@HIDDEN; Wed, 06 Sep 2023 12:57:47 -0400
Received: by mail-wm1-x333.google.com with SMTP id
5b1f17b1804b1-3fe4f3b5f25so233035e9.0
for <bug-guix@HIDDEN>; Wed, 06 Sep 2023 09:57:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20221208; t=1694019461; x=1694624261; darn=gnu.org;
h=content-transfer-encoding:mime-version:message-id:date:subject:to
:from:from:to:cc:subject:date:message-id:reply-to;
bh=IqDFn2ZTeGIfHUc3gd7ZBXtQrgpEGdHr9960R9IHNsE=;
b=ksPkeoq14PIkLDMGwHhpSCZireOagxJNi3+BOyjomUE3nbQhHGweymwvbN+BQijIBx
HpRgtI5QHUhufc6uIiMDP/h4dYukSs1DeTnCc0BVkO4pCEDi12YYBMHLGQjKip8gOdxO
lfeLSI/90dBJ4wgNarRgn6WPDapLKySgNxhzXecpSrVl8hl9LHuUfQ6cZ4xo6Dr6wNaO
HMGMWUJ43iG4KwuB1qNrvWslky3ZKIh13oVZX/+eA+DnkF9av/GmQGOw/8dnW+MR2lT5
r18uN5lLc49lUahVUg6wQeYEiBbrVL6nDXGKkVnhFdIG/2qCgXhzVqXYD1T51wX7sgd3
SRJA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20221208; t=1694019461; x=1694624261;
h=content-transfer-encoding:mime-version:message-id:date:subject:to
:from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=IqDFn2ZTeGIfHUc3gd7ZBXtQrgpEGdHr9960R9IHNsE=;
b=T765ZX94cVDNlUtNxEBOcTyFVZLOHpvUUS874bkWI3hFGlYNsNZhpDLKw0k5YtnWuA
HgOC12gRM7mXP+UY9t+AECXyO5lQRUrPc6NewHyWkLDwoRg7a7sIaH+Svwuqw2S2dvAu
oiBm5ouW7yBSSuo3GPmCXrNJ+p8TQkp2WHZwJadjHCQv65aZ8RSRQYt0wBcd+hHlD9yl
cJIgwaTemzfMItX/KfgXxTKovEJuTKFkaGgWvaqt3HVZN+oxpeotBpkl+vhlrfJ2Ht4B
n9TkRMqiRkqzM8tOP/fIhU55FkqrVXS2VD4PPjZMMlIrDDPJ6hnDWXNuqkr/YGb94PcO
TAuQ==
X-Gm-Message-State: AOJu0YzAJE8TumnquHW0g9QvJvnlvEuzpIbsbWKdujCSKbnhjCvfjIn3
DbXVphJOwkPkk2lHmsPHhlgUH3k8KXc=
X-Google-Smtp-Source: AGHT+IEu+W+3bdYOSbhI3VgUmiDnTnPVy8tCQKQfEEoxJKxCQPZew+1AXe6HvkbGjq9ZcFNkk7OG6Q==
X-Received: by 2002:a05:600c:3ac8:b0:401:bb6e:453a with SMTP id
d8-20020a05600c3ac800b00401bb6e453amr13316878wms.0.1694019461420;
Wed, 06 Sep 2023 09:57:41 -0700 (PDT)
Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id
n17-20020a1c7211000000b003feef5b0bb7sm44886wmc.40.2023.09.06.09.57.40
for <bug-guix@HIDDEN>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 06 Sep 2023 09:57:41 -0700 (PDT)
From: Simon Tournier <zimon.toutoune@HIDDEN>
To: bug-guix@HIDDEN
Subject: poor information when updating using =?utf-8?Q?=E2=80=9Cguix_time?=
=?utf-8?Q?-machine=E2=80=9D?=
Date: Wed, 06 Sep 2023 18:57:38 +0200
Message-ID: <87pm2vme7x.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=2a00:1450:4864:20::333;
envelope-from=zimon.toutoune@HIDDEN; helo=mail-wm1-x333.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
Hi,
Tangential of bug#65787 [1], the annoyance is the order of the updates.
It leads to poor messages. Let exemplify at the extreme case.
--8<---------------cut here---------------start------------->8---
$ guix describe
Generation 28 sept. 06 2023 14:54:50 (current)
guix 6113e05
repository URL: https://git.savannah.gnu.org/git/guix.git
commit: 6113e0529d61df7425f64e30a6bf77f7cfdfe5a5
$ rm -fr ~/.cache/guix/checkouts/pjmkglp4t7znuugeurpurzikxq3tnlaywmisyr27sh=
j7apsnalwq
$ guix time-machine -q --commit=3D6113e05 -- describe
receiving objects 2% =E2=96=95=E2=96=88=E2=96=8B
=E2=80=A6some time flies=E2=80=A6
indexing objects 21% =E2=96=95=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=
=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=
=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=
=96=88=E2=96=88 =
=E2=96=8F
=E2=80=A6some time flies=E2=80=A6
Updating channel 'guix' from Git repository at 'https://git.savannah.gnu.or=
g/git/guix.git'...
=E2=80=A6instant=E2=80=A6
Computing Guix derivation for 'x86_64-linux'... \
--8<---------------cut here---------------end--------------->8---
The reason is because the logic:
(when (procedure? validate-channels)
(validate-channels channels))
(run-with-store store
(mlet* %store-monad ((instances
-> (latest-channel-instances store channels
#:authenticate?
authenticate?))
where =E2=80=99validate-channels=E2=80=99 (validate-guix-channel) reads,
(checkout commit relation (update-cached-checkout
(channel-url guix-channel)
#:ref reference
#:starting-commit
%oldest-possible-commit)))
and =E2=80=99latest-channel-instances=E2=80=99 which is the ones that displ=
ays,
(format (current-error-port)
(G_ "Updating channel '~a' from Git repository=
at '~a'...~%")
(channel-name channel)
(channel-url channel))
this =E2=80=99latest-channel-instances=E2=80=99 reads under the hood,
((checkout commit relation)
(update-cached-checkout (channel-url channel)
#:ref (channel-reference channel)
#:starting-commit starting-commit)))
Why not move this =E2=80=99validate-guix-channel=E2=80=99 to internals. So=
mehow, it is
in guix/scripts/ because it captures =E2=80=99ref=E2=80=99. However, this =
capture is
redundant and is normally managed by =E2=80=99channel-list=E2=80=99. There=
fore, I would
be tempted to have this validation for the reachable commit close to the
=E2=80=9CUpdating=E2=80=9D message.
WDYT?
Cheers,
simon
1: <https://issues.guix.gnu.org/issue/65787>
Simon Tournier <zimon.toutoune@HIDDEN>:bug-guix@HIDDEN.
Full text available.bug-guix@HIDDEN:bug#65788; Package guix.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.