Received: (at 66193) by debbugs.gnu.org; 1 Jan 2025 10:31:23 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 01 05:31:23 2025 Received: from localhost ([127.0.0.1]:37819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tSw0Z-0005z0-AL for submit <at> debbugs.gnu.org; Wed, 01 Jan 2025 05:31:23 -0500 Received: from mail-pj1-x1044.google.com ([2607:f8b0:4864:20::1044]:54743) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <45mg.writes@HIDDEN>) id 1tSw0X-0005yn-NF for 66193 <at> debbugs.gnu.org; Wed, 01 Jan 2025 05:31:22 -0500 Received: by mail-pj1-x1044.google.com with SMTP id 98e67ed59e1d1-2f441904a42so14711833a91.1 for <66193 <at> debbugs.gnu.org>; Wed, 01 Jan 2025 02:31:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735727475; x=1736332275; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=ZZsxS2AilrDAYpb6hWcYAl+TN2GtqTYWva0LIjdYitk=; b=C+rWeuD1Zn3tDb/hcIWvOgKqT7fCG5ClNBzopz0fgJsyM5MiX9bfdt7dSsfp/B+FEr ewWXspdfgOXtHJic0Er1Jb00CXgbEMMENuVOmf8wUnkJm4/3uvsJAaN0W97tf4CI+Ane Klqxmp9ETH1s1NEqFZThXMtq0eW+yFrexA0fL40kDQncCGCKNAUE5fWTYTqik1eWdwx/ KqiiLyoqXPHWuM6WiUi9QC4h8UIqrrqNJN6nddaaKLoKBTlh+BMd8xLYBSV3CFTyHQoI 8pHMpLIaptTksj2x/C6bBHhNEZJ3q1gZbFpxKXh46/JgGCs6BqJH4t/XT4waLq0tiqO8 dfNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735727475; x=1736332275; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZZsxS2AilrDAYpb6hWcYAl+TN2GtqTYWva0LIjdYitk=; b=IH8CERR6DMmwwqcrH2vKMzhPndDl49a7Hex2NhIPBM8q63hmtHZZKAdiLPku7VuTcw 2+6BaSOWUMqLfTNwCKc7PYDO2WXCMKv4j+XbqURg/3dRRch4KTZaZGnlJAc7rd6m5uFt Xzao3egfyRHp1SXr00zWM9jxKVINGhhy9JIESA+z8D84th8BhiqItCQLVep6Z8pJ6dZ2 4XPYPmIWLAXBxo7oKshUbjFHvtm5R2V/zfE+VRDzOEPJpLYoosITQcaQ6mSgq+0x6FYb vwT/tVClw/iVfQ7sOr78aYL7SPkwa/Cbi94NLjm/Is4gsn2YCAwXGz/BUDJ5YDo2oG1i TgZQ== X-Forwarded-Encrypted: i=1; AJvYcCU8drXeJxopOOglF4Te2awVsR/8unVes054XxJ4FA0RAp32dbMEeANARLq367uFilgh005ubw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwT+28eIuyhxLUYH9bebxo1+QEghdzAr8AvMHMAIgncl44fi2KA 0XbaVdVcE9lr4hzq1QlPBGrwvpyoqAt1RkNpUhLui02Rf7MH1YNQ X-Gm-Gg: ASbGncvqTpz1oVy8FRiObmBxGatBBFLEZPU8HzeSyQqObUu6XUiYiWDM6cx4yYmTNjt 0sGWrThBhXfGXruGl94BhPYoR0zGsdzF+tRFN1pCz0Bs9V/8N9FKkecKuBeHW3r6EROhd1Ax6VL LjtgTRdgwB+F9FjlkeySZcigBrux1auQ19KrVzYdZmmyrIvRA9hudyEhlggAC/HRLoQmj+r/K+q 2LdQ9MmTacV0p7ha7tR5xkf3C9H2C6hUCzNIcLJBwCGKVZAIPZp5qUs5wAPsbL0Bb/1uxdWEQVT X-Google-Smtp-Source: AGHT+IFj3Q3xio5ecuilzcd2IMeTZEijT6/MbE7GH4+uuGz9sJPtW0E2k09uLhRhvNRFnb55ZLnr9Q== X-Received: by 2002:a17:90a:c88b:b0:2f2:a9f0:40b0 with SMTP id 98e67ed59e1d1-2f452eb3dd9mr54308220a91.23.1735727475368; Wed, 01 Jan 2025 02:31:15 -0800 (PST) Received: from localhost.localdomain ([2401:4900:1cb8:a2d3:f4aa:1246:d469:678a]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f2ee06dd84sm28674055a91.38.2025.01.01.02.31.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jan 2025 02:31:15 -0800 (PST) From: 45mg <45mg.writes@HIDDEN> To: "ShinyZero0" <shinyzero0@HIDDEN>, 66193 <at> debbugs.gnu.org Subject: [PATCH v3] gnu: Add keyd Date: Wed, 1 Jan 2025 05:24:53 -0500 Message-ID: <0dda1be22511fb183c24bf16691df5963124cb2c.1735727093.git.45mg.writes@HIDDEN> X-Mailer: git-send-email 2.47.1 In-Reply-To: <CVSWXT9ZHO24.3LDYDRIMBKSS7@fedora> References: <CVSWXT9ZHO24.3LDYDRIMBKSS7@fedora> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66193 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) From: ShinyZero0 <shinyzero0@HIDDEN> From 4926a18454135e97832e2d183893f01a2f42a06c Mon Sep 17 00:00:00 2001 From: "zero@fedora" <shinyzero0@HIDDEN> Date: Mon, 25 Sep 2023 19:39:00 +0300 Subject: [PATCH] gnu: Add keyd * gnu/packages/keyd.scm: New file. * gnu/local.mk: Add it. Change-Id: I9a796d5970d910b933999a146c99060413dc13e1 --- This revision fixes a small typo in gnu/local.mk (services/keyd.scm -> packages/keyd.scm). Other than that, I've tested this in a VM and it works fine. While we're still skipping the tests since they require root to run, that's a common approach that isn't at all unique to this package [1]. So, I guess this can be merged, or at least reviewed further. The patch I'm replying to should have been titled 'v2'; this is v3. [1] https://lists.gnu.org/archive/html/guix-devel/2025-01/msg00001.html gnu/local.mk | 1 + gnu/packages/keyd.scm | 60 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 61 insertions(+) create mode 100644 gnu/packages/keyd.scm diff --git a/gnu/local.mk b/gnu/local.mk index 02a6fa616e..45862dfa47 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -412,6 +412,7 @@ GNU_SYSTEM_MODULES = \ %D%/packages/kde-systemtools.scm \ %D%/packages/kde-utils.scm \ %D%/packages/kerberos.scm \ + %D%/packages/keyd.scm \ %D%/packages/kodi.scm \ %D%/packages/language.scm \ %D%/packages/lean.scm \ diff --git a/gnu/packages/keyd.scm b/gnu/packages/keyd.scm new file mode 100644 index 0000000000..666b931650 --- /dev/null +++ b/gnu/packages/keyd.scm @@ -0,0 +1,60 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright © 2023 Paul <shinyzero0@HIDDEN> +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>. + +(define-module (gnu packages keyd) + #:use-module (gnu packages linux) + #:use-module (guix packages) + #:use-module (guix gexp) + #:use-module (guix utils) + #:use-module (guix git-download) + #:use-module ((guix licenses) #:prefix license:) + #:use-module (guix build-system gnu)) + +(define-public keyd + (package + (name "keyd") + (version "2.4.3") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/rvaiya/keyd") + (commit (string-append "v" version)))) + (sha256 + (base32 + "1awdp863amq95y990fi4wj389ssv3ip2daqz2ph23lsahwa6f5in")))) + (arguments + (list #:tests? #f ; tests require root + #:make-flags + #~(list (string-append "CC=" #$(cc-for-target)) + "PREFIX=" + (string-append "DESTDIR=" #$output)) + #:phases + '(modify-phases + %standard-phases + (delete 'configure)))) ; no autoconf + (build-system gnu-build-system) + (inputs (list linux-libre-headers)) + (synopsis "A key remapping daemon for linux.") + (description + "Keyd is a keyboard remapping utility with intuitive ini + config file format. Keyd has several features, many of + which are traditionally only found in custom keyboard firmware + like QMK") + (home-page "https://github.com/rvaiya/keyd") + (license license:expat))) base-commit: c943829ac7b25ac6326f78fe947a5d79c283627b -- 2.47.1
guix-patches@HIDDEN:bug#66193; Package guix-patches.
Full text available.Christopher Baines <mail@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 66193) by debbugs.gnu.org; 26 Sep 2023 14:24:41 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 26 10:24:41 2023 Received: from localhost ([127.0.0.1]:49551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ql8zR-0006Tp-A0 for submit <at> debbugs.gnu.org; Tue, 26 Sep 2023 10:24:41 -0400 Received: from tilde.club ([142.44.150.184]:41328 ident=postfix) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <shinyzero0@HIDDEN>) id 1ql8zP-0006Th-DU for 66193 <at> debbugs.gnu.org; Tue, 26 Sep 2023 10:24:39 -0400 Received: from localhost (unknown [91.236.30.101]) by tilde.club (Postfix) with ESMTPSA id A75FD22414CC0; Tue, 26 Sep 2023 14:24:25 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 tilde.club A75FD22414CC0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tilde.club; s=mail; t=1695738266; bh=fBNHdvi9vea9u8yf5G+egvXvxAP68xpH19+Vy5sWQMw=; h=Date:Cc:Subject:From:To:References:In-Reply-To:From; b=xDHdrYkDOfz4njT3rJG5sngy1YdSfOl2fnD3pQf0a6NNb76DF+A5dHkV2ypq2iZ9e 2deLFSTRzCGLrtWtJK+9o9+wHmmUPCyGCl9xhybfxO/0R+/pDzc16qybghC4RtKdW+ NBkWGbCjHVlokFuNuGTtpyp5aJD6TNhxKK6XSBeI= Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 26 Sep 2023 17:24:22 +0300 Message-Id: <CVSX1NHJR90G.2WWSC8W6GMH9Z@fedora> Subject: Re: [bug#66193] [PATCH] gnu: Add keyd. From: "ShinyZero0" <shinyzero0@HIDDEN> To: "Jack Hill" <jackhill@HIDDEN> X-Mailer: aerc 0.15.2 References: <CVS5DY5C7BGC.NFGIXCDSS1WR@fedora> <alpine.DEB.2.21.2309251433170.16303@HIDDEN> In-Reply-To: <alpine.DEB.2.21.2309251433170.16303@HIDDEN> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 66193 Cc: 66193 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Thanks for your review! I don't know how should i handle the tests requiring user to be root. I tried simply removing `sudo` calls but that didn't work, so tests are still disabled for now.
guix-patches@HIDDEN:bug#66193; Package guix-patches.
Full text available.Received: (at 66193) by debbugs.gnu.org; 26 Sep 2023 14:22:15 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 26 10:22:15 2023 Received: from localhost ([127.0.0.1]:49547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ql8x4-0006Po-Kl for submit <at> debbugs.gnu.org; Tue, 26 Sep 2023 10:22:15 -0400 Received: from tilde.club ([142.44.150.184]:37814 ident=postfix) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <shinyzero0@HIDDEN>) id 1ql8x1-0006Pa-Dh for 66193 <at> debbugs.gnu.org; Tue, 26 Sep 2023 10:22:14 -0400 Received: from localhost (unknown [91.236.30.101]) by tilde.club (Postfix) with ESMTPSA id 63C1322414CC0 for <66193 <at> debbugs.gnu.org>; Tue, 26 Sep 2023 14:21:56 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 tilde.club 63C1322414CC0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tilde.club; s=mail; t=1695738116; bh=m0tFzaGuZn3n6EYr2Ye5YgW09/pA5Auj/AV5g4HqB58=; h=Date:From:To:Subject:From; b=OKCaBrVBh+elI6gpLn55X/oZa4WbbbnQVgX0GaMozbOcRi6F+3VewVNhpl5dIyEpX iuSOBZsaNq0grwSzs+Ws3jGVxZei9go36hGV1OVn3XyF5K3QjBsysqHKJv6qwQehz1 ap4vsReaIvjglRL07BKhy5tPvzpc7WhScTcru1JQ= Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 26 Sep 2023 17:21:53 +0300 From: "ShinyZero0" <shinyzero0@HIDDEN> To: <66193 <at> debbugs.gnu.org> Subject: [PATCH] gnu: Add keyd Message-Id: <CVSWXT9ZHO24.3LDYDRIMBKSS7@fedora> X-Mailer: aerc 0.15.2 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 66193 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) From 4926a18454135e97832e2d183893f01a2f42a06c Mon Sep 17 00:00:00 2001 From: "zero@fedora" <shinyzero0@HIDDEN> Date: Mon, 25 Sep 2023 19:39:00 +0300 Subject: [PATCH] gnu: Add keyd * gnu/packages/keyd.scm: New file. * gnu/local.mk: Add it. --- gnu/local.mk | 1 + gnu/packages/keyd.scm | 60 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 61 insertions(+) create mode 100644 gnu/packages/keyd.scm diff --git a/gnu/local.mk b/gnu/local.mk index bfa816d717..f0745fed65 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -690,6 +690,7 @@ GNU_SYSTEM_MODULES =3D \ %D%/services/guix.scm \ %D%/services/hurd.scm \ %D%/services/kerberos.scm \ + %D%/services/keyd.scm \ %D%/services/ldap.scm \ %D%/services/lightdm.scm \ %D%/services/linux.scm \ diff --git a/gnu/packages/keyd.scm b/gnu/packages/keyd.scm new file mode 100644 index 0000000000..666b931650 --- /dev/null +++ b/gnu/packages/keyd.scm @@ -0,0 +1,60 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright =C2=A9 2023 Paul <shinyzero0@HIDDEN> +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>. + +(define-module (gnu packages keyd) + #:use-module (gnu packages linux) + #:use-module (guix packages) + #:use-module (guix gexp) + #:use-module (guix utils) + #:use-module (guix git-download) + #:use-module ((guix licenses) #:prefix license:) + #:use-module (guix build-system gnu)) + +(define-public keyd + (package + (name "keyd") + (version "2.4.3") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/rvaiya/keyd") + (commit (string-append "v" version)))) + (sha256 + (base32 + "1awdp863amq95y990fi4wj389ssv3ip2daqz2ph23lsahwa6f5in")))) + (arguments + (list #:tests? #f ; tests require root + #:make-flags + #~(list (string-append "CC=3D" #$(cc-for-target)) + "PREFIX=3D" + (string-append "DESTDIR=3D" #$output)) + #:phases + '(modify-phases + %standard-phases + (delete 'configure)))) ; no autoconf + (build-system gnu-build-system) + (inputs (list linux-libre-headers)) + (synopsis "A key remapping daemon for linux.") + (description + "Keyd is a keyboard remapping utility with intuitive ini + config file format. Keyd has several features, many of + which are traditionally only found in custom keyboard firmware + like QMK") + (home-page "https://github.com/rvaiya/keyd") + (license license:expat))) --=20 2.41.0
guix-patches@HIDDEN:bug#66193; Package guix-patches.
Full text available.Received: (at 66193) by debbugs.gnu.org; 25 Sep 2023 19:00:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 25 15:00:18 2023 Received: from localhost ([127.0.0.1]:46675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qkqob-0002EV-Bb for submit <at> debbugs.gnu.org; Mon, 25 Sep 2023 15:00:18 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:40690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <jackhill@HIDDEN>) id 1qkqoV-0002D2-J9 for 66193 <at> debbugs.gnu.org; Mon, 25 Sep 2023 15:00:15 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <jackhill@HIDDEN>) id 1qkqoD-00021f-Ae; Mon, 25 Sep 2023 14:59:53 -0400 Date: Mon, 25 Sep 2023 14:59:53 -0400 (EDT) From: Jack Hill <jackhill@HIDDEN> X-X-Sender: jackhill@HIDDEN To: ShinyZero0 <shinyzero0@HIDDEN> Subject: Re: [bug#66193] [PATCH] gnu: Add keyd. In-Reply-To: <CVS5DY5C7BGC.NFGIXCDSS1WR@fedora> Message-ID: <alpine.DEB.2.21.2309251433170.16303@HIDDEN> References: <CVS5DY5C7BGC.NFGIXCDSS1WR@fedora> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66193 Cc: 66193 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Mon, 25 Sep 2023, ShinyZero0 wrote: > From 01e89ff48c77e12b7a8f206098901e08bc979935 Mon Sep 17 00:00:00 2001 > From: "zero@fedora" <shinyzero0@HIDDEN> > Date: Mon, 25 Sep 2023 19:39:00 +0300 > Subject: [PATCH] gnu: Add keyd > > * gnu/packages/keyd.scm: New file. Thanks for your submission. keyd looks like a neat package that I did not know about before! I'll leave some comments below about some things that I think can be improved. Can you look into them and send a second version? > --- > gnu/packages/keyd.scm | 43 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > create mode 100644 gnu/packages/keyd.scm When adding a new file, it should also be added to the list of files in gnu/local.mk. Also, the "This file is party of GNU Guix" header should be added to the beginning of this file (it can be copied from another one). You can also add a copyright line for yourself! Alternatively, you could put keyd in an existing file. linux.scm might be a good one. This is a little bit of a judgment call, and I'm not experienced enough to know what's best. Maybe someone else will chime in here, or you could ask for advice on IRC. > diff --git a/gnu/packages/keyd.scm b/gnu/packages/keyd.scm > new file mode 100644 > index 0000000000..48afd9f877 > --- /dev/null > +++ b/gnu/packages/keyd.scm > @@ -0,0 +1,43 @@ > +(define-module (gnu packages keyd)) > +(use-modules > + (guix packages) > + (gnu packages linux) > + (guix git-download) > + ((guix licenses) #:prefix license:) > + (guix build-system gnu)) > +(define-public keyd > + (package > + (name "keyd") > + (version "2.4.3") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/rvaiya/keyd") > + (commit (string-append "v" version)))) > + (sha256 > + (base32 > + "1awdp863amq95y990fi4wj389ssv3ip2daqz2ph23lsahwa6f5in")))) > + (arguments > + (list #:tests? ; no tests > + #f I looks to me like there are tests in the t directory. Can they be enabled? https://github.com/rvaiya/keyd/blob/5e4ef41b41ce02f7d6a9f2e51298810d84589e76/Makefile#L87-L91 Also, a little bit of a nitpick, but I think it would be easier to read if #tests? and #f were on the same line. > + #:make-flags > + '(list "CC=gcc" Unfortunately, there's a subtle bug here. Most of the time this will work, but when cross compiling, it will pick the wrong GCC (oops!). Fortunately we have a cc-for-target procedure that will pick the right one. Here's an example of it in use: https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/linux.scm?id=fafd3caef0d51811a5da81d6061789e2908b0dac#n1591 > + "PREFIX=" > + (string-append > + "DESTDIR=" > + (assoc-ref %outputs "out"))) This can probably be upgraded to the new style of using gexps to find the output. The above example package does that. See also this blog post for the long explanation: https://guix.gnu.org/en/blog/2021/the-big-change/ > + #:phases > + '(modify-phases > + %standard-phases > + (delete 'configure)))) ; no autoconf > + (build-system gnu-build-system) > + (inputs (list linux-libre-headers)) > + (synopsis "A key remapping daemon for linux.") > + (description > + "Keyd is a keyboard remapping utility with intuitive ini > + config file format. Keyd has several unique features, many of > + which are traditionally only found in custom keyboard firmware > + like QMK") Another nitpick: intuitive and unique sound like marketing words to me and can probably be left out. However that's just my taste. > + (home-page "https://github.com/rvaiya/keyd") > + (license license:expat))) That's all I have for know. Thanks again for your contribution, and hopefully you found this review helpful. All the best, Jack
guix-patches@HIDDEN:bug#66193; Package guix-patches.
Full text available.Received: (at submit) by debbugs.gnu.org; 25 Sep 2023 16:45:44 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 25 12:45:44 2023 Received: from localhost ([127.0.0.1]:46520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qkoiO-0001HU-4j for submit <at> debbugs.gnu.org; Mon, 25 Sep 2023 12:45:44 -0400 Received: from lists.gnu.org ([2001:470:142::17]:37080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <shinyzero0@HIDDEN>) id 1qkoiI-0001HB-C5 for submit <at> debbugs.gnu.org; Mon, 25 Sep 2023 12:45:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <shinyzero0@HIDDEN>) id 1qkoi0-0008Dd-E9 for guix-patches@HIDDEN; Mon, 25 Sep 2023 12:45:20 -0400 Received: from tilde.club ([2607:5300:204:4340::114]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <shinyzero0@HIDDEN>) id 1qkohy-00063R-Od for guix-patches@HIDDEN; Mon, 25 Sep 2023 12:45:20 -0400 Received: from localhost (unknown [91.236.30.101]) by tilde.club (Postfix) with ESMTPSA id 15F932230DBB7 for <guix-patches@HIDDEN>; Mon, 25 Sep 2023 16:45:15 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 tilde.club 15F932230DBB7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tilde.club; s=mail; t=1695660316; bh=W8Orjgy7xSSClLvJRABf7h4ZUkfUBMHV2k6F4oGbBQg=; h=Date:Subject:From:To:From; b=u6c6fWIVpU7jEwFXpqSRsTCF+eYqvUIYdWP09Ledsr2seffgfXSlyBkgynDiM40im vltbpr1qejIQLRiwcmSg91v1XivMWFpCqCNq3EHHdCKbRI7apiKKdgzdpmLd/RWPwo fKLK+Xgxfxqf03/P/Dr27IQUgONZw95a9g2VnpiI= Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 25 Sep 2023 19:45:13 +0300 Subject: [PATCH] gnu: Add keyd. From: "ShinyZero0" <shinyzero0@HIDDEN> To: <guix-patches@HIDDEN> Message-Id: <CVS5DY5C7BGC.NFGIXCDSS1WR@fedora> X-Mailer: aerc 0.15.2 Received-SPF: pass client-ip=2607:5300:204:4340::114; envelope-from=shinyzero0@HIDDEN; helo=tilde.club X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.1 (/) From 01e89ff48c77e12b7a8f206098901e08bc979935 Mon Sep 17 00:00:00 2001 From: "zero@fedora" <shinyzero0@HIDDEN> Date: Mon, 25 Sep 2023 19:39:00 +0300 Subject: [PATCH] gnu: Add keyd * gnu/packages/keyd.scm: New file. --- gnu/packages/keyd.scm | 43 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) create mode 100644 gnu/packages/keyd.scm diff --git a/gnu/packages/keyd.scm b/gnu/packages/keyd.scm new file mode 100644 index 0000000000..48afd9f877 --- /dev/null +++ b/gnu/packages/keyd.scm @@ -0,0 +1,43 @@ +(define-module (gnu packages keyd)) +(use-modules + (guix packages) + (gnu packages linux) + (guix git-download) + ((guix licenses) #:prefix license:) + (guix build-system gnu)) +(define-public keyd + (package + (name "keyd") + (version "2.4.3") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/rvaiya/keyd") + (commit (string-append "v" version)))) + (sha256 + (base32 + "1awdp863amq95y990fi4wj389ssv3ip2daqz2ph23lsahwa6f5in")))) + (arguments + (list #:tests? ; no tests + #f + #:make-flags + '(list "CC=3Dgcc" + "PREFIX=3D" + (string-append + "DESTDIR=3D" + (assoc-ref %outputs "out"))) + #:phases + '(modify-phases + %standard-phases + (delete 'configure)))) ; no autoconf + (build-system gnu-build-system) + (inputs (list linux-libre-headers)) + (synopsis "A key remapping daemon for linux.") + (description + "Keyd is a keyboard remapping utility with intuitive ini + config file format. Keyd has several unique features, many of + which are traditionally only found in custom keyboard firmware + like QMK") + (home-page "https://github.com/rvaiya/keyd") + (license license:expat))) --=20 2.41.0
"ShinyZero0" <shinyzero0@HIDDEN>:guix-patches@HIDDEN.
Full text available.guix-patches@HIDDEN:bug#66193; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.