GNU logs - #68309, boring messages

Message sent to , guix-patches@HIDDEN:

Subject: [bug#68309] [PATCH] gnu: Add powertop-service-type.
Resent-From: Ian Eure <ian@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: , guix-patches@HIDDEN
Resent-Date: Sun, 07 Jan 2024 21:23:02 +0000
Resent-Message-ID: <handler.68309.B.170466252318750 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 68309 <at> debbugs.gnu.org
Cc: Ian Eure <ian@HIDDEN>, ( <paren@HIDDEN>, Christopher Baines <guix@HIDDEN>, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>, Raghav Gururajan <rg@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>, Simon Tournier <zimon.toutoune@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>, jgart <jgart@HIDDEN>
Feedback-ID: id9014242:Fastmail
From: Ian Eure <ian@HIDDEN>
Date: Sun,  7 Jan 2024 13:21:21 -0800
Message-ID: <20240107212122.21810-1-ian@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=66.111.4.25; envelope-from=ian@HIDDEN;
 helo=out1-smtp.messagingengine.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.6 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.4 (/)

* gnu/services/pm.scm (powertop-shepherd-service): New variable.
* gnu/services/pm.scm (powertop-service-type): New variable.
* gnu/services/pm.scm (powertop-configuration): New variable.
* gnu/packages/linux.scm (powertop): Correct package description.
* doc/guix.texi (Power Management Services): Document powertop-service-type.

Change-Id: I1c5ef855526458ad54f62ca6e755da82acce1c4a
---
 doc/guix.texi          | 24 +++++++++++++++++++++++
 gnu/packages/linux.scm |  2 +-
 gnu/services/pm.scm    | 43 +++++++++++++++++++++++++++++++++++++++++-
 3 files changed, 67 insertions(+), 2 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index a648a106b3..e95ae140f2 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -34755,6 +34755,30 @@ Ignore cpuid check for supported CPU models.
 @item @code{thermald} (default: @var{thermald})
 Package object of thermald.

+@cindex powertop
+@cindex Power tuning with PowerTOP
+@subsubheading PowerTOP
+
+The @code{(gnu services pm)} module provides a Guix service definition
+for PowerTOP.  When started, it tunes kernel settings to reduce power
+consumption.
+
+@defvar powertop-service-type
+The service type for PowerTOP.  No configuration is necessary.  When the
+service starts, it executes @code{powertop --auto-tune}.
+
+@lisp
+(service powertop-service-type)
+
+@end defvar
+
+Available @code{powertop-configuration} fields are:
+
+@deftypevr {@code{powertop-configuration} parameter} package powertop
+The PowerTOP package.  Defaults to @code{powertop}.
+
+@end deftypevr
+
 @end table
 @end deftp

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 0fe64bacf3..c53d8f82bd 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -3634,7 +3634,7 @@ (define-public powertop
     (inputs
      (list kmod libnl ncurses pciutils zlib))
     (home-page "https://01.org/powertop/")
-    (synopsis "Analyze power consumption on Intel-based laptops")
+    (synopsis "Analyze power consumption on x86-based laptops")
     (description
      "PowerTOP is a Linux tool to diagnose issues with power consumption and
 power management.  In addition to being a diagnostic tool, PowerTOP also has
diff --git a/gnu/services/pm.scm b/gnu/services/pm.scm
index 3daf484cc1..13a153ab1d 100644
--- a/gnu/services/pm.scm
+++ b/gnu/services/pm.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2017 Mathieu Othacehe <m.othacehe@HIDDEN>
+;;; Copyright © 2024 Ian Eure <ian@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -17,6 +18,8 @@
 ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.

 (define-module (gnu services pm)
+  #:use-module (srfi srfi-1)
+  #:use-module (ice-9 match)
   #:use-module (guix gexp)
   #:use-module (guix packages)
   #:use-module (guix records)
@@ -31,7 +34,10 @@ (define-module (gnu services pm)
             tlp-configuration

             thermald-configuration
-            thermald-service-type))
+            thermald-service-type
+
+            powertop-configuration
+            powertop-service-type))

 (define (uglify-field-name field-name)
   (let ((str (symbol->string field-name)))
@@ -466,3 +472,38 @@ (define thermald-service-type
    (default-value (thermald-configuration))
    (description "Run thermald, a CPU frequency scaling service that helps
 prevent overheating.")))
+
+
+
+;;;
+;;; powertop
+;;;
+;;; Calls `powertop --auto-tune' to reduce energy consumption.
+
+
+
+(define-configuration powertop-configuration
+  (powertop (package powertop) "PowerTOP package to use."))
+
+(define powertop-shepherd-service
+  (match-lambda
+    (($ <powertop-configuration> powertop)
+     (shepherd-service
+      (documentation "Tune kernel power settings at boot.")
+      (provision '(powertop powertop-auto-tune))
+      (requirement '(user-processes))
+      (one-shot? #t)
+      (start #~(lambda _
+                 (zero? (system* #$(file-append powertop "/sbin/powertop")
+                                 "--auto-tune"))))))))
+
+(define powertop-service-type
+  (service-type
+   (name 'powertop)
+   (extensions
+    (list
+     (service-extension shepherd-root-service-type
+                        (compose list powertop-shepherd-service))))
+   (compose concatenate)
+   (default-value (powertop-configuration))
+   (description "Tune power-related kernel parameters to reduce energy consumption.")))
-- 
2.41.0

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Ian Eure <ian@HIDDEN>
Subject: bug#68309: Acknowledgement ([PATCH] gnu: Add powertop-service-type.)
Message-ID: <handler.68309.B.170466252318750.ack <at> debbugs.gnu.org>
References: <20240107212122.21810-1-ian@HIDDEN>
X-Gnu-PR-Message: ack 68309
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 68309 <at> debbugs.gnu.org
Date: Sun, 07 Jan 2024 21:23:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  ( <paren@HIDDEN>, Christopher Baines <guix@HIDDEN>, Ludovic Cou=
rt=C3=A8s <ludo@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>, Raghav Gurur=
ajan <rg@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>, Simon =
Tournier <zimon.toutoune@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>, =
jgart <jgart@HIDDEN>
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 68309 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
68309: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D68309
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#68309] [PATCH] gnu: Add powertop-service-type.
Resent-From: Mathieu Othacehe <othacehe@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 08 Jan 2024 09:12:01 +0000
Resent-Message-ID: <handler.68309.B68309.170470507613145 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Ian Eure <ian@HIDDEN>
Cc: Simon Tournier <zimon.toutoune@HIDDEN>, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>, Raghav Gururajan <rg@HIDDEN>, 68309 <at> debbugs.gnu.org, jgart <jgart@HIDDEN>, Christopher Baines <guix@HIDDEN>
From: Mathieu Othacehe <othacehe@HIDDEN>
In-Reply-To: <20240107212122.21810-1-ian@HIDDEN> (Ian Eure's message of
 "Sun, 7 Jan 2024 13:21:21 -0800")
References: <20240107212122.21810-1-ian@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
Date: Mon, 08 Jan 2024 10:10:55 +0100
Message-ID: <87zfxg8a1s.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hello,

Looks good,

> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index 0fe64bacf3..c53d8f82bd 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -3634,7 +3634,7 @@ (define-public powertop
>      (inputs
>       (list kmod libnl ncurses pciutils zlib))
>      (home-page "https://01.org/powertop/")
> -    (synopsis "Analyze power consumption on Intel-based laptops")
> +    (synopsis "Analyze power consumption on x86-based laptops")

This should be part of a separate commit.

> +                 (zero? (system* #$(file-append powertop "/sbin/powertop")
> +                                 "--auto-tune"))))))))

If the laptop booted with power cord plugged, but then goes on battery,
does this need to be run again?

Thanks,

Mathieu

Message sent to guix-patches@HIDDEN:

Subject: [bug#68309] [PATCH] gnu: Add powertop-service-type.
Resent-From: Ian Eure <ian@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 13 Jan 2024 21:26:02 +0000
Resent-Message-ID: <handler.68309.B68309.170518111510814 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Mathieu Othacehe <othacehe@HIDDEN>
Cc: Simon Tournier <zimon.toutoune@HIDDEN>, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>, Raghav Gururajan <rg@HIDDEN>, 68309 <at> debbugs.gnu.org, jgart <jgart@HIDDEN>, Christopher Baines <guix@HIDDEN>
Feedback-ID: id9014242:Fastmail
References: <20240107212122.21810-1-ian@HIDDEN> <87zfxg8a1s.fsf@HIDDEN>
User-agent: mu4e 1.10.8; emacs 29.1
From: Ian Eure <ian@HIDDEN>
Date: Sat, 13 Jan 2024 13:23:56 -0800
In-reply-to: <87zfxg8a1s.fsf@HIDDEN>
Message-ID: <87y1ctorin.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Mathieu Othacehe <othacehe@HIDDEN> writes:

> Hello,
>
> Looks good,
>
>> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
>> index 0fe64bacf3..c53d8f82bd 100644
>> --- a/gnu/packages/linux.scm
>> +++ b/gnu/packages/linux.scm
>> @@ -3634,7 +3634,7 @@ (define-public powertop
>>      (inputs
>>       (list kmod libnl ncurses pciutils zlib))
>>      (home-page "https://01.org/powertop/")
>> -    (synopsis "Analyze power consumption on Intel-based=20
>> laptops")
>> +    (synopsis "Analyze power consumption on x86-based=20
>> laptops")
>
> This should be part of a separate commit.
>

Okay, I=E2=80=99ll send a patch series in a bit.  I was hoping it could be=
=20
one commit, because it=E2=80=99s related, and sending a patch series is=20
very annoying.

>> +                 (zero? (system* #$(file-append powertop=20
>> "/sbin/powertop")
>> +                                 "--auto-tune"))))))))
>
> If the laptop booted with power cord plugged, but then goes on=20
> battery,
> does this need to be run again?
>

No, the settings persist across power plug/unplug events.

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#68309] [PATCH 1/2] gnu: Add powertop-service-type.
References: <20240107212122.21810-1-ian@HIDDEN>
In-Reply-To: <20240107212122.21810-1-ian@HIDDEN>
Resent-From: Ian Eure <ian@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 14 Jan 2024 00:41:02 +0000
Resent-Message-ID: <handler.68309.B68309.17051928373339 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 68309
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 68309 <at> debbugs.gnu.org
Cc: Ian Eure <ian@HIDDEN>
Received: via spool by 68309-submit <at> debbugs.gnu.org id=B68309.17051928373339
          (code B ref 68309); Sun, 14 Jan 2024 00:41:02 +0000
Received: (at 68309) by debbugs.gnu.org; 14 Jan 2024 00:40:37 +0000
Received: from localhost ([127.0.0.1]:41359 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rOoYH-0000rm-90
	for submit <at> debbugs.gnu.org; Sat, 13 Jan 2024 19:40:37 -0500
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:40803)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ian@HIDDEN>) id 1rOoYF-0000rV-Ek
 for 68309 <at> debbugs.gnu.org; Sat, 13 Jan 2024 19:40:36 -0500
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id 6F4CD5C007C;
 Sat, 13 Jan 2024 19:40:30 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Sat, 13 Jan 2024 19:40:30 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h=
 cc:cc:content-transfer-encoding:content-type:content-type:date
 :date:from:from:in-reply-to:message-id:mime-version:reply-to
 :subject:subject:to:to; s=fm1; t=1705192830; x=1705279230; bh=xr
 wr6lWSvmvdPfw1YGL0Z4/QEXJtHhFuf8u5XXoyxKc=; b=mJZVI9Z7I/I4khrAwr
 YkmV1w5Q0BQz9nJAD6V/XEa8UlLtdq2yHiWQisft5SubnwFUcOs/O3xD+4/5syTH
 mgBd0ljkBDfAwYhEpNLfOKPlzbF5dFIVR32qiZG5rX6ASFu9PhJ9Vd4BgZPPyqOV
 ytGVP4hE37AeEyMoGloOopMaTKqK+0Qa83Th8enj0kMNx7XSL8Ie27zdMZpt8SIi
 Gl8cT8aDtOi7YE9DuIX3KvpXUxNS0XFbGtQYaMNfzlG5y3WvB5IT5l/UiPIQw3Qy
 +yddpCEPOCAR3c/58PaMyDdLihZeft9cJugbYbmxq9du+4OEu6lBxaWdbKZWhEer
 C0cA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:content-type:date:date:feedback-id:feedback-id
 :from:from:in-reply-to:message-id:mime-version:reply-to:subject
 :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; t=1705192830; x=1705279230; bh=xrwr6lWSvmvdP
 fw1YGL0Z4/QEXJtHhFuf8u5XXoyxKc=; b=9CXKGnRzRKkP13NFcVkfDWGB55bjo
 Talw9YPDK+xxRBB29O+EblkvHiv4ktL8BxqLaXZAZTIB3VKfADAIOhMUIuXQSr3+
 rMl3ummFw2zmqkv3dWdsH4p64fPMIiPwUVRg1fAeL9TcEqOJ6c6g3p7Aroy30xtn
 hxWxmmJa2sOHk3QPrjCvy+4gwpZd8c1z8jRN1BvkcyEMCL+9UtmosTfMkIjZzpL7
 sHagyK+9c/NlqVO8G6+44QuRbsQ9W+VQ/yt4o0hEv1gfnSVO68Xfy7Vakbb8aW7X
 Aict5DDX1wgIR7jE6cS1hHnhAHOhYNzflFMDvlgYzzuTD2C7DpBY+gB/Q==
X-ME-Sender: <xms:fi2jZUCVNeudLg6_mKEVgzss1JMjKhpR9M-yEo3vA_zuQ90OMnr2aw>
 <xme:fi2jZWgo3qhz33O9TxkQxezPlLWeCoHw23wfUcqlAspXUnbjLrQTWruU-VdVULA-U
 XdFTbYxqPF73yABQw>
X-ME-Received: <xmr:fi2jZXn8JObsGdaOcBE-UcGUYYjJWvFzFCZYcWKwkb-slSZWorQJCSWvnmkamVNFJFGjWDk9qLYLricuE-xcqrvgP7alvVIjqImuz4LGV4TZvBOjfw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdeikedgvdehucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffogggtgfesthekre
 dtredtjeenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdr
 thhvqeenucggtffrrghtthgvrhhnpeejuefghefgffefteehvddtuddutefhvddtfeduhf
 dugfdvvdeulefgfefhhefhheenucffohhmrghinhepghhnuhdrohhrghenucevlhhushht
 vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghnsehrvghtrhhosh
 hpvggtrdhtvh
X-ME-Proxy: <xmx:fi2jZayhAyuzPmu5tesN0QEL8CaIrHL6XUtTJvO0QZWwTwFoNTGi8A>
 <xmx:fi2jZZQioAJ_1e6T1SaY13TCtCoymLjK4KBcZzS3HU3QH3ad8uPTsw>
 <xmx:fi2jZVZNlraUJNORhOtTORnI18QV2bp4nGfMiIacLPgi8OWMOtXzFg>
 <xmx:fi2jZa7PXXCEheeUm-N9lvwEtmMJQKjIeTYKazetYNHKt5heS_Ki6A>
Feedback-ID: id9014242:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat,
 13 Jan 2024 19:40:29 -0500 (EST)
From: Ian Eure <ian@HIDDEN>
Date: Sat, 13 Jan 2024 16:40:17 -0800
Message-ID: <20240114004019.5019-1-ian@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

* gnu/services/pm.scm (powertop-shepherd-service): New variable.
* gnu/services/pm.scm (powertop-service-type): New variable.
* gnu/services/pm.scm (powertop-configuration): New variable.
* doc/guix.texi (Power Management Services): Document powertop-service-type.

Change-Id: I1c5ef855526458ad54f62ca6e755da82acce1c4a
---
 doc/guix.texi       | 24 ++++++++++++++++++++++++
 gnu/services/pm.scm | 43 ++++++++++++++++++++++++++++++++++++++++++-
 2 files changed, 66 insertions(+), 1 deletion(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 811edd0bf7..a48aa655ae 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -34798,6 +34798,30 @@ Ignore cpuid check for supported CPU models.
 @item @code{thermald} (default: @var{thermald})
 Package object of thermald.
 
+@cindex powertop
+@cindex Power tuning with PowerTOP
+@subsubheading PowerTOP
+
+The @code{(gnu services pm)} module provides a Guix service definition
+for PowerTOP.  When started, it tunes kernel settings to reduce power
+consumption.
+
+@defvar powertop-service-type
+The service type for PowerTOP.  No configuration is necessary.  When the
+service starts, it executes @code{powertop --auto-tune}.
+
+@lisp
+(service powertop-service-type)
+
+@end defvar
+
+Available @code{powertop-configuration} fields are:
+
+@deftypevr {@code{powertop-configuration} parameter} package powertop
+The PowerTOP package.  Defaults to @code{powertop}.
+
+@end deftypevr
+
 @end table
 @end deftp
 
diff --git a/gnu/services/pm.scm b/gnu/services/pm.scm
index 3daf484cc1..13a153ab1d 100644
--- a/gnu/services/pm.scm
+++ b/gnu/services/pm.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2017 Mathieu Othacehe <m.othacehe@HIDDEN>
+;;; Copyright © 2024 Ian Eure <ian@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -17,6 +18,8 @@
 ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
 
 (define-module (gnu services pm)
+  #:use-module (srfi srfi-1)
+  #:use-module (ice-9 match)
   #:use-module (guix gexp)
   #:use-module (guix packages)
   #:use-module (guix records)
@@ -31,7 +34,10 @@ (define-module (gnu services pm)
             tlp-configuration
 
             thermald-configuration
-            thermald-service-type))
+            thermald-service-type
+
+            powertop-configuration
+            powertop-service-type))
 
 (define (uglify-field-name field-name)
   (let ((str (symbol->string field-name)))
@@ -466,3 +472,38 @@ (define thermald-service-type
    (default-value (thermald-configuration))
    (description "Run thermald, a CPU frequency scaling service that helps
 prevent overheating.")))
+
+
+
+;;;
+;;; powertop
+;;;
+;;; Calls `powertop --auto-tune' to reduce energy consumption.
+
+
+
+(define-configuration powertop-configuration
+  (powertop (package powertop) "PowerTOP package to use."))
+
+(define powertop-shepherd-service
+  (match-lambda
+    (($ <powertop-configuration> powertop)
+     (shepherd-service
+      (documentation "Tune kernel power settings at boot.")
+      (provision '(powertop powertop-auto-tune))
+      (requirement '(user-processes))
+      (one-shot? #t)
+      (start #~(lambda _
+                 (zero? (system* #$(file-append powertop "/sbin/powertop")
+                                 "--auto-tune"))))))))
+
+(define powertop-service-type
+  (service-type
+   (name 'powertop)
+   (extensions
+    (list
+     (service-extension shepherd-root-service-type
+                        (compose list powertop-shepherd-service))))
+   (compose concatenate)
+   (default-value (powertop-configuration))
+   (description "Tune power-related kernel parameters to reduce energy consumption.")))
-- 
2.41.0

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#68309] [PATCH 2/2] gnu: Correct package description.
Resent-From: Ian Eure <ian@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 14 Jan 2024 00:41:02 +0000
Resent-Message-ID: <handler.68309.B68309.17051928423354 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 68309
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 68309 <at> debbugs.gnu.org
Cc: Ian Eure <ian@HIDDEN>
Received: via spool by 68309-submit <at> debbugs.gnu.org id=B68309.17051928423354
          (code B ref 68309); Sun, 14 Jan 2024 00:41:02 +0000
Received: (at 68309) by debbugs.gnu.org; 14 Jan 2024 00:40:42 +0000
Received: from localhost ([127.0.0.1]:41364 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rOoYL-0000s2-RT
	for submit <at> debbugs.gnu.org; Sat, 13 Jan 2024 19:40:42 -0500
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:34387)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ian@HIDDEN>) id 1rOoYH-0000rZ-GU
 for 68309 <at> debbugs.gnu.org; Sat, 13 Jan 2024 19:40:38 -0500
Received: from compute6.internal (compute6.nyi.internal [10.202.2.47])
 by mailout.nyi.internal (Postfix) with ESMTP id 7B4D85C0113;
 Sat, 13 Jan 2024 19:40:33 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute6.internal (MEProxy); Sat, 13 Jan 2024 19:40:33 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h=
 cc:cc:content-transfer-encoding:content-type:date:date:from:from
 :in-reply-to:in-reply-to:message-id:mime-version:references
 :reply-to:subject:subject:to:to; s=fm1; t=1705192833; x=
 1705279233; bh=ljUlfQP5YLSmrmtRdK6YmkiHaibElqJTI0Kp879Hm8E=; b=S
 5aVXihtSMk3i1fgDy5EdcacX7eHnvoJ63emzJjw+4BVb66MLgIftqzxMa9DGQWHb
 1l7LayhRXTqgUg5wnBmWzGYqJgaHWJsT6Mc1u2YgFS/P6VTxVGxDFHTi+A8Pec05
 SsqvsKdjnc1efxKWTwOTklVlIzGDzFqYvvfkAqoumJG/k4vGtQeNRnMtLMLhCtEO
 5S2mcPRidVQxy6/DWevyinN1WpOn1v709kwOk7mPNXfbPUAl6iIoV1q5aj/lqZwj
 sVMMbD6TTJ/lrBDnUvCJzIZ+A8JOe3UebJabVb4fCh72gQJAlb7T6e67zj8+EWHn
 wpybhDQbogWMJ8k1XIKUw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:date:date:feedback-id:feedback-id:from:from
 :in-reply-to:in-reply-to:message-id:mime-version:references
 :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1705192833; x=
 1705279233; bh=ljUlfQP5YLSmrmtRdK6YmkiHaibElqJTI0Kp879Hm8E=; b=6
 mzobsQJBQYyvQ0oaW4D7S2bLwKlObN1QLr5QZH5JZWeAHxrH8H2phgqgoCBMV977
 wB9fqsdLq9Uz189lBABkHWYRJvl+8eKHXEtNveYK58poFcrBAZ/SX0bPN8NZvTC/
 re9kXY/Txz64NrOaBL7XL0wlaJygdBPl12PsA9F5E10NK+jlI1/vuYs+JHjzsFq5
 G5UX0Nw3yEHK7E/vedNud+X78pjNPf8IKXbY70AP0NXOn2xMFLI0/1b009tkqI0E
 V3YQJtwRGGuc0knkrcS93T3CutqYs5a1ilLfMP482zUmCA3H4DorJ1t09buWMAhR
 zkhNxRshj6uq987LkaZ+A==
X-ME-Sender: <xms:gS2jZfUIZYnZ2S-57a7-IW9S96aqP4yFFdyRXq_Fe-kV4GmDbZtPAQ>
 <xme:gS2jZXkK40WohWDmMxAUJ3d4-yfO5Pf8SRlNCbdOfvGHnkxxHHrSk7g6J7J4kT8y5
 TJoJfRs9QMxGZvV5g>
X-ME-Received: <xmr:gS2jZbaDAEqtmmQI9ro2NcQsvEWlCoRS-KaDgNX5mYHYZVf2N6649sorAKkh2ut6QC9mzDKYEtSBMVcg9zT3cLbc57pOJ_ih34hfDo59ntX1SWQaww>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdeikedgvdehucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke
 ertdertddtnecuhfhrohhmpefkrghnucfguhhrvgcuoehirghnsehrvghtrhhoshhpvggt
 rdhtvheqnecuggftrfgrthhtvghrnhepgfeiveehgeeijeeifeekfedthfejudduhfduhe
 ehjeeuhfettdehkedthfegudeinecuffhomhgrihhnpedtuddrohhrghenucevlhhushht
 vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghnsehrvghtrhhosh
 hpvggtrdhtvh
X-ME-Proxy: <xmx:gS2jZaUEOX3HBQZ3F0Tz3yt8sNeppks8HihX8XD27enUZto2vm_TEQ>
 <xmx:gS2jZZn80iXVvA-Yqe2_9IsVZurhElpQdIvINio_3mGoPRWHn0-rew>
 <xmx:gS2jZXefubWyia5odI7HLQZQTYqBWmSR86suGrWnwauVRS1lKSgWrg>
 <xmx:gS2jZYshehck67cemJnoKFANwi6XYPD3aM8Hws-WQiMLWCrU8Z8fTA>
Feedback-ID: id9014242:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat,
 13 Jan 2024 19:40:32 -0500 (EST)
From: Ian Eure <ian@HIDDEN>
Date: Sat, 13 Jan 2024 16:40:18 -0800
Message-ID: <20240114004019.5019-2-ian@HIDDEN>
X-Mailer: git-send-email 2.41.0
In-Reply-To: <20240114004019.5019-1-ian@HIDDEN>
References: <20240114004019.5019-1-ian@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

* gnu/packages/linux.scm (powertop): Correct package description.

Change-Id: Ifc81ed62158df8b3c235d335731590e977dcc725
---
 gnu/packages/linux.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 716f5907f0..3cd63df6ee 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -3634,7 +3634,7 @@ (define-public powertop
     (inputs
      (list kmod libnl ncurses pciutils zlib))
     (home-page "https://01.org/powertop/")
-    (synopsis "Analyze power consumption on Intel-based laptops")
+    (synopsis "Analyze power consumption on x86-based laptops")
     (description
      "PowerTOP is a Linux tool to diagnose issues with power consumption and
 power management.  In addition to being a diagnostic tool, PowerTOP also has
-- 
2.41.0

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#68309] [PATCH 1/2] gnu: Add powertop-service-type.
Resent-From: Mathieu Othacehe <othacehe@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 17 Jan 2024 10:16:02 +0000
Resent-Message-ID: <handler.68309.B68309.170548655332608 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 68309
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ian Eure <ian@HIDDEN>
Cc: 68309 <at> debbugs.gnu.org
Received: via spool by 68309-submit <at> debbugs.gnu.org id=B68309.170548655332608
          (code B ref 68309); Wed, 17 Jan 2024 10:16:02 +0000
Received: (at 68309) by debbugs.gnu.org; 17 Jan 2024 10:15:53 +0000
Received: from localhost ([127.0.0.1]:50880 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rQ2xd-0008TP-0O
	for submit <at> debbugs.gnu.org; Wed, 17 Jan 2024 05:15:53 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:43650)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <othacehe@HIDDEN>) id 1rQ2xc-0008JR-Cv
 for 68309 <at> debbugs.gnu.org; Wed, 17 Jan 2024 05:15:52 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <othacehe@HIDDEN>)
 id 1rQ2xW-0000Ab-2e; Wed, 17 Jan 2024 05:15:46 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=51COeu+49A4leErFpaTCrtPRM4VJ7LTTT00WbYsx+qQ=; b=ZG3mUszsTuzojTozj7gN
 9U7GKI9SnCDmyzW0wbZdduCuBlJ/ql/jxgI83eAE5UaQxBSona6MuTV+2rwRUBa673LdDgc8ewstq
 PXkukigajaZhCBti7f9S0d24HKZJkRFhT/3vn+TB/xtrabDZ5wAlgZVf49xXQ1j4u65E0ThvfVdnq
 dsg/F3puFDOwnAislHbLP26LTDGNzan9pWKJP74tJ/fFT6nchtOC3AsNGY5O8GMHsV1EjJ89Kzwrw
 MfWNC3z0VdGO30UZrzgbVI+5iJXnecYWWmnV7lTogwnAjE3dEpG30MJ9sVYzwueXrByKC89PWpNHL
 P7bj9lugumCSQg==;
From: Mathieu Othacehe <othacehe@HIDDEN>
In-Reply-To: <20240114004019.5019-1-ian@HIDDEN> (Ian Eure's message of
 "Sat, 13 Jan 2024 16:40:17 -0800")
References: <20240107212122.21810-1-ian@HIDDEN>
 <20240114004019.5019-1-ian@HIDDEN>
Date: Wed, 17 Jan 2024 11:15:44 +0100
Message-ID: <87a5p4jmen.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)


Hey,

Thanks for the v2!

> +The @code{(gnu services pm)} module provides a Guix service definition
> +for PowerTOP.  When started, it tunes kernel settings to reduce power
> +consumption.

I have this error when building the documentation:

--8<---------------cut here---------------start------------->8---
guix.texi:34841: `@end' expected `lisp', but saw `defvar'
--8<---------------cut here---------------end--------------->8---

> +
> +
> +

Kill that extra line

> +;;;
> +;;; powertop
> +;;;
> +;;; Calls `powertop --auto-tune' to reduce energy consumption.
> +
> +

That one too.

> +   (description "Tune power-related kernel parameters to reduce energy consumption.")))

Wrap it to be under 78 characters.

Thanks,

Mathieu

Last modified: Sat, 20 Jan 2024 12:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.