Received: (at 68803-done) by debbugs.gnu.org; 12 Feb 2025 03:53:46 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 11 22:53:46 2025 Received: from localhost ([127.0.0.1]:60032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ti3oo-0000Iq-Cg for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 22:53:46 -0500 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]:56640) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1ti3ol-0000Ia-7c for 68803-done <at> debbugs.gnu.org; Tue, 11 Feb 2025 22:53:43 -0500 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5de5bf41652so6609096a12.1 for <68803-done <at> debbugs.gnu.org>; Tue, 11 Feb 2025 19:53:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739332417; x=1739937217; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=3F/vnWj9/MPnq+39kqgmQVNftgsC5wRpu/USxsWduIY=; b=kXj4tsPoKvq3LxnaeBIP4ZpEu9VoayP/FCu5EBvMND9EAzp4fFPy6JsGCpIkwWlEUG E0MQcyJwdwCq9+FhkNqMr30v9CEazzOI9D7MQG36FMeWuHu0O2lS7WHmoayu0yAgj9Fn 9pT9zqGxpuZxmMLy5nFyke3stfeqwlYOvh9Z1osLebKlIwT8+LPwFnLG+wkBijJKJWPP qF2LqmeRaVzpd253ivdMqz5kPhZI+fJORLKvZ3tzY+pfMW3Fb/yAEkWr+IOKcfoAWIhx tv4Wa1Lr/7K+/KpIrp3ua2wC0BpQqdZXUw1IoNna4tegwCrhThmvZ7KHqrZzUV6/r9zW sEpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739332417; x=1739937217; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3F/vnWj9/MPnq+39kqgmQVNftgsC5wRpu/USxsWduIY=; b=V7OiQGCf/F0zB9VFC+OrEL3a7SXf82clkrAI+/nxb0xfrN3cvw5TQvzQqW7LqF2Qo0 9h03mhhR5yWb2Y/85jIQIa/gNbAQnUEo+/z0krBXcANaGsM6fmx7ESyRoWDt3Whh4cDt k7HwV+4KEtFGbwntJjPS2fcucP5dKTzLdnGeTqh96p7aek62syaRWRfeeGWAi+J0C3aT VQhpKF/Nle4SVc/qo3mntdx3UJGHljOCJyCEVFHkROLtgWzzITck2Z2pUhKXc4GU4s0e 3XIr/Qda5d8VpyS7i6AFs6eDY4Xds/iBuxmansYoLJl+FKOCMZd9H/UEZalMbjQalJnn Ypng== X-Gm-Message-State: AOJu0YwMW3DfmRu6Hef0WvX8XP2bUQjBOBESnSXwUbEYz1hpp5g+o1HQ LfhR5vnJPoFplT7kDJhsyZViiL9eWgeg8H+QfEd8lYL8On+fEp51uIs71bl49rqNKXOrLOEC3mg 2LCinN2dyf+qaAttrskhwl302lObEWt2N3ci/iw== X-Gm-Gg: ASbGnctqbAo8SRGKH9waXiLJPypxcJB1J8f87yiVvTUh5oZJSSTZpd5odnBphXsz8xL D1+sQKGPaVl0hykaaLCYirK8YR9KiMK3hTREnXD0muEdYvYxGAOOSp+Bso5+9gLaaSDeedQU0 X-Google-Smtp-Source: AGHT+IFkvgxAo7M8hg6Zzq42arA/1xRhtmS8FC8JjqwrFjuX52pvGni6DGtiqkWmQ6nB31mrdD8YbCEmjR2yHG6WE9E= X-Received: by 2002:a05:6402:2681:b0:5d9:f5c4:a227 with SMTP id 4fb4d7f45d1cf-5deade0b19fmr1134705a12.20.1739332416767; Tue, 11 Feb 2025 19:53:36 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 11 Feb 2025 19:53:36 -0800 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <87h6ivye9v.fsf@HIDDEN> References: <87h6ivye9v.fsf@HIDDEN> MIME-Version: 1.0 Date: Tue, 11 Feb 2025 19:53:36 -0800 X-Gm-Features: AWEUYZn_XP2ODBbgkxclbWLcv6Syq5y5o5e9IEeqoC4lZ_6o5ytZ7imuwh0RdI4 Message-ID: <CADwFkmm19QXOC2Z4sjjhppV62tZbByddHjfS=R2r5RQwp5HAoA@HIDDEN> Subject: Re: bug#68803: [PATCH] Substitute all emacsclient occurrences To: Lin Jian <me@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 68803-done Cc: 68803-done <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Version: 31.1 Lin Jian <me@HIDDEN> writes: > Tags: patch > > After commit "From .desktop files, reuse a frame or start a new > Emacs as required" on 2021-06-30, there are two emacsclient > occurrences for the Exec key of etc/emacsclient.desktop. > > Before this change, only the first occurrence is substituted. > > I propose a patch to substitute all emacsclient occurrences. Thanks for the patch, and sorry here also for the delay in reviewing. Installed on master as commit a73a1e00523. I'm consequently closing this bug report.
Lin Jian <me@HIDDEN>:Stefan Kangas <stefankangas@HIDDEN>:Stefan Kangas <stefankangas@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at submit) by debbugs.gnu.org; 29 Jan 2024 22:19:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 29 17:19:14 2024
Received: from localhost ([127.0.0.1]:33637 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rUZyE-0007UL-Cw
for submit <at> debbugs.gnu.org; Mon, 29 Jan 2024 17:19:14 -0500
Received: from lists.gnu.org ([2001:470:142::17]:47838)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <me@HIDDEN>) id 1rUZyC-0007U3-Om
for submit <at> debbugs.gnu.org; Mon, 29 Jan 2024 17:19:13 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <me@HIDDEN>) id 1rUZxy-00010r-Ba
for bug-gnu-emacs@HIDDEN; Mon, 29 Jan 2024 17:18:58 -0500
Received: from mail.linj.tech ([5.255.109.209])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <me@HIDDEN>) id 1rUZxw-0000b5-3F
for bug-gnu-emacs@HIDDEN; Mon, 29 Jan 2024 17:18:58 -0500
From: Lin Jian <me@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linj.tech; s=mail;
t=1706566732; bh=je2jE9MggLeZWuK5Cn2EMVRMfudvS6cwPOjCnKU43RY=;
h=From:To:Subject:Date;
b=HT3cC2MNBnVO/y0Nm6Lk6e15Vv8RM4dCbH+DahKxgCwuZBUxFBIMR71hHZZFWuIbM
2BlaugRTTwLyfA6LNinOR3jN8mIiKK4U9Fv4PoEyvbWYw5wM5M/wJ9ncQeTSNp6ZlT
9oEXHF7B5HaHBQUncDYVtGiRBqWRjVlCwdxZHMJW5NsqIrfob+e5pWBuf8y1rVEBRP
FT+fEDvGZIiMw8sdpZa8MnIkQRmT4YrR6e/I6GbaAnjq2RdZF8bh8hcuDtWDA0lxOE
snaZ/kOX6/V9OFeAhK7lkK8vPDib4LGm6gtz28scKBjc+0ZzuXzguX3XYKKtENQJwY
KCjNPul284h9A==
To: bug-gnu-emacs@HIDDEN
Subject: [PATCH] Substitute all emacsclient occurrences
Date: Tue, 30 Jan 2024 06:15:51 +0800
Message-ID: <87h6ivye9v.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=5.255.109.209; envelope-from=me@HIDDEN;
helo=mail.linj.tech
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)
--=-=-=
Content-Type: text/plain
Tags: patch
After commit "From .desktop files, reuse a frame or start a new
Emacs as required" on 2021-06-30, there are two emacsclient
occurrences for the Exec key of etc/emacsclient.desktop.
Before this change, only the first occurrence is substituted.
I propose a patch to substitute all emacsclient occurrences.
In GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
version 1.18.0, Xaw3d scroll bars)
Windowing system distributor 'The X.Org Foundation', version 11.0.12101010
System Description: NixOS 24.05 (Uakari)
Configured using:
'configure
--prefix=/nix/store/mzdvpxzkhlryxmbxwbih7bgvkzkw1ly7-emacs-29.1
--disable-build-details --with-modules --with-x-toolkit=lucid
--with-xft --with-cairo --with-compress-install
--with-toolkit-scroll-bars --with-native-compilation
--without-imagemagick --without-small-ja-dic --with-tree-sitter
--with-xinput2 --without-xwidgets'
--=-=-=
Content-Type: text/patch
Content-Disposition: attachment;
filename=0001-Substitute-all-emacsclient-occurrences.patch
From 69ea684a44e1619b3e89a2f2a7189713dfdc03ab Mon Sep 17 00:00:00 2001
From: Lin Jian <me@HIDDEN>
Date: Tue, 30 Jan 2024 06:11:26 +0800
Subject: [PATCH] Substitute all emacsclient occurrences
After commit "From .desktop files, reuse a frame or start a new
Emacs as required" on 2021-06-30, there are two emacsclient
occurrences for the Exec key of etc/emacsclient.desktop.
Before this change, only the first occurrence is substituted.
* Makefile.in (install-etc): Substitute all emacsclient occurrences.
Copyright-paperwork-exempt: yes
---
Makefile.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.in b/Makefile.in
index 996f7b8d8c7..069f756bcf8 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -844,7 +844,7 @@ install-etc:
rm -f $${tmp}
tmp=etc/emacsclient.tmpdesktop; rm -f $${tmp}; \
client_name=`echo emacsclient | sed '$(TRANSFORM)'`${EXEEXT}; \
- sed -e "/^Exec=/ s|emacsclient|${bindir}/$${client_name}|" \
+ sed -e "/^Exec=/ s|emacsclient|${bindir}/$${client_name}|g" \
-e "/^Icon=emacs/ s/emacs/${EMACS_NAME}/" \
$(USE_STARTUP_NOTIFICATION_SED_CMD) \
$(USE_WAYLAND_DISPLAY_SED_CMD) \
--
2.42.0
--=-=-=--
Lin Jian <me@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#68803; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.