GNU bug report logs - #69084
30; check-declare-directory chokes on lock files

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 12 Feb 2024 19:55:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 12 14:55:23 2024
Received: from localhost ([127.0.0.1]:53928 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rZcOf-0006eI-RY
	for submit <at> debbugs.gnu.org; Mon, 12 Feb 2024 14:55:22 -0500
Received: from lists.gnu.org ([2001:470:142::17]:54190)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jonas@HIDDEN>) id 1rZbxq-0004Rr-I0
 for submit <at> debbugs.gnu.org; Mon, 12 Feb 2024 14:27:48 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <jonas@HIDDEN>) id 1rZbxP-00026w-SL
 for bug-gnu-emacs@HIDDEN; Mon, 12 Feb 2024 14:27:12 -0500
Received: from mail.hostpark.net ([212.243.197.30])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <jonas@HIDDEN>) id 1rZbxM-0005w6-5v
 for bug-gnu-emacs@HIDDEN; Mon, 12 Feb 2024 14:27:11 -0500
Received: from localhost (localhost [127.0.0.1])
 by mail.hostpark.net (Postfix) with ESMTP id E3B4E162D7
 for <bug-gnu-emacs@HIDDEN>; Mon, 12 Feb 2024 20:27:00 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h=
 content-type:content-type:mime-version:message-id:date:date
 :subject:subject:from:from; s=sel2011a; t=1707766020; bh=n3ZAzWz
 qu6oRIvOFngHMMulZMrtUf4hCOdQnfMRpC00=; b=dJn47OYhpNjhPSxCfgo/h3g
 XZVOEL3zGoArXmHTgtZzdafI3LluUW3OM5wV0NDFxnID5PI04a1vW/Zhlh/z12CM
 2VIfSx2sg291hREBiluFnD8kfs0tihWRvv5D73YuK0YHScGpQPshxGKqbm0c5WFv
 yxOonqgvqTJ3g5sWnADU=
X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net
Received: from mail.hostpark.net ([127.0.0.1])
 by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10224)
 with ESMTP id f0BABZsWACyd for <bug-gnu-emacs@HIDDEN>;
 Mon, 12 Feb 2024 20:27:00 +0100 (CET)
Received: from customer (localhost [127.0.0.1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest
 SHA256) (No client certificate requested)
 by mail.hostpark.net (Postfix) with ESMTPSA id B62BE162D5
 for <bug-gnu-emacs@HIDDEN>; Mon, 12 Feb 2024 20:26:59 +0100 (CET)
From: Jonas Bernoulli <jonas@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 30; check-declare-directory chokes on lock files
Date: Mon, 12 Feb 2024 20:26:57 +0100
Message-ID: <87ttmd32m6.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=212.243.197.30; envelope-from=jonas@HIDDEN;
 helo=mail.hostpark.net
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)

`check-declare-directory' chokes on lock files for libraries:

  check-declare-scan: Opening input file: No such file or directory,
    /home/jonas/.config/emacs/lib/forge/lisp/.#forge-pullreq.el

This simple change would take care of that:

diff --git a/lisp/emacs-lisp/check-declare.el b/lisp/emacs-lisp/check-declare.el
@@ -328,7 +328,7 @@ check-declare-directory
   (setq root (directory-file-name (file-relative-name root)))
   (or (file-directory-p root)
       (error "Directory `%s' not found" root))
-  (let ((files (directory-files-recursively root "\\.el\\'")))
+  (let ((files (directory-files-recursively root "\\`[^.].*\\.el\\'")))
     (when files
       (apply #'check-declare-files files))))

I am not sure this is acceptable as it would also skip over other hidden
files.  IMO that would be okay; libraries arguably shouldn't be hidden
files.

     Cheers,
     Jonas