GNU logs - #70318, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#70318] [PATCH] Fix unitentional creation of greeter's home directory
Resent-From: lgcoelho@HIDDEN
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 09 Apr 2024 23:59:01 +0000
Resent-Message-ID: <handler.70318.B.171270710927482 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 70318 <at> debbugs.gnu.org
MIME-Version: 1.0
Date: Wed, 10 Apr 2024 01:58:01 +0200
From: lgcoelho@HIDDEN
Message-ID: <c45600de103d560b3487772b103d7e4b@HIDDEN>
Content-Type: multipart/mixed;
 boundary="=_b2be8a9c679be404e8cacd0094788640"
Received-SPF: pass client-ip=178.21.23.139; envelope-from=lgcoelho@HIDDEN;
 helo=layka.disroot.org
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)

--=_b2be8a9c679be404e8cacd0094788640
Content-Type: multipart/alternative;
 boundary="=_ee4a58e70e1ca7de738a635b5b1fa09f"

--=_ee4a58e70e1ca7de738a635b5b1fa09f
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII;
 format=flowed

This patch adresses the unintentional creation of the greeter's home 
directory when using the greetd-service.
--=_ee4a58e70e1ca7de738a635b5b1fa09f
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset=UTF-8

<html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; charset=
=3DUTF-8" /></head><body style=3D'font-size: 10pt; font-family: Verdana,Gen=
eva,sans-serif'>
<p>This patch adresses the unintentional creation of the greeter's home dir=
ectory when using the greetd-service.</p>

</body></html>

--=_ee4a58e70e1ca7de738a635b5b1fa09f--

--=_b2be8a9c679be404e8cacd0094788640
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
 name=0001-services-base-Fix-unintentional-creation-of-greeter-.patch
Content-Disposition: attachment;
 filename=0001-services-base-Fix-unintentional-creation-of-greeter-.patch;
 size=1159

RnJvbSA0YmU1NWMyYjYzYzA1MGFlODM3ZTlhZmE3OTY5Y2ZiM2VlOGRmMWU1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMdWlzIEd1aWxoZXJtZSBDb2VsaG8gPGxnY29lbGhvQGRpc3Jv
b3Qub3JnPgpEYXRlOiBUdWUsIDkgQXByIDIwMjQgMjA6Mzg6MzMgLTAzMDAKU3ViamVjdDogW1BB
VENIXSBzZXJ2aWNlczogYmFzZTogRml4IHVuaW50ZW50aW9uYWwgY3JlYXRpb24gb2YgZ3JlZXRl
cidzIGhvbWUKIGRpcmVjdG9yeQoKKiBnbnUvc2VydmljZXMvYmFzZS5zY20gKGdyZWV0ZC1hY2Nv
dW50KSBbY3JlYXRlLWhvbWUtZGlyZWN0b3J5P106IFNldCB0byBmYWxzZS4KLS0tCiBnbnUvc2Vy
dmljZXMvYmFzZS5zY20gfCAyICsrCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspCgpk
aWZmIC0tZ2l0IGEvZ251L3NlcnZpY2VzL2Jhc2Uuc2NtIGIvZ251L3NlcnZpY2VzL2Jhc2Uuc2Nt
CmluZGV4IDNmOTEyMjI1YTAuLmIzOWI4NDE4ZWQgMTAwNjQ0Ci0tLSBhL2dudS9zZXJ2aWNlcy9i
YXNlLnNjbQorKysgYi9nbnUvc2VydmljZXMvYmFzZS5zY20KQEAgLTIxLDYgKzIxLDcgQEAKIDs7
OyBDb3B5cmlnaHQgwqkgMjAyMiBKdXN0aW4gVmVpbGxldXggPHRlcnJhbW9ycGhhQGNvY2subGk+
CiA7OzsgQ29weXJpZ2h0IMKpIDIwMjIgKCA8cGFyZW5AZGlzcm9vdC5vcmc+CiA7OzsgQ29weXJp
Z2h0IMKpIDIwMjMgQnJ1bm8gVmljdGFsIDxtaXJhaUBtYWtpbmF0YS5ldT4KKzs7OyBDb3B5cmln
aHQgwqkgMjAyNCBMdWlzIEd1aWxoZXJtZSBDb2VsaG8gPGxnY29lbGhvQGRpc3Jvb3Qub3JnPgog
Ozs7CiA7OzsgVGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIEd1aXguCiA7OzsKQEAgLTM0ODEsNiAr
MzQ4Miw3IEBAIChkZWZpbmUgKGdyZWV0ZC1hY2NvdW50cyBjb25maWcpCiAgICAgICAgICAobmFt
ZSAiZ3JlZXRlciIpCiAgICAgICAgICAoZ3JvdXAgImdyZWV0ZXIiKQogICAgICAgICAgKHN1cHBs
ZW1lbnRhcnktZ3JvdXBzIChncmVldGQtZ3JlZXRlci1zdXBwbGVtZW50YXJ5LWdyb3VwcyBjb25m
aWcpKQorICAgICAgICAgKGNyZWF0ZS1ob21lLWRpcmVjdG9yeT8gI2YpCiAgICAgICAgICAoc3lz
dGVtPyAjdCkpKSkKIAogKGRlZmluZSAobWFrZS1ncmVldGQtcGFtLW1vdW50LWNvbmYtZmlsZSBj
b25maWcpCi0tIAoyLjQxLjAKCg==
--=_b2be8a9c679be404e8cacd0094788640--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: lgcoelho@HIDDEN
Subject: bug#70318: Acknowledgement ([PATCH] Fix unitentional creation of
 greeter's home directory)
Message-ID: <handler.70318.B.171270710927482.ack <at> debbugs.gnu.org>
References: <c45600de103d560b3487772b103d7e4b@HIDDEN>
X-Gnu-PR-Message: ack 70318
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 70318 <at> debbugs.gnu.org
Date: Tue, 09 Apr 2024 23:59:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 70318 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
70318: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D70318
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#70318] [PATCH] Fix unitentional creation of greeter's home directory
Resent-From: muradm <mail@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 03 Jan 2025 18:06:01 +0000
Resent-Message-ID: <handler.70318.B70318.173592754425561 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: lgcoelho@HIDDEN
Cc: 70318 <at> debbugs.gnu.org
From: muradm <mail@HIDDEN>
In-Reply-To: <c45600de103d560b3487772b103d7e4b@HIDDEN>
 (lgcoelho@HIDDEN's message of "Wed, 10 Apr 2024 01:58:01 +0200")
References: <c45600de103d560b3487772b103d7e4b@HIDDEN>
User-Agent: mu4e 1.12.7; emacs 29.4
Date: Fri, 03 Jan 2025 21:05:34 +0300
Message-ID: <87msg73h8x.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--=-=-=
Content-Type: text/plain; format=flowed


This may break greeters which are more complex than agreety. For 
instance, gtkgreet/wlgreet run under sway. One of subdependencies 
is mesa, which will want to write shader caches somewhere. Another 
one is fontconfig, doing similar thing for fonts. There may be 
others, which hard to track and tune. Some could be impossible to 
tune at all.

lgcoelho@HIDDEN writes:

> This patch adresses the unintentional creation of the greeter's 
> home
> directory when using the greetd-service.
>
> [4. text/x-diff; 
> 0001-services-base-Fix-unintentional-creation-of-greeter-.patch]...

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEESPY5lma9A9l5HGLP6M7O0mLOBeIFAmd4Ju4ACgkQ6M7O0mLO
BeLJnw/6AxGjlNCGthwuCHs/m2PQXGH7BEH2dDUYwySbSKq6ZI1NRj+H+UG4ND2E
FE6HxrK++ifFNu1/iJQmxCgodmaKmyCJgVoS259AVqJqVuWwHRbPzeEWnETxKmYW
sKUUsgBgXRgP0cMujG+jvliQeg7elI42X5hbAUQUJs9F9b34LSHxQUhO371fOnLa
y5wjUYM84neUFPWmEykw09dBtlnyDwRLXjUH01ruElh2/QfPbOvQEvDdHshNOJkt
eCtkJdeg5L/IYTjiYnuaQOpgIoiHv1nN/63Fa6Qb0mDGXniuPAw/SS10CE1QLSGn
8/IDDnkiSVZI4IjuiKG4EQ6iQpC7a0hyS2rhuLP2DsM+Y2rIqzxDS/+zJLpiXFqn
T7uDZSqRhUxBXEo3IO52xjNbEOv0JaIghA+R+y20tBjs0OODhOukPMwNTK+YE5gH
NyDKadyJL/GGe7qgcUJG6t9JtsBXdq2bHeofaLd/60aB7cQnuZSdvpiazrl/PQfA
SI2OA7qjHJieG+1AMoJC3uYql3Cw/MOiqAQxXVoPpDDrHpq7BH5DOhyiQkRT7XWU
BzKy6RTj1c5vp7iyUmSvfgIS1wGiIWhxUEE6QuDSdZB1RSVv5XfMBWvfqNQ26ap6
inWzP7sx6OmzgHKvKndEc8j0m9lHM/dSjQyb+RoXNw9joFy6zfM=
=6z50
-----END PGP SIGNATURE-----
--=-=-=--

Message sent to guix-patches@HIDDEN:

Subject: [bug#70318] [PATCH] Fix unitentional creation of greeter's home directory
Resent-From: Nicolas Graves <ngraves@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 04 Jan 2025 14:08:03 +0000
Resent-Message-ID: <handler.70318.B70318.17359996235487 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: muradm <mail@HIDDEN>, lgcoelho@HIDDEN
Cc: 70318 <at> debbugs.gnu.org
From: Nicolas Graves <ngraves@HIDDEN>
In-Reply-To: <87msg73h8x.fsf@HIDDEN>
References: <c45600de103d560b3487772b103d7e4b@HIDDEN>
 <87msg73h8x.fsf@HIDDEN>
Date: Sat, 04 Jan 2025 15:06:56 +0100
Message-ID: <87o70mzn9b.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On 2025-01-03 21:05, muradm wrote:

> This may break greeters which are more complex than agreety. For 
> instance, gtkgreet/wlgreet run under sway. One of subdependencies 
> is mesa, which will want to write shader caches somewhere. Another 
> one is fontconfig, doing similar thing for fonts. There may be 
> others, which hard to track and tune. Some could be impossible to 
> tune at all.

Then maybe we can make it conditional on agreety?

If all greetd-configuration-terminals have their
greet-default-session-command being an greetd-agreety-session?, we could
set it to #f.

Something like this could work: 
(create-home-directory? (not (every greetd-agreety-session? (map greetd-default-session-command (greetd-configuration-terminals config)))))

WDYT?

-- 
Best regards,
Nicolas Graves

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#70318] [PATCH] Fix unitentional creation of greeter's home directory
Resent-From: muradm <mail@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 04 Jan 2025 15:06:02 +0000
Resent-Message-ID: <handler.70318.B70318.173600316018804 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70318
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Nicolas Graves <ngraves@HIDDEN>
Cc: 70318 <at> debbugs.gnu.org, lgcoelho@HIDDEN
Received: via spool by 70318-submit <at> debbugs.gnu.org id=B70318.173600316018804
          (code B ref 70318); Sat, 04 Jan 2025 15:06:02 +0000
Received: (at 70318) by debbugs.gnu.org; 4 Jan 2025 15:06:00 +0000
Received: from localhost ([127.0.0.1]:56653 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tU5iy-0004tE-C5
	for submit <at> debbugs.gnu.org; Sat, 04 Jan 2025 10:06:00 -0500
Received: from nomad-cl1.muradm.net ([139.162.159.157]:54644)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <mail@HIDDEN>) id 1tU5iw-0004sy-5i
 for 70318 <at> debbugs.gnu.org; Sat, 04 Jan 2025 10:05:58 -0500
Received: from localhost ([127.0.0.1]:53394)
 by nomad-cl1.muradm.net with esmtps (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.1)
 (envelope-from <mail@HIDDEN>) id 1tU5f7-0001rY-03;
 Sat, 04 Jan 2025 15:02:01 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=muradm.net; 
 s=mail;
 h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:
 Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
 Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
 :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
 List-Post:List-Owner:List-Archive;
 bh=6hVGgPUWIpzTqbDZmA1Qyf+TDNdpSZ6wdPo6uRN+kxQ=; b=NUVzax+4tOtUORiYw3t0qLvHrQ
 zJFbii90yGSA9ejElfATAbSDO9ErN8g6buMmBp2flA+7Jf9dsYKeInG29e2cQaWxtFGpPjJLPaQ2i
 oMZd1hKm7PeS5ou+kGOr9rUxXaLZY/PTTUQOk6j298akj6TdMTgze2bDaXastnK5VBoS9goB0H79I
 u4O6F+0lii0nj3Pouvwtz8hFq+86qnsPPCLh67R5FYD85e2PlOnaQ1G28RUNAQprxhThvENwJ4b6k
 3qmhL3wEqqZV4j2IPO8SeyNnoGCzSLNKCX5unF2N/ORyJ7f3Eo8+sBZBaHKuqPBO6/ZQ3RklxBxBm
 v0mvYkFfWQhQyfASIbob9D7vXNCmM7C2QCXZGJ9sHxFCPlqp1itSjYDlHWROpOo/ESwuxINHbXrpM
 qid17yP9BXWf7fu8/fwqTV5Izdae7YIzK/mRwZ4MR2kzt0r4vdsjNOvMOlymduzfnFUPAKxsjALpe
 DgKWiVNW5xly2JQy79czY/1h;
Received: from muradm by localhost with local (Exim 4.98)
 (envelope-from <mail@HIDDEN>) id 1tU5in-0000000037n-3vIh;
 Sat, 04 Jan 2025 18:05:49 +0300
From: muradm <mail@HIDDEN>
In-Reply-To: <87o70mzn9b.fsf@HIDDEN> (Nicolas Graves's message of "Sat, 04
 Jan 2025 15:06:56 +0100")
References: <c45600de103d560b3487772b103d7e4b@HIDDEN>
 <87msg73h8x.fsf@HIDDEN> <87o70mzn9b.fsf@HIDDEN>
User-Agent: mu4e 1.12.7; emacs 29.4
Date: Sat, 04 Jan 2025 18:05:49 +0300
Message-ID: <878qrqr54i.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha256; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain; format=flowed

Nicolas Graves <ngraves@HIDDEN> writes:

> On 2025-01-03 21:05, muradm wrote:
>
>> This may break greeters which are more complex than agreety. 
>> For
>> instance, gtkgreet/wlgreet run under sway. One of 
>> subdependencies
>> is mesa, which will want to write shader caches somewhere. 
>> Another
>> one is fontconfig, doing similar thing for fonts. There may be
>> others, which hard to track and tune. Some could be impossible 
>> to
>> tune at all.
>
> Then maybe we can make it conditional on agreety?
>
> If all greetd-configuration-terminals have their
> greet-default-session-command being an greetd-agreety-session?, 
> we could
> set it to #f.
>
> Something like this could work:
> (create-home-directory? (not (every greetd-agreety-session? (map 
> greetd-default-session-command (greetd-configuration-terminals 
> config)))))
>
> WDYT?

2 of 3 greeters needs home. With improvements implemented by 75270 
`greetd-terminal-configuration` is detached from details of its 
`default-session-command`. By this, any user can workout its 
greeter. If we hardcode implementation of greeter in terminal user 
may loose such flexibility. Also once you implement such 
condition, you will have to maintain with any other greeter added 
in the future.

One way would be to carry this flag into `greetd-configuration`, 
IMHO will uneccessarily complicate the things. Is there any good 
reason for doing that?

What is the problem with having home directory for greeter user?

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEESPY5lma9A9l5HGLP6M7O0mLOBeIFAmd5Tk0ACgkQ6M7O0mLO
BeKjzw//e5AxLqdhWHaCn4z5bwGvbwDh215TPN0o71iepJBY+0oxjAS5Hg7qUtsr
wjTIhBYfSYRLGJUxtX2lcr+XMJoZQ8caFGRL+wBSzLxU8Tsf8rqIAbB3dwMIpqlB
8Gh2X3ykhk+flvoQPRTxRyVf4I7U/B97BLdE2ddi/A7WjHxKZIz/CR5C8kJJqK69
pb3AFXEjWKOVsEbilPMymF6H3capYl2LjgphScAioDa9k8osvc8l+XuVtiRj/E9w
6jV2qDg+EkyB1pULvWeoZmrUY1mh4bh+USLA/2wFzElR8fUKaKI5fx5f4+vdtlbO
5g/iFLgDfnUrXGmkK5IQBIweKHW4fuN1X3lAWcZs0GufRZi2n00Xj7fc5WtvM5Sp
5b44dput7vdWvkAwb/QgODDAFALnkpmfuqHQ2OsL2+Wqk4jHsOf41o7sl8Z3Ss29
XdxhSX5Y7mvXMOuR3FNWCe5K5+x8CV7VJVXbXHsxnhhch5z8T7yi/Rsz7aVI2Mu8
MGOZfufhRPQgsJYnyLkARLqmwb2Smn7KuQLyQHf7HImLrBt16B7+pUQlufGANxpW
dzemK3m2Os1HrSBTvhfIMjXcEQ/XDYDjrnJk29vMDv1teAD/9W+fmR6BKArp74fo
YzNdnJQ61gEHvfUlsH44JDeMQugt2Kf2sGRnar5I5prelEzdQxw=
=qp6Y
-----END PGP SIGNATURE-----
--=-=-=--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#70318] [PATCH] Fix unitentional creation of greeter's home directory
Resent-From: muradm <mail@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 04 Jan 2025 17:10:01 +0000
Resent-Message-ID: <handler.70318.B70318.17360105539621 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70318
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Nicolas Graves <ngraves@HIDDEN>
Cc: 70318 <at> debbugs.gnu.org, lgcoelho@HIDDEN
Received: via spool by 70318-submit <at> debbugs.gnu.org id=B70318.17360105539621
          (code B ref 70318); Sat, 04 Jan 2025 17:10:01 +0000
Received: (at 70318) by debbugs.gnu.org; 4 Jan 2025 17:09:13 +0000
Received: from localhost ([127.0.0.1]:57003 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tU7eD-0002V6-2z
	for submit <at> debbugs.gnu.org; Sat, 04 Jan 2025 12:09:13 -0500
Received: from nomad-cl1.muradm.net ([139.162.159.157]:54966)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <mail@HIDDEN>) id 1tU7e7-0002UR-3S
 for 70318 <at> debbugs.gnu.org; Sat, 04 Jan 2025 12:09:10 -0500
Received: from localhost ([127.0.0.1]:49294)
 by nomad-cl1.muradm.net with esmtps (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.1)
 (envelope-from <mail@HIDDEN>) id 1tU7aH-0001vT-2S;
 Sat, 04 Jan 2025 17:05:09 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=muradm.net; 
 s=mail;
 h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:
 Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
 Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
 :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
 List-Post:List-Owner:List-Archive;
 bh=E39Rn3r8ZjzD3tN7A0cc7kqRWmA5d0OuIFm7g74Yarg=; b=KvT0aWmunX9QgPkxHhL7UZx+BR
 2Exdhl6S+NcaYvVO8+QOWOeoyaLmwDf7P6M2tnDcQC4Q1hiKx+PnZrkpID5ljvDYEtH49JSRzTUuV
 JHYLFSJH+S7cMPcr5qF47YscdQwkytdHB8HJKbcz1OuEqKNMdoGmxt8aexP+k7lofXSfREE0sd1iR
 thKJHcBN0G7zDFXI9XJOiSR7hd+++EuAm6jK0Cr59nBfsQ3RVtpQGybHV9M4chRPUjpYKdSG/DUQ1
 /SUzQMc7JYuqhfhAgsoXpoHCg2WgbigHEQzrGuZWnRf2yJbTi1AvtFprZxiPQZFsCBljZcuG5NOxC
 B30c3k1PxJhgfGju/TWoeNEoRCwPMyFZy/nmaDH76r/MJK+3WoHTbQmfZ3/zeqkHjW6n1+LZdjy0h
 o9K4yTFiodbTlzU38fs/Mr9DeZGWcQkTEHFrV7heIFug4gZDmVr/X+Sh8S/bsIy3v7GikOAuIUCAE
 TEgUfMyUNPVYK/TCLBHP136z;
Received: from muradm by localhost with local (Exim 4.98)
 (envelope-from <mail@HIDDEN>) id 1tU7dy-000000003uv-45Lp;
 Sat, 04 Jan 2025 20:08:58 +0300
From: muradm <mail@HIDDEN>
In-Reply-To: <878qrqr54i.fsf@HIDDEN> (muradm's message of "Sat, 04 Jan
 2025 18:05:49 +0300")
References: <c45600de103d560b3487772b103d7e4b@HIDDEN>
 <87msg73h8x.fsf@HIDDEN> <87o70mzn9b.fsf@HIDDEN>
 <878qrqr54i.fsf@HIDDEN>
User-Agent: mu4e 1.12.7; emacs 29.4
Date: Sat, 04 Jan 2025 20:08:58 +0300
Message-ID: <87zfk6o6ad.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha256; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain; format=flowed

muradm <mail@HIDDEN> writes:

>>
>> Then maybe we can make it conditional on agreety?
>>
>> If all greetd-configuration-terminals have their
>> greet-default-session-command being an greetd-agreety-session?, 
>> we
>> could
>> set it to #f.
>>
>> Something like this could work:
>> (create-home-directory? (not (every greetd-agreety-session? 
>> (map
>> greetd-default-session-command (greetd-configuration-terminals
>> config)))))
>>
>> WDYT?
>
> 2 of 3 greeters needs home. With improvements implemented by 
> 75270
> `greetd-terminal-configuration` is detached from details of its
> `default-session-command`. By this, any user can workout its 
> greeter.
> If we hardcode implementation of greeter in terminal user may 
> loose
> such flexibility. Also once you implement such condition, you 
> will
> have to maintain with any other greeter added in the future.
>
> One way would be to carry this flag into `greetd-configuration`, 
> IMHO
> will uneccessarily complicate the things. Is there any good 
> reason for
> doing that?
>
> What is the problem with having home directory for greeter user?

After some more meditation, I remembered that originally I also 
did not like idea of having extra user home directory and 
considering changes introduced by #75270, it became obvious that 
sway specific environment can be setup within 
`make-greetd-sway-greeter-command`. Further greeters may either 
improve on it, or provide their own entry point commands as they 
see fit. v2 of 75270 includes this change, and adjusts the 
environment accordingly. This issue can be closed in favor if 
75270.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEESPY5lma9A9l5HGLP6M7O0mLOBeIFAmd5ayoACgkQ6M7O0mLO
BeJVUxAA2h5kx1b+6EBOXS3RjhfUZEo8BqJjWxQtSCR0Oto3NpyidUb6aLjyk1Km
5TXpUst8f4Tuc1PPyCkVkT8rsQ/fh9ijx/JwtP7vWUiUBYC30OWVsfZOY8P6nTpb
eqb6e6i2qaJQySh5WY/djg+M43wMcIhwAw9/BKpA2De4PM5HrTXe0PG9XEUoiCyI
MF5v3uWLBqgB4WAC7l605SSqFdqHhub/dbX2oyHndORjO685eoRytHAUA1ITkP5W
uAX2oQ2bVjdtGENW67937Gl0/LR1RFRNku3oYlurNGfc3y7QTHxYdIfgFgFCRoKz
Wvl2QQby9xc1MAocszGmnUkbL6tUVB/w4/If2OfYBBO5eP1RCnEp04zI3Lfu5cT8
N6EiUK69654X+Mizng0ZMXlM6enzSBLkKS8qRNX7UkdHb3Fs+SdD9/smFbu6cxSr
CSkJHRcqB2Xx28tjCehmxwnxvoEhgIgUBwvtHHyvnFNxYv+tyTxwBIPzKzQBE+ZO
hPMN3oEnUhMUGRsfQDIN/lRLsKyzsE+Ly2+gJhaQTyP/TRZj4OZmptlqOVR0uICN
JcgooIo6elJwTeHjfRYA6dwfi43kHAxgyMXmmKLWF0s6qcMRrXi86UgoGGi5oY9F
xYuMP2ToyJkchGuKwjqEB9sZRxNu87fFNbHAL15wVkR9trnKBo8=
=TaIj
-----END PGP SIGNATURE-----
--=-=-=--

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 6 Feb 2025 13:34:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 06 08:34:03 2025
Received: from localhost ([127.0.0.1]:54848 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tg214-00050w-Qg
	for submit <at> debbugs.gnu.org; Thu, 06 Feb 2025 08:34:03 -0500
Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]:59634)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1tg211-00050L-W8; Thu, 06 Feb 2025 08:34:00 -0500
Received: by mail-pl1-x634.google.com with SMTP id
 d9443c01a7336-21f3e2b4eceso8525355ad.2; 
 Thu, 06 Feb 2025 05:33:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1738848833; x=1739453633; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=bVKThXPNBKNPZpxKFYL3600HPaNcrh/zsypfHJh4mKE=;
 b=CeraDLEwklKCU2I/snxnSe8dK32KoDozsThvuG4YAMZK6rS0If+z6Hdt/uyzDsfxQU
 yZRy6u9qri5ibnGs9iMRWmERm6+1qABiZuLXkO/AHGaezrgMnYNtWLEojA7jbp1ZIcGi
 /EycpNp34CFNiradocWrshCmDD7mE0qxzCfC+3tOK2oZYhfmTAR8hkpfP11Z32XDDLgT
 We1EHCRuu91O/DlaSjDUywlAtFCumDWcc+98RqjIEdMrb7aDR52iOhHLgFWwZUlldhwe
 G2S5PMYhnxD1haB3Jn2RUIf4vhDJE+KeC7+2rCxgNtarNfHicxK49K+SYAWeVBRVeoPd
 xLXw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1738848833; x=1739453633;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=bVKThXPNBKNPZpxKFYL3600HPaNcrh/zsypfHJh4mKE=;
 b=PDz4sb0x9utu8/osvpKugI5aTHXKHsXtTm/pafcsBzxSN5LVKZoUcqCfETac8fGkZt
 /WfBBgKU+BVdrouFuZfp0UckwsAP+v8KhadEijHNXUwhqkq8yhrkjL+SHc8w+2xmnwRb
 5fCPnHWGEbo2MPoHxA/5xM2QwLxhwYsLr6fdHH+pJsEzTWaH1foVWYNprlJ7mgORE9gS
 wVEvI+8B2cVDTTThxs3XATh1MKVhKxjf1dZ1+MA8PVvZTJYwpqI2TdxQ48FAAArgU+ft
 3JKTawsMixQ+sXgaNfRY+1C/Mba6f9kCBcKhibIUdEoMVp08q6vYUFMy9u2i/MTEa/xr
 n82A==
X-Forwarded-Encrypted: i=1;
 AJvYcCXp1TiaKSnD1QJQNcFQrbqAW7V8JsJoq+NpqWQrB4Yu0HdQ1Vxew/1py+ubGW9fduFbM9BPQhDs <at> debbugs.gnu.org
X-Gm-Message-State: AOJu0YyfBp/f1Vno7dLh0ORuwLWtiwu3i5lMeJx7R7VyS00Scbd/xIdc
 1HxaoiUFV/+RJLkWZeuEJ8vD4O35BGfWwC9SMpgxyo3jLyRw8u+8h2WoVw==
X-Gm-Gg: ASbGncssj2U+Z0DHYzPgtFSqoYUSc1SV+DXdltqTFKRQs1q0fNnkkVmWlfXsQcwvl7G
 8LQv7h9qdXDy/t34Znh7szbLuuBDBg5OYskmNUnGva+1I8bRTjQ1XpFlhR4sul9BBgyxmFbROzL
 oVtKuRE6JxcxvaPEkmcPhG3E1Dc54rXlYIuVGBPQcIXyBQA+rNvSkrIwhq3T+7QJvIpOEYRxD+o
 WErm0s5LcLssnsqZ0ug4zdfUuKA/K9Mms2aPqry/Hvtj5yodxSBZifxMWvf+nhsT+Jka42e1Bgi
 FKCu6cR/EZ2l
X-Google-Smtp-Source: AGHT+IGIUbX3V2eMRc7Fs0Iw90OyFDXhmKusy2/3PIiei2Wnlxy+oglieKpjP4FGgfgbpwX8klBw9A==
X-Received: by 2002:a05:6a20:cfa4:b0:1e0:c77c:450d with SMTP id
 adf61e73a8af0-1ede881140dmr14061824637.1.1738848833542; 
 Thu, 06 Feb 2025 05:33:53 -0800 (PST)
Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89])
 by smtp.gmail.com with ESMTPSA id
 d2e1a72fcca58-73048ad2688sm1265558b3a.47.2025.02.06.05.33.51
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 06 Feb 2025 05:33:53 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: muradm <mail@HIDDEN>
Subject: Re: [bug#75270] [PATCH v6 0/3] services: greetd: Improve greeter
 configurations.
In-Reply-To: <cover.1738760538.git.mail@HIDDEN> (muradm's message of "Wed, 
 5 Feb 2025 16:06:11 +0300")
References: <cover.1735771462.git.mail@HIDDEN>
 <cover.1738760538.git.mail@HIDDEN>
Date: Thu, 06 Feb 2025 22:33:40 +0900
Message-ID: <8734gr8aff.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, 75270 <at> debbugs.gnu.org,
 GNU Debbugs <control <at> debbugs.gnu.org>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

close 64112
close 65769
close 70605
close 70318
quit

Hi,

muradm <mail@HIDDEN> writes:

> Minor improvements and fixes compared to v5.
> Adds extra-shepherd-requirement.
>
> Improves greeter configuration and adds new gtkgreet greeter.
>
> Fixes: https://issues.guix.gnu.org/64112
> Fixes: https://issues.guix.gnu.org/65769
> Fixes: https://issues.guix.gnu.org/70605
> Obsoletes: https://issues.guix.gnu.org/70318

Pushed as commit 220ef58440. Thanks a lot for tackling these various
issues and for your patience during the review.

-- 
Thanks,
Maxim

Last modified: Thu, 6 Feb 2025 13:45:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.