Stefan Kangas <stefankangas@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 70577) by debbugs.gnu.org; 26 May 2024 07:14:44 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 26 03:14:44 2024 Received: from localhost ([127.0.0.1]:38237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sB85b-0006Nh-RX for submit <at> debbugs.gnu.org; Sun, 26 May 2024 03:14:44 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:53285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1sB85Z-0006NT-Kr for 70577 <at> debbugs.gnu.org; Sun, 26 May 2024 03:14:42 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id C5E0220004; Sun, 26 May 2024 07:14:26 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Dmitry Gutov <dmitry@HIDDEN> Subject: Re: bug#70577: [PATCH] New command other-project-prefix In-Reply-To: <5c377d02-d61b-4f9c-a34e-ef19b706b2de@HIDDEN> (Dmitry Gutov's message of "Sun, 26 May 2024 05:38:33 +0300") Organization: LINKOV.NET References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> <86jzkhe81b.fsf@HIDDEN> <208c7a05-6cfe-40c2-af54-187967348686@HIDDEN> <86le4tz88d.fsf@HIDDEN> <c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN> <865xvsjklh.fsf@HIDDEN> <c69a277b-0707-4305-aaee-905b24831623@HIDDEN> <861q6esvhl.fsf@HIDDEN> <b1e79441-aa0c-4f37-8af4-fc972810cbba@HIDDEN> <dedd9def-dfbd-46ac-91d0-15a9bb5bf0d1@HIDDEN> <938582b5-0f86-4cb0-8bfe-afb26af0e8c9@HIDDEN> <86eda4hpyh.fsf@HIDDEN> <1b247d37-d1da-462a-9582-f7f7ff689d8f@HIDDEN> <86fruja9bf.fsf@HIDDEN> <eaa0f9e8-4ed9-4c99-b7f5-28844a741283@HIDDEN> <86jzjneoju.fsf@HIDDEN> <c5f43df3-7d80-4452-9ca8-8efeb9ab89f6@HIDDEN> <86plte1jro.fsf@HIDDEN> <86fru9m8dq.fsf@HIDDEN> <5c377d02-d61b-4f9c-a34e-ef19b706b2de@HIDDEN> Date: Sun, 26 May 2024 09:52:37 +0300 Message-ID: <86bk4tdp22.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >>> - (eq this-command command)) >>> + (eq this-original-command command) >> Actually the real problem is that in project--other-place-prefix >> prefix-command-preserve-state changes this-command to last-command. > > This one might not be so bad (the idea, as documented, seems sensible). > > Changing this-read-command seems more suspect. > > But I guess it really means more checks would need to be done on > this-original-command instead. :-/ > > The (eq this-original-command command) check could probably be dropped, but > otherwise your addition looks good (I don't know any cases where > this-original-command would be wrong, though apparently there might be some > -- remappings of the prefix commands? seems an odd thing to do). > > It might also be possible to rewrite display-buffer-override-next-command > in a way that the installation of the "advice" (not actual advice in its > case) happens in pre-command-hook - then at that point the current command > hasn't had a chance to alter this-command. > > prefun would check whether it needs to be applied, if yet, add the cleanup > function to post-command-hook, and run the setup. The modification of > display-buffer-overriding-action might also be better done there, so it > doesn't alter any prompter UI in the next prefix command that might be > invoked. > > Not an urgent change, just something to consider. > > Have you had a chance to run with the modified patch a little? Any edge new > edge cases crop up? I tried to use the patch for a while, with and without this-original-command, but it often leaves the postfun hook in display-buffer-override-next-command active infinitely, thus needed to restart Emacs too often, so I just removed the patch without debugging what part causes this.
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 26 May 2024 02:38:53 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 25 22:38:53 2024 Received: from localhost ([127.0.0.1]:38078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sB3me-0007MX-OB for submit <at> debbugs.gnu.org; Sat, 25 May 2024 22:38:53 -0400 Received: from fout5-smtp.messagingengine.com ([103.168.172.148]:60385) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1sB3mb-0007MI-AQ for 70577 <at> debbugs.gnu.org; Sat, 25 May 2024 22:38:50 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfout.nyi.internal (Postfix) with ESMTP id A8FE01380066; Sat, 25 May 2024 22:38:35 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sat, 25 May 2024 22:38:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1716691115; x=1716777515; bh=pCdCnAdVI4kFPUlLWzsC5JWkaiC2XTjceJ5n3FYPLdU=; b= MyMa1Pz4jbJ04orohe3oRbtS7ArwANVftizDgEXo9/RYcfgj5g3XYWbDe7Qstk1z IVjbD16QgiIM7PwBpjt1Y8Ub+CKYzFqkOimmg1hMN3no2LmAt5HtkstPnFsIGRBq OOG38Z6zVl6UrYC1amvlGuroKswA47Eh2jFK8jyyl2u3/blqFtK42WQWuX6G0b0b 8XDKHS6oeu76S1C99vspEbb+RXqeV7e+05WAHWTXtTLFGakJqVQqDCcmA/hct60d kU0/PPJsZUHKwy6em7nmcF4mRaQBGNK1c7FnIIo4n17A/syc3ipB5/zQPKB94znA CkASREx1chEjheA/o6QVkA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1716691115; x= 1716777515; bh=pCdCnAdVI4kFPUlLWzsC5JWkaiC2XTjceJ5n3FYPLdU=; b=D GnYgd7PdvRW21dR9pe/eAkvLlemhIP3Qis2tUXRgxMgySzvjDOytjQakXN1hcFeo Z9R/DL4OoTf0VhBtYEqGc2bA74gKrLVg0iqpYJ0b85Efrnz2Vs7SFrPUGDeVTYOE YR4id3GKRKIx+W2ei+3e29oyyrsEPAYOeCFmTnSEEblS65twqutIbpem3jS897BL Unw7gEtKn7eK6weDw4jcukELn6B9OBE34F9ve3w4eP9S9Vmwf0Pbvk+KIk2mpf48 KGkZHpDrfUtBQjjDhAT7Wo30P34jukH/Y86WPki/TkjH/nzoNZOAsdZO/JELaFxt KGRjuCxkDyW5uGefYMsTQ== X-ME-Sender: <xms:q6BSZgtXud5qqVCLj3wbpb4E5YMrwggmH0FPHlTA7vpwy3i_6Qyafw> <xme:q6BSZtcNOGmtoc8p2tDbJ90f-Sv7E_-W58xP6osado8r96Pou0Z-49xc0O0h0i1rJ BZoMOp2kweIzQdHKGQ> X-ME-Received: <xmr:q6BSZrxm4VSxDtPWQ5eC5ly1JiU22Y1mSS8bs2a7UNXfWtxtNWloC8Kd7O4d1TKI1daw> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdejuddgiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepteduleejgeehtefgheegjeekueehvdevieekueeftddvtdevfefhvdevgedu jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: <xmx:q6BSZjMSeajIMabFKW5VNmtMDE4i_TOsF1YXvFkPzigWsneGOVGasA> <xmx:q6BSZg9WLr8b4bLpXmoe_qWHvag7ao0GTmzj2BS1EPo-FQ6pbW7beA> <xmx:q6BSZrW6xuCS7wkgFVuhHmSeA8ZX5ZWISH4y_GvSTFanYZ-FOKGWKw> <xmx:q6BSZpeu1cff-0mKTsDTsjWmlz2-3-5uhgkNT4bpxxVzdxOJk3BVqw> <xmx:q6BSZiJ2YupHEla_gWnLWOpuKLt_JZTkhJQwo-NuOgQYvMXEMB1DVJ4J> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 25 May 2024 22:38:34 -0400 (EDT) Message-ID: <5c377d02-d61b-4f9c-a34e-ef19b706b2de@HIDDEN> Date: Sun, 26 May 2024 05:38:33 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70577: [PATCH] New command other-project-prefix To: Juri Linkov <juri@HIDDEN> References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> <86jzkhe81b.fsf@HIDDEN> <208c7a05-6cfe-40c2-af54-187967348686@HIDDEN> <86le4tz88d.fsf@HIDDEN> <c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN> <865xvsjklh.fsf@HIDDEN> <c69a277b-0707-4305-aaee-905b24831623@HIDDEN> <861q6esvhl.fsf@HIDDEN> <b1e79441-aa0c-4f37-8af4-fc972810cbba@HIDDEN> <dedd9def-dfbd-46ac-91d0-15a9bb5bf0d1@HIDDEN> <938582b5-0f86-4cb0-8bfe-afb26af0e8c9@HIDDEN> <86eda4hpyh.fsf@HIDDEN> <1b247d37-d1da-462a-9582-f7f7ff689d8f@HIDDEN> <86fruja9bf.fsf@HIDDEN> <eaa0f9e8-4ed9-4c99-b7f5-28844a741283@HIDDEN> <86jzjneoju.fsf@HIDDEN> <c5f43df3-7d80-4452-9ca8-8efeb9ab89f6@HIDDEN> <86plte1jro.fsf@HIDDEN> <86fru9m8dq.fsf@HIDDEN> Content-Language: en-US From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <86fru9m8dq.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.3 (/) On 23/05/2024 09:24, Juri Linkov wrote: >> - (eq this-command command)) >> + (eq this-original-command command) > Actually the real problem is that in project--other-place-prefix > prefix-command-preserve-state changes this-command to last-command. This one might not be so bad (the idea, as documented, seems sensible). Changing this-read-command seems more suspect. But I guess it really means more checks would need to be done on this-original-command instead. :-/ The (eq this-original-command command) check could probably be dropped, but otherwise your addition looks good (I don't know any cases where this-original-command would be wrong, though apparently there might be some -- remappings of the prefix commands? seems an odd thing to do). It might also be possible to rewrite display-buffer-override-next-command in a way that the installation of the "advice" (not actual advice in its case) happens in pre-command-hook - then at that point the current command hasn't had a chance to alter this-command. prefun would check whether it needs to be applied, if yet, add the cleanup function to post-command-hook, and run the setup. The modification of display-buffer-overriding-action might also be better done there, so it doesn't alter any prompter UI in the next prefix command that might be invoked. Not an urgent change, just something to consider. Have you had a chance to run with the modified patch a little? Any edge new edge cases crop up?
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 23 May 2024 06:30:44 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 23 02:30:44 2024 Received: from localhost ([127.0.0.1]:58504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sA1yN-0007Gd-VL for submit <at> debbugs.gnu.org; Thu, 23 May 2024 02:30:44 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:35545) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1sA1yM-0007GU-2Q for 70577 <at> debbugs.gnu.org; Thu, 23 May 2024 02:30:42 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 02C52E0005; Thu, 23 May 2024 06:30:28 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Dmitry Gutov <dmitry@HIDDEN> Subject: Re: bug#70577: [PATCH] New command other-project-prefix In-Reply-To: <86plte1jro.fsf@HIDDEN> (Juri Linkov's message of "Wed, 22 May 2024 09:12:19 +0300") Organization: LINKOV.NET References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> <86jzkhe81b.fsf@HIDDEN> <208c7a05-6cfe-40c2-af54-187967348686@HIDDEN> <86le4tz88d.fsf@HIDDEN> <c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN> <865xvsjklh.fsf@HIDDEN> <c69a277b-0707-4305-aaee-905b24831623@HIDDEN> <861q6esvhl.fsf@HIDDEN> <b1e79441-aa0c-4f37-8af4-fc972810cbba@HIDDEN> <dedd9def-dfbd-46ac-91d0-15a9bb5bf0d1@HIDDEN> <938582b5-0f86-4cb0-8bfe-afb26af0e8c9@HIDDEN> <86eda4hpyh.fsf@HIDDEN> <1b247d37-d1da-462a-9582-f7f7ff689d8f@HIDDEN> <86fruja9bf.fsf@HIDDEN> <eaa0f9e8-4ed9-4c99-b7f5-28844a741283@HIDDEN> <86jzjneoju.fsf@HIDDEN> <c5f43df3-7d80-4452-9ca8-8efeb9ab89f6@HIDDEN> <86plte1jro.fsf@HIDDEN> Date: Thu, 23 May 2024 09:24:50 +0300 Message-ID: <86fru9m8dq.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) > - (eq this-command command)) > + (eq this-original-command command) Actually the real problem is that in project--other-place-prefix prefix-command-preserve-state changes this-command to last-command.
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.
Received: (at 70577) by debbugs.gnu.org; 22 May 2024 06:17:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 22 02:17:30 2024
Received: from localhost ([127.0.0.1]:53685 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1s9fI2-0006bk-0g
for submit <at> debbugs.gnu.org; Wed, 22 May 2024 02:17:30 -0400
Received: from relay6-d.mail.gandi.net ([217.70.183.198]:54859)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1s9fHx-0006bS-CI
for 70577 <at> debbugs.gnu.org; Wed, 22 May 2024 02:17:27 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id C2BA0C0006;
Wed, 22 May 2024 06:17:11 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Dmitry Gutov <dmitry@HIDDEN>
Subject: Re: bug#70577: [PATCH] New command other-project-prefix
In-Reply-To: <c5f43df3-7d80-4452-9ca8-8efeb9ab89f6@HIDDEN> (Dmitry Gutov's
message of "Tue, 21 May 2024 23:16:55 +0300")
Organization: LINKOV.NET
References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN>
<86le501ykg.fsf@HIDDEN>
<a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN>
<e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN>
<86jzkhe81b.fsf@HIDDEN>
<208c7a05-6cfe-40c2-af54-187967348686@HIDDEN>
<86le4tz88d.fsf@HIDDEN>
<c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN>
<865xvsjklh.fsf@HIDDEN>
<c69a277b-0707-4305-aaee-905b24831623@HIDDEN>
<861q6esvhl.fsf@HIDDEN>
<b1e79441-aa0c-4f37-8af4-fc972810cbba@HIDDEN>
<dedd9def-dfbd-46ac-91d0-15a9bb5bf0d1@HIDDEN>
<938582b5-0f86-4cb0-8bfe-afb26af0e8c9@HIDDEN>
<86eda4hpyh.fsf@HIDDEN>
<1b247d37-d1da-462a-9582-f7f7ff689d8f@HIDDEN>
<86fruja9bf.fsf@HIDDEN>
<eaa0f9e8-4ed9-4c99-b7f5-28844a741283@HIDDEN>
<86jzjneoju.fsf@HIDDEN>
<c5f43df3-7d80-4452-9ca8-8efeb9ab89f6@HIDDEN>
Date: Wed, 22 May 2024 09:12:19 +0300
Message-ID: <86plte1jro.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 70577
Cc: 70577 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
>> This works until I moved project-prompter to the beginning,
>> then 'C-x 5 p p' doesn't work with this:
>> (letrec ((root (funcall project-prompter))
>> (depth (minibuffer-depth))
>> (echofun (lambda () "[switch-project]"))
>> (around-fun
>> Maybe there is a better place?
>
> Last I checked, the project-prompter can change the value of this-command.
>
> Perhaps you can try a let-binding for this-command around the call to
> project-prompter, so that it's restored at the end.
This helps: (letrec ((root (let ((this-command this-command)) (funcall project-prompter)))
> Something to also be concerned about is having any of the display-buffer
> modifications, or other-project advices, get applied to one of the commands
> inside the project-prompter UI (if it's implemented using a sequence of
> commands). Perhaps I haven't triggered this case mostly by luck so far. How
> to guard against that? Maybe a dynamic variable of some sort. But then it'd
> also have to be checked uniformly in all such functions (hooks that prefix
> commands install).
This also helps:
diff --git a/lisp/window.el b/lisp/window.el
index 4147d7e6ebb..a4577d509b8 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -9252,7 +9279,7 @@ display-buffer-override-next-command
;; after the first display-buffer action (bug#39722).
(funcall clearfun)
new-window))))
- (command this-command)
+ (command this-original-command)
(echofun (when echo (lambda () echo)))
(exitfun
(lambda ()
@@ -9274,7 +9301,8 @@ display-buffer-override-next-command
(> (minibuffer-depth) minibuffer-depth)
;; But don't remove immediately after
;; adding the hook by the same command below.
- (eq this-command command))
+ (eq this-original-command command)
+ (get command 'prefix-command))
(funcall exitfun))))
;; Call post-function after the next command finishes (bug#49057).
(add-hook 'post-command-hook postfun)
But not sure about the latter, it might break some cases.
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 21 May 2024 20:17:14 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 21 16:17:14 2024 Received: from localhost ([127.0.0.1]:50985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s9Vv8-0005xm-1g for submit <at> debbugs.gnu.org; Tue, 21 May 2024 16:17:14 -0400 Received: from fout6-smtp.messagingengine.com ([103.168.172.149]:50555) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1s9Vv3-0005xb-4v for 70577 <at> debbugs.gnu.org; Tue, 21 May 2024 16:17:11 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.nyi.internal (Postfix) with ESMTP id 6020913814A1; Tue, 21 May 2024 16:16:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 21 May 2024 16:16:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1716322618; x=1716409018; bh=PQhUgrfFB0g6HPwYqWPUnvZ7dHDFsGjqMbFiBglNSd8=; b= GVzwReFTpe2KJOQngjFw0mIDsHTDgVUfDkavPTLxWXEdS268ci2Hc+CoNgZBndA+ Mn0urLRl8MJaujMHHUJ2wlYpYIC+RvPLrjsc9XatjueBeYIPmXLTlDHc7A59cTTz 4mjv0zJhlKTMbqcmK1/zVCu6he/731vhB3wjsmLwMsNvjSHIl0uM8BliqkYeKMzQ Srm2ZlOUwLNCMh6UmbKQB7KklSvqbWIHsaF5B8aSUzC0dblKvD7O2QVg/UFSkJey gd6YqsqLg8TS9JXFcMtqzXBmdWjxv/FQt3iNXjJ0HPVVCfdUZerg1YLifCTzREHy mx1xJ1HnRHyXhl+yyYWj/g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1716322618; x= 1716409018; bh=PQhUgrfFB0g6HPwYqWPUnvZ7dHDFsGjqMbFiBglNSd8=; b=e 1I+wIMMdOP40Et9kuLYpPBJrG0y23lhn2ESOj4c7TeN3U7aEyUHdW+RTACFWRw09 wEB/4ekpXG5x4KZq+xvezZ2BnuUcNn6ss9gzgZo4z7XdDvL9scY6+KlVJuXhxZQS yeJ1XqlUPVf3/kCQLLJwnzeM+VYcLdV83Pnl3/poQrDQ8O0bsMc5K0ji9buK8Esr Tme/fAa6/XF46zNzruOw4E1rzIrOAHAYglBmT4tS6HU9ake5gCR+HdPYkPQmOfA5 tjfbWPxlQ0cnwmNsr76cQX4qZh2pTfcgtLMygFduaLyEc1bxFKT44iQYQ85zancM sFpeeaEdoColQ03RrqBkg== X-ME-Sender: <xms:OgFNZojnBcQMz1ezpJf2fgNejx7ZTOGoRGAZLBARHJQq84xdOzyjeA> <xme:OgFNZhDh3W11nKvpEdGItJUovWtvmJp-tcYrXyRwkPBcRSrHAqPUQCht4e0cspYBB TsbDNXY9bEhpXm3Ho8> X-ME-Received: <xmr:OgFNZgGMzXHLRuIsE7p2H0Sie1fXe8Own17AopK1tfIpur8lj29Iud2efYxLWjd0HbYG> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdeivddgudeghecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomhepffhm ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg htthgvrhhnpeetudeljeegheetgfehgeejkeeuhedvveeikeeufedtvddtveefhfdvveeg udejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: <xmx:OgFNZpTuHFQM2Fn52hxNn7IG0igUIw1xwoPeL7xjrq8Jvo3uCni00A> <xmx:OgFNZlxRXlN7pbtfC29feGlAzGLjDP9-A1GtHozIwawAF8TovQ2k3g> <xmx:OgFNZn7o94XdvlkRqtzNxaew51pOBHkZI8gmr5pyAiFyxLe5n3jCVg> <xmx:OgFNZizDNNByojLBpKTmPeRd1nYypeg-vJ9iTe3kbgKH9AabiW7psQ> <xmx:OgFNZg-ux_YcLci8lpOhpqULMfx7C_5bjyMaOfaMc-UxmEEOkymiKtzH> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 21 May 2024 16:16:57 -0400 (EDT) Message-ID: <c5f43df3-7d80-4452-9ca8-8efeb9ab89f6@HIDDEN> Date: Tue, 21 May 2024 23:16:55 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70577: [PATCH] New command other-project-prefix To: Juri Linkov <juri@HIDDEN> References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> <86jzkhe81b.fsf@HIDDEN> <208c7a05-6cfe-40c2-af54-187967348686@HIDDEN> <86le4tz88d.fsf@HIDDEN> <c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN> <865xvsjklh.fsf@HIDDEN> <c69a277b-0707-4305-aaee-905b24831623@HIDDEN> <861q6esvhl.fsf@HIDDEN> <b1e79441-aa0c-4f37-8af4-fc972810cbba@HIDDEN> <dedd9def-dfbd-46ac-91d0-15a9bb5bf0d1@HIDDEN> <938582b5-0f86-4cb0-8bfe-afb26af0e8c9@HIDDEN> <86eda4hpyh.fsf@HIDDEN> <1b247d37-d1da-462a-9582-f7f7ff689d8f@HIDDEN> <86fruja9bf.fsf@HIDDEN> <eaa0f9e8-4ed9-4c99-b7f5-28844a741283@HIDDEN> <86jzjneoju.fsf@HIDDEN> Content-Language: en-US From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <86jzjneoju.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On 21/05/2024 09:08, Juri Linkov wrote: >> Here's a patch using symbol properties that makes the prefix commands work >> combined in arbitrary order. At least according to my limited testing - and >> only the commands that have this property set, of course. > > This works until I moved project-prompter to the beginning, > then 'C-x 5 p p' doesn't work with this: > > (letrec ((root (funcall project-prompter)) > (depth (minibuffer-depth)) > (echofun (lambda () "[switch-project]")) > (around-fun > > Maybe there is a better place? Last I checked, the project-prompter can change the value of this-command. Perhaps you can try a let-binding for this-command around the call to project-prompter, so that it's restored at the end. Something to also be concerned about is having any of the display-buffer modifications, or other-project advices, get applied to one of the commands inside the project-prompter UI (if it's implemented using a sequence of commands). Perhaps I haven't triggered this case mostly by luck so far. How to guard against that? Maybe a dynamic variable of some sort. But then it'd also have to be checked uniformly in all such functions (hooks that prefix commands install). >> Something to discuss: >> - A better name for the property? Maybe something longer would be more >> obvious for an accidental reader. > > If it makes sense to use it outside of project.el > then 'prefix-command' is fine. > >> - Applying it through 'declare' forms could be a more self-contained >> approach. > > This could be added later as well.
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.
Received: (at 70577) by debbugs.gnu.org; 21 May 2024 06:09:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 21 02:09:42 2024
Received: from localhost ([127.0.0.1]:47238 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1s9Igw-0003Fb-DJ
for submit <at> debbugs.gnu.org; Tue, 21 May 2024 02:09:42 -0400
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:45175)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1s9Igu-0003FP-6i
for 70577 <at> debbugs.gnu.org; Tue, 21 May 2024 02:09:41 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id 9ECE9E0003;
Tue, 21 May 2024 06:09:07 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Dmitry Gutov <dmitry@HIDDEN>
Subject: Re: bug#70577: [PATCH] New command other-project-prefix
In-Reply-To: <eaa0f9e8-4ed9-4c99-b7f5-28844a741283@HIDDEN> (Dmitry Gutov's
message of "Tue, 21 May 2024 05:31:28 +0300")
Organization: LINKOV.NET
References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN>
<86le501ykg.fsf@HIDDEN>
<a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN>
<e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN>
<86jzkhe81b.fsf@HIDDEN>
<208c7a05-6cfe-40c2-af54-187967348686@HIDDEN>
<86le4tz88d.fsf@HIDDEN>
<c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN>
<865xvsjklh.fsf@HIDDEN>
<c69a277b-0707-4305-aaee-905b24831623@HIDDEN>
<861q6esvhl.fsf@HIDDEN>
<b1e79441-aa0c-4f37-8af4-fc972810cbba@HIDDEN>
<dedd9def-dfbd-46ac-91d0-15a9bb5bf0d1@HIDDEN>
<938582b5-0f86-4cb0-8bfe-afb26af0e8c9@HIDDEN>
<86eda4hpyh.fsf@HIDDEN>
<1b247d37-d1da-462a-9582-f7f7ff689d8f@HIDDEN>
<86fruja9bf.fsf@HIDDEN>
<eaa0f9e8-4ed9-4c99-b7f5-28844a741283@HIDDEN>
Date: Tue, 21 May 2024 09:08:20 +0300
Message-ID: <86jzjneoju.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 70577
Cc: 70577 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
> Here's a patch using symbol properties that makes the prefix commands work
> combined in arbitrary order. At least according to my limited testing - and
> only the commands that have this property set, of course.
This works until I moved project-prompter to the beginning,
then 'C-x 5 p p' doesn't work with this:
(letrec ((root (funcall project-prompter))
(depth (minibuffer-depth))
(echofun (lambda () "[switch-project]"))
(around-fun
Maybe there is a better place?
> Something to discuss:
> - A better name for the property? Maybe something longer would be more
> obvious for an accidental reader.
If it makes sense to use it outside of project.el
then 'prefix-command' is fine.
> - Applying it through 'declare' forms could be a more self-contained
> approach.
This could be added later as well.
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 21 May 2024 02:31:46 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 20 22:31:45 2024 Received: from localhost ([127.0.0.1]:46331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s9FI1-00067O-8N for submit <at> debbugs.gnu.org; Mon, 20 May 2024 22:31:45 -0400 Received: from fout3-smtp.messagingengine.com ([103.168.172.146]:48941) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1s9FHy-00067G-16 for 70577 <at> debbugs.gnu.org; Mon, 20 May 2024 22:31:44 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfout.nyi.internal (Postfix) with ESMTP id A9D931381018; Mon, 20 May 2024 22:31:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 20 May 2024 22:31:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1716258691; x=1716345091; bh=JUeS5bIVdn 0H1C5TVefU9QO+mkFS3Y60GaGJMes5n+c=; b=T02wIBubT62v1i1q7ywQNZ+ImQ I3QVE2xRMtYSpgHcnDvUd5k9LPBjcnWFlk0qxlhQMVP6eq/Lqc8XHIBK8dDBLoCI gNh2lrTBighlNtKDYq2a9pVkPyKfR2tKzeMiw99DG62BQIKxTtOUY+7j9eG06pvq TQllyL4vPuctYiEiyeraC1uRx+KHxSTND1COh5nRs0i/33HTpGw8bByXKi554Lny KM87ME6wGBb1sWqiOMpi+c2gCfmeBKMjY17TsamVHY/KM4jzs6cZcuOZs4u5/3sP Qr/YTl0+AI3aIhmBT7GucqU0lvqy4DLxOYeMdKAg7kpNAsujw1f9cVmqOMQg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1716258691; x=1716345091; bh=JUeS5bIVdn0H1C5TVefU9QO+mkFS 3Y60GaGJMes5n+c=; b=OnprVe3r0tg3kpdP0rov0OdyEeIanHN+TzXx0Nfwx/FB DiOZ/naRhViKisMFRFUi/MObHEkEEYzUWVcXtKu3XhYkOw3KwOL0IOATgLqBQLgY bFrK54G0c9WcZVmycNHOIRSHq7Sw+fVXdruWC2V1DQ5TybbxetpKyTJSugCQXUk3 jFR7she/Vho9jhiVfFUbiQV582Jw165RZOzZXvdysHzz4bASYJf4w/djJ8GAo71D HGUe9O57rDtZw0lnMO+EQETVoGOam5foQJRwOzOESh5fjNZzFINSF5nlKEf7j3aY 6c82r7GraqIHuu1sIO6thnQqMPiFrLZOI+jCNN2/kA== X-ME-Sender: <xms:gwdMZileM8UHstJjBEbYF_GuxVUqPG8CrpnKJ2TDLDFroqDn-YGUPw> <xme:gwdMZp0JOsE7kTb4nmNMDUqOR9DJ7EYp4s2AmWGhms339c4zBh_Bt17Zs6vR1yJzR vAKZEW9TBMowtlKGjI> X-ME-Received: <xmr:gwdMZgp-dWQy0JzhPhgWjTtPRD-FoOSd-oqwyygVDNxuzu-F6L_m6ok7Q5kHMKgvYvHK> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdeiuddgheekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfkffggfgfuvfevfhfhjgesmhdtreertddvjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeelkeejiedvffdtgeejvdffffelueelkefhtdekjeehuefgteduheegfefhieek jeenucffohhmrghinhepghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpegumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: <xmx:gwdMZmkSX3fm9gm0twWHs5MjsYDxqCZLhg5dxzQdt5MumyQBjAxH5A> <xmx:gwdMZg3xFIEGJfEfkiMTRl7RpOoWlqDue_9ax5VddCwpmYHXhmTlog> <xmx:gwdMZtvsXsUC8TGdGdTeNxiqrCLwlMXoU21JO6tpOZKpHfPFjJ-x6Q> <xmx:gwdMZsUsuQgrJRvLRelDgKwDgydSj3FVPD9O1YnVjVEsHhstUSAj6g> <xmx:gwdMZuAyFkwC3s31NsSAjiojFqNfB5Y9LtL1NA8qUpMfgcTX9SMqqdg_> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 20 May 2024 22:31:30 -0400 (EDT) Content-Type: multipart/mixed; boundary="------------K2YGITU9lkG0JS8EmoH9ypBK" Message-ID: <eaa0f9e8-4ed9-4c99-b7f5-28844a741283@HIDDEN> Date: Tue, 21 May 2024 05:31:28 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70577: [PATCH] New command other-project-prefix To: Juri Linkov <juri@HIDDEN> References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> <86jzkhe81b.fsf@HIDDEN> <208c7a05-6cfe-40c2-af54-187967348686@HIDDEN> <86le4tz88d.fsf@HIDDEN> <c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN> <865xvsjklh.fsf@HIDDEN> <c69a277b-0707-4305-aaee-905b24831623@HIDDEN> <861q6esvhl.fsf@HIDDEN> <b1e79441-aa0c-4f37-8af4-fc972810cbba@HIDDEN> <dedd9def-dfbd-46ac-91d0-15a9bb5bf0d1@HIDDEN> <938582b5-0f86-4cb0-8bfe-afb26af0e8c9@HIDDEN> <86eda4hpyh.fsf@HIDDEN> <1b247d37-d1da-462a-9582-f7f7ff689d8f@HIDDEN> <86fruja9bf.fsf@HIDDEN> Content-Language: en-US From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <86fruja9bf.fsf@HIDDEN> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------K2YGITU9lkG0JS8EmoH9ypBK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 15/05/2024 09:46, Juri Linkov wrote: >>>> +(defvar other-project-prefix-transient-commands '(project-other-window-command >>>> + project-other-frame-command >>>> + project-other-tab-command >>>> + other-window-prefix >>>> + other-frame-prefix >>>> + other-tab-prefix) >>>> + "List of commands that `other-project-prefix' does not apply to. >>> This doesn't yet support such things as 'C-x 5 p p'? >> >> I'm not sure that other-project-prefix can do that. >> >> How does other-frame-prefix work? display-buffer-override-next-command sets >> up hooks in the very familiar fashion, so that the next command (and only >> the next command) is affected by a number of changed variables, which get >> restored after. >> >> I suppose other-project-prefix could learn all the new variables it needs >> to "carry on", look up their values, and set them additionally for the next >> command. But that seems very ad-hoc. >> >> It seems the "proper" way to fix that would be a cross-codebase change >> where all similar "prefix" commands themselves check whether the next >> command is a "prefix" command as well, and if so, keep the variables and >> hooks in place for the command after it. This would also mean moving the >> information from other-project-prefix-transient-commands to symbol >> properties (the alternative I've mentioned previously). > > In https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63648#95 > I made an unfinished attempt to handle this by: > > ``` > diff --git a/lisp/window.el b/lisp/window.el > index ab7dd5ced12..52ba407d9c8 100644 > --- a/lisp/window.el > +++ b/lisp/window.el > @@ -9099,7 +9091,8 @@ display-buffer-override-next-command > (> (minibuffer-depth) minibuffer-depth) > ;; But don't remove immediately after > ;; adding the hook by the same command below. > - (eq this-command command)) > + (eq this-command command) > + (memq this-command '(other-project-prefix))) > (funcall exitfun)))) > ;; Call post-function after the next command finishes (bug#49057). > (add-hook 'post-command-hook postfun) > ``` > > I'm not sure if this is a proper way, this needs more trial-and-error. Looks like you were thinking along similar lines. Here's a patch using symbol properties that makes the prefix commands work combined in arbitrary order. At least according to my limited testing - and only the commands that have this property set, of course. Something to discuss: - A better name for the property? Maybe something longer would be more obvious for an accidental reader. - Applying it through 'declare' forms could be a more self-contained approach. --------------K2YGITU9lkG0JS8EmoH9ypBK Content-Type: text/x-patch; charset=UTF-8; name="other-project-prefix-v6.diff" Content-Disposition: attachment; filename="other-project-prefix-v6.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvZnJhbWUuZWwgYi9saXNwL2ZyYW1lLmVsCmluZGV4IGQyMzc2 ZjFlMzM5Li4xZTE4ZDQxYWMzMSAxMDA2NDQKLS0tIGEvbGlzcC9mcmFtZS5lbAorKysgYi9s aXNwL2ZyYW1lLmVsCkBAIC0xMTA4LDYgKzExMDgsOCBAQCBvdGhlci1mcmFtZS1wcmVmaXgK ICAgIG5pbCAiW290aGVyLWZyYW1lXSIpCiAgIChtZXNzYWdlICJEaXNwbGF5IG5leHQgY29t bWFuZCBidWZmZXIgaW4gYSBuZXcgZnJhbWUuLi4iKSkKIAorKHB1dCAnb3RoZXItZnJhbWUt cHJlZml4ICdwcmVmaXgtY29tbWFuZCB0KQorCiAoZGVmdW4gaWNvbmlmeS1vci1kZWljb25p ZnktZnJhbWUgKCkKICAgIkljb25pZnkgdGhlIHNlbGVjdGVkIGZyYW1lLCBvciBkZWljb25p ZnkgaWYgaXQncyBjdXJyZW50bHkgYW4gaWNvbi4iCiAgIChpbnRlcmFjdGl2ZSkKZGlmZiAt LWdpdCBhL2xpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwgYi9saXNwL3Byb2dtb2Rlcy9wcm9q ZWN0LmVsCmluZGV4IGE5NWQxMjY3ZGQyLi43Mjk4ZmZlMTljOCAxMDA2NDQKLS0tIGEvbGlz cC9wcm9nbW9kZXMvcHJvamVjdC5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9wcm9qZWN0LmVs CkBAIC05MzQsNiArOTM0LDggQEAgcHJvamVjdC1vdGhlci13aW5kb3ctY29tbWFuZAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcHJvamVjdC1vdGhlci13aW5kb3ct bWFwKQogICAgIChwcm9qZWN0LS1vdGhlci1wbGFjZS1wcmVmaXggJ3dpbmRvdyBwcm9qZWN0 LW90aGVyLXdpbmRvdy1tYXApKSkKIAorKHB1dCAncHJvamVjdC1vdGhlci13aW5kb3ctY29t bWFuZCAncHJlZml4LWNvbW1hbmQgdCkKKwogOzs7IyMjYXV0b2xvYWQgKGRlZmluZS1rZXkg Y3RsLXgtNC1tYXAgInAiICMncHJvamVjdC1vdGhlci13aW5kb3ctY29tbWFuZCkKIAogOzs7 IyMjYXV0b2xvYWQKQEAgLTk1MCw2ICs5NTIsOCBAQCBwcm9qZWN0LW90aGVyLWZyYW1lLWNv bW1hbmQKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHByb2plY3Qtb3Ro ZXItZnJhbWUtbWFwKQogICAgIChwcm9qZWN0LS1vdGhlci1wbGFjZS1wcmVmaXggJ2ZyYW1l IHByb2plY3Qtb3RoZXItZnJhbWUtbWFwKSkpCiAKKyhwdXQgJ3Byb2plY3Qtb3RoZXItZnJh bWUtY29tbWFuZCAncHJlZml4LWNvbW1hbmQgdCkKKwogOzs7IyMjYXV0b2xvYWQgKGRlZmlu ZS1rZXkgY3RsLXgtNS1tYXAgInAiICMncHJvamVjdC1vdGhlci1mcmFtZS1jb21tYW5kKQog CiA7OzsjIyNhdXRvbG9hZApAQCAtOTY0LDEwICs5NjgsNTQgQEAgcHJvamVjdC1vdGhlci10 YWItY29tbWFuZAogICAgICAgKHByb2plY3QtLW90aGVyLXBsYWNlLWNvbW1hbmQgJygoZGlz cGxheS1idWZmZXItaW4tbmV3LXRhYikpKQogICAgIChwcm9qZWN0LS1vdGhlci1wbGFjZS1w cmVmaXggJ3RhYikpKQogCisocHV0ICdwcm9qZWN0LW90aGVyLXRhYi1jb21tYW5kICdwcmVm aXgtY29tbWFuZCB0KQorCiA7OzsjIyNhdXRvbG9hZAogKHdoZW4gKGJvdW5kLWFuZC10cnVl LXAgdGFiLXByZWZpeC1tYXApCiAgIChkZWZpbmUta2V5IHRhYi1wcmVmaXgtbWFwICJwIiAj J3Byb2plY3Qtb3RoZXItdGFiLWNvbW1hbmQpKQogCis7OzsjIyNhdXRvbG9hZAorKGRlZnVu IG90aGVyLXByb2plY3QtcHJlZml4ICgpCisgICJcIlN3aXRjaFwiIHRvIGFub3RoZXIgcHJv amVjdCBiZWZvcmUgcnVubmluZyBhbiBFbWFjcyBjb21tYW5kLgorVGhlIG5leHQgY29tbWFu ZCB5b3UgaW52b2tlIHdpbGwgcHJvbXB0IGZvciB0aGUgcHJvamVjdCBpbiB3aGljaCB0byBy dW4KK3RoZSBjb21tYW5kLiIKKyAgKGludGVyYWN0aXZlKQorICAocHJlZml4LWNvbW1hbmQt cHJlc2VydmUtc3RhdGUpCisgIChsZXRyZWMgKChkZXB0aCAobWluaWJ1ZmZlci1kZXB0aCkp CisgICAgICAgICAgIChlY2hvZnVuIChsYW1iZGEgKCkgIltzd2l0Y2gtcHJvamVjdF0iKSkK KyAgICAgICAgICAgKGFyb3VuZC1mdW4KKyAgICAgICAgICAgIChsYW1iZGEgKGNvbW1hbmQg JnJlc3QgX2FyZ3MpCisgICAgICAgICAgICAgIChpbnRlcmFjdGl2ZSkKKyAgICAgICAgICAg ICAgKGFkdmljZS1yZW1vdmUgdGhpcy1jb21tYW5kIGFyb3VuZC1mdW4pCisgICAgICAgICAg ICAgIChpZiAob3IgKGVxIHRoaXMtY29tbWFuZCAnb3RoZXItcHJvamVjdC1wcmVmaXgpCisg ICAgICAgICAgICAgICAgICAgICAgKGVxIGxhc3QtY29tbWFuZC1ldmVudCBoZWxwLWNoYXIp KQorICAgICAgICAgICAgICAgICAgKGNhbGwtaW50ZXJhY3RpdmVseSBjb21tYW5kKQorICAg ICAgICAgICAgICAgIChsZXQqICgodGhpcy1jb21tYW5kLXNhdmVkIHRoaXMtY29tbWFuZCkK KyAgICAgICAgICAgICAgICAgICAgICAgKHJvb3QgKGZ1bmNhbGwgcHJvamVjdC1wcm9tcHRl cikpKQorICAgICAgICAgICAgICAgICAgKGlmIChvciAoc3RyaW5nLXByZWZpeC1wICJwcm9q ZWN0LSIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoc3lt Ym9sLW5hbWUgdGhpcy1jb21tYW5kLXNhdmVkKSkKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgKGdldCB0aGlzLWNvbW1hbmQtc2F2ZWQgJ3Byb2plY3QtYXdhcmUpKQorICAgICAgICAg ICAgICAgICAgICAgIChsZXQgKChwcm9qZWN0LWN1cnJlbnQtZGlyZWN0b3J5LW92ZXJyaWRl IHJvb3QpKQorICAgICAgICAgICAgICAgICAgICAgICAgKGNhbGwtaW50ZXJhY3RpdmVseSBj b21tYW5kKSkKKyAgICAgICAgICAgICAgICAgICAgKGxldCAoKGRlZmF1bHQtZGlyZWN0b3J5 IHJvb3QpKQorICAgICAgICAgICAgICAgICAgICAgIChjYWxsLWludGVyYWN0aXZlbHkgY29t bWFuZCkpKSkpKSkKKyAgICAgICAgICAgKHByZWZ1bgorICAgICAgICAgICAgKGxhbWJkYSAo KQorICAgICAgICAgICAgICAodW5sZXNzIChvciAoPiAobWluaWJ1ZmZlci1kZXB0aCkgZGVw dGgpCisgICAgICAgICAgICAgICAgICAgICAgICAgIChnZXQgdGhpcy1jb21tYW5kICdwcmVm aXgtY29tbWFuZCkpCisgICAgICAgICAgICAgICAgKHJlbW92ZS1ob29rICdwcmUtY29tbWFu ZC1ob29rIHByZWZ1bikKKyAgICAgICAgICAgICAgICAocmVtb3ZlLWhvb2sgJ3ByZWZpeC1j b21tYW5kLWVjaG8ta2V5c3Ryb2tlcy1mdW5jdGlvbnMgZWNob2Z1bikKKyAgICAgICAgICAg ICAgICAod2hlbiAoYW5kIHRoaXMtY29tbWFuZCAoc3ltYm9scCB0aGlzLWNvbW1hbmQpKQor ICAgICAgICAgICAgICAgICAgKGFkdmljZS1hZGQgdGhpcy1jb21tYW5kIDphcm91bmQgYXJv dW5kLWZ1bikpKSkpKQorICAgIChhZGQtaG9vayAncHJlLWNvbW1hbmQtaG9vayBwcmVmdW4p CisgICAgKGFkZC1ob29rICdwcmVmaXgtY29tbWFuZC1lY2hvLWtleXN0cm9rZXMtZnVuY3Rp b25zIGVjaG9mdW4pCisgICAgKHNldC10cmFuc2llbnQtbWFwIHByb2plY3QtcHJlZml4LW1h cCkKKyAgICAobWVzc2FnZSAoY29uY2F0ICJUeXBlICIgKHByb2plY3QtLWtleW1hcC1wcm9t cHQpICIgb3IgYW55IGdsb2JhbCBrZXkiKSkpKQorCisocHV0ICdvdGhlci1wcm9qZWN0LXBy ZWZpeCAncHJlZml4LWNvbW1hbmQgdCkKKworOzsgKGRlZmluZS1rZXkgcHJvamVjdC1wcmVm aXgtbWFwIChrYmQgIlAiKSAjJ290aGVyLXByb2plY3QtcHJlZml4KQorCiAoZGVjbGFyZS1m dW5jdGlvbiBncmVwLXJlYWQtZmlsZXMgImdyZXAiKQogKGRlY2xhcmUtZnVuY3Rpb24geHJl Zi0tZmluZC1pZ25vcmVzLWFyZ3VtZW50cyAieHJlZiIpCiAKZGlmZiAtLWdpdCBhL2xpc3Av dGFiLWJhci5lbCBiL2xpc3AvdGFiLWJhci5lbAppbmRleCBkYWM1N2NlMjA3MC4uOWExNmQy MGJlNzMgMTAwNjQ0Ci0tLSBhL2xpc3AvdGFiLWJhci5lbAorKysgYi9saXNwL3RhYi1iYXIu ZWwKQEAgLTI4NTUsNiArMjg1NSw4IEBAIG90aGVyLXRhYi1wcmVmaXgKICAgIG5pbCAiW290 aGVyLXRhYl0iKQogICAobWVzc2FnZSAiRGlzcGxheSBuZXh0IGNvbW1hbmQgYnVmZmVyIGlu IGEgbmV3IHRhYi4uLiIpKQogCisocHV0ICdvdGhlci10YWItcHJlZml4ICdwcmVmaXgtY29t bWFuZCB0KQorCiAMCiA7OzsgU2hvcnQgYWxpYXNlcyBhbmQga2V5YmluZGluZ3MKIApkaWZm IC0tZ2l0IGEvbGlzcC93aW5kb3cuZWwgYi9saXNwL3dpbmRvdy5lbAppbmRleCA4ZmVlYmEw ZDgzZS4uN2QyYzdmOTk3N2QgMTAwNjQ0Ci0tLSBhL2xpc3Avd2luZG93LmVsCisrKyBiL2xp c3Avd2luZG93LmVsCkBAIC00MDQ0LDYgKzQwNDQsOCBAQCBvdGhlci13aW5kb3ctcHJlZml4 CiAgICBuaWwgIltvdGhlci13aW5kb3ddIikKICAgKG1lc3NhZ2UgIkRpc3BsYXkgbmV4dCBj b21tYW5kIGJ1ZmZlciBpbiBhIG5ldyB3aW5kb3cuLi4iKSkKIAorKHB1dCAnb3RoZXItd2lu ZG93LXByZWZpeCAncHJlZml4LWNvbW1hbmQgdCkKKwogKGRlZnVuIHNhbWUtd2luZG93LXBy ZWZpeCAoKQogICAiRGlzcGxheSB0aGUgYnVmZmVyIG9mIHRoZSBuZXh0IGNvbW1hbmQgaW4g dGhlIHNhbWUgd2luZG93LgogVGhlIG5leHQgYnVmZmVyIGlzIHRoZSBidWZmZXIgZGlzcGxh eWVkIGJ5IHRoZSBuZXh0IGNvbW1hbmQgaW52b2tlZApAQCAtOTI2OSw3ICs5MjcxLDggQEAg ZGlzcGxheS1idWZmZXItb3ZlcnJpZGUtbmV4dC1jb21tYW5kCiAJCSAgICAgKD4gKG1pbmli dWZmZXItZGVwdGgpIG1pbmlidWZmZXItZGVwdGgpCiAJCSAgICAgOzsgQnV0IGRvbid0IHJl bW92ZSBpbW1lZGlhdGVseSBhZnRlcgogCQkgICAgIDs7IGFkZGluZyB0aGUgaG9vayBieSB0 aGUgc2FtZSBjb21tYW5kIGJlbG93LgotCQkgICAgIChlcSB0aGlzLWNvbW1hbmQgY29tbWFu ZCkpCisgICAgICAgICAgICAgICAgICAgICAoZXEgdGhpcy1jb21tYW5kIGNvbW1hbmQpCisg ICAgICAgICAgICAgICAgICAgICAoZ2V0IHRoaXMtY29tbWFuZCAncHJlZml4LWNvbW1hbmQp KQogICAgICAgICAgICAgICAoZnVuY2FsbCBleGl0ZnVuKSkpKQogICAgIDs7IENhbGwgcG9z dC1mdW5jdGlvbiBhZnRlciB0aGUgbmV4dCBjb21tYW5kIGZpbmlzaGVzIChidWcjNDkwNTcp LgogICAgIChhZGQtaG9vayAncG9zdC1jb21tYW5kLWhvb2sgcG9zdGZ1bikK --------------K2YGITU9lkG0JS8EmoH9ypBK--
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.
Received: (at 70577) by debbugs.gnu.org; 15 May 2024 06:52:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 15 02:52:13 2024
Received: from localhost ([127.0.0.1]:41812 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1s78Um-0001lw-M7
for submit <at> debbugs.gnu.org; Wed, 15 May 2024 02:52:13 -0400
Received: from relay1-d.mail.gandi.net ([217.70.183.193]:38835)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1s78Ui-0001lW-BX
for 70577 <at> debbugs.gnu.org; Wed, 15 May 2024 02:52:10 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id 65156240009;
Wed, 15 May 2024 06:51:38 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Dmitry Gutov <dmitry@HIDDEN>
Subject: Re: bug#70577: [PATCH] New command other-project-prefix
In-Reply-To: <1b247d37-d1da-462a-9582-f7f7ff689d8f@HIDDEN> (Dmitry Gutov's
message of "Tue, 14 May 2024 23:02:51 +0300")
Organization: LINKOV.NET
References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN>
<86le501ykg.fsf@HIDDEN>
<a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN>
<e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN>
<86jzkhe81b.fsf@HIDDEN>
<208c7a05-6cfe-40c2-af54-187967348686@HIDDEN>
<86le4tz88d.fsf@HIDDEN>
<c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN>
<865xvsjklh.fsf@HIDDEN>
<c69a277b-0707-4305-aaee-905b24831623@HIDDEN>
<861q6esvhl.fsf@HIDDEN>
<b1e79441-aa0c-4f37-8af4-fc972810cbba@HIDDEN>
<dedd9def-dfbd-46ac-91d0-15a9bb5bf0d1@HIDDEN>
<938582b5-0f86-4cb0-8bfe-afb26af0e8c9@HIDDEN>
<86eda4hpyh.fsf@HIDDEN>
<1b247d37-d1da-462a-9582-f7f7ff689d8f@HIDDEN>
Date: Wed, 15 May 2024 09:46:52 +0300
Message-ID: <86fruja9bf.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 70577
Cc: 70577 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
>>> +(defvar other-project-prefix-transient-commands '(project-other-window-command
>>> + project-other-frame-command
>>> + project-other-tab-command
>>> + other-window-prefix
>>> + other-frame-prefix
>>> + other-tab-prefix)
>>> + "List of commands that `other-project-prefix' does not apply to.
>> This doesn't yet support such things as 'C-x 5 p p'?
>
> I'm not sure that other-project-prefix can do that.
>
> How does other-frame-prefix work? display-buffer-override-next-command sets
> up hooks in the very familiar fashion, so that the next command (and only
> the next command) is affected by a number of changed variables, which get
> restored after.
>
> I suppose other-project-prefix could learn all the new variables it needs
> to "carry on", look up their values, and set them additionally for the next
> command. But that seems very ad-hoc.
>
> It seems the "proper" way to fix that would be a cross-codebase change
> where all similar "prefix" commands themselves check whether the next
> command is a "prefix" command as well, and if so, keep the variables and
> hooks in place for the command after it. This would also mean moving the
> information from other-project-prefix-transient-commands to symbol
> properties (the alternative I've mentioned previously).
In https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63648#95
I made an unfinished attempt to handle this by:
```
diff --git a/lisp/window.el b/lisp/window.el
index ab7dd5ced12..52ba407d9c8 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -9099,7 +9091,8 @@ display-buffer-override-next-command
(> (minibuffer-depth) minibuffer-depth)
;; But don't remove immediately after
;; adding the hook by the same command below.
- (eq this-command command))
+ (eq this-command command)
+ (memq this-command '(other-project-prefix)))
(funcall exitfun))))
;; Call post-function after the next command finishes (bug#49057).
(add-hook 'post-command-hook postfun)
```
I'm not sure if this is a proper way, this needs more trial-and-error.
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 14 May 2024 20:03:07 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 14 16:03:07 2024 Received: from localhost ([127.0.0.1]:41226 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s6yMb-0004XS-20 for submit <at> debbugs.gnu.org; Tue, 14 May 2024 16:03:07 -0400 Received: from fout6-smtp.messagingengine.com ([103.168.172.149]:40285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1s6yMX-0004Wr-TV for 70577 <at> debbugs.gnu.org; Tue, 14 May 2024 16:03:04 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfout.nyi.internal (Postfix) with ESMTP id 76EBB138039B; Tue, 14 May 2024 16:02:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 14 May 2024 16:02:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1715716975; x=1715803375; bh=R6XMF+z/cXPuSdB8uPBgduzF0wFIc1MiHYZgAprZMIU=; b= M2F8eYZZi+aMQUL1tA0udVnhBrEjP35IJddeZW2m9EjeBRzAMtrfA5H8bdBZ3ecc ZZrdkGF1OLwcltjaJHyW6Zf6KIIxV1L5DW8nAJ0D/GCuug+UlQ6vZDs/a/N0peYf ub1jQriNe9DA+O2eMZE2NWwDtIkZ/I7Ss1dpw5TQoNwV7oYHxEUcHgIygOO3W7eI 25t+owHkHffZJApMeqdYDDQvzXkjVwA8vdSP4k214G0i8CJ+ENRbO5XhXVV5CPzL 1ESx/QJeUAw1luTi9PCiXJGu6ihjwlPczuXWHwei+JP/UufavLdR+WxtZVT9MKzY LtajWmHo6MPPGZl6gQLs1w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1715716975; x= 1715803375; bh=R6XMF+z/cXPuSdB8uPBgduzF0wFIc1MiHYZgAprZMIU=; b=N pVFf5MG1oJOiOxBT2IL5uoH5X7bpqXoZcpi9x90aDO7ATv9mEiIr2WopXLLSAx0x pp//QfpacareGOvNYSP0Ko9lWHbcl8AtCGw48i0ECiEYNP9lfuZQx8nQA6vavUSR 3+zM0SeoSpNdNHr1PYJN6cD9kDqH6Lc0o2l3RNs44a/oNhrNQCML6sdBs/f/EsmS JbGqnCLNIx8UKZBMPVXh48yirb+ZRGc3fa7dgJ8C+OB/a1MjM2nhaidKRhtc/OPP /R2xuMucFwRwkijuoDgBwGLDvIHuSEkOEAHki7TWdpJ4UdnfGzNDjZGyFQwaVadw TegVO0lF3ssGwrkAxd6Zw== X-ME-Sender: <xms:b8NDZn0BCBH1P5kmUR0eDxh-RiVP7sgMmtUeT5PpXyAdYhWtQuaJNw> <xme:b8NDZmEM8X7cPTsLPm2pBw3e19SOJ21E87S1hk6WToWIYqwx_BmYaBNLDgaemRVfv LslfTjrz9qQRxkEKFQ> X-ME-Received: <xmr:b8NDZn7DjRyUMkUIkcZUIBR57-9TTkPnrWjVgQyrzIi4wPF3n9pYl8Wfksqd69bUr8qR> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdegiedgudegfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomhepffhm ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg htthgvrhhnpeetudeljeegheetgfehgeejkeeuhedvveeikeeufedtvddtveefhfdvveeg udejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: <xmx:b8NDZs3cCkfxwq58rRMTSVmPbDm7n_N3zT5LaZBTjluOw02EMQeI4g> <xmx:b8NDZqH1P5HJNyHqEoWwopHD26BZMe5g9-ZxyXujGj46Q-JCHH3hyw> <xmx:b8NDZt_XPN6GLf8mGR_20_OHUF6j3ePUOXeubX_pSLjtB42SaE1o1g> <xmx:b8NDZnnVCyAQ6TuoelMrE6ILErURd23qIR249lfyDJ5RnT1nblPKkQ> <xmx:b8NDZvS13a67ewjDOIIjP0jJpwIUXEwcMG1zv8JvYFhxj9_a5kmyxaiB> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 14 May 2024 16:02:54 -0400 (EDT) Message-ID: <1b247d37-d1da-462a-9582-f7f7ff689d8f@HIDDEN> Date: Tue, 14 May 2024 23:02:51 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70577: [PATCH] New command other-project-prefix To: Juri Linkov <juri@HIDDEN> References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> <86jzkhe81b.fsf@HIDDEN> <208c7a05-6cfe-40c2-af54-187967348686@HIDDEN> <86le4tz88d.fsf@HIDDEN> <c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN> <865xvsjklh.fsf@HIDDEN> <c69a277b-0707-4305-aaee-905b24831623@HIDDEN> <861q6esvhl.fsf@HIDDEN> <b1e79441-aa0c-4f37-8af4-fc972810cbba@HIDDEN> <dedd9def-dfbd-46ac-91d0-15a9bb5bf0d1@HIDDEN> <938582b5-0f86-4cb0-8bfe-afb26af0e8c9@HIDDEN> <86eda4hpyh.fsf@HIDDEN> Content-Language: en-US From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <86eda4hpyh.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On 14/05/2024 09:23, Juri Linkov wrote: >>>> Speaking of the implementation strategy, though, I think the current >>>> other-project-prefix implementation still doesn't work well together >>>> with project-other-*-command. >>> I suppose we could just blacklist some known prefix commands (*) in the >>> same form where we now compare (eq this-command 'other-project-prefix), >>> but it would be nice to distinguish prefix commands from "real" ones >>> somehow. >>> (*) project-other-window-command, project-other-frame-command, >>> project-other-tab-command, some others? >> >> This can look like the attached. >> >> Though I suppose we would use some global registry, or symbol properties, >> or etc. >> >> +(defvar other-project-prefix-transient-commands '(project-other-window-command >> + project-other-frame-command >> + project-other-tab-command >> + other-window-prefix >> + other-frame-prefix >> + other-tab-prefix) >> + "List of commands that `other-project-prefix' does not apply to. > > This doesn't yet support such things as 'C-x 5 p p'? I'm not sure that other-project-prefix can do that. How does other-frame-prefix work? display-buffer-override-next-command sets up hooks in the very familiar fashion, so that the next command (and only the next command) is affected by a number of changed variables, which get restored after. I suppose other-project-prefix could learn all the new variables it needs to "carry on", look up their values, and set them additionally for the next command. But that seems very ad-hoc. It seems the "proper" way to fix that would be a cross-codebase change where all similar "prefix" commands themselves check whether the next command is a "prefix" command as well, and if so, keep the variables and hooks in place for the command after it. This would also mean moving the information from other-project-prefix-transient-commands to symbol properties (the alternative I've mentioned previously).
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 14 May 2024 06:25:57 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 14 02:25:57 2024 Received: from localhost ([127.0.0.1]:37356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s6lbp-0000RV-Hn for submit <at> debbugs.gnu.org; Tue, 14 May 2024 02:25:57 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:47405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1s6lbn-0000RP-Ag for 70577 <at> debbugs.gnu.org; Tue, 14 May 2024 02:25:56 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 0FB24FF80C; Tue, 14 May 2024 06:25:26 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Dmitry Gutov <dmitry@HIDDEN> Subject: Re: bug#70577: [PATCH] New command other-project-prefix In-Reply-To: <938582b5-0f86-4cb0-8bfe-afb26af0e8c9@HIDDEN> (Dmitry Gutov's message of "Sun, 12 May 2024 21:33:13 +0300") Organization: LINKOV.NET References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> <86jzkhe81b.fsf@HIDDEN> <208c7a05-6cfe-40c2-af54-187967348686@HIDDEN> <86le4tz88d.fsf@HIDDEN> <c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN> <865xvsjklh.fsf@HIDDEN> <c69a277b-0707-4305-aaee-905b24831623@HIDDEN> <861q6esvhl.fsf@HIDDEN> <b1e79441-aa0c-4f37-8af4-fc972810cbba@HIDDEN> <dedd9def-dfbd-46ac-91d0-15a9bb5bf0d1@HIDDEN> <938582b5-0f86-4cb0-8bfe-afb26af0e8c9@HIDDEN> Date: Tue, 14 May 2024 09:23:18 +0300 Message-ID: <86eda4hpyh.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >>> Speaking of the implementation strategy, though, I think the current >>> other-project-prefix implementation still doesn't work well together >>> with project-other-*-command. >> I suppose we could just blacklist some known prefix commands (*) in the >> same form where we now compare (eq this-command 'other-project-prefix), >> but it would be nice to distinguish prefix commands from "real" ones >> somehow. >> (*) project-other-window-command, project-other-frame-command, >> project-other-tab-command, some others? > > This can look like the attached. > > Though I suppose we would use some global registry, or symbol properties, > or etc. > > +(defvar other-project-prefix-transient-commands '(project-other-window-command > + project-other-frame-command > + project-other-tab-command > + other-window-prefix > + other-frame-prefix > + other-tab-prefix) > + "List of commands that `other-project-prefix' does not apply to. This doesn't yet support such things as 'C-x 5 p p'?
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 12 May 2024 18:33:29 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 12 14:33:29 2024 Received: from localhost ([127.0.0.1]:55810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s6E0l-0007k8-3t for submit <at> debbugs.gnu.org; Sun, 12 May 2024 14:33:29 -0400 Received: from wfhigh4-smtp.messagingengine.com ([64.147.123.155]:42231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1s6E0g-0007jy-Gj for 70577 <at> debbugs.gnu.org; Sun, 12 May 2024 14:33:26 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfhigh.west.internal (Postfix) with ESMTP id 6706718000AD; Sun, 12 May 2024 14:33:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 12 May 2024 14:33:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1715538796; x=1715625196; bh=9vTMYLncLI mM9z7pt+7zv4Lq2i5yoFIUQ/n3+/3H5Gs=; b=k+ljeRuhnpyufFqBlvZ5WFrd3K e+ObXGSiki2lWefOUvd1eLFArii+nCMQ0yt+LCFA71+NekwFhGAabxtAq5gqadib NsDxyMr3Oh5Fcx2co+K32sk7dfM6Eg9Nl+KIIrzc+/NzVOujvpacopNDKbqkq9b5 oPczpBWjqTucJLpp8Rn6bhzfDtaqF+3jjtPs95R4XqK44oIZAKV6ElPW1Yf6Zi0/ SmYQeg3XM3QQKKMeuTajRLUeTL2b72oqKgnF8P/GAOLCNBdH6jZIHBWk3CPCUpb4 zarBRspXyCgXJK2d+2oDcshi1YW9NW3lfZjc3dmgc1rYQn61IP2EbVYqmZaA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1715538796; x=1715625196; bh=9vTMYLncLImM9z7pt+7zv4Lq2i5y oFIUQ/n3+/3H5Gs=; b=G0IGyB0d7TGlB1E5BKfwh5vBwpwtKSWNYmn9pbyeJJAT BJGRTpijUFNA6pbEcF4xbzSSmSp8sJAqh21xOzGEQ18HtEOTsNKVjvTVCkVB3I0d yj6ks3jhbbXHGsrflDW0AdadSdF+Ubd3M4RIz4ZhaajMB18lc5AxIRXDYnwC0Ssv z1V84zK1NAGhLReTOTgdJmmJnfqfRPOpAp1jFzSda8CIuqAfDdFtvCczLax8p3l0 a5E9KwYs5jzSuIdZOQf4A9l9BF5unRZYFZpX/ncyvE5MHhwpaTF73wP/waL/G/I/ xJk9eanT+CQwsWawbURJ0gS6211C/8qjCZ+12+Bnqg== X-ME-Sender: <xms:awtBZpXLSZry_ss23VMrFByFRAbLdrHm1mp_7XDZjmL6XeyKBcZo-g> <xme:awtBZpmopSlZ8LL9q4PNpX5aQAaIZY78QZOzIEKYJxTEWgAk2CAy5dp52wYoOfnBh LqOs2W9OUnMK9MQNWY> X-ME-Received: <xmr:awtBZlaXbqNCHNo_vneMZQSU__wAH18I3m_9rOc7ITX-qnHDhkvdXZ-D1lhpZCnK0rCH> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdegvddguddvhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpegtkfffgggfuffhvfevfhgjsehmtderredtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnheptddvueegvdetledvgeevgfeutdfgteehgfegffektdekgeevieefiedujeeu ffffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: <xmx:awtBZsUfOU40iY9HkdlcasvQBawlywuNFsro0m95OaMzhE7a51lPdA> <xmx:awtBZjlJvfzwBlVbnutiE0VZNqMogNkVV7tvFijNbIpUmJo7ZOtErA> <xmx:awtBZpf_0xuvMVjK-E_SfJFqomHwftSJDE5fJt1B8M_vi0gaFDKaWA> <xmx:awtBZtEOt1S1gTMS1lBThkPyI1ZCdhX-iBejIoD7uJ2z8TE0m-86Pw> <xmx:bAtBZozk6N1Th20u5PKSEtB9HfHIBHIsOC-iBZnxSPYnJxlbCaOmFRpI> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 12 May 2024 14:33:15 -0400 (EDT) Content-Type: multipart/mixed; boundary="------------J0q3PDrSERCiwFjjNSXwSF0j" Message-ID: <938582b5-0f86-4cb0-8bfe-afb26af0e8c9@HIDDEN> Date: Sun, 12 May 2024 21:33:13 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70577: [PATCH] New command other-project-prefix From: Dmitry Gutov <dmitry@HIDDEN> To: Juri Linkov <juri@HIDDEN> References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> <86jzkhe81b.fsf@HIDDEN> <208c7a05-6cfe-40c2-af54-187967348686@HIDDEN> <86le4tz88d.fsf@HIDDEN> <c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN> <865xvsjklh.fsf@HIDDEN> <c69a277b-0707-4305-aaee-905b24831623@HIDDEN> <861q6esvhl.fsf@HIDDEN> <b1e79441-aa0c-4f37-8af4-fc972810cbba@HIDDEN> <dedd9def-dfbd-46ac-91d0-15a9bb5bf0d1@HIDDEN> Content-Language: en-US In-Reply-To: <dedd9def-dfbd-46ac-91d0-15a9bb5bf0d1@HIDDEN> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------J0q3PDrSERCiwFjjNSXwSF0j Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09/05/2024 05:22, Dmitry Gutov wrote: > On 07/05/2024 22:16, Dmitry Gutov wrote: >> Speaking of the implementation strategy, though, I think the current >> other-project-prefix implementation still doesn't work well together >> with project-other-*-command. > > I suppose we could just blacklist some known prefix commands (*) in the > same form where we now compare (eq this-command 'other-project-prefix), > but it would be nice to distinguish prefix commands from "real" ones > somehow. > > (*) project-other-window-command, project-other-frame-command, > project-other-tab-command, some others? This can look like the attached. Though I suppose we would use some global registry, or symbol properties, or etc. --------------J0q3PDrSERCiwFjjNSXwSF0j Content-Type: text/x-patch; charset=UTF-8; name="other-project-prefix-v5.diff" Content-Disposition: attachment; filename="other-project-prefix-v5.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwgYi9saXNwL3Byb2dtb2Rl cy9wcm9qZWN0LmVsCmluZGV4IGE5NWQxMjY3ZGQyLi4xM2U5ZDJjOGE5NiAxMDA2NDQKLS0t IGEvbGlzcC9wcm9nbW9kZXMvcHJvamVjdC5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9wcm9q ZWN0LmVsCkBAIC05NjgsNiArOTY4LDU4IEBAIHByb2plY3Qtb3RoZXItdGFiLWNvbW1hbmQK ICh3aGVuIChib3VuZC1hbmQtdHJ1ZS1wIHRhYi1wcmVmaXgtbWFwKQogICAoZGVmaW5lLWtl eSB0YWItcHJlZml4LW1hcCAicCIgIydwcm9qZWN0LW90aGVyLXRhYi1jb21tYW5kKSkKIAor KGRlZnZhciBvdGhlci1wcm9qZWN0LXByZWZpeC10cmFuc2llbnQtY29tbWFuZHMgJyhwcm9q ZWN0LW90aGVyLXdpbmRvdy1jb21tYW5kCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHByb2plY3Qtb3RoZXItZnJhbWUtY29tbWFuZAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwcm9qZWN0 LW90aGVyLXRhYi1jb21tYW5kCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIG90aGVyLXdpbmRvdy1wcmVmaXgKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgb3RoZXItZnJhbWUtcHJlZml4Cisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG90aGVy LXRhYi1wcmVmaXgpCisgICJMaXN0IG9mIGNvbW1hbmRzIHRoYXQgYG90aGVyLXByb2plY3Qt cHJlZml4JyBkb2VzIG5vdCBhcHBseSB0by4KKworTWVhbmluZywgaXRzIGVmZmVjdCB3aWxs IGFwcGx5IHRvIHRoZSBmaXJzdCBuZXh0IGNvbW1hbmQgdGhhdCBpcyBub3QgaW4KK3RoaXMg bGlzdC4gIFlvdSB3b3VsZCB0eXBpY2FsbHkgc3BlY2lmeSBcInByZWZpeFwiIGNvbW1hbmRz IGhlcmUsIG9uZXMKK3RoYXQgYWxzbyBhcHBseSBzb21lIG1vZGlmaWNhdGlvbiB0byB0aGUg Zm9sbG93aW5nIGNvbW1hbmQncyBiZWhhdmlvci4iKQorCis7OzsjIyNhdXRvbG9hZAorKGRl ZnVuIG90aGVyLXByb2plY3QtcHJlZml4ICgpCisgICJcIlN3aXRjaFwiIHRvIGFub3RoZXIg cHJvamVjdCBiZWZvcmUgcnVubmluZyBhbiBFbWFjcyBjb21tYW5kLgorVGhlIG5leHQgY29t bWFuZCB5b3UgaW52b2tlIHdpbGwgcHJvbXB0IGZvciB0aGUgcHJvamVjdCBpbiB3aGljaCB0 byBydW4KK3RoZSBjb21tYW5kLiIKKyAgKGludGVyYWN0aXZlKQorICAocHJlZml4LWNvbW1h bmQtcHJlc2VydmUtc3RhdGUpCisgIChsZXRyZWMgKChkZXB0aCAobWluaWJ1ZmZlci1kZXB0 aCkpCisgICAgICAgICAgIChlY2hvZnVuIChsYW1iZGEgKCkgIltzd2l0Y2gtcHJvamVjdF0i KSkKKyAgICAgICAgICAgKGFyb3VuZC1mdW4KKyAgICAgICAgICAgIChsYW1iZGEgKGNvbW1h bmQgJnJlc3QgX2FyZ3MpCisgICAgICAgICAgICAgIChpbnRlcmFjdGl2ZSkKKyAgICAgICAg ICAgICAgKGFkdmljZS1yZW1vdmUgdGhpcy1jb21tYW5kIGFyb3VuZC1mdW4pCisgICAgICAg ICAgICAgIChpZiAob3IgKGVxIHRoaXMtY29tbWFuZCAnb3RoZXItcHJvamVjdC1wcmVmaXgp CisgICAgICAgICAgICAgICAgICAgICAgKGVxIGxhc3QtY29tbWFuZC1ldmVudCBoZWxwLWNo YXIpKQorICAgICAgICAgICAgICAgICAgKGNhbGwtaW50ZXJhY3RpdmVseSBjb21tYW5kKQor ICAgICAgICAgICAgICAgIChsZXQqICgodGhpcy1jb21tYW5kLXNhdmVkIHRoaXMtY29tbWFu ZCkKKyAgICAgICAgICAgICAgICAgICAgICAgKHJvb3QgKGZ1bmNhbGwgcHJvamVjdC1wcm9t cHRlcikpKQorICAgICAgICAgICAgICAgICAgKGlmIChvciAoc3RyaW5nLXByZWZpeC1wICJw cm9qZWN0LSIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAo c3ltYm9sLW5hbWUgdGhpcy1jb21tYW5kLXNhdmVkKSkKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgKGdldCB0aGlzLWNvbW1hbmQtc2F2ZWQgJ3Byb2plY3QtYXdhcmUpKQorICAgICAg ICAgICAgICAgICAgICAgIChsZXQgKChwcm9qZWN0LWN1cnJlbnQtZGlyZWN0b3J5LW92ZXJy aWRlIHJvb3QpKQorICAgICAgICAgICAgICAgICAgICAgICAgKGNhbGwtaW50ZXJhY3RpdmVs eSBjb21tYW5kKSkKKyAgICAgICAgICAgICAgICAgICAgKGxldCAoKGRlZmF1bHQtZGlyZWN0 b3J5IHJvb3QpKQorICAgICAgICAgICAgICAgICAgICAgIChjYWxsLWludGVyYWN0aXZlbHkg Y29tbWFuZCkpKSkpKSkKKyAgICAgICAgICAgKHByZWZ1bgorICAgICAgICAgICAgKGxhbWJk YSAoKQorICAgICAgICAgICAgICAodW5sZXNzIChvciAoPiAobWluaWJ1ZmZlci1kZXB0aCkg ZGVwdGgpCisgICAgICAgICAgICAgICAgICAgICAgICAgIChtZW1xIHRoaXMtY29tbWFuZCBv dGhlci1wcm9qZWN0LXByZWZpeC10cmFuc2llbnQtY29tbWFuZHMpKQorICAgICAgICAgICAg ICAgIChyZW1vdmUtaG9vayAncHJlLWNvbW1hbmQtaG9vayBwcmVmdW4pCisgICAgICAgICAg ICAgICAgKHJlbW92ZS1ob29rICdwcmVmaXgtY29tbWFuZC1lY2hvLWtleXN0cm9rZXMtZnVu Y3Rpb25zIGVjaG9mdW4pCisgICAgICAgICAgICAgICAgKHdoZW4gKGFuZCB0aGlzLWNvbW1h bmQgKHN5bWJvbHAgdGhpcy1jb21tYW5kKSkKKyAgICAgICAgICAgICAgICAgIChhZHZpY2Ut YWRkIHRoaXMtY29tbWFuZCA6YXJvdW5kIGFyb3VuZC1mdW4pKSkpKSkKKyAgICAoYWRkLWhv b2sgJ3ByZS1jb21tYW5kLWhvb2sgcHJlZnVuKQorICAgIChhZGQtaG9vayAncHJlZml4LWNv bW1hbmQtZWNoby1rZXlzdHJva2VzLWZ1bmN0aW9ucyBlY2hvZnVuKQorICAgIChzZXQtdHJh bnNpZW50LW1hcCBwcm9qZWN0LXByZWZpeC1tYXApCisgICAgKG1lc3NhZ2UgKGNvbmNhdCAi VHlwZSAiIChwcm9qZWN0LS1rZXltYXAtcHJvbXB0KSAiIG9yIGFueSBnbG9iYWwga2V5Iikp KSkKKworOzsgKGRlZmluZS1rZXkgcHJvamVjdC1wcmVmaXgtbWFwIChrYmQgIlAiKSAjJ290 aGVyLXByb2plY3QtcHJlZml4KQorCiAoZGVjbGFyZS1mdW5jdGlvbiBncmVwLXJlYWQtZmls ZXMgImdyZXAiKQogKGRlY2xhcmUtZnVuY3Rpb24geHJlZi0tZmluZC1pZ25vcmVzLWFyZ3Vt ZW50cyAieHJlZiIpCiAK --------------J0q3PDrSERCiwFjjNSXwSF0j--
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 10 May 2024 15:10:00 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 10 11:10:00 2024 Received: from localhost ([127.0.0.1]:42520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s5Rsl-0003IT-PJ for submit <at> debbugs.gnu.org; Fri, 10 May 2024 11:10:00 -0400 Received: from wfout2-smtp.messagingengine.com ([64.147.123.145]:33635) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1s5Rsj-0003IE-0I for 70577 <at> debbugs.gnu.org; Fri, 10 May 2024 11:09:58 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfout.west.internal (Postfix) with ESMTP id 5C8451C000FB; Fri, 10 May 2024 11:09:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 10 May 2024 11:09:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1715353792; x=1715440192; bh=V9f0ykDml2zCVnQMChWoQYwukoQSfnR59n5U3d8swgg=; b= TEFc3HyVcx2UyZ1t5rkrIkCdoSt5+gVXAVQC6Xy5LPSex7h+XwswwyZI5eWl6S0E BHlAJlGshqgKZipaE7DcSEzwheggXksPRRrjAdpWTwVZt4SbUnQ4UdKIzVDdAL2U QuyAZ9ZNd7SHC6J9KMj34k8NC4B4BK6nZvxl63EwYNFhe77MBcmAk6LNOs388I4q 9d0RYsqmvljCVnKMbyZ+z5YWDVYu9Bq8LF9WquJ2yyhk47qKabR/nuawS2d79g3h U9Zr6U+MNWLjg9wsQCVAJDCZAnFVon/RG+QTBezlOdLhLPZ4kL5Ay1m7xpaW7U/Z 85rqSurtjDVFVMUo5G1kCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1715353792; x= 1715440192; bh=V9f0ykDml2zCVnQMChWoQYwukoQSfnR59n5U3d8swgg=; b=X ieMlqG2bk+f6fvF3UhghrBMEi0CJbfdyQNTogGf3US+xa9UjBB3rr1gO2L3Hivnj YFrz1hcc//029x+9Uq/NV6VPW9JtK8R/bqmZyL5+YEuLojUnpsysOxCHPBlVKeGA F26pfHq5vpvxrJGXWRoxqeQMNOaShoZM5gJ7uAm84zHRLt4JeCmxXrUxubvyF1oa HpuNxC//lWKIc3eVvtH3qIsc2xTParybTSsvJYDyhw0qbtHgYDfT68zLJNRQv4ZZ WLEYjIC0FneLtBR14ctkF0cRVizJCyTuiAbd0y3wnOyVIjVbicyWy3km/b7YId6w 1O6VBKB1SNVWEjtjY02Ag== X-ME-Sender: <xms:vzg-Zmjf4cGYhJn4q9MgjLNRjMUSvYaKDN3LCWzu3VjGyP2LLYksAg> <xme:vzg-ZnCruedSZYLxcgTY7VfN1WcLVaeJVG6jPWXAmRFfX9xWAC5D4NKf6F3wTNWUd tGIEolw-cEA4y_sYqA> X-ME-Received: <xmr:vzg-ZuH2tJyKbbv7H9cRoZwyuQE2e6jzMLhoW-BZoBzW3_rfyz4o7iizCk3z8g6-mM_H> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdefkedgkeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepteduleejgeehtefgheegjeekueehvdevieekueeftddvtdevfefhvdevgedu jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: <xmx:vzg-ZvSvKkkyf1P7TTi4UBBN2MnyqINM4xE8M81z9DeYzZbPXGPy-w> <xmx:vzg-ZjzndYpDb-pyPKLubk83HXrEOjSGAh7J0KcJ4OogV9Q1QdG_ng> <xmx:vzg-Zt74KZZhLwJd1vQ9F338AmwohfASjwtvIAEU8RJcIiRMmmT2bQ> <xmx:vzg-Zgz8uwh9Pm8NfojIVkDJ_l-2zqsq2dzE62jpcBiJyFhvVfw9lg> <xmx:vzg-Zu8fSIBeZ4i_r-zwEgMUQuIWGwbm5wyf2lUzkKaH_4PBHJ4ZaAzN> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 10 May 2024 11:09:50 -0400 (EDT) Message-ID: <176dd597-2ed0-40bd-b2be-a1a3acf4c5dd@HIDDEN> Date: Fri, 10 May 2024 18:09:48 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70577: [PATCH] New command other-project-prefix To: Juri Linkov <juri@HIDDEN> References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> <86jzkhe81b.fsf@HIDDEN> <208c7a05-6cfe-40c2-af54-187967348686@HIDDEN> <86le4tz88d.fsf@HIDDEN> <c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN> <865xvsjklh.fsf@HIDDEN> <c69a277b-0707-4305-aaee-905b24831623@HIDDEN> <861q6esvhl.fsf@HIDDEN> <b1e79441-aa0c-4f37-8af4-fc972810cbba@HIDDEN> <dedd9def-dfbd-46ac-91d0-15a9bb5bf0d1@HIDDEN> <86v83n35km.fsf@HIDDEN> <2fe15f19-1d70-4104-b1cc-d54055268f00@HIDDEN> <86a5kyp7dj.fsf@HIDDEN> Content-Language: en-US From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <86a5kyp7dj.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On 10/05/2024 09:43, Juri Linkov wrote: >> Conversely, calling project--other-place-prefix ends the current command, >> and the dynamic binding ends there too. > set-transient-map has the arg KEEP-PRED that could be used to keep the map > for a sequence of commands, but its use might be tricky. I'm not sure if it can help: what we need to do is not keep the keymap, but keep the advice from applying too early (meaning, keep the pre-command-hook from firing and removing itself before the wrong command).
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 10 May 2024 06:55:48 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 10 02:55:47 2024 Received: from localhost ([127.0.0.1]:41610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s5KAV-0007xD-Kb for submit <at> debbugs.gnu.org; Fri, 10 May 2024 02:55:47 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:38005) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1s5KAQ-0007x3-JN for 70577 <at> debbugs.gnu.org; Fri, 10 May 2024 02:55:45 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id B8AC8FF802; Fri, 10 May 2024 06:55:36 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Dmitry Gutov <dmitry@HIDDEN> Subject: Re: bug#70577: [PATCH] New command other-project-prefix In-Reply-To: <2fe15f19-1d70-4104-b1cc-d54055268f00@HIDDEN> (Dmitry Gutov's message of "Fri, 10 May 2024 04:46:27 +0300") Organization: LINKOV.NET References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> <86jzkhe81b.fsf@HIDDEN> <208c7a05-6cfe-40c2-af54-187967348686@HIDDEN> <86le4tz88d.fsf@HIDDEN> <c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN> <865xvsjklh.fsf@HIDDEN> <c69a277b-0707-4305-aaee-905b24831623@HIDDEN> <861q6esvhl.fsf@HIDDEN> <b1e79441-aa0c-4f37-8af4-fc972810cbba@HIDDEN> <dedd9def-dfbd-46ac-91d0-15a9bb5bf0d1@HIDDEN> <86v83n35km.fsf@HIDDEN> <2fe15f19-1d70-4104-b1cc-d54055268f00@HIDDEN> Date: Fri, 10 May 2024 09:43:52 +0300 Message-ID: <86a5kyp7dj.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >>>> Speaking of the implementation strategy, though, I think the current >>>> other-project-prefix implementation still doesn't work well together with >>>> project-other-*-command. >>> I suppose we could just blacklist some known prefix commands (*) in the >>> same form where we now compare (eq this-command 'other-project-prefix), but >>> it would be nice to distinguish prefix commands from "real" ones somehow. >>> >>> (*) project-other-window-command, project-other-frame-command, >>> project-other-tab-command, some others? >> I remember that other-commands worked in one of your previous patches. > > Maybe only when they went down the > > (if (< emacs-major-version 30) > > code path? Nope, only 30. (But it's possible that I mistyped 'C-x p p' instead of 'C-x p P'.) > Conversely, calling project--other-place-prefix ends the current command, > and the dynamic binding ends there too. set-transient-map has the arg KEEP-PRED that could be used to keep the map for a sequence of commands, but its use might be tricky.
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 10 May 2024 01:46:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 09 21:46:39 2024 Received: from localhost ([127.0.0.1]:41464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s5FLL-0004Yx-4n for submit <at> debbugs.gnu.org; Thu, 09 May 2024 21:46:39 -0400 Received: from wfhigh4-smtp.messagingengine.com ([64.147.123.155]:51543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1s5FLH-0004Yr-AM for 70577 <at> debbugs.gnu.org; Thu, 09 May 2024 21:46:38 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailfhigh.west.internal (Postfix) with ESMTP id BB8C3180019C; Thu, 9 May 2024 21:46:30 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 09 May 2024 21:46:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1715305590; x=1715391990; bh=YqpHEjLl/3o0BQP+okDqquV0fjdscWCjzfID0yajRVU=; b= XHQ4AqQsoZefhb4HubVWLR2VI7RGg9cH78AFxqHSYH8UUpP/TzhS4bNlF66fXf8W LOFomZ7x7J9bPo9MpBwiVNeIfD960VaFNleuoOIONsruMR7Gy+w98sNogtLeYolK xy5dtvewTGdeeMmdrbZDBgK04Jk8vtIePjxLu1h2/wtL9RHL26DZgCTQALyoSFXp WZXi/AjdHCZ9unZyq2RTP6vHjyZjOGcejJ9Vf5ZZ7Xb0KwnUgCLsIU4ZVap79ouF l0AjoomdJfdFn5y9Rhf+U/K4E58OJvoQNK4352I7lAVJplRNbVMFV+kkSpVGclGC P5lsMUFQdIj2aYPhhDpfAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1715305590; x= 1715391990; bh=YqpHEjLl/3o0BQP+okDqquV0fjdscWCjzfID0yajRVU=; b=D n8fi7MFeIYEY3kNt09mqQZfAoOWjaat3+i08iWjkUW/yVDYLK1/aWzLbsmP0N2v6 3UoqDMF/jrTOrfmrTCz2jPicuzB4qqp2DT6qB2GYoSJbPbNqVxrcdI6aUQdXrxf0 qUEq02xAO/aON2WZnyw/vYHq4uz+EFYejuBweCRa9OKHbZyU5ZxZy/cTxUvTALKM tDShNjvZ448MbQekPxlj1Y5df1YKHjA11HKyG31XGo4kOmVIcB0PHN2HW1AS68cA TRTvxCd2lEbaNEd49kfnSDLoSdCgAHiI6jpDtmzV7+TU9ftSNh2Ph+KlHepwsDPK nO/W3gZtTeprb30w7TciA== X-ME-Sender: <xms:dnw9ZuwIxhd6PmGdZrzvU9iYmgD4RxOvIiu4TOdT8g6IL_cRYhS3Rw> <xme:dnw9ZqTw2zTHl97Hj_28EUSfNmtm1QFLuF2ooQ3PcjFjW4j_mux31doXcNnsOtWqM 0XHguWXSnmHnQrwcog> X-ME-Received: <xmr:dnw9ZgUmaSJRHHRmDNqC5ZjGraxFoRN0X0BCNcdtgIJRhOn2LtC62YARpq51jmzrIGCN> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdefgedgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepteduleejgeehtefgheegjeekueehvdevieekueeftddvtdevfefhvdevgedu jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: <xmx:dnw9ZkgabcYF8hBvstNiP_hbKB5k4ZhngOj8dlgBnWyQPxknoFKomg> <xmx:dnw9ZgCltGhyep0m089r3Ba3X-oNYWBg_YC5DUuBaEbHfuAapQerKQ> <xmx:dnw9ZlLdDn7W8rcJPrUFmnt4fBiZBD3yvSpG6NgB0cpDOzkapnVeYA> <xmx:dnw9ZnB5YZ3x7qagcHdazJedmZcwdtb6GKC_VhQBaThn-AtQaPTUVw> <xmx:dnw9ZjNSj0cseXaHEaCYdvGFsJJIf1sb20oRHH3XfQDug97eKhsUQzsG> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 9 May 2024 21:46:29 -0400 (EDT) Message-ID: <2fe15f19-1d70-4104-b1cc-d54055268f00@HIDDEN> Date: Fri, 10 May 2024 04:46:27 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70577: [PATCH] New command other-project-prefix To: Juri Linkov <juri@HIDDEN> References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> <86jzkhe81b.fsf@HIDDEN> <208c7a05-6cfe-40c2-af54-187967348686@HIDDEN> <86le4tz88d.fsf@HIDDEN> <c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN> <865xvsjklh.fsf@HIDDEN> <c69a277b-0707-4305-aaee-905b24831623@HIDDEN> <861q6esvhl.fsf@HIDDEN> <b1e79441-aa0c-4f37-8af4-fc972810cbba@HIDDEN> <dedd9def-dfbd-46ac-91d0-15a9bb5bf0d1@HIDDEN> <86v83n35km.fsf@HIDDEN> Content-Language: en-US From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <86v83n35km.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On 09/05/2024 09:20, Juri Linkov wrote: >>> Speaking of the implementation strategy, though, I think the current >>> other-project-prefix implementation still doesn't work well together with >>> project-other-*-command. >> I suppose we could just blacklist some known prefix commands (*) in the >> same form where we now compare (eq this-command 'other-project-prefix), but >> it would be nice to distinguish prefix commands from "real" ones somehow. >> >> (*) project-other-window-command, project-other-frame-command, >> project-other-tab-command, some others? > I remember that other-commands worked in one of your previous patches. Maybe only when they went down the (if (< emacs-major-version 30) code path? Like project-any-command, project--other-place-command uses read-key-sequence and then invokes the command, which means that whatever dynamic binding was in effect, stays in effect for the "next" command. Conversely, calling project--other-place-prefix ends the current command, and the dynamic binding ends there too.
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 9 May 2024 06:31:49 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 09 02:31:49 2024 Received: from localhost ([127.0.0.1]:53342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s4xJk-0003lW-Vr for submit <at> debbugs.gnu.org; Thu, 09 May 2024 02:31:49 -0400 Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]:37113) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1s4xJd-0003kw-3E for 70577 <at> debbugs.gnu.org; Thu, 09 May 2024 02:31:44 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 2ECAF60003; Thu, 9 May 2024 06:31:08 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Dmitry Gutov <dmitry@HIDDEN> Subject: Re: bug#70577: [PATCH] New command other-project-prefix In-Reply-To: <90f9ec8e-0ab0-40c8-9ae8-e745f2ad72e3@HIDDEN> (Dmitry Gutov's message of "Tue, 7 May 2024 22:23:53 +0300") Organization: LINKOV.NET References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> <86jzkhe81b.fsf@HIDDEN> <208c7a05-6cfe-40c2-af54-187967348686@HIDDEN> <86le4tz88d.fsf@HIDDEN> <c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN> <865xvsjklh.fsf@HIDDEN> <c69a277b-0707-4305-aaee-905b24831623@HIDDEN> <861q6esvhl.fsf@HIDDEN> <86o79ieqt1.fsf@HIDDEN> <90f9ec8e-0ab0-40c8-9ae8-e745f2ad72e3@HIDDEN> Date: Thu, 09 May 2024 09:24:38 +0300 Message-ID: <867cg33521.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >> can be changed to read the project before reading the command >> with arguments: >> (defun other-project-prefix () >> (letrec ((root (funcall project-prompter)) >> (depth (minibuffer-depth)) >> (echofun (lambda () "[switch-project]")) >> (around-fun >> ... > > Yeah, it can be made tweakable like that, although I'd suggest first trying > to use it as-is for a little bit. I tried but still can't use it because its sequence of reading the project is incompatible with old 'project-switch-project', so it's difficult to switch to the new sequence. > If you prefer to read the project first, would see a lot of advantage to > the new command? I suppose 'C-h' working is the only plus. The advantage is that the new command paves the way for implementing the support of 'C-x p P C-x 4 p f'.
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 9 May 2024 06:31:45 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 09 02:31:45 2024 Received: from localhost ([127.0.0.1]:53339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s4xJg-0003lB-JB for submit <at> debbugs.gnu.org; Thu, 09 May 2024 02:31:44 -0400 Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]:59689) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1s4xJc-0003kv-Av for 70577 <at> debbugs.gnu.org; Thu, 09 May 2024 02:31:42 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 5B96A60005; Thu, 9 May 2024 06:31:06 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Dmitry Gutov <dmitry@HIDDEN> Subject: Re: bug#70577: [PATCH] New command other-project-prefix In-Reply-To: <dedd9def-dfbd-46ac-91d0-15a9bb5bf0d1@HIDDEN> (Dmitry Gutov's message of "Thu, 9 May 2024 05:22:18 +0300") Organization: LINKOV.NET References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> <86jzkhe81b.fsf@HIDDEN> <208c7a05-6cfe-40c2-af54-187967348686@HIDDEN> <86le4tz88d.fsf@HIDDEN> <c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN> <865xvsjklh.fsf@HIDDEN> <c69a277b-0707-4305-aaee-905b24831623@HIDDEN> <861q6esvhl.fsf@HIDDEN> <b1e79441-aa0c-4f37-8af4-fc972810cbba@HIDDEN> <dedd9def-dfbd-46ac-91d0-15a9bb5bf0d1@HIDDEN> Date: Thu, 09 May 2024 09:20:29 +0300 Message-ID: <86v83n35km.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >> Speaking of the implementation strategy, though, I think the current >> other-project-prefix implementation still doesn't work well together with >> project-other-*-command. > > I suppose we could just blacklist some known prefix commands (*) in the > same form where we now compare (eq this-command 'other-project-prefix), but > it would be nice to distinguish prefix commands from "real" ones somehow. > > (*) project-other-window-command, project-other-frame-command, > project-other-tab-command, some others? I remember that other-commands worked in one of your previous patches.
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 9 May 2024 02:22:57 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 08 22:22:57 2024 Received: from localhost ([127.0.0.1]:52186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s4tQv-0006cM-FT for submit <at> debbugs.gnu.org; Wed, 08 May 2024 22:22:57 -0400 Received: from fhigh6-smtp.messagingengine.com ([103.168.172.157]:34573) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1s4tQs-0006cE-1t for 70577 <at> debbugs.gnu.org; Wed, 08 May 2024 22:22:56 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfhigh.nyi.internal (Postfix) with ESMTP id F31161140150; Wed, 8 May 2024 22:22:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 08 May 2024 22:22:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1715221342; x=1715307742; bh=AYbbLZJ2XmizNwGLte430ktwQpbQuqN41Naj93OtzF8=; b= DcFdRtZP0StoDAWiXqSzf6rCORhsUfKa9AUJSVtwrP547/SocxsvQFT/3R+d532K rFbXNRMGS9wKaH1DxDtC2qgghySaEgwcHVwGHfLJYSbIELRVo5DR/Zw4K1k8z/3n 6tuJYvxVu5JGghbXlU2d4FvWyYxUa7aesn4sYU6WOWQu45DQ72h2JsxoCA0Lb6VE ZubvicGIKvZwAtWQGGyG5dYxGhff3YBo98A6Pr4aw84YnUchaxjGfEI6Rf/4AU/r mQoWIe/DbFYk5krKw8rrgz49krm9WfydDvWAYY36JYqZWEc8rZjiQO6iUQ13l1dv W1QHO6ejf/6bqcxBKXSW/Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1715221342; x= 1715307742; bh=AYbbLZJ2XmizNwGLte430ktwQpbQuqN41Naj93OtzF8=; b=e fe+7te3aDbMWVTL2sA1+a6BMWYuOOLZwJBZDceRPu4m10qQdkTrljzjbbCD6tY9P RchbvkoeTtJbBIBRPIf3bgZd4ttgOVjXlIjp5dhXZtzBdCUBP55g9MLXKWqxiFEd zFnhK6Cq9Y8ut1b7Z152bNB3eQ57wMfX6eMUCvzQbU6e9dmt+ql9Dm6/0uxnXAjU a+TjiFu3FY3jkIvuirvAhFTXK2bU/dshTM28XQn0VBX1Y2+cCGx/bBP0TEewSB55 qLAnR76Cn1r0MqyCS8oo9JKqMaq1fg53QEe581vwsRUa9Pn6+Pskv0GxQXYtB8PH afpjTnMTHWp7RTo5DMczA== X-ME-Sender: <xms:XjM8Zjg-jcOyPPpuGdC0m-uKxXb5hqg_zfTjyRxjI0unt4bwjI7UyQ> <xme:XjM8ZgDqn1y4s9UfrO06BE5OHfdYo6KlBEv_EgINrYQwrToz4ofz7XCvh5YaBT_zq YcCdQEVvjcJMNz45nE> X-ME-Received: <xmr:XjM8ZjH6sss3ytpR7UndAG9eaON-YQ_spg3k_SODuGCvBPFkoM_ctPjtlQ44efljckX3> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdefuddgheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffhvfevfhgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepkeefudefgfejffefvdfhteegveevhfekkeekhffgudfhveejteffhfegueet gefgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: <xmx:XjM8ZgT5C_AgWeQXIVsESYMUFkfzarq1t4C-8GPDQg1uj7FJ6xIDng> <xmx:XjM8Zgxjxjow3NXuWvZVBT1SVqUMfEojkLFlDxtttpxX8ZKGPqLv4Q> <xmx:XjM8Zm6Qa3sdHsEFEOTzWViBQBxdg44MqUIqutGQS1Lby9u9uFaGug> <xmx:XjM8ZlzklCzuP8ZGV-l2s7rGHtPb6h1HtYeW5QL2req8AHKH6CGrBw> <xmx:XjM8Zr9FnkyvGkCxjdYJZQ0xeXICgRERiq_s0BtAa-EBak8XVdLwpg2b> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 8 May 2024 22:22:21 -0400 (EDT) Message-ID: <dedd9def-dfbd-46ac-91d0-15a9bb5bf0d1@HIDDEN> Date: Thu, 9 May 2024 05:22:18 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70577: [PATCH] New command other-project-prefix From: Dmitry Gutov <dmitry@HIDDEN> To: Juri Linkov <juri@HIDDEN> References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> <86jzkhe81b.fsf@HIDDEN> <208c7a05-6cfe-40c2-af54-187967348686@HIDDEN> <86le4tz88d.fsf@HIDDEN> <c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN> <865xvsjklh.fsf@HIDDEN> <c69a277b-0707-4305-aaee-905b24831623@HIDDEN> <861q6esvhl.fsf@HIDDEN> <b1e79441-aa0c-4f37-8af4-fc972810cbba@HIDDEN> Content-Language: en-US In-Reply-To: <b1e79441-aa0c-4f37-8af4-fc972810cbba@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On 07/05/2024 22:16, Dmitry Gutov wrote: > Speaking of the implementation strategy, though, I think the current > other-project-prefix implementation still doesn't work well together > with project-other-*-command. I suppose we could just blacklist some known prefix commands (*) in the same form where we now compare (eq this-command 'other-project-prefix), but it would be nice to distinguish prefix commands from "real" ones somehow. (*) project-other-window-command, project-other-frame-command, project-other-tab-command, some others?
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 7 May 2024 19:24:31 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 07 15:24:31 2024 Received: from localhost ([127.0.0.1]:44272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s4QQQ-0002gs-RQ for submit <at> debbugs.gnu.org; Tue, 07 May 2024 15:24:31 -0400 Received: from wfhigh2-smtp.messagingengine.com ([64.147.123.153]:35965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1s4QQN-0002gj-CA for 70577 <at> debbugs.gnu.org; Tue, 07 May 2024 15:24:29 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfhigh.west.internal (Postfix) with ESMTP id AFE7218000CC; Tue, 7 May 2024 15:23:56 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 07 May 2024 15:23:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1715109836; x=1715196236; bh=STS8KC0MUU7c+uA1xxdqohWr7BY54ACH7wjlvnETr6w=; b= kIi4iVUIpn3fin02FbKkB6xm+HvJ40Wpti+nmqe5YYHAkrDGJD1S2a05u+ccVz7t SBo716bXtd21oLWBVMpmqgb/OWQXVNKDCa+7vapF5b8OXghGvcEVCISXg8qTUIDr bKyLdWMwcup5kR6RpmTSyedaU9afvDgIFft/IttHjxwfiqwtvFIqtSh8zt7S9yo8 F7Hf3k3olqDjLZW3HBZ4kPlhf0YGVwrZstO7dIzgb6WerZKnT+H61hWhSX+YLCo0 ZvsCzvkx1qf54SGtgZ4W446X3/7mcGzJUzQPvV+qUmwPXbKq8xkSfuHRZ3T7L/iz 1xVmknpTYvTERMsHzJZt7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1715109836; x= 1715196236; bh=STS8KC0MUU7c+uA1xxdqohWr7BY54ACH7wjlvnETr6w=; b=D PnkLcqQ+5v30ZSWL9DDyWNXlKeeL4jz7wdd66AaZ+gvbkLZQ9LYud7uh1xNWJB7C M7erE0iYcd4jqyen3j75pzAmLIFmShSKCxSXD0Q9pbGn/+boLvRDLyslcmbtkZIe 978xqLzauPz4Lb6P4rhPIJEonutgPZeo0SOLhZsqjEM4VSKyYPXnmSZ70SY2mTV2 JsnC8YQdS10niGE6JF8OsmxInSZ+HhEPqdmzxDeFZSp4AHxF2jAT3R1aK/Pcdm5e PXo0uZjw8H9fsqt/rUmxmi3CDQ4AqJiyuxiPY0C2R0Z+hkBeMMnE4roxLYu/z7CX uROhNziHtMneB8ZSoITpQ== X-ME-Sender: <xms:y386Zm9TZY_4QMhstXsQbnjI37fmm3JHqV847S9CMC3WXBo2b4e_wg> <xme:y386ZmtcZIupyumdTPatQ0MYxGlkd_QsTH5QRP_53aiLPyjoAT38D5TBAGL1VrXS7 6BM_38Mw7XfL9dU98g> X-ME-Received: <xmr:y386ZsDTx3humVyx-ZmOADGEIfXoBuUdl_TSpgXPLCUWjpGeNqEvMG51jWWjpq8XOj_l> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddvkedgudefgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomhepffhm ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg htthgvrhhnpeetudeljeegheetgfehgeejkeeuhedvveeikeeufedtvddtveefhfdvveeg udejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: <xmx:y386ZucUN--4_aFoYV8wI1UoZFNP1ECk1lokszLHUhi1C5JvBXZyWA> <xmx:y386ZrM0cyo3oP-cjeDqo-_q4cLeTlLWi7iKtbFMY3v2LgiTY_ARFQ> <xmx:y386ZoneUORp1dJNV3Mi4_9HZ1kp25js_T5wCUDIF0QGqSOFuCJJtQ> <xmx:y386ZttnR0VG1R5eEj6yWqWX5PY6DHR0MHV8T27podYAi3d2kdRGcw> <xmx:zH86ZkYFP46sXQR6LXwI0ZJPLL7b6hDdd7Zwbq69b4uaVeUktb67WkpN> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 7 May 2024 15:23:54 -0400 (EDT) Message-ID: <90f9ec8e-0ab0-40c8-9ae8-e745f2ad72e3@HIDDEN> Date: Tue, 7 May 2024 22:23:53 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70577: [PATCH] New command other-project-prefix To: Juri Linkov <juri@HIDDEN> References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> <86jzkhe81b.fsf@HIDDEN> <208c7a05-6cfe-40c2-af54-187967348686@HIDDEN> <86le4tz88d.fsf@HIDDEN> <c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN> <865xvsjklh.fsf@HIDDEN> <c69a277b-0707-4305-aaee-905b24831623@HIDDEN> <861q6esvhl.fsf@HIDDEN> <86o79ieqt1.fsf@HIDDEN> Content-Language: en-US From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <86o79ieqt1.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On 06/05/2024 21:30, Juri Linkov wrote: >>>> Wow, everything works now, will test more as a primary 'C-x p p' command. >>> Thanks, let me know if you find any other problems. >> I confirm that everything works nicely, thanks. The only >> problem is that after trying to use it, its order looks unnatural. >> I already accustomed to this order: 1) select the project, >> 2) run the command. This is handy especially with >> project-switch-commands set to 'project-prefix-or-any-command'. >> This order looks more logical because after selecting the >> project, the user mentally switches to another project, and >> then types a command with arguments in the switched project. >> However, the reverse order of typing a command keys >> before switching the project looks like trying >> to run the command in the previous project. >> Also the problem is that typing a command keys and reading >> the command arguments is separated by reading a project. >> >> Maybe many users would prefer other-project-prefix, I don't know. >> But other-project-prefix can't replace project-switch-project, >> only to be an alternative. > Sorry, I didn't realize that implementation of other-project-prefix > can be changed to read the project before reading the command > with arguments: > > (defun other-project-prefix () > (letrec ((root (funcall project-prompter)) > (depth (minibuffer-depth)) > (echofun (lambda () "[switch-project]")) > (around-fun > ... Yeah, it can be made tweakable like that, although I'd suggest first trying to use it as-is for a little bit. If you prefer to read the project first, would see a lot of advantage to the new command? I suppose 'C-h' working is the only plus.
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 7 May 2024 19:17:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 07 15:17:17 2024 Received: from localhost ([127.0.0.1]:44231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s4QJR-0002aT-G4 for submit <at> debbugs.gnu.org; Tue, 07 May 2024 15:17:17 -0400 Received: from wfout8-smtp.messagingengine.com ([64.147.123.151]:51145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1s4QJO-0002aN-Sd for 70577 <at> debbugs.gnu.org; Tue, 07 May 2024 15:17:16 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfout.west.internal (Postfix) with ESMTP id E2B521C000BD; Tue, 7 May 2024 15:16:43 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 07 May 2024 15:16:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1715109403; x=1715195803; bh=q0nVj95Jkfr21f2WVMc/qj+Na8rxdypus3+1voZW5o8=; b= Wg6EjMUD9yUZtF31025kjk5xHf+06YvLnqjjFr6rfGvlKjahkT2jZ8sZIJJnc9dn Vz96ZfpPWq+dq0qpSkyCKoxCYt+3BBPfzFAgm7Fw7DuE8jDEovWllOyjLQDM0FYJ CTgD7woG2S1PFzsDGQGhIWSdiGRN1+ezi2/i+korNlTxW/CU7y2HwvuMiGjFy8Dc P8cqrrCnaeG0W2B54Q0ZIU7mfhgP2wjAz5kmmMhyM99VUPiWB2eyB1qxXFtzzmHA g/pwt90owHmh+iAWnEUBaa6pXP1aaWDDfy2RWKWFupiZ14SsZeGpZrYaDNZtzk0+ cATNwsBAst+v48K835mlKQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1715109403; x= 1715195803; bh=q0nVj95Jkfr21f2WVMc/qj+Na8rxdypus3+1voZW5o8=; b=c 6rG/SGRYQkUxZI7aQORNhh7f3FToplhHkviW5Z5frVDJtvBO8VTy2K4U6SfyQ2vj QNNOvquXEVC1vFza//IO09gGpw8hQ+Q0j82XP34elV3QHklZDxfOsWPqew9z3WBb cfyQxlEnKggTWONnvv7unjQZMCjWwWlm0mBoQ5bXBvfTzfylU6alXVMdW8+HoR2w vqju3X/Lz2+kqOAP3o3OaTJwNGrHApCrW0JdghF3H2UvFNB7hIVMm+UTPx3KvGaY fcoLOv2M/YlJHX8o4IA9g6kTPfnZ2XnOZWTS5uk+Y3Js8H9B4aNqu688XE712Jnc ElzuLzEFLBZPBtLDZdIIw== X-ME-Sender: <xms:G346Zgmw0vFLzmhpNzaTAmGU-XIjKb64w_klYIAyoRa9QkZbB_JREg> <xme:G346Zv0lH58jfwBNNypZDP76fiXBQ4OW5C6ATaI7g-svLku4FmFqCHCO9WU1qyacO f1MKk6CWVCaShps4vA> X-ME-Received: <xmr:G346ZurSAB-PDJFh_3utcbnI21oTPdLQia0GQWOg-04kyuaAe1qnRNvDdIbGsO4KumTu> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddvkedgudefvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomhepffhm ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg htthgvrhhnpeetudeljeegheetgfehgeejkeeuhedvveeikeeufedtvddtveefhfdvveeg udejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: <xmx:G346Zsl1c5HqjUM9WstjVvNjXnC5ggjpxkievJmq5oqRW9jrKHSG7Q> <xmx:G346Zu2Ai8n_vN0a_2mWprKpDIINlvi5Dr7T2G7Kdkmrz3g39qyS3g> <xmx:G346ZjtvnQdQU7k_BMj4SCJBNtxtdaPCehyG5TOy81VRk5UtgmUr6w> <xmx:G346ZqXv-NZTudtBEmpCzEIrASaVllZ7XnWOL5VqGXTk4Gb2JeVvmg> <xmx:G346ZsDeGjJKscsnVDXzM-2DZqQinNBlxtnCVInkfdaFqT3PRal1NZ69> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 7 May 2024 15:16:42 -0400 (EDT) Message-ID: <b1e79441-aa0c-4f37-8af4-fc972810cbba@HIDDEN> Date: Tue, 7 May 2024 22:16:40 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70577: [PATCH] New command other-project-prefix To: Juri Linkov <juri@HIDDEN> References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> <86jzkhe81b.fsf@HIDDEN> <208c7a05-6cfe-40c2-af54-187967348686@HIDDEN> <86le4tz88d.fsf@HIDDEN> <c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN> <865xvsjklh.fsf@HIDDEN> <c69a277b-0707-4305-aaee-905b24831623@HIDDEN> <861q6esvhl.fsf@HIDDEN> Content-Language: en-US From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <861q6esvhl.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On 06/05/2024 20:25, Juri Linkov wrote: >>> Wow, everything works now, will test more as a primary 'C-x p p' command. >> >> Thanks, let me know if you find any other problems. > > I confirm that everything works nicely, thanks. The only > problem is that after trying to use it, its order looks unnatural. > I already accustomed to this order: 1) select the project, > 2) run the command. This is handy especially with > project-switch-commands set to 'project-prefix-or-any-command'. Could be a problem indeed, but only if we are aiming at changing the default. We're probably not going to do that, or at least not right away. > This order looks more logical because after selecting the > project, the user mentally switches to another project, and > then types a command with arguments in the switched project. > However, the reverse order of typing a command keys > before switching the project looks like trying > to run the command in the previous project. > Also the problem is that typing a command keys and reading > the command arguments is separated by reading a project. My advantage (maybe?) is that I don't use the "switch project" command very often. But when I do and I think about it, it kinds of seem to stick out compared to some other commands, in particular "prefix" ones, that you have two separate key sequences which you need to input, instead of just one longer one. That's where my main motivation for this patch comes (the other being that 'C-h' works with it). Speaking of the implementation strategy, though, I think the current other-project-prefix implementation still doesn't work well together with project-other-*-command. I.e. I'd expect 'C-x p P C-x 4 p f' to function as "find file in different project", but it both interrupts the key sequence before the last char (with a prompt), and ultimately fails to switch to that different project. > Maybe many users would prefer other-project-prefix, I don't know. > But other-project-prefix can't replace project-switch-project, > only to be an alternative. I think we could add the new command, and then revisit the question of defaults in 1-2 years. I guess the main difficulty is documenting all the new alternatives added in Emacs 30 adequately, so the user can make a confident choice which one to use.
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.
Received: (at 70577) by debbugs.gnu.org; 6 May 2024 18:31:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 06 14:31:42 2024
Received: from localhost ([127.0.0.1]:39523 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1s437m-0005Vq-7i
for submit <at> debbugs.gnu.org; Mon, 06 May 2024 14:31:42 -0400
Received: from relay6-d.mail.gandi.net ([217.70.183.198]:57753)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1s437k-0005Vi-6c
for 70577 <at> debbugs.gnu.org; Mon, 06 May 2024 14:31:41 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id F0917C0004;
Mon, 6 May 2024 18:31:07 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Dmitry Gutov <dmitry@HIDDEN>
Subject: Re: bug#70577: [PATCH] New command other-project-prefix
In-Reply-To: <861q6esvhl.fsf@HIDDEN> (Juri Linkov's message of "Mon,
06 May 2024 20:25:42 +0300")
Organization: LINKOV.NET
References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN>
<86le501ykg.fsf@HIDDEN>
<a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN>
<e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN>
<86jzkhe81b.fsf@HIDDEN>
<208c7a05-6cfe-40c2-af54-187967348686@HIDDEN>
<86le4tz88d.fsf@HIDDEN>
<c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN>
<865xvsjklh.fsf@HIDDEN>
<c69a277b-0707-4305-aaee-905b24831623@HIDDEN>
<861q6esvhl.fsf@HIDDEN>
Date: Mon, 06 May 2024 21:30:34 +0300
Message-ID: <86o79ieqt1.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 70577
Cc: 70577 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
>>> Wow, everything works now, will test more as a primary 'C-x p p' command.
>>
>> Thanks, let me know if you find any other problems.
>
> I confirm that everything works nicely, thanks. The only
> problem is that after trying to use it, its order looks unnatural.
> I already accustomed to this order: 1) select the project,
> 2) run the command. This is handy especially with
> project-switch-commands set to 'project-prefix-or-any-command'.
> This order looks more logical because after selecting the
> project, the user mentally switches to another project, and
> then types a command with arguments in the switched project.
> However, the reverse order of typing a command keys
> before switching the project looks like trying
> to run the command in the previous project.
> Also the problem is that typing a command keys and reading
> the command arguments is separated by reading a project.
>
> Maybe many users would prefer other-project-prefix, I don't know.
> But other-project-prefix can't replace project-switch-project,
> only to be an alternative.
Sorry, I didn't realize that implementation of other-project-prefix
can be changed to read the project before reading the command
with arguments:
(defun other-project-prefix ()
(letrec ((root (funcall project-prompter))
(depth (minibuffer-depth))
(echofun (lambda () "[switch-project]"))
(around-fun
...
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 6 May 2024 17:32:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 06 13:32:46 2024 Received: from localhost ([127.0.0.1]:39266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s42Ck-0004rP-JE for submit <at> debbugs.gnu.org; Mon, 06 May 2024 13:32:46 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:42269) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1s42Ci-0004rF-P2 for 70577 <at> debbugs.gnu.org; Mon, 06 May 2024 13:32:45 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 58C2A60003; Mon, 6 May 2024 17:32:12 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Dmitry Gutov <dmitry@HIDDEN> Subject: Re: bug#70577: [PATCH] New command other-project-prefix In-Reply-To: <c69a277b-0707-4305-aaee-905b24831623@HIDDEN> (Dmitry Gutov's message of "Sun, 5 May 2024 21:55:15 +0300") Organization: LINKOV.NET References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> <86jzkhe81b.fsf@HIDDEN> <208c7a05-6cfe-40c2-af54-187967348686@HIDDEN> <86le4tz88d.fsf@HIDDEN> <c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN> <865xvsjklh.fsf@HIDDEN> <c69a277b-0707-4305-aaee-905b24831623@HIDDEN> Date: Mon, 06 May 2024 20:25:42 +0300 Message-ID: <861q6esvhl.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >> Wow, everything works now, will test more as a primary 'C-x p p' command. > > Thanks, let me know if you find any other problems. I confirm that everything works nicely, thanks. The only problem is that after trying to use it, its order looks unnatural. I already accustomed to this order: 1) select the project, 2) run the command. This is handy especially with project-switch-commands set to 'project-prefix-or-any-command'. This order looks more logical because after selecting the project, the user mentally switches to another project, and then types a command with arguments in the switched project. However, the reverse order of typing a command keys before switching the project looks like trying to run the command in the previous project. Also the problem is that typing a command keys and reading the command arguments is separated by reading a project. Maybe many users would prefer other-project-prefix, I don't know. But other-project-prefix can't replace project-switch-project, only to be an alternative.
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 5 May 2024 18:55:55 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 05 14:55:54 2024 Received: from localhost ([127.0.0.1]:33052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s3h1c-0005mY-LD for submit <at> debbugs.gnu.org; Sun, 05 May 2024 14:55:54 -0400 Received: from wfout2-smtp.messagingengine.com ([64.147.123.145]:51527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1s3h1X-0005mQ-Sx for 70577 <at> debbugs.gnu.org; Sun, 05 May 2024 14:55:50 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfout.west.internal (Postfix) with ESMTP id 4E18A1C000D7; Sun, 5 May 2024 14:55:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sun, 05 May 2024 14:55:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1714935317; x=1715021717; bh=CmZWpdZgAF pC8IDLc0b0drERaMIxTvnf3s5rqYkqgbk=; b=qEU6CcGrNOPNHC5IXvoelEhChv 7/XzqqmPCBRXxBzc91f83sDDVFFVMhrWVBbGyQLgah4lxAFW+RfTXD7Hv9L9GNcN rpGGb7OGw2ubbgYmJNEPSl8Kw1mmpN8m7CQk/jHK9ZAPFKqnpKp2N+3YSlAFlr14 NrPe/9QE8gwz7VRPNdIshPwXfzCrY/u1YwENkqSrw+w6gPG9x1aWWg8rbkc3YY65 fuNLe9iyqgVkTH41gXLYOa5uRUMXEvwojyNKV57yxZ6tkTSAjxiMQefXPoKO6shk ghNxZ9M6oz2cGoVYIRZ2RGJAM5X1HwrWWe4Wtehovki6Ue9/sxxMnnBWCZJg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1714935317; x=1715021717; bh=CmZWpdZgAFpC8IDLc0b0drERaMIx Tvnf3s5rqYkqgbk=; b=WDV9rp3G6lib+D9J+pORj+bethiN5LaPuAfbHva2zXUx TNdyk/4g5ZXi6YI37wUyn92afB1DsqQEXUuf+vznkIEDoV/QoxtTmFFHG3CsHKm5 AfxbzlRAHdl3QcXHXp/hxFR8qwmIgbsZcGf83QLZm+VGVijcgrg86ciq2m+bNJIH z5wg8x+F3G6WodInLtbFH5bU9EETejIntN3l3L9TTbNvPLjLLRmP+R7HFMH1kmtS XYD1ZTCathtq7VhaZMJtSdFKntEkos/LuFk21bbRICuk2DKlfgylAHuSKXsdKRsJ 4r0wqgpbcRfH7CquXFYsBY9THmX4fvpwMrjZKN9Xpg== X-ME-Sender: <xms:FdY3ZvKrv-mmtTpg1s1GjUTXXJMyn-bNuwXlIceWJw4L7yOURvvXlw> <xme:FdY3ZjK-JWKp6ffhWrc0hUsiPV_-w1eyB9kxs4h0UmCWDae8x5_v7CL5JnUi67ZQY JOPvRO2bWxGT_JAgew> X-ME-Received: <xmr:FdY3Zns_a1zb6jviBsjC9UpnPbAT49HHvJsJrOzK9KFTCBIEmM69uIlE8k3JDi5bPXES> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddvgedgudeffecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpegtkfffgggfuffvvehfhfgjsehmtderredtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepleekjeeivdfftdegjedvffffleeuleekhfdtkeejheeugfetudehgeefhfei keejnecuffhomhgrihhnpehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: <xmx:FdY3Zob1-ShG0aNxqPOm1XQDq9pTpkuuHcgwZZO0Q851g3IXg2lBZw> <xmx:FdY3Zmayz8wRikI6vn15L5euE3RFMz5r-lE2lHQeqjp6M9rVq6UJMA> <xmx:FdY3ZsA1pTmGVk_A88CCnZ5xen_T9juhzSbews_BK2wVPwa6G7TwYg> <xmx:FdY3Zkb0P3lSto1eIMRWXpwHHVvMQWifAlXi1jsvmoFrZ_-Mx4k0zQ> <xmx:FdY3ZllmHEbWA19gF-bjwyyJd5MuZh3VQeV9GmhiupZS95Rv02ikWBl-> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 5 May 2024 14:55:16 -0400 (EDT) Content-Type: multipart/mixed; boundary="------------htynviPQJi3KUwdjNWZds0im" Message-ID: <c69a277b-0707-4305-aaee-905b24831623@HIDDEN> Date: Sun, 5 May 2024 21:55:15 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70577: [PATCH] New command other-project-prefix To: Juri Linkov <juri@HIDDEN> References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> <86jzkhe81b.fsf@HIDDEN> <208c7a05-6cfe-40c2-af54-187967348686@HIDDEN> <86le4tz88d.fsf@HIDDEN> <c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN> <865xvsjklh.fsf@HIDDEN> Content-Language: en-US From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <865xvsjklh.fsf@HIDDEN> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------htynviPQJi3KUwdjNWZds0im Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05/05/2024 19:40, Juri Linkov wrote: >> We would want 'C-h' to show the regular buffer with key bindings, won't we? >> With similar output to the one that we get after 'C-x p C-h' or 'C-x >> v C-h'. The output might be weirder because of the composed keymap, but it >> could still be useful. > > Then maybe something like > > (define-key map (vector help-char) > (lambda () (interactive) (describe-bindings))) > > or > > (define-key map (vector help-char) > (lambda () (interactive) (describe-keymap (cons 'keymap (current-active-maps))))) > > or > > (define-key map (vector help-char) > (lambda () (interactive) (describe-keymap (cons 'keymap project-prefix-map)))) This actually seems unnecessary. See the attached latest version where the binding works automatically without explicit assignment. >>> However, a much bigger problem is that unfortunately many test cases from >>> https://debbugs.gnu.org/63648#203 are broken. For example, >>> 'C-x p p C-b' fails the same way as in bug#58784. >>> 'C-x p p f M-n' fails because it expects to read arguments >>> in a previous project with an old value of default-directory, etc. >> >> Thanks for noticing. Looks like the call to project-prompter can change the >> value of this-command, and that's why the subsequent check went down the >> wrong branch. See the attached v3 with the fix. > > Wow, everything works now, will test more as a primary 'C-x p p' command. Thanks, let me know if you find any other problems. --------------htynviPQJi3KUwdjNWZds0im Content-Type: text/x-patch; charset=UTF-8; name="other-project-prefix-v4.diff" Content-Disposition: attachment; filename="other-project-prefix-v4.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwgYi9saXNwL3Byb2dtb2Rl cy9wcm9qZWN0LmVsCmluZGV4IDUyZmU0ZGY5MDgwLi5lNDFhMjNmZTEzZCAxMDA2NDQKLS0t IGEvbGlzcC9wcm9nbW9kZXMvcHJvamVjdC5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9wcm9q ZWN0LmVsCkBAIC05NjcsNiArOTY3LDQ1IEBAIHByb2plY3Qtb3RoZXItdGFiLWNvbW1hbmQK ICh3aGVuIChib3VuZC1hbmQtdHJ1ZS1wIHRhYi1wcmVmaXgtbWFwKQogICAoZGVmaW5lLWtl eSB0YWItcHJlZml4LW1hcCAicCIgIydwcm9qZWN0LW90aGVyLXRhYi1jb21tYW5kKSkKIAor Ozs7IyMjYXV0b2xvYWQKKyhkZWZ1biBvdGhlci1wcm9qZWN0LXByZWZpeCAoKQorICAiXCJT d2l0Y2hcIiB0byBhbm90aGVyIHByb2plY3QgYmVmb3JlIHJ1bm5pbmcgYW4gRW1hY3MgY29t bWFuZC4KK1RoZSBuZXh0IGNvbW1hbmQgeW91IGludm9rZSB3aWxsIHByb21wdCBmb3IgdGhl IHByb2plY3QgaW4gd2hpY2ggdG8gcnVuCit0aGUgY29tbWFuZC4iCisgIChpbnRlcmFjdGl2 ZSkKKyAgKHByZWZpeC1jb21tYW5kLXByZXNlcnZlLXN0YXRlKQorICAobGV0cmVjICgoZGVw dGggKG1pbmlidWZmZXItZGVwdGgpKQorICAgICAgICAgICAoZWNob2Z1biAobGFtYmRhICgp ICJbc3dpdGNoLXByb2plY3RdIikpCisgICAgICAgICAgIChhcm91bmQtZnVuCisgICAgICAg ICAgICAobGFtYmRhIChjb21tYW5kICZyZXN0IF9hcmdzKQorICAgICAgICAgICAgICAoaW50 ZXJhY3RpdmUpCisgICAgICAgICAgICAgIChhZHZpY2UtcmVtb3ZlIHRoaXMtY29tbWFuZCBh cm91bmQtZnVuKQorICAgICAgICAgICAgICAoaWYgKG9yIChlcSB0aGlzLWNvbW1hbmQgJ290 aGVyLXByb2plY3QtcHJlZml4KQorICAgICAgICAgICAgICAgICAgICAgICAgICAoZXEgbGFz dC1jb21tYW5kLWV2ZW50IGhlbHAtY2hhcikpCisgICAgICAgICAgICAgICAgICAoY2FsbC1p bnRlcmFjdGl2ZWx5IGNvbW1hbmQpCisgICAgICAgICAgICAgICAgKGxldCogKCh0aGlzLWNv bW1hbmQtc2F2ZWQgdGhpcy1jb21tYW5kKQorICAgICAgICAgICAgICAgICAgICAgICAocm9v dCAoZnVuY2FsbCBwcm9qZWN0LXByb21wdGVyKSkpCisgICAgICAgICAgICAgICAgICAoaWYg KG9yIChzdHJpbmctcHJlZml4LXAgInByb2plY3QtIgorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIChzeW1ib2wtbmFtZSB0aGlzLWNvbW1hbmQtc2F2ZWQp KQorICAgICAgICAgICAgICAgICAgICAgICAgICAoZ2V0IHRoaXMtY29tbWFuZC1zYXZlZCAn cHJvamVjdC1hd2FyZSkpCisgICAgICAgICAgICAgICAgICAgICAgKGxldCAoKHByb2plY3Qt Y3VycmVudC1kaXJlY3Rvcnktb3ZlcnJpZGUgcm9vdCkpCisgICAgICAgICAgICAgICAgICAg ICAgICAoY2FsbC1pbnRlcmFjdGl2ZWx5IGNvbW1hbmQpKQorICAgICAgICAgICAgICAgICAg ICAobGV0ICgoZGVmYXVsdC1kaXJlY3Rvcnkgcm9vdCkpCisgICAgICAgICAgICAgICAgICAg ICAgKGNhbGwtaW50ZXJhY3RpdmVseSBjb21tYW5kKSkpKSkpKQorICAgICAgICAgICAocHJl ZnVuCisgICAgICAgICAgICAobGFtYmRhICgpCisgICAgICAgICAgICAgICh1bmxlc3MgKD4g KG1pbmlidWZmZXItZGVwdGgpIGRlcHRoKQorICAgICAgICAgICAgICAgIChyZW1vdmUtaG9v ayAncHJlLWNvbW1hbmQtaG9vayBwcmVmdW4pCisgICAgICAgICAgICAgICAgKHJlbW92ZS1o b29rICdwcmVmaXgtY29tbWFuZC1lY2hvLWtleXN0cm9rZXMtZnVuY3Rpb25zIGVjaG9mdW4p CisgICAgICAgICAgICAgICAgKHdoZW4gKGFuZCB0aGlzLWNvbW1hbmQgKHN5bWJvbHAgdGhp cy1jb21tYW5kKSkKKyAgICAgICAgICAgICAgICAgIChhZHZpY2UtYWRkIHRoaXMtY29tbWFu ZCA6YXJvdW5kIGFyb3VuZC1mdW4pKSkpKSkKKyAgICAoYWRkLWhvb2sgJ3ByZS1jb21tYW5k LWhvb2sgcHJlZnVuKQorICAgIChhZGQtaG9vayAncHJlZml4LWNvbW1hbmQtZWNoby1rZXlz dHJva2VzLWZ1bmN0aW9ucyBlY2hvZnVuKQorICAgIChzZXQtdHJhbnNpZW50LW1hcCBwcm9q ZWN0LXByZWZpeC1tYXApCisgICAgKG1lc3NhZ2UgKGNvbmNhdCAiVHlwZSAiIChwcm9qZWN0 LS1rZXltYXAtcHJvbXB0KSAiIG9yIGFueSBnbG9iYWwga2V5IikpKSkKKworOzsgKGRlZmlu ZS1rZXkgcHJvamVjdC1wcmVmaXgtbWFwIChrYmQgIlAiKSAjJ290aGVyLXByb2plY3QtcHJl Zml4KQorCiAoZGVjbGFyZS1mdW5jdGlvbiBncmVwLXJlYWQtZmlsZXMgImdyZXAiKQogKGRl Y2xhcmUtZnVuY3Rpb24geHJlZi0tZmluZC1pZ25vcmVzLWFyZ3VtZW50cyAieHJlZiIpCiAK --------------htynviPQJi3KUwdjNWZds0im--
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 5 May 2024 18:27:17 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 05 14:27:17 2024 Received: from localhost ([127.0.0.1]:32919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s3gZw-0002gH-VM for submit <at> debbugs.gnu.org; Sun, 05 May 2024 14:27:17 -0400 Received: from wfout1-smtp.messagingengine.com ([64.147.123.144]:46237) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1s3gZr-0002g9-Ar for 70577 <at> debbugs.gnu.org; Sun, 05 May 2024 14:27:14 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfout.west.internal (Postfix) with ESMTP id 8FACE1C000F9; Sun, 5 May 2024 14:26:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 05 May 2024 14:26:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1714933601; x=1715020001; bh=NoN76m4v6VdzVWJkVVv6wK/L61oDfE19CRN1vt6HAaw=; b= sMAB61tMwS8gd2bg3rmtKnqtnD3AwEUwKS54dojdbT53Pwslufyvg5mo/IQeFXaE xyeIgzjvUhfv11me0q0JlqJPsT46QBuZQ193HLtIGl+sAxpmNoatdoF4xD+aSi8m uKq21yUCacLkT7+JNpXEDlYija4et7SYPy7s2sR4cQpVWtRJxJWMD3EWXBnrL47W f3/JXUBOU+LxY6nulQ8cpLb/gtlPmMi4OSjxnvYqC9UTwMIfaEvH3gwzKMKJTtzw sPZ7FXybUKxodVJnxkfKOWFwTFUxFZnHdtv1/A9+i5/s4I5mvuXQWmsn9HPMLq6e AHvGqE/J3+CLEqrxCfdK4A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1714933601; x= 1715020001; bh=NoN76m4v6VdzVWJkVVv6wK/L61oDfE19CRN1vt6HAaw=; b=O rTDbRx/9pQBfsZIsAsBTti4i6VcNdjbSC0soz5jzA8BY9zEbBxmSSFilnYywbpF9 lBtuc+GW8qCAZphuWJIE5xw3IRtIkOhN319pnTax899k9dVhI1wnWUNi3Lj0h8/l 7qhJa51Zkd1qVWIuMbzSGsruproCkPBEgIxrceiHT8Si7KV9i/5ecsH6BMLnw+YA F709CYuxXpiDN6F2mbkocMhaB8mJBpKQMn5VmHVmXFl3paKTaaUsYqcFV8euzaYF kofkcuUC0c0wNlC85jBOd86qExY0eBVWtj+fT7HWro1eRbhbhLGw+3oYvJCsCXLF JKJaE6WyW2zF8RBhMZY6g== X-ME-Sender: <xms:YM83Zu3ksslAbZmGvJbtAsozgtqJ2pRXo8IzAZ__8lxlszawYrj-yQ> <xme:YM83ZhGDSnNWALetY5COldEswwd7xlt5CzW4b1wqFq2sP-8qOErAiLIvnfyCozOWT Cnft7vU-yH07YwuqIc> X-ME-Received: <xmr:YM83Zm5sh5FA4wKi3DN7QhZLlEnaBlWxflKnb42BbUS-MYRvYkLhp8iHf0QaGxCkDzD1> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddvgedguddvjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomhepffhm ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg htthgvrhhnpeetudeljeegheetgfehgeejkeeuhedvveeikeeufedtvddtveefhfdvveeg udejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: <xmx:YM83Zv1qX0A_zXudePeuaEXc2vjabQp-0KO_rtQhPzd-NcxSoOxN8g> <xmx:YM83ZhGgP2ZFrkgerEVA5QHhwaM_HO7PAgs3A4d5c7JChzf51Z3MbA> <xmx:YM83Zo8JeYEaqAX7aVWL_Gm4ZdOjrpymv6uggdyFRujnNPmHbcbJRg> <xmx:YM83ZmkdkSM5fc7fcSKWj3fvF7024RmPGL28DvWSvNazEwnEQtzSpw> <xmx:Yc83ZhBy3fVmn-X4zXXw4Mg4VdYuOfVryLbZZxV_6ZpQi5voRUrVyXWP> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 5 May 2024 14:26:40 -0400 (EDT) Message-ID: <b6412aaa-bcc8-4420-9300-69d0f7c57caa@HIDDEN> Date: Sun, 5 May 2024 21:26:38 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70577: [PATCH] New command other-project-prefix To: Eli Zaretskii <eliz@HIDDEN> References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> <86jzkhe81b.fsf@HIDDEN> <208c7a05-6cfe-40c2-af54-187967348686@HIDDEN> <86le4tz88d.fsf@HIDDEN> <c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN> <86ttjeghtt.fsf@HIDDEN> <f4a9c2a7-efbf-4241-8c2b-5b1b04be584c@HIDDEN> <8634qxfpl4.fsf@HIDDEN> <b282ebb2-24a0-4923-9231-2925c037ada3@HIDDEN> <86r0egersg.fsf@HIDDEN> Content-Language: en-US From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <86r0egersg.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org, juri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On 05/05/2024 08:44, Eli Zaretskii wrote: >> Date: Sun, 5 May 2024 03:02:27 +0300 >> Cc:juri@HIDDEN,70577 <at> debbugs.gnu.org >> From: Dmitry Gutov<dmitry@HIDDEN> >> >> On 04/05/2024 20:34, Eli Zaretskii wrote: >>>> Date: Sat, 4 May 2024 20:22:39 +0300 >>>> Cc:juri@HIDDEN,70577 <at> debbugs.gnu.org >>>> From: Dmitry Gutov<dmitry@HIDDEN> >>>> >>>> Some ideas regarding 'C-h' behaving differently from the usual would be >>>> welcome, too. >>> You mean, what help--append-keystrokes-help does? For that to work, >>> C-h should have no binding in the last keymap, AFAIR. >> As you can see in the attached patches, I don't add a C-h binding to the >> generated map. >> >> And the text (`C-h' for help) does get printed, but pressing this key >> combination doesn't show help. That seems like a problem. > Can you show a recipe that I could try with the current master to > reproduce this? Then I could take a look. Thanks, I've found the problem - it was caused by the specific code in the function, not something general (it skipped the invocation of COMMAND inside AROUND-FUN).
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.
Received: (at 70577) by debbugs.gnu.org; 5 May 2024 16:44:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 05 12:44:58 2024
Received: from localhost ([127.0.0.1]:60621 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1s3eyw-0001aL-0H
for submit <at> debbugs.gnu.org; Sun, 05 May 2024 12:44:58 -0400
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:39427)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1s3eyu-0001Zp-0I
for 70577 <at> debbugs.gnu.org; Sun, 05 May 2024 12:44:56 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id 22887E0005;
Sun, 5 May 2024 16:44:24 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Dmitry Gutov <dmitry@HIDDEN>
Subject: Re: bug#70577: [PATCH] New command other-project-prefix
In-Reply-To: <c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN> (Dmitry Gutov's
message of "Sat, 4 May 2024 05:12:39 +0300")
Organization: LINKOV.NET
References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN>
<86le501ykg.fsf@HIDDEN>
<a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN>
<e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN>
<86jzkhe81b.fsf@HIDDEN>
<208c7a05-6cfe-40c2-af54-187967348686@HIDDEN>
<86le4tz88d.fsf@HIDDEN>
<c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN>
Date: Sun, 05 May 2024 19:40:14 +0300
Message-ID: <865xvsjklh.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 70577
Cc: 70577 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
> We would want 'C-h' to show the regular buffer with key bindings, won't we?
> With similar output to the one that we get after 'C-x p C-h' or 'C-x
> v C-h'. The output might be weirder because of the composed keymap, but it
> could still be useful.
Then maybe something like
(define-key map (vector help-char)
(lambda () (interactive) (describe-bindings)))
or
(define-key map (vector help-char)
(lambda () (interactive) (describe-keymap (cons 'keymap (current-active-maps)))))
or
(define-key map (vector help-char)
(lambda () (interactive) (describe-keymap (cons 'keymap project-prefix-map))))
>> However, a much bigger problem is that unfortunately many test cases from
>> https://debbugs.gnu.org/63648#203 are broken. For example,
>> 'C-x p p C-b' fails the same way as in bug#58784.
>> 'C-x p p f M-n' fails because it expects to read arguments
>> in a previous project with an old value of default-directory, etc.
>
> Thanks for noticing. Looks like the call to project-prompter can change the
> value of this-command, and that's why the subsequent check went down the
> wrong branch. See the attached v3 with the fix.
Wow, everything works now, will test more as a primary 'C-x p p' command.
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 5 May 2024 05:45:23 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 05 01:45:23 2024 Received: from localhost ([127.0.0.1]:57805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s3Ugc-0000wn-Ry for submit <at> debbugs.gnu.org; Sun, 05 May 2024 01:45:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1s3Ugb-0000wc-3m for 70577 <at> debbugs.gnu.org; Sun, 05 May 2024 01:45:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1s3Ug7-0006qD-ET; Sun, 05 May 2024 01:44:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+e9W0+TdoydMnIycpt/qzPtsspkRyQYpin/SoDCkRY8=; b=gRw92v+EnL4P kI2MWXx2q2nqYcJfqvIL+U1xCRDqpEuOiZrIO08EgupaNR7Hu/CcWc0akLC65+f/M3041PI8TaXbt eYQJb8R+Rw7/L/T2ytknTLnI591/6nb2/z5inQF4RjB3y1BrZumGEia4Uch/s7rByL3ImFpC2kJSt 8jOgOmHRxr3Xo6RxGZxEuJnww+8rpDob/5849j7AMQjKPrnNOnNcyAcOJ1zB6cwOXJ7pXNUHLK+LJ 3ctkLntjA0zN/qWGZl4lsHCElp4sJenrUBY+vg9dKc/vBCkpYEwAuHnh1N/Yt6mSvC9NjiJqsJc1S Y0HqxEcNpJ/KfKWlWD5D8Q==; Date: Sun, 05 May 2024 08:44:47 +0300 Message-Id: <86r0egersg.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <b282ebb2-24a0-4923-9231-2925c037ada3@HIDDEN> (message from Dmitry Gutov on Sun, 5 May 2024 03:02:27 +0300) Subject: Re: bug#70577: [PATCH] New command other-project-prefix References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> <86jzkhe81b.fsf@HIDDEN> <208c7a05-6cfe-40c2-af54-187967348686@HIDDEN> <86le4tz88d.fsf@HIDDEN> <c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN> <86ttjeghtt.fsf@HIDDEN> <f4a9c2a7-efbf-4241-8c2b-5b1b04be584c@HIDDEN> <8634qxfpl4.fsf@HIDDEN> <b282ebb2-24a0-4923-9231-2925c037ada3@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org, juri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Sun, 5 May 2024 03:02:27 +0300 > Cc: juri@HIDDEN, 70577 <at> debbugs.gnu.org > From: Dmitry Gutov <dmitry@HIDDEN> > > On 04/05/2024 20:34, Eli Zaretskii wrote: > >> Date: Sat, 4 May 2024 20:22:39 +0300 > >> Cc:juri@HIDDEN,70577 <at> debbugs.gnu.org > >> From: Dmitry Gutov<dmitry@HIDDEN> > >> > >> Some ideas regarding 'C-h' behaving differently from the usual would be > >> welcome, too. > > You mean, what help--append-keystrokes-help does? For that to work, > > C-h should have no binding in the last keymap, AFAIR. > > As you can see in the attached patches, I don't add a C-h binding to the > generated map. > > And the text (`C-h' for help) does get printed, but pressing this key > combination doesn't show help. That seems like a problem. Can you show a recipe that I could try with the current master to reproduce this? Then I could take a look.
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 5 May 2024 00:03:05 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 04 20:03:05 2024 Received: from localhost ([127.0.0.1]:56486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s3PLM-0005B4-PG for submit <at> debbugs.gnu.org; Sat, 04 May 2024 20:03:05 -0400 Received: from wfhigh8-smtp.messagingengine.com ([64.147.123.159]:45831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1s3PLI-0005Af-Os for 70577 <at> debbugs.gnu.org; Sat, 04 May 2024 20:03:02 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfhigh.west.internal (Postfix) with ESMTP id 724451800070; Sat, 4 May 2024 20:02:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sat, 04 May 2024 20:02:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1714867350; x=1714953750; bh=9T82Qr1InDUz0e0fqlU5yw7MhCcMCL3bFBlISU0BkFU=; b= hx15vgf4rLNTdtKmDpN0EaOWcQFUbSwg15lWfdBtO8boiAzb+G6FD1cdDETW+RCm 961Xq7HbiND6bobr9KTxNQijz6O2O6IKYKvgiKahGfA1eOoLmwS/aj8TTUR8CMg9 EPQxilQIa23JAtg5P4X2V+URMHdXZIcC+CzvtCmpzKwmvM4QCYTHtPlCwOHGsXp6 cYd+gFpfZGOong1z+6Ymx6aGFtjljSeG/wu0c5u5zvdjQO8peuCQDuh6EkpSbNjt FJ404fAxutOTb25JCNr1qz+RS09XV4BZugNW6qWcpMFJT7TmfUpuuNTMG0moHYT2 Yy1XZskPfZqm2rFhMP9QbA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1714867350; x= 1714953750; bh=9T82Qr1InDUz0e0fqlU5yw7MhCcMCL3bFBlISU0BkFU=; b=f OmxcVEh2ETEEx27ebFva8Sifcjmwbf5AIyJpex40DzA3IKuBBiovchTHmBb6AtEF WFbRaTJV84ZBvT8xBd4i3IrqEbqy7IFBQF7hVHakSdJsMmO8bFhI3OBCpn+zzyQe hP3e2iyM1A2xC2SWxEbmeLhhg5VDfbDo7CZct6PPQgQv+kwSShYrot4glcXkTCZg OXwgzcMZpKEZNaoOl9m7s4V1YhgZ4t3v2c9jIVSRHaikj4jP5U/yoFhy4k+ivRiC ufxMRA7iB/02dYMUQVjkIoUIF13GCoaup9+GAHayh5jFwpXnC1HmD+O2Fzrn/CA2 yJKBzxHVUymPJvCLm5WYQ== X-ME-Sender: <xms:lsw2Zs7JF13dEAwbIFU6p5NjzK2pjs5R30PEBxvp1WBLbGQngF-Vlw> <xme:lsw2Zt4cTvi-o7UxqktXljPu8JKD1gifz2ntuVqf6wA4fGfwUhSdCw3ep7uPyT8KK 0JFAmFsMF71JJLU3vg> X-ME-Received: <xmr:lsw2ZrcWOv_GHuLO84qbW_v_HE7WB5YauELGplrWIrE8zdHWMpRi2QA4qkyrLwv-C7nX> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddvfedgfedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepteduleejgeehtefgheegjeekueehvdevieekueeftddvtdevfefhvdevgedu jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: <xmx:lsw2ZhKCu8OOLSpA5xZvP6pMIWif7o9cBVK1mJopcCT1fezCHazdWw> <xmx:lsw2ZgJSjo7kPWUW0OZdsVGX2r7RxpB5QH1X_ykJNxNNyaJBMWz_rA> <xmx:lsw2ZixTBWcUCByOXEcT1nAYiRjVt9c19-oIzrpyRF8alDlxuilQ2A> <xmx:lsw2ZkKDK-0qnXAoUnTBIUWu74HLUXTYlguHdssRVPQfwLdqhEv9XA> <xmx:lsw2Zk1yXNVGb9x8Ou9hA0X7kYRKYvFDZdtMt0CoM0N2U-ov-iGFG65t> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 4 May 2024 20:02:29 -0400 (EDT) Message-ID: <b282ebb2-24a0-4923-9231-2925c037ada3@HIDDEN> Date: Sun, 5 May 2024 03:02:27 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70577: [PATCH] New command other-project-prefix To: Eli Zaretskii <eliz@HIDDEN> References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> <86jzkhe81b.fsf@HIDDEN> <208c7a05-6cfe-40c2-af54-187967348686@HIDDEN> <86le4tz88d.fsf@HIDDEN> <c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN> <86ttjeghtt.fsf@HIDDEN> <f4a9c2a7-efbf-4241-8c2b-5b1b04be584c@HIDDEN> <8634qxfpl4.fsf@HIDDEN> Content-Language: en-US From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <8634qxfpl4.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org, juri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On 04/05/2024 20:34, Eli Zaretskii wrote: >> Date: Sat, 4 May 2024 20:22:39 +0300 >> Cc:juri@HIDDEN,70577 <at> debbugs.gnu.org >> From: Dmitry Gutov<dmitry@HIDDEN> >> >> Some ideas regarding 'C-h' behaving differently from the usual would be >> welcome, too. > You mean, what help--append-keystrokes-help does? For that to work, > C-h should have no binding in the last keymap, AFAIR. As you can see in the attached patches, I don't add a C-h binding to the generated map. And the text (`C-h' for help) does get printed, but pressing this key combination doesn't show help. That seems like a problem.
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 4 May 2024 17:35:22 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 04 13:35:22 2024 Received: from localhost ([127.0.0.1]:54859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s3JIA-0006Tk-02 for submit <at> debbugs.gnu.org; Sat, 04 May 2024 13:35:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1s3JI7-0006Ta-8r for 70577 <at> debbugs.gnu.org; Sat, 04 May 2024 13:35:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1s3JHe-0000qa-2n; Sat, 04 May 2024 13:34:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2rbbFRrc0sGV8eBiNDJzuM4mWUhbOQC5zmfH9pT5NTI=; b=jO6UhvKe9fvt GT0lmoZjIIhvrVpAjcRWsd59kv3aBC6Vd+HjhSMknh+Wzl0XjgbaHNy0tc6dor1o1VvWLX2Mxo8qF Hq8dPj8/7hfBIjQaDvlNeRLrUyO7AB+LXmAraL1bWK5h41kwemqbwKKbZilz2P+scfxBlaz+5X5+7 OYyTQ39iUnKr+KpUJuXnOvi0qihgL2fYx3mj/UoO9XkC3QFJ/knB8pukV/BykodJQKWMDpCFiP/MF Qn9p1QwTyadTMKmLInyqoy2QF4BNaO2Uy8hbQPDmJqKUyJAc0g2c8qx/alBdFQ+niKnRaymer78Bh EbOWTZ6gutLEXYDBo9E+wg==; Date: Sat, 04 May 2024 20:34:47 +0300 Message-Id: <8634qxfpl4.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <f4a9c2a7-efbf-4241-8c2b-5b1b04be584c@HIDDEN> (message from Dmitry Gutov on Sat, 4 May 2024 20:22:39 +0300) Subject: Re: bug#70577: [PATCH] New command other-project-prefix References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> <86jzkhe81b.fsf@HIDDEN> <208c7a05-6cfe-40c2-af54-187967348686@HIDDEN> <86le4tz88d.fsf@HIDDEN> <c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN> <86ttjeghtt.fsf@HIDDEN> <f4a9c2a7-efbf-4241-8c2b-5b1b04be584c@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org, juri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Sat, 4 May 2024 20:22:39 +0300 > Cc: juri@HIDDEN, 70577 <at> debbugs.gnu.org > From: Dmitry Gutov <dmitry@HIDDEN> > > Some ideas regarding 'C-h' behaving differently from the usual would be > welcome, too. You mean, what help--append-keystrokes-help does? For that to work, C-h should have no binding in the last keymap, AFAIR.
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 4 May 2024 17:23:14 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 04 13:23:13 2024 Received: from localhost ([127.0.0.1]:54799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s3J6P-0006JM-Kv for submit <at> debbugs.gnu.org; Sat, 04 May 2024 13:23:13 -0400 Received: from fout1-smtp.messagingengine.com ([103.168.172.144]:43087) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1s3J6N-0006JB-Rq for 70577 <at> debbugs.gnu.org; Sat, 04 May 2024 13:23:12 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfout.nyi.internal (Postfix) with ESMTP id 63DA81380119; Sat, 4 May 2024 13:22:43 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 04 May 2024 13:22:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1714843363; x=1714929763; bh=kvEt8+RCtxq2GVXmWb1ok1jtTjpc5pZqZd3DhOhA4vk=; b= MuyCFcd4+ZN8QVgrNFRaek0feBRHbJh0j1YIE1EVFmJdw34z2JIOpE2OOUnaUYez 970wDr14W6m+eOwzIILeiztETmFTQU/PdceWcqVIZTPBF2r7eZgeUSmBghh3hJQT of2uspT4vzfLH+cHIN8dhTCojjWMXFKE9etqn9TK4iyPpE0spWCVVBJlOJxZ/80a 6BWGdQFfMEaGVZ1vqJ9iSdHbWKHFgAIGpj+F3pb1g5vv64p47DtMOWcDfHgGgvY5 1xdG86e9BcZNqD1i1G1D3CqCCtK2TLHFchdNLSbMC82xT9s5RQg2X+yF84yceBfN kQUjXz0CInUtdiFZpe1w5A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1714843363; x= 1714929763; bh=kvEt8+RCtxq2GVXmWb1ok1jtTjpc5pZqZd3DhOhA4vk=; b=B 5Ywv5RUhRiJw4lDUWY001HD7pxGUlhH3kymkz31V1uIfPStdz20JukiArD4pHz1b ddEt03qx4iRr1jfBLd3pZawuGq2svHbodzZVvMBEMwRjFhNBvGFndDSowUtyRQQg cGbYkXVCeddv+Gk3xDIn1fwt0QvgLmnwM/O2G9vhTllziPLc2WnZuidbmtqzFS6P eAN8PAd0AkWf37a5UBUWTwE0FX0mk9Fukhk0qX/howPJ9tHPnFHNqvr/5OPbuuqC vs7oZn8cILKPeXfX7BqAq+cGDH3WmVVz3nu0Ho7DYFpcw5g2qq0sJMQ4kEs5/Qep e3nagwgWuk1IejvP1r3hQ== X-ME-Sender: <xms:4242ZoImkt45TEwGK_AkVKVR99btf_rk-duAPEwq0o_Ct3PdTPrlBA> <xme:4242ZoJNoZatublEN5hFSHzNjD3o-N6ngHt5RD00sgqR2x64wH4meUqFw7HX1cqrM x_YCYeQ--RjftMR7Pg> X-ME-Received: <xmr:4242ZoskiTVeeyWphEP9uKtuCzy5ZCAxvSnrCRZlu7gOpMwaQAztaCVIg0SXFPCol3H4> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddvvddguddufecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomhepffhm ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg htthgvrhhnpeetudeljeegheetgfehgeejkeeuhedvveeikeeufedtvddtveefhfdvveeg udejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: <xmx:4242ZlbdQIFd4Zl3qATCX2BQzT9446YDt1TjXD4zK84b_X7Uve3FmQ> <xmx:4242ZvZFBSt3gMFo9HOBm4QWebtgu2FaFtSU4ghG0cYNc7ECSU8GaQ> <xmx:4242ZhBqyGH9bLe8fNN5x29q-RMKpntlxzu0vjTF6LGhTQPbEV5mgQ> <xmx:4242ZlYa_cqFCM32ko-gq2fBa9JD8OfdxNIpkBF2cnmjJjv7EvUIsQ> <xmx:4242ZrEBrj44YXtVtctVXcm29DBOI5T7WHwiQlJk05kmx69PC1CRwzY8> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 4 May 2024 13:22:41 -0400 (EDT) Message-ID: <f4a9c2a7-efbf-4241-8c2b-5b1b04be584c@HIDDEN> Date: Sat, 4 May 2024 20:22:39 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70577: [PATCH] New command other-project-prefix To: Eli Zaretskii <eliz@HIDDEN> References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> <86jzkhe81b.fsf@HIDDEN> <208c7a05-6cfe-40c2-af54-187967348686@HIDDEN> <86le4tz88d.fsf@HIDDEN> <c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN> <86ttjeghtt.fsf@HIDDEN> Content-Language: en-US From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <86ttjeghtt.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org, juri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On 04/05/2024 10:24, Eli Zaretskii wrote: >> Cc:70577 <at> debbugs.gnu.org >> Date: Sat, 4 May 2024 05:12:39 +0300 >> From: Dmitry Gutov<dmitry@HIDDEN> >> >> +(defun other-project-prefix () >> + "\"Switch\" to another project before running an Emacs command. >> +Makes sure the next command invoked asks for the project to run it in." > This last sentence reads awkwardly and confusingly. Suggest to reword > > The next command you invoke will prompt for the project in which to > run the command. Thanks, that sounds good. Some ideas regarding 'C-h' behaving differently from the usual would be welcome, too.
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 4 May 2024 07:25:20 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 04 03:25:20 2024 Received: from localhost ([127.0.0.1]:51749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s39ln-0006zt-RB for submit <at> debbugs.gnu.org; Sat, 04 May 2024 03:25:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1s39ll-0006zd-IU for 70577 <at> debbugs.gnu.org; Sat, 04 May 2024 03:25:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1s39lI-0004WK-QJ; Sat, 04 May 2024 03:24:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xdaXZBqWiweRvSZuYJva2cwrxQzr+2Pqs+4nsOtq7l4=; b=D2s41uH4cFjV sti/TzSYKUjXkTfxbHQyPM0F2j3RLd2dAT6UZNCb6ZEoTWPHuymoDG62ISlPSXx3AYDLnVq1mDOte 6TMYq5Hv9yfG+11iZZfN23/AD0PklzZtLeaJdYqUk2Zsvz/v0z2bSOPerNJYGvMZA1kLZtmTPX91g AFe4F5FKcsIWkCZkYVWkba7AsLuGk/h4uYXphDx8YASvcm1+WSUqL/ya1KDxOY2omwgE6DjHBJipj k2q7hsyxGhNgWYb8WTyh3+vRgUQ3U0Adv98y0ftaJk8orQf460/QnRSlZydrtYIuYdRzKnbI4BPBP 6oWQSekSoiGVwOW63vJ+/w==; Date: Sat, 04 May 2024 10:24:46 +0300 Message-Id: <86ttjeghtt.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN> (message from Dmitry Gutov on Sat, 4 May 2024 05:12:39 +0300) Subject: Re: bug#70577: [PATCH] New command other-project-prefix References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> <86jzkhe81b.fsf@HIDDEN> <208c7a05-6cfe-40c2-af54-187967348686@HIDDEN> <86le4tz88d.fsf@HIDDEN> <c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org, juri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: 70577 <at> debbugs.gnu.org > Date: Sat, 4 May 2024 05:12:39 +0300 > From: Dmitry Gutov <dmitry@HIDDEN> > > +(defun other-project-prefix () > + "\"Switch\" to another project before running an Emacs command. > +Makes sure the next command invoked asks for the project to run it in." This last sentence reads awkwardly and confusingly. Suggest to reword The next command you invoke will prompt for the project in which to run the command. Thanks.
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 4 May 2024 02:13:15 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 03 22:13:15 2024 Received: from localhost ([127.0.0.1]:50520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s34tm-0000a5-N8 for submit <at> debbugs.gnu.org; Fri, 03 May 2024 22:13:15 -0400 Received: from wfhigh2-smtp.messagingengine.com ([64.147.123.153]:35207) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1s34tk-0000Zm-Hp for 70577 <at> debbugs.gnu.org; Fri, 03 May 2024 22:13:14 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfhigh.west.internal (Postfix) with ESMTP id 425FB180010A; Fri, 3 May 2024 22:12:43 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 03 May 2024 22:12:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1714788762; x=1714875162; bh=BjMMOXFWyg a+mZ02qPlPcV3z2OClmpXtE/UH/nkNqd8=; b=eI3ZtofwYseXkKj99Eyi64ODmW EgQsk3CPUJ7B7EKaI18TlR2kNrwdgm7M7Xk8gJv3UTllCvojioaCCRH8M6FjHSwc /rLXNyVq5mDfHhtDQLvqnhfVG5J3uWV1GFmc4PZZ54VEudBgKoZnELXO8Gl7sP1Z HewPR4zPPioW8V2kyRBJb0pb3oKNveGtKwPsQL5yivOpnlA+ehHkPXmUuol6Q+7C u5UuJaPGRVFKaRQ/4jWe53vyYysSmSFKVvY2iWaEcEDVX8OfPjq1Cv/lQccgmbht Ay78ApMD721CP4aU9oKoE15y9/XGoEPWFP+JZEL7tDEfbHQS7YrdLAZc5W5A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1714788762; x=1714875162; bh=BjMMOXFWyga+mZ02qPlPcV3z2OCl mpXtE/UH/nkNqd8=; b=clgUZgEjcWAdmhfRWQ2wdBIt6Gos5b7QROKGf4RmRzDc J6De1IkVSKnmJAt1XAAppcAn/SGiHyHwrDZZGP7J5EXk9r1FA1xdtxwj9u3n+eCs ZtEr306tJr4X8OySkdenyCx4Qtz3WOT87YHi/5N3+du+ggfDTNO5ornoggwrtWtQ KiyJidB6G3qbLRgr4sH/g9cs7idMapaztmbClBjfesicEDHBVS8MP+DoZdaWralr fwiWGALshJXIBSvEMsDxjzJWufCz6OgcNAECvOC1hVypucyX9KUjQYR08YdB91bc rLfH+E98DqSVCVKoUfMLT6mqezb9n1h72aKh9PDI7w== X-ME-Sender: <xms:mpk1Zrl6HGdGgSiWHVvUpsJyXwZlZWPGXzYCfub3XFygViSJD8xtZA> <xme:mpk1Zu2S5FWUmOFFq2Lzlq9Xh-MAgfdVtNOJUFM1OYqWm7FtEvfn3RMrmrDjJu_0Z 341DJHUnZlnoEssIfE> X-ME-Received: <xmr:mpk1ZhrVL96T-oYxlYPs56jRl2mXtE9PBYWTtHoINRcJ-RPfiNz1-YsSzKi5V1i29D2M> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddvuddgheehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfkffggfgfuvfevfhfhjgesmhdtreertddvjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeelkeejiedvffdtgeejvdffffelueelkefhtdekjeehuefgteduheegfefhieek jeenucffohhmrghinhepghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpegumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: <xmx:mpk1ZjmErtj3-18wEBABjiTdGe9cLgsHFih3tsu0c9FBtYjUlI6z4w> <xmx:mpk1Zp1G6ZsGNhcnoJYcaMG_r5J_N_HWMf7YeUomWetjPk-e1HNvEQ> <xmx:mpk1Ziu7ZreJne14n9ehKJosgHxGeYPxBiMen45RV6kKawtbzjmlUw> <xmx:mpk1ZtXkJ6urYuSMBG2HwpbHOvtGB2iX6-bUHbHdTE5qerk5zjXPxw> <xmx:mpk1ZnCqaXAl8e6IXEMBinHnazewCds0nwb9146pQ209dnpOzh6uM-fx> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 3 May 2024 22:12:41 -0400 (EDT) Content-Type: multipart/mixed; boundary="------------SR53G2cSRWmqGKgrT2IPY09P" Message-ID: <c062e78a-6145-4ea5-baa7-27d948f8a758@HIDDEN> Date: Sat, 4 May 2024 05:12:39 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70577: [PATCH] New command other-project-prefix To: Juri Linkov <juri@HIDDEN> References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> <86jzkhe81b.fsf@HIDDEN> <208c7a05-6cfe-40c2-af54-187967348686@HIDDEN> <86le4tz88d.fsf@HIDDEN> Content-Language: en-US From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <86le4tz88d.fsf@HIDDEN> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------SR53G2cSRWmqGKgrT2IPY09P Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02/05/2024 09:12, Juri Linkov wrote: >>> Something is wrong here. I bound 'other-project-prefix' to 'C-x p P'. >>> Then typing 'C-x p P C-x d' asked a directory name, then later >>> after selecting a project asked for the directory name again. >> >> Looks like that has to do with the interactive spec. See the attached next >> revision, it seems to behave better. > > Thanks, this works now (except that it can't be debugged because of the > Lisp error: (wrong-type-argument listp ignore)). > > Also 'C-h' is not a problem: 'help-form-show' does nothing > without 'help-form', but with 'help-form' works fine: > > (define-key map (vector help-char) > (lambda () > (interactive) > (let ((help-form "You can use any global keybinding.")) > (help-form-show)))) We would want 'C-h' to show the regular buffer with key bindings, won't we? With similar output to the one that we get after 'C-x p C-h' or 'C-x v C-h'. The output might be weirder because of the composed keymap, but it could still be useful. Also, with which-key-mode, C-h would do its thing. > However, a much bigger problem is that unfortunately many test cases from > https://debbugs.gnu.org/63648#203 are broken. For example, > 'C-x p p C-b' fails the same way as in bug#58784. > 'C-x p p f M-n' fails because it expects to read arguments > in a previous project with an old value of default-directory, etc. Thanks for noticing. Looks like the call to project-prompter can change the value of this-command, and that's why the subsequent check went down the wrong branch. See the attached v3 with the fix. > Maybe this could be fixed by running 'interactive' in a previous project > by using something like: > > (around-fun > (lambda (command &rest _args) > (interactive (lambda (spec) > (let ((default-directory prev-dir)) > (advice-eval-interactive-spec spec)))) I think the command might rather expect to be called in the "new" project. And also while some have interactive specs with significant logic inside, others don't; introducing a difference there could cause more problems. --------------SR53G2cSRWmqGKgrT2IPY09P Content-Type: text/x-patch; charset=UTF-8; name="other-project-prefix-v3.diff" Content-Disposition: attachment; filename="other-project-prefix-v3.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwgYi9saXNwL3Byb2dtb2Rl cy9wcm9qZWN0LmVsCmluZGV4IDAwMGEwNTgwNGE4Li4xZWU2ZTU4NDhhMyAxMDA2NDQKLS0t IGEvbGlzcC9wcm9nbW9kZXMvcHJvamVjdC5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9wcm9q ZWN0LmVsCkBAIC05NTIsNiArOTUyLDQ4IEBAIHByb2plY3Qtb3RoZXItdGFiLWNvbW1hbmQK ICh3aGVuIChib3VuZC1hbmQtdHJ1ZS1wIHRhYi1wcmVmaXgtbWFwKQogICAoZGVmaW5lLWtl eSB0YWItcHJlZml4LW1hcCAicCIgIydwcm9qZWN0LW90aGVyLXRhYi1jb21tYW5kKSkKIAor Ozs7IyMjYXV0b2xvYWQKKyhkZWZ1biBvdGhlci1wcm9qZWN0LXByZWZpeCAoKQorICAiXCJT d2l0Y2hcIiB0byBhbm90aGVyIHByb2plY3QgYmVmb3JlIHJ1bm5pbmcgYW4gRW1hY3MgY29t bWFuZC4KK01ha2VzIHN1cmUgdGhlIG5leHQgY29tbWFuZCBpbnZva2VkIGFza3MgZm9yIHRo ZSBwcm9qZWN0IHRvIHJ1biBpdCBpbi4iCisgIChpbnRlcmFjdGl2ZSkKKyAgKHByZWZpeC1j b21tYW5kLXByZXNlcnZlLXN0YXRlKQorICAobGV0cmVjICgoZGVwdGggKG1pbmlidWZmZXIt ZGVwdGgpKQorICAgICAgICAgICAoZWNob2Z1biAobGFtYmRhICgpICJbc3dpdGNoLXByb2pl Y3RdIikpCisgICAgICAgICAgIChhcm91bmQtZnVuCisgICAgICAgICAgICAobGFtYmRhIChj b21tYW5kICZyZXN0IF9hcmdzKQorICAgICAgICAgICAgICAoaW50ZXJhY3RpdmUpCisgICAg ICAgICAgICAgIChhZHZpY2UtcmVtb3ZlIHRoaXMtY29tbWFuZCBhcm91bmQtZnVuKQorICAg ICAgICAgICAgICAodW5sZXNzIChvciAoZXEgdGhpcy1jb21tYW5kICdvdGhlci1wcm9qZWN0 LXByZWZpeCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgKGVxIGxhc3QtY29tbWFuZC1l dmVudCBoZWxwLWNoYXIpKQorICAgICAgICAgICAgICAgIChsZXQqICgodGhpcy1jb21tYW5k LXNhdmVkIHRoaXMtY29tbWFuZCkKKyAgICAgICAgICAgICAgICAgICAgICAgKHJvb3QgKGZ1 bmNhbGwgcHJvamVjdC1wcm9tcHRlcikpKQorICAgICAgICAgICAgICAgICAgKGlmIChvciAo c3RyaW5nLXByZWZpeC1wICJwcm9qZWN0LSIKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAoc3ltYm9sLW5hbWUgdGhpcy1jb21tYW5kLXNhdmVkKSkKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgKGdldCB0aGlzLWNvbW1hbmQtc2F2ZWQgJ3Byb2pl Y3QtYXdhcmUpKQorICAgICAgICAgICAgICAgICAgICAgIChsZXQgKChwcm9qZWN0LWN1cnJl bnQtZGlyZWN0b3J5LW92ZXJyaWRlIHJvb3QpKQorICAgICAgICAgICAgICAgICAgICAgICAg KGNhbGwtaW50ZXJhY3RpdmVseSBjb21tYW5kKSkKKyAgICAgICAgICAgICAgICAgICAgKGxl dCAoKGRlZmF1bHQtZGlyZWN0b3J5IHJvb3QpKQorICAgICAgICAgICAgICAgICAgICAgIChj YWxsLWludGVyYWN0aXZlbHkgY29tbWFuZCkpKSkpKSkKKyAgICAgICAgICAgKHByZWZ1bgor ICAgICAgICAgICAgKGxhbWJkYSAoKQorICAgICAgICAgICAgICAodW5sZXNzICg+IChtaW5p YnVmZmVyLWRlcHRoKSBkZXB0aCkKKyAgICAgICAgICAgICAgICAocmVtb3ZlLWhvb2sgJ3By ZS1jb21tYW5kLWhvb2sgcHJlZnVuKQorICAgICAgICAgICAgICAgIChyZW1vdmUtaG9vayAn cHJlZml4LWNvbW1hbmQtZWNoby1rZXlzdHJva2VzLWZ1bmN0aW9ucyBlY2hvZnVuKQorICAg ICAgICAgICAgICAgICh3aGVuIChhbmQgdGhpcy1jb21tYW5kIChzeW1ib2xwIHRoaXMtY29t bWFuZCkpCisgICAgICAgICAgICAgICAgICAoYWR2aWNlLWFkZCB0aGlzLWNvbW1hbmQgOmFy b3VuZCBhcm91bmQtZnVuKSkpKSkpCisgICAgKGFkZC1ob29rICdwcmUtY29tbWFuZC1ob29r IHByZWZ1bikKKyAgICAoYWRkLWhvb2sgJ3ByZWZpeC1jb21tYW5kLWVjaG8ta2V5c3Ryb2tl cy1mdW5jdGlvbnMgZWNob2Z1bikKKyAgICAobGV0ICgobWFwIChtYWtlLXNwYXJzZS1rZXlt YXApKSkKKyAgICAgIChzZXQta2V5bWFwLXBhcmVudCBtYXAgcHJvamVjdC1wcmVmaXgtbWFw KQorICAgICAgOzsgRG9lc24ndCB3b3JrIDstKAorICAgICAgOzsgKGRlZmluZS1rZXkgbWFw ICh2ZWN0b3IgaGVscC1jaGFyKQorICAgICAgOzsgICAgICAgICAgICAgKGxhbWJkYSAoKSAo aW50ZXJhY3RpdmUpIChoZWxwLWZvcm0tc2hvdykpKQorICAgICAgKHNldC10cmFuc2llbnQt bWFwIG1hcCkpCisgICAgKG1lc3NhZ2UgKGNvbmNhdCAiVHlwZSAiIChwcm9qZWN0LS1rZXlt YXAtcHJvbXB0KSAiIG9yIGFueSBnbG9iYWwga2V5IikpKSkKKworOzsgKGRlZmluZS1rZXkg cHJvamVjdC1wcmVmaXgtbWFwIChrYmQgIlAiKSAjJ290aGVyLXByb2plY3QtcHJlZml4KQor CiAoZGVjbGFyZS1mdW5jdGlvbiBncmVwLXJlYWQtZmlsZXMgImdyZXAiKQogKGRlY2xhcmUt ZnVuY3Rpb24geHJlZi0tZmluZC1pZ25vcmVzLWFyZ3VtZW50cyAieHJlZiIpCiAK --------------SR53G2cSRWmqGKgrT2IPY09P--
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.
Received: (at 70577) by debbugs.gnu.org; 2 May 2024 06:19:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 02 02:19:36 2024
Received: from localhost ([127.0.0.1]:41756 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1s2Pn5-0004Dd-Qa
for submit <at> debbugs.gnu.org; Thu, 02 May 2024 02:19:36 -0400
Received: from relay1-d.mail.gandi.net ([217.70.183.193]:56837)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1s2Pn4-0004DJ-Ll
for 70577 <at> debbugs.gnu.org; Thu, 02 May 2024 02:19:35 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id 24942240006;
Thu, 2 May 2024 06:19:04 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Dmitry Gutov <dmitry@HIDDEN>
Subject: Re: bug#70577: [PATCH] New command other-project-prefix
In-Reply-To: <208c7a05-6cfe-40c2-af54-187967348686@HIDDEN> (Dmitry Gutov's
message of "Mon, 29 Apr 2024 00:40:00 +0300")
Organization: LINKOV.NET
References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN>
<86le501ykg.fsf@HIDDEN>
<a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN>
<e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN>
<86jzkhe81b.fsf@HIDDEN>
<208c7a05-6cfe-40c2-af54-187967348686@HIDDEN>
Date: Thu, 02 May 2024 09:12:18 +0300
Message-ID: <86le4tz88d.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 70577
Cc: 70577 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
>> Something is wrong here. I bound 'other-project-prefix' to 'C-x p P'.
>> Then typing 'C-x p P C-x d' asked a directory name, then later
>> after selecting a project asked for the directory name again.
>
> Looks like that has to do with the interactive spec. See the attached next
> revision, it seems to behave better.
Thanks, this works now (except that it can't be debugged because of the
Lisp error: (wrong-type-argument listp ignore)).
Also 'C-h' is not a problem: 'help-form-show' does nothing
without 'help-form', but with 'help-form' works fine:
(define-key map (vector help-char)
(lambda ()
(interactive)
(let ((help-form "You can use any global keybinding."))
(help-form-show))))
However, a much bigger problem is that unfortunately many test cases from
https://debbugs.gnu.org/63648#203 are broken. For example,
'C-x p p C-b' fails the same way as in bug#58784.
'C-x p p f M-n' fails because it expects to read arguments
in a previous project with an old value of default-directory, etc.
Maybe this could be fixed by running 'interactive' in a previous project
by using something like:
(around-fun
(lambda (command &rest _args)
(interactive (lambda (spec)
(let ((default-directory prev-dir))
(advice-eval-interactive-spec spec))))
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 28 Apr 2024 21:40:32 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 28 17:40:32 2024 Received: from localhost ([127.0.0.1]:53032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s1CG8-0002Oc-Be for submit <at> debbugs.gnu.org; Sun, 28 Apr 2024 17:40:32 -0400 Received: from fout2-smtp.messagingengine.com ([103.168.172.145]:40631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1s1CG5-0002OU-24 for 70577 <at> debbugs.gnu.org; Sun, 28 Apr 2024 17:40:31 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfout.nyi.internal (Postfix) with ESMTP id F19651380228; Sun, 28 Apr 2024 17:40:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sun, 28 Apr 2024 17:40:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1714340403; x=1714426803; bh=hicaaXjB5w TfyEUnIGSJw/ogEtlS9BRZp9hMskS3REE=; b=BJnsbYf9XVWra+8O/m7U1ioVsL +uLs1Q/JOoe4Z4HTEgpEvD422NxH6+UwNbwK3PwM3l3CRdL982+1HTRom5iOWCBq 5Ys+sB9CTH7f3VFv2QPY0pmupu3OprMxzmva57HP0kIh9NTQIQVlxFxUebOgY/0x xXUPJanCnuz/62YEJf/EDKps/WWcxurd2ZTRQdDCbwmt99JunmcsLLOdWnynUpF7 mgvMIv9u1/1irbKewCZWthV2r5EUHnIiXdg8Bizdm+8c6PaMo34CJJWhcWzkVJ8z KDSzF/jZEJrYKDmd4XuSKylNHWV34CO0YnfYrVgUCyFED9v3SW03gcJLMc1Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1714340403; x=1714426803; bh=hicaaXjB5wTfyEUnIGSJw/ogEtlS 9BRZp9hMskS3REE=; b=UWPEQtbJtybxl7QZg9L+8Ld1jKu5tBF2ROJeOF1qosgr msaA9c8TigwI/7iyU4NI3I/ezRaQgTrpycAGaTXwvCdvSji0fxhNP7Flpzx7nGSR qtRUD0pDiCa/BspMK9O5vDnwXGawIPDlAvJ0QAWdBNO5Q52l8b+RG9Djr/VKF0wh oaTyPskjiNkJOc8U68acCT8X479hRdaZzIynpU1KPjK/GJHKB9lLfTXjpR2UN1gw 2recJgHEMLLQNlBk15sYCJulgWADq28NSOMGfF4sDBc5bkI9j/5uE7xvSSdF/lH6 LDjGj5vMgiODacgKjGqc0LCgdvsr62QaqnBhgspUjA== X-ME-Sender: <xms:M8IuZlcaRQ-AmG3QrpnjBW4fQCkcA9ksGeSBgTs9SIjTgw5AuXyrpA> <xme:M8IuZjN9QJh1bN-J6G22pBWb0JhAO7aDXuzYTwl6QU0UFIlW4IT-vi_fGmExHI9gS S6ZqHq_KnbjlV4CV_Q> X-ME-Received: <xmr:M8IuZuh4VWApW1KKdUZIKiwPHzaO0okvHk_NoIz21FfzPhGhpas3Xp1PxquaB_XtyzjS> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddthedgfeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfkffggfgfuvfevfhfhjgesmhdtreertddvjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeelkeejiedvffdtgeejvdffffelueelkefhtdekjeehuefgteduheegfefhieek jeenucffohhmrghinhepghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpegumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: <xmx:M8IuZu9WyLnmUaP9FlH78fUj4IYTWABkRwK5tF7HJkXdmm_RdDD0qw> <xmx:M8IuZhuC_7r1N4WjgUtUjgRbnqdaFlBP6veAjpVOFw0yciW_oeD4Cw> <xmx:M8IuZtFDeQmpBXWyDLnPfdGN8BDGv0oIU7MsYDtAtrpcd3LIOCUbYA> <xmx:M8IuZoM32TCP48YrrYnCi0X7ZdXI1HIgjG-fXtTcELjpT8uBTMl_Zw> <xmx:M8IuZq6XcBxGeWgoH-ZuC8SfmA7sAmWduU1hCYxnlI-iAwYaNBJZMuEd> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 28 Apr 2024 17:40:02 -0400 (EDT) Content-Type: multipart/mixed; boundary="------------mEOiBgdDWQVL9T0Tqp4wyU0z" Message-ID: <208c7a05-6cfe-40c2-af54-187967348686@HIDDEN> Date: Mon, 29 Apr 2024 00:40:00 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70577: [PATCH] New command other-project-prefix To: Juri Linkov <juri@HIDDEN> References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> <86jzkhe81b.fsf@HIDDEN> Content-Language: en-US From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <86jzkhe81b.fsf@HIDDEN> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------mEOiBgdDWQVL9T0Tqp4wyU0z Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 28/04/2024 19:51, Juri Linkov wrote: >> On 26/04/2024 13:59, Dmitry Gutov wrote: >>> On 26/04/2024 09:09, Juri Linkov wrote: >>>>> This is based on Juri's patch in >>>>> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63648#161, but the idea is >>>>> more focused: to switch the order of events, and first read the full key >>>>> sequence, and then prompt for the project and the command >>>>> arguments. Like >>>>> we also discussed in the past. >>>> >>>> I'm not a fan of reading the full key sequence bypassing the event loop. >>> That's what the current code does. While the patch tries to change that. >> >> Sorry, I forgot to attach the actual patch. > > Thanks. > >> +(defun other-project-prefix () > > Something is wrong here. I bound 'other-project-prefix' to 'C-x p P'. > Then typing 'C-x p P C-x d' asked a directory name, then later > after selecting a project asked for the directory name again. Looks like that has to do with the interactive spec. See the attached next revision, it seems to behave better. > Then some advice remains unremoved. Ok, will test more. I haven't noticed this particular problem, so please write down a repro if you find one. --------------mEOiBgdDWQVL9T0Tqp4wyU0z Content-Type: text/x-patch; charset=UTF-8; name="other-project-prefix-v2.diff" Content-Disposition: attachment; filename="other-project-prefix-v2.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwgYi9saXNwL3Byb2dtb2Rl cy9wcm9qZWN0LmVsCmluZGV4IDAwMGEwNTgwNGE4Li5mZWIzMWNhYmE0ZCAxMDA2NDQKLS0t IGEvbGlzcC9wcm9nbW9kZXMvcHJvamVjdC5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9wcm9q ZWN0LmVsCkBAIC05NTIsNiArOTUyLDQ3IEBAIHByb2plY3Qtb3RoZXItdGFiLWNvbW1hbmQK ICh3aGVuIChib3VuZC1hbmQtdHJ1ZS1wIHRhYi1wcmVmaXgtbWFwKQogICAoZGVmaW5lLWtl eSB0YWItcHJlZml4LW1hcCAicCIgIydwcm9qZWN0LW90aGVyLXRhYi1jb21tYW5kKSkKIAor Ozs7IyMjYXV0b2xvYWQKKyhkZWZ1biBvdGhlci1wcm9qZWN0LXByZWZpeCAoKQorICAiXCJT d2l0Y2hcIiB0byBhbm90aGVyIHByb2plY3QgYmVmb3JlIHJ1bm5pbmcgYW4gRW1hY3MgY29t bWFuZC4KK01ha2VzIHN1cmUgdGhlIG5leHQgY29tbWFuZCBpbnZva2VkIGFza3MgZm9yIHRo ZSBwcm9qZWN0IHRvIHJ1biBpdCBpbi4iCisgIChpbnRlcmFjdGl2ZSkKKyAgKHByZWZpeC1j b21tYW5kLXByZXNlcnZlLXN0YXRlKQorICAobGV0cmVjICgoZGVwdGggKG1pbmlidWZmZXIt ZGVwdGgpKQorICAgICAgICAgICAoZWNob2Z1biAobGFtYmRhICgpICJbc3dpdGNoLXByb2pl Y3RdIikpCisgICAgICAgICAgIChhcm91bmQtZnVuCisgICAgICAgICAgICAobGFtYmRhIChj b21tYW5kICZyZXN0IF9hcmdzKQorICAgICAgICAgICAgICAoaW50ZXJhY3RpdmUgIydpZ25v cmUpCisgICAgICAgICAgICAgIChhZHZpY2UtcmVtb3ZlIHRoaXMtY29tbWFuZCBhcm91bmQt ZnVuKQorICAgICAgICAgICAgICAodW5sZXNzIChvciAoZXEgdGhpcy1jb21tYW5kICdvdGhl ci1wcm9qZWN0LXByZWZpeCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgKGVxIGxhc3Qt Y29tbWFuZC1ldmVudCBoZWxwLWNoYXIpKQorICAgICAgICAgICAgICAgIChsZXQgKChyb290 IChmdW5jYWxsIHByb2plY3QtcHJvbXB0ZXIpKSkKKyAgICAgICAgICAgICAgICAgIChpZiAo b3IgKHN0cmluZy1wcmVmaXgtcCAicHJvamVjdC0iCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgKHN5bWJvbC1uYW1lIHRoaXMtY29tbWFuZCkpCisgICAg ICAgICAgICAgICAgICAgICAgICAgIChnZXQgdGhpcy1jb21tYW5kICdwcm9qZWN0LWF3YXJl KSkKKyAgICAgICAgICAgICAgICAgICAgICAobGV0ICgocHJvamVjdC1jdXJyZW50LWRpcmVj dG9yeS1vdmVycmlkZSByb290KSkKKyAgICAgICAgICAgICAgICAgICAgICAgIChjYWxsLWlu dGVyYWN0aXZlbHkgY29tbWFuZCkpCisgICAgICAgICAgICAgICAgICAgIChsZXQgKChkZWZh dWx0LWRpcmVjdG9yeSByb290KSkKKyAgICAgICAgICAgICAgICAgICAgICAoY2FsbC1pbnRl cmFjdGl2ZWx5IGNvbW1hbmQpKSkpKSkpCisgICAgICAgICAgIChwcmVmdW4KKyAgICAgICAg ICAgIChsYW1iZGEgKCkKKyAgICAgICAgICAgICAgKHVubGVzcyAoPiAobWluaWJ1ZmZlci1k ZXB0aCkgZGVwdGgpCisgICAgICAgICAgICAgICAgKHJlbW92ZS1ob29rICdwcmUtY29tbWFu ZC1ob29rIHByZWZ1bikKKyAgICAgICAgICAgICAgICAocmVtb3ZlLWhvb2sgJ3ByZWZpeC1j b21tYW5kLWVjaG8ta2V5c3Ryb2tlcy1mdW5jdGlvbnMgZWNob2Z1bikKKyAgICAgICAgICAg ICAgICAod2hlbiAoYW5kIHRoaXMtY29tbWFuZCAoc3ltYm9scCB0aGlzLWNvbW1hbmQpKQor ICAgICAgICAgICAgICAgICAgKGFkdmljZS1hZGQgdGhpcy1jb21tYW5kIDphcm91bmQgYXJv dW5kLWZ1bikpKSkpKQorICAgIChhZGQtaG9vayAncHJlLWNvbW1hbmQtaG9vayBwcmVmdW4p CisgICAgKGFkZC1ob29rICdwcmVmaXgtY29tbWFuZC1lY2hvLWtleXN0cm9rZXMtZnVuY3Rp b25zIGVjaG9mdW4pCisgICAgKGxldCAoKG1hcCAobWFrZS1zcGFyc2Uta2V5bWFwKSkpCisg ICAgICAoc2V0LWtleW1hcC1wYXJlbnQgbWFwIHByb2plY3QtcHJlZml4LW1hcCkKKyAgICAg IDs7IERvZXNuJ3Qgd29yayA7LSgKKyAgICAgIDs7IChkZWZpbmUta2V5IG1hcCAodmVjdG9y IGhlbHAtY2hhcikKKyAgICAgIDs7ICAgICAgICAgICAgIChsYW1iZGEgKCkgKGludGVyYWN0 aXZlKSAoaGVscC1mb3JtLXNob3cpKSkKKyAgICAgIChzZXQtdHJhbnNpZW50LW1hcCBtYXAp KQorICAgIChtZXNzYWdlIChjb25jYXQgIlR5cGUgIiAocHJvamVjdC0ta2V5bWFwLXByb21w dCkgIiBvciBhbnkgZ2xvYmFsIGtleSIpKSkpCisKKzs7IChkZWZpbmUta2V5IHByb2plY3Qt cHJlZml4LW1hcCAoa2JkICJQIikgIydvdGhlci1wcm9qZWN0LXByZWZpeCkKKwogKGRlY2xh cmUtZnVuY3Rpb24gZ3JlcC1yZWFkLWZpbGVzICJncmVwIikKIChkZWNsYXJlLWZ1bmN0aW9u IHhyZWYtLWZpbmQtaWdub3Jlcy1hcmd1bWVudHMgInhyZWYiKQogCg== --------------mEOiBgdDWQVL9T0Tqp4wyU0z--
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 28 Apr 2024 17:08:02 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 28 13:08:02 2024 Received: from localhost ([127.0.0.1]:51269 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s180P-0001Rn-EJ for submit <at> debbugs.gnu.org; Sun, 28 Apr 2024 13:08:02 -0400 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]:60005) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1s180K-0001RO-0I for 70577 <at> debbugs.gnu.org; Sun, 28 Apr 2024 13:07:58 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 191E9FF802; Sun, 28 Apr 2024 17:07:28 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Dmitry Gutov <dmitry@HIDDEN> Subject: Re: bug#70577: [PATCH] New command other-project-prefix In-Reply-To: <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> (Dmitry Gutov's message of "Fri, 26 Apr 2024 19:20:58 +0300") Organization: LINKOV.NET References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> Date: Sun, 28 Apr 2024 19:51:04 +0300 Message-ID: <86jzkhe81b.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) > On 26/04/2024 13:59, Dmitry Gutov wrote: >> On 26/04/2024 09:09, Juri Linkov wrote: >>>> This is based on Juri's patch in >>>> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63648#161, but the idea is >>>> more focused: to switch the order of events, and first read the full key >>>> sequence, and then prompt for the project and the command >>>> arguments. Like >>>> we also discussed in the past. >>> >>> I'm not a fan of reading the full key sequence bypassing the event loop. >> That's what the current code does. While the patch tries to change that. > > Sorry, I forgot to attach the actual patch. Thanks. > +(defun other-project-prefix () Something is wrong here. I bound 'other-project-prefix' to 'C-x p P'. Then typing 'C-x p P C-x d' asked a directory name, then later after selecting a project asked for the directory name again. Then some advice remains unremoved. Ok, will test more.
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 28 Apr 2024 15:57:08 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 28 11:57:08 2024 Received: from localhost ([127.0.0.1]:50955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s16to-0000Zc-DI for submit <at> debbugs.gnu.org; Sun, 28 Apr 2024 11:57:08 -0400 Received: from fhigh2-smtp.messagingengine.com ([103.168.172.153]:50375) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1s16tm-0000ZF-HM for 70577 <at> debbugs.gnu.org; Sun, 28 Apr 2024 11:57:06 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 91AFB11400E2; Sun, 28 Apr 2024 11:56:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 28 Apr 2024 11:56:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1714319801; x=1714406201; bh=0B8bnQB40HVEtm5QShryeiee4j7Rm2ENLOpPyrUGFug=; b= LWaCikoHqKog2mXnFIOlpR5F4qcTSa24Ni4cPCuachUGpGXXJNdd0tW3U5c0fzF6 SLCXnmqs/kBZNgKecHifXI9G3xZBJnPBxiHGWcLqA4Q8DZhX610iWmcw+rubm/lF mvg3v0WTJy6aKUf15SCEjn2J7YCdlPP1O0T0amZiZvyeC/Z3yxEzg4t2oC/sO1sT vFq4/8xKVTSVKopkBrYVYhzGlor8vbYMSgIpZjWKV86n400vcG1yU4VfmlCXkZry bojcmmTst4Hi0bwNPH/FvdfHzQ0FYujqa6FkDTYrBPPJ+cAQfbxroXmspnO6BE47 BPaXnXHLdDo3zoYcphkAzw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1714319801; x= 1714406201; bh=0B8bnQB40HVEtm5QShryeiee4j7Rm2ENLOpPyrUGFug=; b=C JvHEE1QhFNi2KHVXWRwBhisc0mEi0rAxbozb62OUSxxracZOrdZEPPsul6OLhngN cbKgxfvZ+jpT8etERrc0+aF9GpfT3dBOXEJ3+Z095cYvxJZj/LQJJLKOoL74hSYw l6w6dSeEzaqivCHaFXi33PnofQHs/Iufqz4gmuh8O2vxwS6t95XcSom76HcwgdO2 3TgqkTDr4NGtfvGGVTnj9A8Fh6J+z3Jvz7wxujfF/DZIyxu3eWMj3GYYQE180G4K ltDfCHZnaALfuNgjIXbSJNrNsn8lqKCEqalu9sipfFoIgGJh7oAtKJSCprC8aAa+ sjuZelQUTnOfCybfnpG3w== X-ME-Sender: <xms:uXEuZpfshWOVCtGQ-ApY2ZkkAToVAm6yUI5oGc_kt8o5IXDo0p6UqA> <xme:uXEuZnOCvwe_bfBSKgD-_QrRYdduhI1ejPzFP-02sNjhYkmz-2NhT_ZNZWLRcY2Db lL_dxfurM81HsEXOxk> X-ME-Received: <xmr:uXEuZig1Ik_g9R2sEunXaHJxNNHuADSkL8bJeaHcUfenU3nBiYOwHAfRkicja1pLkgz_> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddtgedguddukecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomhepffhm ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg htthgvrhhnpeetudeljeegheetgfehgeejkeeuhedvveeikeeufedtvddtveefhfdvveeg udejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: <xmx:uXEuZi_-FWOC0uuuJStXYP7EQiPNGJEDCqj_iTsSWdo9SrjuJ2fZlA> <xmx:uXEuZls4U0T6va2tWDUrlRVSrJ9iErdjjoOvDOMCo4-hS7aNOPgk4w> <xmx:uXEuZhFd2zr3iHPKEWnkAktH0Esi_8Bz-RnXLmrzUXmu2cm0Uoxh6g> <xmx:uXEuZsN3TSFQUMmxvDWgOKxY7ELTkApOEmwoc2iF3560BWjiDk2wYg> <xmx:uXEuZvIbfynSY-Uo3KRAE5xNXBoQRAtotuJRLlfpM9rp3rCi2FX5R75L> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 28 Apr 2024 11:56:39 -0400 (EDT) Message-ID: <eb84dd4a-ab93-49bc-8a09-bcb7e58d7403@HIDDEN> Date: Sun, 28 Apr 2024 18:56:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70577: [PATCH] New command other-project-prefix To: Sean Whitton <spwhitton@HIDDEN>, Juri Linkov <juri@HIDDEN>, emacs-devel@HIDDEN References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> <87wmohlm7a.fsf@HIDDEN> Content-Language: en-US From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <87wmohlm7a.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On 28/04/2024 15:13, Sean Whitton wrote: > In passing, this pattern where you letrec a hook that removes itself, > and also consider minibuffer-depth, is now in several places. > The one I am thinking of is vc-edit-next-command but I based that on > some code of Juri's somewhere. > > It would be good to factor out a macro for this pattern, I think. Makes sense. Maybe a helper function, not necessarily a macro.
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 28 Apr 2024 12:13:44 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 28 08:13:44 2024 Received: from localhost ([127.0.0.1]:50240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s13Pb-0000NC-MP for submit <at> debbugs.gnu.org; Sun, 28 Apr 2024 08:13:44 -0400 Received: from wfout5-smtp.messagingengine.com ([64.147.123.148]:34819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>) id 1s13PZ-0000N4-7v for 70577 <at> debbugs.gnu.org; Sun, 28 Apr 2024 08:13:42 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfout.west.internal (Postfix) with ESMTP id 4101A1C000FD; Sun, 28 Apr 2024 08:13:15 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 28 Apr 2024 08:13:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1714306394; x= 1714392794; bh=pJxBkUWzzeEO/0Mge+GkWdxc7uszPwMGfEffQU86lOI=; b=j EPjr1/pVIuakocWSuf8QYJILEAW9FxRlGgzNO4VUJQH2sZO1JClW4kJqY5rRBLEu xNZtfSYhRYkoW078aGnBf3s8CpvQTMU2GbQNFpIiVWmN6V9d+25uhKy+aZ1/6QX8 IPATMhjLDAGhElwdo8VZ1DhPtDxxMWMbYActKBogoNun8f5T+eVmzDdxCb2DcduD gKIFIT3gE/0dsGgzIN82Gs5qxgFc9aXpni+Ta15F+wVtQ6ln04W2onLWTWZ/rvIz a7d/dx93S4WKSyuJezqWIoyEmc0VPrufxGRNxFnq3cLvHIrvD2bt1AGLEvG0N5dv 9Pcr/idKmBg8AtH/QYPCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1714306394; x=1714392794; bh=pJxBkUWzzeEO/0Mge+GkWdxc7usz PwMGfEffQU86lOI=; b=TayIWUaHU6Rs5C7rV2wMSm2PE51EjdJY5PXRL6JKa+st F+Tl+ThkR/rjG0nBDdEfbvnLcRxC+kwkM71l166mmJVMTCaRmfNGpMo/pYRExw5p FO53MQ5npcW+nyKnOp/t3qEumPVxmplkgH5zefaBaHiJBCpoPdF+SjeNqVN8zTjS 8tO9asgzabzppTAKvHdzAV8Op/xINkdQF+ZqoQ7XjfrnhvcQTdW/oRIdg52he/BK CbM831sYfiIlvjvTiYaQWqBTKzgWMvIaF0HmfPvhna7QDBpKN6yF5Bk4clHmFjRF 7c/MBBnII+11ubnCdjFo2u2LEaE9u/R7/sxlDF5Y4A== X-ME-Sender: <xms:Wj0uZhfTS7xhYfTBzS9qptPA3UNKAcK8QScYFMSqA6u50pfUkiudSw> <xme:Wj0uZvOmGR_ws_mlUufGN8eHOGHTF0VD7J24xOY4EGf65muupBldpo0Dt3xoRYuAn eArTYAXi8uSB8SsGQ> X-ME-Received: <xmr:Wj0uZqi_TuPoftCuq3Sl7YPb6IMixQl3S__Hed0xpNkOJ9oboBmpm_wmpNZZtSiZyL3m5sI0MUHjPK6t90CFGm4YQc_dCmwnJrg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddtgedgjeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedtffdvffeuleeuvdetkedvveehgfehvdegvefghfevudek geegleevgeejkeetkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: <xmx:Wj0uZq_2eywd9ZROu-9CpUo_pNqlqWYhbE5TyS19ZJae1-G2EKmSWQ> <xmx:Wj0uZtsGAbg_z0ykkR7xcKBozUBeW1RkJvb3q5XcwpocqrqQFaBcCg> <xmx:Wj0uZpFJYwGmCYlv_MSmAs4r1syLLO2ORwOeJY5ldDXXcBxxBfP8-Q> <xmx:Wj0uZkMqqM3iSdu-poCJHLjJDM4SemUgsAlushT8ZJldLXCOkkAyJA> <xmx:Wj0uZnKejQLUg9ItpcJIuHqJs2Rkwliw-JOQv5TqdvoUp22taWTFm84c> Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 28 Apr 2024 08:13:14 -0400 (EDT) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 1C29794078C; Sun, 28 Apr 2024 13:13:13 +0100 (BST) From: Sean Whitton <spwhitton@HIDDEN> To: Dmitry Gutov <dmitry@HIDDEN>, Juri Linkov <juri@HIDDEN>, emacs-devel@HIDDEN Subject: Re: bug#70577: [PATCH] New command other-project-prefix In-Reply-To: <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> (Dmitry Gutov's message of "Fri, 26 Apr 2024 19:20:58 +0300") References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> Date: Sun, 28 Apr 2024 13:13:13 +0100 Message-ID: <87wmohlm7a.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.7 (/) Hello, On Fri 26 Apr 2024 at 07:20pm +03, Dmitry Gutov wrote: > +;;;###autoload > +(defun other-project-prefix () > + "\"Switch\" to another project before running an Emacs command. > +Makes sure the next command invoked asks for the project to run it in." > + (interactive) > + (prefix-command-preserve-state) > + (letrec ((depth (minibuffer-depth)) > + (echofun (lambda () "[switch-project]")) > + (around-fun > + (lambda (command &rest _args) > + (advice-remove this-command around-fun) > + (unless (or (eq this-command 'other-project-prefix) > + (eq last-command-event help-char)) > + (let ((root (funcall project-prompter))) > + (if (or (string-prefix-p "project-" > + (symbol-name this-command)) > + (get this-command 'project-aware)) > + (let ((project-current-directory-override root)) > + (call-interactively command)) > + (let ((default-directory root)) > + (call-interactively command))))))) > + (prefun > + (lambda () > + (unless (> (minibuffer-depth) depth) > + (remove-hook 'pre-command-hook prefun) > + (remove-hook 'prefix-command-echo-keystrokes-functions echofun) > + (when (and this-command (symbolp this-command)) > + (advice-add this-command :around around-fun)))))) > + (add-hook 'pre-command-hook prefun) > + (add-hook 'prefix-command-echo-keystrokes-functions echofun) > + (let ((map (make-sparse-keymap))) > + (set-keymap-parent map project-prefix-map) > + ;; Doesn't work ;-( > + ;; (define-key map (vector help-char) > + ;; (lambda () (interactive) (help-form-show))) > + (set-transient-map map)) > + (message (concat "Type " (project--keymap-prompt) " or any global key")))) In passing, this pattern where you letrec a hook that removes itself, and also consider minibuffer-depth, is now in several places. The one I am thinking of is vc-edit-next-command but I based that on some code of Juri's somewhere. It would be good to factor out a macro for this pattern, I think. -- Sean Whitton
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 26 Apr 2024 16:21:35 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Apr 26 12:21:34 2024 Received: from localhost ([127.0.0.1]:38268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s0OKJ-0001nT-5B for submit <at> debbugs.gnu.org; Fri, 26 Apr 2024 12:21:34 -0400 Received: from fout1-smtp.messagingengine.com ([103.168.172.144]:55063) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1s0OKE-0001l5-5K for 70577 <at> debbugs.gnu.org; Fri, 26 Apr 2024 12:21:28 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfout.nyi.internal (Postfix) with ESMTP id 48502138018E; Fri, 26 Apr 2024 12:21:02 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 26 Apr 2024 12:21:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1714148462; x=1714234862; bh=eUnshWd3yi /EKvss5vIPeSxCV4yUVcGpb2yo9aagyoM=; b=CQI/gXXvNow/CutZ8DjEZso9Jd KE1YiNi6KV/4x5rfzFqq1TJCU/hDK4GQyeNQM/uP8IY6hJovQbc4SbyrWYkrzBr3 eXhJ2wYaZWiXgYVcP7gBOjFuOmGbRij05j5Aycv3Xcb5Cp/ZMGWejTpu00ZF8DOj zv4nDdhZv4pYbkVj/3fSRxrt1q44BPAWMuAS0xhJTsKDwVhwylwt1/SOlnhcaeIJ gEBuZGVHkZncWdTiqHm4pF76WpmXPCLxb/v+7ZfDvm0FblUId/0AlF/zaaXB5VyD 4087XkbInVRPtSEWGNLGKIcU2AXX6AgyTNDrkKhPX6oCzpr/kt339Vey+bQw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1714148462; x=1714234862; bh=eUnshWd3yi/EKvss5vIPeSxCV4yU VcGpb2yo9aagyoM=; b=e2PU1a2vgrjQssLqafY/2RVAfs384PLqv4i13vwVajCn VATD1b6MG3Vm5PbwZBQzyfdZr1VXPhVH6v4TbJQpAXrQTeg+CxHnCAQ91rL/aiMZ Y8inJMzMT0kfEZ1z1s+aXBcyXjqWUro5K//X74n5LCF+FpnvrvbHd5NMAL/sDq5A XXXB6Y9Z26uUN0ZZLZcCxddaxJAmfR9KZY+aM80Y0boJlrBn29BsUubW4RTwgEQz m8lMDXYVIV3vmSPHHFRBUayg8+w0yisyEmUZxUmjbcpaDTwx0cVAnWMJQLEmOqek NyLDlGYM8fzsEz1+lJv6jXBe8SmJgZre4aVcJlCPxA== X-ME-Sender: <xms:btQrZoxujYhEn9JCot6R3vkMRYiMDc4LKtWj3BJRi36OygibiW93yw> <xme:btQrZsT1j86xKDDCZVBaSL5TElepMT-hdsNe7_weEqfCMS1IqQOV7R_Pmzyjiagti RopqOjZlYIT8lDJrH0> X-ME-Received: <xmr:btQrZqUUKsryt12LLFA-J9rdHN6lBLGdIF3UDzh0zuGhM4zhC-Omj3KxwUCErEMJIp-5> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudelledguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpegtkfffgggfuffhvfevfhgjsehmtderredtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepteeijeekvefgffekfeevteetvdetuedtffeggfejieehjedvteffvddvtdfh ieegnecuffhomhgrihhnpehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: <xmx:btQrZmh0dkWF4uCAOxglhMd4VrWibXn6RO91S1hzoqMtM7bsQbfELw> <xmx:btQrZqDEKLwS2f83tme8ql6z023b0s_bb8_zs0fN3NXLsoH5zKPRRQ> <xmx:btQrZnIUakISyAOCIyOC5ziyYSs5hO8Yh0hPNSGp3avMsI2pXvMYGg> <xmx:btQrZhCyPr0xyL3Z9fUuVklnTaoXul-QwRO7P0GlzwrabxEwolD1OQ> <xmx:btQrZtPFSxvTa1qMRbbZuDzva7VeYuyGWaB2jw1bDSMDCuyWKvZe7sea> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 26 Apr 2024 12:21:01 -0400 (EDT) Content-Type: multipart/mixed; boundary="------------DwwbCwGLnptzvq3ZW0N0VJR4" Message-ID: <e2d31f31-c6e2-4f1a-81fb-0e222096878e@HIDDEN> Date: Fri, 26 Apr 2024 19:20:58 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70577: [PATCH] New command other-project-prefix From: Dmitry Gutov <dmitry@HIDDEN> To: Juri Linkov <juri@HIDDEN> References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> Content-Language: en-US In-Reply-To: <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------DwwbCwGLnptzvq3ZW0N0VJR4 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 26/04/2024 13:59, Dmitry Gutov wrote: > On 26/04/2024 09:09, Juri Linkov wrote: >>> This is based on Juri's patch in >>> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63648#161, but the idea is >>> more focused: to switch the order of events, and first read the full key >>> sequence, and then prompt for the project and the command arguments. >>> Like >>> we also discussed in the past. >> >> I'm not a fan of reading the full key sequence bypassing the event loop. > > That's what the current code does. While the patch tries to change that. Sorry, I forgot to attach the actual patch. --------------DwwbCwGLnptzvq3ZW0N0VJR4 Content-Type: text/x-patch; charset=UTF-8; name="other-project-prefix.diff" Content-Disposition: attachment; filename="other-project-prefix.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwgYi9saXNwL3Byb2dtb2Rl cy9wcm9qZWN0LmVsCmluZGV4IDAwMGEwNTgwNGE4Li5mMjU0MDNjOTgyYyAxMDA2NDQKLS0t IGEvbGlzcC9wcm9nbW9kZXMvcHJvamVjdC5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9wcm9q ZWN0LmVsCkBAIC05NTIsNiArOTUyLDQ0IEBAIHByb2plY3Qtb3RoZXItdGFiLWNvbW1hbmQK ICh3aGVuIChib3VuZC1hbmQtdHJ1ZS1wIHRhYi1wcmVmaXgtbWFwKQogICAoZGVmaW5lLWtl eSB0YWItcHJlZml4LW1hcCAicCIgIydwcm9qZWN0LW90aGVyLXRhYi1jb21tYW5kKSkKIAor Ozs7IyMjYXV0b2xvYWQKKyhkZWZ1biBvdGhlci1wcm9qZWN0LXByZWZpeCAoKQorICAiXCJT d2l0Y2hcIiB0byBhbm90aGVyIHByb2plY3QgYmVmb3JlIHJ1bm5pbmcgYW4gRW1hY3MgY29t bWFuZC4KK01ha2VzIHN1cmUgdGhlIG5leHQgY29tbWFuZCBpbnZva2VkIGFza3MgZm9yIHRo ZSBwcm9qZWN0IHRvIHJ1biBpdCBpbi4iCisgIChpbnRlcmFjdGl2ZSkKKyAgKHByZWZpeC1j b21tYW5kLXByZXNlcnZlLXN0YXRlKQorICAobGV0cmVjICgoZGVwdGggKG1pbmlidWZmZXIt ZGVwdGgpKQorICAgICAgICAgICAoZWNob2Z1biAobGFtYmRhICgpICJbc3dpdGNoLXByb2pl Y3RdIikpCisgICAgICAgICAgIChhcm91bmQtZnVuCisgICAgICAgICAgICAobGFtYmRhIChj b21tYW5kICZyZXN0IF9hcmdzKQorICAgICAgICAgICAgICAoYWR2aWNlLXJlbW92ZSB0aGlz LWNvbW1hbmQgYXJvdW5kLWZ1bikKKyAgICAgICAgICAgICAgKHVubGVzcyAob3IgKGVxIHRo aXMtY29tbWFuZCAnb3RoZXItcHJvamVjdC1wcmVmaXgpCisgICAgICAgICAgICAgICAgICAg ICAgICAgIChlcSBsYXN0LWNvbW1hbmQtZXZlbnQgaGVscC1jaGFyKSkKKyAgICAgICAgICAg ICAgICAobGV0ICgocm9vdCAoZnVuY2FsbCBwcm9qZWN0LXByb21wdGVyKSkpCisgICAgICAg ICAgICAgICAgICAoaWYgKG9yIChzdHJpbmctcHJlZml4LXAgInByb2plY3QtIgorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChzeW1ib2wtbmFtZSB0aGlz LWNvbW1hbmQpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAoZ2V0IHRoaXMtY29tbWFu ZCAncHJvamVjdC1hd2FyZSkpCisgICAgICAgICAgICAgICAgICAgICAgKGxldCAoKHByb2pl Y3QtY3VycmVudC1kaXJlY3Rvcnktb3ZlcnJpZGUgcm9vdCkpCisgICAgICAgICAgICAgICAg ICAgICAgICAoY2FsbC1pbnRlcmFjdGl2ZWx5IGNvbW1hbmQpKQorICAgICAgICAgICAgICAg ICAgICAobGV0ICgoZGVmYXVsdC1kaXJlY3Rvcnkgcm9vdCkpCisgICAgICAgICAgICAgICAg ICAgICAgKGNhbGwtaW50ZXJhY3RpdmVseSBjb21tYW5kKSkpKSkpKQorICAgICAgICAgICAo cHJlZnVuCisgICAgICAgICAgICAobGFtYmRhICgpCisgICAgICAgICAgICAgICh1bmxlc3Mg KD4gKG1pbmlidWZmZXItZGVwdGgpIGRlcHRoKQorICAgICAgICAgICAgICAgIChyZW1vdmUt aG9vayAncHJlLWNvbW1hbmQtaG9vayBwcmVmdW4pCisgICAgICAgICAgICAgICAgKHJlbW92 ZS1ob29rICdwcmVmaXgtY29tbWFuZC1lY2hvLWtleXN0cm9rZXMtZnVuY3Rpb25zIGVjaG9m dW4pCisgICAgICAgICAgICAgICAgKHdoZW4gKGFuZCB0aGlzLWNvbW1hbmQgKHN5bWJvbHAg dGhpcy1jb21tYW5kKSkKKyAgICAgICAgICAgICAgICAgIChhZHZpY2UtYWRkIHRoaXMtY29t bWFuZCA6YXJvdW5kIGFyb3VuZC1mdW4pKSkpKSkKKyAgICAoYWRkLWhvb2sgJ3ByZS1jb21t YW5kLWhvb2sgcHJlZnVuKQorICAgIChhZGQtaG9vayAncHJlZml4LWNvbW1hbmQtZWNoby1r ZXlzdHJva2VzLWZ1bmN0aW9ucyBlY2hvZnVuKQorICAgIChsZXQgKChtYXAgKG1ha2Utc3Bh cnNlLWtleW1hcCkpKQorICAgICAgKHNldC1rZXltYXAtcGFyZW50IG1hcCBwcm9qZWN0LXBy ZWZpeC1tYXApCisgICAgICA7OyBEb2Vzbid0IHdvcmsgOy0oCisgICAgICA7OyAoZGVmaW5l LWtleSBtYXAgKHZlY3RvciBoZWxwLWNoYXIpCisgICAgICA7OyAgICAgICAgICAgICAobGFt YmRhICgpIChpbnRlcmFjdGl2ZSkgKGhlbHAtZm9ybS1zaG93KSkpCisgICAgICAoc2V0LXRy YW5zaWVudC1tYXAgbWFwKSkKKyAgICAobWVzc2FnZSAoY29uY2F0ICJUeXBlICIgKHByb2pl Y3QtLWtleW1hcC1wcm9tcHQpICIgb3IgYW55IGdsb2JhbCBrZXkiKSkpKQorCiAoZGVjbGFy ZS1mdW5jdGlvbiBncmVwLXJlYWQtZmlsZXMgImdyZXAiKQogKGRlY2xhcmUtZnVuY3Rpb24g eHJlZi0tZmluZC1pZ25vcmVzLWFyZ3VtZW50cyAieHJlZiIpCiAK --------------DwwbCwGLnptzvq3ZW0N0VJR4--
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 26 Apr 2024 11:00:33 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Apr 26 07:00:32 2024 Received: from localhost ([127.0.0.1]:34065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s0JJb-0005N8-78 for submit <at> debbugs.gnu.org; Fri, 26 Apr 2024 07:00:31 -0400 Received: from fhigh2-smtp.messagingengine.com ([103.168.172.153]:38311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1s0JJQ-0005Jq-6j for 70577 <at> debbugs.gnu.org; Fri, 26 Apr 2024 07:00:22 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 7D465114017A; Fri, 26 Apr 2024 06:59:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 26 Apr 2024 06:59:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1714129192; x=1714215592; bh=t0n/8OziG1RBPA9kARf2V06PM7vDg21ija1uyaTfcDc=; b= tAneAwjJh2AN+Gnm2dfUcXd2twSYhSUeieH7zURriH38EYBwH2bjeGMV4pPQhPQR Hx9she5PeLpFisffeyxv3vV8Eb+VtR3xCO93KfuIHrRrbtDsKyC7NTObEVfqMvIz OjSO3ZtTXHj6O8BaV60jmO+Pt1EBQ2zXORp0Q9Yc9XaoMuxgid6Xp9gxacYf4UG/ o7o5vA1GVd0E3kZpBLjx//rkQ+9S33IqLXLDD6p14o1TYYoTuZCkMoYCP4wcexyn FpDCX6myP4tiJZD7BfyN8juvtpUwihLhPmXzUUk39nEX4yLWrn6io2P1M/tHZTMB rnlb8pj2NPkr0EFQ74oBXg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1714129192; x= 1714215592; bh=t0n/8OziG1RBPA9kARf2V06PM7vDg21ija1uyaTfcDc=; b=W kH3yioifbumAOOUbKratFQRt/d28HAifDMTcd03Nv2nf8lgZi7yNsDcdLTlJ3+ok 6rovjGxTbwifaZ9I4miBkGWyivRM9IR0Ul72zehLlvBcTdoMieJRnGwQpdBSYcvh F95fvD/3oAO3GtF0ZQsJNMiHsdDRr0xgmsTPXQcVXM66Keu6J7Cf4pdVsflqT0Pa MOGpuGyLX54GDpdjRzY2t01S8Fi2UUvNZ5hraCcDE/+CZqZ0P7yye7P+GxJ5c+es pFxehKQxik0zn51KuGlp1yMrn/YvmKPdLih5t8hM4ho7q1OS9j3907zEN21yAs46 +tKOMUVtGzSzumK4WCN8A== X-ME-Sender: <xms:J4krZsT1F1upQW7jNXCLrs9MLNws1w65I8ebvVshKBfGArRWkdU7pw> <xme:J4krZpzYpyAZneQ6KY12hEmkEjXH0aMW4qvu8hPf5_sjef3ZiXqd7N3eVIx09goRg 5YgncTe-JMpbMq_TeE> X-ME-Received: <xmr:J4krZp26Q6PzuKeFMoesni6iykPBPotqAMMchp8awxKP3_Ze2goznIhu3SsdIfYKI075> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudelledgfeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepffeifedvleeukedtgfelieegudfgveekfeejveejffetffeuueeugefhveei uddvnecuffhomhgrihhnpehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: <xmx:KIkrZgDvHtEsZmV_9W764FvfDlwOKWdCohn2xa3BtDos209fAuh_BA> <xmx:KIkrZliHKWWumx5xeUNwuhknB9nUVWesgEY-UyHRm2250S6pRhDz3Q> <xmx:KIkrZspMTvgB0JLsKu7P-dwAIyIC4CnGO2vt8cmsAUHpkq4ZQ35MHw> <xmx:KIkrZoi_KXtv3EnpzFJQB_N9kMD9MMsvSWOK11JxNvhh0-5GB91eSg> <xmx:KIkrZosn7cnQRlSGM4GfDW4w-zsAVb4_j7vokWAhz55xZC1MopV6ioUA> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 26 Apr 2024 06:59:51 -0400 (EDT) Message-ID: <a8483157-e2dd-409f-8a6c-08f5e339defc@HIDDEN> Date: Fri, 26 Apr 2024 13:59:48 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70577: [PATCH] New command other-project-prefix To: Juri Linkov <juri@HIDDEN> References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> <86le501ykg.fsf@HIDDEN> Content-Language: en-US From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <86le501ykg.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On 26/04/2024 09:09, Juri Linkov wrote: >> This is based on Juri's patch in >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63648#161, but the idea is >> more focused: to switch the order of events, and first read the full key >> sequence, and then prompt for the project and the command arguments. Like >> we also discussed in the past. > > I'm not a fan of reading the full key sequence bypassing the event loop. That's what the current code does. While the patch tries to change that. >> And to try to reuse the even loop in the more natural way. Unfortunately, >> 'C-h' doesn't work here (when called in the middle of the sequence) - I'm >> not sure why. The rest of the behavior seems to work as expected. > > 'C-h' can't work since 'C-x p p' is bound to a command. Hmm, I wonder how hard it'd be to change that. >> So this can be a new alternative for the 'C-x p p' binding as well. > > I guess there could be 2 new alternative options for 'project-switch-commands': > > 1. read the full key sequence > 2. use the event loop with set-transient-map > > Although I'm already completely content with the existing option > 'project-prefix-or-any-command' of 'project-switch-commands'. This one is indeed an experiment. It just seems that being able to type the full sequence first is more ergonomically advantageous. But overall this (adding a +1 alternative) is probably only worth it if we can make 'C-h' work like normal.
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at 70577) by debbugs.gnu.org; 26 Apr 2024 06:12:16 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Apr 26 02:12:15 2024 Received: from localhost ([127.0.0.1]:33632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s0Eod-0006cz-1a for submit <at> debbugs.gnu.org; Fri, 26 Apr 2024 02:12:14 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:43029) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1s0EoP-0006ZP-Hy for 70577 <at> debbugs.gnu.org; Fri, 26 Apr 2024 02:12:02 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 2C58740003; Fri, 26 Apr 2024 06:11:31 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Dmitry Gutov <dmitry@HIDDEN> Subject: Re: bug#70577: [PATCH] New command other-project-prefix In-Reply-To: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> (Dmitry Gutov's message of "Fri, 26 Apr 2024 06:01:35 +0300") Organization: LINKOV.NET References: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> Date: Fri, 26 Apr 2024 09:09:35 +0300 Message-ID: <86le501ykg.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70577 Cc: 70577 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) > This is based on Juri's patch in > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63648#161, but the idea is > more focused: to switch the order of events, and first read the full key > sequence, and then prompt for the project and the command arguments. Like > we also discussed in the past. I'm not a fan of reading the full key sequence bypassing the event loop. > And to try to reuse the even loop in the more natural way. Unfortunately, > 'C-h' doesn't work here (when called in the middle of the sequence) - I'm > not sure why. The rest of the behavior seems to work as expected. 'C-h' can't work since 'C-x p p' is bound to a command. > So this can be a new alternative for the 'C-x p p' binding as well. I guess there could be 2 new alternative options for 'project-switch-commands': 1. read the full key sequence 2. use the event loop with set-transient-map Although I'm already completely content with the existing option 'project-prefix-or-any-command' of 'project-switch-commands'.
bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 26 Apr 2024 03:02:33 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 25 23:02:30 2024 Received: from localhost ([127.0.0.1]:33526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s0Bqt-0004yd-Ah for submit <at> debbugs.gnu.org; Thu, 25 Apr 2024 23:02:29 -0400 Received: from lists.gnu.org ([2001:470:142::17]:56156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1s0Bqj-0004v7-50 for submit <at> debbugs.gnu.org; Thu, 25 Apr 2024 23:02:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <dmitry@HIDDEN>) id 1s0BqK-0005yM-8m for bug-gnu-emacs@HIDDEN; Thu, 25 Apr 2024 23:01:44 -0400 Received: from wfhigh3-smtp.messagingengine.com ([64.147.123.154]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <dmitry@HIDDEN>) id 1s0BqH-0000gO-T2 for bug-gnu-emacs@HIDDEN; Thu, 25 Apr 2024 23:01:44 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfhigh.west.internal (Postfix) with ESMTP id 084C9180008C for <bug-gnu-emacs@HIDDEN>; Thu, 25 Apr 2024 23:01:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 25 Apr 2024 23:01:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to; s=fm2; t=1714100498; x=1714186898; bh=YwGfFOxNUi WdBhDvSUIvvpjAHXVtZCPdfXQjcKY/BCQ=; b=r2Ond3LAroRsR/GQcseSg0xRsP G7VAzsmTCZ4uY9fWEEC2uwGiyTsBfkohaiDahNmd8Qg70C3NI70juGcsD9G30QWT tjzFvz0VEbB7ay+WYJoxfzWH7JAZTcei3GjkHA/2h0uFjnqIMwqk19b4U+DNomxZ +Vp5RZGHnBER27VS+br+xNaiXIgMnwa5i+RCZB1WI1G+rMAk84eWS+pE0YUTyn5q tI2pDDJutnCRGdjA11H28AXPZCcwFj9Ggy0bTqW6oR78n6kUeatYdN8XYIsVjFzZ 4SPnptfyO06BXIUCv9GV4x4KFw07Fcjd35a/mLtLaglVPkNaZ8KREIFvuqgg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1714100498; x=1714186898; bh=YwGfFOxNUiWdBhDvSUIvvpjAHXVt ZCPdfXQjcKY/BCQ=; b=I5t9TvTPvCU4dpurBfHyt/q/ACdEfM4W6DKScDG3EK8N j6MpPg3zLncCtz2NsN7F54e4ts+6aPghiDzLNR+EYJIZu70G/4YbSTj2FlH+7r2W Vq4P/3Pv6PtmCDtoTRx5bGUnEkwS9F29pzIWsaLSC2xV+ykJsVifxreLxUBqDGvX awaxrhvvHWaAltpSFjjDVeWIDfCAialVZWtz1FmCcsgAoqgTRQNzFKtKM0GjDdCB yqXJbuvx7z2C86KvlIi8LP8Fl9ZZTba80wQFfKRoAiXCGvYUKxDWu6boilMRRdb1 SOmLZW6zi6Soix+sQQGeBXClqnIhtH4w+9Un3Pp22g== X-ME-Sender: <xms:EhkrZuzQyr2D-vIAzo6Tt3Tjgu1bz6t8XdZPzMnWvmdvgrgdhWQi5w> <xme:EhkrZqQYlZBFK9JRhJJHlbz3VqkHR-4pZ-lJAxD-nnYjTrOBxywPkhmY0ly4JEMlr 8sA2RcQVIFVK7UNH3c> X-ME-Received: <xmr:EhkrZgUuL2pt_9Xa-2PjfhT8mP8Z4m3F4-dZM3vwNnec9jA5s0ig4IWehXy1Z8lzKPke> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudelkedgiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfgfvhffutgfgsehtjeertd dtvdejnecuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhuthho vhdruggvvheqnecuggftrfgrthhtvghrnhepgefgjedvueekkeduffekgedutefhkeevgf egkeehgeduffdulefhfefhteetledvnecuffhomhgrihhnpehgnhhurdhorhhgnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepughmihhtrhihse hguhhtohhvrdguvghv X-ME-Proxy: <xmx:EhkrZkiC7qBNuFSAuOMotS7oIG2utqJmLxkxKAGdqoy0NC7RXZGqMA> <xmx:EhkrZgDtPZVw6msMAxdGNs4OdFbZ07kH4HAmUBrtomJu59Ir86sFew> <xmx:EhkrZlKFMisLgj9_rHtYQom3-M7LoU7qAktf2ntPyrGCdHco1sh1jA> <xmx:EhkrZnABgD4RLLHOqphV_wtka1LKN_AlWyqZpmfHrOgN-oARRQSBSQ> <xmx:EhkrZp6OaIk5L57SoSoATWR936LXkkAuozj9OPFLSg1S95IJ60QKEsgR> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for <bug-gnu-emacs@HIDDEN>; Thu, 25 Apr 2024 23:01:37 -0400 (EDT) Message-ID: <d29607f5-11e3-4a3a-a29b-d74967234a35@HIDDEN> Date: Fri, 26 Apr 2024 06:01:35 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: bug-gnu-emacs@HIDDEN From: Dmitry Gutov <dmitry@HIDDEN> Subject: [PATCH] New command other-project-prefix Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=64.147.123.154; envelope-from=dmitry@HIDDEN; helo=wfhigh3-smtp.messagingengine.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_SBL_A=0.1 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: X-Debbugs-Cc: Juri Linkov <juri@HIDDEN> This is based on Juri's patch in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63648#161, but the idea is more focused: to switch the order of events, and first read the full key sequence, and then pr [...] Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.1 URIBL_SBL_A Contains URL's A record listed in the Spamhaus SBL blocklist [URIs: gutov.dev] 0.6 URIBL_SBL Contains an URL's NS IP listed in the Spamhaus SBL blocklist [URIs: gutov.dev] 0.7 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.4 (/) X-Debbugs-Cc: Juri Linkov <juri@HIDDEN> This is based on Juri's patch in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63648#161, but the idea is more focused: to switch the order of events, and first read the full key sequence, and then prompt for the project and the command arguments. Like we also discussed in the past. And to try to reuse the even loop in the more natural way. Unfortunately, 'C-h' doesn't work here (when called in the middle of the sequence) - I'm not sure why. The rest of the behavior seems to work as expected. So this can be a new alternative for the 'C-x p p' binding as well. Regarding the the use of advice, I didn't find a better way to plug (funcall project-prompter) this late. Too complex for pre-command-hook. Thoughts welcome.
Dmitry Gutov <dmitry@HIDDEN>:juri@HIDDEN, bug-gnu-emacs@HIDDEN.
Full text available.juri@HIDDEN, bug-gnu-emacs@HIDDEN:bug#70577; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.