GNU logs - #70871, boring messages

Message sent to help-debbugs@HIDDEN:

Subject: bug#70871: [PATCH] Show avatars from Libravatar.
Resent-From: Felix Lechner <felix.lechner@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: help-debbugs@HIDDEN
Resent-Date: Sat, 11 May 2024 03:21:02 +0000
Resent-Message-ID: <handler.70871.B.171539763723969 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: bug-mumi@HIDDEN
Cc: Felix Lechner <felix.lechner@HIDDEN>
From: Felix Lechner <felix.lechner@HIDDEN>
Date: Fri, 10 May 2024 20:20:08 -0700
Message-ID: <20240511032008.16270-1-felix.lechner@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=208.82.101.137;
 envelope-from=felix.lechner@HIDDEN; helo=sail-ipv4.us-core.com
X-Spam_score_int: -17
X-Spam_score: -1.8
X-Spam_bar: -
X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.1 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.1 (--)

Requires guile-avatar from here:

    https://codeberg.org/lechner/guile-avatar

The packaging code for guile-avatar can be added to Guix by accepting
this patch:

    https://debbugs.gnu.org/70870

In Guix, the package should then be mentioned as an "input" to mumi,
together with an updated commit hash or version for mumi.

A live preview of this change is available at:

    https://patchwise.org/38809
---
 mumi/web/view/html.scm | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/mumi/web/view/html.scm b/mumi/web/view/html.scm
index 2275799..bd5caec 100644
--- a/mumi/web/view/html.scm
+++ b/mumi/web/view/html.scm
@@ -19,6 +19,7 @@
 ;;; <http://www.gnu.org/licenses/>.

 (define-module (mumi web view html)
+  #:use-module (avatar url)
   #:use-module (email email)
   #:use-module (mumi config)
   #:use-module (mumi debbugs)
@@ -451,12 +452,12 @@ failed to process associated messages.")
          ,(map (match-lambda
                  ((message-number message)
                   `(li
-                    (div
-                     (@ (class "avatar")
-                        (style ,(string-append "background-color:"
-                                               (avatar-color (sender-email message)
-                                                             (map extract-email parties)))))
-                     ,(string-upcase (string-take (sender-name message) 1)))
+                    (img (@ (class "avatar")
+                            (style ,(string-append "background-color:"
+                                                   (avatar-color (sender-email message)
+                                                                 (map extract-email parties))))
+                            (src ,(libravatar-url (sender-email message) #:default "404"))
+                            (alt ,(string-upcase (string-take (sender-name message) 1)))))
                     (span (@ (class "date"))
                           (a (@ (href ,(string-append "#" (number->string
                                                            message-number))))
@@ -621,12 +622,12 @@ currently disabled."))
              (id ,(number->string message-number))))
        (a (@ (class "message-anchor")
              (id ,(format #false "msgid-~a" (msgid-hash (message-id message))))))
-       (div
-        (@ (class "avatar")
-           (style ,(string-append "background-color:"
-                                  (avatar-color (sender-email message)
-                                                (map extract-email parties)))))
-        ,(string-upcase (string-take (sender-name message) 1)))
+       (img (@ (class "avatar")
+               (style ,(string-append "background-color:"
+                                      (avatar-color (sender-email message)
+                                                    (map extract-email parties))))
+               (src ,(libravatar-url (sender-email message) #:default "404"))
+               (alt ,(string-upcase (string-take (sender-name message) 1)))))
        (article
         (@ (class "message"))
         (header

base-commit: 394c90d4a176756b9f0f4a716a2646ab98d8f167
-- 
2.41.0

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Felix Lechner <felix.lechner@HIDDEN>
Subject: bug#70871: Acknowledgement ([PATCH] Show avatars from Libravatar.)
Message-ID: <handler.70871.B.171539763723969.ack <at> debbugs.gnu.org>
References: <20240511032008.16270-1-felix.lechner@HIDDEN>
X-Gnu-PR-Message: ack 70871
X-Gnu-PR-Package: debbugs.gnu.org
X-Gnu-PR-Keywords: patch
Reply-To: 70871 <at> debbugs.gnu.org
Date: Sat, 11 May 2024 03:21:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 help-debbugs@HIDDEN

If you wish to submit further information on this problem, please
send it to 70871 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
70871: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D70871
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 11 May 2024 03:23:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 10 23:23:44 2024
Received: from localhost ([127.0.0.1]:45744 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s5dKp-0006HJ-WB
	for submit <at> debbugs.gnu.org; Fri, 10 May 2024 23:23:44 -0400
Received: from sail-ipv4.us-core.com ([208.82.101.137]:43672)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <felix.lechner@HIDDEN>) id 1s5dKo-0006HD-71
 for control <at> debbugs.gnu.org; Fri, 10 May 2024 23:23:42 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=1ah53i/fNwRoxD4
 Ij/Jqu95xDSnEwcTvZtINLVblHqs=; h=date:cc:to:from;
 d=lease-up.com; b=Pp
 UWidB7J2t12XSnV3TOoboItTpNkL0ogGnUsriKlvVavI5wZIB9lEgsMXkrU2NHq5dscRn8
 wVHv+3fMUkL9Ew9c1ynYGWD9pF7Sdb6ZgcRQkeiHIdwImnD43wmI2vRFJg7xh4GRiGEUfO
 XDn6ilm2ZipPbfJ2noIIys0qs4w+k=
Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 9e603ca4
 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO)
 for <control <at> debbugs.gnu.org>; Sat, 11 May 2024 03:23:42 +0000 (UTC)
From: Felix Lechner <felix.lechner@HIDDEN>
To: control <at> debbugs.gnu.org
Date: Fri, 10 May 2024 20:23:41 -0700
Message-ID: <875xvlxc8y.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  reassign 70871 mumi thanks 
 Content analysis details:   (2.0 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 -0.0 SPF_PASS               SPF: sender matches SPF record
 1.8 MISSING_SUBJECT        Missing Subject: header
 0.2 NO_SUBJECT             Extra score for no subject
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.0 (+)

reassign 70871 mumi
thanks

Message sent to bug-mumi@HIDDEN:

Subject: bug#70871: [PATCH] Show avatars from Libravatar.
Resent-From: Arun Isaac <arunisaac@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-mumi@HIDDEN
Resent-Date: Sat, 11 May 2024 16:54:03 +0000
Resent-Message-ID: <handler.70871.B70871.17154464203061 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Felix Lechner <felix.lechner@HIDDEN>
Cc: 70871 <at> debbugs.gnu.org
From: Arun Isaac <arunisaac@HIDDEN>
In-Reply-To: <20240511032008.16270-1-felix.lechner@HIDDEN>
References: <20240511032008.16270-1-felix.lechner@HIDDEN>
Date: Sat, 11 May 2024 17:53:25 +0100
Message-ID: <87plts5lyy.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi Felix,

Libravatar for mumi is a cool idea. I am happy to merge this patch with
the suggested changes.

There seems to be one more place (a total of three places) in
mumi/web/view/html.scm where there is an avatar. Search for
"string-upcase" in the code. Could you change that to Libravatar as
well? And, while you are at it, would you mind deduplicating these three
avatars into a single function or similar?

Also, we now need to check for guile-avatar in configure.ac.

BTW, what is patchwise.org? Did I miss some conversation about it? I was
under the impression that we should be sending to
bug-mumi@HIDDEN Thank you for the clarification!

Regards,
Arun

Last modified: Sat, 11 May 2024 17:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.