X-Loop: help-debbugs@HIDDEN
Subject: bug#70871: [PATCH] Show avatars from Libravatar.
Resent-From: Felix Lechner <felix.lechner@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: help-debbugs@HIDDEN
Resent-Date: Sat, 11 May 2024 03:21:02 +0000
Resent-Message-ID: <handler.70871.B.171539763723969 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 70871
X-GNU-PR-Package: debbugs.gnu.org
X-GNU-PR-Keywords: patch
To: bug-mumi@HIDDEN
Cc: Felix Lechner <felix.lechner@HIDDEN>
Received: via spool by submit <at> debbugs.gnu.org id=B.171539763723969
(code B ref -1); Sat, 11 May 2024 03:21:02 +0000
Received: (at submit) by debbugs.gnu.org; 11 May 2024 03:20:37 +0000
Received: from localhost ([127.0.0.1]:45726 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1s5dHp-0006EX-6t
for submit <at> debbugs.gnu.org; Fri, 10 May 2024 23:20:37 -0400
Received: from lists.gnu.org ([209.51.188.17]:37430)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <felix.lechner@HIDDEN>) id 1s5dHm-0006ER-R4
for submit <at> debbugs.gnu.org; Fri, 10 May 2024 23:20:36 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <felix.lechner@HIDDEN>)
id 1s5dHg-0007RZ-ID
for bug-mumi@HIDDEN; Fri, 10 May 2024 23:20:33 -0400
Received: from sail-ipv4.us-core.com ([208.82.101.137])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256)
(Exim 4.90_1) (envelope-from <felix.lechner@HIDDEN>)
id 1s5dHd-0006JP-Vq
for bug-mumi@HIDDEN; Fri, 10 May 2024 23:20:28 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=X9LxgqXX3dNbzIq
SeLeQRjv7Y+f9VFcSJBMEvHYV45w=; h=date:subject:cc:to:from;
d=lease-up.com; b=CF0nU/sgnfqevCMwh2kKXpmhY5JB8k9F05W+COrkBXntB/vgx9pp
qauuDLgqjhPxUv/2sMShkqf7EcArWm086JLdsxHMsiSFdxLil+2E5VjYLFNczkz26iXtdx
+AsO52IgTJb5t8c441D33SaTTnur4n9anlaVjLTvP4yAz91xQ=
Received: by localhost (OpenSMTPD) with ESMTPA id f2394414
for <bug-mumi@HIDDEN>; Sat, 11 May 2024 03:20:24 +0000 (UTC)
Delivered-To: bug-mumi@HIDDEN
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=X9LxgqXX3dNbzIq
SeLeQRjv7Y+f9VFcSJBMEvHYV45w=; h=date:subject:cc:to:from;
d=lease-up.com; b=CF0nU/sgnfqevCMwh2kKXpmhY5JB8k9F05W+COrkBXntB/vgx9pp
qauuDLgqjhPxUv/2sMShkqf7EcArWm086JLdsxHMsiSFdxLil+2E5VjYLFNczkz26iXtdx
+AsO52IgTJb5t8c441D33SaTTnur4n9anlaVjLTvP4yAz91xQ=
Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 6c0c0bcf
(TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO);
Sat, 11 May 2024 03:20:24 +0000 (UTC)
Received: from localhost (localhost [local])
by localhost (OpenSMTPD) with ESMTPA id bb2c4433;
Sat, 11 May 2024 03:20:23 +0000 (UTC)
From: Felix Lechner <felix.lechner@HIDDEN>
Date: Fri, 10 May 2024 20:20:08 -0700
Message-ID: <20240511032008.16270-1-felix.lechner@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=208.82.101.137;
envelope-from=felix.lechner@HIDDEN; helo=sail-ipv4.us-core.com
X-Spam_score_int: -17
X-Spam_score: -1.8
X-Spam_bar: -
X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.1 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.1 (--)
Requires guile-avatar from here:
https://codeberg.org/lechner/guile-avatar
The packaging code for guile-avatar can be added to Guix by accepting
this patch:
https://debbugs.gnu.org/70870
In Guix, the package should then be mentioned as an "input" to mumi,
together with an updated commit hash or version for mumi.
A live preview of this change is available at:
https://patchwise.org/38809
---
mumi/web/view/html.scm | 25 +++++++++++++------------
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/mumi/web/view/html.scm b/mumi/web/view/html.scm
index 2275799..bd5caec 100644
--- a/mumi/web/view/html.scm
+++ b/mumi/web/view/html.scm
@@ -19,6 +19,7 @@
;;; <http://www.gnu.org/licenses/>.
(define-module (mumi web view html)
+ #:use-module (avatar url)
#:use-module (email email)
#:use-module (mumi config)
#:use-module (mumi debbugs)
@@ -451,12 +452,12 @@ failed to process associated messages.")
,(map (match-lambda
((message-number message)
`(li
- (div
- (@ (class "avatar")
- (style ,(string-append "background-color:"
- (avatar-color (sender-email message)
- (map extract-email parties)))))
- ,(string-upcase (string-take (sender-name message) 1)))
+ (img (@ (class "avatar")
+ (style ,(string-append "background-color:"
+ (avatar-color (sender-email message)
+ (map extract-email parties))))
+ (src ,(libravatar-url (sender-email message) #:default "404"))
+ (alt ,(string-upcase (string-take (sender-name message) 1)))))
(span (@ (class "date"))
(a (@ (href ,(string-append "#" (number->string
message-number))))
@@ -621,12 +622,12 @@ currently disabled."))
(id ,(number->string message-number))))
(a (@ (class "message-anchor")
(id ,(format #false "msgid-~a" (msgid-hash (message-id message))))))
- (div
- (@ (class "avatar")
- (style ,(string-append "background-color:"
- (avatar-color (sender-email message)
- (map extract-email parties)))))
- ,(string-upcase (string-take (sender-name message) 1)))
+ (img (@ (class "avatar")
+ (style ,(string-append "background-color:"
+ (avatar-color (sender-email message)
+ (map extract-email parties))))
+ (src ,(libravatar-url (sender-email message) #:default "404"))
+ (alt ,(string-upcase (string-take (sender-name message) 1)))))
(article
(@ (class "message"))
(header
base-commit: 394c90d4a176756b9f0f4a716a2646ab98d8f167
--
2.41.0
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Felix Lechner <felix.lechner@HIDDEN> Subject: bug#70871: Acknowledgement ([PATCH] Show avatars from Libravatar.) Message-ID: <handler.70871.B.171539763723969.ack <at> debbugs.gnu.org> References: <20240511032008.16270-1-felix.lechner@HIDDEN> X-Gnu-PR-Message: ack 70871 X-Gnu-PR-Package: debbugs.gnu.org X-Gnu-PR-Keywords: patch Reply-To: 70871 <at> debbugs.gnu.org Date: Sat, 11 May 2024 03:21:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): help-debbugs@HIDDEN If you wish to submit further information on this problem, please send it to 70871 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 70871: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D70871 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
Received: (at control) by debbugs.gnu.org; 11 May 2024 03:23:44 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 10 23:23:44 2024 Received: from localhost ([127.0.0.1]:45744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s5dKp-0006HJ-WB for submit <at> debbugs.gnu.org; Fri, 10 May 2024 23:23:44 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]:43672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <felix.lechner@HIDDEN>) id 1s5dKo-0006HD-71 for control <at> debbugs.gnu.org; Fri, 10 May 2024 23:23:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=1ah53i/fNwRoxD4 Ij/Jqu95xDSnEwcTvZtINLVblHqs=; h=date:cc:to:from; d=lease-up.com; b=Pp UWidB7J2t12XSnV3TOoboItTpNkL0ogGnUsriKlvVavI5wZIB9lEgsMXkrU2NHq5dscRn8 wVHv+3fMUkL9Ew9c1ynYGWD9pF7Sdb6ZgcRQkeiHIdwImnD43wmI2vRFJg7xh4GRiGEUfO XDn6ilm2ZipPbfJ2noIIys0qs4w+k= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 9e603ca4 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO) for <control <at> debbugs.gnu.org>; Sat, 11 May 2024 03:23:42 +0000 (UTC) From: Felix Lechner <felix.lechner@HIDDEN> To: control <at> debbugs.gnu.org Date: Fri, 10 May 2024 20:23:41 -0700 Message-ID: <875xvlxc8y.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: reassign 70871 mumi thanks Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 1.0 (+) reassign 70871 mumi thanks
X-Loop: help-debbugs@HIDDEN
Subject: bug#70871: [PATCH] Show avatars from Libravatar.
Resent-From: Arun Isaac <arunisaac@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-mumi@HIDDEN
Resent-Date: Sat, 11 May 2024 16:54:03 +0000
Resent-Message-ID: <handler.70871.B70871.17154464203061 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70871
X-GNU-PR-Package: mumi
X-GNU-PR-Keywords: patch
To: Felix Lechner <felix.lechner@HIDDEN>
Cc: 70871 <at> debbugs.gnu.org
Received: via spool by 70871-submit <at> debbugs.gnu.org id=B70871.17154464203061
(code B ref 70871); Sat, 11 May 2024 16:54:03 +0000
Received: (at 70871) by debbugs.gnu.org; 11 May 2024 16:53:40 +0000
Received: from localhost ([127.0.0.1]:49257 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1s5pyd-0000nJ-KQ
for submit <at> debbugs.gnu.org; Sat, 11 May 2024 12:53:40 -0400
Received: from mugam.systemreboot.net ([139.59.75.54]:43662)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <arunisaac@HIDDEN>) id 1s5pya-0000n1-1J
for 70871 <at> debbugs.gnu.org; Sat, 11 May 2024 12:53:38 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date:
References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:
Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:
Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:
List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
bh=JNztq7KXEiH9LX+fzRKblPDFYEdvBQ2N7bWz1cZgHAM=; b=QzAY2NQgQolMUrqH44QNuDQxt5
2Lua3zU5+jv8oA1ClXGcO2FZeC6y6HO/Z+gpM71Xiw7uq/verp3GKk7EMepO3Oy8yrU5eQPvoKOTZ
D0fYfFmlmp5kS4lLnVcnUcZlUmKYFdwPVVqbjs7NMUsWy79GhSyh8LtiGDugfWyiOH3Qqq2nbWmWI
pv3elJ4zr/pQ4/6n92hzqK9uER++ruO39TJjZupOFQAcCK+9NaUD0+sIM07wSAtMFJWfF3H3evYsp
YkBq3gvFvYTQ8QYJpeODhXoElzx44B2RwwcimNLqfM4DSxRf1eR17Pgmw06D60FhHBttthQArNXH6
I/wYXcwg==;
Received: from [192.168.2.1] (port=33640 helo=localhost)
by systemreboot.net with esmtpsa (TLS1.3) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.1)
(envelope-from <arunisaac@HIDDEN>) id 1s5pvs-0000qX-1e;
Sat, 11 May 2024 17:50:49 +0100
From: Arun Isaac <arunisaac@HIDDEN>
In-Reply-To: <20240511032008.16270-1-felix.lechner@HIDDEN>
References: <20240511032008.16270-1-felix.lechner@HIDDEN>
Date: Sat, 11 May 2024 17:53:25 +0100
Message-ID: <87plts5lyy.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hi Felix,
Libravatar for mumi is a cool idea. I am happy to merge this patch with
the suggested changes.
There seems to be one more place (a total of three places) in
mumi/web/view/html.scm where there is an avatar. Search for
"string-upcase" in the code. Could you change that to Libravatar as
well? And, while you are at it, would you mind deduplicating these three
avatars into a single function or similar?
Also, we now need to check for guile-avatar in configure.ac.
BTW, what is patchwise.org? Did I miss some conversation about it? I was
under the impression that we should be sending to
bug-mumi@HIDDEN Thank you for the clarification!
Regards,
Arun
X-Loop: help-debbugs@HIDDEN
Subject: bug#70871: [PATCH] Show avatars from Libravatar.
Resent-From: Arun Isaac <arunisaac@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-mumi@HIDDEN
Resent-Date: Sun, 12 May 2024 23:53:02 +0000
Resent-Message-ID: <handler.70871.B70871.171555792812768 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70871
X-GNU-PR-Package: mumi
X-GNU-PR-Keywords: patch
To: Felix Lechner <felix.lechner@HIDDEN>
Cc: 70871 <at> debbugs.gnu.org
Received: via spool by 70871-submit <at> debbugs.gnu.org id=B70871.171555792812768
(code B ref 70871); Sun, 12 May 2024 23:53:02 +0000
Received: (at 70871) by debbugs.gnu.org; 12 May 2024 23:52:08 +0000
Received: from localhost ([127.0.0.1]:57147 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1s6IzA-0003Js-Eq
for submit <at> debbugs.gnu.org; Sun, 12 May 2024 19:52:08 -0400
Received: from mugam.systemreboot.net ([139.59.75.54]:59994)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <arunisaac@HIDDEN>) id 1s6Iz5-0003JT-S3
for 70871 <at> debbugs.gnu.org; Sun, 12 May 2024 19:52:06 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date:
References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:
Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:
Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:
List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
bh=+yqI8QOO7fwhdKhOag2P7EfnmONKEOeiZYnGvzEHTkE=; b=kQ3J2dEdvMf8S9569ZVxiJePjW
dkav6/WkzAE6pHQTLtUcyB1+oEABMWi0BTFXrPAW7XuOUCkXLWr3T+Ig5CgFqdDl908v9rgIryi0a
DrK2CUzuBD7wyq3cgJpUI3qGEAwYBcXxcIQ+pNNQ0Xxc6BvkwUqSFo/0PTh+K2C/by95n/TClyTJM
vS+ZWtQvoHyhLJH7YhKBnYpxi2GsMP3SJCpfNyS9OQEWr4esZRDGcf9IRhse2CHiURWEO0a1qjCmg
UHyYo7/B6hczByD0CnZX9J1d2rgMehlQcPzcPbrN33ml6LS3orbmVZhWKrTNgQQrqT0FZglzH3vRt
XSe1Z75A==;
Received: from [192.168.2.1] (port=33968 helo=localhost)
by systemreboot.net with esmtpsa (TLS1.3) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.1)
(envelope-from <arunisaac@HIDDEN>) id 1s6IwK-0002IG-1G;
Mon, 13 May 2024 00:49:13 +0100
From: Arun Isaac <arunisaac@HIDDEN>
In-Reply-To: <87plts5lyy.fsf@HIDDEN>
References: <20240511032008.16270-1-felix.lechner@HIDDEN>
<87plts5lyy.fsf@HIDDEN>
Date: Mon, 13 May 2024 00:51:53 +0100
Message-ID: <87a5ku4mhy.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hi Felix,
Could you also make the deduplication and the switch to libravatar two
separate patches? Thanks!
I also just remembered that the alt attribute of the img tag is meant to
be used in place of the image (visually challenged readers using a
screen reader, image download failed on a slow connection, etc.). So, we
shouldn't use the alt attribute as a fallback for users without
avatars. We should do it some other way.
Regards,
Arun
X-Loop: help-debbugs@HIDDEN
Subject: bug#70871: [PATCH] Show avatars from Libravatar.
Resent-From: Felix Lechner <felix.lechner@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-mumi@HIDDEN
Resent-Date: Mon, 13 May 2024 19:31:01 +0000
Resent-Message-ID: <handler.70871.B70871.171562861631934 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70871
X-GNU-PR-Package: mumi
X-GNU-PR-Keywords: patch
To: Arun Isaac <arunisaac@HIDDEN>
Cc: 70871@HIDDEN
Received: via spool by 70871-submit <at> debbugs.gnu.org id=B70871.171562861631934
(code B ref 70871); Mon, 13 May 2024 19:31:01 +0000
Received: (at 70871) by debbugs.gnu.org; 13 May 2024 19:30:16 +0000
Received: from localhost ([127.0.0.1]:34403 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1s6bNG-0008J0-AY
for submit <at> debbugs.gnu.org; Mon, 13 May 2024 15:30:16 -0400
Received: from sail-ipv4.us-core.com ([208.82.101.137]:46772)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <felix.lechner@HIDDEN>) id 1s6bN6-0008Hl-TR
for 70871 <at> debbugs.gnu.org; Mon, 13 May 2024 15:30:12 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=sURdS/kvJbJ1MVf
NNbi4zH1WN5vIiSOqobFqgzuWKiE=;
h=date:references:in-reply-to:subject:
cc:to:from; d=lease-up.com; b=oAhDNB9S3UtQlXpVFx45A1qvtI3TAMb8FPHABgtb
2ZS1Il4NuzyUi+NOdv3YCvYZwXEbCeCnTSZiL0zBFsdC7ccPnXnYzyatx3nJ4uXkx4oZi8
nXiG4e3hPXKRsp71dKNx8VMm00t/6OD2cW/nu4rfy2nBLnXSsTbQaEsUSAllg=
Received: by localhost (OpenSMTPD) with ESMTPA id b32365ff
for <70871 <at> debbugs.gnu.org>; Mon, 13 May 2024 19:30:02 +0000 (UTC)
Delivered-To: 70871@HIDDEN
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=sURdS/kvJbJ1MVf
NNbi4zH1WN5vIiSOqobFqgzuWKiE=;
h=date:references:in-reply-to:subject:
cc:to:from; d=lease-up.com; b=oAhDNB9S3UtQlXpVFx45A1qvtI3TAMb8FPHABgtb
2ZS1Il4NuzyUi+NOdv3YCvYZwXEbCeCnTSZiL0zBFsdC7ccPnXnYzyatx3nJ4uXkx4oZi8
nXiG4e3hPXKRsp71dKNx8VMm00t/6OD2cW/nu4rfy2nBLnXSsTbQaEsUSAllg=
Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id ed2ae530
(TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO);
Mon, 13 May 2024 19:30:02 +0000 (UTC)
From: Felix Lechner <felix.lechner@HIDDEN>
In-Reply-To: <87a5ku4mhy.fsf@HIDDEN>
References: <20240511032008.16270-1-felix.lechner@HIDDEN>
<87plts5lyy.fsf@HIDDEN> <87a5ku4mhy.fsf@HIDDEN>
Date: Mon, 13 May 2024 12:30:02 -0700
Message-ID: <87pltpwlvp.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hi Arun,
On Mon, May 13 2024, Arun Isaac wrote:
> would you mind deduplicating these three avatars into a single
> function or similar?
Personally, I do not see the benefit of that abstraction for HTML. For
one, the code is a lot easier to parse next to a Web Inspector that
shows the same tags.
There is also not much to abstract: It's a single 'img' tag.
Moreover, the avatars are also in different positions. They do
different things on the page. Most significantly, they are subject to
different CSS.
You'll see why that matters just below.
> There seems to be one more place in mumi/web/view/html.scm where there
> is an avatar.
There is no third avatar. If you haven't yet followed the CSS with a
Web Inspector, please look for the 'display: none' for that 'img' tag.
It comes from here:
https://git.savannah.gnu.org/cgit/guix/mumi.git/tree/assets/mumi.scss#n394
Does the "third" avatar more or less duplicate with the big one in
front? Do you plan to use the third avatar? I'd drop it.
> I also just remembered that the alt attribute of the img tag is meant to
> be used in place of the image (visually challenged readers using a
> screen reader, image download failed on a slow connection, etc.). So, we
> shouldn't use the alt attribute as a fallback for users without
> avatars.
Would you please explain that rationale? A blind person who disables
the loading of images would still "see" (or perhaps hear) the 'alt'
character. How does my code break anything for a blind person, please?
> Also, we now need to check for guile-avatar in configure.ac.
It is not necessary for my deployment on patchwise.org, which already
shows the avatars.
For an interpreted language like Guile there is no need to provide
prerequisite checks at configure time unless they enable workarounds to
build without. The Guile module detections currently found in
configure.ac are luxuries. I would remove them.
If you prefer to keep them and add guile-avatar for the sake of
consistency, please feel free to amend the patch. I do not insist on Git
authorship for my contributions. I am sorry, but I am super busy.
> what is patchwise.org? Did I miss some conversation about it?
That's the domain I hope to use in the near future---and in cooperation
with the FSF---to show off my plans for a Debbugs upgrade based on Mumi.
FSF declined to upgrade debbugs.gnu.org to the latest Debbugs version
(from Debian) because my packaging was based on Guix. FSF wants Trisquel
plus Ansible.
FSF encouraged me to complete my work elsewhere and demonstrate it when
done. It was not my first choice, please believe me. I protested
loudly in various places. Either way, Patchwise is licensed under GNU
Affero. There are no hidden goals.
> I was under the impression that we should be sending to
> bug-mumi@HIDDEN
I had hoped to open the bug by bouncing the message from patchwise.org
to gnu.org. The Patchwise bouncer works in all other cases, such as
when amending or controlling bugs (please try it, or look at the headers
for this message!) or access to the mailing lists. I'll have to talk to
FSF about using the envelope address for submissions, as well.
The Patchwise bouncer is essential for the automatic sequencer that will
allow folks to submit a patch series in one go. I think your command
line tool may do something similar.
Also, the patchwise.org effort has not been made public. You are one of
the first people to hear about it.
I'd be happy to cooperate, if you agree to be less picky about my
patches.
Kind regards
Felix
X-Loop: help-debbugs@HIDDEN
Subject: bug#70871: [PATCH] Show avatars from Libravatar.
Resent-From: Arun Isaac <arunisaac@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-mumi@HIDDEN
Resent-Date: Sun, 19 May 2024 02:51:02 +0000
Resent-Message-ID: <handler.70871.B70871.171608702726155 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70871
X-GNU-PR-Package: mumi
X-GNU-PR-Keywords: patch
To: Felix Lechner <felix.lechner@HIDDEN>
Cc: 70871 <at> debbugs.gnu.org, 70871@HIDDEN
Received: via spool by 70871-submit <at> debbugs.gnu.org id=B70871.171608702726155
(code B ref 70871); Sun, 19 May 2024 02:51:02 +0000
Received: (at 70871) by debbugs.gnu.org; 19 May 2024 02:50:27 +0000
Received: from localhost ([127.0.0.1]:35683 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1s8Wd0-0006nn-HS
for submit <at> debbugs.gnu.org; Sat, 18 May 2024 22:50:27 -0400
Received: from mugam.systemreboot.net ([139.59.75.54]:37428)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <arunisaac@HIDDEN>) id 1s8Wcw-0006nb-Py
for 70871 <at> debbugs.gnu.org; Sat, 18 May 2024 22:50:25 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date:
References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:
Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:
Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:
List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
bh=qoB0qThkKXM5w6ZNZZ0lPeVAC4j4LPtLS8ZNikJ/hvQ=; b=CUk6sHdFrECdmnhsDGgnBmwtkL
u7AiGfJ0K0bThmd232EKhEEkxKH8omUQcERPUNjpdKQzvRtU13KZcU+cc/+uV1HO1LaLwpryXrnfX
vcjiR4II7ZyaKaCI2zHso0fF38MFSHghvQYokxn+5ykw3pnXIPUJm9XVLcbhK4FOk+GrEzEj28VZ/
LlLdUESUNHThAtz793HCq7/u4soH2nKWr9QNLp0rsKxnJESvjWGX2WO42Q/LG1vCqFCy9XgupOOZE
B929NvmD4GJWRxgISQfLWpiMX52Iun7QfWF7+ebws28KEvTAbwN6f2A1v+uMbJxkJkzAXD83UQgxJ
8rs5O5xw==;
Received: from [192.168.2.1] (port=58688 helo=localhost)
by systemreboot.net with esmtpsa (TLS1.3) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.1)
(envelope-from <arunisaac@HIDDEN>) id 1s8WZt-0003DS-2v;
Sun, 19 May 2024 03:47:14 +0100
From: Arun Isaac <arunisaac@HIDDEN>
In-Reply-To: <87pltpwlvp.fsf@HIDDEN>
References: <20240511032008.16270-1-felix.lechner@HIDDEN>
<87plts5lyy.fsf@HIDDEN> <87a5ku4mhy.fsf@HIDDEN>
<87pltpwlvp.fsf@HIDDEN>
Date: Sun, 19 May 2024 03:50:06 +0100
Message-ID: <87ttiuikgx.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hi Felix,
> There is also not much to abstract: It's a single 'img' tag.
Well, it's repeated in three places. So, it's probably worth abstracting
out.
> There is no third avatar. If you haven't yet followed the CSS with a
> Web Inspector, please look for the 'display: none' for that 'img' tag.
> It comes from here:
I believe the third avatar shows up on smaller screens. Try using the
"responsive mode" (Ctrl+Shift+m) in Icecat to simulate a smaller screen.
>> I also just remembered that the alt attribute of the img tag is meant to
>> be used in place of the image (visually challenged readers using a
>> screen reader, image download failed on a slow connection, etc.). So, we
>> shouldn't use the alt attribute as a fallback for users without
>> avatars.
>
> Would you please explain that rationale? A blind person who disables
> the loading of images would still "see" (or perhaps hear) the 'alt'
> character. How does my code break anything for a blind person,
> please?
See https://accessibility.huit.harvard.edu/describe-content-images An
alt text of "A" for "Arun Isaac" would not make sense if read out aloud
by a screen reader. It should rather be "Profile picture of Arun Isaac"
or similar. Perhaps, it should also be marked up with
aria-hidden=true. See
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-hidden
I'm not saying the current situation in mumi gets accessibility
right. But, while we are changing things, we might as well get things
right.
> For an interpreted language like Guile there is no need to provide
> prerequisite checks at configure time unless they enable workarounds to
> build without. The Guile module detections currently found in
> configure.ac are luxuries. I would remove them.
I agree. But, I'm mainly trying to remain consistent with the existing
code base.
> If you prefer to keep them and add guile-avatar for the sake of
> consistency, please feel free to amend the patch.
I am happy to make this change myself.
> I am sorry, but I am super busy.
Sorry, so am I, and so is everyone else hacking away on Guix and mumi in
their spare time.
> I'd be happy to cooperate, if you agree to be less picky about my
> patches.
As a reviewer, it is kinda my job to bring contributions up to shape
before they get applied. I am happy to work in good faith towards that
goal. And, I don't feel I have been particularly picky in my review. The
changes I proposed were pretty reasonable.
Regards,
Arun
X-Loop: help-debbugs@HIDDEN
Subject: bug#70871: [PATCH] Show avatars from Libravatar.
Resent-From: Arun Isaac <arunisaac@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-mumi@HIDDEN
Resent-Date: Sun, 19 May 2024 02:51:02 +0000
Resent-Message-ID: <handler.70871.B70871.171608703926168 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70871
X-GNU-PR-Package: mumi
X-GNU-PR-Keywords: patch
To: Felix Lechner <felix.lechner@HIDDEN>
Cc: 70871 <at> debbugs.gnu.org, 70871@HIDDEN
Received: via spool by 70871-submit <at> debbugs.gnu.org id=B70871.171608703926168
(code B ref 70871); Sun, 19 May 2024 02:51:02 +0000
Received: (at 70871) by debbugs.gnu.org; 19 May 2024 02:50:39 +0000
Received: from localhost ([127.0.0.1]:35686 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1s8WdD-0006o0-2e
for submit <at> debbugs.gnu.org; Sat, 18 May 2024 22:50:39 -0400
Received: from sail-ipv4.us-core.com ([208.82.101.137]:55504)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <arunisaac@HIDDEN>) id 1s8Wd9-0006nu-Vy
for 70871 <at> debbugs.gnu.org; Sat, 18 May 2024 22:50:37 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=Ih+5wKezE8vgawk
BDlW2nGu560nApdhjl1yJG2qSqAY=;
h=date:references:in-reply-to:subject:
cc:to:from; d=us-core.com; b=CucCHk6PjyryapO3edooIYGq1t33rXxqX383HlCVd
7uguSlZN1JAEe+WdFh4VjQDXU+EAoHdLtgvi5bM71R8iMZxq1b9GkgxPvcDOz4QsPNlYBf
PXW6AE1JPuQ3iX2yinova5Yfp8/GmCxXtBfYh4ZEtNW9hA2rnaJXvVBNUfqU=
Received: by localhost (OpenSMTPD) with ESMTPA id 557e142c
for <70871 <at> debbugs.gnu.org>; Sun, 19 May 2024 02:50:30 +0000 (UTC)
Delivered-To: 70871@HIDDEN
Received: from mugam.systemreboot.net (mugam.systemreboot.net [139.59.75.54])
by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPS id bafc9b1d
(TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO);
Sun, 19 May 2024 02:50:23 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date:
References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:
Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:
Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:
List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
bh=qoB0qThkKXM5w6ZNZZ0lPeVAC4j4LPtLS8ZNikJ/hvQ=; b=CUk6sHdFrECdmnhsDGgnBmwtkL
u7AiGfJ0K0bThmd232EKhEEkxKH8omUQcERPUNjpdKQzvRtU13KZcU+cc/+uV1HO1LaLwpryXrnfX
vcjiR4II7ZyaKaCI2zHso0fF38MFSHghvQYokxn+5ykw3pnXIPUJm9XVLcbhK4FOk+GrEzEj28VZ/
LlLdUESUNHThAtz793HCq7/u4soH2nKWr9QNLp0rsKxnJESvjWGX2WO42Q/LG1vCqFCy9XgupOOZE
B929NvmD4GJWRxgISQfLWpiMX52Iun7QfWF7+ebws28KEvTAbwN6f2A1v+uMbJxkJkzAXD83UQgxJ
8rs5O5xw==;
Received: from [192.168.2.1] (port=58688 helo=localhost)
by systemreboot.net with esmtpsa (TLS1.3) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.1)
(envelope-from <arunisaac@HIDDEN>) id 1s8WZt-0003DS-2v;
Sun, 19 May 2024 03:47:14 +0100
From: Arun Isaac <arunisaac@HIDDEN>
In-Reply-To: <87pltpwlvp.fsf@HIDDEN>
References: <20240511032008.16270-1-felix.lechner@HIDDEN>
<87plts5lyy.fsf@HIDDEN> <87a5ku4mhy.fsf@HIDDEN>
<87pltpwlvp.fsf@HIDDEN>
Date: Sun, 19 May 2024 03:50:06 +0100
Message-ID: <87ttiuikgx.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 1.9 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hi Felix, > There is also not much to abstract: It's a single
'img' tag. Well, it's repeated in three places. So,
it's probably worth abstracting out.
Content analysis details: (1.9 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
0.9 SPF_FAIL SPF: sender does not match SPF record (fail)
[SPF failed: Please see http://www.openspf.org/Why?s=mfrom;
id=arunisaac%40systemreboot.net; ip=208.82.101.137; r=debbugs.gnu.org]
1.0 URI_DOTEDU Has .edu URI
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)
Hi Felix,
> There is also not much to abstract: It's a single 'img' tag.
Well, it's repeated in three places. So, it's probably worth abstracting
out.
> There is no third avatar. If you haven't yet followed the CSS with a
> Web Inspector, please look for the 'display: none' for that 'img' tag.
> It comes from here:
I believe the third avatar shows up on smaller screens. Try using the
"responsive mode" (Ctrl+Shift+m) in Icecat to simulate a smaller screen.
>> I also just remembered that the alt attribute of the img tag is meant to
>> be used in place of the image (visually challenged readers using a
>> screen reader, image download failed on a slow connection, etc.). So, we
>> shouldn't use the alt attribute as a fallback for users without
>> avatars.
>
> Would you please explain that rationale? A blind person who disables
> the loading of images would still "see" (or perhaps hear) the 'alt'
> character. How does my code break anything for a blind person,
> please?
See https://accessibility.huit.harvard.edu/describe-content-images An
alt text of "A" for "Arun Isaac" would not make sense if read out aloud
by a screen reader. It should rather be "Profile picture of Arun Isaac"
or similar. Perhaps, it should also be marked up with
aria-hidden=true. See
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-hidden
I'm not saying the current situation in mumi gets accessibility
right. But, while we are changing things, we might as well get things
right.
> For an interpreted language like Guile there is no need to provide
> prerequisite checks at configure time unless they enable workarounds to
> build without. The Guile module detections currently found in
> configure.ac are luxuries. I would remove them.
I agree. But, I'm mainly trying to remain consistent with the existing
code base.
> If you prefer to keep them and add guile-avatar for the sake of
> consistency, please feel free to amend the patch.
I am happy to make this change myself.
> I am sorry, but I am super busy.
Sorry, so am I, and so is everyone else hacking away on Guix and mumi in
their spare time.
> I'd be happy to cooperate, if you agree to be less picky about my
> patches.
As a reviewer, it is kinda my job to bring contributions up to shape
before they get applied. I am happy to work in good faith towards that
goal. And, I don't feel I have been particularly picky in my review. The
changes I proposed were pretty reasonable.
Regards,
Arun
X-Loop: help-debbugs@HIDDEN
Subject: bug#70871: [PATCH v2 0/2] Show avatars from Libavatar.
References: <20240511032008.16270-1-felix.lechner@HIDDEN>
In-Reply-To: <20240511032008.16270-1-felix.lechner@HIDDEN>
Resent-From: noe@HIDDEN
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-mumi@HIDDEN
Resent-Date: Sat, 02 Nov 2024 15:35:02 +0000
Resent-Message-ID: <handler.70871.B70871.173056165827178 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70871
X-GNU-PR-Package: mumi
X-GNU-PR-Keywords: patch
To: 70871 <at> debbugs.gnu.org
Cc: =?UTF-8?Q?No=C3=A9?= Lopez <noelopez@HIDDEN>
Received: via spool by 70871-submit <at> debbugs.gnu.org id=B70871.173056165827178
(code B ref 70871); Sat, 02 Nov 2024 15:35:02 +0000
Received: (at 70871) by debbugs.gnu.org; 2 Nov 2024 15:34:18 +0000
Received: from localhost ([127.0.0.1]:54009 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1t7G8o-00074H-6b
for submit <at> debbugs.gnu.org; Sat, 02 Nov 2024 11:34:18 -0400
Received: from smtp.domeneshop.no ([194.63.252.55]:52049)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <noe@HIDDEN>) id 1t7G8k-000742-JS
for 70871 <at> debbugs.gnu.org; Sat, 02 Nov 2024 11:34:16 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=xn--no-cja.eu; s=ds202402; h=Content-Transfer-Encoding:Content-Type:
MIME-Version:Message-ID:Date:Subject:Cc:To:From:From:Sender:Reply-To:Subject:
Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id:
List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
bh=EfcRU1FeLyOeRZb9iCo3qv4cg7Eq2YxvDWczCPQfcMA=; b=ejAByMr/aQISXq5byHUWRDbVWQ
FRfHnOkU5VOGBzQhybOn5rTi/RyxQuJAr4f6uTJHepD/hGGq4jxhwSB6CaNlS7DYQ47tK1qPTqmuy
PnJVWZsNmgxILXxQ0SngrQ5Sjnckgaa7DfBMoi3PJo5lDKfNucJkOqXAWbYPolf7WakLi50kIUIe+
AzYhc/prwWpegBrFyuaejVIrJRNbjXSxspUV710WOTO4Rbo90ShJS5LSUyUOcEvN4VykMYCyC5IIt
Pi3vlYoPhOS8Lkr7QCM93HEQ9tfoA4UXAyg5dlc81B1CjHKV5B15DE8pQiG6S/3qmB/tJ+5BlihbU
wLCy5Mvg==;
Received: from [2a01:e0a:990:a960:b4f3:8f44:ec4:5af5] (port=49536
helo=localhost.localdomain)
by smtp.domeneshop.no with esmtpsa (TLS1.3) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95)
(envelope-from <noe@HIDDEN>) id 1t7G8d-008uEQ-E2;
Sat, 02 Nov 2024 16:34:07 +0100
From: noe@HIDDEN
Date: Sat, 2 Nov 2024 16:34:48 +0100
Message-ID: <20241102153450.958-1-noe@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
From: Noé Lopez <noelopez@HIDDEN>
Hi,
Here is an updated version of the patch with the requested changes.
I agree with the changes requested because it is that rigor that keeps
the code easy to understand and modify.
The test data does not have libavatar associated emails, but you can
test it by replacing « user » with another email (mine should work):
find . -not -path '*/\.git/*' -type f -exec sed -i 's/user@HIDDEN/REPLACEME/g' '{}' \;
Good afternoon,
Noé
Noé Lopez (2):
web: Extract user avatars to function.
web: Show avatars from Libravatar.
configure.ac | 5 +++++
mumi/web/view/html.scm | 36 ++++++++++++++++++------------------
2 files changed, 23 insertions(+), 18 deletions(-)
base-commit: d8ff427dc16f44f4b15684207d3c531301fb0407
--
2.46.0
X-Loop: help-debbugs@HIDDEN
Subject: bug#70871: [PATCH v2 1/2] web: Extract user avatars to function.
Resent-From: noe@HIDDEN
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-mumi@HIDDEN
Resent-Date: Sat, 02 Nov 2024 15:35:03 +0000
Resent-Message-ID: <handler.70871.B70871.173056165927184 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70871
X-GNU-PR-Package: mumi
X-GNU-PR-Keywords: patch
To: 70871 <at> debbugs.gnu.org
Cc: =?UTF-8?Q?No=C3=A9?= Lopez <noelopez@HIDDEN>
Received: via spool by 70871-submit <at> debbugs.gnu.org id=B70871.173056165927184
(code B ref 70871); Sat, 02 Nov 2024 15:35:03 +0000
Received: (at 70871) by debbugs.gnu.org; 2 Nov 2024 15:34:19 +0000
Received: from localhost ([127.0.0.1]:54011 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1t7G8o-00074J-Iy
for submit <at> debbugs.gnu.org; Sat, 02 Nov 2024 11:34:19 -0400
Received: from smtp.domeneshop.no ([194.63.252.55]:36641)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <noe@HIDDEN>) id 1t7G8l-000743-SE
for 70871 <at> debbugs.gnu.org; Sat, 02 Nov 2024 11:34:16 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=xn--no-cja.eu; s=ds202402; h=Content-Transfer-Encoding:Content-Type:
MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:From:
Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:
Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:
Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:
References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:
List-Owner:List-Archive; bh=5ddlS/pAdEEHxAcyW+SaDR7GV7f25HUbIIPYbUq2lyM=; b=2
xflX1H8/NyW3kEGgTen08KOiaYeHgw/bWga3dRhY9OpP898aK7HN+dwh83uFR6w6hLj1fcviVkE9P
Wm5dnvyBzWcXhB8yi+7iM6u0M/hYGlpyxLI1tEVI0pJdL1eL2dCALEpoTqj9GtQtPQyghd7ZrVFGE
Zq7g4NLnIMKmkNEro1E/gZcAXLu3kHVeCnqw/IuTOVnjWu4mhJnZZNDyIjD11goUn/WdrmFqOngUj
Cjoak2CJY8EMqnTdxPuNodup5EQId4I4NxJ7Xfo/qtbzwXVIZfXjsDfEvx1bjVwsft0TFUHCj4zoP
+4R4bNA7xiX4u+2NgIcGyaFIkutiS7+WQ==;
Received: from [2a01:e0a:990:a960:b4f3:8f44:ec4:5af5] (port=49536
helo=localhost.localdomain)
by smtp.domeneshop.no with esmtpsa (TLS1.3) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95)
(envelope-from <noe@HIDDEN>) id 1t7G8g-008uEQ-6v;
Sat, 02 Nov 2024 16:34:10 +0100
From: noe@HIDDEN
Date: Sat, 2 Nov 2024 16:34:49 +0100
Message-ID: <20241102153450.958-2-noe@HIDDEN>
In-Reply-To: <20241102153450.958-1-noe@HIDDEN>
References: <20241102153450.958-1-noe@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
From: Noé Lopez <noelopez@HIDDEN>
* mumi/web/view/html.scm (avatar): New function.
---
mumi/web/view/html.scm | 31 +++++++++++++------------------
1 file changed, 13 insertions(+), 18 deletions(-)
diff --git a/mumi/web/view/html.scm b/mumi/web/view/html.scm
index fa19ab4..661f248 100644
--- a/mumi/web/view/html.scm
+++ b/mumi/web/view/html.scm
@@ -424,6 +424,16 @@ failed to process associated messages.")
"Encode PARTS and join them together into an absolute URI path."
(string-append "/" (encode-and-join-uri-path parts)))
+(define* (avatar sender
+ #:optional
+ (participants (list (sender-email sender))))
+ `(div (@ (class "avatar")
+ (style ,(string-append
+ "background-color:"
+ (avatar-color (sender-email sender)
+ participants))))
+ ,(string-upcase (string-take (sender-name sender) 1))))
+
(define* (issue-page bug #:key flash-message plain?)
"Render the conversation for the given BUG."
(define id (bug-num bug))
@@ -450,12 +460,7 @@ failed to process associated messages.")
,(map (match-lambda
((message-number message)
`(li
- (div
- (@ (class "avatar")
- (style ,(string-append "background-color:"
- (avatar-color (sender-email message)
- (map extract-email parties)))))
- ,(string-upcase (string-take (sender-name message) 1)))
+ ,(avatar message (map extract-email parties))
(span (@ (class "date"))
(a (@ (href ,(string-append "#" (number->string
message-number))))
@@ -638,23 +643,13 @@ currently disabled."))
(id ,(number->string message-number))))
(a (@ (class "message-anchor")
(id ,(format #false "msgid-~a" (msgid-hash (message-id message))))))
- (div
- (@ (class "avatar")
- (style ,(string-append "background-color:"
- (avatar-color (sender-email message)
- (map extract-email parties)))))
- ,(string-upcase (string-take (sender-name message) 1)))
+ ,(avatar message (map extract-email parties))
(article
(@ (class "message"))
(header
(div
(@ (class "from"))
- (div
- (@ (class "avatar")
- (style ,(string-append "background-color:"
- (avatar-color (sender-email message)
- (map extract-email parties)))))
- ,(string-upcase (string-take (sender-name message) 1)))
+ ,(avatar message (map extract-email parties))
(span (@ (class "address")) ,(sender-name message))
" wrote "
(span (@ (class "date"))
--
2.46.0
X-Loop: help-debbugs@HIDDEN
Subject: bug#70871: [PATCH v2 2/2] web: Show avatars from Libravatar.
Resent-From: noe@HIDDEN
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-mumi@HIDDEN
Resent-Date: Sat, 02 Nov 2024 15:35:03 +0000
Resent-Message-ID: <handler.70871.B70871.173056166127196 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70871
X-GNU-PR-Package: mumi
X-GNU-PR-Keywords: patch
To: 70871 <at> debbugs.gnu.org
Cc: =?UTF-8?Q?No=C3=A9?= Lopez <noelopez@HIDDEN>
Received: via spool by 70871-submit <at> debbugs.gnu.org id=B70871.173056166127196
(code B ref 70871); Sat, 02 Nov 2024 15:35:03 +0000
Received: (at 70871) by debbugs.gnu.org; 2 Nov 2024 15:34:21 +0000
Received: from localhost ([127.0.0.1]:54014 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1t7G8r-00074a-2H
for submit <at> debbugs.gnu.org; Sat, 02 Nov 2024 11:34:21 -0400
Received: from smtp.domeneshop.no ([194.63.252.55]:57413)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <noe@HIDDEN>) id 1t7G8o-000746-Nx
for 70871 <at> debbugs.gnu.org; Sat, 02 Nov 2024 11:34:19 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=xn--no-cja.eu; s=ds202402; h=Content-Transfer-Encoding:Content-Type:
MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:From:
Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:
Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:
Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:
References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:
List-Owner:List-Archive; bh=ZYWTvm1kdCe32wKgT7CoBJzjgTVcYL+9d7JLTjtkLAE=; b=P
s7eUgQ+xJeuedvCJnHfwM0XzAxNlvVzTvd0PyBNi0+AIJXZz7e1QSxY+ofaSpNq+j/2jPwqtKV41S
PO3zgMYuw4OeEBumKVOyRAqXMNXs/xUr/Kg+aXJa553zLwRaiUY7GuTyy3K3+dcc8c99K2x/1BvAw
H+iETn4OpjgNPeDtKH5CLS7iGX1tH7NGkx+RrCBpHNSuZBkt2BNnKLrGEEFZJTWSgal686ZlTgbYr
C6zCj3HEUGrYf7UxZ8VV2DXVB8EmPBr0hW8p80ZkqcRR9guMa+0IzuvFAfo3SHeFlJqeGNumVH/Qi
/drNEeSUJIm81dsDLVWZ1NRagqkN2Dlaw==;
Received: from [2a01:e0a:990:a960:b4f3:8f44:ec4:5af5] (port=49536
helo=localhost.localdomain)
by smtp.domeneshop.no with esmtpsa (TLS1.3) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95)
(envelope-from <noe@HIDDEN>) id 1t7G8j-008uEQ-2b;
Sat, 02 Nov 2024 16:34:13 +0100
From: noe@HIDDEN
Date: Sat, 2 Nov 2024 16:34:50 +0100
Message-ID: <20241102153450.958-3-noe@HIDDEN>
In-Reply-To: <20241102153450.958-1-noe@HIDDEN>
References: <20241102153450.958-1-noe@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
From: Noé Lopez <noelopez@HIDDEN>
* configure.ac: New dependency.
* mumi/web/view/html.scm: Use Libavatar images as avatars.
---
configure.ac | 5 +++++
mumi/web/view/html.scm | 11 ++++++++---
2 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/configure.ac b/configure.ac
index 5981682..ff754b4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -74,6 +74,11 @@ if test "x$have_kolam" != "xyes"; then
AC_MSG_ERROR([Guile kolam is missing; please install it.])
fi
+GUILE_MODULE_AVAILABLE([have_avatar], [(avatar url)])
+if test "x$have_avatar" != "xyes"; then
+ AC_MSG_ERROR([Guile avatar is missing; please install it.])
+fi
+
guilemoduledir="${datarootdir}/guile/site/${GUILE_EFFECTIVE_VERSION}"
AC_SUBST([guilemoduledir])
AC_SUBST([GUILE_EFFECTIVE_VERSION])
diff --git a/mumi/web/view/html.scm b/mumi/web/view/html.scm
index 661f248..a037a74 100644
--- a/mumi/web/view/html.scm
+++ b/mumi/web/view/html.scm
@@ -19,6 +19,7 @@
;;; <http://www.gnu.org/licenses/>.
(define-module (mumi web view html)
+ #:use-module (avatar url)
#:use-module (email email)
#:use-module (mumi config)
#:use-module (mumi debbugs)
@@ -427,12 +428,16 @@ failed to process associated messages.")
(define* (avatar sender
#:optional
(participants (list (sender-email sender))))
- `(div (@ (class "avatar")
+ `(img (@ (class "avatar")
(style ,(string-append
"background-color:"
(avatar-color (sender-email sender)
- participants))))
- ,(string-upcase (string-take (sender-name sender) 1))))
+ participants)))
+ (src ,(libravatar-url (sender-email sender)
+ #:default "404"
+ #:height 48))
+ (alt ,(string-upcase (string-take (sender-name sender) 1)))
+ (aria-hidden "true"))))
(define* (issue-page bug #:key flash-message plain?)
"Render the conversation for the given BUG."
--
2.46.0
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.