GNU bug report logs - #70902
[PATCH] Drop two invocations of 'apply'.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: mumi; Reported by: Felix Lechner <felix.lechner@HIDDEN>; Keywords: patch; Done: Arun Isaac <arunisaac@HIDDEN>; Maintainer for mumi is bug-mumi@HIDDEN.

Message received at 70902-done <at> debbugs.gnu.org:


Received: (at 70902-done) by debbugs.gnu.org; 13 Feb 2025 22:19:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 13 17:19:40 2025
Received: from localhost ([127.0.0.1]:45992 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tihYa-0005Cw-4Z
	for submit <at> debbugs.gnu.org; Thu, 13 Feb 2025 17:19:40 -0500
Received: from mugam.systemreboot.net ([139.59.75.54]:43244)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <arunisaac@HIDDEN>)
 id 1tihYW-0005Cf-75
 for 70902-done <at> debbugs.gnu.org; Thu, 13 Feb 2025 17:19:38 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=systemreboot.net;
 s=default; t=1739485169;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to; bh=9aMJaHa65GoGKOMZ2an8fYaJbiH1t58iaacaxw4okY4=;
 b=Y531rgERvQ0rnwVcmPT3ZfdN+p31VgxnV6UWdlc59YxSenCIEq2FzmswEEkuVRz5QOTQdl
 ebqmfgZuU0/m4B36UKDV1FCGUiRABuH/58yko+MI3nuCynrbpskq/3wJdaY8z+cFB662Qk
 9Pqms6anx/2iXeg+qyfIKvLWu0hW21xCPJfRESExC9AwbJMm5N759B/v2CvLM/n+SDE9WX
 6gWYQa7gu2v7EhkKD5q6HZe8TLj68J696MLwX+hLBNvUDAOarfJJCrtBhpiHXTGjJ3tdbo
 Knm0LKx65IXWdBLZL4HUFZc1C7Yo2tqH/dL5Hs+QX/ni7Qq63mlfgPQfH7czYQ==
Received: from localhost (<unknown> [192.168.2.1])
 by mugam.systemreboot.net (OpenSMTPD) with ESMTPSA id 41f9e500
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Thu, 13 Feb 2025 22:19:28 +0000 (UTC)
From: Arun Isaac <arunisaac@HIDDEN>
To: 70902-done <at> debbugs.gnu.org
Subject: Re: [PATCH] Drop two invocations of 'apply'.
In-Reply-To: <87wmnywc7m.fsf@HIDDEN>
Date: Thu, 13 Feb 2025 22:19:20 +0000
Message-ID: <87jz9tzdw7.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 70902-done
Cc: Felix Lechner <felix.lechner@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


I discovered these independently and fixed them in
0c9ed892e99189f74582a75f91fb8ab25e9fe498. Sorry about the duplicated
work. Thanks for reporting!




Notification sent to Felix Lechner <felix.lechner@HIDDEN>:
bug acknowledged by developer. Full text available.
Reply sent to Arun Isaac <arunisaac@HIDDEN>:
You have taken responsibility. Full text available.

Message received at 70902 <at> debbugs.gnu.org:


Received: (at 70902) by debbugs.gnu.org; 13 May 2024 04:46:41 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 13 00:46:41 2024
Received: from localhost ([127.0.0.1]:58346 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s6NaD-0007D6-2A
	for submit <at> debbugs.gnu.org; Mon, 13 May 2024 00:46:41 -0400
Received: from sail-ipv4.us-core.com ([208.82.101.137]:43348)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <felix.lechner@HIDDEN>) id 1s6NaB-0007D0-90
 for 70902 <at> debbugs.gnu.org; Mon, 13 May 2024 00:46:39 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=62UZ5bUBthfXOSL
 XXqH/9EZbSns+kFJ51B9eikOtAzA=; h=date:subject:cc:to:from;
 d=lease-up.com; b=HLiW5m9HRiCFbilGIDzRiZvMJrucPjoWDxPPznN+dL1rV6LBazI1
 ApAPrVvjVvuPPXfXn2Z5K+uAka0/5d2DIKt0uJdLQWA2MkWfMP3vm1nCr+oLWqJU7uK2cE
 de68SmfUkpCHlgaCioEUeNbiBLk77uqwcTSWHHbpagxHSBsJ0=
Received: by localhost (OpenSMTPD) with ESMTPA id 55d55c7f
 for <70902 <at> debbugs.gnu.org>; Mon, 13 May 2024 04:46:38 +0000 (UTC)
Delivered-To: 70902@HIDDEN
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=62UZ5bUBthfXOSL
 XXqH/9EZbSns+kFJ51B9eikOtAzA=; h=date:subject:cc:to:from;
 d=lease-up.com; b=HLiW5m9HRiCFbilGIDzRiZvMJrucPjoWDxPPznN+dL1rV6LBazI1
 ApAPrVvjVvuPPXfXn2Z5K+uAka0/5d2DIKt0uJdLQWA2MkWfMP3vm1nCr+oLWqJU7uK2cE
 de68SmfUkpCHlgaCioEUeNbiBLk77uqwcTSWHHbpagxHSBsJ0=
Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id b47f8ae8
 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO)
 for <70902@HIDDEN>; Mon, 13 May 2024 04:46:38 +0000 (UTC)
From: Felix Lechner <felix.lechner@HIDDEN>
To: 70902@HIDDEN
Subject: Preview available
Date: Sun, 12 May 2024 21:46:37 -0700
Message-ID: <87wmnywc7m.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 70902
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

A preview of this code is live at patchwise.org.




Information forwarded to bug-mumi@HIDDEN:
bug#70902; Package mumi. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 13 May 2024 04:30:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 13 00:30:05 2024
Received: from localhost ([127.0.0.1]:58234 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s6NK8-0006tG-SR
	for submit <at> debbugs.gnu.org; Mon, 13 May 2024 00:30:05 -0400
Received: from lists.gnu.org ([209.51.188.17]:60834)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <felix.lechner@HIDDEN>) id 1s6NK3-0006sO-Tc
 for submit <at> debbugs.gnu.org; Mon, 13 May 2024 00:30:02 -0400
Received: from eggs.gnu.org ([209.51.188.92])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <felix.lechner@HIDDEN>)
 id 1s6NFf-0005IC-6a
 for bug-mumi@HIDDEN; Mon, 13 May 2024 00:29:56 -0400
Received: from sail-ipv4.us-core.com ([208.82.101.137])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256)
 (Exim 4.90_1) (envelope-from <felix.lechner@HIDDEN>)
 id 1s6NAi-0004op-El
 for bug-mumi@HIDDEN; Mon, 13 May 2024 00:20:26 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=h0iE3F0cyB8x/BM
 LvtyEiEnJ77fueMJsIwklgzHtY4Y=; h=date:subject:cc:to:from;
 d=lease-up.com; b=qFCDSV8A9jYILKAW4RiXS+Ca0d95FA+sc+VSnoUOFu6TXeExrjwH
 aH7lppJcmyeDiZLE0PyOt3cbNpIn/qjmPwdzEsobxMid/4ea7f9BdHnzNnGOXzOc0YecxR
 43oLsjaxN3uZ0aXlyJ+CU1RgKNqc/Se7IIl4khS3rq8AA7XFg=
Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id d83b4750
 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); 
 Mon, 13 May 2024 04:20:17 +0000 (UTC)
Received: from localhost (localhost [local])
 by localhost (OpenSMTPD) with ESMTPA id 88f8c901;
 Mon, 13 May 2024 04:20:16 +0000 (UTC)
From: Felix Lechner <felix.lechner@HIDDEN>
To: bug-mumi@HIDDEN
Subject: [PATCH] Drop two invocations of 'apply'.
Date: Sun, 12 May 2024 21:20:12 -0700
Message-ID: <20240513042012.5053-1-felix.lechner@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=208.82.101.137;
 envelope-from=felix.lechner@HIDDEN; helo=sail-ipv4.us-core.com
X-Spam_score_int: -19
X-Spam_score: -2.0
X-Spam_bar: --
X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.1 (-)
X-Debbugs-Envelope-To: submit
Cc: Felix Lechner <felix.lechner@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.1 (--)

They stood out among other nearby calls to render-html, and do not
appear to be needed.
---
 mumi/web/download.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mumi/web/download.scm b/mumi/web/download.scm
index 5c12fca..d4eb09e 100644
--- a/mumi/web/download.scm
+++ b/mumi/web/download.scm
@@ -56,7 +56,7 @@ PATH."
      (html-response (email-headers entry)
                     (email-body entry)))
     (_
-     (apply render-html (unknown id)))))
+     (render-html (unknown id)))))
 
 (define (download-raw id msg-num)
   "Handle download of an attachment for bug ID, message number
@@ -77,4 +77,4 @@ PATH."
                 (content-disposition text/plain
                                      (filename . ,(format #f "~a-~a.mbox" id msg-num))))
               (list-ref emails msg-num))
-      (apply render-html (unknown id))))
+      (render-html (unknown id))))

base-commit: 99416ed5c7d950eaf54d52023a2efd975bccac92
-- 
2.41.0





Acknowledgement sent to Felix Lechner <felix.lechner@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-mumi@HIDDEN. Full text available.
Report forwarded to bug-mumi@HIDDEN:
bug#70902; Package mumi. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Thu, 13 Feb 2025 22:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.