GNU logs - #71844, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#71844: [PATCH] 29.1; "cucumber" in compilation-error-regexp-alist-alist is too aggressive
Resent-From: Matthew Bauer <mjbauer95@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 29 Jun 2024 22:33:04 +0000
Resent-Message-ID: <handler.71844.B.171970034414195 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 71844 <at> debbugs.gnu.org
From: Matthew Bauer <mjbauer95@HIDDEN>
Date: Sat, 29 Jun 2024 14:55:05 -0500
Message-ID: <m2le2n1q3q.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=2607:f8b0:4864:20::d29;
 envelope-from=mjbauer95@HIDDEN; helo=mail-io1-xd29.google.com
X-Spam_score_int: -17
X-Spam_score: -1.8
X-Spam_bar: -
X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.1 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.1 (--)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

I believe this regex for cucumber is not precise enough. Specifically,
it was picking up this indentation in an error message from GHC:

Main.hs:195:1: error: [GHC-44432]
    The type signature for =E2=80=98apathway=E2=80=99 lacks an accompanying=
 binding
    Suggested fix:
      Perhaps use one of these:
        =E2=80=98foo=E2=80=99 (Defined at Main.hs:196:1),
        =E2=80=98foo=E2=80=99 (Defined at Main.hs:216:1)

It picked up this as being error messages which I believe it shouldn=E2=80=
=99t have:

   =E2=80=98foo=E2=80=99 (Defined at Main.hs:216
   =E2=80=98foo=E2=80=99 (Defined at Main.hs:216

This change just ignores it if there is remaining space. Probably it
still needs to be refined, but this at least avoids this false positive
for me.


--=-=-=
Content-Type: text/x-patch; charset=utf-8
Content-Disposition: attachment;
 filename=0001-Try-to-limit-false-positives-for-cucumber-compilatio.patch
Content-Transfer-Encoding: quoted-printable
Content-Description: Fix "cucumber" regexp

From 3a5e45ec2d836a38348e802c441d567e070b138c Mon Sep 17 00:00:00 2001
From: Matthew Bauer <mjbauer95@HIDDEN>
Date: Sat, 29 Jun 2024 14:45:35 -0500
Subject: [PATCH] Try to limit false positives for cucumber compilation
MIME-Version: 1.0
Content-Type: text/plain; charset=3DUTF-8
Content-Transfer-Encoding: 8bit

I believe this regex for cucumber is not precise enough. Specifically,
it was picking up this indentation in an error message from GHC:

Main.hs:195:1: error: [GHC-44432]
    The type signature for =E2=80=98apathway=E2=80=99 lacks an accompanying=
 binding
    Suggested fix:
      Perhaps use one of these:
        =E2=80=98foo=E2=80=99 (Defined at Main.hs:196:1),
        =E2=80=98foo=E2=80=99 (Defined at Main.hs:216:1)

It picked up this as being error messages which I believe it shouldn=E2=80=
=99t have:

   =E2=80=98foo=E2=80=99 (Defined at Main.hs:216
   =E2=80=98foo=E2=80=99 (Defined at Main.hs:216

This change just ignores it if there is remaining space. Probably it
still needs to be refined, but this at least avoids this false positive
for me.
---
 lisp/progmodes/compile.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index 2e4eb11811a..a03f1935971 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -473,7 +473,7 @@ of[ \t]+\"?\\([a-zA-Z]?:?[^\":\n]+\\)\"?:" 3 2 nil (1))
                    "     "))
              "#")
           " "
-          (group (not "(") (* nonl))          ; file
+          (group (not (in "( ")) (* nonl))          ; file
           ":"
           (group (in "1-9") (* (in "0-9"))))  ; line
      1 2)
--=20
2.39.3 (Apple Git-146)


--=-=-=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Matthew Bauer <mjbauer95@HIDDEN>
Subject: bug#71844: Acknowledgement ([PATCH] 29.1; "cucumber" in
 compilation-error-regexp-alist-alist is too aggressive)
Message-ID: <handler.71844.B.171970034414195.ack <at> debbugs.gnu.org>
References: <m2le2n1q3q.fsf@HIDDEN>
X-Gnu-PR-Message: ack 71844
X-Gnu-PR-Package: emacs
X-Gnu-PR-Keywords: patch
Reply-To: 71844 <at> debbugs.gnu.org
Date: Sat, 29 Jun 2024 22:33:04 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 71844 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
71844: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D71844
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#71844: [PATCH] 29.1; "cucumber" in compilation-error-regexp-alist-alist is too aggressive
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 30 Jun 2024 05:07:01 +0000
Resent-Message-ID: <handler.71844.B71844.171972397110475 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Matthew Bauer <mjbauer95@HIDDEN>
Cc: 71844 <at> debbugs.gnu.org
Date: Sun, 30 Jun 2024 08:05:54 +0300
Message-Id: <8634ovhvf1.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <m2le2n1q3q.fsf@HIDDEN> (message from Matthew Bauer on Sat, 29
 Jun 2024 14:55:05 -0500)
References: <m2le2n1q3q.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> From: Matthew Bauer <mjbauer95@HIDDEN>
> Date: Sat, 29 Jun 2024 14:55:05 -0500
> 
> I believe this regex for cucumber is not precise enough. Specifically,
> it was picking up this indentation in an error message from GHC:
> 
> Main.hs:195:1: error: [GHC-44432]
>     The type signature for ‘apathway’ lacks an accompanying binding
>     Suggested fix:
>       Perhaps use one of these:
>         ‘foo’ (Defined at Main.hs:196:1),
>         ‘foo’ (Defined at Main.hs:216:1)
> 
> It picked up this as being error messages which I believe it shouldn’t have:
> 
>    ‘foo’ (Defined at Main.hs:216
>    ‘foo’ (Defined at Main.hs:216

Why not? don't you want to be able to visit the definitions to examine
whether they are the right fix?

More generally, compilation-mode doesn't (yet) support the "fix
suggestion" features offered by some of the modern compilers.  IMO, we
should address this kind of situations in a general framework of
supporting fix suggestions, not just by ad-hoc changes in the regexps
that recognize error messages.  Patches welcome.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 11 Feb 2025 19:34:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 11 14:34:06 2025
Received: from localhost ([127.0.0.1]:58744 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1thw1G-0007Ci-AK
	for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 14:34:06 -0500
Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]:49543)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1thw1E-0007Bg-DS
 for control <at> debbugs.gnu.org; Tue, 11 Feb 2025 14:34:04 -0500
Received: by mail-ed1-x52c.google.com with SMTP id
 4fb4d7f45d1cf-5de5a853090so7812976a12.3
 for <control <at> debbugs.gnu.org>; Tue, 11 Feb 2025 11:34:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1739302438; x=1739907238; darn=debbugs.gnu.org;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=ukfGiskPKjyIETreEilN/aD74JlxY22EGRPWM39pWic=;
 b=kjtLFMIfyq7bj7ZIl1eNIv1ny0KSjqBZz1Z97pL4VYp+0/A5D0OL/0n9bpj3iTbKlt
 LpR7if/hgP1m6rEWqYdzVlYjsENyxfe1dW4EhO717LqqSr1sg2Ch5+yZcwsgT68CXb8f
 sB/gkNkHtQXK6U2QCRHRvxKkTgEBcl1e8+g+FxbUc45mC/L0fuktXs/icN4zC0WJ4+gV
 DatdB7UZvs+VfmEpNxI6fzXjDeJ3T4WQgpnQ0DyZZGGgfD0bCWqjE7WWo58Z4rFPjHuE
 kGNJopgqdzsr5eDSBdvcDj6ePM4/lENBkjtEhjmYHVIE6RLpx+5mLHnrcrPpz0d4Hbln
 +1zg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1739302438; x=1739907238;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=ukfGiskPKjyIETreEilN/aD74JlxY22EGRPWM39pWic=;
 b=M1Sc1TcgAH1w/XOw9WZGzTfmWt5YnfCqyZ3mg1Ypi6dnVUVVgRjHdiwGMzbWRZTCPr
 LFLyvNU+HPvnFc9YZP0ro54xT/+EOqfbmUhk2xaljQ4oI3pVp4vajxBtXn7HInSSpGLb
 vAhUNsl2UgrY5AWckAL4krswLJyx/rGipoW7SqOIS4cnHxryuZ9HNC0lQ4nY3Loqpaq3
 Ypcejz6Dzh0KR2r5wPELRZkscpYOw3sFm0Z7Elx9cKyiOqf6ux9Cio4bVqOXIx1KbrE4
 oVwlIg3BMUec61RmNyXCeZNNH3RbOTEt0hiD4G2TeVLEkoBhN8k5o04NXHajcZ/C9UZ4
 yuIQ==
X-Gm-Message-State: AOJu0Ywbc3vm/VrP2MoXKzStgJmexLDJSLHuJy9EBcVYrl6M9cC6OyZH
 P8CjIo6prq9u+Tf6kI5qCNp5VbDuWoFN+5jL9aoPYNYQiCexQPG8n7BrSj0s9OXRsBM0eAoI76G
 O6p1I+3QGWmLs76mcRfVd6EOzy3IIYT/hv1QQVw==
X-Gm-Gg: ASbGncvAPMbUQZb+UUlfpczzkFfgkRP98DJWwLaTg9MevMgh2NHscAC0FKNF3F8hmsj
 jFOiSs/XG3ZEk01I/W6fF67KVlo20Rz7TaqWQJZRtX/zyl2IQNNlNYG2igYWW2avitu61X+EtCQ
 ==
X-Google-Smtp-Source: AGHT+IEYlnyhc4/7MLJdAafmtIBWlGbbzgWIhr3pIIBJe6f6is7v93oMTLNEbnOVWny2HME9MUlXCNhMAY2nRXOIJdI=
X-Received: by 2002:a05:6402:2084:b0:5de:a7db:3a7c with SMTP id
 4fb4d7f45d1cf-5deaddba613mr423539a12.17.1739302438236; Tue, 11 Feb 2025
 11:33:58 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Tue, 11 Feb 2025 11:33:57 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
MIME-Version: 1.0
Date: Tue, 11 Feb 2025 11:33:57 -0800
X-Gm-Features: AWEUYZlxyEdAYSob4xa0HCKLRr5GQji4yimlhNalnkTPXSVQDCxBmxVmQ4kcI0M
Message-ID: <CADwFkmmKPz5TGfwK=C3W292veTkYmRfu2fUjAokSP58OYZM7Cg@HIDDEN>
Subject: control message for bug #71844
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

severity 71844 wishlist
quit

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#71844: [PATCH] 29.1; "cucumber" in compilation-error-regexp-alist-alist is too aggressive
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 04 Mar 2025 02:16:02 +0000
Resent-Message-ID: <handler.71844.B71844.174105452128112 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 71844
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Matthew Bauer <mjbauer95@HIDDEN>
Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>, 71844 <at> debbugs.gnu.org
Received: via spool by 71844-submit <at> debbugs.gnu.org id=B71844.174105452128112
          (code B ref 71844); Tue, 04 Mar 2025 02:16:02 +0000
Received: (at 71844) by debbugs.gnu.org; 4 Mar 2025 02:15:21 +0000
Received: from localhost ([127.0.0.1]:53489 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tpHoW-0007I4-HM
	for submit <at> debbugs.gnu.org; Mon, 03 Mar 2025 21:15:21 -0500
Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]:53494)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1tpHoT-0006qY-Mk
 for 71844 <at> debbugs.gnu.org; Mon, 03 Mar 2025 21:15:18 -0500
Received: by mail-ed1-x534.google.com with SMTP id
 4fb4d7f45d1cf-5e57c81d5d0so1434653a12.2
 for <71844 <at> debbugs.gnu.org>; Mon, 03 Mar 2025 18:15:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1741054511; x=1741659311; darn=debbugs.gnu.org;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=DMq/kFGo5dLPyo0hNKcxZh4eHYjWe3PGl95xUCb7Hpk=;
 b=eK70wRpiHqoh5IxEfP0Ln9/laTW7iDfPMy/YNJsWNW+Vc0WxP9HOeSX+oNeaPfshRg
 7eh9xW/f/NObY6HfmULtkvTEyI4gjjR5NgcxmTHPV/o+OnS0J7FftG28AG1HoQeLYXzm
 f6WttbBPCmrn1812rfxR5S1uNkeC48u3E+7jANdsD2sQwMFQS+Hktapz4H17YIKYAn1b
 EEfSZDjzSn1vQkK1IpkFmD2XivK/xMEosfh1qBVAoIy63NHjfzwQa7kjQvZYSujYlPJw
 xtRqsJRhNEm/FMnl33ZEOai+/92GGYQD7xp+jWC2T5BU/X3SM5n8FoZW96o7qwbZZbAy
 XZ8w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1741054511; x=1741659311;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:x-gm-message-state:from:to
 :cc:subject:date:message-id:reply-to;
 bh=DMq/kFGo5dLPyo0hNKcxZh4eHYjWe3PGl95xUCb7Hpk=;
 b=LwG6BoMIp06SR2FJuCikS8sYDHmeCyABvVShzJTsdl9bJFYoqNOuctvDfqw2DiYrOO
 J3sXvK1qFQFMsbh0O3QbVekrvdCzwYCs2YzigIK6eBk3sEF0P792vy+IuG/rcSVQvqDW
 xR/V7aWZnYvMzRYyKBbKEqNiJ8J0lc+CLIhres1MtoBcB8n2QflhalTyxnsfPXvjicLe
 OcjfGA55KqQRVciOT9Jp4SbyElBCcya9vbr01ZuqSqSJR+m0p7sQsgNGB0R5pYupki3+
 O0V8PvGjwri3QQR8az7ybyajFpKN1ANCvRkwETsoV+ibrnTaLeAJx9rNtB27XHWbdIEi
 X3cA==
X-Gm-Message-State: AOJu0YwTyiBLN04bhyaSXb/mr/8isChS+2+CUHdjR/apuhxClJ1D9G6r
 r0zYmYq5fgrSCoCSaVxQK83ACPnVE3nv6qZPtZaMp4LNVP5wKz/mPaDEfzkm6VK8T2V81+Rmm2E
 Zm7couwoMXoChonNwMYoYYSn2aDlACMG/F6s=
X-Gm-Gg: ASbGncvRe+B013ZIGhRxxcc/ZkWF3p+je7hFA/YORVSnwAjxHTZDnrgWLToWALcRc6A
 DpPooJCDR1vCo7R/xGXdZyaFpOY7yGwHCoeVLhvdeD03EMRabGPm3DRAMT6phuqPa8oTfUNT27W
 4P4w08V6E62w2M+WYoq8+uHCLbTg==
X-Google-Smtp-Source: AGHT+IFG/JJky8jD7lzTQ0KACUV1DCi7ftYFw3MZwCjcHvsqLHJpi8JsIuGqzt9xZpKQNcc0Okz92QQJ3aucAh5iVMM=
X-Received: by 2002:a05:6402:42c8:b0:5df:25e8:26d2 with SMTP id
 4fb4d7f45d1cf-5e4d6ac58fdmr37504138a12.5.1741054510972; Mon, 03 Mar 2025
 18:15:10 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Tue, 4 Mar 2025 02:15:10 +0000
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <m2le2n1q3q.fsf@HIDDEN>
References: <m2le2n1q3q.fsf@HIDDEN>
MIME-Version: 1.0
Date: Tue, 4 Mar 2025 02:15:10 +0000
X-Gm-Features: AQ5f1JqpW4RA2Ulakv2txOVru_I2Z2AxyJc7KbXiHv4XucBAMxFBmyKK7mUjTYE
Message-ID: <CADwFkm=Zfv9-a5BeH-p0fV7CP0VipCt6-Zjw+ZMWwJHxwjSadA@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Matthew Bauer <mjbauer95@HIDDEN> writes:

> I believe this regex for cucumber is not precise enough. Specifically,
> it was picking up this indentation in an error message from GHC:
>
> Main.hs:195:1: error: [GHC-44432]
>     The type signature for =E2=80=98apathway=E2=80=99 lacks an accompanyi=
ng binding
>     Suggested fix:
>       Perhaps use one of these:
>         =E2=80=98foo=E2=80=99 (Defined at Main.hs:196:1),
>         =E2=80=98foo=E2=80=99 (Defined at Main.hs:216:1)
>
> It picked up this as being error messages which I believe it shouldn=E2=
=80=99t have:
>
>    =E2=80=98foo=E2=80=99 (Defined at Main.hs:216
>    =E2=80=98foo=E2=80=99 (Defined at Main.hs:216
>
> This change just ignores it if there is remaining space. Probably it
> still needs to be refined, but this at least avoids this false positive
> for me.

Mattias, maybe you have some comments on this one?

>>From 3a5e45ec2d836a38348e802c441d567e070b138c Mon Sep 17 00:00:00 2001
> From: Matthew Bauer <mjbauer95@HIDDEN>
> Date: Sat, 29 Jun 2024 14:45:35 -0500
> Subject: [PATCH] Try to limit false positives for cucumber compilation
> MIME-Version: 1.0
> Content-Type: text/plain; charset=3DUTF-8
> Content-Transfer-Encoding: 8bit
>
> I believe this regex for cucumber is not precise enough. Specifically,
> it was picking up this indentation in an error message from GHC:
>
> Main.hs:195:1: error: [GHC-44432]
>     The type signature for =E2=80=98apathway=E2=80=99 lacks an accompanyi=
ng binding
>     Suggested fix:
>       Perhaps use one of these:
>         =E2=80=98foo=E2=80=99 (Defined at Main.hs:196:1),
>         =E2=80=98foo=E2=80=99 (Defined at Main.hs:216:1)
>
> It picked up this as being error messages which I believe it shouldn=E2=
=80=99t have:
>
>    =E2=80=98foo=E2=80=99 (Defined at Main.hs:216
>    =E2=80=98foo=E2=80=99 (Defined at Main.hs:216
>
> This change just ignores it if there is remaining space. Probably it
> still needs to be refined, but this at least avoids this false positive
> for me.
> ---
>  lisp/progmodes/compile.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
> index 2e4eb11811a..a03f1935971 100644
> --- a/lisp/progmodes/compile.el
> +++ b/lisp/progmodes/compile.el
> @@ -473,7 +473,7 @@ of[ \t]+\"?\\([a-zA-Z]?:?[^\":\n]+\\)\"?:" 3 2 nil (1=
))
>                     "     "))
>               "#")
>            " "
> -          (group (not "(") (* nonl))          ; file
> +          (group (not (in "( ")) (* nonl))          ; file
>            ":"
>            (group (in "1-9") (* (in "0-9"))))  ; line
>       1 2)

Last modified: Tue, 4 Mar 2025 02:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.