GNU logs - #72334, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#72334: [PATCH] Always print commas and comma-ats specially
Resent-From: Thuna <thuna.cing@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 28 Jul 2024 13:34:01 +0000
Resent-Message-ID: <handler.72334.B.17221735932264 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 72334 <at> debbugs.gnu.org
From: Thuna <thuna.cing@HIDDEN>
Date: Sun, 28 Jul 2024 15:30:40 +0200
Message-ID: <874j893apr.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=2a00:1450:4864:20::536;
 envelope-from=thuna.cing@HIDDEN; helo=mail-ed1-x536.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

--=-=-=
Content-Type: text/plain

In 55481 the recursion was fixed but backquotes and comma(-at)s were
left as-is, so as to print comma(-at)s specially only if they are
escaping a backquote.

This is not particularly useful (and I would argue is bad), so something
like the attached patch could be a good starting point to make it so
that they are always printed specially (given `print-quoted' is non-nil
and it is a proper list of length two - the usual checks for other
quoted forms), which also solves(maybe? - it was not the primary goal)
the recursion.  Feel free to change or drop whatever.


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
 filename=0001-Always-print-commas-and-comma-ats-specially-with-pri.patch

From bdb1af8498b523c7e80a02675035037884a2f1d0 Mon Sep 17 00:00:00 2001
From: Thuna <thuna.cing@HIDDEN>
Date: Sun, 28 Jul 2024 14:45:40 +0200
Subject: [PATCH] Always print commas and comma-ats specially with print-quoted

---
 src/print.c | 47 +++++++++++++++--------------------------------
 1 file changed, 15 insertions(+), 32 deletions(-)

diff --git a/src/print.c b/src/print.c
index 8f28b14e8b6..256f19aeb90 100644
--- a/src/print.c
+++ b/src/print.c
@@ -2488,43 +2488,26 @@ print_object (Lisp_Object obj, Lisp_Object printcharfun, bool escapeflag)
 	  && print_depth > XFIXNUM (Vprint_level))
 	print_c_string ("...", printcharfun);
       else if (print_quoted && CONSP (XCDR (obj)) && NILP (XCDR (XCDR (obj)))
-	       && EQ (XCAR (obj), Qquote))
+	       && (EQ (XCAR (obj), Qquote) ||
+		   EQ (XCAR (obj), Qfunction) ||
+		   EQ (XCAR (obj), Qbackquote) ||
+		   EQ (XCAR (obj), Qcomma) ||
+		   EQ (XCAR (obj), Qcomma_at)))
 	{
-	  printchar ('\'', printcharfun);
+	  if (EQ (XCAR (obj), Qquote))
+	    printchar ('\'', printcharfun);
+	  else if (EQ (XCAR (obj), Qfunction))
+	    print_c_string("#'", printcharfun);
+          else if (EQ (XCAR (obj), Qbackquote))
+	    printchar ('`', printcharfun);
+          else if (EQ (XCAR (obj), Qcomma))
+	    printchar (',', printcharfun);
+          else if (EQ (XCAR (obj), Qcomma_at))
+	    print_c_string (",@", printcharfun);
 	  obj = XCAR (XCDR (obj));
 	  --print_depth;	/* tail recursion */
 	  goto print_obj;
 	}
-      else if (print_quoted && CONSP (XCDR (obj)) && NILP (XCDR (XCDR (obj)))
-	       && EQ (XCAR (obj), Qfunction))
-	{
-	  print_c_string ("#'", printcharfun);
-	  obj = XCAR (XCDR (obj));
-	  --print_depth;	/* tail recursion */
-	  goto print_obj;
-	}
-      /* FIXME: Do we really need the new_backquote_output gating of
-	 special syntax for comma and comma-at?  There is basically no
-	 benefit from it at all, and it would be nice to get rid of
-	 the recursion here without additional complexity.  */
-      else if (print_quoted && CONSP (XCDR (obj)) && NILP (XCDR (XCDR (obj)))
-	       && EQ (XCAR (obj), Qbackquote))
-	{
-	  printchar ('`', printcharfun);
-	  new_backquote_output++;
-	  print_object (XCAR (XCDR (obj)), printcharfun, escapeflag);
-	  new_backquote_output--;
-	}
-      else if (print_quoted && CONSP (XCDR (obj)) && NILP (XCDR (XCDR (obj)))
-	       && (EQ (XCAR (obj), Qcomma)
-		   || EQ (XCAR (obj), Qcomma_at))
-	       && new_backquote_output)
-	{
-	  print_object (XCAR (obj), printcharfun, false);
-	  new_backquote_output--;
-	  print_object (XCAR (XCDR (obj)), printcharfun, escapeflag);
-	  new_backquote_output++;
-	}
       else
 	{
 	  printchar ('(', printcharfun);
-- 
2.44.2


--=-=-=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Thuna <thuna.cing@HIDDEN>
Subject: bug#72334: Acknowledgement ([PATCH] Always print commas and
 comma-ats specially)
Message-ID: <handler.72334.B.17221735932264.ack <at> debbugs.gnu.org>
References: <874j893apr.fsf@HIDDEN>
X-Gnu-PR-Message: ack 72334
X-Gnu-PR-Package: emacs
X-Gnu-PR-Keywords: patch
Reply-To: 72334 <at> debbugs.gnu.org
Date: Sun, 28 Jul 2024 13:34:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 72334 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
72334: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72334
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.