GNU bug report logs - #72403
[PATCH] gnu: make-mingw-w64: allow overriding runtime

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 31 Jul 2024 16:36:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jul 31 12:36:02 2024
Received: from localhost ([127.0.0.1]:50205 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sZCIz-0005DT-Ve
	for submit <at> debbugs.gnu.org; Wed, 31 Jul 2024 12:36:02 -0400
Received: from lists.gnu.org ([209.51.188.17]:39454)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <fanquake@HIDDEN>) id 1sZCIx-0005D2-MT
 for submit <at> debbugs.gnu.org; Wed, 31 Jul 2024 12:36:00 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <fanquake@HIDDEN>)
 id 1sZCIh-0003yF-NQ
 for guix-patches@HIDDEN; Wed, 31 Jul 2024 12:35:43 -0400
Received: from mail-yb1-xb32.google.com ([2607:f8b0:4864:20::b32])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <fanquake@HIDDEN>)
 id 1sZCIc-0005vi-Ct
 for guix-patches@HIDDEN; Wed, 31 Jul 2024 12:35:43 -0400
Received: by mail-yb1-xb32.google.com with SMTP id
 3f1490d57ef6-e0875f1e9edso4358832276.1
 for <guix-patches@HIDDEN>; Wed, 31 Jul 2024 09:35:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1722443733; x=1723048533; darn=gnu.org;
 h=to:subject:message-id:date:from:mime-version:from:to:cc:subject
 :date:message-id:reply-to;
 bh=Jz88J+0hfPMo1L8UQ5sOxOPzonuATfXnKz55ITQ2ens=;
 b=KNhy3KpFC3EM400nt8jA2x+WIkQGN/H56OqEP1BkmbAIdDDHOKPut7C1uipSWRBoKt
 K1gI9g0w25Ms2jsCjOsNazb7eoeukwL5fTx3RSslWid6rphlDQ9viYh8MdI1xXcXNylc
 JT+sBrwmOg7yJZbntZr5L0kACLCmnCh8OijD6Z/Q2vkxSYM43OfI6b4C/BWA1Wf0wiY6
 qmHbhYCZkTlTMHgKHHOIYY4Yd46zCsbgaf3+gfvmbMdqt8DlmELm5ou7DEWk3CgY9JtZ
 1nxMth5kz7h2QxyOFZxmw6L2CmyZxz0RGdSu5Zf7EeDk0s5BIbS0lvD8Tn406k5X9vmM
 ghQQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1722443733; x=1723048533;
 h=to:subject:message-id:date:from:mime-version:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=Jz88J+0hfPMo1L8UQ5sOxOPzonuATfXnKz55ITQ2ens=;
 b=cQCbf5kY2wFwOz1JTUqOYd/kunN/CwPLZrgpCz74SccTjacyH3d+7EzJa+dX3/lkE0
 Ni99eq52gGVSO5JzIfNJLU0zmtZe0mdQCOAyy6Ht3xqJo6irKjdIdfwzzovJ+JTj6Y/d
 VtmziK+/xs+pkQxz99qKn9HjLWfRsi5iY4W60MthdWv9w1RcLvIi6r9hY/pqqUw1YiOc
 TdwU628kWN8ZtLpQkWjjJKJ5BRoSQk8Xba4agNEDl0HJ2+5iWwiNU7zyLxvIdTQqDKyT
 hT3m1Gi85Axh0FBh7lmg6NVYp5QQonDDt2P7qZeo81ZUHG+ikbd+fPrvWNBj4LFpEJo8
 l6Xg==
X-Gm-Message-State: AOJu0YzMlh/a1nvvXWzjSPQCRreXDNa3pNEDAQjJoeu18NImQpX12GS0
 um5Gje8z5z3xlCmC65AcxIp7PW1lsW/YI9GGp59gGcqNy0ngpsaNK2k3ZcEiZL8q4qxoUQEI2NV
 UA8+YiNaxDVyyA9ecMW1/z2vzEujVixj2
X-Google-Smtp-Source: AGHT+IEM6YJe5X669sjjFlJPWC8R7iDpI7KPMsqVIyPUaAS+KLdtjyJqFOPVZSqYUolHNJhBxA/b0G25e420CBTE1iM=
X-Received: by 2002:a05:6902:1008:b0:e0b:b1c6:8df3 with SMTP id
 3f1490d57ef6-e0bb1c69068mr4115874276.6.1722443733141; Wed, 31 Jul 2024
 09:35:33 -0700 (PDT)
MIME-Version: 1.0
From: Michael Ford <fanquake@HIDDEN>
Date: Wed, 31 Jul 2024 17:35:22 +0100
Message-ID: <CAFyhPjXfB-gJok=cL688t1TGFd1P85+k8h8-agHLOk0tcJF5Eg@HIDDEN>
Subject: [PATCH] gnu: make-mingw-w64: allow overriding runtime
To: guix-patches@HIDDEN
Content-Type: text/plain; charset="UTF-8"
Received-SPF: pass client-ip=2607:f8b0:4864:20::b32;
 envelope-from=fanquake@HIDDEN; helo=mail-yb1-xb32.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

This would be quite convenient when calling make-mingw-w64/building a
cross-compiler, to be able to use the newer "ucrt" runtime, if
desired.

From f6c97a742375b2f7e2111f0893062d37dff5e8eb Mon Sep 17 00:00:00 2001
From: fanquake <fanquake@HIDDEN>
Date: Wed, 31 Jul 2024 11:27:47 +0100
Subject: [PATCH] gnu: make-mingw-w64: allow overriding runtime

Retain the msvcrt runtime as the default.
---
 gnu/packages/mingw.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/mingw.scm b/gnu/packages/mingw.scm
index ea579d4043..1f7d5c9668 100644
--- a/gnu/packages/mingw.scm
+++ b/gnu/packages/mingw.scm
@@ -35,6 +35,7 @@ (define* (make-mingw-w64/implementation machine
                                         #:key
                                         xgcc
                                         xbinutils
+                                        (runtime "msvcrt")
                                         with-winpthreads?)
   "Return a mingw-w64 for targeting MACHINE.  If XGCC or XBINUTILS is
specified,
 use that gcc or binutils when cross-compiling.  If WITH-WINPTHREADS? is
@@ -87,7 +88,7 @@ (define* (make-mingw-w64/implementation machine
                      ;;
                      ;; XXX: A new target to use UCRT can be introduced as
                      ;; the MSYS2 project does, e.g: x86_64-w64-ucrt-mingw32.
-                     "--with-default-msvcrt=msvcrt")
+                     #$(string-append "--with-default-msvcrt=" runtime))
              #:make-flags #~'("DEFS=-DHAVE_CONFIG_H -D__MINGW_HAS_DXSDK=1")
              #:phases
              #~(modify-phases %standard-phases
-- 
2.46.0