GNU logs - #72666, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#72666] [PATCH] Add firefly-synth package
Resent-From: Apoorv <apoorvs@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 16 Aug 2024 10:45:02 +0000
Resent-Message-ID: <handler.72666.B.172380504527486 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 72666 <at> debbugs.gnu.org
Date: Fri, 16 Aug 2024 12:43:19 +0200 (CEST)
From: Apoorv <apoorvs@HIDDEN>
Message-ID: <O4PmCjA--B-9@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; 
 boundary="----=_Part_83028_1927746075.1723804999562"
Received-SPF: pass client-ip=81.3.6.162; envelope-from=apoorvs@HIDDEN;
 helo=w1.tutanota.de
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001,
 RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

------=_Part_83028_1927746075.1723804999562
Content-Type: multipart/alternative; 
	boundary="----=_Part_83029_1602904391.1723804999562"

------=_Part_83029_1602904391.1723804999562
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

This is a patch to add a new package, `firefly-synth` to `gnu/packages/music.scm`.

-- 
 Sent with Tuta; enjoy secure & ad-free emails: 
 https://tuta.com

------=_Part_83029_1602904391.1723804999562
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<html>
  <head>
    <meta http-equiv="content-type" content="text/html; charset=UTF-8">
  </head>
  <body>
<div dir="auto">This is a patch to add a new package, `firefly-synth` to `gnu/packages/music.scm`.<br></div><div dir="auto"><br></div><div dir="auto">-- <br></div><div dir="auto"> Sent with Tuta; enjoy secure &amp; ad-free emails: <br></div><div dir="auto"> https://tuta.com<br></div>  </body>
</html>

------=_Part_83029_1602904391.1723804999562--

------=_Part_83028_1927746075.1723804999562
Content-Type: text/x-patch; charset=us-ascii; 
	name=0013-Add-firefly-synth-package.patch
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; 
	filename=0013-Add-firefly-synth-package.patch

From 5d08a4fee0ac8906780c43f340d01e9d0b82c03b Mon Sep 17 00:00:00 2001
From: apoorv569 <apoorvs569@HIDDEN>
Date: Fri, 16 Aug 2024 15:37:25 +0530
Subject: [PATCH 13/13] Add firefly-synth package

---
 gnu/packages/music.scm | 70 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 70 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 5b89419b07..6a28d73429 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -8577,6 +8577,76 @@ (define-public bitrot-plugins
       "Audio effect plugins (LV2, VST2, LADSPA) for glitch effects")
      (license license:asl2.0))))
 
+(define-public firefly-synth
+  (let ((commit "b4ba5a90461d698000df73ebff736570667e42ac")
+        (revision "1"))
+    (package
+     (name "firefly-synth")
+     (version (git-version "1.8.5" revision commit))
+     (source
+      (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/sjoerdvankreel/firefly-synth")
+             (recursive? #t)
+             (commit commit)))
+       (sha256
+        (base32 "1j6cap45608jdybgj3zsqlfbzmqpqxl29jk7ikk3x7d29jaxw84r"))
+       (file-name (git-file-name name version))))
+     (build-system cmake-build-system)
+     (arguments
+      (list
+       #:tests? #f ;; No test target
+       #:build-type "Release"
+       #:phases
+       #~(modify-phases
+          %standard-phases
+          (add-after 'install 'plugin-base-ref-gen
+                     (lambda* (#:key outputs #:allow-other-keys)
+                       (let* ((out (assoc-ref outputs "out")))
+                         (with-directory-excursion
+                          "../source/dist/Release/linux"
+                          (system*
+                           "./plugin_base.ref_gen"
+                           "firefly_synth_1.vst3/Contents/x86_64-linux/firefly_synth_1.so"
+                           "../../../param_reference.html")))))
+          (add-after 'plugin-base-ref-gen 'copy-plugin-artefacts
+                     (lambda* (#:key inputs outputs #:allow-other-keys)
+                       (let* ((out (assoc-ref outputs "out"))
+                              (src (assoc-ref inputs "source"))
+                              (clap (string-append out "/lib/clap"))
+                              (vst3 (string-append out "/lib/vst3")))
+                         ;; Make clap and vst3 directories
+                         (mkdir-p clap)
+                         (mkdir-p vst3)
+                         (with-directory-excursion
+                          "../source/dist/Release/linux"
+                          ;; Install clap.
+                          (copy-recursively
+                           "firefly_synth_1.clap"
+                           (string-append clap "/firefly_synth_1.clap"))
+                          (copy-recursively
+                           "firefly_synth_fx_1.clap"
+                           (string-append clap "/firefly_synth_fx_1.clap"))
+                          ;; Install vst3.
+                          (copy-recursively
+                           "firefly_synth_1.vst3"
+                           (string-append vst3 "/firefly_synth_1.vst3"))
+                          (copy-recursively
+                           "firefly_synth_fx_1.vst3"
+                           (string-append vst3 "/firefly_synth_fx_1.vst3")))))))))
+     (inputs (list libxrandr
+                   libxinerama
+                   libxcursor
+                   freetype
+                   mesa
+                   alsa-lib))
+     (native-inputs (list pkg-config))
+     (home-page "https://github.com/sjoerdvankreel/firefly-synth")
+     (synopsis "Semi-modular synthesizer and FX plugin, VST3 and CLAP")
+     (description "A semi-modular software synthesizer and fx plugin")
+     (license license:gpl3))))
+
 ;;;
 ;;; Avoid adding new packages to the end of this file. To reduce the chances
 ;;; of a merge conflict, place them above by existing packages with similar
-- 
2.45.2


------=_Part_83028_1927746075.1723804999562--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Apoorv <apoorvs@HIDDEN>
Subject: bug#72666: Acknowledgement ([PATCH] Add firefly-synth package)
Message-ID: <handler.72666.B.172380504527486.ack <at> debbugs.gnu.org>
References: <O4PmCjA--B-9@HIDDEN>
X-Gnu-PR-Message: ack 72666
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 72666 <at> debbugs.gnu.org
Date: Fri, 16 Aug 2024 10:45:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 72666 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
72666: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72666
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#72666] Add firely-synth package to Guix
References: <O4PmCjA--B-9@HIDDEN>
In-Reply-To: <O4PmCjA--B-9@HIDDEN>
Resent-From: Steve George <steve@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 31 Oct 2024 10:58:01 +0000
Resent-Message-ID: <handler.72666.B72666.173037222314689 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 72666 <at> debbugs.gnu.org
Date: Thu, 31 Oct 2024 10:54:33 +0000
From: Steve George <steve@HIDDEN>
Message-ID: <ZyNh6Y2KXm_Zrj15@dragon2>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi,

You sent a patch to add firefly-synth, a couple of things:

1. Looks like there's a new release, can you update the patch?
  https://github.com/sjoerdvankreel/firefly-synth/releases/tag/v1.9.6

2. You added it to the end of music.scm please don't put it there as it makes
diffs more difficult. See if there's an alphabetical location in the file if at all possible.

3. Please send patches 'in-line' so that the automated QA system can pick them up.
I think the manual now has an updated section on how to use git send-email which might help.

https://guix.gnu.org/manual/devel/en/html_node/Sending-a-Patch-Series.html#Single-Patches-1

Thanks,

Futurile

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.