GNU logs - #72943, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#72943] [PATCH] gnu: gd: Requires.private to propagated inputs
Resent-From: Rutherther <rutherther@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 01 Sep 2024 21:48:05 +0000
Resent-Message-ID: <handler.72943.B.172522723631662 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 72943 <at> debbugs.gnu.org
Cc: Rutherther <rutherther@HIDDEN>
Date: Sun, 01 Sep 2024 19:11:44 +0000
From: Rutherther <rutherther@HIDDEN>
Message-ID: <20240901191119.29870-1-rutherther@HIDDEN>
Feedback-ID: 8107604:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=185.70.43.22;
 envelope-from=rutherther@HIDDEN; helo=mail-4322.protonmail.ch
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Mailman-Approved-At: Sun, 01 Sep 2024 17:47:03 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

The package gd provides a pkg-config file with all
its inputs in Requires.private. I think that this means that packages that =
depend
on gd also need these as inputs to build. This is causing trouble for examp=
le in php,
failing in configure phase with
```
checking for gdlib >=3D 2.1.0... no
configure: error: Package requirements (gdlib >=3D 2.1.0) were not met:

Package 'freetype2', required by 'gdlib', not found

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.
```

After this, php is able to configure, though it still fails in the check
phase, where 3 tests fail. These tests are related to gd, so there seems
to be other problem as well, but I see also other tests for gd disabled,
so maybe it will be fine also disabling these three to fix this, I am not s=
ure.
---
 gnu/packages/gd.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/gd.scm b/gnu/packages/gd.scm
index 98d34cfa71..7ced0774bd 100644
--- a/gnu/packages/gd.scm
+++ b/gnu/packages/gd.scm
@@ -85,7 +85,7 @@ (define-public gd
                                          "\\.la$")))))))
     (native-inputs
      (list pkg-config))
-    (inputs
+    (propagated-inputs
      (list fontconfig
            freetype
            libjpeg-turbo
--=20
2.45.2

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Rutherther <rutherther@HIDDEN>
Subject: bug#72943: Acknowledgement ([PATCH] gnu: gd: Requires.private to
 propagated inputs)
Message-ID: <handler.72943.B.172522723631662.ack <at> debbugs.gnu.org>
References: <20240901191119.29870-1-rutherther@HIDDEN>
X-Gnu-PR-Message: ack 72943
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 72943 <at> debbugs.gnu.org
Date: Sun, 01 Sep 2024 21:48:05 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 72943 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
72943: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72943
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 1 Sep 2024 22:25:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Sep 01 18:25:29 2024
Received: from localhost ([127.0.0.1]:40908 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1skt0j-0001cM-Lr
	for submit <at> debbugs.gnu.org; Sun, 01 Sep 2024 18:25:29 -0400
Received: from tobias.gr ([80.241.217.52]:45966)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@HIDDEN>) id 1skt0h-0001cC-CC
 for control <at> debbugs.gnu.org; Sun, 01 Sep 2024 18:25:28 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=V8S2XS1AgjO/Q
 MhqLS/Fp7MbiciEi5z0jqIpF8bbl3o=; h=to:from:date; d=tobias.gr;
 b=mjAaHO
 kwuODwYA2Zx6CAKfsOvG0WbKZSdoH/AwHAwXRkjWUcNKRBdG3SoMhe9cCzvsHtxQYNNije
 FWHy9f18IzJS84A9PdMMzH4QD0lewvCo+cI0cqPJbD8tdbg80XhHzeQNcgbR55eyJ2gQa4
 ZlGNJPfImm8QbpypTFJUb/8menyn5X8TZZTHjz0DI+bpBo3iu4+NL1tsi3RWe3Z8s1pRhD
 AU6b4w1c134ZGLslcFRtOzlvwK04JyZLehxFBkX9iAksv6yNlaHws0nl/5rTZNvMUqzb3D
 +fTfOc37jRNY657QIzlgjtPZPvF4HSgkjrrIK1QYW1XeBYKkCo3lLbXw==
Received: by submission.tobias.gr (OpenSMTPD) with ESMTP id 7ef21af6
 for <control <at> debbugs.gnu.org>; Sun, 1 Sep 2024 22:24:20 +0000 (UTC)
MIME-Version: 1.0
Date: Mon, 02 Sep 2024 00:24:19 +0200
From: Tobias Geerinckx-Rice <me@HIDDEN>
To: control <at> debbugs.gnu.org
Message-ID: <5507402b9ba5f0301534a1d092c63560@HIDDEN>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  merge 72943 72940 thanks 
 Content analysis details:   (2.0 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 1.8 MISSING_SUBJECT        Missing Subject: header
 0.2 NO_SUBJECT             Extra score for no subject
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.0 (+)

merge 72943 72940
thanks

Message sent to guix-patches@HIDDEN:

Subject: [bug#72943] [PATCH] gnu: gd: Requires.private to propagated inputs
Resent-From: Carlo Zancanaro <carlo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 01 Sep 2024 23:35:02 +0000
Resent-Message-ID: <handler.72943.B72943.172523370020325 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Rutherther <rutherther@HIDDEN>
Cc: 72943 <at> debbugs.gnu.org
From: Carlo Zancanaro <carlo@HIDDEN>
In-Reply-To: <20240901191119.29870-1-rutherther@HIDDEN> (Rutherther
 via Guix-patches via's message of "Sun, 01 Sep 2024 19:11:44 +0000")
References: <20240901191119.29870-1-rutherther@HIDDEN>
Date: Mon, 02 Sep 2024 09:33:43 +1000
Message-ID: <87mskrc5k8.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--=-=-=
Content-Type: text/plain

Hi Rutherther,

I ran into the same issue with PHP, and prepared a slightly different
patch, which I have attached. Rather than propagating the inputs, I
reinstated a patch that we used to have, but which got removed in the
core-updates merge.

My assumption is that it was removed because the referenced GitHub issue
was closed, but the issue is not actually resolved upstream. They claim
it's a pkg-config bug (which has been open for 18 years), so I'm not
holding my breath for an upstream fix.

I also noticed the three failing tests, all related to libgd, but ran
out of time to investigate further.

Carlo


--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline;
 filename=0001-gnu-gd-Restore-patch-to-fix-pkg-config-finding-libgd.patch

From 80dee500e88cfb56984062b2d376b9423a7c9507 Mon Sep 17 00:00:00 2001
Message-ID: <80dee500e88cfb56984062b2d376b9423a7c9507.1725233445.git.carlo@HIDDEN>
From: Carlo Zancanaro <carlo@HIDDEN>
Date: Sun, 1 Sep 2024 22:34:17 +1000
Subject: [PATCH] gnu: gd: Restore patch to fix pkg-config finding libgd
 dependencies.

This patch is restoring a patch that was erroneously removed in
6d7f9294dd62ef428d7ce79ef299b536fab0da30.

* gnu/packages/gd.scm (gd)[source]: Include gd-Revert-fix-303-gdlib.pc.patch patch.
* gnu/packages/patches/gd-Revert-fix-303-gdlib.pc.patch: New file.
* gnu/local.mk (dist_patch_DATA): Register it.

Change-Id: I8102b414f6eacdc2c271ebd4f65855fa7d175692
---
 gnu/local.mk                                  |   1 +
 gnu/packages/gd.scm                           |   9 +-
 .../patches/gd-Revert-fix-303-gdlib.pc.patch  | 179 ++++++++++++++++++
 3 files changed, 188 insertions(+), 1 deletion(-)
 create mode 100644 gnu/packages/patches/gd-Revert-fix-303-gdlib.pc.patch

diff --git a/gnu/local.mk b/gnu/local.mk
index 0c4ab96bf3..679d87fcf4 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1356,6 +1356,7 @@ dist_patch_DATA =						\
   %D%/packages/patches/gcolor3-update-libportal-usage.patch	\
   %D%/packages/patches/gd-fix-tests-on-i686.patch		\
   %D%/packages/patches/gd-brect-bounds.patch			\
+  %D%/packages/patches/gd-Revert-fix-303-gdlib.pc.patch		\
   %D%/packages/patches/gdm-default-session.patch		\
   %D%/packages/patches/gdm-elogind-support.patch		\
   %D%/packages/patches/gdm-remove-hardcoded-xwayland-path.patch	\
diff --git a/gnu/packages/gd.scm b/gnu/packages/gd.scm
index 98d34cfa71..d1dab2880e 100644
--- a/gnu/packages/gd.scm
+++ b/gnu/packages/gd.scm
@@ -56,7 +56,14 @@ (define-public gd
                 "0qas3q9xz3wgw06dm2fj0i189rain6n60z1vyq50d5h7wbn25s1z"))
               (patches
                (search-patches "gd-fix-tests-on-i686.patch"
-                               "gd-brect-bounds.patch"))))
+                               "gd-brect-bounds.patch"
+                               ;; This is needed due to an issue where PHP
+                               ;; cannot find libgd's dependencies. See
+                               ;; https://github.com/libgd/libgd/issues/691
+                               ;; and the linked
+                               ;; https://gitlab.freedesktop.org/pkg-config/pkg-config/-/issues/28
+                               ;; for more details.
+                               "gd-Revert-fix-303-gdlib.pc.patch"))))
     (build-system gnu-build-system)
     (arguments
      ;; As recommended by github.com/libgd/libgd/issues/278 to fix rounding
diff --git a/gnu/packages/patches/gd-Revert-fix-303-gdlib.pc.patch b/gnu/packages/patches/gd-Revert-fix-303-gdlib.pc.patch
new file mode 100644
index 0000000000..6329b129d3
--- /dev/null
+++ b/gnu/packages/patches/gd-Revert-fix-303-gdlib.pc.patch
@@ -0,0 +1,179 @@
+From 9b31dfda73ee2d1b56b3f0dcfd3246c2faa592fe Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?L=C3=A9o=20Le=20Bouter?= <lle-bout@HIDDEN>
+Date: Sun, 28 Mar 2021 19:47:25 +0200
+Subject: [PATCH] Revert "fix #303: gdlib.pc: use Requires instead of Libs
+ (#537)"
+
+This reverts commit 28ecfe77c817aff8ce56422d3e4e8533a281bc76.
+---
+ CMakeLists.txt        | 12 ------------
+ config/gdlib.pc.cmake |  4 +---
+ config/gdlib.pc.in    |  4 +---
+ configure.ac          | 11 +----------
+ src/CMakeLists.txt    |  6 ------
+ 5 files changed, 3 insertions(+), 34 deletions(-)
+
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 57cd95d..6bd0c73 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -53,8 +53,6 @@ SET (CMAKE_ARCHIVE_OUTPUT_DIRECTORY
+   "Single Directory for all static libraries."
+   )
+ 
+-SET(PKG_REQUIRES_PRIVATES "")
+-
+ if (USE_EXT_GD)
+ 	message("Using GD at: ${USE_EXT_GD}")
+ 	INCLUDE_DIRECTORIES(BEFORE ${GD_INCLUDE_DIR})
+@@ -170,13 +168,11 @@ else (USE_EXT_GD)
+ 		INCLUDE_DIRECTORIES(${FREETYPE_INCLUDE_DIRS})
+ 		SET(HAVE_FT2BUILD_H 1)
+ 		SET(HAVE_LIBFREETYPE 1)
+-		LIST(APPEND PKG_REQUIRES_PRIVATES freetype2)
+ 	ENDIF(FREETYPE_FOUND)
+ 
+ 	IF(ZLIB_FOUND)
+ 		INCLUDE_DIRECTORIES(${ZLIB_INCLUDE_DIR})
+ 		SET(HAVE_LIBZ 1)
+-		LIST(APPEND PKG_REQUIRES_PRIVATES zlib)
+ 	ENDIF(ZLIB_FOUND)
+ 
+ 	IF(WEBP_FOUND)
+@@ -192,7 +188,6 @@ else (USE_EXT_GD)
+ 	IF(PNG_FOUND)
+ 		INCLUDE_DIRECTORIES(${PNG_INCLUDE_DIR})
+ 		SET(HAVE_LIBPNG 1)
+-		LIST(APPEND PKG_REQUIRES_PRIVATES libpng)
+ 	ENDIF(PNG_FOUND)
+ 
+ 	IF(ICONV_FOUND)
+@@ -209,25 +204,21 @@ else (USE_EXT_GD)
+ 	IF(XPM_FOUND)
+ 		INCLUDE_DIRECTORIES(${XPM_INCLUDE_DIR})
+ 		SET(HAVE_LIBXPM 1)
+-		LIST(APPEND PKG_REQUIRES_PRIVATES xpm)
+ 	ENDIF(XPM_FOUND)
+ 
+ 	IF(JPEG_FOUND)
+ 		INCLUDE_DIRECTORIES(${JPEG_INCLUDE_DIR})
+ 		SET(HAVE_LIBJPEG 1)
+-		LIST(APPEND PKG_REQUIRES_PRIVATES libjpeg)
+ 	ENDIF(JPEG_FOUND)
+ 
+ 	IF(TIFF_FOUND)
+ 		INCLUDE_DIRECTORIES(${TIFF_INCLUDE_DIR})
+ 		SET(HAVE_LIBTIFF 1)
+-		LIST(APPEND PKG_REQUIRES_PRIVATES libtiff-4)
+ 	ENDIF(TIFF_FOUND)
+ 
+ 	IF(FONTCONFIG_FOUND)
+ 		INCLUDE_DIRECTORIES(${FONTCONFIG_INCLUDE_DIR})
+ 		SET(HAVE_LIBFONTCONFIG 1)
+-		LIST(APPEND PKG_REQUIRES_PRIVATES fontconfig)
+ 	ELSE (FONTCONFIG_FOUND)
+ 		SET(FONTCONFIG_LIBRARY "")
+ 		SET(FONTCONFIG_INCLUDE_DIR "")
+@@ -236,11 +227,8 @@ else (USE_EXT_GD)
+ 
+ 	IF(RAQM_FOUND)
+ 		INCLUDE_DIRECTORIES(${RAQM_INCLUDE_DIR})
+-		SET(HAVE_RAQM 1)
+-		LIST(APPEND PKG_REQUIRES_PRIVAES raqm)
+ 	ENDIF(RAQM_FOUND)
+ 
+-	string(REPLACE ";" ", " PKG_REQUIRES_PRIVATES "${PKG_REQUIRES_PRIVATES}")
+ 	SET(HAVE_CONFIG_H 1)
+ 
+ 	ADD_DEFINITIONS(-DHAVE_CONFIG_H)
+diff --git a/config/gdlib.pc.cmake b/config/gdlib.pc.cmake
+index 5fc8af4..d1a0dda 100644
+--- a/config/gdlib.pc.cmake
++++ b/config/gdlib.pc.cmake
+@@ -6,8 +6,6 @@ includedir=${prefix}/@CMAKE_INSTALL_INCLUDEDIR@
+ Name: gd
+ Description: GD graphics library
+ Version: @GDLIB_VERSION@
+-Requires:
+-Requires.private: @PKG_REQUIRES_PRIVATES@
+ Cflags: -I${includedir}
+-Libs.private: @LIBS_PRIVATES@
++Libs.private: @LIBGD_DEP_LIBS@
+ Libs: -L${libdir} -lgd
+diff --git a/config/gdlib.pc.in b/config/gdlib.pc.in
+index d6bc375..b980a60 100644
+--- a/config/gdlib.pc.in
++++ b/config/gdlib.pc.in
+@@ -6,8 +6,6 @@ includedir=@includedir@
+ Name: gd
+ Description: GD graphics library
+ Version: @VERSION@
+-Requires:
+-Requires.private: @PKG_REQUIRES_PRIVATES@
+ Cflags: -I${includedir}
+-Libs.private: @LIBS_PRIVATES@ @LIBICONV@
++Libs.private: @LIBS@ @LIBICONV@
+ Libs: -L${libdir} -lgd
+diff --git a/configure.ac b/configure.ac
+index 535db68..329c99c 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -33,9 +33,6 @@ AC_SUBST(GDLIB_LT_CURRENT)
+ AC_SUBST(GDLIB_LT_REVISION)
+ AC_SUBST(GDLIB_LT_AGE)
+ 
+-AC_SUBST(LIBS_PRIVATES)
+-AC_SUBST(PKG_REQUIRES_PRIVATES)
+-
+ AM_INIT_AUTOMAKE([1.11 foreign dist-xz -Wall -Werror subdir-objects])
+ AC_CONFIG_HEADERS([src/config.h:src/config.hin])
+ 
+@@ -133,7 +130,6 @@ m4_define([GD_LIB_CHECK], [dnl
+   AC_MSG_RESULT([$gd_with_lib])
+ 
+   gd_found_lib=no
+-  gd_require_pkg_name=""
+   if test "$gd_with_lib" != "no"; then
+     save_CPPFLAGS=$CPPFLAGS
+     save_LDFLAGS=$LDFLAGS
+@@ -165,11 +161,6 @@ m4_define([GD_LIB_CHECK], [dnl
+       $1][_CFLAGS="$gd_lib_cflags $][$1][_CFLAGS"
+       AS_VAR_APPEND([LIBS], [" $][$1][_LIBS"])
+       AS_VAR_APPEND([CPPFLAGS], [" $][$1][_CFLAGS"])
+-      if test -z "$gd_require_pkg_name"; then
+-        AS_VAR_APPEND([LIBS_PRIVATES], [" $][$1][_LIBS"])
+-      else
+-        AS_VAR_APPEND([PKG_REQUIRES_PRIVATES], ["  $gd_require_pkg_name"])
+-      fi
+     elif test "$gd_with_lib" = "yes"; then
+       AC_MSG_ERROR([$3 requested but not found])
+     else
+@@ -189,7 +180,7 @@ dnl $4 - pkg-config module to look for
+ dnl $5 - fallback test for the feature
+ m4_define([GD_LIB_PKG_CHECK], [dnl
+   GD_LIB_CHECK([$1], [$2], [$3], [dnl
+-    PKG_CHECK_MODULES([$1], [$4], [gd_found_lib=yes gd_require_pkg_name="$4"], [$5])
++    PKG_CHECK_MODULES([$1], [$4], [gd_found_lib=yes], [$5])
+   ])
+ ])
+ 
+diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
+index 509c422..49adbd6 100644
+--- a/src/CMakeLists.txt
++++ b/src/CMakeLists.txt
+@@ -142,12 +142,6 @@ if (BUILD_STATIC_LIBS)
+ 	target_link_libraries(${GD_LIB_STATIC} ${LIBGD_DEP_LIBS})
+ endif()
+ 
+-SET(LIBS_PRIVATES
+-	${ICONV_LIBRARIES}
+-	${LIQ_LIBRARIES}
+-	${WEBP_LIBRARIES}
+-)
+-
+ set(GD_PROGRAMS gdcmpgif)
+ 
+ if (PNG_FOUND)
+-- 
+2.31.1
+

base-commit: e1c92c98f7afff13fb7060199ba0dd4d9c5c2c53
-- 
2.45.2


--=-=-=--

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 2 Sep 2024 11:54:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 02 07:54:46 2024
Received: from localhost ([127.0.0.1]:46817 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sl5dt-0008A6-IR
	for submit <at> debbugs.gnu.org; Mon, 02 Sep 2024 07:54:45 -0400
Received: from tobias.gr ([80.241.217.52]:45330)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@HIDDEN>) id 1sl5dq-00089n-Vc
 for control <at> debbugs.gnu.org; Mon, 02 Sep 2024 07:54:44 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=+9NE7EOSALKFu
 tdyQecJdIgMbIeRruX7KlCihNm0A4A=; h=to:from:date; d=tobias.gr;
 b=FGe2+u
 ckclgHuoTBK6nETLszy+I54hfNkbhMbMryIe2w8qpPAr+4FvPg6xYWdnVpq+Zvatzcpwgn
 kocYIok8JKaT4Qgb6AHaOCn+qeRuKlmdgLMuNDpQtcQ5/7VLnv4lBp96OKncNVE0xGFDhJ
 SQ5y3CsaP48+E+CKEglbGEoeFRIt49g6tUTxuy8SLrKjvFW61KMeUmLRvAI5hnmRjquQbn
 rmNp4vUzGodj/OVkNuMkpDP8S+fFXyttx85g/i8+7jV8YvEs9Lvu8F6W2OwFGfYWdrgfJR
 vtI2MerWvgJD0adx5GgL92Q9FDbj+skiBk5GOEC4AefCDr7WA4cnGzlA==
Received: by submission.tobias.gr (OpenSMTPD) with ESMTP id 52691115
 for <control <at> debbugs.gnu.org>; Mon, 2 Sep 2024 11:53:37 +0000 (UTC)
MIME-Version: 1.0
Date: Mon, 02 Sep 2024 13:53:37 +0200
From: Tobias Geerinckx-Rice <me@HIDDEN>
To: control <at> debbugs.gnu.org
Message-ID: <6921935c0d74dd5c7b96395f373f0085@HIDDEN>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  reassign 72962 guix-patches merge 72943 72962 thanks not 
 Content analysis details:   (2.0 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 1.8 MISSING_SUBJECT        Missing Subject: header
 0.2 NO_SUBJECT             Extra score for no subject
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.0 (+)

reassign 72962 guix-patches
merge 72943 72962
thanks
not

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#72943] [PATCH] gnu: gd: Requires.private to propagated inputs
References: <20240901191119.29870-1-rutherther@HIDDEN>
In-Reply-To: <20240901191119.29870-1-rutherther@HIDDEN>
Resent-From: Rutherther <rutherther@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 02 Sep 2024 21:56:02 +0000
Resent-Message-ID: <handler.72943.B72943.172531413730101 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72943
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 72943 <at> debbugs.gnu.org
Cc: Rutherther <rutherther@HIDDEN>, Carlo Zancanaro <carlo@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>
Received: via spool by 72943-submit <at> debbugs.gnu.org id=B72943.172531413730101
          (code B ref 72943); Mon, 02 Sep 2024 21:56:02 +0000
Received: (at 72943) by debbugs.gnu.org; 2 Sep 2024 21:55:37 +0000
Received: from localhost ([127.0.0.1]:52808 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1slF1M-0007pJ-Tw
	for submit <at> debbugs.gnu.org; Mon, 02 Sep 2024 17:55:37 -0400
Received: from mail-4322.protonmail.ch ([185.70.43.22]:48409)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rutherther@HIDDEN>) id 1slAn7-0006Mg-Io
 for 72943 <at> debbugs.gnu.org; Mon, 02 Sep 2024 13:24:38 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
 s=protonmail3; t=1725297809; x=1725557009;
 bh=FNjtBXTrWTaK/GSBkZgPOVQZf+r7v4vAelw64edbQfY=;
 h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:
 Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector;
 b=TjabWuNZGGo4aVpfAe15mjH4uU/yGJGiM5f9kgnDVzEVr2Wgv7GErJlw5x8FUudf1
 /x1Cg0zBCTfcd9jXJrbrl51DIHEIizVZdqaxr0AfB2uXUSdzgNK/+FCb/DL6lRWqlH
 Mvs/ONVlHaaucITuY9Blq+rt19lCsFxlZfaqreI+6brOeST6F207vo3OaxNoVIMq4g
 lILY1bi8Od9T3XX7oYYWGdyN6+dryqH0MwEodXeDN9Fp/A2wzsfVe4lePG51vTDC7i
 xAgizlgjBh9BINncV6ZhepR+OIut8pbXAQCS2tyYa4MQnlgIosna7YUGwtJ/LULglW
 aIEYWSblN36CQ==
Date: Mon, 02 Sep 2024 17:23:22 +0000
From: Rutherther <rutherther@HIDDEN>
Message-ID: <87v7zeezr1.fsf@HIDDEN>
Feedback-ID: 8107604:user:proton
X-Pm-Message-ID: 74f8fef67c21f962942449c2f96dc241a2292eca
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Mailman-Approved-At: Mon, 02 Sep 2024 17:55:32 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


Hello Carlo,

thank you for finding that!
That explains why this issue was caused in the first place,
I was wondering how this could've been unspotted till now.

It seems much better to me to not use propagated-inputs whenever possible,
so I prefer your solution to this one. However, I do wonder about this: oth=
er packages that
have Requires.private do provide the libraries in these as propagated-input=
s. Also
the cookbook shows to do this with such libraries. What is the correct appr=
oach here
then? Maybe every package that has Requires.private could be patched like t=
his, possibly
somehow automatically instead of manual patches?

I am quite new here, this is my first patch. So I am not really sure how to=
 go about this.
Will you open a new issue with your patch, and maintainers will decide patc=
h from which
issue to use? Or is it enough it's in this issue?

I am sending an updated patch with a comment for why specifying
propagates-inputs would be necessary in the meantime,
as Tobias suggested me in a review in #guix IRC channel.

---
 gnu/packages/gd.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gd.scm b/gnu/packages/gd.scm
index 98d34cfa71..1380493c44 100644
--- a/gnu/packages/gd.scm
+++ b/gnu/packages/gd.scm
@@ -85,7 +85,8 @@ (define-public gd
                                          "\\.la$")))))))
     (native-inputs
      (list pkg-config))
-    (inputs
+    ;; These libraries are in 'Requires.private' in libgd.pc.
+    (propagated-inputs
      (list fontconfig
            freetype
            libjpeg-turbo
--=20
2.45.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#72943] [PATCH] gnu: gd: Requires.private to propagated inputs
Resent-From: Carlo Zancanaro <carlo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 Sep 2024 00:21:01 +0000
Resent-Message-ID: <handler.72943.B72943.172532284215844 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72943
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Rutherther <rutherther@HIDDEN>
Cc: Tobias Geerinckx-Rice <me@HIDDEN>, 72943 <at> debbugs.gnu.org
Received: via spool by 72943-submit <at> debbugs.gnu.org id=B72943.172532284215844
          (code B ref 72943); Tue, 03 Sep 2024 00:21:01 +0000
Received: (at 72943) by debbugs.gnu.org; 3 Sep 2024 00:20:42 +0000
Received: from localhost ([127.0.0.1]:53203 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1slHHm-00047U-GF
	for submit <at> debbugs.gnu.org; Mon, 02 Sep 2024 20:20:42 -0400
Received: from voltorb.zancanaro.id.au ([45.77.50.64]:46750)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <carlo@HIDDEN>) id 1slHHj-00047B-4S
 for 72943 <at> debbugs.gnu.org; Mon, 02 Sep 2024 20:20:40 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=k1; bh=8HpbT93fJHjcpnB
 C+1qc0nWljns2tw/LCMpNTGnhYFY=;
 h=date:references:in-reply-to:subject:
 cc:to:from; d=zancanaro.id.au; b=WqUJUCiWqzAHmKaSV+cRAp44BShqJDANrEsm0
 RYWr5J2uLAMQ+IvJTrsOQSteUTCoIfZFbOAg3LKH/jBa2sOUsuE7Ga+FZbu8bQU0SGbd3F
 gCVT0pKI/wTTRtPnS7wnqW95LJxzDqkC2wGWJXs5D8a5hsFLLA7QS8NcbGgBHopk=
Received: by voltorb.zancanaro.id.au (OpenSMTPD) with ESMTPSA id 1c5b000e
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Tue, 3 Sep 2024 00:19:23 +0000 (UTC)
From: Carlo Zancanaro <carlo@HIDDEN>
In-Reply-To: <87v7zeezr1.fsf@HIDDEN> (Rutherther via Guix-patches
 via's message of "Mon, 02 Sep 2024 17:23:22 +0000")
References: <20240901191119.29870-1-rutherther@HIDDEN>
 <87v7zeezr1.fsf@HIDDEN>
Date: Tue, 03 Sep 2024 10:19:26 +1000
Message-ID: <87bk15eghd.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Mon, Sep 02 2024, Rutherther via Guix-patches via wrote:
> It seems much better to me to not use propagated-inputs whenever possible,
> so I prefer your solution to this one. However, I do wonder about this: other packages that
> have Requires.private do provide the libraries in these as propagated-inputs. Also
> the cookbook shows to do this with such libraries. What is the correct approach here
> then? Maybe every package that has Requires.private could be patched like this, possibly
> somehow automatically instead of manual patches?

Ah, I didn't look into it, so I didn't know that other packages in the
same situation just propagate their inputs. If that's more consistent
with the rest of Guix's packages then it would probably be better to do
that than restoring the patch.

> I am quite new here, this is my first patch. So I am not really sure how to go about this.
> Will you open a new issue with your patch, and maintainers will decide patch from which
> issue to use? Or is it enough it's in this issue?

I wasn't planning to open a new issue. Ideally I think we would agree on
which change is more appropriate, then someone with commit access would
apply it.

If this problem is solved elsewhere in Guix with propagated-inputs, then
I think your change is a better idea than mine.

This still leaves the issue of the failing tests, though. I investigated
a bit and looking at [1] and [2], I believe the issue is that our
version of libgd doesn't support the BICUBIC interpolation method.

I'm rebuilding PHP now with those tests removed. I'll send through some
patches soon.

Carlo

[1]: https://github.com/php/php-src/issues/11252
[2]: https://github.com/libgd/libgd/issues/847

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#72943] [PATCH 1/2] gnu: gd: Requires.private to propagated inputs
Resent-From: Carlo Zancanaro <carlo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 Sep 2024 01:57:02 +0000
Resent-Message-ID: <handler.72943.B72943.172532858829203 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72943
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 72943 <at> debbugs.gnu.org
Cc: Rutherther <rutherther@HIDDEN>
Received: via spool by 72943-submit <at> debbugs.gnu.org id=B72943.172532858829203
          (code B ref 72943); Tue, 03 Sep 2024 01:57:02 +0000
Received: (at 72943) by debbugs.gnu.org; 3 Sep 2024 01:56:28 +0000
Received: from localhost ([127.0.0.1]:55619 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1slImS-0007ax-7H
	for submit <at> debbugs.gnu.org; Mon, 02 Sep 2024 21:56:28 -0400
Received: from voltorb.zancanaro.id.au ([45.77.50.64]:54926)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <carlo@HIDDEN>) id 1slImP-0007aR-9Z
 for 72943 <at> debbugs.gnu.org; Mon, 02 Sep 2024 21:56:26 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=k1; bh=y+kPON0AzrywmtE
 J165XZbaaAMvuncLjJ6mVDKhaCVM=;
 h=references:in-reply-to:date:subject:
 cc:to:from; d=zancanaro.id.au; b=Tea3nlumRtC96qwp7zBB4K3ymQcQjsaG8IjR7
 G83obIiPsTzETFRQNXGFc13Jta8RLrpauZmKS9Irmci7AtHRYSQsVPyGdToM83lmAxVxnt
 TncjJfYejVc9xFHC74/K9vhHBq1wP0q/htNCMY7viupyM3eE60TLFpsjN5dBvcdY=
Received: by voltorb.zancanaro.id.au (OpenSMTPD) with ESMTPSA id 4767eb3d
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Tue, 3 Sep 2024 01:55:09 +0000 (UTC)
From: Carlo Zancanaro <carlo@HIDDEN>
Date: Tue,  3 Sep 2024 11:54:53 +1000
Message-ID: <e8531dfdc396ded5d5a93bf2687b79f731cb953a.1725328494.git.carlo@HIDDEN>
X-Mailer: git-send-email 2.45.2
In-Reply-To: <87bk15eghd.fsf@HIDDEN>
References: <87bk15eghd.fsf@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

From: Rutherther <rutherther@HIDDEN>

* gnu/packages/gd.scm (gd): Change inputs to propagated-inputs.

Change-Id: Icb821d36a8250e7eee7d174dae8387949ac219a1
---
 gnu/packages/gd.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gd.scm b/gnu/packages/gd.scm
index 98d34cfa71..1380493c44 100644
--- a/gnu/packages/gd.scm
+++ b/gnu/packages/gd.scm
@@ -85,7 +85,8 @@ (define-public gd
                                          "\\.la$")))))))
     (native-inputs
      (list pkg-config))
-    (inputs
+    ;; These libraries are in 'Requires.private' in libgd.pc.
+    (propagated-inputs
      (list fontconfig
            freetype
            libjpeg-turbo

base-commit: b833aaaee7c95ec0339428a6b602f26831494798
-- 
2.45.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#72943] [PATCH 2/2] gnu: php: Disable tests relating to BICUBIC interpolation.
Resent-From: Carlo Zancanaro <carlo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 03 Sep 2024 01:57:02 +0000
Resent-Message-ID: <handler.72943.B72943.172532859529233 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72943
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 72943 <at> debbugs.gnu.org
Cc: Rutherther <rutherther@HIDDEN>
Received: via spool by 72943-submit <at> debbugs.gnu.org id=B72943.172532859529233
          (code B ref 72943); Tue, 03 Sep 2024 01:57:02 +0000
Received: (at 72943) by debbugs.gnu.org; 3 Sep 2024 01:56:35 +0000
Received: from localhost ([127.0.0.1]:55625 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1slImU-0007bF-HQ
	for submit <at> debbugs.gnu.org; Mon, 02 Sep 2024 21:56:34 -0400
Received: from voltorb.zancanaro.id.au ([45.77.50.64]:54926)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <carlo@HIDDEN>) id 1slImR-0007aR-IL
 for 72943 <at> debbugs.gnu.org; Mon, 02 Sep 2024 21:56:28 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=k1; bh=Mdt/TEPdpEgwi2+
 mkDyj2qQ59iynEd5B/CYFL4rxEVU=;
 h=references:in-reply-to:date:subject:
 cc:to:from; d=zancanaro.id.au; b=N7CvUi8OVC/vAkvB7tPHNkq/uewMjkcUD7G0m
 tjChZhsg2NjRc/NidVKzNt/7zDd1w/Ji8UofZL6v7ZZEY5dJAP/B1IqjX8BdbXvYlENu+v
 wa1TbelBgMms06uIMWVY8RHqOQui0m5aW50Z6/hN2qmSGIXDuX+x79sIMWJ/fg6o=
Received: by voltorb.zancanaro.id.au (OpenSMTPD) with ESMTPSA id 1ac640ec
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Tue, 3 Sep 2024 01:55:09 +0000 (UTC)
From: Carlo Zancanaro <carlo@HIDDEN>
Date: Tue,  3 Sep 2024 11:54:54 +1000
Message-ID: <ac7837e79805d82097b172389a614146cd47108b.1725328494.git.carlo@HIDDEN>
X-Mailer: git-send-email 2.45.2
In-Reply-To: <87bk15eghd.fsf@HIDDEN>
References: <87bk15eghd.fsf@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* gnu/packages/php.scm (php)[arguments]: Delete three tests that are known to
fail.

Change-Id: Ib684328654c75f37111d252fb0f9fb3356daff9a
---
 gnu/packages/php.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/packages/php.scm b/gnu/packages/php.scm
index 8f879dbdca..ce7458d0e5 100644
--- a/gnu/packages/php.scm
+++ b/gnu/packages/php.scm
@@ -253,6 +253,13 @@ (define-public php
                          ;; AVIF support disabled
                          "ext/gd/tests/imagecreatefromstring_avif.phpt"
 
+                         ;; These tests fail due to issues in upstream gd
+                         ;; 2.3.3 around BICUBIC interpolation.  See
+                         ;; https://github.com/libgd/libgd/issues/847
+                         "ext/gd/tests/bug79676.phpt"
+                         "ext/gd/tests/imageinterpolation_basic.phpt"
+                         "ext/gd/tests/imagescale_preserve_ratio.phpt"
+
                          ;; XXX: These test failures appear legitimate, needs investigation.
                          ;; open_basedir() restriction failure.
                          "ext/curl/tests/curl_setopt_ssl.phpt"
-- 
2.45.2

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#72943] bug#72962: php-8.3.10 build failure
Resent-From: Marek =?UTF-8?Q?Pa=C5=9Bnikowski?= <marek@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 04 Sep 2024 07:25:03 +0000
Resent-Message-ID: <handler.72943.B72943.172543467830810 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72943
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Carlo Zancanaro <carlo@HIDDEN>
Cc: Rutherther <rutherther@HIDDEN>, 72962 <at> debbugs.gnu.org, 72943 <at> debbugs.gnu.org
Received: via spool by 72943-submit <at> debbugs.gnu.org id=B72943.172543467830810
          (code B ref 72943); Wed, 04 Sep 2024 07:25:03 +0000
Received: (at 72943) by debbugs.gnu.org; 4 Sep 2024 07:24:38 +0000
Received: from localhost ([127.0.0.1]:33231 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1slkNZ-00080l-HS
	for submit <at> debbugs.gnu.org; Wed, 04 Sep 2024 03:24:38 -0400
Received: from [81.190.248.246] (port=57622 helo=marekpasnikowski.pl)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <marek@HIDDEN>)
 id 1sljrp-00078K-3e; Wed, 04 Sep 2024 02:51:52 -0400
Received: from localhost (localhost.local [127.0.0.1])
 by localhost (OpenSMTPD) with ESMTP id fd799f9a;
 Wed, 4 Sep 2024 06:50:40 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=marekpasnikowski.pl; h=
 from:to:cc:subject:in-reply-to:references:date:message-id
 :mime-version:content-type:content-transfer-encoding; s=dkim;
 bh=fUD3SV4MhgmAu7ahsEwsj2Jp7K8+zSbv0lrUHmnt/KE=; b=gYVm35KaRfTo
 ioGMqSTM0Nr67siXiXCA1oaYvI6c3x7JE1SAtbXacZv2rEmIZOTW9pgnxUh3J6Iz
 ClCAu/5BqjrtC2TF8ZTbjZjCr0QCf9CG1AN4eh6zbRtPkBELc7WXc0IAMHA96jpi
 kMEQ5a7+H0GuVClJyNnjLXjK/9dh1TAZYTrDaFO6vj1Wg1MDo8nhzRg1VCypUHIO
 PkKw1vX/uBwXeZ+Kuapg1wxEMC5VXqucGJshEz6LZl7E3dRPjiXkBSDWXtckNf/A
 nQwXyLOLB0KUoAM/rQ81PDe3hFQrAsoCaM4o+j51J2tFE1gEKgQYjCJ+I9Lywjns
 yhVz0Wt6cA==
Received: by localhost (OpenSMTPD) with ESMTPSA id f3bd40a4
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Wed, 4 Sep 2024 06:50:40 +0000 (UTC)
From: Marek =?UTF-8?Q?Pa=C5=9Bnikowski?= <marek@HIDDEN>
In-Reply-To: <ac7837e79805d82097b172389a614146cd47108b.1725328494.git.carlo@HIDDEN>
 (Carlo Zancanaro's message of "Tue, 3 Sep 2024 11:54:54 +1000")
References: <87bk15eghd.fsf@HIDDEN>
 <ac7837e79805d82097b172389a614146cd47108b.1725328494.git.carlo@HIDDEN>
Date: Wed, 04 Sep 2024 08:50:39 +0200
Message-ID: <87cyljzzcw.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 3.0 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  Carlo Zancanaro <carlo@HIDDEN> writes: > * gnu/packages/php.scm
    (php)[arguments]: Delete three tests that are known to > fail. > This is
   my first time composing a patch review =?UTF-8?Q?=E2=80=94?= I am not sure if I am doing it
   correctly. 
 
 Content analysis details:   (3.0 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
  1.7 URIBL_BLACK            Contains an URL listed in the URIBL blacklist
                             [URIs: marekpasnikowski.pl]
  1.3 RDNS_NONE              Delivered to internal network by a host with no rDNS
X-Mailman-Approved-At: Wed, 04 Sep 2024 03:24:36 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  Carlo Zancanaro <carlo@HIDDEN> writes: > * gnu/packages/php.scm
    (php)[arguments]: Delete three tests that are known to > fail. > This is
   my first time composing a patch review =?UTF-8?Q?=E2=80=94?= I am not sure if I am doing it
   correctly. 
 
 Content analysis details:   (2.0 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
  1.7 URIBL_BLACK            Contains an URL listed in the URIBL blacklist
                             [URIs: marekpasnikowski.pl]
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
  1.3 RDNS_NONE              Delivered to internal network by a host with no rDNS
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager

Carlo Zancanaro <carlo@HIDDEN> writes:

> * gnu/packages/php.scm (php)[arguments]: Delete three tests that are know=
n to
> fail.
>

This is my first time composing a patch review =E2=80=94 I am not sure if I=
 am
doing it correctly.

I attempted to build php with the following command:
=3D
guix build php --with-patch=3Dgd=3Dpatch-1.txt --with-patch=3Dphp=3Dpatch-2=
.txt
=3D

The text files are files saved by using the =E2=80=9Cdownload=E2=80=9D opti=
on of the web
interface of Guix Issues.  My understanding is that the patch to gd
applies cleanly, but the patch to php does not:

=3D
source is at 'php-8.3.10'
applying '/gnu/store/f2zxspb49cbcmcla3mbjrikl48kmbf52-patch-2.txt'...
can't find file to patch at input line 13
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|* gnu/packages/php.scm (php)[arguments]: Delete three tests that are known=
 to
|fail.
|
|Change-Id: Ib684328654c75f37111d252fb0f9fb3356daff9a
|---
| gnu/packages/php.scm | 7 +++++++
| 1 file changed, 7 insertions(+)
|
|diff --git a/gnu/packages/php.scm b/gnu/packages/php.scm
|index 8f879dbdca..ce7458d0e5 100644
|--- a/gnu/packages/php.scm
|+++ b/gnu/packages/php.scm
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
patch unexpectedly ends in middle of line
=3D

Is this helpful?

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#72943] bug#72962: php-8.3.10 build failure
Resent-From: Carlo Zancanaro <carlo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 04 Sep 2024 07:29:01 +0000
Resent-Message-ID: <handler.72943.B72943.172543491431317 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72943
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Marek =?UTF-8?Q?Pa=C5=9Bnikowski?= <marek@HIDDEN>
Cc: Rutherther <rutherther@HIDDEN>, 72943 <at> debbugs.gnu.org
Received: via spool by 72943-submit <at> debbugs.gnu.org id=B72943.172543491431317
          (code B ref 72943); Wed, 04 Sep 2024 07:29:01 +0000
Received: (at 72943) by debbugs.gnu.org; 4 Sep 2024 07:28:34 +0000
Received: from localhost ([127.0.0.1]:33254 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1slkRO-000893-FW
	for submit <at> debbugs.gnu.org; Wed, 04 Sep 2024 03:28:34 -0400
Received: from voltorb.zancanaro.id.au ([45.77.50.64]:33660)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <carlo@HIDDEN>) id 1slkRL-00088l-6t
 for 72943 <at> debbugs.gnu.org; Wed, 04 Sep 2024 03:28:32 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=k1; bh=e+mxNXQVHG/TmJs
 CgwKorrew63qxgaRlZlpo1gs2Gvc=;
 h=date:references:in-reply-to:subject:
 cc:to:from; d=zancanaro.id.au; b=mDv2ofZWVYUyyS7xcS5lXqzmdrTKndiBK15E6
 wwsYo6R0fCIiouuc+ASHO+jKTLefrBULGwzchpfjRsxQwsxj9SEb+LuoAyQ061MBRpyFIv
 TiPNUJZI/1tHfdveZG/nG9LylaeVbH7tUk21g0a5u/121utcJifEd2Lx7XU0PC1k=
Received: by voltorb.zancanaro.id.au (OpenSMTPD) with ESMTPSA id b93eae48
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Wed, 4 Sep 2024 07:27:14 +0000 (UTC)
From: Carlo Zancanaro <carlo@HIDDEN>
In-Reply-To: <87cyljzzcw.fsf_-_@HIDDEN> ("Marek =?UTF-8?Q?Pa=C5=9Bnikowski?="'s
 message of "Wed, 04 Sep 2024 08:50:39 +0200")
References: <87bk15eghd.fsf@HIDDEN>
 <ac7837e79805d82097b172389a614146cd47108b.1725328494.git.carlo@HIDDEN>
 <87cyljzzcw.fsf_-_@HIDDEN>
Date: Wed, 04 Sep 2024 17:27:19 +1000
Message-ID: <87mskn3mlk.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Marek!

On Wed, Sep 04 2024, Marek Pa=C5=9Bnikowski wrote:
> This is my first time composing a patch review =E2=80=94 I am not sure if=
 I am
> doing it correctly.

Thanks for taking a look at my patch!

> I attempted to build php with the following command:
> =3D
> guix build php --with-patch=3Dgd=3Dpatch-1.txt --with-patch=3Dphp=3Dpatch=
-2.txt
> =3D

I don't expect this command to work. The --with-patch argument expects
to apply the patch to the source of the package, whereas the patches I
have prepared should be applied on a checkout of the Guix git repository
(which you can clone from https://git.savannah.gnu.org/git/guix.git).

You should be able to apply them in a fresh clone of the repository with
"git am $patch-name". To build, you can follow the instructions in the
manual "(guix) Building from Git". After that, you can build PHP with
these patches with "./pre-inst-env guix build php".

This can take a bit of time, but things are easier once you're set up
with a working Guix clone.

Carlo

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#72943] bug#72962: php-8.3.10 build failure
Resent-From: Marek =?UTF-8?Q?Pa=C5=9Bnikowski?= <marek@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 04 Sep 2024 12:33:02 +0000
Resent-Message-ID: <handler.72943.B72943.172545316931731 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72943
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Carlo Zancanaro <carlo@HIDDEN>
Cc: Rutherther <rutherther@HIDDEN>, 72962 <at> debbugs.gnu.org, 72943 <at> debbugs.gnu.org
Received: via spool by 72943-submit <at> debbugs.gnu.org id=B72943.172545316931731
          (code B ref 72943); Wed, 04 Sep 2024 12:33:02 +0000
Received: (at 72943) by debbugs.gnu.org; 4 Sep 2024 12:32:49 +0000
Received: from localhost ([127.0.0.1]:33792 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1slpBo-0008Fh-OL
	for submit <at> debbugs.gnu.org; Wed, 04 Sep 2024 08:32:49 -0400
Received: from [81.190.248.246] (port=46448 helo=marekpasnikowski.pl)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <marek@HIDDEN>)
 id 1slkhC-00009y-05; Wed, 04 Sep 2024 03:44:56 -0400
Received: from localhost (localhost.local [127.0.0.1])
 by localhost (OpenSMTPD) with ESMTP id be3db921;
 Wed, 4 Sep 2024 07:43:47 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=marekpasnikowski.pl; h=
 from:to:cc:subject:in-reply-to:references:date:message-id
 :mime-version:content-type; s=dkim; bh=wopm4eyf9+7/+XUVi1znLGQrt
 cCWS+egKoo/7vvdGyo=; b=DYhNKwV6Q6ctzcYpxReFxiHRbWyXtVs5e0eq36518
 2xXaUTJ+xJmwhQ/buBZFz8Lew0mnK7z4+zRclLiKnwCgpHR1R8zg0YEu0m8zv7QZ
 PAmYue/a+8wPZ/wKueOnK//IO7kTyS+fbUHT+x/OvF09l3MXsoFzOu3/ffJLxKTy
 mSh6lu5WkeB+MdYN8mJtWmdKWbm03qdepIPmF7pnNEbDAFugdo7eDccLzwBwqhgE
 xxE5KI/5FpqfzQ5mruivpNLBJ2vP6Hac47tUktO2EDZOTS8kNQcXO7DIJ1Gb99QO
 ugQ1w4oSSAbpqbY+aiOX+j7rOiGRQqiVDsfe5yMXz5B/A==
Received: by localhost (OpenSMTPD) with ESMTPSA id e1a4ae27
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Wed, 4 Sep 2024 07:43:47 +0000 (UTC)
From: Marek =?UTF-8?Q?Pa=C5=9Bnikowski?= <marek@HIDDEN>
In-Reply-To: <87mskn3mlk.fsf@HIDDEN> (Carlo Zancanaro's message of
 "Wed, 04 Sep 2024 17:27:19 +1000")
References: <87bk15eghd.fsf@HIDDEN>
 <ac7837e79805d82097b172389a614146cd47108b.1725328494.git.carlo@HIDDEN>
 <87cyljzzcw.fsf_-_@HIDDEN>
 <87mskn3mlk.fsf@HIDDEN>
Date: Wed, 04 Sep 2024 09:43:45 +0200
Message-ID: <87plpjrhhq.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 3.0 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview: Carlo Zancanaro <carlo@HIDDEN> writes: >> I
 attempted
 to build php with the following command: >> = >> guix build php
 --with-patch=gd=patch-1.txt
 --with-patch=php=patch-2.txt >> = > > You should be able to apply them in
 a fresh clone of th [...] 
 Content analysis details:   (3.0 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 1.7 URIBL_BLACK            Contains an URL listed in the URIBL blacklist
 [URIs: marekpasnikowski.pl]
 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS
X-Mailman-Approved-At: Wed, 04 Sep 2024 08:32:47 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  Carlo Zancanaro <carlo@HIDDEN> writes: >> I attempted
    to build php with the following command: >> = >> guix build php --with-patch=gd=patch-1.txt
    --with-patch=php=patch-2.txt >> = > > You should be able to apply them in
    a fresh clone of th [...] 
 
 Content analysis details:   (2.0 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
  1.7 URIBL_BLACK            Contains an URL listed in the URIBL blacklist
                             [URIs: marekpasnikowski.pl]
  1.3 RDNS_NONE              Delivered to internal network by a host with no rDNS
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager

Carlo Zancanaro <carlo@HIDDEN> writes:

>> I attempted to build php with the following command:
>> =
>> guix build php --with-patch=gd=patch-1.txt --with-patch=php=patch-2.txt
>> =
>
> You should be able to apply them in a fresh clone of the repository with
> "git am $patch-name". To build, you can follow the instructions in the
> manual "(guix) Building from Git". After that, you can build PHP with
> these patches with "./pre-inst-env guix build php".
>

I had a guix clone from previous attempts to patch things, so I
proceeded to apply the patches.  Patch 1 returned a message along the
lines (translation) of "apply: * gnu/packages/gd.scm (gd): Change inputs
to propagated-inputs".  However,
=
LC_ALL=C git am ../Downloads/patch-2.txt
Patch format detection failed.
=

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#72943] bug#72962: php-8.3.10 build failure
Resent-From: Marek =?UTF-8?Q?Pa=C5=9Bnikowski?= <marek@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 04 Sep 2024 12:33:03 +0000
Resent-Message-ID: <handler.72943.B72943.172545317031752 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72943
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Carlo Zancanaro <carlo@HIDDEN>
Cc: Rutherther <rutherther@HIDDEN>, 72962 <at> debbugs.gnu.org, 72943 <at> debbugs.gnu.org
Received: via spool by 72943-submit <at> debbugs.gnu.org id=B72943.172545317031752
          (code B ref 72943); Wed, 04 Sep 2024 12:33:03 +0000
Received: (at 72943) by debbugs.gnu.org; 4 Sep 2024 12:32:50 +0000
Received: from localhost ([127.0.0.1]:33798 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1slpBq-0008Fy-E6
	for submit <at> debbugs.gnu.org; Wed, 04 Sep 2024 08:32:50 -0400
Received: from [81.190.248.246] (port=58336 helo=marekpasnikowski.pl)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <marek@HIDDEN>)
 id 1slkwO-0000cL-HO; Wed, 04 Sep 2024 04:00:37 -0400
Received: from localhost (localhost.local [127.0.0.1])
 by localhost (OpenSMTPD) with ESMTP id f1ab62bd;
 Wed, 4 Sep 2024 07:59:30 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=marekpasnikowski.pl; h=
 from:to:cc:subject:in-reply-to:references:date:message-id
 :mime-version:content-type; s=dkim; bh=m2YDhuiPP1XiJtYkRvRDW7WnL
 MU5CltPlKgRLmTiprw=; b=GxpwZsocexFWGrlsi3FHIemejvVVhwTQ6bxjLe7Y8
 kjApJB7JCevXPgXn6rpA9bmszNGNMKe9HDHmUpEWNSXwTT6F2sn14KXkrU/qs4JB
 DqQoit+XWB6VlHj7EXKOBpkXowa7Lgi0z4unrTgVp6AN57YjiALmOAwpmnbUvhjJ
 F/bOWCJUZpJ9teHNMBsbJg78A9ZLe0ZP9X901/n/Cb7r/Y4gNCfn2eS9Yy8qm9z1
 txr437qyohMpO1CCZZluEVoHMjErh/ECWdN34Ba+ChHTLb6s6gIcpa3SpG/6Jafj
 NjuowxWz4at39InLck5Fdkx55HsgUV+pFtoY8hGx0AaMw==
Received: by localhost (OpenSMTPD) with ESMTPSA id 69eacbc3
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Wed, 4 Sep 2024 07:59:29 +0000 (UTC)
From: Marek =?UTF-8?Q?Pa=C5=9Bnikowski?= <marek@HIDDEN>
In-Reply-To: <87mskn3mlk.fsf@HIDDEN> (Carlo Zancanaro's message of
 "Wed, 04 Sep 2024 17:27:19 +1000")
References: <87bk15eghd.fsf@HIDDEN>
 <ac7837e79805d82097b172389a614146cd47108b.1725328494.git.carlo@HIDDEN>
 <87cyljzzcw.fsf_-_@HIDDEN>
 <87mskn3mlk.fsf@HIDDEN>
Date: Wed, 04 Sep 2024 09:59:28 +0200
Message-ID: <87ttevq273.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 3.0 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  Upon further inspection,
 I noticed the second patch is missing
 the From: <email> header. I copied it from the first patch and it applied.
 The build is now in progress on my slow laptop, so I am sending this report
 immediately. 
 Content analysis details:   (3.0 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 1.7 URIBL_BLACK            Contains an URL listed in the URIBL blacklist
 [URIs: marekpasnikowski.pl]
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS
X-Mailman-Approved-At: Wed, 04 Sep 2024 08:32:47 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  Upon further inspection, I noticed the second patch is missing
    the From: <email> header. I copied it from the first patch and it applied.
    The build is now in progress on my slow laptop, so I am sending this report
    immediately. 
 
 Content analysis details:   (2.0 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
  1.7 URIBL_BLACK            Contains an URL listed in the URIBL blacklist
                             [URIs: marekpasnikowski.pl]
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
  1.3 RDNS_NONE              Delivered to internal network by a host with no rDNS
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager

Upon further inspection, I noticed the second patch is missing the
From: <email> header.  I copied it from the first patch and it applied.

The build is now in progress on my slow laptop, so I am sending this
report immediately.

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#72943] bug#72962: php-8.3.10 build failure
Resent-From: Marek =?UTF-8?Q?Pa=C5=9Bnikowski?= <marek@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 04 Sep 2024 12:33:03 +0000
Resent-Message-ID: <handler.72943.B72943.172545317231767 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72943
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Carlo Zancanaro <carlo@HIDDEN>
Cc: Rutherther <rutherther@HIDDEN>, 72962 <at> debbugs.gnu.org, 72943 <at> debbugs.gnu.org
Received: via spool by 72943-submit <at> debbugs.gnu.org id=B72943.172545317231767
          (code B ref 72943); Wed, 04 Sep 2024 12:33:03 +0000
Received: (at 72943) by debbugs.gnu.org; 4 Sep 2024 12:32:52 +0000
Received: from localhost ([127.0.0.1]:33802 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1slpBr-0008GE-J3
	for submit <at> debbugs.gnu.org; Wed, 04 Sep 2024 08:32:51 -0400
Received: from [81.190.248.246] (port=45734 helo=marekpasnikowski.pl)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <marek@HIDDEN>)
 id 1slnKT-0004ri-TO; Wed, 04 Sep 2024 06:33:42 -0400
Received: from localhost (localhost.local [127.0.0.1])
 by localhost (OpenSMTPD) with ESMTP id 23233604;
 Wed, 4 Sep 2024 10:32:30 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=marekpasnikowski.pl; h=
 from:to:cc:subject:in-reply-to:references:date:message-id
 :mime-version:content-type; s=dkim; bh=GfqubpR8I4+9iFTSv+JMiwXqt
 zEq3nV6KwjbqTV+6qo=; b=YICK0Go6XL5/ZGwEobGa5QM8CuQK7DZeh+DNEYMy9
 ARQA/WQRZJYJjwaW5SPTMIXk8EvWKBGEJLokfBzqDdEEIqCZMVBH6sb81MZTmpwN
 TMSxDEp0Hfdo216V+AO3h4SO+fRv1WbazyEG6k3Kddmg2YAV+H8k0+DyUGoDuNiH
 GpxVbFNtjgJ+ie3GzGBUi43k8Oo5yPRygA7mpeu31ROl7AXPXIL/u1Pnyq+G+CXn
 KuFcZRGM5gyNHp00zXZ+7i4QY4eQTnY8hVz6uUPRRlKUvr6MzQ5KqRBYLv8WiumG
 0eKA6g3tJYm++tezOqkG7tcSrzZfQRKIuWyCHyDZo2Zlw==
Received: by localhost (OpenSMTPD) with ESMTPSA id 242c368c
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Wed, 4 Sep 2024 10:32:30 +0000 (UTC)
From: Marek =?UTF-8?Q?Pa=C5=9Bnikowski?= <marek@HIDDEN>
In-Reply-To: <87mskn3mlk.fsf@HIDDEN> (Carlo Zancanaro's message of
 "Wed, 04 Sep 2024 17:27:19 +1000")
References: <87bk15eghd.fsf@HIDDEN>
 <ac7837e79805d82097b172389a614146cd47108b.1725328494.git.carlo@HIDDEN>
 <87cyljzzcw.fsf_-_@HIDDEN>
 <87mskn3mlk.fsf@HIDDEN>
Date: Wed, 04 Sep 2024 12:32:28 +0200
Message-ID: <878qw7zp37.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 3.0 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  The build completed and passed all the tests. Is this the
 right moment to say reviewed-looks-good? Would I do it by writing the usertag
 followed by thanks in the beginning of the message? Or am I confusing
 concepts?
 Content analysis details:   (3.0 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 1.7 URIBL_BLACK            Contains an URL listed in the URIBL blacklist
 [URIs: marekpasnikowski.pl]
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS
X-Mailman-Approved-At: Wed, 04 Sep 2024 08:32:47 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  The build completed and passed all the tests. Is this the
   right moment to say reviewed-looks-good? Would I do it by writing the usertag
    followed by thanks in the beginning of the message? Or am I confusing concepts?
    
 
 Content analysis details:   (2.0 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
  1.7 URIBL_BLACK            Contains an URL listed in the URIBL blacklist
                             [URIs: marekpasnikowski.pl]
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
  1.3 RDNS_NONE              Delivered to internal network by a host with no rDNS
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager

The build completed and passed all the tests.

Is this the right moment to say reviewed-looks-good? Would I do it by
writing the usertag followed by thanks in the beginning of the message?
Or am I confusing concepts?

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#72943] Patches applied
References: <20240901191119.29870-1-rutherther@HIDDEN>
In-Reply-To: <20240901191119.29870-1-rutherther@HIDDEN>
Resent-From: Andreas Enge <andreas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 05 Sep 2024 20:44:01 +0000
Resent-Message-ID: <handler.72943.B72943.17255689931113 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 72943
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 72968-done <at> debbugs.gnu.org, 72943 <at> debbugs.gnu.org
Received: via spool by 72943-submit <at> debbugs.gnu.org id=B72943.17255689931113
          (code B ref 72943); Thu, 05 Sep 2024 20:44:01 +0000
Received: (at 72943) by debbugs.gnu.org; 5 Sep 2024 20:43:13 +0000
Received: from localhost ([127.0.0.1]:38323 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1smJJw-0000Hs-Hw
	for submit <at> debbugs.gnu.org; Thu, 05 Sep 2024 16:43:12 -0400
Received: from hera.aquilenet.fr ([185.233.100.1]:34952)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <andreas@HIDDEN>)
 id 1smJJu-0000HV-Ba; Thu, 05 Sep 2024 16:43:10 -0400
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 7CB1F125D;
 Thu,  5 Sep 2024 22:41:58 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id zDcUd8auvfuP; Thu,  5 Sep 2024 22:41:58 +0200 (CEST)
Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id C8F5DA3B;
 Thu,  5 Sep 2024 22:41:57 +0200 (CEST)
Date: Thu, 5 Sep 2024 22:41:56 +0200
From: Andreas Enge <andreas@HIDDEN>
Message-ID: <ZtoXlEjn2BP-uDLu@jurong>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello,

I have applied Carlos's second patch of
   https://issues.guix.gnu.org/72943
which gives an explanation why we skip the tests,
and No�'s patch of
   https://issues.guix.gnu.org/72968
adding the missing inputs.

As php currently does not build after the core-updates merge and this issue
has been turning up regularly over the past few days, I have taken the
liberty to push the commits directly without going through QA; I have
tested that the package builds and works with one of my local php projects.

I am closing the second issue, which is thus handled.
And I am leaving the first issue open; while the immediate php problem is
(hopefully) solved, it remains to be discussed whether we should propagate
the gd inputs in the longer term.

My understanding is that given the pkg-config file, we normally would
propagate the inputs. On the other hand, propagated inputs tend to create
problems (for instance, when two different packages propagate two different
versions of the same input library); and I do not quite understand why
with over 5000 packages depending on gd, most of them do not seem to be
affected. Maybe these do not use pkg-config to check for gd?
So it may be a better option to only patch the affected packages (if any
are left) and leave gd as it is.

Andreas

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.