GNU bug report logs - #73647
[PATCH] Add indicator-sound-switcher

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: guix-patches; Reported by: Sebastian Willenbrink <sebastian.willenbrink@HIDDEN>; Keywords: patch; dated Sun, 6 Oct 2024 01:01:01 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 73647 <at> debbugs.gnu.org:


Received: (at 73647) by debbugs.gnu.org; 12 Nov 2024 13:06:07 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 12 08:06:07 2024
Received: from localhost ([127.0.0.1]:32881 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tAqat-0006Y9-F0
	for submit <at> debbugs.gnu.org; Tue, 12 Nov 2024 08:06:07 -0500
Received: from mail-ed1-f54.google.com ([209.85.208.54]:43281)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <sebastian.willenbrink@HIDDEN>) id 1tAqar-0006Y1-3o
 for 73647 <at> debbugs.gnu.org; Tue, 12 Nov 2024 08:06:05 -0500
Received: by mail-ed1-f54.google.com with SMTP id
 4fb4d7f45d1cf-5c9362c26d8so4481032a12.1
 for <73647 <at> debbugs.gnu.org>; Tue, 12 Nov 2024 05:06:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1731416704; x=1732021504; darn=debbugs.gnu.org;
 h=content-transfer-encoding:in-reply-to:from:content-language:subject
 :references:cc:to:user-agent:mime-version:date:message-id:from:to:cc
 :subject:date:message-id:reply-to;
 bh=hBTMtyDLs7Kf9kP/NKYCWc7I4xJcVoSXKwzpMy3Vr28=;
 b=FB2gAPZS3nybaEv6bIbMMNWG7pCfxEFxguxSy8Z2geh3Qj7zcV7EOTCQlJ4H/r3La3
 dA7mJJyznvo3usgU6YNhFZnoCo7HQ9DHt2dQRA4FQ1BxuVg526ybjMxBwhH1Mbx9/ygw
 wKhX3Z45/475dqSXxai++oMFkZ60g9xW/k5VbsEtMjbnHFNhsU/G1QNT8gGS+VF2fImG
 PWE1GwB7RISNeApDYEbBMPI4hMLw9K9J5PDkDM7bRI8JZj3KsdvHj/nSlCya8tsYpnAJ
 75tf79sg8s766wKPjWoZk34oR/Ihspsz9ZP2Cxi9R8gJbTXxb9fUu71w5wAtONa5fsfK
 yI4A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1731416704; x=1732021504;
 h=content-transfer-encoding:in-reply-to:from:content-language:subject
 :references:cc:to:user-agent:mime-version:date:message-id
 :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=hBTMtyDLs7Kf9kP/NKYCWc7I4xJcVoSXKwzpMy3Vr28=;
 b=NAjgUbftBQeOr5AatL5HapDdvRROt7B+vqtHqRbLV9m3O073O/xF3nio5eR5QKoFy5
 SI+jv1SGH4V+CnmzG+ZehhPENEMOTH9d95TDauV63aHeS5G5aaiuV5TyekmdOLAiLx0D
 chniJ7HLxBuz+WCv+l27YhXzAn6GyTxOs+SyJzcc3E4SkF7zYEHvBaU3oF1Jy90ybY94
 taU9DAjYNhiR5hK6n5TMInywzeFQ8+mPZECZ0u605eujzj/BboEq09eoSiKMTIaus4XO
 LtTE8miiGI9/WSXPEx1iB45TBzlIYKjNsKM35Vsm9wSMaQppeKhn0zqOJCTpk4ssNE+6
 G24w==
X-Gm-Message-State: AOJu0Yx94tKXtylpylVSsQ6lHKoEQk9BWglYt2Lt/fhansrpHzNMnlCm
 5EuN+6GV+OB+RjPpPkNvLF6lthDy5NctmH5Cymx1Cv1zdb1oKRgCiytJ4SBeRIw=
X-Google-Smtp-Source: AGHT+IFxyEhMFUC7kV4lrrjzdqe1TuBZPQFvEtZMgQu39+ZUikwSDZt6RpYtinK1VBPM2POUtkbNUQ==
X-Received: by 2002:a17:907:a0c9:b0:a99:ff33:9ba5 with SMTP id
 a640c23a62f3a-a9eeca85d1amr1622090166b.24.1731416704183; 
 Tue, 12 Nov 2024 05:05:04 -0800 (PST)
Received: from ?IPV6:2a02:810d:6740:3af:3cdd:4389:3d79:9d00?
 ([2a02:810d:6740:3af:3cdd:4389:3d79:9d00])
 by smtp.gmail.com with ESMTPSA id
 a640c23a62f3a-a9ee0dc4c60sm727998666b.102.2024.11.12.05.05.03
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 12 Nov 2024 05:05:03 -0800 (PST)
Message-ID: <4a69e161-d581-462f-9d9d-3e7c451a1775@HIDDEN>
Date: Tue, 12 Nov 2024 14:05:02 +0100
MIME-Version: 1.0
User-Agent: Icedove Daily
To: 73647 <at> debbugs.gnu.org
References: <878qujcfln.fsf@HIDDEN>
Subject: Re: [PATCH] Add indicator-sound-switcher
Content-Language: en-US
From: Sebastian Willenbrink <sebastian.willenbrink@HIDDEN>
In-Reply-To: <878qujcfln.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 73647
Cc: Nicolas Graves <ngraves@HIDDEN>, Nicolas Graves <ngraves@HIDDEN>,
 Sebastian Willenbrink <sebastian.willenbrink@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hi!

Here is the new patch. Took some time for me to get around to it.

I'm still a bit confused by the mail/patch-based workflow so I hope I 
didn't mess anything up. I assume amending the commit is the correct way 
to go. Or should I have created a separate commit with only the new changes?

Best regards,
Sebastian
Information forwarded to guix-patches@HIDDEN:
bug#73647; Package guix-patches. Full text available.

Message received at 73647 <at> debbugs.gnu.org:


Received: (at 73647) by debbugs.gnu.org; 12 Nov 2024 13:00:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 12 08:00:15 2024
Received: from localhost ([127.0.0.1]:32848 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tAqVD-0006HD-6O
	for submit <at> debbugs.gnu.org; Tue, 12 Nov 2024 08:00:15 -0500
Received: from mail-ej1-f51.google.com ([209.85.218.51]:42326)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <sebastian.willenbrink@HIDDEN>) id 1tAqVA-0006Bo-N5
 for 73647 <at> debbugs.gnu.org; Tue, 12 Nov 2024 08:00:13 -0500
Received: by mail-ej1-f51.google.com with SMTP id
 a640c23a62f3a-a9e8522c10bso871404766b.1
 for <73647 <at> debbugs.gnu.org>; Tue, 12 Nov 2024 05:00:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1731416347; x=1732021147; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:message-id:date:subject:cc
 :to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=1KwzDSgPmeTVgF+g3IHIGU1XaMCBu5W5YXvqftmT2NY=;
 b=TWyennlCmqS1DxKjcDQTyO6SCwpck5I3E4+yG5LU/h37Osutqahztxb1FaMufSWIyg
 QNlk8Q2MVbfP1qtRTgoe4cVtge5sX3v5Zb+tchiSi+TK4XgMXLs0HkezB0bRpfeGw+rd
 SfohDCULhy4PoI3IQUuzIQQ/64cq4huUuHobYjFK8hBbqXjiSlwKl4xIT4WvCWwijITH
 nct8kdDszemP1JeidkUwOkSeBWJZYzGYz2FHB/cIhRLFKa29yJZ54VRpQorzPAf6Mi1M
 aUF4Va8izExga1tzvwiwPqvT/J0fpVvHh4kYtxB6GXzIo7HG8GQBHTFREyDh05CCirL+
 m1xw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1731416347; x=1732021147;
 h=content-transfer-encoding:mime-version:message-id:date:subject:cc
 :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=1KwzDSgPmeTVgF+g3IHIGU1XaMCBu5W5YXvqftmT2NY=;
 b=FhSKfQNGkM5CJl0ndaDNWhAsijCZ/8E8vf8WnbfwPrpRs+ysKPCEMF/kxZF3WgWQAo
 y+oCdC0zPBK8DNxTsDwEmX4zt2rqwobBR0TlknsEDAKL02englhfPxHahOVYEmKlVFif
 IZ4TW+412tnasATmsZVhjC6H6hPfZ8bt64mj6ahsq4BobMVFafs5hcgekTSPqvaBgz5J
 V03rUKZr3r+7ZkxqbsUXLFZUI3VpT/oc58XRJXFdtde+pY86osyNhDRgecmauT/kKLYm
 Vy6jj5BOhbncAyxEp9ffsnp+TYLaVd+bE5d2c0jzcNk9yT9gQoBbyBr9jCIt8tQ6D5nm
 P/sA==
X-Gm-Message-State: AOJu0YyhqsGweQcQtLy6EDAdx/l6Rwk2RNznLGgyHpS7VVOJVNXInlRY
 axlElAA1aMOjAuZuyyNL5fgYFUhumcbGsQgLVlWCYKEu0h3zpF65NrIiPfrDvF0=
X-Google-Smtp-Source: AGHT+IH2Eq0MZgDQdBhX6h74ED1LRXqQPpkGRxM2Gss7eSsYiu085V7yUNu/coSLCkKrb60MifzG1Q==
X-Received: by 2002:a17:907:2688:b0:a9a:cea7:1294 with SMTP id
 a640c23a62f3a-a9eeca81d45mr1614723666b.21.1731416345740; 
 Tue, 12 Nov 2024 04:59:05 -0800 (PST)
Received: from framework-guix.fritz.box
 (ip5f5befc3.dynamic.kabel-deutschland.de. [95.91.239.195])
 by smtp.gmail.com with ESMTPSA id
 a640c23a62f3a-a9ee0def4b5sm721578866b.146.2024.11.12.04.59.04
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 12 Nov 2024 04:59:05 -0800 (PST)
From: Sebastian Willenbrink <sebastian.willenbrink@HIDDEN>
To: 73647 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add indicator-sound-switcher.
Date: Tue, 12 Nov 2024 13:58:59 +0100
Message-ID: <81ee4883a6a714b32146e01c99270d16ae7d44ff.1731415143.git.sebastian.willenbrink@HIDDEN>
X-Mailer: git-send-email 2.46.0
MIME-Version: 1.0
X-Debbugs-Cc: Sebastian Willenbrink <sebastian.willenbrink@HIDDEN>,
 Nicolas Graves <ngraves@HIDDEN>, Nicolas Graves <ngraves@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 73647
Cc: Sebastian Willenbrink <sebastian.willenbrink@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* gnu/packages/wm.scm (indicator-sound-switcher): New variable.

Change-Id: I013091cca83fc96c47b5a7ebe5ccfc7db1354ff1
---
 gnu/packages/wm.scm | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 836d4b6c04..61f8d4a310 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -112,6 +112,7 @@ (define-module (gnu packages wm)
   #:use-module (gnu packages)
   #:use-module (gnu packages bash)
   #:use-module (gnu packages admin)
+  #:use-module (gnu packages audio)
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages base)
   #:use-module (gnu packages bison)
@@ -3969,3 +3970,41 @@ (define-public wf-config
 configuration files of Wayifre.  It can set key and mouse bindings,
 configure input, and customize Wayfire plugins.")
     (license license:expat)))
+
+(define-public indicator-sound-switcher
+  (package
+    (name "indicator-sound-switcher")
+    (version "2.3.10.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/yktoo/indicator-sound-switcher")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0y52k56ww2327r7ywwdvld5lx85qmcy8yrpaxc5lim7w3jbf3s85"))))
+    (build-system python-build-system)
+    (native-inputs (list gettext-minimal gobject-introspection))
+    (inputs (list python-pygobject girara python-pulsectl pulseaudio))
+    (propagated-inputs (list libappindicator keybinder))
+    (arguments
+     (list
+      #:phases #~(modify-phases %standard-phases
+                   (add-before 'install 'patch-xdg-autostart
+                     (lambda* (#:key inputs #:allow-other-keys)
+                       (substitute* "setup.py"
+                         (("/etc/xdg/autostart")
+                          '"share/etc/xdg/autostart"))
+                       (substitute*
+                           "lib/indicator_sound_switcher/lib_pulseaudio.py"
+                         (("libpulse.so.0")
+                          (search-input-file inputs "/lib/libpulse.so.0"))))))))
+    (home-page "https://github.com/yktoo/indicator-sound-switcher")
+    (synopsis "Sound input/output selector indicator for Linux")
+    (description
+     "indicator-sound-switcher shows an icon in the indicator area or the system
+tray (whatever is available in your desktop environment). The icon's menu allows
+you to switch the current sound input and output (i.e. source ports and sink
+ports in PulseAudio's terms, respectively) with just two clicks.")
+    (license license:gpl3)))

base-commit: 40625c213ad2007f70117518a7cc290d367e652a
-- 
2.46.0
Information forwarded to sebastian.willenbrink@HIDDEN, ngraves@HIDDEN, ngraves@HIDDEN, guix-patches@HIDDEN:
bug#73647; Package guix-patches. Full text available.

Message received at 73647 <at> debbugs.gnu.org:


Received: (at 73647) by debbugs.gnu.org; 20 Oct 2024 09:02:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Oct 20 05:02:29 2024
Received: from localhost ([127.0.0.1]:45771 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1t2RpU-0003hy-W9
	for submit <at> debbugs.gnu.org; Sun, 20 Oct 2024 05:02:29 -0400
Received: from 17.mo550.mail-out.ovh.net ([87.98.179.142]:39085)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ngraves@HIDDEN>) id 1t2RpR-0003hk-T7
 for 73647 <at> debbugs.gnu.org; Sun, 20 Oct 2024 05:02:27 -0400
Received: from director10.ghost.mail-out.ovh.net (unknown [10.109.139.198])
 by mo550.mail-out.ovh.net (Postfix) with ESMTP id 4XWXWB6J6vz1RYT
 for <73647 <at> debbugs.gnu.org>; Sun, 20 Oct 2024 09:01:58 +0000 (UTC)
Received: from ghost-submission-5b5ff79f4f-r6z9k (unknown [10.110.188.95])
 by director10.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 2698D1FE58;
 Sun, 20 Oct 2024 09:01:58 +0000 (UTC)
Received: from ngraves.fr ([37.59.142.108])
 by ghost-submission-5b5ff79f4f-r6z9k with ESMTPSA
 id UhzzAAbHFGekMgAAmSaN5Q
 (envelope-from <ngraves@HIDDEN>); Sun, 20 Oct 2024 09:01:58 +0000
Authentication-Results: garm.ovh; auth=pass
 (GARM-108S00237f0200a-e8f8-4eeb-808e-9d67c3be2b77,
 FA5DCE6FD238C77E776584D68A2B59A15A69FDEC) smtp.auth=ngraves@HIDDEN
X-OVh-ClientIp: 86.246.19.221
From: Nicolas Graves <ngraves@HIDDEN>
To: Sebastian Willenbrink <sebastian.willenbrink@HIDDEN>,
 73647 <at> debbugs.gnu.org
Subject: Re: [bug#73647] [PATCH] Add indicator-sound-switcher
In-Reply-To: <1266383a76e3fe2cd6e05894e3c04b5b5fdc0242.1728154207.git.sebastian.willenbrink@HIDDEN>
References: <1266383a76e3fe2cd6e05894e3c04b5b5fdc0242.1728154207.git.sebastian.willenbrink@HIDDEN>
Date: Sun, 20 Oct 2024 11:01:56 +0200
Message-ID: <878qujcfln.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Ovh-Tracer-Id: 14341150064889029232
X-VR-SPAMSTATE: OK
X-VR-SPAMSCORE: -100
X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeeftddrvdehjedgudduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvvefujghffffkgggtsehttdertddttddtnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepveekleeujedthefgffekleekhffhffetgfdvheekleeuhfehueeljedtjefhvdfgnecukfhppeduvdejrddtrddtrddupdekiedrvdegiedrudelrddvvddupdefjedrheelrddugedvrddutdeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpehnghhrrghvvghssehnghhrrghvvghsrdhfrhdpnhgspghrtghpthhtohepuddprhgtphhtthhopeejfeeigeejseguvggssghughhsrdhgnhhurdhorhhgpdfovfetjfhoshhtpehmohehhedtpdhmohguvgepshhmthhpohhuth
DKIM-Signature: a=rsa-sha256; bh=pK5iDrAnuRV45SGvjaK+sF5YENftvcw8wsdwSCpV3IU=; 
 c=relaxed/relaxed; d=ngraves.fr; h=From;
 s=ovhmo4487190-selector1; t=1729414919; v=1;
 b=hGp4zkhyJTlUQfNh9Uuua2KDEKCGL7EPZZIcCfmY28ReSJIA0RQTtNjzc3wlvqpHx6rhbzbS
 lNCe8QG5ET72sorq8CGS0sQg/fSdkIK9yrAS+rPKGzVLMd9bkhPB8q2RTxdWEFwdtps6VmqqmkX
 Bkv0HfzdRG8gdTgETXc3BVFXuH1zYMtEv+DH7qH1nL3BFfUzaWDJgPOKDbZpAZd+xXzvVHHchvz
 sdno8/EkdFdYrV66CuTxul95e7ObHIKK7cu6GN1ArlcC9MYiBXOqqCUtQG2VnOqaTfXJ+RnJGIj
 mcnHavqcZKpWhjUMuytHgJlS/UvdO5DW5wFwFEJBV9xKQ==
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 73647
Cc: Sebastian Willenbrink <sebastian.willenbrink@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


> +    (arguments
> +     (list
> +      #:phases #~(modify-phases %standard-phases
> +                   (add-before 'install 'patch-xdg-autostart
> +                     (lambda* (#:key inputs outputs #:allow-other-keys)

You also don't need outputs here.

-- 
Best regards,
Nicolas Graves
Information forwarded to guix-patches@HIDDEN:
bug#73647; Package guix-patches. Full text available.

Message received at 73647 <at> debbugs.gnu.org:


Received: (at 73647) by debbugs.gnu.org; 20 Oct 2024 07:18:57 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Oct 20 03:18:57 2024
Received: from localhost ([127.0.0.1]:45582 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1t2QDJ-0007Z0-7y
	for submit <at> debbugs.gnu.org; Sun, 20 Oct 2024 03:18:57 -0400
Received: from mout.gmx.net ([212.227.15.19]:60627)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ngraves@HIDDEN>) id 1t2Q91-0007Lk-44
 for 73647 <at> debbugs.gnu.org; Sun, 20 Oct 2024 03:14:32 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.com;
 s=s31663417; t=1729408440; x=1730013240; i=ngraves@HIDDEN;
 bh=xLW7hYGteTSGGAH/I2x3Xdok9qUFYOQCMn5770dENgA=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date:
 Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc:
 content-transfer-encoding:content-type:date:from:message-id:
 mime-version:reply-to:subject:to;
 b=JxNUMl8Z4Y4BrAP31z6wxBY/lAp8fyvX5n03UssGEGmRuJ/NVyckIJ5mARCzWdIM
 6yZei5wgAoxT8uZR8a8JhEysO6qYPJRqbWf74K0+LmYXJKXtX/iaB1Ri54yuYXqqv
 Tr0nry7s1DKYhhYmYjg9Zd3MlIMnipv2aMrNItVPQccypZQu7QVoD+POOMAG92E6N
 9Qk4pXh5/ftuKx3dpSFECyYuD9YAs5MzwJhsiFRzj0jvkA2L2gyn4Gw8VNlT3Habw
 Gc5rxJApYewFysmdLZLfsHlkj5kId1TppycvcI4vbQKv6dwpO7kD8azUuuEiFHcgq
 +Xl+jDLPTFJbIhtulw==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from localhost ([176.179.140.244]) by mail.gmx.net (mrgmx005
 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MMXQ5-1tJoIK3fa3-00Ncd5; Sun, 20
 Oct 2024 09:14:00 +0200
From: Nicolas Graves <ngraves@HIDDEN>
To: Sebastian Willenbrink <sebastian.willenbrink@HIDDEN>,
 73647 <at> debbugs.gnu.org
Subject: Re: [bug#73647] [PATCH] Add indicator-sound-switcher
In-Reply-To: <1266383a76e3fe2cd6e05894e3c04b5b5fdc0242.1728154207.git.sebastian.willenbrink@HIDDEN>
References: <1266383a76e3fe2cd6e05894e3c04b5b5fdc0242.1728154207.git.sebastian.willenbrink@HIDDEN>
Date: Sun, 20 Oct 2024 09:13:59 +0200
Message-ID: <87wmi3456w.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:/TciVK+LzpVgm85nI3/zaZv/Ng2roMV/Zap4hTzmx2oLQWQfsJN
 MS6nEca2iOBAyv0kejgbc447jzkdtTuK+tqeeBoYHXCRiWNpj4e+/zA63hjC749pz1ljXoM
 raw4s7gkoT89wDGMDyxpIRyPgicK1FCtGh+90l+G22BSuAr3RKqYpTs9DJ1C9E1+hCjL+Dy
 xGRNtX21q1dAYl7U4bmrA==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:JxkK3uTlcRc=;ZG9rdOf4Hs3JkCB/zJj1Kn9dt4j
 f5w7P87+3cG7YYvfJ9Jvo3zupZziy/D4DkbcBn3AsvBFEmaf3tej6LEAZG0kouG4SpBOLzKuS
 J+1XVwQuu8ZESpiGxbEow9dYCmt6qFUAjYqftT7RTnsbOQPGB7TF+jT0tzHS1zJiP4meb6JxX
 3hdBEt+uP0gvFh7kB/3eIC/bGea7wb77WFGR+rUFj/crSjVlRddTXwZxA+4ODRXq1KFsHwWCG
 gabCGU1UmofqDVBT5A4dTBClwW2MB8rEXonvtcRV8HYbVBS9zznmNHddekrXMX5IMqgbBIxX4
 0zVB4JoFt+P1q/7Hwl1yAX2TWwxw11Cj8zCgYcp8RAvq1I9bEuFeo+T/ougoEO22wnhopx7tE
 T1LdEblHWmFmuTk3j7lR0yKKpxW21Fm6Z+yX0X0mDQabi3u8SvzIANF6YFPfh58hih38WWkBz
 ZVCytLg65kqgjTEetku8qACSRa+zZN3OD0G1hXY1163i5nk8gDA9N0qeXsabClhCz/heFus+Y
 zJLQy7EESnbkDgEql846ltA0sIFTgb+Ei1UTf+MW984BTGsIazv1brZM09smE7S9DIW6fAciz
 50iuiaA68wbHboX4wnMeobDU0+BRIUJIrba3/551ZQqjGDsh8edNbLkOQOWMomaIomuYw+GLg
 WiVmB+9coRROgCQk55X5m0ndAuD4JN+sCRMO1fOyeWOsvW0mD9+ytlcBL+hHy66y2YbcBHsbD
 SUBbK2RboVUhI7GF+JvgPwAfKH/2ummoCumJ2njJOcn8NaTXUDWevQGTDj5jCW+DVGZ/gQX7W
 WL8w8jyPqqkuHsg9oW2j/HNxSbBGzcztSx530g/Ib6Wgg=
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 73647
X-Mailman-Approved-At: Sun, 20 Oct 2024 03:18:52 -0400
Cc: Sebastian Willenbrink <sebastian.willenbrink@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hi!

Below some review comments ;)

On 2024-10-05 20:50, Sebastian Willenbrink wrote:
> +(define-public indicator-sound-switcher
> +  (package
> +    (name "indicator-sound-switcher")
> +    (version "2.3.10.1")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/yktoo/indicator-sound-switcher")
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "0y52k56ww2327r7ywwdvld5lx85qmcy8yrpaxc5lim7w3jbf3s85")=
)))
> +    (build-system python-build-system)
> +    (native-inputs (list gettext-minimal gobject-introspection))
> +    (inputs (list python-pygobject girara python-pulsectl pulseaudio))
> +    (propagated-inputs (list libappindicator keybinder))
> +    (arguments
> +     (list
> +      #:phases #~(modify-phases %standard-phases
> +                   (add-before 'install 'patch-xdg-autostart
> +                     (lambda* (#:key inputs outputs #:allow-other-keys)
> +                       (let* ((pulseaudio (assoc-ref inputs "pulseaudio=
"))
> +                              (pulse (string-append pulseaudio
> +                                                    "/lib/libpulse.so.0=
")))

We rather use (search-input-file inputs "/lib/libpulse.so.0") now.
It's also shorter, so you can probably drop the let* and use that
directly in the substitute*

> +                         (substitute* "setup.py"
> +                           (("/etc/xdg/autostart")
> +                            '"share/etc/xdg/autostart"))
> +                         (substitute* "lib/indicator_sound_switcher/lib=
_pulseaudio.py"

This line is probably above 79 characters. Use the next line ;)

> +                           (("libpulse.so.0")
> +                            pulse))))))))
> +    (home-page "https://github.com/yktoo/indicator-sound-switcher")
> +    (synopsis "Sound input/output selector indicator for Linux")
> +    (description
> +     "It shows an icon in the indicator area or the system tray

Please use "This package" or its name instead of it.

> +(whatever is available in your desktop environment).
> +The icon's menu allows you to switch the current sound input and output
> +(i.e. source ports and sink ports in PulseAudio's terms, respectively) =
with just two clicks:")

This last line is too long and shouldn't end with :

> +    (license license:gpl3)))
>
> base-commit: 713f5562faf1acc02dc9e3f3a2d45dc39abbe9f1

You should also write a proper git commit message. There are templates
in guix's source etc/snippets folder if you use emacs (either tempel or
yasnippets). Or copy another gnu: Add [pkg] commit.

I don't see other lints but for some reason the build is blocked for
x86-64-linux on QA.

=2D-
Best regards,
Nicolas Graves
Information forwarded to guix-patches@HIDDEN:
bug#73647; Package guix-patches. Full text available.

Message received at 73647 <at> debbugs.gnu.org:


Received: (at 73647) by debbugs.gnu.org; 6 Oct 2024 20:52:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Oct 06 16:52:36 2024
Received: from localhost ([127.0.0.1]:42521 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sxYF2-0008U5-DZ
	for submit <at> debbugs.gnu.org; Sun, 06 Oct 2024 16:52:36 -0400
Received: from mail-lf1-f42.google.com ([209.85.167.42]:51303)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <sebastian.willenbrink@HIDDEN>) id 1sxYEy-0008Tn-R6
 for 73647 <at> debbugs.gnu.org; Sun, 06 Oct 2024 16:52:34 -0400
Received: by mail-lf1-f42.google.com with SMTP id
 2adb3069b0e04-5389917ef34so4201048e87.2
 for <73647 <at> debbugs.gnu.org>; Sun, 06 Oct 2024 13:52:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1728247880; x=1728852680; darn=debbugs.gnu.org;
 h=content-transfer-encoding:subject:from:content-language:to
 :user-agent:mime-version:date:message-id:from:to:cc:subject:date
 :message-id:reply-to;
 bh=E2SXwR6eEUgjjgqRretv5SoGyJICtYenTjoSnSADGPA=;
 b=NPHP+kSzi01HuhDh1fOdqL/U5zLj3lV4rbRs0ZSIcPJALqsNUONekaiWfmuz4OIaci
 ESGTdWrV70ZfBtouQEdJSE5WYkaRKLGBIzomO4FBApyOJFZSv49JOPx4rXCXtLCVMoz9
 Xoq5plpFdn5R+Oi2MYBaRuibUBi8/l/28PRTLwkK9EQ9MTiGhRmGgnttIBFIC0B7F6lJ
 1Msn6jgM0yZuhebcuEmYkzBKcqxwklGFsCfkBx0NIjnErHZRCeagl2VLEp/bE2f3vOrN
 aX+JMtwTRniwfiBRpY/YrqnsEBOB6071s2eWqwluljCzlLgAeSm0ZMDnF15AkMO+d4mv
 tSoA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1728247880; x=1728852680;
 h=content-transfer-encoding:subject:from:content-language:to
 :user-agent:mime-version:date:message-id:x-gm-message-state:from:to
 :cc:subject:date:message-id:reply-to;
 bh=E2SXwR6eEUgjjgqRretv5SoGyJICtYenTjoSnSADGPA=;
 b=YXbUHNUW+cN7r1mcwz6sxl9RWSHMFa3GhiANiU9/wzwYge0ni2RfyEUspoOmGuLZhD
 AaSRjxYBGeAgusUAeDWnMjs+wTM5+FHUfKnLCFrJyw/3o2selOHA9K3SMzSb1qpYNCD1
 qWFXblOnLx+Ks1iOKwcG73Jqt0YwiFaHz7ym/zv6i2acxN4uLipJhMWaWEyBuQlItfek
 or9wn8aqis1j4fG7SuY8NCmnwDfarXb/MKy8pSkmiu9h7t31SHJKN1fyw5qo3vF0RLK5
 QLeAAbfCgaalyaP8n566zKHq5TEZqOvF9Lziht8R8vPgCiLqFte3KjF/KRd3KbyEGR7n
 mBRA==
X-Gm-Message-State: AOJu0Ywng1bU6NQpYlqEY3jtDIEr3HAL7uP2b7hCGdRS1L+a5Vpnvbd3
 OmRNw+e/Eai2T01uBCzWYV1Qu6kszeX4X77Opsz0/5MJVWVpSsX+IlE/Ww==
X-Google-Smtp-Source: AGHT+IFju+/GkWPntnn1/htHtwF03pAX9d70/Jedz0W/dOaqEk1EgvUD9Qk98ph/Ho9kYr7ZNjFV1Q==
X-Received: by 2002:a05:6512:3b10:b0:539:a353:2799 with SMTP id
 2adb3069b0e04-539ab889f18mr4663479e87.26.1728247879902; 
 Sun, 06 Oct 2024 13:51:19 -0700 (PDT)
Received: from [192.168.0.104] (h-176-10-146-112.NA.cust.bahnhof.se.
 [176.10.146.112]) by smtp.gmail.com with ESMTPSA id
 2adb3069b0e04-539aff1d32dsm613683e87.134.2024.10.06.13.51.18
 for <73647 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 06 Oct 2024 13:51:19 -0700 (PDT)
Message-ID: <4f12902f-250d-4c80-be69-9d951595c716@HIDDEN>
Date: Sun, 6 Oct 2024 22:51:18 +0200
MIME-Version: 1.0
User-Agent: Icedove Daily
To: 73647 <at> debbugs.gnu.org
Content-Language: en-US
From: Sebastian Willenbrink <sebastian.willenbrink@HIDDEN>
Subject: Small oversight
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 73647
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Actually, the icons work fine after logging in again. So it works 
exactly as I would expect it to and can IMHO be merged as it is.
Information forwarded to guix-patches@HIDDEN:
bug#73647; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 6 Oct 2024 01:00:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 05 21:00:44 2024
Received: from localhost ([127.0.0.1]:39744 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sxFdb-0002ZC-8I
	for submit <at> debbugs.gnu.org; Sat, 05 Oct 2024 21:00:43 -0400
Received: from lists.gnu.org ([209.51.188.17]:34282)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <sebastian.willenbrink@HIDDEN>) id 1sx9sZ-0008Te-RW
 for submit <at> debbugs.gnu.org; Sat, 05 Oct 2024 14:51:49 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <sebastian.willenbrink@HIDDEN>)
 id 1sx9sT-0003W5-PL
 for guix-patches@HIDDEN; Sat, 05 Oct 2024 14:51:41 -0400
Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <sebastian.willenbrink@HIDDEN>)
 id 1sx9sQ-0007xw-7s
 for guix-patches@HIDDEN; Sat, 05 Oct 2024 14:51:40 -0400
Received: by mail-lf1-x12b.google.com with SMTP id
 2adb3069b0e04-5389917ef34so3633495e87.2
 for <guix-patches@HIDDEN>; Sat, 05 Oct 2024 11:51:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1728154296; x=1728759096; darn=gnu.org;
 h=content-transfer-encoding:mime-version:message-id:date:subject:cc
 :to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=e4ImNhL0T/GSdvsZEsxYNwm1npEcHjvvEnw1jkkQ4TU=;
 b=ST/DPDpcnmOZBdp8Z+ckPW8nzoRTPa7zgUHZTgZG0o/mzmPZY6fOPTBRHFVnOL1YQi
 SH7ir8Co+t8ysWIyErOO6LE3NZ6d+hadlZBKN+dskP3HxhzOr58yhc+SAjVsRbR8CAI1
 qyJDOIBUSjLL4et/bQ+cfVkDS0kXo66gy0JgMTMOiRIpWl3dcS/VxGNuuRMMAUnLkklx
 VarUfh9WFb1g7KK1WGyGfy2fhw6rNfoVz3MGS0M21f2fvT44YSQBbY8BIrkDjBH3+t7I
 3Tbov/HyZ3UoKRJpdyQf0zWlGtVXJ5gibeponx5+OmuZ/f4e+cAoVs46Q9K/QH1jsT52
 3mWw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1728154296; x=1728759096;
 h=content-transfer-encoding:mime-version:message-id:date:subject:cc
 :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=e4ImNhL0T/GSdvsZEsxYNwm1npEcHjvvEnw1jkkQ4TU=;
 b=kCds1QTVGeXTKgSL1i/gQZYf0SmntwX2gsIajPGydN7CQdnbbXiNxWgHmgBbNOpqkr
 1sp6G/W6n2zhx215YJAJm2Klc4n8cbsY83GEJMNfUXmS5l/grm/seC+batCycXoigaKW
 49hDwPINdhhED/MuNdPCkmWv2+qaXX7u9FoW5o4ux3eU2ieOBVr9qHxFYTwIGEgYejsT
 wv2SPcAArwOwOkLwXrrJG+E4VB+AXXSej964kW4xGuJOYJCaV/zWoTMXPlmF29H60Cvt
 /cnFt94xpYumOkcXgYqoPpjYDRpgtweuyvS7HEmmy6J+GlirB2I/StwmaL2+oFnCrK3C
 l7Fw==
X-Gm-Message-State: AOJu0YxbcYlJBJtzumWb6C7aq+Ja5HKwAjjeISmXVjpl7TlP/oCKbIoN
 a3nlebEqn7dLts6OvCHjliXl/Ge6IZQn5LSp9bTF69ZMD9Nb4O3CbzpTRw==
X-Google-Smtp-Source: AGHT+IHF6eiw6WcRlahPfTOao3TJ+RdCJSzZTbXNhnikW2X8p7rrAE+Vmtsjh2ztA1NDRUKajwdyJQ==
X-Received: by 2002:a05:6512:3d88:b0:539:8b2f:c7aa with SMTP id
 2adb3069b0e04-539ab9e6da1mr3669182e87.53.1728154295371; 
 Sat, 05 Oct 2024 11:51:35 -0700 (PDT)
Received: from localhost.localdomain (h-176-10-146-112.NA.cust.bahnhof.se.
 [176.10.146.112]) by smtp.gmail.com with ESMTPSA id
 2adb3069b0e04-539aff28367sm285932e87.281.2024.10.05.11.51.33
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 05 Oct 2024 11:51:34 -0700 (PDT)
From: Sebastian Willenbrink <sebastian.willenbrink@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] Add indicator-sound-switcher
Date: Sat,  5 Oct 2024 20:50:08 +0200
Message-ID: <1266383a76e3fe2cd6e05894e3c04b5b5fdc0242.1728154207.git.sebastian.willenbrink@HIDDEN>
X-Mailer: git-send-email 2.46.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2a00:1450:4864:20::12b;
 envelope-from=sebastian.willenbrink@HIDDEN; helo=mail-lf1-x12b.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Sat, 05 Oct 2024 21:00:42 -0400
Cc: Sebastian Willenbrink <sebastian.willenbrink@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

This commit adds indicator-sound-switcher.
Unfortunately, I couldn't figure out how to export the icons so
that the program (/GTK?) finds them so it shows only a default gray icon.
Besides that it works fine.

Change-Id: I75e5dde35abe0a95af7c11ab2abfbc368ec9dff7
---
 gnu/packages/wm.scm | 41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 38cb8cc717..836b770c02 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -112,6 +112,7 @@ (define-module (gnu packages wm)
   #:use-module (gnu packages)
   #:use-module (gnu packages bash)
   #:use-module (gnu packages admin)
+  #:use-module (gnu packages audio)
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages base)
   #:use-module (gnu packages bison)
@@ -3957,3 +3958,43 @@ (define-public wf-config
 configuration files of Wayifre.  It can set key and mouse bindings,
 configure input, and customize Wayfire plugins.")
     (license license:expat)))
+
+(define-public indicator-sound-switcher
+  (package
+    (name "indicator-sound-switcher")
+    (version "2.3.10.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/yktoo/indicator-sound-switcher")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0y52k56ww2327r7ywwdvld5lx85qmcy8yrpaxc5lim7w3jbf3s85"))))
+    (build-system python-build-system)
+    (native-inputs (list gettext-minimal gobject-introspection))
+    (inputs (list python-pygobject girara python-pulsectl pulseaudio))
+    (propagated-inputs (list libappindicator keybinder))
+    (arguments
+     (list
+      #:phases #~(modify-phases %standard-phases
+                   (add-before 'install 'patch-xdg-autostart
+                     (lambda* (#:key inputs outputs #:allow-other-keys)
+                       (let* ((pulseaudio (assoc-ref inputs "pulseaudio"))
+                              (pulse (string-append pulseaudio
+                                                    "/lib/libpulse.so.0")))
+                         (substitute* "setup.py"
+                           (("/etc/xdg/autostart")
+                            '"share/etc/xdg/autostart"))
+                         (substitute* "lib/indicator_sound_switcher/lib_pulseaudio.py"
+                           (("libpulse.so.0")
+                            pulse))))))))
+    (home-page "https://github.com/yktoo/indicator-sound-switcher")
+    (synopsis "Sound input/output selector indicator for Linux")
+    (description
+     "It shows an icon in the indicator area or the system tray
+(whatever is available in your desktop environment).
+The icon's menu allows you to switch the current sound input and output
+(i.e. source ports and sink ports in PulseAudio's terms, respectively) with just two clicks:")
+    (license license:gpl3)))

base-commit: 713f5562faf1acc02dc9e3f3a2d45dc39abbe9f1
-- 
2.46.0
Acknowledgement sent to Sebastian Willenbrink <sebastian.willenbrink@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#73647; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.