GNU logs - #73660, boring messages


Message sent to guix@HIDDEN, pelzflorian@HIDDEN, dev@HIDDEN, ludo@HIDDEN, othacehe@HIDDEN, maxim.cournoyer@HIDDEN, zimon.toutoune@HIDDEN, me@HIDDEN, guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#73660] [PATCH] gexp: Improve support of Unicode characters.
Resent-From: Tomas Volf <~@wolfsden.cz>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix@HIDDEN, pelzflorian@HIDDEN, dev@HIDDEN, ludo@HIDDEN, othacehe@HIDDEN, maxim.cournoyer@HIDDEN, zimon.toutoune@HIDDEN, me@HIDDEN, guix-patches@HIDDEN
Resent-Date: Sun, 06 Oct 2024 15:44:01 +0000
Resent-Message-ID: <handler.73660.B.17282293861124 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 73660
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 73660 <at> debbugs.gnu.org
Cc: Tomas Volf <~@wolfsden.cz>, Christopher Baines <guix@HIDDEN>, Florian Pelz <pelzflorian@HIDDEN>, Josselin Poiret <dev@HIDDEN>, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Simon Tournier <zimon.toutoune@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>
X-Debbugs-Original-To: guix-patches@HIDDEN
X-Debbugs-Original-Xcc: Christopher Baines <guix@HIDDEN>, Florian Pelz <pelzflorian@HIDDEN>, Josselin Poiret <dev@HIDDEN>, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Simon Tournier <zimon.toutoune@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>
Received: via spool by submit <at> debbugs.gnu.org id=B.17282293861124
          (code B ref -1); Sun, 06 Oct 2024 15:44:01 +0000
Received: (at submit) by debbugs.gnu.org; 6 Oct 2024 15:43:06 +0000
Received: from localhost ([127.0.0.1]:41987 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sxTPV-0000I2-DC
	for submit <at> debbugs.gnu.org; Sun, 06 Oct 2024 11:43:06 -0400
Received: from lists.gnu.org ([209.51.188.17]:37454)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <~@wolfsden.cz>) id 1sxTPR-0000HP-PR
 for submit <at> debbugs.gnu.org; Sun, 06 Oct 2024 11:43:03 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1sxTPL-00060P-CT
 for guix-patches@HIDDEN; Sun, 06 Oct 2024 11:42:55 -0400
Received: from wolfsden.cz ([37.205.8.62])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1sxTPI-00021n-PL
 for guix-patches@HIDDEN; Sun, 06 Oct 2024 11:42:55 -0400
Received: by wolfsden.cz (Postfix, from userid 104)
 id 5B6FA31EFF6; Sun,  6 Oct 2024 15:42:50 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
 t=1728229370; bh=ZBRaB9MJIRKXeghlOajWnO1m7Ic2O5xdKKnrOZEl82o=;
 h=From:To:Cc:Subject:Date;
 b=pxMmK+ci/oq0O5IPT1Kugz/stNfI33uhC/FXYlBV5JEZWMM7g4MRbLeD9QMBwmsBG
 nLP6bdeS2WD5YlabEDLgV/mMRxDIVoKgANcAroK+BtAMq5pOUf4vNZXcLtNfBskg8V
 aBPP95JdxMQEvdxpDvsUVEBd7HfHWYR8a8G5XU9lf1pHitVu+1A2yXXbUZ94pKVCXt
 vKMschrBc4oxw0Br+MQGE72pwDtyXB6aZ0q4fZOwLKZvZYrFidnjccohMfbaz3KY4O
 9nzsoQb5ElQ4moOsRVL221XqrEaId5Gc+ySyb/9GTn4e0oy2oFdEj2srbrJLAH5Hn9
 UPt1oBP3m4pqtYVBJw65em8jwupCjxK9ok9NfxCC/M0rQImrUi6ojm1PEln7kte4BL
 kS2gAhSnDaL7Ix2X1HhQ8nvJGRy2kJyF0qqhWXrPpZ0djFgxhWfw82Bk9BtHbAXn0U
 UCZ5179pjqKoZ/NEA8aK5MiH0J5UxIAhdaGfd+LkvokuDvqZpL36PExUN9Wr3qKXj3
 oMTC6VsYdviJUvd8VqMHKIx7xitugQnGVnd+soI8rcnSCmxgy1O2WCHjH52YKwlsRx
 XRmBZVD4IN1thu9c/ICuYy6SHxvx9aHVQ3ZrpsjVVBgjZ9oU0HrleOGPnB93eNHrOT
 kg4J3K5U9MUkl/5PL3Ykl4Gw=
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden
X-Spam-Level: 
X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED
 autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (unknown [146.70.134.132])
 by wolfsden.cz (Postfix) with ESMTPSA id 8964A320A72;
 Sun,  6 Oct 2024 15:42:49 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
 t=1728229369; bh=ZBRaB9MJIRKXeghlOajWnO1m7Ic2O5xdKKnrOZEl82o=;
 h=From:To:Cc:Subject:Date;
 b=WCbiWurtPUZ5dm+2+5Fre9w34Vz5uoQowSTSO60nyHEGfykoT3x3yGt1keZoZo4ze
 omc/s7EwPV5aUZARxn9xOIb4AK5iBQ6+62o3gadUKdyZMKhq4NRJh6ufDM9BmEeDF/
 faFr9mjat9OObOqEJ768Fa/PFkIyulMVx+w0KO49H6vJRVcxZaj0g2wsQ1PU+Mj8gg
 G9rQA5RpTPNAzEdcXmqGxJCKuDeFeGjRfY/pxkOq6PzufjMkU/KIzn5cypo4gCREbI
 kyl969x/thG26O6sB+LkwWGiw9gD6p2IiYR5a012hyM6xnQH9HvhLFswFz1Kqnd3dO
 F5BQ3OdUmBmEGcf/wcicAOG757B4bs0KJpAif22WnvtYtmANek6aCMCpUskuK/+uf4
 lLqNA83X76i+GrUW1QBPlBQcOlmdpokNqYbTIe22cxr2sYc8g58UMYa71D44HGDmBs
 KbstWIwvli7Y6L3pbt95qDbEYh2ZjFwBY+pXZ3aBhT32olLq0Ahq8CFeE2PrMEIXJM
 WrLVH7ZnVptd7T6BRWRcYEl0X3/Lu/72k1SBQj+0SigGWaJ1cMxszvPuT6iJlwtgS3
 Dj8e8Lq3qIgZMwzzW9r+N2FtChf2kRlJCe6dKOhUoeqGrc83wgcmPbRVzThXN1PQOl
 hUgHXqt4yR+IDC0O9BlOVF68=
From: Tomas Volf <~@wolfsden.cz>
Date: Sun,  6 Oct 2024 17:42:26 +0200
Message-ID: <a0c437bad0b83665734831f7de7fc7e1f6972128.1728229346.git.~@wolfsden.cz>
X-Mailer: git-send-email 2.46.0
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=37.205.8.62; envelope-from=~@wolfsden.cz;
 helo=wolfsden.cz
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

Support for non-ASCII characters was mixed.  Some gexp forms did support them,
while others did not.  Combined with current value for
%default-port-conversion-strategy, that sometimes led to unpleasant surprises.
For example:

    (scheme-file "utf8" #~(with-output-to-file #$output
                            (λ _ (display "猫"))))

Was written to the store as:

    ((? _ (display "\u732b")))

No, that is not font issue on your part, that is an actual #\? instead of the
lambda character.  Which, surprisingly, does not do what it should when
executed.

The solution is to switch to C.UTF-8 locale where possible, since it is now
always available.  Or to explicitly set the port encoding.

No tests are provided, since majority of tests/gexp.scm use guile in version
2, and it tends to work under it.  The issues occur mostly with guile 3.

I did test it locally using:

      #!/bin/sh
      set -eu
      set -x

      [ -f guix.scm ] || { echo >&2 Run from root of Guix repo.; exit 1; }
      [ -f gnu.scm  ] || { echo >&2 Run from root of Guix repo.; exit 1; }

      cat >猫.scm <<'EOF'
      (define-module (猫)
        #:export (say))

      (define (say)
        "nyaaaa~~~~!")
      EOF

      mkdir -p dir-with-utf8-file
      cp 猫.scm dir-with-utf8-file/

      cat >repro.scm <<'EOF'
      (use-modules (guix build utils)
                   (guix derivations)
                   (guix gexp)
                   (guix store)
                   (ice-9 ftw)
                   (ice-9 textual-ports))

      (define cat "猫")

      (define (drv-content drv)
        (call-with-input-file (derivation->output-path drv)
          get-string-all))

      (define (out-content out)
        (call-with-input-file out
          get-string-all))

      (define (drv-listing drv)
        (scandir (derivation->output-path drv)))

      (define (dir-listing dir)
        (scandir dir))

      (define-macro (test exp lower? report)
        (let ((type (car exp)))
          `(false-if-exception
            (let ((drv (with-store %store
                         (run-with-store %store
                           (,(if lower? lower-object identity) ,exp)))))
              (format #t "~%~a:~%" ',type)
              (when (with-store %store
                      (build-derivations %store (list drv)))
                (format #t "~a~%" (,report drv)))))))

      (test (computed-file "utf8"
                           #~(with-output-to-file #$output
                               (λ _ (display #$cat))))
            #t drv-content)

      (test (program-file "utf8"
                          #~((λ _ (display #$cat))))
            #t drv-content)

      (test (scheme-file "utf8"
                         #~((λ _ (display #$cat))))
            #t drv-content)

      (test (text-file* "utf8" cat cat cat)
            #f drv-content)

      (test (compiled-modules '((猫)))
            #f drv-listing)

      (test (file-union "utf8" `((,cat ,(plain-file "utf8" cat))))
            #t drv-listing)

      ;;; No fix needed:
      (test (imported-modules '((猫)))
            #f dir-listing)

      (test (local-file "dir-with-utf8-file" #:recursive? #t)
            #t dir-listing)

      (test (plain-file "utf8" cat)
            #t out-content)

      (test (mixed-text-file "utf8" cat cat cat)
            #t drv-content)

      (test (directory-union "utf8" (list (local-file "dir-with-utf8-file"
                                                      #:recursive? #t)))
            #t dir-listing)
      EOF

      guix shell -CWN -D guix glibc-locales -- \
           env LANG=C.UTF-8 ./pre-inst-env guix repl -- ./repro.scm

Before this commit, the output is:

      + '[' -f guix.scm ']'
      + '[' -f gnu.scm ']'
      + cat
      + mkdir -p dir-with-utf8-file
      + cp 猫.scm dir-with-utf8-file/
      + cat
      + guix shell -CWN -D guix glibc-locales -- env LANG=C.UTF-8 ./pre-inst-env guix repl -- ./repro.scm

      computed-file:
      ?

      program-file:
      #!/gnu/store/mfkz7fvlfpv3ppwbkv0imb19nrf95akf-guile-3.0.9/bin/guile --no-auto-compile
      !#
      ((? _ (display "\u732b")))

      scheme-file:
      ((? _ (display "\u732b")))

      text-file*:
      ???

      compiled-modules:
      building path(s) `/gnu/store/ay3jifyvliigfgnz67jf0kgngzpya5a5-module-import-compiled'
      Backtrace:
                 5 (primitive-load "/gnu/store/rn7b0dq6iqfmmqyqzamix2mjmfy?")
      In ice-9/eval.scm:
          619:8  4 (_ #f)
      In srfi/srfi-1.scm:
         460:18  3 (fold #<procedure 7ffff79245e0 at ice-9/eval.scm:336:1?> ?)
      In ice-9/eval.scm:
         245:16  2 (_ #(#(#<directory (guix build utils) 7ffff779f320>) # ?))
      In ice-9/boot-9.scm:
        1982:24  1 (_ _)
      In unknown file:
                 0 (stat "./???.scm" #<undefined>)

      ERROR: In procedure stat:
      In procedure stat: No such file or directory: "./???.scm"
      builder for `/gnu/store/dxg87135zcd6a1c92dlrkyvxlbhfwfld-module-import-compiled.drv' failed with exit code 1

      file-union:
      (. .. ?)

      imported-modules:
      (. .. 猫.scm)

      local-file:
      (. .. 猫.scm)

      plain-file:
      猫

      mixed-text-file:
      猫猫猫

      directory-union:
      (. .. 猫.scm)

Which I think you will agree is far from optimal.  After my fix the output
changes to:

      + '[' -f guix.scm ']'
      + '[' -f gnu.scm ']'
      + cat
      + mkdir -p dir-with-utf8-file
      + cp 猫.scm dir-with-utf8-file/
      + cat
      + guix shell -CWN -D guix glibc-locales -- env LANG=C.UTF-8 ./pre-inst-env guix repl -- ./repro.scm

      computed-file:
      猫

      program-file:
      #!/gnu/store/8kbmn359jqkgsbqgqxnmiryvd9ynz8w7-guile-3.0.9/bin/guile --no-auto-compile
      !#
      ((λ _ (display "猫")))

      scheme-file:
      ((λ _ (display "猫")))

      text-file*:
      猫猫猫

      compiled-modules:
      (. .. 猫.go)

      file-union:
      (. .. 猫)

      imported-modules:
      (. .. 猫.scm)

      local-file:
      (. .. 猫.scm)

      plain-file:
      猫

      mixed-text-file:
      猫猫猫

      directory-union:
      (. .. 猫.scm)

Which is actually what the user would expect.

I also added missing arguments to the documentation.

* guix/gexp.scm (computed-file):  Set LANG to C.UTF-8 by default.
(compiled-modules): Try to `setlocale'.
(gexp->script), (gexp->file): New `locale' argument defaulting to C.UTF-8.
(text-file*): Set output port encoding to UTF-8.
* doc/guix.texi (G-Expressions)[computed-file]: Document the changes.  Use
@var.  Document #:guile.
[gexp->script]: Document #:locale.  Fix default value for #:target.
[gexp->file]: Document #:locale, #:system and #:target.

Change-Id: Ib323b51af88a588b780ff48ddd04db8be7c729fb
---
 doc/guix.texi | 11 +++++++----
 guix/gexp.scm | 24 ++++++++++++++++++------
 2 files changed, 25 insertions(+), 10 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 52e36e4354..683ba2f44b 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -12270,7 +12270,9 @@ G-Expressions
 This is the declarative counterpart of @code{text-file}.
 @end deffn
 
-@deffn {Procedure} computed-file name gexp [#:local-build? #t] [#:options '()]
+@deffn {Procedure} computed-file @var{name} @var{gexp} @
+  [#:local-build? #t] [#:guile] @
+  [#:options '(#:env-vars (("LANG" . "C.UTF-8")))]
 Return an object representing the store item @var{name}, a file or
 directory computed by @var{gexp}.  When @var{local-build?} is true (the
 default), the derivation is built locally.  @var{options} is a list of
@@ -12281,7 +12283,7 @@ G-Expressions
 
 @deffn {Monadic Procedure} gexp->script @var{name} @var{exp} @
   [#:guile (default-guile)] [#:module-path %load-path] @
-  [#:system (%current-system)] [#:target #f]
+  [#:system (%current-system)] [#:target 'current] [#:locale "C.UTF-8"]
 Return an executable script @var{name} that runs @var{exp} using
 @var{guile}, with @var{exp}'s imported modules in its search path.
 Look up @var{exp}'s modules in @var{module-path}.
@@ -12318,8 +12320,9 @@ G-Expressions
 
 @deffn {Monadic Procedure} gexp->file @var{name} @var{exp} @
             [#:set-load-path? #t] [#:module-path %load-path] @
-            [#:splice? #f] @
-            [#:guile (default-guile)]
+            [#:splice? #f] [#:guile (default-guile)] @
+            [#:system (%current-system)] [#:target 'current] @
+            [#:locale "C.UTF-8"]
 Return a derivation that builds a file @var{name} containing @var{exp}.
 When @var{splice?}  is true, @var{exp} is considered to be a list of
 expressions that will be spliced in the resulting file.
diff --git a/guix/gexp.scm b/guix/gexp.scm
index e44aea6420..c8aba91779 100644
--- a/guix/gexp.scm
+++ b/guix/gexp.scm
@@ -597,7 +597,10 @@ (define-record-type <computed-file>
   (options    computed-file-options))             ;list of arguments
 
 (define* (computed-file name gexp
-                        #:key guile (local-build? #t) (options '()))
+                        #:key
+                        guile
+                        (local-build? #t)
+                        (options '(#:env-vars (("LANG" . "C.UTF-8")))))
   "Return an object representing the store item NAME, a file or directory
 computed by GEXP.  When LOCAL-BUILD? is #t (the default), it ensures the
 corresponding derivation is built locally.  OPTIONS may be used to pass
@@ -1700,6 +1703,9 @@ (define* (compiled-modules modules
                        (system base target)
                        (system base compile))
 
+          ;; Best effort.  The locale is not installed in all contexts.
+          (false-if-exception (setlocale LC_ALL "C.UTF-8"))
+
           (define modules
             (getenv "modules"))
 
@@ -1990,7 +1996,8 @@ (define* (gexp->script name exp
                        #:key (guile (default-guile))
                        (module-path %load-path)
                        (system (%current-system))
-                       (target 'current))
+                       (target 'current)
+                       (locale "C.UTF-8"))
   "Return an executable script NAME that runs EXP using GUILE, with EXP's
 imported modules in its search path.  Look up EXP's modules in MODULE-PATH."
   (mlet* %store-monad ((target (if (eq? target 'current)
@@ -2033,7 +2040,8 @@ (define* (gexp->script name exp
                       ;; These derivations are not worth offloading or
                       ;; substituting.
                       #:local-build? #t
-                      #:substitutable? #f)))
+                      #:substitutable? #f
+                      #:env-vars `(("LANG" . ,locale)))))
 
 (define* (gexp->file name exp #:key
                      (guile (default-guile))
@@ -2041,7 +2049,8 @@ (define* (gexp->file name exp #:key
                      (module-path %load-path)
                      (splice? #f)
                      (system (%current-system))
-                     (target 'current))
+                     (target 'current)
+                     (locale "C.UTF-8"))
   "Return a derivation that builds a file NAME containing EXP.  When SPLICE?
 is true, EXP is considered to be a list of expressions that will be spliced in
 the resulting file.
@@ -2081,7 +2090,8 @@ (define* (gexp->file name exp #:key
                           #:local-build? #t
                           #:substitutable? #f
                           #:system system
-                          #:target target)
+                          #:target target
+                          #:env-vars `(("LANG" . ,locale)))
         (gexp->derivation name
                           (gexp
                            (call-with-output-file (ungexp output)
@@ -2098,7 +2108,8 @@ (define* (gexp->file name exp #:key
                           #:local-build? #t
                           #:substitutable? #f
                           #:system system
-                          #:target target))))
+                          #:target target
+                          #:env-vars `(("LANG" . ,locale))))))
 
 (define* (text-file* name #:rest text)
   "Return as a monadic value a derivation that builds a text file containing
@@ -2108,6 +2119,7 @@ (define* (text-file* name #:rest text)
   (define builder
     (gexp (call-with-output-file (ungexp output "out")
             (lambda (port)
+              (set-port-encoding! port "UTF-8")
               (display (string-append (ungexp-splicing text)) port)))))
 
   (gexp->derivation name builder
-- 
2.46.0





Message sent:


Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Tomas Volf <~@wolfsden.cz>
Subject: bug#73660: Acknowledgement ([PATCH] gexp: Improve support of
 Unicode characters.)
Message-ID: <handler.73660.B.17282293861124.ack <at> debbugs.gnu.org>
References: <a0c437bad0b83665734831f7de7fc7e1f6972128.1728229346.git.~@wolfsden.cz>
X-Gnu-PR-Message: ack 73660
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 73660 <at> debbugs.gnu.org
Date: Sun, 06 Oct 2024 15:44:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  Christopher Baines <guix@HIDDEN>, Florian Pelz <pelzflorian@pelzflor=
ian.de>, Josselin Poiret <dev@HIDDEN>, Ludovic Court=C3=A8s <ludo@gnu.=
org>, Mathieu Othacehe <othacehe@HIDDEN>, Maxim Cournoyer <maxim.cournoyer=
@gmail.com>, Simon Tournier <zimon.toutoune@HIDDEN>, Tobias Geerinckx-Ri=
ce <me@HIDDEN>
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 73660 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
73660: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D73660
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems


Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#73660] [PATCH] gexp: Improve support of Unicode characters.
Resent-From: Tomas Volf <~@wolfsden.cz>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 23 Oct 2024 00:15:02 +0000
Resent-Message-ID: <handler.73660.B73660.1729642448941 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 73660
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 73660 <at> debbugs.gnu.org
Received: via spool by 73660-submit <at> debbugs.gnu.org id=B73660.1729642448941
          (code B ref 73660); Wed, 23 Oct 2024 00:15:02 +0000
Received: (at 73660) by debbugs.gnu.org; 23 Oct 2024 00:14:08 +0000
Received: from localhost ([127.0.0.1]:58049 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1t3P0q-0000F6-Eh
	for submit <at> debbugs.gnu.org; Tue, 22 Oct 2024 20:14:08 -0400
Received: from wolfsden.cz ([37.205.8.62]:47208)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <~@wolfsden.cz>) id 1t3P0n-0000Ew-83
 for 73660 <at> debbugs.gnu.org; Tue, 22 Oct 2024 20:14:06 -0400
Received: by wolfsden.cz (Postfix, from userid 104)
 id 9F234310A0A; Wed, 23 Oct 2024 00:13:35 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
 t=1729642415; bh=oFoktkh5htHFxbPNSZ0+grRJSNXJtW27uzYoMdkmhQU=;
 h=From:To:Subject:In-Reply-To:References:Date;
 b=aOp63xM6ntavxfMQmbQjqwRZICPdKS+N+087OL0kGmk9EVwlmXeTQVTh7AEG0hGXj
 JEfs9nD4QbDHPH7HC1kF/Gx4Wgi9RLNYR9yXQcdmpcoumGJUU1YwzCMMj2qvVoxAZy
 Yx+LFwjOD0w/EoIUhlN2H+RW8oFHWoLCZ/8LafMbKJ+pwM6NHKgRT4POzBJxtWoWLh
 OoEcHXUZ2Ne/qqW91MEWjTs5/KXzVvReihec+a809yxhQBgdjE9uTnO//rCffQLSK9
 u/gXppW9axtJ+6yIGuGsKXTXaCS8ahqvPoPVxFTJLHsoWmSpB8vlSBGYsZt35NkJDl
 gqcBDC/HLkRkPgByMOEU9p/PACtZSFnqjYmKB2DXT1IiKULYdsdOKRrm3hnGwLM2jx
 W5s0pYiQDl8ub4Q2NLIr+gIVga/Xda9uOLu6wzEWxS5KoRtG+MlXr9lrIc5puExX5E
 ICDlOk2aOz6NRM2GGyJkHdgf5Mw4E+JPymCtCJDkBLNPUCoNKxmCKodkLwdgw1c8Bt
 M4lfnmkOPjJjhFYt6dC3hPu3RcxINTmBMLzgbf+JKSfHz1JS7wS3a/JwVWHSeRo774
 EjRsjTQ8OHwbV5YVGhazhTXaACcu057Us41MExTvIuMxyFm2TcLLsI5mrfKzY0IYFk
 Uon1T2oA3bfJ/FJAPuLqWFzo=
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden
X-Spam-Level: 
X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED
 autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (unknown [128.0.188.242])
 by wolfsden.cz (Postfix) with ESMTPSA id 531DB311099
 for <73660 <at> debbugs.gnu.org>; Wed, 23 Oct 2024 00:13:35 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
 t=1729642415; bh=oFoktkh5htHFxbPNSZ0+grRJSNXJtW27uzYoMdkmhQU=;
 h=From:To:Subject:In-Reply-To:References:Date;
 b=aOp63xM6ntavxfMQmbQjqwRZICPdKS+N+087OL0kGmk9EVwlmXeTQVTh7AEG0hGXj
 JEfs9nD4QbDHPH7HC1kF/Gx4Wgi9RLNYR9yXQcdmpcoumGJUU1YwzCMMj2qvVoxAZy
 Yx+LFwjOD0w/EoIUhlN2H+RW8oFHWoLCZ/8LafMbKJ+pwM6NHKgRT4POzBJxtWoWLh
 OoEcHXUZ2Ne/qqW91MEWjTs5/KXzVvReihec+a809yxhQBgdjE9uTnO//rCffQLSK9
 u/gXppW9axtJ+6yIGuGsKXTXaCS8ahqvPoPVxFTJLHsoWmSpB8vlSBGYsZt35NkJDl
 gqcBDC/HLkRkPgByMOEU9p/PACtZSFnqjYmKB2DXT1IiKULYdsdOKRrm3hnGwLM2jx
 W5s0pYiQDl8ub4Q2NLIr+gIVga/Xda9uOLu6wzEWxS5KoRtG+MlXr9lrIc5puExX5E
 ICDlOk2aOz6NRM2GGyJkHdgf5Mw4E+JPymCtCJDkBLNPUCoNKxmCKodkLwdgw1c8Bt
 M4lfnmkOPjJjhFYt6dC3hPu3RcxINTmBMLzgbf+JKSfHz1JS7wS3a/JwVWHSeRo774
 EjRsjTQ8OHwbV5YVGhazhTXaACcu057Us41MExTvIuMxyFm2TcLLsI5mrfKzY0IYFk
 Uon1T2oA3bfJ/FJAPuLqWFzo=
From: Tomas Volf <~@wolfsden.cz>
In-Reply-To: <a0c437bad0b83665734831f7de7fc7e1f6972128.1728229346.git.~@wolfsden.cz>
 (Tomas Volf's message of "Sun, 6 Oct 2024 17:42:26 +0200")
References: <a0c437bad0b83665734831f7de7fc7e1f6972128.1728229346.git.~@wolfsden.cz>
Date: Wed, 23 Oct 2024 02:13:33 +0200
Message-ID: <87ttd365hu.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello,

any opinion regarding this patch?  I think it prevents whole class of
annoying bugs, and some forms already had support for it, this just
extend it to all forms.

Have a nice day,
Tomas




Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#73660] [PATCH] gexp: Improve support of Unicode characters.
Resent-From: Janneke Nieuwenhuizen <janneke@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 10 Jan 2025 16:01:02 +0000
Resent-Message-ID: <handler.73660.B73660.17365248256243 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 73660
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Tomas Volf <~@wolfsden.cz>
Cc: 73660 <at> debbugs.gnu.org
Received: via spool by 73660-submit <at> debbugs.gnu.org id=B73660.17365248256243
          (code B ref 73660); Fri, 10 Jan 2025 16:01:02 +0000
Received: (at 73660) by debbugs.gnu.org; 10 Jan 2025 16:00:25 +0000
Received: from localhost ([127.0.0.1]:58472 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tWHQv-0001cc-6B
	for submit <at> debbugs.gnu.org; Fri, 10 Jan 2025 11:00:25 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:54008)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <janneke@HIDDEN>) id 1tWHQs-0001cO-BX
 for 73660 <at> debbugs.gnu.org; Fri, 10 Jan 2025 11:00:23 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <janneke@HIDDEN>)
 id 1tWHQl-00045q-CF; Fri, 10 Jan 2025 11:00:15 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=Xkiy+BDmiElIWSltqJ3HO+tC/J77MwMqKWSzbiqfC4I=; b=E/iWXC9ZIAcnOBkdH+ot
 qtuFnXJmKLVHsjvF4jFswDw7sCDx2zvycxAYZqMGP52743xXQfN90O97Xv61SVS4l0dU1iB5fGjzs
 CXmQt1b6JR50/mOmiK8xDaoiK01rCG2y91WjAhvv0F3BrZmKbjv7ZdLPAPJ5eYidTk3O6NvFsJHtu
 0DE90aB8lyBMvNXgKjmncNaiziJ4SwJCwUFsZhs+izaUtSP86/Psv+j35M8ELrIX6Weo9EAsHwiMu
 Vzbkc2xAFWACRpO96ggoDFrTaOOixlf+nchxXNn9P6PsZfrxcL5VHgnaZ4SfM9tSrn84v9FT8gaF5
 BBoT5yRdv2AhWg==;
From: Janneke Nieuwenhuizen <janneke@HIDDEN>
In-Reply-To: <87ttd365hu.fsf@HIDDEN> (Tomas Volf's message of "Wed, 23
 Oct 2024 02:13:33 +0200")
References: <a0c437bad0b83665734831f7de7fc7e1f6972128.1728229346.git.~@wolfsden.cz>
 <87ttd365hu.fsf@HIDDEN>
Date: Fri, 10 Jan 2025 17:00:00 +0100
Message-ID: <87v7ummzgf.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Tomas Volf writes:

Hi,

> any opinion regarding this patch?  I think it prevents whole class of
> annoying bugs, and some forms already had support for it, this just
> extend it to all forms.

While I don't feel qualified to LGTM this patch, it makes sense to me.

As discussed on IRC <https://logs.guix.gnu.org/guix/2025-01-05.log#134213>
I added the patch to core-packages-team, but also reverted it to avoid a
world rebuild.

Just now I pushed a newlyrebased core-packages-team with the patch
in action, see <https://ci.guix.gnu.org/jobset/core-packages-team>.

Would you like to also keep an eye out for how that works?

Greetings,
Janneke

--=20
Janneke Nieuwenhuizen <janneke@HIDDEN>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar=C2=AE https://AvatarAcade=
my.com




Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#73660] [PATCH] gexp: Improve support of Unicode characters.
Resent-From: Tomas Volf <~@wolfsden.cz>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 11 Jan 2025 00:43:01 +0000
Resent-Message-ID: <handler.73660.B73660.17365561715403 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 73660
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Janneke Nieuwenhuizen <janneke@HIDDEN>
Cc: 73660 <at> debbugs.gnu.org
Received: via spool by 73660-submit <at> debbugs.gnu.org id=B73660.17365561715403
          (code B ref 73660); Sat, 11 Jan 2025 00:43:01 +0000
Received: (at 73660) by debbugs.gnu.org; 11 Jan 2025 00:42:51 +0000
Received: from localhost ([127.0.0.1]:40263 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tWPaU-0001P4-IX
	for submit <at> debbugs.gnu.org; Fri, 10 Jan 2025 19:42:50 -0500
Received: from wolfsden.cz ([37.205.8.62]:42376)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1tWPaQ-0001Os-Jt
 for 73660 <at> debbugs.gnu.org; Fri, 10 Jan 2025 19:42:48 -0500
Received: by wolfsden.cz (Postfix, from userid 104)
 id 9369831987F; Sat, 11 Jan 2025 00:42:45 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
 t=1736556165; bh=+ZYHKn55qRcAkT+U3OoZ54Bh9svNP6pPlKNLijeuUw4=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date;
 b=gtmdM+6tHaj/sl44XXKqsZPzhYeZufbWzN4FaAG3QEmq6bwHW6GJOWJNHITZXSEgL
 Jh5K6Mnzih37jobGuAnR6aRcL184HKRkI1GPw/XO+8G7UBf6Pm9EUKXagV8ncq1UbH
 wnVin/dDpxBF99VMvRBJLZlfitq96O6CTlWoI0mYpohx4OxG98dwCz77LZ5PimMK8U
 ai0lpYSnCi79Ulo9qTr2IWGyIYXHVZ1FNa3KepLtTeDX3p+cB/eQSPoPVw+eyMerBa
 AkfwuWwwsb3XxZuYMkSCNxH4d5s1sXHk+1/UvHaCGMoL2vPUsY23vZGBAqHPT4tjuU
 rg+7mgXFgPV1SF6nVqD+cWEjLEgenu9YSEd9kJ8Wp1fv0XBEYMC6qElUbESUXJqMIA
 OyluQYbpg4HRHuXQ0fklxGPcSUi5pn7Jcc6g4ACXNJsyCKqan3rmLnj9S2jZlKapBA
 AJp2/pEmI9Kki56xUTlGSTXlvMhVJUsi8HSRoNAGM144Jj4zh75bEBu1GLN/ROGN2h
 J/56oZiUQ1If5YvXUUqkXpCjVRZFKcKi8HWmHay2ZS2u3wBEBiMplU0pw7SnNTnWST
 ApHCIfJUHLAeHC1m6Biv9E1YIKnxXXmYhyAllhsGhM7vJzP0Z+0U7OXb8u4f3cKlKp
 hsgq4zAqlHmf1G+WcxqoOQq8=
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden
X-Spam-Level: 
X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED
 autolearn=unavailable autolearn_force=no version=3.4.6
Received: from localhost (unknown [128.0.188.242])
 by wolfsden.cz (Postfix) with ESMTPSA id 7BDC831A0A7;
 Sat, 11 Jan 2025 00:42:44 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
 t=1736556164; bh=+ZYHKn55qRcAkT+U3OoZ54Bh9svNP6pPlKNLijeuUw4=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date;
 b=nBJz+KYwAdtCRy6IxxGBVPo6kYNmDIWbQrtAijYA0p68wjbwMkQJMF8+Kcc0ChglP
 wZR4pD891BN/onw4z9lXf1gWc7kosN8ZjNSw4rFsbFOoH2xfYx5EkenMnxk7Jy2nDH
 KdkpJkwAc+qPJrxLeBoN4hBHYdoPV7Y8ov2S0ok5xndaW1uMa+LNyYHu4Ol5VrAb0S
 S8Sd3CUidI58he5EHXaiWDFlfHCF3FRy6pI6OLm8AGDH2N+vz4q85uwonrwqIfMvxV
 ea/BTBR/Jgx3EWGWMO8xH1JZvDxeUgtXnpCyq7FRpWVqpR/Cj2AwJYC7X+ipSt/A2g
 8JgOwssy4LYTD14464mV6g/CBqGM2t06OVp0OPkVtm3Izm/K0sfUzpVDjo4sTbSwtL
 pqKxu5Rpeur05QsxIOmYe+MQnWlOvVjFGACHD7bYS7Uysx97npj0gRReWHwSTmrEW8
 2vpRImSaXSb9aR38a+b77sCMtU9oz7wia7l1RAkbhsdtJ/AIWW989vfto9qieLCzP3
 MsIRSjqt6CRdlkutHkFfXwHTo9lkZ/9id+OuB3hi5AYTOgf9vqA1YCxFcHJamQmbtI
 iWl5ZWPLywxVmegKLRikYrUo6JK4FTskaNlQZvH8yyLpWLdHh9PQ5Fa6tSlf92E2Yp
 3Qc4fjXi4REj3hfR7OJU3JuQ=
From: Tomas Volf <~@wolfsden.cz>
In-Reply-To: <87v7ummzgf.fsf@HIDDEN> (Janneke Nieuwenhuizen's message of
 "Fri, 10 Jan 2025 17:00:00 +0100")
References: <a0c437bad0b83665734831f7de7fc7e1f6972128.1728229346.git.~@wolfsden.cz>
 <87ttd365hu.fsf@HIDDEN> <87v7ummzgf.fsf@HIDDEN>
Date: Sat, 11 Jan 2025 01:42:43 +0100
Message-ID: <87ikqmp4e4.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Janneke Nieuwenhuizen <janneke@HIDDEN> writes:

> Tomas Volf writes:
>
> Hi,
>
>> any opinion regarding this patch?  I think it prevents whole class of
>> annoying bugs, and some forms already had support for it, this just
>> extend it to all forms.
>
> While I don't feel qualified to LGTM this patch, it makes sense to me.
>
> As discussed on IRC <https://logs.guix.gnu.org/guix/2025-01-05.log#134213>
> I added the patch to core-packages-team, but also reverted it to avoid a
> world rebuild.

Re-reading the IRC log I have noticed I forgot to say my thanks, so,
thank you :)

>
> Just now I pushed a newlyrebased core-packages-team with the patch
> in action, see <https://ci.guix.gnu.org/jobset/core-packages-team>.
>
> Would you like to also keep an eye out for how that works?

I can take a look from time to time (seems to still be building).  Let
us hope nothing burns down.  I *think* it should not really break
anything, but who knows, Guix is complex beast and I am not that smart.

Have a nice weekend,
Tomas

=2D-=20
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJCBAEBCgAsFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmeBvoQOHH5Ad29sZnNk
ZW4uY3oACgkQL7/ufbZ/wandbQ/9FTixcveZyrU01FUoc8LwZ46W0TB8su8V0kOw
Q0lsoQBzyCpKw07S6uvccFNf5qgWpRSwTUOT3nYxnOtya8sya3h0znHFqClrdUBl
MwB4sHGKkA3UR2wpehHon6jEe9wKy6pmbDmgSNcCnXl7C+oeLmu1sNUxG1Jg8ZOb
adye9jOfB4oWIVGpQkwKtIseKFHJZ7PepCwjD9tKonugGIYhzW/nvl57oYDPyGws
Mh+bMy5oa3YA2CFeeDf98VUqifYBc0oglXO30LyRWP6y3C3UKinJNQXolFZTqL/u
7KGkdIBP97XlF22ifnz+fqptq5F68kQZxSyl8m4SaBNH7L5VZzznGj4szXFI/r89
71cdBPNPqmYWRAiU/O3PfAonBmZPEAOzxcYSLpXL0wbJ/+ZZ4H6ftXv3KhBSD+R/
cM4D5cWtwGpcy1ySLeQ2p27RXKwyd4Odm3cwIIp3bQJdws132CGKKt+TYw8zJaCa
z0mL1FI3OKICsh6ueSST6gEacRNGqpryE4GmVCRxLby86QTj0uoJwYI8m5emA/Ik
ajDFBS55mmhEQ5OCe3LcqqPVP7MC3cJM6B1jtlzgrPolvnbe5zu0jeQWI5ZyTNeK
6aiIIL7wfx3Az4t5NRp83f6k6QJU8PCLPqaukT9tGYdYp+ZeqilkFN73VwVSw+Ta
LlmWy9M=
=daNr
-----END PGP SIGNATURE-----
--=-=-=--




Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#73660] [PATCH] gexp: Improve support of Unicode characters.
Resent-From: Tomas Volf <~@wolfsden.cz>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 11 Jan 2025 17:08:02 +0000
Resent-Message-ID: <handler.73660.B73660.173661523132690 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 73660
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Janneke Nieuwenhuizen <janneke@HIDDEN>
Cc: 73660 <at> debbugs.gnu.org
Received: via spool by 73660-submit <at> debbugs.gnu.org id=B73660.173661523132690
          (code B ref 73660); Sat, 11 Jan 2025 17:08:02 +0000
Received: (at 73660) by debbugs.gnu.org; 11 Jan 2025 17:07:11 +0000
Received: from localhost ([127.0.0.1]:44647 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tWex5-0008VC-AY
	for submit <at> debbugs.gnu.org; Sat, 11 Jan 2025 12:07:11 -0500
Received: from wolfsden.cz ([37.205.8.62]:41874)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1tWex2-0008V0-H9
 for 73660 <at> debbugs.gnu.org; Sat, 11 Jan 2025 12:07:09 -0500
Received: by wolfsden.cz (Postfix, from userid 104)
 id 61D95338A0F; Sat, 11 Jan 2025 17:07:06 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
 t=1736615226; bh=xBGkdOKIFUl7pHheib5olTRevsc7N6dTHP0T6Cdw2bc=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date;
 b=aNvSs3GDdheuNzmDU7ORf0LGXsstzAlL0px+lLGQS4WCdZ0QP2s8r6j5aPWOUhr+o
 q0Lm1FuSQChJSrLAgA13/4bjxMS1X2NYhwZDrpxOA4eE1xBl0pfOvl6/1qaACNWqD3
 B2p+2KUB60MlaYOOTa72h7E/ixo7R3POR5CM1tKL6GwDfi0zZdHgsjJm6qH87RQqX0
 EfM/3vb9hmL0y3KCBAV2PbIZ28C3oArspC6/5osH5kNPP60PBieMDehohM9cNluF+o
 frWHoicjy2AVJUUT2M0fY8kAhs28i8PGZLIhq4fGTjDojpJgjUNOG/T32blAimBOal
 3gexX+Tw8AVJ694KnbYOz5RFdGYsIP7tn/StyxtK7aBWP2QetrRX+s1BACKXmo4Sp3
 eEDsLjYNQlbCglCdWCGNRhho0rA2AmL/7OWWZngNvO7blhvu2tRc6Lfp/ICy3phmRo
 dkQwfqNs90ATblCJAaAgSlC/3KR2ACDTA0nrAyOT3Ho0k5WQyp1nBQUgHVWBHpi9eP
 Un90OPDLwh9uBEPq0GYzLqHB5s648mnt+UH/be2hJirGDM6pZzd6RLKYHB6ulK5Xi7
 Fi9ZGYSvBGmrx46s4eo92FTIHlE+A6R63N433DO61bkhupw4PRZ9WhR2YM8/Pcs6tq
 ZxycpBE86f2yh9yz3Ll47P4g=
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden
X-Spam-Level: 
X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED
 autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (unknown [128.0.188.242])
 by wolfsden.cz (Postfix) with ESMTPSA id 8AF823395AC;
 Sat, 11 Jan 2025 17:07:05 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
 t=1736615225; bh=xBGkdOKIFUl7pHheib5olTRevsc7N6dTHP0T6Cdw2bc=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date;
 b=LyjxsT55ApxG7lW444MNAPF1TNCIPS1UmBgnWXB2DvJmiG3DOBEK3xOzOn4LE7K5P
 AvzIEMX3u7UMT77cwetFzyOtuKgTbwB3gjrQ+6dD6mR+lLsMmzf9DJlPi2Rf2Kwep2
 Jsgj33yvKnfsHpFuiCYGSqY0IUXN5x2cvYnjkSwuIJp3zVS3x1BP1NAGaNUI37Jfna
 1e2zYgkaVUBnuC8wjVI4qj0j35BSOMOy1b5JFw8NgEc5MDrMu22ApcDGzqPrTcsLJd
 ROOe3KMGDSBO4rpykgd8f0z16D3vCL+X8JWRLdiJ2DI2uOeutXwRRIljpHxE0VWxhj
 hKb1Rd3ejw1WXJ58RLZRUGmp1BMmXdKVVEfETKRHMYbgFCXGMga8qzUNPstGyEoF80
 9Xjlv2hY+R/MtxMOTunZyRdX/wAjTaxwuvahxE68mmcveioYhAViZT2aAN1vzhu4i6
 8lX2s7p0jEC4WCG6Z/0NNUrG+ssmKkyj4m+9CkX6UmORdlv2psVBruSiH9Tt8smuzI
 ZixyM9bcpAnCAkcQvTBh1N9gfrPyrEya7UC4mHY8yfhfbXygXA5as9MBdxyYLKMyPI
 nhciAx83xdVOuCOXX/vm85pCu218xHH2oDOjDjr8l6joYNps9yRnlkcLKnNRpVtuvn
 RuweUZ9gYchhJlfu6m5MDpUc=
From: Tomas Volf <~@wolfsden.cz>
In-Reply-To: <87v7ummzgf.fsf@HIDDEN> (Janneke Nieuwenhuizen's message of
 "Fri, 10 Jan 2025 17:00:00 +0100")
References: <a0c437bad0b83665734831f7de7fc7e1f6972128.1728229346.git.~@wolfsden.cz>
 <87ttd365hu.fsf@HIDDEN> <87v7ummzgf.fsf@HIDDEN>
Date: Sat, 11 Jan 2025 18:07:05 +0100
Message-ID: <875xmlp9dy.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Janneke Nieuwenhuizen <janneke@HIDDEN> writes:

> Would you like to also keep an eye out for how that works?

It seems the evaluation failed, however I have no idea if that is due to
my changes or not.  The first issue I see in the log seems to be:

=2D-8<---------------cut here---------------start------------->8---
building of `/gnu/store/5qizz7ba86rd979xspsw3vi2xpg6gq7b-glibc-headers-mesb=
oot-2.16.0.drv' timed out after 3600 seconds of silence
=2D-8<---------------cut here---------------end--------------->8---

For what it is worth, it fails to me locally as well, but with a
different error:

=2D-8<---------------cut here---------------start------------->8---
build of /gnu/store/n45z6cfa9i3jdh07q1ib6pcbll8j6jn7-libstdc++-boot0-4.9.4.=
drv failed
View build log at '/var/log/guix/drvs/n4/5z6cfa9i3jdh07q1ib6pcbll8j6jn7-lib=
stdc++-boot0-4.9.4.drv.gz'.
cannot build derivation `/gnu/store/gai3hg9c8qb89qlz8fwrgpscmf74g6c8-gcc-cr=
oss-boot0-14.2.0.drv': 1 dependencies couldn't be built
cannot build derivation `/gnu/store/f2di3rzlyqa2xsby7z197wsldvqixq0l-gcc-cr=
oss-boot0-wrapped-14.2.0.drv': 1 dependencies couldn't be built
=2D-8<---------------cut here---------------end--------------->8---

Which, looking into the log leads to:

=2D-8<---------------cut here---------------start------------->8---
starting phase `patch-tzdb.cc'
error: in phase 'patch-tzdb.cc': uncaught exception:
system-error "mkstemp!" "~A" ("No such file or directory") (2)=20
phase `patch-tzdb.cc' failed after 0.0 seconds
=2D-8<---------------cut here---------------end--------------->8---

I am not sure this is caused by my changes.  When I revert the commit:

=2D-8<---------------cut here---------------start------------->8---
$ git -C guix-proper log -1
commit 178c8707fc795b7612ed493523a2f4ef5a71966d (HEAD -> xx)
Author: Linux User
Date:   Sat Jan 11 16:56:00 2025 +0000

    Revert "gexp: Improve support of Unicode characters."
=20=20=20=20
    This reverts commit 3532efb0167dae540d9b968b191aa76c4ec79212.
=2D-8<---------------cut here---------------end--------------->8---

It still fails with the same error.

Any ideas?

Tomas

=2D-=20
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJCBAEBCgAsFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmeCpTkOHH5Ad29sZnNk
ZW4uY3oACgkQL7/ufbZ/wanLtBAAsU8HjVCEDLFI9RpKaEr8bJSTRITWqzd2jq8e
xTFGShf4XDT+pTwLBGbsIqgworHIxIIHN+0zMejCiUXHLSu8WoqMdXaNTCFT/8dG
NAnSaNbp/oGUVYpDwumhSb3mfAZ8fN8AxssSCHan728Lo0r0cOlJ8ZKNx6QLXey5
BCuITcmhn6RMhJRj40u5YI5XDA9RuOKrkxhoo0idGX5MvaPDdncCCTJxTulAkJS0
GvUvlCSR2KwALwbUu4fY/0iOL9TO2jhNMk5Z4ft1fmJb500KmjlFCyUqAG2jCguz
FM54jdRzAkMsHoiWNoJyxfv+NogQG3oFDO6bbSbcCz/0vIN2OP0jiLsRWIzOgKO/
Af1CxAfL6RQyBdm9URY5yRQoXmvqbzKb1K5aeF9Pi0EKWH9bIjP7GGC/N6gpkt7S
GDjmUrXOSg7iH8X4YGaFyfM0taeCC9NSgBtLW/gGKsUBOk6GcQt8eXJErkJCUzOj
1kyyyfDMStxrr8jsE2D4Ta9qz771Xfux74HnU4PC4zUtaCmbB4QUUYmL+tHOFUUT
vqrvoCAXnnO6TzomcKFj6uoo07HuUsd7VZee6tm/LdOGMK7M5L6jQZNmAoB2Su67
wO/bIHlHq4HAC3gk0BztAO6ykOVZYmmj6x6MWanc76HhC3qu49BqUMgs4QQx3gi6
CtZt+5s=
=Iq5M
-----END PGP SIGNATURE-----
--=-=-=--




Message sent to guix-patches@HIDDEN:


X-Loop: help-debbugs@HIDDEN
Subject: [bug#73660] [PATCH] gexp: Improve support of Unicode characters.
Resent-From: Janneke Nieuwenhuizen <janneke@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 11 Jan 2025 18:11:01 +0000
Resent-Message-ID: <handler.73660.B73660.173661901313760 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 73660
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Tomas Volf <~@wolfsden.cz>
Cc: 73660 <at> debbugs.gnu.org
Received: via spool by 73660-submit <at> debbugs.gnu.org id=B73660.173661901313760
          (code B ref 73660); Sat, 11 Jan 2025 18:11:01 +0000
Received: (at 73660) by debbugs.gnu.org; 11 Jan 2025 18:10:13 +0000
Received: from localhost ([127.0.0.1]:44744 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tWfw4-0003Zp-Pv
	for submit <at> debbugs.gnu.org; Sat, 11 Jan 2025 13:10:13 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:55086)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <janneke@HIDDEN>) id 1tWfw1-0003VI-Ru
 for 73660 <at> debbugs.gnu.org; Sat, 11 Jan 2025 13:10:11 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <janneke@HIDDEN>)
 id 1tWfvu-00009C-6c; Sat, 11 Jan 2025 13:10:02 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=yUly/cODHqAHw+ObY7Bej52Tsfj8IlnQq1NbIkJh2Zo=; b=otj79orEVVzpXHUqzilO
 sbIDh96iNc3QVRc+SLInr35qWhlfG9MQtRGi8fV5EDW2wlFJSR6K9e8hPYq4ewAOFTFjEzBMZQDZI
 bt+NT/R4srENBOG1QLpTQGx/pp6lxdLnFcYsu2iDA/VKX0qWmx2xgYhT/FRkCVH5am79B3oNXp/ro
 uqpWdd1Lw/VtOcD6PevfZ+l1/ZhHjGDusWlLhd0ueTgVNzR/mFSSGmL7msfo7nmTu19bqzRuS2oT2
 lFJROC5NEtD3P4UFTFG+f8vuVuQ5rdB0YJllnttZq4mtbNJFp8WCar07WgoEWMRZwlG3tnuHIL1R7
 9MvvU9fiw4W4xA==;
From: Janneke Nieuwenhuizen <janneke@HIDDEN>
In-Reply-To: <875xmlp9dy.fsf@HIDDEN> (Tomas Volf's message of "Sat, 11
 Jan 2025 18:07:05 +0100")
Organization: AvatarAcademy.nl
References: <a0c437bad0b83665734831f7de7fc7e1f6972128.1728229346.git.~@wolfsden.cz>
 <87ttd365hu.fsf@HIDDEN> <87v7ummzgf.fsf@HIDDEN>
 <875xmlp9dy.fsf@HIDDEN>
X-Url: http://AvatarAcademy.nl
Date: Sat, 11 Jan 2025 19:09:55 +0100
Message-ID: <878qrhmdcc.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Tomas Volf writes:

Hello Tomas,

> Janneke Nieuwenhuizen <janneke@HIDDEN> writes:
>
>> Would you like to also keep an eye out for how that works?
>
> It seems the evaluation failed, however I have no idea if that is due to
> my changes or not.  The first issue I see in the log seems to be:
>
> building of
> `/gnu/store/5qizz7ba86rd979xspsw3vi2xpg6gq7b-glibc-headers-mesboot-2.16.0=
.drv'
> timed out after 3600 seconds of silence

Ah.  I wondered why there was a big red cross instead of a lot of nice
green builds...

> For what it is worth, it fails to me locally as well, but with a
> different error:
>
> build of /gnu/store/n45z6cfa9i3jdh07q1ib6pcbll8j6jn7-libstdc++-boot0-4.9.=
4.drv failed
> View build log at '/var/log/guix/drvs/n4/5z6cfa9i3jdh07q1ib6pcbll8j6jn7-l=
ibstdc++-boot0-4.9.4.drv.gz'.
> cannot build derivation `/gnu/store/gai3hg9c8qb89qlz8fwrgpscmf74g6c8-gcc-=
cross-boot0-14.2.0.drv': 1 dependencies couldn't be built
> cannot build derivation `/gnu/store/f2di3rzlyqa2xsby7z197wsldvqixq0l-gcc-=
cross-boot0-wrapped-14.2.0.drv': 1 dependencies couldn't be built
>
>
> Which, looking into the log leads to:
>
> starting phase `patch-tzdb.cc'
> error: in phase 'patch-tzdb.cc': uncaught exception:
> system-error "mkstemp!" "~A" ("No such file or directory") (2)=20
> phase `patch-tzdb.cc' failed after 0.0 seconds

Weird!  Oh wait, I removed guards around that stage.

core-packages-team-old has

--8<---------------cut here---------------start------------->8---
          #$@(if (target-hurd64?)
                 #~((add-after 'unpack 'patch-hurd64
                      (lambda _
                        (substitute* "libstdc++-v3/src/c++20/tzdb.cc"
                          (("#if ! defined _GLIBCXX_ZONEINFO_DIR")
                           "#if __GNU__ || ! defined _GLIBCXX_ZONEINFO_DIR"=
)))))
                 '())
          #$@(if (and (target-x86-64?) (target-linux?)
                      (version>=3D? (package-version gcc) "14"))
                 #~((add-after 'unpack 'patch-x86_64-linux
                      (lambda _
                        (substitute* "libstdc++-v3/src/c++20/tzdb.cc"
                          (("#if ! defined _GLIBCXX_ZONEINFO_DIR")
                           "#if __x86_64__ || ! defined _GLIBCXX_ZONEINFO_D=
IR")))))
                 '())
          #$@(if (and (target-x86-32?) (target-linux?)
                      (version>=3D? (package-version gcc) "14"))
                 #~((add-after 'unpack 'patch-x86_64-linux
                      (lambda _
                        (substitute* "libstdc++-v3/src/c++20/tzdb.cc"
                          (("#if ! defined _GLIBCXX_ZONEINFO_DIR")
                           "#if __i386__ || __x86_64__ || ! defined _GLIBCX=
X_ZONEINFO_DIR")))))
                 '())
          #$@(if (and (target-linux?)
                      (not (target-x86-64?))
                      (not (target-x86-32?))
                      (version>=3D? (package-version gcc) "14"))
                 #~((add-after 'unpack 'patch-tzdb.cc
                      (lambda _
                        (substitute* "libstdc++-v3/src/c++20/tzdb.cc"
                          (("#if ! defined _GLIBCXX_ZONEINFO_DIR")
                           "#if 1 // ! defined _GLIBCXX_ZONEINFO_DIR")))))
                 '()))
--8<---------------cut here---------------end--------------->8---

and the new core-packages-team has

--8<---------------cut here---------------start------------->8---
          (add-after 'unpack 'patch-tzdb.cc
            (lambda _
              (substitute* "libstdc++-v3/src/c++20/tzdb.cc"
                (("#if ! defined _GLIBCXX_ZONEINFO_DIR")
                 "#if 1 // ! defined _GLIBCXX_ZONEINFO_DIR")))))
--8<---------------cut here---------------end--------------->8---

ow, there it already is.  Silly me, we need the gcc-14 guard.  I was so
happy all systems seemed to need the same code that I also removed the
check for gcc-14.

> I am not sure this is caused by my changes.  When I revert the commit:

Certainly not!  But thanks for trying!

[..]

> Any ideas?

Meanwhile, because it seemed the build farm stopped working for me, I
started to build myself again and currently have

--8<---------------cut here---------------start------------->8---
successfully built /gnu/store/5qizz7ba86rd979xspsw3vi2xpg6gq7b-glibc-header=
s-mesboot-2.16.0.drv
successfully built /gnu/store/91212rdl4cn4rr8aqfrbilxagmx9fwj3-glibc-mesboo=
t-2.16.0.drv
successfully built /gnu/store/5a0bd35brzf1sgnw10slaxipmxa3cafn-gcc-mesboot1=
-wrapper-4.6.4.drv
--8<---------------cut here---------------end--------------->8---

so I didn't see this problem yet.  I've pushed a squash! commit that
should fix this.  Thanks!

Greetings,
Janneke

--=20
Janneke Nieuwenhuizen <janneke@HIDDEN>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar=C2=AE https://AvatarAcade=
my.com





Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.