GNU bug report logs - #74132
31.0.50; thing-at-pt, ffap and Github markdown

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: emacs; Severity: wishlist; Reported by: Madhu <enometh@HIDDEN>; Keywords: patch; dated Thu, 31 Oct 2024 10:43:02 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 74132 <at> debbugs.gnu.org:


Received: (at 74132) by debbugs.gnu.org; 13 Feb 2025 11:18:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 13 06:18:45 2025
Received: from localhost ([127.0.0.1]:40936 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tiXEz-0003Ls-Bd
	for submit <at> debbugs.gnu.org; Thu, 13 Feb 2025 06:18:45 -0500
Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:61526)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1tiXEx-0003Lc-AW
 for 74132 <at> debbugs.gnu.org; Thu, 13 Feb 2025 06:18:43 -0500
Received: by mail-ed1-x52a.google.com with SMTP id
 4fb4d7f45d1cf-5dec817f453so1113611a12.2
 for <74132 <at> debbugs.gnu.org>; Thu, 13 Feb 2025 03:18:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1739445517; x=1740050317; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=q0wf6p/BdQmVEupaxxcBNh40/ULuhMoskOKnPjV5xjg=;
 b=LeHtIPTwVIr5xzaalKULIrKR+vFq0xJpdlCEKHd2tBtXepji5YXaEvYrMrMtLhczrk
 9ozJbwK8UP78uoxlTe3JROmwCO+kwSmIg5rDd2t+3Jv0v4fsZBm/7K3Pm8QIuSXx3zVN
 Rrs1BAnSHBRgJy/P6LZwMwhftRckmLChPrPjVcTDZtGhEfNqzf5TmDMqgIw3/HZaCDBW
 v+6EgSJYj/ZtYB8FfCtSiDjfURkwopAjnp5cpALvgxIeMm3rZDmpInFESolSXB2yr49H
 NjNGo3Ocra2y072oF3OBso5SKShOdz1DuhtGQNZz76P6H91R6lhS2Y2mVqQQqZtcitfY
 cTvg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1739445517; x=1740050317;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=q0wf6p/BdQmVEupaxxcBNh40/ULuhMoskOKnPjV5xjg=;
 b=CoKmfTBGdSrDcQB94D47+YCTVz32SBUeM8Hos8CxA070fZKrIHUzZS1CQVKtjd3vSV
 dA3JH2NhdxCYN7rmipW7ygIxoxO/u5NmU/mamRoqIz/8lnSGax6Sq53z1N0hCWFwRdHv
 fEPOmYVFpZ+ZK+BV/nlKq6CcOoVymc/xk/FQoTgDFxqtfO8RCLsvx7wg5/yjywq7vrgs
 MOy26Pw45ZklixNUMEnDqdFN3e0/prGelVxlcMcnlctdG2HRzHCSld/mAX+aPBZ6UUSB
 hOpXgJiX75GDTPl5CPBUfpUbVIBq+mKiWGMFsERoiFS8R2qdl8mTRuyxpSqA+al8b6Tc
 DHRw==
X-Gm-Message-State: AOJu0Ywfli7YV4tuC7Vc4dEuwtx2TYDzZ6znlZmuK8DwASh6c7PBiVks
 Xq95IIMEM8b4Lr9hjG320mafdZyNG0JCH5XjqZJJUe3UNQ8z7QlmgUADjfpdWJHnfyqco0dTMg5
 k0r4n4xgQeiObUuM8D4+FEBhFv4Y=
X-Gm-Gg: ASbGncs3GYj3sO1uJ4JsXUFpn00WdrAimTVmSn4vCz/jFbJ3lx9QFcsbxGGPhImISr3
 fYUFHu8pFBMoPkUUZHxDUGRcaxsO3eUB9Gb2aadD3JI6z3d+WhcEr/A5ZFO+BPkXr62ZbOXW/KO
 Q=
X-Google-Smtp-Source: AGHT+IFZF9wDp+oyypY2gY0PZcb21URxrK5FoaBWBrfbuR/h1TkvtNRUPr/oJt12yG0BP38e1oPerPRnlhxxyZHT+tA=
X-Received: by 2002:a05:6402:1ed1:b0:5db:e6da:5ed3 with SMTP id
 4fb4d7f45d1cf-5deade00efbmr5005135a12.21.1739445516816; Thu, 13 Feb 2025
 03:18:36 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Thu, 13 Feb 2025 03:18:36 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <20250213.162251.382320678131999920.enometh@HIDDEN>
References: <20241101.110842.137608817097414398.enometh@HIDDEN>
 <CADwFkmnzgeu2vcFBWhXVCqqgw3fK7W071o27sXpMx6UPKnSv_Q@HIDDEN>
 <CADwFkm=8ewN4B0b2bWnYtNJHNUxXLK-ePMmz8SxJQdztPaAZFg@HIDDEN>
 <20250213.162251.382320678131999920.enometh@HIDDEN>
MIME-Version: 1.0
Date: Thu, 13 Feb 2025 03:18:36 -0800
X-Gm-Features: AWEUYZldrK3LMnXCk4VSmOhXL51yXZzn1_mL2ffH6ADJb6PYuomvGRNeGcczPaY
Message-ID: <CADwFkmnSTuSZWTV4HD1S5u0XHT1Yj9aTdHUQCTn4Hz_USvHJAg@HIDDEN>
Subject: Re: bug#74132: 31.0.50; thing-at-pt, ffap and Github markdown
To: Madhu <enometh@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 74132
Cc: 74132 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Madhu <enometh@HIDDEN> writes:

> I'd like to update my copy of emacs before reworking the patch, and
> hope to get around to both by monday.  But if the problem and answer
> are clear enough, maybe you go ahead with a solution?

I don't have the bandwidth to take this on right now myself, sorry, so I
think we can wait for your patch.  There's no rush with this, so please
take your time.
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#74132; Package emacs. Full text available.

Message received at 74132 <at> debbugs.gnu.org:


Received: (at 74132) by debbugs.gnu.org; 13 Feb 2025 10:52:59 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 13 05:52:59 2025
Received: from localhost ([127.0.0.1]:40861 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tiWq3-00028h-EH
	for submit <at> debbugs.gnu.org; Thu, 13 Feb 2025 05:52:59 -0500
Received: from smtp7.ctinetworks.com ([205.166.61.237]:44512)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <enometh@HIDDEN>) id 1tiWq0-00028T-A5
 for 74132 <at> debbugs.gnu.org; Thu, 13 Feb 2025 05:52:57 -0500
X-ctinetworks-Watermark: 1740307974.5127@/b8R+eH5PWsqURoF7/0vZw
X-ctinetworks-Envelope-From: enometh@HIDDEN
X-ctinetworks-SpamCheck: 
X-ctinetworks-VirusCheck: Found to be clean
X-ctinetworks-Message-ID: EB1E5EC57.A79DE
Received: from localhost (unknown [117.254.36.132])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 (Authenticated sender: enometh@HIDDEN)
 by smtp7.ctinetworks.com (Postfix) with ESMTPSA id EB1E5EC57;
 Thu, 13 Feb 2025 05:52:52 -0500 (EST)
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp7.ctinetworks.com EB1E5EC57
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meer.net;
 s=ctidkims1; t=1739443974;
 bh=NQerrGxP9zQVJnphtr+iatVDFasu3zI1CBlCo57y8h8=;
 h=Date:To:Cc:Subject:From:In-Reply-To:References:From;
 b=RniMF3TjFGL+EBFATLez7tmrZa9tkY7l8OB+Jlt9JS+GyB8OLVfGY7g9b16Dgzc/+
 TpAhTE35jNHKumTERMz+w7xdT+g/Tqqi17k7PJgAp0ENTkCX0JkrUG5fwGQVfV1hxd
 AYQSungAk9qaB5TIv1sAfPbP5AIZcOF3I/lULyVQ=
Date: Thu, 13 Feb 2025 16:22:51 +0530 (IST)
Message-Id: <20250213.162251.382320678131999920.enometh@HIDDEN>
To: stefankangas@HIDDEN
Subject: Re: bug#74132: 31.0.50; thing-at-pt, ffap and Github markdown
From: Madhu <enometh@HIDDEN>
In-Reply-To: <CADwFkm=8ewN4B0b2bWnYtNJHNUxXLK-ePMmz8SxJQdztPaAZFg@HIDDEN>
References: <20241101.110842.137608817097414398.enometh@HIDDEN>
 <CADwFkmnzgeu2vcFBWhXVCqqgw3fK7W071o27sXpMx6UPKnSv_Q@HIDDEN>
 <CADwFkm=8ewN4B0b2bWnYtNJHNUxXLK-ePMmz8SxJQdztPaAZFg@HIDDEN>
X-Mailer: Mew version 6.9 on Emacs 31.0.50
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 74132
Cc: 74132 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

I'd like to update my copy of emacs before reworking the patch, and
hope to get around to both by monday.  But if the problem and answer
are clear enough, maybe you go ahead with a solution?
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#74132; Package emacs. Full text available.

Message received at 74132 <at> debbugs.gnu.org:


Received: (at 74132) by debbugs.gnu.org; 13 Feb 2025 10:17:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 13 05:17:15 2025
Received: from localhost ([127.0.0.1]:40729 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tiWHT-0005pw-1k
	for submit <at> debbugs.gnu.org; Thu, 13 Feb 2025 05:17:15 -0500
Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]:43046)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1tiWHQ-0005pZ-Bk
 for 74132 <at> debbugs.gnu.org; Thu, 13 Feb 2025 05:17:13 -0500
Received: by mail-ej1-x62a.google.com with SMTP id
 a640c23a62f3a-ab7d583d2afso338126166b.0
 for <74132 <at> debbugs.gnu.org>; Thu, 13 Feb 2025 02:17:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1739441826; x=1740046626; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=te3jd8DmjYIsaU7+AI5Xr1FFCy6yYiSaJZ8kLjD7+Qc=;
 b=RXdIxclP4wfg0GUzO38/cERuR0GmliVXNgVNzTp6b41i0lPKQHo/0FcazmoQ8IcLru
 bupKEF3huWKRiiGkTCUERGxxjRpyQb0l9nAmNCAkUO8y+sSAA4aZcOfp7J9UZ8yszJOk
 PgPdzVgb1GKREnDXMtqeeXs+lHQIk2LT93nPGLEhQ/iMSVYVoZTzC6bFhxXN3T9aAZaP
 nJ1MUurGhnjygXAAYI/UIlQsAoWlBK6RyWc6TevLAwkyw91MFkCkDeoX2UI4OtUGMTuC
 Hb80xYSTA6YYoQJV8idGQUNkxBriUyOaO+Rb//qarCzLaHeXEe2RznYbfbiLGkNlhY0o
 TobA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1739441826; x=1740046626;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=te3jd8DmjYIsaU7+AI5Xr1FFCy6yYiSaJZ8kLjD7+Qc=;
 b=U9egW2ZZvy5/6IWTDt2phjbsELj28pH3gh4JXOLYB/vZmuiwQwwgy3nl5YarcCF8q/
 y1+JEFSvQVLZAVoxsTHxcfKkxQdnAFtDWCLu+W2CLNF9uAn/PIW3TO2yPLhwUOLlDbzN
 HKoeHBLSm4CuiN0SVw3kPJMmlnM7+v5HzvfJLhfjYnqLuHhsSofdaq1yHzuYT3LayO+6
 vwFoMMcpcKYWes16U+r5Ecjf4B8jcDABBXF5btmXt0rhRxR1qQ32yF/LCUkcNzPxQvQt
 vcJ5wx1yNTr6L9Ckrx67AYCnEBVclicq3+LmaWNwFTXfHN07AfzJePkF64EzA8QWiY91
 H1eQ==
X-Gm-Message-State: AOJu0YzfwCwsy5Y1+HcFo5y3RznGdhHig8hFhEObKz30BxMwz5T2dm5z
 caABrwvDOEPo8ygKicXx/ikuz8lqiBsL8n2W1ysByuA2ZhcZdEelXIUrEUgbx6KEEffjQAYzYqx
 +bnlhRl73Aj5hxEqAWBvcNPsMwuBgsyUMicCUtA==
X-Gm-Gg: ASbGncvy+KjgUZB/OdXFeDIjVv9PgggnsysRXdb64claX54KSEEzgGrOC/3/DlsZW5U
 KVFsGfG7MXmrzTShDPXDrXPmrGN9b+TvEBAm3rw5Z+HQ4Hl8sToKCH8G4dPkW4kPEbsVgfWk1u5
 s=
X-Google-Smtp-Source: AGHT+IH4XDnbs/VxqUonw3HTFV8Oa+1gSijrdqPDfEI+CLsXOAGb5O+vgQHx5+sjF4M0leX9GNW5GWj3QyFuYYDcAhQ=
X-Received: by 2002:a17:907:9692:b0:ab7:bc36:f4ad with SMTP id
 a640c23a62f3a-aba50feca36mr200869466b.16.1739441825862; Thu, 13 Feb 2025
 02:17:05 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Thu, 13 Feb 2025 02:17:05 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <CADwFkmnzgeu2vcFBWhXVCqqgw3fK7W071o27sXpMx6UPKnSv_Q@HIDDEN>
References: <20241031.160649.1619221016115134543.enometh@HIDDEN>
 <handler.74132.B.173037135112690.ack <at> debbugs.gnu.org>
 <20241101.110842.137608817097414398.enometh@HIDDEN>
 <CADwFkmnzgeu2vcFBWhXVCqqgw3fK7W071o27sXpMx6UPKnSv_Q@HIDDEN>
MIME-Version: 1.0
Date: Thu, 13 Feb 2025 02:17:05 -0800
X-Gm-Features: AWEUYZnlQRockksoOLHNuDJUPd-ZEPnh-yOZnbi3NYZPAtXsI0ttvRFcJ3R4e_o
Message-ID: <CADwFkm=8ewN4B0b2bWnYtNJHNUxXLK-ePMmz8SxJQdztPaAZFg@HIDDEN>
Subject: Re: bug#74132: 31.0.50; thing-at-pt, ffap and Github markdown
To: Madhu <enometh@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 74132
Cc: 74132 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Stefan Kangas <stefankangas@HIDDEN> writes:

> Madhu <enometh@HIDDEN> writes:
>
>> There was a typo in the patch I posted. It should instead look like this
>
> Could you please resend the amended patch as an attachment?
>
> Also, how about having some tests for this?

Ping!
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#74132; Package emacs. Full text available.

Message received at 74132 <at> debbugs.gnu.org:


Received: (at 74132) by debbugs.gnu.org; 13 Feb 2025 10:17:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 13 05:17:03 2025
Received: from localhost ([127.0.0.1]:40726 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tiWHH-0005pO-M2
	for submit <at> debbugs.gnu.org; Thu, 13 Feb 2025 05:17:03 -0500
Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]:47264)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1tiWHF-0005od-9M
 for 74132 <at> debbugs.gnu.org; Thu, 13 Feb 2025 05:17:01 -0500
Received: by mail-ed1-x52b.google.com with SMTP id
 4fb4d7f45d1cf-5de4a8b4f86so992640a12.2
 for <74132 <at> debbugs.gnu.org>; Thu, 13 Feb 2025 02:17:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1739441815; x=1740046615; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=u8KzkC8TxtCzwJoSZqJlcrUJhrdpXNPatnzoTEl4DFA=;
 b=Ct+wiZmGZPaqyBm49EimpMpRsyHuIZHMBR7MMGwTvKL53hGQ78wrN8Gbbo/4XOgKBD
 KhxAzvim65uPXb3cAM1X5ZCqZYYn5dAkMMIuoAujniwDk/qshtzBhMGlpzpK+OazCKnP
 MRYUFfEvjAs0HGHLw7VDiEiokLeeZvRrtA3kVHqqHexJ+3I2IbmfBNy1PJ2PTGky4LgO
 iVBQvsySx+3oVUt+NY6dhU1nNbLbQk1cb/XLXC2wcaK+rBPTVnss5QTPmWVlEaE75eil
 GOooyyZxla9/MtnkwWq9niYBSCQrC8/H69df1xPCtXenW+MMWTuUfNDdJJu4RyS4dZga
 rSFw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1739441815; x=1740046615;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=u8KzkC8TxtCzwJoSZqJlcrUJhrdpXNPatnzoTEl4DFA=;
 b=Oc3o4HdR8gsEzGc/YE2/pVjfC8AhVxyw44vLFscWURH+89Vpn5HGd4wnUcVF0f4D4R
 lGzjhYu9n7HrokeO0gtW2ah0RMbw0UFWbkCiQDtPfarhD1Iurxp2yHcwZCsR3d2lggDD
 6sjaf4PY2YurEdJkV24sp4njbc3IFH9iitrpsGQACX8+ZmPdHHZnUlr2cH3CP7018gPh
 epvHBNrrQ6eAqTe1m/YNyCXYTU/BhANv7qTd8I8LqoKG2bGka5sipostIc71KpYYv1+m
 XM/cl654wcxdyYlDDsUJ/rXkddxNpYiTwV9S6d7Y3dnh8FoB0HZ2VyZz+tzrskiDRChg
 ssDA==
X-Forwarded-Encrypted: i=1;
 AJvYcCXycMo/OXviq/zw6Op1XRWWJkHb49f6Dzte70bjOJ+akMmI909DRwVgLfVHzvvSl78N0BJXBQ==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YxBX6H6dBb/UOm94gFjtE9jEv62GAaKcXpN3gjM1C40KaQ3kHHu
 vT2xW/dFk65Aqj1SQXGfGVbFlTPVqoXd6ZUl7G38+Kgf9pLkgdICdxoCdnRi0jLRp6n5CmOe5w1
 YofN15uFu5zf2pvEXq8KQ36s/IoN4KTtKs6tXBQ==
X-Gm-Gg: ASbGncuQkAZMB3d6UwPSzf/XcuiYg5/tK+5OCt6gbQ50FEoQVfsnqHqW1DuizBCVIwt
 0NsMl+Cr67G7Ewml1EApe9lBkOSWgnSGOP8hHUK0zcSyy229ZY97RFGWxA6QsPnMwHuHMR4ZtQP
 k=
X-Google-Smtp-Source: AGHT+IFBfHGORxvbaiKKR9dR6L4lW0gWMb1Bo0hDRlhxigKma+OoTaimfsUgK68nX/OdcNLVSocoYCuhy77mxCIJRlM=
X-Received: by 2002:a05:6402:3510:b0:5de:44b1:46c with SMTP id
 4fb4d7f45d1cf-5deadd7504cmr6145074a12.7.1739441814648; Thu, 13 Feb 2025
 02:16:54 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Thu, 13 Feb 2025 02:16:53 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <86wmhcl24s.fsf@HIDDEN>
References: <20241031.160649.1619221016115134543.enometh@HIDDEN>
 <86msi8n1jd.fsf@HIDDEN> <jwvv7wwz9vq.fsf-monnier+emacs@HIDDEN>
 <864j4gmkou.fsf@HIDDEN> <jwvwmhcxs9k.fsf-monnier+emacs@HIDDEN>
 <86wmhcl24s.fsf@HIDDEN>
MIME-Version: 1.0
Date: Thu, 13 Feb 2025 02:16:53 -0800
X-Gm-Features: AWEUYZmyyJQMTs7kHedt9eaNPXxOHocY30a9RpSUCfZkvyGKZTnZOWUOaQw_z3E
Message-ID: <CADwFkmkAC6HQddGbBi_Y4=0FRK3rZJmasb2gRxS8j+ex-mUeAA@HIDDEN>
Subject: Re: bug#74132: 31.0.50; thing-at-pt, ffap and Github markdown
To: Eli Zaretskii <eliz@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 74132
Cc: enometh@HIDDEN, Stefan Monnier <monnier@HIDDEN>,
 74132 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Eli Zaretskii <eliz@HIDDEN> writes:

> So maybe this should be fine-tuned by major modes?

One complication is that you sometimes run into Markdown in other modes
too, for example Markdown inside of Python docstrings, which is quite
common.  So even if we had such a mechanism, I still think there is no
way around trying to handle at least the most common cases by default.
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#74132; Package emacs. Full text available.
Severity set to 'wishlist' from 'normal' Request was from Stefan Kangas <stefankangas@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 74132 <at> debbugs.gnu.org:


Received: (at 74132) by debbugs.gnu.org; 9 Nov 2024 17:59:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 09 12:59:30 2024
Received: from localhost ([127.0.0.1]:54392 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1t9pk9-0007tK-UL
	for submit <at> debbugs.gnu.org; Sat, 09 Nov 2024 12:59:30 -0500
Received: from eggs.gnu.org ([209.51.188.92]:47282)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1t9pk6-0007t3-F6
 for 74132 <at> debbugs.gnu.org; Sat, 09 Nov 2024 12:59:27 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1t9pjz-0008Lf-Vy; Sat, 09 Nov 2024 12:59:20 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=YuVHa9wsCXYDAOdjPb1+BAbkHdL/wfgKFkoy1qR6aHg=; b=KBMaBaAZlU+n
 CeJvwa2YYLMkYY6c6mwgqRWJyN8Buxe8x3191cVbw1i1qo2UFwS1Ui+S7Xl+K4iKLcb4WDxQCQlm+
 JyhGEadMe2jtZmqLzwGixLoWQj31zruAwz3uat47YVfXMEcxLpx5br2wY0eMh4CcgTjo3x4fJ4Kaf
 YdeM19QSts1nGmiVLfbfyOkyNHwjt/pH/UyS6rfKHQTF6v/JPlQAQMwGDJRIRD0Ij+A7v6JzCId8P
 4dyaJwNljWB3KR4ZMuTrX+UNfAzL0BEOBcdkSuissY3oeMP/SL9QUMTe3zTQxMMo/ObCGvQyLVsJp
 PjdXhnx8L845gHkDdlDGZQ==;
Date: Sat, 09 Nov 2024 19:59:15 +0200
Message-Id: <86wmhcl24s.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <jwvwmhcxs9k.fsf-monnier+emacs@HIDDEN> (message from Stefan
 Monnier on Sat, 09 Nov 2024 11:59:44 -0500)
Subject: Re: bug#74132: 31.0.50; thing-at-pt, ffap and Github markdown
References: <20241031.160649.1619221016115134543.enometh@HIDDEN>
 <86msi8n1jd.fsf@HIDDEN> <jwvv7wwz9vq.fsf-monnier+emacs@HIDDEN>
 <864j4gmkou.fsf@HIDDEN> <jwvwmhcxs9k.fsf-monnier+emacs@HIDDEN>
X-Spam-Score: -1.6 (-)
X-Debbugs-Envelope-To: 74132
Cc: enometh@HIDDEN, 74132 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

> From: Stefan Monnier <monnier@HIDDEN>
> Cc: enometh@HIDDEN,  74132 <at> debbugs.gnu.org
> Date: Sat, 09 Nov 2024 11:59:44 -0500
> 
> >> > What will this do to URLs such as
> >> >   http://web.archive.org/web/20240221082647/https://www.imdb.com/
> >> Depends where point is: if it's after the `https`, then you get the
> >> "sub-URL" and if it's on or before the `https` then you get the whole URL.
> > Exactly.  This could be considered a bug, because the actual URL is
> > the entire thing.
> 
> We could refine our heuristic to as to keep looking backward when the
> apparent beginning of the URL is immediately preceded by a /, of course,
> but I'm not sure it's worth the trouble.

The problem is that AFAIU '/' is not the only such character.  It
could also be '=', I think (as in query URLs), and perhaps some
others.

> AFAICT any behavior we come up with will have such cases.

Yes, which is why I said I didn't know how to solve this.

> The [...](...) case mentioned by Madhu is a fairly common one IME, so
> I'm in favor of fixing it.

Not universally so, IME.  It is common in Markdown files and perhaps
also in Org.  So maybe this should be fine-tuned by major modes?
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#74132; Package emacs. Full text available.

Message received at 74132 <at> debbugs.gnu.org:


Received: (at 74132) by debbugs.gnu.org; 9 Nov 2024 17:00:01 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 09 12:00:01 2024
Received: from localhost ([127.0.0.1]:54282 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1t9ooa-0005Cw-Sv
	for submit <at> debbugs.gnu.org; Sat, 09 Nov 2024 12:00:01 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:58130)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1t9ooX-0005Ce-9F
 for 74132 <at> debbugs.gnu.org; Sat, 09 Nov 2024 11:59:59 -0500
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C1D39100208;
 Sat,  9 Nov 2024 11:59:50 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1731171585;
 bh=LwDvohZ4DFBrOYdv2haFpSVQN6/pyfDguRj+jIm9aj8=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=FI/qpGGwdRFTNHDCFc1yokZkSjF+suiggP/rhOtKYJPoZqtmMFSNhkPLdOObmzx+k
 tY9eecgc6VIRS0EiFZij4fPypVZtibAikEQWUqfYOlgcJ53/usGkZkx8nA7zry0rtv
 y3lgclY1Zg1KUcF2X2s4BQL2RR5FBcSrOQxLyY0fqKeOmIo2uoNHFT8oBnVoHEAHrD
 ygiMj1dPGLdvFWE/TVnqT4855YPEuUDqcl8cTmpV5rR4juNwy3c9rr2bEKgVJlKMcG
 D1fzxqN0wZZwrX5q4GQLaiQjZZDQxHptHiPhPhItUHBeJ1IJPY6/BOy8jG54XLKfH5
 qVDqaNLBxlx1w==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id DC394100180;
 Sat,  9 Nov 2024 11:59:45 -0500 (EST)
Received: from pastel (104-195-225-43.cpe.teksavvy.com [104.195.225.43])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4515D1203E2;
 Sat,  9 Nov 2024 11:59:45 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#74132: 31.0.50; thing-at-pt, ffap and Github markdown
In-Reply-To: <864j4gmkou.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 09 Nov
 2024 18:33:05 +0200")
Message-ID: <jwvwmhcxs9k.fsf-monnier+emacs@HIDDEN>
References: <20241031.160649.1619221016115134543.enometh@HIDDEN>
 <86msi8n1jd.fsf@HIDDEN> <jwvv7wwz9vq.fsf-monnier+emacs@HIDDEN>
 <864j4gmkou.fsf@HIDDEN>
Date: Sat, 09 Nov 2024 11:59:44 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL -0.119 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
 URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist
 [207.241.237.3]
X-SPAM-LEVEL: 
X-Spam-Score: -1.6 (-)
X-Debbugs-Envelope-To: 74132
Cc: enometh@HIDDEN, 74132 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

>> > What will this do to URLs such as
>> >   http://web.archive.org/web/20240221082647/https://www.imdb.com/
>> Depends where point is: if it's after the `https`, then you get the
>> "sub-URL" and if it's on or before the `https` then you get the whole URL.
> Exactly.  This could be considered a bug, because the actual URL is
> the entire thing.

We could refine our heuristic to as to keep looking backward when the
apparent beginning of the URL is immediately preceded by a /, of course,
but I'm not sure it's worth the trouble.

AFAICT any behavior we come up with will have such cases.

>> > I'm not sure I see how to resolve this dilemma.  Stefan, any ideas?
>> "url at point" is inherently heuristic, so I'm not too worried.
>> But I do very much agree with Stefan that we need tests, because it's
>> all too easy to run around in circles otherwise, fixing the heuristic to
>> handle case A but breaking case B along the way.
> I'm okay with adding tests, of course, but I'm not sure which of the
> two behaviors leave you "not too worried": the current or the new one
> after the proposed change.  And why.

The [...](...) case mentioned by Madhu is a fairly common one IME, so
I'm in favor of fixing it.  As for the behavior in your example, to the
extent that the users can control which URL they get (depending on where
they place point (or click)), I'm OK with either behavior.


        Stefan
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#74132; Package emacs. Full text available.

Message received at 74132 <at> debbugs.gnu.org:


Received: (at 74132) by debbugs.gnu.org; 9 Nov 2024 16:33:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 09 11:33:18 2024
Received: from localhost ([127.0.0.1]:54215 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1t9oOj-0003zR-VU
	for submit <at> debbugs.gnu.org; Sat, 09 Nov 2024 11:33:18 -0500
Received: from eggs.gnu.org ([209.51.188.92]:51730)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1t9oOg-0003zD-VP
 for 74132 <at> debbugs.gnu.org; Sat, 09 Nov 2024 11:33:15 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1t9oOb-0008Pq-Fg; Sat, 09 Nov 2024 11:33:09 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=bx78JHNjSp1NABYHMUhEGXMzWG1EMKFXDZmZCr7T8NU=; b=VAtkW2TYRq7L
 OP2Kn4OAfgvbmsd1TQw5CxLFR7zl6RMAG3QPUm5rT6G8dLIN1+mvb0wk/D8ppy9UqzBv9DRCGvPH8
 IVxjjb51H5eiZq6CqneTpLBAfW3xoKSE+86jkEc860egVeKoPiZ7d67y7CX+ZWGNAr6H4SLggqiSC
 nV+cleprXnOunDE4bEVfyQuXUVMI3DlsgEEh0c57wM7QqbiG5EURLfwJN+DN6M1NtIPxvjs78UglT
 IZUUtp4tF8s5dgYBoV2M1uHxo73C6F+5/MwZh+IbtsN/xJOxcCdyxH6Bq2bHSYP3c3vaQd7yVlY1m
 nLRUeTSzxk7yMJ5bbBkTYA==;
Date: Sat, 09 Nov 2024 18:33:05 +0200
Message-Id: <864j4gmkou.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <jwvv7wwz9vq.fsf-monnier+emacs@HIDDEN> (message from Stefan
 Monnier on Sat, 09 Nov 2024 10:52:06 -0500)
Subject: Re: bug#74132: 31.0.50; thing-at-pt, ffap and Github markdown
References: <20241031.160649.1619221016115134543.enometh@HIDDEN>
 <86msi8n1jd.fsf@HIDDEN> <jwvv7wwz9vq.fsf-monnier+emacs@HIDDEN>
X-Spam-Score: -1.6 (-)
X-Debbugs-Envelope-To: 74132
Cc: enometh@HIDDEN, 74132 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

> From: Stefan Monnier <monnier@HIDDEN>
> Cc: Madhu <enometh@HIDDEN>,  74132 <at> debbugs.gnu.org
> Date: Sat, 09 Nov 2024 10:52:06 -0500
> 
> > What will this do to URLs such as
> >
> >   http://web.archive.org/web/20240221082647/https://www.imdb.com/
> 
> Depends where point is: if it's after the `https`, then you get the
> "sub-URL" and if it's on or before the `https` then you get the whole URL.

Exactly.  This could be considered a bug, because the actual URL is
the entire thing.

> > I'm not sure I see how to resolve this dilemma.  Stefan, any ideas?
> 
> "url at point" is inherently heuristic, so I'm not too worried.
> But I do very much agree with Stefan that we need tests, because it's
> all too easy to run around in circles otherwise, fixing the heuristic to
> handle case A but breaking case B along the way.

I'm okay with adding tests, of course, but I'm not sure which of the
two behaviors leave you "not too worried": the current or the new one
after the proposed change.  And why.
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#74132; Package emacs. Full text available.

Message received at 74132 <at> debbugs.gnu.org:


Received: (at 74132) by debbugs.gnu.org; 9 Nov 2024 15:52:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 09 10:52:22 2024
Received: from localhost ([127.0.0.1]:54084 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1t9nl8-00025C-Fn
	for submit <at> debbugs.gnu.org; Sat, 09 Nov 2024 10:52:22 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:3750)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1t9nl4-00024v-Mc
 for 74132 <at> debbugs.gnu.org; Sat, 09 Nov 2024 10:52:20 -0500
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 53A3880013;
 Sat,  9 Nov 2024 10:52:12 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1731167527;
 bh=iGNji/Zly401xag3fShz39YjDDOmZBIbopa1WtAEmwA=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=dSY3mGxLhlQQsDMxATHeWqzKKj8/fPUeS7RuyupP6Z4rh8PxHhtmDsuaLSEl9iaAe
 wu2kmLv8j2zvqOfmVu6SkkPb9gfoIKRzwaHAUDzHj2+KcXKrsum7UBkvLSq/cZVnZu
 cACfjamrZWXr5OKkYnm1cnWWyFj84zkRRFXumRI8FcDEAwmVNpUHOZlyy5+Q3SlU49
 05PFnGgPpW3oiuoVkR8XBQAEdOlrXHFJ5cpeQVLNe9/l7jgs1qQ5BhP1Hfclo8E8uM
 yH/f1hMcIVg9tYdkIqhD8fvTJEW05UAVq14BG4YWunvbQK+d/MDKOqrZHO+WY4ndQa
 qYIAsZtfHa7Bw==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 500678053B;
 Sat,  9 Nov 2024 10:52:07 -0500 (EST)
Received: from pastel (104-195-225-43.cpe.teksavvy.com [104.195.225.43])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 21D2C12041D;
 Sat,  9 Nov 2024 10:52:07 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#74132: 31.0.50; thing-at-pt, ffap and Github markdown
In-Reply-To: <86msi8n1jd.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 09 Nov
 2024 12:29:10 +0200")
Message-ID: <jwvv7wwz9vq.fsf-monnier+emacs@HIDDEN>
References: <20241031.160649.1619221016115134543.enometh@HIDDEN>
 <86msi8n1jd.fsf@HIDDEN>
Date: Sat, 09 Nov 2024 10:52:06 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL -0.091 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [archive.org, imdb.com]
 URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist
 [207.241.237.3]
X-SPAM-LEVEL: 
X-Spam-Score: -1.6 (-)
X-Debbugs-Envelope-To: 74132
Cc: Madhu <enometh@HIDDEN>, 74132 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

> What will this do to URLs such as
>
>   http://web.archive.org/web/20240221082647/https://www.imdb.com/

Depends where point is: if it's after the `https`, then you get the
"sub-URL" and if it's on or before the `https` then you get the whole URL.

> I'm not sure I see how to resolve this dilemma.  Stefan, any ideas?

"url at point" is inherently heuristic, so I'm not too worried.
But I do very much agree with Stefan that we need tests, because it's
all too easy to run around in circles otherwise, fixing the heuristic to
handle case A but breaking case B along the way.


        Stefan
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#74132; Package emacs. Full text available.

Message received at 74132 <at> debbugs.gnu.org:


Received: (at 74132) by debbugs.gnu.org; 9 Nov 2024 10:29:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 09 05:29:26 2024
Received: from localhost ([127.0.0.1]:53531 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1t9iib-0004lM-V5
	for submit <at> debbugs.gnu.org; Sat, 09 Nov 2024 05:29:26 -0500
Received: from eggs.gnu.org ([209.51.188.92]:40462)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1t9iiY-0004l8-GN
 for 74132 <at> debbugs.gnu.org; Sat, 09 Nov 2024 05:29:25 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1t9iiS-0000kb-1D; Sat, 09 Nov 2024 05:29:16 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=9+QLby33DRgk3RKE2qTIYHI0Tb0vvK/CrvQMOOWsoik=; b=FytwC3NOfnDY
 kHvyg9C6IyW7ID4gCGIL13XrRUBLB6vo+ZAtGTMor6VsNj2VoPwuitG4tMiQrB5hrIAhME5ZwJUz3
 Sl2m1qixwDmOuzz3wsCB/8LZWG88MkNYQOJ9K/HjfLe1hOTzykgoV1YqHQxm1HtU/2qZJMLRUywBC
 SX36b7jS78fWAmGQ9EzphazFKgTZULdsgnEmv76kL+vkiqp5/HyY4ShQKHQMxQXS9vcVo21tV4kFK
 AlbtLu/IXiLFz4dyWVlVVjlE8y30uM/y5ES30gjrV98i8mDxEupFabVVFbryMjzocIdL4d5GLVzxo
 vvw3ammPUEc6MDMEZXWxqA==;
Date: Sat, 09 Nov 2024 12:29:10 +0200
Message-Id: <86msi8n1jd.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Madhu <enometh@HIDDEN>,
 Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <20241031.160649.1619221016115134543.enometh@HIDDEN> (message
 from Madhu on Thu, 31 Oct 2024 16:06:49 +0530 (IST))
Subject: Re: bug#74132: 31.0.50; thing-at-pt, ffap and Github markdown
References: <20241031.160649.1619221016115134543.enometh@HIDDEN>
X-Spam-Score: -1.6 (-)
X-Debbugs-Envelope-To: 74132
Cc: 74132 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

> Date: Thu, 31 Oct 2024 16:06:49 +0530 (IST)
> From: Madhu <enometh@HIDDEN>
> 
> Consider the following text as is typically found on README.md
> 
> ```
> [![GitHub Releases Downloads](https://img.shields.io/github/downloads/raysan5/raylib/total)](https://github.com/raysan5/raylib/releases)
> ```
> 
> If the point is say at "r" at "raylib/releases", invoking
> (ffap-url-at-point) fails.  this eventually calls
> thing-at-point-bounds-of-url-at-point, which has hardcoded behaviour
> to, skip over "allowed characters" backwards to find the beginning of
> the bound. here it it finds the space character (in "Release
> Downloads") and the whole thing fails.
> 
> This particular failure can be addressed by supplying the lim
> paramater to the skip-chars-backward, as shown in the attached
> patch.
> 
> does this look like a problem which ought to be solved? and is this
> appropriate? (I was going to post on emacs-devel but decided to post
> to the bug list instead) -- Best Regards, Madhu
> 
> >From 5971b7c10d7c38d540fdf278a0cd559c96b10ed2 Mon Sep 17 00:00:00 2001
> From: Madhu <enometh@HIDDEN>
> Date: Thu, 31 Oct 2024 15:40:42 +0530
> Subject: [PATCH] lisp/thingatpt.el: recognize urls better in markdown text
> 
> * lisp/thingatpt.el: (thing-at-point-bounds-of-url-at-point): supply a
> LIM when calling (skip-chars-backward allowed-chars), which is the
> position where `thing-at-point-beginning-of-url-regexp' matches
> backwards
> 
> problematic url e.g.
> ```
> [![GitHub Releases Downloads](https://img.shields.io/github/downloads/raysan5/raylib/total)](https://github.com/raysan5/raylib/releases)
> ```
> If the point is in the the second url, skip-chars-backwards goes to the
> space (between s and D) and `ffap-url-at-point' eventually fails.
> but if we supply a limit with a left anchor, we work around it.

What will this do to URLs such as

  http://web.archive.org/web/20240221082647/https://www.imdb.com/

?  More generally, to any URL that has another URL embedded in it?

I'm not sure I see how to resolve this dilemma.  Stefan, any ideas?
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#74132; Package emacs. Full text available.

Message received at 74132 <at> debbugs.gnu.org:


Received: (at 74132) by debbugs.gnu.org; 2 Nov 2024 22:05:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 02 18:05:24 2024
Received: from localhost ([127.0.0.1]:55896 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1t7MFH-0002bx-Tj
	for submit <at> debbugs.gnu.org; Sat, 02 Nov 2024 18:05:24 -0400
Received: from mail-ed1-f48.google.com ([209.85.208.48]:42235)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1t7MFF-0002br-40
 for 74132 <at> debbugs.gnu.org; Sat, 02 Nov 2024 18:05:22 -0400
Received: by mail-ed1-f48.google.com with SMTP id
 4fb4d7f45d1cf-5cece886771so832954a12.0
 for <74132 <at> debbugs.gnu.org>; Sat, 02 Nov 2024 15:05:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1730585060; x=1731189860; darn=debbugs.gnu.org;
 h=to:subject:message-id:date:mime-version:references:in-reply-to:from
 :from:to:cc:subject:date:message-id:reply-to;
 bh=PsAMJ7B6QzHJuWbtAywGf7mcVEFcITmX33kNuSHfNUw=;
 b=O9DLTOiCUIXMeBQncNpUw9pR0pJISYe8k/H1xH30gCMZGP1FPVoqeeMPCb5vmUn12w
 9tRU2qc7zsQyfgMQ1/22JMgn02OBZbEAywIAW3NAyMWK/ZEXYk8mLTwwXvvgx9EYmYeA
 hJo69XUlghOcwsKXaHozPvrvDcEjjv2Opl3G0+HyUnuQD1r2UdAu3rhT8xm7o3MzAH73
 IAGpD9ThyFrOxf/Z07ev/Or5Mr5asBGsMZ53+4mXvKeKKbflweB1NhkdW5rP0UhOrqck
 Bs2X2Cm+1RvSM5K2pWIDrfSPTl0G1vherGKYrxvoLt1wHyBrjl4d0ekggul/YItpmW5N
 YMMQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1730585060; x=1731189860;
 h=to:subject:message-id:date:mime-version:references:in-reply-to:from
 :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=PsAMJ7B6QzHJuWbtAywGf7mcVEFcITmX33kNuSHfNUw=;
 b=SXV1VSjAEeXNqDl3UW1fQ+Kzd8cj/hWBhe/ND5iqO2AtU3pPvnqalSE2htJfDFHgDo
 BBQaBSRW4AzRSiPvL5PNiEDeBR/tCy6bn1s4ZutScYsE4wyWyfQTn9i0QoDBqjcvmFVk
 OeZIEcfQZsWLbTozCak+wqFUCyxy61/iR3bRgp9nWx9QilenebaDvEUM/uuiIuHaHr8y
 jfyRj+2BQPzpyg+4CzRS5vJfs7SH4Kmny48XhlZICUvAiUzmVc5rw+DeJEk5xZt5kiij
 p4DwMttgXZF9yutZxh3ORp0oLQGpQPXlu2KZ5KIlWPcJW+e1J88v+6IpVJNt728EAkKk
 Gncw==
X-Forwarded-Encrypted: i=1;
 AJvYcCVlpgh0bIGTRpaud950PYSpV/tTeE72m2TVIM53us28UJclYj0zJ2TCGQqdcuTFKy5OrJd8pQ==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YymbF8xp9jUOMMTxFe8wEoeu/TTKNeW7tubUwJtzfe/+9vXqfGB
 /aPVPLay/pzb6x5B9u6kNsO8nEd49DlkPMMrRMsHJWmtwUoC0sgUdXEY0mH0jEvNgZ8e1uiRHP2
 Pt7/LBu3b/b8MllN5D+Tz5jh1V2u80A==
X-Google-Smtp-Source: AGHT+IECYDKOxnnBJvBQR1rK4yNUk7s1WyTSwRSmJzuU5L3xi5xc8vO6afwaAFIgMJcnxoEviEkeUkFf9V6/MEFe1v0=
X-Received: by 2002:a05:6402:40c2:b0:5ce:b120:a080 with SMTP id
 4fb4d7f45d1cf-5ceb120a12cmr9186825a12.13.1730585060111; Sat, 02 Nov 2024
 15:04:20 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sat, 2 Nov 2024 15:04:19 -0700
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <20241101.110842.137608817097414398.enometh@HIDDEN>
References: <20241031.160649.1619221016115134543.enometh@HIDDEN>
 <handler.74132.B.173037135112690.ack <at> debbugs.gnu.org>
 <20241101.110842.137608817097414398.enometh@HIDDEN>
MIME-Version: 1.0
Date: Sat, 2 Nov 2024 15:04:19 -0700
Message-ID: <CADwFkmnzgeu2vcFBWhXVCqqgw3fK7W071o27sXpMx6UPKnSv_Q@HIDDEN>
Subject: Re: bug#74132: Acknowledgement (31.0.50;
 thing-at-pt, ffap and Github markdown)
To: Madhu <enometh@HIDDEN>, 74132 <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 74132
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Madhu <enometh@HIDDEN> writes:

> There was a typo in the patch I posted. It should instead look like this

Could you please resend the amended patch as an attachment?

Also, how about having some tests for this?

> ```
> diff --git a/lisp/thingatpt.el b/lisp/thingatpt.el
> --- a/lisp/thingatpt.el
> +++ b/lisp/thingatpt.el
> @@ -502,9 +502,15 @@ thing-at-point-bounds-of-url-at-point
>        (let* ((allowed-chars "--:=&?$+@-Z_[:alpha:]~#,%;*()!'[]")
>  	     (skip-before "^[0-9a-zA-Z]")
>  	     (skip-after  ":;.,!?'")
> +             (hard-beg (and thing-at-point-beginning-of-url-regexp
> +                            (save-excursion
> +                              (and
> +                               (re-search-backward
> +                                thing-at-point-beginning-of-url-regexp nil t)
> +                               (point)))))
>  	     (pt (point))
>  	     (beg (save-excursion
> -		    (skip-chars-backward allowed-chars)
> +		    (skip-chars-backward allowed-chars hard-beg)
>  		    (skip-chars-forward skip-before pt)
>  		    (point)))
>  	     (end (save-excursion
> ```
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#74132; Package emacs. Full text available.

Message received at 74132 <at> debbugs.gnu.org:


Received: (at 74132) by debbugs.gnu.org; 1 Nov 2024 05:38:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 01 01:38:50 2024
Received: from localhost ([127.0.0.1]:46876 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1t6kN0-00025e-Ie
	for submit <at> debbugs.gnu.org; Fri, 01 Nov 2024 01:38:50 -0400
Received: from smtp0.ctinetworks.com ([205.166.61.207]:51258)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <enometh@HIDDEN>) id 1t6kMy-00025Y-1L
 for 74132 <at> debbugs.gnu.org; Fri, 01 Nov 2024 01:38:48 -0400
X-ctinetworks-Watermark: 1731303526.69588@TbC8g8Gjpnpj9EKWP2B71w
X-ctinetworks-Envelope-From: enometh@HIDDEN
X-ctinetworks-SpamCheck: 
X-ctinetworks-VirusCheck: Found to be clean
X-ctinetworks-Message-ID: 7DF94601C.A5514
Received: from localhost (unknown [117.254.37.0])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 (Authenticated sender: enometh@HIDDEN)
 by smtp0.ctinetworks.com (Postfix) with ESMTPSA id 7DF94601C
 for <74132 <at> debbugs.gnu.org>; Fri,  1 Nov 2024 01:38:45 -0400 (EDT)
Date: Fri, 01 Nov 2024 11:08:42 +0530 (IST)
Message-Id: <20241101.110842.137608817097414398.enometh@HIDDEN>
To: 74132 <at> debbugs.gnu.org
Subject: Re: bug#74132: Acknowledgement (31.0.50; thing-at-pt, ffap and
 Github markdown)
From: Madhu <enometh@HIDDEN>
In-Reply-To: <handler.74132.B.173037135112690.ack <at> debbugs.gnu.org>
References: <20241031.160649.1619221016115134543.enometh@HIDDEN>
 <handler.74132.B.173037135112690.ack <at> debbugs.gnu.org>
X-Mailer: Mew version 6.9 on Emacs 31.0.50
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 74132
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

There was a typo in the patch I posted. It should instead look like this
```
diff --git a/lisp/thingatpt.el b/lisp/thingatpt.el
--- a/lisp/thingatpt.el
+++ b/lisp/thingatpt.el
@@ -502,9 +502,15 @@ thing-at-point-bounds-of-url-at-point
       (let* ((allowed-chars "--:=&?$+@-Z_[:alpha:]~#,%;*()!'[]")
 	     (skip-before "^[0-9a-zA-Z]")
 	     (skip-after  ":;.,!?'")
+             (hard-beg (and thing-at-point-beginning-of-url-regexp
+                            (save-excursion
+                              (and
+                               (re-search-backward
+                                thing-at-point-beginning-of-url-regexp nil t)
+                               (point)))))
 	     (pt (point))
 	     (beg (save-excursion
-		    (skip-chars-backward allowed-chars)
+		    (skip-chars-backward allowed-chars hard-beg)
 		    (skip-chars-forward skip-before pt)
 		    (point)))
 	     (end (save-excursion
```
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#74132; Package emacs. Full text available.
Added tag(s) patch. Request was from Stefan Kangas <stefankangas@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 31 Oct 2024 10:42:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Oct 31 06:42:31 2024
Received: from localhost ([127.0.0.1]:41595 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1t6SdK-0003Ib-UB
	for submit <at> debbugs.gnu.org; Thu, 31 Oct 2024 06:42:31 -0400
Received: from lists.gnu.org ([209.51.188.17]:57514)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <enometh@HIDDEN>) id 1t6SdH-0003IS-Gv
 for submit <at> debbugs.gnu.org; Thu, 31 Oct 2024 06:42:29 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <enometh@HIDDEN>) id 1t6SdF-0004mr-57
 for bug-gnu-emacs@HIDDEN; Thu, 31 Oct 2024 06:42:26 -0400
Received: from smtp0.ctinetworks.com ([205.166.61.207])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <enometh@HIDDEN>) id 1t6SdC-00088d-Dp
 for bug-gnu-emacs@HIDDEN; Thu, 31 Oct 2024 06:42:24 -0400
X-ctinetworks-Watermark: 1731235341.49993@R/A0v5/5scwRcHdNk/ZayQ
X-ctinetworks-Envelope-From: enometh@HIDDEN
X-ctinetworks-SpamCheck: 
X-ctinetworks-VirusCheck: Found to be clean
X-ctinetworks-Message-ID: 920F399E8.A2FF0
Received: from localhost (unknown [117.254.37.96])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits))
 (No client certificate requested)
 (Authenticated sender: enometh@HIDDEN)
 by smtp0.ctinetworks.com (Postfix) with ESMTPSA id 920F399E8
 for <bug-gnu-emacs@HIDDEN>; Thu, 31 Oct 2024 06:42:19 -0400 (EDT)
Date: Thu, 31 Oct 2024 16:06:49 +0530 (IST)
Message-Id: <20241031.160649.1619221016115134543.enometh@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 31.0.50; thing-at-pt, ffap and Github markdown
From: Madhu <enometh@HIDDEN>
X-Mailer: Mew version 6.9 on Emacs 31.0.50
Mime-Version: 1.0
Content-Type: Multipart/Mixed;
 boundary="--Next_Part(Thu_Oct_31_16_06_49_2024_217)--"
Content-Transfer-Encoding: 7bit
Received-SPF: pass client-ip=205.166.61.207; envelope-from=enometh@HIDDEN;
 helo=smtp0.ctinetworks.com
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9,
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

----Next_Part(Thu_Oct_31_16_06_49_2024_217)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Consider the following text as is typically found on README.md

```
[![GitHub Releases Downloads](https://img.shields.io/github/downloads/raysan5/raylib/total)](https://github.com/raysan5/raylib/releases)
```

If the point is say at "r" at "raylib/releases", invoking
(ffap-url-at-point) fails.  this eventually calls
thing-at-point-bounds-of-url-at-point, which has hardcoded behaviour
to, skip over "allowed characters" backwards to find the beginning of
the bound. here it it finds the space character (in "Release
Downloads") and the whole thing fails.

This particular failure can be addressed by supplying the lim
paramater to the skip-chars-backward, as shown in the attached
patch.

does this look like a problem which ought to be solved? and is this
appropriate? (I was going to post on emacs-devel but decided to post
to the bug list instead) -- Best Regards, Madhu


----Next_Part(Thu_Oct_31_16_06_49_2024_217)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="0001-lisp-thingatpt.el-recognize-urls-better-in-markdown-.patch"

From 5971b7c10d7c38d540fdf278a0cd559c96b10ed2 Mon Sep 17 00:00:00 2001
From: Madhu <enometh@HIDDEN>
Date: Thu, 31 Oct 2024 15:40:42 +0530
Subject: [PATCH] lisp/thingatpt.el: recognize urls better in markdown text

* lisp/thingatpt.el: (thing-at-point-bounds-of-url-at-point): supply a
LIM when calling (skip-chars-backward allowed-chars), which is the
position where `thing-at-point-beginning-of-url-regexp' matches
backwards

problematic url e.g.
```
[![GitHub Releases Downloads](https://img.shields.io/github/downloads/raysan5/raylib/total)](https://github.com/raysan5/raylib/releases)
```
If the point is in the the second url, skip-chars-backwards goes to the
space (between s and D) and `ffap-url-at-point' eventually fails.
but if we supply a limit with a left anchor, we work around it.
---
 lisp/thingatpt.el | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/lisp/thingatpt.el b/lisp/thingatpt.el
index 3cfd3905701..0b8e28af5b9 100644
--- a/lisp/thingatpt.el
+++ b/lisp/thingatpt.el
@@ -502,9 +502,14 @@ thing-at-point-bounds-of-url-at-point
       (let* ((allowed-chars "--:=&?$+@-Z_[:alpha:]~#,%;*()!'[]")
 	     (skip-before "^[0-9a-zA-Z]")
 	     (skip-after  ":;.,!?'")
+             (hard-beg (and thing-at-point-beginning-of-url-regexp
+                            (save-excursion
+                              (re-search-backward
+                               thing-at-point-beginning-of-url-regexp nil t)
+                              (point))))
 	     (pt (point))
 	     (beg (save-excursion
-		    (skip-chars-backward allowed-chars)
+		    (skip-chars-backward allowed-chars hard-beg)
 		    (skip-chars-forward skip-before pt)
 		    (point)))
 	     (end (save-excursion
-- 
2.46.0.27.gfa3b914457


----Next_Part(Thu_Oct_31_16_06_49_2024_217)----
Acknowledgement sent to Madhu <enometh@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#74132; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Thu, 13 Feb 2025 11:30:03 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.