GNU logs - #74192, boring messages

Message sent to bug-gzip@HIDDEN:

Subject: bug#74192: [PATCH] build: update gnulib to latest, to enable faster crc
Resent-From: Sam Russell <sam.h.russell@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gzip@HIDDEN
Resent-Date: Sun, 03 Nov 2024 16:16:02 +0000
Resent-Message-ID: <handler.74192.B.173065053216877 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 74192 <at> debbugs.gnu.org
MIME-Version: 1.0
From: Sam Russell <sam.h.russell@HIDDEN>
Date: Sun, 3 Nov 2024 10:52:39 +0100
Message-ID: <CAJm+voV+9ka+YxafEeD5NpxLy=bP4SZjeHhp6Qfhm3zLpDBZNw@HIDDEN>
Content-Type: multipart/mixed; boundary="0000000000009a98190625ff2153"
Received-SPF: pass client-ip=2607:f8b0:4864:20::b34;
 envelope-from=sam.h.russell@HIDDEN; helo=mail-yb1-xb34.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Mailman-Approved-At: Sun, 03 Nov 2024 11:15:30 -0500
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

--0000000000009a98190625ff2153
Content-Type: multipart/alternative; boundary="0000000000009a98170625ff2151"

--0000000000009a98170625ff2151
Content-Type: text/plain; charset="UTF-8"

Hi,

This patch updates to the latest version of gnulib and speeds up gzip by
about ~35%:

$ time ./gzip_old -c -d -k large_file.gz > /dev/null

real    0m0.502s
user    0m0.473s
sys     0m0.030s
$ time ./gzip_new -c -d -k large_file.gz > /dev/null

real    0m0.318s
user    0m0.303s
sys     0m0.010s

I'm not sure what your conventions are around updating submodules, I see
the last update was September 8, also related to CRC code.

A quick browse showed this commit might be an issue:

commit 134978bd830b73d9bd7698f8ec2442d541056df1
Author: Bruno Haible <bruno@HIDDEN>
Date:   Mon Sep 9 15:46:44 2024 +0200

    striconv, striconveh: Drop workaround for glibc 2.1.

    * lib/striconv.c (str_iconv): Remove glibc-2.1 bug workaround.
    * lib/striconveh.c (iconveh_open): Likewise.

Not sure if that means glibc 2.1 is deprected, or what impact that might
have for gzip, but that seemed like the main thing that could be of concern.

Cheers
Sam

--0000000000009a98170625ff2151
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,<div><br></div><div>This patch updates to the latest ve=
rsion of gnulib and speeds up gzip by about ~35%:</div><div><br></div><div>=
$ time ./gzip_old -c -d -k large_file.gz &gt; /dev/null<br><br>real =C2=A0 =
=C2=A00m0.502s<br>user =C2=A0 =C2=A00m0.473s<br>sys =C2=A0 =C2=A0 0m0.030s<=
br>$ time ./gzip_new -c -d -k large_file.gz &gt; /dev/null<br><br>real =C2=
=A0 =C2=A00m0.318s<br>user =C2=A0 =C2=A00m0.303s<br>sys =C2=A0 =C2=A0 0m0.0=
10s<br><div><br></div><div>I&#39;m not sure what your conventions are aroun=
d updating submodules, I see the last update was September 8, also related =
to CRC code.</div><div><br></div><div>A quick browse showed this commit mig=
ht be an issue:</div><div><br></div><div>commit 134978bd830b73d9bd7698f8ec2=
442d541056df1<br>Author: Bruno Haible &lt;<a href=3D"mailto:bruno@HIDDEN=
">bruno@HIDDEN</a>&gt;<br>Date: =C2=A0 Mon Sep 9 15:46:44 2024 +0200<br>=
<br>=C2=A0 =C2=A0 striconv, striconveh: Drop workaround for glibc 2.1.<br><=
br>=C2=A0 =C2=A0 * lib/striconv.c (str_iconv): Remove glibc-2.1 bug workaro=
und.<br>=C2=A0 =C2=A0 * lib/striconveh.c (iconveh_open): Likewise.</div><di=
v><br></div><div>Not sure if that means glibc 2.1 is deprected, or what imp=
act that might have for gzip, but that seemed like the main thing that coul=
d be of concern.</div><div><br></div><div>Cheers</div><div>Sam</div></div><=
/div>

--0000000000009a98170625ff2151--

--0000000000009a98190625ff2153
Content-Type: application/octet-stream; 
	name="0001-build-update-gnulib-to-latest-to-enable-faster-crc.patch"
Content-Disposition: attachment; 
	filename="0001-build-update-gnulib-to-latest-to-enable-faster-crc.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_m31eud700>
X-Attachment-Id: f_m31eud700

RnJvbSBlYzczYTc2YWM3MTQxOGIwOWQxNjk3YzBjNGM3MTNhNTExZDVmMmM4IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBTYW0gUnVzc2VsbCA8c2FtLmgucnVzc2VsbEBnbWFpbC5jb20+
CkRhdGU6IFN1biwgMyBOb3YgMjAyNCAxMDo0ODoxMiArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIGJ1
aWxkOiB1cGRhdGUgZ251bGliIHRvIGxhdGVzdCwgdG8gZW5hYmxlIGZhc3RlciBjcmMKCi0tLQog
Z251bGliIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9u
KC0pCgpkaWZmIC0tZ2l0IGEvZ251bGliIGIvZ251bGliCmluZGV4IDU2NmNmYjAuLjEwOGZkMWYg
MTYwMDAwCi0tLSBhL2dudWxpYgorKysgYi9nbnVsaWIKQEAgLTEgKzEgQEAKLVN1YnByb2plY3Qg
Y29tbWl0IDU2NmNmYjA3YjZlYzQ2ZmQ3MGNiYTgyMzliZThlNmVkMWFjMjg1MWYKK1N1YnByb2pl
Y3QgY29tbWl0IDEwOGZkMWY5MmE0MmM0MjQ2ODVmM2NiNzkzN2JiMzIzYjk3OTUyNjMKLS0gCjIu
MzQuMQoK
--0000000000009a98190625ff2153--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Sam Russell <sam.h.russell@HIDDEN>
Subject: bug#74192: Acknowledgement ([PATCH] build: update gnulib to
 latest, to enable faster crc)
Message-ID: <handler.74192.B.173065053216877.ack <at> debbugs.gnu.org>
References: <CAJm+voV+9ka+YxafEeD5NpxLy=bP4SZjeHhp6Qfhm3zLpDBZNw@HIDDEN>
X-Gnu-PR-Message: ack 74192
X-Gnu-PR-Package: gzip
X-Gnu-PR-Keywords: patch
Reply-To: 74192 <at> debbugs.gnu.org
Date: Sun, 03 Nov 2024 16:16:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gzip@HIDDEN

If you wish to submit further information on this problem, please
send it to 74192 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
74192: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D74192
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gzip@HIDDEN:

Subject: bug#74192: [PATCH] build: update gnulib to latest, to enable faster crc
Resent-From: Paul Eggert <eggert@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gzip@HIDDEN
Resent-Date: Sun, 03 Nov 2024 19:58:01 +0000
Resent-Message-ID: <handler.74192.B74192.173066387210938 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Sam Russell <sam.h.russell@HIDDEN>, 74192 <at> debbugs.gnu.org
Message-ID: <43956bff-e8a5-4c6d-83eb-3c8a4cf54bbd@HIDDEN>
Date: Sun, 3 Nov 2024 11:57:42 -0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
References: <CAJm+voV+9ka+YxafEeD5NpxLy=bP4SZjeHhp6Qfhm3zLpDBZNw@HIDDEN>
Content-Language: en-US
From: Paul Eggert <eggert@HIDDEN>
Organization: UCLA Computer Science Department
In-Reply-To: <CAJm+voV+9ka+YxafEeD5NpxLy=bP4SZjeHhp6Qfhm3zLpDBZNw@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On 2024-11-03 01:52, Sam Russell wrote:
>      * lib/striconv.c (str_iconv): Remove glibc-2.1 bug workaround.
>      * lib/striconveh.c (iconveh_open): Likewise.
> 
> Not sure if that means glibc 2.1 is deprected,

I think it does, but we don't need to worry about that.

Thanks for the heads-up. I have a few more Gnulib changes (in memory 
allocation) that I want to commit before syncing Gnulib to other projects.

Message sent to bug-gzip@HIDDEN:

Subject: bug#74192: [PATCH] build: update gnulib to latest, to enable faster crc
Resent-From: Sam Russell <sam.h.russell@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gzip@HIDDEN
Resent-Date: Sun, 03 Nov 2024 22:44:01 +0000
Resent-Message-ID: <handler.74192.B74192.173067384032684 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Paul Eggert <eggert@HIDDEN>
Cc: 74192 <at> debbugs.gnu.org
MIME-Version: 1.0
References: <CAJm+voV+9ka+YxafEeD5NpxLy=bP4SZjeHhp6Qfhm3zLpDBZNw@HIDDEN>
 <43956bff-e8a5-4c6d-83eb-3c8a4cf54bbd@HIDDEN>
In-Reply-To: <43956bff-e8a5-4c6d-83eb-3c8a4cf54bbd@HIDDEN>
From: Sam Russell <sam.h.russell@HIDDEN>
Date: Sun, 3 Nov 2024 21:03:19 +0100
Message-ID: <CAJm+voW-LVuo7GiUASK8-AcEFTpfNgcvLVY344hEOAoEks7ntA@HIDDEN>
Content-Type: multipart/alternative; boundary="000000000000624f75062607a99c"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--000000000000624f75062607a99c
Content-Type: text/plain; charset="UTF-8"

perfect, no rush, just wanted to confirm that I have a local build from
head that works

On Sun, Nov 3, 2024, 20:57 Paul Eggert <eggert@HIDDEN> wrote:

> On 2024-11-03 01:52, Sam Russell wrote:
> >      * lib/striconv.c (str_iconv): Remove glibc-2.1 bug workaround.
> >      * lib/striconveh.c (iconveh_open): Likewise.
> >
> > Not sure if that means glibc 2.1 is deprected,
>
> I think it does, but we don't need to worry about that.
>
> Thanks for the heads-up. I have a few more Gnulib changes (in memory
> allocation) that I want to commit before syncing Gnulib to other projects.
>

--000000000000624f75062607a99c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<p dir=3D"ltr">perfect, no rush, just wanted to confirm that I have a local=
 build from head that works </p>
<br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Sun=
, Nov 3, 2024, 20:57 Paul Eggert &lt;<a href=3D"mailto:eggert@HIDDEN">=
eggert@HIDDEN</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote=
" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">O=
n 2024-11-03 01:52, Sam Russell wrote:<br>
&gt;=C2=A0 =C2=A0 =C2=A0 * lib/striconv.c (str_iconv): Remove glibc-2.1 bug=
 workaround.<br>
&gt;=C2=A0 =C2=A0 =C2=A0 * lib/striconveh.c (iconveh_open): Likewise.<br>
&gt; <br>
&gt; Not sure if that means glibc 2.1 is deprected,<br>
<br>
I think it does, but we don&#39;t need to worry about that.<br>
<br>
Thanks for the heads-up. I have a few more Gnulib changes (in memory <br>
allocation) that I want to commit before syncing Gnulib to other projects.<=
br>
</blockquote></div>

--000000000000624f75062607a99c--

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.