GNU logs - #74194, boring messages

Message sent to bug-coreutils@HIDDEN:

Subject: bug#74194: compilation error: 'S_MAGIC_BCACHEFS' undeclared
Resent-From: Bruno Haible <bruno@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-coreutils@HIDDEN
Resent-Date: Sun, 03 Nov 2024 23:15:01 +0000
Resent-Message-ID: <handler.74194.B.17306756953991 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 74194 <at> debbugs.gnu.org
From: Bruno Haible <bruno@HIDDEN>
Date: Mon, 04 Nov 2024 00:14:16 +0100
Message-ID: <1867774.e4xvhzFMnl@nimes>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="nextPart1815047.K29ADDU3aD"
Content-Transfer-Encoding: 7Bit
Received-SPF: none client-ip=81.169.146.162; envelope-from=bruno@HIDDEN;
 helo=mo4-p00-ob.smtp.rzone.de
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
 SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

This is a multi-part message in MIME format.

--nextPart1815047.K29ADDU3aD
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"

Hi,

Building coreutils from source, today, I encountered this compilation error:

  CC       src/stat.o
=2E./src/stat.c: In function 'human_fstype':
=2E./src/stat.c:304:10: error: 'S_MAGIC_BCACHEFS' undeclared (first use in =
this function); did you mean 'S_MAGIC_TRACEFS'?
  304 |     case S_MAGIC_BCACHEFS: /* 0xCA451A4E local */
      |          ^~~~~~~~~~~~~~~~
      |          S_MAGIC_TRACEFS
=2E./src/stat.c:304:10: note: each undeclared identifier is reported only o=
nce for each function it appears in
=2E./src/stat.c:378:10: error: 'S_MAGIC_FUSE' undeclared (first use in this=
 function); did you mean 'S_MAGIC_UFS'?
  378 |     case S_MAGIC_FUSE: /* 0x65735546 remote */
      |          ^~~~~~~~~~~~
      |          S_MAGIC_UFS
=2E./src/stat.c:463:10: error: 'S_MAGIC_PID_FS' undeclared (first use in th=
is function); did you mean 'S_MAGIC_PRL_FS'?
  463 |     case S_MAGIC_PID_FS: /* 0x50494446 local */
      |          ^~~~~~~~~~~~~~
      |          S_MAGIC_PRL_FS
make[2]: *** [Makefile:12874: src/stat.o] Error 1

I understand that the list of S_* macros is meant to be defined in src/fs.h,
which is meant to be autogenerated from src/stat.c.

History:
=2D In July I had apparently built coreutils in this checkout.
=2D Now I did a 'git pull', 'make -k distclean', then
  built in a subdir 'build-64' (VPATH build).

The files that I have in this checkout at this point:

$ ls -l src/fs.h src/fs-is-local.h=20
=2Dr--r--r-- 1 bruno bruno 4755 Jul 21 18:15 src/fs.h
=2Dr--r--r-- 1 bruno bruno 5157 Jul 21 18:15 src/fs-is-local.h
$ ls -l src/stat.c=20
=2Drw-rw-r-- 1 bruno bruno 57973 Aug 14 14:38 src/stat.c

I tried this:

$ ./configure; make distclean
$ ls -l src/fs.h src/fs-is-local.h=20
=2Dr--r--r-- 1 bruno bruno 4755 Jul 21 18:15 src/fs.h
=2Dr--r--r-- 1 bruno bruno 5157 Jul 21 18:15 src/fs-is-local.h

This is normal: since src/fs.h and src/fs-is-local.h are contained in the
tarball, "make distclean" does not remove them.

Now I try a non-VPATH build:

$ ./configure; make
$ ls -l src/fs.h src/fs-is-local.h=20
=2Dr--r--r-- 1 bruno bruno 4824 Nov  3 23:39 src/fs.h
=2Dr--r--r-- 1 bruno bruno 5230 Nov  3 23:39 src/fs-is-local.h

This one succeeded, because src/fs.h was regenerated now.

The question thus is: Why was src/fs.h not regenerated in the VPATH build
earlier?

To reproduce this, I
  - remove the 3 entries from src/fs.h,
  - $ touch -d 'Jul 21 18:15' src/fs.h
  - $ mkdir build-64; cd build-64; ../configure; make

What I see is:

1) build-64/src/fs.h has been created, and it contains the 3 entries.

2) In the compilation command, -Isrc occurs before -I../src.

   gcc  -I. -I.. -I./lib  -Ilib -I../lib -Isrc -I../src -Wall   -g -O2 -c -=
o src/stat.o ../src/stat.c

   Use of option -E shows that despite this ordering of -I options,
   ../src/fs.h gets included. Apparently because it sits in the same
   directory as ../src/stat.c.

So the bug is that fs.h was created in the build directory, not in
the source directory. The GNU Coding Standards
<https://www.gnu.org/prep/standards/html_node/Makefile-Basics.html>
say that the file should be generated in the source directory:

  "GNU distributions usually contain some files which are not source
   files=E2=80=94for example, Info files, and the output from Autoconf, Aut=
omake,
   Bison or Flex. Since these files normally appear in the source
   directory, they should always appear in the source directory,
   not in the build directory. So Makefile rules to update them should
   put the updated files in the source directory."

The attached patch fixes this GCS violation and thus fixes the compilation
error.


--nextPart1815047.K29ADDU3aD
Content-Disposition: attachment; filename="0001-build-Regenerate-distributed-built-files-in-top_srcd.patch"
Content-Transfer-Encoding: 7Bit
Content-Type: text/x-patch; charset="UTF-8"; name="0001-build-Regenerate-distributed-built-files-in-top_srcd.patch"

From a750d2b575520966e361753d9a0aebf9cc6809c8 Mon Sep 17 00:00:00 2001
From: Bruno Haible <bruno@HIDDEN>
Date: Mon, 4 Nov 2024 00:11:40 +0100
Subject: [PATCH] build: Regenerate distributed built files in $(top_srcdir)

* src/local.mk (src/dircolors.h, src/fs-is-local.h, src/fs.h): Generate
in $(top_srcdir).
---
 src/local.mk | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/local.mk b/src/local.mk
index 8133925ac..feea9a6c9 100644
--- a/src/local.mk
+++ b/src/local.mk
@@ -521,8 +521,8 @@ clean-local:
 	done
 
 
-BUILT_SOURCES += src/dircolors.h
-src/dircolors.h: src/dcgen src/dircolors.hin
+BUILT_SOURCES += $(top_srcdir)/src/dircolors.h
+$(top_srcdir)/src/dircolors.h: src/dcgen src/dircolors.hin
 	$(AM_V_GEN)rm -f $@ $@-t
 	$(AM_V_at)${MKDIR_P} src
 	$(AM_V_at)$(PERL) -w -- $(srcdir)/src/dcgen \
@@ -614,8 +614,8 @@ src/fs-kernel-magic: Makefile src/fs-latest-magic.h
 	  | $(ASSORT) -u						\
 	  > $@-t && mv $@-t $@
 
-BUILT_SOURCES += src/fs-is-local.h
-src/fs-is-local.h: src/stat.c src/extract-magic
+BUILT_SOURCES += $(top_srcdir)/src/fs-is-local.h
+$(top_srcdir)/src/fs-is-local.h: src/stat.c src/extract-magic
 	$(AM_V_GEN)rm -f $@
 	$(AM_V_at)${MKDIR_P} src
 	$(AM_V_at)$(PERL) $(srcdir)/src/extract-magic \
@@ -623,8 +623,8 @@ src/fs-is-local.h: src/stat.c src/extract-magic
 	$(AM_V_at)chmod a-w $@t
 	$(AM_V_at)mv $@t $@
 
-BUILT_SOURCES += src/fs.h
-src/fs.h: src/stat.c src/extract-magic
+BUILT_SOURCES += $(top_srcdir)/src/fs.h
+$(top_srcdir)/src/fs.h: src/stat.c src/extract-magic
 	$(AM_V_GEN)rm -f $@
 	$(AM_V_at)${MKDIR_P} src
 	$(AM_V_at)$(PERL) $(srcdir)/src/extract-magic \
-- 
2.34.1


--nextPart1815047.K29ADDU3aD--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Bruno Haible <bruno@HIDDEN>
Subject: bug#74194: Acknowledgement (compilation error: 'S_MAGIC_BCACHEFS'
 undeclared)
Message-ID: <handler.74194.B.17306756953991.ack <at> debbugs.gnu.org>
References: <1867774.e4xvhzFMnl@nimes>
X-Gnu-PR-Message: ack 74194
X-Gnu-PR-Package: coreutils
Reply-To: 74194 <at> debbugs.gnu.org
Date: Sun, 03 Nov 2024 23:15:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-coreutils@HIDDEN

If you wish to submit further information on this problem, please
send it to 74194 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
74194: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D74194
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-coreutils@HIDDEN:

Subject: bug#74194: compilation error: 'S_MAGIC_BCACHEFS' undeclared
Resent-From: Paul Eggert <eggert@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-coreutils@HIDDEN
Resent-Date: Sun, 03 Nov 2024 23:54:02 +0000
Resent-Message-ID: <handler.74194.B74194.17306780039057 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Bruno Haible <bruno@HIDDEN>, 74194 <at> debbugs.gnu.org
Message-ID: <b0fd0c0a-875e-4650-92fa-b48aed747a77@HIDDEN>
Date: Sun, 3 Nov 2024 15:53:12 -0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
References: <1867774.e4xvhzFMnl@nimes>
Content-Language: en-US
From: Paul Eggert <eggert@HIDDEN>
Organization: UCLA Computer Science Department
In-Reply-To: <1867774.e4xvhzFMnl@nimes>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Thanks, I installed that patch.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 16 Feb 2025 06:58:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 16 01:58:51 2025
Received: from localhost ([127.0.0.1]:59698 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tjYc6-0000Xc-Mw
	for submit <at> debbugs.gnu.org; Sun, 16 Feb 2025 01:58:50 -0500
Received: from mail.cs.ucla.edu ([131.179.128.66]:41272)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eggert@HIDDEN>)
 id 1tjYc4-0000XJ-AU
 for control <at> debbugs.gnu.org; Sun, 16 Feb 2025 01:58:48 -0500
Received: from localhost (localhost [127.0.0.1])
 by mail.cs.ucla.edu (Postfix) with ESMTP id B42513C00E415
 for <control <at> debbugs.gnu.org>; Sat, 15 Feb 2025 22:58:42 -0800 (PST)
Received: from mail.cs.ucla.edu ([127.0.0.1])
 by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP
 id UNS52wPzlaiO for <control <at> debbugs.gnu.org>;
 Sat, 15 Feb 2025 22:58:42 -0800 (PST)
Received: from localhost (localhost [127.0.0.1])
 by mail.cs.ucla.edu (Postfix) with ESMTP id 544723C00E41C
 for <control <at> debbugs.gnu.org>; Sat, 15 Feb 2025 22:58:42 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 544723C00E41C
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu;
 s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1739689122;
 bh=SVQ/gcc45eTT73KzgPWfKuaPFT5aSqflTr9MAI/aVS4=;
 h=Message-ID:Date:MIME-Version:To:From;
 b=JrHvtUHs1RtuxZXmG+lLRj13bunbeqow9OFro+5oQ674s/0BCvwQYfYgcCW2XGicG
 dSFFQGOAFFbejXGkXm+HWSOSbV4DV38Bbs9pORQXY/L+Hd0LOs65r7OdXmHZzd7e21
 23rceNiZYqeYumYcpdmFkuGGUW9Zu5tUW2WL8FWabXYRNyPzqF+HDiu6l307k91U7W
 OL0ET+MgmpFbAIT7BbbjHuVM7nzPcwSZRc1jt3hQ35NwJcZeI0yDnTs8YdlPhiFuut
 ybX4H09imLgTFYBXEurk8qMwBA3+2NuYnEYGjLeaqIIluWPhXIUM8+xDICuwwnKA2R
 oK3L7NDIeKwug==
X-Virus-Scanned: amavis at mail.cs.ucla.edu
Received: from mail.cs.ucla.edu ([127.0.0.1])
 by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP
 id w3IJTT58v7eV for <control <at> debbugs.gnu.org>;
 Sat, 15 Feb 2025 22:58:42 -0800 (PST)
Received: from [192.168.254.12] (unknown [47.147.225.25])
 by mail.cs.ucla.edu (Postfix) with ESMTPSA id 3C6763C00E415
 for <control <at> debbugs.gnu.org>; Sat, 15 Feb 2025 22:58:42 -0800 (PST)
Message-ID: <d3313a51-ea4c-4bd1-ae8b-ef173a233eb9@HIDDEN>
Date: Sat, 15 Feb 2025 22:58:42 -0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: control <at> debbugs.gnu.org
From: Paul Eggert <eggert@HIDDEN>
Subject: coreutils bug maintenance
Organization: UCLA Computer Science Department
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

severity 76060 wishlist
severity 75994 wishlist
severity 75649 wishlist
severity 73510 wishlist
severity 73331 wishlist
severity 71307 wishlist
severity 73784 wishlist
tags 73194 notabug
close 74194
close 73194
close 73134
close 72756
severity 72024 wishlist
tags 71895 moreinfo unreproducible
tags 69636 notabug
close 69636
severity 69368 wishlist

Last modified: Sun, 16 Feb 2025 07:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.