GNU logs - #74201, boring messages

Message sent to guix@HIDDEN, guix-patches@HIDDEN:

Subject: [bug#74201] [PATCH] gnu: ruby-ethon: Enable tests.
Resent-From: gemmaro <gemmaro.dev@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix@HIDDEN, guix-patches@HIDDEN
Resent-Date: Mon, 04 Nov 2024 07:16:02 +0000
Resent-Message-ID: <handler.74201.B.173070452231243 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 74201 <at> debbugs.gnu.org
Cc: gemmaro <gemmaro.dev@HIDDEN>, Christopher Baines <guix@HIDDEN>
From: gemmaro <gemmaro.dev@HIDDEN>
Date: Mon,  4 Nov 2024 16:14:28 +0900
Message-ID: <9e9174d6e714f9ce79d8e725130e4ad669b65fd4.1730704468.git.gemmaro.dev@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2607:f8b0:4864:20::431;
 envelope-from=gemmaro.dev@HIDDEN; helo=mail-pf1-x431.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

* gnu/packages/ruby.scm (ruby-ethon): Enable tests.
[source]: Switch to use the Git repository, which includes test files.
[arguments]<#:tests?>: Remove it to enable tests by default.
<#:phases>: Add a phase to relax the mime-types gem version constraint.
Add a phase to remove Bundler setup, and replace the check phase to directly
run RSpec, in order to avoid perf dependencies.
Because of this, #:test-target is not needed to be "spec".
[native-inputs]: Add test dependencies.

Change-Id: Ie46d682ccb5e9b5048a109cd8587e2178c34f8ec
---
 gnu/packages/ruby.scm | 32 +++++++++++++++++++++++++++-----
 1 file changed, 27 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 12c439b3a9..3f0d32e8b5 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -3082,22 +3082,44 @@ (define-public ruby-ethon
     (version "0.12.0")
     (source
      (origin
-       (method url-fetch)
-       (uri (rubygems-uri "ethon" version))
+       (method git-fetch) ;for tests
+       (uri (git-reference
+             (url "https://github.com/typhoeus/ethon")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
        (sha256
         (base32
-         "0gggrgkcq839mamx7a8jbnp2h7x2ykfn34ixwskwb0lzx2ak17g9"))))
+         "0f29h4slja66kkc675rk4nnsxzhlgb143whx4ffx250w36ih0aq3"))))
     (build-system ruby-build-system)
     (arguments
      (list
-      #:tests? #f  ; no included tests
       #:phases
       #~(modify-phases %standard-phases
           (add-after 'unpack 'libcurl-use-absolute-reference
             (lambda* (#:key inputs #:allow-other-keys)
               (substitute* "lib/ethon/curls/settings.rb"
                 (("libcurl', 'libcurl\\.so\\.4")
-                 (search-input-file inputs "/lib/libcurl.so"))))))))
+                 (search-input-file inputs "/lib/libcurl.so")))))
+          (add-after 'extract-gemspec 'remove-MIME-types-version-constraint
+            (lambda _
+              (substitute* "Gemfile"
+                (("(gem \"mime-types\").*" _ gem)
+                 gem))))
+
+          ;; Tell Bundler not to request perf dependencies
+          (add-after 'extract-gemspec 'remove-Bundler-setup
+            (lambda _
+              (substitute* "spec/spec_helper.rb"
+                (("Bundler.setup")
+                 ""))))
+          (replace 'check
+            (lambda* (#:key tests? #:allow-other-keys)
+              (when tests?
+                (for-each (lambda (file)
+                            (invoke "ruby" "-Ispec" file))
+                          (find-files "spec" "_spec\\.rb$"))))))))
+    (native-inputs (list ruby-rspec ruby-sinatra ruby-mustermann
+                         ruby-mime-types ruby-webrick))
     (inputs
      (list curl))
     (propagated-inputs

base-commit: 547d97180471e90e404a948015f65431961aa273
-- 
2.46.0

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: gemmaro <gemmaro.dev@HIDDEN>
Subject: bug#74201: Acknowledgement ([PATCH] gnu: ruby-ethon: Enable tests.)
Message-ID: <handler.74201.B.173070452231243.ack <at> debbugs.gnu.org>
References: <9e9174d6e714f9ce79d8e725130e4ad669b65fd4.1730704468.git.gemmaro.dev@HIDDEN>
X-Gnu-PR-Message: ack 74201
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 74201 <at> debbugs.gnu.org
Date: Mon, 04 Nov 2024 07:16:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  Christopher Baines <guix@HIDDEN>
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 74201 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
74201: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D74201
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.