GNU bug report logs - #74405
[PATCH 0/1] antlr4 package does not refer to java executable by full path

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Rutherther <rutherther@HIDDEN>; Keywords: patch; merged with #74406; dated Sun, 17 Nov 2024 19:16:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 74405 <at> debbugs.gnu.org:


Received: (at 74405) by debbugs.gnu.org; 2 Jan 2025 13:51:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 02 08:51:50 2025
Received: from localhost ([127.0.0.1]:43190 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tTLc5-0001BC-5k
	for submit <at> debbugs.gnu.org; Thu, 02 Jan 2025 08:51:49 -0500
Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]:47259)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1tTLc2-0001At-I8; Thu, 02 Jan 2025 08:51:47 -0500
Received: by mail-pl1-x634.google.com with SMTP id
 d9443c01a7336-21680814d42so133374385ad.2; 
 Thu, 02 Jan 2025 05:51:46 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1735825900; x=1736430700; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=3Mos5f/ruxJ81Nnl75cvsMajVhvRdBSE2CanB+udvu8=;
 b=EOmdTvXGhmmZNu1bn+o10sbXcnvmJqxAJA681qtv38EK9roOjW0tGJ31G/ZE9ZKnxC
 ptG2CHB3LbhDsMYLyXPVqjrwndKxCqWWKGQhGuBzOn0qsXSs+TJPCaJQaH5TPqcivobM
 Dyr662UJcG3XgvYh22Ub8s1MZ+aCzZrd4KC7binOCflCQEGxcVDUbEyVjoFwbcTS/mmt
 bWjmOOvLl+hj8cm1RxCpEr033GxY8qI40MzwxlQOpApVfDKx8w30SlANUC7Ifq6Asz8p
 xuGJS2V2TWPci72Je33xzYKDZeXcmwvDXiTHUXHwZ1heIUcZyNGUE/HS7A9EpgVqB5/Z
 5I6A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1735825900; x=1736430700;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=3Mos5f/ruxJ81Nnl75cvsMajVhvRdBSE2CanB+udvu8=;
 b=e9dk+kajg6vvL7WjDP1JFHAcSpuZnHSiJ4seED5IiAIUWQb0ZgbrCorGysHISEKpHx
 PHV+acF5tevrTUOcAfAf9OUu1A3BK4zVTqAoTs6q7oTqzjq4+yO1x8onauWnUaaJ4cPS
 EiMpD5ke++0eNxrm5iJW4D6JRPNhiSn2f4L7Mum7tPSK2ZJfk3JyxB41GsE/wnrNqo+3
 jBFwJyj98bJo9/YyZbjpVrE4bwnr/2aZP4EcyEA0Q2FH/VVgSPAhqRMgg6ak6WL/dcYH
 nFRaj+lyddgIepjmoUOZ4zEZvlp7KucRxAEnuO/ixqosJKONZyRIyzBQsvB1H0No62zU
 HR0g==
X-Forwarded-Encrypted: i=1;
 AJvYcCWPVFoz3ZeuKRa1XQiQezLHguUWtDCP9ibDQZBK++Xs1W8Vih8kRdqqcGd6fMG72N4szpLcvg==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YwGt2+Jt6Ab329ShMtis8sDDe1GY5NC2rZF1KGx3NPDxE9DDE8g
 WVJfxQSDh7TYcBnaSMSF+wMFrj62pZ9w+VVLnT54shtwqoCpCePUNageT0QC
X-Gm-Gg: ASbGnctDlY3pwp1z4xtuNFVmobNTE608Xr8Jidkt5QPNj0A0Gr0fRYaLzesFwpl0QEP
 Oa8Cg0t76t1xB+VnvK2RbRz6rDCEiFxfGD4JkDdWUxloAWjJXq2dcyrSGhkgCgTqEcG1yEmOIwk
 vxNP2ptaQLZUBOjUY/TIkn1fncDPstMv+YuL60YbxBLbLbDLObU4xTZjyPTo7pmRzC3fBcFJvsN
 6svxtehHx0nLgxFObnDLV7eUYwF7Ej4mCJYCz05SZIbRIOPI072lQ==
X-Google-Smtp-Source: AGHT+IG1cXHduT7z+4SJDxLUJZbshYFpD01KnUs1j03nWidMESUdHswMweyChT3tqBzBNcHqPQvYiA==
X-Received: by 2002:a17:902:c406:b0:215:854c:a71a with SMTP id
 d9443c01a7336-219e6ebb68dmr545512085ad.34.1735825900393; 
 Thu, 02 Jan 2025 05:51:40 -0800 (PST)
Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89])
 by smtp.gmail.com with ESMTPSA id
 d9443c01a7336-219dca013f4sm227754135ad.234.2025.01.02.05.51.38
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 02 Jan 2025 05:51:39 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: Rutherther <rutherther@HIDDEN>
Subject: Re: [bug#74406] [PATCH 1/1] gnu: antlr4: Pass full path to java in
 bin executable
In-Reply-To: <27ea0b2b5326c827fd03399b4009c1bb62d81600.1731870758.git.rutherther@HIDDEN>
 (rutherther@HIDDEN's message of "Sun, 17 Nov 2024 20:43:58
 +0100")
References: <cover.1731870758.git.rutherther@HIDDEN>
 <27ea0b2b5326c827fd03399b4009c1bb62d81600.1731870758.git.rutherther@HIDDEN>
Date: Thu, 02 Jan 2025 22:51:28 +0900
Message-ID: <87wmfd5nof.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 74405
Cc: Julien Lepiller <julien@HIDDEN>, 74405 <at> debbugs.gnu.org,
 74406 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Rutherther,

Apologies for the delay, this had been tagged as SPAM by big G.

Rutherther <rutherther@HIDDEN> writes:

> The executable outputted by antlr4 package does not
> refer to full path of java, but to standalone "java".
> That means the package expects java to be in PATH.
> Since it's an application, requiring java to run,
> it should rather refer to full path of java executable
> it was built with/for.
>
> * gnu/packages/java.scm: (antrl4)[arguments]: Change "java" in bin/antlr4 for full path
>
> Change-Id: I311b9ec54a90fc7251eb8fcb62b232e843853e64
> ---
>  gnu/packages/java.scm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index df57385ea7..8607b62bea 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -8866,13 +8866,14 @@ (define-public antlr4
>           (add-after 'install 'bin-install
>             (lambda* (#:key inputs outputs #:allow-other-keys)
>               (let ((jar (string-append (assoc-ref outputs "out") "/share/java"))
> -                   (bin (string-append (assoc-ref outputs "out") "/bin")))
> +                   (bin (string-append (assoc-ref outputs "out") "/bin"))
> +                   (java (search-input-file inputs "bin/java")))
>                 (mkdir-p bin)
>                 (with-output-to-file (string-append bin "/antlr4")
>                   (lambda _
>                     (display
>                       (string-append "#!" (which "sh") "\n"
> -                                    "java -cp " jar "/antlr4.jar:"
> +                                    java " -cp " jar "/antlr4.jar:"

Hm.  I'm not sure what is the state of the art here for our Java
packages; it makes sense that it should work out of the box, but perhaps
there's a reason to want to have it run with any Java available on PATH?

I'll defer to Julien, which I believe has done more work with Java in
Guix.

-- 
Thanks,
Maxim




Information forwarded to guix-patches@HIDDEN:
bug#74405; Package guix-patches. Full text available.

Message received at 74405 <at> debbugs.gnu.org:


Received: (at 74405) by debbugs.gnu.org; 2 Jan 2025 13:48:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 02 08:48:55 2025
Received: from localhost ([127.0.0.1]:43176 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tTLZH-0000zR-CZ
	for submit <at> debbugs.gnu.org; Thu, 02 Jan 2025 08:48:55 -0500
Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]:52224)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1tTLZF-0000zI-GO
 for 74405 <at> debbugs.gnu.org; Thu, 02 Jan 2025 08:48:54 -0500
Received: by mail-pl1-x629.google.com with SMTP id
 d9443c01a7336-2165cb60719so156752805ad.0
 for <74405 <at> debbugs.gnu.org>; Thu, 02 Jan 2025 05:48:53 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1735825732; x=1736430532; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=QiXRNGcf7zc3AlmHtCC88cchnQfUoYKTelIv8zZhzVU=;
 b=gYbh8khnmiF8bQhM8oMdZ7AxHS7yB7N4ZygZpS6xgmKYx7U+j3MQ+qfk3a92p0gdIH
 J3w78LcVbGwLB+xb5yEopbSLQcgkrzOQsG9drEj7GY2lZs4Qyx4DTlm0QfzT2yxEfFsi
 TNCEzsXPCwgehdrrfI51K7ExMQBr1YooOHjwLBrHVL1K9G0m82qjlzsWIEOxjzXSTRIC
 5+IpSNzq6T5QhsYOsVrvp0d6WMQgeQObUsO11Je7vOLfNP+C3L3ftzKvszRMiQiXYWh2
 21Bx2030P63LQzDRKL3t2iHlfSb2anUED/cG63Qo7ZOPYUekOPyLMMWtu6x8iCg0TVJW
 3Iyw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1735825732; x=1736430532;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=QiXRNGcf7zc3AlmHtCC88cchnQfUoYKTelIv8zZhzVU=;
 b=BMVPy+lUmQUBJyPBsk5R+4vXPwXiYZMnyjt4X0Ts0a6O7Da7qB6vnWtIazsyzAP2gx
 5wkueKs5MRqj1u8ZJ+qfyvmHfFbMoDY6qoyLUI7N9jPpsTm5tgLmB+lmb8E/icfievtC
 K6ZljS3UYsbiUqAkShdrg5OMz8gCZNzIRe+oKvFg3of+0ggIO8xdx/eQSGh1OQ3aSi0R
 TIloTgupkdGXZsn9WckBp4y2kZvH4e+An4vgSBlNePEOkC03ClkfoXK5GIvzYEHELRZ+
 Ab6fEH3JM06/2mYBa/xVA+yzzJFWpbHILraZiKgp3yE5X0bGCjphG0PKX1KI3nJ0P5rA
 xLAg==
X-Gm-Message-State: AOJu0YwFsMyIOWGoRL7tHorZe0OYLynnoVuW/XXjf/2R6Wg1Tcr4pLUI
 QFNm5+yh2hzIXWs5alROQZnteFVpz2CYzt85s87ipPrY4KP2ei0dEsD5JROT
X-Gm-Gg: ASbGncv86fU44q+Ag/cGqUod7DVrkH/KQyrj+WaZw6ihEDe013FTbTwHsemnHFs8OD4
 sXAuajE29r/39W/kYDrr/Zdd4pQkhjkoqnwmXfjSqYrKrDh76RiYzoO1Jl6JyQ2289GEzrRCk3O
 w9dPCtL6VdobhFn5/zBkr5kxNnNIbKds4fCRO7az+8/d2LTHLPHCYbZDIs9Zt7YdMwSaiPe+qoW
 8Cq3CBpwzZ/oZIOAiFenrDfU2KrBqYZHbwiPha3Lx5Gpo0ywHBPTQ==
X-Google-Smtp-Source: AGHT+IHL66FGjd9oQyTL8yAMDhuGuQP7n4SoAIOYClwhFGo3tPGRnJ9Pn+X/k+fcyrCzXMTY06q0HA==
X-Received: by 2002:a05:6a21:99aa:b0:1e1:cba5:8e1b with SMTP id
 adf61e73a8af0-1e5e048a318mr59623853637.18.1735825732410; 
 Thu, 02 Jan 2025 05:48:52 -0800 (PST)
Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89])
 by smtp.gmail.com with ESMTPSA id
 d2e1a72fcca58-72aad8dc5absm25059839b3a.127.2025.01.02.05.48.50
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 02 Jan 2025 05:48:51 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: Rutherther <rutherther@HIDDEN>
Subject: Re: [bug#74405] [PATCH 0/1] qt-build-system: Wrap with build
 variables to allow %outputs in arguments
In-Reply-To: <cover.1733339135.git.rutherther@HIDDEN>
 (rutherther@HIDDEN's message of "Wed, 4 Dec 2024 20:12:17 +0100")
References: <cover.1731870758.git.rutherther@HIDDEN>
 <cover.1733339135.git.rutherther@HIDDEN>
Date: Thu, 02 Jan 2025 22:48:41 +0900
Message-ID: <871pxl72di.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 74405
Cc: 74405 <at> debbugs.gnu.org,
 =?utf-8?B?w6XCrsKLw6bClsKHw6bCrcKm?= <iyzsong@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Rutherther,

Rutherther <rutherther@HIDDEN> writes:

> It is impossible to refer to %outputs in arguments like #:configure-flags
> (ie. `(assoc-ref %outputs "out")` leads to unbound-variable %outputs).
> I think the issue is in qt using different system than build systems such
> as cmake or gnu. Since I am unsure about the reason for qt not having
> the same structure, I am submitting this to guix devel for discussion,
> as well as opening a patch in case this is fine to be merged. If not,
> could someone please explain what the reason behind not adding
> inputs and outputs is, and what is the alternative?
>
> Regards,
> Rutherther
>
> Rutherther (1):
>   guix: qt: add inputs and outputs build variables in qt-build

I haven't seen that patch in the series here, but just for the record I
think support for %outputs is omitted by purpose to nudge new package
definitions to migrate to use G-Expressions, e.g.

--8<---------------cut here---------------start------------->8---
#:configure-flags #~(list (string-append "DESTDIR=" #$output))
--8<---------------cut here---------------end--------------->8---

-- 
Thanks,
Maxim




Information forwarded to guix-patches@HIDDEN:
bug#74405; Package guix-patches. Full text available.

Message received at 74405 <at> debbugs.gnu.org:


Received: (at 74405) by debbugs.gnu.org; 2 Jan 2025 13:46:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 02 08:46:16 2025
Received: from localhost ([127.0.0.1]:43165 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tTLWh-0000uH-Hd
	for submit <at> debbugs.gnu.org; Thu, 02 Jan 2025 08:46:15 -0500
Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]:61845)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1tTLWe-0000tt-Sg
 for 74405 <at> debbugs.gnu.org; Thu, 02 Jan 2025 08:46:13 -0500
Received: by mail-pl1-x62b.google.com with SMTP id
 d9443c01a7336-21669fd5c7cso156925865ad.3
 for <74405 <at> debbugs.gnu.org>; Thu, 02 Jan 2025 05:46:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1735825566; x=1736430366; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=zmShXNSsUrT03f2gPHKrMEBwJ4EHuCHC81FC0CF2dOA=;
 b=mPMxngPLHIFLAxMLJZMx04CBajzv5NFNpv9MQHnPcPebIr58Er4BS9P1OFS9Mylpjc
 dXZXEMkC7G7kbqpJMHAET4TDIqCDdgITi3uep2dqL8vWPgM/3xpCjGVwoz0aaFcRp+MG
 SWT9pVPwtAgTQOt95ADe74/W6EmeXP51VHSG5i5Mot22GItxQxvxEq+fmnXscjV5Fy2A
 FmGNuxzqWb44ft1PvkiYj5+jjsb+LozPBWVxtkD7np17vTKLMoZyHm+7bhEG2jrixNh9
 nWjGsu3YBlQX6zR7f7xxNuzRzMolT2GsL1YwDb74FFLwm+MfRVDct+ITfY0kdlGb0KW0
 1aKw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1735825566; x=1736430366;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=zmShXNSsUrT03f2gPHKrMEBwJ4EHuCHC81FC0CF2dOA=;
 b=Jhc/uJjmDQXokJ4MEUVI6LsB3BHu6VtoUlnBPv7XFo4Hmti5knv0hA03U/Znh8rrIJ
 YLJxGbuau2/O1jHtYaKZzXLkbGua5DAZCZ76M589tSURLvDnOPf0JSaLTXDVgi0EJLlk
 ykv8XtOXVu77jLhCoVuz9lmDSlY9qNKQuTCtzeEiHtl1X/OUhGb/+MLyC/V8TZIlng5w
 kvxMjvl/CZL2bL26ESuMs3HWeSFON4oYMIxfD4V0oHcZK+eb/1M7BBhMRzmVu7dhZbaw
 Gjvrx15JrVleyW2WUrGgQGNSyziNLyLSQR9FAJT4/jeBbJGrHVE8LvuT/Uv1XonJv73G
 OSSA==
X-Gm-Message-State: AOJu0YwqSWK+QGIOsKlYb06itKZeyfF95GTz9nIrkkjEfnomp8o24Ktw
 nu2Wv7j2NWrAx8fL3F9ha4psvffrcluJdd6lvtjUNR2PSBvek6uwkbzlZeTl
X-Gm-Gg: ASbGnctLKEYkN3YO6TStLXQ0UcogM8f2ngahPRrm9JgdtrW3ZHvtK4b66QZb/naLOT/
 piXNxDlDy2OPNbL45lx+5F13yGykTHL0+LuVl4A12hdzsGLAXKnpgAkxB/w5awqnun+grrSbYfJ
 Ex94Px2WhPPuVYzotnLtA1IzAtaL621O86Fh0/jPL1LRGK/6pT2trC0I/WcdunggSCV5uhTMeEb
 yZj6EjvU7hMLMJKO1fZ6vzaLoIYu0bQiWXfOlJootPJ6yhBKuey0w==
X-Google-Smtp-Source: AGHT+IG0uTiK/r5igxm9Z+z983bRDQ6KLbJ5HxWitDw+uBIJZ6oOgx3ateYC3cnNcMVRnqKFqq8/rQ==
X-Received: by 2002:a17:902:db0e:b0:215:b75f:a1cb with SMTP id
 d9443c01a7336-219e6e8d361mr599650935ad.9.1735825565570; 
 Thu, 02 Jan 2025 05:46:05 -0800 (PST)
Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89])
 by smtp.gmail.com with ESMTPSA id
 d9443c01a7336-219dca028aesm227180755ad.264.2025.01.02.05.46.04
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 02 Jan 2025 05:46:04 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: Rutherther <rutherther@HIDDEN>
Subject: Re: [bug#74405] [PATCH 0/1] qt-build-system: Wrap with build
 variables to allow %outputs in arguments
In-Reply-To: <87ser31cre.fsf@HIDDEN> (rutherther@HIDDEN's message of
 "Wed, 04 Dec 2024 20:14:45 +0100")
References: <cover.1733339135.git.rutherther@HIDDEN>
 <87ser31cre.fsf@HIDDEN>
Date: Thu, 02 Jan 2025 22:45:54 +0900
Message-ID: <877c7d72i5.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 74405
Cc: 74405 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hey,

Rutherther <rutherther@HIDDEN> writes:

> So sorry, I meant to make a new issue, but instead,
> I accidentally sent it to this one thanks to mumi
> being so easy to use, and not noticing I didn't switch
> to a new issue. :(

No big deal :-).  It's happened to me as well.

-- 
Thanks,
Maxim




Information forwarded to guix-patches@HIDDEN:
bug#74405; Package guix-patches. Full text available.

Message received at 74405 <at> debbugs.gnu.org:


Received: (at 74405) by debbugs.gnu.org; 4 Dec 2024 19:14:53 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 04 14:14:53 2024
Received: from localhost ([127.0.0.1]:36895 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tIupp-0002DH-9o
	for submit <at> debbugs.gnu.org; Wed, 04 Dec 2024 14:14:53 -0500
Received: from ditigal.xyz ([78.46.201.50]:41550 helo=mail.ditigal.xyz)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rutherther@HIDDEN>) id 1tIupn-0002Cx-Ma
 for 74405 <at> debbugs.gnu.org; Wed, 04 Dec 2024 14:14:52 -0500
Received: by cerebrum (OpenSMTPD) with ESMTPSA id 884a752e
 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO)
 for <74405 <at> debbugs.gnu.org>; Wed, 4 Dec 2024 19:14:45 +0000 (UTC)
From: Rutherther <rutherther@HIDDEN>
To: 74405 <at> debbugs.gnu.org
Subject: Re: [PATCH 0/1] qt-build-system: Wrap with build variables to allow
 %outputs in arguments
In-Reply-To: <cover.1733339135.git.rutherther@HIDDEN>
References: <cover.1733339135.git.rutherther@HIDDEN>
Date: Wed, 04 Dec 2024 20:14:45 +0100
Message-ID: <87ser31cre.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ditigal.xyz;
 i=@ditigal.xyz; q=dns/txt; s=20240917; t=1733339686; h=from : to :
 subject : in-reply-to : references : date : message-id : mime-version
 : content-type : from;
 bh=5NEWpiq1IQ3VxDqsNpa6AK84t0ntVLl5u1ga+ptA1iE=;
 b=kksG6XuLo7VRMLIueCIcP/R9g6W92/fGjQLl00nbM5qzdKgmRkFRmVf42DYPFLu9YyY9w
 39fNmzPtfj7F3/UJ66NQnvtw6uzhslL1yEg69YsS4RfqHbLsVjLmvftoYjaJ1oVLiD+gBvw
 B0CBMDhFK59H+qkUkTLsQrkQDpJZdHo=
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 74405
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


So sorry, I meant to make a new issue, but instead,
I accidentally sent it to this one thanks to mumi
being so easy to use, and not noticing I didn't switch
to a new issue. :(




Information forwarded to guix-patches@HIDDEN:
bug#74405; Package guix-patches. Full text available.

Message received at 74405 <at> debbugs.gnu.org:


Received: (at 74405) by debbugs.gnu.org; 4 Dec 2024 19:12:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 04 14:12:32 2024
Received: from localhost ([127.0.0.1]:36880 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tIunY-00027k-G7
	for submit <at> debbugs.gnu.org; Wed, 04 Dec 2024 14:12:32 -0500
Received: from ditigal.xyz ([78.46.201.50]:51970 helo=mail.ditigal.xyz)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rutherther@HIDDEN>) id 1tIunW-00027J-B2
 for 74405 <at> debbugs.gnu.org; Wed, 04 Dec 2024 14:12:31 -0500
Received: by cerebrum (OpenSMTPD) with ESMTPSA id ad45d707
 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); 
 Wed, 4 Dec 2024 19:12:21 +0000 (UTC)
From: Rutherther <rutherther@HIDDEN>
To: 74405 <at> debbugs.gnu.org
Subject: [PATCH 0/1] qt-build-system: Wrap with build variables to allow
 %outputs in arguments
Date: Wed,  4 Dec 2024 20:12:17 +0100
Message-ID: <cover.1733339135.git.rutherther@HIDDEN>
X-Mailer: git-send-email 2.46.0
MIME-Version: 1.0
X-Debbugs-CC: guix-devel@HIDDEN
X-Debbugs-Cc: =?utf-8?b?UnV0aGVydGhlciA8cnV0aGVydGhlckBkaXRpZ2FsLnh5ej4sIE1heGltIENvdXJub3llciA8bWF4aW0uY291cm5veWVyQGdtYWlsLmNvbT4sIMOlwq7Ci8OmwpbCh8Omwq3CpiA8aXl6c29uZ0BlbnZzLm5ldD4=?=
Content-Transfer-Encoding: 8bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ditigal.xyz;
 i=@ditigal.xyz; q=dns/txt; s=20240917; t=1733339541; h=from : to : cc
 : subject : date : message-id : mime-version :
 content-transfer-encoding : from;
 bh=mPY3TwIbkF9b1G8YmrgFaTaO79WsMkRpl1OmUCRqO+w=;
 b=rIk4tTPKvSYsIhDayrp6qxbE4VwMNbhpvikqewA2DnauS84GYhNcEUjphuMhRuo1OaRC6
 Rxptuc8PhvJOPUimoNmns8+0SEDpXAE4NchtLQI6zTWLgmFdxmhzuBmV03UqNY1Ietyqk/l
 4EFuQLZElvjYwRRpDhUf85lB3SfAtZE=
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 74405
Cc: Rutherther <rutherther@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

It is impossible to refer to %outputs in arguments like #:configure-flags
(ie. `(assoc-ref %outputs "out")` leads to unbound-variable %outputs).
I think the issue is in qt using different system than build systems such
as cmake or gnu. Since I am unsure about the reason for qt not having
the same structure, I am submitting this to guix devel for discussion,
as well as opening a patch in case this is fine to be merged. If not,
could someone please explain what the reason behind not adding
inputs and outputs is, and what is the alternative?

Regards,
Rutherther

Rutherther (1):
  guix: qt: add inputs and outputs build variables in qt-build

 guix/build-system/qt.scm | 54 +++++++++++++++++++++-------------------
 1 file changed, 28 insertions(+), 26 deletions(-)


base-commit: 006679d1e6ca7acea0629b4f019c8cf89cde08be
--
2.46.0




Information forwarded to rutherther@HIDDEN, maxim.cournoyer@HIDDEN, iyzsong@HIDDEN, guix-patches@HIDDEN:
bug#74405; Package guix-patches. Full text available.
Merged 74405 74406. Request was from Rutherther <rutherther@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 74405 <at> debbugs.gnu.org:


Received: (at 74405) by debbugs.gnu.org; 17 Nov 2024 19:17:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 17 14:17:24 2024
Received: from localhost ([127.0.0.1]:58649 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tCklv-0001g9-NK
	for submit <at> debbugs.gnu.org; Sun, 17 Nov 2024 14:17:23 -0500
Received: from ditigal.xyz ([78.46.201.50]:38428 helo=mail.ditigal.xyz)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rutherther@HIDDEN>) id 1tCklu-0001fx-2f
 for 74405 <at> debbugs.gnu.org; Sun, 17 Nov 2024 14:17:22 -0500
Received: by cerebrum (OpenSMTPD) with ESMTPSA id 2c97ab73
 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); 
 Sun, 17 Nov 2024 19:17:14 +0000 (UTC)
From: Rutherther <rutherther@HIDDEN>
To: 74405 <at> debbugs.gnu.org
Subject: [PATCH 1/1] gnu: antlr4: Pass full path to java in bin executable
Date: Sun, 17 Nov 2024 20:17:01 +0100
Message-ID: <27ea0b2b5326c827fd03399b4009c1bb62d81600.1731870758.git.rutherther@HIDDEN>
X-Mailer: git-send-email 2.46.0
In-Reply-To: <cover.1731870758.git.rutherther@HIDDEN>
References: <cover.1731870758.git.rutherther@HIDDEN>
MIME-Version: 1.0
X-Debbugs-Cc: Julien Lepiller <julien@HIDDEN>
Content-Transfer-Encoding: 8bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ditigal.xyz;
 i=@ditigal.xyz; q=dns/txt; s=20240917; t=1731871034; h=from : to : cc
 : subject : date : message-id : in-reply-to : references :
 mime-version : content-transfer-encoding : from;
 bh=s2SwSMVNRbG1OWVW885rvr4k5PLi705fgklH17/YbpA=;
 b=SZqWMjplUY694WBnR5qVKcRmvIdWF4ctD4bgQ0+hkIF3hBpslz3HGMukza7KEbhNkzq3V
 Uy1WDv2jsj39JtRKFeSFtj6RaiW09zFZk87z16mvURws0QeqLRVGTR8MmQhzkfCjQr6M0no
 JQDX8DzHm5i+2lyhwJeCJnj0iYuxEb0=
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 74405
Cc: Rutherther <rutherther@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

The executable outputted by antlr4 package does not
refer to full path of java, but to standalone "java".
That means the package expects java to be in PATH.
Since it's an application, requiring java to run,
it should rather refer to full path of java executable
it was built with/for.

* gnu/packages/java.scm: (antrl4)[arguments]: Change "java" in bin/antlr4 for full path

Change-Id: I311b9ec54a90fc7251eb8fcb62b232e843853e64
---
 gnu/packages/java.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index df57385ea7..8607b62bea 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -8866,13 +8866,14 @@ (define-public antlr4
          (add-after 'install 'bin-install
            (lambda* (#:key inputs outputs #:allow-other-keys)
              (let ((jar (string-append (assoc-ref outputs "out") "/share/java"))
-                   (bin (string-append (assoc-ref outputs "out") "/bin")))
+                   (bin (string-append (assoc-ref outputs "out") "/bin"))
+                   (java (search-input-file inputs "bin/java")))
                (mkdir-p bin)
                (with-output-to-file (string-append bin "/antlr4")
                  (lambda _
                    (display
                      (string-append "#!" (which "sh") "\n"
-                                    "java -cp " jar "/antlr4.jar:"
+                                    java " -cp " jar "/antlr4.jar:"
                                     (string-join
                                       (apply
                                         append
-- 
2.46.0




Information forwarded to julien@HIDDEN, guix-patches@HIDDEN:
bug#74405; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 17 Nov 2024 19:15:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 17 14:15:23 2024
Received: from localhost ([127.0.0.1]:58637 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tCkjy-0001bu-TF
	for submit <at> debbugs.gnu.org; Sun, 17 Nov 2024 14:15:23 -0500
Received: from lists.gnu.org ([209.51.188.17]:59092)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rutherther@HIDDEN>) id 1tCkjw-0001bj-J6
 for submit <at> debbugs.gnu.org; Sun, 17 Nov 2024 14:15:21 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <rutherther@HIDDEN>)
 id 1tCkjw-00020A-5Q
 for guix-patches@HIDDEN; Sun, 17 Nov 2024 14:15:20 -0500
Received: from ditigal.xyz ([2a01:4f8:1c1b:6a1c::] helo=mail.ditigal.xyz)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256)
 (Exim 4.90_1) (envelope-from <rutherther@HIDDEN>)
 id 1tCkju-0004x5-BY
 for guix-patches@HIDDEN; Sun, 17 Nov 2024 14:15:19 -0500
Received: by cerebrum (OpenSMTPD) with ESMTPSA id fbcde5a1
 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); 
 Sun, 17 Nov 2024 19:15:14 +0000 (UTC)
From: Rutherther <rutherther@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH 0/1] antlr4 package does not refer to java executable by full
 path
Date: Sun, 17 Nov 2024 20:15:12 +0100
Message-ID: <cover.1731870758.git.rutherther@HIDDEN>
X-Mailer: git-send-email 2.46.0
MIME-Version: 1.0
X-Debbugs-Cc: Julien Lepiller <julien@HIDDEN>
Content-Transfer-Encoding: 8bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ditigal.xyz;
 i=@ditigal.xyz; q=dns/txt; s=20240917; t=1731870914; h=from : to : cc
 : subject : date : message-id : mime-version :
 content-transfer-encoding : from;
 bh=zC7T22bBxwXKDpy5DpZiLruRwxc0xW7j7p5CAr4JuuY=;
 b=lQBcaEzCnSGfheF/r0aG3g2Zh9naQhv0yo6rTRCtkAyBTxelOTlSLBz4lmGya3k6B5/u3
 xEpxUsxLK3bNDQZaarMXhCMsuXjgtUFLZuK5X7btg8MYjHCNK/f40y/rZfrrDsUYN/IBoaX
 e1tF0Nv7mm6P6pY/pf8N59WTwUoQ/ag=
Received-SPF: pass client-ip=2a01:4f8:1c1b:6a1c::;
 envelope-from=rutherther@HIDDEN; helo=mail.ditigal.xyz
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
Cc: Rutherther <rutherther@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

Hello,

this seems to me like a bug - the package antlr4 refers
to "java" in bin/antlr4 that is produced. I think it should
refer to #$icedtea/bin/java. It seems to me quite probable
this was a mistake, since there was java written multiple
times in phases, where it's available in PATH automatically.

Rutherther (1):
  gnu: antlr4: Pass full path to java in bin executable

 gnu/packages/java.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)


base-commit: d108a7aac2c51f21c55cb8ea8801629a97f5242a
--
2.46.0




Acknowledgement sent to Rutherther <rutherther@HIDDEN>:
New bug report received and forwarded. Copy sent to julien@HIDDEN, guix-patches@HIDDEN. Full text available.
Report forwarded to julien@HIDDEN, guix-patches@HIDDEN:
bug#74405; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.