X-Loop: help-debbugs@HIDDEN Subject: [bug#74434] [PATCH] py-compile: Allow user to disable python Resent-From: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric_?= =?UTF-8?Q?B=C3=A9rat?= <fberat@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: automake-patches@HIDDEN Resent-Date: Tue, 19 Nov 2024 09:55:02 +0000 Resent-Message-ID: <handler.74434.B.173201004818364 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 74434 X-GNU-PR-Package: automake-patches X-GNU-PR-Keywords: patch To: 74434 <at> debbugs.gnu.org X-Debbugs-Original-To: automake-patches@HIDDEN Received: via spool by submit <at> debbugs.gnu.org id=B.173201004818364 (code B ref -1); Tue, 19 Nov 2024 09:55:02 +0000 Received: (at submit) by debbugs.gnu.org; 19 Nov 2024 09:54:08 +0000 Received: from localhost ([127.0.0.1]:41108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tDKvw-0004m8-3j for submit <at> debbugs.gnu.org; Tue, 19 Nov 2024 04:54:08 -0500 Received: from lists.gnu.org ([209.51.188.17]:36264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <fberat@HIDDEN>) id 1tDKvt-0004m0-Fx for submit <at> debbugs.gnu.org; Tue, 19 Nov 2024 04:54:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <fberat@HIDDEN>) id 1tDKvt-0003AZ-6d for automake-patches@HIDDEN; Tue, 19 Nov 2024 04:54:05 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <fberat@HIDDEN>) id 1tDKvq-0005b8-V1 for automake-patches@HIDDEN; Tue, 19 Nov 2024 04:54:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732010040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dkOYwOXkmHuaSTxQFPayizk4wDNJxw8lmL3y1vAx7ys=; b=fGu43qborDg91BcFk4ZTUuVUSSm2GXUfLkBGGX7PK5G+ChS/dzE6JppDqJI8h+lrHEYVdW dSuAXhqNyOxjxOLawregJ3x6DmEsrO03w3e7x+K/gXfDTe/Fr4F7x2doRFOCMBhHe2IkpI Rzv2Vm14fhKiuJi04TNnyXsVuo3jToI= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-462-dOrXpFHUN0WQAlucGcng_A-1; Tue, 19 Nov 2024 04:52:10 -0500 X-MC-Unique: dOrXpFHUN0WQAlucGcng_A-1 X-Mimecast-MFC-AGG-ID: dOrXpFHUN0WQAlucGcng_A Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4723E1955E94 for <automake-patches@HIDDEN>; Tue, 19 Nov 2024 09:52:09 +0000 (UTC) Received: from Nymeria-redhat.redhat.com (unknown [10.39.192.53]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7841C19560A3 for <automake-patches@HIDDEN>; Tue, 19 Nov 2024 09:52:08 +0000 (UTC) From: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric_?= =?UTF-8?Q?B=C3=A9rat?= <fberat@HIDDEN> Date: Tue, 19 Nov 2024 10:52:02 +0100 Message-ID: <20241119095202.2696082-1-fberat@HIDDEN> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pHsS5dyx8x4qAALbjHS6lVwJ_P2DyA95HCa9PGRJsuo_1732009929 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true Received-SPF: pass client-ip=170.10.133.124; envelope-from=fberat@HIDDEN; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.142, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.4 (--) Hello, While integrating automake 1.17, I found that otf2 package build fails. The failure is due to: py-compile: could not determine : major version This is a side-effect of a rework of the py-compile script, which formerly defaulted to python3 if there was an error while getting the python version. The new code doesn't have this fallback, and if users want to disable python support by setting `PYTHON=:` as environment variable, the script bails out. I believe this is a common practice and that py-compile needs a fix. I therefore propose the one below. Feel free to tell me otherwise. Fred. -- 8< -- Subject: [PATCH] py-compile: Allow user to disable python Common practice is to set PYTHON=: to disable python support, which breaks the current version of this script. Check that the PYTHON variable contains `python`, early exit otherwise. --- lib/py-compile | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/lib/py-compile b/lib/py-compile index c9d4fde94..0238bab2c 100755 --- a/lib/py-compile +++ b/lib/py-compile @@ -33,6 +33,13 @@ fi me=py-compile +case "$PYTHON" in + *python*) ;; + *) + echo "$me: Python support disabled"; + exit 0;; +esac + usage_error () { echo "$me: $*" >&2 -- 2.47.0
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric_?= =?UTF-8?Q?B=C3=A9rat?= <fberat@HIDDEN> Subject: bug#74434: Acknowledgement ([PATCH] py-compile: Allow user to disable python) Message-ID: <handler.74434.B.173201004818364.ack <at> debbugs.gnu.org> References: <20241119095202.2696082-1-fberat@HIDDEN> X-Gnu-PR-Message: ack 74434 X-Gnu-PR-Package: automake-patches X-Gnu-PR-Keywords: patch Reply-To: 74434 <at> debbugs.gnu.org Date: Tue, 19 Nov 2024 09:55:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): automake-patches@HIDDEN If you wish to submit further information on this problem, please send it to 74434 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 74434: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D74434 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN Subject: [bug#74434] [PATCH] py-compile: Allow user to disable python References: <20241119095202.2696082-1-fberat@HIDDEN> Resent-From: Karl Berry <karl@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: automake-patches@HIDDEN Resent-Date: Tue, 19 Nov 2024 21:29:02 +0000 Resent-Message-ID: <handler.74434.B74434.173205173410148 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 74434 X-GNU-PR-Package: automake-patches X-GNU-PR-Keywords: patch To: fberat@HIDDEN Cc: 74434 <at> debbugs.gnu.org Received: via spool by 74434-submit <at> debbugs.gnu.org id=B74434.173205173410148 (code B ref 74434); Tue, 19 Nov 2024 21:29:02 +0000 Received: (at 74434) by debbugs.gnu.org; 19 Nov 2024 21:28:54 +0000 Received: from localhost ([127.0.0.1]:44271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tDVmI-0002db-8F for submit <at> debbugs.gnu.org; Tue, 19 Nov 2024 16:28:54 -0500 Received: from frenzy.freefriends.org ([198.99.81.75]:59514 helo=freefriends.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <karl@HIDDEN>) id 1tDVmH-0002dT-7X for 74434 <at> debbugs.gnu.org; Tue, 19 Nov 2024 16:28:53 -0500 X-Envelope-From: karl@HIDDEN Received: from freefriends.org (localhost [127.0.0.1]) by freefriends.org (8.16.1/8.16.1) with ESMTPS id 4AJLSXVw2353335 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 19 Nov 2024 14:28:33 -0700 Received: (from apache@localhost) by freefriends.org (8.16.1/8.14.7/Submit) id 4AJLSXZr2353334; Tue, 19 Nov 2024 14:28:33 -0700 Date: Tue, 19 Nov 2024 14:28:33 -0700 Message-Id: <202411192128.4AJLSXZr2353334@HIDDEN> From: Karl Berry <karl@HIDDEN> In-Reply-To: <20241119095202.2696082-1-fberat@HIDDEN> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Frederic, I believe this is a common practice Well, clearly no one had thought of it nor was it tried at any point during the lengthy automake pretest sequence, but anyway, agreed that there's no reason to gratuitously fail in this case. As for disabling pythong, it doesn't seem to me that setting PYTHON=: can really be considered equivalent to something like a --without-python option, but since it helps in some cases, that's fine. --thanks, karl.
X-Loop: help-debbugs@HIDDEN Subject: [bug#74434] [PATCH] py-compile: Allow user to disable python Resent-From: Frederic Berat <fberat@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: automake-patches@HIDDEN Resent-Date: Wed, 20 Nov 2024 14:03:01 +0000 Resent-Message-ID: <handler.74434.B74434.173211136122177 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 74434 X-GNU-PR-Package: automake-patches X-GNU-PR-Keywords: patch To: Karl Berry <karl@HIDDEN> Cc: 74434 <at> debbugs.gnu.org Received: via spool by 74434-submit <at> debbugs.gnu.org id=B74434.173211136122177 (code B ref 74434); Wed, 20 Nov 2024 14:03:01 +0000 Received: (at 74434) by debbugs.gnu.org; 20 Nov 2024 14:02:41 +0000 Received: from localhost ([127.0.0.1]:45859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tDlI0-0005lc-SL for submit <at> debbugs.gnu.org; Wed, 20 Nov 2024 09:02:41 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:35839) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <fberat@HIDDEN>) id 1tDlHw-0005lN-Uk for 74434 <at> debbugs.gnu.org; Wed, 20 Nov 2024 09:02:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732111356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pEWraBHxB4uXaFM1RGdarTAlZrbYp8FZuR1epxeGD+0=; b=DaNUk+f8k1Pnmtky2WuN/YSJeswQ3qaQlPq2UKOxs5O65UunYf/jk+NXVPKCfvF8IJT2De whcEiOAzXjxJ/DP4wCkLgmWIRLY2OBrkElEC/RbrrnZX51ChMZKVvs3vC817Os2Lv0jaDt 2ab7lAHugP2xdeojtEWtok8voqyK5UA= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-221-h0SGMCl_NaKzryYe85RRaw-1; Wed, 20 Nov 2024 09:02:34 -0500 X-MC-Unique: h0SGMCl_NaKzryYe85RRaw-1 X-Mimecast-MFC-AGG-ID: h0SGMCl_NaKzryYe85RRaw Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-5cfde9f622dso373886a12.1 for <74434 <at> debbugs.gnu.org>; Wed, 20 Nov 2024 06:02:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732111352; x=1732716152; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pEWraBHxB4uXaFM1RGdarTAlZrbYp8FZuR1epxeGD+0=; b=CZ7WGiI/HHVLJVtKdA6CgMWAJgVJXALxHKeJHtSp8XhlPUBQDL6Nd16u7gnVBQ0epi 94S4beHvHZpHLdcQWXCpr8/Pdkt3WH3nKaQ/o30zSQhlzSV+9V8mT8fAtfNho2ylJmFQ 8t+SR3IFThNOLgB5O+3OzCUqwsUPitZYdNI/e3RBDYOlJ0qq+HCD6z2NOBvjz7t0GuDm 9he89FFsia/bvgF0VwiC0QRP8FVj+H6cFXHMpyfv/5wEg26o8QjnAuZVjHCB3dylttLo qWBa0M0Kc77IL5PqNy3nGoNc9sMWpUpD+5G7AwI6goJMI9/1C5OHIlpocUh29GeZ22Ae Qxvg== X-Gm-Message-State: AOJu0YwaMjPTv4KmMK8FCaaNHDoagkAHbySEXGdJL4oyNc1wDYqL+qtw ueAo9I6RYVIM8DWNkg5fja7igOSzQqxs620M4AiTkHx1lQOKPL2luz1M7ZnTB2nrNXVtJK3p8xF SroqBwZ+nHWgLZyaSuatNmr2Xdxf4SmSngj1FA+9xBVyNgscFHtIrzbxruGDhkp1N/cAfxp8wdg adtqybNvCEKsY6b4hCIUWBVvlTiB8= X-Gm-Gg: ASbGncv3Jbipfucm7YmxdVb4mGCWVRp/RJFJMb/crO33VwNdotR1nNGa+JjZvuXmeOn bl9aMqSaZKi2R1mt9GWVhYSlBrDh+LvTcz9S8CO+sMI/WNFKZqY44kp2TOHk5Dw== X-Received: by 2002:a17:907:318a:b0:a99:8642:4f41 with SMTP id a640c23a62f3a-aa4dd72c508mr118814566b.14.1732111351882; Wed, 20 Nov 2024 06:02:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IFW/tNNSsVuVzFXJT49hX6Xycmi6YCCO9IDr8kQChatIsOjYpooAWHUioJ0Tn4v7yoz2WNnvC90meFbz9b7nGM= X-Received: by 2002:a17:907:318a:b0:a99:8642:4f41 with SMTP id a640c23a62f3a-aa4dd72c508mr118805166b.14.1732111349764; Wed, 20 Nov 2024 06:02:29 -0800 (PST) MIME-Version: 1.0 References: <20241119095202.2696082-1-fberat@HIDDEN> <202411192128.4AJLSXZr2353334@HIDDEN> In-Reply-To: <202411192128.4AJLSXZr2353334@HIDDEN> From: Frederic Berat <fberat@HIDDEN> Date: Wed, 20 Nov 2024 15:02:19 +0100 Message-ID: <CAObJKZrdGuPGmheQrXBMRT29roF-TGgkx2+z9CsZPG4U0f8EDw@HIDDEN> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: EHu6KjTq2GrJcf1Vn_3vsbdvyoWBNfOOlwnijF-1cCE_1732111352 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000b6e4e706275899cf" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --000000000000b6e4e706275899cf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Nov 19, 2024 at 10:29=E2=80=AFPM Karl Berry <karl@HIDDEN> = wrote: > Hi Frederic, > > I believe this is a common practice > > Well, clearly no one had thought of it nor was it tried at any point > during the lengthy automake pretest sequence, but anyway, agreed that > there's no reason to gratuitously fail in this case. > > As for disabling pythong, it doesn't seem to me that setting PYTHON=3D: > can really be considered equivalent to something like a --without-python > option, but since it helps in some cases, that's fine. --thanks, karl. > Well, to rephrase: that is a construct I've already seen, not that I agree or disagree with its usage in this usecase. There may be a bit more thoughts needed to get the py-compile-env.sh test to work properly though. --000000000000b6e4e706275899cf Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">= <div dir=3D"ltr" class=3D"gmail_attr">On Tue, Nov 19, 2024 at 10:29=E2=80= =AFPM Karl Berry <<a href=3D"mailto:karl@HIDDEN">karl@freefrien= ds.org</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"m= argin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left= :1ex">Hi Frederic,<br> <br> =C2=A0 =C2=A0 I believe this is a common practice <br> <br> Well, clearly no one had thought of it nor was it tried at any point<br> during the lengthy automake pretest sequence, but anyway, agreed that<br> there's no reason to gratuitously fail in this case. <br></blockquote><= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex"> <br> As for disabling pythong, it doesn't seem to me that setting PYTHON=3D:= <br> can really be considered equivalent to something like a --without-python<br= > option, but since it helps in some cases, that's fine. --thanks, karl.<= br></blockquote><div><br></div><div>Well, to rephrase: that is a construct = I've already seen, not that I agree or disagree with its usage in this = usecase.<br></div><div><br></div><div>There may be a bit more thoughts need= ed to get the py-compile-env.sh test to work properly though.<br></div></di= v></div> --000000000000b6e4e706275899cf--
X-Loop: help-debbugs@HIDDEN Subject: [bug#74434] [PATCH] py-compile: Allow user to disable python References: <20241119095202.2696082-1-fberat@HIDDEN> Resent-From: Karl Berry <karl@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: automake-patches@HIDDEN Resent-Date: Wed, 20 Nov 2024 22:24:02 +0000 Resent-Message-ID: <handler.74434.B74434.173214139613887 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 74434 X-GNU-PR-Package: automake-patches X-GNU-PR-Keywords: patch To: fberat@HIDDEN Cc: 74434 <at> debbugs.gnu.org Received: via spool by 74434-submit <at> debbugs.gnu.org id=B74434.173214139613887 (code B ref 74434); Wed, 20 Nov 2024 22:24:02 +0000 Received: (at 74434) by debbugs.gnu.org; 20 Nov 2024 22:23:16 +0000 Received: from localhost ([127.0.0.1]:48110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tDt6R-0003bv-M6 for submit <at> debbugs.gnu.org; Wed, 20 Nov 2024 17:23:15 -0500 Received: from frenzy.freefriends.org ([198.99.81.75]:59292 helo=freefriends.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <karl@HIDDEN>) id 1tDt6P-0003bm-SD for 74434 <at> debbugs.gnu.org; Wed, 20 Nov 2024 17:23:14 -0500 X-Envelope-From: karl@HIDDEN Received: from freefriends.org (localhost [127.0.0.1]) by freefriends.org (8.16.1/8.16.1) with ESMTPS id 4AKMMkXj052969 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 20 Nov 2024 15:22:46 -0700 Received: (from apache@localhost) by freefriends.org (8.16.1/8.14.7/Submit) id 4AKMMkaw052968; Wed, 20 Nov 2024 15:22:46 -0700 Date: Wed, 20 Nov 2024 15:22:46 -0700 Message-Id: <202411202222.4AKMMkaw052968@HIDDEN> From: Karl Berry <karl@HIDDEN> In-Reply-To: <CAObJKZrdGuPGmheQrXBMRT29roF-TGgkx2+z9CsZPG4U0f8EDw@HIDDEN> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) There may be a bit more thoughts needed to get the py-compile-env.sh test to work properly though. Yes, we should add an explicit check for this PYTHON=: setting. If you have time to munge around in the test(s), that would be great. Else I'll get to it when I get to it. --thanks, karl.
X-Loop: help-debbugs@HIDDEN Subject: [bug#74434] [PATCH] py-compile: Allow user to disable python Resent-From: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric_?= =?UTF-8?Q?B=C3=A9rat?= <fberat@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: automake-patches@HIDDEN Resent-Date: Fri, 22 Nov 2024 12:28:02 +0000 Resent-Message-ID: <handler.74434.B74434.173227844730457 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 74434 X-GNU-PR-Package: automake-patches X-GNU-PR-Keywords: patch To: Karl Berry <karl@HIDDEN> Cc: 74434 <at> debbugs.gnu.org Received: via spool by 74434-submit <at> debbugs.gnu.org id=B74434.173227844730457 (code B ref 74434); Fri, 22 Nov 2024 12:28:02 +0000 Received: (at 74434) by debbugs.gnu.org; 22 Nov 2024 12:27:27 +0000 Received: from localhost ([127.0.0.1]:53532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tESkw-0007vB-RN for submit <at> debbugs.gnu.org; Fri, 22 Nov 2024 07:27:27 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:43049) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <fberat@HIDDEN>) id 1tESkt-0007uv-K9 for 74434 <at> debbugs.gnu.org; Fri, 22 Nov 2024 07:27:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732278443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8ZBSIGZ3d/vc0CDu9mDswgNO0Yg9F3lpyBj4U+wUEjQ=; b=ghYXX1cwFITtt3OYstr8kqlJY/2jBURrSZ4TH69A4AxYyKrTi4MpUuS736OvyRFU53kVPg McxbL+CijKITIWko5IOOXqnz64z1AwYCCCHBP2j1f1IURcM3O3p9yK5l04TPxgI1qu5B6U Lq1H1KwYQPXIl0BdlPVHqT3jES1lZ0M= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-MvuBaHC9Otm2SC625gtjZA-1; Fri, 22 Nov 2024 07:27:21 -0500 X-MC-Unique: MvuBaHC9Otm2SC625gtjZA-1 X-Mimecast-MFC-AGG-ID: MvuBaHC9Otm2SC625gtjZA Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9E6B5195608C; Fri, 22 Nov 2024 12:27:19 +0000 (UTC) Received: from Nymeria-redhat.redhat.com (unknown [10.39.192.53]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9203A30001A2; Fri, 22 Nov 2024 12:27:18 +0000 (UTC) From: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric_?= =?UTF-8?Q?B=C3=A9rat?= <fberat@HIDDEN> Date: Fri, 22 Nov 2024 13:27:10 +0100 Message-ID: <20241122122710.2737628-1-fberat@HIDDEN> In-Reply-To: <202411202222.4AKMMkaw052968@HIDDEN> References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: U4-iwUYJCsR0l7gqizQ8ciLpk8DvOCmvrc4nWG3_61M_1732278440 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi, Here is a revision of the patch, so that py-compile-en.sh test passes. I leave to you to decide if a test dedicated to "PYTHON=:" is truly necessary. Fred. -- 8< -- Subject: [PATCH v2] py-compile: Allow user to disable python Common practice is to set PYTHON=: to disable python support, which breaks the current version of this script. --- lib/py-compile | 8 ++++++++ t/py-compile-env.sh | 20 ++++++++++---------- 2 files changed, 18 insertions(+), 10 deletions(-) diff --git a/lib/py-compile b/lib/py-compile index c9d4fde94..332cb4b79 100755 --- a/lib/py-compile +++ b/lib/py-compile @@ -33,6 +33,14 @@ fi me=py-compile +case "$PYTHON" in + *python*) ;; + *) + echo "$me: Invalid python executable ${PYTHON}"; + echo "$me: Python support disabled"; + exit 0;; +esac + usage_error () { echo "$me: $*" >&2 diff --git a/t/py-compile-env.sh b/t/py-compile-env.sh index b4ba6dcbe..7d8766b30 100644 --- a/t/py-compile-env.sh +++ b/t/py-compile-env.sh @@ -21,17 +21,17 @@ cp "$am_scriptdir/py-compile" . \ || fatal_ "failed to fetch auxiliary script py-compile" -cat > my-py <<'END' +cat > my-python <<'END' #!/bin/sh echo 2 -: > my-py.run +: > my-python.run END -chmod a+x my-py +chmod a+x my-python mkdir sub1 cd sub1 -PYTHON=false ../py-compile foo.py && exit 1 +! PYTHON=false ../py-compile foo.py && exit 1 ls | grep . && exit 1 PYTHON='echo GrEpMe AndMeToo' ../py-compile foo.py @@ -42,16 +42,16 @@ cd .. mkdir sub2 cd sub2 -PYTHON=../my-py ../py-compile foo.py -test -f my-py.run -ls | grep -v '^my-py\.run$' | grep . && exit 1 +PYTHON=../my-python ../py-compile foo.py +test -f my-python.run +ls | grep -v '^my-python\.run$' | grep . && exit 1 cd .. mkdir sub3 cd sub3 PATH=..$PATH_SEPARATOR$PATH; export PATH -PYTHON=my-py py-compile foo.py -test -f my-py.run -ls | grep -v '^my-py\.run$' | grep . && exit 1 +PYTHON=my-python py-compile foo.py +test -f my-python.run +ls | grep -v '^my-python\.run$' | grep . && exit 1 : -- 2.47.0
X-Loop: help-debbugs@HIDDEN Subject: [bug#74434] [PATCH] py-compile: Allow user to disable python References: <20241119095202.2696082-1-fberat@HIDDEN> Resent-From: Karl Berry <karl@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: automake-patches@HIDDEN Resent-Date: Sun, 24 Nov 2024 02:05:01 +0000 Resent-Message-ID: <handler.74434.B74434.173241389915193 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 74434 X-GNU-PR-Package: automake-patches X-GNU-PR-Keywords: patch To: fberat@HIDDEN Cc: 74434 <at> debbugs.gnu.org Received: via spool by 74434-submit <at> debbugs.gnu.org id=B74434.173241389915193 (code B ref 74434); Sun, 24 Nov 2024 02:05:01 +0000 Received: (at 74434) by debbugs.gnu.org; 24 Nov 2024 02:04:59 +0000 Received: from localhost ([127.0.0.1]:60118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tF1ze-0003wy-Kb for submit <at> debbugs.gnu.org; Sat, 23 Nov 2024 21:04:59 -0500 Received: from frenzy.freefriends.org ([198.99.81.75]:46870 helo=freefriends.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <karl@HIDDEN>) id 1tF1zc-0003wp-Ts for 74434 <at> debbugs.gnu.org; Sat, 23 Nov 2024 21:04:57 -0500 X-Envelope-From: karl@HIDDEN Received: from freefriends.org (localhost [127.0.0.1]) by freefriends.org (8.16.1/8.16.1) with ESMTPS id 4AO24WDP363284 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sat, 23 Nov 2024 19:04:32 -0700 Received: (from apache@localhost) by freefriends.org (8.16.1/8.14.7/Submit) id 4AO24WBc363282; Sat, 23 Nov 2024 19:04:32 -0700 Date: Sat, 23 Nov 2024 19:04:32 -0700 Message-Id: <202411240204.4AO24WBc363282@HIDDEN> From: Karl Berry <karl@HIDDEN> In-Reply-To: <20241122122710.2737628-1-fberat@HIDDEN> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) +case "$PYTHON" in + *python*) ;; + *) + echo "$me: Invalid python executable ${PYTHON}"; + echo "$me: Python support disabled"; + exit 0;; +esac Thanks. But I'm not sure about requiring the executable name to include "python". Apart from technically being against GNU standards, I can imagine people making a link named anything and then using that. For whatever reason. Maybe it would suffice to run $PYTHON -V and see if the result matches grep -i python? I don't have Python 2.0 (the oldest we claim to support, though I have my doubts), but it works with Python 2.7. $ python2.7 -V Python 2.7.18 Wdyt? --thanks, karl.
X-Loop: help-debbugs@HIDDEN Subject: [bug#74434] [PATCH] py-compile: Allow user to disable python Resent-From: Frederic Berat <fberat@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: automake-patches@HIDDEN Resent-Date: Mon, 25 Nov 2024 07:15:02 +0000 Resent-Message-ID: <handler.74434.B74434.173251889928631 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 74434 X-GNU-PR-Package: automake-patches X-GNU-PR-Keywords: patch To: Karl Berry <karl@HIDDEN> Cc: 74434 <at> debbugs.gnu.org Received: via spool by 74434-submit <at> debbugs.gnu.org id=B74434.173251889928631 (code B ref 74434); Mon, 25 Nov 2024 07:15:02 +0000 Received: (at 74434) by debbugs.gnu.org; 25 Nov 2024 07:14:59 +0000 Received: from localhost ([127.0.0.1]:37648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tFTJD-0007Ri-Ep for submit <at> debbugs.gnu.org; Mon, 25 Nov 2024 02:14:59 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:24691) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <fberat@HIDDEN>) id 1tFTJB-0007Ra-2J for 74434 <at> debbugs.gnu.org; Mon, 25 Nov 2024 02:14:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732518896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=shn6yUPhmlOZHQQWmHXEtkLqWzfIL8gMdSPkcoP7674=; b=QuHqYlanD+3rQTy4Amim89um0Pp8w+i/jK4+G5p4WWylyx328FOULUH4IHCuScd8areoAL /hBsaOvWYeUoCmhSw711WqD88mOeW7obD4hmat4kWJSzm8DHzAxaH4ETURzBD3L9OShMw/ oKsUrgnq/O+5eIAi43DdcvPatXW1SxM= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-371-PSPVjhYUP3KxtdtxAAK6lw-1; Mon, 25 Nov 2024 02:14:54 -0500 X-MC-Unique: PSPVjhYUP3KxtdtxAAK6lw-1 X-Mimecast-MFC-AGG-ID: PSPVjhYUP3KxtdtxAAK6lw Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-aa53a12746dso13265166b.0 for <74434 <at> debbugs.gnu.org>; Sun, 24 Nov 2024 23:14:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732518893; x=1733123693; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=shn6yUPhmlOZHQQWmHXEtkLqWzfIL8gMdSPkcoP7674=; b=NPeuyzpqj8A4Y5noY60bYrQWm11Ngz4i00/6dFxNPEsDUXBFA1NacMivZSyoZ78Wqw G45llD1bHVWqamI1ZmcIgVFHio8VcN4hbn2DFC+wBy1lwAHyFvf7GcZusTxG9jjfBRow vCIVh1tcaaj6eVHVIy+HE2Ah68NYujvRx+UKhTkUV1EbQetqDlxOtb2dQyHY/4ROIopR Uv2a+tdlgH0ivSjCc2Wju2cu/C6f9tJ/yyZk5Cokkv7zRYyV6vxVFgYUqrzsP6alHB4z cZh+K2olo09XCO/MrSmg2YVBcniD4+bcUpV/1zEcRQTi/pl5mZsLp0604vmxRfjwtzE2 YreA== X-Gm-Message-State: AOJu0Yy5qWHdrseFku6CdQzuwdvZYm8QLxOdNpfySgwD8alskl8hbixN xoZ8Hn8KNzSy3SQNYxP+pzh2qF/5yaSZ/Yxn0lqVuH6VdTdag1Rwed1yLO1OzGV1CLGJu7sQEI9 1XsR0SjVrIZLdrLPv5APtn2OvV+Nqv+YPSsc/QVrs85EeO8th2XAE8IhausXOUKHjoOaw0U7ycE n5746ozpmngTAsl2SD9zp10QtthUIn4h/Y7Ls= X-Gm-Gg: ASbGncs4w05p6F+r7LH1ttxVNzl8TRu/k1jra8SfrEfUnDYvlYKcLB4DVmJwOqKjeUL /f7uPq8e0gIyq8sh3Vd3KrsBCooO5p/IheQHsfD/sXSbq71jlBP8V3J2mi8C3YA== X-Received: by 2002:a17:907:e8b:b0:aa5:3e81:5abc with SMTP id a640c23a62f3a-aa53e815e70mr219646166b.1.1732518892698; Sun, 24 Nov 2024 23:14:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IF1roLcNUL9OVFLgtrs9FU4uERZGKibsrvXSAse5hf+xqQpXhF6PqWT7Psm8MVGyIHhsrbjHACK+XeuNXvc/rM= X-Received: by 2002:a17:907:e8b:b0:aa5:3e81:5abc with SMTP id a640c23a62f3a-aa53e815e70mr219646066b.1.1732518892408; Sun, 24 Nov 2024 23:14:52 -0800 (PST) MIME-Version: 1.0 References: <20241122122710.2737628-1-fberat@HIDDEN> <202411240204.4AO24WBc363282@HIDDEN> In-Reply-To: <202411240204.4AO24WBc363282@HIDDEN> From: Frederic Berat <fberat@HIDDEN> Date: Mon, 25 Nov 2024 08:14:41 +0100 Message-ID: <CAObJKZrct9JAKRtAKxjt2u6zN_JsxP-+psws2brr9jawMj3H3A@HIDDEN> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ini0VYT8oRw-F_L0U9fXnAT4rju3mz5FB6uyVmF10yg_1732518893 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000262d860627b77d80" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --000000000000262d860627b77d80 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Nov 24, 2024 at 3:05=E2=80=AFAM Karl Berry <karl@HIDDEN> w= rote: > +case "$PYTHON" in > + *python*) ;; > + *) > + echo "$me: Invalid python executable ${PYTHON}"; > + echo "$me: Python support disabled"; > + exit 0;; > +esac > > Thanks. But I'm not sure about requiring the executable name to include > "python". Apart from technically being against GNU standards, I can > imagine people making a link named anything and then using that. For > whatever reason. > > Maybe it would suffice to run $PYTHON -V and see if the result matches > grep -i python? > > I don't have Python 2.0 (the oldest we claim to support, though I have > my doubts), but it works with Python 2.7. > > $ python2.7 -V > Python 2.7.18 > > Wdyt? --thanks, karl. > That sounds reasonable. --000000000000262d860627b77d80 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">= <div dir=3D"ltr" class=3D"gmail_attr">On Sun, Nov 24, 2024 at 3:05=E2=80=AF= AM Karl Berry <<a href=3D"mailto:karl@HIDDEN">karl@freefriends.= org</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"marg= in:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1e= x">=C2=A0 =C2=A0 +case "$PYTHON" in<br> =C2=A0 =C2=A0 +=C2=A0 *python*) ;;<br> =C2=A0 =C2=A0 +=C2=A0 *)<br> =C2=A0 =C2=A0 +=C2=A0 echo "$me: Invalid python executable ${PYTHON}&q= uot;;<br> =C2=A0 =C2=A0 +=C2=A0 echo "$me: Python support disabled";<br> =C2=A0 =C2=A0 +=C2=A0 exit 0;;<br> =C2=A0 =C2=A0 +esac<br> <br> Thanks. But I'm not sure about requiring the executable name to include= <br> "python". Apart from technically being against GNU standards, I c= an<br> imagine people making a link named anything and then using that. For<br> whatever reason.<br> <br> Maybe it would suffice to run $PYTHON -V and see if the result matches<br> grep -i python?<br> <br> I don't have Python 2.0 (the oldest we claim to support, though I have<= br> my doubts), but it works with Python 2.7.<br> <br> $ python2.7 -V<br> Python 2.7.18<br> <br> Wdyt? --thanks, karl.<br></blockquote><div><br></div><div>That sounds reaso= nable. <br></div></div></div> --000000000000262d860627b77d80--
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.