GNU logs - #74505, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#74505] [PATCH] Update freeciv to version 3.1.3
Resent-From: glab <glab@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 24 Nov 2024 07:35:02 +0000
Resent-Message-ID: <handler.74505.B.173243368313099 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 74505 <at> debbugs.gnu.org
MIME-Version: 1.0
Date: Sat, 23 Nov 2024 22:20:17 +0000
From: glab <glab@HIDDEN>
Message-ID: <ddc71212a342fc798c8f089bfce62af2@HIDDEN>
Content-Type: multipart/mixed;
 boundary="=_b0177fab96bd00fd2693cd5270d64fc1"
Received-SPF: pass client-ip=178.21.23.139; envelope-from=glab@HIDDEN;
 helo=layka.disroot.org
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Mailman-Approved-At: Sun, 24 Nov 2024 02:34:41 -0500
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

--=_b0177fab96bd00fd2693cd5270d64fc1
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
 name=0001-Update-freeciv-to-version-3.1.3.patch
Content-Disposition: attachment;
 filename=0001-Update-freeciv-to-version-3.1.3.patch;
 size=1834

RnJvbSAxZTZmNGIyOTA1MDBiYmI4NGE5NjE5NDc4YjQzMDcxYTA4YTM4ODE1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpNZXNzYWdlLUlEOiA8MWU2ZjRiMjkwNTAwYmJiODRhOTYxOTQ3OGI0MzA3
MWEwOGEzODgxNS4xNzMyMzk5NDczLmdpdC5nbGFiK2d1aXhAZGlzcm9vdC5vcmc+CkZyb206IEd1
c3Rhdm8gTGFib3JlaXJvIDxnbGFiK2d1aXhAZGlzcm9vdC5vcmc+CkRhdGU6IFNhdCwgMjMgTm92
IDIwMjQgMjA6MDU6MDkgKzAwMDAKU3ViamVjdDogW1BBVENIXSBVcGRhdGUgZnJlZWNpdiB0byB2
ZXJzaW9uIDMuMS4zCgpUaGlzIGlzIGEgdHJpdmlhbCB1cGRhdGUgdG8gdGhlIHBhY2thZ2UuIEEg
bmV3IGRlcGVuZGVuY3kgaXMKaW50cm9kdWNlZCAoc3FsaXRlMykuCgpDaGFuZ2UtSWQ6IElmMGMz
NDFiMTc5ZDE3MDQ0MzdmNGJkNzRkZDkyZDgzNGE5MDJjOWI5Ci0tLQogZ251L3BhY2thZ2VzL2dh
bWVzLnNjbSB8IDcgKysrKy0tLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMyBk
ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvZ2FtZXMuc2NtIGIvZ251L3Bh
Y2thZ2VzL2dhbWVzLnNjbQppbmRleCAzOWUzYjZkLi5hNzRkODJkIDEwMDY0NAotLS0gYS9nbnUv
cGFja2FnZXMvZ2FtZXMuc2NtCisrKyBiL2dudS9wYWNrYWdlcy9nYW1lcy5zY20KQEAgLTg1LDYg
Kzg1LDcgQEAKIDs7OyBDb3B5cmlnaHQgwqkgMjAyNCBKYW1lcyBTbWl0aCA8anN1YnVudHV4cEBk
aXNyb290Lm9yZz4KIDs7OyBDb3B5cmlnaHQgwqkgMjAyNCBKYW4gV2llbGtpZXdpY3ogPHRvbmFf
a29zbWljem5lZ29fc21pZWNpYUBpbnRlcmlhLnBsPgogOzs7IENvcHlyaWdodCDCqSAyMDI0IEFz
aHZpdGggU2hldHR5IDxhc2h2aXRoc2hldHR5MTBAZ21haWwuY29tPgorOzs7IENvcHlyaWdodCDC
qSAyMDI0IEd1c3Rhdm8gTGFib3JlaXJvIDxnbGFiK2d1aXhAZGlzcm9vdC5vcmc+CiA7OzsKIDs7
OyBUaGlzIGZpbGUgaXMgcGFydCBvZiBHTlUgR3VpeC4KIDs7OwpAQCAtNjcyMSw3ICs2NzIyLDcg
QEAgKGRlZmluZS1wdWJsaWMga29ib2RlbHV4ZQogKGRlZmluZS1wdWJsaWMgZnJlZWNpdgogICAo
cGFja2FnZQogICAgKG5hbWUgImZyZWVjaXYiKQotICAgKHZlcnNpb24gIjMuMC44IikKKyAgICh2
ZXJzaW9uICIzLjEuMyIpCiAgICAoc291cmNlCiAgICAgKG9yaWdpbgogICAgICAobWV0aG9kIHVy
bC1mZXRjaCkKQEAgLTY3MzMsMTAgKzY3MzQsMTAgQEAgKGRlZmluZS1wdWJsaWMgZnJlZWNpdgog
ICAgICAgICAgICAgICAgICAgKHZlcnNpb24tbWFqb3IrbWlub3IgdmVyc2lvbikgIi8iIHZlcnNp
b24KICAgICAgICAgICAgICAgICAgICIvZnJlZWNpdi0iIHZlcnNpb24gIi50YXIueHoiKSkpCiAg
ICAgIChzaGEyNTYKLSAgICAgIChiYXNlMzIgIjFtM253ejBhYWQ2cDMzenZtZGxkYnczOXJpdzJ4
cW45OWI2Mzg0YnZ4NDQ4YzhwczZuaXYiKSkpKQorICAgICAgKGJhc2UzMiAiMGJ2ejVocXBwajU4
OXcwOGJ6cmZ6ZjVtNm53ZndyemdnMDNscWIzcDhoc3Bqa3g4YzQzbCIpKSkpCiAgICAoYnVpbGQt
c3lzdGVtIGdudS1idWlsZC1zeXN0ZW0pCiAgICAoaW5wdXRzCi0gICAgKGxpc3QgY3VybCBjeXJ1
cy1zYXNsIGd0aysgc2RsLW1peGVyIHpsaWIpKQorICAgIChsaXN0IGN1cmwgY3lydXMtc2FzbCBn
dGsrIHNkbC1taXhlciB6bGliIHNxbGl0ZSkpCiAgICAobmF0aXZlLWlucHV0cwogICAgIChsaXN0
IHBrZy1jb25maWcpKQogICAgKGhvbWUtcGFnZSAiaHR0cHM6Ly93d3cuZnJlZWNpdi5vcmcvIikK
CmJhc2UtY29tbWl0OiAyODVjNzhjYjg5Y2QwZWYzNzc1NDA2ZWNhOWFmOWFhODdkZTIxMmEwCi0t
IAoyLjQ2LjAKCg==
--=_b0177fab96bd00fd2693cd5270d64fc1--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: glab <glab@HIDDEN>
Subject: bug#74505: Acknowledgement ([PATCH] Update freeciv to version 3.1.3)
Message-ID: <handler.74505.B.173243368313099.ack <at> debbugs.gnu.org>
References: <ddc71212a342fc798c8f089bfce62af2@HIDDEN>
X-Gnu-PR-Message: ack 74505
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 74505 <at> debbugs.gnu.org
Date: Sun, 24 Nov 2024 07:35:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 74505 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
74505: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D74505
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#74505] [PATCH] Update freeciv to version 3.1.3
References: <ddc71212a342fc798c8f089bfce62af2@HIDDEN>
Resent-From: Rodion Goritskov <rodion.goritskov@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 24 Nov 2024 20:39:01 +0000
Resent-Message-ID: <handler.74505.B74505.17324807117524 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 74505 <at> debbugs.gnu.org
Cc: glab <glab@HIDDEN>
From: Rodion Goritskov <rodion.goritskov@HIDDEN>
In-Reply-To: <ddc71212a342fc798c8f089bfce62af2@HIDDEN>
Date: Mon, 25 Nov 2024 00:37:11 +0400
Message-ID: <87frngtll4.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>


Hi!

I tried building and running an updated version.
It builds fine, but game has no sound.

>     (inputs
> -    (list curl cyrus-sasl gtk+ sdl-mixer zlib))
> +    (list curl cyrus-sasl gtk+ sdl-mixer zlib sqlite))

As far as I understand - sdl-mixer version 1 support had been dropped in
version 3.1.0 [1]

I tried building with sdl2-mixer instead of sdl-mixer - that fixed the
sound issue.

Also, I think that dependency list should be sorted alphabetically (it
looks like it was previously).

[1] - https://web.archive.org/web/https://gna.org/patch/?6246

Message sent to guix-patches@HIDDEN:

Subject: [bug#74505] [PATCH] Update freeciv to version 3.1.3
Resent-From: glab <glab@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 09 Dec 2024 04:22:02 +0000
Resent-Message-ID: <handler.74505.B74505.173371810914751 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Rodion Goritskov <rodion.goritskov@HIDDEN>
Cc: 74505 <at> debbugs.gnu.org
MIME-Version: 1.0
Date: Sun, 08 Dec 2024 20:52:30 +0000
From: glab <glab@HIDDEN>
In-Reply-To: <87frngtll4.fsf@HIDDEN>
References: <87frngtll4.fsf@HIDDEN>
Message-ID: <7c5dddb24c595fb17c162006c75a5c00@HIDDEN>
Content-Type: multipart/mixed;
 boundary="=_032583c9eb66e59ca6d8b2cc90fa7737"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--=_032583c9eb66e59ca6d8b2cc90fa7737
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII;
 format=flowed

On 2024-11-24 20:37, Rodion Goritskov wrote:
> Hi!
> 
> I tried building and running an updated version.
> It builds fine, but game has no sound.
> 
>>     (inputs
>> -    (list curl cyrus-sasl gtk+ sdl-mixer zlib))
>> +    (list curl cyrus-sasl gtk+ sdl-mixer zlib sqlite))
> 
> As far as I understand - sdl-mixer version 1 support had been dropped 
> in
> version 3.1.0 [1]
> 
> I tried building with sdl2-mixer instead of sdl-mixer - that fixed the
> sound issue.
> 
> Also, I think that dependency list should be sorted alphabetically (it
> looks like it was previously).
> 
> [1] - https://web.archive.org/web/https://gna.org/patch/?6246

Hello. Thank you, Rodion, for helping me with this patch.

I think I have improved it, based on your feedback.

Best regards,
-- 
Gustavo
--=_032583c9eb66e59ca6d8b2cc90fa7737
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
 name=0001-Update-freeciv-to-version-3.1.3.patch
Content-Disposition: attachment;
 filename=0001-Update-freeciv-to-version-3.1.3.patch;
 size=1837

RnJvbSA4OWZlMmQ3NGRlYmFiNDM3Y2U4MTQ3YjQ5Yjc5NDNjMWE5ZWVjMzZmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpNZXNzYWdlLUlEOiA8ODlmZTJkNzRkZWJhYjQzN2NlODE0N2I0OWI3OTQz
YzFhOWVlYzM2Zi4xNzMzNjkwNzIxLmdpdC5nbGFiK2d1aXhAZGlzcm9vdC5vcmc+CkZyb206IEd1
c3Rhdm8gTGFib3JlaXJvIDxnbGFiK2d1aXhAZGlzcm9vdC5vcmc+CkRhdGU6IFNhdCwgMjMgTm92
IDIwMjQgMjA6MDU6MDkgKzAwMDAKU3ViamVjdDogW1BBVENIXSBVcGRhdGUgZnJlZWNpdiB0byB2
ZXJzaW9uIDMuMS4zCgpUaGlzIGlzIGEgdHJpdmlhbCB1cGRhdGUgdG8gdGhlIHBhY2thZ2UuIEEg
bmV3IGRlcGVuZGVuY3kgaXMKaW50cm9kdWNlZCAoc3FsaXRlMykuCgpDaGFuZ2UtSWQ6IElmMGMz
NDFiMTc5ZDE3MDQ0MzdmNGJkNzRkZDkyZDgzNGE5MDJjOWI5Ci0tLQogZ251L3BhY2thZ2VzL2dh
bWVzLnNjbSB8IDcgKysrKy0tLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMyBk
ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvZ2FtZXMuc2NtIGIvZ251L3Bh
Y2thZ2VzL2dhbWVzLnNjbQppbmRleCA5YzczMTZmZi4uNzM0ZWFhM2MgMTAwNjQ0Ci0tLSBhL2du
dS9wYWNrYWdlcy9nYW1lcy5zY20KKysrIGIvZ251L3BhY2thZ2VzL2dhbWVzLnNjbQpAQCAtODUs
NiArODUsNyBAQAogOzs7IENvcHlyaWdodCDCqSAyMDI0IEphbWVzIFNtaXRoIDxqc3VidW50dXhw
QGRpc3Jvb3Qub3JnPgogOzs7IENvcHlyaWdodCDCqSAyMDI0IEphbiBXaWVsa2lld2ljeiA8dG9u
YV9rb3NtaWN6bmVnb19zbWllY2lhQGludGVyaWEucGw+CiA7OzsgQ29weXJpZ2h0IMKpIDIwMjQg
QXNodml0aCBTaGV0dHkgPGFzaHZpdGhzaGV0dHkxMEBnbWFpbC5jb20+Cis7OzsgQ29weXJpZ2h0
IMKpIDIwMjQgR3VzdGF2byBMYWJvcmVpcm8gPGdsYWIrZ3VpeEBkaXNyb290Lm9yZz4KIDs7Owog
Ozs7IFRoaXMgZmlsZSBpcyBwYXJ0IG9mIEdOVSBHdWl4LgogOzs7CkBAIC02NzIxLDcgKzY3MjIs
NyBAQCAoZGVmaW5lLXB1YmxpYyBrb2JvZGVsdXhlCiAoZGVmaW5lLXB1YmxpYyBmcmVlY2l2CiAg
IChwYWNrYWdlCiAgICAobmFtZSAiZnJlZWNpdiIpCi0gICAodmVyc2lvbiAiMy4wLjgiKQorICAg
KHZlcnNpb24gIjMuMS4zIikKICAgIChzb3VyY2UKICAgICAob3JpZ2luCiAgICAgIChtZXRob2Qg
dXJsLWZldGNoKQpAQCAtNjczMywxMCArNjczNCwxMCBAQCAoZGVmaW5lLXB1YmxpYyBmcmVlY2l2
CiAgICAgICAgICAgICAgICAgICAodmVyc2lvbi1tYWpvcittaW5vciB2ZXJzaW9uKSAiLyIgdmVy
c2lvbgogICAgICAgICAgICAgICAgICAgIi9mcmVlY2l2LSIgdmVyc2lvbiAiLnRhci54eiIpKSkK
ICAgICAgKHNoYTI1NgotICAgICAgKGJhc2UzMiAiMW0zbnd6MGFhZDZwMzN6dm1kbGRidzM5cml3
Mnhxbjk5YjYzODRidng0NDhjOHBzNm5pdiIpKSkpCisgICAgICAoYmFzZTMyICIwYnZ6NWhxcHBq
NTg5dzA4YnpyZnpmNW02bndmd3J6Z2cwM2xxYjNwOGhzcGpreDhjNDNsIikpKSkKICAgIChidWls
ZC1zeXN0ZW0gZ251LWJ1aWxkLXN5c3RlbSkKICAgIChpbnB1dHMKLSAgICAobGlzdCBjdXJsIGN5
cnVzLXNhc2wgZ3RrKyBzZGwtbWl4ZXIgemxpYikpCisgICAgKGxpc3QgY3VybCBjeXJ1cy1zYXNs
IGd0aysgc2RsMi1taXhlciBzcWxpdGUgemxpYikpCiAgICAobmF0aXZlLWlucHV0cwogICAgIChs
aXN0IHBrZy1jb25maWcpKQogICAgKGhvbWUtcGFnZSAiaHR0cHM6Ly93d3cuZnJlZWNpdi5vcmcv
IikKCmJhc2UtY29tbWl0OiBmMTI2M2Y0MWVkNzQyZDg5YjM1NDI0MWEwNGQxOWMwODQwYjg2YmM0
Ci0tIAoyLjQ2LjAKCg==
--=_032583c9eb66e59ca6d8b2cc90fa7737--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#74505] [PATCH] Update freeciv to version 3.1.3
References: <ddc71212a342fc798c8f089bfce62af2@HIDDEN>
In-Reply-To: <ddc71212a342fc798c8f089bfce62af2@HIDDEN>
Resent-From: Rodion Goritskov <rodion.goritskov@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 22 Dec 2024 21:47:02 +0000
Resent-Message-ID: <handler.74505.B74505.173490397912741 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 74505
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 74505 <at> debbugs.gnu.org
Received: via spool by 74505-submit <at> debbugs.gnu.org id=B74505.173490397912741
          (code B ref 74505); Sun, 22 Dec 2024 21:47:02 +0000
Received: (at 74505) by debbugs.gnu.org; 22 Dec 2024 21:46:19 +0000
Received: from localhost ([127.0.0.1]:52241 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tPTmF-0003JQ-Ax
	for submit <at> debbugs.gnu.org; Sun, 22 Dec 2024 16:46:19 -0500
Received: from mail-wr1-f42.google.com ([209.85.221.42]:47425)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rodion.goritskov@HIDDEN>) id 1tPTmB-0003JH-SD
 for 74505 <at> debbugs.gnu.org; Sun, 22 Dec 2024 16:46:17 -0500
Received: by mail-wr1-f42.google.com with SMTP id
 ffacd0b85a97d-38634c35129so2735833f8f.3
 for <74505 <at> debbugs.gnu.org>; Sun, 22 Dec 2024 13:46:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1734903915; x=1735508715; darn=debbugs.gnu.org;
 h=mime-version:message-id:date:subject:to:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=kZDYeCNmlA/OW9xSZCcYB7kJUW4h8Yu3eeFtoP+0s8M=;
 b=XpM2Aow4jwJtzNuEY4VFHZ+mUg0Jbk1yAY4gwH1xqY5hjwrxzr0F6fUD4S0Y5JTqfC
 GHFEaiZpajX5OCzCOPnO2iprhPBjKfwXGP8MF/PiwakDO/elQFCQfDEHeTsqU4Fd89Ie
 aSEdVzz7cIadvYFqXpOtpyGmoLlzcDjXp/KABk0WLVScMHmORSJkNS0ys7Y8Adq6qYAg
 WLXz809LbBbnC/wCQ3XIeWBb6yDxR+TxcGJRhl7ixfDb+DlA0hGO4jDEnrG5D9Pzkjhc
 +NqygccKVpnFksNpTsgHHkuWc+8JYt7UVCoz+F13qWx78LOxN8NE21rTMMYM0hlXTD9M
 yvRw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1734903915; x=1735508715;
 h=mime-version:message-id:date:subject:to:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=kZDYeCNmlA/OW9xSZCcYB7kJUW4h8Yu3eeFtoP+0s8M=;
 b=bNlxk12bCZUO57pIDhCWa7cGbXOaTmsn5uWRbk1z8YsJEQ0FeooWvaQJuRj+IWd209
 5PbeOXnpVfH0l4pvPr8qMBmjiky3FQNM9Vodxs7gv3Upn76l2zTX+u3IQoyO5CuVMcBX
 Fg211CFNT45bD+QTFM9MlUKJ4SkBK/cjSH/xVG0g+rJvETm4XD9vN/tOpVFANF8TXHrh
 HmdsHEcji4Oj+nYCkxFwFqmSlCBm54Kid+6yyOPc2Rk5ICKqvOOgbCn13GId3YXqNWgN
 URahJt2/hSEvrirjKlihL/vUAfj87WIv4yGlFg1NEPUZph38JsqEcVO0P4z8tNRqCXke
 sYog==
X-Gm-Message-State: AOJu0YxWH5SJ4GtfVsQAelEzxcuLZvlNUAVIq/8bCy6vSdwVM9xlWVjJ
 dUR5iPQ2+zWB6Cx0qIU+hRmuW5SgVyq4gmCyvtqkyqSM8nnoBvaPaO66zg==
X-Gm-Gg: ASbGncsiPwI/zHDprU18enCN5DXPTm2RkKEi+lNSEm+lqtFKfCEze5dN/WaMgfhBjEf
 6sk9iGipwz5GdxuyNRm5ti40l/2NvMv0Dp7HnPAn/MH8G1s0JjRQJGR7Y0jqJs9PoDojAcGS1/A
 Kf7cJJgMwRe1jI7/COl3X4SgGSAYuokIpzuYwxIDlOi3TdgPZN2dnWi6pLaXUqRwA3QU/DCOiDe
 yYkxyEBkO3xemsohFzcVrmTp33Chne0gkXSPGShz2gMfxPNj7bv4G0Ocr9WPFSctkl6v+j+A/bk
 YtRohXqj/+zIWj9QVKw+INcpx9zqOA16/W4qgQX03Q==
X-Google-Smtp-Source: AGHT+IHMtMsEsbML9S/JS1GEEgY6c1bAmNXn00J9QVPjxwFB178LjWz+AVNAQgxSkzJRZ0niKcVTFQ==
X-Received: by 2002:a5d:64ac:0:b0:385:effc:a279 with SMTP id
 ffacd0b85a97d-38a223ff46cmr8259964f8f.58.1734903914512; 
 Sun, 22 Dec 2024 13:45:14 -0800 (PST)
Received: from bumblebee-serious (port-92-193-175-166.dynamic.as20676.net.
 [92.193.175.166]) by smtp.gmail.com with ESMTPSA id
 ffacd0b85a97d-38a1c89e2b0sm9932648f8f.82.2024.12.22.13.45.12
 for <74505 <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 22 Dec 2024 13:45:13 -0800 (PST)
From: Rodion Goritskov <rodion.goritskov@HIDDEN>
Date: Sun, 22 Dec 2024 22:45:08 +0100
Message-ID: <865xnbv1cr.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Gustavo,

Thank you for the updated patch - it works great now (not a big fan of
freeciv, but at least game starts and sound works fine after selecting
sdl in sound options).

I don't have any comments about the changes in patch.
But I noticed some things to improve in commit messages and patch naming.

Looks like now it is not fully up to the Guix commit style practices.

Lets take a look on some package update commit message example [1]

Commit message first line should be in format:
> gnu: <package name>: Update to <version>

And then in following lines specific changes should be described:

> * gnu/packages/<file>.scm (<package>): Update to <version>
> [inputs]: <change in inputs description>

For broad and detailed commit logs standards you could check GNU Coding
Standards [2]. But examples are easier (:

Also, please send an updated version of the patch with the next
revision, so it would be easier for maintainers to distinct and apply
it.

To do this you could specify the revision 2 in git send-email. You could
find some instructions in documentation [3] at the end of the Single
Patches section.

Also, you could take a look on the mumi CLI tool, it makes working with
patches much easier [4].

Happy hacking!

[1] -
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=af28be202cb2b7fd0fc2e277467304f81c78ab74
[2] -
https://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-Logs
[3] -
https://guix.gnu.org/manual/devel/en/html_node/Sending-a-Patch-Series.html
[4] - https://guix.gnu.org/manual/devel/en/html_node/Debbugs-User-Interfaces.html#Command_002dLine-Interface

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.