GNU logs - #74584, boring messages

Message sent to bug-guix@HIDDEN:

Subject: bug#74584: wrong pull/time-machine message when channels.scm does not exit
Resent-From: Simon Tournier <zimon.toutoune@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Thu, 28 Nov 2024 08:25:02 +0000
Resent-Message-ID: <handler.74584.B.173278229411459 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 74584 <at> debbugs.gnu.org
From: Simon Tournier <zimon.toutoune@HIDDEN>
Date: Thu, 28 Nov 2024 02:26:16 +0100
Message-ID: <874j3sf8sn.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=2a00:1450:4864:20::32c;
 envelope-from=zimon.toutoune@HIDDEN; helo=mail-wm1-x32c.google.com
X-Spam_score_int: -5
X-Spam_score: -0.6
X-Spam_bar: /
X-Spam_report: (-0.6 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_06_12=1.543,
 DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -0.2 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.2 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi,

The =E2=80=9Cbug=E2=80=9C:

--8<---------------cut here---------------start------------->8---
$ ls channels.scm
ls: cannot access 'channels.scm': No such file or directory

$ guix time-machine -q -C channels.scm -- help
guix time-machine: error: 'channels.scm' did not return a list of channels
--8<---------------cut here---------------end--------------->8---

That=E2=80=99s incorrect.  What I expect is something as:

--8<---------------cut here---------------start------------->8---
$ ls foo.scm
ls: cannot access 'foo.scm': No such file or directory

$ guix time-machine -q -C foo.scm -- help
guix time-machine: error: failed to load 'foo.scm':
ice-9/boot-9.scm:2190:9: In procedure primitive-load-path: Unable to find f=
ile "guix/foo.scm" in load path
--8<---------------cut here---------------end--------------->8---

Although the second part can be confusing for regular user.  And
although I think the message is also incorrect.

Well, the story is about =E2=80=99load*=E2=80=99 from module (guix ui).  Us=
ing this
trivial patch with some =E2=80=99pk=E2=80=99.


--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline; filename=p.patch
Content-Description: trivial.patch

diff --git a/guix/scripts/pull.scm b/guix/scripts/pull.scm
index 58d3cd7e83..d294df4f37 100644
--- a/guix/scripts/pull.scm
+++ b/guix/scripts/pull.scm
@@ -752,6 +752,7 @@ (define (channel-list opts)
 
   (define (load-channels file)
     (let ((result (load* file (make-user-module '((guix channels))))))
+      (pk 'load-channels result)
       (if (and (list? result) (every channel? result))
           result
           (leave (G_ "'~a' did not return a list of channels~%") file))))
diff --git a/guix/ui.scm b/guix/ui.scm
index eba12c8616..651cea4ff7 100644
--- a/guix/ui.scm
+++ b/guix/ui.scm
@@ -250,7 +250,11 @@ (define* (load* file user-module
                ;; 'primitive-load', so that FILE is compiled, which then allows
                ;; us to provide better error reporting with source line numbers.
                (without-compiler-optimizations
-                (load (try-canonicalize-path file))))
+                (begin
+                  (pk 'file file)
+                  (pk 'try-canonicalize-path (try-canonicalize-path file))
+                  (pk 'load-file (load file))
+                  (load (try-canonicalize-path file)))))
              (const #f))))))
     (lambda _
       ;; XXX: Errors are reported from the pre-unwind handler below, but
@@ -262,6 +266,7 @@ (define* (load* file user-module
          (let* ((stack (make-stack #t handle-error tag))
                 (frame (last-frame-with-source stack)))
 
+           (pk 'let-raise-error)
            (report-load-error file args frame)
 
            (case on-error

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


It reads:

--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix time-machine -q -C channels.scm -- help

;;; (file "channels.scm")

;;; (try-canonicalize-path "channels.scm")

;;; (load-file #<unspecified>)

;;; (load-channels #<unspecified>)
guix time-machine: error: 'channels.scm' did not return a list of channels
--8<---------------cut here---------------end--------------->8---

In other words, instead of raising an error, it returns #<unspecified>
and thus because =E2=80=99load-channels=E2=80=99 tests against =E2=80=99lis=
t?=E2=80=99 which
#<unspecified> is obviously not then bang!

Bah the easy fix is to check with =E2=80=99unspecified?=E2=80=99 directly in
=E2=80=99load-channels=E2=80=99.  But that does not really fix the issue, I=
MHO.

The issue is that because a file named channels.scm is around in
load-path.  For instance, let say the non-existent file is named
=E2=80=99packages.scm=E2=80=99:

--8<---------------cut here---------------start------------->8---
$ ls packages.scm
ls: cannot access 'packages.scm': No such file or directory

$ guix time-machine -q -C packages.scm -- help
guix time-machine: error: 'packages.scm' did not return a list of channels
--8<---------------cut here---------------end--------------->8---

In other words, is the comment accurate

               ;; Give 'load' an absolute file name so that it doesn't try =
to
               ;; search for FILE in %LOAD-PATH.

?

Well, since I am not sure to get the use case of
=E2=80=99try-canonicalize-path=E2=80=99, then I don=E2=80=99t know what cou=
ld be the best fix.
But I guess =E2=80=99canonicalize-path=E2=80=99 is not doing what we expect=
, right?

Cheers,
simon

--=-=-=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Simon Tournier <zimon.toutoune@HIDDEN>
Subject: bug#74584: Acknowledgement (wrong pull/time-machine message when
 channels.scm does not exit)
Message-ID: <handler.74584.B.173278229411459.ack <at> debbugs.gnu.org>
References: <874j3sf8sn.fsf@HIDDEN>
X-Gnu-PR-Message: ack 74584
X-Gnu-PR-Package: guix
Reply-To: 74584 <at> debbugs.gnu.org
Date: Thu, 28 Nov 2024 08:25:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-guix@HIDDEN

If you wish to submit further information on this problem, please
send it to 74584 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
74584: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D74584
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.