GNU logs - #74832, boring messages

Message sent to bug-guix@HIDDEN:

Subject: bug#74832: guix copy incorrectly assumes port is 22
Resent-From: Dariqq <dariqq@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Thu, 12 Dec 2024 16:46:02 +0000
Resent-Message-ID: <handler.74832.B.173402194714647 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 74832 <at> debbugs.gnu.org
Message-ID: <bd64a6c0-3a38-4fe2-9315-c4ff6be02e91@HIDDEN>
Date: Thu, 12 Dec 2024 16:45:20 +0000
MIME-Version: 1.0
From: Dariqq <dariqq@HIDDEN>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Received-SPF: pass client-ip=185.67.36.65; envelope-from=dariqq@HIDDEN;
 helo=mout01.posteo.de
X-Spam_score_int: -43
X-Spam_score: -4.4
X-Spam_bar: ----
X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

Hello,

Here is bug report number 3 with guile-ssh@HIDDEN

When using a host defined in ~/.ssh/config in the --to/--from argument 
in guix-copy "send-to-remote-host" and "retrieve-from-remote-host" 
incorrectly pass the port as 22 to open-ssh-session.


This then leads to a failure when trying to connect:
--8<---------------cut here---------------start------------->8---

guix copy hello --to=name
guix copy: error: failed to authenticate server at 'domain': not-known

--8<---------------cut here---------------end--------------->8---


With guile-ssh@HIDDEN guile-ssh silently ignored the "wrong port" and 
instead connects to the one specified by the ssh Host

--8<---------------cut here---------------start------------->8---
guix copy hello --to=name

with guile-ssh@HIDDEN :
#<session dariqq@domain:10022 (disconnected) 7f21d88a2fe0>

with-guile-ssh@HIDDEN:
#<session dariqq@localhost:22 (disconnected) 7f17887a2fe0>
--8<---------------cut here---------------end--------------->8---

Are the (or port 22) clauses in guix/scripts/copy.scm still neccesary?

 From my limited testing removing them fixed the problem and passing a 
port of #f will result in 22 being used.

This might also be a problem in other places wghere open-ssh-session is 
used?

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Dariqq <dariqq@HIDDEN>
Subject: bug#74832: Acknowledgement (guix copy incorrectly assumes port is 22)
Message-ID: <handler.74832.B.173402194714647.ack <at> debbugs.gnu.org>
References: <bd64a6c0-3a38-4fe2-9315-c4ff6be02e91@HIDDEN>
X-Gnu-PR-Message: ack 74832
X-Gnu-PR-Package: guix
Reply-To: 74832 <at> debbugs.gnu.org
Date: Thu, 12 Dec 2024 16:46:03 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-guix@HIDDEN

If you wish to submit further information on this problem, please
send it to 74832 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
74832: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D74832
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-guix@HIDDEN:

Subject: bug#74832: guix copy incorrectly assumes port is 22
Resent-From: Tomas Volf <~@wolfsden.cz>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Thu, 12 Dec 2024 17:36:02 +0000
Resent-Message-ID: <handler.74832.B74832.173402494125471 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Dariqq <dariqq@HIDDEN>
Cc: 74832 <at> debbugs.gnu.org
From: Tomas Volf <~@wolfsden.cz>
In-Reply-To: <bd64a6c0-3a38-4fe2-9315-c4ff6be02e91@HIDDEN>
 (dariqq@HIDDEN's message of "Thu, 12 Dec 2024 16:45:20 +0000")
References: <bd64a6c0-3a38-4fe2-9315-c4ff6be02e91@HIDDEN>
Date: Thu, 12 Dec 2024 18:35:29 +0100
Message-ID: <87msh0n6se.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Dariqq <dariqq@HIDDEN> writes:

> Are the (or port 22) clauses in guix/scripts/copy.scm still neccesary?
>
>  From my limited testing removing them fixed the problem and passing a
> port of #f will result in 22 being used.

Yeah I think you are right.

>
> This might also be a problem in other places wghere open-ssh-session is
> used?

Will look them over and send a patch.

Tomas

=2D-=20
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJCBAEBCgAsFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmdbHuEOHH5Ad29sZnNk
ZW4uY3oACgkQL7/ufbZ/wak2qg//bxVsamqFAvenMNaFy3uqonKhsA6kepNaA6Gu
qKJkt6HUQdlwMiNe4lf1mBju5lEVOjXB1X4y9vQ4N5gvuT+5OdH4OBipCCoI7J68
PUC1d70ketK72B14bnWT0LJJ/np++ugQCjJ9q52uAGYGwU0miQHhhz5VORSJD753
QIgsgHyxiBB87fY+oNCRG9XQaDPE9e6WitesXSGQY7cWtTxfs18O11kSakzMl97S
gmQWCX6Et09ghSHzbu2rs5XSYPS85jwpd9woj1s9cMLBrXTCYVAeWq7/LCxaxb22
ICOpxWUZihxoJYONSkRk8ZWW1r+KmFMcMZRFR9koaayROIJO/IV1ytxzpR/j676c
qm+5ZZcltEfasPJED/kW4D6dgodieHC4/3JFOsh14a5nAqe+ypKulQuHj3Q3DwRV
jrhwBvo/Umme0rK2oWjXR/bMCxQEt79q4ROuptT2xlYHVbV77eoOF3jFrWcpmzGl
uWapeuzVgRKvkERUJOX+e6m5uqcnGPb4INvGFTro42p/HJBUJwfucbjJFlL+8u1J
yvWwXiT+BIFwtxhNr7esQZlX6dQww1LYRjNPDvwyYcFflfwS710hnYA+3oM3RVyB
4o7b6QSVU1dpVDHEbUtgdAwInXjEmWBDxXhM32ArGBFXoVfSSWmRvPKmN9zwQIpY
EOeyT9w=
=jFkk
-----END PGP SIGNATURE-----
--=-=-=--

Message sent to guix@HIDDEN, dev@HIDDEN, ludo@HIDDEN, othacehe@HIDDEN, zimon.toutoune@HIDDEN, me@HIDDEN, bug-guix@HIDDEN:

Subject: bug#74832: [PATCH] guix: Do not default to 22 ssh port (let guile-ssh do it).
References: <bd64a6c0-3a38-4fe2-9315-c4ff6be02e91@HIDDEN>
In-Reply-To: <bd64a6c0-3a38-4fe2-9315-c4ff6be02e91@HIDDEN>
Resent-From: Tomas Volf <~@wolfsden.cz>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix@HIDDEN, dev@HIDDEN, ludo@HIDDEN, othacehe@HIDDEN, zimon.toutoune@HIDDEN, me@HIDDEN, bug-guix@HIDDEN
Resent-Date: Thu, 12 Dec 2024 19:33:02 +0000
Resent-Message-ID: <handler.74832.B74832.173403195016799 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 74832 <at> debbugs.gnu.org
Cc: Tomas Volf <~@wolfsden.cz>, Christopher Baines <guix@HIDDEN>, Josselin Poiret <dev@HIDDEN>, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>, Simon Tournier <zimon.toutoune@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>
From: Tomas Volf <~@wolfsden.cz>
Date: Thu, 12 Dec 2024 20:31:04 +0100
Message-ID: <a3e2370fc79301d5de4aa242a3a81083d28cebb0.1734031864.git.~@wolfsden.cz>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

After update to guile-ssh 0.18.0, options passed to the `make-session'
procedure now take precedence over the configuration file.  In few places we
however had code like `(or port 22)' leading to (in absence of alternative
port being specified) always using port 22, ignoring the configuration file.

Due to that for example following command fails:

    guix copy hello --to=name

Name is reachable, but ssh server listens on port 2222.  That is correctly
configured in ~/.ssh/config, and the invocation used to succeed until the
upgrade.  However now it tries to connect to port 22 (since port was not
specified).  While setting the port on the command line *is* possible, it is
not exactly ergonomic.

Since guile-ssh (well, libssh) defaults to 22 if not told otherwise, we can
just always pass the port, and #f will use the port from ~/.ssh/config or, iff
none is set, 22.

I went through the repository and adjusted all places where it seemed
appropriate.  In particular, these places were left alone:

gnu/machine/digital-ocean.scm: The droplet is created with root user and the
expected key, so forcing them to those values seems correct.

gnu/machine/ssh.scm: For deployments reproducibility is favored over
convenience, and user can pass #f to explicitly request using value the
~/.ssh/config.

* guix/scripts/copy.scm (send-to-remote-host): Always pass the port to
open-ssh-session.
(retrieve-from-remote-host): Same.
* guix/scripts/offload.scm (open-ssh-session): Pass #f as #:config.  Skips
reading the configuration file and is nicer.
* guix/ssh.scm (open-ssh-session): Drop explicit parsing of the configuration
since it is parsed by default.  Report actual port used in the error message.
* guix/store/ssh.scm (connect-to-daemon): Always pass the port part of the
uri, even when #f.

Change-Id: I5fdf20f36509a9a0ef138ce72c7198f688eea494
---
I did few more tweaks than strictly required, feel free to discard them.

 guix/scripts/copy.scm    | 5 ++---
 guix/scripts/offload.scm | 2 +-
 guix/ssh.scm             | 8 +++-----
 guix/store/ssh.scm       | 2 +-
 4 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/guix/scripts/copy.scm b/guix/scripts/copy.scm
index 67975ac1a9..116583590f 100644
--- a/guix/scripts/copy.scm
+++ b/guix/scripts/copy.scm
@@ -75,8 +75,7 @@ (define (send-to-remote-host local target opts)
                 (options->derivations+files local opts)))
     (warn-if-empty items)
     (and (build-derivations local drv)
-         (let* ((session (open-ssh-session host #:user user
-                                           #:port (or port 22)))
+         (let* ((session (open-ssh-session host #:user user #:port port))
                 (remote  (connect-to-remote-daemon session))
                 (sent    (send-files local items remote
                                      #:recursive? #t)))
@@ -89,7 +88,7 @@ (define (retrieve-from-remote-host local source opts)
   (let*-values (((user host port)
                  (ssh-spec->user+host+port source))
                 ((session)
-                 (open-ssh-session host #:user user #:port (or port 22)))
+                 (open-ssh-session host #:user user #:port port))
                 ((remote)
                  (connect-to-remote-daemon session)))
     ;; TODO: Here we could to compute and build the derivations on REMOTE
diff --git a/guix/scripts/offload.scm b/guix/scripts/offload.scm
index 93e9d3759c..ccf989a881 100644
--- a/guix/scripts/offload.scm
+++ b/guix/scripts/offload.scm
@@ -234,7 +234,7 @@ (define* (open-ssh-session machine #:optional max-silent-time)
                                #:knownhosts "/dev/null"

                                ;; Likewise for ~/.ssh/config.
-                               #:config "/dev/null"
+                               #:config #f

                                ;; We need lightweight compression when
                                ;; exchanging full archives.
diff --git a/guix/ssh.scm b/guix/ssh.scm
index ae506df14c..5e89997df3 100644
--- a/guix/ssh.scm
+++ b/guix/ssh.scm
@@ -138,10 +138,6 @@ (define* (open-ssh-session host #:key user port identity
                                ;; Speed up RPCs by creating sockets with
                                ;; TCP_NODELAY.
                                #:nodelay #t)))
-
-    ;; Honor ~/.ssh/config.
-    (session-parse-config! session)
-
     (match (connect! session)
       ('ok
        (if host-key
@@ -181,7 +177,9 @@ (define* (open-ssh-session host #:key user port identity
       (x
        ;; Connection failed or timeout expired.
        (raise (formatted-message (G_ "SSH connection to '~a' port ~a failed: ~a~%")
-                                 host (or port 22) (get-error session)))))))
+                                 host
+                                 (session-get session 'port)
+                                 (get-error session)))))))

 (define* (remote-inferior session #:optional become-command)
   "Return a remote inferior for the given SESSION.  If BECOME-COMMAND is
diff --git a/guix/store/ssh.scm b/guix/store/ssh.scm
index 09c0832505..7e6371acbc 100644
--- a/guix/store/ssh.scm
+++ b/guix/store/ssh.scm
@@ -33,7 +33,7 @@ (define (connect-to-daemon uri)
   "Connect to the SSH daemon at URI, a URI object with the 'ssh' scheme."
   (remote-daemon-channel
    (open-ssh-session (uri-host uri)
-                     #:port (or (uri-port uri) 22)
+                     #:port (uri-port uri)
                      #:user (uri-userinfo uri))))

 ;;; ssh.scm ends here
--
2.46.0

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 13 Dec 2024 11:58:59 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 13 06:58:59 2024
Received: from localhost ([127.0.0.1]:41852 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tM4Ju-000252-NH
	for submit <at> debbugs.gnu.org; Fri, 13 Dec 2024 06:58:58 -0500
Received: from mail-wm1-f42.google.com ([209.85.128.42]:46295)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zimon.toutoune@HIDDEN>) id 1tM4Jq-00024V-Hd
 for control <at> debbugs.gnu.org; Fri, 13 Dec 2024 06:58:55 -0500
Received: by mail-wm1-f42.google.com with SMTP id
 5b1f17b1804b1-43622267b2eso16960275e9.0
 for <control <at> debbugs.gnu.org>; Fri, 13 Dec 2024 03:58:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1734091069; x=1734695869; darn=debbugs.gnu.org;
 h=subject:from:to:message-id:date:from:to:cc:subject:date:message-id
 :reply-to; bh=3KqspVQVjIZb7U+4bj95aSp/akZO4rSumleZrFBbNV8=;
 b=cC0d62PdnftmJAIAoysyXIOwV436ksdHEHxz9XQMr4IZPT6JgUyM63l5wgN6PZWvzl
 iryi7cYIsQ25S/JTyoCfJJtSaKO/aBMLnMhRLzM1EyAzNLWBOLotuL37FzppTIqi0dK6
 JVjV6fZwXhej+H9qmkdfwPzEqoe0b2Cnf93ouf6wkVoLb+lRGcFMskZpdyfEqWPwPHBm
 fNaV6Taz+bRdu5OZnulboKiNXfX3p12j+BT0sgOM6Mt2NA+pkZu6xPkZM+jF5Vlp/SFM
 KhWP2F+lso7jplRifSSN2qaGPC8eQeE04GpM27nUp1eVwIYRIiehbntq0avrvGHugdzu
 0Hfw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1734091069; x=1734695869;
 h=subject:from:to:message-id:date:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=3KqspVQVjIZb7U+4bj95aSp/akZO4rSumleZrFBbNV8=;
 b=a5IFeBDvjSb1ToP14l+L/VEHBKuIODG7d7C6PMabGGdZglcGPwY9KdNZT7EYiV64rk
 amqtv5lwPqr1Cs/IhAZwBXo4eZIxqKW5TwRWDqe6Auv2n0sTss+ksFCPLAuzxSIQ8VMD
 92fYqP3zOdZqIYPhuLvvXZ0j1wWqr6nt9WtqIho4UQDfMuFy0EFx72tlGCCnd4xomw1S
 PqhKfUNhDZPT9LRCaIQsQV2XOOlHwgUg+8szVkS4gdh3xn2FQY0gslOU21rgmvAy69/r
 6LjAc4nq+RFs/oxtgfoT7GC3EChinByZjykXTU6YsHpqH730tvGgXuCIztrANg3tmWxS
 tG7g==
X-Gm-Message-State: AOJu0YzlrWCS5w83CupkdEKTJP3j2fiIhjJ/YWKEp0zrKYYUe9aIWlfa
 7ibmDue66R6KPCQIXRBbBNf5b0Xfu9TYGEvoi4tEzLiFNOQR2mXcxWH8aQ==
X-Gm-Gg: ASbGncvPz5Pvn3NSAvNQCdUj3joU5CTS+EDwEFiNh0QbLBF+6rN2mTqBhaGUpoh6yJF
 REYt1TCe/Av2m1HrsPBVWkvhhb7qK55b9NzVWjNilGzD5BGPWoHiDqiP9rWKLxT8ou3YlXiT42Z
 FrgGU9emqDj3VNyIXTmuRMs6weboyuq5kYV3Vr9CcyqiPNgOl4VetGVyqP/GCWJyyfOt+szxcOX
 GOe61HqzPXMZCV/SufEULBvTK5Bg6jJQkDkxmFC3O0llEQy2ybL
X-Google-Smtp-Source: AGHT+IFIJQTz1urUo0VfcwSn7t8d7iv//apbXPMkLZUjF/PoMzoubpECgUrbdamt4pgTrl3Zlzwucg==
X-Received: by 2002:a05:600c:6058:b0:434:fd15:3ac9 with SMTP id
 5b1f17b1804b1-4362aa97487mr15238235e9.22.1734091068891; 
 Fri, 13 Dec 2024 03:57:48 -0800 (PST)
Received: from lili ([148.60.59.223]) by smtp.gmail.com with ESMTPSA id
 5b1f17b1804b1-4362559ec46sm47513535e9.20.2024.12.13.03.57.47
 for <control <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 13 Dec 2024 03:57:48 -0800 (PST)
Date: Fri, 13 Dec 2024 11:36:37 +0100
Message-Id: <87h6776f9m.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: Simon Tournier <zimon.toutoune@HIDDEN>
Subject: control message for bug #74832
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 74832 + patch
quit

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 17 Dec 2024 01:27:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Dec 16 20:27:16 2024
Received: from localhost ([127.0.0.1]:56853 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tNMMm-0006Y7-1n
	for submit <at> debbugs.gnu.org; Mon, 16 Dec 2024 20:27:16 -0500
Received: from mail-qt1-f172.google.com ([209.85.160.172]:57544)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1tNMMj-0006Xn-Vx
 for control <at> debbugs.gnu.org; Mon, 16 Dec 2024 20:27:14 -0500
Received: by mail-qt1-f172.google.com with SMTP id
 d75a77b69052e-46741855f9bso41228591cf.2
 for <control <at> debbugs.gnu.org>; Mon, 16 Dec 2024 17:27:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1734398768; x=1735003568; darn=debbugs.gnu.org;
 h=subject:from:to:message-id:date:from:to:cc:subject:date:message-id
 :reply-to; bh=qm0Ok/Oii0OssvbuhNPSo4xnFouIWIpGYq3a6GsTPuc=;
 b=Bh/bPVDnt5OLbUQuPPQW1sM+J43nBqpYh9LLtSHrBkxOd3hf1JVM3uGXPgFofkZHr6
 yzXmpd6PKzj9S4x93sA+lfYmQYgZERYpKPZK1iKVH07wRkB/8GguF4br6pdNZAF5viw2
 LVSlX7itA8mBS5zJT29r+jK4UczM0tonKaGktHvOAHWQi7K7h7b0PAy95QOedpUs40ML
 WRD6pdq8QmpraG/JHordcZaudtO0gikzQX3xCO6CeGxnS42yCe32097Tsh6JFL0Vcegt
 vwdYKBZNMuk8BkHnifo1mYKIb1V2i7VcizCwhKQ6YWNNEgo/eSpBa+wyduHsY3BxTz/m
 gMSA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1734398768; x=1735003568;
 h=subject:from:to:message-id:date:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=qm0Ok/Oii0OssvbuhNPSo4xnFouIWIpGYq3a6GsTPuc=;
 b=DGpBdXYMLlGx4QOEatMOPNgF894kV3HrSlJIRoAfvoU8wx9OKTgIWa/nCpAMHYc9O2
 QqlyznBMt9s4jldyeABiDlp452zkwgzVjVD/izHMg7WCpFQfekZLbkTNgdgVEceP3OBb
 iAgPK8oUqrQY0yVW0vMZyN74ggJw4D5Zd+aJevdYutAYvpYibDNIh6T/2FNQxCgcE7f2
 Bg63zUkEl3va6lkLvLQ2+UAI04DfPQfxZ2qXpLESDaAtrEh0da26USUe6cEV040A1Q23
 YvY2gfcf/xA+Q7x2j9gIuoYH7JnOdacgWOaT5lIHT06AkIUGHse2A9uMwWiS2Y3hGg1Z
 w0Hw==
X-Gm-Message-State: AOJu0Yz78jrL+3u+Juw53dKbTDLXCDXS7CAXy0Wrngam9uOPlSN+bhu3
 jWTaT2Guvl6o6pUak0gP+abHemintv+XQfX4a/e+ydrozXeZ1vbePKv2iejbLQc=
X-Gm-Gg: ASbGncs3ER0kGHctzKHqhe2KAb+Az7FuzJrCCuO4OHIxYD2aAOeETZVGBPlBf1GqYa8
 fqags+CZ9Cm0zHgMhrOLWi4ye1wUbXuZuogFlRnU6LfdKi9Az9Vn0I2hMICtoXTnotFAQYp0zDp
 Otly9/wjQpyAlrdn6lZa2s3nO1ua8F8hwsnPVa+RYHzdsAbQ1tvZ5c93AeMfF2F4ZkY6UFASBJL
 7VOH1bbzsK7+ux3aE2EoNezUlFwYCHz05bWsMA9uOElcin8UJHbenuG3BjOYWHjLskOs6l8PhCK
 mA==
X-Google-Smtp-Source: AGHT+IGUhs8x5radE+qJ/2cKeba7TUDFaQ3pXwPSiOMVrWVQVZmywpZFBVshmliaq+Q95XdFoEffiw==
X-Received: by 2002:a05:622a:2ca:b0:467:681a:69f4 with SMTP id
 d75a77b69052e-467a5839c08mr368361501cf.39.1734398768035; 
 Mon, 16 Dec 2024 17:26:08 -0800 (PST)
Received: from terra (vps-6234970c.vps.ovh.ca. [51.222.13.224])
 by smtp.gmail.com with ESMTPSA id
 d75a77b69052e-467b2cc278dsm33619931cf.48.2024.12.16.17.26.05
 for <control <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 16 Dec 2024 17:26:06 -0800 (PST)
Date: Tue, 17 Dec 2024 10:25:56 +0900
Message-Id: <87ldwfrtgb.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Subject: control message for bug #74832
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

merge 74832 33266
quit

Message sent to bug-guix@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#74832: guix copy incorrectly assumes port is 22
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Thu, 19 Dec 2024 02:35:02 +0000
Resent-Message-ID: <handler.74832.B74832.17345756701868 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 74832
X-GNU-PR-Package: guix
X-GNU-PR-Keywords: patch
To: Tomas Volf <~@wolfsden.cz>
Cc: Josselin Poiret <dev@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>, Simon Tournier <zimon.toutoune@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, 74832 <at> debbugs.gnu.org, Christopher Baines <guix@HIDDEN>
Received: via spool by 74832-submit <at> debbugs.gnu.org id=B74832.17345756701868
          (code B ref 74832); Thu, 19 Dec 2024 02:35:02 +0000
Received: (at 74832) by debbugs.gnu.org; 19 Dec 2024 02:34:30 +0000
Received: from localhost ([127.0.0.1]:36795 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tO6Mw-0000U4-1U
	for submit <at> debbugs.gnu.org; Wed, 18 Dec 2024 21:34:30 -0500
Received: from mail-pl1-f181.google.com ([209.85.214.181]:52690)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1tO6Mu-0000Tt-BT
 for 74832 <at> debbugs.gnu.org; Wed, 18 Dec 2024 21:34:29 -0500
Received: by mail-pl1-f181.google.com with SMTP id
 d9443c01a7336-21661be2c2dso2584815ad.1
 for <74832 <at> debbugs.gnu.org>; Wed, 18 Dec 2024 18:34:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1734575607; x=1735180407; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=lHTXZgZbodr2+DiCdy3d8SKnmEujOlEXajMSf0XaIXI=;
 b=Era/7qyH3JxyogsU3sYQJZHuV0SenIa+b28XmqffHr+TRxIYEpimykRVbAFp5s2fbU
 7NMbVcDPojMB90yOvXRtM7JYBPXdTiJWEPGxJ5AwAlIdczwdnqxUrsRVmvT56wtuyIU7
 AbzucMC8MOResNEfnnWE8wZ15jW2tobBOvnVsJdevlmhlyqcQ+8PRaI22UiQQTYYYvhk
 fzShKVwmrt9IwP2+6aNBZXqbW2wigxNJEMEOR2E8YNXjhpf0da4nPFW2TTRxnvivZAuZ
 drlhRuvf+qZiQqsjcTaVC+7IOC2wKWtBPlofSx9NJFQ/5Y9ALn69NUjJ/ddF3wbJo5mv
 phEw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1734575607; x=1735180407;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=lHTXZgZbodr2+DiCdy3d8SKnmEujOlEXajMSf0XaIXI=;
 b=A2OnHb5fB34ynT3VsKliBS2Z1I8j/I1Ao6/Y8kXn+dj7rA4OIw3crQXpE5y5sxipg6
 RXcLgr6f4CDxE+TAxx5666f047V55e++mjFf5JbwnMC4TrS27oIvG3Ot0G/7ugq5NJK7
 W2R2BmWyaZdwsNSqWQwtX9wmnd3QWKJaCPiOut5rdAFRGqZilV2cDpGn+9TPuwwzswVU
 qHz7vjRf3FEGZEMyUEp1dQWp2ghoUdsdT7xri6TqZyeJ6/leNGB5WlAxdDoN283VdlxA
 nYOFajA7El0bTSZSN4ykwHI8k7eC898N3Mk4gCOIuJAPyqgZEq9ImoK4n60oomgoFCnT
 BrEA==
X-Gm-Message-State: AOJu0YxOSd4jUs15ZKn3As32N0qiY6jnnZH235py6Tksr8UqC8eWBUtZ
 8MYpGd8Yk6Dlj8Mk4eqMgNBuy19Y80tWDy8idzw8kBf4EU81dbcg
X-Gm-Gg: ASbGncv+vj5S1a7Kc6QzBoyiaEYKohkUd0/1AaCyw4SP/qQUlJNXfflJ2nAJZ2dpr/6
 t+CgIMXF/zOwHQ+rrV5Unt3napkDPEOFF/sZy4D77XaYocdW+dLvOgFdYCtgXmrdBwfvBVFKZIN
 qXn8oJjFmTpYLaiY2f5PK27TJsVBx53/1vWa06A+S/tXBIdHev+FvxxoHOqjbYHmjVAhmtJmfBe
 A0XMEKiGuAJwYkmHBrjRcR5hAORXApinxrfjtlt7YYhg5qXcR4uHA==
X-Google-Smtp-Source: AGHT+IF/ColIvvUrG5jKabYA40UZmqMsYjX69Bvh+FTdBJECxm5jGhYDECgRMh2MKhGi/PkOTKtalQ==
X-Received: by 2002:a17:902:e54f:b0:216:59d4:40e7 with SMTP id
 d9443c01a7336-219d96ab567mr23585465ad.55.1734575607617; 
 Wed, 18 Dec 2024 18:33:27 -0800 (PST)
Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89])
 by smtp.gmail.com with ESMTPSA id
 d9443c01a7336-219dc9d945csm2180295ad.117.2024.12.18.18.33.25
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 18 Dec 2024 18:33:27 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
In-Reply-To: <a3e2370fc79301d5de4aa242a3a81083d28cebb0.1734031864.git.~@wolfsden.cz>
 (Tomas Volf's message of "Thu, 12 Dec 2024 20:31:04 +0100")
References: <bd64a6c0-3a38-4fe2-9315-c4ff6be02e91@HIDDEN>
 <a3e2370fc79301d5de4aa242a3a81083d28cebb0.1734031864.git.~@wolfsden.cz>
Date: Thu, 19 Dec 2024 11:33:17 +0900
Message-ID: <87ikrgmmfm.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Tomas,

Tomas Volf <~@wolfsden.cz> writes:

> After update to guile-ssh 0.18.0, options passed to the `make-session'
> procedure now take precedence over the configuration file.  In few places we
> however had code like `(or port 22)' leading to (in absence of alternative
> port being specified) always using port 22, ignoring the configuration file.
>
> Due to that for example following command fails:
>
>     guix copy hello --to=name
>
> Name is reachable, but ssh server listens on port 2222.  That is correctly
> configured in ~/.ssh/config, and the invocation used to succeed until the
> upgrade.

That is curious, because I had reported the exact same problem 6 years
ago (!) in bug#33266 (now merged with this one), with a similar
solution:

--8<---------------cut here---------------start------------->8---
Subject: [PATCH] Revert "copy: Default to port 22."

This reverts commit cc1dfc202f2fefb6c2eb9467d1fc90a9154550c9.  Specifying a
default port had the undesirable effect of disregarding a port specification
for a given host in the ~/.ssh/config that would otherwise have been honored
at the time `open-ssh-session' calls the `session-parse-config!' method.

In any case, `make-session' will default the port value of the created session
to 22 if left unspecified.
--8<---------------cut here---------------end--------------->8---

But, Ludovic had mentioned that without it,

--8<---------------cut here---------------start------------->8---
[...] "%p" would be "0" when using "ProxyCommand" in ~/.ssh/config.
--8<---------------cut here---------------end--------------->8---

So it'd perhaps regress in another way; I want to retry the test I had
done then but I need to setup at least a VM with SSH to test.  If you
can beat me to that, all the better :-).

-- 
Thanks,
Maxim

Message sent to bug-guix@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#74832: guix copy incorrectly assumes port is 22
Resent-From: Tomas Volf <~@wolfsden.cz>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Thu, 19 Dec 2024 09:31:02 +0000
Resent-Message-ID: <handler.74832.B74832.173460064619877 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 74832
X-GNU-PR-Package: guix
X-GNU-PR-Keywords: patch
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Cc: Josselin Poiret <dev@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>, Simon Tournier <zimon.toutoune@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, 74832 <at> debbugs.gnu.org, Christopher Baines <guix@HIDDEN>
Received: via spool by 74832-submit <at> debbugs.gnu.org id=B74832.173460064619877
          (code B ref 74832); Thu, 19 Dec 2024 09:31:02 +0000
Received: (at 74832) by debbugs.gnu.org; 19 Dec 2024 09:30:46 +0000
Received: from localhost ([127.0.0.1]:37502 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tOCrm-0005AU-0k
	for submit <at> debbugs.gnu.org; Thu, 19 Dec 2024 04:30:46 -0500
Received: from wolfsden.cz ([37.205.8.62]:45212)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <~@wolfsden.cz>) id 1tOCrj-0005AL-FQ
 for 74832 <at> debbugs.gnu.org; Thu, 19 Dec 2024 04:30:44 -0500
Received: by wolfsden.cz (Postfix, from userid 104)
 id 913C2338D14; Thu, 19 Dec 2024 09:30:42 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
 t=1734600642; bh=JbqOM8Ch874b0nsNKfQTX7/9wrX3PJZDTK9DNVikZFk=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date;
 b=jf9BH5wFS/ZecpqAoC1/NvHS9FMZauaS2Lxv7dBJhRf+Z1x6fuMpBf+sQ7EhaTRs+
 X/5uoSPeJjmjAa1v8bXl7+x1xg2QElVFNpp1ffodxFnSXgejFNsMfqAJyx+zWo7wr+
 /kh2DtQp1YyXrsKclW9e7uJhwl/H9zCDsatO5r+bGzPdIi93/3lWueGY2Ot/8lXl2Z
 RNRtUQXqhWYJk/Ma2DtuLyVN6ZM1ECpV8DKlM2w1NYj5J8acJrWWCBqoLYrtsruL/N
 9+VHojzB5MD1J+m309YuoXaXJ7kJIEqSNLBNMstExjtEeG/LmUg8TMlGOuXU5U/t08
 7NtH2elQlBmG1reb1Aya2BKYaJJBRhsWwsfcjM1uyt3xj64Cx4MjC9ld8vpRwkFK4o
 97pyna+/0Ret0LMjloMLxoWYhJFxEdmAIp+4/iDCUFJcek4+g+/4xA+BrihUTFWVxr
 hPW1K7q1qmNt31MSPOy3oKTgf5Ro8myt3JMB4LEGLdvU6F35qReNL5+Hyfj9617iGb
 wNVvSID0ROZsKTv2FtVaDCH2wRGeuAwBAWbye7wplNrZEeIY8+8oIZMo4kCNZ/9G62
 3ko0AdmmdVjQ7/1lKyNd19gi4b0QOv80XwEim+tUEj/JwlLdI+IaM9VC+UseXstd9V
 PE9ERYWGGmEykjdd1kQE+ilE=
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden
X-Spam-Level: 
X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED
 autolearn=unavailable autolearn_force=no version=3.4.6
Received: from localhost (unknown [128.0.188.242])
 by wolfsden.cz (Postfix) with ESMTPSA id 82F3037F1CE;
 Thu, 19 Dec 2024 09:30:40 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
 t=1734600640; bh=JbqOM8Ch874b0nsNKfQTX7/9wrX3PJZDTK9DNVikZFk=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date;
 b=nqHk8GsBaJLq44unj0PDXWBZEpiZk9f8J9hU6pTHXa4d7AaEnMLYU2WzqGp9RMiuN
 /CGV/P+EFqQvXnHYsRv/0VQGHlRO5R8XU34Ssf8dgePQWr/pBmJhJ1ZBLe0oXVIdcv
 RuwEKYvE6bDudYy9Jyy9ejMTnhPT8oofLOeP6NAlZXyQ6mwBOZGdv7yBH0MQWw+aOd
 1MO3vs4dwgzTsuRqG6BbSAalEzZR+6D0Br4tuyG1weD3d393525L5MBCDjQ63U2Jea
 CSWzRXOsUD1vgCfDhNvk+F93hZVEoPD/GRuX38zuZCYjzpvB5jCeoPHiB9kHd+sEXi
 Z8FSIv8HezBXlSjLYg+0JlJA1HHCGegtFY3YZ2RKWlhtyQ84U72HUJ4SpnKwGbKXrA
 kGXlye5tpjjfBFakqWTO3LrXvtwDTeQgsjvZvtv40iIeXbyQwhdeda9vupYfvxsiRV
 kqatqlyi/ECBQDnzUA8D7LjBO4hnFc51CPStwDEqGf1fQyMnIlhWtzbvaMEH4zA0PX
 VqZDJ9A75MZtE2RaVLXcWl0n2fqadOrrsYjMwkxlO3xhyDzA3pCKUNvcNL3fPq4nnF
 SFWDBvfFCf52adWhoekOvzQuLSTb3GhsE3F9ZKhD46EKNDLgm2i1RO1dcfMM5ld7hB
 SWQoUelM7j5Dsi/FAeMJhg7c=
From: Tomas Volf <~@wolfsden.cz>
In-Reply-To: <87ikrgmmfm.fsf_-_@HIDDEN> (Maxim Cournoyer's message of "Thu, 
 19 Dec 2024 11:33:17 +0900")
References: <bd64a6c0-3a38-4fe2-9315-c4ff6be02e91@HIDDEN>
 <a3e2370fc79301d5de4aa242a3a81083d28cebb0.1734031864.git.~@wolfsden.cz>
 <87ikrgmmfm.fsf_-_@HIDDEN>
Date: Thu, 19 Dec 2024 10:30:39 +0100
Message-ID: <8734ik6mv4.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Maxim Cournoyer <maxim.cournoyer@HIDDEN> writes:

> Hi Tomas,
>
> Tomas Volf <~@wolfsden.cz> writes:
>
>> After update to guile-ssh 0.18.0, options passed to the `make-session'
>> procedure now take precedence over the configuration file.  In few place=
s we
>> however had code like `(or port 22)' leading to (in absence of alternati=
ve
>> port being specified) always using port 22, ignoring the configuration f=
ile.
>>
>> Due to that for example following command fails:
>>
>>     guix copy hello --to=3Dname
>>
>> Name is reachable, but ssh server listens on port 2222.  That is correct=
ly
>> configured in ~/.ssh/config, and the invocation used to succeed until the
>> upgrade.
>
> That is curious, because I had reported the exact same problem 6 years
> ago (!) in bug#33266 (now merged with this one), with a similar
> solution:
>
> Subject: [PATCH] Revert "copy: Default to port 22."
>
> This reverts commit cc1dfc202f2fefb6c2eb9467d1fc90a9154550c9.  Specifying=
 a
> default port had the undesirable effect of disregarding a port specificat=
ion
> for a given host in the ~/.ssh/config that would otherwise have been hono=
red
> at the time `open-ssh-session' calls the `session-parse-config!' method.
>
> In any case, `make-session' will default the port value of the created se=
ssion
> to 22 if left unspecified.
>
>
> But, Ludovic had mentioned that without it,
>
> [...] "%p" would be "0" when using "ProxyCommand" in ~/.ssh/config.
>
> So it'd perhaps regress in another way; I want to retry the test I had
> done then but I need to setup at least a VM with SSH to test.  If you
> can beat me to that, all the better :-).

I wonder whether VM is necessary.  I added the following to my
~/.ssh/config file:

=2D-8<---------------cut here---------------start------------->8---
host name
port 2222
proxycommand echo %p >/tmp/port
=2D-8<---------------cut here---------------end--------------->8---

Then I executed guix copy:

=2D-8<---------------cut here---------------start------------->8---
$ guix copy hello --to=3Dname
guix copy: error: SSH connection to 'name' port 2222 failed: Socket error: =
Connection reset by peer
=2D-8<---------------cut here---------------end--------------->8---

And after that I checked /tmp:

=2D-8<---------------cut here---------------start------------->8---
$ cat /tmp/port=20
2222
=2D-8<---------------cut here---------------end--------------->8---

So it seems to work fine?  Would not hurt if someone double checked
(with the patch above applied).

Tomas

=2D-=20
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJCBAEBCgAsFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmdj578OHH5Ad29sZnNk
ZW4uY3oACgkQL7/ufbZ/wamP6Q/7B4ikDK1ixCco6JTps/lxAI5Vs36yeS3hbjHH
BrxvNT8b1HbdIY2yXkM81AIPbYaEnZ8mRUPLmDbyMD4Byrz47YmF1xbhUyS+WUg0
PM5STiimR4Uh87XuKaH9EwclTsg1ic7eBHRA7BqveSbY7BdE/y3C3m8evvg+ak7f
TTdbnYg0MZFEkZ1Fd8P4i1DpXaPyFS9xD4XFH+ND4dOFK10rFHUpAzRvZYKhAs3z
9AgrtlwSP74e7czUCGzhkyaCcNOu7lWdzgDLu1kxaZ08CxXqFOkeRPWLm7h8M0/v
TdLeru7h3KSeJGHPF/aLx9eFYohVKZLlV9KHIRDc/a788DmWPNHMEcnq9wPWyYSI
kUSR62xoS1n5enwMou0FdC2UhrdBKOW3mXo09lNU73+871kXMwjNDa0eFe67cwAW
bt4eJN6d/bololtI3wJuRa549fmVCSmfMw1Dq6g8NauisA5+QbQdoCMVWVpZMggz
Go/+yKhR88uX1XHhq2rWqGj0V7LIppXYS1N/VVlu1ROXH8+VAbgeqDTryVykrnjI
BJDbcBqVRQeOQ7/NVsSGmca8SI2q5vB/VQ0lEl6P2vRUMhoot8Kumr0nTrghXEhr
zKdQ/VZb19yYgS6unIAkIbOI5mgmbN+Vd5WXvQQ+qtKOzzD5MTIducfsEtfYNuyx
hS1+49s=
=JWzT
-----END PGP SIGNATURE-----
--=-=-=--

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.