GNU bug report logs - #74970
Supercite sc-setup-filladapt accesses void variable filladapt-prefix-table (from Filladapt)

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: emacs; Reported by: Mekeor Melire <mekeor@HIDDEN>; dated Thu, 19 Dec 2024 11:24:02 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 74970 <at> debbugs.gnu.org:


Received: (at 74970) by debbugs.gnu.org; 4 Jan 2025 11:34:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 04 06:34:19 2025
Received: from localhost ([127.0.0.1]:53607 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tU2Q6-0002iJ-LP
	for submit <at> debbugs.gnu.org; Sat, 04 Jan 2025 06:34:19 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:55166)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tU2Q4-0002i5-Ab
 for 74970 <at> debbugs.gnu.org; Sat, 04 Jan 2025 06:34:17 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1tU2Px-0000Ic-Az; Sat, 04 Jan 2025 06:34:09 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=wVzSppKNPzAwDD1Te2ujeWpb7UFNkLZ3xZbkIFOrhmg=; b=QpkDa5P99D8w
 N/yxL8WfkNWNOuED7ju6shjlw/vFSubjv9261UacFhmVHVUr61SLiy7hY/ehTkzwuZdSnhAagc3+4
 pooiW4b/PfPKH1f7LQ9+dZf1bjf9xYlCvzbirdjaxMYo52NEJda93xXIfYoPrsTzOk/UxWSVdEKd/
 gXpp29X30MW+qqsQDqbtaS09VeZ72ABVOUFjXGLmqkNoG2Ktu7veUW43t+V3Cubx7Nf1UxxLBhKMB
 NXzfkeSHQfpXNS/44Z8RKojVEugLZTpIKa2W4VXUBYWbBZYylM1oF0vDBuI/Yule2LhkGotDPS2BI
 SgVgqqhkCm+Uz9k0vYHcxg==;
Date: Sat, 04 Jan 2025 13:34:06 +0200
Message-Id: <86sepyertd.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Mekeor Melire <mekeor@HIDDEN>, kyle_jones@HIDDEN,
 bwarsaw@HIDDEN
In-Reply-To: <87msgr29yn.fsf@HIDDEN> (message from Mekeor Melire on Thu, 19
 Dec 2024 11:22:56 +0000)
Subject: Re: bug#74970: Supercite sc-setup-filladapt accesses void variable
 filladapt-prefix-table (from Filladapt)
References: <87msgr29yn.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 74970
Cc: 74970 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Ping! Barry and Kyle, could you please chime in?

> Cc: Kyle E. Jones <kyle_jones@HIDDEN>,
>  Barry A. Warsaw <bwarsaw@HIDDEN>
> From: Mekeor Melire <mekeor@HIDDEN>
> Date: Thu, 19 Dec 2024 11:22:56 +0000
> 
> (Supercite is a built-in package and Filladapt is on GNU Elpa.) 
> Supercite's manual [1] states that one can install Filladapt and 
> call the `sc-setup-filladapt' function.  But calling 
> `sc-setup-filladapt' will result in the error (void-variable 
> filladapt-prefix-table).
> 
> It seems like Filladapt has renamed that variable from 
> "filladapt-prefix-table" to "filladapt-token-table".  I only found 
> one very old version of Filladapt [2] where the old name is used.
> 
> Apparently, the variable has not only been renamed but the logic 
> of has changed quite a bit.  For example, filladapt-prefix-table 
> had the format ((REGXP . FUNCTION) ...) while 
> filladapt-token-table has the format ((REGEXP SYM) ...).
> 
> I'm CCing the authors of both packages.
> 
> [1] (info "(sc) Filling Cited Text")
> 
> [2] https://www.ic.unicamp.br/~stolfi/EXPORT/elisp/JUNK/mandel-disabled/filladapt.el
> 
> 
> 
>
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#74970; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 19 Dec 2024 11:23:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Dec 19 06:23:22 2024
Received: from localhost ([127.0.0.1]:37683 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tOEck-00024A-FX
	for submit <at> debbugs.gnu.org; Thu, 19 Dec 2024 06:23:22 -0500
Received: from lists.gnu.org ([209.51.188.17]:45818)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mekeor@HIDDEN>) id 1tOEci-000242-F5
 for submit <at> debbugs.gnu.org; Thu, 19 Dec 2024 06:23:21 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <mekeor@HIDDEN>) id 1tOEcg-00058M-Rp
 for bug-gnu-emacs@HIDDEN; Thu, 19 Dec 2024 06:23:19 -0500
Received: from mout02.posteo.de ([185.67.36.66])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <mekeor@HIDDEN>) id 1tOEce-0006mb-AU
 for bug-gnu-emacs@HIDDEN; Thu, 19 Dec 2024 06:23:18 -0500
Received: from submission (posteo.de [185.67.36.169]) 
 by mout02.posteo.de (Postfix) with ESMTPS id 532ED240101
 for <bug-gnu-emacs@HIDDEN>; Thu, 19 Dec 2024 12:23:11 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017;
 t=1734607391; bh=fMS8T06zFOn82v3aAO+DiJxCX9TRgQmAjNcwnR5GDP8=;
 h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From;
 b=TFqmKGMraQnLp/AIqCS1bJPr5L8m1YBErMHyMk9zUUvANey5rWLrZsAhP2WW190pJ
 NFY2znV3fPoTN0ZSoNmN0CXNq639SVcQxwE0yjNWznupJlFXDag6L8y08y4In49b7a
 Kn1wzxVfHcrSoQvGvYkFE9uiUMWsU1zuLwU45BLDN88zET36j2nh62s+GJNh8UcsKT
 OVZFU0rOPBgomVFBP3eMnRHTDvaYpFEAcMbDEAqCrDFZqLDGy5n/yvDrtZthDo9VKG
 J4AwXJRDEPWFUQUi9JiELTVvjkU/kcjAgm/7yRywa6u/TV3h2WkpVr8UWzfT8fWTJb
 cp+uIT+uuVqMA==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4YDSpQ5DGGz9rxD;
 Thu, 19 Dec 2024 12:23:10 +0100 (CET)
From: Mekeor Melire <mekeor@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: Supercite sc-setup-filladapt accesses void variable
 filladapt-prefix-table (from Filladapt)
X-Debbugs-Cc: Kyle E. Jones <kyle_jones@HIDDEN>, Barry A. Warsaw
 <bwarsaw@HIDDEN>
Date: Thu, 19 Dec 2024 11:22:56 +0000
Message-ID: <87msgr29yn.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; format=flowed
Received-SPF: pass client-ip=185.67.36.66; envelope-from=mekeor@HIDDEN;
 helo=mout02.posteo.de
X-Spam_score_int: -43
X-Spam_score: -4.4
X-Spam_bar: ----
X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

(Supercite is a built-in package and Filladapt is on GNU Elpa.) 
Supercite's manual [1] states that one can install Filladapt and 
call the `sc-setup-filladapt' function.  But calling 
`sc-setup-filladapt' will result in the error (void-variable 
filladapt-prefix-table).

It seems like Filladapt has renamed that variable from 
"filladapt-prefix-table" to "filladapt-token-table".  I only found 
one very old version of Filladapt [2] where the old name is used.

Apparently, the variable has not only been renamed but the logic 
of has changed quite a bit.  For example, filladapt-prefix-table 
had the format ((REGXP . FUNCTION) ...) while 
filladapt-token-table has the format ((REGEXP SYM) ...).

I'm CCing the authors of both packages.

[1] (info "(sc) Filling Cited Text")

[2] https://www.ic.unicamp.br/~stolfi/EXPORT/elisp/JUNK/mandel-disabled/filladapt.el
Acknowledgement sent to Mekeor Melire <mekeor@HIDDEN>:
New bug report received and forwarded. Copy sent to kyle_jones@HIDDEN, bwarsaw@HIDDEN, bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to kyle_jones@HIDDEN, bwarsaw@HIDDEN, bug-gnu-emacs@HIDDEN:
bug#74970; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.