GNU logs - #75145, boring messages

Message sent to ludo@HIDDEN, maxim.cournoyer@HIDDEN, guix-patches@HIDDEN:

Subject: [bug#75145] [PATCH] services: NetworkManager: configuration-directory
Resent-From: 45mg <45mg.writes@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: ludo@HIDDEN, maxim.cournoyer@HIDDEN, guix-patches@HIDDEN
Resent-Date: Fri, 27 Dec 2024 18:23:02 +0000
Resent-Message-ID: <handler.75145.B.173532372329028 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 75145 <at> debbugs.gnu.org
Cc: 45mg <45mg.writes@HIDDEN>, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
From: 45mg <45mg.writes@HIDDEN>
Date: Fri, 27 Dec 2024 13:18:06 -0500
Message-ID: <7743f403ebf1693fc386a397e9aed1975b43f900.1735323486.git.45mg.writes@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2607:f8b0:4864:20::1044;
 envelope-from=45mg.writes@HIDDEN; helo=mail-pj1-x1044.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

Give users a way to configure NetworkManager, by specifying a directory
containing configuration files. This directory will then be symlinked to
`/etc/NetworkManager/conf.d` (NetworkManager's default configuration
directory location).

* gnu/services/networking.scm (<network-manager-configuration>)
[configuration-directory]: new option.
* doc/guix.texi: document it.

Change-Id: I243a71593b9235cc11ebf9fea1926a1840d993d2
---
 doc/guix.texi               | 30 ++++++++++++++++++++++++++++++
 gnu/services/networking.scm | 10 ++++++++--
 2 files changed, 38 insertions(+), 2 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index da4d2f5ebc..ee0fbf59f9 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -21441,6 +21441,36 @@ Networking Setup
 (VPNs).  An example of this is the @code{network-manager-openvpn}
 package, which allows NetworkManager to manage VPNs @i{via} OpenVPN.
 
+@item @code{configuration-directory} (default: @code{#f})
+A directory (file-like object) that will be symlinked as
+@file{/etc/NetworkManager/conf.d}. NetworkManager will read
+configuration files from this directory. For the configuration file
+format, see the @command{NetworkManager.conf(5)} man page.
+
+For example, you could supply an existing directory:
+
+@lisp
+(service network-manager-service-type
+         (network-manager-configuration
+          (configuration-directory
+           (local-file "files/NetworkManager/conf.d" #:recursive? #t))))
+@end lisp
+
+Or create a directory using @code{file-union}:
+
+@lisp
+(service network-manager-service-type
+         (network-manager-configuration
+          (configuration-directory
+           (file-union "my-configuration-directory"
+                       `(("existing-file" ,(local-file "001-basic.conf"))
+                         ("constructed-file" ,(plain-file "002-unmanaged.conf"
+                                                      "[keyfile]
+unmanaged-devices=interface-name:wlo1_ap
+")))))))
+@end lisp
+
+
 @end table
 @end deftp
 
diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm
index 48a86b3694..7152c5a95f 100644
--- a/gnu/services/networking.scm
+++ b/gnu/services/networking.scm
@@ -23,6 +23,7 @@
 ;;; Copyright © 2023 Bruno Victal <mirai@HIDDEN>
 ;;; Copyright © 2023 muradm <mail@HIDDEN>
 ;;; Copyright © 2024 Nigko Yerden <nigko.yerden@HIDDEN>
+;;; Copyright © 2024 45mg <45mg.writes@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1262,18 +1263,23 @@ (define-record-type* <network-manager-configuration>
                (default '()))
   (iwd? network-manager-configuration-iwd?  ; TODO: deprecated field, remove.
         (default #f)
-        (sanitize warn-iwd?-field-deprecation)))
+        (sanitize warn-iwd?-field-deprecation))
+  (configuration-directory network-manager-configuration-configuration-directory ;file-like
+                           (default #f)))
 
 (define (network-manager-activation config)
   ;; Activation gexp for NetworkManager
   (match-record config <network-manager-configuration>
-    (network-manager dns vpn-plugins)
+    (network-manager dns vpn-plugins configuration-directory)
     #~(begin
         (use-modules (guix build utils))
         (mkdir-p "/etc/NetworkManager/system-connections")
         #$@(if (equal? dns "dnsmasq")
                ;; create directory to store dnsmasq lease file
                '((mkdir-p "/var/lib/misc"))
+               '())
+        #$@(if configuration-directory
+               `((symlink ,configuration-directory "/etc/NetworkManager/conf.d"))
                '()))))
 
 (define (vpn-plugin-directory plugins)

base-commit: 831b94a1efcea8f793afc949b5123a6235c9bb1a
-- 
2.47.1

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: 45mg <45mg.writes@HIDDEN>
Subject: bug#75145: Acknowledgement ([PATCH] services: NetworkManager:
 configuration-directory)
Message-ID: <handler.75145.B.173532372329028.ack <at> debbugs.gnu.org>
References: <7743f403ebf1693fc386a397e9aed1975b43f900.1735323486.git.45mg.writes@HIDDEN>
X-Gnu-PR-Message: ack 75145
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 75145 <at> debbugs.gnu.org
Date: Fri, 27 Dec 2024 18:23:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  Ludovic Court=C3=A8s <ludo@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@gma=
il.com>
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 75145 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
75145: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D75145
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to ludo@HIDDEN, maxim.cournoyer@HIDDEN, guix-patches@HIDDEN:

Subject: [bug#75145] [PATCH v2 0/1] services: network-manager: Add extra-configuration-files field.
Resent-From: 45mg <45mg.writes@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: ludo@HIDDEN, maxim.cournoyer@HIDDEN, guix-patches@HIDDEN
Resent-Date: Thu, 09 Jan 2025 12:26:01 +0000
Resent-Message-ID: <handler.75145.B75145.173642550617912 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 75145 <at> debbugs.gnu.org
Cc: guix-devel@HIDDEN, 45mg <45mg.writes@HIDDEN>, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
From: 45mg <45mg.writes@HIDDEN>
Date: Thu,  9 Jan 2025 12:24:30 +0000
Message-ID: <cover.1736423822.git.45mg.writes@HIDDEN>
In-Reply-To: <7743f403ebf1693fc386a397e9aed1975b43f900.1735323486.git.45mg.writes@HIDDEN>
References: <7743f403ebf1693fc386a397e9aed1975b43f900.1735323486.git.45mg.writes@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi Guix,

As the first revision of this patch failed to get any attention in two weeks,
I'm CC'ing guix-devel on this one, hoping it'll get reviewed this time. Let me
know if I should have done anything differently; I'm still relatively new to
contributing.

This patch allows users to specify configuration files for NetworkManager.
While perhaps it would be more Guix-y to instead have a field in
`network-manager-configuration` for every configuration option, this would be
a monumental undertaking (look at the number of options listed in
NetworkManager.conf(5)!). At any rate, I think any means of configuring
NetworkManager is better than none.

The difference from the first revision is that instead of specifying a single
directory (file-like object) containing the configuration files (which was
then symlinked to /etc/NetworkManager/conf.d), you now specify an alist
mapping file names to file-like objects, like with `etc-service-type`; and
those are then added to /etc/NetworkManager/conf.d. The rationale behind this
change is that it doesn't rule out putting our own stuff in
/etc/NetworkManager/conf.d. For example, if we wanted a default set of files
in there, we could modify the procedure
`network-manager-configuration-directory` to add the files supplied via the
field to our default set; in the first revision, this wouldn't be possible as
the user specifies the entire directory. (I don't know whether we'd ever
actually want to do this, but I thought it best to leave our options open.)

45mg (1):
  services: network-manager: Add extra-configuration-files field.

 doc/guix.texi               | 21 +++++++++++++++++++++
 gnu/services/networking.scm | 26 ++++++++++++++++++++++++--
 2 files changed, 45 insertions(+), 2 deletions(-)

base-commit: 7f27dc47c52886b785359799b6dc67b61f638544
-- 
2.47.1

Message sent to ludo@HIDDEN, maxim.cournoyer@HIDDEN, guix-patches@HIDDEN:

Subject: [bug#75145] [PATCH v2 1/1] services: network-manager: Add extra-configuration-files field.
Resent-From: 45mg <45mg.writes@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: ludo@HIDDEN, maxim.cournoyer@HIDDEN, guix-patches@HIDDEN
Resent-Date: Thu, 09 Jan 2025 12:26:02 +0000
Resent-Message-ID: <handler.75145.B75145.173642551718209 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 75145 <at> debbugs.gnu.org
Cc: guix-devel@HIDDEN, 45mg <45mg.writes@HIDDEN>, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
From: 45mg <45mg.writes@HIDDEN>
Date: Thu,  9 Jan 2025 12:24:31 +0000
Message-ID: <6c5c3ce265d159c862de73a77e985cf30a1f30a8.1736423822.git.45mg.writes@HIDDEN>
In-Reply-To: <7743f403ebf1693fc386a397e9aed1975b43f900.1735323486.git.45mg.writes@HIDDEN>
References: <7743f403ebf1693fc386a397e9aed1975b43f900.1735323486.git.45mg.writes@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Allow users to specify additional configuration files for
NetworkManager. These files will be added to
`/etc/NetworkManager/conf.d` (NetworkManager's default configuration
directory location).

* gnu/services/networking.scm (<network-manager-configuration>)
[extra-configuration-files]: New field.
(network-manager-configuration-directory): New procedure.
(network-manager-activation): Honor the new field.
* doc/guix.texi (Networking Setup): Document the new field.

Change-Id: I07479958e4d0aa318328c666a9630b779230b300
---
 doc/guix.texi               | 21 +++++++++++++++++++++
 gnu/services/networking.scm | 26 ++++++++++++++++++++++++--
 2 files changed, 45 insertions(+), 2 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index caebe3b03c..279fdb838b 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -21455,6 +21455,27 @@ Networking Setup
 (VPNs).  An example of this is the @code{network-manager-openvpn}
 package, which allows NetworkManager to manage VPNs @i{via} OpenVPN.
 
+@item @code{extra-configuration-files} (default: @code{'()})
+An alist of file names to file-like objects, representing configuration
+files which will be added to @file{/etc/NetworkManager/conf.d}.
+NetworkManager will read additional configuration from this directory.
+For details on configuration file precedence and the configuration file
+format, see the @command{NetworkManager.conf(5)} man page.
+
+For example, to add two files @file{001-basic.conf} and
+@file{002-unmanaged.conf}:
+
+@lisp
+(service network-manager-service-type
+         (network-manager-configuration
+          (extra-configuration-files
+           `(("existing-file" ,(local-file "001-basic.conf"))
+             ("constructed-file" ,(plain-file "002-unmanaged.conf"
+                                              "[keyfile]
+unmanaged-devices=interface-name:wlo1_ap
+"))))))
+@end lisp
+
 @end table
 @end deftp
 
diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm
index 48a86b3694..4355158225 100644
--- a/gnu/services/networking.scm
+++ b/gnu/services/networking.scm
@@ -1262,18 +1262,40 @@ (define-record-type* <network-manager-configuration>
                (default '()))
   (iwd? network-manager-configuration-iwd?  ; TODO: deprecated field, remove.
         (default #f)
-        (sanitize warn-iwd?-field-deprecation)))
+        (sanitize warn-iwd?-field-deprecation))
+  (extra-configuration-files network-manager-configuration-extra-configuration-files
+                             (default '())))  ;alist of file names to file-like objects
+
+(define (network-manager-configuration-directory extra-configuration-files)
+  "Return a directory containing EXTRA-CONFIGURATION-FILES."
+  (with-imported-modules (source-module-closure '((guix build utils)))
+    (computed-file
+     "network-manager-configuration-directory"
+     #~(begin
+         (use-modules (guix build utils))
+         (mkdir-p #$output)
+         (for-each (lambda (pair)
+                     (let* ((filename (list-ref pair 0))
+                            (file (list-ref pair 1))
+                            (dest (string-append #$output "/" filename)))
+                       (copy-file file dest)))
+                   '#$extra-configuration-files)))))
 
 (define (network-manager-activation config)
   ;; Activation gexp for NetworkManager
   (match-record config <network-manager-configuration>
-    (network-manager dns vpn-plugins)
+                (network-manager dns vpn-plugins extra-configuration-files)
     #~(begin
         (use-modules (guix build utils))
         (mkdir-p "/etc/NetworkManager/system-connections")
         #$@(if (equal? dns "dnsmasq")
                ;; create directory to store dnsmasq lease file
                '((mkdir-p "/var/lib/misc"))
+               '())
+        #$@(if extra-configuration-files
+               `((symlink
+                  ,(network-manager-configuration-directory extra-configuration-files)
+                  "/etc/NetworkManager/conf.d"))
                '()))))
 
 (define (vpn-plugin-directory plugins)
-- 
2.47.1

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#75145] [PATCH v2 0/1] services: network-manager: Add extra-configuration-files field.
Resent-From: Arnaud Daby-Seesaram <ds-ac@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 09 Jan 2025 14:45:02 +0000
Resent-Message-ID: <handler.75145.B75145.173643389413246 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75145
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 45mg <45mg.writes@HIDDEN>
Cc: guix-devel@HIDDEN, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, 75145 <at> debbugs.gnu.org
Received: via spool by 75145-submit <at> debbugs.gnu.org id=B75145.173643389413246
          (code B ref 75145); Thu, 09 Jan 2025 14:45:02 +0000
Received: (at 75145) by debbugs.gnu.org; 9 Jan 2025 14:44:54 +0000
Received: from localhost ([127.0.0.1]:51335 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tVtmH-0003RY-EU
	for submit <at> debbugs.gnu.org; Thu, 09 Jan 2025 09:44:53 -0500
Received: from nanein.fr ([185.230.78.41]:58536)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <ds-ac@HIDDEN>) id 1tVtmE-0003RA-LT
 for 75145 <at> debbugs.gnu.org; Thu, 09 Jan 2025 09:44:51 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nanein.fr; s=mail;
 t=1736433883; bh=P3fcGZNuIlX5sqBoC/5o0/aQAwDc/hkQgHCH7TjGqFY=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=u3PbmPU+YZqb2tJQPcktLhwmX7sRyO26aIA2d1o1duTCgOasHhhPC+5skKkbT8FM5
 9t63OFj08KMihM0JKkGjjGhVFvuHv7eX4d+W/SjTpa5IK2FEZzih9wJSjFzfnzm7Wg
 2f1Ho/XIsUzN+XMVgvuxvv74v59pv0Q11SM3U9co8eslYoLEt7V1O9xKpOBjJdSAmk
 FwryMha0B/NO6fx8+KTBUekT6rhnKO2naIUh+cVABw1LURy+XxN23/g4nSaoSVQwdR
 Tq5wlplnNCzc9bxjDjjJlt+PDiQwv3+rspa4FdwwSudJ3cxJLAP72dohOQmt42AGkw
 PXmsnEcHYQYkGfooV+/tKCnFKUmrOrJJGpJccOJ7zaq2d57iraAGNExnwmI1szl200
 tUE2Pps/haWRQWq7nwB82PrCHpJ4dQdFqnXV008QJQNj7LRB1Am/WQ7lNpnh+iL8oG
 VjNGCpR1UEesn5WGSC6VdWSCG5IU+6lGeDtTXOo/dvmeDHByc3PO9qo6qZllGpjwgU
 5UVWHehTllC3lG5yRD2CXWFqA0dEr73kz6wb1elYZNWdqU/IDCCwdCvsOcPWDEsZcA
 IAsiLQKw05Mrk9ndvw+LomjJfcuh+Wv55C1actT0IG5mZgMaxwX9kz5vOvkncmCb3j
 SaJntCKmlyshPj+CHQkb2szI=
Received: from cochea (eduroam09.au.dk [185.45.22.146])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1)
 server-digest SHA256) (No client certificate requested)
 by nanein.fr (Postfix) with ESMTPSA id 194791401EC;
 Thu,  9 Jan 2025 15:44:43 +0100 (CET)
From: Arnaud Daby-Seesaram <ds-ac@HIDDEN>
In-Reply-To: <cover.1736423822.git.45mg.writes@HIDDEN>
 (45mg.writes@HIDDEN's message of "Thu, 9 Jan 2025 12:24:30 +0000")
References: <7743f403ebf1693fc386a397e9aed1975b43f900.1735323486.git.45mg.writes@HIDDEN>
 <cover.1736423822.git.45mg.writes@HIDDEN>
User-Agent: mu4e 1.12.7; emacs 29.4
Date: Thu, 09 Jan 2025 15:44:27 +0100
Message-ID: <875xmo11ys.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi,

Thank you for your patch.

45mg <45mg.writes@HIDDEN> writes:
> As the first revision of this patch failed to get any attention in two we=
eks,
> I'm CC'ing guix-devel on this one, hoping it'll get reviewed this time. L=
et me
> know if I should have done anything differently; I'm still relatively new=
 to
> contributing.

I am also new to contributing, so the following may not be fully
accurate.

I think that you did everything right.  Unfortunately, some patches
"fall through the cracks".  I have seen some people replying to
issues=C2=A0[0], so that emails would show up in people' mailboxes (similar
to what you did) and restart the discussion.

I think that it is also possible to suggest simple patches for patch
review events [1].  I do not know if proposing one's own patches is
frowned upon or not, but I would not expect it to be as long as there is
no abuse.

[0] Random example: https://issues.guix.gnu.org/64620#21
[1] Wiki page for last year:
    https://libreplanet.org/wiki/Group:Guix/PatchReviewSessions2024

> This patch allows users to specify configuration files for NetworkManager.
> While perhaps it would be more Guix-y to instead have a field in
> `network-manager-configuration` for every configuration option, this woul=
d be
> a monumental undertaking (look at the number of options listed in
> NetworkManager.conf(5)!). At any rate, I think any means of configuring
> NetworkManager is better than none.

I agree that an escape hatch enabling to configure NetworkManager would
be nice indeed.

> The difference from the first revision is that instead of specifying a si=
ngle
> directory (file-like object) containing the configuration files (which was
> then symlinked to /etc/NetworkManager/conf.d), you now specify an alist
> mapping file names to file-like objects, like with `etc-service-type`; and
> those are then added to /etc/NetworkManager/conf.d. The rationale behind =
this
> change is that it doesn't rule out putting our own stuff in
> /etc/NetworkManager/conf.d. For example, if we wanted a default set of fi=
les
> in there, we could modify the procedure
> `network-manager-configuration-directory` to add the files supplied via t=
he
> field to our default set; in the first revision, this wouldn't be possibl=
e as
> the user specifies the entire directory. (I don't know whether we'd ever
> actually want to do this, but I thought it best to leave our options open=
.)

On adding default files in .../conf.d/:
```````````````````````````````````````

Adding a default configuration could one day be interesting.  However,
I=C2=A0would rather (personal opinion) see the default value in an exported
variable %default-networkmanager-files (non-contractual name) if needed.
This variable could become the default value of the field.

This way, it would be more transparent to users, and would enable them
to easily opt-out.  Adding their files could be done with the following
configuration:

=2D-8<---------------cut here---------------start------------->8---
(extra-configuration-files
  (cons* `("file1" ,(plain-file ...))
         ...
         %default-networkmanager-files))
=2D-8<---------------cut here---------------end--------------->8---


On doing a similar job than `etc-service-type':
```````````````````````````````````````````````

As you said, you are doing something similar to `etc-service-type'.  Is
there a reason not to extend [2] it directly (e.g.=C2=A0like
`greetd-service-type' does in `(gnu services base)')?

You could, for example, prepend "NetworkManager/conf.d/" to file names
and pass the value to `etc-service-type'.  WDYT?

[2] more on service extension can be found in (guix)Service Reference:
    https://guix.gnu.org/manual/devel/en/html_node/Service-Reference.html


Final thought:
``````````````

Would it make sense to allow the NetworkManager service to be extended?
(E.g to allow another service to add a configuration file.)

Note: this is not a blocker for your patch and could be done in a later
      patch.  It is simply a thought that I wanted to share.


Best regards,

=2D-=20
Arnaud

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCgAuFiEEMgqfJ4U0fby1t860ojLKXoMTiAwFAmd/4MsQHGRzLWFjQG5h
bmVpbi5mcgAKCRCiMspegxOIDE/rD/9vIUKmRubYnKSkm6VZL41gBsjjozwBkpbS
yo4GX8zD0mrrIfeyZcWkLj5VgUGWkElN+6WV0EM4Q71dAoAbi6NrhMlAY1cv4M9z
V+6bHnF0kK7HeM/kRq2dr57E4NXNbwfZ8ysuohiXzHmDiM08xVSKcfUO69S17w8I
A52SLgsdHRGQXE8ru4OuqSBahZNCTd3E+/fe73E+loRzXO9IlTCWkLsYzc1GUHY/
gfqThda3mTh/VkS6+2cINA/fDzNx3v4kJWzPMsg+00WaPwp5AP322JoGMo8TIX7d
+y41Fy4PZdLlRGss3gk/ZndPLmdN1RRg6v2ohTahzRfQId8n+ypfqicf3Gp8sS8K
lj2u2fvDcdHNQr+M6xd9DPLWFKn2okLEVS+/6mdmIGtMVdgUcazdp35rpfk9zEVg
Dc/EQkoq7TA9hJycJN3Oevwt2n9L8BntdhhYMF6EBzWa9jSp4GmNGDxlHHeSlBOJ
thQdzZH1hY2UESP6w7N1Z0FmVo4eII19aHfyybvgsoAFg00cwstECFj9ZFHRGVlz
108jfrorXAR7loXG7Yrl1uXw34/sUM1dRt8qoN3YNWYI88sMYt1QfVCm8j7zuRAa
f4btbZCI7+ntDPwwffHSYFZs5cyo/SOdhX7XVexz7BOCeZtPP0loLCd3lPsRFo2I
0pQCYc0vlg==
=ucdW
-----END PGP SIGNATURE-----
--=-=-=--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#75145] [PATCH v2 0/1] services: network-manager: Add extra-configuration-files field.
Resent-From: 45mg <45mg.writes@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 09 Jan 2025 17:04:01 +0000
Resent-Message-ID: <handler.75145.B75145.17364422119986 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75145
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Arnaud Daby-Seesaram <ds-ac@HIDDEN>, 45mg <45mg.writes@HIDDEN>
Cc: guix-devel@HIDDEN, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, 75145 <at> debbugs.gnu.org
Received: via spool by 75145-submit <at> debbugs.gnu.org id=B75145.17364422119986
          (code B ref 75145); Thu, 09 Jan 2025 17:04:01 +0000
Received: (at 75145) by debbugs.gnu.org; 9 Jan 2025 17:03:31 +0000
Received: from localhost ([127.0.0.1]:54067 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tVvwQ-0002b0-VI
	for submit <at> debbugs.gnu.org; Thu, 09 Jan 2025 12:03:31 -0500
Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]:47301)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <45mg.writes@HIDDEN>)
 id 1tVvwO-0002af-Ig
 for 75145 <at> debbugs.gnu.org; Thu, 09 Jan 2025 12:03:29 -0500
Received: by mail-pj1-x1041.google.com with SMTP id
 98e67ed59e1d1-2f43da61ba9so1587364a91.2
 for <75145 <at> debbugs.gnu.org>; Thu, 09 Jan 2025 09:03:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1736442202; x=1737047002; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:message-id:date:references
 :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id
 :reply-to; bh=Af0dWIk9laaEL3ETaob4BC+44JiUe0zN2G8oUW/INok=;
 b=YdMeflqBkYOYLpsUArj8kTpMMTmQw/9Oy9CRw1vDvzaNqaNNPeqH43aJ7+tv39yhJr
 D6Wt+Yr19P5NsS7IcowY6X7yEzTlF5tTwFl1P1KjRUzrKiDsYY15+gmIbm1xQre61L/v
 ucK+aXQw+5QRLmkS1nTejg8f0Ineyhw5Myv64uQ0clCM3Gp0aRo2kDgDyysOBHGRwOY8
 nfotMC+VSt5zvsfI7N/Cq3rsuvmWNUELU61lMzWYfOTr34LIWAecfaG/yyRdWbiocjZ6
 gkFoFZ8N2LUn3VYWz0tsEYFoOKpzei6VzsBJlUCSaEA6ZVYEdTxOmQXNxf1CLjdd87Im
 H11A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1736442202; x=1737047002;
 h=content-transfer-encoding:mime-version:message-id:date:references
 :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=Af0dWIk9laaEL3ETaob4BC+44JiUe0zN2G8oUW/INok=;
 b=RJckiLDSNf3xqVRDMcxs++36LN+PRyzwS4GEPMwXoR467ofWJ4jr5ZH50pdcZnmWZj
 gR/yPjo5f0BQTPIDU14RvGKswyPr69ZaPlmym4i4/t2J47k2WTaIShLfSR1Jdu5+dNtZ
 rK2pCpIFeEfdMhK7POS2K5D+PdpLGjSf627OBxonG/UzrQB1pFF4B1G1IwYKTM0N/tf1
 W/9NqcVZAgwHFEz842FhEE1m0V5z0oh6r+5+TaJ7QeaKrPkyR3eoXH0SL4g2cEx/OIEb
 ygQUT+XgiyMvawwmsYDysH3fDLnkZSIr0se7UlA5d+xDDHwCR6fjz04Tb1XErfY9rqGW
 Tfag==
X-Gm-Message-State: AOJu0YyyowqnJMhF3YZtm2YSUoyowSDOmwoFMPATWEPry2q5BhU4wNT+
 D+e0iIGtYs2ZgMJM9PrXtW3FZrfcurTVV5u7e5CTnx4RUk0hlRan
X-Gm-Gg: ASbGncs4siFjIW3MXH3bjmpJhpyGa0lcJPjRUJ08aoWC1j7R/AIkTvcG9eF4yYpntbZ
 zEeODT/+g77YkfMbJ18fGytx01HxO7+zG9b8HdlyISi0M1vgE4QQoTuIhA2K6W+5byOZQ2XXjRP
 XhuDekGUrEbNQkJaFyTOpF2EGku76bplsgQasgbSU4uSez/OzZYmTEPdBpWFLFa5hrVSe4aSCH9
 sMxxTnd80mWYh3KhpOX+25d19XjhW6zZL9vO3DnLWcTJAspPMyRzaeE1g==
X-Google-Smtp-Source: AGHT+IGFsHin18QOUVsNZWfJRAAjarqsXJ7titOvO1S/b2UsXazF3u8zHBMXvUvxbMT9xJA8crSBlw==
X-Received: by 2002:a17:90b:4d0c:b0:2ee:8619:210b with SMTP id
 98e67ed59e1d1-2f5490bd21dmr11050861a91.29.1736442201958; 
 Thu, 09 Jan 2025 09:03:21 -0800 (PST)
Received: from guix0 (utm3.nitt.edu. [14.139.162.2])
 by smtp.gmail.com with ESMTPSA id
 98e67ed59e1d1-2f5593d08a8sm1802511a91.9.2025.01.09.09.03.18
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 09 Jan 2025 09:03:21 -0800 (PST)
From: 45mg <45mg.writes@HIDDEN>
In-Reply-To: <875xmo11ys.fsf@HIDDEN>
References: <7743f403ebf1693fc386a397e9aed1975b43f900.1735323486.git.45mg.writes@HIDDEN>
 <cover.1736423822.git.45mg.writes@HIDDEN> <875xmo11ys.fsf@HIDDEN>
Date: Thu, 09 Jan 2025 12:03:13 -0500
Message-ID: <87jzb3zzqm.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Arnaud!

Arnaud Daby-Seesaram <ds-ac@HIDDEN> writes:

> Adding a default configuration could one day be interesting.  However,
> I=C2=A0would rather (personal opinion) see the default value in an export=
ed
> variable %default-networkmanager-files (non-contractual name) if needed.
> This variable could become the default value of the field.
>
> This way, it would be more transparent to users, and would enable them
> to easily opt-out.  Adding their files could be done with the following
> configuration:
>
> --8<---------------cut here---------------start------------->8---
> (extra-configuration-files
>   (cons* `("file1" ,(plain-file ...))
>          ...
>          %default-networkmanager-files))
> --8<---------------cut here---------------end--------------->8---

Yes, I think I agree. Of course, it's a moot point for now since we
don't have any use for such a variable yet, but it seems like a good
approach.

> As you said, you are doing something similar to `etc-service-type'.  Is
> there a reason not to extend [2] it directly (e.g.=C2=A0like
> `greetd-service-type' does in `(gnu services base)')?
>
> You could, for example, prepend "NetworkManager/conf.d/" to file names
> and pass the value to `etc-service-type'.  WDYT?

That's a good suggestion! I don't know why it didn't occur to me.

So I tried it; the problem is that if I pass something like this:
--8<---------------cut here---------------start------------->8---
(service-extension etc-service-type
                   (lambda (config)
                     `(("NetworkManager/conf.d"
                        ,(network-manager-configuration-directory config)))=
))
--8<---------------cut here---------------end--------------->8---

...then I get this error when creating a container:
--8<---------------cut here---------------start------------->8---
ERROR: In procedure primitive-load:
In procedure mkdir: Read-only file system
--8<---------------cut here---------------end--------------->8---

It looks like this is because of this line in `network-manager-activation`:
--8<---------------cut here---------------start------------->8---
        (mkdir-p "/etc/NetworkManager/system-connections")
--8<---------------cut here---------------end--------------->8---

When we use `etc-service-type`, "/etc/NetworkManager" becomes a symlink
to "/etc/static/NetworkManager"; and "/etc/static" is a symlink to the
result of building the derivation returned by `etc-entry` (see (gnu
services)). And derivations are in the store, which is read-only. So we
can't create "/etc/NetworkManager/system-connections/". And this won't
do, since NetworkManager itself needs to be able to write to that
directory to manage saved connections.

So it looks like that won't work.

> Would it make sense to allow the NetworkManager service to be extended?
> (E.g to allow another service to add a configuration file.)
>
> Note: this is not a blocker for your patch and could be done in a later
>       patch.  It is simply a thought that I wanted to share.

Yeah, this was another reason for this revision. Again, it's not
actually something we need right now; it's just worth leaving open as a
possibility.

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#75145] [PATCH v2 0/1] services: network-manager: Add extra-configuration-files field.
Resent-From: Felix Lechner <felix.lechner@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 09 Jan 2025 19:35:01 +0000
Resent-Message-ID: <handler.75145.B75145.17364512634262 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75145
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 45mg <45mg.writes@HIDDEN>
Cc: guix-devel@HIDDEN, 75145 <at> debbugs.gnu.org
Received: via spool by 75145-submit <at> debbugs.gnu.org id=B75145.17364512634262
          (code B ref 75145); Thu, 09 Jan 2025 19:35:01 +0000
Received: (at 75145) by debbugs.gnu.org; 9 Jan 2025 19:34:23 +0000
Received: from localhost ([127.0.0.1]:54311 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tVyIQ-00016f-Ue
	for submit <at> debbugs.gnu.org; Thu, 09 Jan 2025 14:34:23 -0500
Received: from sail-ipv4.us-core.com ([208.82.101.137]:36440)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <felix.lechner@HIDDEN>)
 id 1tVyIP-00016S-5I
 for 75145 <at> debbugs.gnu.org; Thu, 09 Jan 2025 14:34:22 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=v1FZJ5LjbLMRfBa
 O0n8niDCQH3jS5ML+PisbzIgVius=;
 h=date:references:in-reply-to:subject:
 cc:to:from; d=lease-up.com; b=U2I8SQYjzqyp8ywjIfiwedVPQjulZVVLKPGhfy7q
 hxYCFh2dibAFQY6vatgrcfN/mG86kiakhWWCKlUAzFmci9CLdlbhPWQwsUjMPbHdBnsbFa
 a1A1mzqsh4hIioi/49iCpE+98yUusO7N84M7e1tlTVSr8N55D8QkDqrvNp5c4=
Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id e78882a7
 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); 
 Thu, 9 Jan 2025 19:34:12 +0000 (UTC)
From: Felix Lechner <felix.lechner@HIDDEN>
In-Reply-To: <cover.1736423822.git.45mg.writes@HIDDEN>
 (45mg.writes@HIDDEN's message of "Thu, 9 Jan 2025 12:24:30 +0000")
References: <7743f403ebf1693fc386a397e9aed1975b43f900.1735323486.git.45mg.writes@HIDDEN>
 <cover.1736423822.git.45mg.writes@HIDDEN>
User-Agent: mu4e 1.12.7; emacs 29.4
Date: Thu, 09 Jan 2025 11:34:12 -0800
Message-ID: <87seprdbnv.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi 45mg,

On Thu, Jan 09 2025, 45mg wrote:

> this patch failed to get any attention in two weeks

Two weeks isn't a long time in free software projects.  A more common
time frame would be between one year and eighteen months.

> I'm CC'ing guix-devel on this one

Pings are generally frowned upon, but I also just did it yesterday. [1]
Pings are usually not worth it anywhere, not just in GNU Guix.  Pings
are likely to be ineffective in hastening the acceptance of your patch
but will almost certainly affect your social relationships negatively.

> This patch allows users to specify configuration files for NetworkManager.

If you require that change personally, as I suspect you do, my
recommendation would be to clone the Guix repo and pull your 'guix'
executable from your custom branch.  For example, I have in my
channels.scm a branch that I rebase periodically. [2]

I pull with

    guix pull --allow-downgrades --disable-authentication

That kind of setup totally removes the timing pressure from your
contribution.  It also allows you to test your patch in real life and
then argue with committers solely about its merits.  It's better for
everybody, I think.

It may leave everyone, most importantly yourself, in a happier place.

Kind regards
Felix

[1] https://lists.gnu.org/archive/html/guix-devel/2025-01/msg00056.html
[2] https://codeberg.org/lechner/guix-config/src/branch/history/channels.scm

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#75145] [PATCH v2 0/1] services: network-manager: Add extra-configuration-files field.
References: <7743f403ebf1693fc386a397e9aed1975b43f900.1735323486.git.45mg.writes@HIDDEN>
In-Reply-To: <7743f403ebf1693fc386a397e9aed1975b43f900.1735323486.git.45mg.writes@HIDDEN>
Resent-From: 45mg <45mg.writes@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 12 Jan 2025 17:45:02 +0000
Resent-Message-ID: <handler.75145.B75145.17367038575857 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75145
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Felix Lechner <felix.lechner@HIDDEN>, 45mg <45mg.writes@HIDDEN>
Cc: guix-devel@HIDDEN, 75145 <at> debbugs.gnu.org
Received: via spool by 75145-submit <at> debbugs.gnu.org id=B75145.17367038575857
          (code B ref 75145); Sun, 12 Jan 2025 17:45:02 +0000
Received: (at 75145) by debbugs.gnu.org; 12 Jan 2025 17:44:17 +0000
Received: from localhost ([127.0.0.1]:48961 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tX20X-0001WL-2T
	for submit <at> debbugs.gnu.org; Sun, 12 Jan 2025 12:44:17 -0500
Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]:50286)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <45mg.writes@HIDDEN>)
 id 1tX20T-0001Vu-Qs
 for 75145 <at> debbugs.gnu.org; Sun, 12 Jan 2025 12:44:15 -0500
Received: by mail-pl1-x643.google.com with SMTP id
 d9443c01a7336-216426b0865so59765105ad.0
 for <75145 <at> debbugs.gnu.org>; Sun, 12 Jan 2025 09:44:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1736703848; x=1737308648; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:message-id:date:subject:cc
 :to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=zz6nBajFUCQWxo5xYjKRRRDF+vPA9J6XLraLgGrsvjo=;
 b=at7r+EjUFrcnwcEOmTabynDN4uitnb9+9dxY4levv8YZeifVPeQHFPK0AvnFpvvqD0
 EoKikeuLvoh7zbSJU5oohjcA6phpqdaK+Iz/I9XOYVVAgYSqyGz04WCHlYpQR9YeVu+J
 9Z0MmUf9GclblyP380J85Dz29GP9fgxG2omCZ5uyM5L6xW1p5UN6LH+MMHRxfQ/IvyKO
 hfsigwdwQ+bHu0t/LgoiXu8RyULsl6F1afaIWyMuviHnvM7Gm+yDX2Tlj8MEG6O1F816
 kElcjTHRANq8td37FQuliTSqWdtjd6wz8NMOGmm+3nRqqWY0vkXprvADfld6uOIoPFw5
 kFrQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1736703848; x=1737308648;
 h=content-transfer-encoding:mime-version:message-id:date:subject:cc
 :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=zz6nBajFUCQWxo5xYjKRRRDF+vPA9J6XLraLgGrsvjo=;
 b=KNi2GAXecE39vba2bntnwtpU6mlPH7dIs5BttZ3F4kWzEbJzl+FsiXq591xA/MCwJe
 4C6A/q7asSMtLAlTpCQo2CSSbVsmeKAkoyaho5a9Vr5hvna6rRcAJ5kOvQ2MCB06Z0tc
 emISzQAUQKSOlB3blKQgOvjW5xRc/uE5ZUyXkmXV/ocMpme3We2s4YSXU7AEICeCpCkR
 QzBEQ/B8CRsPilkrPtx8fBJunniqaTkqK5D7MT2qcagAqsMVZEabpnrA5UvkIBedvfiw
 kyzpFrnP1CidON858mRRsI6t5Ng0/D5u8M/fqE/nrM5nb3wySH/ERAleE3fW53NCA6ze
 eziw==
X-Gm-Message-State: AOJu0Yx6t0bvWs5FvHUkdGizbFIYoD0cWvaP6Ra2ipDBH2TAicy8C3yI
 MNdOWnXNAWeXvDQDYhihx7gBOocCptCwK5vYgEmxu8ddUZUWmQDO
X-Gm-Gg: ASbGnct66zVNcTzcqxmyVTBd3svS0UxVY+202kWI/V9Y6H/pIBVPevieUwXuXPi9Kok
 aS1DTPl6kVc0ldblpk1f7+MSpsVK5ntwZyv7SJyOaEhwQnPyzPEWxtv8loYzB07fEXOWk6ab18K
 TRoLX4LsI3j5RD/v3jgQt6f0Xl9qwqI6w4jiY8b2dWExKUhNu7NamH+ZiCF9F7J9zArM8fiwQui
 8Iunjf5S6SAYlCFKC6pEMBbWS8ApBvFdAJ7ZBqgLDEJuhbtDDcphlqg4A==
X-Google-Smtp-Source: AGHT+IH5v5oVhcsqNNbNBL8rSgFSU5b0vdiZ76KOjRg4+C3TrNOoXXnrulIkp87aqGpeSGbY44M+SA==
X-Received: by 2002:a05:6a00:392a:b0:725:b347:c3cc with SMTP id
 d2e1a72fcca58-72d2200273bmr25540560b3a.23.1736703846180; 
 Sun, 12 Jan 2025 09:44:06 -0800 (PST)
Received: from guix1 (utm3.nitt.edu. [14.139.162.2])
 by smtp.gmail.com with ESMTPSA id
 d2e1a72fcca58-72d40658cd0sm4484175b3a.113.2025.01.12.09.44.04
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 12 Jan 2025 09:44:05 -0800 (PST)
From: 45mg <45mg.writes@HIDDEN>
Date: Sun, 12 Jan 2025 17:43:59 +0000
Message-ID: <87sepogc68.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Guix,

I'd just like to apologise for CC'ing Guix-Devel at this point; this
patch isn't nearly critical enough to warrant the noise after two weeks'
wait - which, as Felix points out, really isn't that long in the grand
scheme of things. I got impatient; I'm sorry. I'll try to remember to
remove Guix-Devel from further replies to this Debbug.

(...but it is a good patch i promise, pls do review it so it doesnt feel
sad and neglected =F0=9F=A5=B9)

Felix Lechner <felix.lechner@HIDDEN> writes:

> If you require that change personally, as I suspect you do, my
> recommendation would be to clone the Guix repo and pull your 'guix'
> executable from your custom branch.  For example, I have in my
> channels.scm a branch that I rebase periodically. [2]

I guess it's time for me to bite the bullet and finally do this, then :|
I had hoped to avoid the annoyance, but maybe it was inevitable. And
you're right - I do need this change personally.

I'm working on this. For anyone here who's interested, I'm currently
trying to figure out a way to have an authenticated local fork. The
current design of `guix git authenticate` prevents merging upstream into
such a fork, so this is a bit of a challenge. I've outlined an idea in
the threads linked below, which will require modifying the authorization
invariant a bit; I'll probably share the full proposal to Devel once I
have a working patch:

https://lists.gnu.org/archive/html/help-guix/2023-09/msg00010.html
https://lists.gnu.org/archive/html/help-guix/2025-01/msg00093.html

> Pings are generally frowned upon, but I also just did it yesterday. [1]
> Pings are usually not worth it anywhere, not just in GNU Guix.  Pings
> are likely to be ineffective in hastening the acceptance of your patch
> but will almost certainly affect your social relationships negatively.

Thanks, good to know. Will try to keep that in mind. I do wish there was
something I could do to get things moving faster, but I guess this is a
limitation of projects that run on (primarily) unpaid volunteer work :/

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#75145] [PATCH v2 0/1] services: network-manager: Add extra-configuration-files field.
Resent-From: Attila Lendvai <attila@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 13 Jan 2025 13:48:01 +0000
Resent-Message-ID: <handler.75145.B75145.173677607817704 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75145
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Felix Lechner <felix.lechner@HIDDEN>
Cc: guix-devel@HIDDEN, 45mg <45mg.writes@HIDDEN>, 75145 <at> debbugs.gnu.org
Received: via spool by 75145-submit <at> debbugs.gnu.org id=B75145.173677607817704
          (code B ref 75145); Mon, 13 Jan 2025 13:48:01 +0000
Received: (at 75145) by debbugs.gnu.org; 13 Jan 2025 13:47:58 +0000
Received: from localhost ([127.0.0.1]:50719 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tXKnO-0004bS-2V
	for submit <at> debbugs.gnu.org; Mon, 13 Jan 2025 08:47:58 -0500
Received: from mail-10626.protonmail.ch ([79.135.106.26]:47819)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <attila@HIDDEN>)
 id 1tXKnJ-0004aw-9t
 for 75145 <at> debbugs.gnu.org; Mon, 13 Jan 2025 08:47:56 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lendvai.name;
 s=protonmail3; t=1736776065; x=1737035265;
 bh=YTyIWJSPujIObZCKIfFoc4IYVC3/KS5QbMGdeZ1m5gg=;
 h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
 Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
 Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;
 b=Ld3IpMNbT5XgLuGrZ0MLs2q9/17/s98fny4OiQuBckvwCy8Hgg9sEN2P821d9shjI
 kMcU6yV+wct5Vb7leC7q+nW4FTCAIEfborUfxua4RNN/xRom5Eczko4UmioFggH2gF
 AQC/8goviVttGdnoZJcbpg4Y8jFjoeumfWjvQ2FGXR+ICcxLDQfaGJC2pglMSNsDig
 ir8gTtDjVCm6mOBalmcxNpZXRnquv1tQYEAotM1/ezPBHlFd84OMVMvbLbRjU85pFD
 lu7+JyXgWbK/Kem4FuZc10hemVrAZ12BJzpnjFuuL4Ob29hKEQ/zXfHmOqiryfmcMU
 YnRTDeOKbBETA==
Date: Mon, 13 Jan 2025 13:47:40 +0000
From: Attila Lendvai <attila@HIDDEN>
Message-ID: <QT6_4dMIPg29JWMoiMYCRq_GP98T2qfwNEctUHh0f21jO7TnR864v_1P9ntIfLFpKRUcR6CN6LXPSPwcdXhlya7e73qoYO9aNWNMxRljGmM=@lendvai.name>
In-Reply-To: <87seprdbnv.fsf@HIDDEN>
References: <7743f403ebf1693fc386a397e9aed1975b43f900.1735323486.git.45mg.writes@HIDDEN>
 <cover.1736423822.git.45mg.writes@HIDDEN> <87seprdbnv.fsf@HIDDEN>
Feedback-ID: 28384833:user:proton
X-Pm-Message-ID: 2d662b1d78ca7a695de7bb0aefa661f15dde4dcd
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

> > this patch failed to get any attention in two weeks
>
>
> Two weeks isn't a long time in free software projects. A more common
> time frame would be between one year and eighteen months.


...and with such a delay most patches bitrot beyond recognition, then after=
 one too many burdensome rebase the contributor gives up, and then the whol=
e thing gets forgotten.

or an alternative reading of this is that this process selects for contribu=
tors who are willful enough about that specific patch to push it through th=
e finish line of such a marathon.

in my opensource experience 1+ year is nowhere near the average, especially=
 not for patches with a localized effect.

unfortunately, i only have a vague/vapourware proposal to resolve this, whi=
ch is to develop better support for channels, and then allow a thousand flo=
wers to bloom (i.e. allow/facilitate the division of labor). it's not neces=
sarily a safe/simple/straightforward path forward, but it would solve the b=
ottleneck of the central control.

but either way, i wanted to speak up against normalizing 1+ years of delays=
.

--
=E2=80=A2 attila lendvai
=E2=80=A2 PGP: 963F 5D5F 45C7 DFCD 0A39
--
=E2=80=9CAction has meaning only in relationship; without understanding rel=
ationship, action on any level will only breed conflict. The understanding =
of relationship is infinitely more important than the search for any plan o=
f action.=E2=80=9D
=09=E2=80=94 Jiddu Krishnamurti (1895=E2=80=931986), 'Relationship', Colomb=
o Ceylon 2nd radio talk (1950)

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#75145] [PATCH v2 0/1] services: network-manager: Add extra-configuration-files field.
Resent-From: Ricardo Wurmus <rekado@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Mon, 13 Jan 2025 15:49:02 +0000
Resent-Message-ID: <handler.75145.B75145.17367832898040 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75145
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Attila Lendvai <attila@HIDDEN>
Cc: guix-devel@HIDDEN, 45mg <45mg.writes@HIDDEN>, Felix Lechner <felix.lechner@HIDDEN>, 75145 <at> debbugs.gnu.org
Received: via spool by 75145-submit <at> debbugs.gnu.org id=B75145.17367832898040
          (code B ref 75145); Mon, 13 Jan 2025 15:49:02 +0000
Received: (at 75145) by debbugs.gnu.org; 13 Jan 2025 15:48:09 +0000
Received: from localhost ([127.0.0.1]:52539 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tXMfh-00025c-D4
	for submit <at> debbugs.gnu.org; Mon, 13 Jan 2025 10:48:09 -0500
Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21180)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <rekado@HIDDEN>)
 id 1tXMfe-00025P-Dr
 for 75145 <at> debbugs.gnu.org; Mon, 13 Jan 2025 10:48:07 -0500
ARC-Seal: i=1; a=rsa-sha256; t=1736783274; cv=none; 
 d=zohomail.com; s=zohoarc; 
 b=OgtQmkcaU6A+Z4Jv9OGsndDyvM28Sv/PmtoG6w15HOAsFZQDk883+6vpKI6PbSMZs6hErwLDXYdijAJc3mjz3qcd06R+Go1A5JMHXOkXiS57tQ9qzawtoBO4bGpB1zjZSJ/HYpv7SHqC4olQTIZMdRUYiHcywMD0kNUXcLlQFQ4=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
 s=zohoarc; t=1736783274;
 h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;
 bh=fUorfeCAMGjXljp9GtkBoHWQR6mDXa4WUCYQlobZIuQ=; 
 b=A9nfxj7uFU75J2dVS9FjVBLY1TqUDps+JhTpDDUU0gAfgA182J3lYQWmzhjiusovxdbExmlSCHQIzLcQKAeLGMQvqkWk014QdVUyyr4TpnuTvbh//wYxCS3K7hI/W3tgV3EbNowl01mGEyIgppYdQAMgC5yFRM0Wc9sX3cWt+MI=
ARC-Authentication-Results: i=1; mx.zohomail.com;
 dkim=pass  header.i=elephly.net;
 spf=pass  smtp.mailfrom=rekado@HIDDEN;
 dmarc=pass header.from=<rekado@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1736783274; 
 s=zoho; d=elephly.net; i=rekado@HIDDEN;
 h=From:From:To:To:Cc:Cc:Subject:Subject:In-Reply-To:References:Date:Date:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To;
 bh=fUorfeCAMGjXljp9GtkBoHWQR6mDXa4WUCYQlobZIuQ=;
 b=cLAXL66gOmd0Yd09aaSB1sU8AFlAZreZSRwme5egiBYWRYHrMKvxuyyF3OtortbD
 UsFk/6X44DrNZYEAZ7POfRQqWgvP0SgaNZExAAgP05JBSi+rwVJ+21RpQr7as5nQj2a
 HoLHdwA0yDFNhOlxZ8SkX3HHiKEvQcjs/fyR4Spc=
Received: by mx.zohomail.com with SMTPS id 1736783272814362.2777159150146;
 Mon, 13 Jan 2025 07:47:52 -0800 (PST)
From: Ricardo Wurmus <rekado@HIDDEN>
In-Reply-To: <QT6_4dMIPg29JWMoiMYCRq_GP98T2qfwNEctUHh0f21jO7TnR864v_1P9ntIfLFpKRUcR6CN6LXPSPwcdXhlya7e73qoYO9aNWNMxRljGmM=@lendvai.name>
 (Attila Lendvai's message of "Mon, 13 Jan 2025 13:47:40 +0000")
References: <7743f403ebf1693fc386a397e9aed1975b43f900.1735323486.git.45mg.writes@HIDDEN>
 <cover.1736423822.git.45mg.writes@HIDDEN> <87seprdbnv.fsf@HIDDEN>
 <QT6_4dMIPg29JWMoiMYCRq_GP98T2qfwNEctUHh0f21jO7TnR864v_1P9ntIfLFpKRUcR6CN6LXPSPwcdXhlya7e73qoYO9aNWNMxRljGmM=@lendvai.name>
User-Agent: mu4e 1.12.7; emacs 29.4
Date: Mon, 13 Jan 2025 16:47:49 +0100
Message-ID: <87jzayk95m.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-ZohoMailClient: External
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Attila Lendvai <attila@HIDDEN> writes:

>> > this patch failed to get any attention in two weeks
>>
>>
>> Two weeks isn't a long time in free software projects. A more common
>> time frame would be between one year and eighteen months.
>
>
> ...and with such a delay most patches bitrot beyond recognition, then
> after one too many burdensome rebase the contributor gives up, and
> then the whole thing gets forgotten.

I agree.  Let's not normalize long delays.
Pinging is, in fact, encouraged.

We're still in the slow process of forming self-organized teams that
cover a manageable amount of packages/files and have enough dedicated
committers to review patches.  This works fine for some of our
sub-communities, but for others it still doesn't.

Once the community grew beyond a size where I recognized each and every
contributers the problems of structurelessness have become painfully
obvious.  It is not something we want people to get used to, but it's
also not something a handful of people can fix by decree.

Speaking for myself: I burned out a few years ago and haven't recovered
even a fraction of my capacity today.  This is something we really want
to avoid, and ideally people would self-organize around committers they
know, who can champion their contributions --- instead of calling for
the proliferation of private channels, a different kind of unmanageable
structurelessness.

-- 
Ricardo

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#75145] [PATCH v2 0/1] services: network-manager: Add extra-configuration-files field.
Resent-From: Attila Lendvai <attila@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 17 Jan 2025 13:44:02 +0000
Resent-Message-ID: <handler.75145.B75145.173712143621781 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75145
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ricardo Wurmus <rekado@HIDDEN>
Cc: guix-devel <guix-devel@HIDDEN>, 45mg <45mg.writes@HIDDEN>, Felix Lechner <felix.lechner@HIDDEN>, "75145 <at> debbugs.gnu.org" <75145 <at> debbugs.gnu.org>
Received: via spool by 75145-submit <at> debbugs.gnu.org id=B75145.173712143621781
          (code B ref 75145); Fri, 17 Jan 2025 13:44:02 +0000
Received: (at 75145) by debbugs.gnu.org; 17 Jan 2025 13:43:56 +0000
Received: from localhost ([127.0.0.1]:36421 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tYmdg-0005fF-67
	for submit <at> debbugs.gnu.org; Fri, 17 Jan 2025 08:43:56 -0500
Received: from mail-10625.protonmail.ch ([79.135.106.25]:52203)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <attila@HIDDEN>)
 id 1tYmda-0005ev-Mh
 for 75145 <at> debbugs.gnu.org; Fri, 17 Jan 2025 08:43:53 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lendvai.name;
 s=protonmail3; t=1737121423; x=1737380623;
 bh=1OMl/kYjIZZZOocKT9QT4WuAm9i/0DeZ9mA1/XKcMqU=;
 h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
 Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
 Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;
 b=HLu6stqWXbLc25qgebXZs3qSL99irva9C4jt2VEBPNvVK6onZ8WXDw9HT1IeMnuCP
 jc97spPSdWwg7MNwWzvRtyoDq5/Vx272d0B9ia4rTdfiGkASOFxfjsnvsgNF9gIvMK
 lbX1vRI0skFAFCpirq3ss2fe48aIpya5quPZAdrHh9uvkxvFJyd0lT/hwgnQyY4BLI
 krIlKrW2yGGg7ieFw0AcT+J3Y655kwLn+YiJFsioKSiIR3ukfQ/21zDgahJeC3JRw1
 EFk55ehjuHOsPJyYccHXDjKs1mfB2+sxsqAoyjluaATx8UZwvgCCU1kzbYR+v3qZAJ
 78boBxIYQBPyg==
Date: Fri, 17 Jan 2025 13:43:36 +0000
From: Attila Lendvai <attila@HIDDEN>
Message-ID: <aHnXXMTRpTEKwchU2tjCKh6sjTnh95IQHWz6zStXqCmHl06EJxj55Q0pSGd0iEMTnb33vTbmctdtwWzkXQKopuvD4hjO3d6xJ-RyPOHc2Lc=@lendvai.name>
In-Reply-To: <87jzayk95m.fsf@HIDDEN>
References: <7743f403ebf1693fc386a397e9aed1975b43f900.1735323486.git.45mg.writes@HIDDEN>
 <cover.1736423822.git.45mg.writes@HIDDEN> <87seprdbnv.fsf@HIDDEN>
 <QT6_4dMIPg29JWMoiMYCRq_GP98T2qfwNEctUHh0f21jO7TnR864v_1P9ntIfLFpKRUcR6CN6LXPSPwcdXhlya7e73qoYO9aNWNMxRljGmM=@lendvai.name>
 <87jzayk95m.fsf@HIDDEN>
Feedback-ID: 28384833:user:proton
X-Pm-Message-ID: 4d06d27d3d7489f9250fb075ddf2b09798c9eb1c
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

> instead of calling for
>  the proliferation of private channels, a different kind of unmanageable
>  structurelessness.

not private channels, simply channels that are not owned/controlled by the =
exact same set of committers as guix proper, and not demanding the exact sa=
me requirements from their contributors.

this may seem like nitpicking, but i think it's an important detail in this=
 context.

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#75145] [PATCH v2 0/1] services: network-manager: Add extra-configuration-files field.
Resent-From: Ricardo Wurmus <rekado@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 17 Jan 2025 20:26:02 +0000
Resent-Message-ID: <handler.75145.B75145.173714553419791 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75145
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Attila Lendvai <attila@HIDDEN>
Cc: guix-devel <guix-devel@HIDDEN>, 45mg <45mg.writes@HIDDEN>, Felix Lechner <felix.lechner@HIDDEN>, "75145 <at> debbugs.gnu.org" <75145 <at> debbugs.gnu.org>
Received: via spool by 75145-submit <at> debbugs.gnu.org id=B75145.173714553419791
          (code B ref 75145); Fri, 17 Jan 2025 20:26:02 +0000
Received: (at 75145) by debbugs.gnu.org; 17 Jan 2025 20:25:34 +0000
Received: from localhost ([127.0.0.1]:38937 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tYsuM-000599-1H
	for submit <at> debbugs.gnu.org; Fri, 17 Jan 2025 15:25:34 -0500
Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21190)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <rekado@HIDDEN>)
 id 1tYsuG-00058m-1t
 for 75145 <at> debbugs.gnu.org; Fri, 17 Jan 2025 15:25:31 -0500
ARC-Seal: i=1; a=rsa-sha256; t=1737145517; cv=none; 
 d=zohomail.com; s=zohoarc; 
 b=bM+2CV61iNsLdcvCcPsFQh81+R2PvDCW1AHW7ftfR74qVd1ETa4Ee8iqsQrOqhRKe0fqTeQ8q9pjOJ5gflahZTQyVxyWoW3bLgi7fUtx8fRz86gYQ4TneAf/vCpsnQovVw5wAEbwK+d9JGin4VRdK0oZPT4UKAklBdbYJzfi0LM=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
 s=zohoarc; t=1737145517;
 h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;
 bh=vSe2ulkfsnZ3Pgdxj4jH+RCl/fjitNYa1L+9Ik82r7Y=; 
 b=jx5QTC7Q+mqYXr3TvbsKvA0nU/Ly66v3Sgbh3zudbutAnSGHJzG/d6fNxLxCf50Bvx8+4eymHFQtqBNKjEkSSqY9vMJc9pmsQsrGYtOnQ/umGIFHxXIZMSW0owXSAkX8NuhHAMnvDFQIwaUHKm5CdfhQK4x+siVlOFOohqawARE=
ARC-Authentication-Results: i=1; mx.zohomail.com;
 dkim=pass  header.i=elephly.net;
 spf=pass  smtp.mailfrom=rekado@HIDDEN;
 dmarc=pass header.from=<rekado@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1737145517; 
 s=zoho; d=elephly.net; i=rekado@HIDDEN;
 h=From:From:To:To:Cc:Cc:Subject:Subject:In-Reply-To:References:Date:Date:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To;
 bh=vSe2ulkfsnZ3Pgdxj4jH+RCl/fjitNYa1L+9Ik82r7Y=;
 b=RzAtYRiHa4NytK1RJvgVahL6fAS+oLsbMdD2KFUxW9FfHhxvI7mq1b0xkpjfJ6lB
 BIRXUwHjjeuDF9m8leUU4dxUk5HkiE+sGigYWgmOu9ldkW+cb1fiuQ+sWIzGCR5NdQv
 z6oJmQkncaM6NzF9B+7mUCelUMPlNuFtZzy7/e+8=
Received: by mx.zohomail.com with SMTPS id 1737145515277125.96998083337314;
 Fri, 17 Jan 2025 12:25:15 -0800 (PST)
From: Ricardo Wurmus <rekado@HIDDEN>
In-Reply-To: <aHnXXMTRpTEKwchU2tjCKh6sjTnh95IQHWz6zStXqCmHl06EJxj55Q0pSGd0iEMTnb33vTbmctdtwWzkXQKopuvD4hjO3d6xJ-RyPOHc2Lc=@lendvai.name>
 (Attila Lendvai's message of "Fri, 17 Jan 2025 13:43:36 +0000")
References: <7743f403ebf1693fc386a397e9aed1975b43f900.1735323486.git.45mg.writes@HIDDEN>
 <cover.1736423822.git.45mg.writes@HIDDEN> <87seprdbnv.fsf@HIDDEN>
 <QT6_4dMIPg29JWMoiMYCRq_GP98T2qfwNEctUHh0f21jO7TnR864v_1P9ntIfLFpKRUcR6CN6LXPSPwcdXhlya7e73qoYO9aNWNMxRljGmM=@lendvai.name>
 <87jzayk95m.fsf@HIDDEN>
 <aHnXXMTRpTEKwchU2tjCKh6sjTnh95IQHWz6zStXqCmHl06EJxj55Q0pSGd0iEMTnb33vTbmctdtwWzkXQKopuvD4hjO3d6xJ-RyPOHc2Lc=@lendvai.name>
User-Agent: mu4e 1.12.7; emacs 29.4
Date: Fri, 17 Jan 2025 21:25:11 +0100
Message-ID: <87ldv9fas8.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-ZohoMailClient: External
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Attila Lendvai <attila@HIDDEN> writes:

>> instead of calling for
>>  the proliferation of private channels, a different kind of unmanageable
>>  structurelessness.
>
> not private channels, simply channels that are not owned/controlled by
> the exact same set of committers as guix proper, and not demanding the
> exact same requirements from their contributors.
>
> this may seem like nitpicking, but i think it's an important detail in this context.

Thanks for the correction.  I did mean personal channels, i.e. operated
(or abandoned) by a single person.

The guix-science collective demonstrates an alternative model, where
people of similar interest band together to provide a channel (or set of
channels) that is governed by different rules than Guix itself.  This
started out as a set of independently run channels (guix-bimsb,
guix-bimsb-nonfree, guix-science, guix-science-nonfree, guix-hpc, etc)
and is now a much more streamlined and cohesive shared effort.

I would advise against running a multitude of personal channels in favor
of collaborating with others on a much smaller number of channels -- and
ideally as a team in Guix itself.

-- 
Ricardo

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#75145] [PATCH v2 0/1] services: network-manager: Add extra-configuration-files field.
Resent-From: Arnaud Daby-Seesaram <ds-ac@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 18 Jan 2025 21:20:02 +0000
Resent-Message-ID: <handler.75145.B75145.173723516419383 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75145
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 45mg <45mg.writes@HIDDEN>
Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, 75145 <at> debbugs.gnu.org
Received: via spool by 75145-submit <at> debbugs.gnu.org id=B75145.173723516419383
          (code B ref 75145); Sat, 18 Jan 2025 21:20:02 +0000
Received: (at 75145) by debbugs.gnu.org; 18 Jan 2025 21:19:24 +0000
Received: from localhost ([127.0.0.1]:43957 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tZGE0-00052Z-02
	for submit <at> debbugs.gnu.org; Sat, 18 Jan 2025 16:19:24 -0500
Received: from nanein.fr ([185.230.78.41]:53518)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <ds-ac@HIDDEN>) id 1tZGDx-00052I-Jp
 for 75145 <at> debbugs.gnu.org; Sat, 18 Jan 2025 16:19:22 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nanein.fr; s=mail;
 t=1737234854; bh=A96Q8AnyA2j4C0gCaagQIlaDlsZ8D72nTUZ1NyFvzgE=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=Om4Sbxae/kDnIvhebje+TcCLS/nQ9S3kjqRFhx1yysENP/vPFLGRFUyO2A0gov4pj
 WRpQ5zCU+Pz8R+UDySw2N/b4oN4+OqGce/1TX8Gyy+l6Z1ik/vZE6g5LSvreqL/xom
 ZDkhB6LwioDaoaM4pm2xqqVffsL/Lw/mJGwdgEz13KuBnxY5RAibGQv0IoQa4ueZq5
 gxA4fYBIOzVYDcAzHhleEXChfIYiHFfYUcPuFTLbEgqN9io/jw250ja7TTQTjMUEV1
 4Egt8srzwS3pNwE2EfJKObOUQJ1YUTEiFip+rD2FSV/k6qUYd+1au1UY+uJ7rj7+yT
 Jsxufqx0e9Ta4p6f6sAwPJjir7Lv2/NJTMdRAioG0MmosetN8PJOCktz9OqZRu42bE
 AhRqfhHFJPeCZmvShIwRplgOVk+Zgm/oeLi2F8zcXmDQ/ugJIu64jCqOzY1a447fmI
 k77rGJ6lRtuWdCG5z/LThwl/6je6ex0VWjr2eI005yzA1U3/1mkisXQX5lPgyKxpFp
 6WTehO7MajU5tCKCU/w7Z5ZeJuO8D+VWUlpal5YMDxcvC9MoaSheuIxETjW5XOCASe
 ipJgysBtxzEQ2etrTwBbRiTberkInD+1ZXMbwkiEPolyj3N8mXphggad1HUZp9JFTT
 2uptoRtO6x3JgfO655O6zM24=
Received: from cochea (wg.nanein.fr [IPv6:2a0c:700:12:50:1::109])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1)
 server-digest SHA256) (No client certificate requested)
 by nanein.fr (Postfix) with ESMTPSA id 056E01401ED;
 Sat, 18 Jan 2025 22:14:13 +0100 (CET)
From: Arnaud Daby-Seesaram <ds-ac@HIDDEN>
In-Reply-To: <87jzb3zzqm.fsf@HIDDEN> (45mg.writes@HIDDEN's message of
 "Thu, 09 Jan 2025 12:03:13 -0500")
References: <7743f403ebf1693fc386a397e9aed1975b43f900.1735323486.git.45mg.writes@HIDDEN>
 <cover.1736423822.git.45mg.writes@HIDDEN>
 <875xmo11ys.fsf@HIDDEN> <87jzb3zzqm.fsf@HIDDEN>
User-Agent: mu4e 1.12.7; emacs 29.4
Date: Sat, 18 Jan 2025 22:13:58 +0100
Message-ID: <87o703hlk9.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi,

I apologise for the late answer.

45mg <45mg.writes@HIDDEN> writes:
> Arnaud Daby-Seesaram <ds-ac@HIDDEN> writes:
>> As you said, you are doing something similar to `etc-service-type'.  Is
>> there a reason not to extend [2] it directly (e.g.=C2=A0like
>> `greetd-service-type' does in `(gnu services base)')?
>>
>> You could, for example, prepend "NetworkManager/conf.d/" to file names
>> and pass the value to `etc-service-type'.  WDYT?
>
> [...]
>
> When we use `etc-service-type`, "/etc/NetworkManager" becomes a symlink
> to "/etc/static/NetworkManager"; and "/etc/static" is a symlink to the
> result of building the derivation returned by `etc-entry` (see (gnu
> services)). And derivations are in the store, which is read-only. So we
> can't create "/etc/NetworkManager/system-connections/". And this won't
> do, since NetworkManager itself needs to be able to write to that
> directory to manage saved connections.
>
> So it looks like that won't work.

That is unfortunate; thank you for trying it out!

Re-reading your patch and the implementation of `etc-service-type',
maybe `network-manager-configuration-directory' could be replaced by
`file-union' defined in `(guix gexp)', WDYT?

Otherwise, your patch seems good to me=C2=A0:).  I will let others comment
and give their opinion.


Best regards,

=2D-=20
Arnaud

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCgAuFiEEMgqfJ4U0fby1t860ojLKXoMTiAwFAmeMGZYQHGRzLWFjQG5h
bmVpbi5mcgAKCRCiMspegxOIDJHiEACWAZNT3iF5k9gjoKHyj1oVUr37PEC5Z14I
vYClwcxY7ILkOquepMyUlbcQ8sH2GbwlN87C1xicmhIiQ7IXNp40F5ilHbXoPruD
YLsOpsnD25GCXz7IusLPk4NQVjOBn05DmuG+3sNoapxwaZ00mG3ut8gYde1iHqoK
g7vuWhiJozzQ/OKIuxu5SodwiPQ9Ocqrkozt+ERItQIAcM2IYv347vR/i/1P+nFV
3EusquR7LiF9/e5fYORmZLWJ7SqzieDCd3YSlLEMJrQx4/GmxKJIZF6V+jDu1kaR
+KWXXkVHnUDa7Lqn11AEpP/5q9lGzOqS2UjJ5w6aaS7CMuaSq83ssTrDuNKKqoSf
xEc/6aFxs/Hg3ABwLaCeRALrezdrJnDAa7EZ1VhoFkaTa4WNOXEJ/UCW09ECpAc2
61smQ/kHb+gB6q/ZSXFq1/iJxRVkbQfBaOsqMHfG2Ijqikq+xM/v7t+JwZFrrA35
RQAOhMOnfZox3dn+MtAngVHIk6ossFK5wSpB10NZHYAHJxGWnoAx9t6KASFsnPOn
oGnrICtEn956H5kR+uAG8rKLggrTvb2ioGgbbQ5SPwAdsz3g1mJU/0lI1wPfMfOc
RgARoLZx8JeaFAwWertam+3fn2+JvrXgL+rfo6oTfSTpB6YQe3WkxXWwYLwy1fIy
AIfsrnPlHg==
=6XrX
-----END PGP SIGNATURE-----
--=-=-=--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#75145] [PATCH v2 0/1] services: network-manager: Add extra-configuration-files field.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 21 Jan 2025 04:45:02 +0000
Resent-Message-ID: <handler.75145.B75145.17374346522298 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75145
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Arnaud Daby-Seesaram <ds-ac@HIDDEN>
Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, 45mg <45mg.writes@HIDDEN>, 75145 <at> debbugs.gnu.org
Received: via spool by 75145-submit <at> debbugs.gnu.org id=B75145.17374346522298
          (code B ref 75145); Tue, 21 Jan 2025 04:45:02 +0000
Received: (at 75145) by debbugs.gnu.org; 21 Jan 2025 04:44:12 +0000
Received: from localhost ([127.0.0.1]:52902 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ta67X-0000az-T0
	for submit <at> debbugs.gnu.org; Mon, 20 Jan 2025 23:44:12 -0500
Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]:51651)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1ta67V-0000ah-Al
 for 75145 <at> debbugs.gnu.org; Mon, 20 Jan 2025 23:44:10 -0500
Received: by mail-pl1-x62c.google.com with SMTP id
 d9443c01a7336-216401de828so86680195ad.3
 for <75145 <at> debbugs.gnu.org>; Mon, 20 Jan 2025 20:44:09 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1737434643; x=1738039443; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:user-agent:message-id:date
 :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=f7domqmYDrkM4hYZ7KVG34bcmb+BKPIgKWmsGVhqp90=;
 b=hi29EK0PZ4StHFvDu9xEYExcAfJbm9SVAPigHuJetWSh7olEtu+U9Jbnyp8+flEvcn
 3u31RVWOHMSTHdQ0ias1kauXpUFt6zPWb+h6qqeqCgqWnGAIqMxQqFTGTZ3fk1wuDh4r
 e8pPsJzeXig9xuUJ2N83HGbpCC6O7iFq5bLqLi90Dq73mn7g5Apreh8lYAhvbcagQPPQ
 C8hR59yXyb4V22mvP8Pn/AEncuu9UcD0YV1G5r/RmYRYkl5P5ed8uYO1qbRTZIZFMOSt
 YrTgEWM6lORfWYiHUWt2ElMzNx53PORFqr4LZ3xVLBWYVQRcuVCjyNK1cmYmsr6sN3zR
 4hNQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1737434643; x=1738039443;
 h=content-transfer-encoding:mime-version:user-agent:message-id:date
 :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
 :to:cc:subject:date:message-id:reply-to;
 bh=f7domqmYDrkM4hYZ7KVG34bcmb+BKPIgKWmsGVhqp90=;
 b=BWeKVnKApCdZegAkWZKbsDHaHaXFzcVYti3bp9OVqh7cG6G9TO5Nsyp/tCzOT39oRe
 P3slI/HpGgFg7ACW+TonMNnGD7IVVpvL8ShRfDciOyDmnh5HRSG3pma3/vYFZZTGjbTf
 Jp0A7eSV8aiw5mqLGH5+ty+YoI1bl9t7nHiJCSqnIpecxPZD4XcX3CfZs5ZqELgSmFGe
 CL/nh5CutlBTEigD19svBGP2cYuKp5b1bISQiZZwRVTSn2hSwx5L8Tg6uzIajav5zsBy
 ErnziWHMsVLOJDvP/WgaiMw6QLku/nqq3VYS7Y0xnV1RNZOEn9/IOgKx4/hQ4DNaL532
 M0Ww==
X-Forwarded-Encrypted: i=1;
 AJvYcCWiZ4p4OTgHIkNdEoCsx4WJSnkPmAtnRknn+h0J96UOMVmize6Nta2QlbvwR90y8e7wKTC5DQ==@debbugs.gnu.org
X-Gm-Message-State: AOJu0Yw8Jw504pz+zA0yLsR8CWavOMeEc6+kwJhUluJMh8CMptfvMFlP
 bNrDkTuxPUuHWX8gGbRFjCzFQl476s7lVk7ecjSfuvXKwswP4N3i
X-Gm-Gg: ASbGncvjjUQBODe971BR5/qS/qwJemvgO8QxumvWWJk04FEeL9KXYIijrNRb63BAw0g
 0XvqWuUb8bjTSZS2xowSQ6Dl8MRuLR5D0WZ+EK0S+iHqcSNfW2ZpB/I+D8kC0ekSYiH1L0cJV3p
 GSphzMWxsl2Yky2tFaSycXPt9gjamjIu76P4EJKAvNIzzQRX1R2v09RHRESFlasW3sF1M4Y46nT
 IgxFl79QjkokL/kYvqnGBHi68YoOj9acD8LxD6O2k0KuxW6SC3cXa7x53EBpXv8f4s=
X-Google-Smtp-Source: AGHT+IFRTmIYQ08e5O5gkoOywQPbKFguPx3Pne5BplJ2ufASIxuj3gcMv4fm9VPTrnOd1qZhX4g5AA==
X-Received: by 2002:a05:6a20:729e:b0:1e1:cd09:e08d with SMTP id
 adf61e73a8af0-1eb21485321mr23312049637.11.1737434643182; 
 Mon, 20 Jan 2025 20:44:03 -0800 (PST)
Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89])
 by smtp.gmail.com with ESMTPSA id
 d2e1a72fcca58-72dab7f06b8sm8158677b3a.16.2025.01.20.20.44.01
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 20 Jan 2025 20:44:02 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
In-Reply-To: <87o703hlk9.fsf@HIDDEN> (Arnaud Daby-Seesaram's message of
 "Sat, 18 Jan 2025 22:13:58 +0100")
References: <7743f403ebf1693fc386a397e9aed1975b43f900.1735323486.git.45mg.writes@HIDDEN>
 <cover.1736423822.git.45mg.writes@HIDDEN>
 <875xmo11ys.fsf@HIDDEN> <87jzb3zzqm.fsf@HIDDEN>
 <87o703hlk9.fsf@HIDDEN>
Date: Tue, 21 Jan 2025 13:43:51 +0900
Message-ID: <87jzaoai9k.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi,

Arnaud Daby-Seesaram <ds-ac@HIDDEN> writes:

[...]

>> When we use `etc-service-type`, "/etc/NetworkManager" becomes a symlink
>> to "/etc/static/NetworkManager"; and "/etc/static" is a symlink to the
>> result of building the derivation returned by `etc-entry` (see (gnu
>> services)). And derivations are in the store, which is read-only. So we
>> can't create "/etc/NetworkManager/system-connections/". And this won't
>> do, since NetworkManager itself needs to be able to write to that
>> directory to manage saved connections.
>>
>> So it looks like that won't work.
>
> That is unfortunate; thank you for trying it out!
>
> Re-reading your patch and the implementation of `etc-service-type',
> maybe `network-manager-configuration-directory' could be replaced by
> `file-union' defined in `(guix gexp)', WDYT?
>
> Otherwise, your patch seems good to me=C2=A0:).  I will let others comment
> and give their opinion.

A file-union also result in a read-only directory in the store, so if
NetworkManager needs write access to that location, that also wouldn't
work.

--=20
Thanks,
Maxim

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#75145] [PATCH v2 0/1] services: network-manager: Add extra-configuration-files field.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 21 Jan 2025 04:53:01 +0000
Resent-Message-ID: <handler.75145.B75145.17374351523997 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75145
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 45mg <45mg.writes@HIDDEN>
Cc: guix-devel@HIDDEN, Felix Lechner <felix.lechner@HIDDEN>, 75145 <at> debbugs.gnu.org
Received: via spool by 75145-submit <at> debbugs.gnu.org id=B75145.17374351523997
          (code B ref 75145); Tue, 21 Jan 2025 04:53:01 +0000
Received: (at 75145) by debbugs.gnu.org; 21 Jan 2025 04:52:32 +0000
Received: from localhost ([127.0.0.1]:52919 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ta6Fc-00012P-7y
	for submit <at> debbugs.gnu.org; Mon, 20 Jan 2025 23:52:32 -0500
Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]:43283)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1ta6FZ-00012A-OC
 for 75145 <at> debbugs.gnu.org; Mon, 20 Jan 2025 23:52:30 -0500
Received: by mail-pl1-x62e.google.com with SMTP id
 d9443c01a7336-21631789fcdso74670095ad.1
 for <75145 <at> debbugs.gnu.org>; Mon, 20 Jan 2025 20:52:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1737435143; x=1738039943; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=Y6HNOygB/cTuCtToxkmOecPTT3CVjrmkzIl4cXpjRng=;
 b=Dx0iDlX9/RnlQpLThysqRCsJBdaKs8Ij7ZHq9gaduzkPK8TDVGf9vLRMx/iUiYyuuS
 lTHcAL/M7eX1+mig6/Z3yIWSQIYxkrHMAGSbrVxL/SlLlxUW6YYQ6Ao9Rm6Kzc0HBCGv
 opTKRdWFvkAVTjo5O1BHuXxffYQfQtCZCGAH2uyqf/ODYe5Us8vuN88NP82+g26cxzCj
 BbrNr2UpkOIZXEWSo3Qfko8XhePY82rmRoloBahC81xTnPNrhG7ubFM4KLrKhITszVZO
 u6a8sQ3w80Mqg6hIcFMtkpf3q3G2JGLipjsbRFpZ/TiLTNOsPOBidqdsIKyhLzy9HtTP
 qvgA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1737435143; x=1738039943;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=Y6HNOygB/cTuCtToxkmOecPTT3CVjrmkzIl4cXpjRng=;
 b=RCZ9keGnirYVKsTMpAkMWUWWL/UhuW4rBFdaJg62FNDgd8QEakkVJKrRM8Saar6lw2
 VI7mF6VD4AOF6OuV7jwOSdC32Vxzos7PNzHHHLiWjFhUGoVRsvxyRf92ElnD2xc9lRwT
 IdKYn7h9XrcfEglr56Yfq7/fEKP9UasCnErFlg8N8F3U9tr9FcJWDIeDZnBV5UV0ZfCe
 heSDeWsOwKlIf255ARFr56PuJ0T46BH1bG1q8irL0zZiEiPC1NwNVhj7SO125qs3g7Iu
 rUB6+dA4SPmQ/801SbTrmmXf1O2tYRpjemUEAKkIKdJZ1KEDkLo+7Yhue8vq5CLIbUio
 9rVw==
X-Forwarded-Encrypted: i=1;
 AJvYcCUQVfu4tZaY63x8qvWn9ma+bVXqJptdBUDG+fxOtFGBGpRfiy9U8C3kBJ3fzcz3PXjBWukeUg==@debbugs.gnu.org
X-Gm-Message-State: AOJu0Yzx5KZ1ULNmRW+m56hwkOShT24oTu2sp5Ab5Pa9VAAQ2jM22VAK
 0aCziIVO8rnXWR7Qj/jzka0x34sMQ3feDM4sZnhlaQinPFUDiBQ4fGvuM8MS0wA=
X-Gm-Gg: ASbGncs0XsWLMV7aJjgrN5/2eZNYbbwroVoaDk9uaEyOkjHncpg8i/WF0aqLvLPbt2T
 SG+IPojz9YSuJIGXYU1dZLtAAbj+ckXN4GrAVvIg8WJRv09B+F/WxzTf8rWGeIN7nuXa08L6dsf
 8fYbtscvB0fNiKrDxSkZBX2t9epWtAHiFIDLQ5Sm/LHqmuz+Xv2UNy1uXFpQoPb8SsNQIDTQSnb
 G1+InD3bAN2laRnMMxgH2UEzl27Fw/z82irtpKqd6Ig+ntHmJWW19XSvFZDGNYLJDY=
X-Google-Smtp-Source: AGHT+IFjn48KgPKcWxvCuWBreihGWBzop2vF2iZYrShW4Zak/eKHdnWuORY+qi+t1nwEkmSL2dA5JA==
X-Received: by 2002:a17:903:120b:b0:215:758c:52ea with SMTP id
 d9443c01a7336-21c35c8ca8emr192063815ad.9.1737435143213; 
 Mon, 20 Jan 2025 20:52:23 -0800 (PST)
Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89])
 by smtp.gmail.com with ESMTPSA id
 d9443c01a7336-21c2d3ac658sm67953575ad.127.2025.01.20.20.52.21
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 20 Jan 2025 20:52:22 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
In-Reply-To: <87sepogc68.fsf@HIDDEN> (45mg.writes@HIDDEN's message of
 "Sun, 12 Jan 2025 17:43:59 +0000")
References: <7743f403ebf1693fc386a397e9aed1975b43f900.1735323486.git.45mg.writes@HIDDEN>
 <87sepogc68.fsf@HIDDEN>
Date: Tue, 21 Jan 2025 13:52:11 +0900
Message-ID: <87frlcahvo.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi 45mg,

45mg <45mg.writes@HIDDEN> writes:

[...]

> Thanks, good to know. Will try to keep that in mind. I do wish there was
> something I could do to get things moving faster, but I guess this is a
> limitation of projects that run on (primarily) unpaid volunteer work :/

As mentioned by Ricardo, a good way to try to tackle the load would be
to get involved with a Guix team and conduct reviews.  There's no need
to be an expert; even just spotting typos and small details help.  If
you have time, applying it locally and giving it a try and sharing your
experience is also very valuable.

-- 
Thanks,
Maxim

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#75145] [PATCH v2 0/1] services: network-manager: Add extra-configuration-files field.
Resent-From: Arnaud Daby-Seesaram <ds-ac@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 21 Jan 2025 08:37:03 +0000
Resent-Message-ID: <handler.75145.B75145.173744861617969 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75145
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, 45mg <45mg.writes@HIDDEN>, 75145 <at> debbugs.gnu.org
Received: via spool by 75145-submit <at> debbugs.gnu.org id=B75145.173744861617969
          (code B ref 75145); Tue, 21 Jan 2025 08:37:03 +0000
Received: (at 75145) by debbugs.gnu.org; 21 Jan 2025 08:36:56 +0000
Received: from localhost ([127.0.0.1]:53174 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ta9kl-0004fl-Hu
	for submit <at> debbugs.gnu.org; Tue, 21 Jan 2025 03:36:55 -0500
Received: from nanein.fr ([185.230.78.41]:59752)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <ds-ac@HIDDEN>) id 1ta9kj-0004fX-Cs
 for 75145 <at> debbugs.gnu.org; Tue, 21 Jan 2025 03:36:54 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nanein.fr; s=mail;
 t=1737448606; bh=VKdOR5QfM6cAs/9wwtnWiC5tYhDzHE8/ZD97BhoZZNI=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=hm2s5FD1lzWlbHPGNCgHlgilOLhFCoeKdmmGFhDcAL3eCBZ4X19RM0/90JXeQ4SAn
 BovfvorqXXQjpfAOH+C6/2q245rj/HKMOZw372amJxLmws7mgGjnrbrqO1KsudAMRU
 pA/h/YTyfomb4NjiihIdNjaN7Bg6c4cY/B2Cm2sEIDF09h7rNRFccU6MnH4ST2973w
 b3bDNtJkJCbJcvbPGIO9ViPTZCoKOPy7yJbnqNO1Cn30MUDYg7Se4HUC6WoNN3Up3X
 ERlmGYHWa9VANVfVqC9p0taijs2vEYaRdiNUCWxTm59VcbwEmWCk94cVDKxXdNz1ET
 mxc0HK7oqJc9dUknYt3pQ3j7h1ShrInjYhDRExa8iEmVdOu6Io3txZ2fm4ec5JKWyC
 VxclB3le+Wtftsed2El39qMU2N7LSG1FjdTJTGY6ICnO8iDCtCMtALEpkp3dDdGkbD
 v262gVEzl78/qznRbAncIbVyyK+5ncQfMQVkNwlH/D2xkhYESPLLn7WellDbbZZgQj
 B2unHwJGP9gyLkYzROStM5a3cISKqlJJ6qfa7jVidHwawr+EnD4cp3MzwQ+p8KNQYv
 a1CIcdWmeBLSOu2++ihsAh7Bl200/kTLgT9toh4cBq4hbX6kMi7Hm+q/pOjNYfWQH4
 7Ba6iEuyMFiVrrTVGkkcQKJU=
Received: from cochea (eduroam09.au.dk [185.45.22.146])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1)
 server-digest SHA256) (No client certificate requested)
 by nanein.fr (Postfix) with ESMTPSA id 2B9801401EC;
 Tue, 21 Jan 2025 09:36:46 +0100 (CET)
From: Arnaud Daby-Seesaram <ds-ac@HIDDEN>
In-Reply-To: <87jzaoai9k.fsf@HIDDEN> (Maxim Cournoyer's message of "Tue, 21
 Jan 2025 13:43:51 +0900")
References: <7743f403ebf1693fc386a397e9aed1975b43f900.1735323486.git.45mg.writes@HIDDEN>
 <cover.1736423822.git.45mg.writes@HIDDEN>
 <875xmo11ys.fsf@HIDDEN> <87jzb3zzqm.fsf@HIDDEN>
 <87o703hlk9.fsf@HIDDEN> <87jzaoai9k.fsf@HIDDEN>
User-Agent: mu4e 1.12.7; emacs 29.4
Date: Tue, 21 Jan 2025 09:36:41 +0100
Message-ID: <87jzaoa7hi.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi Maxim,

Maxim Cournoyer <maxim.cournoyer@HIDDEN> writes:
> Hi,
>
> Arnaud Daby-Seesaram <ds-ac@HIDDEN> writes:
>
> [...]
>
>>> When we use `etc-service-type`, "/etc/NetworkManager" becomes a symlink
>>> to "/etc/static/NetworkManager"; and "/etc/static" is a symlink to the
>>> result of building the derivation returned by `etc-entry` (see (gnu
>>> services)). And derivations are in the store, which is read-only. So we
>>> can't create "/etc/NetworkManager/system-connections/". And this won't
>>> do, since NetworkManager itself needs to be able to write to that
>>> directory to manage saved connections.
>>>
>>> So it looks like that won't work.
>>
>> That is unfortunate; thank you for trying it out!
>>
>> Re-reading your patch and the implementation of `etc-service-type',
>> maybe `network-manager-configuration-directory' could be replaced by
>> `file-union' defined in `(guix gexp)', WDYT?
>>
>> Otherwise, your patch seems good to me=C2=A0:).  I will let others comme=
nt
>> and give their opinion.
>
> A file-union also result in a read-only directory in the store, so if
> NetworkManager needs write access to that location, that also wouldn't
> work.

Sorry, I was imprecise.

NetworkManager needs to write to /etc/NetworkManager/system-connections
The issue with extending etc-service-type was that "/etc/NetworkManager"
became a link to the store, and thus system-connections could no longer
be created/written to.

However, the configuration directory is /etc/NetworkManager/conf.d .

What I was proposing was to use file-union to create the configuration
directory (in the store) and symlink it to /etc/NetworkManager/conf.d .

This is close to what the patch already does.  I merely suggested to
replace a homemade function by a function of (guix gexp):
network-manager-configuration-directory and file-union do a similar job
if I read them correctly.


Best regards,

=2D-=20
Arnaud

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCgAuFiEEMgqfJ4U0fby1t860ojLKXoMTiAwFAmePXJoQHGRzLWFjQG5h
bmVpbi5mcgAKCRCiMspegxOIDMD2D/wIlD9fbe+uZ52UGOGwAN07C/dT4FYcg8h5
gIdhOFPC5jltYZuv5uEeSD1oMQ/5WL11mWkXnr1+MOi+DZwrjpHuNSaGjEQ2lVx1
rrtdX6hrEQKiqpCUTXFDVIu/0418liN2PyYsghBTruXSRTP+nQIAMZ30hW8KBmUI
KPc2N/hwAGvZxc91cLoUacHGrgbmauvPQoIMH4gl7VW8myajohUmQRlJyVYG/lP1
hoxHjsopvglmYGdb3K7BStqkdNL+lOMyMTJqrl9Vcz/nKQ0E+5cq5YV1Gfw5NawC
x6LAt+lEFAPW4sunkl8SMChwgA1RVhs0gibHqjFD9/U9GIOUGjlMdhPywJrLcnkQ
MoEQbIjYuU8YL7CqXc1taG4kyhnZvtgrgacLR4SvRzmoESjbYHUMGVAZNWEji8zx
O2AAIaY9eo+j9lIHpIIfXPc03Y49NDPNTducAJSCPhPhc4XtAnsL65vglJPKJ1jT
lDvAJjRI9t6F3mQJbt8aqZMFcB3UoAvpeE1bo2xgqQL/RqtCLSHeYer02+QdTxuy
dpgQ5A1xjcaNDs6THUbmydzf6dEvN1LkXnMhGfb4/24LK67R7aGzcnzq//TJ/F9R
6cwjMJCj2s5Wney4861dGcKMtT9aXm/qutesLdi3PezBkgo+rHneJaN/OYSuLRO8
blOMh2yLFQ==
=ItNN
-----END PGP SIGNATURE-----
--=-=-=--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#75145] [PATCH v2 0/1] services: network-manager: Add extra-configuration-files field.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 21 Jan 2025 13:03:01 +0000
Resent-Message-ID: <handler.75145.B75145.173746454423893 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75145
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Arnaud Daby-Seesaram <ds-ac@HIDDEN>
Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, 45mg <45mg.writes@HIDDEN>, 75145 <at> debbugs.gnu.org
Received: via spool by 75145-submit <at> debbugs.gnu.org id=B75145.173746454423893
          (code B ref 75145); Tue, 21 Jan 2025 13:03:01 +0000
Received: (at 75145) by debbugs.gnu.org; 21 Jan 2025 13:02:24 +0000
Received: from localhost ([127.0.0.1]:53651 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1taDtf-0006DJ-Kh
	for submit <at> debbugs.gnu.org; Tue, 21 Jan 2025 08:02:23 -0500
Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]:61822)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1taDtd-0006D0-4I
 for 75145 <at> debbugs.gnu.org; Tue, 21 Jan 2025 08:02:22 -0500
Received: by mail-pl1-x634.google.com with SMTP id
 d9443c01a7336-21669fd5c7cso98077715ad.3
 for <75145 <at> debbugs.gnu.org>; Tue, 21 Jan 2025 05:02:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1737464535; x=1738069335; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=2YcAHIUNl5mO1UajaseLknlVJt5gzH1ilHE/P/IVH54=;
 b=DSOiYX48+5Nb7jAAewn0vpBgWA78vO5F5urS7DBnjRE+/uLtgTCTMMKWoe5MLXnNnS
 O45UDXIzT8DGM6i0Wn4T+8mTL+TQYbFKuRQeZEj7754W0XErHPe9JZnk8n/NMPcBIalf
 70v2XBOi7EZrtH4QBv+oxUyyxKDw2F3A7oovWlbKXmi0iCum4S1HIg4waVnnLWBvTUyY
 q0x+sllkA+y8qe5P16vhv1zAn4U9KFmrhnWYNaKBLbN8VZ8vR7AkL66PwCi9E8oGXQLP
 XP527L323WjnWGDMV4VCTGeNnvkdLGAWpphcteJQA2BkM4P17ZBZQPVqlSVI7raZ31wU
 qKnw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1737464535; x=1738069335;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=2YcAHIUNl5mO1UajaseLknlVJt5gzH1ilHE/P/IVH54=;
 b=ef+1gR2bZMtDSm20/DO41A4e1kMHYgLpT3WFeYTbvpKMdhWamMCMILRKtShKe/id7C
 +GG1HqH8ZwG6j3rQwEdl9NZdoaN468SfmfwUOHWH+88np+wXCtVcKeZpL3QfEHHv4Vyy
 MykrZJidrcq8ifVZyOiya9fRSNNMCVI2FgulWZedKm17wvpSV7OlA5cnLNszpRZ0PgRA
 p0NorhPDnOqqNZKd6iDdxPEQjFWDJHOqgxPWpuTwIXRe9fvlt7+wBjYqanTTSQfc11Np
 ZR5jpMWfAIhHTaBb9GUNBKHUH/lLOxq09EWtbFIYsTWwuWAPAr4WZiTaQSEJZ3ZD6BuD
 Q4hQ==
X-Forwarded-Encrypted: i=1;
 AJvYcCXKkKrzfO48FzdD/cnKbHFLqzrBHlnzYTtfReCoRNA7WNBXkdLAgtTO5x/Ofo8KyQS3wqGucg==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YzUrFw8hsgLNxnOX29NnTKbfpkpo4x9msc9TJthxMxzcRlys3jz
 +WGZuCXfuzZl7hYoFlfN1L2/kFb0dvMZ8mnsO1mGb2l6VzCA0X2HoLhjIY7qSPU=
X-Gm-Gg: ASbGncvCdxoCbu4UPQUP5aEVPhDEPLKDgAFAd9S+JM9+D+UUSvMAeVw5EDsr6cVKgFn
 +VSOvRQ8iXtfK2bX1CkxLPCsXlhnwOL1uvHQ0VTokZ6Q+WlCmhyLA/fd9hN3dM3MX4a8fuGL8LL
 uK7eML10pWh95yq5GGcBVeeFJO5HK/jFjBdMnNRhTNBH+/Fxg5K9h6rm8KOQv0YQzfC/r+In8+q
 3mACGLqgOMmT5tSQ1wV4Rv0nGN3yUON601N+lNfaPwLMWPPiBSB9kk+Fgy107lyORw=
X-Google-Smtp-Source: AGHT+IHJaa80E/5ywu0j9w/Dsawlbaj+hrdQvBdvCdi7jBETshOtnyjtFQBxyDrSHb5k9d+LrAKGoQ==
X-Received: by 2002:a17:902:d50c:b0:21a:8dec:e59f with SMTP id
 d9443c01a7336-21c355c28f0mr198949515ad.39.1737464534556; 
 Tue, 21 Jan 2025 05:02:14 -0800 (PST)
Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89])
 by smtp.gmail.com with ESMTPSA id
 d9443c01a7336-21c2d3a8543sm76887185ad.124.2025.01.21.05.02.12
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 21 Jan 2025 05:02:13 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
In-Reply-To: <87jzaoa7hi.fsf@HIDDEN> (Arnaud Daby-Seesaram's message of
 "Tue, 21 Jan 2025 09:36:41 +0100")
References: <7743f403ebf1693fc386a397e9aed1975b43f900.1735323486.git.45mg.writes@HIDDEN>
 <cover.1736423822.git.45mg.writes@HIDDEN>
 <875xmo11ys.fsf@HIDDEN> <87jzb3zzqm.fsf@HIDDEN>
 <87o703hlk9.fsf@HIDDEN> <87jzaoai9k.fsf@HIDDEN>
 <87jzaoa7hi.fsf@HIDDEN>
Date: Tue, 21 Jan 2025 22:02:03 +0900
Message-ID: <87wmeos4l0.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Arnaud,

Arnaud Daby-Seesaram <ds-ac@HIDDEN> writes:

[...]

> Sorry, I was imprecise.
>
> NetworkManager needs to write to /etc/NetworkManager/system-connections
> The issue with extending etc-service-type was that "/etc/NetworkManager"
> became a link to the store, and thus system-connections could no longer
> be created/written to.
>
> However, the configuration directory is /etc/NetworkManager/conf.d .
>
> What I was proposing was to use file-union to create the configuration
> directory (in the store) and symlink it to /etc/NetworkManager/conf.d .
>
> This is close to what the patch already does.  I merely suggested to
> replace a homemade function by a function of (guix gexp):
> network-manager-configuration-directory and file-union do a similar job
> if I read them correctly.

Oh, I understand now, thank you for explaining.  It seems to make sense
to reuse file-union then.  45mg, do you also agree it makes sense?
If so, could you rework your change to use it and send a v3?

-- 
Thanks,
Maxim

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#75145] [PATCH v2 0/1] services: network-manager: Add extra-configuration-files field.
Resent-From: Attila Lendvai <attila@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 22 Jan 2025 00:18:02 +0000
Resent-Message-ID: <handler.75145.B75145.17375050351948 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75145
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ricardo Wurmus <rekado@HIDDEN>
Cc: guix-devel <guix-devel@HIDDEN>, 45mg <45mg.writes@HIDDEN>, Felix Lechner <felix.lechner@HIDDEN>, "75145 <at> debbugs.gnu.org" <75145 <at> debbugs.gnu.org>
Received: via spool by 75145-submit <at> debbugs.gnu.org id=B75145.17375050351948
          (code B ref 75145); Wed, 22 Jan 2025 00:18:02 +0000
Received: (at 75145) by debbugs.gnu.org; 22 Jan 2025 00:17:15 +0000
Received: from localhost ([127.0.0.1]:58229 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1taOQk-0000VI-I3
	for submit <at> debbugs.gnu.org; Tue, 21 Jan 2025 19:17:15 -0500
Received: from mail-4018.proton.ch ([185.70.40.18]:27777)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <attila@HIDDEN>)
 id 1taOQa-0000Ts-PI
 for 75145 <at> debbugs.gnu.org; Tue, 21 Jan 2025 19:17:11 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lendvai.name;
 s=protonmail3; t=1737505017; x=1737764217;
 bh=33Tg6DRa5cyYRtPhNHicW3us9gN0ylefEfUDT49Yrmg=;
 h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
 Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
 Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;
 b=bFeDTEIJir9tru0ZuI1tXC7r3+jJEwMc8flSnRRxMbcaNjQi4kzoJzYstVqiFy6+z
 KdKOAIGOoURLV0iTH/mdY75pN8cyUVJlgnYLFp5rHmLOSjc2hQNlgW0lnq58Mdhj6Y
 Vhp1N3KTa7WkMPDRbHxAK6PVYefUANl7DlQBjCnETn8AcOekAisS1S3hM7N99cWXSW
 uXq/Fk4yAa/XtBDv1eyjV9vPRA+ToRK6+iAVPf4jQAXuH77b0YRgjAbxEtlsHeUvsH
 Zbjhpyzn4ML0bLyL71UrB53cH2YFi2nQwdmo98xpKapcnPKnPBMp7GP3t2g9Scv9HS
 kmggtDEndVnBA==
Date: Wed, 22 Jan 2025 00:16:50 +0000
From: Attila Lendvai <attila@HIDDEN>
Message-ID: <-h5Hwm4p6WeQ3B3qCJhnwYCYoEaXv4VWcwJqKPg9nRslB2HPIsFsdXDJrssm_2_xkycfn8YTsVvyn3jnpb02m8gdSv-LnbDqu7A62WMbXho=@lendvai.name>
In-Reply-To: <87ldv9fas8.fsf@HIDDEN>
References: <7743f403ebf1693fc386a397e9aed1975b43f900.1735323486.git.45mg.writes@HIDDEN>
 <cover.1736423822.git.45mg.writes@HIDDEN> <87seprdbnv.fsf@HIDDEN>
 <QT6_4dMIPg29JWMoiMYCRq_GP98T2qfwNEctUHh0f21jO7TnR864v_1P9ntIfLFpKRUcR6CN6LXPSPwcdXhlya7e73qoYO9aNWNMxRljGmM=@lendvai.name>
 <87jzayk95m.fsf@HIDDEN>
 <aHnXXMTRpTEKwchU2tjCKh6sjTnh95IQHWz6zStXqCmHl06EJxj55Q0pSGd0iEMTnb33vTbmctdtwWzkXQKopuvD4hjO3d6xJ-RyPOHc2Lc=@lendvai.name>
 <87ldv9fas8.fsf@HIDDEN>
Feedback-ID: 28384833:user:proton
X-Pm-Message-ID: 46702346d530f3fdc9603f4ca9eb93040e59b647
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

> I would advise against running a multitude of personal channels in favor
> of collaborating with others on a much smaller number of channels -- and


i agree. i meant to use the expression 'let a thousand flowers bloom' to be=
 more about freedom and (friendly) competition, not the actual number.


> ideally as a team in Guix itself.


i don't think that will ever be satisfying because it's not facilitating th=
e division of labor, which requires delegating responsibility (aka freedom)=
, which in turn requires isolated parts of the system with isolated consequ=
ences.

there's no reason that the same set of people, or the same level of "securi=
ty clearance" should be needed for the core guix tools, and e.g. updating t=
he packages of the python ecosystem, or updating gnome.

i'm not saying it's easy to draw such demarcation lines. what i'm trying to=
 say here is that i don't see any discussion or at least some wishful think=
ing that it could/should be like that.

and meanwhile there's a clear bottleneck at the center, no matter how much =
we talk about consensus and equality... at the end of the day a commit bit =
is a commit bit (which is ok, because it couldn't work any other way).

--
=E2=80=A2 attila lendvai
=E2=80=A2 PGP: 963F 5D5F 45C7 DFCD 0A39
--
=E2=80=9CSince olden times conscience has been understood by many people le=
ss as a psychic function than as a divine intervention; indeed, its dictate=
s were regarded as [=E2=80=A6] the voice of God. This view shows what value=
 and significance were, and still are, attached to the phenomenon of consci=
ence [=E2=80=A6] Conscience [=E2=80=A6] commands the individual to obey his=
 inner voice even at the risk of going astray.=E2=80=9D
=09=E2=80=94 Carl Jung (1875=E2=80=931961), 'Civilization in Transition'

Message sent to ludo@HIDDEN, maxim.cournoyer@HIDDEN, guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#75145] [PATCH v3] services: network-manager: Add extra-configuration-files field.
Resent-From: 45mg <45mg.writes@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: ludo@HIDDEN, maxim.cournoyer@HIDDEN, guix-patches@HIDDEN
Resent-Date: Sat, 01 Feb 2025 19:52:01 +0000
Resent-Message-ID: <handler.75145.B75145.173843950514202 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75145
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 75145 <at> debbugs.gnu.org
Cc: Arnaud Daby-Seesaram <ds-ac@HIDDEN>, 45mg <45mg.writes@HIDDEN>, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
X-Debbugs-Original-Xcc: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Received: via spool by 75145-submit <at> debbugs.gnu.org id=B75145.173843950514202
          (code B ref 75145); Sat, 01 Feb 2025 19:52:01 +0000
Received: (at 75145) by debbugs.gnu.org; 1 Feb 2025 19:51:45 +0000
Received: from localhost ([127.0.0.1]:60076 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1teJWr-0003gu-Ae
	for submit <at> debbugs.gnu.org; Sat, 01 Feb 2025 14:51:45 -0500
Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]:61792)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <45mg.writes@HIDDEN>)
 id 1teJWl-0003gc-QT
 for 75145 <at> debbugs.gnu.org; Sat, 01 Feb 2025 14:51:43 -0500
Received: by mail-pl1-x643.google.com with SMTP id
 d9443c01a7336-21669fd5c7cso53725125ad.3
 for <75145 <at> debbugs.gnu.org>; Sat, 01 Feb 2025 11:51:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1738439493; x=1739044293; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=JRJSkwr1N2/DEjqSkjEQlvi+8vAwTv0rlVVKqTI9XIw=;
 b=GS8gvko9cqGuRHXFGsovPnQcaAcnFWLAEl58Xw/Pcp9y1B+O9Khk3p3fF3LHJsyZi2
 4tQPZCMOtTs5E1/hHZ94TFgNk0PrlsiIXNwvj7ej+lYZZMvO92dpPPSaX6lbAu4FI9qd
 otWrM2fKSWQopjOyMUotj9MKNyk69qWHh4srjNlhjf+t7Qx0kIvGIy8UqA2Jfp9klq5X
 ghLBgL0+DuCCpcFLxss0OCNfcUoUJTTaHBQeQKxIA5+XfR9EmQrEQHNjcFMRE18hWgDM
 owc0MECxYCpzystbI3sN/TdqjUT6DdGzpDvK+wy8V+N3AvKMSomQQJBRkO+Wfsdfky+T
 OwLg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1738439493; x=1739044293;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=JRJSkwr1N2/DEjqSkjEQlvi+8vAwTv0rlVVKqTI9XIw=;
 b=rtZDJiav1MnRhWAZEWHnOn34GcRFACFtDdBhv+wr+diVVDl5bvHNRHNkO1KlVqUKSN
 SySdn81fvpHLhxNg6TxHiiwE/NXZ0nZ/6nwmFg+vCVl/iWhLEacx6poSxdfJoUF4GmD5
 aZd46Dw6ukXaT76CVaEUx/OqSDE9mOZ7mHAYZal8AKCnVJeKndrLGMMKA7j7e5PrhzKe
 /IvZw+U2fVPAq8nqOUwN/LmX4gvi2dx6ISqJc+gYfKcRRWeJPoVo+96wSYtPOjaEcN23
 PnKzW55O9XNQ4NV/fc13Ucc9iZLUZSbeM8QT1VooNvcTDqmEoZC0NTv+zqvlRJ46UEW8
 8cNg==
X-Gm-Message-State: AOJu0YzCYldIojwmSTRYmCibiHa/DXXlJ+Oww3RHaas6VtF/moK2Wjk0
 PvHMVvFRwUcvyhHeN0ZdCLqQb+YOpZuIqrJSbn3E8AWL8mpdzsbygDvrdqfs
X-Gm-Gg: ASbGncsF/5OGBjrCOO1fEPMHAE22KIj4A6WPSo+V2o3qqONHzH9RiDi0HG9HyKxkDN/
 vV/oQePMPWOjBALSKZ3xMatqO+FAgC7UiOgiOAd8FuSfaBRzaSkWc3iNGfTk0QfKh02CQ7DRE8E
 lGFj57MqpTakyN8H4BhEieB69L2ESrXSbVa6vbEQP7YH0QcaABGMwZmPCRTztVtQqNXfJhYieSz
 snvJ9TeKS2nfc4YP6yPXMus151Uh45uok4B9fwkqYEog0elRzym1Qhq0HEiJHGIwR7vnOcJcX7m
 VawmQ5ymFdPS0Sq6J/BvQvX6yNP8loB1Z/9axA==
X-Google-Smtp-Source: AGHT+IFbT+rXtk2fyAREZLOp2F3EUUcexEmW51jyJM7zkQIRx6ZSeQNjU/C8fpS653c3jWgxSeLotA==
X-Received: by 2002:a05:6a00:1396:b0:725:db34:6a7d with SMTP id
 d2e1a72fcca58-72fd0c7c6c5mr23351201b3a.23.1738439493128; 
 Sat, 01 Feb 2025 11:51:33 -0800 (PST)
Received: from localhost.localdomain (utm3.nitt.edu. [14.139.162.2])
 by smtp.gmail.com with ESMTPSA id
 d2e1a72fcca58-72fe69cebbcsm5482856b3a.130.2025.02.01.11.51.30
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 01 Feb 2025 11:51:32 -0800 (PST)
From: 45mg <45mg.writes@HIDDEN>
Date: Sun,  2 Feb 2025 01:19:26 +0530
Message-ID: <b165980dd5f8ec513a391aa50818692461e44a80.1738439366.git.45mg.writes@HIDDEN>
X-Mailer: git-send-email 2.48.1
In-Reply-To: <87wmeos4l0.fsf@HIDDEN>
References: <87wmeos4l0.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Allow users to specify additional configuration files for
NetworkManager. These files will be added to
`/etc/NetworkManager/conf.d` (NetworkManager's default configuration
directory location).

* gnu/services/networking.scm (<network-manager-configuration>)
[extra-configuration-files]: New field.
(network-manager-activation): Honor the new field.
* doc/guix.texi (Networking Setup): Document the new field.

Change-Id: I07479958e4d0aa318328c666a9630b779230b300
---
 doc/guix.texi               | 21 +++++++++++++++++++++
 gnu/services/networking.scm | 13 +++++++++++--
 2 files changed, 32 insertions(+), 2 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index b1b6d98e74..58ce4663c3 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -21541,6 +21541,27 @@ Networking Setup
 (VPNs).  An example of this is the @code{network-manager-openvpn}
 package, which allows NetworkManager to manage VPNs @i{via} OpenVPN.
 
+@item @code{extra-configuration-files} (default: @code{'()})
+An alist of file names to file-like objects, representing configuration
+files which will be added to @file{/etc/NetworkManager/conf.d}.
+NetworkManager will read additional configuration from this directory.
+For details on configuration file precedence and the configuration file
+format, see the @command{NetworkManager.conf(5)} man page.
+
+For example, to add two files @file{001-basic.conf} and
+@file{002-unmanaged.conf}:
+
+@lisp
+(service network-manager-service-type
+         (network-manager-configuration
+          (extra-configuration-files
+           `(("existing-file" ,(local-file "001-basic.conf"))
+             ("constructed-file" ,(plain-file "002-unmanaged.conf"
+                                              "[keyfile]
+unmanaged-devices=interface-name:wlo1_ap
+"))))))
+@end lisp
+
 @end table
 @end deftp
 
diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm
index af28bd0626..4e455cc114 100644
--- a/gnu/services/networking.scm
+++ b/gnu/services/networking.scm
@@ -23,6 +23,7 @@
 ;;; Copyright © 2023 Bruno Victal <mirai@HIDDEN>
 ;;; Copyright © 2023 muradm <mail@HIDDEN>
 ;;; Copyright © 2024 Nigko Yerden <nigko.yerden@HIDDEN>
+;;; Copyright © 2025 45mg <45mg.writes@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1253,18 +1254,26 @@ (define-record-type* <network-manager-configuration>
                (default '()))
   (iwd? network-manager-configuration-iwd?  ; TODO: deprecated field, remove.
         (default #f)
-        (sanitize warn-iwd?-field-deprecation)))
+        (sanitize warn-iwd?-field-deprecation))
+  (extra-configuration-files network-manager-configuration-extra-configuration-files
+                             (default '())))  ;alist of file names to file-like objects
 
 (define (network-manager-activation config)
   ;; Activation gexp for NetworkManager
   (match-record config <network-manager-configuration>
-    (network-manager dns vpn-plugins)
+                (network-manager dns vpn-plugins extra-configuration-files)
     #~(begin
         (use-modules (guix build utils))
         (mkdir-p "/etc/NetworkManager/system-connections")
         #$@(if (equal? dns "dnsmasq")
                ;; create directory to store dnsmasq lease file
                '((mkdir-p "/var/lib/misc"))
+               '())
+        #$@(if extra-configuration-files
+               `((symlink
+                  ,(file-union "network-manager-configuration-directory"
+                               extra-configuration-files)
+                  "/etc/NetworkManager/conf.d"))
                '()))))
 
 (define (vpn-plugin-directory plugins)

base-commit: b85d20e853192a92093cd8d6a5756ec80e94c658
-- 
2.48.1

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#75145] [PATCH v3] services: network-manager: Add extra-configuration-files field.
Resent-From: Arnaud Daby-Seesaram <ds-ac@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 01 Feb 2025 23:37:01 +0000
Resent-Message-ID: <handler.75145.B75145.17384529941162 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75145
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 45mg <45mg.writes@HIDDEN>
Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, 75145 <at> debbugs.gnu.org
Received: via spool by 75145-submit <at> debbugs.gnu.org id=B75145.17384529941162
          (code B ref 75145); Sat, 01 Feb 2025 23:37:01 +0000
Received: (at 75145) by debbugs.gnu.org; 1 Feb 2025 23:36:34 +0000
Received: from localhost ([127.0.0.1]:60431 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1teN2P-0000Ig-HT
	for submit <at> debbugs.gnu.org; Sat, 01 Feb 2025 18:36:33 -0500
Received: from nanein.fr ([185.230.78.41]:56212)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <ds-ac@HIDDEN>) id 1teN2N-0000IM-CT
 for 75145 <at> debbugs.gnu.org; Sat, 01 Feb 2025 18:36:32 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nanein.fr; s=mail;
 t=1738452684; bh=as/UVt+O7+8fFYdn1hk81fvI8d0uTlNusKH89+KGLJs=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=J47b8nQ8P0POqk0eMKYvZ2Pfq9YA0tvQ3UlbaefWXoY1adPbou0u5xi/oiJtwydsa
 H2ADba9ITrwMS1j2EXiQemed0cIE5bp3FLaYsYgUif1N5eXqq/QDPn4RSFrqlz7xce
 3g8Z662VvacNQCH5tjaYHNX7fz/5ZcvTYLjwLY7rAUa8u4Ej+lOufsR5UUKipeBMkK
 UUq8h9yDXwITFOzr1OWBdeDuG9t/77AF/FUX22K7lE8nJV9in42qMg/33FDPsuZZhp
 sfT2MvAO7zLT2Fe4vuguRw/mriVRtA7Sa7KJDBy46TxBrKED44NTiKA0X6Eti+frnU
 Ev3ihy7PWf8DYcEnOaWy2hGX4pm/5xZ1BdW+0dJgpuYqe4NF0lEFfRPiluzRF+VBKD
 uAbHQanePOUkAclI+WPnAbYTYmHNbyr9G7b+mYYI7M2K2Ks+p0l09fEZWeEtiI0zFL
 EbSCk1XrdVh8EJmWyLe8H1HAolD+aFYIgKGrgwwRZHj/13CbeEKM8IgQpu6jRMQNJx
 /qpyc+tYKvrH8tZNN4tjvN5kWBCqiTqmxj/3RUdOISz7tbEay2ddCT/Vcq4YAkAeJK
 GEbbJCSukuzM3wFFk2fSeCmr3df49++P8s8wSJbUw5IQBYXO4ZN/RQF/oNiXgf2i4b
 PDTysdm7l0a/FJoRAvFZmkOY=
Received: from cochea (wg.nanein.fr [IPv6:2a0c:700:12:50:1::109])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1)
 server-digest SHA256) (No client certificate requested)
 by nanein.fr (Postfix) with ESMTPSA id 192CF1401EC;
 Sun,  2 Feb 2025 00:31:24 +0100 (CET)
From: Arnaud Daby-Seesaram <ds-ac@HIDDEN>
In-Reply-To: <b165980dd5f8ec513a391aa50818692461e44a80.1738439366.git.45mg.writes@HIDDEN>
 (45mg.writes@HIDDEN's message of "Sun, 2 Feb 2025 01:19:26 +0530")
References: <87wmeos4l0.fsf@HIDDEN>
 <b165980dd5f8ec513a391aa50818692461e44a80.1738439366.git.45mg.writes@HIDDEN>
User-Agent: mu4e 1.12.8; emacs 29.4
Date: Sun, 02 Feb 2025 00:31:16 +0100
Message-ID: <871pwhs0mz.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

Thank you for the v3.  I just have two minor comments.


45mg <45mg.writes@HIDDEN> writes:

> @@ -1253,18 +1254,26 @@ (define-record-type* <network-manager-configurati=
on>
>                 (default '()))
>    (iwd? network-manager-configuration-iwd?  ; TODO: deprecated field, re=
move.
>          (default #f)
> -        (sanitize warn-iwd?-field-deprecation)))
> +        (sanitize warn-iwd?-field-deprecation))
> +  (extra-configuration-files network-manager-configuration-extra-configu=
ration-files
> +                             (default '())))  ;alist of file names to fi=
le-like objects
>=20=20
>  (define (network-manager-activation config)
>    ;; Activation gexp for NetworkManager
>    (match-record config <network-manager-configuration>
> -    (network-manager dns vpn-plugins)
> +                (network-manager dns vpn-plugins extra-configuration-fil=
es)
>      #~(begin
>          (use-modules (guix build utils))
>          (mkdir-p "/etc/NetworkManager/system-connections")
>          #$@(if (equal? dns "dnsmasq")
>                 ;; create directory to store dnsmasq lease file
>                 '((mkdir-p "/var/lib/misc"))
> +               '())
> +        #$@(if extra-configuration-files
> +               `((symlink
> +                  ,(file-union "network-manager-configuration-directory"
> +                               extra-configuration-files)
> +                  "/etc/NetworkManager/conf.d"))
>                 '()))))

If I understand, the `if' is here to avoid creating a symbolic link to
an empty directory: if no extra configuration files are provided, do not
symlink.  However, in Guile, it seems that (if '() 'yes 'no) evaluates
to 'yes.  Therefore, the symlink is always created.  A solution is to
use `pair?':
=2D-8<---------------cut here---------------start------------->8---
        #$@(if (pair? extra-configuration-files)
               `((symlink
                  ,(file-union "network-manager-configuration-directory"
                               extra-configuration-files)
                  "/etc/NetworkManager/conf.d"))
               '()))))
=2D-8<---------------cut here---------------end--------------->8---

Apologies, I should have realised that before my first review.


> +@item @code{extra-configuration-files} (default: @code{'()})
> +An alist of file names to file-like objects, representing configuration
> +files which will be added to @file{/etc/NetworkManager/conf.d}.
> +NetworkManager will read additional configuration from this directory.
> +For details on configuration file precedence and the configuration file
> +format, see the @command{NetworkManager.conf(5)} man page.

I am not sure that "alist" is the correct term.  When I hear alist, I
think of something of the form
((key-1 . val-1)
 ...
 (key-n . val-n))

The documentation of `file-union' uses the term "two-element list" for
its argument.  Maybe it would be more precise to do the same (I am not
very opinionated on this).


Best regards,

=2D-=20
Arnaud

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCgAuFiEEMgqfJ4U0fby1t860ojLKXoMTiAwFAmeersUQHGRzLWFjQG5h
bmVpbi5mcgAKCRCiMspegxOIDO5CD/429bWN+kZ+PH1j4QUapjHeiyCczN+yjlh6
JnqPqBMI43zaBgXZYSAjfmQKaeMHZWz1VLO+iab1OMLs9e4vcuoHLPrlIT0CjGAd
UIqWRwAda1OIDbP2qBGUFh749X+x/CWtpCBPZna4CIWFLtGpr3OnKoTiPObgKbuv
fEMmCtkvBqbllVjhIw8uCDIy6RjwZ+n5u+E8aAWGRuP3WcF8k5fuKl6Gu5mDXZwo
cguXLUFETbePf+vST0nNzg12svz4Sld17OlSfFpmc253GIFAsysWgTgwxZFWDfQM
fWKW+2esHUL1AfiXUSZ0mtKnIhBFLGyF3xZxg1Fpt89HZNBfigOacfy2+OCZORCN
9e/U9Dh+yCCwNdxHVEwCcm1CMgAyCwIvVVP0VgpFN6DqoVwisMF1uKU6GslQm27e
mWvcTl+4+1MRtLn3MFP52l8rG6Gur6R4nDeF0tAW2xurR6Whl8dj0cIrUh/h/oL5
jrb6CFbIzWyBaq4Y1w3uDnH7AMt8foOpBbCmX5OZWy4QERoxbs28c+ha6/jaUE3t
wfFzl1lmPtwlfqsJpWfhzJyIqWGzYv2Vz5Ch9TEhDBBp31m7qnhcJf0dOIV78aeE
fHiWH/4Pwu3Q8ESkJytarGvjJvOD2dIL91xSjf4l5kaUrfRz2I+0dkBZr5OOnXRs
KgYrewIgIw==
=osrN
-----END PGP SIGNATURE-----
--=-=-=--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#75145] [PATCH v3] services: network-manager: Add extra-configuration-files field.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 02 Feb 2025 06:48:01 +0000
Resent-Message-ID: <handler.75145.B75145.173847883925223 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75145
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Arnaud Daby-Seesaram <ds-ac@HIDDEN>
Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, 45mg <45mg.writes@HIDDEN>, 75145 <at> debbugs.gnu.org
Received: via spool by 75145-submit <at> debbugs.gnu.org id=B75145.173847883925223
          (code B ref 75145); Sun, 02 Feb 2025 06:48:01 +0000
Received: (at 75145) by debbugs.gnu.org; 2 Feb 2025 06:47:19 +0000
Received: from localhost ([127.0.0.1]:32792 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1teTlH-0006Yl-41
	for submit <at> debbugs.gnu.org; Sun, 02 Feb 2025 01:47:19 -0500
Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]:50188)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1teTlF-0006YO-8P
 for 75145 <at> debbugs.gnu.org; Sun, 02 Feb 2025 01:47:17 -0500
Received: by mail-pj1-x102f.google.com with SMTP id
 98e67ed59e1d1-2f42992f608so4483832a91.0
 for <75145 <at> debbugs.gnu.org>; Sat, 01 Feb 2025 22:47:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1738478831; x=1739083631; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=wITz1IRpN4DYjj9qV/X4iwCq7iWVWo9gKmFFNV4arSQ=;
 b=gneesfTFHHrYKZnFs8iWpJ0dzpauEIemEMlQNmJd+SQGCAqb/tFl3ee36bgJiBkUMU
 lrtKF/+fChGAsTFrkLlFT8uyrpGvIxfJp05JNAuXJqUtAE08YuF44rlK7xPof7HeSgpU
 9l70TddXmuScd025ngvfOho+od0ryrQ814InLWiezGrh/15MXNWIC0H1ZMmrerCKYnPS
 kyYwr16eUGsWK3sVCCuMSKfgW3wWITXPGgTa3Tqdzjw0csbVfFn3SZdKtqCzOLUURs0a
 Lx2LnII3f2PLSmnHOhLeC7nHtDkqrpY4VX0pg8qP+YB5D3eLwh9zcj0Ieg4MyOjeF3Le
 UDtA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1738478831; x=1739083631;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=wITz1IRpN4DYjj9qV/X4iwCq7iWVWo9gKmFFNV4arSQ=;
 b=bRAchf2kKRNS+64Ssqg6DYTH3D4HHpRxkvbkd8cHA3We/1C3tHJPZt49KwJaiDVzTr
 K1QTTcEAMhFqY/aGamqcVkTf/EDV3b11TZG8uMMS7RKtVeSMN07qoZ6Iyd084E+ZAg1L
 Ll4rzk6clfP8MXgMKztajws2PzsZ6PzKUE0T5UcASFXarCNlJzidni0J8yml7kpqFmWD
 TwRzwv7t7gs8gCmWISObRPC1/hapVLxbAWV8MkaAKPpZYsH+OGDGrkJ2DbqCse/x9bhm
 uG6dVfY2pta3vOY1N5HoZ4QT8ujIgfAaEg5ULbbpnnXIVwEytqChMPktQnA2JqVwiiIx
 A4xg==
X-Forwarded-Encrypted: i=1;
 AJvYcCX+3q2zCeRBlkn/ynPjaSEMr59wxpHyUf8z9l+9PRgsQ6GKw1e7M1bjeID8ujMBNmTVVNCQow==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YyiZ/5Cw1H+vEtXMHdPmEB7g8ysUDJtaV2DuLfXen1dTOX58zTH
 wcvdrQn0/BcKxOE88xXw6vI5ykXFDYugKi/tl+T6id0MNjSAYnaT
X-Gm-Gg: ASbGncvlxWWES+dvOd2NsVWzgYcvgMtSnq81pzqroxLi3RYQisGTYAsX0AsT32Li+Wp
 JVerxUwLutynCn7VtI5iXlQlzCRP4qAckOkacR5qmmWAiTsfw8syjwS+D9hEnh0bOEssawDLgig
 QlL2OhyIJJ96NBc0jf4P/IucWwk5j+BHkR+TfnUMiKiGqvgs8ecjWigtVEGc8FfphnwoupX9rXy
 E/sJTf/1ePTOIkzIOy7e1Rf32ltlNFCTJl7MdBwGTgwFeddvStPpBKqyODtXKhvSJpEkYq1Kwuy
 tSeE0gdW71OY
X-Google-Smtp-Source: AGHT+IGuH/AMOqpOxneDiG89o1LspsqHrKtgaKa+O7EwhDGfA9zFjm42XdS1Z/DEz7oVFIr6P0Fh4A==
X-Received: by 2002:a17:90b:2583:b0:2ee:a04b:92d3 with SMTP id
 98e67ed59e1d1-2f83ac8c4b9mr21797114a91.34.1738478830958; 
 Sat, 01 Feb 2025 22:47:10 -0800 (PST)
Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89])
 by smtp.gmail.com with ESMTPSA id
 98e67ed59e1d1-2f8489d65a2sm7220842a91.29.2025.02.01.22.47.08
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 01 Feb 2025 22:47:10 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
In-Reply-To: <871pwhs0mz.fsf@HIDDEN> (Arnaud Daby-Seesaram's message of
 "Sun, 02 Feb 2025 00:31:16 +0100")
References: <87wmeos4l0.fsf@HIDDEN>
 <b165980dd5f8ec513a391aa50818692461e44a80.1738439366.git.45mg.writes@HIDDEN>
 <871pwhs0mz.fsf@HIDDEN>
Date: Sun, 02 Feb 2025 15:46:57 +0900
Message-ID: <87bjvkkfmm.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Arnaud,

Arnaud Daby-Seesaram <ds-ac@HIDDEN> writes:

> Hi,
>
> Thank you for the v3.  I just have two minor comments.
>
>
> 45mg <45mg.writes@HIDDEN> writes:
>
>> @@ -1253,18 +1254,26 @@ (define-record-type* <network-manager-configuration>
>>                 (default '()))
>>    (iwd? network-manager-configuration-iwd?  ; TODO: deprecated field, remove.
>>          (default #f)
>> -        (sanitize warn-iwd?-field-deprecation)))
>> +        (sanitize warn-iwd?-field-deprecation))
>> +  (extra-configuration-files network-manager-configuration-extra-configuration-files
>> +                             (default '())))  ;alist of file names to file-like objects
>>  
>>  (define (network-manager-activation config)
>>    ;; Activation gexp for NetworkManager
>>    (match-record config <network-manager-configuration>
>> -    (network-manager dns vpn-plugins)
>> +                (network-manager dns vpn-plugins extra-configuration-files)
>>      #~(begin
>>          (use-modules (guix build utils))
>>          (mkdir-p "/etc/NetworkManager/system-connections")
>>          #$@(if (equal? dns "dnsmasq")
>>                 ;; create directory to store dnsmasq lease file
>>                 '((mkdir-p "/var/lib/misc"))
>> +               '())
>> +        #$@(if extra-configuration-files
>> +               `((symlink
>> +                  ,(file-union "network-manager-configuration-directory"
>> +                               extra-configuration-files)
>> +                  "/etc/NetworkManager/conf.d"))
>>                 '()))))
>
> If I understand, the `if' is here to avoid creating a symbolic link to
> an empty directory: if no extra configuration files are provided, do not
> symlink.  However, in Guile, it seems that (if '() 'yes 'no) evaluates
> to 'yes.  Therefore, the symlink is always created.  A solution is to
> use `pair?':
>
>         #$@(if (pair? extra-configuration-files)
>                `((symlink
>                   ,(file-union "network-manager-configuration-directory"
>                                extra-configuration-files)
>                   "/etc/NetworkManager/conf.d"))
>                '()))))
>
> Apologies, I should have realised that before my first review.

That's fine, and good catch!

>> +@item @code{extra-configuration-files} (default: @code{'()})
>> +An alist of file names to file-like objects, representing configuration
>> +files which will be added to @file{/etc/NetworkManager/conf.d}.
>> +NetworkManager will read additional configuration from this directory.
>> +For details on configuration file precedence and the configuration file
>> +format, see the @command{NetworkManager.conf(5)} man page.
>
> I am not sure that "alist" is the correct term.  When I hear alist, I
> think of something of the form
> ((key-1 . val-1)
>  ...
>  (key-n . val-n))
>
> The documentation of `file-union' uses the term "two-element list" for
> its argument.  Maybe it would be more precise to do the same (I am not
> very opinionated on this).

Indeed, I think a list of pure lists (rather than pair) cannot be called
an association list (alist), as that shoud be made up of pairs (using
cons or the dot notation).

See info '(guile) Association Lists'.

Thank you for the review!

45mg, would you mind sending a v4?

-- 
Maxim

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#75145] [PATCH v4] services: network-manager: Add extra-configuration-files field.
Resent-From: 45mg <45mg.writes@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 12 Feb 2025 09:58:02 +0000
Resent-Message-ID: <handler.75145.B75145.173935427914591 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75145
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 75145 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Arnaud Daby-Seesaram <ds-ac@HIDDEN>
Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, 45mg <45mg.writes@HIDDEN>
Received: via spool by 75145-submit <at> debbugs.gnu.org id=B75145.173935427914591
          (code B ref 75145); Wed, 12 Feb 2025 09:58:02 +0000
Received: (at 75145) by debbugs.gnu.org; 12 Feb 2025 09:57:59 +0000
Received: from localhost ([127.0.0.1]:32768 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ti9VH-0003nG-6w
	for submit <at> debbugs.gnu.org; Wed, 12 Feb 2025 04:57:59 -0500
Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]:44475)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <45mg.writes@HIDDEN>)
 id 1ti9VC-0003mu-Om
 for 75145 <at> debbugs.gnu.org; Wed, 12 Feb 2025 04:57:56 -0500
Received: by mail-pl1-x642.google.com with SMTP id
 d9443c01a7336-21f5268cf50so73085855ad.1
 for <75145 <at> debbugs.gnu.org>; Wed, 12 Feb 2025 01:57:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1739354268; x=1739959068; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=uqYGo+XH4pkSidEvoL1fTi7/+d+Q3BkzVDLcG/RsWnM=;
 b=ILjZkVDP/0305dcvZ4BzZ5dLTUgv3CIycsj6CTzq6ubA/Hc3kgHEs3gBPoYpyG0ZCs
 sUH5SAl8uKcMappyw13NdEKksUdtUVf87lyVPjaYDVn9H7YVszxVWXMkV4IeXr6+lJUd
 hlpN2GrLoF1Y0YJ9s+SPrkxwwqKfOe4PxElSdex5kO7EFtWdic5OLY1kTDzLcXoFSqeS
 /bj7IHpNc4Ncw0FqLfGbZNVKdro01zRN/abSy9MDQB1dZ3r7Ctq2evSLxlT9Pa1wBWDr
 W5ZqicO6uMOHmkT/iFknrK0pJVyfRdP489NrAKmIhOGa3grLtBmleKiDR2+6cpinL7c7
 eTbQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1739354268; x=1739959068;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=uqYGo+XH4pkSidEvoL1fTi7/+d+Q3BkzVDLcG/RsWnM=;
 b=Ik4TdBROT3CRZRv1NNtmhLXfveU2/tOtfVu+M8cRZhvN4k8aDLFhk12VPiaU7FW08z
 +nmPMwWEoGit0ztqj6k2d7bJYnosNoadVoHIZAsI9w511Gbqcidj86duT9DNUXA7yC4V
 hcslCaY0WdPikbpu1J2r65/IHZnxnYTloJOSHRjb+FDf2HhgyUJF9kV559vIkw9FrCvn
 lQxUduIQEfSaLmiIR8buA3qQad/pEcH7wIn/xNvcn2SQRXlAClcbMsdQr++xf9BYyA24
 iz4OhqQ10wlJiv6EzbmsgcAapFSJqgzkn1tXbxs2MDTg5QZLTGIEjt7KxN7ob6Uq+/xC
 s5LA==
X-Gm-Message-State: AOJu0YxyhRbtvTgUWQpcPT8rWtsAnTVYeNFYymC7Regu/4ezS8T7CwP/
 w7iFoTxLQ+tY3+SLg5CciqFlDKgAOBhU5JMcTmJOqC3KpMRQaIE8pCmhRN56
X-Gm-Gg: ASbGnctiK1z9YVLSNAv/hxdkFP+HM4MmzMqYuIdouA3WHPIj/cNP1Cbox9Zw5OnE35M
 KEzBqAApdW8UwgfgxbBTtEHn5nDEtwtPD0yQxH6q0Pn/TfLQpGT+Q436F73X0FlexLvpkPHYHcW
 t43go5uf2NtlotFBEnyhwDxfR5tbXjG/nEDA9hqhahz47ZCNHvoKNE0IZmpQ6E1cwCnE9lTCnAz
 d/L6LZEQT1PpYgyZMlcZPESajZczxX5b+WuwcMZrFaaaRE4mlM7dGhfhX/S06cXDfrCE/jWPj2m
 G5WvxZiNTKf4FwaLaFlfQWpuN8FxlQ3hN8wE4w==
X-Google-Smtp-Source: AGHT+IGGEJuJE7QLd5Y/c6JXDy7f5ezIefe971qXGpBCyqOt/igo7pLlUzf2X8dr4+IeP/PlR69sdw==
X-Received: by 2002:a05:6a21:6f07:b0:1ee:3116:1b66 with SMTP id
 adf61e73a8af0-1ee5e6667bamr4940771637.34.1739354268310; 
 Wed, 12 Feb 2025 01:57:48 -0800 (PST)
Received: from localhost.localdomain (utm3.nitt.edu. [14.139.162.2])
 by smtp.gmail.com with ESMTPSA id
 d2e1a72fcca58-730884f5711sm5648332b3a.9.2025.02.12.01.57.46
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 12 Feb 2025 01:57:48 -0800 (PST)
From: 45mg <45mg.writes@HIDDEN>
Date: Wed, 12 Feb 2025 09:56:42 +0000
Message-ID: <3a2eb3562a02010cbd1bf319561c6d3b22d4ff2a.1739354202.git.45mg.writes@HIDDEN>
X-Mailer: git-send-email 2.48.1
In-Reply-To: <87bjvkkfmm.fsf@HIDDEN>
References: <87bjvkkfmm.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Allow users to specify additional configuration files for
NetworkManager. These files will be added to
`/etc/NetworkManager/conf.d` (NetworkManager's default configuration
directory location).

* gnu/services/networking.scm (<network-manager-configuration>)
[extra-configuration-files]: New field.
(network-manager-activation): Honor the new field.
* doc/guix.texi (Networking Setup): Document the new field.

Change-Id: I07479958e4d0aa318328c666a9630b779230b300
---
 gnu/services/networking.scm | 19 +++----------------
 1 file changed, 3 insertions(+), 16 deletions(-)

diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm
index a5aa86fd43..c93ed58cf5 100644
--- a/gnu/services/networking.scm
+++ b/gnu/services/networking.scm
@@ -23,6 +23,7 @@
 ;;; Copyright © 2023 Bruno Victal <mirai@HIDDEN>
 ;;; Copyright © 2023 muradm <mail@HIDDEN>
 ;;; Copyright © 2024 Nigko Yerden <nigko.yerden@HIDDEN>
+;;; Copyright © 2025 45mg <45mg.writes@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1257,21 +1258,6 @@ (define-record-type* <network-manager-configuration>
   (extra-configuration-files network-manager-configuration-extra-configuration-files
                              (default '())))  ;'((file-name-string file-like-object) ...)
 
-(define (network-manager-configuration-directory extra-configuration-files)
-  "Return a directory containing EXTRA-CONFIGURATION-FILES."
-  (with-imported-modules (source-module-closure '((guix build utils)))
-    (computed-file
-     "network-manager-configuration-directory"
-     #~(begin
-         (use-modules (guix build utils))
-         (mkdir-p #$output)
-         (for-each (lambda (pair)
-                     (let* ((filename (list-ref pair 0))
-                            (file (list-ref pair 1))
-                            (dest (string-append #$output "/" filename)))
-                       (copy-file file dest)))
-                   '#$extra-configuration-files)))))
-
 (define (network-manager-activation config)
   ;; Activation gexp for NetworkManager
   (match-record config <network-manager-configuration>
@@ -1285,7 +1271,8 @@ (define (network-manager-activation config)
                '())
         #$@(if (pair? extra-configuration-files)  ;if non-empty
                `((symlink
-                  ,(network-manager-configuration-directory extra-configuration-files)
+                  ,(file-union "network-manager-configuration-directory"
+                               extra-configuration-files)
                   "/etc/NetworkManager/conf.d"))
                '()))))
 

base-commit: d59a13b6401e7494d8d5c9c9f66df3318451be79
prerequisite-patch-id: 8f30976d00586f571762f6333bf29dd355a64dbb
-- 
2.48.1

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#75145] [PATCH v4] services: network-manager: Add extra-configuration-files field.
Resent-From: 45mg <45mg.writes@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 12 Feb 2025 10:01:01 +0000
Resent-Message-ID: <handler.75145.B75145.173935440815773 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75145
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 45mg <45mg.writes@HIDDEN>, 75145 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Arnaud Daby-Seesaram <ds-ac@HIDDEN>
Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, 45mg <45mg.writes@HIDDEN>
Received: via spool by 75145-submit <at> debbugs.gnu.org id=B75145.173935440815773
          (code B ref 75145); Wed, 12 Feb 2025 10:01:01 +0000
Received: (at 75145) by debbugs.gnu.org; 12 Feb 2025 10:00:08 +0000
Received: from localhost ([127.0.0.1]:32781 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ti9XL-00044t-CP
	for submit <at> debbugs.gnu.org; Wed, 12 Feb 2025 05:00:07 -0500
Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]:47300)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <45mg.writes@HIDDEN>)
 id 1ti9XJ-0003rI-8j
 for 75145 <at> debbugs.gnu.org; Wed, 12 Feb 2025 05:00:06 -0500
Received: by mail-pl1-x643.google.com with SMTP id
 d9443c01a7336-21f48ebaadfso111868095ad.2
 for <75145 <at> debbugs.gnu.org>; Wed, 12 Feb 2025 02:00:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1739354399; x=1739959199; darn=debbugs.gnu.org;
 h=mime-version:message-id:date:references:in-reply-to:subject:cc:to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=Kgy0M7YoxIpI9IarE34Av7POnpd9yr3Hl+eQ8E5ZQ1I=;
 b=Vr6CdMYtGfNRxmWaq94oCTBVwbseOwLkTwDCpg+p0w6q1qndzWt+LRaSNRjCCZXFll
 dApv1NWEl+gGtdlo1ygObDoUs8r5/1f1E+mW88h2vvnXo4Z+0Wj2v5IEJXiGDMKHMc+J
 890P9Nzj4ZiF+KyOuJALFJNB6AX92FEHmVkKWbxH8McPtQZpPHl9mgPrQT8EYHsNs0dk
 +V3z6IVQ/y/aWH7klTw490w6I9kg8YnGUMbofeL8Zp94oQKx2eT4/pECrAAEJJhMsmaw
 L4dVLFXCO/6gsrl1ifY8Xcn7vot/M4gXK/4eu8rQMPbPmB74BX4t3DGm7kzAqpFmS9U0
 NXUA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1739354399; x=1739959199;
 h=mime-version:message-id:date:references:in-reply-to:subject:cc:to
 :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=Kgy0M7YoxIpI9IarE34Av7POnpd9yr3Hl+eQ8E5ZQ1I=;
 b=FVO3vYt4EqdayG3gwSpWHrEJJ0p+Y7luhoL8Bn2yhC7YxL+PFI1q7yv/VZZuOUp6RS
 +21Oq1aKJY6hRjQwld96uHp1Eap/T8DhjNEobN0mTJ5RAVZK/rxdiZOOCXJyQHyikzE8
 MlvS7FGGokGb1CWtYFdXw5QYVUgPuf8EC6Dk2MQ14OIh8XhhzSjBe7luS8ZucbIteXQV
 /WMgRHC8VPWZjItHnj72mptiLX4wllovlYAs+6j8+WTxdsxDw+wOoXybm85HyOBDD7M3
 i3TF54a2/+CeNBtXL8kYB8PVIzWZCD9hGg674YTr+J3gj1k0cPxtES0oqkGeJgrX3pa5
 5JDg==
X-Forwarded-Encrypted: i=1;
 AJvYcCXkUoF92VWaW5YX4ynCgyqx3Cct70pCuD+tjOJhyG2STqwiVBDNW+h9EXz5x56IiQYHICmirQ==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YwM44ijJL7/cXto9Y8Bd2c64l0DytqV6AVDuVJVsZMlBpyfUvbO
 DE66MQl80Ea1izzQ8P8jkfnlsoRaqE9P8DWWfs76tHIaelepFmnt
X-Gm-Gg: ASbGncsDwOjK2zebt2tPJkwNuUCaKfS33dgRlmpikyqliuDMFiILKlxZ5HjFMUr5JVW
 O+UegNrT8JLn50yVvAVVvU82JK8EcRHGvZlqvSGnLKRPBjOjDgBk8g4LWvxf7J9k/WUeWQZYzL4
 dVThn+6sMgczmVyzbVto37Q7nV1vgk3rAALS6KMrtu053OC7jtrxs2Xa3OYHUn1GPdHO7UYMGMh
 VlM3GGomG3Q/RYqNztt/+VCmr/2lOFQ06hBCagvgvK5X+BeR1xDr7RXkInQgJAXtggEml+vpXJF
 BGqLG9b74qgeUcS4
X-Google-Smtp-Source: AGHT+IF25vfhkOi+LZQbrUz+Y+0WH4/HDCUXZ/ZQouEm0zRkyUVmUq1PGy2hp18yYHckixQ/z5720w==
X-Received: by 2002:a05:6a00:23d1:b0:730:99cb:7c32 with SMTP id
 d2e1a72fcca58-7322c380acbmr3461673b3a.7.1739354399165; 
 Wed, 12 Feb 2025 01:59:59 -0800 (PST)
Received: from guix1 (utm3.nitt.edu. [14.139.162.2])
 by smtp.gmail.com with ESMTPSA id
 d2e1a72fcca58-73219ea34acsm2955034b3a.62.2025.02.12.01.59.56
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 12 Feb 2025 01:59:58 -0800 (PST)
From: 45mg <45mg.writes@HIDDEN>
In-Reply-To: <3a2eb3562a02010cbd1bf319561c6d3b22d4ff2a.1739354202.git.45mg.writes@HIDDEN>
References: <87bjvkkfmm.fsf@HIDDEN>
 <3a2eb3562a02010cbd1bf319561c6d3b22d4ff2a.1739354202.git.45mg.writes@HIDDEN>
Date: Wed, 12 Feb 2025 10:00:03 +0000
Message-ID: <87h64zh49o.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Wait - I sent the wrong commit here. Please ignore this; I'll send a v5.

Message sent to ludo@HIDDEN, maxim.cournoyer@HIDDEN, guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#75145] [PATCH v5] services: network-manager: Add extra-configuration-files field.
Resent-From: 45mg <45mg.writes@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: ludo@HIDDEN, maxim.cournoyer@HIDDEN, guix-patches@HIDDEN
Resent-Date: Wed, 12 Feb 2025 10:11:01 +0000
Resent-Message-ID: <handler.75145.B75145.173935504828845 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75145
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 75145 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Arnaud Daby-Seesaram <ds-ac@HIDDEN>
Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, 45mg <45mg.writes@HIDDEN>, Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
X-Debbugs-Original-Xcc: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Received: via spool by 75145-submit <at> debbugs.gnu.org id=B75145.173935504828845
          (code B ref 75145); Wed, 12 Feb 2025 10:11:01 +0000
Received: (at 75145) by debbugs.gnu.org; 12 Feb 2025 10:10:48 +0000
Received: from localhost ([127.0.0.1]:32811 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ti9hg-0007VB-4S
	for submit <at> debbugs.gnu.org; Wed, 12 Feb 2025 05:10:48 -0500
Received: from mail-pj1-x1044.google.com ([2607:f8b0:4864:20::1044]:53676)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <45mg.writes@HIDDEN>)
 id 1ti9ha-0007Us-MH
 for 75145 <at> debbugs.gnu.org; Wed, 12 Feb 2025 05:10:45 -0500
Received: by mail-pj1-x1044.google.com with SMTP id
 98e67ed59e1d1-2fa488351ffso6164223a91.3
 for <75145 <at> debbugs.gnu.org>; Wed, 12 Feb 2025 02:10:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1739355036; x=1739959836; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=IXttwUS6HB+lnrq1XobO0tKyPPRiaHGuhcQB+iGjHIo=;
 b=Ra8dR8u/gHF8Dr/69HATdqsrrVqeGQPm1dU/iVs/dlbcd9MBazy/wfrlqkBW65QsnZ
 /4mYwYlXIn+8NNsvE+lT5yR3XJyMai7vIze7xtBUk3SVvcsMTxjEvyhWToclNSExlKBZ
 95OGVVIpUrRwr83Tby+LQiK1Pa25IYzVdBcVmtXLQqSvz/FezPghyu7+RKcjC+2hGm/+
 DPO+JqiNCpXdinx4LQZS1b5EQ5au6t+eOnBLwNwSlfiXvjjE2l+8wvlOH40sL1IbltWW
 6D3c8FkdsqlwOF6LjpfUNGROBGM3G+U89bn/p86BfnJ70ZDoJm5fgf8tBfs88CHnRLEW
 nzqg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1739355036; x=1739959836;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=IXttwUS6HB+lnrq1XobO0tKyPPRiaHGuhcQB+iGjHIo=;
 b=BVCsXYr3T6YWIkTu33vW3pHiODZnIkvaTgGGuJ7XGZTBlRS7iisVRSclnIdQ1r3bki
 YrvxbspECNSZ6KM00GH4UvrdIlZU3jVfpzVJq0xMiRJIrLLkr2EOyw0M3uyry8j1Ro/Q
 Dygq0UbFjxmEgTH+sD/RD3GJDKj2axwjTKct5HDbBktU+uu4agEM5kYqbHLlE3u0ypnS
 qUCDN61ARuwp7MHm71j5/3YP9HIwxQjpYyd1AfjDqdBk/XCiaxpnSQan3kKD6WtDtVhP
 5ALWGSLI1ZcxDvRos/pkn9PP384p4dUuxfbjoZEz8C0bjfN1h/42mXZrbFyeUbWwXtiq
 7sHQ==
X-Gm-Message-State: AOJu0YxOG1aHR/MNABqaEa4DekDLUdrO96KfiKfcbTjAVfkmxVmUdL3S
 fCBdAUx3VPBLXLGeutlW9+hcn9LMyIfgzqy23ic5VLAxL/pMh3bzvuJFRThC
X-Gm-Gg: ASbGncsQB+GSQXWNIkGcllsP25A6Tyo0ldlGcjocawP12mM47H+eVJ1X5jwV3vU7gGy
 MghMjTWLXksnQ9oI0GbS9+BSGyn+bxZKtoOjRVcZet2MWAMUCtiXTfHayvF5AEMO9sjaejhWdu7
 sZaeVsWDIEpriIiWlspC2a7/J7kXkP3eX0niVbSbp6xYMOHLBzcCEmVBTIqNbN7ht4Ou9bnY/7N
 OZVQUJJASI8mImvmOG4+kerWXgzuvaHYvPMXelmwDIfNHx3L+RZyPs7UCotmej9sI5F2bkZDPuo
 62Vh3j+9ulZQ/JuR2EXTW6zVwTXRI/dI5cV+YQ==
X-Google-Smtp-Source: AGHT+IHrGX7anO5JlnI9o7wP6wOLedhJlSk9jIkEq0cdBwa3tgX6uXw0iEtxcvOOAoyq5vnItgmwAw==
X-Received: by 2002:a17:90b:524b:b0:2ee:a76a:830 with SMTP id
 98e67ed59e1d1-2fbf5c58382mr4230446a91.24.1739355036165; 
 Wed, 12 Feb 2025 02:10:36 -0800 (PST)
Received: from localhost.localdomain (utm3.nitt.edu. [14.139.162.2])
 by smtp.gmail.com with ESMTPSA id
 d9443c01a7336-21f368cf8acsm109916505ad.248.2025.02.12.02.10.33
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 12 Feb 2025 02:10:35 -0800 (PST)
From: 45mg <45mg.writes@HIDDEN>
Date: Wed, 12 Feb 2025 15:39:22 +0530
Message-ID: <33af7378f90f4bea3a4b09fe65ef967edee28433.1739354962.git.45mg.writes@HIDDEN>
X-Mailer: git-send-email 2.48.1
In-Reply-To: <87bjvkkfmm.fsf@HIDDEN>
References: <87bjvkkfmm.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Allow users to specify additional configuration files for
NetworkManager. These files will be added to
`/etc/NetworkManager/conf.d` (NetworkManager's default configuration
directory location).

* gnu/services/networking.scm (<network-manager-configuration>)
[extra-configuration-files]: New field.
(network-manager-activation): Honor the new field.
* doc/guix.texi (Networking Setup): Document the new field.

Change-Id: I07479958e4d0aa318328c666a9630b779230b300
---
 doc/guix.texi               | 23 +++++++++++++++++++++++
 gnu/services/networking.scm | 13 +++++++++++--
 2 files changed, 34 insertions(+), 2 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index ce780682ed..648398ed63 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -21635,6 +21635,29 @@ Networking Setup
 (VPNs).  An example of this is the @code{network-manager-openvpn}
 package, which allows NetworkManager to manage VPNs @i{via} OpenVPN.
 
+@item @code{extra-configuration-files} (default: @code{'()})
+A list of two-element lists; the first element of each list is a file
+name (as a string), and the second is a file-like object.  Used to
+specify configuration files which will be added to
+@file{/etc/NetworkManager/conf.d}.  NetworkManager will read additional
+configuration from this directory.  For details on configuration file
+precedence and the configuration file format, see the
+@command{NetworkManager.conf(5)} man page.
+
+For example, to add two files @file{001-basic.conf} and
+@file{002-unmanaged.conf}:
+
+@lisp
+(service network-manager-service-type
+         (network-manager-configuration
+          (extra-configuration-files
+           `(("existing-file" ,(local-file "001-basic.conf"))
+             ("constructed-file" ,(plain-file "002-unmanaged.conf"
+                                              "[keyfile]
+unmanaged-devices=interface-name:wlo1_ap
+"))))))
+@end lisp
+
 @end table
 @end deftp
 
diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm
index af28bd0626..c93ed58cf5 100644
--- a/gnu/services/networking.scm
+++ b/gnu/services/networking.scm
@@ -23,6 +23,7 @@
 ;;; Copyright © 2023 Bruno Victal <mirai@HIDDEN>
 ;;; Copyright © 2023 muradm <mail@HIDDEN>
 ;;; Copyright © 2024 Nigko Yerden <nigko.yerden@HIDDEN>
+;;; Copyright © 2025 45mg <45mg.writes@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1253,18 +1254,26 @@ (define-record-type* <network-manager-configuration>
                (default '()))
   (iwd? network-manager-configuration-iwd?  ; TODO: deprecated field, remove.
         (default #f)
-        (sanitize warn-iwd?-field-deprecation)))
+        (sanitize warn-iwd?-field-deprecation))
+  (extra-configuration-files network-manager-configuration-extra-configuration-files
+                             (default '())))  ;'((file-name-string file-like-object) ...)
 
 (define (network-manager-activation config)
   ;; Activation gexp for NetworkManager
   (match-record config <network-manager-configuration>
-    (network-manager dns vpn-plugins)
+                (network-manager dns vpn-plugins extra-configuration-files)
     #~(begin
         (use-modules (guix build utils))
         (mkdir-p "/etc/NetworkManager/system-connections")
         #$@(if (equal? dns "dnsmasq")
                ;; create directory to store dnsmasq lease file
                '((mkdir-p "/var/lib/misc"))
+               '())
+        #$@(if (pair? extra-configuration-files)  ;if non-empty
+               `((symlink
+                  ,(file-union "network-manager-configuration-directory"
+                               extra-configuration-files)
+                  "/etc/NetworkManager/conf.d"))
                '()))))
 
 (define (vpn-plugin-directory plugins)

base-commit: d59a13b6401e7494d8d5c9c9f66df3318451be79
-- 
2.48.1

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#75145] [PATCH v5] services: network-manager: Add extra-configuration-files field.
Resent-From: Arnaud Daby-Seesaram <ds-ac@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 12 Feb 2025 14:41:02 +0000
Resent-Message-ID: <handler.75145.B75145.173937122118566 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75145
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 45mg <45mg.writes@HIDDEN>
Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, 75145 <at> debbugs.gnu.org
Received: via spool by 75145-submit <at> debbugs.gnu.org id=B75145.173937122118566
          (code B ref 75145); Wed, 12 Feb 2025 14:41:02 +0000
Received: (at 75145) by debbugs.gnu.org; 12 Feb 2025 14:40:21 +0000
Received: from localhost ([127.0.0.1]:33530 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tiDuW-0004pM-M1
	for submit <at> debbugs.gnu.org; Wed, 12 Feb 2025 09:40:21 -0500
Received: from nanein.fr ([185.230.78.41]:50586)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <ds-ac@HIDDEN>) id 1tiDuT-0004jg-P7
 for 75145 <at> debbugs.gnu.org; Wed, 12 Feb 2025 09:40:18 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nanein.fr; s=mail;
 t=1739371211; bh=UEgMS88C45B5cSJ4Of5NLOnkvuDbZeNCwllBLwJridw=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=RV5IxTee3w3PUgNfdH4BthwSpLW8Manwbx+v6ese1LYGt5SblLAFC/My9pGijNns6
 PRiZybDKj99tNeZDLzkMCryBssylZ2e0df8XXi1arrOFkMcB5vrCYY5993MElZFO1D
 jMF6NXDkN0KMbwA9GowjnvHAXrfxyWuSaznNdMOFYkOMG4s8L4evXIDZwu/Ihjw/pu
 yqLkmKuMi0MnDVkeWiHA/xj9gSM11eeyusYCjtClma2rmu1jJUIRZMz9XbbL5Db4ZR
 CPS/yBVoXGlgoZXnZe5jNummB58LrdH+iPJwJiOdGvzrE+ZRtU+y/EDBuQUQzUy5Z+
 dQ4z78cLlhqTeNDFkoswGIjjb8Ss2sQzNVZaRUexOy5BHaOuyX/gfvH1h6sRY8kn7f
 auoRYl6azaZ353YGiS7DnkP+uxJ2b7J/sObcGDzQJKJrWneUYNxdR23zMI4Er096Vo
 k3d/HmqHiK1inWkFVsChB27Wpx3bkqb7WQTaCSTDlFYd6l1AOXlR5mGFBQy2rUHjqS
 Bfj+B3yxiRfQDyn7EEPPCxsWm+txjZ1XGYWcfrZHYE/wUtlw02DztVcf2pBi+wF2UR
 SgO0u2jfxG/sVdWTIcBts8FkcBoynD8xHlEUhnD9YP53Oj3nCx22spiyasFiPeX132
 RxdWk9cZJAIwG+aniW19SGlg=
Received: from cochea (wg.nanein.fr [IPv6:2a0c:700:12:50:1::109])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1)
 server-digest SHA256) (No client certificate requested)
 by nanein.fr (Postfix) with ESMTPSA id E5DBA1401EC;
 Wed, 12 Feb 2025 15:40:10 +0100 (CET)
From: Arnaud Daby-Seesaram <ds-ac@HIDDEN>
In-Reply-To: <33af7378f90f4bea3a4b09fe65ef967edee28433.1739354962.git.45mg.writes@HIDDEN>
 (45mg.writes@HIDDEN's message of "Wed, 12 Feb 2025 15:39:22 +0530")
References: <87bjvkkfmm.fsf@HIDDEN>
 <33af7378f90f4bea3a4b09fe65ef967edee28433.1739354962.git.45mg.writes@HIDDEN>
User-Agent: mu4e 1.12.8; emacs 29.4
Date: Wed, 12 Feb 2025 15:39:59 +0100
Message-ID: <871pw3i5vk.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi,

Thank you for the v5.  The patch applies cleanly on master, and works as
expected.  I have one remark left (it's the last one, I promise=C2=A0:/).

45mg <45mg.writes@HIDDEN> writes:

> * gnu/services/networking.scm (<network-manager-configuration>)
> [extra-configuration-files]: New field.
> (network-manager-activation): Honor the new field.
> * doc/guix.texi (Networking Setup): Document the new field.
>
> Change-Id: I07479958e4d0aa318328c666a9630b779230b300
> ---
>  doc/guix.texi               | 23 +++++++++++++++++++++++
>  gnu/services/networking.scm | 13 +++++++++++--
>  2 files changed, 34 insertions(+), 2 deletions(-)

=2D the configuration snippet of the documentation indeed adds files with
  the right content and names in /etc/NetworkManager/conf.d,

=2D the directory conf.d is no longer created when empty,

=2D the man page mentioned in the documentation is correct,

=2D last remark (non-blocking):

=2D-8<---------------cut here---------------start------------->8---
     (service network-manager-service-type
              (network-manager-configuration
               (extra-configuration-files
                `(("existing-file" ,(local-file "001-basic.conf"))
                  ("constructed-file" ,(plain-file "002-unmanaged.conf"
                                                   "[keyfile]
     unmanaged-devices=3Dinterface-name:wlo1_ap
     "))))))
=2D-8<---------------cut here---------------end--------------->8---

adds files named "existing-file" and "constructed-file".  This is the
expected behaviour (explained in the doc).  However, the example is
introduced by:

=2D-8<---------------cut here---------------start------------->8---
For example, to add two files =E2=80=98001-basic.conf=E2=80=99 and
=E2=80=98002-unmanaged.conf=E2=80=99:
=2D-8<---------------cut here---------------end--------------->8---

This may seem counter-intuitive to some readers.


Best regards,

=2D-=20
Arnaud

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCgAuFiEEMgqfJ4U0fby1t860ojLKXoMTiAwFAmesssAQHGRzLWFjQG5h
bmVpbi5mcgAKCRCiMspegxOIDBjzD/41lWSORGFlk44czC0vp0ArK0m2tJpKyLZW
+cpnOePpWx3o9TfuxZLrBl6OQ5jzsUI4koggyb4ht0kTbQv8ZySzTGZUSEWLurG1
r1i8yDZA/WotddlKhdPGC0I+IrQNwsvhgM9IHvBnC2DD5nIe0ClyM2yRucgTWDxB
4v9N1MLftRtuG1tmdFU3O/sb9f5KN377DWHO7iwXs4x4N1lvUod82v8x9kB8fnmn
pGg4qpB3LSGqKatJ2/6RFVh+hl6R5HV7t9+yr1f+KByUJVqjZsrclzXcgfIo3BHZ
SmDdzB6vjpidjRZldJPCnoURlib3eH0JXJSu8eIcnW4HOlhJWZ8Z3mOBmSh6GnjZ
4Wgop2TUpeqf5AylxN6iFfE3O31b5cc8Qluw811vknZB2LaCukiO59S17RyUxVaO
vH3DWA3Qp7z0ZEGXaNi/qwwJACSNQZq05aem4GA2jcc6rrwQVRpn5shJx1On1xJR
b1XrtYy1U5D2zinkDak9mayycpj4mNcHztLODvgUxnMe6zUvZ+Dpy47BTAf2m4kq
svD8ortCb1r2cESNWKxKLrnhGnu5hawtO0HF5NX1XZt61jmIHQF4KIwsbSpZqS2y
x6BqgRTzCl905US/5VaXBACtqwjrdBdin1+r2ye8clSp24G6QUymNLQItcOH3if6
fC6NwquHuQ==
=spj4
-----END PGP SIGNATURE-----
--=-=-=--

Last modified: Wed, 12 Feb 2025 14:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.