GNU bug report logs - #75192
[PATCH] Update fontification for attribute values in heex-ts-mode

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: wishlist; Reported by: Wilhelm Kirschbaum <wkirschbaum@HIDDEN>; Keywords: patch; Done: Stefan Kangas <stefankangas@HIDDEN>; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 75192-done <at> debbugs.gnu.org:


Received: (at 75192-done) by debbugs.gnu.org; 3 Jan 2025 15:15:01 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 03 10:15:01 2025
Received: from localhost ([127.0.0.1]:51568 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tTjO8-0004vh-VA
	for submit <at> debbugs.gnu.org; Fri, 03 Jan 2025 10:15:01 -0500
Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]:52438)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1tTjO5-0004vR-KF
 for 75192-done <at> debbugs.gnu.org; Fri, 03 Jan 2025 10:14:59 -0500
Received: by mail-ej1-x633.google.com with SMTP id
 a640c23a62f3a-aa6b4cc7270so1773778166b.0
 for <75192-done <at> debbugs.gnu.org>; Fri, 03 Jan 2025 07:14:57 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1735917291; x=1736522091; darn=debbugs.gnu.org;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=f3oX37qQ1NXDTSIwyLQLaICDDTYJtIqFf2/xrtGaDAw=;
 b=DTVrrrRM2a9ieZ7jQmHBub2LiVqM1m3iH2mPBiHdPt1teKS+0hKE3+XsU3/WcHiLbW
 Exu8+o5PmplLYT2b0W2TjE5Xgqc397gRXVMurJiwYQp+Hwitg0dKBRRD8iLP4rLFEvXC
 u9cETtM+LV82I2/5Gsmdd0CvCxkfCZzCp14UEIdqLmqYjbyyuQKjxn920kbMwAt8qp9d
 jI6cZf0WYWTe12NMSCKmwSOQHuLFXqAmLcKZO7SU9ai0oyhWIAIg77nl5Sjs48Vw6wjN
 4dhzqFqSkNczJd4LYPoE7c91BOBKOBIPoPOCqL2VCTZoMu9uE658aA1sALNAwW9405US
 K1Xw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1735917291; x=1736522091;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:x-gm-message-state:from:to
 :cc:subject:date:message-id:reply-to;
 bh=f3oX37qQ1NXDTSIwyLQLaICDDTYJtIqFf2/xrtGaDAw=;
 b=oPUqxmUYML3wkUiyorDwBlvOtF08cBBQAvRm/32T6bNnbLsJrpm+nyIpYBfkID95Ay
 J51OMCbE986WS9GNvjSufO8TRSx/iEhZhS0Df4u72MLykKygQfYaptQNCRG5iUnVS62V
 GmeZELRrLvHqdm6nSKJ79+1jEit85/41MOchOWL1ImNDYm/GvuxonpNVl2I5+IQGWLuJ
 v7/0Y8HSmGJ7gPu84eYNcUPhtPoX2yOhBn0g7/tfvOmzfHqc9f7xIeGeWkKMGp1t9cz3
 9xcAvbOWohEVli4QQcpvl48HzhHfdkq8LyLJioHpoGjfVveRPG+v/MhhXsGqVrzhZo/R
 C/sg==
X-Forwarded-Encrypted: i=1;
 AJvYcCUgDgI3xAzrhatBbfzjNhCMs/0+zn26BcS9KiTp8wGvJeN9HByfEWlvmo9AFxgjFnd2f/Xnjxtmcrk+@debbugs.gnu.org
X-Gm-Message-State: AOJu0Yw/JUNEkdWUhitNmdOsGx0tXotMHzodVeTQQdCpUOp0dOoYgJdC
 XbPuDYbiNAWkfkzy2Ue88fvwCXGTQqH3TmHrtROvUWMI1eV1FdPVY6DlPE8q3pyc8I5wFyXOwLn
 2LLAXn6R9cqaxyqyAEcz82mZb9jg=
X-Gm-Gg: ASbGnct0htiwwYFu6gLLMcQUsyrW6NKaAGW+iwIJZofGPa+uTmNrX3pmLhr8ZkM/8E/
 IKxDkwzeQjKITCa3/W/VN2eevG3uFGgHp2JE8ubwF
X-Google-Smtp-Source: AGHT+IE5ivd7DD6tqZbxMk/LqmQWYdg7j/QG0xifLewueVqu9VP0IFY1e7oAtz4fXBs2WJaj/Ez88HB8covakmw2fsY=
X-Received: by 2002:a05:6402:2802:b0:5d3:cff5:635e with SMTP id
 4fb4d7f45d1cf-5d81de065b8mr116873563a12.26.1735917291071; Fri, 03 Jan 2025
 07:14:51 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Fri, 3 Jan 2025 09:14:50 -0600
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <62396379-9915-49AD-8C2D-0CAF8ED4F063@HIDDEN>
References: <CAOS0-340bL=UjmgG4Zj+V5Cb46r=8WzxcjFU0OEMPWmyL0kMRA@HIDDEN>
 <CADwFkmn1R2ussE0fwXdi3=g41L_d0UDHCZZTu51b_VsHTEX_xg@HIDDEN>
 <86zfk9k3xr.fsf@HIDDEN>
 <CADwFkmmHCUYa8kypE19Y2biGmdw0UO6GVYYGCdcst8m=nttO1A@HIDDEN>
 <86ttahk2j2.fsf@HIDDEN>
 <CAOS0-35Zvj8v6URG8TnvWEYDaD8eXR6X9Waz0wsPkRbDWjnwiA@HIDDEN>
 <86o70pjl16.fsf@HIDDEN> <62396379-9915-49AD-8C2D-0CAF8ED4F063@HIDDEN>
MIME-Version: 1.0
Date: Fri, 3 Jan 2025 09:14:50 -0600
Message-ID: <CADwFkmkkWO1E736diLpBLsa1VvsdjJTMJ4Wb8JeGxjHBqpgSsw@HIDDEN>
Subject: Re: bug#75192: [PATCH] Update fontification for attribute values in
 heex-ts-mode
To: Yuan Fu <casouri@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: 75192-done
Cc: Wilhelm Kirschbaum <wkirschbaum@HIDDEN>, 75192-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Version: 30.1

Yuan Fu <casouri@HIDDEN> writes:

>> On Jan 2, 2025, at 7:24=E2=80=AFAM, Eli Zaretskii <eliz@HIDDEN> wrote:
>>
>>> From: Wilhelm Kirschbaum <wkirschbaum@HIDDEN>
>>> Date: Thu, 2 Jan 2025 12:13:27 +0200
>>> Cc: Stefan Kangas <stefankangas@HIDDEN>, 75192 <at> debbugs.gnu.org, caso=
uri@HIDDEN
>>>
>>>>> attribute be highlighted as a string?
>>>>
>>>> I'm not familiar with HEEx and can't share a useful opinion, but FWIW,=
 I
>>>> simply noted that the code directly above the change said
>>>>
>>>>    :feature 'heex-string
>>>>
>>>> which is why I assumed that using a string face should make sense.
>>>
>>> So we think that the current face is just a typo?
>>>
>>> Originally I was not sure what would be more appropriate, but got a com=
ment from a user and saw
>>> html-ts-mode uses string so thought it would be good to change before i=
t gets released.
>>
>> OK, then I think installing this on emacs-30 is TRT.
>
> Agree.

Thanks all, installed on emacs-30 as commit 921f454f508.  Closing.




Notification sent to Wilhelm Kirschbaum <wkirschbaum@HIDDEN>:
bug acknowledged by developer. Full text available.
Reply sent to Stefan Kangas <stefankangas@HIDDEN>:
You have taken responsibility. Full text available.

Message received at 75192 <at> debbugs.gnu.org:


Received: (at 75192) by debbugs.gnu.org; 3 Jan 2025 05:49:57 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 03 00:49:57 2025
Received: from localhost ([127.0.0.1]:49182 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tTaZI-0001Pg-UV
	for submit <at> debbugs.gnu.org; Fri, 03 Jan 2025 00:49:57 -0500
Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]:58617)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <casouri@HIDDEN>) id 1tTaZC-0001PM-JZ
 for 75192 <at> debbugs.gnu.org; Fri, 03 Jan 2025 00:49:55 -0500
Received: by mail-pj1-x102c.google.com with SMTP id
 98e67ed59e1d1-2ee67e9287fso16788212a91.0
 for <75192 <at> debbugs.gnu.org>; Thu, 02 Jan 2025 21:49:50 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1735883384; x=1736488184; darn=debbugs.gnu.org;
 h=to:references:message-id:content-transfer-encoding:cc:date
 :in-reply-to:from:subject:mime-version:from:to:cc:subject:date
 :message-id:reply-to;
 bh=A9Db1+KYqBS2V+XHIK6l+8Dtlw5XN/VFqvOTtVUCtjw=;
 b=V8Asd22ywc2yOZvfy1REr2EuSDGA5JYwsaoTb7LisvYAv9vxXdaI9vWpuCW9Stkkfe
 e3FjfP9Dkb7t5Rb/BUws/QQqJa/kI1DXtfrl/YshbXkz4aF8jEbj14yngGXn/UBGrsfL
 M6H2acfsIyVF+Sl58pdUIHs0tba0s4T/ZVs88dDY49L05AHYjiP3dImMUsycuUhacqO6
 UuNIbkiaBRbB435nFqy5MUjrD9l31zgwJG+JIC3egCaDMXZgvFsJ8b0npuzTXypyeV9N
 nGtLonZJmmpCiAmFgmeFuRvFFzB7YI35Qo992zEU7V89uXqbW1WozsuIKd1KSw/q3NYX
 mUfA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1735883384; x=1736488184;
 h=to:references:message-id:content-transfer-encoding:cc:date
 :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=A9Db1+KYqBS2V+XHIK6l+8Dtlw5XN/VFqvOTtVUCtjw=;
 b=D38xM/GnCOHdBYicbd8sEZFVzgpU8/IDi6+9l4KIMBALzxpARNuK+1GO0i7w+W1601
 zImlAe5/XgLyQWM6YlSiJJssCpJb3QVrPTYgTgBU/EjSbvgRkuLzWvryt+HykZccgKqe
 2o0AhSvNAJOsXej3oSRcjoCMtwLVaDxSTnf1RMaL2hkjvQ96Ps9C2t+6uQHrCPp/UuDT
 DLEQPpQy7NTRNMtHsDiCWCG//3CgJPUDCZyDmYptJCoKLKjD2NxIfUdj6AEEJ4GUbQ0h
 0V8p93B0JJeqV4trGjaB9zefbHgc2Uzbq15oiGWCzZLaeG+0G/9faXkwxHskHc7mm8pP
 Ut/A==
X-Forwarded-Encrypted: i=1;
 AJvYcCXHL5hymKBwcDWXwUESw9Yp0jG2xz+MYKeVmLRwjcs3M1FB1fsVKiPBIG0Oa0dyJetLQs38Tw==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YzhWfwlaiZa5rggeGSj9SP5XEunTXNFntAdKlkO6VfwpUDO0kJc
 Md4N+etS5I1ypTGpYxu+Z5XrNKzGFmDB1o+V7hRCnm0LH1e3EajL
X-Gm-Gg: ASbGnctnyfo3WwtEAwTNrJxIB0EHpY5TU9nJJVcGGqVfAGjczEgiLN1KPwIyYQ4QbXi
 KHO+ahkERYybPsmWClac8ECVqK5chRM/9QdIXzz3cxV/Q6pmb+QIHIbZy8DZTDnnOYGB2qzTyZh
 vW7O9Z9MGuxlZVKt34mCU0L2RDtp52DPsXF6F7Ro+ak10gGHN9QzSYS7HM/u0zyV9ZZN/SFl01W
 E38ZDQyAe9rYF+xaQ6L0cZ8ExHx/MHFCP7mepQV0J5H6TxW92c8o/4ORVWP/RBFhbcjShiTEhTt
 ftvb
X-Google-Smtp-Source: AGHT+IHo7JqEabARAFIgq7PQj2CepqSe8JlmQrWZRIiwedmthQhIrau7CaRPJ8HWIc7vGw4CWl8DHg==
X-Received: by 2002:a05:6a00:f96:b0:724:ed8f:4d35 with SMTP id
 d2e1a72fcca58-72abdedda5fmr71315009b3a.26.1735883384283; 
 Thu, 02 Jan 2025 21:49:44 -0800 (PST)
Received: from smtpclient.apple ([2601:646:8f81:6120:85eb:71bd:58ac:56a8])
 by smtp.gmail.com with ESMTPSA id
 d2e1a72fcca58-72aad815796sm26213005b3a.28.2025.01.02.21.49.43
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 02 Jan 2025 21:49:43 -0800 (PST)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\))
Subject: Re: bug#75192: [PATCH] Update fontification for attribute values in
 heex-ts-mode
From: Yuan Fu <casouri@HIDDEN>
In-Reply-To: <86o70pjl16.fsf@HIDDEN>
Date: Thu, 2 Jan 2025 21:49:32 -0800
Content-Transfer-Encoding: quoted-printable
Message-Id: <62396379-9915-49AD-8C2D-0CAF8ED4F063@HIDDEN>
References: <CAOS0-340bL=UjmgG4Zj+V5Cb46r=8WzxcjFU0OEMPWmyL0kMRA@HIDDEN>
 <CADwFkmn1R2ussE0fwXdi3=g41L_d0UDHCZZTu51b_VsHTEX_xg@HIDDEN>
 <86zfk9k3xr.fsf@HIDDEN>
 <CADwFkmmHCUYa8kypE19Y2biGmdw0UO6GVYYGCdcst8m=nttO1A@HIDDEN>
 <86ttahk2j2.fsf@HIDDEN>
 <CAOS0-35Zvj8v6URG8TnvWEYDaD8eXR6X9Waz0wsPkRbDWjnwiA@HIDDEN>
 <86o70pjl16.fsf@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
X-Mailer: Apple Mail (2.3776.700.51)
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75192
Cc: Wilhelm Kirschbaum <wkirschbaum@HIDDEN>, 75192 <at> debbugs.gnu.org,
 stefankangas@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)



> On Jan 2, 2025, at 7:24=E2=80=AFAM, Eli Zaretskii <eliz@HIDDEN> =
wrote:
>=20
>> From: Wilhelm Kirschbaum <wkirschbaum@HIDDEN>
>> Date: Thu, 2 Jan 2025 12:13:27 +0200
>> Cc: Stefan Kangas <stefankangas@HIDDEN>, 75192 <at> debbugs.gnu.org, =
casouri@HIDDEN
>>=20
>>>> attribute be highlighted as a string?
>>>=20
>>> I'm not familiar with HEEx and can't share a useful opinion, but =
FWIW, I
>>> simply noted that the code directly above the change said
>>>=20
>>>    :feature 'heex-string
>>>=20
>>> which is why I assumed that using a string face should make sense.
>>=20
>> So we think that the current face is just a typo?
>>=20
>> Originally I was not sure what would be more appropriate, but got a =
comment from a user and saw
>> html-ts-mode uses string so thought it would be good to change before =
it gets released.
>=20
> OK, then I think installing this on emacs-30 is TRT.

Agree.





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75192; Package emacs. Full text available.

Message received at 75192 <at> debbugs.gnu.org:


Received: (at 75192) by debbugs.gnu.org; 2 Jan 2025 15:25:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 02 10:25:20 2025
Received: from localhost ([127.0.0.1]:46132 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tTN4a-0006oD-Df
	for submit <at> debbugs.gnu.org; Thu, 02 Jan 2025 10:25:20 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:53480)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tTN4Z-0006kW-AF
 for 75192 <at> debbugs.gnu.org; Thu, 02 Jan 2025 10:25:19 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1tTN4T-0000Uj-QY; Thu, 02 Jan 2025 10:25:13 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=fDghuEAYXMBHiwFqnk7OUIbVME5DRo6AzN3tGRqbNZU=; b=XdUZG0bLW49r
 HScRjWjId0yq7rBqf2G3GOz4ltk3hLjdq5ZP2K7sEZAz2eV5v+gtrADo+Of2SSwOeGEnx3dcBwu9s
 alFhCdKqhToj2o9G6OPn/AJtPZu3MOpxl8qDbi1Q0PgmSNIJ7i7aMsXH1Cp2CIT8i/bI97ar+Yaob
 dHi/SzWlnKmVLYkGhhzkXboNfeIIi43onoQ9Tivmz8Sbp2F3WtySLMD1kT0wLFwCd95+CM24vwpTN
 G/TKqMTnUzNIcguDui7rC1kiUbIJonN79oegX2KNHJiRjdPIxOdfL0joDbjOFj7aLrsijQBierGOt
 fnsJk1IKELlTVZnfK2rORw==;
Date: Thu, 02 Jan 2025 17:24:53 +0200
Message-Id: <86o70pjl16.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Wilhelm Kirschbaum <wkirschbaum@HIDDEN>
In-Reply-To: <CAOS0-35Zvj8v6URG8TnvWEYDaD8eXR6X9Waz0wsPkRbDWjnwiA@HIDDEN>
 (message from Wilhelm Kirschbaum on Thu, 2 Jan 2025 12:13:27 +0200)
Subject: Re: bug#75192: [PATCH] Update fontification for attribute values in
 heex-ts-mode
References: <CAOS0-340bL=UjmgG4Zj+V5Cb46r=8WzxcjFU0OEMPWmyL0kMRA@HIDDEN>
 <CADwFkmn1R2ussE0fwXdi3=g41L_d0UDHCZZTu51b_VsHTEX_xg@HIDDEN>
 <86zfk9k3xr.fsf@HIDDEN>
 <CADwFkmmHCUYa8kypE19Y2biGmdw0UO6GVYYGCdcst8m=nttO1A@HIDDEN>
 <86ttahk2j2.fsf@HIDDEN>
 <CAOS0-35Zvj8v6URG8TnvWEYDaD8eXR6X9Waz0wsPkRbDWjnwiA@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 75192
Cc: casouri@HIDDEN, 75192 <at> debbugs.gnu.org, stefankangas@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Wilhelm Kirschbaum <wkirschbaum@HIDDEN>
> Date: Thu, 2 Jan 2025 12:13:27 +0200
> Cc: Stefan Kangas <stefankangas@HIDDEN>, 75192 <at> debbugs.gnu.org, casouri@HIDDEN
> 
>  > > attribute be highlighted as a string?
>  > 
>  > I'm not familiar with HEEx and can't share a useful opinion, but FWIW, I
>  > simply noted that the code directly above the change said
>  > 
>  >     :feature 'heex-string
>  > 
>  > which is why I assumed that using a string face should make sense.
> 
>  So we think that the current face is just a typo?
> 
> Originally I was not sure what would be more appropriate, but got a comment from a user and saw
> html-ts-mode uses string so thought it would be good to change before it gets released.

OK, then I think installing this on emacs-30 is TRT.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75192; Package emacs. Full text available.

Message received at 75192 <at> debbugs.gnu.org:


Received: (at 75192) by debbugs.gnu.org; 2 Jan 2025 10:13:41 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 02 05:13:41 2025
Received: from localhost ([127.0.0.1]:42826 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tTICz-0008Ts-1A
	for submit <at> debbugs.gnu.org; Thu, 02 Jan 2025 05:13:41 -0500
Received: from mail-qt1-x835.google.com ([2607:f8b0:4864:20::835]:53295)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <wkirschbaum@HIDDEN>)
 id 1tTICx-0008Tl-EA
 for 75192 <at> debbugs.gnu.org; Thu, 02 Jan 2025 05:13:40 -0500
Received: by mail-qt1-x835.google.com with SMTP id
 d75a77b69052e-467a6781bc8so80659151cf.2
 for <75192 <at> debbugs.gnu.org>; Thu, 02 Jan 2025 02:13:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1735812818; x=1736417618; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=srQRJvv8AZihkE4oyxy+02Yu8RuwNqrs0IQQV45Z1Mg=;
 b=ZzryF4rB5tuF+0D8Kr9Nmolba2ZJkU5uEfIZovr11h7b/zHbgefkHzTzI1Kdiv1Oc3
 qV8s3D6w3VyDw/Xp+47qC8JtiIzBYk+v8WFx5rKibG4E8mfX5KvOXrNJfn6YfQFXwGZX
 AeLpN7tlUJld6juWOAiy0VHo/Al8OtryyRdCMbPkxHCnnT8Oopt/BxWZ8euaU0+5HL1k
 Boh9zUXmjGIitCEfzy0nYDiP7qQ83PYbH99aByFuJANLMor0a8L6Gd5Mev/TkDCBPYO3
 wlaoobiZH0mprjUf0p7boXuj0iiZHq4Rg4iU+kQxiVCvP0XHwJJlz1y3vCXu+ksevHsK
 jPpg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1735812818; x=1736417618;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=srQRJvv8AZihkE4oyxy+02Yu8RuwNqrs0IQQV45Z1Mg=;
 b=jJzZKxFWb7jRlwBhL6YhqbUS6wX/ASCC/hYEW853w4uYqa6cusbvNF2IoXCLw2QVCn
 /12Zbw7sMMVc3dd4jPA1/s99kF5/ryf1ovm7dOqENKSgrN5dIbZ2SSyFmP/qd4Om+Zsb
 PAL3ZT0OWybrIigC7gLpk1Rs38n8PHCu0vSGz8WEWdHZv0eu3zH4Q1B34HH2qVM6Dn3x
 LTKEajgbiuIx9YiSsSmgD5t61wo2kiyvzSZRuIfFbwBr9vOCGG2uehLLtolEQ6/u3mNA
 63RR14/jGRh9eUQAlolcL8mb4Win7SmIvPJPJNeHHovXNhtiPausYtEm9XqaMCib3+gD
 9xnA==
X-Forwarded-Encrypted: i=1;
 AJvYcCXHIcIC4I4xP/3n9egX5GiWlDerG2/trHLzuN+crst7OXEFyDn1nBdxSv/nN+wshJf5uudZsA==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YzZgm9HxSivVgghGuEHIHIplq3tmbiHbpalvoXujAiZaHwZ0Liz
 P0XhQQhrEuJyi+fntSyiLgjnXbXN82TE7sYLpzduSHflwjoFckYxl8cFA5SsE/952HI3QePZmRP
 cQDJ+u+gW7ooMee+4cjliCvBbxAY=
X-Gm-Gg: ASbGnctw14sjfuToNGRHXNWx4sOSPPl7PTQMhgovc9m9FzYFkd2C8acVpjhMo80pce3
 1n4+9kXWhPoMKkKvd4U2BbYcdzz5mo0uw/n+pItg=
X-Google-Smtp-Source: AGHT+IE4k20xM+HRfOAmFVCr7ynpHmdpNFvzgIWZ5K63/yrCf+NPEKFWyvdg/ZnSsOOyH+Kbvr+utShwydcufta4BHY=
X-Received: by 2002:ac8:5852:0:b0:467:6c61:b70a with SMTP id
 d75a77b69052e-46a4a8c9e2bmr780738621cf.17.1735812818729; Thu, 02 Jan 2025
 02:13:38 -0800 (PST)
MIME-Version: 1.0
References: <CAOS0-340bL=UjmgG4Zj+V5Cb46r=8WzxcjFU0OEMPWmyL0kMRA@HIDDEN>
 <CADwFkmn1R2ussE0fwXdi3=g41L_d0UDHCZZTu51b_VsHTEX_xg@HIDDEN>
 <86zfk9k3xr.fsf@HIDDEN>
 <CADwFkmmHCUYa8kypE19Y2biGmdw0UO6GVYYGCdcst8m=nttO1A@HIDDEN>
 <86ttahk2j2.fsf@HIDDEN>
In-Reply-To: <86ttahk2j2.fsf@HIDDEN>
From: Wilhelm Kirschbaum <wkirschbaum@HIDDEN>
Date: Thu, 2 Jan 2025 12:13:27 +0200
Message-ID: <CAOS0-35Zvj8v6URG8TnvWEYDaD8eXR6X9Waz0wsPkRbDWjnwiA@HIDDEN>
Subject: Re: bug#75192: [PATCH] Update fontification for attribute values in
 heex-ts-mode
To: Eli Zaretskii <eliz@HIDDEN>
Content-Type: multipart/alternative; boundary="00000000000074fde8062ab66a99"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75192
Cc: casouri@HIDDEN, 75192 <at> debbugs.gnu.org,
 Stefan Kangas <stefankangas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--00000000000074fde8062ab66a99
Content-Type: text/plain; charset="UTF-8"

> > > attribute be highlighted as a string?
> >
> > I'm not familiar with HEEx and can't share a useful opinion, but FWIW, I
> > simply noted that the code directly above the change said
> >
> >     :feature 'heex-string
> >
> > which is why I assumed that using a string face should make sense.
>
> So we think that the current face is just a typo?
>

Originally I was not sure what would be more appropriate, but got a comment
from a user and saw html-ts-mode uses string so thought it would be good to
change before it gets released.

--00000000000074fde8062ab66a99
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><div class=3D"gmail_quote gmail=
_quote_container"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px=
 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
&gt; &gt; attribute be highlighted as a string?<br>
&gt; <br>
&gt; I&#39;m not familiar with HEEx and can&#39;t share a useful opinion, b=
ut FWIW, I<br>
&gt; simply noted that the code directly above the change said<br>
&gt; <br>
&gt;=C2=A0 =C2=A0 =C2=A0:feature &#39;heex-string<br>
&gt; <br>
&gt; which is why I assumed that using a string face should make sense.<br>
<br>
So we think that the current face is just a typo?<br></blockquote><div><br>=
</div><div>Originally I was not sure what would be more appropriate, but go=
t a comment from a user and saw html-ts-mode uses string so thought it woul=
d be good to change before it gets released.<br></div></div></div>

--00000000000074fde8062ab66a99--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75192; Package emacs. Full text available.

Message received at 75192 <at> debbugs.gnu.org:


Received: (at 75192) by debbugs.gnu.org; 2 Jan 2025 09:07:11 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 02 04:07:11 2025
Received: from localhost ([127.0.0.1]:42747 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tTHAc-0005gC-MP
	for submit <at> debbugs.gnu.org; Thu, 02 Jan 2025 04:07:10 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:50940)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tTHAZ-0005fh-2N
 for 75192 <at> debbugs.gnu.org; Thu, 02 Jan 2025 04:07:09 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1tTHAT-0004Do-MB; Thu, 02 Jan 2025 04:07:01 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=4kmcE21YbeG4E0u+VXOtoVgLdn4yIBxeQfPRjTxWmQo=; b=iN0JPviIdrRb
 nsr7NrCpDpseaP3JpsSPCsomAXeew3IwKoSKjVcftOfS9TPWqTz9eIKXaSuJmTgfb28/ess/pJszO
 B3uHP9ZrmEpminVUrSwFbzT7jww4T0fkEM0l5FVn4iOuktOUyEaWug5kapYJ12bMEk1dDvp/PT/HE
 bqBHbfkDBV/xCOokJg+fy++H+pi4I3NUPorYz5RRkYmPruLHqhZHeNaIRVXaztBDDZ7En86csczJQ
 1llY6wu2So+uP1CpV5Lf67G78+6U5ehYaIGUq/uEqHKfSKeJpVEcNy84t51K4jWIp+HxA3cEVRKLR
 5AWkPvFygiBttWvsS3lC3A==;
Date: Thu, 02 Jan 2025 11:06:57 +0200
Message-Id: <86ttahk2j2.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <CADwFkmmHCUYa8kypE19Y2biGmdw0UO6GVYYGCdcst8m=nttO1A@HIDDEN>
 (message from Stefan Kangas on Thu, 2 Jan 2025 02:41:12 -0600)
Subject: Re: bug#75192: [PATCH] Update fontification for attribute values in
 heex-ts-mode
References: <CAOS0-340bL=UjmgG4Zj+V5Cb46r=8WzxcjFU0OEMPWmyL0kMRA@HIDDEN>
 <CADwFkmn1R2ussE0fwXdi3=g41L_d0UDHCZZTu51b_VsHTEX_xg@HIDDEN>
 <86zfk9k3xr.fsf@HIDDEN>
 <CADwFkmmHCUYa8kypE19Y2biGmdw0UO6GVYYGCdcst8m=nttO1A@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 75192
Cc: wkirschbaum@HIDDEN, casouri@HIDDEN, 75192 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Stefan Kangas <stefankangas@HIDDEN>
> Date: Thu, 2 Jan 2025 02:41:12 -0600
> Cc: wkirschbaum@HIDDEN, 75192 <at> debbugs.gnu.org, casouri@HIDDEN
> 
> Eli Zaretskii <eliz@HIDDEN> writes:
> 
> >> From: Stefan Kangas <stefankangas@HIDDEN>
> >> Date: Thu, 2 Jan 2025 01:45:22 -0600
> >> Cc: Eli Zaretskii <eliz@HIDDEN>, Yuan Fu <casouri@HIDDEN>
> >>
> >> Wilhelm Kirschbaum <wkirschbaum@HIDDEN> writes:
> >>
> >> > This updates heex-ts-mode to use font-lock-string-face to be consistent
> >> > with html-ts-mode on attribute values.
> >>
> >> Should we install this change on master or emacs-30?  Eli, Yuan, WDYT?
> >
> > Are we all in agreement with the change itself?  Why should an
> > attribute be highlighted as a string?
> 
> I'm not familiar with HEEx and can't share a useful opinion, but FWIW, I
> simply noted that the code directly above the change said
> 
>     :feature 'heex-string
> 
> which is why I assumed that using a string face should make sense.

So we think that the current face is just a typo?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75192; Package emacs. Full text available.

Message received at 75192 <at> debbugs.gnu.org:


Received: (at 75192) by debbugs.gnu.org; 2 Jan 2025 08:56:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 02 03:56:48 2025
Received: from localhost ([127.0.0.1]:42733 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tTH0a-0005En-E9
	for submit <at> debbugs.gnu.org; Thu, 02 Jan 2025 03:56:48 -0500
Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]:61707)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <wkirschbaum@HIDDEN>)
 id 1tTH0Y-0005Eg-TL
 for 75192 <at> debbugs.gnu.org; Thu, 02 Jan 2025 03:56:47 -0500
Received: by mail-qk1-x72f.google.com with SMTP id
 af79cd13be357-7b702c3c021so978818985a.3
 for <75192 <at> debbugs.gnu.org>; Thu, 02 Jan 2025 00:56:46 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1735808206; x=1736413006; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=9ymt10bLaq5hPftWF+ztTwGXkwZWgXLus/sgOLcggIk=;
 b=L4Zp9yp45FtohaBH3mlO24YWGPF/yFcfW9gwzask9USQZ2W4UR7P9+psB97lE+yDeZ
 JO1qdnEEh67RdzFbq29dJIUzgR8o26wCUnE1ug996TmV9kYdP9cuTlgJZhtxPghvrWJ/
 lF3PvlTiQQW3idq3MhLaGjnmlREX+bh6aVzlr+hhrIBNH7jNRk0JNtsqnhF0GOx3GPPn
 3ZU5ua6aNXVDPwSWun2LBHXrBEuEaY3RikUYjl8lTqMfosOCaT2zuveYerWsoLSxxwEo
 u0F3bUGsx+bgTERer6tbJcdETMXD4GCp1yueceCn3vWN2pqX18rgw3NYs8sxjIPBuiIq
 DGZA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1735808206; x=1736413006;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=9ymt10bLaq5hPftWF+ztTwGXkwZWgXLus/sgOLcggIk=;
 b=EXspGf08GGt14LiHz3ZCFjyszaLghLqxzb8DntFBa7A3j+a2/aHJ3D5jubgnVVtEjU
 5OMfwf62C+fdcB66Wq/trUUoKZVqt7vHJbW2aJh8uNfI2Z4Nl+PyA4R5k57pW4X+o0DE
 X9gI5CRQxpomCvuk4Tgl4rowJWBw0nO6ezdCcfbG54gMsg+DJiIva/ZDQMBHBkjEO7lE
 P9f3566MCZc+5W/Hv2dw0yPZJnydKKKMu9w4Y15XXGGVnTijkB325Oa4iTa0Eqq3Vhc2
 HNafdpQBNau5Ozpqdw/wliKSjNEGqYnagjhUINKglURE0DKsdbLXy+UI53bfjCo3V/v6
 Z7jQ==
X-Forwarded-Encrypted: i=1;
 AJvYcCUS2ZwCSVw+1CGJU5F7aO48B5A1liwYXftT+5JnbrsX2OHCF86q8n/E/REvr8JZW0NcbdUK0g==@debbugs.gnu.org
X-Gm-Message-State: AOJu0Yxlb6C1NslGE8ChNsVj8SDVUDvk/NPzS0GH+Q08uZzhXVVikfvS
 0incrPOosjd04ajUOezTprEj/LrxzdgX9wxknesK1+vVhv2hd6nqqFy7/mRI26wJ/+PTwwd5DQT
 ijyH4JxHcT8lC4raK9cjiYSwUEIw=
X-Gm-Gg: ASbGnct7QGsN2KOqaq4wDcuHN0U0uZHmXZyU7dAuniPmlI6uAxP4O+fjSoA10OtcftT
 KeVndAQczBYtLfsU3z/e8xmZYmmBfaGLFYOiNkmQ=
X-Google-Smtp-Source: AGHT+IHAPqGWR5Mdh0GRVcBaFLC2T7IT+ukr2NApPK7SOSFEqqZ+p3N2TGnjH0B+5q3xdqGzgyAgzbOoJVIh5OnT750=
X-Received: by 2002:a05:620a:2901:b0:7b6:dd9c:fabe with SMTP id
 af79cd13be357-7b9ba74f084mr7726444085a.19.1735808206176; Thu, 02 Jan 2025
 00:56:46 -0800 (PST)
MIME-Version: 1.0
References: <CAOS0-340bL=UjmgG4Zj+V5Cb46r=8WzxcjFU0OEMPWmyL0kMRA@HIDDEN>
 <CADwFkmn1R2ussE0fwXdi3=g41L_d0UDHCZZTu51b_VsHTEX_xg@HIDDEN>
 <86zfk9k3xr.fsf@HIDDEN>
 <CADwFkmmHCUYa8kypE19Y2biGmdw0UO6GVYYGCdcst8m=nttO1A@HIDDEN>
In-Reply-To: <CADwFkmmHCUYa8kypE19Y2biGmdw0UO6GVYYGCdcst8m=nttO1A@HIDDEN>
From: Wilhelm Kirschbaum <wkirschbaum@HIDDEN>
Date: Thu, 2 Jan 2025 10:56:35 +0200
Message-ID: <CAOS0-34y-G3nPX8Fa7dQ_WxWsn732rpOd=Zi35Dq_no5Sm5zXw@HIDDEN>
Subject: Re: bug#75192: [PATCH] Update fontification for attribute values in
 heex-ts-mode
To: Stefan Kangas <stefankangas@HIDDEN>
Content-Type: multipart/alternative; boundary="0000000000008705e4062ab55765"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75192
Cc: Eli Zaretskii <eliz@HIDDEN>, 75192 <at> debbugs.gnu.org, casouri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--0000000000008705e4062ab55765
Content-Type: text/plain; charset="UTF-8"

>
>
> >> > This updates heex-ts-mode to use font-lock-string-face to be
> consistent
> >> > with html-ts-mode on attribute values.
> >>
> >> Should we install this change on master or emacs-30?  Eli, Yuan, WDYT?
> >
> > Are we all in agreement with the change itself?  Why should an
> > attribute be highlighted as a string?
>

It's the value of an attribute as in <div attribute="attribute_value">.  It
matches html-ts-mode which I believe is more correct.

--0000000000008705e4062ab55765
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote gmail_quote_container"><blockquo=
te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px =
solid rgb(204,204,204);padding-left:1ex"><br>
&gt;&gt; &gt; This updates heex-ts-mode to use font-lock-string-face to be =
consistent<br>
&gt;&gt; &gt; with html-ts-mode on attribute values.<br>
&gt;&gt;<br>
&gt;&gt; Should we install this change on master or emacs-30?=C2=A0 Eli, Yu=
an, WDYT?<br>
&gt;<br>
&gt; Are we all in agreement with the change itself?=C2=A0 Why should an<br=
>
&gt; attribute be highlighted as a string?<br></blockquote><div><br></div><=
div>It&#39;s the value of an attribute as in &lt;div attribute=3D&quot;attr=
ibute_value&quot;&gt;.=C2=A0 It matches html-ts-mode which I believe is mor=
e correct.<br></div><div>=C2=A0</div></div></div>

--0000000000008705e4062ab55765--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75192; Package emacs. Full text available.

Message received at 75192 <at> debbugs.gnu.org:


Received: (at 75192) by debbugs.gnu.org; 2 Jan 2025 08:41:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 02 03:41:21 2025
Received: from localhost ([127.0.0.1]:42705 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tTGld-0004bO-FQ
	for submit <at> debbugs.gnu.org; Thu, 02 Jan 2025 03:41:21 -0500
Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]:43479)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1tTGlb-0004b9-Og
 for 75192 <at> debbugs.gnu.org; Thu, 02 Jan 2025 03:41:20 -0500
Received: by mail-ed1-x530.google.com with SMTP id
 4fb4d7f45d1cf-5d3f57582a2so21368409a12.1
 for <75192 <at> debbugs.gnu.org>; Thu, 02 Jan 2025 00:41:19 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1735807273; x=1736412073; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=IeIkZeJnzlOWM3kIIRlZbiD4g4YQDdGrl0ktcr03GjU=;
 b=V9oFMrRXO/p512xynE0p+n07Rn4EdeNmaHdT3ApXpz0VP1N/lFurte7IPOdbXIckbw
 IldD+ijPDwCk4DUQdMX5hc3fZCJOTUkrkX8Kc7zovsRAfQm1cxgxUZIZd94Tz/cQrvQF
 dlTqLYWbPiBxoBnDQR+jlWB/hBT0c/bwVpMAlSiweQ5u1c1pNTPscFUnsyqjRM9U2GqT
 unRNoabaDt7NrP+3aMOknHBG5lgT5bdIzLbSkYwirGMZjarXgBM/bElltdUwuXBsNPNO
 xs7Vvh9tcuM28jmXNTqS1XDzc6bFstXc96zsUACgTSaX9OJGNDr/bMoJqQw9gJUFHh7g
 TCOA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1735807273; x=1736412073;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=IeIkZeJnzlOWM3kIIRlZbiD4g4YQDdGrl0ktcr03GjU=;
 b=MZk6TJ6scdrkJc52c+ox/kk3B94zNmy75zsapRRUWAJjtLTeKqTZv0dJ0qPjZKwhIt
 890SaKckY9gexyokFG6DYykc1axDq8YW5SIXT0fTSnCj2p+HUvEbS63s3He2y9f+CUFa
 +mAUjPRm5AOrUPLkgHFnk7eJi0d0CRZzC4XRGqzN9uGBEe6QZ5xJapIANZPIsbEHsdb8
 sX3TMxP9X7fb129H9JxcQqhv08TBvtvRuj7DUUfOwV+JgQG7skQOxOqSMzxvP22tgYG1
 gBA+RZPv8EAe+EtNhPPca3ycSCbdGNSy7s82jBciled9f7JL4pBZHN5vfxSLiriVHJZc
 usGg==
X-Forwarded-Encrypted: i=1;
 AJvYcCVWaHXSjTG+TcpfX2uevosFsiLi64CwfFmxulQQQK80RbwaOzWpldScim3k+QjEJvQN387ZkQ==@debbugs.gnu.org
X-Gm-Message-State: AOJu0Yy9c6TJ0OTSNc4Wf0HM0ahRzJGHLc/Ms0Hdo8egcwUfqG2zqUu9
 JrM6N8ioJwcS7vaWhK73fOgKrrmYoL5azV7tFz1Z5e9baZ5/SjkImhufmYsrSyTUOX1iFx6gy6o
 /10dKTYgsiPWBnQclTdKLCcEpmGQ=
X-Gm-Gg: ASbGncvgAk7M00THSVedLIoVii3APb0Aw01JNQ/uaU6R9PJgGr0yCZY5jlmt4zSs5+N
 TSqN+zkO17xxfvWFr14/SNyxC7oU1bEJtGuoBqm7j
X-Google-Smtp-Source: AGHT+IH1C/vJR66+z2anFGBgmnT/wsF1s1zcOVmMjdDsXYmA7o6Audt1TQB1UtdfAHZJL6+dr8qBwBAXUOwXfVpFdac=
X-Received: by 2002:a05:6402:3513:b0:5d3:e9fd:9a16 with SMTP id
 4fb4d7f45d1cf-5d80245b6e8mr42876476a12.12.1735807273525; Thu, 02 Jan 2025
 00:41:13 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Thu, 2 Jan 2025 02:41:12 -0600
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <86zfk9k3xr.fsf@HIDDEN>
References: <CAOS0-340bL=UjmgG4Zj+V5Cb46r=8WzxcjFU0OEMPWmyL0kMRA@HIDDEN>
 <CADwFkmn1R2ussE0fwXdi3=g41L_d0UDHCZZTu51b_VsHTEX_xg@HIDDEN>
 <86zfk9k3xr.fsf@HIDDEN>
MIME-Version: 1.0
Date: Thu, 2 Jan 2025 02:41:12 -0600
Message-ID: <CADwFkmmHCUYa8kypE19Y2biGmdw0UO6GVYYGCdcst8m=nttO1A@HIDDEN>
Subject: Re: bug#75192: [PATCH] Update fontification for attribute values in
 heex-ts-mode
To: Eli Zaretskii <eliz@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75192
Cc: wkirschbaum@HIDDEN, casouri@HIDDEN, 75192 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Eli Zaretskii <eliz@HIDDEN> writes:

>> From: Stefan Kangas <stefankangas@HIDDEN>
>> Date: Thu, 2 Jan 2025 01:45:22 -0600
>> Cc: Eli Zaretskii <eliz@HIDDEN>, Yuan Fu <casouri@HIDDEN>
>>
>> Wilhelm Kirschbaum <wkirschbaum@HIDDEN> writes:
>>
>> > This updates heex-ts-mode to use font-lock-string-face to be consistent
>> > with html-ts-mode on attribute values.
>>
>> Should we install this change on master or emacs-30?  Eli, Yuan, WDYT?
>
> Are we all in agreement with the change itself?  Why should an
> attribute be highlighted as a string?

I'm not familiar with HEEx and can't share a useful opinion, but FWIW, I
simply noted that the code directly above the change said

    :feature 'heex-string

which is why I assumed that using a string face should make sense.

I'll let others chime in here.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75192; Package emacs. Full text available.

Message received at 75192 <at> debbugs.gnu.org:


Received: (at 75192) by debbugs.gnu.org; 2 Jan 2025 08:36:41 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 02 03:36:41 2025
Received: from localhost ([127.0.0.1]:42697 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tTGh6-0004Op-OB
	for submit <at> debbugs.gnu.org; Thu, 02 Jan 2025 03:36:41 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:49992)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tTGh4-0004Oc-ST
 for 75192 <at> debbugs.gnu.org; Thu, 02 Jan 2025 03:36:39 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1tTGgz-00076O-9K; Thu, 02 Jan 2025 03:36:33 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=XNvFzVa3a+rpdB0IydrQLtsJWUNxg4M3nu7U9GbqQX0=; b=EIqY3ICqBMqy
 imdH/2keiq/SvB1JmUYktjyLR7Fnn7JRfa+HxybVdGsETviGOzCzpcbRKTPS17d6kSUpT/JknJFpN
 0Lt6HQSMFyT/e/mnj4H1lNAAZzRe+afejWS0O/N8yxCLPuKNOe5MBeY341xSppHgr8HmM3CmEOLI2
 dfqXpgZbAZL7IHqJHXtADJi1QBUldeUO6MBBnMnUTLH92RgPdY2EjBlUbSKjIuYj95KANQuqaXW4l
 hU/5xIKpiGL3/6XCB35TsTSR0crikjbYkLXVMAVB7y478VRuP3VgdPQL/DQf8vQYA/r0n+3qa3sCA
 K94qZoHGdGMtKwPB3KGCdQ==;
Date: Thu, 02 Jan 2025 10:36:32 +0200
Message-Id: <86zfk9k3xr.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <CADwFkmn1R2ussE0fwXdi3=g41L_d0UDHCZZTu51b_VsHTEX_xg@HIDDEN>
 (message from Stefan Kangas on Thu, 2 Jan 2025 01:45:22 -0600)
Subject: Re: bug#75192: [PATCH] Update fontification for attribute values in
 heex-ts-mode
References: <CAOS0-340bL=UjmgG4Zj+V5Cb46r=8WzxcjFU0OEMPWmyL0kMRA@HIDDEN>
 <CADwFkmn1R2ussE0fwXdi3=g41L_d0UDHCZZTu51b_VsHTEX_xg@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 75192
Cc: wkirschbaum@HIDDEN, casouri@HIDDEN, 75192 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Stefan Kangas <stefankangas@HIDDEN>
> Date: Thu, 2 Jan 2025 01:45:22 -0600
> Cc: Eli Zaretskii <eliz@HIDDEN>, Yuan Fu <casouri@HIDDEN>
> 
> Wilhelm Kirschbaum <wkirschbaum@HIDDEN> writes:
> 
> > This updates heex-ts-mode to use font-lock-string-face to be consistent
> > with html-ts-mode on attribute values.
> 
> Should we install this change on master or emacs-30?  Eli, Yuan, WDYT?

Are we all in agreement with the change itself?  Why should an
attribute be highlighted as a string?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75192; Package emacs. Full text available.

Message received at 75192 <at> debbugs.gnu.org:


Received: (at 75192) by debbugs.gnu.org; 2 Jan 2025 07:45:28 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 02 02:45:27 2025
Received: from localhost ([127.0.0.1]:42586 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tTFtX-00025y-Ha
	for submit <at> debbugs.gnu.org; Thu, 02 Jan 2025 02:45:27 -0500
Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]:61534)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1tTFtV-00025q-UL
 for 75192 <at> debbugs.gnu.org; Thu, 02 Jan 2025 02:45:26 -0500
Received: by mail-ed1-x530.google.com with SMTP id
 4fb4d7f45d1cf-5d3f28a4fccso17200578a12.2
 for <75192 <at> debbugs.gnu.org>; Wed, 01 Jan 2025 23:45:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1735803925; x=1736408725; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=rzWuLKqzLjbnk4pspS5KRlcGf6UruoUALrec+GryWJ4=;
 b=gI8Zuav8x66dBYb2axMRg05QPS1UGCe3v/dkCB5Xmc6Xao50k/cA0TeD2cFtLGOay+
 Zda/dGpnOfs10WXpLbkkjQ4Md64ikzxAaLr8yE9kTqFwttn6zGb2EiFR7Tz0XsP8yeOK
 +LjYrSBgRBZZJECl9gW2Cy7hp0FSscVye9i0EMSSnSVo78Hc5fVZa6EULe+rI20ngxNw
 2a1W8zs+UMNKQl4osmytt/M6Uuax33ta4PgqOfQDNY6pvv3V452YcYZ6hvhbO/7bmy1s
 pSiyFwyJO7/7k5rRo6KCfTonQJnOtQ3gdRjPJOkGUMNm5Xx18FFBNRthsv0luZ33Km34
 NysA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1735803925; x=1736408725;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=rzWuLKqzLjbnk4pspS5KRlcGf6UruoUALrec+GryWJ4=;
 b=IOpNdvETGvijtNR3oBWM2RMB3ZJwwkqDRGAsAXZJxGR4XOIj8+DthKT2+s6LmQI2MI
 ZqEEePrgysfvhh6Dlz0ode63kw5vNgNmp5pUFZRM8vLde5xb9fEUzH1jpnF8UDMshZ9R
 7I/v8ib5V5iPyRGHD2lYnpSqI3pcDsYjG4e98N7M+VX0LS+l6lT0gKLEkL+/W6Tv3qxd
 9wXZaMvSVsrQaji+DSwX8txk55GCuwulZGjbyv5nBB0ivPMM4vgLCV4goQTy5z86ZHyv
 rilJ8InnmwEzAl6v/6bsIPocF73j8MlDf7F6H2D/GydZ88u9u93DDJu+clI6+UNo40pe
 QX4Q==
X-Forwarded-Encrypted: i=1;
 AJvYcCX25CuyP4ivZMmCBhrcq4MMZCKecM9h0Y/Vr0A5QvSio5/U+lCeVZtb2rpfdTaRJiQFcnGPeg==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YxHkrTuLW62P5eiNkoHZpHLVRwKBk5R9JyiGvjbWLOPtM/yAVWC
 1GQ34Jq1urTbJKhUQFYoLifjlh7GIgyN6e4lbDBuX5/3WaSZ1qMtR14w2At3a9wTn6qLV5AlBvj
 kzTPmpX3+Lh1RugXdKjquiLMQuVw=
X-Gm-Gg: ASbGncsRKaYRrYwT/Hyd+FinwnShVNCyxuCOqxyjY6sH1f2vjSOr+yQ5IGQZr4GDkLf
 TjjowVU6a0+e+g3rmX7PwZWgDe/wK96INALR8h7Yq
X-Google-Smtp-Source: AGHT+IHazRiJFXywUo4Oa9F4oqdgbfKCiYocUQKtmbUqbO4UsST+M/YjmtHqK2SY/JZJOTasavdZVlEnHtnsO7upIJg=
X-Received: by 2002:a05:6402:2802:b0:5d3:d7c1:31a4 with SMTP id
 4fb4d7f45d1cf-5d81dd5e8famr47179156a12.7.1735803923223; Wed, 01 Jan 2025
 23:45:23 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Thu, 2 Jan 2025 01:45:22 -0600
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <CAOS0-340bL=UjmgG4Zj+V5Cb46r=8WzxcjFU0OEMPWmyL0kMRA@HIDDEN>
References: <CAOS0-340bL=UjmgG4Zj+V5Cb46r=8WzxcjFU0OEMPWmyL0kMRA@HIDDEN>
MIME-Version: 1.0
Date: Thu, 2 Jan 2025 01:45:22 -0600
Message-ID: <CADwFkmn1R2ussE0fwXdi3=g41L_d0UDHCZZTu51b_VsHTEX_xg@HIDDEN>
Subject: Re: bug#75192: [PATCH] Update fontification for attribute values in
 heex-ts-mode
To: Wilhelm Kirschbaum <wkirschbaum@HIDDEN>, 75192 <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75192
Cc: Eli Zaretskii <eliz@HIDDEN>, Yuan Fu <casouri@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Wilhelm Kirschbaum <wkirschbaum@HIDDEN> writes:

> This updates heex-ts-mode to use font-lock-string-face to be consistent
> with html-ts-mode on attribute values.

Should we install this change on master or emacs-30?  Eli, Yuan, WDYT?

> From 51dcd9cea634233439db59c977928f8d7a36edff Mon Sep 17 00:00:00 2001
> From: Wilhelm Kirschbaum <wkirschbaum@HIDDEN>
> Date: Mon, 30 Dec 2024 12:56:40 +0200
> Subject: [PATCH] Update fontification for attribute values in heex-ts-mode
>
> Attribute values are strings as with html-ts-mode.
>
> * lisp/progmodes/heex-ts-mode.el (heex-ts--font-lock-settings):
> Change to attribute value to @font-lock-string-face.
> ---
>  lisp/progmodes/heex-ts-mode.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/progmodes/heex-ts-mode.el b/lisp/progmodes/heex-ts-mode.el
> index 797bfd6c8ff..4be987f9d81 100644
> --- a/lisp/progmodes/heex-ts-mode.el
> +++ b/lisp/progmodes/heex-ts-mode.el
> @@ -113,7 +113,7 @@ heex-ts--font-lock-settings
>       `((special_attribute_name) @font-lock-keyword-face)
>       :language 'heex
>       :feature 'heex-string
> -     `([(attribute_value) (quoted_attribute_value)] @font-lock-constant-face)
> +     `([(attribute_value) (quoted_attribute_value)] @font-lock-string-face)
>       :language 'heex
>       :feature 'heex-component
>       `([
> --
> 2.45.2




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#75192; Package emacs. Full text available.
Severity set to 'wishlist' from 'normal' Request was from Stefan Kangas <stefankangas@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 30 Dec 2024 11:02:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Dec 30 06:02:23 2024
Received: from localhost ([127.0.0.1]:57485 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tSDXT-0002TJ-Gr
	for submit <at> debbugs.gnu.org; Mon, 30 Dec 2024 06:02:23 -0500
Received: from lists.gnu.org ([209.51.188.17]:43640)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <wkirschbaum@HIDDEN>) id 1tSDXR-0002TB-QZ
 for submit <at> debbugs.gnu.org; Mon, 30 Dec 2024 06:02:22 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <wkirschbaum@HIDDEN>)
 id 1tSDVL-0005ub-9e
 for bug-gnu-emacs@HIDDEN; Mon, 30 Dec 2024 06:00:11 -0500
Received: from mail-qt1-x831.google.com ([2607:f8b0:4864:20::831])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <wkirschbaum@HIDDEN>)
 id 1tSDVJ-0002vv-QH
 for bug-gnu-emacs@HIDDEN; Mon, 30 Dec 2024 06:00:11 -0500
Received: by mail-qt1-x831.google.com with SMTP id
 d75a77b69052e-46788c32a69so112663821cf.2
 for <bug-gnu-emacs@HIDDEN>; Mon, 30 Dec 2024 03:00:09 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1735556408; x=1736161208; darn=gnu.org;
 h=to:subject:message-id:date:from:mime-version:from:to:cc:subject
 :date:message-id:reply-to;
 bh=uKb5xadeUUgXuYnWlDvwnRkHsudTy8HlDIlvAENxi4I=;
 b=Zm7x1O62bIz6jKXc0i+Cslkn6GdNno9188V5GhdnvVdoHdO6X1/LIj8osQhVFRKxf7
 qWjlj7QKHTGJjcsS30eqn4LzJhg8SxAJyDbur51KUbRVUafnJLpyN3ajqtRJHCii9mCP
 ouOeyJk0edKnRGSGHE7lravf459o2T/ks7wtIfmbDmtr2h5+KacmGDwBPEnkyY8Fa/KF
 AtFcpvB9eR3CXdpgfn+EaoHZ27geOsG65bkrSEfKYfvn9WA2sU/c/MZgR5UswgWK1A4B
 +BCrLIzEQztlJHVsNKNNL+7W2LO7ewM97V+5sbdfxUDYotVsUVt4l9V5WzDNXg4Xy4MO
 Un0Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1735556408; x=1736161208;
 h=to:subject:message-id:date:from:mime-version:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=uKb5xadeUUgXuYnWlDvwnRkHsudTy8HlDIlvAENxi4I=;
 b=stXEhi59VuBos3EhWvHzfXwCrPDsZWzfSkdcaQ+DayfXqaasxPvjozeJS7EYlbz2v0
 G8vQzx0kIfWsNLsfKUbSWV2FeJqH2C2VPku6nhKEjBF8BzD3ur73vDVgG/CsGS/JbmI1
 uvPLvkhVIwn762k0Ygm71sYPfZraCQgdQuTR3ON0zS6pXjfqi7p+/V14kNpo1iB+K9cb
 Ds5+MAlMYo4P76NdAvRGhBm3Gt4xPIfXAnRWSk7BMgz75MSSWDsA1JSXw3DusCdaZPlY
 ZBSFAgY0k6Jqm8DPU81LsrT8uZi4afHCENxb7pPAoT7nN6FbVmoNtBPYxJE0Zy5AdYeZ
 JObQ==
X-Gm-Message-State: AOJu0Yx7Z1H6gorOiCRNeitW52a2MUqve6ZBAoZ3FzkKX9+5s0y0THyr
 nnTUp1kgQRTXBvDXiEuAFIstiNBN5mBmejB1EQzXBI1ziyTKerXfC1fdpDvx4h5cla9I62zB94R
 hXDC7r3QyySqYFvUkgwwbjfyK6V78OA==
X-Gm-Gg: ASbGncsC7EfaSyuLJjE7YYgfv68gafVp3nsPkVTSoa2nJQOfewXrpZXnphPeFom1xV7
 q4KNnb8QD2+nfWm1P9qL7QgojYxijJ9N3uVjwZIA=
X-Google-Smtp-Source: AGHT+IFOw9QMnFa2klVamdeSFR2M8oq7G8lD7e68CAb3MXRUvRWFCJ702aqvtnjX3meMeC+2ZUlQq9Y6C+yJLoQE5xY=
X-Received: by 2002:a05:622a:2cc:b0:467:864b:dd79 with SMTP id
 d75a77b69052e-46a4a9a2aabmr606944841cf.49.1735556408359; Mon, 30 Dec 2024
 03:00:08 -0800 (PST)
MIME-Version: 1.0
From: Wilhelm Kirschbaum <wkirschbaum@HIDDEN>
Date: Mon, 30 Dec 2024 12:59:57 +0200
Message-ID: <CAOS0-340bL=UjmgG4Zj+V5Cb46r=8WzxcjFU0OEMPWmyL0kMRA@HIDDEN>
Subject: [PATCH] Update fontification for attribute values in heex-ts-mode
To: Bug Report Emacs <bug-gnu-emacs@HIDDEN>
Content-Type: multipart/mixed; boundary="000000000000356d4c062a7ab700"
Received-SPF: pass client-ip=2607:f8b0:4864:20::831;
 envelope-from=wkirschbaum@HIDDEN; helo=mail-qt1-x831.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

--000000000000356d4c062a7ab700
Content-Type: multipart/alternative; boundary="000000000000356d4b062a7ab7fe"

--000000000000356d4b062a7ab7fe
Content-Type: text/plain; charset="UTF-8"

This updates heex-ts-mode to use font-lock-string-face to be consistent
with html-ts-mode on attribute values.

Kind regards,
Wilhelm

--000000000000356d4b062a7ab7fe
Content-Type: text/html; charset="UTF-8"

<div dir="ltr"><div>This updates heex-ts-mode to use font-lock-string-face to be consistent with html-ts-mode on attribute values. <br></div><div><br></div><div>Kind regards,<br></div><div>Wilhelm<br></div><br></div>

--000000000000356d4b062a7ab7fe--

--000000000000356d4c062a7ab700
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="0001-Update-fontification-for-attribute-values-in-heex-ts.patch"
Content-Disposition: attachment; 
	filename="0001-Update-fontification-for-attribute-values-in-heex-ts.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_m5axgltb0>
X-Attachment-Id: f_m5axgltb0

RnJvbSA1MWRjZDljZWE2MzQyMzM0MzlkYjU5Yzk3NzkyOGY4ZDdhMzZlZGZmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBXaWxoZWxtIEtpcnNjaGJhdW0gPHdraXJzY2hiYXVtQGdtYWls
LmNvbT4KRGF0ZTogTW9uLCAzMCBEZWMgMjAyNCAxMjo1Njo0MCArMDIwMApTdWJqZWN0OiBbUEFU
Q0hdIFVwZGF0ZSBmb250aWZpY2F0aW9uIGZvciBhdHRyaWJ1dGUgdmFsdWVzIGluIGhlZXgtdHMt
bW9kZQoKQXR0cmlidXRlIHZhbHVlcyBhcmUgc3RyaW5ncyBhcyB3aXRoIGh0bWwtdHMtbW9kZS4K
CiogbGlzcC9wcm9nbW9kZXMvaGVleC10cy1tb2RlLmVsIChoZWV4LXRzLS1mb250LWxvY2stc2V0
dGluZ3MpOgpDaGFuZ2UgdG8gYXR0cmlidXRlIHZhbHVlIHRvIEBmb250LWxvY2stc3RyaW5nLWZh
Y2UuCi0tLQogbGlzcC9wcm9nbW9kZXMvaGVleC10cy1tb2RlLmVsIHwgMiArLQogMSBmaWxlIGNo
YW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9w
cm9nbW9kZXMvaGVleC10cy1tb2RlLmVsIGIvbGlzcC9wcm9nbW9kZXMvaGVleC10cy1tb2RlLmVs
CmluZGV4IDc5N2JmZDZjOGZmLi40YmU5ODdmOWQ4MSAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9k
ZXMvaGVleC10cy1tb2RlLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL2hlZXgtdHMtbW9kZS5lbApA
QCAtMTEzLDcgKzExMyw3IEBAIGhlZXgtdHMtLWZvbnQtbG9jay1zZXR0aW5ncwogICAgICBgKChz
cGVjaWFsX2F0dHJpYnV0ZV9uYW1lKSBAZm9udC1sb2NrLWtleXdvcmQtZmFjZSkKICAgICAgOmxh
bmd1YWdlICdoZWV4CiAgICAgIDpmZWF0dXJlICdoZWV4LXN0cmluZwotICAgICBgKFsoYXR0cmli
dXRlX3ZhbHVlKSAocXVvdGVkX2F0dHJpYnV0ZV92YWx1ZSldIEBmb250LWxvY2stY29uc3RhbnQt
ZmFjZSkKKyAgICAgYChbKGF0dHJpYnV0ZV92YWx1ZSkgKHF1b3RlZF9hdHRyaWJ1dGVfdmFsdWUp
XSBAZm9udC1sb2NrLXN0cmluZy1mYWNlKQogICAgICA6bGFuZ3VhZ2UgJ2hlZXgKICAgICAgOmZl
YXR1cmUgJ2hlZXgtY29tcG9uZW50CiAgICAgIGAoWwotLSAKMi40NS4yCgo=
--000000000000356d4c062a7ab700--




Acknowledgement sent to Wilhelm Kirschbaum <wkirschbaum@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#75192; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.