X-Loop: help-debbugs@HIDDEN Subject: bug#75933: 29; Disabling smerge-command-prefix results in error Resent-From: Jonas Bernoulli <jonas@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Wed, 29 Jan 2025 19:29:01 +0000 Resent-Message-ID: <handler.75933.B.17381789354100 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 75933 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 75933 <at> debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN Received: via spool by submit <at> debbugs.gnu.org id=B.17381789354100 (code B ref -1); Wed, 29 Jan 2025 19:29:01 +0000 Received: (at submit) by debbugs.gnu.org; 29 Jan 2025 19:28:55 +0000 Received: from localhost ([127.0.0.1]:43100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tdDk7-000144-IX for submit <at> debbugs.gnu.org; Wed, 29 Jan 2025 14:28:55 -0500 Received: from lists.gnu.org ([2001:470:142::17]:37276) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <jonas@HIDDEN>) id 1tdDk3-00013o-Pn for submit <at> debbugs.gnu.org; Wed, 29 Jan 2025 14:28:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <jonas@HIDDEN>) id 1tdDjx-00034w-Mq for bug-gnu-emacs@HIDDEN; Wed, 29 Jan 2025 14:28:45 -0500 Received: from mail.hostpark.net ([212.243.197.30]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <jonas@HIDDEN>) id 1tdDjv-0002y6-9K for bug-gnu-emacs@HIDDEN; Wed, 29 Jan 2025 14:28:45 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id B414816776 for <bug-gnu-emacs@HIDDEN>; Wed, 29 Jan 2025 20:28:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :subject:subject:from:from; s=sel2011a; t=1738178915; bh=hC1nQfD wV/LuODbdem65sDiYQDSO6reI0aM2X0puehQ=; b=X7cUCezBXSS9z4Utg5bS6jM Wypd1AniWdN8HPfhUUI0d6Rl8+GkvXhF03Q0gJ4WvhFtEX+c4bLLYCdSR+lotwpJ Iu47/f70O8zL8fsLe2IDcOdBeEo3sTNhTpGuGYrQLvy3d5UStvsPxShPUOeKOPMi dKWwIAzBGVWuTJTKZ3KM= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id Q1w90d5aCF1Y for <bug-gnu-emacs@HIDDEN>; Wed, 29 Jan 2025 20:28:35 +0100 (CET) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 6F73D16275 for <bug-gnu-emacs@HIDDEN>; Wed, 29 Jan 2025 20:28:35 +0100 (CET) From: Jonas Bernoulli <jonas@HIDDEN> Date: Wed, 29 Jan 2025 20:28:32 +0100 Message-ID: <87r04lbesf.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=212.243.197.30; envelope-from=jonas@HIDDEN; helo=mail.hostpark.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.1 (/) Hello, In Emacs 28 the prefix key was defined like this: (defcustom smerge-command-prefix "\C-c^" "Prefix for `smerge-mode' commands." :type '(choice (const :tag "ESC" "\e") (const :tag "C-c ^" "\C-c^" ) (const :tag "none" "") string)) (easy-mmode-defmap smerge-mode-map `((,smerge-command-prefix . ,smerge-basic-map)) "Keymap for `smerge-mode'.") In Emacs 29.1 (after 2ae3b66fa80 and some fixup commits), the former remained as it was in 28, but the latter was replaced with: (defvar-keymap smerge-mode-map (key-description smerge-command-prefix) smerge-basic-map) Setting the option to "", to add no prefix command, results in: keymap--check: "" is not a valid key definition; see `key-valid-p' A possible fix could be to do it old-school: (defvar smerge-mode-map (let ((map (make-sparse-keymap)) (key (key-description smerge-command-prefix))) (when (key-valid-p key) (keymap-set map key smerge-basic-map)) map)) Best regards, Jonas
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Jonas Bernoulli <jonas@HIDDEN> Subject: bug#75933: Acknowledgement (29; Disabling smerge-command-prefix results in error) Message-ID: <handler.75933.B.17381789354100.ack <at> debbugs.gnu.org> References: <87r04lbesf.fsf@HIDDEN> X-Gnu-PR-Message: ack 75933 X-Gnu-PR-Package: emacs Reply-To: 75933 <at> debbugs.gnu.org Date: Wed, 29 Jan 2025 19:29:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 75933 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 75933: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D75933 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN Subject: bug#75933: 29; Disabling smerge-command-prefix results in error Resent-From: Eli Zaretskii <eliz@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Wed, 29 Jan 2025 19:55:02 +0000 Resent-Message-ID: <handler.75933.B75933.17381804538655 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 75933 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Jonas Bernoulli <jonas@HIDDEN>, Stefan Monnier <monnier@HIDDEN> Cc: 75933 <at> debbugs.gnu.org Received: via spool by 75933-submit <at> debbugs.gnu.org id=B75933.17381804538655 (code B ref 75933); Wed, 29 Jan 2025 19:55:02 +0000 Received: (at 75933) by debbugs.gnu.org; 29 Jan 2025 19:54:13 +0000 Received: from localhost ([127.0.0.1]:43143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tdE8a-0002FX-R7 for submit <at> debbugs.gnu.org; Wed, 29 Jan 2025 14:54:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34734) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tdE8Y-0002FE-1x for 75933 <at> debbugs.gnu.org; Wed, 29 Jan 2025 14:54:10 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tdE8M-0005ae-N6; Wed, 29 Jan 2025 14:54:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=9RaHSzpuDlGJ6FpLueqvntTrsrNOSGnm4Zo0azjLJOg=; b=SIRk/KQnQgCV viU2E/zks4fpVdEa3c3x2Km8UZSmz+uMwnWRm06MVi2l8IALc2uzw1BkQA9ZgxUzdk2mfFELtNlNY OtUhKVeDqoimWExwk/hD4yNTbHyOdSUzpY3kLYfMYEYEmAyd4X36y3U1p0fuvAML6O9uHqcVq1/gT W4XlZ+T4iULzJOF5ODSWRYGI6PA84lqhF5tL7T3al1tW0HkUzaywwpQ96lC0cjGRBJNphOLVZANjL Dk9S8xsmWJdEmqbL0648h7eYPZzy/2U604w/wjOQHQw6rBn+CiWIBojS7CU9s4gjTMSoFTVVdSdr3 H0VJ6+xbtdHM19Lblx7WkQ==; Date: Wed, 29 Jan 2025 21:53:29 +0200 Message-Id: <861pwlmm6e.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> In-Reply-To: <87r04lbesf.fsf@HIDDEN> (bug-gnu-emacs@HIDDEN) References: <87r04lbesf.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Wed, 29 Jan 2025 20:28:32 +0100 > From: Jonas Bernoulli via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > Hello, > > In Emacs 28 the prefix key was defined like this: > > (defcustom smerge-command-prefix "\C-c^" > "Prefix for `smerge-mode' commands." > :type '(choice (const :tag "ESC" "\e") > (const :tag "C-c ^" "\C-c^" ) > (const :tag "none" "") > string)) > > (easy-mmode-defmap smerge-mode-map > `((,smerge-command-prefix . ,smerge-basic-map)) > "Keymap for `smerge-mode'.") > > In Emacs 29.1 (after 2ae3b66fa80 and some fixup commits), the former > remained as it was in 28, but the latter was replaced with: > > (defvar-keymap smerge-mode-map > (key-description smerge-command-prefix) smerge-basic-map) > > Setting the option to "", to add no prefix command, results in: > > keymap--check: "" is not a valid key definition; see `key-valid-p' > > A possible fix could be to do it old-school: > > (defvar smerge-mode-map > (let ((map (make-sparse-keymap)) > (key (key-description smerge-command-prefix))) > (when (key-valid-p key) > (keymap-set map key smerge-basic-map)) > map)) Thanks. Stefan, can you suggest a solution?
X-Loop: help-debbugs@HIDDEN Subject: bug#75933: 29; Disabling smerge-command-prefix results in error Resent-From: Stefan Monnier <monnier@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Wed, 05 Feb 2025 23:09:01 +0000 Resent-Message-ID: <handler.75933.B75933.17387969226001 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 75933 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Jonas Bernoulli <jonas@HIDDEN> Cc: 75933 <at> debbugs.gnu.org Received: via spool by 75933-submit <at> debbugs.gnu.org id=B75933.17387969226001 (code B ref 75933); Wed, 05 Feb 2025 23:09:01 +0000 Received: (at 75933) by debbugs.gnu.org; 5 Feb 2025 23:08:42 +0000 Received: from localhost ([127.0.0.1]:53155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tfoVe-0001Yj-94 for submit <at> debbugs.gnu.org; Wed, 05 Feb 2025 18:08:42 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:21030) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <monnier@HIDDEN>) id 1tfoVZ-0001YO-8o for 75933 <at> debbugs.gnu.org; Wed, 05 Feb 2025 18:08:39 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 114B14442B1; Wed, 5 Feb 2025 18:08:29 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1738796908; bh=NekwAOpq8Xk2pLCdzqfO5RZju5F4Y2ntxtGzydkV294=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=WrdPtG6CHqd4YMHSxcuzXEpqY77MQ0+dRxllLVS5AZrKnFkyLQMEz4qcpI3E1Okuj 1LTeTX3eJBGw76VTXWKmIDn8rRlrzkMeRqg6tO3oNzHAUYmHinDl06rff5DjIlsYoZ eHiy7OXJsyOEWIeGuN+0DVUA6iKq6rnCl3jXLhDzMv6vLB33XlQtOAzU+d4HNEAq22 QHPxoZxHQ/cymNkfPO1KDWLx1EBiBh5v8201Hh2wkaAHDNzAbWLMiLI25IGgeCLgPG E642jvna5IfwAmlwsv/KJpTxh+UYZcgMXFnzRxBRQufnvUYNWvwOTWi4tytXRKDtjE RtppFxvTABpkA== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id F20E04442A4; Wed, 5 Feb 2025 18:08:27 -0500 (EST) Received: from alfajor (104-195-232-86.cpe.teksavvy.com [104.195.232.86]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C7C501203A5; Wed, 5 Feb 2025 18:08:27 -0500 (EST) From: Stefan Monnier <monnier@HIDDEN> In-Reply-To: <87r04lbesf.fsf@HIDDEN> (Jonas Bernoulli's message of "Wed, 29 Jan 2025 20:28:32 +0100") Message-ID: <jwvtt98hu6y.fsf-monnier+emacs@HIDDEN> References: <87r04lbesf.fsf@HIDDEN> Date: Wed, 05 Feb 2025 18:08:26 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.006 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > (easy-mmode-defmap smerge-mode-map > `((,smerge-command-prefix . ,smerge-basic-map)) > "Keymap for `smerge-mode'.") > > In Emacs 29.1 (after 2ae3b66fa80 and some fixup commits), the former > remained as it was in 28, but the latter was replaced with: > > (defvar-keymap smerge-mode-map > (key-description smerge-command-prefix) smerge-basic-map) > > Setting the option to "", to add no prefix command, results in: > > keymap--check: "" is not a valid key definition; see `key-valid-p' Emacs Emacs<29 setting the option to "" resulted in keeping `smerge-mode-map` empty, AFAICT. Is that what you wanted or did you expect all the bindings of `smerge-basic-map` to be made available without a prefix? To my mind the value "" would be closer to meaning that all the bindings of `smerge-basic-map` should be made available without a prefix, and if we want to allow the bindings to be completely absent, it might make more sense to use a nil value. Stefan
X-Loop: help-debbugs@HIDDEN Subject: bug#75933: 29; Disabling smerge-command-prefix results in error Resent-From: Jonas Bernoulli <jonas@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Thu, 06 Feb 2025 13:51:02 +0000 Resent-Message-ID: <handler.75933.B75933.17388498121885 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 75933 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier <monnier@HIDDEN> Cc: 75933 <at> debbugs.gnu.org Received: via spool by 75933-submit <at> debbugs.gnu.org id=B75933.17388498121885 (code B ref 75933); Thu, 06 Feb 2025 13:51:02 +0000 Received: (at 75933) by debbugs.gnu.org; 6 Feb 2025 13:50:12 +0000 Received: from localhost ([127.0.0.1]:54914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tg2Gh-0000U3-Eh for submit <at> debbugs.gnu.org; Thu, 06 Feb 2025 08:50:11 -0500 Received: from mail.hostpark.net ([212.243.197.30]:42020) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <jonas@HIDDEN>) id 1tg2Gd-0000PG-KZ for 75933 <at> debbugs.gnu.org; Thu, 06 Feb 2025 08:50:09 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 1CA50164D4; Thu, 6 Feb 2025 14:50:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :references:in-reply-to:subject:subject:from:from; s=sel2011a; t=1738849804; bh=X7wc0YqpPqrmDs9N6VX5oR2QNrbc2f3OvqMQM8ZJlIA=; b= Q7szDy7PB7xQySs2ysuRmn+t7klRFyccFGwJbTQ607zuvXKuFJ7iXWlghHFCUDfi gxYXUsCVHkxaQ4MjV2wSPc0UzN4cBqajdOebHfRT+Z4J93dzPBcKUrUS8vXa588k sVUD+FtRKlqPrU6Y6ClNgeVg9H3HFHYTd1klziZ8gJc= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id lJ9uJOwlVHaC; Thu, 6 Feb 2025 14:50:04 +0100 (CET) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 8774E16466; Thu, 6 Feb 2025 14:50:04 +0100 (CET) From: Jonas Bernoulli <jonas@HIDDEN> In-Reply-To: <jwvtt98hu6y.fsf-monnier+emacs@HIDDEN> References: <87r04lbesf.fsf@HIDDEN> <jwvtt98hu6y.fsf-monnier+emacs@HIDDEN> Date: Thu, 06 Feb 2025 14:50:04 +0100 Message-ID: <87pljvp4hf.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Stefan Monnier <monnier@HIDDEN> writes: >> (easy-mmode-defmap smerge-mode-map >> `((,smerge-command-prefix . ,smerge-basic-map)) >> "Keymap for `smerge-mode'.") >> >> In Emacs 29.1 (after 2ae3b66fa80 and some fixup commits), the former >> remained as it was in 28, but the latter was replaced with: >> >> (defvar-keymap smerge-mode-map >> (key-description smerge-command-prefix) smerge-basic-map) >> >> Setting the option to "", to add no prefix command, results in: >> >> keymap--check: "" is not a valid key definition; see `key-valid-p' > > Emacs Emacs<29 setting the option to "" resulted in keeping > `smerge-mode-map` empty, AFAICT. Is that what you wanted or did you > expect all the bindings of `smerge-basic-map` to be made available > without a prefix? Well *I* am perfectly happy with the defaults. But there's at least one Magit user who never uses Smerge and thus doesn't want keymaps cluttered with its bindings. > To my mind the value "" would be closer to meaning that all the bindings > of `smerge-basic-map` should be made available without a prefix, and if > we want to allow the bindings to be completely absent, it might make > more sense to use a nil value. That does make sense to me too, but I don't think that users who have set this to "", to not even use a top-level binding for Smerge commands, would be happy if the meaning were changed to add *multiple* top-level bindings, that's worse for them than the default of one prefix keymap. So it might be better to use two new symbols, such as 'top-level and 'none, and make "" a backward compatibility alias for 'none.
X-Loop: help-debbugs@HIDDEN Subject: bug#75933: 29; Disabling smerge-command-prefix results in error Resent-From: Eli Zaretskii <eliz@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Sat, 22 Feb 2025 09:17:01 +0000 Resent-Message-ID: <handler.75933.B75933.17402157868472 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 75933 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Jonas Bernoulli <jonas@HIDDEN> Cc: 75933 <at> debbugs.gnu.org, monnier@HIDDEN Received: via spool by 75933-submit <at> debbugs.gnu.org id=B75933.17402157868472 (code B ref 75933); Sat, 22 Feb 2025 09:17:01 +0000 Received: (at 75933) by debbugs.gnu.org; 22 Feb 2025 09:16:26 +0000 Received: from localhost ([127.0.0.1]:47301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tllcX-0002CM-3n for submit <at> debbugs.gnu.org; Sat, 22 Feb 2025 04:16:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51594) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tllcU-0002BR-MQ for 75933 <at> debbugs.gnu.org; Sat, 22 Feb 2025 04:16:23 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tllcN-0003eR-Lq; Sat, 22 Feb 2025 04:16:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2/4bm0VDAY6YrTdy15p4QkHCkp941N9iBB0sMKC258I=; b=JfMm9PyEOgUz MW6DLYyoaCOlw96gr9pqI+2MhkIjvux3MLnzQx8aTW/EyI/eQtTAiV/ZCLdH3VZr24mB0DlGiezSN dKXE4p17zMEdHYUipYkhboT6i/Y3No9CD1to+uLgp01i9YBk5tIXIL/n7kR3L8Ex9MnxtDi6Sixuo dqb0eNGMB6jQYoVEm7mkUpxjXinygJbz3UYHMhKX3FKGKE1S78g/vklF7x4L2uIPRKnpqqwIhOxA+ pYkTHTjDjUfPRQ8fkVDkrMohySgFOe/LSsVdDNG2VBMDrukMX2hK0JZPB/R69O0G5/hQMWnUuHq9I mKE707/MpVn2vWpOEUaOLQ==; Date: Sat, 22 Feb 2025 11:16:14 +0200 Message-Id: <865xl2l4pt.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> In-Reply-To: <87pljvp4hf.fsf@HIDDEN> (bug-gnu-emacs@HIDDEN) References: <87r04lbesf.fsf@HIDDEN> <jwvtt98hu6y.fsf-monnier+emacs@HIDDEN> <87pljvp4hf.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Ping! How should we proceed with this issue? > Cc: 75933 <at> debbugs.gnu.org > Date: Thu, 06 Feb 2025 14:50:04 +0100 > From: Jonas Bernoulli via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > Stefan Monnier <monnier@HIDDEN> writes: > > >> (easy-mmode-defmap smerge-mode-map > >> `((,smerge-command-prefix . ,smerge-basic-map)) > >> "Keymap for `smerge-mode'.") > >> > >> In Emacs 29.1 (after 2ae3b66fa80 and some fixup commits), the former > >> remained as it was in 28, but the latter was replaced with: > >> > >> (defvar-keymap smerge-mode-map > >> (key-description smerge-command-prefix) smerge-basic-map) > >> > >> Setting the option to "", to add no prefix command, results in: > >> > >> keymap--check: "" is not a valid key definition; see `key-valid-p' > > > > Emacs Emacs<29 setting the option to "" resulted in keeping > > `smerge-mode-map` empty, AFAICT. Is that what you wanted or did you > > expect all the bindings of `smerge-basic-map` to be made available > > without a prefix? > > Well *I* am perfectly happy with the defaults. But there's at least one > Magit user who never uses Smerge and thus doesn't want keymaps cluttered > with its bindings. > > > To my mind the value "" would be closer to meaning that all the bindings > > of `smerge-basic-map` should be made available without a prefix, and if > > we want to allow the bindings to be completely absent, it might make > > more sense to use a nil value. > > That does make sense to me too, but I don't think that users who have > set this to "", to not even use a top-level binding for Smerge commands, > would be happy if the meaning were changed to add *multiple* top-level > bindings, that's worse for them than the default of one prefix keymap. > So it might be better to use two new symbols, such as 'top-level and > 'none, and make "" a backward compatibility alias for 'none. > > > >
X-Loop: help-debbugs@HIDDEN Subject: bug#75933: 29; Disabling smerge-command-prefix results in error Resent-From: Stefan Monnier <monnier@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Sat, 22 Feb 2025 16:24:01 +0000 Resent-Message-ID: <handler.75933.B75933.174024143532256 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 75933 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii <eliz@HIDDEN> Cc: Jonas Bernoulli <jonas@HIDDEN>, 75933 <at> debbugs.gnu.org Received: via spool by 75933-submit <at> debbugs.gnu.org id=B75933.174024143532256 (code B ref 75933); Sat, 22 Feb 2025 16:24:01 +0000 Received: (at 75933) by debbugs.gnu.org; 22 Feb 2025 16:23:55 +0000 Received: from localhost ([127.0.0.1]:56983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tlsIE-0008OB-Ld for submit <at> debbugs.gnu.org; Sat, 22 Feb 2025 11:23:55 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:35589) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <monnier@HIDDEN>) id 1tlsIB-0008Nu-QS for 75933 <at> debbugs.gnu.org; Sat, 22 Feb 2025 11:23:52 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id DE997440A26; Sat, 22 Feb 2025 11:23:43 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1740241422; bh=ip4oNgN30bVQkZsZUprQmg/9Ij22/tcKKT4WLaEyNrQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=mCubTGRJPKI4Z7NeahUDjh7ETxmk1jedxhGyGhoCAwua9fb6sz7HYSCnWFpP/bnRd pfnWLmJ1ryfdULqPLVYujGheSjGVyUDmwnnQfnPnft2+RmMU+9BRHEoRhYCHDmvmno 8jalGaDkegqhEsmJwTbwGoB0LGnFFg4gFaehzZXuo17XqvyY0biDeti+6EXnIaG8LG 1EyQNzJGlW4it3oTV6X5Q39oxeJcmsGUShIVTRFnkbfUXC5g6QSTYEH38p4NJDF9mx 6a+HsXOC4YGSJwaMOuVqYxPepdkCgQSrWuHUezF8+AJZI8QWzNdTn+VDs5dE4ypW0I g+tcwy68EE08A== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 5F1D2440B54; Sat, 22 Feb 2025 11:23:42 -0500 (EST) Received: from pastel (unknown [104.247.242.5]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2CF4F1202AB; Sat, 22 Feb 2025 11:23:42 -0500 (EST) From: Stefan Monnier <monnier@HIDDEN> In-Reply-To: <865xl2l4pt.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 22 Feb 2025 11:16:14 +0200") Message-ID: <jwvbjuut15o.fsf-monnier+emacs@HIDDEN> References: <87r04lbesf.fsf@HIDDEN> <jwvtt98hu6y.fsf-monnier+emacs@HIDDEN> <87pljvp4hf.fsf@HIDDEN> <865xl2l4pt.fsf@HIDDEN> Date: Sat, 22 Feb 2025 11:23:41 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.461 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Ping! How should we proceed with this issue? Maybe another way to look at it is that it's again bumping into `define-keymap`s limitation that you can't easily "deactivate" a binding. We saw that back in the bug#68213: if a keymap is defined where some of the key sequences are chosen dynamically (typically coming from a config var), we tend to get into trouble where it can be difficult/inconvenient to avoid duplicate key bindings (we fixed that problem by demoting that error to a warning), and similarly there's no easy way for the user to say "no key at all" (which was another way we could have fixed the problem in bug#68213). Maybe we should have an "impossible key sequence" (like we have the `regexp-unmatchable`) and offer it in the customization interface? And then arrange for `define-keymap` (and maybe others) to handle it accordingly. Not sure what that key sequence should be, but some choices that come to mind would be: - nil - [] (a.k.a "") - [impossible] Stefan >> Cc: 75933 <at> debbugs.gnu.org >> Date: Thu, 06 Feb 2025 14:50:04 +0100 >> From: Jonas Bernoulli via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> >> >> Stefan Monnier <monnier@HIDDEN> writes: >> >> >> (easy-mmode-defmap smerge-mode-map >> >> `((,smerge-command-prefix . ,smerge-basic-map)) >> >> "Keymap for `smerge-mode'.") >> >> >> >> In Emacs 29.1 (after 2ae3b66fa80 and some fixup commits), the former >> >> remained as it was in 28, but the latter was replaced with: >> >> >> >> (defvar-keymap smerge-mode-map >> >> (key-description smerge-command-prefix) smerge-basic-map) >> >> >> >> Setting the option to "", to add no prefix command, results in: >> >> >> >> keymap--check: "" is not a valid key definition; see `key-valid-p' >> > >> > Emacs Emacs<29 setting the option to "" resulted in keeping >> > `smerge-mode-map` empty, AFAICT. Is that what you wanted or did you >> > expect all the bindings of `smerge-basic-map` to be made available >> > without a prefix? >> >> Well *I* am perfectly happy with the defaults. But there's at least one >> Magit user who never uses Smerge and thus doesn't want keymaps cluttered >> with its bindings. >> >> > To my mind the value "" would be closer to meaning that all the bindings >> > of `smerge-basic-map` should be made available without a prefix, and if >> > we want to allow the bindings to be completely absent, it might make >> > more sense to use a nil value. >> >> That does make sense to me too, but I don't think that users who have >> set this to "", to not even use a top-level binding for Smerge commands, >> would be happy if the meaning were changed to add *multiple* top-level >> bindings, that's worse for them than the default of one prefix keymap. >> So it might be better to use two new symbols, such as 'top-level and >> 'none, and make "" a backward compatibility alias for 'none. >> >> >> >>
X-Loop: help-debbugs@HIDDEN Subject: bug#75933: 29; Disabling smerge-command-prefix results in error Resent-From: Daniel Colascione <dancol@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Sat, 22 Feb 2025 23:11:02 +0000 Resent-Message-ID: <handler.75933.B75933.174026585232717 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 75933 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 75933 <at> debbugs.gnu.org Cc: eliz@HIDDEN, jonas@HIDDEN, monnier@HIDDEN X-Debbugs-Original-To: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> X-Debbugs-Original-Cc: Eli Zaretskii <eliz@HIDDEN>, Jonas Bernoulli <jonas@HIDDEN>, 75933 <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN> Received: via spool by 75933-submit <at> debbugs.gnu.org id=B75933.174026585232717 (code B ref 75933); Sat, 22 Feb 2025 23:11:02 +0000 Received: (at 75933) by debbugs.gnu.org; 22 Feb 2025 23:10:52 +0000 Received: from localhost ([127.0.0.1]:57713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tlye3-0008Vd-L3 for submit <at> debbugs.gnu.org; Sat, 22 Feb 2025 18:10:51 -0500 Received: from dancol.org ([2600:3c01:e000:3d8::1]:44134) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <dancol@HIDDEN>) id 1tlye1-0008VS-H9 for 75933 <at> debbugs.gnu.org; Sat, 22 Feb 2025 18:10:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=42zFVbJpUOEEB1sGgQWXtWiYIm/PsnWR3pzqhbmX38Q=; b=TxDd7/TR3Wy6c8VL7KLfQD14Fw Lve0kOeRSbpgJWTRdI1/aA2+M1PqodAjioRk9Lql+x+gZofCtJ44llKp3MhDGPXJk+LMw8Z16tcE8 fmZr9MC/aFvsrbnTUskk9bHsRPtsNW8s/tFCdsB/Wv3Yao/ZgIqMlR5QvdRtBd84hVy9oM4jjhGk0 yYCR24h2gd9i2ohDubuVzMVb6yhuvwXaNFwUA+lm13DsVAbEd9xPBmoc188ujgCq4NEjtzTRcC38O EJe1j8Hu9k1yN96zlSUq7RRqoyUtobKjuEVaQvDRF/zIHdhuVjoz294DMMUjnmkL2B96klOLeQNGZ C5dPU6Gw==; Received: from dancol by dancol.org with local (Exim 4.96) (envelope-from <dancol@HIDDEN>) id 1tlydm-000psc-18; Sat, 22 Feb 2025 18:10:34 -0500 From: Daniel Colascione <dancol@HIDDEN> In-Reply-To: <jwvbjuut15o.fsf-monnier+emacs@HIDDEN> References: <87r04lbesf.fsf@HIDDEN> <jwvtt98hu6y.fsf-monnier+emacs@HIDDEN> <87pljvp4hf.fsf@HIDDEN> <865xl2l4pt.fsf@HIDDEN> <jwvbjuut15o.fsf-monnier+emacs@HIDDEN> User-Agent: mu4e 1.12.8; emacs 31.0.50 Date: Sat, 22 Feb 2025 18:10:36 -0500 Message-ID: <m11pvpd18z.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> writes: >> Ping! How should we proceed with this issue? > > Maybe another way to look at it is that it's again bumping into > `define-keymap`s limitation that you can't easily "deactivate" > a binding. > > We saw that back in the bug#68213: if a keymap is defined where some of > the key sequences are chosen dynamically (typically coming from a config > var), we tend to get into trouble where it can be difficult/inconvenient > to avoid duplicate key bindings (we fixed that problem by demoting that > error to a warning), and similarly there's no easy way for the user to > say "no key at all" (which was another way we could have fixed the > problem in bug#68213). > > Maybe we should have an "impossible key sequence" (like we have the > `regexp-unmatchable`) and offer it in the customization interface? The question is ill-formed. Why do we have keymaps with bindings based on random defcustoms in the first place? The proper place to customize a keymap is the keymap.
X-Loop: help-debbugs@HIDDEN Subject: bug#75933: 29; Disabling smerge-command-prefix results in error Resent-From: Daniel Colascione <dancol@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Sat, 22 Feb 2025 23:12:01 +0000 Resent-Message-ID: <handler.75933.B.1740265898361 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 75933 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 75933 <at> debbugs.gnu.org Cc: eliz@HIDDEN, jonas@HIDDEN, monnier@HIDDEN X-Debbugs-Original-To: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> X-Debbugs-Original-Cc: Eli Zaretskii <eliz@HIDDEN>, Jonas Bernoulli <jonas@HIDDEN>, 75933 <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN> Received: via spool by submit <at> debbugs.gnu.org id=B.1740265898361 (code B ref -1); Sat, 22 Feb 2025 23:12:01 +0000 Received: (at submit) by debbugs.gnu.org; 22 Feb 2025 23:11:38 +0000 Received: from localhost ([127.0.0.1]:57717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tlyen-00005k-88 for submit <at> debbugs.gnu.org; Sat, 22 Feb 2025 18:11:37 -0500 Received: from lists.gnu.org ([2001:470:142::17]:43318) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <dancol@HIDDEN>) id 1tlye3-0008VN-Tt for submit <at> debbugs.gnu.org; Sat, 22 Feb 2025 18:10:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <dancol@HIDDEN>) id 1tlydy-0005XI-2H for bug-gnu-emacs@HIDDEN; Sat, 22 Feb 2025 18:10:46 -0500 Received: from dancol.org ([2600:3c01:e000:3d8::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <dancol@HIDDEN>) id 1tlydw-0001Ay-8u; Sat, 22 Feb 2025 18:10:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=42zFVbJpUOEEB1sGgQWXtWiYIm/PsnWR3pzqhbmX38Q=; b=TxDd7/TR3Wy6c8VL7KLfQD14Fw Lve0kOeRSbpgJWTRdI1/aA2+M1PqodAjioRk9Lql+x+gZofCtJ44llKp3MhDGPXJk+LMw8Z16tcE8 fmZr9MC/aFvsrbnTUskk9bHsRPtsNW8s/tFCdsB/Wv3Yao/ZgIqMlR5QvdRtBd84hVy9oM4jjhGk0 yYCR24h2gd9i2ohDubuVzMVb6yhuvwXaNFwUA+lm13DsVAbEd9xPBmoc188ujgCq4NEjtzTRcC38O EJe1j8Hu9k1yN96zlSUq7RRqoyUtobKjuEVaQvDRF/zIHdhuVjoz294DMMUjnmkL2B96klOLeQNGZ C5dPU6Gw==; Received: from dancol by dancol.org with local (Exim 4.96) (envelope-from <dancol@HIDDEN>) id 1tlydm-000psc-18; Sat, 22 Feb 2025 18:10:34 -0500 From: Daniel Colascione <dancol@HIDDEN> In-Reply-To: <jwvbjuut15o.fsf-monnier+emacs@HIDDEN> References: <87r04lbesf.fsf@HIDDEN> <jwvtt98hu6y.fsf-monnier+emacs@HIDDEN> <87pljvp4hf.fsf@HIDDEN> <865xl2l4pt.fsf@HIDDEN> <jwvbjuut15o.fsf-monnier+emacs@HIDDEN> User-Agent: mu4e 1.12.8; emacs 31.0.50 Date: Sat, 22 Feb 2025 18:10:36 -0500 Message-ID: <m11pvpd18z.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2600:3c01:e000:3d8::1; envelope-from=dancol@HIDDEN; helo=dancol.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.1 (/) Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> writes: >> Ping! How should we proceed with this issue? > > Maybe another way to look at it is that it's again bumping into > `define-keymap`s limitation that you can't easily "deactivate" > a binding. > > We saw that back in the bug#68213: if a keymap is defined where some of > the key sequences are chosen dynamically (typically coming from a config > var), we tend to get into trouble where it can be difficult/inconvenient > to avoid duplicate key bindings (we fixed that problem by demoting that > error to a warning), and similarly there's no easy way for the user to > say "no key at all" (which was another way we could have fixed the > problem in bug#68213). > > Maybe we should have an "impossible key sequence" (like we have the > `regexp-unmatchable`) and offer it in the customization interface? The question is ill-formed. Why do we have keymaps with bindings based on random defcustoms in the first place? The proper place to customize a keymap is the keymap.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.