Juri Linkov <juri@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 75935) by debbugs.gnu.org; 30 Jan 2025 18:38:38 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 30 13:38:38 2025 Received: from localhost ([127.0.0.1]:47771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tdZR0-00007v-9Q for submit <at> debbugs.gnu.org; Thu, 30 Jan 2025 13:38:38 -0500 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]:53587) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1tdZQm-00006W-1L; Thu, 30 Jan 2025 13:38:24 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 65CF4442D5; Thu, 30 Jan 2025 18:38:15 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Ship Mints <shipmints@HIDDEN> Subject: Re: bug#75935: tab-bar-select-tab buffer-list and buried-buffer-list bug In-Reply-To: <CAN+1HbpwPiAVcr-irQqUP7DT2z3BS4ZL3bq5_kz2CZHcJSxaHg@HIDDEN> (Ship Mints's message of "Thu, 30 Jan 2025 07:29:33 -0500") Organization: LINKOV.NET References: <CAN+1HbqyY1F2TRb_Td75LHH1ODVeQE8tD+YTHcCa2CD_7K6pTA@HIDDEN> <87a5b8ycsp.fsf@HIDDEN> <CAN+1HbpwPiAVcr-irQqUP7DT2z3BS4ZL3bq5_kz2CZHcJSxaHg@HIDDEN> Date: Thu, 30 Jan 2025 20:35:27 +0200 Message-ID: <87a5b8taj5.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdeiheeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrdeliedrledtnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehinhgvthepledurdduvdelrdeliedrledtpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepfedprhgtphhtthhopegtohhnthhrohhlseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepjeehleefheesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehshhhiphhmihhnthhssehgmhgrihhlrdgtohhm X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75935 Cc: 75935 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) close 75935 31.0.50 thanks > No problem. Patch attached. Thanks for the fix, this is pushed as well.
bug-gnu-emacs@HIDDEN:bug#75935; Package emacs.
Full text available.Received: (at 75935) by debbugs.gnu.org; 30 Jan 2025 12:31:34 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 30 07:31:34 2025 Received: from localhost ([127.0.0.1]:44902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tdThl-00011n-Rv for submit <at> debbugs.gnu.org; Thu, 30 Jan 2025 07:31:34 -0500 Received: from mail-vs1-xe29.google.com ([2607:f8b0:4864:20::e29]:50301) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <shipmints@HIDDEN>) id 1tdThj-0000o3-4C for 75935 <at> debbugs.gnu.org; Thu, 30 Jan 2025 07:31:32 -0500 Received: by mail-vs1-xe29.google.com with SMTP id ada2fe7eead31-4afe1009960so192652137.0 for <75935 <at> debbugs.gnu.org>; Thu, 30 Jan 2025 04:31:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738240285; x=1738845085; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=wbnpxakIXu+ehiDOdbqXOavJcxaAeavFcVYqd7nB2fE=; b=RoZW6ZILbw6cGkvdgcsAn2NhS78RgOG5AE81/jPYLLYDYBQyZmVrCJEJfxDlmf1iZb eNxXUoA08ti2AzhKIHgUJgCnTw2OSljiKKUMw14iVuXUIP7WVYi6W77idu3Wll0rou7G ZlQN+18Kb8p5AC8GfahubnoXDB52ME2d6oKlHdktkGXdxwVufer2hII0yL3abLbl10AI ipLvRn7NnWm6xJ1mXWNA+rpzWmuUUC6aajhWZBYrS2+Nr7qWDnvdCzcw97+CIxH1EgMK XAy/eKrLmFLdzEMQCxe6MBkQfPInilOeo4u0+F8vDPP4gO7rLt8oe4dnEck6pP8mdYtg JXgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738240285; x=1738845085; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wbnpxakIXu+ehiDOdbqXOavJcxaAeavFcVYqd7nB2fE=; b=cm1FFrBHmzltOlktHWanK31VN7UgZiG2dTSRLjvmFvFbY67Bb8vSJcaHB3SAB0hfN/ L8JbmqKs3RsNNc5vgNnLJSwI1fMmrLY2bk/qYKMBOOeuJwjVcsuRpHTeLr+blLsfVJ4e 44g1Vh7CxaCp6uR2ALMdpNdEgiO3YZzEwFAw8KXCM1Q7s0o+E9a53uRnqiu+vHl3h3Yv CP4drgF+cE8TX6c+bv3g+zUw8fRqSC56+wgSxsR3SMo6rkNTkWlIocjAa7WByfSJWZZA dG/eT5/p/vmrI8RXdaCvOhQ0ST89ZPg52IwjHHyhb1XojF7f//OVTjin96mxS2RJvIgI 8L2A== X-Gm-Message-State: AOJu0YybJTRUHT2NwxgbGI7L4lw9eTLpACtVxrELycRkg/K/k5UL4TBR jlXh6j5RizrT5TjNT1G9WiUa/OUlOLCSXfawRO4nklurxd9YKrlzDxV7C44J8LdK1zA+4ASEoHF HyCXr2gOBNv9m5VCSfNi+fD5h/xbS8g== X-Gm-Gg: ASbGnctf7I/NknIQrTBW+ZMwUBr0ZjlP9mQnqlCC/de+nhaA/IdlBaHWaz/cBD0YkdC LCnvE9FKUGIZ8AJca4D6bzzpO/h0/S21Sk8AyEiOsIONLD8VxzY0wgMFcLSeitY4Jd+MYlLSF X-Google-Smtp-Source: AGHT+IFk2CMgpM+G6jxUrvZs9DfU37882aDlSNftUcnHpux9CHO3d17rbt3RmuO8JXwJG00ZSmwbA3lE3yz9WkFIkdw= X-Received: by 2002:a05:6102:5128:b0:4b2:bc9f:3f91 with SMTP id ada2fe7eead31-4b9a5268ffbmr5627466137.21.1738240285348; Thu, 30 Jan 2025 04:31:25 -0800 (PST) MIME-Version: 1.0 References: <CAN+1HbqyY1F2TRb_Td75LHH1ODVeQE8tD+YTHcCa2CD_7K6pTA@HIDDEN> <87a5b8ycsp.fsf@HIDDEN> In-Reply-To: <87a5b8ycsp.fsf@HIDDEN> From: Ship Mints <shipmints@HIDDEN> Date: Thu, 30 Jan 2025 07:29:33 -0500 X-Gm-Features: AWEUYZmVTHmgxNj6f4KCMWq5BgceQIHQur2saYTFxslQeHIXLevjqEl8bi1L-Kw Message-ID: <CAN+1HbpwPiAVcr-irQqUP7DT2z3BS4ZL3bq5_kz2CZHcJSxaHg@HIDDEN> Subject: Re: bug#75935: tab-bar-select-tab buffer-list and buried-buffer-list bug To: Juri Linkov <juri@HIDDEN> Content-Type: multipart/mixed; boundary="000000000000be659e062ceb9aed" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75935 Cc: 75935 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --000000000000be659e062ceb9aed Content-Type: multipart/alternative; boundary="000000000000be659d062ceb9aeb" --000000000000be659d062ceb9aeb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable No problem. Patch attached. On Thu, Jan 30, 2025 at 2:38=E2=80=AFAM Juri Linkov <juri@HIDDEN> wrote= : > > Happy to submit a patch for this but first wanted to discuss it to make > > sure there's agreement. > > > > (defun tab-bar-select-tab (&optional tab-number) > > ... > > (when wc-bl (set-frame-parameter nil 'buffer-list wc-bl)) > > (when wc-bbl (set-frame-parameter nil 'buried-buffer-list > > wc-bbl)) > > > > What this skips is that if either the originating window-configuration > > buffer-list or its twin is nil, that the frame's parameters are not > > properly reset to nil. > > > > This is a function that we've had to work around in an ELPA package by > > advising tab-bar--tab to first clear these frame parameters before > > tab-bar-select-tab goes to set them when selecting the specified tab. > This > > avoids the bug, but is annoying. This advice has been in place for thre= e > > years without issue. > > > > The patch would eliminate the 'when' conditions. > > > > What do you think? > > Thanks for finding this bug! > > A week ago I fixed a similar bug in 6b71d0b1786 > where needed to reset tab-bar-history-back to nil > after selecting the specified tab. > We should do the same for buffer-lists as well. > > So you proposed the right fix. Please submit a patch. > Then I will push all your other patches too. > --000000000000be659d062ceb9aeb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:monospac= e">No problem. Patch attached.</div></div><br><div class=3D"gmail_quote gma= il_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Thu, Jan 30, 2= 025 at 2:38=E2=80=AFAM Juri Linkov <<a href=3D"mailto:juri@HIDDEN">j= uri@HIDDEN</a>> wrote:<br></div><blockquote class=3D"gmail_quote" st= yle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padd= ing-left:1ex">> Happy to submit a patch for this but first wanted to dis= cuss it to make<br> > sure there's agreement.<br> ><br> > (defun tab-bar-select-tab (&optional tab-number)<br> > ...<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(when wc-bl=C2=A0 (set-= frame-parameter nil 'buffer-list wc-bl))<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(when wc-bbl (set-frame= -parameter nil 'buried-buffer-list<br> > wc-bbl))<br> ><br> > What this skips is that if either the originating window-configuration= <br> > buffer-list or its twin is nil, that the frame's parameters are no= t<br> > properly reset to nil.<br> ><br> > This is a function that we've had to work around in an ELPA packag= e by<br> > advising tab-bar--tab to first clear these frame parameters before<br> > tab-bar-select-tab goes to set them when selecting the specified tab. = This<br> > avoids the bug, but is annoying. This advice has been in place for thr= ee<br> > years without issue.<br> ><br> > The patch would eliminate the 'when' conditions.<br> ><br> > What do you think?<br> <br> Thanks for finding this bug!<br> <br> A week ago I fixed a similar bug in 6b71d0b1786<br> where needed to reset tab-bar-history-back to nil<br> after selecting the specified tab.<br> We should do the same for buffer-lists as well.<br> <br> So you proposed the right fix.=C2=A0 Please submit a patch.<br> Then I will push all your other patches too.<br> </blockquote></div> --000000000000be659d062ceb9aeb-- --000000000000be659e062ceb9aed Content-Type: application/octet-stream; name="0001-lisp-tab-bar.el-tab-bar-select-tab-Fix-wc-bl-wc-bbl-.patch" Content-Disposition: attachment; filename="0001-lisp-tab-bar.el-tab-bar-select-tab-Fix-wc-bl-wc-bbl-.patch" Content-Transfer-Encoding: base64 Content-ID: <f_m6jbbej40> X-Attachment-Id: f_m6jbbej40 RnJvbSBlYTM2MThlMjliNWVlMDIzOGZkOWRmZGNjYzhmYWQ5NDMwZTJkODViIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBzaGlwbWludHMgPHNoaXBtaW50c0BnbWFpbC5jb20+CkRhdGU6 IFRodSwgMzAgSmFuIDIwMjUgMDc6MjA6MzQgLTA1MDAKU3ViamVjdDogW1BBVENIXSAqIGxpc3Av dGFiLWJhci5lbCAodGFiLWJhci1zZWxlY3QtdGFiKTogRml4IHdjLWJsL3djLWJibCB3aGVuCiBu aWwKClJlbW92ZSB0aGUgbmlsLWNoZWNrIGNvbmRpdGlvbmFscyBhcm91bmQgJ3djLWJsJyBhbmQg J3djLWJibCcgdGhhdCByZXNldApmcmFtZSBwYXJhbWV0ZXJzICdidWZmZXItbGlzdCcgYW5kICdi dXJpZWQtYnVmZmVyLWxpc3QnLiBUaGlzIGVuc3VyZXMKb3JpZ2luYXRpbmcgbmlsIHZhbHVlcyBj b3JyZWN0bHkgcHJvcGFnYXRlLgotLS0KIGxpc3AvdGFiLWJhci5lbCB8IDQgKystLQogMSBmaWxl IGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9s aXNwL3RhYi1iYXIuZWwgYi9saXNwL3RhYi1iYXIuZWwKaW5kZXggYjU3MDk0OWJmZWMuLjg4ZjMz ZDJiZGMyIDEwMDY0NAotLS0gYS9saXNwL3RhYi1iYXIuZWwKKysrIGIvbGlzcC90YWItYmFyLmVs CkBAIC0xNjQzLDggKzE2NDMsOCBAQCB0YWItYmFyLXNlbGVjdC10YWIKICAgICAgICAgICAgICAg ICAgICAgICAgKG1hcmtlci1idWZmZXIgd2MtcG9pbnQpKQogICAgICAgICAgICAgICAoZ290by1j aGFyIHdjLXBvaW50KSkKIAotICAgICAgICAgICAgKHdoZW4gd2MtYmwgIChzZXQtZnJhbWUtcGFy YW1ldGVyIG5pbCAnYnVmZmVyLWxpc3Qgd2MtYmwpKQotICAgICAgICAgICAgKHdoZW4gd2MtYmJs IChzZXQtZnJhbWUtcGFyYW1ldGVyIG5pbCAnYnVyaWVkLWJ1ZmZlci1saXN0IHdjLWJibCkpCisg ICAgICAgICAgICAoc2V0LWZyYW1lLXBhcmFtZXRlciBuaWwgJ2J1ZmZlci1saXN0IHdjLWJsKQor ICAgICAgICAgICAgKHNldC1mcmFtZS1wYXJhbWV0ZXIgbmlsICdidXJpZWQtYnVmZmVyLWxpc3Qg d2MtYmJsKQogCiAgICAgICAgICAgICAod2hlbiB0YWItYmFyLWhpc3RvcnktbW9kZQogICAgICAg ICAgICAgICAocHV0aGFzaCAoc2VsZWN0ZWQtZnJhbWUpCi0tIAoyLjQ3LjEKCg== --000000000000be659e062ceb9aed--
bug-gnu-emacs@HIDDEN:bug#75935; Package emacs.
Full text available.Received: (at 75935) by debbugs.gnu.org; 30 Jan 2025 07:38:27 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 30 02:38:27 2025 Received: from localhost ([127.0.0.1]:44128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tdP87-0008UG-Bh for submit <at> debbugs.gnu.org; Thu, 30 Jan 2025 02:38:27 -0500 Received: from relay8-d.mail.gandi.net ([2001:4b98:dc4:8::228]:33461) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1tdP83-0008Tr-5v for 75935 <at> debbugs.gnu.org; Thu, 30 Jan 2025 02:38:24 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 885644441A; Thu, 30 Jan 2025 07:38:14 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Ship Mints <shipmints@HIDDEN> Subject: Re: bug#75935: tab-bar-select-tab buffer-list and buried-buffer-list bug In-Reply-To: <CAN+1HbqyY1F2TRb_Td75LHH1ODVeQE8tD+YTHcCa2CD_7K6pTA@HIDDEN> (Ship Mints's message of "Wed, 29 Jan 2025 15:59:49 -0500") Organization: LINKOV.NET References: <CAN+1HbqyY1F2TRb_Td75LHH1ODVeQE8tD+YTHcCa2CD_7K6pTA@HIDDEN> Date: Thu, 30 Jan 2025 09:35:18 +0200 Message-ID: <87a5b8ycsp.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdehvdefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrdeliedrledtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrdeliedrledtpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepvddprhgtphhtthhopeejheelfeehseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepshhhihhpmhhinhhtshesghhmrghilhdrtghomh X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75935 Cc: 75935 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) > Happy to submit a patch for this but first wanted to discuss it to make > sure there's agreement. > > (defun tab-bar-select-tab (&optional tab-number) > ... > (when wc-bl (set-frame-parameter nil 'buffer-list wc-bl)) > (when wc-bbl (set-frame-parameter nil 'buried-buffer-list > wc-bbl)) > > What this skips is that if either the originating window-configuration > buffer-list or its twin is nil, that the frame's parameters are not > properly reset to nil. > > This is a function that we've had to work around in an ELPA package by > advising tab-bar--tab to first clear these frame parameters before > tab-bar-select-tab goes to set them when selecting the specified tab. This > avoids the bug, but is annoying. This advice has been in place for three > years without issue. > > The patch would eliminate the 'when' conditions. > > What do you think? Thanks for finding this bug! A week ago I fixed a similar bug in 6b71d0b1786 where needed to reset tab-bar-history-back to nil after selecting the specified tab. We should do the same for buffer-lists as well. So you proposed the right fix. Please submit a patch. Then I will push all your other patches too.
bug-gnu-emacs@HIDDEN:bug#75935; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 29 Jan 2025 21:02:12 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 29 16:02:12 2025
Received: from localhost ([127.0.0.1]:43239 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tdFCO-0005Kk-AK
for submit <at> debbugs.gnu.org; Wed, 29 Jan 2025 16:02:12 -0500
Received: from lists.gnu.org ([2001:470:142::17]:39208)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <shipmints@HIDDEN>)
id 1tdFCL-0005Jp-Lh
for submit <at> debbugs.gnu.org; Wed, 29 Jan 2025 16:02:10 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <shipmints@HIDDEN>)
id 1tdFBv-0000Uj-Bs
for bug-gnu-emacs@HIDDEN; Wed, 29 Jan 2025 16:01:45 -0500
Received: from mail-oa1-x35.google.com ([2001:4860:4864:20::35])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <shipmints@HIDDEN>)
id 1tdFBt-00057U-RS
for bug-gnu-emacs@HIDDEN; Wed, 29 Jan 2025 16:01:43 -0500
Received: by mail-oa1-x35.google.com with SMTP id
586e51a60fabf-29fe7ff65e6so34204fac.0
for <bug-gnu-emacs@HIDDEN>; Wed, 29 Jan 2025 13:01:41 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1738184500; x=1738789300; darn=gnu.org;
h=to:subject:message-id:date:from:mime-version:from:to:cc:subject
:date:message-id:reply-to;
bh=guxN3swjDhY6m8gHa5suzA7Xa0UsiEeSweVButZmpb0=;
b=FgmNp3Jiq0k662p2WP2bkkiWZ3vHvmZt2U4B6DbSMt4yGJOBZDGIZj+pXN21VKamIq
WpWMkA7z51pRihrLLsGUKDmKVU48Xw4e9qlz0wO+DETHmPefdIH3ZbC5VYsASq3D89Lg
6o1zeZ7h9chLKxaL0w89iBaQUk7WcQH3buEYnPHa4ZG3JwmPLXgOGhVGKkls/cK5TNhk
BEbc31qpnD6c9AoegyK7jUR9oBemzYU5SlftsIB2DqTnXpSH/cpCNkF5sTCL95ikQ6My
daG7XEnqEZ2KxNlQ0I9OgoIcVf5mvOipZ2YibPV1SyZpAS0WKDApHN6DqvJITqp9lZQD
J8Ww==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1738184500; x=1738789300;
h=to:subject:message-id:date:from:mime-version:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=guxN3swjDhY6m8gHa5suzA7Xa0UsiEeSweVButZmpb0=;
b=N4lcbv42zMnDOkh5jiE6EzPuaHdyQPaGBcJRIpSRDPkhZRqbpWysYg2kjU1SMykSCn
/t2TMvPURzO87S2G9x8kdOJQNPKLMfkTbcMJ588N/nz+HLD88mzD3jNWXorvTMsfIfdv
76QeNtdJySLl1SjuXMX3qbLgY4gDdVuJFOdHaRLnCoPdOikvUYv8VVfK+C6unQcXCIGP
4SK46Q0sIZNeEUInuLR26UPpkFQYY1JkDsg2qA1H14h42iZdRD/B72HGXyTH+b8bPpAq
JhYkM2LDPaueU/d0QwS9s57dGOXAY5U7iMGqx7eCraA9e3KIUSJzcJn38I/lyaMG2J+j
iQpQ==
X-Gm-Message-State: AOJu0YywKDVaCLOsN3YocqapVPrujf4+QHuM5+YrSHw6GXx+jixDwkmy
Z7VoRKqbDc/blAYZLvcRq4WnogS+aK7KzW0CcDzEfyImZCzIN+i7xr8YojOGmvPWyi7oE4U31uM
C+pfj3yxNeAK2KlWQNMyNrIUVu3rdWWEb
X-Gm-Gg: ASbGncszXKZoTZQvwQ+gQi/Z91Thmce70eA6B3FfyLvmJTHG1wvUQ9KGgjkZvsBbJzC
1FetRHKyvl3Rkf1kwWTmpjJSM+UzUExpS0hydVl9Dfh9Arpp5rqVJ+olUfd8RhCX0RZxCSeea
X-Google-Smtp-Source: AGHT+IFiYDZqf9foMNxVpdKYpVmKyRoAopDaepKBNS1cNNRiyv6mwmxUcPkE9gjRQaxA60vKzLxNnpAldYxh1NTNFbA=
X-Received: by 2002:a05:6871:5e04:b0:29e:6bdb:e362 with SMTP id
586e51a60fabf-2b32f12d880mr2450506fac.17.1738184500006; Wed, 29 Jan 2025
13:01:40 -0800 (PST)
MIME-Version: 1.0
From: Ship Mints <shipmints@HIDDEN>
Date: Wed, 29 Jan 2025 15:59:49 -0500
X-Gm-Features: AWEUYZkrd39trbjDedUe1Lo3AevqpWEj6xV29CJ8EMzKvJQY_68P2npR3NyOFL0
Message-ID: <CAN+1HbqyY1F2TRb_Td75LHH1ODVeQE8tD+YTHcCa2CD_7K6pTA@HIDDEN>
Subject: tab-bar-select-tab buffer-list and buried-buffer-list bug
To: bug-gnu-emacs@HIDDEN, Juri Linkov <juri@HIDDEN>
Content-Type: multipart/alternative; boundary="000000000000ad59f7062cde9d72"
Received-SPF: pass client-ip=2001:4860:4864:20::35;
envelope-from=shipmints@HIDDEN; helo=mail-oa1-x35.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
--000000000000ad59f7062cde9d72
Content-Type: text/plain; charset="UTF-8"
Happy to submit a patch for this but first wanted to discuss it to make
sure there's agreement.
(defun tab-bar-select-tab (&optional tab-number)
...
(when wc-bl (set-frame-parameter nil 'buffer-list wc-bl))
(when wc-bbl (set-frame-parameter nil 'buried-buffer-list
wc-bbl))
What this skips is that if either the originating window-configuration
buffer-list or its twin is nil, that the frame's parameters are not
properly reset to nil.
This is a function that we've had to work around in an ELPA package by
advising tab-bar--tab to first clear these frame parameters before
tab-bar-select-tab goes to set them when selecting the specified tab. This
avoids the bug, but is annoying. This advice has been in place for three
years without issue.
The patch would eliminate the 'when' conditions.
What do you think?
-Stephane
--000000000000ad59f7062cde9d72
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:monospac=
e">Happy to submit a patch for this but first wanted to discuss it to make =
sure there's agreement.</div><div class=3D"gmail_default" style=3D"font=
-family:monospace"><br></div><div class=3D"gmail_default" style=3D"font-fam=
ily:monospace">(defun tab-bar-select-tab (&optional tab-number)<br></di=
v><div class=3D"gmail_default" style=3D"font-family:monospace">...</div><di=
v class=3D"gmail_default" style=3D"font-family:monospace">=C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 (when wc-bl =C2=A0(set-frame-parameter nil 'bu=
ffer-list wc-bl))<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (when wc-bbl=
(set-frame-parameter nil 'buried-buffer-list wc-bbl))<br></div><div cl=
ass=3D"gmail_default" style=3D"font-family:monospace"><br></div><div class=
=3D"gmail_default" style=3D"font-family:monospace">What this skips is that =
if either the originating window-configuration buffer-list or its twin is n=
il, that the frame's parameters are not properly reset to nil.</div><di=
v class=3D"gmail_default" style=3D"font-family:monospace"><br></div><div cl=
ass=3D"gmail_default" style=3D"font-family:monospace">This is a function th=
at we've had to work around in an ELPA package by advising tab-bar--tab=
to first clear these frame parameters before tab-bar-select-tab goes to se=
t them when selecting the specified tab. This avoids the bug, but is annoyi=
ng. This advice has been in place for three years without issue.</div><div =
class=3D"gmail_default" style=3D"font-family:monospace"><br></div><div clas=
s=3D"gmail_default" style=3D"font-family:monospace">The patch would elimina=
te the 'when' conditions.</div><div class=3D"gmail_default" style=
=3D"font-family:monospace"><br></div><div class=3D"gmail_default" style=3D"=
font-family:monospace">What do you think?</div><div class=3D"gmail_default"=
style=3D"font-family:monospace"><br></div><div class=3D"gmail_default" sty=
le=3D"font-family:monospace">-Stephane</div></div>
--000000000000ad59f7062cde9d72--
Ship Mints <shipmints@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#75935; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.