Received: (at 76446-done) by debbugs.gnu.org; 7 Mar 2025 08:14:30 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 07 03:14:30 2025 Received: from localhost ([127.0.0.1]:46853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tqSqj-0003x3-P6 for submit <at> debbugs.gnu.org; Fri, 07 Mar 2025 03:14:30 -0500 Received: from mout.gmx.net ([212.227.15.19]:49859) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <michael.albinus@HIDDEN>) id 1tqSqg-0003wl-JL for 76446-done <at> debbugs.gnu.org; Fri, 07 Mar 2025 03:14:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1741335257; x=1741940057; i=michael.albinus@HIDDEN; bh=Zk8jKE/YhbgELM2zP7aMavCOvUtd7U2jnkQSbdhrf4c=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=I8sRHFO6ck14fIWDqKIjKiaBlORCURMgVd6L04kV1KkPqmay8ACDpF5XLxC3kAqr y3nRPVeOHRP8pPqWMOIJ3Mg65v1ZVTf+h4mpTGx6nCXoFZ3PEy15OnGQQvIwLKl38 f1O0hYa2RTetoVQyYaUYKz/+A5iAzsL43GcINjFl6LhenmP/jbozGj4WwTat1AKeS OukDAgoahMKZMLykwLO8wtdDFA9LvsbUNeXRSpNfwTMwaaj0vqHzDQWqp3lIiJZqJ K+gHqbtgs1vYUntia8STREhMWSL9+a5Cz0nfeKJ62t1M+vR++qm9dB5MsX9ZpBdWl QdDB8fTWJuoJQE2EQA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.37.59]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M59C2-1trZJF2QRY-00GgjB; Fri, 07 Mar 2025 09:14:17 +0100 From: Michael Albinus <michael.albinus@HIDDEN> To: Maxim Cournoyer <maxim.cournoyer@HIDDEN> Subject: Re: bug#76446: [Patch Debbugs] Infrastructure Improvements In-Reply-To: <87a5a4gga1.fsf@HIDDEN> References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN> <87bjuvy17p.fsf@HIDDEN> <CH3PR84MB3424807016C1C6E6EBCD08E6C5C72@HIDDEN> <CH3PR84MB3424F04FC0B2977D0234503BC5C12@HIDDEN> <874j0jyy3n.fsf@HIDDEN> <CH3PR84MB342487797E764F59AC3A9724C5C32@HIDDEN> <87o6ypx1ps.fsf@HIDDEN> <87jz9amg1k.fsf@HIDDEN> <87ikoshi1i.fsf_-_@HIDDEN> <87a5a4lha2.fsf@HIDDEN> <87a5a4gga1.fsf@HIDDEN> Date: Fri, 07 Mar 2025 09:14:17 +0100 Message-ID: <87a59xgsva.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:AFpWHShAGFWhPNuWuaY8o6DvOqDcf4JAo4w0g6yEABRlneiDstu +veQpv3vhTjCeNpC/zFR6Pg7A2ziKOfFe/GDUNj+mgDOU/ERL5zaXZCsGnN0GitpHPsW9w2 g6JtCczRMrbAUA5UVhWlbdWScv4jJEf4UOeF/+WjaRyPWPxLiCO/tgO45UGrI+KXf62dFTW QkmG150PKABSKywHnSNhw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:FephPQLAOa0=;vuEd9ELOh5jTN716KCzamUyB0Bo n78qGEF81l18iy6NI6qhvjuT22bw0F+EA/gWNvxU377dDswDg3LVLugpIM516UckM1kYFA40M ogo3j1fisc+D3UsqWEjUftZ78I9Jtw5MUh/wYOhoyQ8LyGqQizhajwt5+mn1UxF7VUsWlozsC v9xhE9L/CQX7lLDB06eKlv/Yk393ttZQV65ahLqZEiI5GTRpzJy+qGGPPM474IxUMn7InPuAT WLb9EykjfTdVGGawI48Jv7EL9FXsMTZrcIZYM/eN7V22d+ROlNkeC4vigKs0n3Jw7z7WMX4xE GoEoaivhdqiL/3XGHQsvZlQ1L5XfwqbXPyiDcWRexmWy3j7TvyMiieZNoeSZXpgroRHJS80UC NJtuzMPs3kBA0MK8iSFXciWLOhdvbWyy6i9EeFkDSWr1EJMaOh/wBy5yevPU3bu+5wEWBErLD 9jJssBoDF0Hp2UQBBEv966FziwWffvVN0ApIFR0ZfUZB4wcT5L9O49cuFYY+Jl2sEGvXWVhZh rKjuRCMl+ffft3Y00ZU9EUhFb6/6Q6BFG4FC5UGyHsn1swbue0BsWVxE8N/VTKHcZ8rvEBJe3 3pW8Ra7FmDJaQ0o3SP36WJ858Vb6ictZlwvG4HToCPollx++ilq4Lwvoyj089O4Tsqx9VFr2h WvgbvrEBYoLrZVqXYqgcz57DjixhSkE3WJl9XyVraJZ+KUVXMDNh8ydLRgOdkoEVKgMxX/rDe +FuTBKwgdzNdhmRTAfk7nkYHmE9i3qB+W6PGZuBDVgRbaQB4tJxIErOjFRYjXDBinV2gW4JMY +OCI4hhkOQU/uVN6IbO6hdkYv1+G+TQm9NCkD3FfeBPwiU+KA2m1rYJRQAZGbxUaKY4oOERCW wxEKYwaj6qKWW9moPMU+t1J2kgWlB8/SmL5PiDF2am3f/11r2KuS/pcrR3E1RmML8nrWAFMX1 1v2VG2UStc1LgSrjJt+voJZa1QRtmbCbV5gY23EImM9bi0y84Lh/s9DwiWx0piUlM1x6bEuaK 5qAup9I94OT3LA+e0uXhIRWUi2n+T/tLmIuIJ11lOLszoVie9n3mIpc2zj4ngNAiqBLUJEWC9 ZieOMDkrz2M2iDPGeiEr32yLsg8E3nBS1fyiExy4084JXV4E/ojFvw/hxXvMUYXafs5+L9dFe gzgZlJAcBRgNdrMqCPa31jljc2WbLu3wJRSIGmPXwgRHiYcRmEpv+jZi4+qvDUyHw4aAJNQod 8Zdj9p6ZFxIsVUDy86VCkwmrbqbFV/Zfw7dTDpnBUWpvtaX5BPrm0zLrHEDBg55q72TXpks33 bXl2avGqSQS3d+CGkHxtfM1VA6R9dtA3DIHrdboXJc3xvOEcGWJdoGXtoUzMCYsecoCI/2qFt UZn/lyDYuFrWglqCchWY+AT1JtCayPxEWowd/2aDNEgQMbO8o4wkVyNeBIE6zyW12s3e+wvuy VQFCB8g== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76446-done Cc: 76446-done <at> debbugs.gnu.org, Morgan Smith <morgan.j.smith@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Maxim Cournoyer <maxim.cournoyer@HIDDEN> writes: > Hello, Hi, > Thanks for explaining; I also see this is standard behavior from ERT > (info '(ert) Test Selectors)'). > > Reviewed-by: Maxim Cournoyer <maxim.cournoyer@HIDDEN> No further comment, so I've pushed the change of the Makefile. Debbugs 0.44 is released; I'm closing the bug. > Thanks, > Maxim Best regards, Michael.
Morgan Smith <Morgan.J.Smith@HIDDEN>:Michael Albinus <michael.albinus@HIDDEN>:Received: (at 76446) by debbugs.gnu.org; 2 Mar 2025 05:20:45 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Mar 02 00:20:45 2025 Received: from localhost ([127.0.0.1]:50581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tobkq-000415-Rr for submit <at> debbugs.gnu.org; Sun, 02 Mar 2025 00:20:45 -0500 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:60740) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>) id 1tobko-00040B-36 for 76446 <at> debbugs.gnu.org; Sun, 02 Mar 2025 00:20:43 -0500 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-2234e5347e2so68176805ad.1 for <76446 <at> debbugs.gnu.org>; Sat, 01 Mar 2025 21:20:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740892835; x=1741497635; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=2Vz0v3N/+v96dv5z6QhSuqLTb3kB0jkEumzaH8saGHk=; b=GSlH74ftsALDLwgDGQeN41ObkRx/L/6ADtkfa2GWk3vzrSZDo5zxy0yCYiz9G8bRM6 t1DYySdbe1W7qzFU1N5Ym0Y4XTYz7FkqvDhx405kXIwS3gXd8pnLQc1IrY1nYhhJ2L+i 8zno6cWNkXClbzvOtw9cqy2ezeOxMUuKfrqT2MD8B119GGKeESAILzjoXTlvyhGZf5TX qdAypBcNogEW3j9rfgWDepbEdNYZ+fT49522wWTE0xqwswT/R1v2LSgrancY0uLFDY/f 0clZ+qGRiso/ONFVkm9H2cLW435Hjx4i+1mU6Bh+80NzZOXilC6lKaLGU39R1bmX0XpU 6aIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740892835; x=1741497635; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2Vz0v3N/+v96dv5z6QhSuqLTb3kB0jkEumzaH8saGHk=; b=Res+rJPkSUrEpdt17mO2Wb6lkW4fJUgDHlm6hy89/iphEBmTD0dkgtD7cuQe/bOh7+ 1xOJPs6m6LAkD0ocug+n7BJ1NDY91IekTD5Tw8AHLnfhLEFkB+b4bym9Zp+kCutupRJq Z7++uqW8/pnDSPzJwQ7dwvtiSTd7V+gyLATOs0J88LFzEiCfmLx8FdIhudJF66uqWvrD vil/ZJo/Xn8ufg4o9BkkX+N/y87dlQCy45evUl5gaYH/rjSu5iYRbP4dLkLx+QKB2tVg 1RpteEgnGh2L3LFw4bqFbfHVMhvWxsV8uaoM+ZpYx5SyE4CzwSRRN6Otah8wUAPUOCh2 guJQ== X-Forwarded-Encrypted: i=1; AJvYcCWtptyqeVLa48JtIrFNbO1IENnX2kwgt6Afm6QKLn7CXIJNn5hPB+pskvykT2lPx1juh3Gw7g==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwfyGvdHIQ34JURHDodcl4zR58lQvePrhxsKBZob4s+wnA8Faei ZNHCrbFOOzslAwoiy0cHkpk9qr9Z2PhcXS0DUTzD5ZAvsTVyuT8nfSm+4JZ1 X-Gm-Gg: ASbGncsG4ZubUjWyRqziH+D/8S3U5u3x8lLkORpCB19U0M72eifnKRmploZHoP8Mse4 WIwmvgPYmUtQ453IbhqFxXasHFrtHvUn7QjRb2afSB9j/EkpZdTIHTZMz3yEXbSe2odkYXtwgVn Zw+GjWMSMXaoRwlrClaVQ2uxYcapedcv14lzwedHydY7K7690fObIPZmOyH9uKcp8X5FCmXf2dO QmJipw5a9bAx4B+8uzXSveRG/SbfeVRnU4Rpy1dyff+6B3Uchu+PWFaiuiSVN+JCVXPj46jlu/a xcSlP2+g+5kZMb4tnDkjvjBrK7/Zv0NO2x6qdO6Oo2M= X-Google-Smtp-Source: AGHT+IFTHNQ/pXzVoQtzmUoCCm/odqxRxgOi93hxESYA8ivZscBmMREVzJLAjzPar6plj5mWlvKrlw== X-Received: by 2002:a17:903:2ca:b0:21b:d105:26b9 with SMTP id d9443c01a7336-22368f8197fmr140127265ad.16.1740892834684; Sat, 01 Mar 2025 21:20:34 -0800 (PST) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22355773b58sm52991385ad.234.2025.03.01.21.20.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Mar 2025 21:20:34 -0800 (PST) From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> To: Michael Albinus <michael.albinus@HIDDEN> Subject: Re: bug#76446: [Patch Debbugs] Infrastructure Improvements In-Reply-To: <87a5a4lha2.fsf@HIDDEN> (Michael Albinus's message of "Sat, 01 Mar 2025 19:47:33 +0100") References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN> <87bjuvy17p.fsf@HIDDEN> <CH3PR84MB3424807016C1C6E6EBCD08E6C5C72@HIDDEN> <CH3PR84MB3424F04FC0B2977D0234503BC5C12@HIDDEN> <874j0jyy3n.fsf@HIDDEN> <CH3PR84MB342487797E764F59AC3A9724C5C32@HIDDEN> <87o6ypx1ps.fsf@HIDDEN> <87jz9amg1k.fsf@HIDDEN> <87ikoshi1i.fsf_-_@HIDDEN> <87a5a4lha2.fsf@HIDDEN> Date: Sun, 02 Mar 2025 14:20:22 +0900 Message-ID: <87a5a4gga1.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76446 Cc: 76446 <at> debbugs.gnu.org, Morgan Smith <morgan.j.smith@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hello, Michael Albinus <michael.albinus@HIDDEN> writes: [...] > If a selector isn't a regexp, we don't need quoting at all. Both works: > > # make debbugs-tests SELECTOR=debbugs-test-get-status > # make debbugs-tests SELECTOR='debbugs-test-get-status' > > > However, if the selector is more complex, we must quote: > > # make debbugs-tests SELECTOR='(not debbugs-test-get-status)' > > Summary: I have the attitude to quote every selector with '...'. This works. Thanks for explaining; I also see this is standard behavior from ERT (info '(ert) Test Selectors)'). Reviewed-by: Maxim Cournoyer <maxim.cournoyer@HIDDEN> -- Thanks, Maxim
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.Received: (at 76446) by debbugs.gnu.org; 1 Mar 2025 18:47:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 01 13:47:47 2025 Received: from localhost ([127.0.0.1]:43677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1toRsI-0007VU-LL for submit <at> debbugs.gnu.org; Sat, 01 Mar 2025 13:47:46 -0500 Received: from mout.gmx.net ([212.227.17.20]:45567) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <michael.albinus@HIDDEN>) id 1toRsG-0007Up-33 for 76446 <at> debbugs.gnu.org; Sat, 01 Mar 2025 13:47:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1740854854; x=1741459654; i=michael.albinus@HIDDEN; bh=EyR9B8QBQCBycGqnds2nwp7J/lcuP14XqbPNNQPEL08=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=GSwx1wUvBeQakrBSWbT9eMc81xgRjwJ8nsKP9rOMOwVZoCQO5SKFWRP23GrI14Nm OFMuHw11GjEuLJbhQsk7zT8EeXpYus3nc7E4NEATmFqya18LTmYHSiNENOCPw1gX0 RkdcgaLAnr7GjtLalY+hJv18AwPUDZ60Jk/y+qUcyFuzs0srcdovDsf8UrIZfdP5V 6wEMB/bAgGdyOFtK6tCgYfmQ3WWpqXNMGV2axj+uCI1RpdNgZaGn49k1pCs4R3Xm7 KxfAvQbY+jTiqCOylUy/MCjYWuUeF/QC9JxpaAO7lk8pGeXo3X6h/KQQHuOr57vTH FdnCTXaekvmo6+gyGQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N7R1J-1tDy3c3xwT-016Apu; Sat, 01 Mar 2025 19:47:34 +0100 From: Michael Albinus <michael.albinus@HIDDEN> To: Maxim Cournoyer <maxim.cournoyer@HIDDEN> Subject: Re: bug#76446: [Patch Debbugs] Infrastructure Improvements In-Reply-To: <87ikoshi1i.fsf_-_@HIDDEN> References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN> <87bjuvy17p.fsf@HIDDEN> <CH3PR84MB3424807016C1C6E6EBCD08E6C5C72@HIDDEN> <CH3PR84MB3424F04FC0B2977D0234503BC5C12@HIDDEN> <874j0jyy3n.fsf@HIDDEN> <CH3PR84MB342487797E764F59AC3A9724C5C32@HIDDEN> <87o6ypx1ps.fsf@HIDDEN> <87jz9amg1k.fsf@HIDDEN> <87ikoshi1i.fsf_-_@HIDDEN> Date: Sat, 01 Mar 2025 19:47:33 +0100 Message-ID: <87a5a4lha2.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:CXxf9TONs8DD3ZzPUWuc0c1hd00ZQGOMDuLLgBXEaND08jZqQd/ 3h+MF96oXYl1TJaqcjPaniziW9Hj8oLTFBadbmLm3Sd/GEy0uDIDbkZvqqbfReLkocIWPWE cBy5qUng4+ospJbE16sv3pa5uQb1JIsPw3IohBPBFLAZBT+JlGouP4Gd6f9cgX9XoM1donV CTVwlmvJrVMq5m/gyNNdQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:4bHawvx5CYY=;OoKhdUC2TyW7dG537OSi7ll4Vxx /x6ittMsgpEtVBealtCY/jFZC5gUkEWx0GmyzwyD6Or9GIdlZWjR1QuhbNlhVJjg+ISqScGiM yTwIxiCPZH4+AsKkOZaBHisxPFg6r9Js4nkpdCVfYT1JAzonVjzpO9vr+tVAJ7JRFsz+F3tNd 6KiOQzTQLs1WpFeZrZlwfC9n/Rh48EL1BzF3QFBttdVJOqn3wsxG/y+t1KyAaI57yCtR9dPYS JYiVIZ29FzJOEZrOMiw7MzXuO5x3dKgPipZns5ZV3xa1kfcHMVsyrBtyFTlJzXawbCHWSFi1E H9nNx2ooJs5J51Ec0ucLAw+4pR43ptftpQpGhlGtcqAjlFeC/2gYkfM/wLPumkOIrxeUYdJf9 QpbYt46dT2XWyzso+L6QhAQR5VKxR9ztp++rZCxJ2gh8dEO6d/mk5VScSIhjJaT1v2tBG9XQ5 TkJGkZZo5WA5SxGPRHTstATulDI1bOgd4k+qhsEg1gNit07O1EeW53Hm5r0yYdiMXU58a62F7 74tQZ34qa5MCUB628gb/XhfZWQ1TqIf80Wv+kIXtH8x4lWFEfO4cYrtzmbKslBhOGqekEtDqv M3aktdyGyIB1WhdJ2dEYVSDSIoQsg2241UahoiLz9RUM00Qo6ck3aiz9niQIobdpLUxBDCXQD 5MMbF8acSkNbXm+UcRjI/nafH81Ae/GP5JuLrxZysa5+bkhdrpTj5G4qQwsubPMGUOHFG40P7 eq7YnlF5MMuo7uFKf/3gyGDEtqOYwqZqmNAghvt4xDiQnt/TNxgBr7DmcwUSviiwFrLRD8ux5 +jayi47f5fDQh4JfcIVo7zMdcF2V0dZzDFmnKjvQAvb7iZgt9vHIewaZ+2w4w6VvKMqRYFjOS Sawxb45DCazvz0Kn3k7SriG0Q/H7UYwUA7pq8ie2Spf4Yfyjv39LExaUhTuBBRPPk/9NrEANL kWwHNUmefoAo+uapKRikLRdvX89zuE+PCPsMSmx5sjOJpA6/qR9ALb2P/FeJy68gqTpkx5TRR 195Sgz0ZjnxdUXydKkbVBlLHvlHL1wQCsUeeabHAWCyuvt/q4LSCLA/5GnTTR6QqqJ2sdC2sw J3sJPOBZ5iHSkfoaoy5VVXo4pZDQgYnJiUYiTlMe4WIHBrOqbsf5WGLctTzr0UyqXILYmssp5 zcCPBI33hRBWO8+po9rIrRDmTitfIUkAJGaaOSDPpSSJo7TsKN1mIwYtj4uHOQOd8n3pybZ4b 7F9nr3xNJpVP5Oy9BSzIQ9+kPG8khjMSdzyCIcs68dcCHzpQtfeKszSXnLHxT7H8J+9IVLlkp QPKLCeoCuGEcOhpkLI3CLhti9PT3vLklPCpZDMzFIYo5NWXDLnHmW+YRSGMQF5pMhXph0RoJQ aIt6NP69iaavlindeIs7NifSwH2gYxsGwFE6Io8nXEDli0iJpKiBak2vTn X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76446 Cc: 76446 <at> debbugs.gnu.org, Morgan Smith <morgan.j.smith@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Maxim Cournoyer <maxim.cournoyer@HIDDEN> writes: > Hi, Hi Maxim, >> +## SELECTOR discrimination (see ERT manual for more possibilities): >> +## >> +## SELECTOR='"regexp"': Run all tests which name match "regexp" >> +## SELECTOR='test-name': Run test with name test-name > > The use of different quotes here appear somewhat misleading to me; > someone may think extra quoting is needed when using a regexp, but it > isn't, IIUC. This is needed due to regexp quoting and shell quoting. A regexp must be a string. However, the following calls don't work: --8<---------------cut here---------------start------------->8--- # make debbugs-tests SELECTOR=get # make debbugs-tests SELECTOR='get' # make debbugs-tests SELECTOR="get" --8<---------------cut here---------------end--------------->8--- So we must use --8<---------------cut here---------------start------------->8--- # make debbugs-tests SELECTOR='"get"' --8<---------------cut here---------------end--------------->8--- If a selector isn't a regexp, we don't need quoting at all. Both works: --8<---------------cut here---------------start------------->8--- # make debbugs-tests SELECTOR=debbugs-test-get-status # make debbugs-tests SELECTOR='debbugs-test-get-status' --8<---------------cut here---------------end--------------->8--- However, if the selector is more complex, we must quote: --8<---------------cut here---------------start------------->8--- # make debbugs-tests SELECTOR='(not debbugs-test-get-status)' --8<---------------cut here---------------end--------------->8--- Summary: I have the attitude to quote every selector with '...'. This works. Best regards, Michael.
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.
Received: (at 76446) by debbugs.gnu.org; 1 Mar 2025 15:45:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 01 10:45:06 2025
Received: from localhost ([127.0.0.1]:41585 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1toP1U-0005EA-VN
for submit <at> debbugs.gnu.org; Sat, 01 Mar 2025 10:45:06 -0500
Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]:56789)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>)
id 1toP1R-0005CY-Dh
for 76446 <at> debbugs.gnu.org; Sat, 01 Mar 2025 10:45:02 -0500
Received: by mail-pl1-x62a.google.com with SMTP id
d9443c01a7336-223785beedfso24696455ad.1
for <76446 <at> debbugs.gnu.org>; Sat, 01 Mar 2025 07:45:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1740843895; x=1741448695; darn=debbugs.gnu.org;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=8/JURicFpQjhZV+EtwW7e3QfzGGWOt1HTUJ50GaboXM=;
b=LRX+jxlCxl8S7URyrJRPgfXFY4867zsnIYeDtXDG1CPIoDGjUCji8I+SxHLrlnhoPY
myj0Zn1czb3XtkTsMS/CX/L5g/oYH9tgMHyn/iCbPGjFS0dZ6+jx7Yy4MAKOwaMMnxSA
+WI1VvSSahVasUXnLETQIb1GX8F2NWaBNHnL0+guGxOGlme4fHiHyYZlyN1AMfdWr0hn
3eB0VQoPSOmNdBGk5+NyRPmBMx1DL/wtrH3LaVqnJ9wOt7PYb+gjx7cv1fMmR2wdNF+T
ZrlI92bIdiADsw8RcCk6j1rg6AkNMnYgaPtCgPPuZ2ACk2Vav0ixtTYyp7NabmAdFB8o
Axdw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1740843895; x=1741448695;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
:message-id:reply-to;
bh=8/JURicFpQjhZV+EtwW7e3QfzGGWOt1HTUJ50GaboXM=;
b=fZC+LzkZjJizQSKDoVFkKnqAtffIGYBgleSySbx3KN4WZifTOOZs1hc7jdWd8jcoBV
/ZaEJSJaGWkp8ECK2hKqzX3zybvkymGYmdib4PRi0XPLS6va6X008/pGlQRbMOt30VLA
htcr2cMCEDCiInKgLgOnInTyEe9waAH5JwWVxco8058LfQD8vfgTmUYV4Bi+tE/ZErL5
X3IIfXfibVuVn8HVEDFgv7gF7CQVJBeoOZyWKOKwHBu3rWZ4DVgrcSTevS9PwHGa4aJE
pi+pdU9PPYZ5CI6g+6pRlAbjRUPvGUNAO185xNsN9OHVxoEANTSbrG3Ca54koiotEeaO
yWkg==
X-Forwarded-Encrypted: i=1;
AJvYcCXMAJZxggxSSXblWy13p8lcfKrubU2MbPsP7vt8VeHtP7HgRRxx6ALFj08L2ZFI+943Gcs/GQ==@debbugs.gnu.org
X-Gm-Message-State: AOJu0Ywwns7kqnj+0gj1pgKAI3Q+fb3J7hZU8ACCCKP74Ht7uZdfOTzV
o5Jrb1TIinybvfNBx9SU1k4EQAygMOXGMnba+jDX2E7e0+N/eF6So/Yk8o+8
X-Gm-Gg: ASbGncuXkqCID1AsojA3V4cFWbHWdjYBdDzG9S0xLw74KyXXUn0KcALahOcZgz3IGDG
ExydJBP+DA97Afg+87JjrNPeWIDssjfzIglhKyi8eI5tpIux1IElWFXqfumfHvAALH4aZzFnt2+
LZKyhEDLRsTO07To6IuGqwSzUicnolueD/4wpiuH6PxhRFBCVgRxbN1sWlzJhuq8U/fOK2mmsbO
BMORMD50gfMP0RwXE8EJSmSMSW3wjDNEih6T6ij3RU++IgCRjjc3X6A9trroTxBz5zpo/hpErYS
lTDoWlZuwCbV6bqvl4ng0kES5SiLgntFP+BxEoVbY3Y=
X-Google-Smtp-Source: AGHT+IF/9ll+w3s985NuLT8ESlxMIQs2JY7SW/UUtS1qctKIl8GUt+mj858UFxEYDwMYrTHDd2FAWQ==
X-Received: by 2002:a17:903:2ca:b0:223:44c5:4eb8 with SMTP id
d9443c01a7336-2236924e3d8mr136795875ad.32.1740843894575;
Sat, 01 Mar 2025 07:44:54 -0800 (PST)
Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542])
by smtp.gmail.com with ESMTPSA id
d9443c01a7336-223501fa5a6sm50331365ad.72.2025.03.01.07.44.52
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 01 Mar 2025 07:44:53 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: Michael Albinus <michael.albinus@HIDDEN>
Subject: Re: bug#76446: [Patch Debbugs] Infrastructure Improvements
In-Reply-To: <87jz9amg1k.fsf@HIDDEN> (Michael Albinus's message of "Fri, 28
Feb 2025 13:04:23 +0100")
References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN>
<87bjuvy17p.fsf@HIDDEN>
<CH3PR84MB3424807016C1C6E6EBCD08E6C5C72@HIDDEN>
<CH3PR84MB3424F04FC0B2977D0234503BC5C12@HIDDEN>
<874j0jyy3n.fsf@HIDDEN>
<CH3PR84MB342487797E764F59AC3A9724C5C32@HIDDEN>
<87o6ypx1ps.fsf@HIDDEN> <87jz9amg1k.fsf@HIDDEN>
Date: Sun, 02 Mar 2025 00:44:41 +0900
Message-ID: <87ikoshi1i.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 76446
Cc: 76446 <at> debbugs.gnu.org, Morgan Smith <morgan.j.smith@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hi,
Michael Albinus <michael.albinus@HIDDEN> writes:
[...]
> +## SELECTOR discrimination (see ERT manual for more possibilities):
> +##
> +## SELECTOR='"regexp"': Run all tests which name match "regexp"
> +## SELECTOR='test-name': Run test with name test-name
The use of different quotes here appear somewhat misleading to me;
someone may think extra quoting is needed when using a regexp, but it
isn't, IIUC.
> +
> +### Code:
> +
> EMACS ?= emacs
> MAKEINFO ?= makeinfo
>
> -# regex of tests to run
> -TESTS=.*
> +SOURCE = $(wildcard *.el)
> +TESTSOURCE = $(wildcard test/*.el)
> +TARGET = $(filter-out debbugs-pkg.elc,$(patsubst %.el,%.elc,$(SOURCE)))
> +TESTTARGET = $(patsubst %.el,%.elc,$(TESTSOURCE))
>
> -SOURCE=$(wildcard *.el)
> -TESTSOURCE=$(wildcard test/*.el)
> -TARGET=$(filter-out debbugs-pkg.elc,$(patsubst %.el,%.elc,$(SOURCE)))
> -TESTTARGET=$(patsubst %.el,%.elc,$(TESTSOURCE))
> +TESTS = $(patsubst test/%.el,%,$(wildcard test/*-tests.el))
> +SELECTOR ?= (not (tag :unstable))
>
> -INFOMANUALS=debbugs.info debbugs-ug.info
> +INFOMANUALS = debbugs.info debbugs-ug.info
>
> .PHONY: all build check clean checkdoc
> .PRECIOUS: %.elc
> @@ -30,10 +63,14 @@ doc: $(INFOMANUALS)
> build: $(TARGET)
>
> checkdoc: $(SOURCE) $(TESTSOURCE)
> - @$(EMACS) -Q --batch -l resources/debbugs-checkdoc-config.el $(foreach file,$^,"--eval=(checkdoc-file \"$(file)\")")
> + @$(EMACS) -Q --batch -l resources/debbugs-checkdoc-config.el \
> + $(foreach file,$^,"--eval=(checkdoc-file \"$(file)\")")
> +
> +check: $(TESTS)
>
> -check: build $(TESTTARGET)
> - @$(EMACS) -Q --batch -L . -L ./test $(foreach file,$(TESTSOURCE), -l $(file)) --eval '(ert-run-tests-batch-and-exit "$(TESTS)")'
> +%-tests: build $(TESTTARGET)
> + @$(EMACS) -Q --batch -L . -L ./test -l $@ \
> + --eval '(ert-run-tests-batch-and-exit (quote ${SELECTOR}))'
The above LGTM; I agree being able to select a single test is useful.
--
Thanks,
Maxim
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.
Received: (at 76446) by debbugs.gnu.org; 28 Feb 2025 12:04:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 28 07:04:39 2025
Received: from localhost ([127.0.0.1]:46338 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tnz6c-0006tD-VT
for submit <at> debbugs.gnu.org; Fri, 28 Feb 2025 07:04:39 -0500
Received: from mout.gmx.net ([212.227.17.22]:37537)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <michael.albinus@HIDDEN>)
id 1tnz6Z-0006s5-8W
for 76446 <at> debbugs.gnu.org; Fri, 28 Feb 2025 07:04:37 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de;
s=s31663417; t=1740744264; x=1741349064; i=michael.albinus@HIDDEN;
bh=Zy8bmPdsAPzxY5gXyIlKBYYVwyD7xQl3+BlPtWodjpc=;
h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date:
Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding:
content-type:date:from:message-id:mime-version:reply-to:subject:
to;
b=BeYAtZM9mtBex0ClaF5tkCqmK4n4jMU7u041cft+22QNoSgyeqipDYOf91l3ebOA
eMfv5IgAzhS/+iZsM6o7Qpzr9553qrQ8eQ6N/SGfRrvbAwxoaa7/FTDHPxxuPNY+T
fPFipFZ2Ptkuh9pOWJRT6LZT9XrGxIhe4fL2cA6Mn5bbiTvtfVwHRJz9DgfODZByV
1Gr4ZPLS86QNZFIlD8koBM+du1l5mA0JEhQPsiIqaApOc9Rn0LOw9oNyJL4bvOcBY
9BsB2ZD8fH/tsBiQRNdwccCzGIPa5GrlSywJymqN5fri7Evr81+hSlwW/XKWM+Z6z
algOReXOAFdrnG1L/w==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx104
[212.227.17.168]) with ESMTPSA (Nemesis) id 1MbAci-1tGrGy1ome-00ZtNO; Fri, 28
Feb 2025 13:04:24 +0100
From: Michael Albinus <michael.albinus@HIDDEN>
To: Morgan Smith <morgan.j.smith@HIDDEN>
Subject: Re: bug#76446: [Patch Debbugs v3] Infrastructure Improvements
In-Reply-To: <87o6ypx1ps.fsf@HIDDEN>
References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN>
<87bjuvy17p.fsf@HIDDEN>
<CH3PR84MB3424807016C1C6E6EBCD08E6C5C72@HIDDEN>
<CH3PR84MB3424F04FC0B2977D0234503BC5C12@HIDDEN>
<874j0jyy3n.fsf@HIDDEN>
<CH3PR84MB342487797E764F59AC3A9724C5C32@HIDDEN>
<87o6ypx1ps.fsf@HIDDEN>
Date: Fri, 28 Feb 2025 13:04:23 +0100
Message-ID: <87jz9amg1k.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Provags-ID: V03:K1:t+D8/W0r6u4evKb8R+JC96Z1eFJB2/wVm+DJiiRcNRxQW3Yj+Sp
AIP6m7lryhJsuA+5uqhzpEA+tlI6d1BLJp5/XLq15lv5ZNu+knSSD5rE08BAEtQGvzhxaGK
tXkEEs6cxahRCPlp8mde1LFwT9DSwKJlLkP+B92vO/Tmqjh/2saB47lGRUw6uaSnZ5AnkTs
BtA918nieiTASsyWfxJJQ==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:Q+oTptg1/dE=;DuhWs+frSIZGJXY0SboVL1POdlk
eg8A5tp8b79MdWG4UzlvEfN5kQ5nMIQoHs6QLQNjIvbf0kU2f4KQWzhfgHg7o05rSj0g6yC/9
uy98lwCY1JPtE0GRoEVdFH3M4uJQ6EgS8I2kkPH6PkDnpnq4npT7d0W981zRB7G5u5aiwbmlT
wKhIrkSiRElGuoR9Vh+TiVikGwDKQMwN4wH+lEszlUxMHVcDcR4CjC4oEmnCRwLsDYzIm+6f0
8VC7WT2Msd8X6v8fNLfzs6vloOGMvj/FocLsxSuYnrev9ge0eBnEQT3qo4WZG0svlmebndD31
NsXijUhvYLelbpkBmOoAIUTfhYXStQH3OBKv6b2R2QkX+LDHmIKqjp23Ov+d2e5W7JDym3Pm0
2UYDFeGXxsZyEIdLOBe+EqiE0Y9vJHPbqcIPaVGSh/gkoCcyoSeNZFCW0Q4cYSujFQAAIx2tA
gPdb7NSFTTWD4uD5BNBKB6AURgWqt7W/JrobXXZTR8L/MuJIXjWRLXnm/NtHkNYzxxNRG8fGT
RcVyivoIuDloAmhvzIkIdZyiyqAT9CoZ3W+DdH9TsC5stvzC7LWM0W2E5Q0vySpo5bJq0vUJR
wVXK1urpPc9E9lzZjdytAiPnJOprxzozgdH3puYy5FqFDwQl1Gys3xdcxXBxbISgjkwGlKZtI
KcWW58AJJCRdEjs4RH8XsinIhiBYp/hXpWwPnbSzEWsEsgQ/daFnVyb0mpXO3ijjVvMyHn2J+
Ho5jkbF9p+FIBmkXvNbh+qAL1rXdKDTL11f/kJwQ0TWvQlW+x0ZYlUndwFkzTECJt6pOVHnXG
6LgqC9Vchkc53hXUtbMY4MEcd1IaW7EgD+0P+CBH/qfOzN3tEQACUAubLgecA+786hBKH5iSb
cKvBSiZvPJ7Bh6/0Hrhf+em34IBi+Tlez0pa80QElyBXYIX6Yc1h987+bMAOGD7u3+Jb3NpW5
ID+mNqDS+JT7zL+gzBuXl6hkubH7nWO5UXgz2xQHVu0HPqLbngVzy12yGoRoiF9H6AwNtbfte
AroFbdKemjsrixINY7p/kDdxtzpTXRye1LuA+1Nahy8leBN+bwomFi/sa2rw3V0zcTXQv+bYj
uX3jTp0oyRjezP7n/Jn34tL0oY+KetfD2oy2DKCsx/L8Ka8DFL0CaiStvH6j6pWGPx+ToXVrN
JM7HA2zeH/8rwaf2JS4poIzpkrM429tXAAH16bo6eFmr/HNLfzLG2aZs8MRKOjtnVkkJUn7JO
96dc7bCGFBYihj+6FRPQtU7GplSp9AesgzcIf0Srh4JaxVXSD46/iOkNgZ2BqdQi1z2hinOsq
B7SLAGj5seQIHoPoNtiLVzJ85dD/hGvxXQY9fWBopX0wwmXiIyaJ6tKYR12cVQKaP7wRj4ldm
+O5cYGTmrfyUdbSYaerkFS0Sx71ZbKtLCRUHsApxxA2fmP/MCdtkHa/gZd
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 76446
Cc: 76446 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
--=-=-=
Content-Type: text/plain
Michael Albinus <michael.albinus@HIDDEN> writes:
Hi Morgan,
>> Are you trying to selectively run tests so we can debug tests one at a time?
>> That is already entirely doable with the current setup. Running 'make check
>> TESTS=get-status' only runs a singular test.
>
> This is exactly what is called SELECTOR in the Emacs make. And this is
> the same name used in the ERT manual.
>
> I said already in my last message that this is missing, and I will add this.
>
>> The patch you have provided actually removes the ability to run one test at a
>> time as we'd have to run entire files.
>
> No, with adding SELECTOR to the Makefile we'll have it. Read test/README
> from the Emacs source tree for a better understanding how Emacs does it.
>
> Disclaimer: I have written a large part of that README.
>
>> I'm not certain what the SELECTORs do but perhaps you're thinking that
>> in the future we would have groups of tests (like "expensive" or
>> "network") that we could select. In the interest of not
>> over-engineering on hypotheticals, I would say that is a future problem.
>> One that I would likely solve by putting those test files in
>> sub-directories labeled "expensive" and "network".
>
> A SELECTOR can be anything. A regexp, a test name a tag, you name it.
> See (info "(ert) Test Selectors")
I have extended the Makefile to support also SELECTOR, see
appended. Comments?
Best regards, Michael.
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment
Content-Transfer-Encoding: quoted-printable
diff --git a/Makefile b/Makefile
index da0764ea36..258d553ae1 100644
=2D-- a/Makefile
+++ b/Makefile
@@ -1,15 +1,48 @@
+# Copyright (C) 2024-2025 Free Software Foundation, Inc.
+
+# Author: Morgan Smith <Morgan.J.Smith@HIDDEN>
+# Package: debbugs
+# Keywords: comm, hypermedia, maint
+
+# This file is free software: you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# This file is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.
+
+### Commentary:
+
+## Some test targets:
+##
+## check: re-run all tests.
+## filename-tests: re-run tests from test/filename-tests.el(c).
+
+## SELECTOR discrimination (see ERT manual for more possibilities):
+##
+## SELECTOR=3D'"regexp"': Run all tests which name match "regexp"
+## SELECTOR=3D'test-name': Run test with name test-name
+
+### Code:
+
EMACS ?=3D emacs
MAKEINFO ?=3D makeinfo
-# regex of tests to run
-TESTS=3D.*
+SOURCE =3D $(wildcard *.el)
+TESTSOURCE =3D $(wildcard test/*.el)
+TARGET =3D $(filter-out debbugs-pkg.elc,$(patsubst %.el,%.elc,$(SOURCE)))
+TESTTARGET =3D $(patsubst %.el,%.elc,$(TESTSOURCE))
-SOURCE=3D$(wildcard *.el)
-TESTSOURCE=3D$(wildcard test/*.el)
-TARGET=3D$(filter-out debbugs-pkg.elc,$(patsubst %.el,%.elc,$(SOURCE)))
-TESTTARGET=3D$(patsubst %.el,%.elc,$(TESTSOURCE))
+TESTS =3D $(patsubst test/%.el,%,$(wildcard test/*-tests.el))
+SELECTOR ?=3D (not (tag :unstable))
-INFOMANUALS=3Ddebbugs.info debbugs-ug.info
+INFOMANUALS =3D debbugs.info debbugs-ug.info
.PHONY: all build check clean checkdoc
.PRECIOUS: %.elc
@@ -30,10 +63,14 @@ doc: $(INFOMANUALS)
build: $(TARGET)
checkdoc: $(SOURCE) $(TESTSOURCE)
- @$(EMACS) -Q --batch -l resources/debbugs-checkdoc-config.el $(foreach f=
ile,$^,"--eval=3D(checkdoc-file \"$(file)\")")
+ @$(EMACS) -Q --batch -l resources/debbugs-checkdoc-config.el \
+ $(foreach file,$^,"--eval=3D(checkdoc-file \"$(file)\")")
+
+check: $(TESTS)
-check: build $(TESTTARGET)
- @$(EMACS) -Q --batch -L . -L ./test $(foreach file,$(TESTSOURCE), -l $(f=
ile)) --eval '(ert-run-tests-batch-and-exit "$(TESTS)")'
+%-tests: build $(TESTTARGET)
+ @$(EMACS) -Q --batch -L . -L ./test -l $@ \
+ --eval '(ert-run-tests-batch-and-exit (quote ${SELECTOR}))'
clean:
-rm -f $(TARGET) $(TESTTARGET) $(INFOMANUALS)
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.Received: (at 76446) by debbugs.gnu.org; 25 Feb 2025 19:29:33 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 25 14:29:33 2025 Received: from localhost ([127.0.0.1]:48532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tn0cW-0005sV-Oh for submit <at> debbugs.gnu.org; Tue, 25 Feb 2025 14:29:33 -0500 Received: from mout.gmx.net ([212.227.15.15]:39387) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <michael.albinus@HIDDEN>) id 1tn0cT-0005sC-13 for 76446 <at> debbugs.gnu.org; Tue, 25 Feb 2025 14:29:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1740511762; x=1741116562; i=michael.albinus@HIDDEN; bh=XyCrI4m5w/LX83bkz4DK7WBab4yoFIPA3S4S45fSVsc=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=ttXvz2b49wjD6okDX9n8i5JN7DvQBF+3OkZn6Jyx0rIaR6wR9fwTOV+9mYPKCphG QFxjlCR4eV6kcufvTif6Kz9zsuUjuSBa+j7U8pP+G/zdEU4+7HHRJhzqoZqNGKtVI vnraSwSDE25RNZrAXsItiE6kCM89yPbHkCAPjZS36ikkrzzoiAmaRXKZYSWea1/JO Y2Wnxl+ZGKLW1cntzBZacaPiUJxvvmVbXRQUDf1RHf5OSYEl1ZbDlSJGuTUVNPkjA AU/irSSeqv4673vPjSJHERdx0K3DDeTxAFutMejXxhRwj7SjsOsclBkjIT2kxhUej eRYd8zZo/cpvrc03Yg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MPokD-1tzz3h1qtv-00TfTT; Tue, 25 Feb 2025 20:29:22 +0100 From: Michael Albinus <michael.albinus@HIDDEN> To: Morgan Smith <morgan.j.smith@HIDDEN> Subject: Re: bug#76446: [Patch Debbugs v3] Infrastructure Improvements In-Reply-To: <CH3PR84MB342487797E764F59AC3A9724C5C32@HIDDEN> References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN> <87bjuvy17p.fsf@HIDDEN> <CH3PR84MB3424807016C1C6E6EBCD08E6C5C72@HIDDEN> <CH3PR84MB3424F04FC0B2977D0234503BC5C12@HIDDEN> <874j0jyy3n.fsf@HIDDEN> <CH3PR84MB342487797E764F59AC3A9724C5C32@HIDDEN> Date: Tue, 25 Feb 2025 20:29:19 +0100 Message-ID: <87o6ypx1ps.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:YdmMfsBWNpvAnEbUmCv1Xq65vrmKhvaa6WVb2wBbrmXQjLgejl7 AIw0XbpKFz6RWeHVUGHYcYsI1B00L9i07aZDgPziXOkjxBxyBT/xmNW2q7TqAQr/IZk+U68 k7c+F4Gy9UXwZQ322if5XvmtNGj2EZUgkjHeSGhofAxsM4MUSGMJjqyH7zrFLw9VZdCc2J4 9Blig0ZZgNiQRyjCYBzTw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:MAXglu9LiTk=;dwKCUIzncn+TC2myLoHsWOPkS43 GyHgWUAvBeqz9r0tUA2rqOIdqXJwI+ib3DiEEHag/OrL2pZMbuXPLGm2ji+OGP50CPwRu+TtM kV7Vj4DaZC8HlnMxyTkOCC4RkT+kNVX1oPy6eMiKpkOzlwpZ9OGs2kZ06TnKyhIRh/JxO0uga 1bg9nUafpFW2BcwV8pC20Sz+PKJ3eqMnOcwUWQ30pRF31rBIlBLsJjO8EtWJDYgSVWLh36TkK MdNcgEjcuM+dPxT370eyAOHQ/ty2QOZb6Xy2E7jcbOlEFqHNlVAU7yP0+rxXITM+xSdnnxk5Y oA/2XJCXYSf4y9QZpqF+cjL+3yDX64La9nYNONVkMcp9Juy7y4/RlWihIoN6M4pjf+9NFJQBF UIy9bA4CxWb7GjZ3SE0tOGwAjYDXAhO6RwJIa05EeM+9y2RGs/n+vx/rP9PK7TaTPyYWm25R1 xpp2thg9dTN/LGkFPwi8hPE2hzPlkvz71P4W98w+MIekdGTt8ktSm/TYXHJaAYxXzkcxLe3+V oMlEBBIc9slIZUQ6dJTgmxgk//6hl7xOvUjuz5Ot5+qRWgsVLg8x+Yw0rIiv0vvS5VUg/AyFX MACc4Isl2Eok5MH8Z9f88Eqt489skIdjOr+lbYrgSiAXs9Nqsa5tcDKISMV/1dJGJlmfriOj2 LVafn9O4mi0ZOxKRD3Cx/TH2A1E6kyNWvU+u44nAfUvmAJz6PopSVDNgejKTjyLV1vcRP1E5v aPMWYkMf8pkD1Hbv7MCjQkK1P8czY86wVuQNhZUwSWkHERntGXOtCWsPcTa8eGWEG4ZjyqD6e VThFqc7ozhkrt2l0bI5h5oPWKxAVfJ2FkaP0tjETnaiDWZu+NObPHTZ5goz76RdJgv/N0TvyC 4vdsUNL6dic+UG4CLlreqvrI0ITNDKPJ6+cchYUfk0EFYRkwFz6GNLYdiEO6EE3N409gLq6O/ mM5O8CT6mOGjLn/aTG52Jl/U+1qTUw0R8PWbjawcirdO2/WNRmeM+WtfpmiKjlm7t9sKn1bpm wEMB1iYMebUacHJ5thRLQR2ZKWSEqo6ZhKCSnc4g0FTTpQuna82uww9xwBxx3DNHF7eanBKoM zdM5muUJ6y6EuDLBzI+xLggcavcw2dU6T2Q+0zBM0GX+e4SCZf6RHFfND9ujwzlSzSLieVHUp rM9yF5jNFhsNXKSSfM5uM3CezB2ehEp1Ts4YLD1mgMAOfptG2fNFBaM1NSJdvoHCMwsw2yBWp HpDlsuu1Qz/9/CflO9qVr5RiEFn5lXFZu1GkmAqk1sM4S8HdpbOou7ViS3MjGLQrcKCSxlKfr PxBBAAqUtrslqqoN8dolnmJydLnrtBz9JPtPKsWzMuTSMJcG4F7o+gLEQJ+d/p/OO+v28MPZp o3/DXnFsO8wAawRlCuAoDsAWaO5J8Pm7HZRhk2tNIGixVqHsPGVW479Upj+FE3T6DA+x1NIpL E8GnbQw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76446 Cc: 76446 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Morgan Smith <morgan.j.smith@HIDDEN> writes: Hi Morgan, > I started looking at what emacs does. It looks complicated. I don't > entirely understand what they are doing. However, I would argue that > what is currently in the debbugs makefile is quite powerful and I would > be interested in what use cases your solution provides. > > Are you trying to improve performance of running the tests? Here are the > performance numbers for running the current tests on my laptop: No. It isn't performance. What I'm trying to do is to run only one test file by a given make call. This wasn't possible; your version of the Makefile has always loaded everything. > Are you trying to selectively run tests so we can debug tests one at a time? > That is already entirely doable with the current setup. Running 'make check > TESTS=get-status' only runs a singular test. This is exactly what is called SELECTOR in the Emacs make. And this is the same name used in the ERT manual. I said already in my last message that this is missing, and I will add this. > The patch you have provided actually removes the ability to run one test at a > time as we'd have to run entire files. No, with adding SELECTOR to the Makefile we'll have it. Read test/README from the Emacs source tree for a better understanding how Emacs does it. Disclaimer: I have written a large part of that README. > I'm not certain what the SELECTORs do but perhaps you're thinking that > in the future we would have groups of tests (like "expensive" or > "network") that we could select. In the interest of not > over-engineering on hypotheticals, I would say that is a future problem. > One that I would likely solve by putting those test files in > sub-directories labeled "expensive" and "network". A SELECTOR can be anything. A regexp, a test name a tag, you name it. See (info "(ert) Test Selectors") Best regards, Michael.
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.Received: (at 76446) by debbugs.gnu.org; 25 Feb 2025 18:18:09 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 25 13:18:09 2025 Received: from localhost ([127.0.0.1]:48419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tmzVQ-0002fG-KD for submit <at> debbugs.gnu.org; Tue, 25 Feb 2025 13:18:09 -0500 Received: from mail-dm6nam12olkn20817.outbound.protection.outlook.com ([2a01:111:f403:2c17::817]:47713 helo=NAM12-DM6-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <morgan.j.smith@HIDDEN>) id 1tmzVM-0002ee-SS for 76446 <at> debbugs.gnu.org; Tue, 25 Feb 2025 13:18:06 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YcindTLi9rOKzDb1ZdbODkwYb06Xnk3+8H8vQyr5mltPDNq0Dn92vBB+ruRQT55TyVpJYnCNCM79ZMnoESm9cVLxpivwV5YzNlZj26OQrK4AalYFD7K38tNVzqoa0QsDq4iSMFAQ/3sZX9gYdF4YTQ6/6vr216Ni1Caho7w4HJCbGN6B83P7V7pyZZchMHxqNU1UMn70Drkjwe797lELS8UdP1wN8SuyDPF0dVOBCVT7zPOYbPHccuHf3yIHSdJn2AOAVqhwoMfKzls2IcePEryTutmAwfxIukLgi1WWES0juvjHLwt2+G5aAnVKES1rRxxjsR+GbLbxSz4oetjTvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lpajPASJ1dsdlSDALXuefqMRk3hKy0oXBAW0Kj6TXpY=; b=YCGC9pZhjkOKEqPocd17Hpr8D++HwDj7G7b4gZruySPdiwfpiTVw5Wx6jAffpc07j8gZMdrWcFlNFY8Xld/BioWl8XGcL4lUz92eJHG/MVHalTL9YTfQ4KCax+4J98bUXuuFgC3TkgDNoScIFzhiutmcwGVF6PCGugvw0ITYrqCh5UznjaCQqWCp83HE71y4a+eXvzUB3w2ZtrPAi989ix+nlreaaV6iJSmpHHclGP8JxbpBriqHvobKPc4WdyfQFB7MpM3hUr5RG16OSPbwGB9iiUyQogLN/5mj+L0kq3IIUod3ZPJvXKkXfRrVPBVZyl1THIeBIuavOrkb6MiCFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lpajPASJ1dsdlSDALXuefqMRk3hKy0oXBAW0Kj6TXpY=; b=OykfFEmNTh9UcNybMzvxPHrIj+dQBpRbn/9oRWEenVO4P8ggdA7GRfVhWFEftxz6qYOZktwncBqSAhQIwBFYipaRDVRqGoEr6qh7V3D5BTWXdHi6cn2r1bb87OG8Le7vFYH2RUgmG2VzFElvCOMylcD8hXSo6feza+9y8duxVtTlR+e30BMR6x5gjCp+si/qlyIqTiyPdPZ8Gc3rWMasQWW1Jge9lCo7hzU0XmBClq3w2KZgp++cfDp2J4KEAVfBQdCz7XBiY3k4w94RkvECeh7S4rAcj02E+5nwhCcsK83jCbUAGeksz5wP3OTFvlTF1OHwmCT7NSYUTMv1pWfMEQ== Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17) by SJ0PR84MB1411.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:a03:431::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.18; Tue, 25 Feb 2025 18:17:56 +0000 Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM ([fe80::5c77:7a58:48ed:9aef]) by CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM ([fe80::5c77:7a58:48ed:9aef%4]) with mapi id 15.20.8489.018; Tue, 25 Feb 2025 18:17:56 +0000 From: Morgan Smith <morgan.j.smith@HIDDEN> To: Michael Albinus <michael.albinus@HIDDEN> Subject: Re: bug#76446: [Patch Debbugs v3] Infrastructure Improvements In-Reply-To: <874j0jyy3n.fsf@HIDDEN> (Michael Albinus's message of "Mon, 24 Feb 2025 19:52:12 +0100") References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN> <87bjuvy17p.fsf@HIDDEN> <CH3PR84MB3424807016C1C6E6EBCD08E6C5C72@HIDDEN> <CH3PR84MB3424F04FC0B2977D0234503BC5C12@HIDDEN> <874j0jyy3n.fsf@HIDDEN> X-Hashcash: 1:20:250225:76446 <at> debbugs.gnu.org::0KX1Sw6Ty2EjYfWZ:klm X-Hashcash: 1:20:250225:michael.albinus@HIDDEN::X5+YnYWN+1fvAkGi:1Tnq Date: Tue, 25 Feb 2025 13:17:52 -0500 Message-ID: <CH3PR84MB342487797E764F59AC3A9724C5C32@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: text/plain X-ClientProxiedBy: YT4P288CA0020.CANP288.PROD.OUTLOOK.COM (2603:10b6:b01:d4::19) To CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17) X-Microsoft-Original-Message-ID: <87tt8h7usv.fsf@HIDDEN> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR84MB3424:EE_|SJ0PR84MB1411:EE_ X-MS-Office365-Filtering-Correlation-Id: 8429cd8b-6052-4a4d-9c9b-08dd55c8b9da X-Microsoft-Antispam: BCL:0; ARA:14566002|15080799006|19110799003|7092599003|461199028|8060799006|5072599009|12121999004|440099028|3412199025|56899033|12091999003; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?veQcxZNsWCIgGZNJdJYLJriBgi53r+4PxJSgAA0TIexY44q8dBXe0hE46ASW?= =?us-ascii?Q?2RTSgRcXE+K2GdbY4AUtro7Ivl9W2Wo6i1UpS+92QQSJrE/5E2jFYke8pcQj?= =?us-ascii?Q?hhM2fB7R6DvLnNBgOeWjvNShvXDGnHfi1tWHymZvz6YFEAl4cPVI/ed3wzb0?= =?us-ascii?Q?dkr/XowFGt55KDVQUKRwSJ9b81Lb7AXQKkKcXRh8zPTUlOj6JtRtF1IX6Stq?= =?us-ascii?Q?+Z1bU+2RFV2R8R5B2MuBwBm/rKa0Bx5RalpFK/5QIvYnOcwRDnFycVmRH0FD?= =?us-ascii?Q?IqDLxQcSrxUCH+W0c8x/gq1k1kQJrP+tdhgQiqTR78r7+toHM7XPKCaiVAjs?= =?us-ascii?Q?akibptd/XlOoUcVMm84WHwfUYVJjz5T/1N91c+lhjKq9C5d/gXRkvLkYNqCc?= =?us-ascii?Q?fTyV9hxAnwWFz0oScVnNfggzgBhWzbIMreERzJvwI3dcQYvUfBOTGytBWzsM?= =?us-ascii?Q?yS8U4r50SMVRn7xZMtQwu0ar6+a1tPSw8zh5QlnX1Wt5vB5fZFjXkYcFAmr8?= =?us-ascii?Q?eoTKoszljaZ8as2Z5GyGv6cez4yk96fkuLiexcqnftv1M1lv9VoCONgqVs08?= =?us-ascii?Q?xvq1j20uuZpkHjn5v/ZKzrzZTKfg8cF18/kIR8X1NbOC9RTVlWwRcLSnT2rJ?= =?us-ascii?Q?6l7NoWAhJGtNeD9zEpYR15uYhuoANsohPCAP7pP26lvD/z26C7yM9u2j6Bnj?= =?us-ascii?Q?xYtramC0I21GEL8nQG8HCsSx6BKvPGPOpOLNlZfv7PjVYCqi6MY1jsg9+Yrz?= =?us-ascii?Q?zY9Jqh1EaLNuzTDxH1QSSacb0vSAcuTaW3ypKGsMK4GgWaCiamDLI/v7ZvXh?= =?us-ascii?Q?k1yftDfj0LmWbWf7vUVaWcZmr9OfiwEANyJPLezmYRwBu2v7+EW5T+hbGN7I?= =?us-ascii?Q?RZJtAEXK6hGyXeAJR1XsDtbaGfNV8ShK3iwYXopOofk3aYmuRNEO9AgPz0Jy?= =?us-ascii?Q?vLG40MwougQL0eKQ9B8xHHZqkYF9P9cCqzI4Tr6Vm/HTTQ2RuDIn4vicxy9o?= =?us-ascii?Q?gUNpsgqM2KK5FROiENYledbMa7A7Yp9MvEtnte8x4XO7WbhTfxJDzuNl4mkT?= =?us-ascii?Q?/TONEJ/0XxMMC9u4AgM8dgShA1We94Tz+a/o8i1/GJttuRo/WnRNYDDd5f4A?= =?us-ascii?Q?0dneEwV5kCMPyo27tsPN8KVrhEyEgZu23g=3D=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rQA8N1/SsYQQmi9Sg/wmLZxNqw0KysREI0xNoN+7lRDESw3S4ItX0tnPKufo?= =?us-ascii?Q?G292Er8SR3QN/rvfRBngkOfabW7tGiVjE4xIYVRRlyvMsAbRKCilUJ8zA5vn?= =?us-ascii?Q?kEHLeyZGd4EGNUC/tWKDi9GH2r2LBli3NIJFy921a53pLzYk0psFVjDJ2R4T?= =?us-ascii?Q?gZNZruvYNkuXx33RkRjmMGVy067W+h/LeWXc/vjAt04DoteZp+m8SfGxZqIF?= =?us-ascii?Q?Y65myvW9BMez1j4Q8VE0lH5IAb+7hgydjv6YaqROOEWrH8A3egq+urJvF2WE?= =?us-ascii?Q?EPofM868K+5q64Lcy/sfP81s9Tk0kGtZD5eN3rpUs0Q0Zc+OsExT0U3Lg24l?= =?us-ascii?Q?ZCOTx6c9MYLCAxftSYMHPupcLl5a+1rU9AvNjsmeEm3Vdt+H75fGnIuGMXjb?= =?us-ascii?Q?kq/XKbmnxvfda/VnrChYlPSCXs2DnPC/0bv16HYLG6n91mCjx1kF9eAlA7t2?= =?us-ascii?Q?Nue3zurbAsyXA4/SrRUTh3+kkv35Ye19ChcuGEAd3R+M/6EiP4qjGun9OTGY?= =?us-ascii?Q?WUk3XvenvFQBTrvPGHjmGyKwEGO02UcODIYQ8tSggsx1dOV0HMVt+zpg5PQA?= =?us-ascii?Q?LrpHf7zNvfg+aF3IvmAI//q9XaO18HeKuy5ZGFr/PuhGJiSb2ABTCHNXL6sm?= =?us-ascii?Q?t4KcAeL2Ccf9/iWqAwn6/mCeVnCxPwI70SO29VXrYQxMoet32llszycbk4rn?= =?us-ascii?Q?sxpTrejxyXKblJperWvy+bFTYeq7QQJ/KO2UvLqsA4Ihhma2kzOOUoH6tf6q?= =?us-ascii?Q?Nlsg+HEIb7g2GzJ1QQJV4ooZ67amx46094lDZuqOvUGNQPFUyo8JitgecgRo?= =?us-ascii?Q?DPR1VvfTAu6C7w8Ej4yycEuSflUtfz/Stfgq901AAC1+9zNyMvCtdWSZ9JGI?= =?us-ascii?Q?byYwBSPsponrsNd+tPod1P9Zdib2hsfSWz6aOqglm/eWTkXpjvATsy+hYhiX?= =?us-ascii?Q?69Rdv27MEe+66oB6zmHfzmqh7B0rRfptIJCSEbhhMPJNpJB+rREqoMNaU57S?= =?us-ascii?Q?iYRw0+bndMEfrzlOMxNnhKROW15NaLbEa+RBBX/WNJwwCAvM+dQjlLhj341K?= =?us-ascii?Q?Zi8nUy4jPoYRB6Y0NeWUsNCDVepCuMyUB1GAtJJor4jzUgGfhRPs6dx7GMcY?= =?us-ascii?Q?1+NrQKl3lbn8+/K7u/N4BoVdX/VS1sW12Js8gnmacDreQbOmOf+kXsUg3Rz2?= =?us-ascii?Q?XooBGaT+CyCLU4Jtvk+N4ChqlRtUWJSmJe4mRd3to0PEtl+kL7n+usl9jVc2?= =?us-ascii?Q?x44RKE+/Wn50znnGTtlA?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8429cd8b-6052-4a4d-9c9b-08dd55c8b9da X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2025 18:17:56.0707 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR84MB1411 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 76446 Cc: 76446 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Michael Albinus <michael.albinus@HIDDEN> writes: > Morgan Smith <morgan.j.smith@HIDDEN> writes: > > Hi Morgan, > >> I'm still not 100% sure what the ideal way to send in patches is. Here >> is the entire v3 patch series > > This is fine. Since most of the changes are not controversial, I've > committed all your patches to the debbugs repo (plus some very minor > cleanups from me). I am still curious. The guix people seem to prefer 'git send-email' but I was told not to do that by some emacs devel people. > The last point I like to discuss is the Makefile. Attached is a patch I > propose. It changes the handling of the tests more like Emacs does. Now > we have different calls: > > --8<---------------cut here---------------start------------->8--- > # make check > # make debbugs-tests > # make debbugs-gnu-tests > --8<---------------cut here---------------end--------------->8--- > > What's missing is the handling of SELECTORs like Emacs does. This we > could add later. > > WDYT? I started looking at what emacs does. It looks complicated. I don't entirely understand what they are doing. However, I would argue that what is currently in the debbugs makefile is quite powerful and I would be interested in what use cases your solution provides. Are you trying to improve performance of running the tests? Here are the performance numbers for running the current tests on my laptop: make clean time make build 0.590s time make check 0.472s time make check TESTS=get-status 0.148s time make check TESTS=no-tests 0.122s time emacs -Q --batch 0.033s As we can see, if we only selectivly load the test files instead of loading all of the test files, we can maybe save 1/10 of a second. I personally am not that worried about this. Are you trying to selectively run tests so we can debug tests one at a time? That is already entirely doable with the current setup. Running 'make check TESTS=get-status' only runs a singular test. The patch you have provided actually removes the ability to run one test at a time as we'd have to run entire files. I'm not certain what the SELECTORs do but perhaps you're thinking that in the future we would have groups of tests (like "expensive" or "network") that we could select. In the interest of not over-engineering on hypotheticals, I would say that is a future problem. One that I would likely solve by putting those test files in sub-directories labeled "expensive" and "network". > > Best regards, Michael. > > diff --git a/Makefile b/Makefile > index da0764ea36..bb69ebe9da 100644 > --- a/Makefile > +++ b/Makefile > @@ -1,13 +1,11 @@ > EMACS ?= emacs > MAKEINFO ?= makeinfo > > -# regex of tests to run > -TESTS=.* > - > SOURCE=$(wildcard *.el) > TESTSOURCE=$(wildcard test/*.el) > TARGET=$(filter-out debbugs-pkg.elc,$(patsubst %.el,%.elc,$(SOURCE))) > TESTTARGET=$(patsubst %.el,%.elc,$(TESTSOURCE)) > +TESTS=$(patsubst test/%.el,%,$(wildcard test/*-tests.el)) > > INFOMANUALS=debbugs.info debbugs-ug.info > > @@ -30,10 +28,14 @@ doc: $(INFOMANUALS) > build: $(TARGET) > > checkdoc: $(SOURCE) $(TESTSOURCE) > - @$(EMACS) -Q --batch -l resources/debbugs-checkdoc-config.el $(foreach file,$^,"--eval=(checkdoc-file \"$(file)\")") > + @$(EMACS) -Q --batch -l resources/debbugs-checkdoc-config.el \ > + $(foreach file,$^,"--eval=(checkdoc-file \"$(file)\")") > + > +check: $(TESTS) > > -check: build $(TESTTARGET) > - @$(EMACS) -Q --batch -L . -L ./test $(foreach file,$(TESTSOURCE), -l $(file)) --eval '(ert-run-tests-batch-and-exit "$(TESTS)")' > +%-tests: build $(TESTTARGET) > + @$(EMACS) -Q --batch -L . -L ./test -l $@ \ > + --eval '(ert-run-tests-batch-and-exit t)' > > clean: > -rm -f $(TARGET) $(TESTTARGET) $(INFOMANUALS)
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.Received: (at 76446) by debbugs.gnu.org; 24 Feb 2025 18:52:25 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 24 13:52:25 2025 Received: from localhost ([127.0.0.1]:42593 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tmdZ3-00012N-Ch for submit <at> debbugs.gnu.org; Mon, 24 Feb 2025 13:52:25 -0500 Received: from mout.gmx.net ([212.227.17.20]:54603) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <michael.albinus@HIDDEN>) id 1tmdYy-000122-Bp for 76446 <at> debbugs.gnu.org; Mon, 24 Feb 2025 13:52:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1740423134; x=1741027934; i=michael.albinus@HIDDEN; bh=asMRhhCo5ufwJiPovrCJ0/tAzBGBajIDtVQ8kFZQdRc=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=m6F8liy6+PcxBRhxGstfRzhrkUGOf4+CtXs8rwB8zmRaS4diCHinUwNKc75uad9s 1t1dOd3FBg/L9nv6YIecYsROlHhr3/+r9WEEeYkThSjRHyoACVxAGfCvz4/hDFPI4 UBCSMv3IzFmcEOLpQE/br+HQyPEvzhiAb8hS9FN07K3RUD/cd4+R1ERIBEs9wEIBq ooK0giVKbZZ+UcDyo6CM5ZNWOysMG/yM3xk0kxQ3Hpej5OzJmUPtTnRmSwBmpLc20 PYy7SMQbjmxdQaaKv5CHavNOkXjlZLMvDVr9Xnobgg7fxLdNJSMo2/T/rw5nE62GV rYe7Y5w2U+PzWxXtSg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N4hzj-1tLquo3ZQd-00rKh0; Mon, 24 Feb 2025 19:52:14 +0100 From: Michael Albinus <michael.albinus@HIDDEN> To: Morgan Smith <morgan.j.smith@HIDDEN> Subject: Re: bug#76446: [Patch Debbugs v3] Infrastructure Improvements In-Reply-To: <CH3PR84MB3424F04FC0B2977D0234503BC5C12@HIDDEN> References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN> <87bjuvy17p.fsf@HIDDEN> <CH3PR84MB3424807016C1C6E6EBCD08E6C5C72@HIDDEN> <CH3PR84MB3424F04FC0B2977D0234503BC5C12@HIDDEN> Date: Mon, 24 Feb 2025 19:52:12 +0100 Message-ID: <874j0jyy3n.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:RPH6disOhpQlEJ+G8OKSxzTiH5mNoc77BhfYqOTxhdxXczMoCCP NVGqLVEoVZ1nh/bV5DP325R0HUPAQfYtLTK53Lkn3mRcN0T3YmAIkTHs7gy7yBG0slbqfa4 jddxYlmkuIT6AcR212tHwpdbjSiaR5TqEM/blnHmi8SmsqbCHZAqGQagkOY2knetazpiN3A vfi1lKxT0cfRGEDG1/BLg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:KKpY8tJ/RgU=;3MbeMlh9mVoZgA3USBZ1lrUYdz7 K1D3/2clMDE9u1+AEdMfdABRcpxiipZAWUcULCzlAnuqL6qGMJtPnaMRYvFxeEJuY9eQJAUc/ EUMjKmcA97czHXCjIQimUOiS+NrzU91GXMOPWC1u31SVFFe+6cbAPkpIdkKEjTeLL9CEZmWyM 5IyuUVSSnFKwMA1Ki8VLvMj5L1/hAPTVtOArk+SowhRn/LFFH/tpCvW7MkFUgaVjBkiyG3CGu KXCDL2b/PAwktY0U1Wy/OaYjIUsH27yCNu2J0lh6Ou1KVKbt0uEtE+i49F6RBHEdvd5xFxigJ 3CWQz651gXAXxsZFi9MSppt71Kl5o1tbJg67GmcXWXGFpOyrkmYgcOhEmz7p29WqiXXs9ZPue LMY10C8UcuCHAe08/FW6RJKQrfEFG5YoFyCira8rYoMmMz2grAjycv1lVlLrhbV2pGKKCdz2E MhDtleqV9RDdub7aeLarHK1WVgJCx9TkQC3xtZcIUaLZ6mFoYVj9JZxPlpsp+J5ZZVYUg6iCW ztZmZd1iUlWHKdsbiVRA6KaPLDSxmMio6MMVDW6UXzqzo6h0VgC7c7Ssi74FP4wR8aViTiduH xfHlxAk22hjczpQpJQ+zRkCWb5s+gYxVsDV5uw5nCIV6Bbq+kdMjUIVAfu/DxN3ayz1yXPBQb XrNMlT7hEVeJwmOej75y/uRoe127zXeDdotd/aL0tXUb0kdTjMVbR7DyJIfNVu6l6YOfynegA 6jx6n90g+eTnJ4hYut6bL1VLjQVnn3bOgYH42rQ1p+Kz0ISKs4OkaNe0lfaKrnmAiSY/ZoF/R Ug/KruMyuWNFYyz0xUpQYlTVxI8WIgjw3roZ9+6m7eW8RtsfRz18D/A/Zhk99JGVTgbPmJ1YZ wkYqzq0jT7uuMzk4Aksuq2I9D9HdUXLx/zylHi0LaJDyRhbjk5PF3mHthJDQZcBSedhXSKWw5 OVthNYtyUBZmVqN1LDqxc6mGBDj3T/t5zpvg0QaDi6bz3K9sOcY8hebArNhblr+2tAUpnMK/a jFTWf7L/3u924d3c8JcnUgyivnDGmeRH1MhNe3j4FQfHIkcej3lof7+XjIuHpUxZwqDPU2mQi 4IyDarEuWddEt9VKOztHpFTpNGNUE1ELsm0EKxe/Noobrb7Gn8aRvN3XEkVWUuQCz1skvD39X DBUDDVAT+8DFXi1Br2Ir0lE6iwmtqrUoRET7/WQWxNFhUKbA+n7Rd919itmTnpesL32b5aWEd DO7tpEz9YH7eAA4/V0wCfgSHCR1jgbxj1u9CXQLEeQvaSS1DCS6eIAu6lZoZW6hM3i1KJ6Ujb fKFrxBIPw5kAY/VlX8VUwfqglBp5ezuyKrFJ2cGqZUhQLzYZmGhJkrWqEqlYQ6dAeIoHQWqJR cbrWk4FLym5M/7qRDVm/Gmo8UtCCpisY6YY4AZhiFrK0HpA/nqXwzE+yfu X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76446 Cc: 76446 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Morgan Smith <morgan.j.smith@HIDDEN> writes: Hi Morgan, > I'm still not 100% sure what the ideal way to send in patches is. Here > is the entire v3 patch series This is fine. Since most of the changes are not controversial, I've committed all your patches to the debbugs repo (plus some very minor cleanups from me). The last point I like to discuss is the Makefile. Attached is a patch I propose. It changes the handling of the tests more like Emacs does. Now we have different calls: --8<---------------cut here---------------start------------->8--- # make check # make debbugs-tests # make debbugs-gnu-tests --8<---------------cut here---------------end--------------->8--- What's missing is the handling of SELECTORs like Emacs does. This we could add later. WDYT? Best regards, Michael. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Transfer-Encoding: quoted-printable diff --git a/Makefile b/Makefile index da0764ea36..bb69ebe9da 100644 =2D-- a/Makefile +++ b/Makefile @@ -1,13 +1,11 @@ EMACS ?=3D emacs MAKEINFO ?=3D makeinfo -# regex of tests to run -TESTS=3D.* - SOURCE=3D$(wildcard *.el) TESTSOURCE=3D$(wildcard test/*.el) TARGET=3D$(filter-out debbugs-pkg.elc,$(patsubst %.el,%.elc,$(SOURCE))) TESTTARGET=3D$(patsubst %.el,%.elc,$(TESTSOURCE)) +TESTS=3D$(patsubst test/%.el,%,$(wildcard test/*-tests.el)) INFOMANUALS=3Ddebbugs.info debbugs-ug.info @@ -30,10 +28,14 @@ doc: $(INFOMANUALS) build: $(TARGET) checkdoc: $(SOURCE) $(TESTSOURCE) - @$(EMACS) -Q --batch -l resources/debbugs-checkdoc-config.el $(foreach f= ile,$^,"--eval=3D(checkdoc-file \"$(file)\")") + @$(EMACS) -Q --batch -l resources/debbugs-checkdoc-config.el \ + $(foreach file,$^,"--eval=3D(checkdoc-file \"$(file)\")") + +check: $(TESTS) -check: build $(TESTTARGET) - @$(EMACS) -Q --batch -L . -L ./test $(foreach file,$(TESTSOURCE), -l $(f= ile)) --eval '(ert-run-tests-batch-and-exit "$(TESTS)")' +%-tests: build $(TESTTARGET) + @$(EMACS) -Q --batch -L . -L ./test -l $@ \ + --eval '(ert-run-tests-batch-and-exit t)' clean: -rm -f $(TARGET) $(TESTTARGET) $(INFOMANUALS) --=-=-=--
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.
Received: (at 76446) by debbugs.gnu.org; 23 Feb 2025 19:26:35 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 23 14:26:35 2025
Received: from localhost ([127.0.0.1]:36204 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tmHcY-0001zo-9N
for submit <at> debbugs.gnu.org; Sun, 23 Feb 2025 14:26:35 -0500
Received: from mail-dm3nam02olkn20800.outbound.protection.outlook.com
([2a01:111:f403:2c05::800]:39681
helo=NAM02-DM3-obe.outbound.protection.outlook.com)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <morgan.j.smith@HIDDEN>)
id 1tmHcU-0001zY-If
for 76446 <at> debbugs.gnu.org; Sun, 23 Feb 2025 14:26:32 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=cEWbGpfCrHg1X15Ca3ouQSmiOtOxkQt14dI4iD+Uwke7S+OX79VipcT1flp/Dqkc8AHqCAWNbGV4ual/TDncjca/nabtXSEp3E+sjumIlk3K5lt0nPjYkwXQnsfFCICI8LL34iNGtIEmQjHVAxV6XJbL4Ak2F6Y8kimfLqsmgsVQFTnSFxb8jVWtCuGq/ErwXPHXKh82J+0Gq4os1yHicNarKM7QPX1s7o/nE7rq4yBlQr6en8z4LFC5RyjQifGk5msbLWn/qD916h5X1xwMUPOJdmvskuxu60cm3RkMGooNWKBCvZ3nZqY/fUQf0K8JZF56MMYd5jtO/oDa/w39KQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=LNRMnkcWBojVBqcI1mSCOG5/MyzirMS+qNdTLVHcvtg=;
b=ipkKDTQZSHi/RiMH1Z9JEicBFIbhiCoXTdjgpFgXD+CTs8hx/f3rJwPdcwIje4Z5AdgD2XJMgj8JiEMYpO/+83PazQa0OV/76GN/6uyQ6oql0mOl6J/PUpwS7wIyo7Rc1EoLdKVNfDEZwMdnkj3VCNFbhvj82yvP5SQuW4pZYSkdMHgAgG6rLG3YAmhKYbAAzvSZC7+L+fpaDyWGYjsBXZna2OiqxM2pcWZdl2A9dzVIuJJuUmpjqBd/HL7kWyoSuM1x/LEuYPrsM6db6A/R5MClnx63/i7jaMuWcLvQbP8mbPbh7ymakrKaHz/Al+kiaX9Vcet5qKwaKZl9BDpX4w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=LNRMnkcWBojVBqcI1mSCOG5/MyzirMS+qNdTLVHcvtg=;
b=NrI8A30Z8lK+gVStwk2lISTcMxllQS4UratRmpfY62E8gWqUogCBsgL9heSf2Lh7VL3B27nTrGXHbvCqNztV3nrE430Jonoo57opznQA20FRgoRjIAoUVOV8Mx6BaBZHKlre+bWohzlxB7EDdMyM5ICbr1Jfa2NHCPbWoQOdHUaANGoaulkg9qREzEUScYZlJfbvtjcoRwLzSznxbVdUJHGOQ4Vsz/iide4iNXoPvlyBaqKJKMk56d+wpvhStkeOQsjUuOG+XEola6smZhFF6S6Sh/IekeBpXGkAurm797aBh6cCRoGAC+Y4tJh2X266lq9dyR4q7P0yPPWW23EqkA==
Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17)
by SN7PR84MB3154.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:806:272::13)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.18; Sun, 23 Feb
2025 19:26:23 +0000
Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
([fe80::5c77:7a58:48ed:9aef]) by CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
([fe80::5c77:7a58:48ed:9aef%4]) with mapi id 15.20.8466.016; Sun, 23 Feb 2025
19:26:22 +0000
From: Morgan Smith <morgan.j.smith@HIDDEN>
To: Michael Albinus <michael.albinus@HIDDEN>
Subject: Re: bug#76446: [Patch Debbugs v3] Infrastructure Improvements
In-Reply-To: <CH3PR84MB3424807016C1C6E6EBCD08E6C5C72@HIDDEN>
(Morgan Smith's message of "Fri, 21 Feb 2025 13:20:41 -0500")
References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN>
<87bjuvy17p.fsf@HIDDEN>
<CH3PR84MB3424807016C1C6E6EBCD08E6C5C72@HIDDEN>
X-Hashcash: 1:20:250223:michael.albinus@HIDDEN::APvR6bsR5XiMqztQ:16gD
X-Hashcash: 1:20:250223:76446 <at> debbugs.gnu.org::LT1H9NOOTXek58FW:6v/f
Date: Sun, 23 Feb 2025 14:26:19 -0500
Message-ID: <CH3PR84MB3424F04FC0B2977D0234503BC5C12@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
Content-Type: multipart/mixed; boundary="=-=-="
X-ClientProxiedBy: YT4PR01CA0440.CANPRD01.PROD.OUTLOOK.COM
(2603:10b6:b01:10d::16) To CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
(2603:10b6:610:1c4::17)
X-Microsoft-Original-Message-ID: <87r03o799g.fsf_-_@HIDDEN>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CH3PR84MB3424:EE_|SN7PR84MB3154:EE_
X-MS-Office365-Filtering-Correlation-Id: 44dfe43c-80a7-4292-970d-08dd543ff4c2
X-Microsoft-Antispam: BCL:0;
ARA:14566002|5072599009|19110799003|8060799006|461199028|6092099012|15080799006|7092599003|3412199025|440099028|13095399003|41001999003|56899033;
X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?rr7J4lvoo2ouIWAPnEJ/aiauP2ICUFwsy5WD6sxmiSiI2VF72juUWhce/V8l?=
=?us-ascii?Q?GkJSUvGBzVUNPeMrYhfXWEajkxHXx2b8owLkJvrCyVuElOUTpvQytCBe0ykf?=
=?us-ascii?Q?wTMa+iVP0uhLQQKGiih6+MKb2pxMHI2UVgzmYNinFiR0fcYaWOVXy1/dMBFv?=
=?us-ascii?Q?BsA34bjAl3daeqwzABzPSpfsH4s5SQVVuI1PC4/uqCs2A5pFMLzrwG7vsnQO?=
=?us-ascii?Q?w5NidkCegwahq5mUKpQfOAZqaFJ7H0L+/2mhPg/SgNPE/jrMZ8iHDDaRMPo0?=
=?us-ascii?Q?3LaJ50ocABJjpoD+nDYUEjis/LuJdspf8UyEXoRXnQg3Y7Z95Vqx/dAb5VwJ?=
=?us-ascii?Q?zuEez5aBPmZ8pENgovCzMPXgtIgaDK0ytP40Mtjkagn8mAIlqzuOkCMohisN?=
=?us-ascii?Q?1LROgUeMSDtxm99uuSpMnHkyQ2b8vOeypQxXeoFkSYjdzJE6aZeLiK3BPs6C?=
=?us-ascii?Q?c/OBimIm7jG7YRJHzrOq5ZpLD+XyFvNS+G5NmaJcUrxGzh0vhKSWqM+f+uwq?=
=?us-ascii?Q?6/hYHl9+yi06RpstzgFZnwLl4WadqvKEmh6cuHSx0eVYoHDEPirDf7zSL8N7?=
=?us-ascii?Q?DS4GT6Vh9G7aVgGWKzfovnlN0UjpFLAaJ6hMv9nXI22F931ZDwGR1KSI7WRw?=
=?us-ascii?Q?rgO8g+3O8FuT+xvlJ1U68pAXwKtDT0VME2ezbZ24BmyQOqT2ZHRAzqOi4yuJ?=
=?us-ascii?Q?T+k/eNbB8XloYur/1BFjeT3W/rwGNQ9+0d3uefQEr2BR2IgyttPUNS1dGFeH?=
=?us-ascii?Q?r6euwgqs9WZbvh9VEU/Ma/t6tWGoTOJmavsJ2CsWMKp0Ap127o0TjaVqqUeF?=
=?us-ascii?Q?MLQqBxxcSkh377blbWIwAlJHCBZPjRAN65OFew/6vY6F/kSSt+PSvVg1eBjl?=
=?us-ascii?Q?5PuPnRCdiEUpgDGRw5VMuk2ovSmQ32uKSr6+tyudQ2PdrE+sTQj2y+/x42d4?=
=?us-ascii?Q?aIf7+ryGatWT/+4O8nI+u1qNidYh1UGbj63TXlmMkLt7O7elcNBL8ya90Pco?=
=?us-ascii?Q?SEsCYtS3bOQo/h69pYOzlJwUaKKIkGVDogSAZXsXjXxiJRmN44RwIM/E1+AK?=
=?us-ascii?Q?SqcA/lXV4Y+moD+Q/CKsGbJJFyM6RBzgiO5V4CmGCtOQXLFkQUAa+PyNmX26?=
=?us-ascii?Q?VxsPAykbXVn4wt05wwhAM7v8T+T+7JcdngWuZmgcAvoP/ALSx3w9rDQ=3D?=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?srLTQn1npUJ8hzqoXSCwRi4BVbnHiL6t00m3EGP8S8fF2R87EfU468ME2Awq?=
=?us-ascii?Q?KrBPSOYRGDcM/CYXIHKr4nylzC0IqAxzrvG5DwSVQPUZGD+9Rb5zat8t6vie?=
=?us-ascii?Q?pGsORY16lSmlH4RfzfKNIbvJYfAERJGkPqLTz3l3LnrF781w7m8UwO8vC+Q2?=
=?us-ascii?Q?z9x/O+qS5vXtlxWvrRyRQlOAOMHLTuzP8mvBculK1jYMkZpcQ2Bn8OafI/SM?=
=?us-ascii?Q?jKqBu3c755jGvMg2OYARToKd5IjBBgZEBeO33LhEyWu6GvxYMBSUfnhrSqjS?=
=?us-ascii?Q?6Dl0kB0xXMZn8fLC1x1wPpg13d9CyezVfXR0z2hRG+gm48gxmZUymxNRDX0d?=
=?us-ascii?Q?JW01tKfkSWcFIZBa/okLMPbwwuzbdDJyJ8Oag4WZRtnikBMwWtGKJgZfgOaQ?=
=?us-ascii?Q?uA/ES4R+QfAwCon55cLmIWvNTj5xe8xC9ogUTO4OGw9XJAkQkJSfR+834cSK?=
=?us-ascii?Q?X70lD1LTwT7sdHWllvsGX2392m7orD0Lk0fZzyqhfj1//JaG9llYAVnLCgxm?=
=?us-ascii?Q?/u027nKeefmUi6yomDDMYD+FXzMmKYe39pojwNXoGVDKnZBGaw+UP9KoJ80e?=
=?us-ascii?Q?6cYnBteaEjEVHO9XszXlekAx01zic1wJiFwO2RYmjml7nEbG6N95SpgBQhut?=
=?us-ascii?Q?e9byUfEKjn2J9bxkysP0BejaEz5N5yhEWKevA9QcGcF4Kq0PcygrKcH2b2CK?=
=?us-ascii?Q?tB8uc2IcQkCv89D1ZVL06K9sk+33x90KNiCIAR/z7/ffH/N8Q7pc3n67m+mv?=
=?us-ascii?Q?42eBj5dpnkOHW9u4ikTfBY6E4Y76xQGmrFDgYPmVEvhM6+C+U/CZ+PSc3PSF?=
=?us-ascii?Q?hylaZP1sjreHC1mWuxrTSvTNfixMLvddwUhai8+THGFWPLUyLQdjSqtL8s9v?=
=?us-ascii?Q?IH7zRtuhAEEQUfR9Ui4DG/Rie5AJ1wwhBHzijh9q4ZacokhzpgNh6NVIt3NO?=
=?us-ascii?Q?pvZJ5gpStCkibJxAu/GKr6S6UUUmJ5v7FWuc4MhHK8LyYrpAeV+BJWGmvgFz?=
=?us-ascii?Q?Ihkc9FQd2YCMShmiPKg4Mx9x3etNuEf1qFAyMueYPgu9CYXi6CpRx+hK+d91?=
=?us-ascii?Q?6BIXLDYcBmQOTd+y0EP8QBDsw2fyObZujsj77k8fZIAwy6x5dWjPTWb+auKC?=
=?us-ascii?Q?xVq80U71YSL9FhBkHlknQUz8IMUrAreOY1ctWFTuCdbRbPk/TLCdRcRTDvr7?=
=?us-ascii?Q?RgpOddKhO2n/cJTTTGlwBxqBiMlGW3gJ0OfaDnzpds2wJgH/mEky+rJ0AdmL?=
=?us-ascii?Q?CXbLOnGvOFBUGw8oSgUY?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 44dfe43c-80a7-4292-970d-08dd543ff4c2
X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2025 19:26:22.5768 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR84MB3154
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 76446
Cc: 76446 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain
I'm still not 100% sure what the ideal way to send in patches is. Here
is the entire v3 patch series
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=v3-0001-tests-Move-helper-and-wrapper-functions-into-thei.patch
From 71fd3e1a8490c038473e91fd521ced6661de56f6 Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Fri, 21 Feb 2025 12:52:03 -0500
Subject: [PATCH v3 1/5] tests: Move helper and wrapper functions into their
own file
* test/debbugs-test-helpers.el: New file.
* test/debbugs-tests.el: Move test helper and wrapper functions into the new
file and require it.
* Makefile(check): Load all files in the test directory.
---
Makefile | 8 +-
test/debbugs-test-helpers.el | 146 +++++++++++++++++++++++++++++++++++
test/debbugs-tests.el | 113 +--------------------------
3 files changed, 154 insertions(+), 113 deletions(-)
create mode 100644 test/debbugs-test-helpers.el
diff --git a/Makefile b/Makefile
index a7b6b0c7f3..81d7b5d2f2 100644
--- a/Makefile
+++ b/Makefile
@@ -1,6 +1,9 @@
EMACS ?= emacs
MAKEINFO ?= makeinfo
+# regex of tests to run
+TESTS=.*
+
SOURCE=$(wildcard *.el)
TESTSOURCE=$(wildcard test/*.el)
TARGET=$(filter-out debbugs-pkg.elc,$(patsubst %.el,%.elc,$(SOURCE)))
@@ -14,6 +17,9 @@ INFOMANUALS=debbugs.info debbugs-ug.info
%.elc: %.el
@$(EMACS) -Q -batch -L . -f batch-byte-compile $<
+test/%.elc: test/%.el
+ @$(EMACS) -Q -batch -L . -L ./test -f batch-byte-compile $<
+
%.info: %.texi
$(MAKEINFO) --error-limit=0 --no-split $< -o $@
@@ -24,7 +30,7 @@ doc: $(INFOMANUALS)
build: $(TARGET)
check: build $(TESTTARGET)
- @$(EMACS) -Q --batch -L . -l $(TESTSOURCE) -f ert-run-tests-batch-and-exit
+ @$(EMACS) -Q --batch -L . -L ./test $(foreach file,$(TESTSOURCE), -l $(file)) --eval '(ert-run-tests-batch-and-exit "$(TESTS)")'
clean:
-rm -f $(TARGET) $(TESTTARGET) $(INFOMANUALS)
diff --git a/test/debbugs-test-helpers.el b/test/debbugs-test-helpers.el
new file mode 100644
index 0000000000..f98bab40ed
--- /dev/null
+++ b/test/debbugs-test-helpers.el
@@ -0,0 +1,146 @@
+;;; debbugs-test-helpers.el --- Helpers for testing debbugs -*- lexical-binding: t; -*-
+
+;; Copyright (C) 2024-2025 Free Software Foundation, Inc.
+
+;; Author: Morgan Smith <Morgan.J.Smith@HIDDEN>
+;; Package: debbugs
+
+;; This file is not part of GNU Emacs.
+
+;; This program is free software: you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; This program is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;; Please ensure tests don't actually make network calls.
+
+;;; Code:
+
+(require 'debbugs)
+
+;;; Helper Data:
+
+;; Generated using this:
+;; (soap-invoke debbugs-wsdl debbugs-port "get_status" [64064])
+(defconst debbugs-test--bug-status-soap-return
+ '(((item
+ (key . 64064)
+ (value
+ (package . "emacs") (found_date) (last_modified . 1689593050)
+ (affects) (date . 1686745022) (fixed_versions)
+ (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>")
+ (blocks) (archived . 1) (found) (unarchived) (tags . "patch")
+ (severity . "normal") (location . "archive") (owner) (fixed)
+ (blockedby) (pending . "done") (keywords . "patch") (id . 64064)
+ (found_versions) (mergedwith) (summary) (forwarded)
+ (log_modified . 1689593050)
+ (done . "Michael Albinus <michael.albinus@HIDDEN>")
+ (source . "unknown")
+ (msgid
+ . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>")
+ (bug_num . 64064) (subject . "[PATCH 0/4] debbugs improvements")
+ (fixed_date)))))
+ "Mock result from `soap-invoke' for bug 64064.")
+
+;; Generated using this:
+;; (debbugs-get-status 64064)
+(defconst debbugs-test--bug-status
+ '(((cache_time . 5000) (source . "unknown") (unarchived)
+ (keywords "patch") (blocks) (pending . "done") (severity . "normal")
+ (done . "Michael Albinus <michael.albinus@HIDDEN>") (location . "archive")
+ (log_modified . 1689593050) (subject . "[PATCH 0/4] debbugs improvements")
+ (last_modified . 1689593050) (found) (tags "patch") (package "emacs")
+ (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>") (archived . t)
+ (blockedby) (affects) (mergedwith) (summary) (date . 1686745022)
+ (fixed_versions) (id . 64064) (fixed) (found_date) (forwarded)
+ (msgid
+ . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>")
+ (owner) (found_versions) (fixed_date) (bug_num . 64064)))
+ "Mock result from `debbugs-get-status' for bug 64064.")
+
+;;; Helper Functions:
+
+(defvar debbugs-test--soap-operation-name nil)
+(defvar debbugs-test--soap-parameters nil)
+(defun debbugs-test--soap-invoke-internal
+ (callback _cbargs _wsdl _service operation-name &rest parameters)
+ "Over-ride for testing."
+ (setq debbugs-test--soap-operation-name operation-name)
+ (setq debbugs-test--soap-parameters parameters)
+ (let ((return
+ (cond ((string-equal operation-name "get_status")
+ debbugs-test--bug-status-soap-return)
+ ((string-equal operation-name "get_usertag")
+ '(((hi))))
+ (t '((0))))))
+ (if callback
+ (progn
+ (funcall callback return)
+ nil)
+ return)))
+
+(defun debbugs-test--override-float-time (func &rest rest)
+ "Override `float-time' for FUNC with args REST."
+ (cl-letf (((symbol-function #'float-time)
+ (lambda (&optional _specified-time) 5000)))
+ (apply func rest)))
+
+(defun debbugs-test--setup ()
+ "Mock network and time functions.
+These mock functions are needed to make the tests reproducible."
+ (setq debbugs-test--soap-operation-name nil)
+ (setq debbugs-test--soap-parameters nil)
+
+ (add-function
+ :override (symbol-function #'soap-invoke-internal)
+ #'debbugs-test--soap-invoke-internal)
+
+ (add-function
+ :around (symbol-function #'debbugs-get-cache)
+ #'debbugs-test--override-float-time)
+
+ (add-function
+ :around (symbol-function #'debbugs-put-cache)
+ #'debbugs-test--override-float-time))
+
+(defun debbugs-test--teardown ()
+ "Restore functions to as they where before."
+ (setq debbugs-test--soap-operation-name nil)
+ (setq debbugs-test--soap-parameters nil)
+
+ (remove-function
+ (symbol-function #'soap-invoke-internal)
+ #'debbugs-test--soap-invoke-internal)
+
+ (remove-function
+ (symbol-function #'debbugs-get-cache)
+ #'debbugs-test--override-float-time)
+
+ (remove-function
+ (symbol-function #'debbugs-put-cache)
+ #'debbugs-test--override-float-time))
+
+(defmacro ert-deftest--debbugs (name args docstring &rest body)
+ "The same as `ert-deftest' but runs setup and teardown functions."
+ (declare
+ (doc-string 3)
+ (indent 2))
+ `(ert-deftest ,name ,args ,docstring
+ (debbugs-test--setup)
+ ,@body
+ (debbugs-test--teardown)))
+
+
+(provide 'debbugs-test-helpers)
+
+;;; debbugs-test-helpers.el ends here
diff --git a/test/debbugs-tests.el b/test/debbugs-tests.el
index f3abea2837..da1b9dffe6 100644
--- a/test/debbugs-tests.el
+++ b/test/debbugs-tests.el
@@ -27,118 +27,7 @@
;;; Code:
(require 'debbugs)
-
-;;; Helper Data:
-
-;; Generated using this:
-;; (soap-invoke debbugs-wsdl debbugs-port "get_status" [64064])
-(defconst debbugs-test--bug-status-soap-return
- '(((item
- (key . 64064)
- (value
- (package . "emacs") (found_date) (last_modified . 1689593050)
- (affects) (date . 1686745022) (fixed_versions)
- (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>")
- (blocks) (archived . 1) (found) (unarchived) (tags . "patch")
- (severity . "normal") (location . "archive") (owner) (fixed)
- (blockedby) (pending . "done") (keywords . "patch") (id . 64064)
- (found_versions) (mergedwith) (summary) (forwarded)
- (log_modified . 1689593050)
- (done . "Michael Albinus <michael.albinus@HIDDEN>")
- (source . "unknown")
- (msgid
- . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>")
- (bug_num . 64064) (subject . "[PATCH 0/4] debbugs improvements")
- (fixed_date)))))
- "Mock result from `soap-invoke' for bug 64064.")
-
-;; Generated using this:
-;; (debbugs-get-status 64064)
-(defconst debbugs-test--bug-status
- '(((cache_time . 5000) (source . "unknown") (unarchived)
- (keywords "patch") (blocks) (pending . "done") (severity . "normal")
- (done . "Michael Albinus <michael.albinus@HIDDEN>") (location . "archive")
- (log_modified . 1689593050) (subject . "[PATCH 0/4] debbugs improvements")
- (last_modified . 1689593050) (found) (tags "patch") (package "emacs")
- (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>") (archived . t)
- (blockedby) (affects) (mergedwith) (summary) (date . 1686745022)
- (fixed_versions) (id . 64064) (fixed) (found_date) (forwarded)
- (msgid
- . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>")
- (owner) (found_versions) (fixed_date) (bug_num . 64064)))
- "Mock result from `debbugs-get-status' for bug 64064.")
-
-;;; Helper Functions:
-
-(defvar debbugs-test--soap-operation-name nil)
-(defvar debbugs-test--soap-parameters nil)
-(defun debbugs-test--soap-invoke-internal
- (callback _cbargs _wsdl _service operation-name &rest parameters)
- "Over-ride for testing."
- (setq debbugs-test--soap-operation-name operation-name)
- (setq debbugs-test--soap-parameters parameters)
- (let ((return
- (cond ((string-equal operation-name "get_status")
- debbugs-test--bug-status-soap-return)
- ((string-equal operation-name "get_usertag")
- '(((hi))))
- (t '((0))))))
- (if callback
- (progn
- (funcall callback return)
- nil)
- return)))
-
-(defun debbugs-test--override-float-time (func &rest rest)
- "Override `float-time' for FUNC with args REST."
- (cl-letf (((symbol-function #'float-time)
- (lambda (&optional _specified-time) 5000)))
- (apply func rest)))
-
-(defun debbugs-test--setup ()
- "Mock network and time functions.
-These mock functions are needed to make the tests reproducible."
- (setq debbugs-test--soap-operation-name nil)
- (setq debbugs-test--soap-parameters nil)
-
- (add-function
- :override (symbol-function #'soap-invoke-internal)
- #'debbugs-test--soap-invoke-internal)
-
- (add-function
- :around (symbol-function #'debbugs-get-cache)
- #'debbugs-test--override-float-time)
-
- (add-function
- :around (symbol-function #'debbugs-put-cache)
- #'debbugs-test--override-float-time))
-
-(defun debbugs-test--teardown ()
- "Restore functions to as they where before."
- (setq debbugs-test--soap-operation-name nil)
- (setq debbugs-test--soap-parameters nil)
-
- (remove-function
- (symbol-function #'soap-invoke-internal)
- #'debbugs-test--soap-invoke-internal)
-
- (remove-function
- (symbol-function #'debbugs-get-cache)
- #'debbugs-test--override-float-time)
-
- (remove-function
- (symbol-function #'debbugs-put-cache)
- #'debbugs-test--override-float-time))
-
-(defmacro ert-deftest--debbugs (name args docstring &rest body)
- "The same as `ert-deftest' but runs setup and teardown functions."
- (declare
- (doc-string 3)
- (indent 2))
- `(ert-deftest ,name ,args ,docstring
- (debbugs-test--setup)
- ,@body
- (debbugs-test--teardown)))
+(require 'debbugs-test-helpers)
;;; Tests:
--
2.48.1
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=v3-0002-tests-Use-unwind-protect-to-ensure-test-cleanup-a.patch
From 9319fd0c4737eb433383b271845c2627edf918dc Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Fri, 21 Feb 2025 12:47:28 -0500
Subject: [PATCH v3 2/5] tests: Use 'unwind-protect' to ensure test cleanup
always occurs
* test/debbugs-test-helpers.el(ert-deftest--debbugs): Use 'unwind-protect'.
---
test/debbugs-test-helpers.el | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/test/debbugs-test-helpers.el b/test/debbugs-test-helpers.el
index f98bab40ed..7ea6f00dce 100644
--- a/test/debbugs-test-helpers.el
+++ b/test/debbugs-test-helpers.el
@@ -136,9 +136,11 @@ These mock functions are needed to make the tests reproducible."
(doc-string 3)
(indent 2))
`(ert-deftest ,name ,args ,docstring
- (debbugs-test--setup)
- ,@body
- (debbugs-test--teardown)))
+ (unwind-protect
+ (progn
+ (debbugs-test--setup)
+ ,@body)
+ (debbugs-test--teardown))))
(provide 'debbugs-test-helpers)
--
2.48.1
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=v3-0003-tests-Add-tests-for-debbugs-gnu.patch
From bfac115a81decf5b711e79cd65f999a96150f4df Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Fri, 21 Feb 2025 12:52:24 -0500
Subject: [PATCH v3 3/5] tests: Add tests for debbugs-gnu
* test/debbugs-gnu-tests.el: New file.
---
test/debbugs-gnu-tests.el | 46 +++++++++++++++++++++++++++++++++++++++
1 file changed, 46 insertions(+)
create mode 100644 test/debbugs-gnu-tests.el
diff --git a/test/debbugs-gnu-tests.el b/test/debbugs-gnu-tests.el
new file mode 100644
index 0000000000..6c803aefc3
--- /dev/null
+++ b/test/debbugs-gnu-tests.el
@@ -0,0 +1,46 @@
+;;; debbugs-gnu-tests.el --- tests for debbugs-gnu.el -*- lexical-binding: t; -*-
+
+;; Copyright (C) 2025 Free Software Foundation, Inc.
+
+;; Author: Morgan Smith <Morgan.J.Smith@HIDDEN>
+;; Package: debbugs
+
+;; This file is not part of GNU Emacs.
+
+;; This program is free software: you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; This program is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;; Please ensure tests don't actually make network calls.
+
+;;; Code:
+
+(require 'debbugs-gnu)
+(require 'debbugs-test-helpers)
+
+;;; Tests:
+
+(ert-deftest--debbugs debbugs-test-debbugs-gnu-search ()
+ "Test `debbugs-gnu-search'."
+ (cl-letf (((symbol-function #'debbugs-gnu)
+ #'list))
+ (should
+ (equal '(nil ("guix" "guix-patches") nil)
+ (debbugs-gnu-search "frogs" '((pending . "pending")) nil '("guix" "guix-patches") nil)))
+ (should (equal debbugs-gnu-current-query '((phrase . "frogs"))))
+ (should (equal debbugs-gnu-current-filter '((pending . "pending"))))))
+
+(provide 'debbugs-gnu-tests)
+
+;;; debbugs-gnu-tests.el ends here
--
2.48.1
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=v3-0004-Makefile-Add-target-to-run-checkdoc-on-all-files.patch
From 89a74c43388187fb342cf41730494e2364b444b5 Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Fri, 21 Feb 2025 12:52:35 -0500
Subject: [PATCH v3 4/5] Makefile: Add target to run checkdoc on all files
* Makefile: Add target to run checkdoc on all files.
* resources/debbugs-checkdoc-config.el: New file.
---
Makefile | 5 ++-
resources/debbugs-checkdoc-config.el | 50 ++++++++++++++++++++++++++++
2 files changed, 54 insertions(+), 1 deletion(-)
create mode 100644 resources/debbugs-checkdoc-config.el
diff --git a/Makefile b/Makefile
index 81d7b5d2f2..da0764ea36 100644
--- a/Makefile
+++ b/Makefile
@@ -11,7 +11,7 @@ TESTTARGET=$(patsubst %.el,%.elc,$(TESTSOURCE))
INFOMANUALS=debbugs.info debbugs-ug.info
-.PHONY: all build check clean
+.PHONY: all build check clean checkdoc
.PRECIOUS: %.elc
%.elc: %.el
@@ -29,6 +29,9 @@ doc: $(INFOMANUALS)
build: $(TARGET)
+checkdoc: $(SOURCE) $(TESTSOURCE)
+ @$(EMACS) -Q --batch -l resources/debbugs-checkdoc-config.el $(foreach file,$^,"--eval=(checkdoc-file \"$(file)\")")
+
check: build $(TESTTARGET)
@$(EMACS) -Q --batch -L . -L ./test $(foreach file,$(TESTSOURCE), -l $(file)) --eval '(ert-run-tests-batch-and-exit "$(TESTS)")'
diff --git a/resources/debbugs-checkdoc-config.el b/resources/debbugs-checkdoc-config.el
new file mode 100644
index 0000000000..d09b1adfe5
--- /dev/null
+++ b/resources/debbugs-checkdoc-config.el
@@ -0,0 +1,50 @@
+;;; debbugs-checkdoc-config.el --- Configuration for running checkdoc on debbugs -*- lexical-binding: t; -*-
+
+;; Copyright (C) 2025 Free Software Foundation, Inc.
+
+;; Author: Morgan Smith <Morgan.J.Smith@HIDDEN>
+;; Package: debbugs
+
+;; This file is not part of GNU Emacs.
+
+;; This program is free software: you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; This program is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;;; Code:
+
+(defvar checkdoc-package-keywords-flag)
+(defvar checkdoc-spellcheck-documentation-flag)
+(defvar checkdoc-ispell-lisp-words)
+
+(with-eval-after-load "checkdoc"
+ (setq checkdoc-package-keywords-flag t)
+ (setq checkdoc-spellcheck-documentation-flag t)
+ (setq checkdoc-ispell-lisp-words
+ '("ChangeLog" "ChangeLogs" "UTF" "alist" "args"
+ "armstrong" "backend" "bcc" "bugreport" "cdate" "cedet"
+ "coreutils" "cygwin" "debbugs" "debian" "el" "emacs"
+ "etags" "freemail" "fsf" "guix" "gw" "henoch" "hu"
+ "hyperestraier" "keymap" "magit" "magnus" "maint"
+ "maintainer" "maintainer's" "mbox" "mboxes" "minibuffer"
+ "moreinfo" "multibyte" "notabug" "paren" "persistency"
+ "regexp" "rescan" "rgm" "rmail" "severities" "sexp"
+ "solaris" "src" "sublist" "submitter" "submitter's"
+ "subproduct" "subqueries" "subquery" "teardown"
+ "unarchived" "unibyte" "unreproducible" "url" "util"
+ "wishlist" "wontfix" "wsdl" "www" "xsd" "zltuz")))
+
+(provide 'debbugs-checkdoc-config)
+
+;;; debbugs-checkdoc-config.el ends here
--
2.48.1
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=v3-0005-Sort-return-value-of-debbugs-get-status.patch
From 82a242ad878aee8371229a2c54ff961db03cc93f Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Fri, 21 Feb 2025 12:49:04 -0500
Subject: [PATCH v3 5/5] Sort return value of `debbugs-get-status'
* debbugs.el(debbugs-get-status): Sort return value to ensure a stable return
value.
* test/debbugs-test-helpers.el(debbugs-test--bug-status): Sort.
* test/debbugs-tests.el(debbugs-test-get-status): Remove unnecessary sorting.
---
debbugs.el | 4 +++-
test/debbugs-test-helpers.el | 19 ++++++++++---------
test/debbugs-tests.el | 8 ++++----
3 files changed, 17 insertions(+), 14 deletions(-)
diff --git a/debbugs.el b/debbugs.el
index 71c3cba233..288a057b52 100644
--- a/debbugs.el
+++ b/debbugs.el
@@ -590,7 +590,9 @@ Example:
;; Cache the result, and return.
(debbugs-put-cache
(alist-get 'key x)
- (alist-get 'value x))))
+ (sort (alist-get 'value x)
+ (lambda (x y)
+ (string< (car x) (car y)))))))
debbugs-soap-invoke-async-object))))
(defun debbugs-get-usertag (&rest query)
diff --git a/test/debbugs-test-helpers.el b/test/debbugs-test-helpers.el
index 7ea6f00dce..14bd261c9f 100644
--- a/test/debbugs-test-helpers.el
+++ b/test/debbugs-test-helpers.el
@@ -55,17 +55,18 @@
;; Generated using this:
;; (debbugs-get-status 64064)
(defconst debbugs-test--bug-status
- '(((cache_time . 5000) (source . "unknown") (unarchived)
- (keywords "patch") (blocks) (pending . "done") (severity . "normal")
- (done . "Michael Albinus <michael.albinus@HIDDEN>") (location . "archive")
- (log_modified . 1689593050) (subject . "[PATCH 0/4] debbugs improvements")
- (last_modified . 1689593050) (found) (tags "patch") (package "emacs")
- (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>") (archived . t)
- (blockedby) (affects) (mergedwith) (summary) (date . 1686745022)
- (fixed_versions) (id . 64064) (fixed) (found_date) (forwarded)
+ '(((cache_time . 5000) (affects) (archived . t) (blockedby) (blocks)
+ (bug_num . 64064) (date . 1686745022)
+ (done . "Michael Albinus <michael.albinus@HIDDEN>") (fixed) (fixed_date)
+ (fixed_versions) (forwarded) (found) (found_date) (found_versions)
+ (id . 64064) (keywords "patch") (last_modified . 1689593050)
+ (location . "archive") (log_modified . 1689593050) (mergedwith)
(msgid
. "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>")
- (owner) (found_versions) (fixed_date) (bug_num . 64064)))
+ (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>") (owner)
+ (package "emacs") (pending . "done") (severity . "normal")
+ (source . "unknown") (subject . "[PATCH 0/4] debbugs improvements") (summary)
+ (tags "patch") (unarchived)))
"Mock result from `debbugs-get-status' for bug 64064.")
;;; Helper Functions:
diff --git a/test/debbugs-tests.el b/test/debbugs-tests.el
index da1b9dffe6..16c8c6629a 100644
--- a/test/debbugs-tests.el
+++ b/test/debbugs-tests.el
@@ -64,15 +64,15 @@
(ert-deftest--debbugs debbugs-test-get-status ()
"Test \"get_status\"."
- (should (equal (sort (car (debbugs-get-status 64064)))
- (sort (car debbugs-test--bug-status))))
+ (should (equal (car (debbugs-get-status 64064))
+ (car debbugs-test--bug-status)))
(should (string-equal debbugs-test--soap-operation-name "get_status"))
(should (equal debbugs-test--soap-parameters '([64064])))
(setq debbugs-test--soap-operation-name nil)
(setq debbugs-test--soap-parameters nil)
;; cached
- (should (equal (sort (car (debbugs-get-status 64064)))
- (sort (car debbugs-test--bug-status))))
+ (should (equal (car (debbugs-get-status 64064))
+ (car debbugs-test--bug-status)))
(should (equal debbugs-test--soap-operation-name nil))
(should (equal debbugs-test--soap-parameters nil)))
--
2.48.1
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.
Received: (at 76446) by debbugs.gnu.org; 23 Feb 2025 19:23:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 23 14:23:36 2025
Received: from localhost ([127.0.0.1]:36196 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tmHZf-0001p8-L7
for submit <at> debbugs.gnu.org; Sun, 23 Feb 2025 14:23:36 -0500
Received: from mail-mw2nam12olkn2011.outbound.protection.outlook.com
([40.92.23.11]:53984 helo=NAM12-MW2-obe.outbound.protection.outlook.com)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <morgan.j.smith@HIDDEN>)
id 1tmHY8-0001ls-8R
for 76446 <at> debbugs.gnu.org; Sun, 23 Feb 2025 14:22:01 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=eKeunAF9JbTEsbr9PjJtQMrZYfpc12eFv3zzNrk5iyfe1ltjzXcKWFjmmGxi3WMOuoG3H5D+iNuv1MrLVbz1rZfn7rI4L6Dswqqy14Gx9lDv6gN/BTpZb8jesi/VM7LC0XY6WaKZ1PET766zW4Jy81bMG1+QSL8KiwEEiU+DSFoLmrX38hJuxOPSKkEzF0nisJz9nPFcoXZmZ0dq1x/fiPiQ30ktYxnyBHMqkrUsRXAPtnbQsJLoKl2vHYs/KUZjbvcM3V9Q25nKmvIQwXsXTbYRFb5idzBnyxVrDd8sRwlYJsoHF5qKcxeS39ZAPsYPRMqrfwn85HZMfF6/zyPM4g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=yrp0jvD5DnQchFdlzMwaN/uKb7ojAMvniTjWE7SPolY=;
b=CrEgXONACnLw8cX+282tkV1MAwBA9jazallYkGMlLgRLnGKz71bZWvUk3xjFc1TtAGFqy9glL3LD+5+wKfr7aOXfAzyKEyPFlOSzZFHJUjGpFXPGY2ApOr4YaTwvJtVFD0pomAMHmOQvma0ha0XJOKPYxoVUuUDjHgo53Cxk1V6ZyF0OOAFtcYKQYr5KUQ8Arm0y5akCSezkUCB2pHpVwFPagh3grKm2FBC352iQ/ErzjB+f7yGBcQFr+cSwkY5fxC9GWwW/ppcEy5lHU8jYv1PBXRDb1Z+aKByiC9pRPx6NFbGu+3wOqCOuixtA5M6yBbhZvZwyCEIby+Om9v42ng==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=yrp0jvD5DnQchFdlzMwaN/uKb7ojAMvniTjWE7SPolY=;
b=pUSiwvQuTNhGWX2QaT4o8RTQMtOc7RW1XhnVPT4bhRdKJZf0jGMA50IVGBY5OOJL0v7YjQvO4PLkFQnOC3Tlt+C5y6jX2VK5SViQiJK2AnpJ+9VU3BzEz1c6pLSPlpdOruaTp5Z0sIYCPInB+4jGvT7e4G7FB4mEDlmCminpFwGdrBCK+2sBad0bAqPT5vlbzJ7JxjPlmGOwloIxhbXx03qdtx72uvebKeyOCiOkA963zXAkndyN3RrascBsZVEU0A6WudcPi09rNSf2N760+6DN2JABMlyPxaBi9dEAAp2lR/g8PiSukElrIpdQOvcMjps+IUnvZUj4dqaF1yBUxQ==
Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17)
by MW4PR84MB1708.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:303:1a7::13)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.16; Sun, 23 Feb
2025 19:21:52 +0000
Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
([fe80::5c77:7a58:48ed:9aef]) by CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
([fe80::5c77:7a58:48ed:9aef%4]) with mapi id 15.20.8466.016; Sun, 23 Feb 2025
19:21:52 +0000
From: Morgan Smith <morgan.j.smith@HIDDEN>
To: Michael Albinus <michael.albinus@HIDDEN>
Subject: Re: bug#76446: [PATCH v2 5/5] tests: Support older Emacs sorting
conventions
In-Reply-To: <87cyfaufdv.fsf_-_@HIDDEN> (Michael Albinus's message of "Sat, 22
Feb 2025 17:13:16 +0100")
References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN>
<87bjuvy17p.fsf@HIDDEN>
<CH3PR84MB3424807016C1C6E6EBCD08E6C5C72@HIDDEN>
<87cyfaufdv.fsf_-_@HIDDEN>
X-Hashcash: 1:20:250223:76446 <at> debbugs.gnu.org::GJ4lovkCCGhpZB2z:1jid
X-Hashcash: 1:20:250223:michael.albinus@HIDDEN::yIxAHqmvYjirNE9I:5y9h
Date: Sun, 23 Feb 2025 14:21:49 -0500
Message-ID: <CH3PR84MB3424303190E3F485C596500CC5C12@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
Content-Type: multipart/mixed; boundary="=-=-="
X-ClientProxiedBy: YTBP288CA0009.CANP288.PROD.OUTLOOK.COM
(2603:10b6:b01:14::22) To CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
(2603:10b6:610:1c4::17)
X-Microsoft-Original-Message-ID: <87v7t079gy.fsf@HIDDEN>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CH3PR84MB3424:EE_|MW4PR84MB1708:EE_
X-MS-Office365-Filtering-Correlation-Id: 33c9b1e4-4b37-40a0-a1f4-08dd543f53f6
X-Microsoft-Antispam: BCL:0;
ARA:14566002|19110799003|5072599009|8060799006|461199028|7092599003|15080799006|6092099012|13095399003|440099028|3412199025|41001999003;
X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?WbEoZdzrz26j68LAGyIhRHfPZKmMgeI3BPp9scqCWqffrDvlGmxyTtpRoPDm?=
=?us-ascii?Q?nz68XMCAsMAHPkeubjBeiONKjwXhiOb1RmyQ0p5LunmCvNQoHpGGyCNYYc1C?=
=?us-ascii?Q?ENrfaxgS1Vee13H3U5y1dk+wVoj20aEOmpXKpPoTrucf8zEbkU+0AvLbEN38?=
=?us-ascii?Q?+u1keevQmDCCvi0tmeTpByQ+MJhNlKX3J4J/sakjeC/yH0Of91FUc+Z+QKU4?=
=?us-ascii?Q?t1ZltqdJYFZuzSMbNbkBQ+e6M1lTTRRCRDMflONDruYPEO7KELvkai78a9i5?=
=?us-ascii?Q?MoqAazvOKhRrkF4X26f9m5kX5p+K/uPkXJtzGgtg5WxN4KLkqhJUC5XTqKOz?=
=?us-ascii?Q?i86IlwAXDwEmy61k5BnKoJICKKY+RUDdwekJhSlNU2XxsaPjEG/CP9IXhS+p?=
=?us-ascii?Q?5lGT1MyREq3Yn6phK8ZhLVnvxSgErDu0U7Opa9kqGo4hA0lGPFPYAabrVvGW?=
=?us-ascii?Q?ngcSe+/B8tqJerhnTDyrc/FwuZ1ggVUsdV4G+6ecvuu2ifOYDBFA25XlHUuN?=
=?us-ascii?Q?CLeeNXb9XDZ08HQdCb02GCqWV7P8rMkDN8BYMUnFrLUihrmslaDu4bxll4Rn?=
=?us-ascii?Q?YbJVcA9TcC+Fut2UEbfF+YO8tPPVBNyG8wPig5OKHpJdQlAb7oh3Mbgtp4pD?=
=?us-ascii?Q?njUPgaStZIJOKSv1utbGorNZcBhs6vUoV+XXrxnS5Gc3om0o4CP8L23sjfYd?=
=?us-ascii?Q?r63GtIsWi6BunOfdE5LwKnMS9f2M3DuFDM70O08K7rrqwEbRWHgTsz4KxmU1?=
=?us-ascii?Q?blwnM+eJAHBRjpDeThg/Va3ZP2SPuMm2h09alfWNMK3m0ubdyCNAw+kCoTFa?=
=?us-ascii?Q?zcL6USsD+FV1J6dnX+wF3jYyKZDjkSAb1b1KjcY4Vpr4PSPtoa8cdD+RpaK4?=
=?us-ascii?Q?isbi866Kaq1oq1nc5So3oJOFIdVCIm4b2oLhl1WIAGvVbPHEPHJGVecCrlhc?=
=?us-ascii?Q?Jl6XDpvZ0chnSeOYj9mXUnWcHLSlFsonuuntB6S8+PfQ+ebdC/S94FLHLjEm?=
=?us-ascii?Q?XbPObCGoz8ouAUJy7LA+BB2hgyYSarbIHlRzcQGmlBpYq359ykOrHTPhOvvb?=
=?us-ascii?Q?avwPqHFJtSRRf6LHPvBGa6TWSy6a/x2wnT9ptJmg8/gfntFJU/7IEPG++yDQ?=
=?us-ascii?Q?sL9t08zFd1n80DoS3uF921edqB80uR8JirIjXHQO4w7DeRxXkY8+Y54=3D?=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ifct5tTfPq9fbYVD7Ioqua2/4G0mlbw2yTGcMlHAF+qKxCLUNWC/430WAFBh?=
=?us-ascii?Q?V/DqqzHyrgIB6JYsoBqAWwSUBCNGYrFuygjUyzaaSe3nYlRCEPrh+hKbum70?=
=?us-ascii?Q?6SVyG0GFQrQUD5mqPFMA164gv7pBNnj485LEdul1WC4A0b8gZxT1x5v7xX3b?=
=?us-ascii?Q?yYLPICQt4F8nMW9N01zXyWGBuJbjr397hcBCYE2e+a0UfwVqPBSpjMWYDG6X?=
=?us-ascii?Q?QufjGX24nWrDSHdXEC/yMcA8kpkrrxER2hxsfNdhdyXcgbCQnJ0ubtF/uCe3?=
=?us-ascii?Q?FoHmtIsOMoKwiKal5DWT58reRSy4xNmwnDjZbfTe393KUr13Q3FTxLv1ydtR?=
=?us-ascii?Q?kTST1SHNB2nk6hL/4FAiDYPNhmESI+qx7SBvfnEdJBJ91mG4i86VcvRbncjU?=
=?us-ascii?Q?9iJh8acmRjXeMJml+H28kmM6JVR8SgKFV4C5zpwYGjNckdxs2Z08lLOa2ZST?=
=?us-ascii?Q?20T/alIY6M7+s9fTckyIL5L9nTAelp+8we8XyfrwMILUzGB67u2o6Dfcgwh3?=
=?us-ascii?Q?kU9QzxtcfWqhhPY8jtRJRsc26kanSWdJa0IF6Ium1HnTWERLqTtfifyQ8orj?=
=?us-ascii?Q?j0yRqvQ133AhtjcXLYpiaxEvpFazBbmjhrvBSnN8Kj99wUtM8cEEraVLrLRF?=
=?us-ascii?Q?mD+Apw7a0vH6LTFDzWlES/sLsprPbygg1H7M956AP/oV1gWMzJiHJro+51f7?=
=?us-ascii?Q?24A9d3/jn0lQhaQNQkBosYhit7RBVeQp7cIU/Z1c0Yvu/Qc/3h10hquAaZCZ?=
=?us-ascii?Q?h0hZph5KX22ugyNtxV4YdIh8DfxTOeq+8NL2xtT/3591eJFeN244HIqZrlK6?=
=?us-ascii?Q?DHcZTXoOYfGIXkAgx+4TklTjTyd+VsnbIfotlSsqRSyXnBXxO1F8hWwmoVjL?=
=?us-ascii?Q?tU/4lv7VYwk+67HaVpL7g1uQfdiSttdWDbCgOqqIMQKBIcum9zPNPtSRqYW6?=
=?us-ascii?Q?23FzxkWvLtLobejawMwlVpUtoSQdJiCjnh54ya7UJa+WLe/lF5lfoFvGPH9/?=
=?us-ascii?Q?ATzodzGj2vxmZ5TJMzR2b30raHbMH5H8M7umP+jirrH0cOWIp26n+k+msAZx?=
=?us-ascii?Q?Q7SP/nE0E1isJVGRu3agIm9TUGl+IEnIyV1o+/rpd8pfjGXmmzuzC/G5vJLN?=
=?us-ascii?Q?qjVNcCarzaoTFkH3xJyB5Udq3pCEjqBs/Ckt48s6HNBleX0ORVt/9y/vWEvp?=
=?us-ascii?Q?3pFBPyfZZFWGloGdey92MOyUu6zAhOV2WGyf/0lEPmAvOVRx6hAmXVspMMmM?=
=?us-ascii?Q?zzont34BvToAzxxIcs8n?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 33c9b1e4-4b37-40a0-a1f4-08dd543f53f6
X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2025 19:21:52.7570 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR84MB1708
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 76446
Cc: 76446 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain
Michael Albinus <michael.albinus@HIDDEN> writes:
> Morgan Smith <morgan.j.smith@HIDDEN> writes:
>
>> --- a/test/debbugs-tests.el
>> +++ b/test/debbugs-tests.el
>> + (eval-and-compile
>> + (defun alist-sort (x y)
>> + (string< (car x) (car y))))
>
> I would define this function in debbugs-test-helpers.el. And perhaps
> give it a debbugs-test- prefix; we don't want to pollute the Emacs name
> space.
Ah, my bad. I wrongly assumed Emacs had lexical scoping.
I've attached an alternative solution. It would help stabilize the
return value of `debbugs-get-status'. But also users should not be
relying on `debbugs-get-status' to have a stable return so maybe this is
a bad idea.
> Best regards, Michael.
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=v3-0005-Sort-return-value-of-debbugs-get-status.patch
From 82a242ad878aee8371229a2c54ff961db03cc93f Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Fri, 21 Feb 2025 12:49:04 -0500
Subject: [PATCH v3 5/5] Sort return value of `debbugs-get-status'
* debbugs.el(debbugs-get-status): Sort return value to ensure a stable return
value.
* test/debbugs-test-helpers.el(debbugs-test--bug-status): Sort.
* test/debbugs-tests.el(debbugs-test-get-status): Remove unnecessary sorting.
---
debbugs.el | 4 +++-
test/debbugs-test-helpers.el | 19 ++++++++++---------
test/debbugs-tests.el | 8 ++++----
3 files changed, 17 insertions(+), 14 deletions(-)
diff --git a/debbugs.el b/debbugs.el
index 71c3cba233..288a057b52 100644
--- a/debbugs.el
+++ b/debbugs.el
@@ -590,7 +590,9 @@ Example:
;; Cache the result, and return.
(debbugs-put-cache
(alist-get 'key x)
- (alist-get 'value x))))
+ (sort (alist-get 'value x)
+ (lambda (x y)
+ (string< (car x) (car y)))))))
debbugs-soap-invoke-async-object))))
(defun debbugs-get-usertag (&rest query)
diff --git a/test/debbugs-test-helpers.el b/test/debbugs-test-helpers.el
index 7ea6f00dce..14bd261c9f 100644
--- a/test/debbugs-test-helpers.el
+++ b/test/debbugs-test-helpers.el
@@ -55,17 +55,18 @@
;; Generated using this:
;; (debbugs-get-status 64064)
(defconst debbugs-test--bug-status
- '(((cache_time . 5000) (source . "unknown") (unarchived)
- (keywords "patch") (blocks) (pending . "done") (severity . "normal")
- (done . "Michael Albinus <michael.albinus@HIDDEN>") (location . "archive")
- (log_modified . 1689593050) (subject . "[PATCH 0/4] debbugs improvements")
- (last_modified . 1689593050) (found) (tags "patch") (package "emacs")
- (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>") (archived . t)
- (blockedby) (affects) (mergedwith) (summary) (date . 1686745022)
- (fixed_versions) (id . 64064) (fixed) (found_date) (forwarded)
+ '(((cache_time . 5000) (affects) (archived . t) (blockedby) (blocks)
+ (bug_num . 64064) (date . 1686745022)
+ (done . "Michael Albinus <michael.albinus@HIDDEN>") (fixed) (fixed_date)
+ (fixed_versions) (forwarded) (found) (found_date) (found_versions)
+ (id . 64064) (keywords "patch") (last_modified . 1689593050)
+ (location . "archive") (log_modified . 1689593050) (mergedwith)
(msgid
. "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>")
- (owner) (found_versions) (fixed_date) (bug_num . 64064)))
+ (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>") (owner)
+ (package "emacs") (pending . "done") (severity . "normal")
+ (source . "unknown") (subject . "[PATCH 0/4] debbugs improvements") (summary)
+ (tags "patch") (unarchived)))
"Mock result from `debbugs-get-status' for bug 64064.")
;;; Helper Functions:
diff --git a/test/debbugs-tests.el b/test/debbugs-tests.el
index da1b9dffe6..16c8c6629a 100644
--- a/test/debbugs-tests.el
+++ b/test/debbugs-tests.el
@@ -64,15 +64,15 @@
(ert-deftest--debbugs debbugs-test-get-status ()
"Test \"get_status\"."
- (should (equal (sort (car (debbugs-get-status 64064)))
- (sort (car debbugs-test--bug-status))))
+ (should (equal (car (debbugs-get-status 64064))
+ (car debbugs-test--bug-status)))
(should (string-equal debbugs-test--soap-operation-name "get_status"))
(should (equal debbugs-test--soap-parameters '([64064])))
(setq debbugs-test--soap-operation-name nil)
(setq debbugs-test--soap-parameters nil)
;; cached
- (should (equal (sort (car (debbugs-get-status 64064)))
- (sort (car debbugs-test--bug-status))))
+ (should (equal (car (debbugs-get-status 64064))
+ (car debbugs-test--bug-status)))
(should (equal debbugs-test--soap-operation-name nil))
(should (equal debbugs-test--soap-parameters nil)))
--
2.48.1
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.
Received: (at 76446) by debbugs.gnu.org; 23 Feb 2025 19:17:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 23 14:17:50 2025
Received: from localhost ([127.0.0.1]:36167 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tmHU5-0001Xd-Lf
for submit <at> debbugs.gnu.org; Sun, 23 Feb 2025 14:17:50 -0500
Received: from mail-mw2nam12olkn2081.outbound.protection.outlook.com
([40.92.23.81]:48128 helo=NAM12-MW2-obe.outbound.protection.outlook.com)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <morgan.j.smith@HIDDEN>)
id 1tmHU2-0001XL-3a
for 76446 <at> debbugs.gnu.org; Sun, 23 Feb 2025 14:17:47 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=Oc39PuwsM8avu9s/Hc6IC7KrE7+O+LO2yxQfBR0NDUclAt+wFRApLuCqyzmc3KZpIgQ761HwPUgmWZgt7XycAgwPjbfg0+iCOyZxPK+xfQwiJDV6I1o1WkKqL/jwVdbXpvCPS6JG1A+NmXxgBtpaS45Qq0cjhQHTQPTQozegCNLY7ts4OVQiUEMr5haexJ7s1BaPl390JRTSKu/TCfKapsdQis2kg0z7PBFoE9b10aXtTEli7afNoy8b7shf2UW/JvN/euR7qSKB3jGJwpUkNjSYKl9Lb/U9HP2QBwKqRKGvle/JXOxe3TK3CygN5ee9J7HxkY966ShUY7bkpDjo1A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=9hei96VfLCRpxccltsR0gvUN7Ntw48BlmrZeMtS8Sj0=;
b=WOyzSTSTSzUW7aJJ14lwHF4jG8nZnJdZiOlMASgEcruPiPd1fvsyNYcYY3icVuSatiUuLB89SYVk4Kr1dZxLd2eNuzNN/3hiDyjKw7myKp7PjOYVZojqGagttT+5UipE7CMxBfekpzfyyAfFMHAiuVxcQf6xLMX0KeT6HcM0vPv72KQa+fO5JiP3wLIJsSpX6QhdFCzXUSYBU7nG1+QhLtprLc2rCSSYdnxuLemAEsd/vh6VEy1X2mCtWR91yjYxRJm5VoadiH0/ZO0Zf1gXl93KoLpRfCiKgE/o833AaHSwKfM4J456heWYZOA4cIBl/hpiKbA58SyHjagzqkVBxQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=9hei96VfLCRpxccltsR0gvUN7Ntw48BlmrZeMtS8Sj0=;
b=lLlkJv/KEPuyzn3cSP69IF1d3XPEd1ZnfhbzeE/vvR6r2XgSY2PWvEbKhO3Oh5PrYRD7vjYPypdXI/Yl7Kg4Y23dhlO5X3Mj0V3FkkaiNYIZC+zXGOmTzIsIH9VcLm+7r6pPUOZFX/eWiFIOPkohbfNNeXPZ8pqKxn5PQfih7pqBNQ+0+jWRUu1DYLtsRApbjwGlqTZsGpybdoDnklfyiSmpGoYSNvGld8MXcC6+pTaXZIRZjj3BqzI8NkjThdjmv/SgmLm4gP8wTAfcKm+ZvkM1TaHyJBvy169X5mbjGmtAIITBNhVMnCmdGlQnwXi3zvGtBTS/8n7MCIrouhrS7Q==
Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17)
by MW4PR84MB1708.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:303:1a7::13)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.16; Sun, 23 Feb
2025 19:17:38 +0000
Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
([fe80::5c77:7a58:48ed:9aef]) by CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
([fe80::5c77:7a58:48ed:9aef%4]) with mapi id 15.20.8466.016; Sun, 23 Feb 2025
19:17:37 +0000
From: Morgan Smith <morgan.j.smith@HIDDEN>
To: Michael Albinus <michael.albinus@HIDDEN>
Subject: Re: bug#76446: [PATCH v2 4/5] Makefile: Add target to run checkdoc
on all files
In-Reply-To: <87h64mufrj.fsf_-_@HIDDEN> (Michael Albinus's message of "Sat, 22
Feb 2025 17:05:04 +0100")
References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN>
<87v7t3wlo3.fsf@HIDDEN>
<CH3PR84MB3424EB975A4BE9FE7185E74EC5C72@HIDDEN>
<87h64mufrj.fsf_-_@HIDDEN>
X-Hashcash: 1:20:250223:76446 <at> debbugs.gnu.org::5WDxPKpPqP2bB8bm:2qYi
X-Hashcash: 1:20:250223:michael.albinus@HIDDEN::1mkUj2jNDmoyX7+U:7IzT
Date: Sun, 23 Feb 2025 14:17:34 -0500
Message-ID: <CH3PR84MB3424D9265F13197B3276AFB5C5C12@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
Content-Type: multipart/mixed; boundary="=-=-="
X-ClientProxiedBy: YT2PR01CA0002.CANPRD01.PROD.OUTLOOK.COM
(2603:10b6:b01:38::7) To CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
(2603:10b6:610:1c4::17)
X-Microsoft-Original-Message-ID: <87zfic79o1.fsf@HIDDEN>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CH3PR84MB3424:EE_|MW4PR84MB1708:EE_
X-MS-Office365-Filtering-Correlation-Id: 5b920094-3d8b-4dfa-b056-08dd543ebbe6
X-Microsoft-Antispam: BCL:0;
ARA:14566002|19110799003|5072599009|8060799006|461199028|7092599003|15080799006|6092099012|13095399003|440099028|3412199025;
X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?X3QgNrLpu52jRD/5v8cRX6oMufTUgILGDsunRvAo1Q64kAAWwtYJLbILP4xE?=
=?us-ascii?Q?4KJMIPeRKbiYhY7/ZFpn+UbFxw+YVe9Sr9Uu/JIX4ksjnFP55mflolt3N78G?=
=?us-ascii?Q?ZJ6igQA80vi2lLwxHCAWEMljjuG/mr7Nja5J3U9vZ13t8z2+VRpU0bVr5+VI?=
=?us-ascii?Q?skxUCXu12Q1qMmzei0Ym0BaEEywkk9m048DGV3MtfTRglp4wnLQ7P7X7FtnW?=
=?us-ascii?Q?PVKi1hnFMPv2ffN/7Y1jvgQ5rZpPQ00CFys3xxIsXG32F9GoFj2wVv2z5xAB?=
=?us-ascii?Q?+da3VFNgoqqDDj26ewD0FrSPcCbPLk95hFNxIVKRNKiI/7rFWfH8aSZrnymf?=
=?us-ascii?Q?CAgB+ELH1mw9teM9o9pkIOYCz3lYwZo9HMJcjf0Kt2Pqaj/drnDyxgr+X7W6?=
=?us-ascii?Q?mp3+nxBChurT2V/ei4lpu68FTaL+Qk3BbfwHXxKZukELsi28W66CxXAYKoQd?=
=?us-ascii?Q?ONkStqjlXyFUNb3r+ImRPoY0buWw+VX2wZEktU93rQW55s3/tZvovLtFDofY?=
=?us-ascii?Q?sxlCLyTOlaic+eJsRVHRgkldZwsCabiW4cvxiKO1j62s/z/FM0J3LEyxoS39?=
=?us-ascii?Q?XxUrB4WvPa7L58Z3//ahCWvOSjmxcg3qoaOHH5NfJIW8DyZuE4hfQD8GWS6t?=
=?us-ascii?Q?k3KAPxa/F3Mm3qlXAIWdXocEuZIx/1TPLMt0+//pbbTltRNjDnwx3xJKpl6+?=
=?us-ascii?Q?hWrjBNuLOHKckpsVRJ4Fhok4KA/slQmNxc+MkynNHuvfa+Iksn7KWTMVZyrK?=
=?us-ascii?Q?DBx4a1rAa3RjEEq1b8OLB3hn3IcReGwEv/W66lDM667z2vFHDioDSGA7f9g4?=
=?us-ascii?Q?SiWKMB/z8PGljpmzOLSK2SalYn3eHZXwc/jtMEpxQVmJEdG2Bvb3g/rQrZJJ?=
=?us-ascii?Q?PQFL6p4alA9PPEJFE/BIvg3c0J3RoE930B51rIGPD3NlFFwGQ8WmjitCMgU9?=
=?us-ascii?Q?LBak6XBk8v53XHYIvQ9e9qItFTnpSCsRikh0vqoorMGRl5APiw2ZTtQEugCM?=
=?us-ascii?Q?s4SLDxzWNiP/5LkXEpGHvDrBOjj2r/xBMSM9UjDX5TWz7W5npRuHIxCO9PVs?=
=?us-ascii?Q?K3DIIU4uDCGqF5DhYM0iJbp/LZrp/hGgfpEA/c95+zbJC8mJWykk+EJSuAN9?=
=?us-ascii?Q?uzfs8qO0/HGxWSz+SXz3DfsDbgLp1VAfjQ=3D=3D?=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WBfihFerHOwUWxKV3RGQkXIq2dSYOqpZASSFnIg8kT7noIjtV3ve3+BQ9rpf?=
=?us-ascii?Q?Qwp7bgMcRhozoZMBNIrLyaJi+EQWrzvEN6UMGWpq/LJ7f9jRCzvnyjsh+tll?=
=?us-ascii?Q?QRzrVGpXHZtiRlhuqfXPhVExBPUxEfdqLO9xNXHUTdiI94/L4Zt1J7iX8aou?=
=?us-ascii?Q?teucUhR8g2O8fNtk9MzvNOG2Xk0Rn8SxFqg1nO3clNx5sveoWI7TyL1aBn8+?=
=?us-ascii?Q?7NCiRlITbda3Fl+nOV5HAqjv5EndSHEf68bo6W0DzIO7v+eBeyou/sTqNBSD?=
=?us-ascii?Q?B65ZqlfRmKvPKt6NOshaVMDi6AVWmc6IljooQrO1h7GNZUEwB50ExySwoKU+?=
=?us-ascii?Q?oD3lpFqjIW9LOyPVDkWFvBbLJsP+pUR5pAJO1EfvCB07gpXurVx2ZxL/ZFq1?=
=?us-ascii?Q?yyrLfTRloHTZORhMI4oMQ604wmJXrVQRTt5xsYBQ59oc/+uYDBUhMRxZ053N?=
=?us-ascii?Q?1cCPjWsLpPAssr0+oHaXCCf+5KFgwV7ZSDMUmB5j0J00eZsdoQm8wfzrS6ma?=
=?us-ascii?Q?uhzJZuwWs3CM9h4Hmwu1sWTW0BKQH8qw3slgS5vvPH/Q+BT3P0CB1M32/rD9?=
=?us-ascii?Q?rYCV1izmLks6s1yMuYH7ebynMRc5JCzDzhgyq27p/vu1/Mz7UtanVNmjjrnt?=
=?us-ascii?Q?OrfXtna6da76mfMJaes5kBesGV91Td+6vECKTwRbZrfARbwjRRVJ2eXGp1zS?=
=?us-ascii?Q?6tE6B9aHS10moAZVUKOffN5tlBl6dRf9JwCurWv02CwGoeXaoHvYKDZVev4S?=
=?us-ascii?Q?JvJhKD0ofMt4IN7HoWaTw7SIIbpes2fWiroIwZoeMHvJ2ZAakHbaQlN3yxTE?=
=?us-ascii?Q?vAlAo9SpFv6DrFsWLX/3/AmsZ2roksDlJhbLec8gFov3HyBDPiW1R9jTMYzV?=
=?us-ascii?Q?ygpBJnb7zjB2YQFbY6XJibWlCPt+TLv3OI3Qm+PiDYfhpEs8I6eah1qEls/v?=
=?us-ascii?Q?6qnNoDrLdUq7VIlk9UbfirjGfZKtdm1rgQV9/4wYbFQ42kN7KO+RY5XyHQzl?=
=?us-ascii?Q?912QcUT0n8JWiyirdsiJEJea/JsLK4bwvSDYqoYAFihlJWgOAHBT9nhQAV/D?=
=?us-ascii?Q?3ZNxzEgLjq1ktbb52sm/XnG9MQDOzC6raXASbZpztiyDckNQrbr+9vzpVe+x?=
=?us-ascii?Q?JNgWazt67QFlgD7SBpy+FYOeimYLfkteLdEYmegc01Ms8JzFDlHgBRdgqXDY?=
=?us-ascii?Q?+571Ern+KtY5vRc+PQTBToTj9vn1ETGFAntF+ORik1iE9JrW/zam+AZRk91z?=
=?us-ascii?Q?OVV22u0qcenP6gcUFicq?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b920094-3d8b-4dfa-b056-08dd543ebbe6
X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2025 19:17:37.6689 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR84MB1708
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 76446
Cc: 76446 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain
Michael Albinus <michael.albinus@HIDDEN> writes:
> Morgan Smith <morgan.j.smith@HIDDEN> writes:
>
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -8,7 +8,7 @@ TESTTARGET=$(patsubst %.el,%.elc,$(TESTSOURCE))
>>
>> INFOMANUALS=debbugs.info debbugs-ug.info
>>
>> -.PHONY: all build check clean
>> +.PHONY: all build check clean checkdoc
>> .PRECIOUS: %.elc
>>
>> %.elc: %.el
>> @@ -26,6 +26,9 @@ doc: $(INFOMANUALS)
>>
>> build: $(TARGET)
>>
>> +checkdoc: $(SOURCE) $(TESTSOURCE)
>> + @$(EMACS) -Q --batch -l test/debbugs-checkdoc-config.el $(foreach file,$^,"--eval=(checkdoc-file \"$(file)\")")
>> +
>> check: build $(TESTTARGET)
>> @$(EMACS) -Q --batch -L . -L ./test $(foreach file,$(TESTSOURCE), -l $(file)) -f ert-run-tests-batch-and-exit
>
> This would be wrong. You don't need to load debbugs-helpers.el (it is
> required in *-tests.el) and debbugs-checkdoc-config.el (it isn't related
> to ert tests.
>
I've decided to move debbugs-checkdoc-config.el into a new resources
directory so that's no longer an issue.
I understand that loading 'debbugs-test-helpers.el' isn't needed but I
don't see any harm in doing so.
>> --- /dev/null
>> +++ b/test/debbugs-checkdoc-config.el
>> + (setq checkdoc-ispell-lisp-words
>> + '("ChangeLog" "ChangeLogs" "UTF" "alist" "args"
>> + "armstrong" "backend" "bcc" "bugreport" "cdate" "cedet"
>> + "coreutils" "cygwin" "debbugs" "debian" "el" "emacs"
>> + "etags" "freemail" "fsf" "guix" "gw" "henoch" "hu"
>> + "hyperestraier" "keymap" "magit" "magnus" "maint"
>> + "maintainer" "maintainer's" "mbox" "mboxes" "minibuffer"
>> + "moreinfo" "multibyte" "notabug" "paren" "persistency"
>> + "regexp" "rescan" "rgm" "rmail" "severities" "sexp"
>> + "solaris" "src" "sublist" "submitter" "submitter's"
>> + "subproduct" "subqueries" "subquery" "teardown"
>> + "unarchived" "unibyte" "unreproducible" "url" "util"
>> + "wishlist" "wontfix" "wsdl" "www" "xsd" "zltuz")))
>
> Same comment here: couldn't it be a ressource file?
Again, why?
> And, more general: Could this file transformed into an ert test?
I mean it could be but then the build dependencies would expand to
include ispell and an appropriate dictionary.
In my opinion linting is not testing and should be optional.
> Best regards, Michael.
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=v3-0004-Makefile-Add-target-to-run-checkdoc-on-all-files.patch
From 89a74c43388187fb342cf41730494e2364b444b5 Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Fri, 21 Feb 2025 12:52:35 -0500
Subject: [PATCH v3 4/5] Makefile: Add target to run checkdoc on all files
* Makefile: Add target to run checkdoc on all files.
* resources/debbugs-checkdoc-config.el: New file.
---
Makefile | 5 ++-
resources/debbugs-checkdoc-config.el | 50 ++++++++++++++++++++++++++++
2 files changed, 54 insertions(+), 1 deletion(-)
create mode 100644 resources/debbugs-checkdoc-config.el
diff --git a/Makefile b/Makefile
index 81d7b5d2f2..da0764ea36 100644
--- a/Makefile
+++ b/Makefile
@@ -11,7 +11,7 @@ TESTTARGET=$(patsubst %.el,%.elc,$(TESTSOURCE))
INFOMANUALS=debbugs.info debbugs-ug.info
-.PHONY: all build check clean
+.PHONY: all build check clean checkdoc
.PRECIOUS: %.elc
%.elc: %.el
@@ -29,6 +29,9 @@ doc: $(INFOMANUALS)
build: $(TARGET)
+checkdoc: $(SOURCE) $(TESTSOURCE)
+ @$(EMACS) -Q --batch -l resources/debbugs-checkdoc-config.el $(foreach file,$^,"--eval=(checkdoc-file \"$(file)\")")
+
check: build $(TESTTARGET)
@$(EMACS) -Q --batch -L . -L ./test $(foreach file,$(TESTSOURCE), -l $(file)) --eval '(ert-run-tests-batch-and-exit "$(TESTS)")'
diff --git a/resources/debbugs-checkdoc-config.el b/resources/debbugs-checkdoc-config.el
new file mode 100644
index 0000000000..d09b1adfe5
--- /dev/null
+++ b/resources/debbugs-checkdoc-config.el
@@ -0,0 +1,50 @@
+;;; debbugs-checkdoc-config.el --- Configuration for running checkdoc on debbugs -*- lexical-binding: t; -*-
+
+;; Copyright (C) 2025 Free Software Foundation, Inc.
+
+;; Author: Morgan Smith <Morgan.J.Smith@HIDDEN>
+;; Package: debbugs
+
+;; This file is not part of GNU Emacs.
+
+;; This program is free software: you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; This program is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;;; Code:
+
+(defvar checkdoc-package-keywords-flag)
+(defvar checkdoc-spellcheck-documentation-flag)
+(defvar checkdoc-ispell-lisp-words)
+
+(with-eval-after-load "checkdoc"
+ (setq checkdoc-package-keywords-flag t)
+ (setq checkdoc-spellcheck-documentation-flag t)
+ (setq checkdoc-ispell-lisp-words
+ '("ChangeLog" "ChangeLogs" "UTF" "alist" "args"
+ "armstrong" "backend" "bcc" "bugreport" "cdate" "cedet"
+ "coreutils" "cygwin" "debbugs" "debian" "el" "emacs"
+ "etags" "freemail" "fsf" "guix" "gw" "henoch" "hu"
+ "hyperestraier" "keymap" "magit" "magnus" "maint"
+ "maintainer" "maintainer's" "mbox" "mboxes" "minibuffer"
+ "moreinfo" "multibyte" "notabug" "paren" "persistency"
+ "regexp" "rescan" "rgm" "rmail" "severities" "sexp"
+ "solaris" "src" "sublist" "submitter" "submitter's"
+ "subproduct" "subqueries" "subquery" "teardown"
+ "unarchived" "unibyte" "unreproducible" "url" "util"
+ "wishlist" "wontfix" "wsdl" "www" "xsd" "zltuz")))
+
+(provide 'debbugs-checkdoc-config)
+
+;;; debbugs-checkdoc-config.el ends here
--
2.48.1
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.
Received: (at 76446) by debbugs.gnu.org; 23 Feb 2025 19:08:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 23 14:08:46 2025
Received: from localhost ([127.0.0.1]:36142 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tmHLJ-00015V-Rk
for submit <at> debbugs.gnu.org; Sun, 23 Feb 2025 14:08:46 -0500
Received: from mail-bn7nam10olkn20827.outbound.protection.outlook.com
([2a01:111:f403:2804::827]:28704
helo=NAM10-BN7-obe.outbound.protection.outlook.com)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <morgan.j.smith@HIDDEN>)
id 1tmHLH-00015G-3f
for 76446 <at> debbugs.gnu.org; Sun, 23 Feb 2025 14:08:43 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=vzc/+HNtbaTFJmq5XZNJVLVTMOGf4ELxLV2tY7RH2IUiMCz28VSQqQQ6kzSjYzrlXAJ776Wr0KKqryKeAQK0OnxeDRzTzognRGFvU1S4eKSJZmjfQJeoGX2iCWV4/rYwjHEf1NE52qvd0hinOT1Aqgg4Gn1tOhR/SaFEkecGDg1Zdex3cv7SbYAIZy3m/zo4bG3uR9LCUZ6/1Is6TuNS/UR7kaxTJmjHoqs0/mFDP/AEjeoaT0sCLhJPhaeb14hMeEEOlpJYS/yRLMwM/yR1rPcBAI7lmzvw555f2UMcpiv9G6mGHO0C0loF9E6E31HYzLqjvF4R6sKl4TDvtdtQHQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=FQsMy5mcjyfwBvoMmHyl8b9gA/ON/IXAiO3HL1ljKWU=;
b=IR1wzrKaP31tpLL0FjcYI6ziPRhrzOkpKkK+tTkfJ6wohcCPix12CvMc4zq9iPvt+2RF45PfaaGySCZGhIiRRe3A+3YRVXClYL6B+ftt0M4vJjXTb+BnFR2aTPPjyOJaJexpNnchBfwb3kCDoR2WQhz0K3bER8B7a4E2CAsa52uhRCCc+Q8MXFJ0Orkn0E9N0icTQsDXMFrzJNvYcJ8qIJscQazMRW4NLs+76bx5e2hiuYPLa2gbwVRAGHhY5DXGzDo7pX1eJ1nMwAdqxPRZxnvBWm5XiYSBf3Aj6vbsQkudZqBeizO+7oCn+EZqxXCetLmGoeW2fdOWswRRD/obGg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=FQsMy5mcjyfwBvoMmHyl8b9gA/ON/IXAiO3HL1ljKWU=;
b=RBsoEj1cXr9Qv0uJVcSTKFV9Gdnjv8xHI4LDXW2WuxTBqPgHVt2/MzSapZjUG09PSu/ykPq5nV+L9Dsrlyhkgpzycz5b9vF0q+FXY4RXjMJtImkyVlLwzgugIQdaOpl6CQkedGmlU7Y5qWhmUe9UZ2nt2284o4qNkuEbAgp4xTXdmSPDLgw6UZLlra+u0KVoGJN95oS6RvaLAs3t8cme92DJsue7+svVJxnR982mujlPowMxbk/PC29g1kNMuappsC1fsq991sNuzO1bM3nXJByZeqjlh6J9xpm+qshlkUPgic9xcWcJYE2RcUNkPG2NybcOun7QbQ42BvCS/ZPaAw==
Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17)
by LV3PR84MB3768.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:408:1d4::22)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.20; Sun, 23 Feb
2025 19:08:35 +0000
Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
([fe80::5c77:7a58:48ed:9aef]) by CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
([fe80::5c77:7a58:48ed:9aef%4]) with mapi id 15.20.8466.016; Sun, 23 Feb 2025
19:08:35 +0000
From: Morgan Smith <morgan.j.smith@HIDDEN>
To: Michael Albinus <michael.albinus@HIDDEN>
Subject: Re: bug#76446: [PATCH v2 3/5] tests: Add tests for debbugs-gnu
In-Reply-To: <87ldtyug07.fsf_-_@HIDDEN> (Michael Albinus's message of "Sat, 22
Feb 2025 16:59:52 +0100")
References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN>
<87zfifwlxg.fsf@HIDDEN>
<CH3PR84MB342460F7CF9FD5B9347BD72AC5C72@HIDDEN>
<87ldtyug07.fsf_-_@HIDDEN>
X-Hashcash: 1:20:250223:76446 <at> debbugs.gnu.org::vjIgGvBZ1BjEl07G:NJW
X-Hashcash: 1:20:250223:michael.albinus@HIDDEN::SnAT3/dMDr/Hpbf7:1Oaz
Date: Sun, 23 Feb 2025 14:08:31 -0500
Message-ID: <CH3PR84MB3424B8F637F82E2A7F1F5FBAC5C12@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
Content-Type: multipart/mixed; boundary="=-=-="
X-ClientProxiedBy: YT3PR01CA0007.CANPRD01.PROD.OUTLOOK.COM
(2603:10b6:b01:86::19) To CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
(2603:10b6:610:1c4::17)
X-Microsoft-Original-Message-ID: <874j0k8onk.fsf@HIDDEN>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CH3PR84MB3424:EE_|LV3PR84MB3768:EE_
X-MS-Office365-Filtering-Correlation-Id: d83fb5c0-fe54-4b92-2b13-08dd543d789f
X-Microsoft-Antispam: BCL:0;
ARA:14566002|15080799006|7092599003|6092099012|461199028|5072599009|19110799003|8060799006|440099028|3412199025|13095399003;
X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?/6iOBOqMPGom5/UYFIRh4ebXUAyacjwdeub+TlGNKVwl+SDNGDKvlLbSTCYE?=
=?us-ascii?Q?qBOVMXboBsidWcipCeRngt1/hT3XRvFOqiDAqDQqS77Sl4QMDXdgjQArNwmj?=
=?us-ascii?Q?rJxbp0HLcXtKW8Fg6QUkzOgQGZNADpApKmjSowT2iJURo/0/2AJW8VwTW1DD?=
=?us-ascii?Q?pgBqqnnOWr3wEOWH59jeTIHgLSROl0dy+/vHFKXwb9hL2jHQV774pE1q39ty?=
=?us-ascii?Q?cdXAXFbpti5zRcucDpg3Mn/VT6dpdoj2lEu9t/nfz2iNqEHyY54t0tJdnAHJ?=
=?us-ascii?Q?xWJiPSPH5kjOb7slgzKA4Si3Lz2c9i4MXBE8uTddgcO1icGaN1MliW5vzSzc?=
=?us-ascii?Q?CJvL9+jKrplHQXl0a9OQq2zjV79dWYsh2hGHei+Hh5j1iUzEUWlvM06h8zsn?=
=?us-ascii?Q?35S7vUFvvGHyTF3HtJHUTKEeqS2act+s/HvLV3YmmURhJexWzXm1OsBLRPmQ?=
=?us-ascii?Q?DDj/hdXMQxgfhDVfhxpnNcPsLWifZWmaloUFKRoJt/0K47+9MkREPC/siyiH?=
=?us-ascii?Q?8ToKVZ4LrZk5xD2tbrJSO3jwxfodLx6vGe+lqfOUWy3svh82miCqecuqSPIp?=
=?us-ascii?Q?f2LhzPBw+nDCkNvoDGDLFdulgVPCWvG27fv+72cwODi0OrBkaL+Sua+DW241?=
=?us-ascii?Q?VuHZJLLDCKrXz+aEEkzyb6FOPk+x7Ag5OpDmN00PTIBCqpDAMJfLgPU2T4Db?=
=?us-ascii?Q?NCGqDkKK+pifaZBcLhQKzkrcTY0wb2DlaB3Ka7eUCE+JBfG3ZkJXSZItdXFc?=
=?us-ascii?Q?bbji49uPVe5UhU6kYS5D05QmQWn4QPMNrj8RTYrONhflE8oT4XrYv6dM9+yl?=
=?us-ascii?Q?KL/IZqpvVDNjRlosKqqNQ57cPKXaxHJdj0oH/OMbmXhYVFLTjKbX7G9o8AfB?=
=?us-ascii?Q?nGnKFckTsJKVHFlH9HGC2aQz2RosXHqi8aDOVPYiAGr/2DryeAUtAV+y5gbu?=
=?us-ascii?Q?QeSNW32J1QX5sl+hCNOk+IRzlHUszFEAlRepC0Frx94qYCBXnPM9eUhAU4mB?=
=?us-ascii?Q?pOeMoeuthsbRSvmgMZAFtVZyr3lMgbMNV4o7thawWxVhjDnGu47FIbQAurwY?=
=?us-ascii?Q?vVg5bMC5gXyjS5US2+7ts2Ef2XUYTrZ1l31Ld8+Lnl02Fvtncwm1tlRy26su?=
=?us-ascii?Q?Hujtzka4Xt6zp2N3h1xJB+ZM6hnlLjKJbA=3D=3D?=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jLj0gVTBANpgzRLTZh/ifQT+fCefPUR2es8pWk7RPsnnvYR5XH/2At992HC6?=
=?us-ascii?Q?hxpELxl2VCH+HSH3nKoMk1SC2NSLCtLLCMrxjja5mrPLTtLB5sd0UhQzYUiW?=
=?us-ascii?Q?IH7/oG0hpC8Qv35VkIE91N/GleWo66ruzA2dr7bUgjg/sW7iQaPyIpP+bSMm?=
=?us-ascii?Q?0CK5DOzFDSj2ifwgKpSVQ7D6NDk8kQHyV26kplXzNx4OjUwxha9mAeKgUaDe?=
=?us-ascii?Q?o3+hOfji5+g14s/SeMMZpqDF8UljFzCrO6RyugkyyRLEb9olFCucW06BpfdA?=
=?us-ascii?Q?aeD9aozLezrFNvMLkQIg+whIGcujcdBIBDeLYo5ZXXSpvoHwNa2Wld6t6EFk?=
=?us-ascii?Q?+W4RkzWkGgBJmbhFgmzzzmPfiC6M6KlCm+OJM7gxToGdfz9p87Ky2mBF3bo6?=
=?us-ascii?Q?J1xQ2HZ/TPWaPE9cFg2iSQjmVEmh/2RGi16oD0u5bGBAgnWkBN95rEuL722m?=
=?us-ascii?Q?/Nwx7BKGlOCfI2UnwTv+Xu/QMEJt1Rx8n/e6HRRQf27eIn8QOq29icENgPL1?=
=?us-ascii?Q?bZsGinhe4mvtoez//caJLjkisIqgKbjcRQRqvHxPKURRcMJ59+vyAnfQtJta?=
=?us-ascii?Q?mSmwtpFceZEhuP8JzvMC1UDQY3Jjp7j9E8OpHMnTqJWFJ6l45FpC9KRjwqZw?=
=?us-ascii?Q?LHZ8bEEs/lzc1g+d8qT77aETEA8Re2wPoVM2bukmBUarLBlSjKzIKuj5vTHf?=
=?us-ascii?Q?cr1QXt9Z2kIu8I4Z32HqNe60lpqr+P56uCHlhw2Sdsa/X8h2au9O6mAIVB3o?=
=?us-ascii?Q?6Zi9q+kz9XuTSFZ4E2NBo4NBStiGrirMEK/VZEDMeudEVV8Bt+vZ9eK7SEWn?=
=?us-ascii?Q?CJnw/Jl8rRwkXAZmqzJGr+p0ub1nfSWgiWM7UjwBWN9887G8eqDK2MgEvf3y?=
=?us-ascii?Q?z+i+2ChhIZ8kmCBAyE3yOxLCsS+NjqnVNyO3zB5IowulkYQHXblzn0JOiaR1?=
=?us-ascii?Q?0E9Q8AoWESwQpMrJoKJa4SyhttPyMFbhaILMTjmjohOD7pebzT8nSgfAcYqk?=
=?us-ascii?Q?FyZfmXjpog0hSFy8Axre3jaJB30vPhYihudqvAPuQcX5OJSY8QoXsv2OL8ud?=
=?us-ascii?Q?kbn/a4MWPYB6qEMOgyehYvjVkEszGD2rg1o2YG/qA8VBzE4UWyE/g8n4oBzz?=
=?us-ascii?Q?KynmJ9SXM8WWEPlvD8X5rphf39KL3Bo63e7LKtqWd9hl5OFTBQ2zK2KjWmOE?=
=?us-ascii?Q?ZwPNyuOMHkTZGMGrw5xE58EEg8nR4gKyq5OMVQ23zldWsSNkFdrOND88X+kv?=
=?us-ascii?Q?eLPXIm3RhNON4SzslUgE?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d83fb5c0-fe54-4b92-2b13-08dd543d789f
X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2025 19:08:35.2297 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR84MB3768
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 76446
Cc: 76446 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain
Michael Albinus <michael.albinus@HIDDEN> writes:
> Morgan Smith <morgan.j.smith@HIDDEN> writes:
>
>>>> +Also test `debbugs-gnu-patches' and `debbugs-gnu-tagged' which are
>>>> +simple wrappers for `debbugs-gnu-search'."
>>>
>>> Nope. They are wrappers of `debbugs-gnu'.
>>
>> Oops! You're right. I have removed those tests.
>
> Perhaps you can give them own tests? In the futeure?
>
The tests I removed tested absolutely nothing. In the future I will
likely add tests for that. The current testing is pretty bare bones as
I'm just trying to get the test infrastructure up and running first.
>> --- /dev/null
>> +++ b/test/debbugs-gnu-tests.el
>> +(require 'debbugs)
>> +(require 'debbugs-gnu)
>
> You don't need to require 'debbugs'; debbugs-gnu does it for you.
Done!
>
> Best regards, Michael.
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=v3-0003-tests-Add-tests-for-debbugs-gnu.patch
From bfac115a81decf5b711e79cd65f999a96150f4df Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Fri, 21 Feb 2025 12:52:24 -0500
Subject: [PATCH v3 3/5] tests: Add tests for debbugs-gnu
* test/debbugs-gnu-tests.el: New file.
---
test/debbugs-gnu-tests.el | 46 +++++++++++++++++++++++++++++++++++++++
1 file changed, 46 insertions(+)
create mode 100644 test/debbugs-gnu-tests.el
diff --git a/test/debbugs-gnu-tests.el b/test/debbugs-gnu-tests.el
new file mode 100644
index 0000000000..6c803aefc3
--- /dev/null
+++ b/test/debbugs-gnu-tests.el
@@ -0,0 +1,46 @@
+;;; debbugs-gnu-tests.el --- tests for debbugs-gnu.el -*- lexical-binding: t; -*-
+
+;; Copyright (C) 2025 Free Software Foundation, Inc.
+
+;; Author: Morgan Smith <Morgan.J.Smith@HIDDEN>
+;; Package: debbugs
+
+;; This file is not part of GNU Emacs.
+
+;; This program is free software: you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; This program is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;; Please ensure tests don't actually make network calls.
+
+;;; Code:
+
+(require 'debbugs-gnu)
+(require 'debbugs-test-helpers)
+
+;;; Tests:
+
+(ert-deftest--debbugs debbugs-test-debbugs-gnu-search ()
+ "Test `debbugs-gnu-search'."
+ (cl-letf (((symbol-function #'debbugs-gnu)
+ #'list))
+ (should
+ (equal '(nil ("guix" "guix-patches") nil)
+ (debbugs-gnu-search "frogs" '((pending . "pending")) nil '("guix" "guix-patches") nil)))
+ (should (equal debbugs-gnu-current-query '((phrase . "frogs"))))
+ (should (equal debbugs-gnu-current-filter '((pending . "pending"))))))
+
+(provide 'debbugs-gnu-tests)
+
+;;; debbugs-gnu-tests.el ends here
--
2.48.1
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.Received: (at 76446) by debbugs.gnu.org; 23 Feb 2025 19:05:33 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 23 14:05:33 2025 Received: from localhost ([127.0.0.1]:36125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tmHIC-0000zb-QO for submit <at> debbugs.gnu.org; Sun, 23 Feb 2025 14:05:33 -0500 Received: from mail-bn8nam04olkn2081f.outbound.protection.outlook.com ([2a01:111:f403:2c08::81f]:30080 helo=NAM04-BN8-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <morgan.j.smith@HIDDEN>) id 1tmHI9-0000zL-15 for 76446 <at> debbugs.gnu.org; Sun, 23 Feb 2025 14:05:30 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=m9DZpUT3Vb5WRklMoxkepA7s73PEsdzFjkz5xJyIU58rOah7xeeOPaNfvQFJAt8rKaydDoxpplZsh1Gaj5DRJSJCoNjVjRDuXvVa14IbEgp6afhSuT2KuSx41KNxoDIXH2544AMuSMz2zNPKtMo95Y+/FFNaX5rq1aXsID2rdeHArcUz7VDtBSqj7CG5ukDchJYO9ao49OCrdEkJ5L/b1fI9K7oo3VWchG4AELvTBCnyH5rjzb3vMroEsP2DnaCYrYL7g47PuOFaTs8SErxXh+yGTLmjao8hppeEuH5zJi60YSzbHqkOcpCqoblvz3WI6lz+56tAufrZD5fxf2bw+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CIWDJv522eC41BwYorEHRXzJMpyGIhDYP8dXkK30wMA=; b=TyTTx5TZek8d6r8TIKGFoGuvC/vHuq7BSH/CGUSeCmzGFCYMu/jD9H+SnRuO8iqlnybUGynarxp8edt/POrh8skyQBlZoPYSjXBFsf6LUARkbgGih5Xih3cq6aAJHwLggmBFK+48AaR8gu0EdbfkZelhc86Tm17ak82kMoH9w2fLlFwTokD9OnZknCTGeNF20T2S/4Vw1xvLjP5/w1/2Blv2BHJLFZ4geYr6hvwfY8ph+La3CWjTJUGnNsrWSYkhDjurf49K3kwUD2jo4dI8nBVLAgSfAOgex0QuJZ7htmUV+DPhYNyw8tVbbG7vVXVDJ7LLDxXl3dY/6KcpA2vTog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CIWDJv522eC41BwYorEHRXzJMpyGIhDYP8dXkK30wMA=; b=WSRHcbE4nXVo/gF8Dg388vQLHiviwkdy6nRaghJmFzUYIidO2CURblJ7LawKUSNVCQDFdBShRlQQdcJEhzXtjB5l5+/0u+2Hnwfj69j/TqjB6PuKB3HarMgeZUiUEWHqN+pK6DM8MI9Bdh/CmIsXklTAKHdxDkFXJW0BiwNgF5PViaUJsxK/zRYgZ4+WqJBtkFFpM9ctOVFldRGh3Vht/bdescO74xOC9P1TOvVmdbHk9w68EzmgJfZg/z2iflru13gytIwaMTbiDXWNh7VoR04gmDzndM0EV5esdhzGNZKGBPKGgLSBfLr0j3sjUxo6Y9OoHhCtEwjM2voPZraJ9Q== Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17) by LV3PR84MB3768.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:408:1d4::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.20; Sun, 23 Feb 2025 19:05:21 +0000 Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM ([fe80::5c77:7a58:48ed:9aef]) by CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM ([fe80::5c77:7a58:48ed:9aef%4]) with mapi id 15.20.8466.016; Sun, 23 Feb 2025 19:05:20 +0000 From: Morgan Smith <morgan.j.smith@HIDDEN> To: Michael Albinus <michael.albinus@HIDDEN> Subject: Re: bug#76446: [PATCH v2 1/5] tests: Move helper and wrapper functions into their own file In-Reply-To: <87pljaug6e.fsf_-_@HIDDEN> (Michael Albinus's message of "Sat, 22 Feb 2025 16:56:09 +0100") References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN> <874j0ny0pa.fsf@HIDDEN> <CH3PR84MB3424C014EA66C2F79FDC1E0AC5C72@HIDDEN> <87pljaug6e.fsf_-_@HIDDEN> X-Hashcash: 1:20:250223:76446 <at> debbugs.gnu.org::U4lUzGfOqVUaz2sf:0tRp X-Hashcash: 1:20:250223:michael.albinus@HIDDEN::/tWs12XSh7PP/Q4k:gZF Date: Sun, 23 Feb 2025 14:05:17 -0500 Message-ID: <CH3PR84MB342428AE49137127C00EDACDC5C12@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: multipart/mixed; boundary="=-=-=" X-ClientProxiedBy: YT3PR01CA0049.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:82::30) To CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17) X-Microsoft-Original-Message-ID: <878qpw8osy.fsf@HIDDEN> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR84MB3424:EE_|LV3PR84MB3768:EE_ X-MS-Office365-Filtering-Correlation-Id: 18e965af-827a-4ab4-fa41-08dd543d0491 X-Microsoft-Antispam: BCL:0; ARA:14566002|15080799006|7092599003|6092099012|461199028|5072599009|19110799003|8060799006|440099028|3412199025|13095399003|41001999003|12091999003; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?cLG7xRJaNM5QoqL0KGmyWjTCbf3n35/PZ6lqCUpqlI64I/jHHesFefhcPh3N?= =?us-ascii?Q?VSOOsSlHMZCin6LQE5MGDAIy0aJpl3zZiLPzlZZXHQsX+9Sw63sXmA7ltAL5?= =?us-ascii?Q?9B9CDsgjNClgbtlikZhz8AXMy7BlPUexMkuOYnqGAFaQfAoyZnwh+ImEAf0K?= =?us-ascii?Q?KAivQIsfzPWKgI3CkKatlhvaYv4dNIlCmXowS4ggpTKzlFtqonPSglYW/tHb?= =?us-ascii?Q?XIWfcTF2xp/PN9ulEwvEVQxOKkpemG4B8qRw5VoIs8cnJzE28W0LFHFuzvxU?= =?us-ascii?Q?8k10oo7MmKTnrC0fSZMIUSJbwiA0oN3cA8QrTov93ZpdPJ9oyfxddVWlvw+c?= =?us-ascii?Q?vEHsgR+PQTh8MTXaxA68WIVn5SQYP3NdYDdI5r5yGd83Wq5RoxXKWiC/Qcep?= =?us-ascii?Q?ocEUAFN/Ibpiy3HvTtiuaj0HF4PbOraIxS8/+A+LtRCbQGSS8E+sfB37Rgoq?= =?us-ascii?Q?hF57XwaX1W51uoDfJnGa+HmAfg0EArtdCkjFXB3GHWevn3WplpoAaQduL4Mv?= =?us-ascii?Q?+UxX2pIC+cIE6E9KfjSZheHmgrwMemXuWSyenHqQ0MZEygp9dPInmtdbTfqO?= =?us-ascii?Q?k954wZ6UWd+qr8TAUM8ubm1x6311RMABbpn5laqwfzecoGruTwDTdsgzj3KO?= =?us-ascii?Q?Un4XCJv5Z/8kEDK1tKwZMj8CG6dUG9jxpJJRbhl3c5vPhbWO9HUEfOg7REQs?= =?us-ascii?Q?7pmjGUrv3hMfFmg5uTFIo9Rnx70lvGURplzQKe6AVK2TIqB/2f8cOU4L7EXf?= =?us-ascii?Q?iADA3P9OqjfHIYRPWqDnzPJP1aUmM6QyDZQFCRGXNHqbf/LcZD659B3WaM68?= =?us-ascii?Q?9RES1qOIKkVBchMMSc6JVGTYd5BmwFcgOhARlm+Bq0pf0WXzfyxqcfOPrDHH?= =?us-ascii?Q?Aeq5f1KqGVMMKzmkchxbHHLbuABXXqfei+RadM0ZjphMTwIT7NB8zXayKcCP?= =?us-ascii?Q?PoFey0Pr1YnEPdE3ifdePhU5qtpc/a8gMpCHPV2tI3U1qZ7JyOxrgN91bT3x?= =?us-ascii?Q?jG42LUDH5jiWxMZHGPgj9rwohp0DLDAe2j/6LvJ2XoecpLy8XaE7uSfKuFKn?= =?us-ascii?Q?d2wW8+GtLRxDGl+SigFqL0nCZDzxP7NeruO/1dGaM9CyqgN2eefYL85A1v8E?= =?us-ascii?Q?Hdi7Ym6ixF+Tnj8vV/IpaOCqdI0X5kNkkMCdxmPnLob47kx7QXAGFf842v7x?= =?us-ascii?Q?hp5hKxTegXkTX7qZkG+/3YXPZoZq9kXUDaR1aw=3D=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1gRyzRiw79tK6OJsvTV5tCmZ+VqchIYQqR5vlfz57RHndF27v6CGsJAISozC?= =?us-ascii?Q?/e+XQ6bJ8J4VrwfjiuGwyN/CbYCQSF/NyjPMEL9jYED4xcCVKX52uimNWch2?= =?us-ascii?Q?QWnNajOHvt0Jj0pirzJlQsStsokwxfRhB6YqZB7x3icvC0j4pfabGGuUAoUh?= =?us-ascii?Q?dawsWdP6r3d27cKz/H/9DtExu2VeOI5onE1GrPqtICzPLHSPlvLhB5BSCC2s?= =?us-ascii?Q?b9kns4SZGZOBihS6YXxkhbt83DCE8z5BR3TLSD6tVndQqNqBFx6LCMRsZxha?= =?us-ascii?Q?hc7RzOfbI3SF/mOu0VhXoR5eUM8FdnEj9nAv+wZQZN3hHiFpNiGxIu+YnUXV?= =?us-ascii?Q?ajYvvcL2dVcL1uwZj0nP0BVsN55xlodu+K/59/i8NmWbKxbWwLL1dGtFgs3l?= =?us-ascii?Q?aZwlmw5JDyRIprDhsia+NSCDbR5GP+loLJRmK3Ougng56m8bFgL3pVFGzBau?= =?us-ascii?Q?cU9JPQ7C3qOtHDjvr67boUmDN6FDp/Fq0xX34ySaZFel4L+ifdxFL/n+mI17?= =?us-ascii?Q?LR/Gy1WrK4eQOcSvDAurxIN4s4Ovp10y9GU3VHAAqdciAEURN7dyI1SrBByE?= =?us-ascii?Q?PDnRnTIBjWTjWnZ+BHlhOAzGHzo1Bu+89oKvArLd8fG90i1MLtUJPGTrI4+B?= =?us-ascii?Q?IHXI1q6NK4RIysKB9Z+X4h8XcjVeT8/vjw3SwMi9tKW/3KW+bnLPZPdzVspN?= =?us-ascii?Q?uZn+RD55PtABWKzp5oKm0MX4Htm304WtMJx+gmZMx1N+dVAWsxFEqTBkm4rm?= =?us-ascii?Q?MaeI/JrlaK1pRCVjMOcdtENQwpPKmF0Ht6NC36XMLIto+oogUL+TXV22l7iO?= =?us-ascii?Q?wNqh/FtpcKMADfe3HDOQLj9GbRhyA/YzKwdc+AZdql0X31mmiiwcBwYpiv2m?= =?us-ascii?Q?Uif5z2IhDc/T+IFWBMB6gLc46MTe5Liw2uYJF41QOdfkS3iNe4G1Ul5o3cuL?= =?us-ascii?Q?GduCgfr9P4X2sAlTFiJBP6xw9C4xAtdjDrkf1yM4rWJvfKhvRY5vYhYuSYDV?= =?us-ascii?Q?1rPzRp0QSWgpZ9DYhmsRPqxeHswYhopWBtzvEAOaLLA9ZM7q4CTuiHBeyPPL?= =?us-ascii?Q?EJcUdKi/vwIQwXx9ZvS3GQTiJcLGZHO8G6BEJuqXpmHqnyrvd4nT7mlrSFfj?= =?us-ascii?Q?gG9w5abPyFKTyDVdL85pSwXV5hHeNVTW5I4tRL1sFPCswhKtGBP0fQDfMH5G?= =?us-ascii?Q?I8rY00aidV69ZKfR/zNGLi5e9ekLywseQ7L8MN+PYQdakPyfawi+anFJUDHF?= =?us-ascii?Q?tzCO3+ULmWDlIFXsm4z8?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18e965af-827a-4ab4-fa41-08dd543d0491 X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2025 19:05:20.6160 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR84MB3768 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 76446 Cc: 76446 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Michael Albinus <michael.albinus@HIDDEN> writes: > Morgan Smith <morgan.j.smith@HIDDEN> writes: > >>> We might be better with >>> >>> --8<---------------cut here---------------start------------->8--- >>> @$(EMACS) -Q --batch -L . -L ./test -l $(TESTSOURCE) -f ert-run-tests-batch-and-exit >>> --8<---------------cut here---------------end--------------->8--- >>> >> >> I did the '-L ./test' part but I kept the foreach. >> >> Without the foreach the command looks like "... -l file1.el file2.el >> file3.el ..." and emacs only actually loads the first file. The command >> needs to look like "... -l file1.el -l file2.el -l file3.el ..." > > My point is, that we have only the make target 'check', which runs all > ert tests located in different files. But I would also like to run only > the tests in, say for example, debbugs-tests.el. So we need an own > target for every *-tests.el file. > I've now implemented the interface I've seen in other projects (guix, org-mode) to enable this feature. It looks something like this: "make check TESTS='get-status'". >>>> --- /dev/null >>>> +++ b/test/debbugs-test-helpers.el >>>> @@ -0,0 +1,146 @@ >>>> +(defconst debbugs-test--bug-status-soap-return >>>> +(defconst debbugs-test--bug-status >>> >>> Perhaps we should move these data into an ert-resource file (or two). >>> I still don't understand why it would be beneficial to have the data in resource files. I also think that maybe it should be classified as an enhancement that goes beyond the scope of this particular patch series. If you would like to do this please feel free. I've only got so many hours in my day. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=v3-0001-tests-Move-helper-and-wrapper-functions-into-thei.patch From 71fd3e1a8490c038473e91fd521ced6661de56f6 Mon Sep 17 00:00:00 2001 From: Morgan Smith <Morgan.J.Smith@HIDDEN> Date: Fri, 21 Feb 2025 12:52:03 -0500 Subject: [PATCH v3 1/5] tests: Move helper and wrapper functions into their own file * test/debbugs-test-helpers.el: New file. * test/debbugs-tests.el: Move test helper and wrapper functions into the new file and require it. * Makefile(check): Load all files in the test directory. --- Makefile | 8 +- test/debbugs-test-helpers.el | 146 +++++++++++++++++++++++++++++++++++ test/debbugs-tests.el | 113 +-------------------------- 3 files changed, 154 insertions(+), 113 deletions(-) create mode 100644 test/debbugs-test-helpers.el diff --git a/Makefile b/Makefile index a7b6b0c7f3..81d7b5d2f2 100644 --- a/Makefile +++ b/Makefile @@ -1,6 +1,9 @@ EMACS ?= emacs MAKEINFO ?= makeinfo +# regex of tests to run +TESTS=.* + SOURCE=$(wildcard *.el) TESTSOURCE=$(wildcard test/*.el) TARGET=$(filter-out debbugs-pkg.elc,$(patsubst %.el,%.elc,$(SOURCE))) @@ -14,6 +17,9 @@ INFOMANUALS=debbugs.info debbugs-ug.info %.elc: %.el @$(EMACS) -Q -batch -L . -f batch-byte-compile $< +test/%.elc: test/%.el + @$(EMACS) -Q -batch -L . -L ./test -f batch-byte-compile $< + %.info: %.texi $(MAKEINFO) --error-limit=0 --no-split $< -o $@ @@ -24,7 +30,7 @@ doc: $(INFOMANUALS) build: $(TARGET) check: build $(TESTTARGET) - @$(EMACS) -Q --batch -L . -l $(TESTSOURCE) -f ert-run-tests-batch-and-exit + @$(EMACS) -Q --batch -L . -L ./test $(foreach file,$(TESTSOURCE), -l $(file)) --eval '(ert-run-tests-batch-and-exit "$(TESTS)")' clean: -rm -f $(TARGET) $(TESTTARGET) $(INFOMANUALS) diff --git a/test/debbugs-test-helpers.el b/test/debbugs-test-helpers.el new file mode 100644 index 0000000000..f98bab40ed --- /dev/null +++ b/test/debbugs-test-helpers.el @@ -0,0 +1,146 @@ +;;; debbugs-test-helpers.el --- Helpers for testing debbugs -*- lexical-binding: t; -*- + +;; Copyright (C) 2024-2025 Free Software Foundation, Inc. + +;; Author: Morgan Smith <Morgan.J.Smith@HIDDEN> +;; Package: debbugs + +;; This file is not part of GNU Emacs. + +;; This program is free software: you can redistribute it and/or modify +;; it under the terms of the GNU General Public License as published by +;; the Free Software Foundation, either version 3 of the License, or +;; (at your option) any later version. + +;; This program is distributed in the hope that it will be useful, +;; but WITHOUT ANY WARRANTY; without even the implied warranty of +;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;; GNU General Public License for more details. + +;; You should have received a copy of the GNU General Public License +;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>. + +;;; Commentary: + +;; Please ensure tests don't actually make network calls. + +;;; Code: + +(require 'debbugs) + +;;; Helper Data: + +;; Generated using this: +;; (soap-invoke debbugs-wsdl debbugs-port "get_status" [64064]) +(defconst debbugs-test--bug-status-soap-return + '(((item + (key . 64064) + (value + (package . "emacs") (found_date) (last_modified . 1689593050) + (affects) (date . 1686745022) (fixed_versions) + (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>") + (blocks) (archived . 1) (found) (unarchived) (tags . "patch") + (severity . "normal") (location . "archive") (owner) (fixed) + (blockedby) (pending . "done") (keywords . "patch") (id . 64064) + (found_versions) (mergedwith) (summary) (forwarded) + (log_modified . 1689593050) + (done . "Michael Albinus <michael.albinus@HIDDEN>") + (source . "unknown") + (msgid + . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>") + (bug_num . 64064) (subject . "[PATCH 0/4] debbugs improvements") + (fixed_date))))) + "Mock result from `soap-invoke' for bug 64064.") + +;; Generated using this: +;; (debbugs-get-status 64064) +(defconst debbugs-test--bug-status + '(((cache_time . 5000) (source . "unknown") (unarchived) + (keywords "patch") (blocks) (pending . "done") (severity . "normal") + (done . "Michael Albinus <michael.albinus@HIDDEN>") (location . "archive") + (log_modified . 1689593050) (subject . "[PATCH 0/4] debbugs improvements") + (last_modified . 1689593050) (found) (tags "patch") (package "emacs") + (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>") (archived . t) + (blockedby) (affects) (mergedwith) (summary) (date . 1686745022) + (fixed_versions) (id . 64064) (fixed) (found_date) (forwarded) + (msgid + . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>") + (owner) (found_versions) (fixed_date) (bug_num . 64064))) + "Mock result from `debbugs-get-status' for bug 64064.") + +;;; Helper Functions: + +(defvar debbugs-test--soap-operation-name nil) +(defvar debbugs-test--soap-parameters nil) +(defun debbugs-test--soap-invoke-internal + (callback _cbargs _wsdl _service operation-name &rest parameters) + "Over-ride for testing." + (setq debbugs-test--soap-operation-name operation-name) + (setq debbugs-test--soap-parameters parameters) + (let ((return + (cond ((string-equal operation-name "get_status") + debbugs-test--bug-status-soap-return) + ((string-equal operation-name "get_usertag") + '(((hi)))) + (t '((0)))))) + (if callback + (progn + (funcall callback return) + nil) + return))) + +(defun debbugs-test--override-float-time (func &rest rest) + "Override `float-time' for FUNC with args REST." + (cl-letf (((symbol-function #'float-time) + (lambda (&optional _specified-time) 5000))) + (apply func rest))) + +(defun debbugs-test--setup () + "Mock network and time functions. +These mock functions are needed to make the tests reproducible." + (setq debbugs-test--soap-operation-name nil) + (setq debbugs-test--soap-parameters nil) + + (add-function + :override (symbol-function #'soap-invoke-internal) + #'debbugs-test--soap-invoke-internal) + + (add-function + :around (symbol-function #'debbugs-get-cache) + #'debbugs-test--override-float-time) + + (add-function + :around (symbol-function #'debbugs-put-cache) + #'debbugs-test--override-float-time)) + +(defun debbugs-test--teardown () + "Restore functions to as they where before." + (setq debbugs-test--soap-operation-name nil) + (setq debbugs-test--soap-parameters nil) + + (remove-function + (symbol-function #'soap-invoke-internal) + #'debbugs-test--soap-invoke-internal) + + (remove-function + (symbol-function #'debbugs-get-cache) + #'debbugs-test--override-float-time) + + (remove-function + (symbol-function #'debbugs-put-cache) + #'debbugs-test--override-float-time)) + +(defmacro ert-deftest--debbugs (name args docstring &rest body) + "The same as `ert-deftest' but runs setup and teardown functions." + (declare + (doc-string 3) + (indent 2)) + `(ert-deftest ,name ,args ,docstring + (debbugs-test--setup) + ,@body + (debbugs-test--teardown))) + + +(provide 'debbugs-test-helpers) + +;;; debbugs-test-helpers.el ends here diff --git a/test/debbugs-tests.el b/test/debbugs-tests.el index f3abea2837..da1b9dffe6 100644 --- a/test/debbugs-tests.el +++ b/test/debbugs-tests.el @@ -27,118 +27,7 @@ ;;; Code: (require 'debbugs) - -;;; Helper Data: - -;; Generated using this: -;; (soap-invoke debbugs-wsdl debbugs-port "get_status" [64064]) -(defconst debbugs-test--bug-status-soap-return - '(((item - (key . 64064) - (value - (package . "emacs") (found_date) (last_modified . 1689593050) - (affects) (date . 1686745022) (fixed_versions) - (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>") - (blocks) (archived . 1) (found) (unarchived) (tags . "patch") - (severity . "normal") (location . "archive") (owner) (fixed) - (blockedby) (pending . "done") (keywords . "patch") (id . 64064) - (found_versions) (mergedwith) (summary) (forwarded) - (log_modified . 1689593050) - (done . "Michael Albinus <michael.albinus@HIDDEN>") - (source . "unknown") - (msgid - . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>") - (bug_num . 64064) (subject . "[PATCH 0/4] debbugs improvements") - (fixed_date))))) - "Mock result from `soap-invoke' for bug 64064.") - -;; Generated using this: -;; (debbugs-get-status 64064) -(defconst debbugs-test--bug-status - '(((cache_time . 5000) (source . "unknown") (unarchived) - (keywords "patch") (blocks) (pending . "done") (severity . "normal") - (done . "Michael Albinus <michael.albinus@HIDDEN>") (location . "archive") - (log_modified . 1689593050) (subject . "[PATCH 0/4] debbugs improvements") - (last_modified . 1689593050) (found) (tags "patch") (package "emacs") - (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>") (archived . t) - (blockedby) (affects) (mergedwith) (summary) (date . 1686745022) - (fixed_versions) (id . 64064) (fixed) (found_date) (forwarded) - (msgid - . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>") - (owner) (found_versions) (fixed_date) (bug_num . 64064))) - "Mock result from `debbugs-get-status' for bug 64064.") - -;;; Helper Functions: - -(defvar debbugs-test--soap-operation-name nil) -(defvar debbugs-test--soap-parameters nil) -(defun debbugs-test--soap-invoke-internal - (callback _cbargs _wsdl _service operation-name &rest parameters) - "Over-ride for testing." - (setq debbugs-test--soap-operation-name operation-name) - (setq debbugs-test--soap-parameters parameters) - (let ((return - (cond ((string-equal operation-name "get_status") - debbugs-test--bug-status-soap-return) - ((string-equal operation-name "get_usertag") - '(((hi)))) - (t '((0)))))) - (if callback - (progn - (funcall callback return) - nil) - return))) - -(defun debbugs-test--override-float-time (func &rest rest) - "Override `float-time' for FUNC with args REST." - (cl-letf (((symbol-function #'float-time) - (lambda (&optional _specified-time) 5000))) - (apply func rest))) - -(defun debbugs-test--setup () - "Mock network and time functions. -These mock functions are needed to make the tests reproducible." - (setq debbugs-test--soap-operation-name nil) - (setq debbugs-test--soap-parameters nil) - - (add-function - :override (symbol-function #'soap-invoke-internal) - #'debbugs-test--soap-invoke-internal) - - (add-function - :around (symbol-function #'debbugs-get-cache) - #'debbugs-test--override-float-time) - - (add-function - :around (symbol-function #'debbugs-put-cache) - #'debbugs-test--override-float-time)) - -(defun debbugs-test--teardown () - "Restore functions to as they where before." - (setq debbugs-test--soap-operation-name nil) - (setq debbugs-test--soap-parameters nil) - - (remove-function - (symbol-function #'soap-invoke-internal) - #'debbugs-test--soap-invoke-internal) - - (remove-function - (symbol-function #'debbugs-get-cache) - #'debbugs-test--override-float-time) - - (remove-function - (symbol-function #'debbugs-put-cache) - #'debbugs-test--override-float-time)) - -(defmacro ert-deftest--debbugs (name args docstring &rest body) - "The same as `ert-deftest' but runs setup and teardown functions." - (declare - (doc-string 3) - (indent 2)) - `(ert-deftest ,name ,args ,docstring - (debbugs-test--setup) - ,@body - (debbugs-test--teardown))) +(require 'debbugs-test-helpers) ;;; Tests: -- 2.48.1 --=-=-=--
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.Stefan Kangas <stefankangas@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 76446) by debbugs.gnu.org; 22 Feb 2025 16:13:30 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 22 11:13:30 2025 Received: from localhost ([127.0.0.1]:56950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tls89-0007sf-WD for submit <at> debbugs.gnu.org; Sat, 22 Feb 2025 11:13:30 -0500 Received: from mout.gmx.net ([212.227.15.15]:43453) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <michael.albinus@HIDDEN>) id 1tls85-0007sJ-MT for 76446 <at> debbugs.gnu.org; Sat, 22 Feb 2025 11:13:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1740240797; x=1740845597; i=michael.albinus@HIDDEN; bh=EeY4Go5675/Mn3UZOU8/N0oR2WhCJpITnqn4KPOhXW8=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=EsLUrdaArGL1m/0b/e98REX5FSnMsWVht1gVFsv4rY2WG5kQxu6xPca4DEbyzKkx zSWcn83jEgZr5AVLnAo+YMUApbdxbz7XUZeOubILSoPC7CB83A75FlBpCBmucop2o yo6hidUSV5Cv3TwXL1x29vyn7vRQsym8SqtUxfDBSxcSsMyEZvmhl7N2d7hQ3cDOM cxbqAhLKJ0rBH1X13B6kr74oVwV/791b/Q6N1qGd7ZPgkqohBib3GP69rO0jjqxXO teUZlmUwShsBBrqrc0dgaLH1OECZtXUiXa7PhbiB1ql7aLe2sd+wgrv9IEXCTmcxQ xefG5SApseVnoK/U9A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mg6e4-1t7ZUQ41yo-00aSVl; Sat, 22 Feb 2025 17:13:17 +0100 From: Michael Albinus <michael.albinus@HIDDEN> To: Morgan Smith <morgan.j.smith@HIDDEN> Subject: Re: bug#76446: [PATCH v2 5/5] tests: Support older Emacs sorting conventions In-Reply-To: <CH3PR84MB3424807016C1C6E6EBCD08E6C5C72@HIDDEN> References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN> <87bjuvy17p.fsf@HIDDEN> <CH3PR84MB3424807016C1C6E6EBCD08E6C5C72@HIDDEN> Date: Sat, 22 Feb 2025 17:13:16 +0100 Message-ID: <87cyfaufdv.fsf_-_@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:CX8O/SXKgNG1m2pNsTTwpg9r3jCq+W4w2obLCV1wiY3CsH4uhKj ciz/7b6QAFXTObX6k9gyDIocFw2SeVHyPTl+fqf9e32JHs3E6JbNVDtma8HSunQCGyqTOiJ N/VfoQoNHG6O0XBkIUv0s0KEmBRLwkuuqjhf+gO9XimoGeMeBINtVMKcyiAdW05hTLsR2eE FYOGls8S83JXVDfvikteg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:7l95oUhApLI=;DzxAleI4nhSzDGUB0clOt1Vpyll R0eyVKK0Y69X7c4A+Ni0xcslw5QlixCb2bB4Ib5KeaocHmSib6r5H1L+wonwsY0SnCNE349VA QF23YycUB6z7DWcCm38RQ8yzeQ27vgm6zWb9yFgZOedX+wdLR5+JVh1z8FVw9zHJrgdMNMjKs dNx2LwmmkMVciS/rwdl4vh57zScQwegpM2qWr+X+ZRP2t28yth3pwJ+W5zEsDFDLe3/eYICyg KFl6OwAazHNcG6a+RW9n0z5mQeV9+WBK64uSR5tv7EymgXOFa4tb819w8hPw3AftrsWYAUFVe 3WxGIVmK07elBj9Up751k5T2L2jWfjOh/XbLyq9N6b/Yyyafhgbo03tqQ9/zk4fjb4g9BfTgD uEGJMZ2fcm2D2VgsKZaKUlq7m4BB1Bj1StUTbLFu/B+0mE2fwkN7swAc22SVR06u3CK6gK0N2 ai18R7LRba1AcKqYd0lPNPDlGpHajHs+YR2N6kLLAgI/ZB/o+xBv+zvXL3NwI9+jjnPLHcwqW abid00AwAOMnu4nbajmOFW/5OMDZ2o47XfYmrEl05rEtwo0qzIYiOCIEtm/4B43HjXsti2Ley m+z+uiqu1HDB51cCOvgaLIhKi+Ss1nEVOWcWIVedwc/Xuk6x2Au7Q5A0vCESXSU6fbdnPQGuQ Jg9YnIM4vcSBZs2cK7wApL9U21uOkuDKIBoqQILSFtCDBkHdQylV9mS6cTl67DZFKXeZfhxUO dzv1jL7ogtjYebFcskcnzum8llX/RrZyHcb5cuj+9e4kgQbLgz3cgn47CuQucqbVWyDzZlb7A waulo+n5QS+ntK9tbQf/zZrxrNbXBG3/prOC/PDZv0wfW3JtCx9SZymUAKGfjeFi9eMW/Za1e ByP7YBoCKuznIYsnRS2f3XFaoEEuy3UTB4NO0eLEOqZglYWoMbiF4L4yqqbmgTtWqfhRuLsNA BpbEvLIAHSACIwcjee0kX5a9oLTga2HVamyvTZf7uf4ivhECLlSsXMe6rT5LKd11L1EanE2lG puCazstIz9J1+kumCvQ8hzPeyIsNgZNy0hbwWSrDKNN6otIPoaPSvGaa799UR7MNP2CZpzEHd 9VIfGwqsBrLarGgEcpZ95EbZGrMjUPfqXpxC28lEOv5OulvlqYi3iVh+fLqPloQ7Vu3oB3gz0 Xz0v8ToiBtVP0qyz0FqvmDjLp7y6nY64JmoXRuI8v8eFcS6fVQcoY9jtBAqx/Qob9Uh9VJttp kSSmrXSv6pxMqX47jpcidoAv3Ce8NeqyJek9PB5+udHw4c3YLItcfeiNKnHxgzTZj1NkMm7GO D4FtUfdb0qNxkWAjbb+dWUXutC1CqP6UTGnStEWIsrU5TeaK09kBEx3ukzhnXdoPwPJag6Meu uwt5kHzKrkLUw2O9vs1Xwoy9BkXAsHyrMmYuRVHDtUTblNor+rExzHtWnB X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76446 Cc: 76446 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Morgan Smith <morgan.j.smith@HIDDEN> writes: > --- a/test/debbugs-tests.el > +++ b/test/debbugs-tests.el > + (eval-and-compile > + (defun alist-sort (x y) > + (string< (car x) (car y)))) I would define this function in debbugs-test-helpers.el. And perhaps give it a debbugs-test- prefix; we don't want to pollute the Emacs name space. Best regards, Michael.
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.
Received: (at 76446) by debbugs.gnu.org; 22 Feb 2025 16:05:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 22 11:05:18 2025
Received: from localhost ([127.0.0.1]:56922 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tls0E-0007X7-7p
for submit <at> debbugs.gnu.org; Sat, 22 Feb 2025 11:05:18 -0500
Received: from mout.gmx.net ([212.227.17.21]:52719)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <michael.albinus@HIDDEN>)
id 1tls0B-0007RC-1R
for 76446 <at> debbugs.gnu.org; Sat, 22 Feb 2025 11:05:16 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de;
s=s31663417; t=1740240307; x=1740845107; i=michael.albinus@HIDDEN;
bh=W3tmvoX11Evhi57GNWCFw/QX6Vgp1vAu9VV2K+OoVcI=;
h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date:
Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc:
content-transfer-encoding:content-type:date:from:message-id:
mime-version:reply-to:subject:to;
b=AIvtSXtn9v7Rd/h301CnJicA0+Rvi0HbmSnhOXtuJCepWA1KBJMK8COaD/5wpgRq
YG45CVpejIl/eVb4h8yOsN5DKHfDdkCWB3zSNJlpUd0zzJwXFYGuN94nvd60xeG9a
qBLnnXQ2aQcZPqPdQ2rPbTvOZXcGwQbfklkzI4oaavBEai5LC2sgMCCqOeYPdOXTq
DBK1GVggRldeFacVY0/VavAyiZ4PlnWOK+lagTGqWr5HhVPfboz7wusMT40FYgyt2
bNmPWtGLC/5fPac/e1PPuEC5JnrpTBmDmeePlhGnDO5BaShrdv+fpwIjajpkv+TLw
Nhsm8/x0AySnvORT0w==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx105
[212.227.17.168]) with ESMTPSA (Nemesis) id 1MEV3C-1tWyoj1ldK-002ub9; Sat, 22
Feb 2025 17:05:07 +0100
From: Michael Albinus <michael.albinus@HIDDEN>
To: Morgan Smith <morgan.j.smith@HIDDEN>
Subject: Re: bug#76446: [PATCH v2 4/5] Makefile: Add target to run checkdoc
on all files
In-Reply-To: <CH3PR84MB3424EB975A4BE9FE7185E74EC5C72@HIDDEN>
References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN>
<87v7t3wlo3.fsf@HIDDEN>
<CH3PR84MB3424EB975A4BE9FE7185E74EC5C72@HIDDEN>
Date: Sat, 22 Feb 2025 17:05:04 +0100
Message-ID: <87h64mufrj.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:Fc8tZKsTrPLq4Yb9Ta/PibxLCnB7ak8KEwQ53LxtGLKKBBuwV/f
HBBhAcC1ne5b0nV2udN0SNVr71sTxiFY6pT6hXeTEsi0qOwLGonBTHZ7uvJohJ4Qw+lv1MT
A1KqvFBkXmj60lRy9cZ+R6f6h9R1HdJj3GS9f5qHXr264S69STDhff73/rD8WApZx/1SxX7
LHMHQ05GJWsHwTao/MNIQ==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:rCrDqm5P1pQ=;pTB3rAlwBCSEAo0umhTLbaVGxRo
Fx2qAUuzBOCz89zcWIjFwHVvF/duT9MxifDwQKXCOHPLGhMeiUk6/Q+kvshcEHOkx+5l+vtz0
SJiED3JgkPy/fpGxWoTf133mNAOP3GFRaorsx+IRmAYIWuQVS+R2xmQt7uYtTKiBZD5aVfEO1
FSRV5OhA33OGZs09I+2bG1JJsTw0qytBdIVa9wNV2aGAl1a7RBQBDg0BWbrFX5Xcx7v03nz8i
T+nlXce6Ewqr5l3chhPQGG0BTts5gZA19v+m15Y3bQrkDLzVkh98ENAmk3G0N3s5+CIpZeG5i
/DIySXC5hppvzbfleU1aNtewRrtAB/Ii0C8pcrRpXHuW/WA11jh2o2YAHkFNPz9SNlMgEhK2C
kARde8HQpxq4Q3Yz1xJPY/dNkaTnmMEsD6YLLnl7HTeNZs1ZCMIZLIws9XY6akFYR2nBg10/q
0Whyu2id8nAkSpcm9LEHpC08vHeiXqMUu3NoIUoOMJZHFAuxbt01weVVgZZdLKd0IvZr3vwMw
JgVp/b5dR2sIZtEqLrs2CD7nrAlLckGdKIpqRrIGvtV0gcfnIaXAxD5sG/Ec1Yh3NiZLo1J79
8Hbv74UfLkhFoZYw87lMXyAcy4ZRCKBW8vpqIyvHOYZkDD4NzdiOAbdyQY3tvka0IH1D9pFd3
NM2VP5qzNtRkaopyh5vze4DE9IIpy/HvJcWBI/3CADduz1a4ZMldfH+DW7XSpjSLaco5DQ2VU
sRJjgxuwUdhwDf+1622DIgyEmx2vdy4DpsEYDepf3xlzj1NO4BnYwz5vLceDLJaZNtHpoJSTi
4+nbAkrB7ZyiboKg93EENzaKkvuFO5nWIuU0cuY3L1beg+m88qLEi6UoLohOOe6e/Uk8spW3E
Efresi7aUNiYHfBQtR/BuNzn7954ayVg1hBLzlOt7j671ykAXmCJgJc7otZVYqipU1nP/hRCg
M20c07S/yPKQNVl+AF2Z+1h/WgWv9WM9nS7/vUZsMRThtp9FmvKoDIZbLH/bVUl2ebVNmnsvq
C3wVjd5OVqk25YnHtQMAHZ1DIWBT+HPOieTlzc+dVsTN7bTUhU43M02L3asmL1cPEWTTbW9wT
/syShz8Q56e5XoiXaG4WBNCl5qV43eWSRllZHU+Ckg8NjW1l05RQjErYoyEjubbr4e9IgQiWr
F9fi56/LZfe+K63k3HuRAH4PMZ3azAcpGSpJW7wWBjytt7zBp6xx73hUyDijxM9NLj0JCO+9s
QZya9kiVyH6NlNM8YebcQJqhd/L1meX8mmka9uKwgYpKM0iyOKE0YOmDL/qVbCOTGEsayF/lq
Qv6cDYGf5ef7fMeCPPZOS04WIUBwUhA6w6HSYdzjfO5xj3yU4ZFtll5vEsOZX5z/5XoYZ0+yZ
EHsJ+vwIVSYSfmtfcgIyUDVs6AaiChfJxwyK7Q803N43AcUeY8jtlV3PqK
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 76446
Cc: 76446 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Morgan Smith <morgan.j.smith@HIDDEN> writes:
> --- a/Makefile
> +++ b/Makefile
> @@ -8,7 +8,7 @@ TESTTARGET=3D$(patsubst %.el,%.elc,$(TESTSOURCE))
>
> INFOMANUALS=3Ddebbugs.info debbugs-ug.info
>
> -.PHONY: all build check clean
> +.PHONY: all build check clean checkdoc
> .PRECIOUS: %.elc
>
> %.elc: %.el
> @@ -26,6 +26,9 @@ doc: $(INFOMANUALS)
>
> build: $(TARGET)
>
> +checkdoc: $(SOURCE) $(TESTSOURCE)
> + @$(EMACS) -Q --batch -l test/debbugs-checkdoc-config.el $(foreach file=
,$^,"--eval=3D(checkdoc-file \"$(file)\")")
> +
> check: build $(TESTTARGET)
> @$(EMACS) -Q --batch -L . -L ./test $(foreach file,$(TESTSOURCE), -l $=
(file)) -f ert-run-tests-batch-and-exit
This would be wrong. You don't need to load debbugs-helpers.el (it is
required in *-tests.el) and debbugs-checkdoc-config.el (it isn't related
to ert tests.
> --- /dev/null
> +++ b/test/debbugs-checkdoc-config.el
> + (setq checkdoc-ispell-lisp-words
> + '("ChangeLog" "ChangeLogs" "UTF" "alist" "args"
> + "armstrong" "backend" "bcc" "bugreport" "cdate" "cedet"
> + "coreutils" "cygwin" "debbugs" "debian" "el" "emacs"
> + "etags" "freemail" "fsf" "guix" "gw" "henoch" "hu"
> + "hyperestraier" "keymap" "magit" "magnus" "maint"
> + "maintainer" "maintainer's" "mbox" "mboxes" "minibuffer"
> + "moreinfo" "multibyte" "notabug" "paren" "persistency"
> + "regexp" "rescan" "rgm" "rmail" "severities" "sexp"
> + "solaris" "src" "sublist" "submitter" "submitter's"
> + "subproduct" "subqueries" "subquery" "teardown"
> + "unarchived" "unibyte" "unreproducible" "url" "util"
> + "wishlist" "wontfix" "wsdl" "www" "xsd" "zltuz")))
Same comment here: couldn't it be a ressource file?
And, more general: Could this file transformed into an ert test?
Best regards, Michael.
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.Received: (at 76446) by debbugs.gnu.org; 22 Feb 2025 16:00:05 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 22 11:00:04 2025 Received: from localhost ([127.0.0.1]:56885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tlrv8-0006xO-9Y for submit <at> debbugs.gnu.org; Sat, 22 Feb 2025 11:00:04 -0500 Received: from mout.gmx.net ([212.227.15.18]:44987) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <michael.albinus@HIDDEN>) id 1tlrv5-0006vm-N7 for 76446 <at> debbugs.gnu.org; Sat, 22 Feb 2025 11:00:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1740239993; x=1740844793; i=michael.albinus@HIDDEN; bh=LDt0eNq03eB1AX3+txPjp3Ux5UUFYOGtrgTMHr+RdB8=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=ECnBmdAxhEwrGw2aCyebNPFpiba1HDxbS/FOOH33/7B7byTF49Z4Rh9NaQRFZf8x jOw0Sk0h+yISUcDfVeaCECmLzcHEnpOhnDGHlGZ0B2osNT+PCB4MFxPyBygl4gSib bJ7M3F/Ma6hcn0/tPKA2nGG1fnYpRFvHsWOwMKwKcc8o3+f1dD6Eqbmtjic9D394x +/PiMztYmaZ8FRerxjsEHUG3iy7ThN77ISpYkVIb4vfqTp0kuXD/oisifm9BYr4w3 YndrMRcVgCZmcBDhBwMaCB1OyJ9zbx4cajw2Ox/rBq0oREhb4xLcAguHvDjnb1dVo LghBIRFNlx53NAiDJA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N2mFi-1tK8Np2Vxs-015tBc; Sat, 22 Feb 2025 16:59:53 +0100 From: Michael Albinus <michael.albinus@HIDDEN> To: Morgan Smith <morgan.j.smith@HIDDEN> Subject: Re: bug#76446: [PATCH v2 3/5] tests: Add tests for debbugs-gnu In-Reply-To: <CH3PR84MB342460F7CF9FD5B9347BD72AC5C72@HIDDEN> References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN> <87zfifwlxg.fsf@HIDDEN> <CH3PR84MB342460F7CF9FD5B9347BD72AC5C72@HIDDEN> Date: Sat, 22 Feb 2025 16:59:52 +0100 Message-ID: <87ldtyug07.fsf_-_@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:C1SaGLQIz1FAi0yfn1ZGJTHljMFotgXYp8BIUjaY/XSOGF4Cf4y zSGybioRyZDQzlBkrloh/JpNSU4VQ4vEmiyCD9FHYk7NVAYClpWhrX8PGq9RAJDMdA6yH0F nPn7+u487pqMQPvLAkIgnktWRg7lo+sZAmzhxzWxcPzN5JjqLO4DL9NDZUCDxG9bvyOwJiK 5ie4ohFRo56jXJJ5YFQuw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:kD1S+4xSSRo=;4inTFRoBaxLCwWAR1BwHgYM19cY iRP9XAuXwgXWlaqZn64G/EH124t0nodGl74slPPIpVe1ZlvwaeXZIV3532gku+gARnKkPtVcQ qOwjBpgSPi9L1epWvS7u9tn8ji85LyT3FptVMtruvDQ+vMmwTeWY7EwOoWg7KvHmMXk9dX9b+ TbOw/wPTgGuvUgugczaWY198jHkJVRYlkmUsTQLM/ZORYGhoKPJMaIdILfJuaEcrmlcLUEbta gLNdy1ZsjEqyw0GounbMWGLKPHRN/QrEAjRDGKN3HyXEn6A7GopQtaL/qMAAFivHZ55QMWafk +z59Eun4xC4atYCwwZYSVBSWhZEiNEsnbMmKoBHtzdPu3EQnrG+eKbsI4hQ665J7tcm6MnvEZ H65EWjGXmogRi/f5wt0lc/GsKDpAnKKpjmEiWV7JPO3jOYQZocXKChriD3M+J02uLG11zjeOE djxxGoZhFSu1tnol08LdzkFYXZX9eNCajpDguGBiX81xxDiJZpjPrCy/F9s0SgihP+E+aFdcC laLxxNEfWfsqi+WtL/ji6TQ136vOKaAU1XyrKKgEBSQArxO5mgyAGtMMC8UsJPv0iba/MUzab 3SSoWIudeqSWxFMiuUhpAvTeGn3O86mC+qVZ+gXiaxvySU2WLIZFuxvwzxbWt/VChpS52EjUq pgLQEk4r7V47CMNk/Y9K8F//JbYsqpNlLbeVbRkL77lA0TuGISFAPK35A5GOLUmTxHrIBkmjZ dpwyB9BtHnKxh155MmrIcr20JNRXFxgO0xxFACd7fdMwuL/5WxP0UB8NOkFQnjon9//Xr//+A nDJ+Amycp5XJNYc/cIj5dCx56w8g+iDK+Jwl6H4smaP8HnkSlSfaVN/RtwCsHUAi0f7tblvyD KqE0wLQjL6kexSlsrXLClZnXhTioguHzC5+InTRCswEJqlMmlWnJ74EbDl6ho1aR2zYkNVWcN aDjBOIO0pDOUFTTgmdYeE//tDRjrtQ0gcbXYeNDtWNszPoBml8T+1Tx0tI+7LvkqtPcvuaS/M chdvV9yjtNW3Ion4NDexr3ddBTbYLnYMqpHWxr1p9jwfSPCCuNa54ZeVhSBOPOzdYdGeSuggf LA3hRQl0Hr46yChKHujr99HFINx7Zs/4IHVkuITCE6fH6J/Qkiw1hPrFgtGCxdJS+qHG7QUOx avV652KXpNmMaeuWP0tANCU9EY5ogXOEYluVcBuUvHCKSxxbqPV6c4xmvGjfgdsZqjglnXVyC lj4uU6ao3pKtGdl4MD3nPCbMUVljuTalDAWSFJQyIroOemAWI/dPXh2zYPRPNF4Za8JElsjLy 1t7aE1y1B5maasQEy5Izd7q4RQ0jpqWCbKIjCmzTGIqtWHEu2pfgWDtDR/xvIiea/75muPMF7 Xy3zrbYVqfO/FcxSmILqaGO6r8ayWeIZV4Xr95bYhHilar2HKljsXnHcxX X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76446 Cc: 76446 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Morgan Smith <morgan.j.smith@HIDDEN> writes: >>> +Also test `debbugs-gnu-patches' and `debbugs-gnu-tagged' which are >>> +simple wrappers for `debbugs-gnu-search'." >> >> Nope. They are wrappers of `debbugs-gnu'. > > Oops! You're right. I have removed those tests. Perhaps you can give them own tests? In the futeure? > --- /dev/null > +++ b/test/debbugs-gnu-tests.el > +(require 'debbugs) > +(require 'debbugs-gnu) You don't need to require 'debbugs'; debbugs-gnu does it for you. Best regards, Michael.
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.Received: (at 76446) by debbugs.gnu.org; 22 Feb 2025 15:56:21 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 22 10:56:21 2025 Received: from localhost ([127.0.0.1]:56832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tlrrX-0006SH-FE for submit <at> debbugs.gnu.org; Sat, 22 Feb 2025 10:56:20 -0500 Received: from mout.gmx.net ([212.227.15.15]:56235) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <michael.albinus@HIDDEN>) id 1tlrrU-0006Qz-Q1 for 76446 <at> debbugs.gnu.org; Sat, 22 Feb 2025 10:56:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1740239770; x=1740844570; i=michael.albinus@HIDDEN; bh=znxxC8ISHr2To6Gj/RfZwBU049C43eptp3B/bx9yVsA=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=RTNWMxRAOpIkhKdjEgImrfQXHldOXv9Yx3RwvbyXUxlh0GF/bZnsAqafjBrUnnuM CP0oH2mlE+cA+mT4eKSyu9WdKfB5DEpGQIC1SN1jY2EOp3Q+67GDZHZ+bUT3x0iia U1Y3P96Q7CQs/J75hn83nC4PPK4VB/sia7ytdAOywzXr49r78H7WL/e480zmLdC30 UGTZsrOHGQVu6OImLnzSBj5I9Ho3a6LBM9mQB5ujO6S6RLfIXRBHMcoqaEYwcKG9y 8TEiE8ZdFttc4c1VipxZ14b1cpWT+LVzQEhFQO0iTyxmrcmbuDnGgMBcE1LH2AbPh ebrBwWb6v9kGVMQRVQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M7b2d-1tg5Ul1rDh-001wmT; Sat, 22 Feb 2025 16:56:10 +0100 From: Michael Albinus <michael.albinus@HIDDEN> To: Morgan Smith <morgan.j.smith@HIDDEN> Subject: Re: bug#76446: [PATCH v2 1/5] tests: Move helper and wrapper functions into their own file In-Reply-To: <CH3PR84MB3424C014EA66C2F79FDC1E0AC5C72@HIDDEN> References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN> <874j0ny0pa.fsf@HIDDEN> <CH3PR84MB3424C014EA66C2F79FDC1E0AC5C72@HIDDEN> Date: Sat, 22 Feb 2025 16:56:09 +0100 Message-ID: <87pljaug6e.fsf_-_@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:uJW2ekTOf5W1dMv/u/+U2L7pdWlYgeVYh+xT6WRKKbUBZRNnr8S GMO0JJlSSOZNNhHzmUkeXm/Xv9XcdqRyhcbfozS+Gyo45DdddLvrFZyn+7Rg/wXLaZDu7sm LmeSHqvjq70pBzJj2avu46IlmwJSnLvTdVT7pOIqzRZUmWvfYFuXrFYn+4AE9R7866Lz18f gQCnxLIs5hE2g/JLj6fpg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:GU1S+kRTNZg=;/0x8bELgWlH6dmpXnLfovzwGaAZ YnaeoucpUhOGvu99Axr20H0Ja50IFj9ceabjb3tdGQ1rnkuZUuk4SOiUm8wSLX8g8R477IceX jvV1BGtstVGX1is4X75x13XInfzN2/fzs5RUwrKt7UUqUGY6BjnLEDFSDqTfWcGD2RPjS7gzX G20yS68BBZLIHMlL0b3aaW7dfL05z0b8CW49FULvlyuN/5dRoCRVfLVibFGT3ZD3mIE5oC9fH uF5AbqqjUwob7s8+5gQOIExCtVrcHJfZkTnzHYOIB/tfCkHnM7Waq00f4mWoVsZ8nvgwoSG96 JFKSzOWjOtjBZxe/plih4p0ov/9jd8974zbpaN0jRTWNMb/rkOOWWNivG7njKnOSyWg8NLBeD 2n97UvH40N/009GU3AsrQq0ja5g9qYwKAV7XPn9qR3JV3EpY+MamG4wyZ5DqNyIJLhfwcj/Ys +lcu5chRF7b53m9xN3cHwQfdK69v9mDh0a6ssFOBoILTSITpmc95qupQkzIWbSTllQ935nDEG rJVqHLz1Coq6GdGy4GGKYqUnLyMP8vnmpJVXY+ujmnGZ4iv8ALHNKSgRLXdTwn/RCZ5pbMpem b4D2LFTkOfiTi/W2INQUdOtFsoHUfo9WeKaeWumPYJEGTEYT4jkHgfhCfe2xQvLoUVSAlnp4x lzeBgxc/zjfMYKVCu246uTl7TIdIMIoL7eL8v0zIXpp+DX6wZRKiU9guST4ommnFzQyUqOuDt zOpb4LyyfNq1RchursEL7TKyHWFJeG4LpLU3abvWfXVsjH3oKNgm34PxbOhlXshx3YRca8ER1 0hBmybDAhYftwCu28VNvIeQ41L3MaeSM4qsR2F35dVsIvlOMwzEI910tqQKBjOPiHdUP3GKvc 1nM/2p7Gj5QNDAU2eVk7M7Aowro2hdwBwC/oCeAQYuhwIkCxwQxTEjuhXqi55Gf2MDcN8SBc9 7f3F4XUSNEnJPNlChMOV51lCq1Ice9UnL85rNv3jJIa2xgEiDP5w1hy9shPn7Umu90HQMG0Be ma7tcJy1zss58zV1RHHfwD3WKU9dqSSE4YAPpXvttJ4y7CkpokwHhXrfM2KV2Sh9NFymLp0ML Ldy+9tmfT2ecfaQIYLmT4RBVGAOkJArTtBZwp07ABRwGOdjYGH2LsO5ZnMMOGzdM87hpqNcEK /3oJG6i5yITAO2PoPmi0o+XpLsO83sIxRRliVY6Ot00xZvFnwc/HBnUA8CZlQZji0AUTvriZg k6bLjaJb4az4VkPzqG2p036yGn1DlmKbNHMgNFzlDLolVkrlRClhqe6y5tzK9qF7fHfiXrALU lTlJv/r15xDwBdzcnM0BoywtQr0tj48eA55YE2gavNzgOC6uet+6hZpcZpDpiahB6cD04GWTb X2gJOXiqCYwuHR5CeqCC0/6VXLFpEosAPpxbv1CHRCq1jklnhOVtdEgIjx X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76446 Cc: 76446 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Morgan Smith <morgan.j.smith@HIDDEN> writes: >> We might be better with >> >> --8<---------------cut here---------------start------------->8--- >> @$(EMACS) -Q --batch -L . -L ./test -l $(TESTSOURCE) -f ert-run-tests-batch-and-exit >> --8<---------------cut here---------------end--------------->8--- >> > > I did the '-L ./test' part but I kept the foreach. > > Without the foreach the command looks like "... -l file1.el file2.el > file3.el ..." and emacs only actually loads the first file. The command > needs to look like "... -l file1.el -l file2.el -l file3.el ..." My point is, that we have only the make target 'check', which runs all ert tests located in different files. But I would also like to run only the tests in, say for example, debbugs-tests.el. So we need an own target for every *-tests.el file. >>> --- /dev/null >>> +++ b/test/debbugs-test-helpers.el >>> @@ -0,0 +1,146 @@ >>> +(defconst debbugs-test--bug-status-soap-return >>> +(defconst debbugs-test--bug-status >> >> Perhaps we should move these data into an ert-resource file (or two). >> > > I read the info manual and source code pertaining to 'ert-resource' and > I fail to see any benefit from using it. Both defconsts contain data. Those data belong into a ressource file, and shall be read from there. Something like --8<---------------cut here---------------start------------->8--- ;; -*- lisp-data -*- (((cache_time . 5000) (source . "unknown") (unarchived) (keywords "patch") (blocks) (pending . "done") (severity . "normal") (done . "Michael Albinus <michael.albinus@HIDDEN>") (location . "archive") (log_modified . 1689593050) (subject . "[PATCH 0/4] debbugs improvements") (last_modified . 1689593050) (found) (tags "patch") (package "emacs") (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>") (archived . t) (blockedby) (affects) (mergedwith) (summary) (date . 1686745022) (fixed_versions) (id . 64064) (fixed) (found_date) (forwarded) (msgid . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>") (owner) (found_versions) (fixed_date) (bug_num . 64064))) --8<---------------cut here---------------end--------------->8--- With this, we could reuse tests with the sam logic, but different data files. In the future. > --- /dev/null > +++ b/test/debbugs-test-helpers.el > +(defconst debbugs-test--bug-status-soap-return > + '(((item > + (key . 64064) > + (value > + (package . "emacs") (found_date) (last_modified . 1689593050) > + (affects) (date . 1686745022) (fixed_versions) > + (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>") > + (blocks) (archived . 1) (found) (unarchived) (tags . "patch") > + (severity . "normal") (location . "archive") (owner) (fixed) > + (blockedby) (pending . "done") (keywords . "patch") (id . 64064) > + (found_versions) (mergedwith) (summary) (forwarded) > + (log_modified . 1689593050) > + (done . "Michael Albinus <michael.albinus@HIDDEN>") > + (source . "unknown") > + (msgid > + . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>") > + (bug_num . 64064) (subject . "[PATCH 0/4] debbugs improvements") > + (fixed_date))))) > + "Mock result from `soap-invoke' for bug 64064.") Read from ressource file. > +(defconst debbugs-test--bug-status > + '(((cache_time . 5000) (source . "unknown") (unarchived) > + (keywords "patch") (blocks) (pending . "done") (severity . "normal") > + (done . "Michael Albinus <michael.albinus@HIDDEN>") (location . "archive") > + (log_modified . 1689593050) (subject . "[PATCH 0/4] debbugs improvements") > + (last_modified . 1689593050) (found) (tags "patch") (package "emacs") > + (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>") (archived . t) > + (blockedby) (affects) (mergedwith) (summary) (date . 1686745022) > + (fixed_versions) (id . 64064) (fixed) (found_date) (forwarded) > + (msgid > + . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>") > + (owner) (found_versions) (fixed_date) (bug_num . 64064))) > + "Mock result from `debbugs-get-status' for bug 64064.") Read from ressource file.
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.
Received: (at 76446) by debbugs.gnu.org; 21 Feb 2025 18:21:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 21 13:21:00 2025
Received: from localhost ([127.0.0.1]:35423 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tlXdx-0007f7-JF
for submit <at> debbugs.gnu.org; Fri, 21 Feb 2025 13:21:00 -0500
Received: from mail-co1nam11olkn2085.outbound.protection.outlook.com
([40.92.18.85]:23584 helo=NAM11-CO1-obe.outbound.protection.outlook.com)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <morgan.j.smith@HIDDEN>)
id 1tlXdt-0007dn-Aa
for 76446 <at> debbugs.gnu.org; Fri, 21 Feb 2025 13:20:55 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=k4h33HLogs57qBAvOuk7w3qIrF78HxqHLhibg5R42biNnSCWUu3JPksb18bYCIkKCTqBcAWEgOLBaVJYgFlyZ8B+ud4OvT52+gC7HqYsTnaqyZ7d6KpxEkVfgRok+w+oifR3/UsEP2BmVHHrR6SWsaze6x+FUJ/aJDIk+jvSA3lExTRLNC4NOXv9pzCileaLpH3ioCjzYJPq6pw7SwCnoPC1q6aRd6Puk/NIu9O/Z3SVahmQ+hHRlujji673h6LCn8hDPsUcsTmgjHWhwd+SXv0CXZYW4p0c5i/vCTKjGH9PqDOXche/ruo4/vLYDmNfyZXNJ0banK9EHPq43nzq2Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=nj5dBumUuVQs5ygkeWMB+ELIO2IyW+RLkFn5ew7MJIM=;
b=MMwO2SJGvjfZNc8sXJSa16usP171MD8A33cjGlARfPKuA2NesSwYKG3jWNRGDx5TlSIyPsO8vojzLKLuq+3NennFffEJAWmHY2WNQxVk0lj+JZLf7DvW9mj3dlOltXLuuWeNOk9cCnVieYJEmzbwmC+69meVmgzDjSfYuVlxTv2RNF9uSAYsn2rkzl1GPkyyWDuYqYuExIgRneWqpmjZJy7KKw5tuVJMJfIbdBfFThmNjr8RC3VrgyUqa5c7XJpE8QE8FyihvZEF8IciWYFO5aULubai914mie81u9ykf1L9jGai6uTT3JwDg9UmwypgQyTgXZDiXqIMuHdGGAdnDg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=nj5dBumUuVQs5ygkeWMB+ELIO2IyW+RLkFn5ew7MJIM=;
b=Rz1b+T4ROyavF3qJXx9av4bqAlDp8oIpheti3o7mZduuN5vEB3nEe0+IBUFnIXUpHF0d0uF4AZL+FLn1lbMJvULasqImAWVgPbRs+LdkDzlEeOS5MxP4lvmUgOF7OE6XNY0lxHBsgex+cfcVvVb9jz8aVnTxdH8/ez7zLHe+aFr8UxlcPa90bmkTky67tqaOMwrJrzd5auxpVBEnxljhJJHdBZrsSe9hg4f5scSSQF7KJzA0jon/IZHhSMQbrqM3gpsRDm3A7hX3HYcv29SpdC/9stUe5Pd6Zgx4h/aoZqenLazIWBTk6KRvrer0h8SXdvIpNjU1DLm2Qvw/Tojs7g==
Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17)
by PH8PR84MB3212.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:510:1c4::7)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.14; Fri, 21 Feb
2025 18:20:45 +0000
Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
([fe80::5c77:7a58:48ed:9aef]) by CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
([fe80::5c77:7a58:48ed:9aef%4]) with mapi id 15.20.8466.015; Fri, 21 Feb 2025
18:20:45 +0000
From: Morgan Smith <morgan.j.smith@HIDDEN>
To: Michael Albinus <michael.albinus@HIDDEN>
Subject: Re: bug#76446: [Patch Debbugs] Infrastructure Improvements
In-Reply-To: <87bjuvy17p.fsf@HIDDEN> (Michael Albinus's message of "Fri, 21
Feb 2025 12:41:14 +0100")
References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN>
<87bjuvy17p.fsf@HIDDEN>
X-Hashcash: 1:20:250221:76446 <at> debbugs.gnu.org::dkQ161snrcGnvVvr:0Hio
X-Hashcash: 1:20:250221:michael.albinus@HIDDEN::mKW5LwfY7bxg33d1:/LP
Date: Fri, 21 Feb 2025 13:20:41 -0500
Message-ID: <CH3PR84MB3424807016C1C6E6EBCD08E6C5C72@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
Content-Type: multipart/mixed; boundary="=-=-="
X-ClientProxiedBy: YQBPR01CA0020.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01::28)
To CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
(2603:10b6:610:1c4::17)
X-Microsoft-Original-Message-ID: <87h64ndurq.fsf@HIDDEN>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CH3PR84MB3424:EE_|PH8PR84MB3212:EE_
X-MS-Office365-Filtering-Correlation-Id: 1983076f-66bd-430e-3860-08dd52a4756a
X-Microsoft-Antispam: BCL:0;
ARA:14566002|461199028|19110799003|6092099012|7092599003|15080799006|8060799006|5072599009|3412199025|440099028|13095399003;
X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?aZzD/PIdC5vYW2cIK2tZTq002QnzzveyUOE/g4wad35r2S6e5tlRXmBznB/+?=
=?us-ascii?Q?ycf4PCD+mybyaWu/c6fYyI+xEmUtqalazRaIiWBjkPW8BxnQlmxIlEONQbAX?=
=?us-ascii?Q?ck+gxIhDRyZZnVux19mYOkdMPR7h4C2EU2SsqqnJosCa2MI/q9zzuLJCzwaY?=
=?us-ascii?Q?CdlqacDW4wPf0BocE8LdOAqB5vgBbC+F9SdN0cns5/u3wgma+muAudGtgMCh?=
=?us-ascii?Q?QnCA3WwPfQQBBe+2L9+Ky0tJz+wHhSlSsum8+GbWS2KYFuE3dJLdI1fNmcaF?=
=?us-ascii?Q?6n0Dh+tYWYos29DnOtvo5mdMATv+MbclSIzGe6m9f7qY4DlPNSGU7mbWIsKr?=
=?us-ascii?Q?QG8ev/7NqBA9tH9Ww11caF3ufE1Au8Qisi6qArySggzdB5fS+R2flr2fuS03?=
=?us-ascii?Q?sTJOW0vhzWlT5CVVAAJqeq4FVQuJUpLTUJ/n/zbUx6FKAgkNBDNTTaSVnIk8?=
=?us-ascii?Q?pHm3026ibsecHwH7mir3vA7lxgh1CPMucGyGTTXVVkWtgB3+4XINKm5lpdOy?=
=?us-ascii?Q?OOvnbjNPqPqCYr0rr03xkfha3bb4qKQfg6LewtW4xuHHiIR9WMq3Mx/dHF31?=
=?us-ascii?Q?smuhnhmB0RcPti9lP51NT2Mj72l9bDp10KPEBPrXiW6NlOwk5GORf6qblM/Q?=
=?us-ascii?Q?ulR5c5fuzPQS5boWtC9tDqrk5/NtyllEC3XRbZ0Lj1PAq4IGbclVHh3gqRG2?=
=?us-ascii?Q?BmIzMeXCpijbwRMudSA7LN9yzFpuVhge83R2WsnSxOo4RjaJeTgAjdo8vmGA?=
=?us-ascii?Q?1s8z0tCVeM1C16q0436DbuWBWWkAI65FJlOpKZBUGvblDvNrm4PbC/Vn9NAl?=
=?us-ascii?Q?f9zRbO4ATpXmnNVsI4h+sCmD+YI3LiABGagYLyLn5S/8C53Hygqyy65t15yA?=
=?us-ascii?Q?zJeec9+F1lv6xfcTlqsJjGL00C1AuH5FJetxB9Te21iBkUohqcANgwsjCj2v?=
=?us-ascii?Q?MDEqS1YruS2aoN4WKHeY0sMFgxpF56+xQyFspPUWI8yICW7z+cfIFwgFtOIQ?=
=?us-ascii?Q?mpsxJ2cuLxkTT9iE5yHiFtjgU+xD2RSAtW5ib1S7l6ixgbJnZOC0iBAV5Pjy?=
=?us-ascii?Q?JedjF9dB9/lrN3/QW6HO9KjWl0JlMNozC17xydMCkJyp4oUq+pXL0KJpjlP6?=
=?us-ascii?Q?UIyfzhoTpySlIDJGh3ILRyffxw2aXAEJ/g=3D=3D?=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uTr9WckdUi5XezzpF1w+wQp6NxBuNeW8jndfldYdwlj6WYL0psHAXnZ5mvOG?=
=?us-ascii?Q?fPkYdQkel8uE6Udbb2Kh80rbfgXZsqUnlcKnajdsEEMFEzwrhrz5+PvWt4Fx?=
=?us-ascii?Q?2zXBsznw+rga8pNosJ8wxRzGd3uP91+PrgbuH7GMPkfQzu2JKO8Mn2aoojgW?=
=?us-ascii?Q?GF/ci7AMoAlc2p2Fi2M/upq/gRU6DHANd3QE72G0Xv2Enh6js10DrQ9T4uPr?=
=?us-ascii?Q?3LPEenBuqFQE5RXaGPb0F3q5VGVuLH6CEK0iYRl7Sbne/cKHgchVSn+/AkTm?=
=?us-ascii?Q?4sTDPmXxPnvtAsV7/FioKagEn94vk8T8f8yVtRQReJ2URbpO6MPtQD5UtLv+?=
=?us-ascii?Q?/PBEPTsgvioPsUhRRPl6ROPpMF3Vk7OweqWwZjLo76Awwvs3Dso26UkM2hOU?=
=?us-ascii?Q?h9o+fnpPEAXOsP2n6u6slgnDwTlA1o2cRF1ad0PnEgXyKVpU2v6taYZmB3JI?=
=?us-ascii?Q?I/r9cGFKHDnMO63O5Sy9aLTWInk2tKk559mtV9UuSDL/WZc4Sg9smuKwe+gD?=
=?us-ascii?Q?YlgNomBviqcCzwH6+7sSDMwOZ2A2sUDT0Bm7NgUI/GJnZALzH42IPpnheK71?=
=?us-ascii?Q?Zsxyw9iUj/Vk4u8QIK8ZlxlVCj9Ueo6UXQHJeyJP6xJXX1xdMFsvPqXRfc75?=
=?us-ascii?Q?wu+5i4qHwRtJN5kt9qTXIb8MN/2m6jKAXAhGuH/JhvWa3zZIgJCasrzDXcpm?=
=?us-ascii?Q?idPu3McU/xKMaNvAnzlyFLlgqu3XsBPflG5mUecne/ATIiOZYZPM00jHyaNN?=
=?us-ascii?Q?kgEnw+FxLCico8zA/eVbofaMNop6WKLPjOP/8J/X9VCTw9aLn/j6D4E+WAC/?=
=?us-ascii?Q?qejykq3sEaLag+oWdgd5PgCLBN4lWIxHYHyAjF7P2NbUITUkpCwGzfBzfkwn?=
=?us-ascii?Q?fQ/IILOtWajAo00u3p2kt9+yvVMM2o04whtq+U1f7KmsMen0CqEifdFVnYxh?=
=?us-ascii?Q?P9PvNdF4BhQ4OYN0KC2MWzyEXmtkheu8jlNx5p8v6WAra7Yv/Q5XNNhjpmlH?=
=?us-ascii?Q?BlVZSa3aJXvHDWUnVllTTjgctzIxcG0kk7Y6VXV1pEdALOtec9vcFt6uN5vm?=
=?us-ascii?Q?8oaJi+qTiTRf8IefNdZT3IsSUNwuBG+iTxpuzXiKkS53njxDBWNm5XciB8dN?=
=?us-ascii?Q?LZKzmeESv06PXRGMcAMYTyd0J6MsiSsCzNkULzmZyPoFC31aPlcNWI7IHyrI?=
=?us-ascii?Q?gSzc+tWqOGPk+0GtBFf5jXltRlY1snbZmj6VBn+U66aC+dLYs1OY9l0NpRR1?=
=?us-ascii?Q?+Yx1+eW4ITlvorIyh8CF?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1983076f-66bd-430e-3860-08dd52a4756a
X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2025 18:20:45.6835 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR84MB3212
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 76446
Cc: 76446 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain
Michael Albinus <michael.albinus@HIDDEN> writes:
> Morgan Smith <Morgan.J.Smith@HIDDEN> writes:
>
>> Hello!
>
> Hi Morgan,
>
>> Nothing too exciting in this series. Just adjusting things so we can
>> split the tests into multiple files. Also adding a makefile target to
>> run the "checkdoc" stuff with the spell checker enabled.
>
> Thanks for this! I'm happy that you's started to provide also a
> debbugs-gnu-tests.el file.
>
> I didn't test the patches yet, starting with my comments on the code
> reading first. See next messages.
>
Thanks for reviewing my patches! I appreciate the insightful comments
you've provided.
I've attached the relevant patches to the other email threads but I'll
dump them all in this email as well in case that's easier. You'll
notice I've also sneakily included an extra 5th patch here :).
>> Thanks,
>>
>> Morgan
>
> Best regards, Michael.
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=v2-0001-tests-Move-helper-and-wrapper-functions-into-thei.patch
From 310038c998bfcaddebd4144d6d37da6a4d4f6aeb Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Fri, 21 Feb 2025 12:52:03 -0500
Subject: [PATCH v2 1/5] tests: Move helper and wrapper functions into their
own file
* test/debbugs-test-helpers.el: New file.
* test/debbugs-tests.el: Move test helper and wrapper functions into the new
file and require it.
* Makefile(check): Load all files in the test directory.
---
Makefile | 5 +-
test/debbugs-test-helpers.el | 146 +++++++++++++++++++++++++++++++++++
test/debbugs-tests.el | 113 +--------------------------
3 files changed, 151 insertions(+), 113 deletions(-)
create mode 100644 test/debbugs-test-helpers.el
diff --git a/Makefile b/Makefile
index a7b6b0c7f3..eec1c65a14 100644
--- a/Makefile
+++ b/Makefile
@@ -14,6 +14,9 @@ INFOMANUALS=debbugs.info debbugs-ug.info
%.elc: %.el
@$(EMACS) -Q -batch -L . -f batch-byte-compile $<
+test/%.elc: test/%.el
+ @$(EMACS) -Q -batch -L . -L ./test -f batch-byte-compile $<
+
%.info: %.texi
$(MAKEINFO) --error-limit=0 --no-split $< -o $@
@@ -24,7 +27,7 @@ doc: $(INFOMANUALS)
build: $(TARGET)
check: build $(TESTTARGET)
- @$(EMACS) -Q --batch -L . -l $(TESTSOURCE) -f ert-run-tests-batch-and-exit
+ @$(EMACS) -Q --batch -L . -L ./test $(foreach file,$(TESTSOURCE), -l $(file)) -f ert-run-tests-batch-and-exit
clean:
-rm -f $(TARGET) $(TESTTARGET) $(INFOMANUALS)
diff --git a/test/debbugs-test-helpers.el b/test/debbugs-test-helpers.el
new file mode 100644
index 0000000000..f98bab40ed
--- /dev/null
+++ b/test/debbugs-test-helpers.el
@@ -0,0 +1,146 @@
+;;; debbugs-test-helpers.el --- Helpers for testing debbugs -*- lexical-binding: t; -*-
+
+;; Copyright (C) 2024-2025 Free Software Foundation, Inc.
+
+;; Author: Morgan Smith <Morgan.J.Smith@HIDDEN>
+;; Package: debbugs
+
+;; This file is not part of GNU Emacs.
+
+;; This program is free software: you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; This program is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;; Please ensure tests don't actually make network calls.
+
+;;; Code:
+
+(require 'debbugs)
+
+;;; Helper Data:
+
+;; Generated using this:
+;; (soap-invoke debbugs-wsdl debbugs-port "get_status" [64064])
+(defconst debbugs-test--bug-status-soap-return
+ '(((item
+ (key . 64064)
+ (value
+ (package . "emacs") (found_date) (last_modified . 1689593050)
+ (affects) (date . 1686745022) (fixed_versions)
+ (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>")
+ (blocks) (archived . 1) (found) (unarchived) (tags . "patch")
+ (severity . "normal") (location . "archive") (owner) (fixed)
+ (blockedby) (pending . "done") (keywords . "patch") (id . 64064)
+ (found_versions) (mergedwith) (summary) (forwarded)
+ (log_modified . 1689593050)
+ (done . "Michael Albinus <michael.albinus@HIDDEN>")
+ (source . "unknown")
+ (msgid
+ . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>")
+ (bug_num . 64064) (subject . "[PATCH 0/4] debbugs improvements")
+ (fixed_date)))))
+ "Mock result from `soap-invoke' for bug 64064.")
+
+;; Generated using this:
+;; (debbugs-get-status 64064)
+(defconst debbugs-test--bug-status
+ '(((cache_time . 5000) (source . "unknown") (unarchived)
+ (keywords "patch") (blocks) (pending . "done") (severity . "normal")
+ (done . "Michael Albinus <michael.albinus@HIDDEN>") (location . "archive")
+ (log_modified . 1689593050) (subject . "[PATCH 0/4] debbugs improvements")
+ (last_modified . 1689593050) (found) (tags "patch") (package "emacs")
+ (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>") (archived . t)
+ (blockedby) (affects) (mergedwith) (summary) (date . 1686745022)
+ (fixed_versions) (id . 64064) (fixed) (found_date) (forwarded)
+ (msgid
+ . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>")
+ (owner) (found_versions) (fixed_date) (bug_num . 64064)))
+ "Mock result from `debbugs-get-status' for bug 64064.")
+
+;;; Helper Functions:
+
+(defvar debbugs-test--soap-operation-name nil)
+(defvar debbugs-test--soap-parameters nil)
+(defun debbugs-test--soap-invoke-internal
+ (callback _cbargs _wsdl _service operation-name &rest parameters)
+ "Over-ride for testing."
+ (setq debbugs-test--soap-operation-name operation-name)
+ (setq debbugs-test--soap-parameters parameters)
+ (let ((return
+ (cond ((string-equal operation-name "get_status")
+ debbugs-test--bug-status-soap-return)
+ ((string-equal operation-name "get_usertag")
+ '(((hi))))
+ (t '((0))))))
+ (if callback
+ (progn
+ (funcall callback return)
+ nil)
+ return)))
+
+(defun debbugs-test--override-float-time (func &rest rest)
+ "Override `float-time' for FUNC with args REST."
+ (cl-letf (((symbol-function #'float-time)
+ (lambda (&optional _specified-time) 5000)))
+ (apply func rest)))
+
+(defun debbugs-test--setup ()
+ "Mock network and time functions.
+These mock functions are needed to make the tests reproducible."
+ (setq debbugs-test--soap-operation-name nil)
+ (setq debbugs-test--soap-parameters nil)
+
+ (add-function
+ :override (symbol-function #'soap-invoke-internal)
+ #'debbugs-test--soap-invoke-internal)
+
+ (add-function
+ :around (symbol-function #'debbugs-get-cache)
+ #'debbugs-test--override-float-time)
+
+ (add-function
+ :around (symbol-function #'debbugs-put-cache)
+ #'debbugs-test--override-float-time))
+
+(defun debbugs-test--teardown ()
+ "Restore functions to as they where before."
+ (setq debbugs-test--soap-operation-name nil)
+ (setq debbugs-test--soap-parameters nil)
+
+ (remove-function
+ (symbol-function #'soap-invoke-internal)
+ #'debbugs-test--soap-invoke-internal)
+
+ (remove-function
+ (symbol-function #'debbugs-get-cache)
+ #'debbugs-test--override-float-time)
+
+ (remove-function
+ (symbol-function #'debbugs-put-cache)
+ #'debbugs-test--override-float-time))
+
+(defmacro ert-deftest--debbugs (name args docstring &rest body)
+ "The same as `ert-deftest' but runs setup and teardown functions."
+ (declare
+ (doc-string 3)
+ (indent 2))
+ `(ert-deftest ,name ,args ,docstring
+ (debbugs-test--setup)
+ ,@body
+ (debbugs-test--teardown)))
+
+
+(provide 'debbugs-test-helpers)
+
+;;; debbugs-test-helpers.el ends here
diff --git a/test/debbugs-tests.el b/test/debbugs-tests.el
index f3abea2837..da1b9dffe6 100644
--- a/test/debbugs-tests.el
+++ b/test/debbugs-tests.el
@@ -27,118 +27,7 @@
;;; Code:
(require 'debbugs)
-
-;;; Helper Data:
-
-;; Generated using this:
-;; (soap-invoke debbugs-wsdl debbugs-port "get_status" [64064])
-(defconst debbugs-test--bug-status-soap-return
- '(((item
- (key . 64064)
- (value
- (package . "emacs") (found_date) (last_modified . 1689593050)
- (affects) (date . 1686745022) (fixed_versions)
- (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>")
- (blocks) (archived . 1) (found) (unarchived) (tags . "patch")
- (severity . "normal") (location . "archive") (owner) (fixed)
- (blockedby) (pending . "done") (keywords . "patch") (id . 64064)
- (found_versions) (mergedwith) (summary) (forwarded)
- (log_modified . 1689593050)
- (done . "Michael Albinus <michael.albinus@HIDDEN>")
- (source . "unknown")
- (msgid
- . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>")
- (bug_num . 64064) (subject . "[PATCH 0/4] debbugs improvements")
- (fixed_date)))))
- "Mock result from `soap-invoke' for bug 64064.")
-
-;; Generated using this:
-;; (debbugs-get-status 64064)
-(defconst debbugs-test--bug-status
- '(((cache_time . 5000) (source . "unknown") (unarchived)
- (keywords "patch") (blocks) (pending . "done") (severity . "normal")
- (done . "Michael Albinus <michael.albinus@HIDDEN>") (location . "archive")
- (log_modified . 1689593050) (subject . "[PATCH 0/4] debbugs improvements")
- (last_modified . 1689593050) (found) (tags "patch") (package "emacs")
- (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>") (archived . t)
- (blockedby) (affects) (mergedwith) (summary) (date . 1686745022)
- (fixed_versions) (id . 64064) (fixed) (found_date) (forwarded)
- (msgid
- . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>")
- (owner) (found_versions) (fixed_date) (bug_num . 64064)))
- "Mock result from `debbugs-get-status' for bug 64064.")
-
-;;; Helper Functions:
-
-(defvar debbugs-test--soap-operation-name nil)
-(defvar debbugs-test--soap-parameters nil)
-(defun debbugs-test--soap-invoke-internal
- (callback _cbargs _wsdl _service operation-name &rest parameters)
- "Over-ride for testing."
- (setq debbugs-test--soap-operation-name operation-name)
- (setq debbugs-test--soap-parameters parameters)
- (let ((return
- (cond ((string-equal operation-name "get_status")
- debbugs-test--bug-status-soap-return)
- ((string-equal operation-name "get_usertag")
- '(((hi))))
- (t '((0))))))
- (if callback
- (progn
- (funcall callback return)
- nil)
- return)))
-
-(defun debbugs-test--override-float-time (func &rest rest)
- "Override `float-time' for FUNC with args REST."
- (cl-letf (((symbol-function #'float-time)
- (lambda (&optional _specified-time) 5000)))
- (apply func rest)))
-
-(defun debbugs-test--setup ()
- "Mock network and time functions.
-These mock functions are needed to make the tests reproducible."
- (setq debbugs-test--soap-operation-name nil)
- (setq debbugs-test--soap-parameters nil)
-
- (add-function
- :override (symbol-function #'soap-invoke-internal)
- #'debbugs-test--soap-invoke-internal)
-
- (add-function
- :around (symbol-function #'debbugs-get-cache)
- #'debbugs-test--override-float-time)
-
- (add-function
- :around (symbol-function #'debbugs-put-cache)
- #'debbugs-test--override-float-time))
-
-(defun debbugs-test--teardown ()
- "Restore functions to as they where before."
- (setq debbugs-test--soap-operation-name nil)
- (setq debbugs-test--soap-parameters nil)
-
- (remove-function
- (symbol-function #'soap-invoke-internal)
- #'debbugs-test--soap-invoke-internal)
-
- (remove-function
- (symbol-function #'debbugs-get-cache)
- #'debbugs-test--override-float-time)
-
- (remove-function
- (symbol-function #'debbugs-put-cache)
- #'debbugs-test--override-float-time))
-
-(defmacro ert-deftest--debbugs (name args docstring &rest body)
- "The same as `ert-deftest' but runs setup and teardown functions."
- (declare
- (doc-string 3)
- (indent 2))
- `(ert-deftest ,name ,args ,docstring
- (debbugs-test--setup)
- ,@body
- (debbugs-test--teardown)))
+(require 'debbugs-test-helpers)
;;; Tests:
--
2.48.1
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=v2-0002-tests-Use-unwind-protect-to-ensure-test-cleanup-a.patch
From 1f59c38fb149ec8b5716e89135e9d2fb46c687d9 Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Fri, 21 Feb 2025 12:47:28 -0500
Subject: [PATCH v2 2/5] tests: Use 'unwind-protect' to ensure test cleanup
always occurs
* test/debbugs-test-helpers.el(ert-deftest--debbugs): Use 'unwind-protect'.
---
test/debbugs-test-helpers.el | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/test/debbugs-test-helpers.el b/test/debbugs-test-helpers.el
index f98bab40ed..7ea6f00dce 100644
--- a/test/debbugs-test-helpers.el
+++ b/test/debbugs-test-helpers.el
@@ -136,9 +136,11 @@ These mock functions are needed to make the tests reproducible."
(doc-string 3)
(indent 2))
`(ert-deftest ,name ,args ,docstring
- (debbugs-test--setup)
- ,@body
- (debbugs-test--teardown)))
+ (unwind-protect
+ (progn
+ (debbugs-test--setup)
+ ,@body)
+ (debbugs-test--teardown))))
(provide 'debbugs-test-helpers)
--
2.48.1
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=v2-0003-tests-Add-tests-for-debbugs-gnu.patch
From 3bd34242bffce78a908ca66ff1073e304d185fda Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Fri, 21 Feb 2025 12:52:24 -0500
Subject: [PATCH v2 3/5] tests: Add tests for debbugs-gnu
* test/debbugs-gnu-tests.el: New file.
---
test/debbugs-gnu-tests.el | 47 +++++++++++++++++++++++++++++++++++++++
1 file changed, 47 insertions(+)
create mode 100644 test/debbugs-gnu-tests.el
diff --git a/test/debbugs-gnu-tests.el b/test/debbugs-gnu-tests.el
new file mode 100644
index 0000000000..04c445e43b
--- /dev/null
+++ b/test/debbugs-gnu-tests.el
@@ -0,0 +1,47 @@
+;;; debbugs-gnu-tests.el --- tests for debbugs-gnu.el -*- lexical-binding: t; -*-
+
+;; Copyright (C) 2025 Free Software Foundation, Inc.
+
+;; Author: Morgan Smith <Morgan.J.Smith@HIDDEN>
+;; Package: debbugs
+
+;; This file is not part of GNU Emacs.
+
+;; This program is free software: you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; This program is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;; Please ensure tests don't actually make network calls.
+
+;;; Code:
+
+(require 'debbugs)
+(require 'debbugs-gnu)
+(require 'debbugs-test-helpers)
+
+;;; Tests:
+
+(ert-deftest--debbugs debbugs-test-debbugs-gnu-search ()
+ "Test `debbugs-gnu-search'."
+ (cl-letf (((symbol-function #'debbugs-gnu)
+ #'list))
+ (should
+ (equal '(nil ("guix" "guix-patches") nil)
+ (debbugs-gnu-search "frogs" '((pending . "pending")) nil '("guix" "guix-patches") nil)))
+ (should (equal debbugs-gnu-current-query '((phrase . "frogs"))))
+ (should (equal debbugs-gnu-current-filter '((pending . "pending"))))))
+
+(provide 'debbugs-gnu-tests)
+
+;;; debbugs-gnu-tests.el ends here
--
2.48.1
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=v2-0004-Makefile-Add-target-to-run-checkdoc-on-all-files.patch
From 9d6fc20715ae9a13a82811bf7b3b3469e060bd45 Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Fri, 21 Feb 2025 12:52:35 -0500
Subject: [PATCH v2 4/5] Makefile: Add target to run checkdoc on all files
* Makefile: Add target to run checkdoc on all files.
* test/debbugs-checkdoc-config.el: New file.
---
Makefile | 5 +++-
test/debbugs-checkdoc-config.el | 50 +++++++++++++++++++++++++++++++++
2 files changed, 54 insertions(+), 1 deletion(-)
create mode 100644 test/debbugs-checkdoc-config.el
diff --git a/Makefile b/Makefile
index eec1c65a14..8ed6a917fe 100644
--- a/Makefile
+++ b/Makefile
@@ -8,7 +8,7 @@ TESTTARGET=$(patsubst %.el,%.elc,$(TESTSOURCE))
INFOMANUALS=debbugs.info debbugs-ug.info
-.PHONY: all build check clean
+.PHONY: all build check clean checkdoc
.PRECIOUS: %.elc
%.elc: %.el
@@ -26,6 +26,9 @@ doc: $(INFOMANUALS)
build: $(TARGET)
+checkdoc: $(SOURCE) $(TESTSOURCE)
+ @$(EMACS) -Q --batch -l test/debbugs-checkdoc-config.el $(foreach file,$^,"--eval=(checkdoc-file \"$(file)\")")
+
check: build $(TESTTARGET)
@$(EMACS) -Q --batch -L . -L ./test $(foreach file,$(TESTSOURCE), -l $(file)) -f ert-run-tests-batch-and-exit
diff --git a/test/debbugs-checkdoc-config.el b/test/debbugs-checkdoc-config.el
new file mode 100644
index 0000000000..d09b1adfe5
--- /dev/null
+++ b/test/debbugs-checkdoc-config.el
@@ -0,0 +1,50 @@
+;;; debbugs-checkdoc-config.el --- Configuration for running checkdoc on debbugs -*- lexical-binding: t; -*-
+
+;; Copyright (C) 2025 Free Software Foundation, Inc.
+
+;; Author: Morgan Smith <Morgan.J.Smith@HIDDEN>
+;; Package: debbugs
+
+;; This file is not part of GNU Emacs.
+
+;; This program is free software: you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; This program is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;;; Code:
+
+(defvar checkdoc-package-keywords-flag)
+(defvar checkdoc-spellcheck-documentation-flag)
+(defvar checkdoc-ispell-lisp-words)
+
+(with-eval-after-load "checkdoc"
+ (setq checkdoc-package-keywords-flag t)
+ (setq checkdoc-spellcheck-documentation-flag t)
+ (setq checkdoc-ispell-lisp-words
+ '("ChangeLog" "ChangeLogs" "UTF" "alist" "args"
+ "armstrong" "backend" "bcc" "bugreport" "cdate" "cedet"
+ "coreutils" "cygwin" "debbugs" "debian" "el" "emacs"
+ "etags" "freemail" "fsf" "guix" "gw" "henoch" "hu"
+ "hyperestraier" "keymap" "magit" "magnus" "maint"
+ "maintainer" "maintainer's" "mbox" "mboxes" "minibuffer"
+ "moreinfo" "multibyte" "notabug" "paren" "persistency"
+ "regexp" "rescan" "rgm" "rmail" "severities" "sexp"
+ "solaris" "src" "sublist" "submitter" "submitter's"
+ "subproduct" "subqueries" "subquery" "teardown"
+ "unarchived" "unibyte" "unreproducible" "url" "util"
+ "wishlist" "wontfix" "wsdl" "www" "xsd" "zltuz")))
+
+(provide 'debbugs-checkdoc-config)
+
+;;; debbugs-checkdoc-config.el ends here
--
2.48.1
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=v2-0005-tests-Support-older-Emacs-sorting-conventions.patch
From db6e63b75a576bdebbb6800c5afd477886e4bcf9 Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Fri, 21 Feb 2025 12:49:04 -0500
Subject: [PATCH v2 5/5] tests: Support older Emacs sorting conventions
* test/debbugs-tests.el(debbugs-test-get-status): Call sort with two arguments
to avoid errors on older versions of emacs (such as version 29.4).
---
test/debbugs-tests.el | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/test/debbugs-tests.el b/test/debbugs-tests.el
index da1b9dffe6..e0479cd811 100644
--- a/test/debbugs-tests.el
+++ b/test/debbugs-tests.el
@@ -64,15 +64,20 @@
(ert-deftest--debbugs debbugs-test-get-status ()
"Test \"get_status\"."
- (should (equal (sort (car (debbugs-get-status 64064)))
- (sort (car debbugs-test--bug-status))))
+ ;; eval-and-compile gets rid of ridiculous warning:
+ ;; the function `alist-sort' is not known to be defined.
+ (eval-and-compile
+ (defun alist-sort (x y)
+ (string< (car x) (car y))))
+ (should (equal (sort (car (debbugs-get-status 64064)) #'alist-sort)
+ (sort (car debbugs-test--bug-status) #'alist-sort)))
(should (string-equal debbugs-test--soap-operation-name "get_status"))
(should (equal debbugs-test--soap-parameters '([64064])))
(setq debbugs-test--soap-operation-name nil)
(setq debbugs-test--soap-parameters nil)
;; cached
- (should (equal (sort (car (debbugs-get-status 64064)))
- (sort (car debbugs-test--bug-status))))
+ (should (equal (sort (car (debbugs-get-status 64064)) #'alist-sort)
+ (sort (car debbugs-test--bug-status) #'alist-sort)))
(should (equal debbugs-test--soap-operation-name nil))
(should (equal debbugs-test--soap-parameters nil)))
--
2.48.1
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.
Received: (at 76446) by debbugs.gnu.org; 21 Feb 2025 18:16:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 21 13:16:08 2025
Received: from localhost ([127.0.0.1]:35355 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tlXZH-0005B8-Ss
for submit <at> debbugs.gnu.org; Fri, 21 Feb 2025 13:16:08 -0500
Received: from mail-mw2nam10olkn2058.outbound.protection.outlook.com
([40.92.42.58]:16864 helo=NAM10-MW2-obe.outbound.protection.outlook.com)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <morgan.j.smith@HIDDEN>)
id 1tlXZD-0004we-SY
for 76446 <at> debbugs.gnu.org; Fri, 21 Feb 2025 13:16:05 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=WtS1XF3ppp69VorZ29Je12TV8yUa0eJQ/Ly8ceSr4qzXRFsU9oHFe03Fky0TzgJkcUVgODEQsWRLcw5Zfst19G4NEHAH3C57MX7WSZcPPSYmEOz2aRQvbLZwM3SrdWQYi43kfKna4qVF/6CwlLtmyJ8gZ00ltW3A/Yk3oXMreDc4Tdql7egatav6W/LOMepnDnoxxcmUTKZHF/jup/3CPoaBGXP2CnVIdcPp9mAGaMo1nxSzIG0bpZGSXF93r4SgrSshh2GJkFbDbQfaZr0JPv3QjGKwC8u4gKB1Rxa04xqPUWboGsqUvlGRXYYDrw7WGCX3pHW/iBkoC+GCWwTIqw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=gQySLknpVXvcOZG02wy2qU8j3qlqbqHuqriSqng2C1w=;
b=kwkmkJuZ/JV+kmFuhkHIllqyTAEYg1/OboX4ULksoBCGOMbUU2QuMgGbo+wjpxHERPk5kcTWSR3hBm3x+otz6Zv7CYy1quFieWsDOvwjJAIBcL9Jem3dryaaH+aCp+FhAteEToKy1UqnhqgnDvYnHC1xBiPBojGpTb8B4reNKv5XwxSxd46K7SXKGPRfCewnRQKbupMhVWXBnHCpJxLpnjn4/iZyoiHjBbahZ/yOhFFA89bSDfUTsiJsUesVxehyaeakA5NBoaBO0WZ3s30V+GrN2c4lBRPDFpn9aTG/EKwEMtxCgeTUsqQAruGPNKvJu/kaAE/KSiIIfNF84kntMw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=gQySLknpVXvcOZG02wy2qU8j3qlqbqHuqriSqng2C1w=;
b=qWwz8jf/k9ovarK7uI29lWKN/tBtKTBBxdxBaWC08PLv/LJgi6YkLpKq3LILu5pyCjlh+njpkXWpGM3np2zyNesHYkEmMwPlWmxPcfh9zuneQg2jew4UwTMaSTD8B9aUvjZBHCFvwVkMMJOxkWgP59G9HLTuuNNrkYpOR3hYjMkrH0Whv18Z3ZY57iUohMf/Zgp1wijiArMEl9KZALJQKn1UCuhV4kjlp2kAfeFVv7m2FUE8LvBkEnxWUMo3RPukgMllwwo0nAu5ThJTixBTtiTLWsJGMV+JMvLuGjVRGsZH84dTOUvSehJJbJXA8fQG+G+g/SUOPDtcYqmXg67mAQ==
Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17)
by IA1PR84MB3108.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:208:3e8::9)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.16; Fri, 21 Feb
2025 18:15:57 +0000
Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
([fe80::5c77:7a58:48ed:9aef]) by CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
([fe80::5c77:7a58:48ed:9aef%4]) with mapi id 15.20.8466.015; Fri, 21 Feb 2025
18:15:56 +0000
From: Morgan Smith <morgan.j.smith@HIDDEN>
To: Michael Albinus <michael.albinus@HIDDEN>
Subject: Re: bug#76446:
0003-Makefile-Add-target-to-run-checkdoc-on-all-files.patch
In-Reply-To: <87v7t3wlo3.fsf@HIDDEN> (Michael Albinus's message of "Fri, 21
Feb 2025 13:02:20 +0100")
References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN>
<87v7t3wlo3.fsf@HIDDEN>
X-Hashcash: 1:20:250221:76446 <at> debbugs.gnu.org::xDTGDMMzcXT9zlx+:0A6j
X-Hashcash: 1:20:250221:michael.albinus@HIDDEN::NaQuFYBT/hamGuzV:3hFJ
Date: Fri, 21 Feb 2025 13:15:53 -0500
Message-ID: <CH3PR84MB3424EB975A4BE9FE7185E74EC5C72@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
Content-Type: multipart/mixed; boundary="=-=-="
X-ClientProxiedBy: YT4P288CA0084.CANP288.PROD.OUTLOOK.COM
(2603:10b6:b01:d0::18) To CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
(2603:10b6:610:1c4::17)
X-Microsoft-Original-Message-ID: <87ldtzduzq.fsf@HIDDEN>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CH3PR84MB3424:EE_|IA1PR84MB3108:EE_
X-MS-Office365-Filtering-Correlation-Id: 4e86e6e3-6d2d-4b18-8cdb-08dd52a3c952
X-Microsoft-Antispam: BCL:0;
ARA:14566002|461199028|15080799006|19110799003|6092099012|7092599003|8060799006|5072599009|13095399003|440099028|3412199025|41001999003;
X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Gp5HNgYdoyKFM41Jg5gaiOLs9Fsvtv9pSuraTAsksugK11hUI9ld3SpRsMON?=
=?us-ascii?Q?TwkzBk7ASzrC3LM3Knih9wvZlg316sG9H94aP6Eo2zkIIy9i56Dmicx/Fz6S?=
=?us-ascii?Q?vx21mV26MwSbLLJZQQPrQVI3cNgKIS7ssLogJNBj6a+U370HL49iKxhT6io1?=
=?us-ascii?Q?xzMjYa+OO4BwlfYN3BD0OagaIqS5Paw2g+5V+Nfab35S2RmAkL/58tgac6Q+?=
=?us-ascii?Q?Q3a9hzx3cH4MJGcdqpFU7sEZoAzqLY9s8lgdzxi0Ljrqf9Pwo9wErD2PMVDK?=
=?us-ascii?Q?l2tsvrVeVqSI9sLqw6kcUVnyQU1DtehHf0NnWv0TsfNq4yfx3LFJUnawvp6X?=
=?us-ascii?Q?hQWG7Mce/h6KdqPu60neCc1eVbBa1TU4f0MfGrryiR/vkXx9p49zKBhYiLVv?=
=?us-ascii?Q?+aob0T7XQhs4moTH3NKuyJavE6m16wxSak7fM0/F8lgOEhVWqelxA3Lp3UvP?=
=?us-ascii?Q?pFX+6tdpJg1bQbleaZXxgNIfKC7qmrOgEhVoSnGW5lnGWrly8wIm+N7e/70E?=
=?us-ascii?Q?uHd01yVW0ehFam3hN30mvlbtNzavgSqKoBOghdhMAq5MPfmKe5Vz2PuZcFpA?=
=?us-ascii?Q?BSxGYHJsgQKN5K/3btP8xt1IW8J1ybtWBWA9A/X52RrAzsylsWThZJ+E4F5b?=
=?us-ascii?Q?La3kbU97npGjA3xuMiSH8LZmdslqsrUzszQKNYdbSxuYQJLzgsFYAbSIvD+3?=
=?us-ascii?Q?cElKD88V6ABgbCkOqGgaPlSgFdp2gqLjyKLqpsHTiAUsqcXsDLy2aaxVNMZO?=
=?us-ascii?Q?60y4jd6Tr9YOduvoPRtQRjPtjAD4XTzXDZFjP3v1vmlSvn5keR6WDb/NNkgc?=
=?us-ascii?Q?1OIMuEyWPFyN7aauoCxUpJJm07d41kEE9PKoundj/9roi69HUbO9Le8VBolg?=
=?us-ascii?Q?luOffqaJG8oGaD+5VrYErOu6/cac5n782/2XycdaFfA9rf2yFkGBvDharKI7?=
=?us-ascii?Q?5sAR2n5Eyy2WMan1CabWvtb3VvW7eL8Zz6LpYGaAoRGHsrJXwMKgqgEisJMl?=
=?us-ascii?Q?UM9gAY9PWjmRB/cAXwJv8EvNTC7PQClwHi8RbezI14nVMfCvzidw21CgJuro?=
=?us-ascii?Q?hjfoQlXPLAHOhL2qorlz+TnzlMSYoQ40fqEcyhtxsFdnUlEPYJsf7fNV5+LO?=
=?us-ascii?Q?jvD8YNerSBiNjQe/k5+/7X1fnXL5mtS7o5WHtSHdMERJji250VtyrZE=3D?=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Q9kvzoxJopnkw9hFL0mxxpIhHJzo6JsBOmrYnlBpZJkMEVN6qFzuDGHFuwQR?=
=?us-ascii?Q?UBiuhc2PGVMWbUjHaRHUInwwWBwRK/borUiT1vCiWg0x7IAPJG/2iN7D+FxY?=
=?us-ascii?Q?hHSKkL23cDolwCWw9YIJytZhhRmp/WlUWGbckgOP6thbGFtnJGfnvof60tNB?=
=?us-ascii?Q?JcPd4lmezRc37F9AGijspdAbzEEr7B+hJz0nh8Vit9bpGrpPY0/RMsBVS7v3?=
=?us-ascii?Q?2GswueygfInXxyXC1MhpkDPVH/EN8xiGBDBAyo1lFllSsjulXTDpcOzxu8pR?=
=?us-ascii?Q?KSCAYrE6RbVKHm1IuEl+UlmrBmXp68W9yqY/4+h1h2+tvbAzHyw9lXALN/6a?=
=?us-ascii?Q?ICYXAEU8pES2uFWXiBJx+0vwhWevSzgmJkOvDpxyp7lsDldmR+MfA/5R/+9N?=
=?us-ascii?Q?zpgj5JGWX0hNueeE4tsCZPqaMzgYX7A+cR9AZOSgRoDJ8SnudjjWsWliBV+T?=
=?us-ascii?Q?XbGQLp4lEv56Iot2PLQ8EORLJHRe7p4olSP9LaJlqCEymWpuzd32rkN9+qjV?=
=?us-ascii?Q?sABIL2u36Ix7InTara4ngdNZUnCkKu6NHo4q0Y7ujfCaLkmHewNx40PhATKI?=
=?us-ascii?Q?ozMdLAljZ7/3mWg4SVJcD6gzvhr3dn0xlk7RnfYGRdzaVSFUokxh5U7iR+vt?=
=?us-ascii?Q?iwm47/v7WdKYBLwpUQYmvEzwLVSZ2+pWOtfL1c+fADT490CZtzNVadOrXP2c?=
=?us-ascii?Q?lBy0UupFzRSo8xUezwXuRm/k14n4phyZ1IBc5flkhdcQcRhr36snNWewHZfZ?=
=?us-ascii?Q?o+XPDQXIO1xTdqcdOaAYXbsyzLhOy6WQslv9sKWo/IwV0PP63lZS0pERO567?=
=?us-ascii?Q?LRHztJ1caVvlHT73+T3ZyH1pdVVQeT4jxn5Ikk5U5wPV89jhGtbhd6QmeQJ6?=
=?us-ascii?Q?oyrCjuJzf+pr25iCYyM6Y95+aFts84yC7ASVR5hTtsLL9aAPqMnDCBEN6sS8?=
=?us-ascii?Q?Z3mLulz9OEEbH2L4/1ExyKG2OGXWbkS6hHYTLl/ZgxHs54VHFejxI0rcUguk?=
=?us-ascii?Q?0HEoHdBi2JkVfx22KQEKGiAXVqwwt5txyFx/bMD/Ou6hQy3fg/yjD4RGHnrY?=
=?us-ascii?Q?teWvxJs3efFV0DKq/ySyJuvZnb/cqtnAFQcV/KAA7S/YLJGN4/xKhrMqxlmH?=
=?us-ascii?Q?A8nLc2wsv4br7ahZPgjm43ayRA3t/bVDqwFeS+U5SumpLOnm5uPjvIBe7RSH?=
=?us-ascii?Q?zZcMSc2DT4zbVZVbiqoxR/yrM5vnOTgFEKUGpl6Vt2ZthyXVfTRHRf6DaNxh?=
=?us-ascii?Q?b+EEvCSqhwPn/rPAHKPv?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e86e6e3-6d2d-4b18-8cdb-08dd52a3c952
X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2025 18:15:56.9413 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR84MB3108
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 76446
Cc: 76446 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain
Michael Albinus <michael.albinus@HIDDEN> writes:
> Morgan Smith <Morgan.J.Smith@HIDDEN> writes:
>
>> --- /dev/null
>> +++ b/.dir-locals.el
>> @@ -0,0 +1,18 @@
>> +;;; Directory Local Variables -*- no-byte-compile: t -*-
>> +;;; For more information see (info "(emacs) Directory Variables")
>> +
>> +((emacs-lisp-mode . ((checkdoc-package-keywords-flag . t)
>> + (checkdoc-ispell-lisp-words
>> + .
>> + ("ChangeLog" "ChangeLogs" "UTF" "alist" "args"
>> + "armstrong" "backend" "bcc" "bugreport" "cdate" "cedet"
>> + "coreutils" "cygwin" "debbugs" "debian" "el" "emacs"
>> + "etags" "freemail" "fsf" "guix" "gw" "henoch" "hu"
>> + "hyperestraier" "keymap" "magit" "magnus" "maint"
>> + "maintainer" "maintainer's" "mbox" "mboxes" "minibuffer"
>> + "moreinfo" "multibyte" "notabug" "paren" "persistency"
>> + "regexp" "rescan" "rgm" "rmail" "severities" "sexp"
>> + "solaris" "src" "sublist" "submitter" "submitter's"
>> + "subproduct" "subqueries" "subquery" "teardown"
>> + "unarchived" "unibyte" "unreproducible" "url" "util"
>> + "wishlist" "wontfix" "wsdl" "www" "xsd" "zltuz")))))
>
> This is needed for the checkdoc target in make only, isn't it? Shouldn't
> we activate it for just this case?
>
Ya this seems a little inelegant. See the attached patch for an attempt
to do this a different way.
>> --- a/Makefile
>> +++ b/Makefile
>> +checkdoc: $(SOURCE) $(TESTSOURCE)
>> + @$(EMACS) -Q --batch "--eval=(setq enable-local-variables :all \
>> + checkdoc-spellcheck-documentation-flag t)" \
>> + -L . $(foreach file,$^,"--eval=(checkdoc-file \"$(file)\")")
>
> Do we need '-L .'?
We do not!
>
> Best regards, Michael.
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=v2-0004-Makefile-Add-target-to-run-checkdoc-on-all-files.patch
From 9d6fc20715ae9a13a82811bf7b3b3469e060bd45 Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Fri, 21 Feb 2025 12:52:35 -0500
Subject: [PATCH v2 4/5] Makefile: Add target to run checkdoc on all files
* Makefile: Add target to run checkdoc on all files.
* test/debbugs-checkdoc-config.el: New file.
---
Makefile | 5 +++-
test/debbugs-checkdoc-config.el | 50 +++++++++++++++++++++++++++++++++
2 files changed, 54 insertions(+), 1 deletion(-)
create mode 100644 test/debbugs-checkdoc-config.el
diff --git a/Makefile b/Makefile
index eec1c65a14..8ed6a917fe 100644
--- a/Makefile
+++ b/Makefile
@@ -8,7 +8,7 @@ TESTTARGET=$(patsubst %.el,%.elc,$(TESTSOURCE))
INFOMANUALS=debbugs.info debbugs-ug.info
-.PHONY: all build check clean
+.PHONY: all build check clean checkdoc
.PRECIOUS: %.elc
%.elc: %.el
@@ -26,6 +26,9 @@ doc: $(INFOMANUALS)
build: $(TARGET)
+checkdoc: $(SOURCE) $(TESTSOURCE)
+ @$(EMACS) -Q --batch -l test/debbugs-checkdoc-config.el $(foreach file,$^,"--eval=(checkdoc-file \"$(file)\")")
+
check: build $(TESTTARGET)
@$(EMACS) -Q --batch -L . -L ./test $(foreach file,$(TESTSOURCE), -l $(file)) -f ert-run-tests-batch-and-exit
diff --git a/test/debbugs-checkdoc-config.el b/test/debbugs-checkdoc-config.el
new file mode 100644
index 0000000000..d09b1adfe5
--- /dev/null
+++ b/test/debbugs-checkdoc-config.el
@@ -0,0 +1,50 @@
+;;; debbugs-checkdoc-config.el --- Configuration for running checkdoc on debbugs -*- lexical-binding: t; -*-
+
+;; Copyright (C) 2025 Free Software Foundation, Inc.
+
+;; Author: Morgan Smith <Morgan.J.Smith@HIDDEN>
+;; Package: debbugs
+
+;; This file is not part of GNU Emacs.
+
+;; This program is free software: you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; This program is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;;; Code:
+
+(defvar checkdoc-package-keywords-flag)
+(defvar checkdoc-spellcheck-documentation-flag)
+(defvar checkdoc-ispell-lisp-words)
+
+(with-eval-after-load "checkdoc"
+ (setq checkdoc-package-keywords-flag t)
+ (setq checkdoc-spellcheck-documentation-flag t)
+ (setq checkdoc-ispell-lisp-words
+ '("ChangeLog" "ChangeLogs" "UTF" "alist" "args"
+ "armstrong" "backend" "bcc" "bugreport" "cdate" "cedet"
+ "coreutils" "cygwin" "debbugs" "debian" "el" "emacs"
+ "etags" "freemail" "fsf" "guix" "gw" "henoch" "hu"
+ "hyperestraier" "keymap" "magit" "magnus" "maint"
+ "maintainer" "maintainer's" "mbox" "mboxes" "minibuffer"
+ "moreinfo" "multibyte" "notabug" "paren" "persistency"
+ "regexp" "rescan" "rgm" "rmail" "severities" "sexp"
+ "solaris" "src" "sublist" "submitter" "submitter's"
+ "subproduct" "subqueries" "subquery" "teardown"
+ "unarchived" "unibyte" "unreproducible" "url" "util"
+ "wishlist" "wontfix" "wsdl" "www" "xsd" "zltuz")))
+
+(provide 'debbugs-checkdoc-config)
+
+;;; debbugs-checkdoc-config.el ends here
--
2.48.1
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.
Received: (at 76446) by debbugs.gnu.org; 21 Feb 2025 18:12:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 21 13:12:08 2025
Received: from localhost ([127.0.0.1]:35291 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tlXVO-0003FX-SQ
for submit <at> debbugs.gnu.org; Fri, 21 Feb 2025 13:12:08 -0500
Received: from mail-mw2nam10olkn2100.outbound.protection.outlook.com
([40.92.42.100]:26081 helo=NAM10-MW2-obe.outbound.protection.outlook.com)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <morgan.j.smith@HIDDEN>)
id 1tlXVK-0003Da-Jz
for 76446 <at> debbugs.gnu.org; Fri, 21 Feb 2025 13:12:04 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=bkgJfoBLYhTWPhwhc+oGRDotsgiPC0yTwG+tc9HM2+x6G4ypStDmZfjvERQePuhMZ5SGePTgEKSDmW14bGbEDEFNSoaoDv05Wd2zOfoeFROcrcSBnHpuBIJJfPs9Uoh0Y3CTGnLb144Hym3ggquj8p/nomtX0HNpPVNCCblRaTFW6wJ02G316Z1rK7aPLl5XOVdCmvVKxbXoCIbzebietUQnFbtFsUNWEl+hufhNVUyMT7xoqvEWv1oIiFtrTt7cyUl2PLKwShZl8Aa/axX6IDMSjnKgAe6rOlsIIccaOQ/u3ALES7iYS0kaDhq7PBncgeHw2H6yxCprNrNNZA/alw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=VuSHEhvv1wqOf16/xs3w1vowOYr/qw3sDXU7a5242/E=;
b=YpL55+WCP7PrIUkacCNacQVMmaEP4mIDFRTePmdxrRAcjepeNTtkkpr2Lhxz0Hk0MYuEjMPNQIFrGmgm1eXlq1TofjYsp4TLLYrD91QPnCqTLHcGeY/xSLDbT7cieDi9dXGVqLYYb7VEhwqtBkanP2aXnUJInWmG0MuugjvdfB7I1zsY0unIMr130OTJ7FqWMdbZPTr3MXpGa70Dy/tAyKLrrwD9T15lFVi3Qi8Px6VAiF2ZOTpv5BSXHPAdayBZFZgqOlxBXGqvymuffHvuHt2CD+Tqt+ecXFkwHGtwYzRtVqAnsGqSigMeSHFM3L157lrEmjYmEAvuFOnImWJ0jw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=VuSHEhvv1wqOf16/xs3w1vowOYr/qw3sDXU7a5242/E=;
b=mI850TO076JRtuJLh8wl5ekv+kv9G/TLHfBLYYsdiclTgFQ1J+McFPR2+xhxAfKkg0KWCoN8kAN8dLrEwgFxoIWgXytRgIjDjoEyFKi79kyxgPMt7zDfC+uNfjxM0qTJHDxnD331VYf0hK3L28lfKFr4n/ND2q4d8NgjybhlwpK5cbLcz5eM5We7GeD7o5PrSzI4PgGpfgFyMh1Gja5PX76BWAfR1YxqmujyvzGOZWeH1iHhK+v1c2vKYWyLUy+/UrEEbhNWijfHQyebEhzhjkebme+PxUJh9NNleNNx4Y1gUzSofAp9xnmUEh7RLsGHkAvOK1aAbHIMGyTJG1ex/Q==
Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17)
by IA1PR84MB3108.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:208:3e8::9)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.16; Fri, 21 Feb
2025 18:11:55 +0000
Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
([fe80::5c77:7a58:48ed:9aef]) by CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
([fe80::5c77:7a58:48ed:9aef%4]) with mapi id 15.20.8466.015; Fri, 21 Feb 2025
18:11:54 +0000
From: Morgan Smith <morgan.j.smith@HIDDEN>
To: Michael Albinus <michael.albinus@HIDDEN>
Subject: Re: bug#76446: 0002-tests-Add-tests-for-debbugs-gnu.patch
In-Reply-To: <87zfifwlxg.fsf@HIDDEN> (Michael Albinus's message of "Fri, 21
Feb 2025 12:56:43 +0100")
References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN>
<87zfifwlxg.fsf@HIDDEN>
X-Hashcash: 1:20:250221:michael.albinus@HIDDEN::rBDXwCqxDgl2oSZR:zS4
X-Hashcash: 1:20:250221:76446 <at> debbugs.gnu.org::uHPlXxQBr0pezHPD:30UE
Date: Fri, 21 Feb 2025 13:11:51 -0500
Message-ID: <CH3PR84MB342460F7CF9FD5B9347BD72AC5C72@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
Content-Type: multipart/mixed; boundary="=-=-="
X-ClientProxiedBy: YT3PR01CA0001.CANPRD01.PROD.OUTLOOK.COM
(2603:10b6:b01:86::27) To CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
(2603:10b6:610:1c4::17)
X-Microsoft-Original-Message-ID: <87pljbdv6g.fsf@HIDDEN>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CH3PR84MB3424:EE_|IA1PR84MB3108:EE_
X-MS-Office365-Filtering-Correlation-Id: cc8103a9-ac09-48fc-2dff-08dd52a3390a
X-Microsoft-Antispam: BCL:0;
ARA:14566002|461199028|15080799006|19110799003|6092099012|7092599003|8060799006|5072599009|13095399003|440099028|3412199025;
X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?EOm3iBv5dModYJv4sb1WOvAQI0rCapmkeZEABvpfPifyae+dRgFl4fe5JPgF?=
=?us-ascii?Q?HRsl5fSZATLCtZOPvFXX5OGyKWDnsf4/+7T0qraPKb85xJXHfypO6yuU35VB?=
=?us-ascii?Q?iXVqDP+XAD+4rufR9Om/caNdyvyn+UmWEG3eKN2gm6aLYwlsPspl4i7iWGB8?=
=?us-ascii?Q?XkWEVIRcjOEyMLVSVNeTUCRCHADlHsz7jKNN4S578iiAbL2KsOCCsmTX3eyV?=
=?us-ascii?Q?8F9AIJfNGmRRY1/05XigXTuhd8TtT5eDoaAA5N4Mi52QNb5qAF6gfTpYT/bw?=
=?us-ascii?Q?C5XOI63zJKj2vCskKJKBnJpDWCR/hAHCjzJX1Opzaqv+b/2/jeZ7/P2Cpk4W?=
=?us-ascii?Q?jauIxfAm98R3AZ4pueCk5Km/Kk8nMaVf2BOfLuFqNlP8TF3/kUkRKjASkd/k?=
=?us-ascii?Q?Gz5Vu8ShoExs94SiYS9dTVmXQ7D6ffzoSGyLsPadKyuToWYNZiwx7WDM8bQ6?=
=?us-ascii?Q?P+bd+JBxSBTjld/qPqOIIBdkNDx3JUccpNjB+toP3K02O9ZPgk2D+0xcuEiU?=
=?us-ascii?Q?4pfBRmhqQ6SfaSlVHVp/7aJFUX564W5hUKh6hqjjkp6jrMnpGmd9xdWwCRxh?=
=?us-ascii?Q?xuu+TWuy2EJ3pkgn4ANSpS+5MFL/7oNPak/R9BpO5MHxpDAhg++ESr2mNdXP?=
=?us-ascii?Q?SGIJWgAVR56rC2g+Y8lMziNvO7dkDzTaBJi0UNvkEHZXU6C7M+pAr1dBa0RF?=
=?us-ascii?Q?5KLBEkd2cUTtcrooXY6mxzPhtkIGkLWsTYgnM9zCYjXgkSCJPCiKDYnL+NpC?=
=?us-ascii?Q?ACWosxBUeCYpT+CVjKvPX6a67Z29sCIsAOyJHXm3FTG5oYxVOnBPjuP9AuaS?=
=?us-ascii?Q?YY9I6qKWUxAZpXX/GaY7qU9QI8vcz/hnkWVv5JxrwoJDoSXoBPZ55BRzmML/?=
=?us-ascii?Q?iCsLV1TvgXziBgjC7WcB7cUwSMWXXzc4LVnQMl23iO76rR06sn7cXezUwB6d?=
=?us-ascii?Q?xc5bR0w221LHhWut2y8z8IWrWNbWmK5WU2VEkHCZqxxmmsCM6UIqFKPzbUVL?=
=?us-ascii?Q?hecejJUw+Isx9q7fV/k24GqU/V0PwDhCK/PTz42Gxe7mGIbCnzeDrnEwf/Gr?=
=?us-ascii?Q?LIBPyPlHoSGBhUC56WNmSyquKbYq9M13s/Bf/Vk/hnaWXm3isEwlyx5i9VZO?=
=?us-ascii?Q?cfrsJaRo7bMePxUOVfgW4QSyt/FcLD4d9g=3D=3D?=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?k8S7/calK14R+qp4kxd1w+VGi7VgQa95GRhzdWpxUSv3UDb6SrpR0z2BJCPq?=
=?us-ascii?Q?6VcFqDcE5DyfHBaDDFo8jtk2NCnL7cdK4kGvCAOx/2//7SLg1JqXe0rl0Epz?=
=?us-ascii?Q?ghpRYlupphBigM0PpVzsvw4MnXDPxBJuGsel+zyvFvxqBzV4f/78fP8Xd28M?=
=?us-ascii?Q?Slm14pm6qlJgVccdtqXQQgU/6Q4uXXPgchxDQ/XZhVGI8l1gKbwYoisueU91?=
=?us-ascii?Q?tvitBllkAoPpngWKgM/dkVAALVJno0cV2r1FmGoTUQInJYJ+Sg8iePggzFrB?=
=?us-ascii?Q?UQLGvex7uP7icyZkwIQdKyszOzDKUoofWcD/IEO/nHQ7jWaqY6bQHLxqqJ1z?=
=?us-ascii?Q?A1RJ98e+Oc5CDh8ncYO5p5kM82SXYdiaBF+NJiYCfP9tJOQBN7xDEj5xjKsW?=
=?us-ascii?Q?6Wm4UFgSWowX2n4jthhHT7Ui0OrHc20G3OorPQ81sMsvEHbJPeWeUZkoFWp9?=
=?us-ascii?Q?TPXDPbqUHb+CFchvHc2CalLbRy1W3d3Z/N0jrY/GvF/+4ZEXnK3GplwN5aMM?=
=?us-ascii?Q?jnrmq1X5ODJVornE8wXcfd4Jj53pBWX4oG4SvhAhEE2wyoJeISOCLxkjEUf6?=
=?us-ascii?Q?waHjBQqrbLVRtAAqM/315Focm0o8oponz6H/NQh9LMgG5P7zLACGUmPW/HyQ?=
=?us-ascii?Q?9wwZFTKQfsey857WeTNxSo+TX7n9fkVf0DGnO2tOW6qsWlukU0ZOAQQC/auY?=
=?us-ascii?Q?3OgLCoHLPSGRRH/9PTuSL9mEDXwBnw6fuLLfT1+wQx2Ykofqt2Ouug/rT7EQ?=
=?us-ascii?Q?yCigqdKDminJ6dNmkf0dz3mtBhDSrqv8c8CbTXt2UxYW+wC7l+nn6Hn3nXoL?=
=?us-ascii?Q?xMrMFsaas+UAL2ZhzATim5piUsSjCfA+nZHIYwEs8eVNZ017s+G4XEcO+qbX?=
=?us-ascii?Q?8/IpuIqbyLGL5cckHVh9xJOHwzPpEbXG/NAVfJY5TGQkdR+aIfwXeq609VlX?=
=?us-ascii?Q?Rpe1kBrUgDVnegDJJaH/Fb+SAx/SUCyrBk9rFRRNyK015fV9i4DFKX7V5Hv9?=
=?us-ascii?Q?7oGEN09Uy1IEjvPoEiqewZ7Mn6fWtUlOESWmTe/4za5bOq+dsUL6pxguj+za?=
=?us-ascii?Q?q4Jcj1mFtMjbI8i6z7qUrI5AEvGOOIED4hGwLRWBAEQuKAkoy/ELO749iWQX?=
=?us-ascii?Q?2BrEqILCdiMuU9L1dp+/46gIEKKpUAfWaSUlKaPSp/01063v2KPh/Q1+ONat?=
=?us-ascii?Q?WgXiBktuSS1ooaJxZfUns8XRnQ878G8TY2UxOlBcflsURDzDGsdCyLFfH0Q/?=
=?us-ascii?Q?umBWYHdW++k0NT52kLUm?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc8103a9-ac09-48fc-2dff-08dd52a3390a
X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2025 18:11:54.8832 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR84MB3108
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 76446
Cc: 76446 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain
Michael Albinus <michael.albinus@HIDDEN> writes:
> Morgan Smith <Morgan.J.Smith@HIDDEN> writes:
>
>> --- /dev/null
>> +++ b/test/debbugs-gnu-tests.el
>> +(require 'debbugs)
>> +(require 'debbugs-gnu)
>> +(require 'debbugs-test-helpers "./test/debbugs-test-helpers")
>
> (require 'debbugs-test-helpers) is sufficient.
>
Done!
>> +(ert-deftest--debbugs debbugs-test-debbugs-gnu-search ()
>> + "Test `debbugs-gnu-search'.
>
> Isn't it rather a test of `debbugs-gnu'?
>
Nope! The intention is to test `debbugs-gnu-search'. In fact I stub out
`debbugs-gnu' with #'list so that I can test how `debbugs-gnu is
being calling by `debbugs-gnu-search''.
>> +Also test `debbugs-gnu-patches' and `debbugs-gnu-tagged' which are
>> +simple wrappers for `debbugs-gnu-search'."
>
> Nope. They are wrappers of `debbugs-gnu'.
Oops! You're right. I have removed those tests.
> Best regards, Michael.
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=v2-0003-tests-Add-tests-for-debbugs-gnu.patch
From 3bd34242bffce78a908ca66ff1073e304d185fda Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Fri, 21 Feb 2025 12:52:24 -0500
Subject: [PATCH v2 3/5] tests: Add tests for debbugs-gnu
* test/debbugs-gnu-tests.el: New file.
---
test/debbugs-gnu-tests.el | 47 +++++++++++++++++++++++++++++++++++++++
1 file changed, 47 insertions(+)
create mode 100644 test/debbugs-gnu-tests.el
diff --git a/test/debbugs-gnu-tests.el b/test/debbugs-gnu-tests.el
new file mode 100644
index 0000000000..04c445e43b
--- /dev/null
+++ b/test/debbugs-gnu-tests.el
@@ -0,0 +1,47 @@
+;;; debbugs-gnu-tests.el --- tests for debbugs-gnu.el -*- lexical-binding: t; -*-
+
+;; Copyright (C) 2025 Free Software Foundation, Inc.
+
+;; Author: Morgan Smith <Morgan.J.Smith@HIDDEN>
+;; Package: debbugs
+
+;; This file is not part of GNU Emacs.
+
+;; This program is free software: you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; This program is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;; Please ensure tests don't actually make network calls.
+
+;;; Code:
+
+(require 'debbugs)
+(require 'debbugs-gnu)
+(require 'debbugs-test-helpers)
+
+;;; Tests:
+
+(ert-deftest--debbugs debbugs-test-debbugs-gnu-search ()
+ "Test `debbugs-gnu-search'."
+ (cl-letf (((symbol-function #'debbugs-gnu)
+ #'list))
+ (should
+ (equal '(nil ("guix" "guix-patches") nil)
+ (debbugs-gnu-search "frogs" '((pending . "pending")) nil '("guix" "guix-patches") nil)))
+ (should (equal debbugs-gnu-current-query '((phrase . "frogs"))))
+ (should (equal debbugs-gnu-current-filter '((pending . "pending"))))))
+
+(provide 'debbugs-gnu-tests)
+
+;;; debbugs-gnu-tests.el ends here
--
2.48.1
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.
Received: (at 76446) by debbugs.gnu.org; 21 Feb 2025 18:09:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 21 13:09:07 2025
Received: from localhost ([127.0.0.1]:35218 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tlXSQ-0002jj-SE
for submit <at> debbugs.gnu.org; Fri, 21 Feb 2025 13:09:07 -0500
Received: from mail-mw2nam12olkn2107.outbound.protection.outlook.com
([40.92.23.107]:27777 helo=NAM12-MW2-obe.outbound.protection.outlook.com)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <morgan.j.smith@HIDDEN>)
id 1tlXSH-0002h3-31
for 76446 <at> debbugs.gnu.org; Fri, 21 Feb 2025 13:08:55 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=gg/IMvcQiX/UhIp7sjrSDPJTqSEb7QnIILjs276N4NeBiWn8n1DqGXlmUpT2tnB+2vQ6nbR+ja38jqHv4ZRsjEZiBn2/0Nnl/BD++lU/EPEgkEaHdbf7PsIRavGoPPl4rtc09YsTWaq2YLZu7gWwynz7zab9OlwgADz+R2LGPRQ79aFZ6WnrLPbr8VpbairX2QwFjPhSbpK+xzuEUT2q4wM82WZeLdA6SCV9A18vgCPoRh27wllkVEv3GwbvYOyUanR25IdyByglJcZGGsFVpRMJIcUFB2T0ldeFT7lGhB/kGimiSXSWD6MUbfO4dIHibQJeGeI6jzKR1C/uXAfCzA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=S9qROuiRlzQ/v26S0SLWwnd8p47hwsPzEgKXYR0pfag=;
b=ShR9kdCMzXk8+9IIEyyorSd0RCpjKursJtTYnfqJnk45M7hR5akdCDajD3go37xoY7n48qFszJsdAWX4STL7Cvht1mfeYxiSEu0Q+jWFsxFr+/U2gAhCLCY0qr/Z3jiIrCCLIDYXLTQYuYEt+IWFdXdCWixj8YK7pwlew1j3yIkXrblo3qc/uWsvK7dKdDq/yKtZc+2LHbgRIiS4AZMBeG1cA8Xow+Kk5SyudONGWNNW6SZSeXYse73O6b9udI7m/tANbxukbhUmJbE2as1oRZk3nS7yVVcBfpgjT3GzX44wxbVmCtaxQkWXOiFjl8crol5N/GIjjskYEjUpKqN75w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=S9qROuiRlzQ/v26S0SLWwnd8p47hwsPzEgKXYR0pfag=;
b=tZKJqz8vCvjDs4OX8wZurfNjiXh7qI5bZABgwF6EFDKxBAB291VtOkKaLl1ukuiTlIOmvljTtpF0r2O1A00Fzxb125NoDvSXpRgmh74krI6a5ZwtcD18FtIG4epIVLE0DQcjyUuu5ixDMcbdnDVrWIx04KMiOtjTZlS/t+onFIZmo95VilWIrgCxXugIAKk5dqzmSmmRWA73Fa0Ye0TBHjoIuaFfkjNHSADaHoqKwGrZZkpJuX/iyHNrnBNyq4gYwKXtiNd+8PybAC2xzTYnSEhyRkZn+tM5KqNN4piJkxR8w1FZLGMvd/vJ5fg8Ack0lOQBbqa2/6p8sYM+xMp3EQ==
Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17)
by SJ0PR84MB1776.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:a03:436::16)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.16; Fri, 21 Feb
2025 18:08:45 +0000
Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
([fe80::5c77:7a58:48ed:9aef]) by CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
([fe80::5c77:7a58:48ed:9aef%4]) with mapi id 15.20.8466.015; Fri, 21 Feb 2025
18:08:45 +0000
From: Morgan Smith <morgan.j.smith@HIDDEN>
To: Michael Albinus <michael.albinus@HIDDEN>
Subject: Re: bug#76446:
0001-tests-Move-helper-and-wrapper-functions-into-their-o.patch
In-Reply-To: <874j0ny0pa.fsf@HIDDEN> (Michael Albinus's message of "Fri, 21
Feb 2025 12:52:17 +0100")
References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN>
<874j0ny0pa.fsf@HIDDEN>
X-Hashcash: 1:20:250221:michael.albinus@HIDDEN::pSQbBy57qmMmaW09:rPc
X-Hashcash: 1:20:250221:76446 <at> debbugs.gnu.org::fchVcm5q/0J91mY2:2IlD
Date: Fri, 21 Feb 2025 13:08:40 -0500
Message-ID: <CH3PR84MB3424C014EA66C2F79FDC1E0AC5C72@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
Content-Type: multipart/mixed; boundary="=-=-="
X-ClientProxiedBy: YQBPR0101CA0240.CANPRD01.PROD.OUTLOOK.COM
(2603:10b6:c01:66::14) To CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
(2603:10b6:610:1c4::17)
X-Microsoft-Original-Message-ID: <87tt8ndvbr.fsf@HIDDEN>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CH3PR84MB3424:EE_|SJ0PR84MB1776:EE_
X-MS-Office365-Filtering-Correlation-Id: 100f1261-7d70-4777-d9d7-08dd52a2c7dc
X-Microsoft-Antispam: BCL:0;
ARA:14566002|461199028|19110799003|6092099012|7092599003|15080799006|8060799006|5072599009|3412199025|13095399003|440099028|41001999003;
X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?uas8eIP3nQvMoVLfd52ZIaD1QB8n2j7tkFuvRBRgAH0tEhVIMCqLeiaW59pb?=
=?us-ascii?Q?6odn95rFR2qrMWMj4BKr6Mn5/497ow14aWiyIVdIxxsWT30B07wI6+36361G?=
=?us-ascii?Q?uoUx4PuNvW3vnFbHGVhdc29bhU6lBZA1EPn6OZeO+3qfaUW7XPBDIFTMzsOg?=
=?us-ascii?Q?+X7sO4Twh0t13PnufA4IQzwtegQYU3IoPVsaVTeSlelmWE03APoDLyIUdW8B?=
=?us-ascii?Q?10dmZX3VTt+idlz9Y463DC6b20klv8yQgTbxY3C0L/ZupSYH5u6ExBdEZmUZ?=
=?us-ascii?Q?Cm+OghL8rQwHdAzNIIhuXZiNSvkkaKHZNKDElaytXnfRH9NnlqEPwymFbHvE?=
=?us-ascii?Q?AyySkPZwEPLd1QhUTBX7j48cI0VvC7u9CXDeJ17NspgV9SCNo1WUN6/VXLzp?=
=?us-ascii?Q?h2pWPDEUxDxvqgolKHNTXq9Wcx7Trzq9eHGnFei0mC1bj8XXvZ5Lids7OrbS?=
=?us-ascii?Q?VujhUZjk9aU1xnqvNrOkQKQCuQfulqA1Enoww5n3PepM60d+uHS913NeVRtW?=
=?us-ascii?Q?5lwbCOzHbsXkM3I/u2CFDy3Y7P+kPJI7PnP8W4NQ2Q3fmMeCgvRnBf6kksix?=
=?us-ascii?Q?B/0qtT0fWbqbhmq/+Z6F3uXBLSASk53pHtYa8A/o162nB4uksvxZS4i0U91x?=
=?us-ascii?Q?sbW+riB8HepKUYm+CeTT7rN385W77/9LwMuXF7QDiFty9cQWiBFhUqoSFV8d?=
=?us-ascii?Q?JevGPc1hccR1vRrxlznItqoZLkWUT1PnZQWcjzPexi+gvw4ou3TPzLAHS7Ra?=
=?us-ascii?Q?Tp3nF32pZWRPN3+yiHttRRndKoBK9Rcqygm46R+St8/Zy5SZquzp+TLLQg4m?=
=?us-ascii?Q?IVjk942C/nt9P8oWo3vECBz5eWgSrcVW3Ec1gB1zEDBUJ0ueuw2Db7CV295p?=
=?us-ascii?Q?Pui23seaVuJCNbSkoY3qJfKzm1X5hQZ+dBzyKqyTeIum8p6PrLdD75LzKu6t?=
=?us-ascii?Q?+5JMzOXbV3nKIRV8CTJQQZlSRL1cGb605NfpmkaJWTquPI9UrZr04CsAJoOv?=
=?us-ascii?Q?7R7UDyYz6UrK7iANLC+uoG6575JJ59AiB2BGFuLOpGI6CMY0JvZ92No1vAXm?=
=?us-ascii?Q?k3ZIPFmIwj69dg31KcSvk8in9SJCoXrp7/aoetf4kgb+HOS+IrYvhze4dseK?=
=?us-ascii?Q?EXc91wcxqmvV4Q5oAu6o6/BcGLnFkZU3Ro0cWzA+bPnUNw5Tfe3nDwQ=3D?=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3mw1DQAowCheA+Gt1xStBkN9WdiWAQdpKmFvlwK/LBTWkdRQxFrVhEH572Jx?=
=?us-ascii?Q?SmSaBTALMC2O0+5V/oYj+pdJy57pqis4oKT0XZ6YemsSiFvLoh4iCyDEUY8f?=
=?us-ascii?Q?nrLnlmlkRtZd5xoL6fBPtp7gQnKo1nCY44v/zmt9wLuWUMtmlAEAdm+HKeYk?=
=?us-ascii?Q?Wq6fjEw/qmf0v78RdWYMUdka7MUwfv6ycziPG/LXyJzU4Ksefm44mOKORAWh?=
=?us-ascii?Q?iOVCO/Sv9qLVB0oK2quF05tl8UnwA7eWemgdhG6OceHWmTwxFi+6h1nwsK69?=
=?us-ascii?Q?cQYMBfVLHQtoOHlqVyq+GXLoiRwIPaRbQ3zlkUwmiqWdmxsSK7P0FUQ2nJMF?=
=?us-ascii?Q?KctnFVCbtnzcfNWH++XY6Lat6dtNNs3Zl7QSEqjvyRyubgWd83GskL77kKdc?=
=?us-ascii?Q?Zh6Kls8Hf14+OP+LXsPWC/+mUD38FQNNy8AShb2Y3nRvb1HM1FraOA0cDwyz?=
=?us-ascii?Q?ejMvYGBPPSc0gQcaJferNaZFW68tD7bw4U91j+FS4TrP0k3pFijFBR9fdWNC?=
=?us-ascii?Q?/FBrRnlf9jHSX9rM/I35CUaWo5QsGL5m3xl0SbzBy8rXBSLP+FmYozrJDqN/?=
=?us-ascii?Q?yfo0CA1ToNVusreCr8R3iUIX/dn6r6F6kku7BXPS2l7ThT8+c17dv54KWVxY?=
=?us-ascii?Q?SnkegZb6r1/5TJfORyKZMoPFlPF6c/VHYAQbXlThLpN8xEBP3YhrTK/xy4qo?=
=?us-ascii?Q?bQPBcQN81aRFkrROt9V5lcWjT7Fk1orDGRPeojuGhUY4F5C5SROzgJ1PCor0?=
=?us-ascii?Q?P+O+0sByvto3EZGwLinYx8isV+hZsQYLbllfGjN5Ym+UEZYDvy9ONhyqn2cj?=
=?us-ascii?Q?MUEE9GtNCjHG2V3iQiqW6ahGpGh6l11neLqeEV2VLaYsAfiA9sEbshIgE4IB?=
=?us-ascii?Q?IgGZHGMVQQOe3SgipUgyrwM0s5/C+76XSDv/SPREgvzxugGioR1hHN6zSPtt?=
=?us-ascii?Q?7HtCd9dWHPMwZzND4XMpNsV6xPLFBXFRqywXyViTqxq7+ukf95hRLICYz6QF?=
=?us-ascii?Q?dDcZD5X6+CSmAaZUAdmhuH/AFQi77r8taYa05VBuLyfs8O3t9RJPlFE8pn9j?=
=?us-ascii?Q?LhTRWUPBCY0u1zkvLUqQF/ROaVu7vS7xIvrGWjlVK/7ScJosrj/DILsz/cQC?=
=?us-ascii?Q?a6Zo9m7pCHoz4FGPm36EEoqZGMJlzX519rti0PST95ZQ/MbaZCLYG6cI+lYG?=
=?us-ascii?Q?SGN27+o3FHtEZ8NmEA/2YtF2/iRWeRf4apat9qeRhM+KMey98RAAHoQLXJ2B?=
=?us-ascii?Q?0794Zfiy88GKX2el6QkJ?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 100f1261-7d70-4777-d9d7-08dd52a2c7dc
X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2025 18:08:45.1919 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR84MB1776
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 76446
Cc: 76446 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain
Michael Albinus <michael.albinus@HIDDEN> writes:
> Morgan Smith <Morgan.J.Smith@HIDDEN> writes:
>
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -24,7 +24,7 @@ doc: $(INFOMANUALS)
>> build: $(TARGET)
>>
>> check: build $(TESTTARGET)
>> - @$(EMACS) -Q --batch -L . -l $(TESTSOURCE) -f ert-run-tests-batch-and-exit
>> + @$(EMACS) -Q --batch -L . $(foreach file,$(TESTSOURCE), -l $(file)) -f ert-run-tests-batch-and-exit
>
> We might be better with
>
> --8<---------------cut here---------------start------------->8---
> @$(EMACS) -Q --batch -L . -L ./test -l $(TESTSOURCE) -f ert-run-tests-batch-and-exit
> --8<---------------cut here---------------end--------------->8---
>
I did the '-L ./test' part but I kept the foreach.
Without the foreach the command looks like "... -l file1.el file2.el
file3.el ..." and emacs only actually loads the first file. The command
needs to look like "... -l file1.el -l file2.el -l file3.el ..."
>> --- /dev/null
>> +++ b/test/debbugs-test-helpers.el
>> @@ -0,0 +1,146 @@
>> +(defconst debbugs-test--bug-status-soap-return
>> +(defconst debbugs-test--bug-status
>
> Perhaps we should move these data into an ert-resource file (or two).
>
I read the info manual and source code pertaining to 'ert-resource' and
I fail to see any benefit from using it.
>> +(defmacro ert-deftest--debbugs (name args docstring &rest body)
>> + "The same as `ert-deftest' but runs setup and teardown functions."
>> + (declare
>> + (doc-string 3)
>> + (indent 2))
>> + `(ert-deftest ,name ,args ,docstring
>> + (debbugs-test--setup)
>> + ,@body
>> + (debbugs-test--teardown)))
>
> In order to ensure that debbugs-test--teardown is called even in case of
> errors, we could use
>
> (unwind-protect
> (progn
> (debbugs-test--setup)
> ,@body)
> (debbugs-test--teardown))
>
Good catch! Thank you! I don't want to move things and change them at
the same time so now this is two patches.
>> --- a/test/debbugs-tests.el
>> +++ b/test/debbugs-tests.el
>> @@ -27,118 +27,7 @@
>> ;;; Code:
>>
>> (require 'debbugs)
>> +(require 'debbugs-test-helpers "./test/debbugs-test-helpers")
>
> (require 'debbugs-test-helpers) should be sufficient with the proposed
> change in the Makefile.
Done!
>
> Best regards, Michael.
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=v2-0001-tests-Move-helper-and-wrapper-functions-into-thei.patch
From 310038c998bfcaddebd4144d6d37da6a4d4f6aeb Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Fri, 21 Feb 2025 12:52:03 -0500
Subject: [PATCH v2 1/5] tests: Move helper and wrapper functions into their
own file
* test/debbugs-test-helpers.el: New file.
* test/debbugs-tests.el: Move test helper and wrapper functions into the new
file and require it.
* Makefile(check): Load all files in the test directory.
---
Makefile | 5 +-
test/debbugs-test-helpers.el | 146 +++++++++++++++++++++++++++++++++++
test/debbugs-tests.el | 113 +--------------------------
3 files changed, 151 insertions(+), 113 deletions(-)
create mode 100644 test/debbugs-test-helpers.el
diff --git a/Makefile b/Makefile
index a7b6b0c7f3..eec1c65a14 100644
--- a/Makefile
+++ b/Makefile
@@ -14,6 +14,9 @@ INFOMANUALS=debbugs.info debbugs-ug.info
%.elc: %.el
@$(EMACS) -Q -batch -L . -f batch-byte-compile $<
+test/%.elc: test/%.el
+ @$(EMACS) -Q -batch -L . -L ./test -f batch-byte-compile $<
+
%.info: %.texi
$(MAKEINFO) --error-limit=0 --no-split $< -o $@
@@ -24,7 +27,7 @@ doc: $(INFOMANUALS)
build: $(TARGET)
check: build $(TESTTARGET)
- @$(EMACS) -Q --batch -L . -l $(TESTSOURCE) -f ert-run-tests-batch-and-exit
+ @$(EMACS) -Q --batch -L . -L ./test $(foreach file,$(TESTSOURCE), -l $(file)) -f ert-run-tests-batch-and-exit
clean:
-rm -f $(TARGET) $(TESTTARGET) $(INFOMANUALS)
diff --git a/test/debbugs-test-helpers.el b/test/debbugs-test-helpers.el
new file mode 100644
index 0000000000..f98bab40ed
--- /dev/null
+++ b/test/debbugs-test-helpers.el
@@ -0,0 +1,146 @@
+;;; debbugs-test-helpers.el --- Helpers for testing debbugs -*- lexical-binding: t; -*-
+
+;; Copyright (C) 2024-2025 Free Software Foundation, Inc.
+
+;; Author: Morgan Smith <Morgan.J.Smith@HIDDEN>
+;; Package: debbugs
+
+;; This file is not part of GNU Emacs.
+
+;; This program is free software: you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; This program is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;; Please ensure tests don't actually make network calls.
+
+;;; Code:
+
+(require 'debbugs)
+
+;;; Helper Data:
+
+;; Generated using this:
+;; (soap-invoke debbugs-wsdl debbugs-port "get_status" [64064])
+(defconst debbugs-test--bug-status-soap-return
+ '(((item
+ (key . 64064)
+ (value
+ (package . "emacs") (found_date) (last_modified . 1689593050)
+ (affects) (date . 1686745022) (fixed_versions)
+ (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>")
+ (blocks) (archived . 1) (found) (unarchived) (tags . "patch")
+ (severity . "normal") (location . "archive") (owner) (fixed)
+ (blockedby) (pending . "done") (keywords . "patch") (id . 64064)
+ (found_versions) (mergedwith) (summary) (forwarded)
+ (log_modified . 1689593050)
+ (done . "Michael Albinus <michael.albinus@HIDDEN>")
+ (source . "unknown")
+ (msgid
+ . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>")
+ (bug_num . 64064) (subject . "[PATCH 0/4] debbugs improvements")
+ (fixed_date)))))
+ "Mock result from `soap-invoke' for bug 64064.")
+
+;; Generated using this:
+;; (debbugs-get-status 64064)
+(defconst debbugs-test--bug-status
+ '(((cache_time . 5000) (source . "unknown") (unarchived)
+ (keywords "patch") (blocks) (pending . "done") (severity . "normal")
+ (done . "Michael Albinus <michael.albinus@HIDDEN>") (location . "archive")
+ (log_modified . 1689593050) (subject . "[PATCH 0/4] debbugs improvements")
+ (last_modified . 1689593050) (found) (tags "patch") (package "emacs")
+ (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>") (archived . t)
+ (blockedby) (affects) (mergedwith) (summary) (date . 1686745022)
+ (fixed_versions) (id . 64064) (fixed) (found_date) (forwarded)
+ (msgid
+ . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>")
+ (owner) (found_versions) (fixed_date) (bug_num . 64064)))
+ "Mock result from `debbugs-get-status' for bug 64064.")
+
+;;; Helper Functions:
+
+(defvar debbugs-test--soap-operation-name nil)
+(defvar debbugs-test--soap-parameters nil)
+(defun debbugs-test--soap-invoke-internal
+ (callback _cbargs _wsdl _service operation-name &rest parameters)
+ "Over-ride for testing."
+ (setq debbugs-test--soap-operation-name operation-name)
+ (setq debbugs-test--soap-parameters parameters)
+ (let ((return
+ (cond ((string-equal operation-name "get_status")
+ debbugs-test--bug-status-soap-return)
+ ((string-equal operation-name "get_usertag")
+ '(((hi))))
+ (t '((0))))))
+ (if callback
+ (progn
+ (funcall callback return)
+ nil)
+ return)))
+
+(defun debbugs-test--override-float-time (func &rest rest)
+ "Override `float-time' for FUNC with args REST."
+ (cl-letf (((symbol-function #'float-time)
+ (lambda (&optional _specified-time) 5000)))
+ (apply func rest)))
+
+(defun debbugs-test--setup ()
+ "Mock network and time functions.
+These mock functions are needed to make the tests reproducible."
+ (setq debbugs-test--soap-operation-name nil)
+ (setq debbugs-test--soap-parameters nil)
+
+ (add-function
+ :override (symbol-function #'soap-invoke-internal)
+ #'debbugs-test--soap-invoke-internal)
+
+ (add-function
+ :around (symbol-function #'debbugs-get-cache)
+ #'debbugs-test--override-float-time)
+
+ (add-function
+ :around (symbol-function #'debbugs-put-cache)
+ #'debbugs-test--override-float-time))
+
+(defun debbugs-test--teardown ()
+ "Restore functions to as they where before."
+ (setq debbugs-test--soap-operation-name nil)
+ (setq debbugs-test--soap-parameters nil)
+
+ (remove-function
+ (symbol-function #'soap-invoke-internal)
+ #'debbugs-test--soap-invoke-internal)
+
+ (remove-function
+ (symbol-function #'debbugs-get-cache)
+ #'debbugs-test--override-float-time)
+
+ (remove-function
+ (symbol-function #'debbugs-put-cache)
+ #'debbugs-test--override-float-time))
+
+(defmacro ert-deftest--debbugs (name args docstring &rest body)
+ "The same as `ert-deftest' but runs setup and teardown functions."
+ (declare
+ (doc-string 3)
+ (indent 2))
+ `(ert-deftest ,name ,args ,docstring
+ (debbugs-test--setup)
+ ,@body
+ (debbugs-test--teardown)))
+
+
+(provide 'debbugs-test-helpers)
+
+;;; debbugs-test-helpers.el ends here
diff --git a/test/debbugs-tests.el b/test/debbugs-tests.el
index f3abea2837..da1b9dffe6 100644
--- a/test/debbugs-tests.el
+++ b/test/debbugs-tests.el
@@ -27,118 +27,7 @@
;;; Code:
(require 'debbugs)
-
-;;; Helper Data:
-
-;; Generated using this:
-;; (soap-invoke debbugs-wsdl debbugs-port "get_status" [64064])
-(defconst debbugs-test--bug-status-soap-return
- '(((item
- (key . 64064)
- (value
- (package . "emacs") (found_date) (last_modified . 1689593050)
- (affects) (date . 1686745022) (fixed_versions)
- (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>")
- (blocks) (archived . 1) (found) (unarchived) (tags . "patch")
- (severity . "normal") (location . "archive") (owner) (fixed)
- (blockedby) (pending . "done") (keywords . "patch") (id . 64064)
- (found_versions) (mergedwith) (summary) (forwarded)
- (log_modified . 1689593050)
- (done . "Michael Albinus <michael.albinus@HIDDEN>")
- (source . "unknown")
- (msgid
- . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>")
- (bug_num . 64064) (subject . "[PATCH 0/4] debbugs improvements")
- (fixed_date)))))
- "Mock result from `soap-invoke' for bug 64064.")
-
-;; Generated using this:
-;; (debbugs-get-status 64064)
-(defconst debbugs-test--bug-status
- '(((cache_time . 5000) (source . "unknown") (unarchived)
- (keywords "patch") (blocks) (pending . "done") (severity . "normal")
- (done . "Michael Albinus <michael.albinus@HIDDEN>") (location . "archive")
- (log_modified . 1689593050) (subject . "[PATCH 0/4] debbugs improvements")
- (last_modified . 1689593050) (found) (tags "patch") (package "emacs")
- (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>") (archived . t)
- (blockedby) (affects) (mergedwith) (summary) (date . 1686745022)
- (fixed_versions) (id . 64064) (fixed) (found_date) (forwarded)
- (msgid
- . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>")
- (owner) (found_versions) (fixed_date) (bug_num . 64064)))
- "Mock result from `debbugs-get-status' for bug 64064.")
-
-;;; Helper Functions:
-
-(defvar debbugs-test--soap-operation-name nil)
-(defvar debbugs-test--soap-parameters nil)
-(defun debbugs-test--soap-invoke-internal
- (callback _cbargs _wsdl _service operation-name &rest parameters)
- "Over-ride for testing."
- (setq debbugs-test--soap-operation-name operation-name)
- (setq debbugs-test--soap-parameters parameters)
- (let ((return
- (cond ((string-equal operation-name "get_status")
- debbugs-test--bug-status-soap-return)
- ((string-equal operation-name "get_usertag")
- '(((hi))))
- (t '((0))))))
- (if callback
- (progn
- (funcall callback return)
- nil)
- return)))
-
-(defun debbugs-test--override-float-time (func &rest rest)
- "Override `float-time' for FUNC with args REST."
- (cl-letf (((symbol-function #'float-time)
- (lambda (&optional _specified-time) 5000)))
- (apply func rest)))
-
-(defun debbugs-test--setup ()
- "Mock network and time functions.
-These mock functions are needed to make the tests reproducible."
- (setq debbugs-test--soap-operation-name nil)
- (setq debbugs-test--soap-parameters nil)
-
- (add-function
- :override (symbol-function #'soap-invoke-internal)
- #'debbugs-test--soap-invoke-internal)
-
- (add-function
- :around (symbol-function #'debbugs-get-cache)
- #'debbugs-test--override-float-time)
-
- (add-function
- :around (symbol-function #'debbugs-put-cache)
- #'debbugs-test--override-float-time))
-
-(defun debbugs-test--teardown ()
- "Restore functions to as they where before."
- (setq debbugs-test--soap-operation-name nil)
- (setq debbugs-test--soap-parameters nil)
-
- (remove-function
- (symbol-function #'soap-invoke-internal)
- #'debbugs-test--soap-invoke-internal)
-
- (remove-function
- (symbol-function #'debbugs-get-cache)
- #'debbugs-test--override-float-time)
-
- (remove-function
- (symbol-function #'debbugs-put-cache)
- #'debbugs-test--override-float-time))
-
-(defmacro ert-deftest--debbugs (name args docstring &rest body)
- "The same as `ert-deftest' but runs setup and teardown functions."
- (declare
- (doc-string 3)
- (indent 2))
- `(ert-deftest ,name ,args ,docstring
- (debbugs-test--setup)
- ,@body
- (debbugs-test--teardown)))
+(require 'debbugs-test-helpers)
;;; Tests:
--
2.48.1
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=v2-0002-tests-Use-unwind-protect-to-ensure-test-cleanup-a.patch
From 1f59c38fb149ec8b5716e89135e9d2fb46c687d9 Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Fri, 21 Feb 2025 12:47:28 -0500
Subject: [PATCH v2 2/5] tests: Use 'unwind-protect' to ensure test cleanup
always occurs
* test/debbugs-test-helpers.el(ert-deftest--debbugs): Use 'unwind-protect'.
---
test/debbugs-test-helpers.el | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/test/debbugs-test-helpers.el b/test/debbugs-test-helpers.el
index f98bab40ed..7ea6f00dce 100644
--- a/test/debbugs-test-helpers.el
+++ b/test/debbugs-test-helpers.el
@@ -136,9 +136,11 @@ These mock functions are needed to make the tests reproducible."
(doc-string 3)
(indent 2))
`(ert-deftest ,name ,args ,docstring
- (debbugs-test--setup)
- ,@body
- (debbugs-test--teardown)))
+ (unwind-protect
+ (progn
+ (debbugs-test--setup)
+ ,@body)
+ (debbugs-test--teardown))))
(provide 'debbugs-test-helpers)
--
2.48.1
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.
Received: (at 76446) by debbugs.gnu.org; 21 Feb 2025 12:03:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 21 07:03:24 2025
Received: from localhost ([127.0.0.1]:55781 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tlRkZ-0006mQ-51
for submit <at> debbugs.gnu.org; Fri, 21 Feb 2025 07:03:24 -0500
Received: from mout.gmx.net ([212.227.17.21]:56869)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <michael.albinus@HIDDEN>)
id 1tlRjg-0006eC-9K
for 76446 <at> debbugs.gnu.org; Fri, 21 Feb 2025 07:02:31 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de;
s=s31663417; t=1740139341; x=1740744141; i=michael.albinus@HIDDEN;
bh=yi1I1slgDWtyL/djILFTUbaXtNk1pbQ0ZG8BtaVyeBA=;
h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date:
Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding:
content-type:date:from:message-id:mime-version:reply-to:subject:
to;
b=uZ5MJygaOY1j6o6st6XIYOTBaAIjK6/619vIGZxK4kIAOshynPl7BFchXZtb3uqm
OFXjsYl3v3T7TX4Qgf8c2ruOtKN9atcfkGWyEJ/UqPmeOztyqBXR8S89siHWYETYU
65UD1S3oGtoWYqw3d5NslA1eYwtVa+XvObi4430CdEPwO9YUeUFmxCyiWEjNWwJ4P
EWTMI7FSN6YNbi4RLwjWDnkQAKE12zy8CwZDqfi8Xw3+Xpmhr0bRX1sY2oSC+EUra
DVDvOLuqzNZYJJJaN5f5ulKqd3qQmwiwMi4e7JP28X+NhdXiP7dxNdnrukVsZi78K
mtLmAtIRhqeL6ZUghQ==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx105
[212.227.17.168]) with ESMTPSA (Nemesis) id 1N4Qwg-1tMjcZ1cHu-00wvLR; Fri, 21
Feb 2025 13:02:21 +0100
From: Michael Albinus <michael.albinus@HIDDEN>
To: Morgan Smith <Morgan.J.Smith@HIDDEN>
Subject: Re: bug#76446:
0003-Makefile-Add-target-to-run-checkdoc-on-all-files.patch
In-Reply-To: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN>
References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN>
Date: Fri, 21 Feb 2025 13:02:20 +0100
Message-ID: <87v7t3wlo3.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:JITi1PrkT1EfKIX4Y5/xWWVtQbImsPkFh8gUTn5Ol/dEE7CNAhR
jaxiZWJiIEsy0MtigiQWHbZYJ26XGkqbXhtCVYYXwouYvrRN+XJqYlS4Dvp3nCnItRV8cX9
/tR1jQFHZ3TPe2+OY+NVWrhtMUx3mvTTQW8bx+L9Nb97fcnSsQZi1dFxYhmoi4oiC3Qs8c8
J82YyxAfsC0z+Vb4XplfA==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:jetl3ntci28=;63zyQCWY0Rd3g0mo+Dv6+3F5GRQ
iq0qIQDEtyCN4d9RqnANtqBewHgucCr5fTDZ8EVDIYNRV0vWb73i2XWxa6dvXF0TF1E0sIE1b
Mhxbh9iAeDLBYFq53lzJQ90blsdDjX8FsfNBQAStO7b4HSECEKByaxMVdiE9xvOUcw+ucc8C9
+lxFFL67W453G/dnH2YgLl/Ugsi3wKK25hVMJgv4yBPveMnVYBEjtNZdg+LzX1TcSOoFv+3rS
yHZPZliOKjTXbbLRBP4dA2kJ0AcvIvBbTkOnGHq8zdAnNoaxp0PNAxapPjlyuHA/+EGbAbsPD
PA8B/8YJdfW+QcafNqXE1u4SRy/bqVSguXyzHk2RhaQdMCmL0LLlRuqooEeVFs8qJZZPKX/kq
MMyr0i2UDmHi9oJcLX3DHPJ4OKI/wRPk/q33KQHFRJXIwfnvTztBJI65/jcsaxW4U9PKDjT/o
XvQUF2oaklGrkHONfrY5hrX+V//wDrPA4PJ+vv47ph79pL+C5jA1UnaHwPXb/9Yu47LSqamrN
xq/hMo/nbp7M+RhdM9fRpqcqA1Cg7Dcb1BaLPq9m+nBpmBm7ScwwGBs1EQNo9fYArHBPZ26tV
jOyXU1Up0m4xfmoi0Lf+4MqnddfJjChxU1i57bgjbWod7HSHJQCt1cybOehVzN2SlOva4bZWm
Wf42ZGnqy4etexthVc0/946aZMYJFarFxj1Sal9H1WAooV+N/SfHELoqdeKVYh7o2+sqng0Yj
UwXEsyyIiScnmhx9/WG90s/48mEwxDx7Vx9ZJeCPgwvQe/Ap7CHT8jU7O6D+mvVweHvvD+Aw0
HdEyHQSSQjrcfpDMxItGiN2kaQxfOvJpXVROwO/P2XATrTqlICBfoNIyXHVLr8et6cRpBQ/ls
165VWVSLUfOF+EI0Ylfbpqv8A1S0ZAc8JXodD4iZ9FtmSeLydwGUySlGxKTBKdH4GR7IhXbaT
lg7jLd9pzYHQnYf1Hg9TU0q8i4YMtmnCOih6dxXReQZBtQzHhsI3Llm9Rdod3N7ps+/LEKNsa
I08Slyeb6GEroLC+5JnfQPgFpky1SgFXQvgXRS/pV/dwn5inT/cLkJpLammIvFGfVHv5M5AXm
tNy3A6ZVjBOYIwr5NrKBKa1xmKUMkYt4rcFV5t1Rq+xujc1JHf4vtBc8fcuPfLWnVRV3mSwBd
AsBBBZX8nDTLC86vtPx8X3UTzc1P4Zqh1cFLJ3CIJrzQLz6wZXAnLiHoxpou0s4Pj/9QTaLJN
FgKfnqyHO+RuOhaYp5AL9dYU06MN3wIymwA15ik5hisekOjTYEm9Hx+zfdSfKgHSOgZJaShCI
I8FyKBRjfC+yMTVWX4fd0IKf4nmqAUCTQ19eGrsY913k9cUFU9XvroAJul/jftw20HVWBTo7O
HsMM/JPe3vLen27+Nisnqr6E4FDlWbK/zUv8l71Z9+pUE0ZoPxHY+yDbBd
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 76446
Cc: 76446 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Morgan Smith <Morgan.J.Smith@HIDDEN> writes:
> --- /dev/null
> +++ b/.dir-locals.el
> @@ -0,0 +1,18 @@
> +;;; Directory Local Variables -*- no-byte-compile: t -*-
> +;;; For more information see (info "(emacs) Directory Variables")
> +
> +((emacs-lisp-mode . ((checkdoc-package-keywords-flag . t)
> + (checkdoc-ispell-lisp-words
> + .
> + ("ChangeLog" "ChangeLogs" "UTF" "alist" "args"
> + "armstrong" "backend" "bcc" "bugreport" "cdate" "cedet"
> + "coreutils" "cygwin" "debbugs" "debian" "el" "emacs"
> + "etags" "freemail" "fsf" "guix" "gw" "henoch" "hu"
> + "hyperestraier" "keymap" "magit" "magnus" "maint"
> + "maintainer" "maintainer's" "mbox" "mboxes" "minibuffer"
> + "moreinfo" "multibyte" "notabug" "paren" "persistency"
> + "regexp" "rescan" "rgm" "rmail" "severities" "sexp"
> + "solaris" "src" "sublist" "submitter" "submitter's"
> + "subproduct" "subqueries" "subquery" "teardown"
> + "unarchived" "unibyte" "unreproducible" "url" "util"
> + "wishlist" "wontfix" "wsdl" "www" "xsd" "zltuz")))))
This is needed for the checkdoc target in make only, isn't it? Shouldn't
we activate it for just this case?
> --- a/Makefile
> +++ b/Makefile
> +checkdoc: $(SOURCE) $(TESTSOURCE)
> + @$(EMACS) -Q --batch "--eval=(setq enable-local-variables :all \
> + checkdoc-spellcheck-documentation-flag t)" \
> + -L . $(foreach file,$^,"--eval=(checkdoc-file \"$(file)\")")
Do we need '-L .'?
Best regards, Michael.
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.Received: (at 76446) by debbugs.gnu.org; 21 Feb 2025 11:56:55 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 21 06:56:55 2025 Received: from localhost ([127.0.0.1]:55669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tlReJ-0005rE-0f for submit <at> debbugs.gnu.org; Fri, 21 Feb 2025 06:56:55 -0500 Received: from mout.gmx.net ([212.227.15.15]:51649) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <michael.albinus@HIDDEN>) id 1tlReG-0005pj-A1 for 76446 <at> debbugs.gnu.org; Fri, 21 Feb 2025 06:56:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1740139004; x=1740743804; i=michael.albinus@HIDDEN; bh=bWKFvvU5kMvUensnc6t6fdiMW1hF7XWYBNBOTUWwuZI=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=DcO1k++ipajTZ3Iw7t6XJ+uKjxfV+7lSkxpqksJZ1yOMcwkCzWNXwg7mlcTQ2LXy 5ay/g2Ig0kYumyCzqSJH5PCc1ufaLyp9iB+ditE0qKo3HHpYxF+NlI75mWySx3e2o 6zNHc5fDlnCgyWv6WJYwFa2AIT7cJSJldoIB0PWMkKgZzYlQzBlTcgq6FH9NEFy4i IjglLIycXCKyCXqn2vZCnjZ16uqyXOLlUn0d6pXz+9f63DfzUaDaaVUZcOIqYMqVj SL2dLIk3J/9JxcVjLZmsYThwgCn42gS//x5QXXr2H6+Joj8yEXFZ1IKZUZwaRzjXV 84eNx77ipqVJpBRawA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MVvL5-1tvWEj2pi1-00Z2Ol; Fri, 21 Feb 2025 12:56:44 +0100 From: Michael Albinus <michael.albinus@HIDDEN> To: Morgan Smith <Morgan.J.Smith@HIDDEN> Subject: Re: bug#76446: 0002-tests-Add-tests-for-debbugs-gnu.patch In-Reply-To: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN> References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN> Date: Fri, 21 Feb 2025 12:56:43 +0100 Message-ID: <87zfifwlxg.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:APjAnCYZQpmVJxVM8krd3RWytGOqbG11xO/+K3Reax2DNiRDU/p IsGC2ohDNHrc2ObDcTbNgZFm5WDECCqVBnkLxPibTAL/1gBDTgR7hQh9mr013+ECEiPKwoA k0+xsT9MKoMvBFdssTkoguf9y6Lc7yX2NYmJy2RtEpnunQfhpkaoaz0cIY4ppmHPkCHccF1 JBByxLTmN/cV/4Xi7M+4Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:DD9Xz0itysY=;0gdOPlZ4hItqtZMwPlNrtjNd/fJ AR51B9SxmGgL5S54z88eGrQoY+NYeGM0kWjH86E61T1tw/HKRimc0yQNHEWUzxP3gJBRD+H0r A1HcgbU2bDRvcMb3yshpW5OEt2yXGZ7ePaQP1jzsNmNo470kZEGCrcumNm5kOT7a+W/5cpkbE 0HJtAO7Eu0ee090pmbMpFVM6FD675o0OnkGYuWkeiXlFam+Yuf22w26Cgj8nrCfI9ajDBEkoQ HTzADT++sc50nipnXIzJQEtBevM6ugi/A6gAA1Xg5ltSs3niarM69yExoCr1yxp77g9apXtrh 6OSHtHbUsrT+9qhTnZaejGvYrag4GJhCTSyFhDiLcj1tulV7ynVB898urQ9jQ92fBF/ul8dJ0 dgaNsVfwjmGJGQ2ardA6Jrf8192CSegtPvZncRSkTXLXnB4VKfwHzd6111K3Ogyz+2U133Yoc W/lhHVO1qnGF2o3moxe0qXQA1kBXxaoq7AIBCC7WBNhVDv9FcalHUet5/EnKhuZ10Tm7RfU7t d3oLR2hxyev6hn4w5X/SZp1MUCkRFk7xTu6iWNQW0M8PsGIeGM4oeDQ7Yg5KtYNpjtRg6hP5X PW6nhH2GaVVhUNUsbJtZvhc+fIbaaIZ6z7VdsQMz9PQDzAHnS8F2OKRKRdE+Jy8GTZP9YE5mD sy10rUTYP6zlLSQsJ+U5FOs/T0taU9aPS01QTXGO/O9tAs6PnUTvdJfIe9lZe0FTHhxmN5XVk XMO+KwE5ITL8GCydYRyM0nHr+/avqWyzMKBtqQzR/Q8+x+7KCTVYnmtaouoK2BlczyjTGkQXJ a5QfLqPbB91Eht0glybXsfC/mP71OfywNeSC2yMQxvxJ1mulJjQbP7sCVnksx9GiCgw5fBGy/ ebr3OrZ3p/zdS/SOxazB+m3VN187EFwTTgAP3ENpC0U3+dhiv6wUMA9uxJQKy4u39l8e1OZKa 7WVpquNmovI8wq87ibqaFPZcuZqftN3yRHXX02HDR69PZtiM09+LdVkQpqXxGgntFDX8WJnD1 EhDrbM3rK9JBvwutfho+9UAjNNx084TqCEpMfFopCjZXpdFjr0D7y7hDpeiYhNWvzYYkS6u1E IinTy7zYgXFwesrsdPkYOh8RAcudmtNP7qfKW77U8okN+jm/vydSxs6ef/G7L3qAPqjvMG0VZ CZD+mk4ss8PdFK8FHEYLw2bb8mGoEl4Nf+tES8Ca813DyyeXGM8Wi0IgPYoB8ytg4RA+INnRf TUIJnxYP4kDM0IJOBQFuTXEV3ks3eqBSVwdb4HD/XRVWv5YHYl2i5rzz3lrkNx/Jdkgfbz2pV rZlJbzWGuGd2HpDxpMESZCLbMvzwZwwkFW1gkIYyZY6KBUsmKhOi+tLajuh6Xua5eH3u98BWG 0x+6vBtJ22KYsh82x0M8+8tZt/lkN/FbCh+MDEKefou4WXMufSh6uiux4T X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76446 Cc: 76446 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Morgan Smith <Morgan.J.Smith@HIDDEN> writes: > --- /dev/null > +++ b/test/debbugs-gnu-tests.el > +(require 'debbugs) > +(require 'debbugs-gnu) > +(require 'debbugs-test-helpers "./test/debbugs-test-helpers") (require 'debbugs-test-helpers) is sufficient. > +(ert-deftest--debbugs debbugs-test-debbugs-gnu-search () > + "Test `debbugs-gnu-search'. Isn't it rather a test of `debbugs-gnu'? > +Also test `debbugs-gnu-patches' and `debbugs-gnu-tagged' which are > +simple wrappers for `debbugs-gnu-search'." Nope. They are wrappers of `debbugs-gnu'. Best regards, Michael.
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.
Received: (at 76446) by debbugs.gnu.org; 21 Feb 2025 11:52:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 21 06:52:31 2025
Received: from localhost ([127.0.0.1]:55597 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tlRa2-0005Bf-2e
for submit <at> debbugs.gnu.org; Fri, 21 Feb 2025 06:52:31 -0500
Received: from mout.gmx.net ([212.227.17.22]:42465)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <michael.albinus@HIDDEN>)
id 1tlRZz-0005AV-2W
for 76446 <at> debbugs.gnu.org; Fri, 21 Feb 2025 06:52:28 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de;
s=s31663417; t=1740138738; x=1740743538; i=michael.albinus@HIDDEN;
bh=tTaReb9YoGwN5K11wjQJNJWzkDfgadXv+vOh7QJOpF0=;
h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date:
Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc:
content-transfer-encoding:content-type:date:from:message-id:
mime-version:reply-to:subject:to;
b=L0n2M6gMIzZ1I0Hr3bok6gfTkOjlwzvK8Cw2iJSwhm6T22iJnU9kVMfNbecMyhrK
z+wM/gESBcJKixKnQkp251cO1mV0ug2Z2hF6C3PFt+vRbb2SPOrki1zfdWjBAhSqm
g/qkS7Ez198KEsyXnJVOKIJ/7jUEYoOlvDehuuTczsMJs4R6nEVRXCCc+3M45mUSJ
3lpu9bA6yGCEJc1uKuZ8Im9yG76JPIpeB+ncoXzIAgt/KUp72jjlIKiIjQIC8m4hz
inSLLVvsTxG/AG5Ur0ioi2oGZgfuzH2YdF2OrKpebHw9xR+zZXP+EoVjy8Mgf+Yfr
8Y01Kh2FzCOADFElDA==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx104
[212.227.17.168]) with ESMTPSA (Nemesis) id 1MTiTt-1ttJNc3eG5-00Kkyi; Fri, 21
Feb 2025 12:52:17 +0100
From: Michael Albinus <michael.albinus@HIDDEN>
To: Morgan Smith <Morgan.J.Smith@HIDDEN>
Subject: Re: bug#76446:
0001-tests-Move-helper-and-wrapper-functions-into-their-o.patch
In-Reply-To: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN>
References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN>
Date: Fri, 21 Feb 2025 12:52:17 +0100
Message-ID: <874j0ny0pa.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:QbUQM9U+BUrgoYCKMrO/pFW+mqqRYMMFo+pyB1F5+llRh2fNWTg
oK8gm/FTs9b0yPizGlHfyX2WZwKmOC9C9gv7/Pc3L/w5GClf0lPVWa6Ag46QO5KUaVtKLXa
1f/rdrCOWE0b3W7ys295mTXub6sql77gXuffz1rQzxJe800j4GYCAb9YFZcgE/HEj3hvMq+
FxWAuBQVGpNN1zIwDS1Zw==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:CYB6Gk+bE/A=;EtCE1DCBeQQpG4yaSP0GG+ge8i+
OcqBN8pzqYBPXvU/bseT2MJ7zqwIeYqpqWueXM7yrgyP7i9SUGjWoNlz5QdvcGNFn1WfILfU7
CqBGLYl1FYc91bJvvKkhNqKcFi/XfY7C1nMwf7aKC+3ghDebYG+uqJSvM5+uodGghzDE3t8uJ
pEYQWTExnvWxvrmKLDN/zXkdFsXoKeWBtwRxbs7RmyvxgsSAjXW9fUgSCoI1KS/K0sJ/HEcsr
qATegq1G7phKcCcuT3e6eRnYpjJczbl16gKAFFW4yQmmmcyfV6ZnljWia+AY0e15w7aR74RFP
W96a3TQcjrUyzOSDEzpRTdfWFVe8I1NzNjbA20sRDlgo5xqUvUd0VAwVUhdqKiBIKoEofiRJ1
stzMELjxRdyLlVFek1eDYv1euqPRRr8FKXaRrBUWs0J/KeiU48bzNYeTglc4MKO+Pryt8SkU9
/YIDnG3aRmyvmOYb6tw9Wy/mRZ5q3KkvORCiP/krqo1C3DwImWutx1ynOLUP+VsYk1562OJWq
0KHqREdFZCDYPNAphI83AN5V+om4RVfWJelpL41dgm1PdUTPco47oh8kk26IwK2uULY/SfKPj
mpzsf6GpIgPacqc3i57cWuUP3LIP/YfZPJiTopjq1l5SoRaTH/QlYp4SwNtSuHSmY7RAxTeb5
JupQTjpY6/+lgYyc+Fl1tuCMdcHdjXymNKhBczR8jlHGBKvtNgfR4HyWWW8sGqUCjxXaayCne
jdGpc4XzH8mAje/y0qP4oFjp8S8p9NemvszNBMgveckjdgfiDjddpsYIRnm0u9BRQaVvJa0t1
QAuj9X4e+WJjm/uUDJH+fXDtlBHerEXBm2dvl1hfePmMWp65GiOlPf8D9CgEWNM1lmAeFmjC5
93xzDfTmw56FavFYTUgTfxZ2MLr9wpztmMvxAuRmqExSwiH7W8wFZ5m0ZgHoBoMtfltii8T+P
R9Nt+xxCsQTwio3cU+vCtJCvevsHa+TnSBBB4U3DzVnzxcRpBF13IdXR0tb2U7k8QYLcDuvsf
3oyYxFmpgPhsAeYW/IqEi8Zp8N0JSFo+A/FmCfP4MOATt5Dmf3nJfQlk9Fb2h8jHR3s7q2y7B
ims2RPvOdPLCow7SRAXrg9NIFior59DAiXYl+4q4EgrzbajumDmjdpV+p7P5tEPqYaKhJGRIG
EFu1N9aLeHkTZaJGI1RKVfbuGAocgYxv20sT21ypJrlkvxBl7INNEG9+J4mgRZft20hI2JXtY
gPINcrS23jotbKaotPXi8stxS2f+GBJxG6C7j+exArtJ/5PHurCaU7SIw0adK7Nt2TlwV9Z6P
Uihz/EipJhZjx0EuReUw8CIKffDh8TgX9e2MkXCpnnc7UozFgmCRB5KOvKYpjEPsoyTYI9ZYQ
Uc1Sly9EYQoy9En8FXqOOOTGtXlSKD2g9duqS9UnKi2zorwqS4phabeHzC
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 76446
Cc: 76446 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Morgan Smith <Morgan.J.Smith@HIDDEN> writes:
> --- a/Makefile
> +++ b/Makefile
> @@ -24,7 +24,7 @@ doc: $(INFOMANUALS)
> build: $(TARGET)
>
> check: build $(TESTTARGET)
> - @$(EMACS) -Q --batch -L . -l $(TESTSOURCE) -f ert-run-tests-batch-and-=
exit
> + @$(EMACS) -Q --batch -L . $(foreach file,$(TESTSOURCE), -l $(file)) -f=
ert-run-tests-batch-and-exit
We might be better with
=2D-8<---------------cut here---------------start------------->8---
@$(EMACS) -Q --batch -L . -L ./test -l $(TESTSOURCE) -f ert-run-tests-batc=
h-and-exit
=2D-8<---------------cut here---------------end--------------->8---
> --- /dev/null
> +++ b/test/debbugs-test-helpers.el
> @@ -0,0 +1,146 @@
> +(defconst debbugs-test--bug-status-soap-return
> +(defconst debbugs-test--bug-status
Perhaps we should move these data into an ert-resource file (or two).
> +(defmacro ert-deftest--debbugs (name args docstring &rest body)
> + "The same as `ert-deftest' but runs setup and teardown functions."
> + (declare
> + (doc-string 3)
> + (indent 2))
> + `(ert-deftest ,name ,args ,docstring
> + (debbugs-test--setup)
> + ,@body
> + (debbugs-test--teardown)))
In order to ensure that debbugs-test--teardown is called even in case of
errors, we could use
(unwind-protect
(progn
(debbugs-test--setup)
,@body)
(debbugs-test--teardown))
> --- a/test/debbugs-tests.el
> +++ b/test/debbugs-tests.el
> @@ -27,118 +27,7 @@
> ;;; Code:
>
> (require 'debbugs)
> +(require 'debbugs-test-helpers "./test/debbugs-test-helpers")
(require 'debbugs-test-helpers) should be sufficient with the proposed
change in the Makefile.
Best regards, Michael.
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.Received: (at 76446) by debbugs.gnu.org; 21 Feb 2025 11:41:30 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 21 06:41:30 2025 Received: from localhost ([127.0.0.1]:55397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tlRPO-0003aJ-0t for submit <at> debbugs.gnu.org; Fri, 21 Feb 2025 06:41:30 -0500 Received: from mout.gmx.net ([212.227.17.20]:35727) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <michael.albinus@HIDDEN>) id 1tlRPK-0003Z4-Bx for 76446 <at> debbugs.gnu.org; Fri, 21 Feb 2025 06:41:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1740138077; x=1740742877; i=michael.albinus@HIDDEN; bh=0P6wjHR/wN3b5IHn0RSTUWjSK09I3SbCIw7MUpzL65Q=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=p2UOrRReAx6ZYpT4alpdgp0FpKvbwz0xTRocw6w5AWwkF3qVPRLoVxypeRZKDfOO yiS4QEMwhCIEf5/H54UPfPh8LOorwpeojXOhCXVr7xo564y6aI1ToSqlsjSwdKn9L OD6m7+5mhpRY2mHa74s/OfMNn2kW60OlzZ0yOIVIFLkcRllQ2rmELJc+9MZiW9Vv6 Y0bn4U9swFNucrseYv/Xb8l2404ogaFz9mZSAtFNQAm/vHrcs6dYwhHYTIpxKHx+C RmfFYEeSYQemEJ5edg4PwJSdqU++wIRb1SZwQ/NcC96WAOFBcZ/xgjfAGqi6e8dlI rWBV1V0uhHS+E+D2hw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mv2xU-1tTuYP0XPk-011T2s; Fri, 21 Feb 2025 12:41:17 +0100 From: Michael Albinus <michael.albinus@HIDDEN> To: Morgan Smith <Morgan.J.Smith@HIDDEN> Subject: Re: bug#76446: [Patch Debbugs] Infrastructure Improvements In-Reply-To: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN> References: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN> Date: Fri, 21 Feb 2025 12:41:14 +0100 Message-ID: <87bjuvy17p.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:nHk/D7IzASRi6e5H3GtEZbyjBtoE9ata5xlDOHFaFOerHm09dCw S+qLTI8Bk5mW8FJ5nkjTsbkjxcBWBQbgF8i40DIUBPbYXfzu8tJEMyV+nxwm9I/QE6OVFu3 Rx4GfJtR5N0VSio6uQDPx1sO1YtsaOJyR9vJNpsVWYf5Pq8Onfy5Ho9TAUlM4h9FIfYyM4l mcP+GjKtjGbYCaY8TK/oA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:IV9sMUEpCTA=;h+3JbK7Di2abDfccn5Q+z1dndie bazZSY0cGLgVxkn1D5pfwPkSdsSfMpXknp1YFgTUYoDr8qrpnJvhtraxJtpP4sLySkSToic7r a160LZyQST5CuDz+pF6kA2LeQvN56bN35GRdnPDvfb4NcWukAvqyYrjCFpd3gCyLi+gd9P92U dCJM3IBD2JyVv3r8PFyVD3/IQuGq1oSHPN2Dmg7gz0p1ffSFj+aY+Y215vRbWGDUZr5atLeB7 0qYfnDk4N67f+veHlu65ckcOnGvS8Hls3C0WJhXVZ5dqvRJuUU7CmnXM8AD00rXspae3T9wXU cxceN7XRPvmcvnOLpFOSJX5UYnDZsyCi0ghIH0D5VkbJOLygOzSDLxWPqWxVVEqKqds3X0Hf0 b8O07E059IC+9iC/m23p8JlzIG19+bu0XjGtDDYBAV9SUGC6RpNo9e5hhrNzYNVnIhZFJ+x1S RmS1F1mDk7Xpvg1wYxBgkS45YIEfuZ3x2T137oz4g0lM/qg+ZoxPolplD6hDxR1Oj+/HhFtH1 zfCbrwqSWzg5EW3ACGHkI3mncfoUEFSZtdCGKdB3utsBg4Ie8S7CN9tJMPguTCWNGoQD9t/Uf fBAjVq8IllfXjyGsTWd9xcI+Q0g2LDnCasotVG8WZyjoeYEgdYoXgnIQ70w02tqizD8LQF+bd usSoUEgza2LpKLh/0nNOvPS//5sdzkuAQTP66MmuECxqXGoDHwPkyssZFOi7hk6/dGLgJWr2I UL0G0XfxtiBwMqNUE7dD1QmiioQA1Z9WoD/n1SlwndKrf7S5NcrUIIzZf7aMRg1K8bZ2cZCsm e95G3XbkFjt6rofJe6NJWNoSTpWe/6b8k+BHEW0CdxdLg3On5o8j4fNHCmhdfHluhlu4NX9MI vZ/sfrE2aGRRHpvTZgNC3mSdUAd5sqndKrjOjmAz3swH1qNylKa/Qz+n/LJk09IFzdUTkpQsn cG5ajuk5n6ug1BgzBCsZP8kdrJLZfOX2nakVDdGg/Aaidrb4r/y6Z4Bq4lQ0fLHXWYaXZZYkx MHABAwlzHUellpHLQ01WIeU1/0cUnfoyY+IrkIbsF+WKLaAxdSC/9tf0LU6H/Hq9MbgbL3kXa 39A9m2iPyTqEmKt4tD6/IOoTCCMzHwV1t0xJA1UU8zYml1HkBIvtxiZC95rl15iIgNGm4D3Cr Vkcyytusy/goGQakQDGd4hg2tja6ubM24WfVa74veIqpZyGH1zaZ2MonlXU9LbB5Axz3Oimky nDHHFY48PABCir/QJzsW8oHSwEJZtD0fDhMYtB4hmJ40cAv4CNbdZ23Z5ME5dTYQ0V+kokcx8 HZykGP6bl8CtlS1ax6DCQWY340tPPEB9hFH1pJIWq2dBWczyXUZ2oFZa6+9hP3n9j/5yEmCrU ihxLvxg9MdNKtIMNscQWvjyCLf97T03mq6cKzaHJyi0wIV+eOdpmaMcUXx X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 76446 Cc: 76446 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Morgan Smith <Morgan.J.Smith@HIDDEN> writes: > Hello! Hi Morgan, > Nothing too exciting in this series. Just adjusting things so we can > split the tests into multiple files. Also adding a makefile target to > run the "checkdoc" stuff with the spell checker enabled. Thanks for this! I'm happy that you's started to provide also a debbugs-gnu-tests.el file. I didn't test the patches yet, starting with my comments on the code reading first. See next messages. > Thanks, > > Morgan Best regards, Michael.
bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 20 Feb 2025 19:06:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 20 14:06:30 2025
Received: from localhost ([127.0.0.1]:41073 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tlBsQ-0000NX-Mq
for submit <at> debbugs.gnu.org; Thu, 20 Feb 2025 14:06:30 -0500
Received: from lists.gnu.org ([2001:470:142::17]:37066)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <Morgan.J.Smith@HIDDEN>)
id 1tlBsM-0000M8-Gk
for submit <at> debbugs.gnu.org; Thu, 20 Feb 2025 14:06:24 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <Morgan.J.Smith@HIDDEN>)
id 1tlBsG-0002Cx-No
for bug-gnu-emacs@HIDDEN; Thu, 20 Feb 2025 14:06:16 -0500
Received: from mail-mw2nam12olkn2089.outbound.protection.outlook.com
([40.92.23.89] helo=NAM12-MW2-obe.outbound.protection.outlook.com)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <Morgan.J.Smith@HIDDEN>)
id 1tlBsD-0008V4-Vt
for bug-gnu-emacs@HIDDEN; Thu, 20 Feb 2025 14:06:16 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=hJNiKO/QjWQciX80UX/WwjxtSIYnrELiLOHU0GoQgG75PtEH3yETF7gDaYKUR13aJ7s/qzeeKju8QiLI3HN1+d0drbSZiI/ACP5pCtNnA9sX8f2rjllyFKAzQHmleE9+xdnnotW3BU8Op3JzvGYHBqBjsmgxxKSKMFofKbJRQbsipiTI2Htu6D+V859HAZnfMnimiCC0aSc5UqGahOtZ2WNmNGvgTTX+FLjs4q6uXO1pF23O+2NXBy7G2OhqTMa+f3LkYUBNiGHZPGEn2Ro+xyPEwDTXNw3dLMF5+Nn/vzZkptb2BbxI2VQyG7MwHU159T7JS3jeAUZUzJTONvRO3Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=EnU4czNbLnY+gCbp23Pgl+swggBPBXyAO6+Hn7xgPnA=;
b=X2rbdxDFqcZWJRI4j9t12HX90w0HVcIZ4++UQ+51fVK3AY1YOr4f/a8t1sJPjtBe96Me1GLWYK7fCajGR6YGNZa3CLL2jlnWGX6upOAjwMZgA4hbbY9cZr2//huGBbjtqOSQzn7PIZ5aJag6dLvKoX2do9QuvBX26Uqr9H/J0NDT0XrbKctMfAWkskDfhsWhaaJpPB73iSPocCoYQ6+j8zytI8N+NBKaaebr/7nEoIghaOuNqE+BFUQ2k9asyiMoKEMFR/dLbaCrvUUhwcA5Xod0rSShTbmtcrWExCB9o3LvQPlb70IDqjpS7042ksup52ar5FjeZPVyqaKEYGPd2g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=EnU4czNbLnY+gCbp23Pgl+swggBPBXyAO6+Hn7xgPnA=;
b=LhgAV7TxvnAc35rsGDB0eaVKpG28IFbPgSK08Z6iR//eIzbBhOhQBAnfBDBRJnF9rpQ4HUsjj60AjhQDT7+eHEgeoHbpUX+YPr1NaA2h/aknPh+YFaXoi20zm9loBrlBR6L2W1CvuoNEj+OCG3VT9KXMJBHTBWiWHnANdtJ8f3Wov3B+oRYZuVAf8xvwLj3vZyMxJIO3nNCrCLqKMlAZrkBBkx5KkbN+Pz4dtuFtOSS0UbBfn9sLu8A+QgJqudWtvChE1kgnSRLkhidxmsHKPLI6jdGjnv2qZTpJNFUGB8K1BCzcgbNN8Ow2oHb/LZuv7OlsxeTZ+5in+jCdSFf4zw==
Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17)
by MW5PR84MB2298.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:303:1c8::12)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.15; Thu, 20 Feb
2025 19:01:08 +0000
Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
([fe80::5c77:7a58:48ed:9aef]) by CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
([fe80::5c77:7a58:48ed:9aef%4]) with mapi id 15.20.8466.015; Thu, 20 Feb 2025
19:01:08 +0000
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: [Patch Debbugs] Infrastructure Improvements
X-Debbugs-Cc: Michael Albinus <michael.albinus@HIDDEN>
X-Hashcash: 1:20:250220:bug-gnu-emacs@HIDDEN::3sISYf09y7FKnZ7L:bns
Date: Thu, 20 Feb 2025 14:01:03 -0500
Message-ID: <CH3PR84MB3424A760E665315157019B5FC5C42@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
Content-Type: multipart/mixed; boundary="=-=-="
X-ClientProxiedBy: YQBPR0101CA0286.CANPRD01.PROD.OUTLOOK.COM
(2603:10b6:c01:6d::15) To CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
(2603:10b6:610:1c4::17)
X-Microsoft-Original-Message-ID: <871pvsfnkg.fsf@HIDDEN>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CH3PR84MB3424:EE_|MW5PR84MB2298:EE_
X-MS-Office365-Filtering-Correlation-Id: f783aa46-5faf-48c5-e382-08dd51e0eed3
X-Microsoft-Antispam: BCL:0;
ARA:14566002|461199028|15080799006|6092099012|7092599003|8060799006|5072599009|19110799003|440099028|3412199025|13095399003;
X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?5PjCsTk/qT2FV4tbYrMydN30oq9Egqy5TgFeZv/dp2JuVbDYBXIvoBQn6bQW?=
=?us-ascii?Q?QysZ6ugHiwH5haePdAoFGruFGL8/YIMFYzXvNLO0tu+grE2vK5jD7GcWa4cW?=
=?us-ascii?Q?49F9wxJM3/2+VRsaxN/qauBOm+sqZTIdkTyA/OU2MeaDMs0k+ZiyByp4poqg?=
=?us-ascii?Q?IFsxRZ9b38w5rthqjBWO8OdQeljrSngyiCkiGfC2KXLe5DzpO5n9v4PBTqG8?=
=?us-ascii?Q?RM9cbFEg0ZpwO9BcWuOQOmqKJcBnD1XEyGB4JTo2SoJTInnLcMdaTE7UdBCL?=
=?us-ascii?Q?wO1yX9jdjIIqrjYdEL11WdawrjQr1hZTsRtqxE1JFlrSt5mZC2VPepd1c5/q?=
=?us-ascii?Q?PmGST+KbIS1rAymXDyEMJ/pBkBeBh5+FQ13gSF6VVyUQ/tz9fthv51/iIGIA?=
=?us-ascii?Q?ylPYgdp5bu34LuoD89qTGgCxiz7m1jt7KV+SjjctQWR7Nyuk62crYRjGAbhf?=
=?us-ascii?Q?C64iVGg7U5vk/sgy+JOjm1KbolSQ0gfplgOUvK6EiqJIkyYbsGn4uwhAhFlQ?=
=?us-ascii?Q?LS+2zr4DJvR46aWXIBiA8Vu+JmGScjyecz1YVuW7pCr9kLjzoKoKxBkZKMwB?=
=?us-ascii?Q?FwGTBmxkjYF1FgycoCNfuNQbpMklsUiNd9DMgTYWBU/eevelHGUvvijxUCAk?=
=?us-ascii?Q?88lLFkcNjVqy1ANt40RR/lTmRKeehnzngtnXdBWASO2VNp85D34YVT3xxVu4?=
=?us-ascii?Q?i9WaaeLVmj/XcReib15YVPBmcxa/WCXvRv9ejjeYydvO5ZUwxaRuqA2SY0YQ?=
=?us-ascii?Q?HhE1aPCFMMYwQV2O1SZOw299XwDDexSyxr1wpPO4SWSoc/RJWhx7XbPgxY4G?=
=?us-ascii?Q?J8nAEByB/SGx6kB6EHq/goT6/Y2HJinsiiauwEnUi2yOo8hbZ3Kds41o2lqG?=
=?us-ascii?Q?w3wA0s9kpEbiCQwycsTvSFJe2RyFsqq1ZxOqObNpiCm9u7gYQ8UNQUN7zXMO?=
=?us-ascii?Q?GCSGhJ1cMEHmrj2nrBvf58OTlbeDLCuPHeixwtiIl2cO1kSCDP8uGL03ghGs?=
=?us-ascii?Q?4noP+t4gQL18gvVFsu+CI+KKjgd+l/7MlkQ84ZdCiTbJd+/AK44cvBpAY6jb?=
=?us-ascii?Q?5NHQ47BdFHO9rXf6dcKzp0CvTAMYusts3VJG4Sn/+W6KU3/+e/oB74HF/zNw?=
=?us-ascii?Q?O4FKFBTtiY3IEt/m1cckEF0s5yFeQwFo2Q=3D=3D?=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?irUcrVFaBcOcxFBcyGFGxUL5EWRrLnAWfDAMWYlVGjP/EfvSWdR+LAcqwsac?=
=?us-ascii?Q?6rmIO76TXUxTkeasBv6ZcGsjf8Y328QUlWAYqk6UeTq442+uQ8WHECESmt3d?=
=?us-ascii?Q?NBOEtpLxxDUECuTC18qyr1p2H+ypuepfxUZRTwdi0muRFPk+bGPOyBTj1AHl?=
=?us-ascii?Q?6JQs7lOU8t47ijBxgzoZS4dqA3yoJmB1ztYnwMCyzIMWB8QDXfJpryZ4VbO8?=
=?us-ascii?Q?ZYksGNAjgdPz1ABS/aCT6TYHB/UH8TClBlxUgZLmzF58ha/NdUWwlxVdPhBm?=
=?us-ascii?Q?1YamHnY/mWISqXe2WtIsB1xCTz+aUnevsqZ1oBQJYZYSZKG3JSil10X5t29X?=
=?us-ascii?Q?WzAJLq+VIfEk3EwMfvjJLgnKepGPY5LimvAaRJ6COo07qAHjvNKxXFnY9UiG?=
=?us-ascii?Q?YH5ZzOL6hFpJfhIwQuDOFkFZdlrvARacjCrjc3KcLl7TBX5wO+rYPbJECyqH?=
=?us-ascii?Q?nuE65FreJnKh/QOuwmb6EW6aOtQ+KuY1ecusvMyBxmSXoEILo8EfF8UXSxkK?=
=?us-ascii?Q?bYKhiMHccL2FrCuUOFwsD1lpVjT8O/y0f+ChC5pzUzp9h3R31O9XGS3fCZmP?=
=?us-ascii?Q?G00tzKi7OTWku0Jhl2pjSmDrLyP+vvEJ2NFQ03qULQhMD1F6sSkh7a2aIJ/8?=
=?us-ascii?Q?M5jVPn5CtMsqWG2smX/PMNuJUvbLHWLcjrTIyEQQAvYU9j1XgB902qApvNL7?=
=?us-ascii?Q?e5mbjwEce023pwwaijS9Ul9Vtg20PQYJbKK/+6Ycbq8wsErGOnktr3zPWviz?=
=?us-ascii?Q?sW3x6S4IdcRLJNp5rcGEJWwKfpz7FJ9ru+muJev0jy79yf3+xy3m6Kd/KG1r?=
=?us-ascii?Q?4/m/As3NN9pkL8SKzJu0AJCsq45irsXnwVf0z9L7ai/gNPtv4lAWEtmGSEFY?=
=?us-ascii?Q?/e4TCFrEFnUqIIcojpIXOHy6ymwLT89SGkOxfgMrJFCRCv3wBl8JDBDkL/hI?=
=?us-ascii?Q?3qXZbLz4DStMcR0dkG/a2/VYdPNHcKy6dEp5N0+MMR3Au9GtJ6DpRMP4fQXR?=
=?us-ascii?Q?8+5jnsGnWcDewhSeZTQWJ79AETJUOpI89v+rY9qGKdXY8lQuOMibilgE814Q?=
=?us-ascii?Q?u+9HXsZGNAAitEyNZ2ctTfPZ+uYpnW6EQvZs1s8PjCnnQIUnMwivT0EGs6Wc?=
=?us-ascii?Q?wELF+5dkW2y/vpm30v39UzcS+pyG0qJjRmgNEl/LD1dnEcLCPLRGotpMoL+V?=
=?us-ascii?Q?eV6HSrnLFkhp9Z4j74MUBUbtO9FsE4MVBPmwK8H/63i8c88MyjxBMeQ0weR+?=
=?us-ascii?Q?PKisynUignAv554jmfEM?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f783aa46-5faf-48c5-e382-08dd51e0eed3
X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2025 19:01:08.3824 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR84MB2298
Received-SPF: pass client-ip=40.92.23.89;
envelope-from=Morgan.J.Smith@HIDDEN;
helo=NAM12-MW2-obe.outbound.protection.outlook.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
--=-=-=
Content-Type: text/plain
Hello!
Nothing too exciting in this series. Just adjusting things so we can
split the tests into multiple files. Also adding a makefile target to
run the "checkdoc" stuff with the spell checker enabled.
Thanks,
Morgan
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0001-tests-Move-helper-and-wrapper-functions-into-their-o.patch
From 9c73769d4255c072655ff307939098a5dc058f86 Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Fri, 14 Feb 2025 16:23:34 -0500
Subject: [PATCH 1/3] tests: Move helper and wrapper functions into their own
file
* test/debbugs-test-helpers.el: New file.
* test/debbugs-tests.el: Move test helper and wrapper functions into the new
file and require it.
* Makefile(check): Load all files in the test directory.
---
Makefile | 2 +-
test/debbugs-test-helpers.el | 146 +++++++++++++++++++++++++++++++++++
test/debbugs-tests.el | 113 +--------------------------
3 files changed, 148 insertions(+), 113 deletions(-)
create mode 100644 test/debbugs-test-helpers.el
diff --git a/Makefile b/Makefile
index a7b6b0c7f3..1ab85d2b64 100644
--- a/Makefile
+++ b/Makefile
@@ -24,7 +24,7 @@ doc: $(INFOMANUALS)
build: $(TARGET)
check: build $(TESTTARGET)
- @$(EMACS) -Q --batch -L . -l $(TESTSOURCE) -f ert-run-tests-batch-and-exit
+ @$(EMACS) -Q --batch -L . $(foreach file,$(TESTSOURCE), -l $(file)) -f ert-run-tests-batch-and-exit
clean:
-rm -f $(TARGET) $(TESTTARGET) $(INFOMANUALS)
diff --git a/test/debbugs-test-helpers.el b/test/debbugs-test-helpers.el
new file mode 100644
index 0000000000..f98bab40ed
--- /dev/null
+++ b/test/debbugs-test-helpers.el
@@ -0,0 +1,146 @@
+;;; debbugs-test-helpers.el --- Helpers for testing debbugs -*- lexical-binding: t; -*-
+
+;; Copyright (C) 2024-2025 Free Software Foundation, Inc.
+
+;; Author: Morgan Smith <Morgan.J.Smith@HIDDEN>
+;; Package: debbugs
+
+;; This file is not part of GNU Emacs.
+
+;; This program is free software: you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; This program is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;; Please ensure tests don't actually make network calls.
+
+;;; Code:
+
+(require 'debbugs)
+
+;;; Helper Data:
+
+;; Generated using this:
+;; (soap-invoke debbugs-wsdl debbugs-port "get_status" [64064])
+(defconst debbugs-test--bug-status-soap-return
+ '(((item
+ (key . 64064)
+ (value
+ (package . "emacs") (found_date) (last_modified . 1689593050)
+ (affects) (date . 1686745022) (fixed_versions)
+ (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>")
+ (blocks) (archived . 1) (found) (unarchived) (tags . "patch")
+ (severity . "normal") (location . "archive") (owner) (fixed)
+ (blockedby) (pending . "done") (keywords . "patch") (id . 64064)
+ (found_versions) (mergedwith) (summary) (forwarded)
+ (log_modified . 1689593050)
+ (done . "Michael Albinus <michael.albinus@HIDDEN>")
+ (source . "unknown")
+ (msgid
+ . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>")
+ (bug_num . 64064) (subject . "[PATCH 0/4] debbugs improvements")
+ (fixed_date)))))
+ "Mock result from `soap-invoke' for bug 64064.")
+
+;; Generated using this:
+;; (debbugs-get-status 64064)
+(defconst debbugs-test--bug-status
+ '(((cache_time . 5000) (source . "unknown") (unarchived)
+ (keywords "patch") (blocks) (pending . "done") (severity . "normal")
+ (done . "Michael Albinus <michael.albinus@HIDDEN>") (location . "archive")
+ (log_modified . 1689593050) (subject . "[PATCH 0/4] debbugs improvements")
+ (last_modified . 1689593050) (found) (tags "patch") (package "emacs")
+ (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>") (archived . t)
+ (blockedby) (affects) (mergedwith) (summary) (date . 1686745022)
+ (fixed_versions) (id . 64064) (fixed) (found_date) (forwarded)
+ (msgid
+ . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>")
+ (owner) (found_versions) (fixed_date) (bug_num . 64064)))
+ "Mock result from `debbugs-get-status' for bug 64064.")
+
+;;; Helper Functions:
+
+(defvar debbugs-test--soap-operation-name nil)
+(defvar debbugs-test--soap-parameters nil)
+(defun debbugs-test--soap-invoke-internal
+ (callback _cbargs _wsdl _service operation-name &rest parameters)
+ "Over-ride for testing."
+ (setq debbugs-test--soap-operation-name operation-name)
+ (setq debbugs-test--soap-parameters parameters)
+ (let ((return
+ (cond ((string-equal operation-name "get_status")
+ debbugs-test--bug-status-soap-return)
+ ((string-equal operation-name "get_usertag")
+ '(((hi))))
+ (t '((0))))))
+ (if callback
+ (progn
+ (funcall callback return)
+ nil)
+ return)))
+
+(defun debbugs-test--override-float-time (func &rest rest)
+ "Override `float-time' for FUNC with args REST."
+ (cl-letf (((symbol-function #'float-time)
+ (lambda (&optional _specified-time) 5000)))
+ (apply func rest)))
+
+(defun debbugs-test--setup ()
+ "Mock network and time functions.
+These mock functions are needed to make the tests reproducible."
+ (setq debbugs-test--soap-operation-name nil)
+ (setq debbugs-test--soap-parameters nil)
+
+ (add-function
+ :override (symbol-function #'soap-invoke-internal)
+ #'debbugs-test--soap-invoke-internal)
+
+ (add-function
+ :around (symbol-function #'debbugs-get-cache)
+ #'debbugs-test--override-float-time)
+
+ (add-function
+ :around (symbol-function #'debbugs-put-cache)
+ #'debbugs-test--override-float-time))
+
+(defun debbugs-test--teardown ()
+ "Restore functions to as they where before."
+ (setq debbugs-test--soap-operation-name nil)
+ (setq debbugs-test--soap-parameters nil)
+
+ (remove-function
+ (symbol-function #'soap-invoke-internal)
+ #'debbugs-test--soap-invoke-internal)
+
+ (remove-function
+ (symbol-function #'debbugs-get-cache)
+ #'debbugs-test--override-float-time)
+
+ (remove-function
+ (symbol-function #'debbugs-put-cache)
+ #'debbugs-test--override-float-time))
+
+(defmacro ert-deftest--debbugs (name args docstring &rest body)
+ "The same as `ert-deftest' but runs setup and teardown functions."
+ (declare
+ (doc-string 3)
+ (indent 2))
+ `(ert-deftest ,name ,args ,docstring
+ (debbugs-test--setup)
+ ,@body
+ (debbugs-test--teardown)))
+
+
+(provide 'debbugs-test-helpers)
+
+;;; debbugs-test-helpers.el ends here
diff --git a/test/debbugs-tests.el b/test/debbugs-tests.el
index f3abea2837..eb2e8b1768 100644
--- a/test/debbugs-tests.el
+++ b/test/debbugs-tests.el
@@ -27,118 +27,7 @@
;;; Code:
(require 'debbugs)
-
-;;; Helper Data:
-
-;; Generated using this:
-;; (soap-invoke debbugs-wsdl debbugs-port "get_status" [64064])
-(defconst debbugs-test--bug-status-soap-return
- '(((item
- (key . 64064)
- (value
- (package . "emacs") (found_date) (last_modified . 1689593050)
- (affects) (date . 1686745022) (fixed_versions)
- (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>")
- (blocks) (archived . 1) (found) (unarchived) (tags . "patch")
- (severity . "normal") (location . "archive") (owner) (fixed)
- (blockedby) (pending . "done") (keywords . "patch") (id . 64064)
- (found_versions) (mergedwith) (summary) (forwarded)
- (log_modified . 1689593050)
- (done . "Michael Albinus <michael.albinus@HIDDEN>")
- (source . "unknown")
- (msgid
- . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>")
- (bug_num . 64064) (subject . "[PATCH 0/4] debbugs improvements")
- (fixed_date)))))
- "Mock result from `soap-invoke' for bug 64064.")
-
-;; Generated using this:
-;; (debbugs-get-status 64064)
-(defconst debbugs-test--bug-status
- '(((cache_time . 5000) (source . "unknown") (unarchived)
- (keywords "patch") (blocks) (pending . "done") (severity . "normal")
- (done . "Michael Albinus <michael.albinus@HIDDEN>") (location . "archive")
- (log_modified . 1689593050) (subject . "[PATCH 0/4] debbugs improvements")
- (last_modified . 1689593050) (found) (tags "patch") (package "emacs")
- (originator . "Morgan Smith <Morgan.J.Smith@HIDDEN>") (archived . t)
- (blockedby) (affects) (mergedwith) (summary) (date . 1686745022)
- (fixed_versions) (id . 64064) (fixed) (found_date) (forwarded)
- (msgid
- . "<DM5PR03MB31632E3A4FE170C62E7D4B0CC55AA@HIDDEN>")
- (owner) (found_versions) (fixed_date) (bug_num . 64064)))
- "Mock result from `debbugs-get-status' for bug 64064.")
-
-;;; Helper Functions:
-
-(defvar debbugs-test--soap-operation-name nil)
-(defvar debbugs-test--soap-parameters nil)
-(defun debbugs-test--soap-invoke-internal
- (callback _cbargs _wsdl _service operation-name &rest parameters)
- "Over-ride for testing."
- (setq debbugs-test--soap-operation-name operation-name)
- (setq debbugs-test--soap-parameters parameters)
- (let ((return
- (cond ((string-equal operation-name "get_status")
- debbugs-test--bug-status-soap-return)
- ((string-equal operation-name "get_usertag")
- '(((hi))))
- (t '((0))))))
- (if callback
- (progn
- (funcall callback return)
- nil)
- return)))
-
-(defun debbugs-test--override-float-time (func &rest rest)
- "Override `float-time' for FUNC with args REST."
- (cl-letf (((symbol-function #'float-time)
- (lambda (&optional _specified-time) 5000)))
- (apply func rest)))
-
-(defun debbugs-test--setup ()
- "Mock network and time functions.
-These mock functions are needed to make the tests reproducible."
- (setq debbugs-test--soap-operation-name nil)
- (setq debbugs-test--soap-parameters nil)
-
- (add-function
- :override (symbol-function #'soap-invoke-internal)
- #'debbugs-test--soap-invoke-internal)
-
- (add-function
- :around (symbol-function #'debbugs-get-cache)
- #'debbugs-test--override-float-time)
-
- (add-function
- :around (symbol-function #'debbugs-put-cache)
- #'debbugs-test--override-float-time))
-
-(defun debbugs-test--teardown ()
- "Restore functions to as they where before."
- (setq debbugs-test--soap-operation-name nil)
- (setq debbugs-test--soap-parameters nil)
-
- (remove-function
- (symbol-function #'soap-invoke-internal)
- #'debbugs-test--soap-invoke-internal)
-
- (remove-function
- (symbol-function #'debbugs-get-cache)
- #'debbugs-test--override-float-time)
-
- (remove-function
- (symbol-function #'debbugs-put-cache)
- #'debbugs-test--override-float-time))
-
-(defmacro ert-deftest--debbugs (name args docstring &rest body)
- "The same as `ert-deftest' but runs setup and teardown functions."
- (declare
- (doc-string 3)
- (indent 2))
- `(ert-deftest ,name ,args ,docstring
- (debbugs-test--setup)
- ,@body
- (debbugs-test--teardown)))
+(require 'debbugs-test-helpers "./test/debbugs-test-helpers")
;;; Tests:
--
2.48.1
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0002-tests-Add-tests-for-debbugs-gnu.patch
From b585fc479503e96a42d966f90fbb8d13f4e2d26e Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Fri, 14 Feb 2025 16:23:57 -0500
Subject: [PATCH 2/3] tests: Add tests for debbugs-gnu
* test/debbugs-gnu-tests.el: New file.
---
test/debbugs-gnu-tests.el | 60 +++++++++++++++++++++++++++++++++++++++
1 file changed, 60 insertions(+)
create mode 100644 test/debbugs-gnu-tests.el
diff --git a/test/debbugs-gnu-tests.el b/test/debbugs-gnu-tests.el
new file mode 100644
index 0000000000..7b038b7411
--- /dev/null
+++ b/test/debbugs-gnu-tests.el
@@ -0,0 +1,60 @@
+;;; debbugs-gnu-tests.el --- tests for debbugs-gnu.el -*- lexical-binding: t; -*-
+
+;; Copyright (C) 2025 Free Software Foundation, Inc.
+
+;; Author: Morgan Smith <Morgan.J.Smith@HIDDEN>
+;; Package: debbugs
+
+;; This file is not part of GNU Emacs.
+
+;; This program is free software: you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; This program is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;; Please ensure tests don't actually make network calls.
+
+;;; Code:
+
+(require 'debbugs)
+(require 'debbugs-gnu)
+(require 'debbugs-test-helpers "./test/debbugs-test-helpers")
+
+;;; Tests:
+
+(ert-deftest--debbugs debbugs-test-debbugs-gnu-search ()
+ "Test `debbugs-gnu-search'.
+Also test `debbugs-gnu-patches' and `debbugs-gnu-tagged' which are
+simple wrappers for `debbugs-gnu-search'."
+ (cl-letf (((symbol-function #'debbugs-gnu)
+ #'list))
+
+ (should (equal '(nil ("emacs") nil nil "patch")
+ (debbugs-gnu-patches)))
+ (should (equal debbugs-gnu-current-query nil))
+ (should (equal debbugs-gnu-current-filter nil))
+
+ (should (equal '(("tagged"))
+ (debbugs-gnu-tagged)))
+ (should (equal debbugs-gnu-current-query nil))
+ (should (equal debbugs-gnu-current-filter nil))
+
+ (should
+ (equal '(nil ("guix" "guix-patches") nil)
+ (debbugs-gnu-search "frogs" '((pending . "pending")) nil '("guix" "guix-patches") nil)))
+ (should (equal debbugs-gnu-current-query '((phrase . "frogs"))))
+ (should (equal debbugs-gnu-current-filter '((pending . "pending"))))))
+
+(provide 'debbugs-gnu-tests)
+
+;;; debbugs-gnu-tests.el ends here
--
2.48.1
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0003-Makefile-Add-target-to-run-checkdoc-on-all-files.patch
From 9d8234d59a854b2bfcec37d5ef99c3244ef351f6 Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@HIDDEN>
Date: Thu, 20 Feb 2025 12:55:42 -0500
Subject: [PATCH 3/3] Makefile: Add target to run checkdoc on all files
* Makefile: Add target to run checkdoc on all files.
* .dir-locals.el: Run ispell with checkdoc with some words added to the
dictionary.
---
.dir-locals.el | 18 ++++++++++++++++++
Makefile | 12 +++++++++++-
2 files changed, 29 insertions(+), 1 deletion(-)
create mode 100644 .dir-locals.el
diff --git a/.dir-locals.el b/.dir-locals.el
new file mode 100644
index 0000000000..fa8707345f
--- /dev/null
+++ b/.dir-locals.el
@@ -0,0 +1,18 @@
+;;; Directory Local Variables -*- no-byte-compile: t -*-
+;;; For more information see (info "(emacs) Directory Variables")
+
+((emacs-lisp-mode . ((checkdoc-package-keywords-flag . t)
+ (checkdoc-ispell-lisp-words
+ .
+ ("ChangeLog" "ChangeLogs" "UTF" "alist" "args"
+ "armstrong" "backend" "bcc" "bugreport" "cdate" "cedet"
+ "coreutils" "cygwin" "debbugs" "debian" "el" "emacs"
+ "etags" "freemail" "fsf" "guix" "gw" "henoch" "hu"
+ "hyperestraier" "keymap" "magit" "magnus" "maint"
+ "maintainer" "maintainer's" "mbox" "mboxes" "minibuffer"
+ "moreinfo" "multibyte" "notabug" "paren" "persistency"
+ "regexp" "rescan" "rgm" "rmail" "severities" "sexp"
+ "solaris" "src" "sublist" "submitter" "submitter's"
+ "subproduct" "subqueries" "subquery" "teardown"
+ "unarchived" "unibyte" "unreproducible" "url" "util"
+ "wishlist" "wontfix" "wsdl" "www" "xsd" "zltuz")))))
diff --git a/Makefile b/Makefile
index 1ab85d2b64..3b39b4f692 100644
--- a/Makefile
+++ b/Makefile
@@ -8,7 +8,7 @@ TESTTARGET=$(patsubst %.el,%.elc,$(TESTSOURCE))
INFOMANUALS=debbugs.info debbugs-ug.info
-.PHONY: all build check clean
+.PHONY: all build check clean checkdoc
.PRECIOUS: %.elc
%.elc: %.el
@@ -23,6 +23,16 @@ doc: $(INFOMANUALS)
build: $(TARGET)
+# We need to set `enable-local-variables' to load '.dir-locals.el' while in batch mode.
+# We load '.dir-locals.el' to set the ispell wordlist for checkdoc.
+# We don't set `checkdoc-spellcheck-documentation-flag' in '.dir-locals.el'
+# so that developers don't need to have ispell set up and because flymake
+# doesn't seem to respect the word list.
+checkdoc: $(SOURCE) $(TESTSOURCE)
+ @$(EMACS) -Q --batch "--eval=(setq enable-local-variables :all \
+ checkdoc-spellcheck-documentation-flag t)" \
+ -L . $(foreach file,$^,"--eval=(checkdoc-file \"$(file)\")")
+
check: build $(TESTTARGET)
@$(EMACS) -Q --batch -L . $(foreach file,$(TESTSOURCE), -l $(file)) -f ert-run-tests-batch-and-exit
--
2.48.1
--=-=-=--
Morgan Smith <Morgan.J.Smith@HIDDEN>:michael.albinus@HIDDEN, bug-gnu-emacs@HIDDEN.
Full text available.michael.albinus@HIDDEN, bug-gnu-emacs@HIDDEN:bug#76446; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.