GNU logs - #76568, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#76568: 'package-install' should not install duplicate packages
Resent-From: Ship Mints <shipmints@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 25 Feb 2025 20:53:01 +0000
Resent-Message-ID: <handler.76568.B.17405167465155 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 76568 <at> debbugs.gnu.org
MIME-Version: 1.0
From: Ship Mints <shipmints@HIDDEN>
Date: Tue, 25 Feb 2025 15:52:02 -0500
Message-ID: <CAN+1Hbpu9dE-JgZ9SY5cq=FV6QXLK+BcTre94V5JDGt-x_sMSA@HIDDEN>
Content-Type: multipart/alternative; boundary="000000000000a84331062efda169"
Received-SPF: pass client-ip=2607:f8b0:4864:20::936;
 envelope-from=shipmints@HIDDEN; helo=mail-ua1-x936.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

--000000000000a84331062efda169
Content-Type: text/plain; charset="UTF-8"

As part of my production upgrade to 30.1, and before I wrote a program to
install my local ELPA tree from scratch, I tried to first curate my
packages and change from MELPA to generally equivalent GNU ELPA or non-GNU
ELPA archives.  The result was that I had two of each package installed.

I think there's a bug in 'package-install' which, when invoked from
'package-install-button-action', processes the new package spec, and
incorrectly checks to see if the package is already installed.  Interactive
invocation of 'package-install' yields the package name from the prompt,
not its archive description.

If the below is correct, I can submit a patch to make 'package-install'
behave like 'package-reinstall' for the non-interactive case.

(defun package-install (pkg &optional dont-select)
...
    (if-let* ((transaction
               (if (package-desc-p pkg)
;; Problem seems to be here.  If the new pkg desc is for a
;; different archive directory name style, package-installed-p
;; fails as it checks to see if the new directory exists (which
;; does not), ignoring the old archive directory.
                   (unless (package-installed-p pkg)
                     (package-compute-transaction (list pkg)
                                                  (package-desc-reqs pkg)))

In contrast, 'package-reinstall' does the right thing by first deleting the
existing package before installing the new one.

(defun package-reinstall (pkg)
...
  (package-delete
   (if (package-desc-p pkg) pkg (cadr (assq pkg package-alist)))
   'force 'nosave)
  (package-install pkg 'dont-select))

-Stephane

--000000000000a84331062efda169
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:monospac=
e">As part of my production upgrade to 30.1, and before I wrote a program t=
o install my local ELPA tree from scratch, I tried to first curate my packa=
ges and change from MELPA to generally equivalent GNU ELPA or non-GNU ELPA =
archives.=C2=A0 The result was that I had two of each package installed.</d=
iv><div class=3D"gmail_default" style=3D"font-family:monospace"><br></div><=
div class=3D"gmail_default" style=3D"font-family:monospace">I think there&#=
39;s a bug in &#39;package-install&#39; which, when invoked from &#39;packa=
ge-install-button-action&#39;, processes the new package spec, and incorrec=
tly checks to see if the package is already installed.=C2=A0 Interactive in=
vocation=C2=A0of &#39;package-install&#39; yields the package name from the=
 prompt, not its archive description.</div><div class=3D"gmail_default" sty=
le=3D"font-family:monospace"><br></div><div class=3D"gmail_default" style=
=3D"font-family:monospace">If the below is correct, I can submit a patch to=
 make &#39;package-install&#39; behave like &#39;package-reinstall&#39; for=
 the non-interactive case.</div><div class=3D"gmail_default" style=3D"font-=
family:monospace"><br></div><div class=3D"gmail_default" style=3D"font-fami=
ly:monospace">(defun package-install (pkg &amp;optional dont-select)<br></d=
iv><div class=3D"gmail_default" style=3D"font-family:monospace">...</div><d=
iv class=3D"gmail_default" style=3D"font-family:monospace">=C2=A0 =C2=A0 (i=
f-let* ((transaction<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0(if (package-desc-p pkg)</div><div class=3D"gmail_default" style=3D"f=
ont-family:monospace">;;=C2=A0Problem seems to be here.=C2=A0 If the new pk=
g desc is for a=C2=A0</div><div class=3D"gmail_default" style=3D"font-famil=
y:monospace">;; different archive directory name style, package-installed-p=
</div><div class=3D"gmail_default" style=3D"font-family:monospace">;; fails=
 as it checks to see if the new directory exists (which</div><div class=3D"=
gmail_default" style=3D"font-family:monospace">;; does not), ignoring the o=
ld archive directory.<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0(unless (package-installed-p pkg)<br>=C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(package-compute=
-transaction (list pkg)<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (package-desc-reqs pkg=
)))<br></div><div class=3D"gmail_default" style=3D"font-family:monospace"><=
br></div><div class=3D"gmail_default" style=3D""><span style=3D"font-family=
:monospace">In contrast, &#39;package-reinstall&#39; does the right thing b=
y first deleting the exi</span><font face=3D"monospace">sting package befor=
e installing the new one.</font></div><div class=3D"gmail_default" style=3D=
""><font face=3D"monospace"><br></font></div><font face=3D"monospace">(defu=
n package-reinstall (pkg)</font><div><div class=3D"gmail_default" style=3D"=
"><font face=3D"monospace">...</font></div><div class=3D"gmail_default" sty=
le=3D""><font face=3D"monospace">=C2=A0 (package-delete<br>=C2=A0 =C2=A0(if=
 (package-desc-p pkg) pkg (cadr (assq pkg package-alist)))<br>=C2=A0 =C2=A0=
&#39;force &#39;nosave)<br></font></div><div class=3D"gmail_default" style=
=3D""><font face=3D"monospace">=C2=A0 (package-install pkg &#39;dont-select=
))</font></div><div class=3D"gmail_default" style=3D"font-family:monospace"=
><br>-Stephane</div></div></div>

--000000000000a84331062efda169--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Ship Mints <shipmints@HIDDEN>
Subject: bug#76568: Acknowledgement ('package-install' should not install
 duplicate packages)
Message-ID: <handler.76568.B.17405167465155.ack <at> debbugs.gnu.org>
References: <CAN+1Hbpu9dE-JgZ9SY5cq=FV6QXLK+BcTre94V5JDGt-x_sMSA@HIDDEN>
X-Gnu-PR-Message: ack 76568
X-Gnu-PR-Package: emacs
Reply-To: 76568 <at> debbugs.gnu.org
Date: Tue, 25 Feb 2025 20:53:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 76568 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
76568: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D76568
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#76568: 'package-install' should not install duplicate packages
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 26 Feb 2025 13:33:02 +0000
Resent-Message-ID: <handler.76568.B76568.17405767264871 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Ship Mints <shipmints@HIDDEN>, Philip Kaludercic <philipk@HIDDEN>
Cc: 76568 <at> debbugs.gnu.org
Date: Wed, 26 Feb 2025 15:31:52 +0200
Message-Id: <861pvkx25z.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <CAN+1Hbpu9dE-JgZ9SY5cq=FV6QXLK+BcTre94V5JDGt-x_sMSA@HIDDEN>
 (message from Ship Mints on Tue, 25 Feb 2025 15:52:02 -0500)
References: <CAN+1Hbpu9dE-JgZ9SY5cq=FV6QXLK+BcTre94V5JDGt-x_sMSA@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> From: Ship Mints <shipmints@HIDDEN>
> Date: Tue, 25 Feb 2025 15:52:02 -0500
> 
> As part of my production upgrade to 30.1, and before I wrote a program to install my local ELPA tree from
> scratch, I tried to first curate my packages and change from MELPA to generally equivalent GNU ELPA or
> non-GNU ELPA archives.  The result was that I had two of each package installed.
> 
> I think there's a bug in 'package-install' which, when invoked from 'package-install-button-action', processes
> the new package spec, and incorrectly checks to see if the package is already installed.  Interactive
> invocation of 'package-install' yields the package name from the prompt, not its archive description.
> 
> If the below is correct, I can submit a patch to make 'package-install' behave like 'package-reinstall' for the
> non-interactive case.
> 
> (defun package-install (pkg &optional dont-select)
> ...
>     (if-let* ((transaction
>                (if (package-desc-p pkg)
> ;; Problem seems to be here.  If the new pkg desc is for a 
> ;; different archive directory name style, package-installed-p
> ;; fails as it checks to see if the new directory exists (which
> ;; does not), ignoring the old archive directory.
>                    (unless (package-installed-p pkg)
>                      (package-compute-transaction (list pkg)
>                                                   (package-desc-reqs pkg)))
> 
> In contrast, 'package-reinstall' does the right thing by first deleting the existing package before installing the
> new one.
> 
> (defun package-reinstall (pkg)
> ...
>   (package-delete
>    (if (package-desc-p pkg) pkg (cadr (assq pkg package-alist)))
>    'force 'nosave)
>   (package-install pkg 'dont-select))

Philip, any comments or suggestions?

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#76568: 'package-install' should not install duplicate packages
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 04 Mar 2025 02:36:02 +0000
Resent-Message-ID: <handler.76568.B76568.174105570419222 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Ship Mints <shipmints@HIDDEN>
Cc: 76568 <at> debbugs.gnu.org
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <CAN+1Hbpu9dE-JgZ9SY5cq=FV6QXLK+BcTre94V5JDGt-x_sMSA@HIDDEN>
References: <CAN+1Hbpu9dE-JgZ9SY5cq=FV6QXLK+BcTre94V5JDGt-x_sMSA@HIDDEN>
MIME-Version: 1.0
Date: Tue, 4 Mar 2025 02:34:54 +0000
Message-ID: <CADwFkmkgdjt=Z=593ZnhOvNuYZ1WhCSpH3h3eC1O3eXzC74aUw@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Ship Mints <shipmints@HIDDEN> writes:

> As part of my production upgrade to 30.1, and before I wrote a program to install my local
> ELPA tree from scratch, I tried to first curate my packages and change from MELPA to
> generally equivalent GNU ELPA or non-GNU ELPA archives.  The result was that I had two of
> each package installed.
>
> I think there's a bug in 'package-install' which, when invoked from
> 'package-install-button-action', processes the new package spec, and incorrectly checks to
> see if the package is already installed.  Interactive invocation of 'package-install' yields the
> package name from the prompt, not its archive description.
>
> If the below is correct, I can submit a patch to make 'package-install' behave like
> 'package-reinstall' for the non-interactive case.

Please submit a patch, but could we also have tests for this please?

Thanks in advance.

>
> (defun package-install (pkg &optional dont-select)
> ...
>     (if-let* ((transaction
>                (if (package-desc-p pkg)
> ;; Problem seems to be here.  If the new pkg desc is for a
> ;; different archive directory name style, package-installed-p
> ;; fails as it checks to see if the new directory exists (which
> ;; does not), ignoring the old archive directory.
>                    (unless (package-installed-p pkg)
>                      (package-compute-transaction (list pkg)
>                                                   (package-desc-reqs pkg)))
>
> In contrast, 'package-reinstall' does the right thing by first deleting the existing package before
> installing the new one.
>
> (defun package-reinstall (pkg)
> ...
>   (package-delete
>    (if (package-desc-p pkg) pkg (cadr (assq pkg package-alist)))
>    'force 'nosave)
>   (package-install pkg 'dont-select))
>
> -Stephane

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#76568: 'package-install' should not install duplicate packages
Resent-From: Ship Mints <shipmints@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 05 Mar 2025 17:02:02 +0000
Resent-Message-ID: <handler.76568.B76568.17411940748304 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 76568
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Kangas <stefankangas@HIDDEN>
Cc: 76568 <at> debbugs.gnu.org
Received: via spool by 76568-submit <at> debbugs.gnu.org id=B76568.17411940748304
          (code B ref 76568); Wed, 05 Mar 2025 17:02:02 +0000
Received: (at 76568) by debbugs.gnu.org; 5 Mar 2025 17:01:14 +0000
Received: from localhost ([127.0.0.1]:39380 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tps7O-00029r-CS
	for submit <at> debbugs.gnu.org; Wed, 05 Mar 2025 12:01:14 -0500
Received: from mail-vk1-xa32.google.com ([2607:f8b0:4864:20::a32]:50196)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <shipmints@HIDDEN>)
 id 1tps7M-00029Y-Aj
 for 76568 <at> debbugs.gnu.org; Wed, 05 Mar 2025 12:01:13 -0500
Received: by mail-vk1-xa32.google.com with SMTP id
 71dfb90a1353d-523909ec175so1577202e0c.0
 for <76568 <at> debbugs.gnu.org>; Wed, 05 Mar 2025 09:01:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1741194066; x=1741798866; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=eMxEzi16Q/aM/9YAGJiK5ZOveex8cbrboPYbsVE1fsk=;
 b=JzUL2+6J/evUpHGVELH0RHC5eoTPOGjx2a+N4Uoijo2jDoUDlKWq6M6NV8uIFX/2BS
 lT39V9Vv5nuyKzb++aMH2SH4qfm8tJuLWSLK4PclPnrEUW1i1vkYHOEf1Po0SAEHMDXD
 PhD0jpd8ZuSqXqhRs1cvGr1QO/sBuuDaPTEMuxf3Q09tBR/bFDzu1VvAIbRZi/D3eDp9
 +7abxIK4QTg6cFbjwrl+d9jg516Ee05GNPH3TlCdCqlmfT2Jx7TAbl9fL/NmuCtBE4Dk
 k96Lx1BJm3tEnrTbTMANQX8OlpjS3gWFda71WRfxZXrtot/3NLWkcpkHkK7lRM+Kvcv9
 Qdsg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1741194066; x=1741798866;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=eMxEzi16Q/aM/9YAGJiK5ZOveex8cbrboPYbsVE1fsk=;
 b=IOyinJmbSoxphM77p1SVThNwCfUpGyyvkokPyzJACnmPFd5J4Wk1E5xO5Jos4QdhxW
 lMBkw+WbTVK7eVj7MI5haSpeaWSrmA3xUL1JdiV9PtG4OkmB0efUs7DWmEbT+ib29Z60
 R5MeBFR6ND9ErGDUQ1C6LVo88fEGLRLvrxYFiq0qwH0GGH0t1Q0MhI+y56plj2mUURxe
 oGVAZDuiWz4FjWXVl12kGe63Cs8rKYC53u9ekmlRQQ1fPkles1e5oNi30jn0L984M8tI
 +eU/TPnBkNFnV+EQLHKIopJ10W6s8SUI0rU9LZDBTvY/8NgowcnOiH7VCPEM9+bedCU/
 Gscw==
X-Gm-Message-State: AOJu0YwgX16G5Ell7grml5SwUOB4pzWzjjyjMz6zT9LuBIl+lhVv1Trb
 FF72a5cxU10LBDVsT0dHgoRZJxlhTl1hbz3H2cnhmLXzC2GnFiUuUkb45YmlhpJNcepPCbWu868
 Ero4heyTwa4kdkI4xwOpkVai5U84=
X-Gm-Gg: ASbGncudatioY8HaflFva4k+Iz0E2CEqGbvUC2mv4Pljx2bW281OmHI1gzTRw5mulQo
 vDGoOcT3STdRHjAcVBZzlU8DRuAkxEEAYee0gbtVtH3bNv+GXVLxsaFYmj5oJhD0aCH++nfT04n
 ag7GFXmDpX9AimFCZtbzTuFDPgyw==
X-Google-Smtp-Source: AGHT+IFjqI762RT4YHDzAZ3mhr05Jk3AIn/ZkVEyuS35v9wFk/Xi8GOgtFd4YCoXrHLCciwu7XviD38080PQ//+o4eU=
X-Received: by 2002:a05:6122:d21:b0:51f:3ffb:79ab with SMTP id
 71dfb90a1353d-523c62889d4mr2236708e0c.8.1741194066703; Wed, 05 Mar 2025
 09:01:06 -0800 (PST)
MIME-Version: 1.0
References: <CAN+1Hbpu9dE-JgZ9SY5cq=FV6QXLK+BcTre94V5JDGt-x_sMSA@HIDDEN>
 <CADwFkmkgdjt=Z=593ZnhOvNuYZ1WhCSpH3h3eC1O3eXzC74aUw@HIDDEN>
In-Reply-To: <CADwFkmkgdjt=Z=593ZnhOvNuYZ1WhCSpH3h3eC1O3eXzC74aUw@HIDDEN>
From: Ship Mints <shipmints@HIDDEN>
Date: Wed, 5 Mar 2025 12:00:55 -0500
X-Gm-Features: AQ5f1JpZxBIC91z3mdKdTkvpmoeo1Vq4bPFQ2_WtZYc0W27WUW5wxIHWlL0uQZ0
Message-ID: <CAN+1HbqFzN9_KoDr2J71WHoe75E6HcZfdB-=SUAa1aaJ6Oc=_A@HIDDEN>
Content-Type: multipart/mixed; boundary="000000000000d4d271062f9b556b"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--000000000000d4d271062f9b556b
Content-Type: multipart/alternative; boundary="000000000000d4d26f062f9b5569"

--000000000000d4d26f062f9b5569
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 3, 2025 at 9:34=E2=80=AFPM Stefan Kangas <stefankangas@HIDDEN=
m> wrote:

> Ship Mints <shipmints@HIDDEN> writes:
>
> > As part of my production upgrade to 30.1, and before I wrote a program
> to install my local
> > ELPA tree from scratch, I tried to first curate my packages and change
> from MELPA to
> > generally equivalent GNU ELPA or non-GNU ELPA archives.  The result was
> that I had two of
> > each package installed.
> >
> > I think there's a bug in 'package-install' which, when invoked from
> > 'package-install-button-action', processes the new package spec, and
> incorrectly checks to
> > see if the package is already installed.  Interactive invocation of
> 'package-install' yields the
> > package name from the prompt, not its archive description.
> >
> > If the below is correct, I can submit a patch to make 'package-install'
> behave like
> > 'package-reinstall' for the non-interactive case.
>
> Please submit a patch, but could we also have tests for this please?
>
> Thanks in advance.
>

Patch attached.  It prevents the menu-driven case from erasing the already
installed message.  It could suggest to the user to remove and then install
or we could offer to use package upgrade to the chosen package-desc.  At
the very least, the patch prevents duplicates.

-Stephane

--000000000000d4d26f062f9b5569
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon=
t-family:monospace"><span style=3D"font-family:Arial,Helvetica,sans-serif">=
On Mon, Mar 3, 2025 at 9:34=E2=80=AFPM Stefan Kangas &lt;<a href=3D"mailto:=
stefankangas@HIDDEN">stefankangas@HIDDEN</a>&gt; wrote:</span></div><=
/div><div class=3D"gmail_quote gmail_quote_container"><blockquote class=3D"=
gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(20=
4,204,204);padding-left:1ex">Ship Mints &lt;<a href=3D"mailto:shipmints@gma=
il.com" target=3D"_blank">shipmints@HIDDEN</a>&gt; writes:<br>
<br>
&gt; As part of my production upgrade to 30.1, and before I wrote a program=
 to install my local<br>
&gt; ELPA tree from scratch, I tried to first curate my packages and change=
 from MELPA to<br>
&gt; generally equivalent GNU ELPA or non-GNU ELPA archives.=C2=A0 The resu=
lt was that I had two of<br>
&gt; each package installed.<br>
&gt;<br>
&gt; I think there&#39;s a bug in &#39;package-install&#39; which, when inv=
oked from<br>
&gt; &#39;package-install-button-action&#39;, processes the new package spe=
c, and incorrectly checks to<br>
&gt; see if the package is already installed.=C2=A0 Interactive invocation =
of &#39;package-install&#39; yields the<br>
&gt; package name from the prompt, not its archive description.<br>
&gt;<br>
&gt; If the below is correct, I can submit a patch to make &#39;package-ins=
tall&#39; behave like<br>
&gt; &#39;package-reinstall&#39; for the non-interactive case.<br>
<br>
Please submit a patch, but could we also have tests for this please?<br>
<br>
Thanks in advance.<br></blockquote><div><br></div><div class=3D"gmail_defau=
lt" style=3D"font-family:monospace">Patch attached.=C2=A0 It prevents the m=
enu-driven case from erasing the already installed message.=C2=A0 It could =
suggest to the user to remove and then install or we could offer to use pac=
kage upgrade to the chosen package-desc.=C2=A0 At the very least, the patch=
 prevents duplicates.</div><div class=3D"gmail_default" style=3D"font-famil=
y:monospace"><br></div><div class=3D"gmail_default" style=3D"font-family:mo=
nospace">-Stephane</div></div></div>

--000000000000d4d26f062f9b5569--

--000000000000d4d271062f9b556b
Content-Type: application/octet-stream; 
	name="0001-Correct-package-install-to-detect-installed-packages.patch"
Content-Disposition: attachment; 
	filename="0001-Correct-package-install-to-detect-installed-packages.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_m7w5xifu0>
X-Attachment-Id: f_m7w5xifu0

RnJvbSA3YWY5YmNhNDExN2Y1NjNiMzRkYWNiYmNiNjE4MzM0OTdhZWQ2ZjE2IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBzaGlwbWludHMgPHNoaXBtaW50c0BnbWFpbC5jb20+CkRhdGU6
IFdlZCwgNSBNYXIgMjAyNSAxMTozMzowNyAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIENvcnJlY3Qg
J3BhY2thZ2UtaW5zdGFsbCcgdG8gZGV0ZWN0IGluc3RhbGxlZCBwYWNrYWdlcwogKGJ1ZyM3NjU2
OCkKCiogbGlzcC9lbWFjcy1saXNwL3BhY2thZ2UuZWwKKHBhY2thZ2UtaW5zdGFsbCk6IENoZWNr
IGZvciBhbHJlYWR5IGluc3RhbGxlZCBwYWNrYWdlIHVzaW5nIGl0cyBzeW1ib2wKcmF0aGVyIHRo
YW4gcmVseSBvbiBkaWZmZXJpbmcgYXJjaGl2ZSBkaXJlY3Rvcnkgc3RydWN0dXJlcy4gIFJldHVy
biB0IGlmCmluc3RhbGxlZCwgbmlsIG90aGVyd2lzZS4KKHBhY2thZ2UtaW5zdGFsbC1idXR0b24t
YWN0aW9uKTogJ2Rlc2NyaWJlLXBhY2thZ2UnIG9ubHkgd2hlbgoncGFja2FnZS1pbnN0YWxsJyBh
Y3R1YWxseSBpbnN0YWxsZWQgdGhlIHBhY2thZ2UuCiogdGVzdC9saXNwL2VtYWNzLWxpc3AvcGFj
a2FnZS10ZXN0cy5lbCAocGFja2FnZS10ZXN0LWluc3RhbGwtc2luZ2xlKToKQWRkIGFscmVhZHkt
aW5zdGFsbGVkIHRlc3QgdXNpbmcgJ3BhY2thZ2UtaW5zdGFsbCcgd2l0aCBhCidwYWNrYWdlLWRl
c2MnLgotLS0KIGxpc3AvZW1hY3MtbGlzcC9wYWNrYWdlLmVsICAgICAgICAgICAgfCAxNCArKysr
KysrKystLS0tLQogdGVzdC9saXNwL2VtYWNzLWxpc3AvcGFja2FnZS10ZXN0cy5lbCB8ICA0ICsr
KysKIDIgZmlsZXMgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRp
ZmYgLS1naXQgYS9saXNwL2VtYWNzLWxpc3AvcGFja2FnZS5lbCBiL2xpc3AvZW1hY3MtbGlzcC9w
YWNrYWdlLmVsCmluZGV4IDhkNDk4YzIxNmRjLi5hNWVhNTNkMTllYSAxMDA2NDQKLS0tIGEvbGlz
cC9lbWFjcy1saXNwL3BhY2thZ2UuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNwL3BhY2thZ2UuZWwK
QEAgLTIyNDMsMTYgKzIyNDMsMjAgQEAgcGFja2FnZS1pbnN0YWxsCiAgICAgICAgICAgICAgICAo
cGFja2FnZS0tYWN0aXZlLWJ1aWx0LWluLXAgcGtnKSkKICAgICAgIChzZXRxIHBrZyAob3IgKGNh
ZHIgKGFzc3EgbmFtZSBwYWNrYWdlLWFyY2hpdmUtY29udGVudHMpKSBwa2cpKSkKICAgICAoaWYt
bGV0KiAoKHRyYW5zYWN0aW9uCisgICAgICAgICAgICAgICA7OyBUZXN0IGZvciBhbHJlYWR5IGlu
c3RhbGxlZCB1c2luZyB0aGUgcGtnIHN5bWJvbCwgbm90CisgICAgICAgICAgICAgICA7OyB0aGUg
YXJjaGl2ZS1zcGVjaWZpYyBkaXJlY3Rvcnkgc3RydWN0dXJlLgogICAgICAgICAgICAgICAgKGlm
IChwYWNrYWdlLWRlc2MtcCBwa2cpCi0gICAgICAgICAgICAgICAgICAgKHVubGVzcyAocGFja2Fn
ZS1pbnN0YWxsZWQtcCBwa2cpCisgICAgICAgICAgICAgICAgICAgKHVubGVzcyAocGFja2FnZS1p
bnN0YWxsZWQtcCAocGFja2FnZS1kZXNjLW5hbWUgcGtnKSkKICAgICAgICAgICAgICAgICAgICAg
IChwYWNrYWdlLWNvbXB1dGUtdHJhbnNhY3Rpb24gKGxpc3QgcGtnKQogICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAocGFja2FnZS1kZXNjLXJlcXMgcGtn
KSkpCi0gICAgICAgICAgICAgICAgIChwYWNrYWdlLWNvbXB1dGUtdHJhbnNhY3Rpb24gKCkgKGxp
c3QgKGxpc3QgcGtnKSkpKSkpCisgICAgICAgICAgICAgICAgICh1bmxlc3MgKHBhY2thZ2UtaW5z
dGFsbGVkLXAgcGtnKQorICAgICAgICAgICAgICAgICAgIChwYWNrYWdlLWNvbXB1dGUtdHJhbnNh
Y3Rpb24gKCkgKGxpc3QgKGxpc3QgcGtnKSkpKSkpKQogICAgICAgICAocHJvZ24KICAgICAgICAg
ICAocGFja2FnZS1kb3dubG9hZC10cmFuc2FjdGlvbiB0cmFuc2FjdGlvbikKICAgICAgICAgICAo
cGFja2FnZS0tcXVpY2tzdGFydC1tYXliZS1yZWZyZXNoKQogICAgICAgICAgIChtZXNzYWdlICAi
UGFja2FnZSBgJXMnIGluc3RhbGxlZC4iIG5hbWUpKQotICAgICAgKG1lc3NhZ2UgImAlcycgaXMg
YWxyZWFkeSBpbnN0YWxsZWQiIG5hbWUpKSkpCisgICAgICAobWVzc2FnZSAiYCVzJyBpcyBhbHJl
YWR5IGluc3RhbGxlZCIgbmFtZSkKKyAgICAgIG5pbCkpKQogCiAoZGVjbGFyZS1mdW5jdGlvbiBw
YWNrYWdlLXZjLXVwZ3JhZGUgInBhY2thZ2UtdmMiIChwa2cpKQogCkBAIC0zMDUzLDggKzMwNTcs
OCBAQCBwYWNrYWdlLWluc3RhbGwtYnV0dG9uLWFjdGlvbgogICAobGV0ICgocGtnLWRlc2MgKGJ1
dHRvbi1nZXQgYnV0dG9uICdwYWNrYWdlLWRlc2MpKSkKICAgICAod2hlbiAoeS1vci1uLXAgKGZv
cm1hdC1tZXNzYWdlICJJbnN0YWxsIHBhY2thZ2UgYCVzJz8gIgogICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgKHBhY2thZ2UtZGVzYy1mdWxsLW5hbWUgcGtnLWRlc2MpKSkKLSAg
ICAgIChwYWNrYWdlLWluc3RhbGwgcGtnLWRlc2MgbmlsKQotICAgICAgKGRlc2NyaWJlLXBhY2th
Z2UgKHBhY2thZ2UtZGVzYy1uYW1lIHBrZy1kZXNjKSkpKSkKKyAgICAgICh3aGVuIChwYWNrYWdl
LWluc3RhbGwgcGtnLWRlc2MgbmlsKQorICAgICAgICAoZGVzY3JpYmUtcGFja2FnZSAocGFja2Fn
ZS1kZXNjLW5hbWUgcGtnLWRlc2MpKSkpKSkKIAogKGRlZnVuIHBhY2thZ2UtZGVsZXRlLWJ1dHRv
bi1hY3Rpb24gKGJ1dHRvbikKICAgIlJ1biBgcGFja2FnZS1kZWxldGUnIG9uIHRoZSBwYWNrYWdl
IEJVVFRPTiBwb2ludHMgdG8uCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvZW1hY3MtbGlzcC9wYWNr
YWdlLXRlc3RzLmVsIGIvdGVzdC9saXNwL2VtYWNzLWxpc3AvcGFja2FnZS10ZXN0cy5lbAppbmRl
eCBkOGUyNjAzMTliZC4uMzY2MTdlZDZmNmUgMTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9lbWFjcy1s
aXNwL3BhY2thZ2UtdGVzdHMuZWwKKysrIGIvdGVzdC9saXNwL2VtYWNzLWxpc3AvcGFja2FnZS10
ZXN0cy5lbApAQCAtMjQ4LDYgKzI0OCwxMCBAQCBwYWNrYWdlLXRlc3QtaW5zdGFsbC1zaW5nbGUK
ICAgICAgIChzaG91bGQgKHN0cmluZy1tYXRjaCAiXltg4oCYJ11zaW1wbGUtc2luZ2xlW+KAmSdd
IGlzIGFscmVhZHkgaW5zdGFsbGVkXG4/XFwnIgogICAgICAgICAgICAgICAgICAgICAgICAgICAg
IChidWZmZXItc3RyaW5nKSkpKQogICAgIChzaG91bGQgKHBhY2thZ2UtaW5zdGFsbGVkLXAgJ3Np
bXBsZS1zaW5nbGUpKQorICAgIDs7IFRlc3QgZm9yIGBwYWNrYWdlLWluc3RhbGwnIGFscmVhZHkg
aW5zdGFsbGVkIHVzaW5nIGEKKyAgICA7OyBwYWNrYWdlLWRlc2MuICBgcGFja2FnZS1pbnN0YWxs
JyByZXR1cm5zIG5pbCBpZiBhbHJlYWR5CisgICAgOzsgaW5zdGFsbGVkLgorICAgIChzaG91bGQt
bm90IChwYWNrYWdlLWluc3RhbGwgc2ltcGxlLXNpbmdsZS1kZXNjKSkKICAgICAobGV0KiAoKHNp
bXBsZS1wa2ctZGlyIChmaWxlLW5hbWUtYXMtZGlyZWN0b3J5CiAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgKGV4cGFuZC1maWxlLW5hbWUKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
InNpbXBsZS1zaW5nbGUtMS4zIgotLSAKMi40Ny4xCgo=
--000000000000d4d271062f9b556b--

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 5 Mar 2025 17:54:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Mar 05 12:54:22 2025
Received: from localhost ([127.0.0.1]:39647 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tpswo-0007ll-Lh
	for submit <at> debbugs.gnu.org; Wed, 05 Mar 2025 12:54:22 -0500
Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]:50185)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1tpswm-0007lW-6S
 for control <at> debbugs.gnu.org; Wed, 05 Mar 2025 12:54:20 -0500
Received: by mail-ed1-x531.google.com with SMTP id
 4fb4d7f45d1cf-5e04064af07so13331457a12.0
 for <control <at> debbugs.gnu.org>; Wed, 05 Mar 2025 09:54:20 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1741197254; x=1741802054; darn=debbugs.gnu.org;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=mfU07YGwtT4wSPNb1leY8VvLcE77FJBrUaiP/dsLyNc=;
 b=HR2AIDv4xsd5ddaSlec5lwFmDmRnvKj+SA4QMoUtNUmGAOPpouU5DmICpugtL41Pyf
 rj9vC2WcIhUC4MjYRx/0KiAi5turZJjxEpCHID2ZcSjWSpZonJ1xDw1KF35aQZpv4oCt
 7cqDNsgXfFNclmTj/YzqfJFFJ1Qx6DfiM1Sc0IOMRm5oV29aIHwNokOdcGGoHEPr63ap
 UGX27Ue2jcbfUNyb2BQ3FvUXL0a3HiqZGW80P2JL7yO6g7K1UPYS3h0EmabXZ8Kirelw
 dba51DPQeGy7oZKU9l2wHQ93jU05ojhKtThZFo6wzIVKci8GRJIPSQMRrwYAi6E+EOfd
 zpWw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1741197254; x=1741802054;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=mfU07YGwtT4wSPNb1leY8VvLcE77FJBrUaiP/dsLyNc=;
 b=dzV27nvs6QRTotiK9HGqj4Te7WDeRPCDaqoWKNJeiPB2OB6gbeWLdcgdukCyItIFdh
 prCjEEh7r3bp+1wF+Ux722ZRpNS1CbBlirEJh4+3Nce3hTR+MyckhNVlhkEmqms4tmGm
 6bulV8RKBgFsV5NkODCfurfFd7Z2g6spOp8x6ctstd60FA5nXlObGwDLU0TAs+xXS5xB
 ej914jysXayi+CSFOJ1X1vtiZrjB9CForYwp7IYaZL1qtktsm3RuGcq5NBNusfxkDISU
 7exDV2qEUc/mJwwA4ijE9eePKadydjZ7IYNuSOfQSY2qFHX0RuVMpp5gz6AkQI4Rlxn1
 eHZg==
X-Gm-Message-State: AOJu0YyztEsiftRFvaTT4bxVoKiLNyf/Ikul386JEXkWK1Mz9/dk+9ss
 jJNpzWiUTIlu0N6TEreAHQl/rwWY6TSyqzIiLORFuIgFij7uYf57YiH2BHHnLTAgO1yIDF95K6/
 wiugQEc/UVzNjqi/nq8pXS/xq3cKG5svB
X-Gm-Gg: ASbGncttzQtVvE6y7ACRGG0ifI1PuxsSOY/lbt/AFZMrlV7SPpqKS/lC7qsoigbkbnW
 +vhp8BNyQd8ZV4m51Q0J3fIsHxFhOwgDhaT/Qws75GZC/Ka4Lzbpj0y9Sv62h0Hg2jMv7tM7JdF
 fof/CXFGZ4wc+LDdCN0g+2fmSpsA==
X-Google-Smtp-Source: AGHT+IE2e4wC5tAkYhNL4qF5cJiJbJtMopf6mbm9oZ2w0RwWoCQK//VuFN5gqOuuA5s7WX3sAOq+ddOEl78OWDqLVrs=
X-Received: by 2002:a17:907:c22:b0:abf:6744:5e96 with SMTP id
 a640c23a62f3a-ac20d84a962mr381827566b.8.1741197253833; Wed, 05 Mar 2025
 09:54:13 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Wed, 5 Mar 2025 09:54:13 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
MIME-Version: 1.0
Date: Wed, 5 Mar 2025 09:54:13 -0800
X-Gm-Features: AQ5f1JrXa-mFBNoZ1MwYst6_TYzkbkcCJkJqWR8Ia3qwX0pDmnSQWKTaJWaDxgY
Message-ID: <CADwFkmkygr3sGgoc9ZBnvOE65Vvds4+z3tcgmhXSWaUShJBrUQ@HIDDEN>
Subject: control message for bug #76568
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 76568 + patch
quit

Last modified: Wed, 5 Mar 2025 18:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.